From nobody Fri Sep 25 04:08:51 2026 Received: from cstnet.cn (smtp25.cstnet.cn [159.226.251.25]) (using TLSv1.2 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 72E6A390CAA; Wed, 16 Sep 2026 17:53:45 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=159.226.251.25 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1789581231; cv=none; b=UZQCVVEFMpRhwovfsJW+tUjZmWosf/il4jn5JpbDQf4cUFdvK1aJsD9oomSGAI4W9aGx8nh5ReYRx5ei7iX22j0n6NLVbSPNri4xjO/8C9jLsp65tLxAOI/96mcmlc8XcZ1pkL6oQfC8kdAbcV5hjsY0FIZQm4RvbYZr7oKREpw= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1789581231; c=relaxed/simple; bh=lBlT1hhWlz0cF/tzcEKSsy4AktxWdt6gaymJ3x85Nfc=; h=From:To:Cc:Subject:Date:Message-Id:MIME-Version; b=b/dZvXBDPYQW3+AbugNd/sEBF5gWia5N4oQkw02dPKztl/KDv39XdTb6ZsIoqxKvGmeh9AhyDhVxLC9cmAmp2l2X7+n8UBcMFPsQ+mslIzu73DqgsTVRLgPVMwgLTLxEK+fLrJ8fc8setl3GylPoeX3TqI64k8s5YmnNvhyleew= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=iscas.ac.cn; spf=pass smtp.mailfrom=iscas.ac.cn; arc=none smtp.client-ip=159.226.251.25 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=iscas.ac.cn Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=iscas.ac.cn Received: from dfae2b116770.home.arpa (unknown [36.110.52.2]) by APP-05 (Coremail) with SMTP id zQCowAAHcz2b16pq6vhuCA--.23507S2; Thu, 17 Sep 2026 01:53:31 +0800 (CST) From: Wentao Liang To: abhinav.kumar@linux.dev Cc: airlied@gmail.com, akhilpo@oss.qualcomm.com, dri-devel@lists.freedesktop.org, freedreno@lists.freedesktop.org, jesszhan0024@gmail.com, konradybcio@kernel.org, linux-arm-msm@vger.kernel.org, linux-kernel@vger.kernel.org, lumag@kernel.org, marijn.suijten@somainline.org, mcanal@igalia.com, robin.clark@oss.qualcomm.com, sean@poorly.run, simona@ffwll.ch, Wentao Liang , stable@vger.kernel.org Subject: [PATCH] drm/msm: Fix task struct leak in recover_worker() Date: Wed, 16 Sep 2026 17:53:04 +0000 Message-Id: <20260916175304.2089651-1-vulab@iscas.ac.cn> X-Mailer: git-send-email 2.34.1 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-CM-TRANSID: zQCowAAHcz2b16pq6vhuCA--.23507S2 X-Coremail-Antispam: 1UD129KBjvdXoWruryrWFW5AFWxCry5Ww1Utrb_yoWDKFb_ua 4Yy3s7Way2yFnakF1jyw1fZrn2y3ZF9FW0gws0gr95CrZxtr1avry5Kr98Zr1UuFZxAF1D Aa1kXr1rZwsrKjkaLaAFLSUrUUUUjb8apTn2vfkv8UJUUUU8Yxn0WfASr-VFAUDa7-sFnT 9fnUUIcSsGvfJTRUUUb-xFF20E14v26ryj6rWUM7CY07I20VC2zVCF04k26cxKx2IYs7xG 6rWj6s0DM7CIcVAFz4kK6r1j6r18M28lY4IEw2IIxxk0rwA2F7IY1VAKz4vEj48ve4kI8w A2z4x0Y4vE2Ix0cI8IcVAFwI0_Xr0_Ar1l84ACjcxK6xIIjxv20xvEc7CjxVAFwI0_Gr1j 6F4UJwA2z4x0Y4vEx4A2jsIE14v26r4UJVWxJr1l84ACjcxK6I8E87Iv6xkF7I0E14v26F 4UJVW0owAS0I0E0xvYzxvE52x082IY62kv0487Mc02F40EFcxC0VAKzVAqx4xG6I80ewAv 7VC0I7IYx2IY67AKxVWUtVWrXwAv7VC2z280aVAFwI0_Cr0_Gr1UMcvjeVCFs4IE7xkEbV WUJVW8JwACjcxG0xvY0x0EwIxGrwACjI8F5VA0II8E6IAqYI8I648v4I1lFIxGxcIEc7Cj xVA2Y2ka0xkIwI1lc7CjxVAaw2AFwI0_GFv_Wryl42xK82IYc2Ij64vIr41l4I8I3I0E4I kC6x0Yz7v_Jr0_Gr1lx2IqxVAqx4xG67AKxVWUJVWUGwC20s026x8GjcxK67AKxVWUGVWU WwC2zVAF1VAY17CE14v26r4a6rW5MIIYrxkI7VAKI48JMIIF0xvE2Ix0cI8IcVAFwI0_JF I_Gr1lIxAIcVC0I7IYx2IY6xkF7I0E14v26r4UJVWxJr1lIxAIcVCF04k26cxKx2IYs7xG 6r1j6r1xMIIF0xvEx4A2jsIE14v26F4j6r4UJwCI42IY6I8E87Iv6xkF7I0E14v26F4UJV W0obIYCTnIWIevJa73UjIFyTuYvjTRRD7VDUUUU X-CM-SenderInfo: pyxotu46lvutnvoduhdfq/1tbiBwgMA2qqpVht5AAAs0 Content-Type: text/plain; charset="utf-8" recover_worker() grabs a reference to the offending task with get_pid_task() to bump the per-VM fault counters, but never drops the reference again, leaking a task struct every time a hang is recovered for a task that is still alive. Drop the reference with put_task_struct() once the fault counters have been updated, mirroring what get_comm_cmdline() already does. Fixes: 25654a1756a4 ("drm/msm: Update global fault counter when faulty proc= ess has already ended") Cc: stable@vger.kernel.org Signed-off-by: Wentao Liang --- drivers/gpu/drm/msm/msm_gpu.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/drivers/gpu/drm/msm/msm_gpu.c b/drivers/gpu/drm/msm/msm_gpu.c index 3f3925b11eea..9a4ebf47b8b8 100644 --- a/drivers/gpu/drm/msm/msm_gpu.c +++ b/drivers/gpu/drm/msm/msm_gpu.c @@ -505,6 +505,8 @@ static void recover_worker(struct kthread_work *work) */ if (!vm->managed) msm_gem_vm_unusable(submit->vm); + + put_task_struct(task); } =20 noreclaim_flag =3D memalloc_noreclaim_save(); --=20 2.34.1