From nobody Fri Sep 25 04:42:04 2026 Received: from cstnet.cn (smtp25.cstnet.cn [159.226.251.25]) (using TLSv1.2 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 4ECAD4BD34D; Wed, 16 Sep 2026 17:05:44 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=159.226.251.25 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1789578351; cv=none; b=qeAqFPgjY/UFBShZFM39++ZczNg6X4tmiwHVz1Olo9oJnUnUVJ3Oi4+dtGhchth+cJAEg1OIUFfIUFNhv3mHCgcdRrQqTmZSrRBSDriyCoJVcwYzSvSfergcj6YRhWHLHD6u+U+aZsD0OEZ+d6cQ2vVpkham2ljU/yK+FeiAd44= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1789578351; c=relaxed/simple; bh=VeIs9q7lSy+JIHRFYmbBq6hMwnhpmDMbNFpVq5FQCpM=; h=From:To:Cc:Subject:Date:Message-Id:MIME-Version; b=YzoZQoQGxybVr0jXaL2yKJCW7uUJ/ZNMlCvb+2aFV3gwdMcd0cwLv6KgXL+GlYT8FC+zBPxdaJxQnmQosllz2/oqV71vrDZuygcHFU67RXohd7EPQaW99lyWVw5oL9JS0aAuTAk/J2xbzomBcZb67KnsSglHGcUDD31/yTgA28A= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=iscas.ac.cn; spf=pass smtp.mailfrom=iscas.ac.cn; arc=none smtp.client-ip=159.226.251.25 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=iscas.ac.cn Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=iscas.ac.cn Received: from dfae2b116770.home.arpa (unknown [36.110.52.2]) by APP-05 (Coremail) with SMTP id zQCowABXh0FjzKpq0jpuCA--.22736S2; Thu, 17 Sep 2026 01:05:39 +0800 (CST) From: Wentao Liang To: linux-kernel@vger.kernel.org Cc: linux-watchdog@vger.kernel.org, linux@roeck-us.net, mikew@google.com, priyankag@google.com, wim@linux-watchdog.org, Wentao Liang , stable@vger.kernel.org Subject: [PATCH] watchdog: sp5100_tco: Fix pci_dev reference leak in sp5100_tco_init() Date: Wed, 16 Sep 2026 17:05:11 +0000 Message-Id: <20260916170511.2086199-1-vulab@iscas.ac.cn> X-Mailer: git-send-email 2.34.1 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-CM-TRANSID: zQCowABXh0FjzKpq0jpuCA--.22736S2 X-Coremail-Antispam: 1UD129KBjvJXoW7CF45CFWDJF13XrW8AF18Krg_yoW8AF17pr 48JFWYvFWUGws2yw47X3WDZFyUCayIva4I9w17twnYvws8u3sIyr18WayUX3WDWr4rta15 tr45tFsruFW5Zr7anT9S1TB71UUUUU7qnTZGkaVYY2UrUUUUjbIjqfuFe4nvWSU5nxnvy2 9KBjDU0xBIdaVrnRJUUUvY14x267AKxVW8JVW5JwAFc2x0x2IEx4CE42xK8VAvwI8IcIk0 rVWrJVCq3wAFIxvE14AKwVWUJVWUGwA2ocxC64kIII0Yj41l84x0c7CEw4AK67xGY2AK02 1l84ACjcxK6xIIjxv20xvE14v26r4j6ryUM28EF7xvwVC0I7IYx2IY6xkF7I0E14v26F4j 6r4UJwA2z4x0Y4vEx4A2jsIE14v26r4UJVWxJr1l84ACjcxK6I8E87Iv6xkF7I0E14v26r 4UJVWxJr1le2I262IYc4CY6c8Ij28IcVAaY2xG8wAqx4xG64xvF2IEw4CE5I8CrVC2j2Wl Yx0E2Ix0cI8IcVAFwI0_JF0_Jw1lYx0Ex4A2jsIE14v26r4j6F4UMcvjeVCFs4IE7xkEbV WUJVW8JwACjcxG0xvY0x0EwIxGrwACjI8F5VA0II8E6IAqYI8I648v4I1lc7CjxVAaw2AF wI0_JF0_Jw1l42xK82IYc2Ij64vIr41l4I8I3I0E4IkC6x0Yz7v_Jr0_Gr1lx2IqxVAqx4 xG67AKxVWUJVWUGwC20s026x8GjcxK67AKxVWUGVWUWwC2zVAF1VAY17CE14v26r1q6r43 MIIYrxkI7VAKI48JMIIF0xvE2Ix0cI8IcVAFwI0_JFI_Gr1lIxAIcVC0I7IYx2IY6xkF7I 0E14v26F4j6r4UJwCI42IY6xAIw20EY4v20xvaj40_Jr0_JF4lIxAIcVC2z280aVAFwI0_ Gr0_Cr1lIxAIcVC2z280aVCY1x0267AKxVW8Jr0_Cr1UYxBIdaVFxhVjvjDU0xZFpf9x0J USLvNUUUUU= X-CM-SenderInfo: pyxotu46lvutnvoduhdfq/1tbiBgMMA2qqok9gFwAEsU Content-Type: text/plain; charset="utf-8" sp5100_tco_init() stores the PCI device matched by for_each_pci_dev() in the global sp5100_tco_pci and keeps its reference for the lifetime of the driver, but neither sp5100_tco_exit() nor the error paths of sp5100_tco_init() call pci_dev_put(), leaking the reference on driver registration failure and on every module load/unload cycle. Drop the reference when the platform driver or device registration fails and when the module is unloaded. Fixes: 15e28bf13008 ("watchdog: Add support for sp5100 chipset TCO") Cc: stable@vger.kernel.org Signed-off-by: Wentao Liang --- drivers/watchdog/sp5100_tco.c | 6 +++++- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/drivers/watchdog/sp5100_tco.c b/drivers/watchdog/sp5100_tco.c index 2bd3dc25cb03..3562d5ec63c1 100644 --- a/drivers/watchdog/sp5100_tco.c +++ b/drivers/watchdog/sp5100_tco.c @@ -604,8 +604,10 @@ static int __init sp5100_tco_init(void) pr_info("SP5100/SB800 TCO WatchDog Timer Driver\n"); =20 err =3D platform_driver_register(&sp5100_tco_driver); - if (err) + if (err) { + pci_dev_put(sp5100_tco_pci); return err; + } =20 sp5100_tco_platform_device =3D platform_device_register_simple(TCO_DRIVER_NAME, -1, NULL, 0); @@ -618,6 +620,7 @@ static int __init sp5100_tco_init(void) =20 unreg_platform_driver: platform_driver_unregister(&sp5100_tco_driver); + pci_dev_put(sp5100_tco_pci); return err; } =20 @@ -625,6 +628,7 @@ static void __exit sp5100_tco_exit(void) { platform_device_unregister(sp5100_tco_platform_device); platform_driver_unregister(&sp5100_tco_driver); + pci_dev_put(sp5100_tco_pci); } =20 module_init(sp5100_tco_init); --=20 2.34.1