From nobody Fri Sep 25 04:43:45 2026 Received: from cstnet.cn (smtp25.cstnet.cn [159.226.251.25]) (using TLSv1.2 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 4A2B14D0CFF; Wed, 16 Sep 2026 16:37:19 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=159.226.251.25 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1789576643; cv=none; b=qbT54RJ8Kg3x5jpIADn44Jn+0bpAKzjnEKbAVopeanYHghx9yhffJLRvJ5uli7QDl+4EQpY8fcRmINx8ZLahn/sD7k0HYgb/iHDn8MYyKxei8MS9A+4xQEyjPoj8lZ9BrK47gUmnZjNa4sWRx2Lg1Vp+2vmeF2KmsZScTCMTk8g= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1789576643; c=relaxed/simple; bh=H3mFFXZrPRd+526vLB3hsmqvxWcA49ddm3ls7OV3Kgk=; h=From:To:Cc:Subject:Date:Message-Id:MIME-Version; b=bNPU61LEYzy5ggfKyZXF2C9hj3TpbHJNDzoXx3l0scSZtJkGFrUJWxPyIe18PEMlDeQ9l8CW/QmKv49d3HzlDemNDfJuu99l1NnzqslaHmzcOjXqbbgruwGFhAHM2XQzfyELNNNW72Axd4+hfN5Qf1WulApK+Zafft6fP3UKGXA= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=iscas.ac.cn; spf=pass smtp.mailfrom=iscas.ac.cn; arc=none smtp.client-ip=159.226.251.25 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=iscas.ac.cn Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=iscas.ac.cn Received: from dfae2b116770.home.arpa (unknown [36.110.52.2]) by APP-05 (Coremail) with SMTP id zQCowACXATy5xapq2sZtCA--.22093S2; Thu, 17 Sep 2026 00:37:14 +0800 (CST) From: Wentao Liang To: andy@kernel.org Cc: dlechner@baylibre.com, jic23@kernel.org, linusw@kernel.org, linux-iio@vger.kernel.org, linux-kernel@vger.kernel.org, nuno.sa@analog.com, xc-racer2@live.ca, Wentao Liang , stable@vger.kernel.org Subject: [PATCH] iio: light: gp2ap002: Fix runtime PM leak in gp2ap002_read_raw() Date: Wed, 16 Sep 2026 16:36:46 +0000 Message-Id: <20260916163646.2084234-1-vulab@iscas.ac.cn> X-Mailer: git-send-email 2.34.1 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-CM-TRANSID: zQCowACXATy5xapq2sZtCA--.22093S2 X-Coremail-Antispam: 1UD129KBjvdXoWruw17Jr4rJr18Wry3ZrW5KFg_yoWDArg_Gr 1q9asrXrWUAF40qFn5t3WfZr9agF97Xr18ur4IkanxGry7Cr93AryDArZ8Aa9xZrW3uFn8 Xw1qkFn29w47ujkaLaAFLSUrUUUUjb8apTn2vfkv8UJUUUU8Yxn0WfASr-VFAUDa7-sFnT 9fnUUIcSsGvfJTRUUUbakFF20E14v26r4j6ryUM7CY07I20VC2zVCF04k26cxKx2IYs7xG 6rWj6s0DM7CIcVAFz4kK6r1j6r18M28lY4IEw2IIxxk0rwA2F7IY1VAKz4vEj48ve4kI8w A2z4x0Y4vE2Ix0cI8IcVAFwI0_Xr0_Ar1l84ACjcxK6xIIjxv20xvEc7CjxVAFwI0_Cr0_ Gr1UM28EF7xvwVC2z280aVAFwI0_Cr0_Gr1UM28EF7xvwVC2z280aVCY1x0267AKxVW8Jr 0_Cr1UM2AIxVAIcxkEcVAq07x20xvEncxIr21l5I8CrVACY4xI64kE6c02F40Ex7xfMcIj 6xIIjxv20xvE14v26r126r1DMcIj6I8E87Iv67AKxVW8JVWxJwAm72CE4IkC6x0Yz7v_Jr 0_Gr1lF7xvr2IYc2Ij64vIr41lF7I21c0EjII2zVCS5cI20VAGYxC7M4IIrI8v6xkF7I0E 8cxan2IY04v7MxkF7I0En4kS14v26r1q6r43MxAIw28IcxkI7VAKI48JMxC20s026xCaFV Cjc4AY6r1j6r4UMI8I3I0E5I8CrVAFwI0_Jr0_Jr4lx2IqxVCjr7xvwVAFwI0_JrI_JrWl x4CE17CEb7AF67AKxVWUtVW8ZwCIc40Y0x0EwIxGrwCI42IY6xIIjxv20xvE14v26r1I6r 4UMIIF0xvE2Ix0cI8IcVCY1x0267AKxVWxJVW8Jr1lIxAIcVCF04k26cxKx2IYs7xG6r1j 6r1xMIIF0xvEx4A2jsIE14v26r4j6F4UMIIF0xvEx4A2jsIEc7CjxVAFwI0_Gr1j6F4UJb IYCTnIWIevJa73UjIFyTuYvjfU5dgADUUUU X-CM-SenderInfo: pyxotu46lvutnvoduhdfq/1tbiDAIMA2qqpO9NxwABsB Content-Type: text/plain; charset="utf-8" pm_runtime_get_sync() increments the usage counter even on failure, so every successful call must be paired with a put. A failure of gp2ap002_get_lux() returned early and skipped the paired pm_runtime_put_autosuspend(), permanently preventing runtime suspend. Jump to the common exit that releases the reference. Fixes: f6dbf83c17cb ("iio: light: gp2ap002: Take runtime PM reference on li= ght read") Cc: stable@vger.kernel.org Signed-off-by: Wentao Liang Reviewed-by: Linus Walleij --- drivers/iio/light/gp2ap002.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/iio/light/gp2ap002.c b/drivers/iio/light/gp2ap002.c index a0d8a58f2704..886accf5e859 100644 --- a/drivers/iio/light/gp2ap002.c +++ b/drivers/iio/light/gp2ap002.c @@ -258,7 +258,7 @@ static int gp2ap002_read_raw(struct iio_dev *indio_dev, case IIO_LIGHT: ret =3D gp2ap002_get_lux(gp2ap002); if (ret < 0) - return ret; + goto out; *val =3D ret; ret =3D IIO_VAL_INT; goto out; --=20 2.34.1