From nobody Fri Sep 25 04:43:51 2026 Received: from cstnet.cn (smtp25.cstnet.cn [159.226.251.25]) (using TLSv1.2 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id A022C370ADF; Wed, 16 Sep 2026 15:59:15 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=159.226.251.25 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1789574364; cv=none; b=ru+m8qMyiQnTT8LwgDbK8L99awqU9vPcda6Y8Y3aNgwHCc1syPibNmXFg/WGVt1RF9WNlgh8EV42lpHDJMOz+q2E95y0bEPgzN3dLH+HhyOOhMe83MgkFIUuyzsotqC3QT7vZ8xuBnH6IyIRihvosBQWl07XgPz/xsHkLfoLQUc= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1789574364; c=relaxed/simple; bh=rQznw9Pm2MppyI1WQ5TE0CYYBdHXTT7LuTpGCd9NBcM=; h=From:To:Cc:Subject:Date:Message-Id:MIME-Version; b=n1YAkksSiwn7QGkW5vvgWf/anLHebJ82QbnZ1z3LnWCA8P537iKs2f8VnZ1bxbzl8XfSGIUwEtJVi3AB274ECeo0xXmIikk3i3RaFqSjsus57a1HZ7pZGEoV2FG4E3Ue6qYafYSUjgqI6N/Uu2U7Q29u3Iq4qzTs/FO4P21WMBI= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=iscas.ac.cn; spf=pass smtp.mailfrom=iscas.ac.cn; arc=none smtp.client-ip=159.226.251.25 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=iscas.ac.cn Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=iscas.ac.cn Received: from dfae2b116770.home.arpa (unknown [36.110.52.2]) by APP-05 (Coremail) with SMTP id zQCowAAHcz3JvKpqj0RtCA--.21547S2; Wed, 16 Sep 2026 23:59:05 +0800 (CST) From: Wentao Liang To: andi.shyti@kernel.org Cc: linux-arm-kernel@lists.infradead.org, linux-i2c@vger.kernel.org, linux-kernel@vger.kernel.org, piotr.wojtaszczyk@timesys.com, stigge@antcom.de, vz@mleia.com, wsa@kernel.org, Wentao Liang , stable@vger.kernel.org Subject: [PATCH] i2c: pnx: Fix of_node reference leak in i2c_pnx_probe() Date: Wed, 16 Sep 2026 15:58:38 +0000 Message-Id: <20260916155838.2078067-1-vulab@iscas.ac.cn> X-Mailer: git-send-email 2.34.1 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-CM-TRANSID: zQCowAAHcz3JvKpqj0RtCA--.21547S2 X-Coremail-Antispam: 1UD129KBjvJXoW7Cw1rKry7Xr13Kr4DJr4DCFg_yoW8trW7pa 9rGFZIvr4UJFn7KrWkXr1UZFy5tw4ftrW8K3W3uw1kCanxKrWUJr4aqFyFvFWFkFWvq3WY qF1DJFWfuF1kuFJanT9S1TB71UUUUU7qnTZGkaVYY2UrUUUUjbIjqfuFe4nvWSU5nxnvy2 9KBjDU0xBIdaVrnRJUUU9I14x267AKxVW8JVW5JwAFc2x0x2IEx4CE42xK8VAvwI8IcIk0 rVWrJVCq3wAFIxvE14AKwVWUJVWUGwA2ocxC64kIII0Yj41l84x0c7CEw4AK67xGY2AK02 1l84ACjcxK6xIIjxv20xvE14v26r4j6ryUM28EF7xvwVC0I7IYx2IY6xkF7I0E14v26F4j 6r4UJwA2z4x0Y4vEx4A2jsIE14v26rxl6s0DM28EF7xvwVC2z280aVCY1x0267AKxVW0oV Cq3wAS0I0E0xvYzxvE52x082IY62kv0487Mc02F40EFcxC0VAKzVAqx4xG6I80ewAv7VC0 I7IYx2IY67AKxVWUAVWUtwAv7VC2z280aVAFwI0_Gr1j6F4UJwAm72CE4IkC6x0Yz7v_Jr 0_Gr1lF7xvr2IYc2Ij64vIr41lF7I21c0EjII2zVCS5cI20VAGYxC7M4IIrI8v6xkF7I0E 8cxan2IY04v7MxkF7I0En4kS14v26r1q6r43MxAIw28IcxkI7VAKI48JMxC20s026xCaFV Cjc4AY6r1j6r4UMI8I3I0E5I8CrVAFwI0_Jr0_Jr4lx2IqxVCjr7xvwVAFwI0_JrI_JrWl x4CE17CEb7AF67AKxVWUtVW8ZwCIc40Y0x0EwIxGrwCI42IY6xIIjxv20xvE14v26r1I6r 4UMIIF0xvE2Ix0cI8IcVCY1x0267AKxVWxJVW8Jr1lIxAIcVCF04k26cxKx2IYs7xG6r1j 6r1xMIIF0xvEx4A2jsIE14v26F4j6r4UJwCI42IY6I8E87Iv6xkF7I0E14v26F4UJVW0ob IYCTnIWIevJa73UjIFyTuYvjfUrrWFUUUUU X-CM-SenderInfo: pyxotu46lvutnvoduhdfq/1tbiBwUMA2qqpVg55wADst Content-Type: text/plain; charset="utf-8" The device node reference taken with of_node_get() for the adapter device is never released: the early probe error paths return without dropping it, and neither the late error paths nor i2c_pnx_remove() put it back. The i2c core does not release the adapter device's of_node either. Route the clock, I/O mapping and clock-enable error paths to a common label that drops the node reference, and drop the reference after i2c_del_adapter() in the remove path. Fixes: b41a216dafe4 ("i2c: Add device tree support to i2c-pnx.c") Cc: stable@vger.kernel.org Signed-off-by: Wentao Liang --- drivers/i2c/busses/i2c-pnx.c | 17 ++++++++++++----- 1 file changed, 12 insertions(+), 5 deletions(-) diff --git a/drivers/i2c/busses/i2c-pnx.c b/drivers/i2c/busses/i2c-pnx.c index 8daa0008bd05..b2a686b132ea 100644 --- a/drivers/i2c/busses/i2c-pnx.c +++ b/drivers/i2c/busses/i2c-pnx.c @@ -644,20 +644,24 @@ static int i2c_pnx_probe(struct platform_device *pdev) } #endif alg_data->clk =3D devm_clk_get(&pdev->dev, NULL); - if (IS_ERR(alg_data->clk)) - return PTR_ERR(alg_data->clk); + if (IS_ERR(alg_data->clk)) { + ret =3D PTR_ERR(alg_data->clk); + goto err_of_node; + } =20 snprintf(alg_data->adapter.name, sizeof(alg_data->adapter.name), "%s", pdev->name); =20 /* Register I/O resource */ alg_data->ioaddr =3D devm_platform_get_and_ioremap_resource(pdev, 0, &res= ); - if (IS_ERR(alg_data->ioaddr)) - return PTR_ERR(alg_data->ioaddr); + if (IS_ERR(alg_data->ioaddr)) { + ret =3D PTR_ERR(alg_data->ioaddr); + goto err_of_node; + } =20 ret =3D clk_prepare_enable(alg_data->clk); if (ret) - return ret; + goto err_of_node; =20 freq =3D clk_get_rate(alg_data->clk); =20 @@ -707,6 +711,8 @@ static int i2c_pnx_probe(struct platform_device *pdev) =20 out_clock: clk_disable_unprepare(alg_data->clk); +err_of_node: + of_node_put(alg_data->adapter.dev.of_node); return ret; } =20 @@ -716,6 +722,7 @@ static void i2c_pnx_remove(struct platform_device *pdev) =20 i2c_del_adapter(&alg_data->adapter); clk_disable_unprepare(alg_data->clk); + of_node_put(alg_data->adapter.dev.of_node); } =20 #ifdef CONFIG_OF --=20 2.34.1