From nobody Fri Sep 25 04:38:17 2026 Received: from mta0.migadu.com (out-227.mta0.migadu.com [91.218.175.227]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 6C2B71A2C04 for ; Wed, 16 Sep 2026 14:38:58 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=91.218.175.227 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1789569541; cv=none; b=TAN/c61qCxnrdF3mFNUi4VFOfdBikYjReDHZmfEusint77vVfY0NTMKNl3JfbiWWYYBvawZEjRcKbzS+VJ77FXxgX/Gu0rwIO2+uklftGZ7XKupC7wI9FttS6DAIJivRJbtoQGJHKFpIIotvbcUwfZT7meKb8asz60aPbhHDwCQ= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1789569541; c=relaxed/simple; bh=xgidOb6wZQb6UV880KBNFOuD0LDd0qtpFCKtTZo+PqM=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=r/1lQ+RdifEqRdGUs8fX+mA383n1+6VFZFO4G6S6K3YYQMr2kj093YAbL6LwWTR8+k1+PgB+R5V2zOBT9YBJvAW/DZ71NweloDbmDi/SjhuBnTGMzF1NQjNoNAINBnay22z+Sug7HbxaXkKq0TlnXJrQTeZx4EVb0kuwBHctKrE= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.dev; spf=pass smtp.mailfrom=linux.dev; dkim=pass (1024-bit key) header.d=linux.dev header.i=@linux.dev header.b=cZVypZDo; arc=none smtp.client-ip=91.218.175.227 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.dev Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linux.dev Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linux.dev header.i=@linux.dev header.b="cZVypZDo" X-Envelope-To: linux-kernel@vger.kernel.org DKIM-Signature: a=rsa-sha256; bh=xgidOb6wZQb6UV880KBNFOuD0LDd0qtpFCKtTZo+PqM=; c=simple/simple; d=linux.dev; h=from:to:subject:date:message-id:mime-version:content-type; s=key1; t=1789569536; v=1; x=1790174336; b=cZVypZDo1Ae4a5Q+lg1U5eLvXXGv9ThsZbQ2KXCd9CIpuz6yFq3s0vBVv5rxF2aam7PkoIWf bjYLt0xDVaM6H4rnzFg9f6kX/72y/C9ILtLp/i5YDyUlAyG1jjLtNF5jJoWuv62ZSdRTdTk0Df2 3JnyZpmJjwJj1MKlfO5iWXbM= X-Envelope-To: linux-kernel@vger.kernel.org Received: by smtp.migadu.com with ESMTPS id b843479c0028f47b; Wed, 16 Sep 2026 14:38:56 +0000 X-Mizu-Trace-ID: b843479c0028f47b X-Migadu-Flow: FLOW_OUT From: Denis Benato To: platform-driver-x86@vger.kernel.org Cc: linux-kernel@vger.kernel.org, =?UTF-8?q?Ilpo=20J=C3=A4rvinen?= , "Hans de Goede" , "Corentin Chary" , "Luke Jones" , "Hugo Baigue" , "Ponali" , =?UTF-8?q?Manuel=20A=2E=20R=2E=20de=20Or=C3=BAe=20R=C3=ADos?= , "Salvatore Bonaccorso" , "Thorsten Leemhuis" , "Denis Benato" , Denis Benato , stable@vger.kernel.org Subject: [PATCH v1 1/4] platform/x86: asus-wmi: fix unclear usage of bd->props.power Date: Wed, 16 Sep 2026 14:38:25 +0000 Message-ID: <20260916143838.170950-2-denis.benato@linux.dev> X-Mailer: git-send-email 2.47.3 In-Reply-To: <20260916143838.170950-1-denis.benato@linux.dev> References: <20260916143838.170950-1-denis.benato@linux.dev> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" The bd->props.power is checked in parts of the driver correctly comparing with BACKLIGHT_POWER_ON, while in others with a raw usage of bd->props.power and !bd->props.power, moreover in certain checks the logic has been inverted due to BACKLIGHT_POWER_ON being defined as 0: fix both the wrong usage and the inconsistencies by using proper comparisons. Fixes: 130d29c5627c ("platform/x86: asus-wmi: adjust screenpad power/bright= ness handling") Closes: https://lore.kernel.org/all/178362762638.911488.8564892548331679884= @eldamar.lan/ Closes: https://lore.kernel.org/all/ea9c63d1-4776-49d5-9dc4-6c09498f99c9@li= nux.dev/ Tested-by: Hugo Baigue Tested-by: Ponali Cc: stable@vger.kernel.org Assisted-by: zcode:glm-5.3-flash Signed-off-by: Denis Benato --- drivers/platform/x86/asus-wmi.c | 12 +++++++++--- 1 file changed, 9 insertions(+), 3 deletions(-) diff --git a/drivers/platform/x86/asus-wmi.c b/drivers/platform/x86/asus-wm= i.c index b4fd2257bc8e..7382f2b38678 100644 --- a/drivers/platform/x86/asus-wmi.c +++ b/drivers/platform/x86/asus-wmi.c @@ -4532,7 +4532,8 @@ static int update_screenpad_bl_status(struct backligh= t_device *bd) u32 ctrl_param =3D bd->props.brightness; int err =3D 0; =20 - if (bd->props.power) { + switch (bd->props.power) { + case BACKLIGHT_POWER_ON: err =3D asus_wmi_set_devstate(ASUS_WMI_DEVID_SCREENPAD_POWER, 1, NULL); if (err < 0) return err; @@ -4540,12 +4541,17 @@ static int update_screenpad_bl_status(struct backli= ght_device *bd) err =3D asus_wmi_set_devstate(ASUS_WMI_DEVID_SCREENPAD_LIGHT, ctrl_param= , NULL); if (err < 0) return err; - } + break; =20 - if (!bd->props.power) { + case BACKLIGHT_POWER_OFF: err =3D asus_wmi_set_devstate(ASUS_WMI_DEVID_SCREENPAD_POWER, 0, NULL); if (err < 0) return err; + break; + + default: + pr_warn("Invalid screenpad backlight power state: %d\n", bd->props.power= ); + return -EINVAL; } =20 return err; --=20 2.47.3 From nobody Fri Sep 25 04:38:17 2026 Received: from mta0.migadu.com (out-235.mta0.migadu.com [91.218.175.235]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 4B2531A2C04 for ; Wed, 16 Sep 2026 14:39:03 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=91.218.175.235 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1789569546; cv=none; b=l5BOIYAUCXLlXFUzAMPYX6AIInElMHMz4gA17dwJco/cpBEA8K8pFcsnEHCDZoMGDuGgGoTGASkULYN/400YlPoxir03njhzN9nOFD+INgOh3ib7YH0A6aE3IIS0FkTBYnrevrcfgnvlJ2ia4WH5Cws3TvZL1+irOvPzhpoTnWA= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1789569546; c=relaxed/simple; bh=2KQnoA/3jVWPg6XZS+56Vv+yFvdhfi8eQ1F3fC57pHs=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=P5uirUbrfbyCKZW+q7GYXT0xkFfaitzyhDJqf3lZTwDAG7zVxBw5Xech7K4KSmcAGxQ1j2CEpUnKtHdjSEVriJMsgtQOkJ23wzQLaCXe2OXO8KAc1KdXnzTdYr+ozsjMoiB+SnkIYNricrwMADna7+F0kn2QaXix8ZL8EDyQSpk= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.dev; spf=pass smtp.mailfrom=linux.dev; dkim=pass (1024-bit key) header.d=linux.dev header.i=@linux.dev header.b=MvuBeEYZ; arc=none smtp.client-ip=91.218.175.235 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.dev Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linux.dev Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linux.dev header.i=@linux.dev header.b="MvuBeEYZ" X-Envelope-To: linux-kernel@vger.kernel.org DKIM-Signature: a=rsa-sha256; bh=2KQnoA/3jVWPg6XZS+56Vv+yFvdhfi8eQ1F3fC57pHs=; c=simple/simple; d=linux.dev; h=from:to:subject:date:message-id:mime-version:content-type; s=key1; t=1789569542; v=1; x=1790174342; b=MvuBeEYZNIkpOUEWtmr6w2sTWIPrVizqoKGoiqsjbzpYpCiEA6zTCmb1hci4Bm4aGJ5RTeak NHPnFxEIPHmXuFBGOuyZQ4ROxOqyo4oRzJPgRE+de37MPidhAB6Bg4PJUcld+NaFexW9g3WvIi/ ClLewR0ncUUIArDlJC8rZkzg= X-Envelope-To: linux-kernel@vger.kernel.org Received: by smtp.migadu.com with ESMTPS id 38e479fb58c47116; Wed, 16 Sep 2026 14:39:02 +0000 X-Mizu-Trace-ID: 38e479fb58c47116 X-Migadu-Flow: FLOW_OUT From: Denis Benato To: platform-driver-x86@vger.kernel.org Cc: linux-kernel@vger.kernel.org, =?UTF-8?q?Ilpo=20J=C3=A4rvinen?= , "Hans de Goede" , "Corentin Chary" , "Luke Jones" , "Hugo Baigue" , "Ponali" , =?UTF-8?q?Manuel=20A=2E=20R=2E=20de=20Or=C3=BAe=20R=C3=ADos?= , "Salvatore Bonaccorso" , "Thorsten Leemhuis" , "Denis Benato" , Denis Benato , stable@vger.kernel.org Subject: [PATCH v1 2/4] platform/x86: asus-wmi: fix screenpad power state detection Date: Wed, 16 Sep 2026 14:38:26 +0000 Message-ID: <20260916143838.170950-3-denis.benato@linux.dev> X-Mailer: git-send-email 2.47.3 In-Reply-To: <20260916143838.170950-1-denis.benato@linux.dev> References: <20260916143838.170950-1-denis.benato@linux.dev> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" On some models, e.g. the UX5400EA, the screenpad power state cannot be read back: DSTS(ASUS_WMI_DEVID_SCREENPAD_POWER) never sets ASUS_WMI_DSTS_STATUS_BIT, so asus_wmi_get_devstate_simple() reports the panel as powered off regardless of its real state. The DSDT shows DSTS 0x00050031 (POWER) and DSTS 0x00050032 (LIGHT) both read the same two-byte EC register, each returning a different byte: byte 0 is a raw EC status byte, which is 0xa0 when the panel is powered and 0x00 when it is off, and byte 1 is the brightness. Read the power state from the low byte instead of ASUS_WMI_DSTS_STATUS_BIT: firmware reporting the power through the status bit is covered too, since ASUS_WMI_DSTS_STATUS_BIT lies inside ASUS_WMI_DSTS_BRIGHTNESS_MASK. Reuse read_screenpad_backlight_power() in asus_screenpad_init() in place of the raw devstate read. This makes the brightness read reachable on models like the UX5400EA, so mask the SCREENPAD_LIGHT value with ASUS_WMI_DSTS_BRIGHTNESS_MASK before storing it: the unmasked devstate (0x0001ffa0 when the panel is on) would otherwise be exposed to userspace as an out-of-range brightness (max_brightness is 255) which systemd-backlight then persists. While at it, pass asus_wmi_get_devstate() the u32 it expects. Fixes: 130d29c5627c ("platform/x86: asus-wmi: adjust screenpad power/bright= ness handling") Reported-by: Hugo Baigue Closes: https://lore.kernel.org/all/CAO84+x+P2_xyHP89+nGVSMV6bL+dy0P9=3DvyE= EfZGnFhv0hBNWw@mail.gmail.com/ Suggested-by: Hugo Baigue Tested-by: Hugo Baigue Cc: stable@vger.kernel.org Assisted-by: zcode:glm-5.3-flash Signed-off-by: Denis Benato --- drivers/platform/x86/asus-wmi.c | 22 +++++++++++++++------- 1 file changed, 15 insertions(+), 7 deletions(-) diff --git a/drivers/platform/x86/asus-wmi.c b/drivers/platform/x86/asus-wm= i.c index 7382f2b38678..ded1aa356cf3 100644 --- a/drivers/platform/x86/asus-wmi.c +++ b/drivers/platform/x86/asus-wmi.c @@ -4498,13 +4498,20 @@ static int is_display_toggle(int code) =20 static int read_screenpad_backlight_power(struct asus_wmi *asus) { - int ret; + int ret, retval; =20 - ret =3D asus_wmi_get_devstate_simple(asus, ASUS_WMI_DEVID_SCREENPAD_POWER= ); + ret =3D asus_wmi_get_devstate(asus, ASUS_WMI_DEVID_SCREENPAD_POWER, &retv= al); if (ret < 0) return ret; - /* 1 =3D=3D powered */ - return ret ? BACKLIGHT_POWER_ON : BACKLIGHT_POWER_OFF; + + /* + * The firmware reports the panel power in the low byte of the + * devstate as a raw EC status byte that is non-zero when the + * panel is powered; other models report it through + * ASUS_WMI_DSTS_STATUS_BIT, which lies inside the same mask. + */ + return (retval & ASUS_WMI_DSTS_BRIGHTNESS_MASK) ? + BACKLIGHT_POWER_ON : BACKLIGHT_POWER_OFF; } =20 static int read_screenpad_brightness(struct backlight_device *bd) @@ -4568,16 +4575,17 @@ static int asus_screenpad_init(struct asus_wmi *asu= s) struct backlight_device *bd; struct backlight_properties props; int err, power; - int brightness =3D 0; + u32 brightness =3D 0; =20 - power =3D asus_wmi_get_devstate_simple(asus, ASUS_WMI_DEVID_SCREENPAD_POW= ER); + power =3D read_screenpad_backlight_power(asus); if (power < 0) return power; =20 - if (power) { + if (power =3D=3D BACKLIGHT_POWER_ON) { err =3D asus_wmi_get_devstate(asus, ASUS_WMI_DEVID_SCREENPAD_LIGHT, &bri= ghtness); if (err < 0) return err; + brightness &=3D ASUS_WMI_DSTS_BRIGHTNESS_MASK; } =20 memset(&props, 0, sizeof(struct backlight_properties)); --=20 2.47.3 From nobody Fri Sep 25 04:38:17 2026 Received: from mta0.migadu.com (out-244.mta0.migadu.com [91.218.175.244]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 23EDF529417 for ; Wed, 16 Sep 2026 14:39:08 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=91.218.175.244 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1789569550; cv=none; b=oZKIG3S1SBAfHiWZWMr+eH7bG5VtkKHwyKEvTodJrX0ux0lwjEbbPeeBcwvxlmdS5eqBJJBMZZt9q9Z0dGFYnBkbDFuDB2+W9mFG5spL28d5puTwUc8afMizn0h0aD5c5aP82zrm9ogkxc7zUz6q7K5UIpInpYsEpqs2gOj9Izc= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1789569550; c=relaxed/simple; bh=P9XV2XO4MmtDvdZItN3sTDDtWP1gBvv2w2g7tC4qrkE=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=jXcKyC4jFe+lvRiHyDPdo9ooWqI7bfVPcGuZrux0THxfJEWCnYLx0OwZ71jdfx7RonnHZM5YZ9gbyBJI1xp37ArggqQQjQnpdaDz7/PUfjJ9xSlOnutKs8+5LqrQDTLWciebwvH/46BgayQF2M3nBYsEnCX14Atrd+9YNqLX/qQ= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.dev; spf=pass smtp.mailfrom=linux.dev; dkim=pass (1024-bit key) header.d=linux.dev header.i=@linux.dev header.b=RAEz5zoE; arc=none smtp.client-ip=91.218.175.244 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.dev Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linux.dev Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linux.dev header.i=@linux.dev header.b="RAEz5zoE" X-Envelope-To: linux-kernel@vger.kernel.org DKIM-Signature: a=rsa-sha256; bh=P9XV2XO4MmtDvdZItN3sTDDtWP1gBvv2w2g7tC4qrkE=; c=simple/simple; d=linux.dev; h=from:to:subject:date:message-id:mime-version:content-type; s=key1; t=1789569547; v=1; x=1790174347; b=RAEz5zoE+LLErtU0V3xfw1QelNAuW6Hu0MdmCos0GsqA59aJnsQwz0yJGuu3ug+MTWalElmz tScfhDIPTE4MqPk0zTYwgmofjsCUwVyWhk/6/vKsMv2j32bX9Feaw8//hQMObOmlVrQ0BX88XVA cgJEeyrhP485fxa12pNbUc9Y= X-Envelope-To: linux-kernel@vger.kernel.org Received: by smtp.migadu.com with ESMTPS id 97704f99edd96b49; Wed, 16 Sep 2026 14:39:06 +0000 X-Mizu-Trace-ID: 97704f99edd96b49 X-Migadu-Flow: FLOW_OUT From: Denis Benato To: platform-driver-x86@vger.kernel.org Cc: linux-kernel@vger.kernel.org, =?UTF-8?q?Ilpo=20J=C3=A4rvinen?= , "Hans de Goede" , "Corentin Chary" , "Luke Jones" , "Hugo Baigue" , "Ponali" , =?UTF-8?q?Manuel=20A=2E=20R=2E=20de=20Or=C3=BAe=20R=C3=ADos?= , "Salvatore Bonaccorso" , "Thorsten Leemhuis" , "Denis Benato" , Denis Benato Subject: [PATCH v1 3/4] platform/x86: asus-wmi: use backlight_is_blank() for screenpad power Date: Wed, 16 Sep 2026 14:38:27 +0000 Message-ID: <20260916143838.170950-4-denis.benato@linux.dev> X-Mailer: git-send-email 2.47.3 In-Reply-To: <20260916143838.170950-1-denis.benato@linux.dev> References: <20260916143838.170950-1-denis.benato@linux.dev> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" The screenpad backlight sets BL_CORE_SUSPENDRESUME, so the backlight core calls update_status() on suspend, resume and fb blanking with BL_CORE_SUSPENDED or BL_CORE_FBBLANK set in bd->props.state while bd->props.power keeps its value: the switch on bd->props.power alone ignored those flags, repowering the panel at suspend entry instead of turning it off, and ignoring fb blank requests. Replace the switch with backlight_is_blank(), which accounts for both bd->props.power and bd->props.state: the panel is powered off whenever the backlight is blank and powered on with backlight_get_brightness() otherwise. Writing a power state other than BACKLIGHT_POWER_ON or BACKLIGHT_POWER_OFF to bl_power now blanks the panel following the core convention instead of warning and failing with -EINVAL. The visible change is that the panel now actually powers off on suspend and fb blank, and is restored on unblank and resume. Suggested-by: Hugo Baigue Closes: https://lore.kernel.org/all/CAO84+xJ9aW3pj3x8e9b5biWtnNd4EyH7A4Uy7a= qBR4qZMDcVvg@mail.gmail.com/ Assisted-by: zcode:glm-5.3-flash Signed-off-by: Denis Benato --- drivers/platform/x86/asus-wmi.c | 32 +++++++++----------------------- 1 file changed, 9 insertions(+), 23 deletions(-) diff --git a/drivers/platform/x86/asus-wmi.c b/drivers/platform/x86/asus-wm= i.c index ded1aa356cf3..e6f3a5c0dba9 100644 --- a/drivers/platform/x86/asus-wmi.c +++ b/drivers/platform/x86/asus-wmi.c @@ -4536,32 +4536,18 @@ static int read_screenpad_brightness(struct backlig= ht_device *bd) =20 static int update_screenpad_bl_status(struct backlight_device *bd) { - u32 ctrl_param =3D bd->props.brightness; - int err =3D 0; - - switch (bd->props.power) { - case BACKLIGHT_POWER_ON: - err =3D asus_wmi_set_devstate(ASUS_WMI_DEVID_SCREENPAD_POWER, 1, NULL); - if (err < 0) - return err; - - err =3D asus_wmi_set_devstate(ASUS_WMI_DEVID_SCREENPAD_LIGHT, ctrl_param= , NULL); - if (err < 0) - return err; - break; + int err; =20 - case BACKLIGHT_POWER_OFF: - err =3D asus_wmi_set_devstate(ASUS_WMI_DEVID_SCREENPAD_POWER, 0, NULL); - if (err < 0) - return err; - break; + if (backlight_is_blank(bd)) + return asus_wmi_set_devstate(ASUS_WMI_DEVID_SCREENPAD_POWER, + 0, NULL); =20 - default: - pr_warn("Invalid screenpad backlight power state: %d\n", bd->props.power= ); - return -EINVAL; - } + err =3D asus_wmi_set_devstate(ASUS_WMI_DEVID_SCREENPAD_POWER, 1, NULL); + if (err < 0) + return err; =20 - return err; + return asus_wmi_set_devstate(ASUS_WMI_DEVID_SCREENPAD_LIGHT, + backlight_get_brightness(bd), NULL); } =20 static const struct backlight_ops asus_screenpad_bl_ops =3D { --=20 2.47.3 From nobody Fri Sep 25 04:38:17 2026 Received: from mta0.migadu.com (out-21.mta0.migadu.com [91.218.175.21]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id DA68C526AA0 for ; Wed, 16 Sep 2026 14:39:13 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=91.218.175.21 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1789569555; cv=none; b=nbUFwGxGYYIkTyWvW2nQPpHRHn9OaJdSCDjBF75ZEAHtZT3alMDlJnBtPu+kgki2NpKMFPRVUSFk0oRPOj6XZ7us44jxp9OONQsYhngiSSsxKkFSUvQWWIE5+NmPMWQ7htlMg3RbIPlkBuHyrkQm/CZdhApy5+rauu05yfVl/ZM= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1789569555; c=relaxed/simple; bh=yDRqn32T6OsTeld75ue/eGYhd366gSjMZAXI9ZW0rI0=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=RAQab54gDoMLUCFyah9qkIVe4PooUordjiv+8JnDcfTqBOvu0eCzgRV7iRgA9S7yP3v0IDBAvElwnaIAodnUgj8ErUd6bqnd9u619nwJhZH41TuBDhHvhVqT76iKmBQaSAVz1KxNb0IkoXWJuQH2cd0RS1YryW8h0nyNw06yQIM= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.dev; spf=pass smtp.mailfrom=linux.dev; dkim=pass (1024-bit key) header.d=linux.dev header.i=@linux.dev header.b=iajgI7HH; arc=none smtp.client-ip=91.218.175.21 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.dev Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linux.dev Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linux.dev header.i=@linux.dev header.b="iajgI7HH" X-Envelope-To: linux-kernel@vger.kernel.org DKIM-Signature: a=rsa-sha256; bh=yDRqn32T6OsTeld75ue/eGYhd366gSjMZAXI9ZW0rI0=; c=simple/simple; d=linux.dev; h=from:to:subject:date:message-id:mime-version:content-type; s=key1; t=1789569551; v=1; x=1790174351; b=iajgI7HHLNHX1Xnn2IyFju6EY67RK2zcdyS6JxofPy0qgY3e6UP9VpigFRbMszcFebsqhiHF q59w6m0NxgFELSJB64zLcNp0ofWe3WY9tpEvJky/OzRxn57bIBeAobM+3JpewuWxqZvDFzAfEEg X8YYjvAcgwqlNs5WQOU5DDcE= X-Envelope-To: linux-kernel@vger.kernel.org Received: by smtp.migadu.com with ESMTPS id bc1733425284d87c; Wed, 16 Sep 2026 14:39:11 +0000 X-Mizu-Trace-ID: bc1733425284d87c X-Migadu-Flow: FLOW_OUT From: Denis Benato To: platform-driver-x86@vger.kernel.org Cc: linux-kernel@vger.kernel.org, =?UTF-8?q?Ilpo=20J=C3=A4rvinen?= , "Hans de Goede" , "Corentin Chary" , "Luke Jones" , "Hugo Baigue" , "Ponali" , =?UTF-8?q?Manuel=20A=2E=20R=2E=20de=20Or=C3=BAe=20R=C3=ADos?= , "Salvatore Bonaccorso" , "Thorsten Leemhuis" , "Denis Benato" , Denis Benato Subject: [PATCH v1 4/4] platform/x86: asus-wmi: remove unused screenpad_brightness Date: Wed, 16 Sep 2026 14:38:28 +0000 Message-ID: <20260916143838.170950-5-denis.benato@linux.dev> X-Mailer: git-send-email 2.47.3 In-Reply-To: <20260916143838.170950-1-denis.benato@linux.dev> References: <20260916143838.170950-1-denis.benato@linux.dev> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Nothing reads asus->driver->screenpad_brightness anymore: the last reader went away when the screenpad update path stopped relying on a driver-side copy of the brightness, leaving only the write in asus_screenpad_init(). ASUS_SCREENPAD_BRIGHT_DEFAULT became unused in the same rework. Drop the field from struct asus_wmi_driver, the write and the unused define. Nothing in the current code depends on remembering the last brightness while the panel is off; should a model turn up that needs it (the original screenpad implementation did, and older DUO models may behave differently from the hardware tested so far), the field can be reintroduced then. Assisted-by: zcode:glm-5.3-flash Signed-off-by: Denis Benato --- drivers/platform/x86/asus-wmi.c | 2 -- drivers/platform/x86/asus-wmi.h | 1 - 2 files changed, 3 deletions(-) diff --git a/drivers/platform/x86/asus-wmi.c b/drivers/platform/x86/asus-wm= i.c index e6f3a5c0dba9..440b86549eb9 100644 --- a/drivers/platform/x86/asus-wmi.c +++ b/drivers/platform/x86/asus-wmi.c @@ -127,7 +127,6 @@ module_param(fnlock_default, bool, 0444); #define NVIDIA_TEMP_MAX 87 =20 #define ASUS_SCREENPAD_BRIGHT_MAX 255 -#define ASUS_SCREENPAD_BRIGHT_DEFAULT 60 =20 #define ASUS_MINI_LED_MODE_MASK 0x03 /* Standard modes for devices with only on/off */ @@ -4586,7 +4585,6 @@ static int asus_screenpad_init(struct asus_wmi *asus) } =20 asus->screenpad_backlight_device =3D bd; - asus->driver->screenpad_brightness =3D brightness; bd->props.brightness =3D brightness; bd->props.power =3D power; backlight_update_status(bd); diff --git a/drivers/platform/x86/asus-wmi.h b/drivers/platform/x86/asus-wm= i.h index 5cd4392b964e..b45f81b38a47 100644 --- a/drivers/platform/x86/asus-wmi.h +++ b/drivers/platform/x86/asus-wmi.h @@ -57,7 +57,6 @@ struct quirk_entry { struct asus_wmi_driver { int brightness; int panel_power; - int screenpad_brightness; int wlan_ctrl_by_user; =20 const char *name; --=20 2.47.3