From nobody Fri Sep 25 05:30:48 2026 Received: from OS0P286CU011.outbound.protection.outlook.com (mail-japanwestazon11010024.outbound.protection.outlook.com [52.101.228.24]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 7A6DF466AE6; Wed, 16 Sep 2026 12:00:35 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=fail smtp.client-ip=52.101.228.24 ARC-Seal: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1789560040; cv=fail; b=ge1FJLKmOyU/hdIB2oVMfWHVYyxGwNbQcpjkfTjjRhRa1Y9jEQSKg6K1fbzQ8eBx6xjFAolBV9e/BbSt3Tr+KKMFWsgMws6/CJuJu3vSGcK8rQUj3aaQ3ptaqMDZFYBNqckZItNRDMDNvSAW8p4aHdMBqqS5vKyEIYCq6dBX6sc= ARC-Message-Signature: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1789560040; c=relaxed/simple; bh=Ovyb+DfyQNJbkyETx6zbmd7D4ZP1ApeLS16Vl0m2nSs=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=VnNfasgO7bqnljohCBwirk89nLceLS4IfKqc0PpYEErzH5Tnn2CVpVUYm0h10WvFAeECSNU2Vu9PeDH2SxUKqdVjfRBr03t9dtyLGjGx+EIS35lAjPBdKXhLh1gF2Fx/TUQjdZ8ElgzKrI3xKEJHi+13QGzNsOcVNg28TEKUf3g= ARC-Authentication-Results: i=2; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=renesas.com; spf=pass smtp.mailfrom=renesas.com; dkim=pass (1024-bit key) header.d=renesas.com header.i=@renesas.com header.b=iDYNrGtP; arc=fail smtp.client-ip=52.101.228.24 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=renesas.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=renesas.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=renesas.com header.i=@renesas.com header.b="iDYNrGtP" ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=Ft4OJ4lPVQCwMMhm8GDks4i+foy214rEeajFZVGadsDNKjgWj+dxCIMp+cGpdFrr5QDdbql3+SX8oDo7bZVd7PmMAKxn4afX7O0H+UDyUzUxoyU7fWf3jGPGpDMM37E86P5lUPuQ9ZAcwPs2a8WOq0dtFAfbEvMN9fxQx0oS0ceBzXs/VQQQvE52cso5CoHSsgoo6GiMfSwBwHXQpKkbaDe2oD6vPFs8ErBjU4mDvR3vNselsFTB/4v60wjvgROlAlUoic9q7nlX0dNu+I6J/2i7stALyp7QSrrvdTirnVeO8jkFIO3Hg4tsDHNkinEkQ+0I4lvgEPEG73neI+rCDw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=b1+sG1ljEVivCrW6hJu07pWxh8+z0iiGfqYlqOe2pEY=; b=QVgDPtrEw6gzF/gycxoVYNvkaL+lcfKdCOFRxnluew38o2KXHJlEjkEbPAqGLV5NcvE8L+z6wnz5WfaR9hPou+9AceMuIqBbyKcuKTcQfI1Wd8zkWsEoskj/zKJunLsEQiCrvLYjJG0o6PY0wfFA9WMMl/gq+YZXIMhrXn2+rWvE6G7zbgmVpgSA1CT6rOmA6rRM8l+ezbGoS1a67iwppOKtkpvpBUK/aB/f1xaIRYqKIampDm56dVAa7gab5jm1C/R1BDlYCbCekx/gwXTMWxGwcny7UYnUuCFAhqVG3KTcu5xbc/Zz8gsjEHf+JhE8h4Gyyth35t/f861sWb90mQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 8.62.32.50) smtp.rcpttodomain=arm.com smtp.mailfrom=renesas.com; dmarc=pass (p=none sp=none pct=100) action=none header.from=renesas.com; dkim=none (message not signed); arc=none (0) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=renesas.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=b1+sG1ljEVivCrW6hJu07pWxh8+z0iiGfqYlqOe2pEY=; b=iDYNrGtPVAgrGfDI+Irv7MhZw6cDZU7y88X38HiMiLYXTTG6Fb8Hc5S0aubGtrdmmua9cyO5I1z2byfY6AlyYp4qn3HBZA+frHL7B+tm+x4jrxyRoWVuD0Ve2v+wTHES6V5sBhTwz+RBV8Cfh1b9D7pMnm1n8T4gq6neWWWf19g= Received: from TY4PR01CA0061.jpnprd01.prod.outlook.com (2603:1096:405:370::16) by OS3PR01MB6888.jpnprd01.prod.outlook.com (2603:1096:604:117::13) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.21.428.11; Wed, 16 Sep 2026 12:00:30 +0000 Received: from TYO1EPF00005023.JPNP286.PROD.OUTLOOK.COM (2603:1096:405:370:cafe::a7) by TY4PR01CA0061.outlook.office365.com (2603:1096:405:370::16) with Microsoft SMTP Server (version=TLS1_3, cipher=TLS_AES_256_GCM_SHA384) id 15.21.428.11 via Frontend Transport; Wed, 16 Sep 2026 12:00:30 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 8.62.32.50) smtp.mailfrom=renesas.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=renesas.com; Received-SPF: Pass (protection.outlook.com: domain of renesas.com designates 8.62.32.50 as permitted sender) receiver=protection.outlook.com; client-ip=8.62.32.50; helo=ejcrelay005p.adwin.renesas.com; pr=E Received: from ejcrelay005p.adwin.renesas.com (8.62.32.50) by TYO1EPF00005023.mail.protection.outlook.com (10.167.240.20) with Microsoft SMTP Server (version=TLS1_3, cipher=TLS_AES_256_GCM_SHA384) id 15.21.428.7 via Frontend Transport; Wed, 16 Sep 2026 12:00:29 +0000 Received: from vm01.adwin.renesas.com (DEU-5CG20946WF.adwin.renesas.com [10.226.92.205]) by ejcrelay005p.adwin.renesas.com (Postfix) with ESMTP id F3CB73000442; Wed, 16 Sep 2026 21:00:26 +0900 (JST) From: Ovidiu Panait To: john.madieu.xa@bp.renesas.com, rafael@kernel.org, daniel.lezcano@kernel.org, rui.zhang@intel.com, lukasz.luba@arm.com, linux-kernel@vger.kernel.org Cc: linux-pm@vger.kernel.org, Ovidiu Panait Subject: [PATCH 1/5] thermal: renesas: rzg3e: Fix signed integer overflow in temp_to_code() Date: Wed, 16 Sep 2026 11:59:59 +0000 Message-ID: <20260916120003.87018-2-ovidiu.panait.rb@renesas.com> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20260916120003.87018-1-ovidiu.panait.rb@renesas.com> References: <20260916120003.87018-1-ovidiu.panait.rb@renesas.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: TYO1EPF00005023:EE_|OS3PR01MB6888:EE_ X-MS-Office365-Filtering-Correlation-Id: 2266ad7b-cc1a-4b62-bf1e-08df13ea1a7e X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|376014|36860700016|82310400026|23010399003|1800799024|18002099003|22082099003|56012099006|11063799006|10067099003; X-Microsoft-Antispam-Message-Info: ekvDC9skNoZBLJvHHALXdaGgK1al6MDNydQB6P9xOtVGn+uDF1qXbH9iKqytlVfQhJay3IF5c0njEk7F7HcDZd+joSbm2LKxbQnKthvkLLvMZwSpX46LkP1GMS4hbiWztizGFmN0Ki8K4PWRf/TH0x9K4Vjc6Gfp31rBte4DDpNuFAjf5DMg2QMy/pjmnjm6VzeVLVUvNGBiFfqUYclTqeDrcALVmMCcL4RfDqHvlOXOdDqxxTOr/97mjWQt9TRuY4itHDnp+g4d+c8Gh1q0Fx5vMCj8gOt6bEO4bbSYbd7LI83s6kdncYtStIujFzvcP9CdK3DkFWzAi1vyhWrl4e4YqlP5aoR5qG3CZ8WXTbpy8qXU5m3Qke++2TbkB5xUXrLr/qzbpn/NkRDyphFUHOcKhr5pDT420xy41ceeALAzdDmBigp43jHngIClTaSgufUa0v2fL4CPFtZI9fRkaCo9YrFNCSj7Z6HMEBKuwzTiof+9U914ZyLzRQr7wGBFnbeVFhdg/0y7pQQJWq9NzpiHxb4U8kapH7r/ytwE9AMueeK2ZRP2uWRo9o9n7NXlSeQgFTDKTzc508zd577g0WHh/ZkTP5oRnHon0gaLC5U7fUtj4Aa8Kwe6BP6AwGjeMVBBOi0peUxVOpE75fJffCdX1IHCK9vXR6vlWUuWP0OPG2fh57rDpfSQuQOc7GDaIHv6EK3TbTewCHclJHqSfw== X-Forefront-Antispam-Report: CIP:8.62.32.50;CTRY:US;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:ejcrelay005p.adwin.renesas.com;PTR:InfoDomainNonexistent;CAT:NONE;SFS:(13230040)(376014)(36860700016)(82310400026)(23010399003)(1800799024)(18002099003)(22082099003)(56012099006)(11063799006)(10067099003);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: LPl7LCwqiV4hv8D4RMU9ckQB2mrgqnI8tyxjEtzLeX6SPniItOe8/ip4bjTQw2W0woc22pE7MS0vuOnhXh7yzyVHMZ8k8QWizlUfohz0MGLCFhvvUT3mj6F+X7wLC8/XYxWk47n5q89J5VWupNCEjOtCik1duCPB5K5zpkJvo9ckxZ19vEJ4QV6wR0NnNnDp6NBcuncb7kcf2sqUb/Q5+7tk0gKZVr3zx75A5srZQKbmT6QGbD2KOZ8kY/2lltka3+rjdGmdZlIj/xiHQ9Wzop5Q4zFCjFCZBuCHmCjrXKUyJR0kktO/4xvIoCB8EjwhSN5CWywm84J1k/dxtAp8DSp42r//7Sl/1EduUqs3+w+zK7I6BD/FmWNNZhMwqAXoAQ6ZhV0YEuUPKkbtoD9SDe0kFKfUHsipKRxjjim0UiMVWuSWOhUI5IQeI5a6k8yU X-OriginatorOrg: renesas.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 16 Sep 2026 12:00:29.7186 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 2266ad7b-cc1a-4b62-bf1e-08df13ea1a7e X-MS-Exchange-CrossTenant-Id: 53d82571-da19-47e4-9cb4-625a166a4a2a X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=53d82571-da19-47e4-9cb4-625a166a4a2a;Ip=[8.62.32.50];Helo=[ejcrelay005p.adwin.renesas.com] X-MS-Exchange-CrossTenant-AuthSource: TYO1EPF00005023.JPNP286.PROD.OUTLOOK.COM X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: OS3PR01MB6888 Content-Type: text/plain; charset="utf-8" The thermal core passes -INT_MAX/INT_MAX as low/high trip points, which the driver then converts to code values for programming the registers: numerator =3D (temp_mc - info->temp_d_mc) * (priv->trmval1 - priv->trmval0); Although 'numerator' is defined as s64, the arithmetic is performed as int. Because of this, the multiplication overflows for -INT_MAX and, because temp_d_mc is negative, the subtraction overflows for INT_MAX. To fix this, cast the temperature to s64, so that the arithmetic is performed as s64. Fixes: dc67521c20b7 ("thermal/drivers/renesas/rzg3e: Fix add thermal driver= for the Renesas RZ/G3E SoC") Signed-off-by: Ovidiu Panait --- drivers/thermal/renesas/rzg3e_thermal.c | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/drivers/thermal/renesas/rzg3e_thermal.c b/drivers/thermal/rene= sas/rzg3e_thermal.c index c44f5b8858d0..4acee4eaff05 100644 --- a/drivers/thermal/renesas/rzg3e_thermal.c +++ b/drivers/thermal/renesas/rzg3e_thermal.c @@ -194,7 +194,12 @@ static u16 rzg3e_thermal_temp_to_code(struct rzg3e_the= rmal_priv *priv, int temp_ s64 numerator, denominator; s64 code; =20 - numerator =3D (temp_mc - info->temp_d_mc) * (priv->trmval1 - priv->trmval= 0); + /* + * Perform the arithmetic in 64 bits so that it cannot overflow for + * -INT_MAX/INT_MAX values passed from the thermal core or when + * userspace writes arbitrary trip point temperatures. + */ + numerator =3D ((s64)temp_mc - info->temp_d_mc) * (priv->trmval1 - priv->t= rmval0); denominator =3D info->temp_e_mc - info->temp_d_mc; =20 code =3D div64_s64(numerator, denominator) + priv->trmval0; --=20 2.34.1 From nobody Fri Sep 25 05:30:48 2026 Received: from TY3P286CU002.outbound.protection.outlook.com (mail-japaneastazon11010034.outbound.protection.outlook.com [52.101.229.34]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 9B86E3EB802; Wed, 16 Sep 2026 12:00:39 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=fail smtp.client-ip=52.101.229.34 ARC-Seal: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1789560044; cv=fail; b=CCxFcwcQd18mPXqXf6sK2Yck9PiVZMbXB1b11m+8wukDXiPfJPpGJfonrUMuWF/S6tPh8yTbR/S+GJbZVGinLiEZT/ffgq01ux3KtyNnymkRMHrqUGffZilgTQ5oKQhJR6MoOBDd33BrsKb9TislAHBioXoUic311u35nacJu5c= ARC-Message-Signature: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1789560044; c=relaxed/simple; bh=FxtTmvCUlu5UgcMsb9AAeFgJLQhuVaGQakR1AEb+/DE=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=bACttDxEGCySGbvDL6sj+qe1gYHikNaAhmUVYN8fT6n1LedwJBkkLb/lbdDWQsulPxGo1uwUN2zrlIzFbLfwIT7YC05VHfNUGUIesS9BtYU+p05fslCfrtawLll5pcWkSQ6I1vwWWiIoeWv/cCp7ByaPlD4tzpvfCtd18NGJfQQ= ARC-Authentication-Results: i=2; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=renesas.com; spf=pass smtp.mailfrom=renesas.com; dkim=pass (1024-bit key) header.d=renesas.com header.i=@renesas.com header.b=mqkCaVBP; arc=fail smtp.client-ip=52.101.229.34 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=renesas.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=renesas.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=renesas.com header.i=@renesas.com header.b="mqkCaVBP" ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=GCk6fzAuilvbCF8BmdYen04RPuMo47RssbR0+FY8fvDiSlFTQqJFa2r6QePbrUpTHKd2F7o9c+3i1MXIxDrmbWfNfIrKIO/LbSU32w+rxfxoDIJ1XKrRTjTb/WUyyGJLy9bK91+eiWXJf4V5nNyAoSDSntZl6OXn1YlB29UTkLxJkRw/Ax9vuy9xz9qBsr6pkgvB3Fj9pvXHvDMvxmPccGV2RVSJe+aH98ri9BQzO3v6LGNO3fit4Ys+gd5UNL4qojZnjE0QMPYb0fYBik5u4n3PIgHRQbEx1sqZf8EECowIxE+4qUdL5jIW9L5NOYE1x/XktcftmvJ454ZfWJViSA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=S+SY32bnBtyEWV45h64MSlnYtVkmPWGuKsUtsXwV3uQ=; b=CoMULQdwrASDwK+ZCtQB2s7KIwks2CLCUyF3nM3w3BtiV78xg6WfNCg+XpEcQwDsFIN1TzGUEjgcDYjih1lznJGm/q563G/iuYSx3G48Lp3ubwt7IUofeWeipG508JhmNi52sDfugzQAgzBaEbASQuWf6+SIqEsLS/GxGGjz1ci4wCmxPVLBe7IxtkBETYWbuusw+gGdTK5V4ti73rhmCORrkdU9v+HA+U8vl5lH4BKoFBO5w0E/E0dhG7Nplr2mgg2tpRvRgcR9DlSLGzWNgJhyVBa8nMZIEjbN51Mn13LyBnbA1X66zWnDFXavzfJo+H4CSTW9h2cHPsqtUgc4rA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 8.62.32.50) smtp.rcpttodomain=arm.com smtp.mailfrom=renesas.com; dmarc=pass (p=none sp=none pct=100) action=none header.from=renesas.com; dkim=none (message not signed); arc=none (0) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=renesas.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=S+SY32bnBtyEWV45h64MSlnYtVkmPWGuKsUtsXwV3uQ=; b=mqkCaVBPrdJ5jMVPr1r9M9Luti0RzNJJINwb+F+O1jUIBgVtlMejkhOd1Pd4AkZDbMGy+BPCBfi7w74coukfRIpIqxLekWamDMMT1PZMFvSgOTdqPVv0r6PSI9+C6H7wfwNUAnQt/TENLScU2kJJ7y9ctunc//B9jXn+1mao4Rk= Received: from OS0P286CA0037.JPNP286.PROD.OUTLOOK.COM (2603:1096:604:9e::6) by OS3PR01MB7383.jpnprd01.prod.outlook.com (2603:1096:604:14a::9) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.21.428.11; Wed, 16 Sep 2026 12:00:33 +0000 Received: from OS1PEPF0000D216.JPNP286.PROD.OUTLOOK.COM (2603:1096:604:9e:cafe::88) by OS0P286CA0037.outlook.office365.com (2603:1096:604:9e::6) with Microsoft SMTP Server (version=TLS1_3, cipher=TLS_AES_256_GCM_SHA384) id 15.21.428.11 via Frontend Transport; Wed, 16 Sep 2026 12:00:33 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 8.62.32.50) smtp.mailfrom=renesas.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=renesas.com; Received-SPF: Pass (protection.outlook.com: domain of renesas.com designates 8.62.32.50 as permitted sender) receiver=protection.outlook.com; client-ip=8.62.32.50; helo=ejcrelay005p.adwin.renesas.com; pr=E Received: from ejcrelay005p.adwin.renesas.com (8.62.32.50) by OS1PEPF0000D216.mail.protection.outlook.com (10.167.240.23) with Microsoft SMTP Server (version=TLS1_3, cipher=TLS_AES_256_GCM_SHA384) id 15.21.428.7 via Frontend Transport; Wed, 16 Sep 2026 12:00:32 +0000 Received: from vm01.adwin.renesas.com (DEU-5CG20946WF.adwin.renesas.com [10.226.92.205]) by ejcrelay005p.adwin.renesas.com (Postfix) with ESMTP id 2EB313000441; Wed, 16 Sep 2026 21:00:29 +0900 (JST) From: Ovidiu Panait To: john.madieu.xa@bp.renesas.com, rafael@kernel.org, daniel.lezcano@kernel.org, rui.zhang@intel.com, lukasz.luba@arm.com, linux-kernel@vger.kernel.org Cc: linux-pm@vger.kernel.org, Ovidiu Panait Subject: [PATCH 2/5] thermal: renesas: rzg3e: Fix runtime PM handling of compare irq Date: Wed, 16 Sep 2026 12:00:00 +0000 Message-ID: <20260916120003.87018-3-ovidiu.panait.rb@renesas.com> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20260916120003.87018-1-ovidiu.panait.rb@renesas.com> References: <20260916120003.87018-1-ovidiu.panait.rb@renesas.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: OS1PEPF0000D216:EE_|OS3PR01MB7383:EE_ X-MS-Office365-Filtering-Correlation-Id: 76543b26-a39e-4081-83b0-08df13ea1c6c X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|23010399003|36860700016|376014|82310400026|1800799024|56012099006|11063799006|6133799003|10067099003|18002099003|22082099003; X-Microsoft-Antispam-Message-Info: sXU2za0w3EHMToQAdwraJDPQMQ2IGFtmTNJikv1jqqtWGgzx/GmreGTkKXO0lHZIFK3KXwlFTMRLtL7cXudz3EuCo48CCFV8RR9760fUufutyA0fGuD97CmNd+4sXd+nmg9z3udjKOscknsTYkhy4k5b0ZBmPpVQBuaHFf4IVCfSnCmFWXIXg0PoqxN1AHCa7INH6MTIqyyMAFkNHyIEbx3a/DVGmIO08LUoTrzGb7AZ+cOsQHXVZiIPcUDhBY6LO4eaJ4a1+CEWc+/t9P4M+dprIs1UlMuRRs7H54Y1xsVtwS0kKiOALf6ifwZ7gMlE1ju88WhPa9KD3fCNrQAiRxaooqe9Oj78Bzj+XpXOB4Y8r9PuJ1o4b684p4fvmY+udUN7FdytApJAjSoDrR+N4gEtw67+4K+F2fAeeKGwjp1q04S0ePOSc56hGkYcJre0mp++3SB/bJfkIr4r26EXLIwxKaEJnseBXp7BITcJqFavhqqApSXfxQ0wy0r/aH8jZejH23tyffD9Ybz2d2T5ZxB2nuxNnu3tx3gIFvv/1CGJK0xUSqksDrhGISrwZfqN1Ce7Q5oUKTRUQoqbawHWqmvqxKCDobYdxa3aX2IBCbRNkei1ughXoCSspY95xa3xVvEIXbXaXIrw3/ELDRe7/4flUYF+HtV/+YsZ8J8y9UlTUgXkpgti6Az1bjyxhAPtjJQMojOSpSmyyG8eQRSNdA== X-Forefront-Antispam-Report: CIP:8.62.32.50;CTRY:US;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:ejcrelay005p.adwin.renesas.com;PTR:InfoDomainNonexistent;CAT:NONE;SFS:(13230040)(23010399003)(36860700016)(376014)(82310400026)(1800799024)(56012099006)(11063799006)(6133799003)(10067099003)(18002099003)(22082099003);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: 85YYLGHqmE80NCK6NHbq1K9PvW49PfBgEk/723TL3Z0LEu68qF/pnS6+3T4hyTWQB0rgDjVuUYasno6yA4j9zbShQuWaomkTsrNhlS9zifCA1vn+la7EHRxJoCAhS7R6ouyf3jszKvjKsfrjrVzuBi9tAOTpIQ8ADHaf6pd+BT6KLgyGel8mNbi8swasMYlPRwe9mvrNxuKmfu+FhVhju12Q9EkoUAyoS9xjG4FkQa0HZ+/XO3iUHU0mBkn85oLm7cwT2k/SV++AOhfFzGJrOiPXc9HgB6kYTNkxz0/C2cbY6c8z/Z79dRiIX4bU9Gq3zJK9Cq90evQqqRuQtCjF5Fibp2u6lPuV2bAxxQzemU7J2aUeZCLE18uT76BRTxTdNhebbbZ7aTHFckRfWlcCx+T+wlpPkomFjyHY+BUkASvl3uL8lonV7JqGYwhwMQ0a X-OriginatorOrg: renesas.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 16 Sep 2026 12:00:32.9436 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 76543b26-a39e-4081-83b0-08df13ea1c6c X-MS-Exchange-CrossTenant-Id: 53d82571-da19-47e4-9cb4-625a166a4a2a X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=53d82571-da19-47e4-9cb4-625a166a4a2a;Ip=[8.62.32.50];Helo=[ejcrelay005p.adwin.renesas.com] X-MS-Exchange-CrossTenant-AuthSource: OS1PEPF0000D216.JPNP286.PROD.OUTLOOK.COM X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: OS3PR01MB7383 Content-Type: text/plain; charset="utf-8" The TSU hw is limited in the sense that lower and upper trip points can be set, but the hw cannot raise interrupts on its own. It can only signal that the thresholds were passed when the temperature is read, either during polling or on a manual read. Therefore, the interrupt enable state configured by set_trips() must remain active for the next read to trigger an event. Currently, runtime PM autosuspend puts the chip to sleep and clears the compare interrupt that was enabled during set_trips(). On power up, the compare interrupt enable is not restored, which means that it won't ever fire. Fix this by caching the contents of the SIER register during runtime power off and restore it during runtime power on. Fixes: dc67521c20b7 ("thermal/drivers/renesas/rzg3e: Fix add thermal driver= for the Renesas RZ/G3E SoC") Signed-off-by: Ovidiu Panait --- drivers/thermal/renesas/rzg3e_thermal.c | 8 +++++++- 1 file changed, 7 insertions(+), 1 deletion(-) diff --git a/drivers/thermal/renesas/rzg3e_thermal.c b/drivers/thermal/rene= sas/rzg3e_thermal.c index 4acee4eaff05..45f67b2e1131 100644 --- a/drivers/thermal/renesas/rzg3e_thermal.c +++ b/drivers/thermal/renesas/rzg3e_thermal.c @@ -93,6 +93,7 @@ struct rzg3e_thermal_info { * @info: chip type specific information * @trmval0: calibration value 0 (b) * @trmval1: calibration value 1 (c) + * @sier: cached interrupt enable register * @lock: protects hardware access during conversions */ struct rzg3e_thermal_priv { @@ -103,6 +104,7 @@ struct rzg3e_thermal_priv { const struct rzg3e_thermal_info *info; u16 trmval0; u16 trmval1; + u32 sier; struct mutex lock; }; =20 @@ -148,12 +150,16 @@ static int rzg3e_thermal_power_on(struct rzg3e_therma= l_priv *priv) return ret; } =20 + /* Restore interrupt enable state */ + writel(priv->sier, priv->base + TSU_SIER); + return 0; } =20 static void rzg3e_thermal_power_off(struct rzg3e_thermal_priv *priv) { - /* Disable all interrupts */ + /* Save and disable all interrupts */ + priv->sier =3D readl(priv->base + TSU_SIER); writel(0, priv->base + TSU_SIER); =20 /* Clear pending interrupts */ --=20 2.34.1 From nobody Fri Sep 25 05:30:48 2026 Received: from TY3P286CU002.outbound.protection.outlook.com (mail-japaneastazon11010042.outbound.protection.outlook.com [52.101.229.42]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 1ABB64E3ED9; Wed, 16 Sep 2026 12:00:40 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=fail smtp.client-ip=52.101.229.42 ARC-Seal: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1789560046; cv=fail; b=D3ZUSBvNQCUoru5RKSx8QSqQCpJj68WD5eZD/aVKo9xFItd/mcv0tpeCtGBA6zAP+qotc6sN/SBmLRWUaCZkBOpVdTmK/3emIPt+AvcbkSOPct2KBcYlMu4N8j7abt/SU663RYPpGlB4KEZo6vo8fWZmpGX2JdLcUVXJVwRovn4= ARC-Message-Signature: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1789560046; c=relaxed/simple; bh=A0Y6STjtupIYq7PynAIpWmIa23vrYhYSIkMzsKN/Sxs=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=shs9kyvWjxvpZA2EEUBoyn5FhFtJM5VE+rEDj4pUvISEKIo4AAPUl0GZTf6Dr9hwEpDqv6MGSM7uTMun10LDHdoNouOYB2hhC1z9Frt6NyB7IhxzJvUFAoobu9bRzFng5/QF/QN3D5qN//J/uGD1KFkLwjy7c8y8EhPu57+DraU= ARC-Authentication-Results: i=2; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=renesas.com; spf=pass smtp.mailfrom=renesas.com; dkim=pass (1024-bit key) header.d=renesas.com header.i=@renesas.com header.b=b+jNZOez; arc=fail smtp.client-ip=52.101.229.42 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=renesas.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=renesas.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=renesas.com header.i=@renesas.com header.b="b+jNZOez" ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=FF8YN54ieE+JP91kmLmsinkgin/GznK375mHvw4+H5qaT8aONVIoqsRvH1BSFZnfqpqdleM61i5fdV9mYwDO4bmb1/XjBtwprD3ah1ewop4gVjx4EuAdZ80B2fksfVWqFXqga5SIMHr3ka6/OVZm1FB7yHmuIcUhvSCxMhdJMKgZehdVL4ONWKPtxnRgH0CYLNSZSWLjW1L56NRM+6QwvS8egHVm7jCBwNvaCsPwfT0S/I0PG6eE3Pi7sq+TAx2TehJQBbv96XQDwO9pEcPGGWZDhaXEL4q4tmTWEOsUiPofxPkqje6F5GXCTpWUmRpOsaTZO5XfqhpJrCAEvdnEyg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=dBnYSJ8P00F6a4tSszP5rdoK1W99CgxnfecMRK1BKs8=; b=GJdfpgojPHR75tLmlQ3C+2c9Qeq3WJHN+riQ4z8V2sdXWQBrPcoS8nJiAi68ExOmxEEAH8jdAdzCNxcowiI0/x0vrFOBPvn6KLwlDUEDaSzkGr86bdWgvHFzlz5A600FIlZDqTwftSBwN7UBDZ9jKQ/p8Fvips25VPYdAuDePasqibxOjO/Lp00re4J4IYSjrjvU57E69B78WehdxffBAnsiEA75V7W3h86hLACn0LDoxMjTcoCCyoNCAea8383+nxJcWkF76niiaBoM9w+BELPf7JsA5dGejUFyNB9ggKw9cNeNXJjDIMnIp3RIf2pupNOPd/g0lfV8cApaqbl08w== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 8.62.32.50) smtp.rcpttodomain=arm.com smtp.mailfrom=renesas.com; dmarc=pass (p=none sp=none pct=100) action=none header.from=renesas.com; dkim=none (message not signed); arc=none (0) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=renesas.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=dBnYSJ8P00F6a4tSszP5rdoK1W99CgxnfecMRK1BKs8=; b=b+jNZOezAfhgkTp0xy0vn9jJUSci/G7ojy0rnrohQ0HKmoAtwPO9P3FlTySjRp+8etnJbIagQWHA4ETllcwMxuWieYdgTW5nTts2jiJqf7eWT7i8g7Cmu90HJXFhhwEdSoaa38tW74WeA+7QCZGzvYAD2rHsonH7GixDMWu7s5E= Received: from TY6PR01CA0025.jpnprd01.prod.outlook.com (2603:1096:405:3bb::14) by OS9PR01MB17980.jpnprd01.prod.outlook.com (2603:1096:604:474::12) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.21.428.9; Wed, 16 Sep 2026 12:00:36 +0000 Received: from TY1PEPF0000BAD7.JPNP286.PROD.OUTLOOK.COM (2603:1096:405:3bb:cafe::4c) by TY6PR01CA0025.outlook.office365.com (2603:1096:405:3bb::14) with Microsoft SMTP Server (version=TLS1_3, cipher=TLS_AES_256_GCM_SHA384) id 15.21.428.11 via Frontend Transport; Wed, 16 Sep 2026 12:00:36 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 8.62.32.50) smtp.mailfrom=renesas.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=renesas.com; Received-SPF: Pass (protection.outlook.com: domain of renesas.com designates 8.62.32.50 as permitted sender) receiver=protection.outlook.com; client-ip=8.62.32.50; helo=ejcrelay005p.adwin.renesas.com; pr=E Received: from ejcrelay005p.adwin.renesas.com (8.62.32.50) by TY1PEPF0000BAD7.mail.protection.outlook.com (10.167.240.36) with Microsoft SMTP Server (version=TLS1_3, cipher=TLS_AES_256_GCM_SHA384) id 15.21.428.7 via Frontend Transport; Wed, 16 Sep 2026 12:00:36 +0000 Received: from vm01.adwin.renesas.com (DEU-5CG20946WF.adwin.renesas.com [10.226.92.205]) by ejcrelay005p.adwin.renesas.com (Postfix) with ESMTP id 5B8343000441; Wed, 16 Sep 2026 21:00:33 +0900 (JST) From: Ovidiu Panait To: john.madieu.xa@bp.renesas.com, rafael@kernel.org, daniel.lezcano@kernel.org, rui.zhang@intel.com, lukasz.luba@arm.com, linux-kernel@vger.kernel.org Cc: linux-pm@vger.kernel.org, Ovidiu Panait Subject: [PATCH 3/5] thermal: renesas: rzg3e: Fix race between set_trips() and get_temp() Date: Wed, 16 Sep 2026 12:00:01 +0000 Message-ID: <20260916120003.87018-4-ovidiu.panait.rb@renesas.com> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20260916120003.87018-1-ovidiu.panait.rb@renesas.com> References: <20260916120003.87018-1-ovidiu.panait.rb@renesas.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: TY1PEPF0000BAD7:EE_|OS9PR01MB17980:EE_ X-MS-Office365-Filtering-Correlation-Id: 44c836fe-696a-49a0-bd10-08df13ea1e56 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|376014|23010399003|36860700016|82310400026|1800799024|11063799006|56012099006|10067099003|18002099003|22082099003|6133799003; X-Microsoft-Antispam-Message-Info: 2wVlJgFpJm67vVfUTaFvgOVEtZDWyfNivLd2fR15/0sqhcy9BOG1tfypw8wn2clCXGRupgHnkBSTovihBuPZovGXprI5GDgwN7hFD8oDUzm6B9BaQocHCB2qyAjr0bnf0qAlbtjRQcB48rlwCQZFybyQisvYts6HQ9e/ZxMxsqp6bVrmyFybcQbn3jExcHlmTKVzJ92u2rqp9iGTbIQmTiadLTH8NXXmSWKgZlx/X79ggs0SwdYohWOFOo8P/bntr2Av8joBGvb03/sbhVy9zV8Xco96M3ZN8i7zglltdUI5n0thdSv/JVBRAmBB/jbesW/brjrPIwB25QfJozoziL7m08zZaZcKycpLZA+t1H1ppAsPR02yGywDkbl+ox2wiQz8rhs3AbTQAICNNUWGcwi9VsKyxWvsEukRY/egZQlUmj9xUQONkwjdyJTPtJi8EvL8nwDka4o53eGzUnhx05mNFH/VH+NZ9b8+3A4FlxYd9ZCIzh2KxBokPymjRbDrUU/6h2chG3Vjd76T5mmvtCDDBuJFg88ERsCySy+Wa7wxyGGPbtaxNdrpO+dl0gNnTKg4o60+YbrVcBSoiA1wV8sqf/UtCICqXgGOBXNl+Iu9A5ivQR3jmRYlK0mlJ9rGI9/b4Erd/IzgLJNKkDp2oR7PTzf264qxMOah5twklWyXcG0HdJ1wXiJ9YQa0SD1KedVfsbAEW3//UJfWZBHHtg== X-Forefront-Antispam-Report: CIP:8.62.32.50;CTRY:US;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:ejcrelay005p.adwin.renesas.com;PTR:InfoDomainNonexistent;CAT:NONE;SFS:(13230040)(376014)(23010399003)(36860700016)(82310400026)(1800799024)(11063799006)(56012099006)(10067099003)(18002099003)(22082099003)(6133799003);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: cmzcnWywAulGwIhbr9++D69GwcjH3BjughnjiNTooEABMfQJ0vCb65fG16rUHSR/BlBg67KNKN93eH2TrKsBlvSP5lOLwA3l7rItay18S4T039fvaTL8ZX5BC6gNMTMN9rlRJJcoxWmoSovkZT+s+DN3Gj1g/m0keMEj4zC/2Um1vitfAfTkro6DJErJJ/2c5rr9eeCios5yE8Jwfrx8zCo92JWQ9jjqNlHD8AufvYed7SzXKxWrZf4/NKqxF50qnDVRr4M5Xbv/p3y9KZabhZvjS8OiUjMlPDuXKNMZ4dg9MFyg2bhkiuZyQrEWrMEvqI5aB7j9D9EEm51xr5Or47Wt820qQ1H/WIP5H/XYjnOYA1C9gfxKKylSxIFfkmpYI/HcqhIIMP2GF/Yd7SDGRa7l4hLhypSRTvhNj2dnC+M6hQfY9liRXXRA7GAzRIul X-OriginatorOrg: renesas.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 16 Sep 2026 12:00:36.1672 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 44c836fe-696a-49a0-bd10-08df13ea1e56 X-MS-Exchange-CrossTenant-Id: 53d82571-da19-47e4-9cb4-625a166a4a2a X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=53d82571-da19-47e4-9cb4-625a166a4a2a;Ip=[8.62.32.50];Helo=[ejcrelay005p.adwin.renesas.com] X-MS-Exchange-CrossTenant-AuthSource: TY1PEPF0000BAD7.JPNP286.PROD.OUTLOOK.COM X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: OS9PR01MB17980 Content-Type: text/plain; charset="utf-8" Datasheet section 7.11.9.2 "Conversion Start Trigger" states that a conversion must only be started while no other conversion is in progress: "Before making the setting to start conversion by software or an ELC trigger, check that the CONV bit of the sensor status register is 0b." set_trips() starts a conversion at the end of the function and returns without waiting for it to finish. A get_temp() call arriving right after that starts a conversion while the CONV bit may still be set, violating the requirement above. Fix this by: - polling for CONV =3D=3D 0 in get_temp() before starting a conversion - not starting a conversion at the end of set_trips() anymore The conversion started at the end of set_trips() was supposed to check whether the thresholds have been passed, since the hw cannot raise interrupts on its own, but only when the temperature is read. However, the thermal core reads the temperature and computes the trip window from it just before calling into set_trips(), so reading the temperature again straight away is useless. Fixes: dc67521c20b7 ("thermal/drivers/renesas/rzg3e: Fix add thermal driver= for the Renesas RZ/G3E SoC") Signed-off-by: Ovidiu Panait --- drivers/thermal/renesas/rzg3e_thermal.c | 13 +++++++++++-- 1 file changed, 11 insertions(+), 2 deletions(-) diff --git a/drivers/thermal/renesas/rzg3e_thermal.c b/drivers/thermal/rene= sas/rzg3e_thermal.c index 45f67b2e1131..58fdcc66456a 100644 --- a/drivers/thermal/renesas/rzg3e_thermal.c +++ b/drivers/thermal/renesas/rzg3e_thermal.c @@ -225,6 +225,16 @@ static int rzg3e_thermal_get_temp(struct thermal_zone_= device *tz, int *temp) =20 guard(mutex)(&priv->lock); =20 + /* Make sure a previous conversion is not in progress */ + ret =3D readl_poll_timeout(priv->base + TSU_SSR, status, + !(status & TSU_SSR_CONV), + TSU_POLL_DELAY_US, + USEC_PER_MSEC); + if (ret) { + dev_err(priv->dev, "Timeout waiting for conversion\n"); + goto out; + } + /* Clear any previous conversion status */ writel(TSU_SICR_ADCLR, priv->base + TSU_SICR); =20 @@ -304,9 +314,8 @@ static int rzg3e_thermal_set_trips(struct thermal_zone_= device *tz, /* Enable comparison with "out of range" mode (CMPCOND=3D0) */ writel(TSU_CMSR_CMPEN, priv->base + TSU_CMSR); =20 - /* Unmask compare IRQ and start a conversion to evaluate window */ + /* Unmask compare IRQ */ writel(TSU_SIER_CMPIE, priv->base + TSU_SIER); - writel(TSU_STRGR_ADST, priv->base + TSU_STRGR); =20 pm_runtime_mark_last_busy(priv->dev); pm_runtime_put_autosuspend(priv->dev); --=20 2.34.1 From nobody Fri Sep 25 05:30:48 2026 Received: from TYVP286CU001.outbound.protection.outlook.com (mail-japaneastazon11011038.outbound.protection.outlook.com [52.101.125.38]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 82B1A233945; Wed, 16 Sep 2026 12:00:45 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=fail smtp.client-ip=52.101.125.38 ARC-Seal: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1789560051; cv=fail; b=SJwXE09JSPOfUHdD/FO95JE/EwVUkHFu5N//GA1CcaJnGyhLgvSE482F7EFKifqt3/2qUh8TzSKhwUBUAh6oYEajjLo8GQd555nF/DZpIP0onb3Ju8rKsxnxoKcUiCqmbF3Fol20LaNe21cQj5eReQpQRvtJZEDl5hcpFLEJWWU= ARC-Message-Signature: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1789560051; c=relaxed/simple; bh=399Ddsop68fdRiWUrEPQwgeDB9ohvg/K3bVxZwkSzd0=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=cFS4zZWNo/cFdlOsyOuaM4nNEcKeili7+d9HeW4S2odkmu6RIjl7TQynKwoKOSIOJqh/AXfHCZt2Dmfuw/MbrhNXrAl8jSPJwc25xgYAEYDlmXbLyncDAiap2p9V21rHh9HgCb1ZtiIKKx8zUtzOTu4V9emEm+vuG5l53cRzXWo= ARC-Authentication-Results: i=2; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=renesas.com; spf=pass smtp.mailfrom=renesas.com; dkim=pass (1024-bit key) header.d=renesas.com header.i=@renesas.com header.b=NMScqDqP; arc=fail smtp.client-ip=52.101.125.38 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=renesas.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=renesas.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=renesas.com header.i=@renesas.com header.b="NMScqDqP" ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=BNhef3jWC3tTJrOPeqop0rdcOInPg/sqH999OzG4wF0fGI2uxMujCHN3l2NazNDvrEUgwAOjXaKaxcHAMwcdppHZLFzhi7oejXsv1DtAtnYY+bICHjPVuabudjKU4Lk8WM48If59Z0qq7kc5VmmVxGIeC7kHFpoSLZQfaRK6vIxJVGuWWTL7kAY/tzPJHBDdVYXg683FhhBanKjbmXDvaRfXcnoVomXHic4Ztsn2aC4KP/FF+/RlD8GkrNl41BIVSFSozrb+DRbvaKDmYTq+ctxL/y0/5wuPFS8oT4zSiNoeJDtVat4TNRYmplchbxPzg4oxvBzEeyxAJt5JwivAPg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=OT+euU59/XOrSjauEIcYxozIYKvGt0YQYq4LGUf4eX4=; b=gqqv/W3GZdbpjCF22IEJ2Rf+I3o6K58EEQcJekb8310ZezmzayAEzlD2Dm00Gnt/4uFL4bcytHBWqBkW40H3V4sGr55DRdu2FSjHIeaC9eOWfhQueX7tnbZ6NI/vw9emEuAqSRD2yADBtzGjAw2a9EUvfN7kvb+o1VVUqBk6X/hCZjUAMtIqBtjSDR+nScqgskOFoljJEUFmSFn5uDvrl48t4Wu9ItAjlEsbTQNa5FNLDCajAXI1mfFgNx/eOYuo6s8dNNTufEeZZj8BIhQLXLBLKxvMYS+7O7Cretl5MELn3T3JLePxR8Cv4jqYORzjhTbQOt7L7ybG0ppzNL01aQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 8.62.32.50) smtp.rcpttodomain=arm.com smtp.mailfrom=renesas.com; dmarc=pass (p=none sp=none pct=100) action=none header.from=renesas.com; dkim=none (message not signed); arc=none (0) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=renesas.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=OT+euU59/XOrSjauEIcYxozIYKvGt0YQYq4LGUf4eX4=; b=NMScqDqPSv0IWWVmuRJQt4cqlWxsCl6MMVnxGro/XSx4K46GV/SgJa3fDiliaPg4ee8MoreNi8sKMX7DO96OEnpPR39kOMF+wpjzcl1o4Cu1MQFScUmLi2hcSboo0J/MLTL1ShdCymgwgLVpzYKvZOALsiVKVk7Uq4Fs1xaq7rk= Received: from TYCP301CA0001.JPNP301.PROD.OUTLOOK.COM (2603:1096:400:386::19) by OSCPR01MB15628.jpnprd01.prod.outlook.com (2603:1096:604:3b3::10) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.21.428.9; Wed, 16 Sep 2026 12:00:39 +0000 Received: from TY2PEPF00005622.JPNP286.PROD.OUTLOOK.COM (2603:1096:400:386:cafe::2) by TYCP301CA0001.outlook.office365.com (2603:1096:400:386::19) with Microsoft SMTP Server (version=TLS1_3, cipher=TLS_AES_256_GCM_SHA384) id 15.21.428.11 via Frontend Transport; Wed, 16 Sep 2026 12:00:39 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 8.62.32.50) smtp.mailfrom=renesas.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=renesas.com; Received-SPF: Pass (protection.outlook.com: domain of renesas.com designates 8.62.32.50 as permitted sender) receiver=protection.outlook.com; client-ip=8.62.32.50; helo=ejcrelay005p.adwin.renesas.com; pr=E Received: from ejcrelay005p.adwin.renesas.com (8.62.32.50) by TY2PEPF00005622.mail.protection.outlook.com (10.167.240.53) with Microsoft SMTP Server (version=TLS1_3, cipher=TLS_AES_256_GCM_SHA384) id 15.21.428.7 via Frontend Transport; Wed, 16 Sep 2026 12:00:39 +0000 Received: from vm01.adwin.renesas.com (DEU-5CG20946WF.adwin.renesas.com [10.226.92.205]) by ejcrelay005p.adwin.renesas.com (Postfix) with ESMTP id 84BAA3000441; Wed, 16 Sep 2026 21:00:36 +0900 (JST) From: Ovidiu Panait To: john.madieu.xa@bp.renesas.com, rafael@kernel.org, daniel.lezcano@kernel.org, rui.zhang@intel.com, lukasz.luba@arm.com, linux-kernel@vger.kernel.org Cc: linux-pm@vger.kernel.org, Ovidiu Panait Subject: [PATCH 4/5] thermal: renesas: rzg3e: Remove unneeded low/high check in set_trips() Date: Wed, 16 Sep 2026 12:00:02 +0000 Message-ID: <20260916120003.87018-5-ovidiu.panait.rb@renesas.com> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20260916120003.87018-1-ovidiu.panait.rb@renesas.com> References: <20260916120003.87018-1-ovidiu.panait.rb@renesas.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: TY2PEPF00005622:EE_|OSCPR01MB15628:EE_ X-MS-Office365-Filtering-Correlation-Id: 77f22844-0889-4574-10dc-08df13ea202b X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|82310400026|36860700016|1800799024|376014|23010399003|22082099003|18002099003|10067099003|11063799006|56012099006; X-Microsoft-Antispam-Message-Info: 5eN2AG0MlMj3SYZsFcXq8y1lAMGAXlv1RY+DRDgdBWtU2uklNPU+Y5K/JwvuO6Mkf2fJ5rqJQbeN+yerzUE4zoz+7PBNSPoGDtssZNsSoBtf7Vrx7drw7GID4yX+tTIsEu5eK275XyqZH0sDX2yM7s13VU1qYXn58B16t+cFqm4LC69oFiY/w9Hm3K6exyPMnclgaDxYYdsbWptX54C4uFKK0X0nv0Q7AnAKrZcEV0eMwLNAcjpMFXXnLhpmhMWQTgTDkWSKQSYAvPQP/O1FeRu/w3L6epo+8zeZYVG71wpwjFsDR8uZ2xmQ1W4YEQV0Sp+mfbo6mr/+pEH/6R9lKJSx+enePtWiTwJ2+0GsS4xH7tgTJSSbCMGYHifhmIEcIB2YK0pugEpuUCJEOYBX5J3tYT9UUw6GdExqti5rw4i6ukwW6pqxGpfQ0Sz4fkf7SSrEel1CM4gHZYTWyLBYUyJhMw6ua/Oej32bSHOWvA1Qr/3NwcLe8Lr6vVc93zlHmzDFa8x8OKEBA7TvtC0WE5TU49RyQTSR7iDVxPZKl/wXa05PzsS1Xels1nYfnoZiYuBwQ0E3bCoQ35MB+3OWYy5X9n4mInMZIsJbBASeczLm8IjK+HveCU9Sj0+ozb039Gvd1nSnW3yrZgXCFb2C9EmTCQWhxwTNhmcbs7+mHLBw9xuTITmmfWCL3YHRew4eqNV5jAr6z2mQ7tZHYJ7FQA== X-Forefront-Antispam-Report: CIP:8.62.32.50;CTRY:US;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:ejcrelay005p.adwin.renesas.com;PTR:InfoDomainNonexistent;CAT:NONE;SFS:(13230040)(82310400026)(36860700016)(1800799024)(376014)(23010399003)(22082099003)(18002099003)(10067099003)(11063799006)(56012099006);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: McQ37vyomoggmPySOTRnKr8TZxeNs2qM+4ulACRoHfJ8JQCOyJ2xGBcEICXX5FxTGsSM9QeKqzBdNIArheFfSF7YExCr27YWaDOagHyeczAMUSlQISD/6NZTxvUlGHH3/0SQRyZ5N8O7Did12e+qqk4YAhQZ3BNQMKpp0R086APEXIBx4R5/0Iw8DbD+6plUoljvOsbQHIDBMPjD1sHNdFbtkyZ3c3+G+BnDvuz6jCz+2wRSzkUlUZ8gMa2nKJMynLLKGgmhx5BP2q0V5fZiwkKBSq7ekUnOtbbndkcbAfdV2hFTT1b0uBiXENS2WLYkwVwgc/wJlI4+NY0CiLyyiNwv0IOOGegaAvsejnX0j6Z9RKnN3OJImnktjfRB+IqtBvxKUVyeEtGmJq0acMDkjlP73KlJJ3gWIHDatkOgh6d8NaWnIA1pY6VCCUcTF7mn X-OriginatorOrg: renesas.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 16 Sep 2026 12:00:39.2369 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 77f22844-0889-4574-10dc-08df13ea202b X-MS-Exchange-CrossTenant-Id: 53d82571-da19-47e4-9cb4-625a166a4a2a X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=53d82571-da19-47e4-9cb4-625a166a4a2a;Ip=[8.62.32.50];Helo=[ejcrelay005p.adwin.renesas.com] X-MS-Exchange-CrossTenant-AuthSource: TY2PEPF00005622.JPNP286.PROD.OUTLOOK.COM X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: OSCPR01MB15628 Content-Type: text/plain; charset="utf-8" The hardware manual doesn't specify that the trip settings must be strictly low < high, just that when the CMPCOND bit is 0, an interrupt will be raised when the acquired temperature data is > ULIM or < LLIM. Also, the thermal core already guarantees low < high. Remove the redundant check. Signed-off-by: Ovidiu Panait --- drivers/thermal/renesas/rzg3e_thermal.c | 4 ---- 1 file changed, 4 deletions(-) diff --git a/drivers/thermal/renesas/rzg3e_thermal.c b/drivers/thermal/rene= sas/rzg3e_thermal.c index 58fdcc66456a..ffe2b8725031 100644 --- a/drivers/thermal/renesas/rzg3e_thermal.c +++ b/drivers/thermal/renesas/rzg3e_thermal.c @@ -275,10 +275,6 @@ static int rzg3e_thermal_set_trips(struct thermal_zone= _device *tz, u32 val; int ret; =20 - /* Hardware requires low < high */ - if (low >=3D high) - return -EINVAL; - ret =3D pm_runtime_resume_and_get(priv->dev); if (ret < 0) return ret; --=20 2.34.1 From nobody Fri Sep 25 05:30:48 2026 Received: from TY3P286CU002.outbound.protection.outlook.com (mail-japaneastazon11010018.outbound.protection.outlook.com [52.101.229.18]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id CFFBA3BCD0B; Wed, 16 Sep 2026 12:00:50 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=fail smtp.client-ip=52.101.229.18 ARC-Seal: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1789560059; cv=fail; b=gA30dwAnevOrFLsLwfF7zaD5OPR1QBZK8YmlTDZQAsPPAlBrpB3FX8zFTA/gfbf6hwcU1kfDe/UYV107oshAA88XjNdw0pCml8o4T7WF3kyFtln/In4ntHI27gMnwVb4dpDWtO9kkxaFYTO+KkFTWPBeo70i7EtzJKr4MsWaRX4= ARC-Message-Signature: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1789560059; c=relaxed/simple; bh=PwI2IGpHvsqeDpfUb/pz7MQGnr1C9zHaYVwKVMGelkU=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=MBHgNxeLG2mM2AvtuIbfARzf1CwGAaAdtXOCSqVE0zOTi1Q1FvY6K9TkJW3QAmruRYDFt1edQgbEsLoQ3ZMG1dYY0BxGKB8rUb98TiO85k6JL9Yfc6XsuHAP3xa14a02NphVacReWbXCtwcMQMgCwEx+Ux67Bmwl/vN2MfB8UxY= ARC-Authentication-Results: i=2; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=renesas.com; spf=pass smtp.mailfrom=renesas.com; dkim=pass (1024-bit key) header.d=renesas.com header.i=@renesas.com header.b=LczT4ih+; arc=fail smtp.client-ip=52.101.229.18 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=renesas.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=renesas.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=renesas.com header.i=@renesas.com header.b="LczT4ih+" ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=XNO0kF53p+9kvtoAfSK/2PUx3MLIQJUzRhPpOfAQE15r92V2qHdSZRj+6r7y4kazW28h2fQ4wm7uEtXoKXatw2MoI9HjYSzOMivHAPWyQf86dzOSBxjTTflp3hz9kzHArOh8rp3V85EXhO3Eq8UUfhXN5C3c0AV5Q3AS2zLMyIxr/wko3mXNlI3Gi359P5fqUd/uMeq+cy65fGjIlz+iZIQGpdX5FhD5Fu5Nw+e5ot7viyrv29YaPbBiHbVh9w3uX4qjSflCSGUsU8dhEWlO9J/b1NwKbIOABXZiytWaZvbV1FVNDN8envVYN1Er5VUEAvuTHYNVz411+qTSjd2nZA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=oeudhQGTK91LSTKQCW8CsrtjVUu2nZtKHzSaWIk77a8=; b=snsDSC4DkU/G4o6Lvi9r9un0EDh60tIbdjtmmtI3d+61Jt+YaCPijn5PIEXWlm3+dl+FCdP1FiDwlG7VNfW8g2Qyn83ywIYQysO9/T4dcO+GMLgdK5hCFAHGD9IQYJxPuSzJG5mSHQF2DD8SnRxgBBLkiaWS2oYBM6IVDZ4dq1j2ofQ8YCJdV8LJ8oyMlmtn/TPBKxtU5Bu81DPep+c3NBmkclpv3P+/U9i1YK7C0rKjn4wG536GjDgdvi+WJ/QK9JvNSYWVtz32mpHarz3Z/JVkxcW2mIGmjsVEWRifiYASrOhjB4rwQj5WaP7pwbWs0aWWl/GTqxCmdoOpONotwg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 8.62.32.50) smtp.rcpttodomain=arm.com smtp.mailfrom=renesas.com; dmarc=pass (p=none sp=none pct=100) action=none header.from=renesas.com; dkim=none (message not signed); arc=none (0) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=renesas.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=oeudhQGTK91LSTKQCW8CsrtjVUu2nZtKHzSaWIk77a8=; b=LczT4ih+3euTzhyptX/VSUAROo6W5UBdgtkAsXFZD7N5UwzQF8JDXKNzmYx5pjEem2lxQ8nDeYTspg4LonvJowl6DNzCMCbB7tQFIy36PJzkWUjstmMHQRmCPlZapAiba+dPYG46iUrVUkwCnIgWwlo9eY0hg+AKlsHLTpm5Yzs= Received: from TYCP301CA0007.JPNP301.PROD.OUTLOOK.COM (2603:1096:400:386::18) by TY7PR01MB13704.jpnprd01.prod.outlook.com (2603:1096:405:1ef::7) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.21.428.11; Wed, 16 Sep 2026 12:00:42 +0000 Received: from TY2PEPF00005622.JPNP286.PROD.OUTLOOK.COM (2603:1096:400:386:cafe::91) by TYCP301CA0007.outlook.office365.com (2603:1096:400:386::18) with Microsoft SMTP Server (version=TLS1_3, cipher=TLS_AES_256_GCM_SHA384) id 15.21.428.11 via Frontend Transport; Wed, 16 Sep 2026 12:00:42 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 8.62.32.50) smtp.mailfrom=renesas.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=renesas.com; Received-SPF: Pass (protection.outlook.com: domain of renesas.com designates 8.62.32.50 as permitted sender) receiver=protection.outlook.com; client-ip=8.62.32.50; helo=ejcrelay005p.adwin.renesas.com; pr=E Received: from ejcrelay005p.adwin.renesas.com (8.62.32.50) by TY2PEPF00005622.mail.protection.outlook.com (10.167.240.53) with Microsoft SMTP Server (version=TLS1_3, cipher=TLS_AES_256_GCM_SHA384) id 15.21.428.7 via Frontend Transport; Wed, 16 Sep 2026 12:00:42 +0000 Received: from vm01.adwin.renesas.com (DEU-5CG20946WF.adwin.renesas.com [10.226.92.205]) by ejcrelay005p.adwin.renesas.com (Postfix) with ESMTP id AD9A93000441; Wed, 16 Sep 2026 21:00:39 +0900 (JST) From: Ovidiu Panait To: john.madieu.xa@bp.renesas.com, rafael@kernel.org, daniel.lezcano@kernel.org, rui.zhang@intel.com, lukasz.luba@arm.com, linux-kernel@vger.kernel.org Cc: linux-pm@vger.kernel.org, Ovidiu Panait Subject: [PATCH 5/5] thermal: renesas: rzg3e: Remove redundant pm_runtime_mark_last_busy() calls Date: Wed, 16 Sep 2026 12:00:03 +0000 Message-ID: <20260916120003.87018-6-ovidiu.panait.rb@renesas.com> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20260916120003.87018-1-ovidiu.panait.rb@renesas.com> References: <20260916120003.87018-1-ovidiu.panait.rb@renesas.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: TY2PEPF00005622:EE_|TY7PR01MB13704:EE_ X-MS-Office365-Filtering-Correlation-Id: 48f53048-3939-4bc5-3f79-08df13ea220e X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|1800799024|82310400026|23010399003|376014|36860700016|10067099003|11063799006|56012099006|18002099003|22082099003; X-Microsoft-Antispam-Message-Info: KEFvHES/S6aWNmVJ8n3d5lUcLtExIZZ4omc8rMafrq8uqXV2fHFf6nyOZu/97M4uccMJDOmg+xBGQGkN66Z6cWwf4NQ8zQ+bsUBOubKHZYIuqH1fRT9GCZYNBNxYTk4cQXMKh2QEPaBowHk9N08IkfFczaymeceGKhSZVDMsp7m3Lxfn4W4RQtntI4CeCdSJGO4aVK0AB9k2n2bBJllVwkV254W5sei8MEWpVxds8itu3/QF4dA6P5UgND0y6yXZZ6b5rUdv39yYFejSeBNjUOWze9gjO22jc5D1p0gXrG+YgkEZCy+VAnBIGjCoesW10jgP9v/yt7eeFwLORaZUXbDkESgMEq6i3+DEhLFEYtBHTNYtuY+xbfd50jw1XGuVBMepTgq7ohyPXG9gB6PXmdwdUQOKsdtft4SpoO8ByazXTy8ot+z+AY8HXYHC++HJcv5YY4z+fkOIjZji6ilXoRfrdWtzaNJqNo/yppO2xMzyyT7gaLmcWqjKxGeaQx0p7ZzrXrDLWFBPWsId4kFPb8zF9wdEb2UFIK1EnnMvLiWLHx5p/imwNsUV12Wst7LB+mgHu0csAU2oXVR5y9KeceB3/7eGayGeo6mZR1hGEu/6sndnvk2G4RO745tFUTYhXPRkSRkLioW78hLFwEF+GzEv4rqbyAZE2bG9wrCKNP/KBZLnaD5BWlcBcNaOxplaM58kbgaI8WE8YmaG3aGUFg== X-Forefront-Antispam-Report: CIP:8.62.32.50;CTRY:US;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:ejcrelay005p.adwin.renesas.com;PTR:InfoDomainNonexistent;CAT:NONE;SFS:(13230040)(1800799024)(82310400026)(23010399003)(376014)(36860700016)(10067099003)(11063799006)(56012099006)(18002099003)(22082099003);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: qmOMPkbW1gcZW8t3t0+pDwcgpFugZQ92IbHx6IexXce0DCkvapro/ysBaexLyVZlNryZ7gSsxCsx7SpTupNg5cUXd+Pq81AZ21QywiZjTud1+oAVSBBmwQT5cF0kK/8i4PLEnAhzlYt8ZcUo7gXZJqjTLFBds3cljh6PySgqYfA/rXT5bZC6rlD3BawfoKJ++esR7GGBqIHd99PifoEeDO9a9rhQTUW2IKiA4wNMlSkHg2KXl1MSCL11SWKte3WSi+8f4S2PZv/0b9ZXvLo2/7XHuNIdDvs0tWp2WcN2+5bWz3lPot/Tq41deB5eaeYKXSfGI0bAEOs+3sr6a7hPPRgEQiVa2SSmyJbpqds3D8x3wl3dGf/aTjE/goykzetBlh5bHlnrdZCJMda709JcbJGTZ/nLx3TNrPXq9Oauwfw3EsHie0yjWAnszw/tYYB6 X-OriginatorOrg: renesas.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 16 Sep 2026 12:00:42.4044 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 48f53048-3939-4bc5-3f79-08df13ea220e X-MS-Exchange-CrossTenant-Id: 53d82571-da19-47e4-9cb4-625a166a4a2a X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=53d82571-da19-47e4-9cb4-625a166a4a2a;Ip=[8.62.32.50];Helo=[ejcrelay005p.adwin.renesas.com] X-MS-Exchange-CrossTenant-AuthSource: TY2PEPF00005622.JPNP286.PROD.OUTLOOK.COM X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: TY7PR01MB13704 Content-Type: text/plain; charset="utf-8" pm_runtime_put_autosuspend() already calls pm_runtime_mark_last_busy() internally, so the explicit calls are not needed. Remove them. Signed-off-by: Ovidiu Panait --- drivers/thermal/renesas/rzg3e_thermal.c | 3 --- 1 file changed, 3 deletions(-) diff --git a/drivers/thermal/renesas/rzg3e_thermal.c b/drivers/thermal/rene= sas/rzg3e_thermal.c index ffe2b8725031..a1ceff79e83e 100644 --- a/drivers/thermal/renesas/rzg3e_thermal.c +++ b/drivers/thermal/renesas/rzg3e_thermal.c @@ -262,7 +262,6 @@ static int rzg3e_thermal_get_temp(struct thermal_zone_d= evice *tz, int *temp) *temp, *temp / 1000, abs(*temp) % 1000, code); =20 out: - pm_runtime_mark_last_busy(priv->dev); pm_runtime_put_autosuspend(priv->dev); return ret; } @@ -313,7 +312,6 @@ static int rzg3e_thermal_set_trips(struct thermal_zone_= device *tz, /* Unmask compare IRQ */ writel(TSU_SIER_CMPIE, priv->base + TSU_SIER); =20 - pm_runtime_mark_last_busy(priv->dev); pm_runtime_put_autosuspend(priv->dev); =20 return 0; @@ -485,7 +483,6 @@ static int rzg3e_thermal_probe(struct platform_device *= pdev) if (ret) dev_warn(dev, "Failed to add hwmon sysfs attributes\n"); =20 - pm_runtime_mark_last_busy(dev); pm_runtime_put_autosuspend(dev); =20 dev_info(dev, "RZ/G3E thermal sensor registered\n"); --=20 2.34.1