From nobody Fri Sep 25 06:01:07 2026 Received: from cstnet.cn (smtp81.cstnet.cn [159.226.251.81]) (using TLSv1.2 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id A5EE14457B6; Wed, 16 Sep 2026 07:28:15 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=159.226.251.81 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1789543706; cv=none; b=VQs7bbZ4wyKSegb0EZKV6b8chmeOVG6sUFKIO+gQHlTd37kNWTpw3q/2HkZu54BprtgwbGYs9L3EKMygy6jeORVHvJ+cPrFLK6lArizabYHU0aQ+PLk62Z8I54beUEBNapw4F5nFttosCrEeKRlEgV3uruwmgoadE/AAKXFQHps= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1789543706; c=relaxed/simple; bh=d4DQPthliOWxbh+4rDlS03mFq/hQT2ZPq3DEPffyIhs=; h=From:To:Cc:Subject:Date:Message-Id:MIME-Version; b=oO/JUVKTcKIGhzP9IOU+DgRhyRLqo+7DhHgA+YwpUbEKnEQPzsqO8wK/L2Qad3/VTWJbBic1+NJ1vRYEThLUIVUFZ10utAoIlzq98oZmijfGsWzEbFjMeNVljzvI7dM4Qd6MAi1eaYegeDK2kMFhcmHlTEhPkcc0spW/xG9r4pw= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=iscas.ac.cn; spf=pass smtp.mailfrom=iscas.ac.cn; arc=none smtp.client-ip=159.226.251.81 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=iscas.ac.cn Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=iscas.ac.cn Received: from dfae2b116770.home.arpa (unknown [36.110.52.2]) by APP-03 (Coremail) with SMTP id rQCowABnaTcFRapq9SDfBw--.14437S2; Wed, 16 Sep 2026 15:28:05 +0800 (CST) From: Wentao Liang To: broonie@kernel.org Cc: ckeepax@opensource.cirrus.com, krzk@kernel.org, lgirdwood@gmail.com, linux-kernel@vger.kernel.org, linux-sound@vger.kernel.org, patches@opensource.cirrus.com, perex@perex.cz, s.nawrocki@samsung.com, tiwai@suse.com, Wentao Liang , stable@vger.kernel.org Subject: [PATCH] ASoC: wm8994: Fix runtime PM imbalance in wm8994_component_probe() Date: Wed, 16 Sep 2026 07:27:37 +0000 Message-Id: <20260916072737.1970990-1-vulab@iscas.ac.cn> X-Mailer: git-send-email 2.34.1 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-CM-TRANSID: rQCowABnaTcFRapq9SDfBw--.14437S2 X-Coremail-Antispam: 1UD129KBjvJXoW7Cw1DCrWxXw1DZryUJFWUArb_yoW8Xw4kpr 4vqFZ5KF95uF4avryjyw4kZFyIgFWUAan8G3y7Ka4Ivr1ayas2gryUArWFqFWUGrZ5WFnx XFy2qay8AF1rGaUanT9S1TB71UUUUU7qnTZGkaVYY2UrUUUUjbIjqfuFe4nvWSU5nxnvy2 9KBjDU0xBIdaVrnRJUUU9I14x267AKxVW8JVW5JwAFc2x0x2IEx4CE42xK8VAvwI8IcIk0 rVWrJVCq3wAFIxvE14AKwVWUJVWUGwA2ocxC64kIII0Yj41l84x0c7CEw4AK67xGY2AK02 1l84ACjcxK6xIIjxv20xvE14v26F1j6w1UM28EF7xvwVC0I7IYx2IY6xkF7I0E14v26r4U JVWxJr1l84ACjcxK6I8E87Iv67AKxVW0oVCq3wA2z4x0Y4vEx4A2jsIEc7CjxVAFwI0_Gc CE3s1le2I262IYc4CY6c8Ij28IcVAaY2xG8wAqx4xG64xvF2IEw4CE5I8CrVC2j2WlYx0E 2Ix0cI8IcVAFwI0_Jw0_WrylYx0Ex4A2jsIE14v26F4j6r4UJwAm72CE4IkC6x0Yz7v_Jr 0_Gr1lF7xvr2IYc2Ij64vIr41lF7I21c0EjII2zVCS5cI20VAGYxC7M4IIrI8v6xkF7I0E 8cxan2IY04v7MxkF7I0En4kS14v26r1q6r43MxAIw28IcxkI7VAKI48JMxC20s026xCaFV Cjc4AY6r1j6r4UMI8I3I0E5I8CrVAFwI0_Jr0_Jr4lx2IqxVCjr7xvwVAFwI0_JrI_JrWl x4CE17CEb7AF67AKxVWUtVW8ZwCIc40Y0x0EwIxGrwCI42IY6xIIjxv20xvE14v26r1I6r 4UMIIF0xvE2Ix0cI8IcVCY1x0267AKxVWxJVW8Jr1lIxAIcVCF04k26cxKx2IYs7xG6r1j 6r1xMIIF0xvEx4A2jsIE14v26r4j6F4UMIIF0xvEx4A2jsIEc7CjxVAFwI0_Gr1j6F4UJb IYCTnIWIevJa73UjIFyTuYvjfUFhL0UUUUU X-CM-SenderInfo: pyxotu46lvutnvoduhdfq/1tbiDAMMA2qqP7kWdQAAsl Content-Type: text/plain; charset="utf-8" In wm8994_component_probe(), pm_runtime_get_sync() is invoked before reading the GPIO configuration registers. If either regmap_read() fails, the function jumps to err_irq without calling pm_runtime_put(), leaving the runtime PM usage count incremented and causing a leak. Add pm_runtime_put() on both GPIO read failure paths before jumping to err_irq. Fixes: f5a2cda4f1db ("ASoC: wm8994: Ensure the device is resumed in wm89xx_= mic_detect functions") Cc: stable@vger.kernel.org Signed-off-by: Wentao Liang Reviewed-by: Charles Keepax --- sound/soc/codecs/wm8994.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/sound/soc/codecs/wm8994.c b/sound/soc/codecs/wm8994.c index 1d64c7c42ed1..7a790f5e33f1 100644 --- a/sound/soc/codecs/wm8994.c +++ b/sound/soc/codecs/wm8994.c @@ -4354,6 +4354,7 @@ static int wm8994_component_probe(struct snd_soc_comp= onent *component) ret =3D regmap_read(control->regmap, WM8994_GPIO_1, ®); if (ret < 0) { dev_err(component->dev, "Failed to read GPIO1 state: %d\n", ret); + pm_runtime_put(component->dev); goto err_irq; } if ((reg & WM8994_GPN_FN_MASK) !=3D WM8994_GP_FN_PIN_SPECIFIC) { @@ -4366,6 +4367,7 @@ static int wm8994_component_probe(struct snd_soc_comp= onent *component) ret =3D regmap_read(control->regmap, WM8994_GPIO_6, ®); if (ret < 0) { dev_err(component->dev, "Failed to read GPIO6 state: %d\n", ret); + pm_runtime_put(component->dev); goto err_irq; } if ((reg & WM8994_GPN_FN_MASK) !=3D WM8994_GP_FN_PIN_SPECIFIC) { --=20 2.34.1