From nobody Fri Sep 25 06:00:46 2026 Received: from mail-pj2-f17.google.com (mail-pj2-f17.google.com [74.125.227.145]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 0F820352021 for ; Wed, 16 Sep 2026 05:16:30 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=74.125.227.145 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1789535794; cv=none; b=UUeUQ1qzjGcKWDxYKo+hRHaDDmv9TI1NCHYMqvOIimyySUnLSUXhVh8CiO1zFxJfTBsNhHj2irXpoNDHePw8bui4cJIVShvLYEASsIOSDOp+gnu8ytUrtZ/ZTU9DYCqQ2k6AAjP8tku7kPOM2d95KkjyT5DmHo+Bix8ZSKtjmys= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1789535794; c=relaxed/simple; bh=uwmZUWNFubCxa2vYuasTSUVwkwVzc+oCbHAoSLSNBaY=; h=From:To:Cc:Subject:Date:Message-ID:MIME-Version; b=OnGC4GrnmB7238jQ/KBHDToTceNRbwE+EjT5k8iMZF0OVkLQrMuArFffSOP0vWQcZiUQ9g75XWnd/0pd+mln58//VGCgO+E3oTI4nt4ksuZ1qactchF1tCzItE++npLnkP9Me+dFskvA+gpQs4FerRmiJClWUwhB39dnCaO0yTA= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=aQHWVY/A; arc=none smtp.client-ip=74.125.227.145 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="aQHWVY/A" Received: by mail-pj2-f17.google.com with SMTP id d9443c01a7336-2db1ca06a25so3552695ad.2 for ; Tue, 15 Sep 2026 22:16:30 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1789535789; x=1790140589; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to:content-type; bh=WVOHsi5wK8IUeKTXKaFBxVem+p3DhnYKQL8R4DBSpiI=; b=aQHWVY/ACJkqGvCQKrgzOSX/ich3frOvdLYx4A87x/LjEbpc2KlCkZ/qN5+u+I8mlI RoHDwxFu/xVIRxILPnctlFD4hpawi3Z7K0TLPk06w9oU89xNA5zOqPoQ7WFXqOUaH9VK /JQGH60jgVXujug0Sk/Xo5on/scCn9nlCbuOrI0spSfUNrw1SLa99OJwRrMBdQ2u+19r zNBy++L868jJobrNvE5R2/YVq6UNSoV5Dd9EPfA207n/Qm+n4U2NMAn278WB6HQN6ctX McWsvtQYRI4aBKghcvjtW7H5SBLd/1pzNaqfkq/KXOHk2tVdcHLShGzBVfiHf6kz0Z8r l1yA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20260707; t=1789535789; x=1790140589; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to:content-type; bh=WVOHsi5wK8IUeKTXKaFBxVem+p3DhnYKQL8R4DBSpiI=; b=TjacnImnzyxL7rHKJCyVnnjVJqKIkOOOY+m5OHZ0EpMPXKeGuVAjDY5Fe2Q79CuIDO bfxHsrY3VKwWRRhK3myTOP6VFh9KB+eilJPxSoIEyke8aafrTk2DmliVzUS2wtrNL4wq plf8HZNR63oIW9T39/5T68U5vvAHe5clDkYaIWCAjHXrTpaTzz3egjB/4qpBKsc3DPxH LfJjnyTPaV2/qGPsY/U44gaMc5Vjw7vWkGfc8f7Pqi4xkpFsi0rX6f3lu7JwoJlu8yuq oql4AlnDLisxUR+KNHnUSEWMaBeFnPce5CdhNyPgQQBBoOCRsOZej4lvIE2gEqREY5jD QaRg== X-Forwarded-Encrypted: i=1; AKwUvBzPXW3ejc1AaHICn5xb1sQPGsJ0ytjvZVipi7M47AmoNOBWjc8WJssrOJ9HF3MMaSBuasZJnQ92Jc1HTYM=@vger.kernel.org X-Gm-Message-State: AFuF++nUo/uUbhTkUn7bVD68hDLMEGFti3MsWBOkzhlMi+aoV2He4JWJ 1urMFq+mBtgkAsILR/kPjR9fSwpXC3oTKmhWLEF+W7U3fK3zkhECD981 X-Gm-Gg: AYBFou3IXpVYQHLSjkTWbQhdJ1YJ1G4fSGQ2EYJdEciBZJngLMuSsPkPZ5WzPCGaz/c KYljMMJ8C9WEJP6yFZNtD8R9tfQ+ZzXSFkqcRVw5Pww/j1Ny2iqQvxhYQ6TQMWQ3/u6hl5Vbt0i NvhuvfXju7gZeaYl9k7+tWK9AeUFN9/OdWr+Y6oTYny+8qVHOTW3CaECvIxssLURqOfziFpUZxD +N4CpmLOaJ7CtHAhwst4P6Raswyo5XFrLt7Q4TkO35jrNO/Evz/s/te8hNZ1Z9snSa0bv+Upoo7 IIRKymdz+6WTAm0Snrsfvcv2hcppOydkqvU1ALBY7CTH8tGkmy/erXiXRPd9Tu5CdIBNB19+DOk 7V1d+3IGAkKns9v3QChwk743vkUSxne1wsz1c+y7PoUHnBUOj/O3gILwZwKx99tB4UGlpVV3XwC IXRyPaw32xfSv0A1YO96hKs8oG05hz/UJKRct/FgpsOK0P2KOmDIj7WlzC7K/QO20fU7uq X-Received: by 2002:a17:90b:2645:b0:398:9be9:ab92 with SMTP id 98e67ed59e1d1-39e1e5777famr3113557a91.23.1789535788375; Tue, 15 Sep 2026 22:16:28 -0700 (PDT) Received: from lgs.. ([101.76.249.46]) by smtp.gmail.com with ESMTPSA id 98e67ed59e1d1-39e1bb22ee5sm2428218a91.5.2026.09.15.22.16.23 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 15 Sep 2026 22:16:27 -0700 (PDT) From: Guangshuo Li To: Felix Fietkau , Lorenzo Bianconi , Andrew Lunn , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Matthias Brugger , AngeloGioacchino Del Regno , netdev@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-mediatek@lists.infradead.org Cc: Guangshuo Li , stable@vger.kernel.org Subject: [PATCH] net: mediatek: fix PPE resource leak on remove Date: Wed, 16 Sep 2026 13:16:18 +0800 Message-ID: <20260916051618.2904439-1-lgs201920130244@gmail.com> X-Mailer: git-send-email 2.43.0 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" mtk_ppe_init() initializes the l2_flows rhashtable for each PPE instance. The probe failure path releases these resources with mtk_ppe_deinit(). However, after a successful probe, mtk_remove() tears down the network devices without calling mtk_ppe_deinit(), leaving the PPE rhashtable resources allocated. Call mtk_ppe_deinit() during device removal before freeing the network devices. This issue was found by manual code inspection. Fixes: 33fc42de3327 ("net: ethernet: mtk_eth_soc: support creating mac addr= ess based offload entries") Cc: stable@vger.kernel.org Signed-off-by: Guangshuo Li Acked-by: Lorenzo Bianconi --- drivers/net/ethernet/mediatek/mtk_eth_soc.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/net/ethernet/mediatek/mtk_eth_soc.c b/drivers/net/ethe= rnet/mediatek/mtk_eth_soc.c index be3bd025c41a..04d0a1eec4cf 100644 --- a/drivers/net/ethernet/mediatek/mtk_eth_soc.c +++ b/drivers/net/ethernet/mediatek/mtk_eth_soc.c @@ -5394,6 +5394,7 @@ static void mtk_remove(struct platform_device *pdev) =20 netif_napi_del(ð->tx_napi); netif_napi_del(ð->rx_napi); + mtk_ppe_deinit(eth); mtk_cleanup(eth); free_netdev(eth->dummy_dev); mtk_mdio_cleanup(eth); --=20 2.43.0