From nobody Fri Sep 25 06:02:54 2026 Received: from mail-pz2-f41.google.com (mail-pz2-f41.google.com [74.125.228.41]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id C921A3B8D4F for ; Wed, 16 Sep 2026 05:00:57 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=74.125.228.41 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1789534859; cv=none; b=vBh7exaAcmtyIuH1hy5jwVuO93y3qQ6/sj7h9kXjViArpBTdDrX91glt20Y81xGFKIAxc3kSmBD0jhbexbroRpOf0JWeLs/f5oAv5ZfeS4VeFNEudX28j79YOF4k9KlQmmhV8i+fHnDD/S+Osn7f9Lo68HlR31CK1BDKS8YZoSQ= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1789534859; c=relaxed/simple; bh=FCuMskY3XvDPPwvJIw9JLjawiUu1vTBO2FumCelMA38=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=JwONfg2XcA5E+uHWI2neAapg5oFVDzgYV3Ds5RSywzf//yt5CTtoWfve/rlG2Ius7KnTKdIc9PeCBv0L5+vorCnmVhjjxFVaAElRfqfv8vkMkTokHfu3eKT0nuL07XAyqbcGsrI0AZ9wF7m0ZTbkpyb9BPeIKpdflTaEuTSsZF4= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=oZIW2jpK; arc=none smtp.client-ip=74.125.228.41 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="oZIW2jpK" Received: by mail-pz2-f41.google.com with SMTP id d2e1a72fcca58-85469f20513so403510b3a.0 for ; Tue, 15 Sep 2026 22:00:57 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1789534857; x=1790139657; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to:content-type; bh=Pql7MOYwKZW3o6yhPXEQuRrMz6C0eX70Gy/W9byUq7w=; b=oZIW2jpKTiXfIG0Phr/48KpCEgr3jlisDWvN4oSWk6eAPl+jwa93jCw8lf9tYa5Hhc 0wmuQqtL9FsKj8ahd3QaH+dItoSPUk1QMNMimaDOdRVvpKr4+HqNitzg2wiKgpNa/c3j rEFCs+Izixw2IQM9kyJk7DcdrTqw37bGAL1FBpfPaEm9LBZqEDYq+6WOMrgZFJkOBrev jfsaMsSayyuQZOpIO1hAqfVdm2dsVd561yjpQvY/YcO31PyecVhWJ1tamDVE+iQrW4mE qFKzeOAbLLwSkBWmd8eKcnIK7Fv9yHQQfsxc59l/Zr2HAmurv61VEPFnRpFmr96Nn2US GB5w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20260707; t=1789534857; x=1790139657; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to:content-type; bh=Pql7MOYwKZW3o6yhPXEQuRrMz6C0eX70Gy/W9byUq7w=; b=VeNnB2JQFa+qmz6nHxBzdI3LBK7Hx5JiLoyT/sWvTZkPr+1gDkDpd1wDVHdW6MMP3G X9VEkuPX97PVws7jvghoC5IQdmN5DDBYcObGbc9i6oNmi2ybYM0wrt1xM161yAMym+ib NoEIqleWvveW2GZj0o2DZdAI6H/Lg9q6uoC8lR1n/JK4DButl81BvSRxX91faSpaVj4L t5iWGMd7sjF+kWmRKMTQH1R3YsLYW0VVMpqi++ieZUjKugczGLA91QvZ9u0f/ELODQXb Ve6TIi4rW9FQIG3RyJALCY451yVjd2BdeAGubV9IkPCKWZ6i22VQZ3Szz8q/iftO9l1y 2EFg== X-Forwarded-Encrypted: i=1; AKwUvBxC+wxqTEPI0FrvQXYbIqgL9DQ73/6lHHnpeHnlcxjSWtvHskAighOskxu+AuEak7O9Q+z1SGc/yiJbLP4=@vger.kernel.org X-Gm-Message-State: AFuF++mWENSS6K24yOU0HYBxM75evDXpAjglRUQ6bfppzQb4u5j9oW/Q b5DXNUMmzAaEnp1bLkzh9r0JsD7Rh41p4XAsxPd49VyZ/vyGFqM1sYCp X-Gm-Gg: AYBFou2ou4LSVWIobo2LIXsvMa7s3SEY2b6x5vQrKU2HjWPqEsJOJ6TGlpdtwtSXbcB tHICxvavXXH0IHci5vO5TS2gZo1FxfuMOUwsXjBokiSzqJ8SzFs7+cca50M3Ov/EIxP3ksFrFoQ n0cbgsdXBJH2C1xWkFF9jFmfq7dtCqyNWFsIC2/jRXfqT+57KzeGvYVXleky/8zG4vS6VPRXZLb zxxWLmMvSXHCWGS5hWzGi9Wq2yIYNOmNirrJpkbeSP4Sk7+kxZvY1Ws2GI1KbBa3lSZPFpNsSSq oCZ2QzWtbACVEptvojukAVUR3+SAgxMpKv1Q92EdFRDjCDZW64EFEq3tp1Qa/+o/mX2Ciq8qfgA 8eHcVX7YnlkeKRY1bI8taiafUyphn7x1q0NoZ2uzJZd1T/fUZ/JakFeKahs6y9OBv5KIC/YWo7z 5o6MXleWy1WX2rKNMWBIXCUPvioL7p3z8LvY8JJQo1F/NhO4zz9tZSaPsTEt+6V09Cx9XI89sNd 27kBCZ6h4lpnPyPiT+PJnxm+SG/47SJuflEQU5NdY3fPvTE6aNwDfyS/sOnd95RmW1espGiyQAw 5QHOl1UuR8X6NM0= X-Received: by 2002:a05:6a00:b8a:b0:86c:f33d:e3b4 with SMTP id d2e1a72fcca58-872378b6fc0mr2276748b3a.8.1789534842957; Tue, 15 Sep 2026 22:00:42 -0700 (PDT) Received: from phuc-desktop.. ([183.91.15.56]) by smtp.gmail.com with ESMTPSA id 41be03b00d2f7-cc50abb1776sm850589a12.27.2026.09.15.22.00.39 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 15 Sep 2026 22:00:42 -0700 (PDT) From: phucduc.bui@gmail.com To: Mark Brown , AngeloGioacchino Del Regno Cc: Liam Girdwood , Matthias Brugger , Jaroslav Kysela , Takashi Iwai , Cezary Rojewski , Cyril Chao , Kuninori Morimoto , Dan Carpenter , cassiogabrielcontato@gmail.com, linux-sound@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-mediatek@lists.infradead.org, linux-kernel@vger.kernel.org, bui duc phuc Subject: [PATCH v3 01/12] ASoC: mediatek: mt8189: Propagate APLL enable errors Date: Wed, 16 Sep 2026 12:00:08 +0700 Message-ID: <20260916050020.14575-2-phucduc.bui@gmail.com> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20260916050020.14575-1-phucduc.bui@gmail.com> References: <20260916050020.14575-1-phucduc.bui@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" From: bui duc phuc mt8189_apll1_enable() and mt8189_apll2_enable() currently ignore errors from regmap_update_bits() and do not clean up resources when clock enable operations fail. Propagate these errors and roll back the clocks and tuner state on errors. Fixes: dc637ffeed6c ("ASoC: mediatek: mt8189: support audio clock control") Signed-off-by: bui duc phuc Reviewed-by: AngeloGioacchino Del Regno --- Changes in v2: - Update the names of the goto labels. sound/soc/mediatek/mt8189/mt8189-afe-clk.c | 78 ++++++++++++++++------ 1 file changed, 56 insertions(+), 22 deletions(-) diff --git a/sound/soc/mediatek/mt8189/mt8189-afe-clk.c b/sound/soc/mediate= k/mt8189/mt8189-afe-clk.c index fc7a7a73b0cf..f088ccf80448 100644 --- a/sound/soc/mediatek/mt8189/mt8189-afe-clk.c +++ b/sound/soc/mediatek/mt8189/mt8189-afe-clk.c @@ -454,30 +454,47 @@ int mt8189_apll1_enable(struct mtk_base_afe *afe) =20 ret =3D mt8189_afe_enable_top_cg(afe, MT8189_CG_APLL1_CK); if (ret) - return ret; + goto err_clear_mux_setting; =20 ret =3D mt8189_afe_enable_top_cg(afe, MT8189_PDN_APLL_TUNER1); if (ret) - return ret; + goto err_disable_apll1_ck; =20 /* sel 44.1kHz:1, apll_div:7, upper bound:3 */ - regmap_update_bits(afe->regmap, AFE_APLL1_TUNER_CFG, - XTAL_EN_128FS_SEL_MASK_SFT | APLL_DIV_MASK_SFT | - UPPER_BOUND_MASK_SFT, - (0x1 << XTAL_EN_128FS_SEL_SFT) | (7 << APLL_DIV_SFT) | - (3 << UPPER_BOUND_SFT)); + ret =3D regmap_update_bits(afe->regmap, AFE_APLL1_TUNER_CFG, + XTAL_EN_128FS_SEL_MASK_SFT | APLL_DIV_MASK_SFT | + UPPER_BOUND_MASK_SFT, + (0x1 << XTAL_EN_128FS_SEL_SFT) | (7 << APLL_DIV_SFT) | + (3 << UPPER_BOUND_SFT)); + if (ret) + goto err_disable_apll_tuner1; =20 /* apll1 freq tuner enable */ - regmap_update_bits(afe->regmap, AFE_APLL1_TUNER_CFG, - FREQ_TUNER_EN_MASK_SFT, - 0x1 << FREQ_TUNER_EN_SFT); + ret =3D regmap_update_bits(afe->regmap, AFE_APLL1_TUNER_CFG, + FREQ_TUNER_EN_MASK_SFT, + 0x1 << FREQ_TUNER_EN_SFT); + if (ret) + goto err_disable_apll_tuner1; =20 /* audio apll1 on */ ret =3D mt8189_afe_enable_top_cg(afe, MT8189_AUDIO_APLL1_EN_ON); if (ret) - return ret; + goto err_clear_freq_tuner_en; =20 return 0; + +err_clear_freq_tuner_en: + regmap_update_bits(afe->regmap, AFE_APLL1_TUNER_CFG, + FREQ_TUNER_EN_MASK_SFT, + 0x0); +err_disable_apll_tuner1: + mt8189_afe_disable_top_cg(afe, MT8189_PDN_APLL_TUNER1); +err_disable_apll1_ck: + mt8189_afe_disable_top_cg(afe, MT8189_CG_APLL1_CK); +err_clear_mux_setting: + apll1_mux_setting(afe, false); + + return ret; } =20 void mt8189_apll1_disable(struct mtk_base_afe *afe) @@ -506,30 +523,47 @@ int mt8189_apll2_enable(struct mtk_base_afe *afe) =20 ret =3D mt8189_afe_enable_top_cg(afe, MT8189_CG_APLL2_CK); if (ret) - return ret; + goto err_clear_mux_setting; =20 ret =3D mt8189_afe_enable_top_cg(afe, MT8189_PDN_APLL_TUNER2); if (ret) - return ret; + goto err_disable_apll2_ck; =20 /* sel 48kHz: 2, apll_div: 7, upper bound: 3*/ - regmap_update_bits(afe->regmap, AFE_APLL2_TUNER_CFG, - XTAL_EN_128FS_SEL_MASK_SFT | APLL_DIV_MASK_SFT | - UPPER_BOUND_MASK_SFT, - (0x2 << XTAL_EN_128FS_SEL_SFT) | (7 << APLL_DIV_SFT) | - (3 << UPPER_BOUND_SFT)); + ret =3D regmap_update_bits(afe->regmap, AFE_APLL2_TUNER_CFG, + XTAL_EN_128FS_SEL_MASK_SFT | APLL_DIV_MASK_SFT | + UPPER_BOUND_MASK_SFT, + (0x2 << XTAL_EN_128FS_SEL_SFT) | (7 << APLL_DIV_SFT) | + (3 << UPPER_BOUND_SFT)); + if (ret) + goto err_disable_apll_tuner2; =20 /* apll2 freq tuner enable */ - regmap_update_bits(afe->regmap, AFE_APLL2_TUNER_CFG, - FREQ_TUNER_EN_MASK_SFT, - 0x1 << FREQ_TUNER_EN_SFT); + ret =3D regmap_update_bits(afe->regmap, AFE_APLL2_TUNER_CFG, + FREQ_TUNER_EN_MASK_SFT, + 0x1 << FREQ_TUNER_EN_SFT); + if (ret) + goto err_disable_apll_tuner2; =20 /* audio apll2 on */ ret =3D mt8189_afe_enable_top_cg(afe, MT8189_AUDIO_APLL2_EN_ON); if (ret) - return ret; + goto err_clear_freq_tuner_en; =20 return 0; + +err_clear_freq_tuner_en: + regmap_update_bits(afe->regmap, AFE_APLL2_TUNER_CFG, + FREQ_TUNER_EN_MASK_SFT, + 0x0); +err_disable_apll_tuner2: + mt8189_afe_disable_top_cg(afe, MT8189_PDN_APLL_TUNER2); +err_disable_apll2_ck: + mt8189_afe_disable_top_cg(afe, MT8189_CG_APLL2_CK); +err_clear_mux_setting: + apll2_mux_setting(afe, false); + + return ret; } =20 void mt8189_apll2_disable(struct mtk_base_afe *afe) --=20 2.43.0 From nobody Fri Sep 25 06:02:54 2026 Received: from mail-pz2-f43.google.com (mail-pz2-f43.google.com [74.125.228.43]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 14AA23B42DE for ; Wed, 16 Sep 2026 05:00:48 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=74.125.228.43 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1789534850; cv=none; b=m8LUtrDr0fEBxPWm5qTMn3DF7Y9itW6BNgvPH2tZF8WD3LQPzvhCH4HMWDNYjd4+yDxdsEgeHEBMG6Rlkj+oRbMU7k2d5Pen5oS405mdjzIAdm1JCzcDeRAc4EzYaOZ0EpXukDhZI75e4wIcZEg+g5mYsQ++v1MKbhhLAlAsOFg= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1789534850; c=relaxed/simple; bh=xflv8IXogpKHOiX9yYBSteBDb/dchvBi49QGMB3YIgo=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=rUtj8NHgcIXqmtBhk76WGTW7sYUaFsqH83qFxKGZXVNFoxuVhmQZ6uxgQAvp7snoVGlZHJ/IPJsTAvrn4iFNcn+5OhmA8KjjCYSIWIThx5Dr+VY0uKVZbJzXJcStk1UXkeXc4loS5Q7MJtSBqcPQVGtcSqiqfJdK4cQlakpCrQo= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=hXXlMkSe; arc=none smtp.client-ip=74.125.228.43 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="hXXlMkSe" Received: by mail-pz2-f43.google.com with SMTP id d2e1a72fcca58-86b90133ae8so345744b3a.1 for ; Tue, 15 Sep 2026 22:00:48 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1789534848; x=1790139648; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to:content-type; bh=B/w0mflA4CW2wen443DfpVvqyUW44q6NA3gxSFkvPnM=; b=hXXlMkSeqNjqzdA64Mo90qwuIGZo7TQKMtSI/CzP79oMzWvY/uhz3C/1+kr1KljuNy qzsi9FquOQ3dJSZruccb5/ftRxDzDNIZPVv/jp9nBdBs6t7bvNCLQt52OTH2RAEIkCM0 C8JZ9z2mkOdmMiqOQQIIT8Lekeh/yHfGEgbr3N18D3mSLqkMg4bUD3aI4o9VZBSs9yuF 61xq8OwJNYOJKUx00zXGk4Cg1ktKem7X+11g4qZG8wWCEmOYNqAuybhT3Uov5Es46wr0 ZbjMrdcDX8+4VXeiY4mgW+4K1xnYpRzrUwzMyolQFPqWIm4nn8NGVBFweytWyS8YqQFl S3kg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20260707; t=1789534848; x=1790139648; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to:content-type; bh=B/w0mflA4CW2wen443DfpVvqyUW44q6NA3gxSFkvPnM=; b=IJeEqjR9kzBMloM0Ns0W1VEQnzJkyhq+3FXXZjLjVOx0Z/e5bSX1sk7xFmFqfWZ/aY /lBk2DgQU78bn3t2fLdyyoUrNX+8cd8Eu7W8anagxyvykjVsyEJ1N9Gvgar6hSIbcApk oEqK0weM7PhOcG0Meo15WWDjsfJwjTIqCqDgCVz1BN/vxXhNf8GyLoibeEvXOx1UMIA1 XGpeUkcUmSTWT0cVH4Vpn0cTIMVY3Pi6bdi5UP6uIpc6wzdmEKlMIN9jQKQU8rDPvVp4 xDX+/2bepiMG4AeNdggqO8kKjt1ulppE/Er7tZYPOzhygJ9PpXPDWtwuSQ24/IsYKcVo aFTA== X-Forwarded-Encrypted: i=1; AKwUvBz1sF4MFypY3R76xXvtfvj2stWzfq0ZNrmWY2GgfR7HWIyg4+frXeJ5Qv7Qtq2bAr5rKr6JwiHxedrUfTo=@vger.kernel.org X-Gm-Message-State: AFuF++lEtcc4qKkOQ7iYIv6VczQbjob+TCZbuxuJ/C50uD3mx40TOmLw usazs8CoHe+1YGDo4BfgnE9R7ZncHvLU6jWQx1CrvHMUUSCjZj+LUm3B X-Gm-Gg: AYBFou2J3c2+8w6abnKjZC8FVxEfNM4TDLOiXFnrVbKRNyNDYKxkKkOPGg4J60mpP02 LoJW2gQqkked3zDUNZ9iFiPS4Lb9d3/KNRUQfcWzYNdL1jdvQ4q8Z9J6+LZWPKibJ+7vzeIvE2O qhLizwC48idUHKz2PP2OckCyRB7JC5QViDJdVe+BJV/lL+2ftj4RiO2/61xlBUjG2UIvV/5/5j8 d/Ke2x5ohGUqs4KCnDpLtC1rBJ3k6f8U745OtwNjshwozdIEZQigLmDGsmBhJzHWhPlXoTqXzVl Rg69aFhtOpqtqmz4v28SoMYxgJX5f64Ni4p1yY9drZPAGgJ5Pcghjy1Mks1ZhcErAEPRf1EOkie chnh+1qs3VHoYC+HguzMaJ3/REwEzliuDZ0dV+cqFOWXsjkmq799cSycmWj7uHctPaLDEYSPaEu iAL1Qv39d83czx2/XqmGBAmcOSynt5MgsqAPXY4rRJf4Ie/HqriBGt/0J0jZczV0mKl4pC8Vo4q xTK6/V7DuCml2WYRuygayJgmYuxsYE36L/Vc9LBDCLDw5fmZiY6U5SkI3j36vSw1eEd3hqmC6rw apbuWQw4j0pY9r0= X-Received: by 2002:a05:6a00:4185:b0:845:3033:6cb7 with SMTP id d2e1a72fcca58-87236ce44a9mr2291018b3a.9.1789534848308; Tue, 15 Sep 2026 22:00:48 -0700 (PDT) Received: from phuc-desktop.. ([183.91.15.56]) by smtp.gmail.com with ESMTPSA id 41be03b00d2f7-cc50abb1776sm850589a12.27.2026.09.15.22.00.44 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 15 Sep 2026 22:00:47 -0700 (PDT) From: phucduc.bui@gmail.com To: Mark Brown , AngeloGioacchino Del Regno Cc: Liam Girdwood , Matthias Brugger , Jaroslav Kysela , Takashi Iwai , Cezary Rojewski , Cyril Chao , Kuninori Morimoto , Dan Carpenter , cassiogabrielcontato@gmail.com, linux-sound@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-mediatek@lists.infradead.org, linux-kernel@vger.kernel.org, bui duc phuc Subject: [PATCH v3 02/12] ASoC: mediatek: mt8189: Propagate MCK enable errors Date: Wed, 16 Sep 2026 12:00:09 +0700 Message-ID: <20260916050020.14575-3-phucduc.bui@gmail.com> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20260916050020.14575-1-phucduc.bui@gmail.com> References: <20260916050020.14575-1-phucduc.bui@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" From: bui duc phuc mt8189_mck_enable() currently returns without restoring the clock state when setting the clock parent, enabling the divider, or setting the divider rate fails. Propagate the error and disable clocks enabled by the function. Fixes: dc637ffeed6c ("ASoC: mediatek: mt8189: support audio clock control") Signed-off-by: bui duc phuc Reviewed-by: AngeloGioacchino Del Regno --- Changes in v2: - Update the names of the goto labels. sound/soc/mediatek/mt8189/mt8189-afe-clk.c | 14 +++++++++++--- 1 file changed, 11 insertions(+), 3 deletions(-) diff --git a/sound/soc/mediatek/mt8189/mt8189-afe-clk.c b/sound/soc/mediate= k/mt8189/mt8189-afe-clk.c index f088ccf80448..56362c4756c9 100644 --- a/sound/soc/mediatek/mt8189/mt8189-afe-clk.c +++ b/sound/soc/mediatek/mt8189/mt8189-afe-clk.c @@ -639,7 +639,7 @@ int mt8189_mck_enable(struct mtk_base_afe *afe, int mck= _id, int rate) ret =3D mt8189_afe_set_clk_parent(afe, afe_priv->clk[m_sel_id], afe_priv->clk[apll_clk_id]); if (ret) - return ret; + goto err_disable_m_sel_clk; } =20 /* enable div, set rate */ @@ -650,13 +650,21 @@ int mt8189_mck_enable(struct mtk_base_afe *afe, int m= ck_id, int rate) =20 ret =3D mt8189_afe_enable_clk(afe, afe_priv->clk[div_clk_id]); if (ret) - return ret; + goto err_disable_m_sel_clk; =20 ret =3D mt8189_afe_set_clk_rate(afe, afe_priv->clk[div_clk_id], rate); if (ret) - return ret; + goto err_disable_div_clk; =20 return 0; + +err_disable_div_clk: + mt8189_afe_disable_clk(afe, afe_priv->clk[div_clk_id]); +err_disable_m_sel_clk: + if (m_sel_id >=3D 0) + mt8189_afe_disable_clk(afe, afe_priv->clk[m_sel_id]); + + return ret; } =20 int mt8189_mck_disable(struct mtk_base_afe *afe, int mck_id) --=20 2.43.0 From nobody Fri Sep 25 06:02:54 2026 Received: from mail-pz2-f12.google.com (mail-pz2-f12.google.com [74.125.228.12]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 874533B841F for ; Wed, 16 Sep 2026 05:00:57 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=74.125.228.12 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1789534858; cv=none; b=QAK0wrdiWGz+jVb7kR9ai7OdCl/koF/n9rMVsuA65+o+8h/zo3tuP6HpMTZvjP+3Og7CmFq46TV5/OV7vB7mJhElNGz+qucGojt/9lfltUThFreSv2PPWYKJkmz00rOvGsfa0Oav2XWaYhxZ5yCO+1VlF51sxM/YB/sn9EsKLuI= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1789534858; c=relaxed/simple; bh=86gBoh26nC94bjujUtZG3l5WFFuaeyV07o+eqxx+8JE=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=t3P6huCZIYLYD7zn8f6eMQg9HfWsGmC8lckPMWPLBesZGtsesofAieZKTGya8UOvq+eMRr0JpSFLsbPjJFCRAup50o13CSjcPjO67YmSXpwPWfgHZlrl3ma8qXM0kPVLMSU/90n8vrcmFAPaMfx8SfgCENk3MvpTA3gpD+yyfrY= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=SDYSLVww; arc=none smtp.client-ip=74.125.228.12 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="SDYSLVww" Received: by mail-pz2-f12.google.com with SMTP id d2e1a72fcca58-8633a38df87so271936b3a.2 for ; Tue, 15 Sep 2026 22:00:57 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1789534857; x=1790139657; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to:content-type; bh=O5PNRO0CdJEhOq1jWeluVyLPq+PGbJMv3Lvj1R4ejMk=; b=SDYSLVwwiMTyOO/pi336uFr2ceS6OvQggpmrOtjRplvsNJnLhH9CleeOekRXIsTmL5 INyLEuvmlGOaOOxkT6itlIVD0zBBLM0IoahojcpkUN0SYzIC41jKZKqdK+cairhzuljN DVJPkr1pl2qeSzj34RRCYcC+o2BPjAkKe8jarMCnllWNY7jRE3Ljlv9moQv3Xyz8Z1Th OSyoCAogohrn82Z4m1orVEdnTrtA8VEDL4JMOY7REOOPKgVP2tfTDzvYmEA78qJZvRRD /fswG6FMlbKdIqmLXoXxrx8kxJ3SdPC/qpfFSAGJ4PrB9mlxV3Cwki3Km1GrFW+7WyPZ fRVQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20260707; t=1789534857; x=1790139657; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to:content-type; bh=O5PNRO0CdJEhOq1jWeluVyLPq+PGbJMv3Lvj1R4ejMk=; b=WsAseHgoNd0mJBttOsyQC+mxIkW9axsQGS4P8WGQp8OZKnVCGDDlKy5whlTRX9B2VF v2xKkbWYlV1TJkN8Ppjn3VI/40ncItTv/OLmgwqNLxs2R7wHjebIFCMPblQlOfz2FXMx AG3fpYZ5f9UJDWR60KuEXZsoOMG++kJGLF4WTpK31lNKt/iZLFCWlsZN2lL/OVith+bC zrNE7g4SzQlm6BMWhBgCb4bSKuVXy9FrRPeJV1P0QV/sjV4vWEKKHWIWExm7kJ0kRzUE u9UhQlYDN4Mqpynr8kN+myL2cK1mGa+Mr82rKKlAeqGTS1iUrgeEk+lm3pgRH13OIKC4 R03A== X-Forwarded-Encrypted: i=1; AKwUvBxRIikGkDvIFcdKyLVD/fhMARhFjJvNXqfKbeqjBpLkI82raQXJoHHysKvdNEIQK0yubWZUc4a0XHvTeLU=@vger.kernel.org X-Gm-Message-State: AFuF++lu9KHI/iAUKBeRZ3zyPIkTFYHwVDTb+pJkorxeYA/9iXwQKUmO tWjuZKDhpZ9JxD/seVnjDKkrU3BXbWLgERs6O2N+5cSwdXzpq/ls7Dvf X-Gm-Gg: AYBFou2VZ7uqjT/U2BdJhiMG6IV/Tzm9f/8jMkamYEL3OAcUSuppa+EEenmHeWJ6+tQ 4OPTM6uesMx4mVAvUpQAo73eZz8Ge5tqvNKjJUbV6mK2/5BPFRYxZmScFX8PiJzrCnRlquUntdz M2VjtxbLIo+qzpeBO45GWX34iKBw7Isp6lwDWcc49FT8Ne8oeWZedNuJ4HM63HJpSx/i6BO7+e8 tVbDvmp6J/2YGBXjpSM9k37vYK+LqhkTr82/JNCkLFlkvuizSJp0ce+N376TEl4TQjBtT7FxNRE RMK3aXXgVOnQvFjFbFGpY1ds4PMRRhIkyf1lS/SD3WyPv6k4VGaKf1hXmz55yVVXXLzIdt+3VtL bEICG0kNvSyO6tOtv4/JdaQHia4U/Y5zXTgz2+sESGACuiBmS5ITffPFHanItQ69BWnewOQJgpF hNtkwcR86hoGkakxfexZ+K4KAmSEtWaB/Wqgn4XMFYSByKGebuwabbkAz3VZov+934e3MF8sd/0 7OyVgk138NbHgQbN66nrRFu/ljyP+flUT9BqHCV0talHmMW+qqhkw8iKOTkPttB/lZ5Ijuen7tb s4hFsU+wbFml8WA= X-Received: by 2002:a05:6a00:908f:b0:864:cbc5:b8dc with SMTP id d2e1a72fcca58-872378bbb6bmr2333682b3a.10.1789534853419; Tue, 15 Sep 2026 22:00:53 -0700 (PDT) Received: from phuc-desktop.. ([183.91.15.56]) by smtp.gmail.com with ESMTPSA id 41be03b00d2f7-cc50abb1776sm850589a12.27.2026.09.15.22.00.49 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 15 Sep 2026 22:00:53 -0700 (PDT) From: phucduc.bui@gmail.com To: Mark Brown , AngeloGioacchino Del Regno Cc: Liam Girdwood , Matthias Brugger , Jaroslav Kysela , Takashi Iwai , Cezary Rojewski , Cyril Chao , Kuninori Morimoto , Dan Carpenter , cassiogabrielcontato@gmail.com, linux-sound@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-mediatek@lists.infradead.org, linux-kernel@vger.kernel.org, bui duc phuc Subject: [PATCH v3 03/12] ASoC: mediatek: mt8189: Validate MCK ID Date: Wed, 16 Sep 2026 12:00:10 +0700 Message-ID: <20260916050020.14575-4-phucduc.bui@gmail.com> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20260916050020.14575-1-phucduc.bui@gmail.com> References: <20260916050020.14575-1-phucduc.bui@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" From: bui duc phuc mt8189_mck_disable() only checks for negative MCK IDs. Reject IDs outside the valid MCK range as well. Fixes: dc637ffeed6c ("ASoC: mediatek: mt8189: support audio clock control") Reviewed-by: AngeloGioacchino Del Regno Signed-off-by: bui duc phuc --- Changes in v3: - Add Angelo's Reviewed-by tag. sound/soc/mediatek/mt8189/mt8189-afe-clk.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/sound/soc/mediatek/mt8189/mt8189-afe-clk.c b/sound/soc/mediate= k/mt8189/mt8189-afe-clk.c index 56362c4756c9..7fe9d01006d5 100644 --- a/sound/soc/mediatek/mt8189/mt8189-afe-clk.c +++ b/sound/soc/mediatek/mt8189/mt8189-afe-clk.c @@ -675,8 +675,8 @@ int mt8189_mck_disable(struct mtk_base_afe *afe, int mc= k_id) =20 dev_dbg(afe->dev, "mck_id: %d.\n", mck_id); =20 - if (mck_id < 0) { - dev_err(afe->dev, "mck_id =3D %d < 0\n", mck_id); + if (mck_id >=3D MT8189_MCK_NUM || mck_id < 0) { + dev_err(afe->dev, "mck_id =3D %d\n", mck_id); return -EINVAL; } =20 --=20 2.43.0 From nobody Fri Sep 25 06:02:54 2026 Received: from mail-pz2-f12.google.com (mail-pz2-f12.google.com [74.125.228.12]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 7603C3BD643 for ; Wed, 16 Sep 2026 05:01:00 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=74.125.228.12 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1789534862; cv=none; b=UY0+U7WJF/sky7T4MtxyQYOsXgZBxI453mrfnxw0DRe/vkkFRlncNGtCtN4nlPJb2ztmsAgqQO2ws+NfcnKGU4lLMBD2zIFxnMxi2aMPM9DZvw4Xz/WTzzFFdYPr5Wj/CS9tQhgLMKS3U3TtTOVJqysz6qF4Y+zyojNagp/pXAs= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1789534862; c=relaxed/simple; bh=SRqGJTOXPZ/J0lb99O7VgZISgRhjpleo4umogP2E/9I=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=nq4+P06KpmdDSfVmwl3ldwv0H3ZgrWn/m3/lmPye7S6yWSdJY/t1P1Hykuj/5N42Aw62rkeEdksdMd/MBHM9GbH11LBoNdzFiLBGg5KKVIjMh8Ul4XwUrwI/+bA4OSUMpT7kfG3udhq4SgVgEc1zh+rS0xsbqD8smim5sawwC48= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=D26nQrpa; arc=none smtp.client-ip=74.125.228.12 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="D26nQrpa" Received: by mail-pz2-f12.google.com with SMTP id d2e1a72fcca58-85469b355ffso317069b3a.1 for ; Tue, 15 Sep 2026 22:01:00 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1789534860; x=1790139660; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to:content-type; bh=0uEKxahRyi+OLn+C//hdXAFcJKQaUJ4E7tV7IKAJQEs=; b=D26nQrpahVkxkHMW2Ubt3umVlfO+vzIjx9EKyqIHT1dLM5V27OQrDbsG2dMcDeHNxz m30lU9R+YX5MsJ4tvP5TPXLIISWWhh/mMq+h3JA1YVvo5g5T7UPtUzk22xJLs90TbiRT YIkAV+vqMQ+7tfzTsUdoNkKc8gr+v0eybx0RROfFxpCNVKF/TDcA12u222nEDchSLMDY 5NakJSotPESUXvIgdML+5Aa2yptRSeVletZCL6MsEmnshTu0pRrW5Xs0JQeqUWueMSjh w+TwEA/Pk8+uhl/15IuXFvDPT/W/UrBpHRt8eu2jmyXozwn/z/1fjM2tBqsF8TgSnxmY uu1g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20260707; t=1789534860; x=1790139660; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to:content-type; bh=0uEKxahRyi+OLn+C//hdXAFcJKQaUJ4E7tV7IKAJQEs=; b=L9gAPZLwtVefRj05bLTocU3fXhoG7PNulIQzM9yElJ1mmd6elD+dJNs8D+lakO0vSu 3oqwu9t2Z5c+UWkE95lv08Mf8EDfbgRUSWJ7y+nEUJtGwu9+O73FV4APZFx2eIKBNsug 4uwAXCRlTbIcstTC/oZnGN71ofvyMSrAL7WJRLRkle8k68hYFO+7euAzAXlxVyJfmjWD KSAYcTgQ6q/Z0b7WMgiPqYq41ir/UmeJAvAqsaqgqSY8IwCtKqSN/uvbeUMpsvOFQopa PoxGDQL5ChCUgwla+qsM3jQnxYbU+9ySUlhcOTFbKY7hCMferSIHpYIna8fa8qzx6tEP J6Dg== X-Forwarded-Encrypted: i=1; AKwUvBzaddBgGrSC5y5lJbnQHl31LuR7N47x/2nqsvKJkA5KfWuG+3rUQF8Wcf4aoZH4+8pWDo+/jx5rtsweocs=@vger.kernel.org X-Gm-Message-State: AFuF++lDh2JkjV/LeKZzcVzgb9e64feknIbmsI/7N2929/dAqsi9tprh 3C3pcUwazFnI9z7lLjtXs0O1fAObxcWc8ycvTufYhUxcarYwgt6E8pMo X-Gm-Gg: AYBFou3PrX+8KlV5Ia+21uLSEec3h0vSjXjL404mFgDAs7tFOWNZZGeqP/oaxASEp5z Tu3Pe21SSSegfMGwR62fPQk7rZgrzBE5h1AOLSXYPGYH7wuldwd74uyHlcTG1HC3WAB4JvCuW3c jDGCtZlMXixsfs0IxxgLABypPBoPNHGQUjvkBWVCjPistuCX+E1V/Amt//EckjNv0Tf0nTE/lzE 3Z/JBm1BXpjZpyRD0N2zJS5HvivHuMmCap4LzOZEd0EFUotDxlzoAsbS3CPFPNkWmGGMgWNUxFZ s673Lt7pafK/6hsWeuhGnpcQJPXEdMGqpu59cxLXxpStUbfgIOpMujI6WEvxdoRuStPkfZ4Ze6P gTL7A12KoTRD/D3hyMIf1lROtIFaKT+7boys93MdMzXwJBSWmC0NQQDVOyjmqlT0bhuW7oOdlnO ugUkONOPCviGHpqIsSCx4JQoWqz2axiiGcezNCPtTcAXSjRlwwDnIT5ZnqAn+YhKfUmQ2jTKQMH lttTrViwfbol64iT8U9DlmhtY4DZiJD4t+c7P2j8lXAhVDYRLOgiimE9ajZrBW90VL2uN/+RGGy hlgyw9n1sOalSkc= X-Received: by 2002:a05:6a21:4a81:b0:3cd:8bba:824f with SMTP id adf61e73a8af0-3dd5f3f8a8fmr2852962637.4.1789534859652; Tue, 15 Sep 2026 22:00:59 -0700 (PDT) Received: from phuc-desktop.. ([183.91.15.56]) by smtp.gmail.com with ESMTPSA id 41be03b00d2f7-cc50abb1776sm850589a12.27.2026.09.15.22.00.55 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 15 Sep 2026 22:00:59 -0700 (PDT) From: phucduc.bui@gmail.com To: Mark Brown , AngeloGioacchino Del Regno Cc: Liam Girdwood , Matthias Brugger , Jaroslav Kysela , Takashi Iwai , Cezary Rojewski , Cyril Chao , Kuninori Morimoto , Dan Carpenter , cassiogabrielcontato@gmail.com, linux-sound@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-mediatek@lists.infradead.org, linux-kernel@vger.kernel.org, bui duc phuc Subject: [PATCH v3 04/12] ASoC: mediatek: mt8189: Propagate reg_rw clock errors Date: Wed, 16 Sep 2026 12:00:11 +0700 Message-ID: <20260916050020.14575-5-phucduc.bui@gmail.com> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20260916050020.14575-1-phucduc.bui@gmail.com> References: <20260916050020.14575-1-phucduc.bui@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" From: bui duc phuc mt8189_afe_enable_reg_rw_clk() currently ignores errors from clock enable and parent operations. Propagate these errors and clean up the clocks before returning the error. Fixes: dc637ffeed6c ("ASoC: mediatek: mt8189: support audio clock control") Signed-off-by: bui duc phuc Reviewed-by: AngeloGioacchino Del Regno --- Changes in v2: - Update the names of the goto labels. sound/soc/mediatek/mt8189/mt8189-afe-clk.c | 31 +++++++++++++++++----- 1 file changed, 25 insertions(+), 6 deletions(-) diff --git a/sound/soc/mediatek/mt8189/mt8189-afe-clk.c b/sound/soc/mediate= k/mt8189/mt8189-afe-clk.c index 7fe9d01006d5..1132c924158d 100644 --- a/sound/soc/mediatek/mt8189/mt8189-afe-clk.c +++ b/sound/soc/mediatek/mt8189/mt8189-afe-clk.c @@ -700,17 +700,36 @@ int mt8189_mck_disable(struct mtk_base_afe *afe, int = mck_id) int mt8189_afe_enable_reg_rw_clk(struct mtk_base_afe *afe) { struct mt8189_afe_private *afe_priv =3D afe->platform_priv; + int ret; =20 /* bus clock for AFE internal access, like AFE SRAM */ - mt8189_afe_enable_clk(afe, afe_priv->clk[MT8189_CLK_TOP_MUX_AUDIOINTBUS]); - mt8189_afe_set_clk_parent(afe, afe_priv->clk[MT8189_CLK_TOP_MUX_AUDIOINTB= US], - afe_priv->clk[MT8189_CLK_TOP_CLK26M]); + ret =3D mt8189_afe_enable_clk(afe, afe_priv->clk[MT8189_CLK_TOP_MUX_AUDIO= INTBUS]); + if (ret) + return ret; + + ret =3D mt8189_afe_set_clk_parent(afe, afe_priv->clk[MT8189_CLK_TOP_MUX_A= UDIOINTBUS], + afe_priv->clk[MT8189_CLK_TOP_CLK26M]); + if (ret) + goto err_disable_audiointbus_clk; + /* enable audio clock source */ - mt8189_afe_enable_clk(afe, afe_priv->clk[MT8189_CLK_TOP_MUX_AUDIO_H]); - mt8189_afe_set_clk_parent(afe, afe_priv->clk[MT8189_CLK_TOP_MUX_AUDIO_H], - afe_priv->clk[MT8189_CLK_TOP_CLK26M]); + ret =3D mt8189_afe_enable_clk(afe, afe_priv->clk[MT8189_CLK_TOP_MUX_AUDIO= _H]); + if (ret) + goto err_disable_audiointbus_clk; + + ret =3D mt8189_afe_set_clk_parent(afe, afe_priv->clk[MT8189_CLK_TOP_MUX_A= UDIO_H], + afe_priv->clk[MT8189_CLK_TOP_CLK26M]); + if (ret) + goto err_disable_audio_h_clk; =20 return 0; + +err_disable_audio_h_clk: + mt8189_afe_disable_clk(afe, afe_priv->clk[MT8189_CLK_TOP_MUX_AUDIO_H]); +err_disable_audiointbus_clk: + mt8189_afe_disable_clk(afe, afe_priv->clk[MT8189_CLK_TOP_MUX_AUDIOINTBUS]= ); + + return ret; } =20 int mt8189_afe_disable_reg_rw_clk(struct mtk_base_afe *afe) --=20 2.43.0 From nobody Fri Sep 25 06:02:54 2026 Received: from mail-pz2-f12.google.com (mail-pz2-f12.google.com [74.125.228.12]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 21A813B442B for ; Wed, 16 Sep 2026 05:01:06 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=74.125.228.12 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1789534867; cv=none; b=g6UzQ5Zn8rTNrK7T6JqOUAWwn080f1Ox4SQsK7tQkwUPIcspQPPScnJkIogR7o+khM9v05+nCLd6FFVKyi9CgP1loT7aYqiyHmnEvPJ3wJnYRtsriGb/7HxOCPiCPI9RAboFDp79tKdh6wqKwPY0ofmksn6ZFGm+zJ6STwMOdyA= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1789534867; c=relaxed/simple; bh=sl/gIEyH51hHq7ahCeZqum/kQo2BHWlJjw6te8rTW7s=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=TuzA+Xc5UqpI5sBZaQwgivohas84ca6B7xsTNm5+L0zOGGZNe2UnuJDGa8TteJZU1zM5MfmRu1GjNJvy1ndBmNRwUt2F6/P3pfaXsuqg6KQalXREWI9nirPwITsrI6nLfzC4FuCxKWqQNOMXtzAbqwNiXYZ7SJ+EkZnHae1RxpQ= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=ZtvZObVm; arc=none smtp.client-ip=74.125.228.12 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="ZtvZObVm" Received: by mail-pz2-f12.google.com with SMTP id d2e1a72fcca58-85469b35611so308923b3a.0 for ; Tue, 15 Sep 2026 22:01:06 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1789534866; x=1790139666; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to:content-type; bh=cdugvJNqgU6E7j1wDJGENADgIVNNhusm8dqwAWIMj0U=; b=ZtvZObVmzjTaSITqdNS3iK2RHjMhrg+AoyzbwZ1K+myRokdt4j+nJnDoBARQLxq1oq yVgNUG1+zKrdzUVjVS7cUKGbAHzkxVk1+9on8lYowASlzWVjdYZbthQ+YFA2uBaOejLk lblULpixCktilqSrQ62JfSdONgM+OPFej65BAWjXy0ybgtigz6qcWcfzquYPk9ihGbLS 1YMTcFVBTdDJn27o9HzcBBKzpxoONqaFMdP7LJ6OF/CBjNx1iVqmmap4xNV2XKp8Ragm Ox5141jWwN9Q58GjuFvgq1VdbkvRo5L6n2QnYKQdSq3oYLL32oaLbgjHR3CQlNYBXWse S5ag== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20260707; t=1789534866; x=1790139666; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to:content-type; bh=cdugvJNqgU6E7j1wDJGENADgIVNNhusm8dqwAWIMj0U=; b=KgYRQOEmPIHO7qzzuO1PDvLhZPCjRvjZSdf6FQrA11O3MOVtcweELiXlmAoLYuFtao XbNjY8bXboWZ5ZU5JHabl/szd9MRpP8WDsJHCDlr6sJ0fiUO7N4nvh3ifStD/ORb/odO E1iao0YWKqzS/7cah7lwIRA28AEi9dvQEzdGB8YgE2t128o1RHyfI0pQFzyFj+nGrTep qpud4z0EuNDcxaMZMuUcbEO2xssDWYWXg2b6JMGE1FnvckaOgw2DMLQfVC9feC9Sa6QZ OMAdc9YuN95KOCt4VhcCqRDGYAYoue+3A2xlnBJaFZcTSw1ToQk18Qqn7Wbs4Hh83EZs qJfA== X-Forwarded-Encrypted: i=1; AKwUvBzSJ6RKneRDj0PE3vYGIEMOrEwkrE2xDvHjM9Pd4zM1uIt3ONKEUNRKWR6m2aNqNUD/5pp1d4PvlhLLZkA=@vger.kernel.org X-Gm-Message-State: AFuF++nK3K5pQtzxwT/EARdJf0yadnU+ThrKY/d9xLNANVahB1lY6ir0 0djvAjVB6HWYJEM9q+EimNXVDa3v6UspClDhtgVAqOvkJPbQ1Lw+L6WE X-Gm-Gg: AYBFou058rQhOY4dtUOBig3o5LcaoUc8lP5UHNUxtRKfy3rX5QoBe1s9RG22bKjYDC1 v77h/gnDtTFPalw0ivKnNoWpEC/P25j7IyX6yhMs613YQ3+AIygpPjGNbR5Rz+wHdv/0oBDEAyJ t/BRXXgWYzpA6ZgXjCVPaSj2ppwqsu+yY1iQIwwJm6gLbXgjcCYP5nssWxpIUZmhxS938MjsgGi S+Y1CvUIDA9cjopJBsEcfH4RuGCguQjwqT1qBCudVVvrkKTJlmlWi85C1/D8dHA1KE0xpg9TC+q t6vCOo290hJdiCP9H6ufceHvcwEbuts7ucITOEFqfSGOuhnIKmrxzSheuFMrB1G968AhBhXyEEK 9RdzNQF3l3LvVmZ6oPwLU+MKtslggMceggb1kr5znwHP4NhRsjJZQeSP2Xexcpx5nAYl7g3TU4L jKbMM9y/6E1gnqzaCUIfybyFi45dVWdLWvTbClMZKaW/rwQvy92Tr9E8vht4ekd7Lb/vq2P33MO Mrk3tnCK/qG2b01+4OZf83Jt1TArVc5QLLbqrn6hJ9YXIY4fIfXr7BbwNhQlKq8TrtszWQDJRZn KJSMl5xQU6C/swk= X-Received: by 2002:a05:6a20:918e:b0:3d3:b00a:7082 with SMTP id adf61e73a8af0-3dd5f7b25d9mr2952258637.28.1789534865531; Tue, 15 Sep 2026 22:01:05 -0700 (PDT) Received: from phuc-desktop.. ([183.91.15.56]) by smtp.gmail.com with ESMTPSA id 41be03b00d2f7-cc50abb1776sm850589a12.27.2026.09.15.22.01.00 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 15 Sep 2026 22:01:04 -0700 (PDT) From: phucduc.bui@gmail.com To: Mark Brown , AngeloGioacchino Del Regno Cc: Liam Girdwood , Matthias Brugger , Jaroslav Kysela , Takashi Iwai , Cezary Rojewski , Cyril Chao , Kuninori Morimoto , Dan Carpenter , cassiogabrielcontato@gmail.com, linux-sound@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-mediatek@lists.infradead.org, linux-kernel@vger.kernel.org, bui duc phuc Subject: [PATCH v3 05/12] ASoC: mediatek: mt8189: Use dev_err_probe() for clock errors Date: Wed, 16 Sep 2026 12:00:12 +0700 Message-ID: <20260916050020.14575-6-phucduc.bui@gmail.com> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20260916050020.14575-1-phucduc.bui@gmail.com> References: <20260916050020.14575-1-phucduc.bui@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" From: bui duc phuc Use dev_err_probe() when obtaining clocks to avoid redundant error messages, particularly for probe deferral. Reviewed-by: AngeloGioacchino Del Regno Signed-off-by: bui duc phuc --- Changes in v3: - Add Angelo's Reviewed-by tag. sound/soc/mediatek/mt8189/mt8189-afe-clk.c | 7 +++---- 1 file changed, 3 insertions(+), 4 deletions(-) diff --git a/sound/soc/mediatek/mt8189/mt8189-afe-clk.c b/sound/soc/mediate= k/mt8189/mt8189-afe-clk.c index 1132c924158d..594c214fa697 100644 --- a/sound/soc/mediatek/mt8189/mt8189-afe-clk.c +++ b/sound/soc/mediatek/mt8189/mt8189-afe-clk.c @@ -793,10 +793,9 @@ int mt8189_init_clock(struct mtk_base_afe *afe) =20 for (i =3D 0; i < MT8189_CLK_NUM; i++) { afe_priv->clk[i] =3D devm_clk_get(afe->dev, aud_clks[i]); - if (IS_ERR(afe_priv->clk[i])) { - dev_err(afe->dev, "devm_clk_get %s fail\n", aud_clks[i]); - return PTR_ERR(afe_priv->clk[i]); - } + if (IS_ERR(afe_priv->clk[i])) + return dev_err_probe(afe->dev, PTR_ERR(afe_priv->clk[i]), + "failed to get clock %s\n", aud_clks[i]); } =20 ret =3D mt8189_afe_disable_apll(afe); --=20 2.43.0 From nobody Fri Sep 25 06:02:54 2026 Received: from mail-pz2-f41.google.com (mail-pz2-f41.google.com [74.125.228.41]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id AEDF43BCD2C for ; Wed, 16 Sep 2026 05:01:11 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=74.125.228.41 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1789534873; cv=none; b=rNMCkTYEGUAsS2thOllujZW+5adnZ3mvf5sfieQTKoVzgj2YaWRU0CTfTqWkEbeKm97EmeA7TEwLPSHxBPRh9G4MPU1K1jOSoiMGwlead59WhMgANobBolA4CcQPJ6UVbYVAZSoTX936vo8SLDKfvgu6nmOzetkkpCpN1TcNkSY= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1789534873; c=relaxed/simple; bh=oeRk0bBJFuLJzLGlSEPoNXPBNRImrcUF+YBmLpWZ/7g=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=SzYuUn4ET/we/L6qsRzGEgmXIpMjXvGORqLhIA5B2L8C7yIU9OmKt/9/Is8TDxeXJNuU1avFByIg9alNI1oabEJ1/lj6q0RpH/lnSq+p/+RVgAVXhm7MuUN7HEj6Z6PrMa/Gavymb6PG7kE/yusW1h/fG8FDOAj77C+isVAI18o= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=JyutKMBE; arc=none smtp.client-ip=74.125.228.41 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="JyutKMBE" Received: by mail-pz2-f41.google.com with SMTP id d2e1a72fcca58-8631d0023daso304392b3a.2 for ; Tue, 15 Sep 2026 22:01:11 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1789534871; x=1790139671; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to:content-type; bh=jypTF/RLwAzXcjo5Lv+S1qv5niAwH9zwffT+/LnOWho=; b=JyutKMBE1IplCDxf2sfvqFIiQLquB0N7xV4LACqJTW4+TrsEf9jTfcvuA7bOlNySmB lhPduOqWfNqGNsKH0yI8tb/ZUcjLvezg3gYXpML42C+NwrsxCr4FTIm3gKsTYs7sSPsz sJN0viNjS2TMFSbFOxXY5qyrqBy8J2o5fa1UteVx+cyXIFgUy8B+tVuEnVc0kqWkLlHJ tC/wk0FOzAvb4RGfXEzfCOBfrO96ccjflvI7/5YFueRnk30UTl7zmeFrn4DTkO69DuWm R6jwGZWqQWcyaBMwuYuHHLGT1ZfafuvzJSwbP1Xk8/QSlHIEuQ7BkrrvuTznS7aMG549 +zJA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20260707; t=1789534871; x=1790139671; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to:content-type; bh=jypTF/RLwAzXcjo5Lv+S1qv5niAwH9zwffT+/LnOWho=; b=y/ba5rW5hqD6Q/YnvUagbaifodhY5bVAbpw8rI/MrmxYZYnqwfy/bCHEinAqd3nhmV YL3IdWTNl7c9uknRHVnjAUDuUOZrZ4dmwpNtizmJKcdLThoa9pQLWkRlCiwflTC2XnGV FbnPzRSk0u3TxjQz0XqrxZOKnqJBzUDDEO2mZwwIIYWLO9Xu7SftWM0KRKFcJdrKqtUg 7/NfmzUbjwjBJmYMOpOCNQGDCkBF530EWo8I3Ig5wMmupC3J4Mg7ixUL0G8TpqQWmO/a nqRyQ1lhLWtQRI9RUHts3wU8nvMwEoEOnxU4hA8a7m7ShpWKG3uwq1litHU58O1kTe7/ MhpQ== X-Forwarded-Encrypted: i=1; AKwUvBzBYrdPR4ukuxeXuPAxLVL/el1hdUY8MRWIYkX4qT4uFvPpBI/Rss4c1ufWs5sQIVl6q84sCfKSh7Z54cw=@vger.kernel.org X-Gm-Message-State: AFuF++lGUV+23hAhOF0YI6n4Az99yiTMkIk5/ecaGgPnESADkOPUu0DF /DtPh9CuatD+KVZs3LuNQ0QfajsoOa4mnNOoUM0qeUdClCQxlMtPWMIR X-Gm-Gg: AYBFou2c5WMXGt7TUsGsUJrMqnA1qBPwtsoKxkDu1mpyB+UBQ+M/uF2aO/XXaiogLPH zj99J6DOvjBQwZUxbTe0JIgB8941LlpY03Q2LZ8Xbo62fvHLBWEFDy7DEYudcH54UOVj/JAooT3 9OQkysGvIyvqqun7O2QH/HhpnqpnzuzeR7x/LK4/9efB+ZR+Ep4aXALudou3zRQxilggQxoLw3y nmRcESfAzidJE5V/OfGOQVBl3dPBakksaUBCpE6gYr9u2NdbMcMwLPifAp/JTd6NnCnW8jktrW2 we6oqfYF2qRo67v500Ho9EGZyu72tuNvvWrhzFbzJFiOOUdi+rDWalH6syhUC0HS5ru5V74KSyI 72Bu/h3/XelgBHEBMS6pHhcnkjRCeDOqDndq1QPzhOqS1AlaXkyGUxU+iGiAP656ufj7uF7g7FN lEsM7kGtJfpPIKKElcw7jE0Ikp/1oXNwXmAr9728IQZnKIsh5pCqKERxmBWWHWwwbBT5eg5BfRK 2jRxdUnAbSPc1D1aXDztWtPJkx35FSOlBTtbK9vXimYS5Rs+ulB5fqqCq05vcpqz4IG/pbTxnjY M6i6Qor9O3CHaYk= X-Received: by 2002:a05:6a20:4307:b0:3dd:5844:c95e with SMTP id adf61e73a8af0-3dd5f7b07ebmr2753489637.27.1789534870897; Tue, 15 Sep 2026 22:01:10 -0700 (PDT) Received: from phuc-desktop.. ([183.91.15.56]) by smtp.gmail.com with ESMTPSA id 41be03b00d2f7-cc50abb1776sm850589a12.27.2026.09.15.22.01.06 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 15 Sep 2026 22:01:10 -0700 (PDT) From: phucduc.bui@gmail.com To: Mark Brown , AngeloGioacchino Del Regno Cc: Liam Girdwood , Matthias Brugger , Jaroslav Kysela , Takashi Iwai , Cezary Rojewski , Cyril Chao , Kuninori Morimoto , Dan Carpenter , cassiogabrielcontato@gmail.com, linux-sound@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-mediatek@lists.infradead.org, linux-kernel@vger.kernel.org, bui duc phuc Subject: [PATCH v3 06/12] ASoC: mediatek: mt8189: Propagate runtime resume errors Date: Wed, 16 Sep 2026 12:00:13 +0700 Message-ID: <20260916050020.14575-7-phucduc.bui@gmail.com> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20260916050020.14575-1-phucduc.bui@gmail.com> References: <20260916050020.14575-1-phucduc.bui@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" From: bui duc phuc mt8189_afe_runtime_resume() currently ignores errors from regmap operations and mt8189_afe_enable_main_clock(). Propagate these errors and clean up the state before returning the error. Fixes: 7eb153585598 ("ASoC: mediatek: mt8189: add platform driver") Reviewed-by: AngeloGioacchino Del Regno Signed-off-by: bui duc phuc --- Changes in v2: - Update the names of the goto labels. Changes in v3: - Add Angelo's Reviewed-by tag. - Restore the existing afe->regmap checks. sound/soc/mediatek/mt8189/mt8189-afe-pcm.c | 32 ++++++++++++++++++---- 1 file changed, 26 insertions(+), 6 deletions(-) diff --git a/sound/soc/mediatek/mt8189/mt8189-afe-pcm.c b/sound/soc/mediate= k/mt8189/mt8189-afe-pcm.c index 77cf2b604f6c..39cc2804ad4c 100644 --- a/sound/soc/mediatek/mt8189/mt8189-afe-pcm.c +++ b/sound/soc/mediatek/mt8189/mt8189-afe-pcm.c @@ -2332,20 +2332,40 @@ static int mt8189_afe_runtime_resume(struct device = *dev) } =20 regcache_cache_only(afe->regmap, false); - regcache_sync(afe->regmap); + ret =3D regcache_sync(afe->regmap); + if (ret) + goto err_set_cache_only; =20 /* set audio 26M request */ - regmap_update_bits(afe->regmap, AFE_SPM_CONTROL_REQ, 0x1, 0x1); - regmap_update_bits(afe->regmap, AFE_CBIP_CFG0, 0x1, 0x1); + ret =3D regmap_update_bits(afe->regmap, AFE_SPM_CONTROL_REQ, 0x1, 0x1); + if (ret) + goto err_set_cache_only; + + ret =3D regmap_update_bits(afe->regmap, AFE_CBIP_CFG0, 0x1, 0x1); + if (ret) + goto err_clear_26m_req; =20 /* force cpu use 8_24 format when writing 32bit data */ - regmap_update_bits(afe->regmap, AFE_MEMIF_CON0, - CPU_HD_ALIGN_MASK_SFT, 0 << CPU_HD_ALIGN_SFT); + ret =3D regmap_update_bits(afe->regmap, AFE_MEMIF_CON0, + CPU_HD_ALIGN_MASK_SFT, 0 << CPU_HD_ALIGN_SFT); + if (ret) + goto err_clear_26m_req; =20 /* enable AFE */ - mt8189_afe_enable_main_clock(afe); + ret =3D mt8189_afe_enable_main_clock(afe); + if (ret) + goto err_clear_26m_req; =20 return 0; + +err_clear_26m_req: + regmap_update_bits(afe->regmap, + AFE_SPM_CONTROL_REQ, 0x1, 0x0); +err_set_cache_only: + regcache_cache_only(afe->regmap, true); + mt8189_afe_disable_reg_rw_clk(afe); + + return ret; } =20 static int mt8189_afe_component_probe(struct snd_soc_component *component) --=20 2.43.0 From nobody Fri Sep 25 06:02:54 2026 Received: from mail-pz2-f42.google.com (mail-pz2-f42.google.com [74.125.228.42]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id A4A1A3BF68F for ; Wed, 16 Sep 2026 05:01:16 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=74.125.228.42 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1789534878; cv=none; b=ZyOLukFpO8mNO2AlJrNMbJTFBI35EfoM7s3EbRtqyXWCVEHsM8facPseQI+1nngpeRRLXzDvhnC24HgehUDrWzHBZ0yj3zSFqVD5W3lX9AO9wX7rZ7rBj68B8kEvPQbixd7TwlE9TgaxzwqtB4DkDRRfVN7H6LbT7a0dQynDY8E= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1789534878; c=relaxed/simple; bh=cnhZJjul/G/ZTpHODnkmh6c/dIrJzdW84QixxOCRIBI=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=AxoejUspcPw3/FWDMZowfCHDdu+ndkDHgQCVaiJM5nOx+BLc3X2KgeLehVodxLoL3Jxb0ExRIR/8Mkr9qEkdpyxvQA0Cd+18q4cBew6AphIXpLtjxdv66w/mQz5yFEzZZQuxowgVDmY37Mb8P/emkmpVs770dfNxI5TnJNma4i0= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=C6nX5oJ+; arc=none smtp.client-ip=74.125.228.42 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="C6nX5oJ+" Received: by mail-pz2-f42.google.com with SMTP id 41be03b00d2f7-cc4d2fe2056so308948a12.2 for ; Tue, 15 Sep 2026 22:01:16 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1789534876; x=1790139676; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to:content-type; bh=a6hZRc7AVMqT+dPho3OXEUUZfvSnaC+QBxw2ObR4QHA=; b=C6nX5oJ+0SEtIeeHyVQlTxoZnCXGRWHAHeQqX2PyMeF4zR1ktJ6H+e9jQtxmw5HdP3 fgVToz5uvLfEZLFqcBg3etYrEYJHnUevOn+ZQjSN9ADyGEveKL5wBr5g/KJ0DH/817rp PNBqs1bgMfN2/whVUY51EMBKjsVkgKkxaFBVmownEWGEVs7IDWbObnApbFNS5d+tHA1W AbmIB42oJKSCUSy51UTMqATsGKPEfXqt8DfYwjoIyZKNi+DLJ7UMUlYx3enlGhfbhLUY 0urICw8VgDgsZehevDH0k6/QlKv5F8tvqmYbY+s59UUiYOb5GbqUzL2ccYOSZiZKG0Wg QL2g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20260707; t=1789534876; x=1790139676; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to:content-type; bh=a6hZRc7AVMqT+dPho3OXEUUZfvSnaC+QBxw2ObR4QHA=; b=GBqCxDjFE3Ax1XvFeNVARiyFoNryzCAAQ76fmg76ivI3t0z+Cv4sid/3QX2bzbeW/j 90Zq0zdlTyEdSbVz7DMI5HzWLiJ66Jn6ArNBeS54C3ULDrJdx3QoZluWE2KEUgklF5bB Z1faV+6za4kHFNy/sG8UZaav2HYo48iTDu8dcRBTyY9RHiz22haZn3HgGUAVh9h++k+O /k/cOf6WnDKpWQZi+2aOvKYyF6GL/X7XyTLxJeKdO0EODKITB3ezbHu0DPQ0Ozydm0NH o9Uqjwx6n8UIDhXDsILYF/M8gs9xZ8sKcFFnOUflvw5R7OUKhnv2j1Jllnqf5JhPunzN zreQ== X-Forwarded-Encrypted: i=1; AKwUvBykvwVjfJ25AA7osz66u8EBj4Vw8q3fjIUsVfYupR4AL6qCkA7GtklGNidA0KzfJceNp1Ncg/nDWtczF6o=@vger.kernel.org X-Gm-Message-State: AFuF++kcA+QgT65Lwa01ioehK5o1VSuI3pUY6vJJBczEx8ZndBPU1ZvH KTsmkbKflU49fRVgLBrkVbhE8FJfpsI5jt4+zp+qZB6VKmCMPUDHAKXq X-Gm-Gg: AYBFou2q0FSUCDyeXJ9RyaMMlp2xb+UWPFjUszlO2bZdErr1LANPzpC9lbAkX4EBnxN M+2Qn8kq6NJGV8a6hUWbCYTkBbmjU7AzVD+eVc8HN9r0APUs2hC8r+/Tt4mNIVnQ0qwj824iL4c iRClkpztIJ92/sjC3qbksffvVSD46IERRgs0YlJsmDYI+voxStJyKiHcB90MHmCgZzuHX5BMtk8 r43M0c3vG9kkXd9gr7UUc1/xW8IQsEEQBAaRiSenqjjx+8rt0wQH1yyHPHJwsOB3gzzHHg8bzeS ys7ZudxOWRi3znaIW3p+E/ZEbmmlHBelWumMbXP4v9s2uP7PEIw/KUxzSh/Uf6dNqQEGxnevJdU 18B2QfcW7oLJwLSVUL/RYUPRObglff2w6nAysklZzM707P7uj4qT+S5BsDbvhEiYW/NOjjl57v6 VqldNmvuTn4sCq3LcmiU39WoxpWCBzU/sJ7El/4FkFw41/l/fu7PmrXGquoxcGwwieO1JJ2lHER 67OqBylMGgZCDMuY42orkbWkk7U99uAH4fLr5x2pcW2ucLXcUwyhdIFpW8oAJG2u5M2XJLBESo4 mo1wEsUPSkXYMdI= X-Received: by 2002:a05:6a20:d48e:b0:3da:1e2f:3be9 with SMTP id adf61e73a8af0-3dd5f720482mr3249802637.22.1789534875984; Tue, 15 Sep 2026 22:01:15 -0700 (PDT) Received: from phuc-desktop.. ([183.91.15.56]) by smtp.gmail.com with ESMTPSA id 41be03b00d2f7-cc50abb1776sm850589a12.27.2026.09.15.22.01.11 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 15 Sep 2026 22:01:15 -0700 (PDT) From: phucduc.bui@gmail.com To: Mark Brown , AngeloGioacchino Del Regno Cc: Liam Girdwood , Matthias Brugger , Jaroslav Kysela , Takashi Iwai , Cezary Rojewski , Cyril Chao , Kuninori Morimoto , Dan Carpenter , cassiogabrielcontato@gmail.com, linux-sound@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-mediatek@lists.infradead.org, linux-kernel@vger.kernel.org, bui duc phuc Subject: [PATCH v3 07/12] ASoC: mediatek: mt8189: Remove redundant error message Date: Wed, 16 Sep 2026 12:00:14 +0700 Message-ID: <20260916050020.14575-8-phucduc.bui@gmail.com> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20260916050020.14575-1-phucduc.bui@gmail.com> References: <20260916050020.14575-1-phucduc.bui@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" From: bui duc phuc The errors handled here are already reported by the called functions, either directly or deeper in the call chain. Therefore, the additional dev_err() and dev_err_probe() call is redundant and can be removed. Reviewed-by: AngeloGioacchino Del Regno Signed-off-by: bui duc phuc --- Changes in v3: - Add Angelo's Reviewed-by tag. sound/soc/mediatek/mt8189/mt8189-afe-pcm.c | 13 +++++-------- 1 file changed, 5 insertions(+), 8 deletions(-) diff --git a/sound/soc/mediatek/mt8189/mt8189-afe-pcm.c b/sound/soc/mediate= k/mt8189/mt8189-afe-pcm.c index 39cc2804ad4c..11dba86c3e81 100644 --- a/sound/soc/mediatek/mt8189/mt8189-afe-pcm.c +++ b/sound/soc/mediatek/mt8189/mt8189-afe-pcm.c @@ -2486,13 +2486,12 @@ static int mt8189_afe_pcm_dev_probe(struct platform= _device *pdev) =20 afe->base_addr =3D devm_platform_ioremap_resource(pdev, 0); if (IS_ERR(afe->base_addr)) - return dev_err_probe(dev, PTR_ERR(afe->base_addr), - "AFE base_addr not found\n"); + return PTR_ERR(afe->base_addr); =20 /* init audio related clock */ ret =3D mt8189_init_clock(afe); if (ret) - return dev_err_probe(dev, ret, "init clock error.\n"); + return ret; =20 /* init memif */ /* IPM2.0 no need banding */ @@ -2526,13 +2525,13 @@ static int mt8189_afe_pcm_dev_probe(struct platform= _device *pdev) /* request irq */ irq_id =3D platform_get_irq(pdev, 0); if (irq_id < 0) - return dev_err_probe(dev, irq_id, "no irq found"); + return irq_id; =20 ret =3D devm_request_irq(dev, irq_id, mt8189_afe_irq_handler, IRQF_TRIGGER_NONE, "Afe_ISR_Handle", afe); if (ret) - return dev_err_probe(dev, ret, "could not request_irq for Afe_ISR_Handle= \n"); + return ret; =20 /* init sub_dais */ INIT_LIST_HEAD(&afe->sub_dais); @@ -2601,10 +2600,8 @@ static int mt8189_afe_pcm_dev_probe(struct platform_= device *pdev) &mt8189_afe_component, afe->dai_drivers, afe->num_dai_drivers); - if (ret) { - dev_err(dev, "afe component err: %d\n", ret); + if (ret) return ret; - } =20 return 0; =20 --=20 2.43.0 From nobody Fri Sep 25 06:02:54 2026 Received: from mail-pg1-f180.google.com (mail-pg1-f180.google.com [209.85.215.180]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 5B9A03BCD3A for ; Wed, 16 Sep 2026 05:01:21 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.215.180 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1789534882; cv=none; b=Hepzb7Jkfx6CSpW34uLjBX/HN1vG1xUAJzo76ge/lPjjB6CkeLABMtLDQ/weYzEbFrexLMxuVxz2Vemq4EKIC1H5RXQGgwAaSpYj+/YLi/h2BvUSxRkuZaCupyvosYPcOba55qGmvk+8BuGmQU1BF7bOUMGnUWKhVOZNfvYMnXI= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1789534882; c=relaxed/simple; bh=Wfj7ayzlWfEu+I8dT6gg9Qx37En8fvuHsBJbQGPJEIc=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=qS9crT2jxHiqmRYyJZQPu5+Omx0uc6I1B3u8Lkdici/duJcRjgzyWKOByfMgL9ek6Eg86NxTUA4aHhty5qUjLaGkMbjZUQfQfd2xiJZURbySPPZ0pEGMZoUMvF4pVSiS2sVXSf6w7Ah1UDCnQa1hYheZ2616TGpiQhiDl71ZCDM= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=DGgpxG+0; arc=none smtp.client-ip=209.85.215.180 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="DGgpxG+0" Received: by mail-pg1-f180.google.com with SMTP id 41be03b00d2f7-cc502a179c1so976394a12.1 for ; Tue, 15 Sep 2026 22:01:21 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1789534881; x=1790139681; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to:content-type; bh=qB6h8bEY4JQqTm9X+KYhPwqJjNuxDZMSiRPIGrpZWzc=; b=DGgpxG+0xlTKDdHU0DNZP8acVcr3+RwWNiskjP8QE6gOIREDw6P0t+Kpn73QIjKIca rsBGy+Aja0UZuFuV/EqnK9TFV3775WGHjCloPHeb8PrhLxDtewZGGd+EFvY154B1V55P CdMRFLXus4MXI+NlrZHulH8+k5idNN2KKi6o5nqgHOg7ChsxiRq+4KpO+71AOPFdLHVR xL5zl7+R5Pd0D5Nq4epuTUHx5vHAVoXiSvH9Ya35M9kZmNiRw/7N20oRnL26FfO5xRGP 5H4fWLk8n3ICQ7K873T1WfyNPPd4xf8GxFwoEOtCaT3e+SvUKM8I2rtXaJEWz4T+/n8e dlng== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20260707; t=1789534881; x=1790139681; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to:content-type; bh=qB6h8bEY4JQqTm9X+KYhPwqJjNuxDZMSiRPIGrpZWzc=; b=DV4YcX0n4WAvNK3Qrhp3rsYUYtpvMmwTAw5RxmQWbWE/2k8kgjPLMAWM+gYZMnfC3U JWJP2zjNIDs4gYvDbhDDJ0Hf3SDWVoBzeH4GbgsnIQf1tYpEYNcKXo6BMiRZv98gkaRc p4dtrQzChH7qYCnZg4huxpzQj9uIWuhmOEXEyVXun82MlJzMzoXtVBmHrNXaKsijp3mS KtjqLWIulzrsRzNxqXxmbpzDY5SIbvZaO9xWQOhq09nwh+iL7yDaWz6FPy24gMEkHUoW ywcpPrIZWfVdoQ2Tu7uVAzETiu+lxmzatnFIzfaAu36lA8vP7k2R3s4A0kYnDRks08kL DObw== X-Forwarded-Encrypted: i=1; AKwUvBw5CyXz5ZQUpTwNjPfOY+jI8CmFZr69d73QshI/8Mig6G3EqEusEL5vUuy7b/aEQZw000pGi+KxTkdmXOI=@vger.kernel.org X-Gm-Message-State: AFuF++kdXYnZMNIW5AoY/+3nxrEuGXMyPGm8Ue7vw2IIrh8VQLp6wksB yfwt+1RXxbHXIICm5serM6hftlQWyjC94JXoCKAE1YcA9D1OoYfpI0HPXZ13OA== X-Gm-Gg: AYBFou3XnA5nhHFOvygBoWY272XT0A9Pm8TRA3CdagbysS8ywt5KrIL1pdEKAxeWeNy bUprY7USfWak4Vzc5Mgq0fU19WIu9GlWYrpLPkVRblD4jTDCapGoTvWwQX/m4EltFwBxkjAq7oC 4UB8WgPHrW9lPuS2XBMqsUFFEu+QlyAoR1bJqSK8SQTvKgDRo4TmpIfYO+EVoP8HXqMnwPag4g6 jNUKkzcRS5fp/OJaKQt8BtjlDLWg64QM5mdkpX740ssUC3RPc1EdtnSt/uURHzyBAEGGix3ZpCX hYjR+BV48CVO2+1W7Bvu8fnux/Vx6xEEQqWDpUbMPzpDjzb/wExANb9i32rXWFah3IWPdf+MRAS 8zCkrvzkpBGVT/JfGf+JYS8IRP7qg+xol+1HKehUfZ4TeR4FZ0dgfX3Uu9OkTUT9luOgW+0NpoY zPRr3YD9ntMU5jBhIOapFiTRzMsUuSCdxNFCcoBsJyZRZ4PxHol+ZRO9EvwEhZ7NJfXqD9VgRzF lVh92mXbpNXGBehPE7l7/q1TszSyzp6/KpQUacrf+r4LPqQ4gtQvWMY79bFsKkfTmyH/TCgqptB ggpQTWZFW8BtXqg= X-Received: by 2002:a05:6a20:e615:b0:3da:f1b3:50fa with SMTP id adf61e73a8af0-3db4fb852a7mr9838208637.8.1789534880774; Tue, 15 Sep 2026 22:01:20 -0700 (PDT) Received: from phuc-desktop.. ([183.91.15.56]) by smtp.gmail.com with ESMTPSA id 41be03b00d2f7-cc50abb1776sm850589a12.27.2026.09.15.22.01.16 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 15 Sep 2026 22:01:20 -0700 (PDT) From: phucduc.bui@gmail.com To: Mark Brown , AngeloGioacchino Del Regno Cc: Liam Girdwood , Matthias Brugger , Jaroslav Kysela , Takashi Iwai , Cezary Rojewski , Cyril Chao , Kuninori Morimoto , Dan Carpenter , cassiogabrielcontato@gmail.com, linux-sound@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-mediatek@lists.infradead.org, linux-kernel@vger.kernel.org, bui duc phuc Subject: [PATCH v3 08/12] ASoC: mediatek: mt8189: Propagate APLL errors Date: Wed, 16 Sep 2026 12:00:15 +0700 Message-ID: <20260916050020.14575-9-phucduc.bui@gmail.com> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20260916050020.14575-1-phucduc.bui@gmail.com> References: <20260916050020.14575-1-phucduc.bui@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" From: bui duc phuc mtk_apll_event() currently ignores errors returned by the APLL enable functions. Propagate these errors. Fixes: 7eb153585598 ("ASoC: mediatek: mt8189: add platform driver") Signed-off-by: bui duc phuc Reviewed-by: AngeloGioacchino Del Regno --- sound/soc/mediatek/mt8189/mt8189-dai-i2s.c | 7 +++++-- 1 file changed, 5 insertions(+), 2 deletions(-) diff --git a/sound/soc/mediatek/mt8189/mt8189-dai-i2s.c b/sound/soc/mediate= k/mt8189/mt8189-dai-i2s.c index 94c49a662e2d..4826ee250d70 100644 --- a/sound/soc/mediatek/mt8189/mt8189-dai-i2s.c +++ b/sound/soc/mediatek/mt8189/mt8189-dai-i2s.c @@ -485,6 +485,7 @@ static int mtk_apll_event(struct snd_soc_dapm_widget *w, { struct snd_soc_component *cmpnt =3D snd_soc_dapm_to_component(w->dapm); struct mtk_base_afe *afe =3D snd_soc_component_get_drvdata(cmpnt); + int ret; =20 dev_dbg(cmpnt->dev, "%s(), name %s, event 0x%x\n", __func__, w->name, event); @@ -492,9 +493,11 @@ static int mtk_apll_event(struct snd_soc_dapm_widget *= w, switch (event) { case SND_SOC_DAPM_PRE_PMU: if (strcmp(w->name, APLL1_W_NAME) =3D=3D 0) - mt8189_apll1_enable(afe); + ret =3D mt8189_apll1_enable(afe); else - mt8189_apll2_enable(afe); + ret =3D mt8189_apll2_enable(afe); + if (ret) + return ret; break; case SND_SOC_DAPM_POST_PMD: if (strcmp(w->name, APLL1_W_NAME) =3D=3D 0) --=20 2.43.0 From nobody Fri Sep 25 06:02:54 2026 Received: from mail-oi2-f12.google.com (mail-oi2-f12.google.com [74.125.231.204]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id E2D913BD225 for ; Wed, 16 Sep 2026 05:01:26 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=74.125.231.204 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1789534889; cv=none; b=DrwYDT7Ujf1bcDV/LGCOwaAMrlqqgh8jpjxY5A23YsCYkdujN1fkHp0iI6MuJMJ2OkShbg4M+oLIX8b4l3mjpuDSD9J/ItnziXcu9b/qHpL0rTL9vPY2EPhstOlNMZ/uDj77q5Of6llkPvftpnsWNf4S9Kz9/iZ7PrGeHr0eg4c= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1789534889; c=relaxed/simple; bh=xKR92clgBSMOu24lioWfDgbWesVkWCGN0SMJs27HPlI=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=T5mnp/Uh9DAwkwiBQY+XHyUr4dv6h2bpxbyVeAY6ZJCOLufpulfhtg96dob3Ky/s1cxPFDS8HZUYdEdqB4mMhpaGSFZC12i6Tnh7T9YvrQl/8qy9/Yj5vUS8P75AK1Sje6IsEZY8Du5+/Anx7Cg5OhhysHyeyuW0nslO19Nzmr8= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=nfS/SX8n; arc=none smtp.client-ip=74.125.231.204 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="nfS/SX8n" Received: by mail-oi2-f12.google.com with SMTP id 5614622812f47-4c5b53d710cso351020b6e.2 for ; Tue, 15 Sep 2026 22:01:26 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1789534886; x=1790139686; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to:content-type; bh=D9B0Lnz9uNh2cM8wk4dYkQqiHmEJincpWAn3l27K96A=; b=nfS/SX8nxJqYuO/aCKiXSZTXbwWD7qAulqcfsRwbsJ2hq0tuJEwsf0ro6T3/l56jL7 Y3ZxHoL9ajAxwdLxMVaoWwZLHz+lN3AhPKXmlMhjPIXJfmDaxNsEZlfd26j5+DuxSWFb D7iao+4GWOlGal+H16OmzykUEuFLuobx20DK+CvCvbPYwnSktd7h97600mLVe4GnJSEc jpM4VmpPKGagJMFpXtLsuWCjnKNNOBrxsLbofczPrwMeuLwn0dB6P1R795FAw8RBzOai ZahjKtg+TYK9NvtfRrUo0a7xy1kLBGyiqxIX2NKACphhw9/SBxQSQbCNcD1oiQAQFJ+3 nV8w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20260707; t=1789534886; x=1790139686; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to:content-type; bh=D9B0Lnz9uNh2cM8wk4dYkQqiHmEJincpWAn3l27K96A=; b=f3lZkU8wYO4X+UoCO+pynaWaZ/WlnSdAqvkhFLgSj4rGZ0YIj2DLhyBiO6j2vdmnPE SUTXvVXEZAeheMp1I7chjawzLNr2qT3YOW4vqu5UG9IzgrjeWZLF6u9GIZGj3/e966te vMo9Bk7AIM0rOJYfaIbPhkkeG/0XDjlK5iNUXJ/Qp3vNS2TnpK72vjM1dymLLhWRAjDX fwUm7ZvT5gNNBhxGwjerXsfGuOma3dIEp/Aav5PuAOUKpVKkoL9srhjNKCtYGDSH443K TAA09rzNVhoMZoTR9dVk6PS2QWuZaPrHqIAK2Mw7UBfdI3z13G9MK9S1BCNVDLRWjoVs GS0Q== X-Forwarded-Encrypted: i=1; AKwUvBxNjp5jRGqS2GIZLctT3HfIaipnriWYNoCxf/v+dTWPeNY7lVxWJrQ9bX1ILxJMxhyngpjj9OvrVVEyvnU=@vger.kernel.org X-Gm-Message-State: AFuF++lxJSj2h3EWixyFy+QtBDZIHeGbmZJI0WA5MGjlTUwZwt8RG5Hr tropTex34UZqAuwW2ojaWu572XK5vecyLxcUgy4PQzrLmcnsKOF0Ljcw X-Gm-Gg: AYBFou1SIHAJqjrfrqjKHiVYGfxcNcJhtNatrxIX5ccuBi9t/0CtMMIJK1fS7VvFt/e p0/r42TGRHJljZlTDK9Qx4W4T8iBO5L0oK4oa67Vg8p2T+tdg3e4qEOmxPGBzZ1eUaJ06ylNo8u SM74xaoNugCi7AN8KEPagLp5qson/QaJ4YCnqSpwQYBVYXdcj/UeSmkrvglp51P5x1IBhHg6kn6 b8RON4izQzDzz/OvHNf9tJpaQxgd2P1gSez6iZCM8P2nE5e3cXDyEj6H4hTJArL6YlRRn+1i0mN 5sWvUr/rHqbFz5ApHcKy/jYDTfTpnBDd7818zFZsJnPg4+FPfPrc1reTS3qgdw16wE9K6kDMI65 FkDQWiQiGDS3ZBNA/H5zKIhcVWucMkoWOeiP4ugrmwyt6ag7VezZdK0irM2u9a4RiMacj+Y5VH9 LgHURLSx7e3L1EUU2yM9177ir7DcuGk3wrU3tG2t8OhKi7znuPeOQFM0MkgIZxaJ5Lw7c4w1V9e QEPLprubQnXvW+xcC2XfIZSdMkvFV4i1UifE8+LAkDFVlLiybs1UK5DtUG/OzcL/hHksCrSRwvf ZBdtvl9yP7fOYw0= X-Received: by 2002:a05:6808:23ca:b0:4c3:e608:ade7 with SMTP id 5614622812f47-4ca49dd720fmr1842524b6e.11.1789534885682; Tue, 15 Sep 2026 22:01:25 -0700 (PDT) Received: from phuc-desktop.. ([183.91.15.56]) by smtp.gmail.com with ESMTPSA id 41be03b00d2f7-cc50abb1776sm850589a12.27.2026.09.15.22.01.21 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 15 Sep 2026 22:01:25 -0700 (PDT) From: phucduc.bui@gmail.com To: Mark Brown , AngeloGioacchino Del Regno Cc: Liam Girdwood , Matthias Brugger , Jaroslav Kysela , Takashi Iwai , Cezary Rojewski , Cyril Chao , Kuninori Morimoto , Dan Carpenter , cassiogabrielcontato@gmail.com, linux-sound@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-mediatek@lists.infradead.org, linux-kernel@vger.kernel.org, bui duc phuc Subject: [PATCH v3 09/12] ASoC: mediatek: mt8189: Propagate MCLK errors Date: Wed, 16 Sep 2026 12:00:16 +0700 Message-ID: <20260916050020.14575-10-phucduc.bui@gmail.com> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20260916050020.14575-1-phucduc.bui@gmail.com> References: <20260916050020.14575-1-phucduc.bui@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" From: bui duc phuc mtk_mclk_en_event() currently ignores errors returned by the MCK enable and disable functions. Propagate these errors. Fixes: 7eb153585598 ("ASoC: mediatek: mt8189: add platform driver") Reviewed-by: AngeloGioacchino Del Regno Signed-off-by: bui duc phuc --- Changes in v3: - Add Angelo's Reviewed-by tag. - Do not pre-initialize ret; set ret =3D 0 in the default case. sound/soc/mediatek/mt8189/mt8189-dai-i2s.c | 8 +++++--- 1 file changed, 5 insertions(+), 3 deletions(-) diff --git a/sound/soc/mediatek/mt8189/mt8189-dai-i2s.c b/sound/soc/mediate= k/mt8189/mt8189-dai-i2s.c index 4826ee250d70..8cd5ddf62d46 100644 --- a/sound/soc/mediatek/mt8189/mt8189-dai-i2s.c +++ b/sound/soc/mediatek/mt8189/mt8189-dai-i2s.c @@ -519,6 +519,7 @@ static int mtk_mclk_en_event(struct snd_soc_dapm_widget= *w, struct snd_soc_component *cmpnt =3D snd_soc_dapm_to_component(w->dapm); struct mtk_base_afe *afe =3D snd_soc_component_get_drvdata(cmpnt); struct mtk_afe_i2s_priv *i2s_priv; + int ret; =20 dev_dbg(cmpnt->dev, "%s(), name %s, event 0x%x\n", __func__, w->name, event); @@ -529,17 +530,18 @@ static int mtk_mclk_en_event(struct snd_soc_dapm_widg= et *w, =20 switch (event) { case SND_SOC_DAPM_PRE_PMU: - mt8189_mck_enable(afe, i2s_priv->mclk_id, i2s_priv->mclk_rate); + ret =3D mt8189_mck_enable(afe, i2s_priv->mclk_id, i2s_priv->mclk_rate); break; case SND_SOC_DAPM_POST_PMD: i2s_priv->mclk_rate =3D 0; - mt8189_mck_disable(afe, i2s_priv->mclk_id); + ret =3D mt8189_mck_disable(afe, i2s_priv->mclk_id); break; default: + ret =3D 0; break; } =20 - return 0; + return ret; } =20 static const struct snd_soc_dapm_widget mtk_dai_i2s_widgets[] =3D { --=20 2.43.0 From nobody Fri Sep 25 06:02:54 2026 Received: from mail-pz2-f12.google.com (mail-pz2-f12.google.com [74.125.228.12]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id B989D3BF684 for ; Wed, 16 Sep 2026 05:01:30 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=74.125.228.12 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1789534892; cv=none; b=Lbv0YqHwb8A/Roj/I9QC/GAVeFiQzL9viPdoCXZdr5wI70XFWjCOkWHp119ao10c1HOaSsUiuLfgBUuNwJEDd0IhBWQ5xwG6eJLFRj0JV8I133ySfSub6NHzv8/8rxfWjRayY3GWGNUjlsvApW7Ixkz8iPLH2itCu43c8ff+2Ew= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1789534892; c=relaxed/simple; bh=Xu6BPAMU0+75jjsBaml0eU1zP6f+KPzQJJ6a5O50TOM=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=EAc3DyF+RLRGn/msEF9aMdEJi/LlHF9nrEE8gIB4wrb3GoVKmJjSkrQZMmDH1y3nB45CraV3pQfIelg5zXWDTt4h91nQeEgfilgB2n5gZ/8DHwJoiVgOXujPmEnEJTCC/4PtxGzi4aiQUGMcU/oAJcJv9EM/jwHDMFg4QTFSCSo= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=YV+eYhxo; arc=none smtp.client-ip=74.125.228.12 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="YV+eYhxo" Received: by mail-pz2-f12.google.com with SMTP id 41be03b00d2f7-cc1cea50db3so342965a12.1 for ; Tue, 15 Sep 2026 22:01:30 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1789534890; x=1790139690; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to:content-type; bh=w6bmQtp3Ds5+ZJWXFpufINVse/crG8NXJOilyMFAbqM=; b=YV+eYhxocU2u5DolYIrBPKfk9YzBQrNNblwIIckpemz6mzkVq7YMp5YMFOBtGcR7HP r1aUJcFOO1A7KfNf9E0qVKxEZstIkTQfMsEb+7pcui9yAmXK1WPi65XjhvpHhm66Tost 5gp/kMN14eNunVw/bL7SUXHAt9UC+073ki6B0YWuyTMaKuTkLfbRYAQYPEHSjETJ4xXd 4ZS7Giujek5I1WSuVh4b1x8XiIJuZasSpEPxRqX8+dsA/g6Vu4iMUe/HnF2ll+ql88pm mYc0KEVad/oCln+Rype4N/3Fl/KCsQhyFvhq5zfturseEpBf92yeWHVd3luX1HJaSsX4 LOfw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20260707; t=1789534890; x=1790139690; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to:content-type; bh=w6bmQtp3Ds5+ZJWXFpufINVse/crG8NXJOilyMFAbqM=; b=cUo2pmCrR94LNQ++j1us4Q/UuQ/uC1O/O2R6yeKoiR5A6o9A1Vm/9Ucshvy8hHe3GJ a/AQUpYYPR3WqOljNU02b80LTXFGGrTW8j2V3HodU4BG+WE0uJVB9a5bMXGFoGhtE2Zg mx7EegGaAKNLO0JveCii93zulkx4a4VS3bQSn8JomeMqKHUtfoKwQejy3P+YS8PivIFt rQajVW1q2ox7noxvJZR8E1hxIssiqBNf/Q1ZOBIU0ozYlGohPRDHgEk+GfTKp695bLG/ 7ZcqPZV4ibvZ63vqapDeSYbBcrPrBGiFFy3xpoUffFl2MLq7/qob5mEI6Q7aDBBXSQYZ HBIw== X-Forwarded-Encrypted: i=1; AKwUvBwABb4Ts4uV4rS62agaOALKu5d/Yy5f8ScbAu22oOGhFd46Y70QwiRG3xKRVmGlqQy+fTfwR9Qwf2lW7hA=@vger.kernel.org X-Gm-Message-State: AFuF++kIKtihhyeXSS/IqcNtQVioP1xYxuTzBpJrudqygRs2RI4TgrXf H1xMMIaarT3JSbALO8OOy+D2HZrJuAnyDj/zOcG34N2lJ+rj+oHglqSJ X-Gm-Gg: AYBFou00DTwa/Vahg2RCp/3cchUbMS0rhXfPBY9KDYAwxgT5kj9rgkCyZ4L5pp+wE1u E/9q8/Av66Ela3NJ6FNYyxep02xQNPvzgzv/jErU0r+qyaB67s9KSvDJNdOj/+nVg/uOCGES+oy 5/7lsyWd/dsJcpDBEceBo+/WcKKsfmvHmEWCntBdHxgdzIUnqjwPsdEa2G1pHUnJxFwSNGzDJ5c MyDYuBchOPjil7I8WXi4v4zWZ+PH3yN6+DiUPEmMrk7GWNmFaaLueriDruIWa1unkQpJcunx3hk p6AMxsilt1HAXky/vBU9Ss+IuOM+ilfNWO6VJV/UgA4f18zLCndDhbNkfTmbm0B8FjftLOrD6en xKcNLMrfCTyWV/rKP3366h45/wpbFcmgQC983P4wtXsMiYs7aCOnhq5GVGyOk9t229aEi1f/V9k nbE3+Rze7BIs2QiJpJq8dfmsE2qbyc/lRXudhsKSszcNFzKYMzGvfkyogI0AWUw0u/Q2Aw3Urez BzRZZfGUNdFbuQZpKjkuIqq8lSnLf/jHiWTyYhMXVR8Q4FSOfdabSugFLUTX/U1xNKcm4rSRbTn XZl4TBou3U+Trqg= X-Received: by 2002:a05:6a20:7288:b0:3d2:89db:1688 with SMTP id adf61e73a8af0-3dd5f3f9548mr2947733637.2.1789534890268; Tue, 15 Sep 2026 22:01:30 -0700 (PDT) Received: from phuc-desktop.. ([183.91.15.56]) by smtp.gmail.com with ESMTPSA id 41be03b00d2f7-cc50abb1776sm850589a12.27.2026.09.15.22.01.26 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 15 Sep 2026 22:01:29 -0700 (PDT) From: phucduc.bui@gmail.com To: Mark Brown , AngeloGioacchino Del Regno Cc: Liam Girdwood , Matthias Brugger , Jaroslav Kysela , Takashi Iwai , Cezary Rojewski , Cyril Chao , Kuninori Morimoto , Dan Carpenter , cassiogabrielcontato@gmail.com, linux-sound@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-mediatek@lists.infradead.org, linux-kernel@vger.kernel.org, bui duc phuc Subject: [PATCH v3 10/12] ASoC: mediatek: mt8189: Validate sysclk frequency Date: Wed, 16 Sep 2026 12:00:17 +0700 Message-ID: <20260916050020.14575-11-phucduc.bui@gmail.com> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20260916050020.14575-1-phucduc.bui@gmail.com> References: <20260916050020.14575-1-phucduc.bui@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" From: bui duc phuc A zero frequency causes a modulo-by-zero error when validating the I2S clock frequency. Reject it before performing the validation. Fixes: 7eb153585598 ("ASoC: mediatek: mt8189: add platform driver") Reviewed-by: AngeloGioacchino Del Regno Signed-off-by: bui duc phuc --- Changes in v2: - Check for zero frequency since freq is unsigned.=20 Changes in v3: - Add Angelo's Reviewed-by tag. sound/soc/mediatek/mt8189/mt8189-dai-i2s.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/sound/soc/mediatek/mt8189/mt8189-dai-i2s.c b/sound/soc/mediate= k/mt8189/mt8189-dai-i2s.c index 8cd5ddf62d46..c9e80ef42f60 100644 --- a/sound/soc/mediatek/mt8189/mt8189-dai-i2s.c +++ b/sound/soc/mediatek/mt8189/mt8189-dai-i2s.c @@ -1287,6 +1287,9 @@ static int mtk_dai_i2s_set_sysclk(struct snd_soc_dai = *dai, dir !=3D SND_SOC_CLOCK_OUT) return -EINVAL; =20 + if (!freq) + return -EINVAL; + i2s_priv =3D afe_priv->dai_priv[dai->id]; if (!i2s_priv) return -EINVAL; --=20 2.43.0 From nobody Fri Sep 25 06:02:54 2026 Received: from mail-oi2-f13.google.com (mail-oi2-f13.google.com [74.125.231.205]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 07ABB3BE17E for ; Wed, 16 Sep 2026 05:01:36 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=74.125.231.205 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1789534899; cv=none; b=MdC7uZwGGD89zQVvbmlm/52jiGlE0icR7Z6fsFjnGXagZxSpyo8c296u8iivalFgag2FZacryVv/G8lvH8YQjoOaSR9LzfEkXmIwVF8CR1mrpE4l5m03UACH7FwvK2lMSTq4z0uSXxEjuxmC5exSEEonyohcTGfIWBZWrrinGRg= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1789534899; c=relaxed/simple; bh=lIeCLIr2sVuwfKmGBusqVfb4nxMq6QbYAHerlA3l9mU=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=fHKpxD6AM280oMJUJKDE/pcPSenKL6MzGZWLe68DG5D81g3xhz1j5EO0Bb9U94G9eYa3dS4lASFypr6sRuSk1vrQHUgj0cW/DCfZKa//0WnmpeeqwPWi5Lh/NqsxUs0lpYStbaoDnI1ioWI7E5TCpW8XTV5TpI0oIA/t9WStCVM= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=fyWj4ZCh; arc=none smtp.client-ip=74.125.231.205 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="fyWj4ZCh" Received: by mail-oi2-f13.google.com with SMTP id 5614622812f47-4c0776592e3so317186b6e.1 for ; Tue, 15 Sep 2026 22:01:36 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1789534895; x=1790139695; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to:content-type; bh=IvZwvf16j3ZKmO5l7pN+WcP86Sh39SLeqVvmvvinM4o=; b=fyWj4ZChlbTn6Y+OkZC7WyXHiiAO+KhS14zLUgrDBl2bocmp9SdZLLs/xrNnvpyELT h/fW0PHL4KiSCTC5hL6CuNGwWb2L1h9bR3a0MdUruQglhHnFT54H3VfHM6gMkh78HpTN uBloUBN0oAh85FIEfyJ5OaRpgnAG1ruvaavhV5MjOX/hhJBgDN1NjtAazawYjUYqJXyh 2qroDNYLNn/rbAcKUdPauAJd3YM6PO6RlCX0xNxoG6QczQ8TPpLi99y8yBF+6rXdT9sa m6XNJIo9xA34pgvM4DC6Ct0lc5htuK3MAcCH93nmndz/Arx1rajl5jJUStOqcLV3Y9FO fGjA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20260707; t=1789534895; x=1790139695; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to:content-type; bh=IvZwvf16j3ZKmO5l7pN+WcP86Sh39SLeqVvmvvinM4o=; b=lcOskgQMagThDjxbeZVSBrZfuJhkIy/IeQKmhNlL+x0OqyudS2kBPW2ZhK1u3Sz8Mr RQGtCgVAaizlq0dVRO3Nd7PNjpWiI5hMYgz0qSeUhUflVXvd5rX+urQCr3/YnLNxtF/N R9QBlihS1PfbtBL3tjPP/Ci++0oRThuHUHLg5UsDp7QRFzr/n+50V6HQdqYqc3/0mJFo 7Om0QGhanhuQB49IrnnxWf9VZ5QyBgSnIzKWEm3xWcI7obDzQp+LsATNriaoL+z9HNgB eGT/GcEupj2nX3OJSFs1Ptccw+Y/Zm7pPUy7ktlMKbGnQtZhf2XfUYIEqhVjAyh7ducz TL9A== X-Forwarded-Encrypted: i=1; AKwUvBzKtYmQG2GaJrDaqeOWObvuTGvejfV1bJxPYUz/IIgxT9AVfWbhaL3gBQU9M5FHaD8BItyE6dJv5n9jeRw=@vger.kernel.org X-Gm-Message-State: AFuF++m/T4/q7Sk4k0dCss4HYuHp9U/GWQfljTwBDEBVjdJWnbXw9CST sJSTqUifbEyx/PYnhSArj0dW+PKpl+60adXPlUoWBlvY/XBkgsXHO+S9gZA5qQ== X-Gm-Gg: AYBFou1hWf9Cnp4OkuZtvpxEmfjLxvXcjFPTXtfO5v/JIPAyCPKABA3yQVHWOZS5meX b393fJFjorh5ohq1AxbhxjzyBbJn2Wx6EToyVufltY8pdzG746Ev4h05XExWC9zB2WjNQCgIRib /+v8WXOhRR9eu+uZ3Jtz633BpWf4fVHOMTVGi0ytE3GWC37vWbplN1xqQzqd5KDrsIH9cJwnApA MgYGq6t9+0uB9TJ8XAkczkX25u+LNvjKTjC2zT84h7qrYbmDn8sPmH1YP9TfHJ1XOVgt/3fJI2D EmcMjKQZJrnCuOIpyIYG60UFsSP6y5zSsrwgz/d/sq8jZ1AyL85gZEVZ4Cj+UZinj7k4c5sTrqg Hojy4mEOBZah8iHUMQdTboYesPnGQZO4KcvfIn82cxDdbVgFxzBMGCmhZZ2y9vk9tsM5d/YIWtD hgSoA1zu6YhPRQwTvqNaHbE+/L68iauFCSLekhsCC9xrYhYslfvGdBGaGaUiLMEimGGMNBTVV5p d1GQmbw/2G86Ifpt4kxV7u0UWogPooumxS96O2HoKKbXuVNJaHoaxj5rLytJMXW57hfOBETtjj4 4GCi7lvzOJsursw= X-Received: by 2002:a05:6808:1783:b0:4c5:d2a5:3caa with SMTP id 5614622812f47-4ca497b172fmr1584357b6e.8.1789534895474; Tue, 15 Sep 2026 22:01:35 -0700 (PDT) Received: from phuc-desktop.. ([183.91.15.56]) by smtp.gmail.com with ESMTPSA id 41be03b00d2f7-cc50abb1776sm850589a12.27.2026.09.15.22.01.31 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 15 Sep 2026 22:01:34 -0700 (PDT) From: phucduc.bui@gmail.com To: Mark Brown , AngeloGioacchino Del Regno Cc: Liam Girdwood , Matthias Brugger , Jaroslav Kysela , Takashi Iwai , Cezary Rojewski , Cyril Chao , Kuninori Morimoto , Dan Carpenter , cassiogabrielcontato@gmail.com, linux-sound@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-mediatek@lists.infradead.org, linux-kernel@vger.kernel.org, bui duc phuc Subject: [PATCH v3 11/12] ASoC: mediatek: mt8189: Propagate TDM clock errors Date: Wed, 16 Sep 2026 12:00:18 +0700 Message-ID: <20260916050020.14575-12-phucduc.bui@gmail.com> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20260916050020.14575-1-phucduc.bui@gmail.com> References: <20260916050020.14575-1-phucduc.bui@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" From: bui duc phuc mtk_tdm_bck_en_event() and mtk_tdm_mck_en_event() currently ignore errors returned by the MCK enable and disable functions. Propagate these errors. Fixes: 9f202872ba04 ("ASoC: mediatek: mt8189: support TDM in platform drive= r") Signed-off-by: bui duc phuc Reviewed-by: AngeloGioacchino Del Regno --- Changes in v3: - Do not pre-initialize ret; set ret =3D 0 in the default case. sound/soc/mediatek/mt8189/mt8189-dai-tdm.c | 16 ++++++++++------ 1 file changed, 10 insertions(+), 6 deletions(-) diff --git a/sound/soc/mediatek/mt8189/mt8189-dai-tdm.c b/sound/soc/mediate= k/mt8189/mt8189-dai-tdm.c index 5d68a55ccc45..9aebd0320614 100644 --- a/sound/soc/mediatek/mt8189/mt8189-dai-tdm.c +++ b/sound/soc/mediatek/mt8189/mt8189-dai-tdm.c @@ -261,22 +261,24 @@ static int mtk_tdm_bck_en_event(struct snd_soc_dapm_w= idget *w, struct mt8189_afe_private *afe_priv =3D afe->platform_priv; int dai_id =3D get_tdm_id_by_name(w->name); struct mtk_afe_tdm_priv *tdm_priv =3D afe_priv->dai_priv[dai_id]; + int ret; =20 dev_dbg(cmpnt->dev, "name %s, event 0x%x, dai_id %d, bck: %d\n", w->name, event, dai_id, tdm_priv->bck_rate); =20 switch (event) { case SND_SOC_DAPM_PRE_PMU: - mt8189_mck_enable(afe, tdm_priv->bck_id, tdm_priv->bck_rate); + ret =3D mt8189_mck_enable(afe, tdm_priv->bck_id, tdm_priv->bck_rate); break; case SND_SOC_DAPM_POST_PMD: - mt8189_mck_disable(afe, tdm_priv->bck_id); + ret =3D mt8189_mck_disable(afe, tdm_priv->bck_id); break; default: + ret =3D 0; break; } =20 - return 0; + return ret; } =20 static int mtk_tdm_mck_en_event(struct snd_soc_dapm_widget *w, @@ -288,23 +290,25 @@ static int mtk_tdm_mck_en_event(struct snd_soc_dapm_w= idget *w, struct mt8189_afe_private *afe_priv =3D afe->platform_priv; int dai_id =3D get_tdm_id_by_name(w->name); struct mtk_afe_tdm_priv *tdm_priv =3D afe_priv->dai_priv[dai_id]; + int ret; =20 dev_dbg(cmpnt->dev, "name %s, event 0x%x, dai_id %d, mclk %d\n", w->name, event, dai_id, tdm_priv->mclk_rate); =20 switch (event) { case SND_SOC_DAPM_PRE_PMU: - mt8189_mck_enable(afe, tdm_priv->mclk_id, tdm_priv->mclk_rate); + ret =3D mt8189_mck_enable(afe, tdm_priv->mclk_id, tdm_priv->mclk_rate); break; case SND_SOC_DAPM_POST_PMD: tdm_priv->mclk_rate =3D 0; - mt8189_mck_disable(afe, tdm_priv->mclk_id); + ret =3D mt8189_mck_disable(afe, tdm_priv->mclk_id); break; default: + ret =3D 0; break; } =20 - return 0; + return ret; } =20 static const struct snd_soc_dapm_widget mtk_dai_tdm_widgets[] =3D { --=20 2.43.0 From nobody Fri Sep 25 06:02:54 2026 Received: from mail-pz2-f12.google.com (mail-pz2-f12.google.com [74.125.228.12]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id BC85F3B8124 for ; Wed, 16 Sep 2026 05:01:41 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=74.125.228.12 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1789534903; cv=none; b=SfBvMS0HiH/SgLlGEbWTzwSNeOtinEpGnhDKR8mdbGAQ5pQ708amlv+bRIQOdITFzjxAX122qOH3kqzqCWPAxFnSpHBbw5+NyeoekwCYAQeRu/+9oUPd6J1BuAMy+IqmdAIaRXfd0GYWGCxN3xvnUAkPGT9aW/t7lxQjZZ+UEOs= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1789534903; c=relaxed/simple; bh=IsAFDMAvv2PPza76qRYZGtakVEj0dj2ce+A6qA3jXuQ=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=eaABAWN2A5g6BXC0FNLxFtmL11w8xHKitW2rPk8XcF9P9CXUWDND57HaWAlvmIo2BimQfVF+XTyEYfoyUKJVkyRvsVtPlJd9RKnXrDxelmeWSa6tbY6kqOpVnXvyt0+WCMc8fYlsQEs+F/gKWNDUolxhscSVHbYIIYAbh8wVtWw= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=WITcWrT8; arc=none smtp.client-ip=74.125.228.12 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="WITcWrT8" Received: by mail-pz2-f12.google.com with SMTP id d2e1a72fcca58-8674704dab1so645512b3a.2 for ; Tue, 15 Sep 2026 22:01:41 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1789534901; x=1790139701; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to:content-type; bh=9y50VuB/l2kLa1542VqPbt/G57KIRr9fbdB6tbrEkBk=; b=WITcWrT8GNIxsSx4IDqcvl+ToelDc9QjLr/ONjAKVBPkzvrsiKTWWM11v6zXPVx6cX 2E7zvRXl6OAttcMA6ABD5qDPofNoDHhYnPdA3c9K2CuNayLVd/RCHzKfmRJ6jY2nwQwf lNRyLxNjD1BmVL3tyK2AcRVFX2x+7B3XNabffue9spcylKlb2ClMcGXvSvilqCFHvOA3 GcYToDgrNIXWC2OrGLjBDBbSRNOjTXvi+/owpeF+h/XS5JHNrKgw5HujcfJ9Adubm/B2 KWnQQOdGcHTgMaN34z48Sw5gXer7lfxEZEps4/I7s0ZNniESaDdLzOLlBcud26+2usmr Z93g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20260707; t=1789534901; x=1790139701; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to:content-type; bh=9y50VuB/l2kLa1542VqPbt/G57KIRr9fbdB6tbrEkBk=; b=cvhh9foqFeOQ5lbvvgF747hBPjo+cxaNPdYgXflawa7/jUdcW2VYqsBVDS4TXsvV9o LUiSefl07WDJ3MneHd8nJOjRakSm4dZ1ngMg7XFDCP8vC04S6KR5FiwT65i4DnH5oqdB Cff17hwykqvL06x386tKH/rcWo3h6RcRRAdze8XvkeBWA3AlI9InXDVvdrIDNTgB5ELK Bzf/1OIBTo9ba53hNiXUzSlO35d8BPQvgFzm6C+dKjzqAz1Xnoi0WhV00jKMarfl3xaU 2NK9qoGS/tm3DUX75/gh+bk1KsXykI0CEp6ttHQilcwqUtq2fCSm6CvuF19/U9DlgN2d iukw== X-Forwarded-Encrypted: i=1; AKwUvByAOYU0kn1WPaV32A2ebYQlk5uiTDBDZqEltYLRc9LFKeUE7io5ptlkVX9QRgbivpQM9V7T1C6qTsugOEM=@vger.kernel.org X-Gm-Message-State: AFuF++kWjpQlQkVx77huKQ+JEnhSHD89UWQ5vPhKfCAR9W4W+jy0PBJn M1biGSl1cmO3a6nSqOqUzW3t47CsJVlquRvlVKYx/eo8JBr9FTLWpD24 X-Gm-Gg: AYBFou1yhrVR81/YtwutguvrpFQaIyNnfnmUebYRdIp0FJCZ44DNqepfB5qq3wGlGzN 6wsNIQDuFixv58yiId1iA6A6oJAlt8ykLDq2rB88ppFNTNLdS+RWSOIKWjiJnzP0yaL6i3r6Qrk rxMAQiYg/oaybuyYmM8q51y2badBaU7LfuhsDJ4XNRnRwdcemFpmxLBrdcle/+SNJRZDs0gJSas 66Wg4UEa5hBl5XKDpoL8nxZ1tuoU9UAlytCEfA05Ter7f2O+A5fJNcbmnCxSVGCkkYtcUvIrNJD RXDnUtkbgab36OKCA7EYV4c0vaRYFelg0oGKHOBW8OWyve1+Hs+j2if2WT/FMbvDwgsKtQjoC9z 8srtzZ0UFHCnrqVKp52xZvC7woLpctcCBaVuyFtyQjMolCjIunHUwAb+HdLFdxeJ0URzdaGfc2l /ZZ8rwNmS1FWw6Xycskgks/7oquFoFHy958UJLtbuIMwYvZNEJoDNad9ETRA3xl7UpA6B27qSJl 8V4SbecFxiCxUsO5kjL8peSpAs/7S6S/+z1BFTJT+AaVtTEh60I//v86gfGkVqS773twij1hMN2 wNzUNNhjCpP2qOg= X-Received: by 2002:a05:6a21:6803:b0:3da:e1b5:2baa with SMTP id adf61e73a8af0-3dd5f4041a7mr2929083637.2.1789534900789; Tue, 15 Sep 2026 22:01:40 -0700 (PDT) Received: from phuc-desktop.. ([183.91.15.56]) by smtp.gmail.com with ESMTPSA id 41be03b00d2f7-cc50abb1776sm850589a12.27.2026.09.15.22.01.36 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 15 Sep 2026 22:01:39 -0700 (PDT) From: phucduc.bui@gmail.com To: Mark Brown , AngeloGioacchino Del Regno Cc: Liam Girdwood , Matthias Brugger , Jaroslav Kysela , Takashi Iwai , Cezary Rojewski , Cyril Chao , Kuninori Morimoto , Dan Carpenter , cassiogabrielcontato@gmail.com, linux-sound@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-mediatek@lists.infradead.org, linux-kernel@vger.kernel.org, bui duc phuc Subject: [PATCH v3 12/12] ASoC: mediatek: mt8189: Validate TDM MCLK frequency Date: Wed, 16 Sep 2026 12:00:19 +0700 Message-ID: <20260916050020.14575-13-phucduc.bui@gmail.com> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20260916050020.14575-1-phucduc.bui@gmail.com> References: <20260916050020.14575-1-phucduc.bui@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" From: bui duc phuc mtk_dai_tdm_cal_mclk() accepts zero or negative frequencies. Reject invalid frequencies before configuring the TDM clock. Fixes: 9f202872ba04 ("ASoC: mediatek: mt8189: support TDM in platform drive= r") Reviewed-by: AngeloGioacchino Del Regno Signed-off-by: bui duc phuc --- Changes in v3: - Add Angelo's Reviewed-by tag. sound/soc/mediatek/mt8189/mt8189-dai-tdm.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/sound/soc/mediatek/mt8189/mt8189-dai-tdm.c b/sound/soc/mediate= k/mt8189/mt8189-dai-tdm.c index 9aebd0320614..e113c52fe06a 100644 --- a/sound/soc/mediatek/mt8189/mt8189-dai-tdm.c +++ b/sound/soc/mediatek/mt8189/mt8189-dai-tdm.c @@ -383,6 +383,9 @@ static int mtk_dai_tdm_cal_mclk(struct mtk_base_afe *af= e, int apll; int apll_rate; =20 + if (freq <=3D 0) + return -EINVAL; + apll =3D mt8189_get_apll_by_rate(afe, freq); apll_rate =3D mt8189_get_apll_rate(afe, apll); =20 --=20 2.43.0