From nobody Fri Sep 25 06:00:34 2026 Received: from mail-pj1-f41.google.com (mail-pj1-f41.google.com [209.85.216.41]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id A48DC31B130 for ; Wed, 16 Sep 2026 03:45:37 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.216.41 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1789530339; cv=none; b=HRWMandwdMwdrAP4EOlt0SU8144u43NE693XOoHKgSC2E0Swmr5owGgg/c9jUEdx+zNSUKXkK6eHZd6NgKV2ntPuHbqN5VxjHmIzDOP+pBfedNpyVkBxhoCINQDWHXAfv0sHlebpn5WFjYw+aDutQBC9jQQcr0bJ37Gzx5zQbUA= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1789530339; c=relaxed/simple; bh=kj+jwfz2ESgc5zFDsF3Qm12OZV92X1W7h3OVHgPgo7Q=; h=From:To:Cc:Subject:Date:Message-ID:MIME-Version; b=SD3Q33ZrkeXKJCy3ECUL4YU7MdZvYR8Atq/tjqShu4WMqfwcXDyCRpt/9o5qmDJmN9AeEK3ATG4JpokKgC+2+NhIjWL9jk4v26tPMtfoZWhXlCiAhC8FkcfXcgslf4gA7rZVXMXs+zc4Fc6hSqMqxHCpdXCPWywjb13Cx8DCtpg= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=asu.edu; spf=pass smtp.mailfrom=asu.edu; dkim=pass (2048-bit key) header.d=asu.edu header.i=@asu.edu header.b=rKlYr2eA; arc=none smtp.client-ip=209.85.216.41 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=asu.edu Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=asu.edu Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=asu.edu header.i=@asu.edu header.b="rKlYr2eA" Received: by mail-pj1-f41.google.com with SMTP id 98e67ed59e1d1-39647184c73so1448474a91.1 for ; Tue, 15 Sep 2026 20:45:37 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=asu.edu; s=google; t=1789530337; x=1790135137; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to:content-type; bh=G8OBnZpdkznSDHoOVDOJgOwhfNo4gWFfvtnI5e7GBu8=; b=rKlYr2eAUhKC02NildikSqpZUTltbAtlFj8cRVwAWM/zt1x1Etb/5wA1cSKN0fbSWl 2XF0CRkek3auZZVQNszH/ceTS0wRxShcOseNnMIO3rLjEvSU7MgM6Aq3684/WoMtNwkC 3FcmKKAjTUbdwH1mz1pmmZM/CVGCDNtZO+QhY6Rvtl/aoxBZYjs2Rb754rfQdJhqWiR/ LffFB56cX2XirC2dU+3hX/3TKIbNHYAS6K9mFOc+SW1nQVafgSEzwxaQbuNyTytj+rcv tuCU5iVSGo7hXAbE45W5q0QoYP72LctF7zdJSuBlD92+UNz/ckuzFzWSbL5csCjfv25f jgNA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20260707; t=1789530337; x=1790135137; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to:content-type; bh=G8OBnZpdkznSDHoOVDOJgOwhfNo4gWFfvtnI5e7GBu8=; b=FTXfQRNpvCs7yh+qb5K7eDekHBM4/DhYvGX95U5qnTBUP1o4sg709dY/3lKEO3hyEL u9n+Qkh/Ab49bXSw3n8mYzKKbFPrTWVs7w9kDVuI+/MWAT7KnQSZgaO2LEAUo0Ejm929 nRM3ls+VUZeng89gcUc7tUOfG8aReg8zDW0KLHr9mRRcjfs77zTvG+jNfO7JCX9AGoNx u+9Z72uDkx7HZq8dQzkixHLuinLLKljSfBVv8JH7iCdPPcsDyCn/ZI/hwWMOfoYbBk6e c19BULlyhY4c7V6IgwvqWtSE/9lRKxJb5j3ojTEEigUGv375Qfq4wVWUaOuEcwPQl7YJ OoWQ== X-Gm-Message-State: AFuF++mU2dgD1LAqlIw43k5//xetw3f6hIxeYpfwITIu1uuZL/f+dYbx IkoKMwBckLmAt2+vb5hcOJEBHdL5qF7SWvOmnN9YAB2G0rvjzVXVQ8IXafZqd5at1Q== X-Gm-Gg: AYBFou23JFsYYRtTBwVg+V86n6mlYqC7Mv7DdEYGFKysK7kbx1FhlZoUm+rMwAkk+w+ 2P9okykDskw76y++OZy4j9NSw4PdJEjOltVlW70g5dLp/+R7T4HiI1oS6ZdTmlVkR+itNrYA5AF hHQcFaZkxWr8DDCQ/ndFiDcFg3MiTwbiQDYMVHV1wVRWdyaYpokC48SOdbk4OILn8G8XfkJLx2C ifpDPnDeNkHtqFftc4Be5SF2ev82/5uN1AsKeeSmtwiCGsUE+pXxY71tiN+ufyNkazoznv53BT/ 3r7Jnxr95+/LUDgTiUwL4gUI2UcV/d3o7+8vFriIFLbXtye6LVzUb/lcID32u/TkQMN5Z3gZ/ST SKC2yYQ4Kgsg7LGnvkBbZ0qKpcC18Rfq2cDUEIAYRWu5ooTBKAyKst7TntTk5ttHO5BjIhJHJ/S sY57oR8YGY1v7+z3OzlQbpSeWpqQm3rmZSgRpdz2WJZWDVj0wL1MOLuDK7Su+JEqQVMWYSxqeSP I1hDlSO55OfEN4lbqFbCkMJUR0QULn/pOMz8rwY0B5bDuN4Pegipasz X-Received: by 2002:a17:90b:35cb:b0:39e:1e25:c6fd with SMTP id 98e67ed59e1d1-39e1e25f48cmr1670277a91.30.1789530336957; Tue, 15 Sep 2026 20:45:36 -0700 (PDT) Received: from xps.tailc0aff1.ts.net (149-169-99-5.nat.asu.edu. [149.169.99.5]) by smtp.gmail.com with ESMTPSA id 5a478bee46e88-33bf5b2753csm6953812eec.31.2026.09.15.20.45.36 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 15 Sep 2026 20:45:36 -0700 (PDT) From: Xiang Mei To: hverkuil@kernel.org, mchehab@kernel.org, linux-media@vger.kernel.org Cc: linux-kernel@vger.kernel.org, co+ac0ebfcd53bd2316@bugs.sh, stable@vger.kernel.org, Xiang Mei Subject: [PATCH] media: go7007: only set audio_enabled if go7007_snd_init() succeeded Date: Tue, 15 Sep 2026 20:45:34 -0700 Message-ID: <20260916034534.863732-1-xmei5@asu.edu> X-Mailer: git-send-email 2.43.0 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" go7007_register_encoder() sets go->audio_enabled before calling go7007_snd_init() and discards its return value. go7007_snd_init() assigns go->snd_context only on success, so a failed ALSA setup leaves audio_enabled set with snd_context still NULL. The disconnect path tests audio_enabled and calls go7007_snd_remove(), which dereferences snd_context unconditionally. go7007_snd_init() returns -ENODEV once its never-decremented static card counter reaches SNDRV_CARDS, so SNDRV_CARDS attach/detach cycles arm the next attach; no memory pressure is needed. Set go->audio_enabled only once go7007_snd_init() has succeeded. Oops: general protection fault, probably for non-canonical address ... KASAN: null-ptr-deref in range [0x0000000000000000-0x0000000000000007] Workqueue: usb_hub_wq hub_event RIP: 0010:go7007_snd_remove (drivers/media/usb/go7007/snd-go7007.c:273) Call Trace: go7007_usb_disconnect (drivers/media/usb/go7007/go7007-usb.c:1336) usb_unbind_interface (drivers/usb/core/driver.c:461) device_remove (drivers/base/dd.c:618) device_release_driver_internal (drivers/base/dd.c:1349) bus_remove_device (drivers/base/bus.c:664) device_del (drivers/base/core.c:3965) usb_disable_device (drivers/usb/core/message.c:1478) usb_disconnect hub_event (drivers/usb/core/hub.c:5966) process_one_work (kernel/workqueue.c:3396) worker_thread (kernel/workqueue.c:3560) kthread (kernel/kthread.c:436) ret_from_fork (arch/x86/kernel/process.c:158) ret_from_fork_asm (arch/x86/entry/entry_64.S:245) Kernel panic - not syncing: Fatal exception Cc: stable@vger.kernel.org Fixes: 866b8695d67e ("Staging: add the go7007 video driver") Reported-by: Assisted-by: LLM Signed-off-by: Xiang Mei --- drivers/media/usb/go7007/go7007-driver.c | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/drivers/media/usb/go7007/go7007-driver.c b/drivers/media/usb/g= o7007/go7007-driver.c index 453ab5c3aa03..7db2440886b0 100644 --- a/drivers/media/usb/go7007/go7007-driver.c +++ b/drivers/media/usb/go7007/go7007-driver.c @@ -306,10 +306,9 @@ int go7007_register_encoder(struct go7007 *go, unsigne= d num_i2c_devs) if (ret < 0) goto err_free_controls; =20 - if (go->board_info->flags & GO7007_BOARD_HAS_AUDIO) { + if ((go->board_info->flags & GO7007_BOARD_HAS_AUDIO) && + go7007_snd_init(go) =3D=3D 0) go->audio_enabled =3D 1; - go7007_snd_init(go); - } return 0; =20 err_free_controls: --=20 2.43.0