From nobody Fri Sep 25 05:31:34 2026 Received: from mx0b-0031df01.pphosted.com (mx0b-0031df01.pphosted.com [205.220.180.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id A766C4D0A1C for ; Wed, 16 Sep 2026 10:29:26 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.180.131 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1789554582; cv=none; b=YBbbwYxroHRtu/u7dAvBSMSOrtCrLf0hgWNaob1GZsUaqrGy1dldrgecI5NAGSMEk+PyRyVYxOBqdcvRCVYmFSVJiXxxXU8CwxvNuMD1ud53jipKD+pfjd8sxJeKdWgdSH6orhR53UjQgf2OJgg7ZytEPLK9tB2O4xe+sB1RQXI= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1789554582; c=relaxed/simple; bh=VqEBhAc+je+QLk1thcaX/xUiR2txfR576Si9Id9vd9U=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=HlXPqSbxto66CiA3PQpHoGA4RzjcBDoquC4yexIrYUb7ViuNXoONvgNvn+jE594mcyc/lEnsjSXuOYCPgdEFvkJE36QFJ0jpzFrD9TJC90eSzMh51sgCMbUXPBBGzOrq31qteVaA7x4USb4/cuSLthQSryItpgmpmoWGxpYAtCA= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=UhxIkExT; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=aw8DsoSO; arc=none smtp.client-ip=205.220.180.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="UhxIkExT"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="aw8DsoSO" Received: from pps.filterd (m0279873.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 68G934fF2226509 for ; Wed, 16 Sep 2026 10:29:19 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= WCNL0ejjcavhoD0Cb9ydVzVR4/0kvlSG9IlQISXrxEA=; b=UhxIkExTGLr6ksiV Ck9zenvLkpEFVQkjBpLnIxr9QsX9Dt/YtwiV5HH6ptQ2EtE80oooriAUiCYeX6aC xCtYUe0QGXDv/nsuWJz3WeCHbVE6ojPQb4ED+n5L1C7X9VjQz+GfrnwMJQNJtD6X G2fnCodx6WKt4i+OQXGQwJb5hkcxmT0gatjoHQsoJwIHN6u+e1XhIceHAF0cKot/ TidwSzBJ47ANyG9xr1FmIYkskqkgoSQmWIM8vIK5eOhUJKBiNiNugguHaIYXOahH UTD0eLR0XDVk5wQISoELlSK3ZY7lMfPvRRM3MkDTZnlUdgA9IS0bs7VBNhezaynw 0QTKtg== Received: from mail-qk1-f197.google.com (mail-qk1-f197.google.com [209.85.222.197]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4gqah9usxj-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Wed, 16 Sep 2026 10:29:19 +0000 (GMT) Received: by mail-qk1-f197.google.com with SMTP id af79cd13be357-93a183a0e93so674959885a.1 for ; Wed, 16 Sep 2026 03:29:19 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1789554559; x=1790159359; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :content-type:mime-version:subject:date:from:from:to:cc:subject:date :message-id:reply-to:content-type; bh=WCNL0ejjcavhoD0Cb9ydVzVR4/0kvlSG9IlQISXrxEA=; b=aw8DsoSOC+PN6DrdN/UjIQNlu+Bpk6T5f7Nb3rUmhCsGgWpY1t1A7bbS0t8c1lry9l uKNIm3spMfa5VuzjPTTiM2hqc6kr2sx31vPYosTeZKqjakXDVgi3dKYmf25luOeovTkT s6Ao0RqgpJ7RzW++NT/owQhlbTLeLpGkjfRsT2Av5s61+wSVT/jC3ACsnkh5y/LQgAm1 yy25kPxLvAvCdwN/9qybZAkMh7PV9Qy9LAjNLQPz5SSd3D9O/fWb705OB5IdGpL+yxr+ PqSMnWqb5NMazxWtsreEEjF/jmQUOTpKJGxc/9y0XPZu1Ocvwce9fZ4A1P8NC+Yuxjtn Xhfg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20260707; t=1789554559; x=1790159359; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :content-type:mime-version:subject:date:from:x-gm-gg :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to :content-type; bh=WCNL0ejjcavhoD0Cb9ydVzVR4/0kvlSG9IlQISXrxEA=; b=zM04AYbMKx6RBnFgZWZ3Y1frmfrd9uFNUsHR8Yw5g2D40a+O6+B32+/La97818ZKKo 47e0QHhX8WHkEwPuCwdEfipyP0swBBGYi54b3Qi85UiY6KWgVW/P5REJjZM+Ot+st7Yg MstaDev6uPzg+h6BL3xrHYw+j6VnZJUEF0ypod37EbQ6GKo7cmDY2dPhURV1kbZpAWU9 wOziYtTh4Nuav7LFyOswn3qdBbicD4LTnhjhleE331ZgCojncjgK6awu5d5iTlgtZi6L n80G8rIwkg4rHzp54M7ElIWswQSSesC40xGu6G6/V9oeRne5FAFKDW8KG0S1LPRim5ha ninw== X-Forwarded-Encrypted: i=1; AKwUvBzz7M1Oys5t0wtQDlfxAE+Z/NKX9I3WNq6Y9j9mnlTyZMh6o47R0dt8sTBRw/w2I65qjBW17jifEQUL5sw=@vger.kernel.org X-Gm-Message-State: AFuF++m4en7kS9OCPMGdmdxYTVGdRxZwXaVYLRpaYmxbxRfxj7RqRpAN xV0O8/3u4boYwS0ZWiSIU3pBeg4q1UqOkoV7aOXFM6tDSdye4F3Ai4lnDxGJOkan2tbEvqbvR0N mVWE1l/okL/dpwN4Er8J8+c+9SmjLojItHG2GtaIZtpzjESHJ6cISJRWJvqvcgGWCU6M= X-Gm-Gg: AYBFou1nuK2BVyGQVP7GzRtCOW6SguglUqf5hHdIDz0n2E2yXKXDV7JSvxnWD+XAZ3D aEMrC7YwsYXSikZ0uRbeNXyxAxjlb9KXEdTbIZI/cr/mFKeIe5UcC0w199KeYDl2x1n5/etr7i1 dXEWlvqrErrXoJ4Iyq7Zf+tBVpoHT35PtyXDVFHAuwh2HKnHXLRC/5vtdG0+5WFEndikOJR0Jh3 9vodIJEuuqwND5DgMLWz/F0dsCGQDtavocVURj4xM2Qwi0rV82OA3Uqk64DAHwQuwsxm5KNS73k qVIzjtr1U+t2eDCc9YFLEXlOY0D/aGEyVQYbme0gVR5k3OnqvaW0oAjRUrASHT1KaZ4aiLN1UIe OdnV7hus= X-Received: by 2002:a05:620a:4693:b0:939:de6c:cb45 with SMTP id af79cd13be357-93bb793e1f1mr298993885a.47.1789554558701; Wed, 16 Sep 2026 03:29:18 -0700 (PDT) X-Received: by 2002:a05:620a:4693:b0:939:de6c:cb45 with SMTP id af79cd13be357-93bb793e1f1mr298989485a.47.1789554558151; Wed, 16 Sep 2026 03:29:18 -0700 (PDT) Received: from [127.0.1.1] ([86.121.170.232]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-49e83dbb0c1sm71633805e9.14.2026.09.16.03.29.16 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 16 Sep 2026 03:29:17 -0700 (PDT) From: Abel Vesa Date: Wed, 16 Sep 2026 13:28:17 +0300 Subject: [PATCH 01/48] clk: qcom: camcc-sa8775p: Use common probe handling for always-on clocks Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20260916-clk-qcom-rework-legacy-always-on-clocks-v1-1-25a24e50f82a@oss.qualcomm.com> References: <20260916-clk-qcom-rework-legacy-always-on-clocks-v1-0-25a24e50f82a@oss.qualcomm.com> In-Reply-To: <20260916-clk-qcom-rework-legacy-always-on-clocks-v1-0-25a24e50f82a@oss.qualcomm.com> To: Bjorn Andersson , Abel Vesa , Stephen Boyd , Brian Masney , Jerome Brunet Cc: linux-arm-msm@vger.kernel.org, linux-clk@vger.kernel.org, linux-kernel@vger.kernel.org, Abel Vesa X-Mailer: b4 0.16-dev-0e65f X-Developer-Signature: v=1; a=openpgp-sha256; l=3027; i=abel.vesa@oss.qualcomm.com; h=from:subject:message-id; bh=VqEBhAc+je+QLk1thcaX/xUiR2txfR576Si9Id9vd9U=; b=owEBbQKS/ZANAwAKARtfRMkAlRVWAcsmYgBqqm9LD0sjyesYKIoV0/4C9ypVNoFj3s6SMvr/J 9srqvc4UHKJAjMEAAEKAB0WIQRO8+4RTnqPKsqn0bgbX0TJAJUVVgUCaqpvSwAKCRAbX0TJAJUV VnvzD/0X463c3vRToWa0/H0xRHYuwCZm7CpCyBw64RZMS17w2Q5L0LeMjR49NWypljWexF3HNsZ Ud8YvehPpNdjJrvmf7Zay2CrJTPHSXXrtMl0eLUCe45iNZF6OgG4db3jF9ZUwRGiU+oLImadjcq gsBqNunngj+PUTIvKRcJamtTs6bQ/NWgFkiirXQ0KznjlcwqQDiE4EKMKxdI591lsdu8v69W1W4 Suwcjb6M+haLUXOrdD77Tqc7cn9pZlKiI2yPOh+BlA+dDlWyIm0zqDsHX7qqAx2X3tULSsI3Kwy +TmntwhG0hmaa9rMAsgyPxoRimrx++DQ0ekzrzefbJew1HM0ScsqVHrWlxdkFMgBAIJchhiRDG2 Rt/oI0gtBieONAEJgYfXCSMVi03BY3RNVX3Am2EesynW75DVH0JnZQDJu/U3exT5wGqIGIAp8Sn wwFkJtfCADVMgEwzIXZDni411TtkUy7WHixUog0yfpZXta/CMqPFbsY4vFF10nK6ZN2Yw5naA6/ NS4f8QYfXw/DqQq+sbKFlnzcCa8sXBPJhGQSddWXRdfKuKSHSE4Eu061dnhYM9QdtuFaPl2ooui nU8bQhvmSkN5DEj59AuBcmz0TKW6ChDWpaMK5VwXuyD3I+v1G6esSmS/OKrd38RTjnyiFA8tD1B V5GwRdMSV6b7Z6w== X-Developer-Key: i=abel.vesa@oss.qualcomm.com; a=openpgp; fpr=6AFF162D57F4223A8770EF5AF7BF214136F41FAE X-Authority-Analysis: v=2.4 cv=BtkIUoX5 c=1 sm=1 tr=0 ts=6aaa6f7f cx=c_pps a=50t2pK5VMbmlHzFWWp8p/g==:117 a=po8fGBi+ks8MzcVQGuqtFQ==:17 a=IkcTkHD0fZMA:10 a=VdqzKS8jKosA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=rJkE3RaqiGZ5pbrm-msn:22 a=EUspDBNiAAAA:8 a=Q3HO4hYmujdu-APuiMYA:9 a=QEXdDO2ut3YA:10 a=IoWCM6iH3mJn3m4BftBB:22 X-Proofpoint-ORIG-GUID: 6c8N-fQeMkCHTsxdbIERPQPFOy6HqHUm X-Proofpoint-GUID: 6c8N-fQeMkCHTsxdbIERPQPFOy6HqHUm X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwOTE2MDEzNyBTYWx0ZWRfXzVT01DLcg1Gt a0T2y7q+NEmaeSFEOyGvr/ZqO3xxmkXMLP3fXnz4LenePbY7DqYzPU9Hspa0nz3Sk3KPCz22leG /9nKGpXVFaTvvzDuNvs3Ca60eSe94PnYlPXmyLfqkNno8H6SUQed+Lgg6gbiB8CY2NLlWEoFZET AXD9qDbijXj7odbvb5XS6EAaudl8abCEVLMb8HuQOfS88WDW5l24Hhf1ZAwsGo57LU1P2qGl0Xe D+KZc/SL0qBLpenPdjdnW0mEzwzGyX+dgFHVFM1Bj9vKbPU01yPD3+BjIGJHwShsikwOwwFqHMO +a9slzTtwFPfZIPNi58zR5Twy5KLdmcfdsn5jMsBiOR3O4DOX6jd66aY93j4ZpUd8VcIgafsRjD JG6d5t65gVxUb6FYDT3ccty3whpqXEddwa1gl2ItfvycDnkz+d8RMDmSvRsoCymyUtdKY5zwe5S ea6vNKu195baubwQ0JA== X-Proofpoint-Spam-Info: AW1haW4tMjYwOTE2MDEzNyBTYWx0ZWRfXx1oadVa8a+Qh FGUfbBIBA+RINVUvfunjLs4VC6ixL0no2Cbm7zdpbI0ZEkmTjSjme86AuPIi1Tns9rgtFDi3GB3 F5QCi8cjAQMjVXruvyP5HCdY00eh7RI= X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1176,Hydra:6.1.134,FMLib:17.12.100.49 definitions=2026-09-15_05,2026-09-15_02,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 priorityscore=1501 lowpriorityscore=0 spamscore=0 adultscore=0 malwarescore=0 impostorscore=0 bulkscore=0 clxscore=1015 phishscore=0 suspectscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2609040000 definitions=main-2609160137 Describe the always-on branches in a critical_cbcrs array and reference it through qcom_cc_driver_data. Let qcom_cc_really_probe() enable these branches instead of programming them directly in the driver's probe. Keep separate CBCR arrays for SA8775P and QCS8300 to preserve their different CAMNOC XO, GDSC and sleep clock register offsets. Assisted-by: LLM Signed-off-by: Abel Vesa Reviewed-by: Konrad Dybcio --- drivers/clk/qcom/camcc-sa8775p.c | 36 ++++++++++++++++++++++++++---------- 1 file changed, 26 insertions(+), 10 deletions(-) diff --git a/drivers/clk/qcom/camcc-sa8775p.c b/drivers/clk/qcom/camcc-sa87= 75p.c index 914478139e97..b0a8f0077dd8 100644 --- a/drivers/clk/qcom/camcc-sa8775p.c +++ b/drivers/clk/qcom/camcc-sa8775p.c @@ -1818,7 +1818,30 @@ static const struct regmap_config cam_cc_sa8775p_reg= map_config =3D { .fast_io =3D true, }; =20 +static const u32 cam_cc_sa8775p_critical_cbcrs[] =3D { + 0x13194, /* CAM_CC_CAMNOC_XO_CLK */ + 0x131ec, /* CAM_CC_GDSC_CLK */ + 0x13208, /* CAM_CC_SLEEP_CLK */ +}; + +static const u32 cam_cc_qcs8300_critical_cbcrs[] =3D { + 0x13178, /* CAM_CC_CAMNOC_XO_CLK */ + 0x131d0, /* CAM_CC_GDSC_CLK */ + 0x131ec, /* CAM_CC_SLEEP_CLK */ +}; + +static const struct qcom_cc_driver_data cam_cc_sa8775p_driver_data =3D { + .clk_cbcrs =3D cam_cc_sa8775p_critical_cbcrs, + .num_clk_cbcrs =3D ARRAY_SIZE(cam_cc_sa8775p_critical_cbcrs), +}; + +static const struct qcom_cc_driver_data cam_cc_qcs8300_driver_data =3D { + .clk_cbcrs =3D cam_cc_qcs8300_critical_cbcrs, + .num_clk_cbcrs =3D ARRAY_SIZE(cam_cc_qcs8300_critical_cbcrs), +}; + static const struct qcom_cc_desc cam_cc_sa8775p_desc =3D { + .driver_data =3D &cam_cc_sa8775p_driver_data, .config =3D &cam_cc_sa8775p_regmap_config, .clks =3D cam_cc_sa8775p_clocks, .num_clks =3D ARRAY_SIZE(cam_cc_sa8775p_clocks), @@ -1837,6 +1860,7 @@ MODULE_DEVICE_TABLE(of, cam_cc_sa8775p_match_table); =20 static int cam_cc_sa8775p_probe(struct platform_device *pdev) { + struct qcom_cc_desc desc =3D cam_cc_sa8775p_desc; struct regmap *regmap; int ret; =20 @@ -1927,18 +1951,10 @@ static int cam_cc_sa8775p_probe(struct platform_dev= ice *pdev) cam_cc_sa8775p_clocks[CAM_CC_TITAN_TOP_ACCU_SHIFT_CLK] =3D &cam_cc_titan_top_accu_shift_clk.clkr; =20 - /* Keep some clocks always enabled */ - qcom_branch_set_clk_en(regmap, 0x13178); /* CAM_CC_CAMNOC_XO_CLK */ - qcom_branch_set_clk_en(regmap, 0x131d0); /* CAM_CC_GDSC_CLK */ - qcom_branch_set_clk_en(regmap, 0x131ec); /* CAM_CC_SLEEP_CLK */ - } else { - /* Keep some clocks always enabled */ - qcom_branch_set_clk_en(regmap, 0x13194); /* CAM_CC_CAMNOC_XO_CLK */ - qcom_branch_set_clk_en(regmap, 0x131ec); /* CAM_CC_GDSC_CLK */ - qcom_branch_set_clk_en(regmap, 0x13208); /* CAM_CC_SLEEP_CLK */ + desc.driver_data =3D &cam_cc_qcs8300_driver_data; } =20 - ret =3D qcom_cc_really_probe(&pdev->dev, &cam_cc_sa8775p_desc, regmap); + ret =3D qcom_cc_really_probe(&pdev->dev, &desc, regmap); =20 pm_runtime_put(&pdev->dev); =20 --=20 2.54.0 From nobody Fri Sep 25 05:31:34 2026 Received: from mx0b-0031df01.pphosted.com (mx0b-0031df01.pphosted.com [205.220.180.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 546884E56C4 for ; Wed, 16 Sep 2026 10:29:23 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.180.131 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1789554578; cv=none; b=RnDsNgEhERBabJNwSQvBT4ICICGK904UUs7S1ZClHUytEAhNT1NViREa4orlkSqZEKrK9nJalIfGHtzP6mT93EsJkHdMq3SgIl4iuicUqpTGIEo3xENznk5ixr5LwiYSZryzeZJkDNlMFNcpXhnB8EV8sCKDHc808joOkjaa9No= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1789554578; c=relaxed/simple; bh=5kVvtWRtMetQrC301SdF709Q+ZqaylTFJGaMMYBiDNI=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=Gs+TXT8n9ue0RhW4MA4eFjvDG7Ac35WAH+hDVV/GbXihnlC/nhl/ENlseupvbrBhsknVI5K8KqWq466FpoNZhqBxpEXxwIP6wysen/RoZGGWswsaC7omc3GtDpbAjXGLW0U3Ms/RzZm98ky85PzUGulsX/kZJrvzlLWLjimyiIE= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=o4EkMDsx; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=ZSHnkmYv; arc=none smtp.client-ip=205.220.180.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="o4EkMDsx"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="ZSHnkmYv" Received: from pps.filterd (m0279872.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 68G933kk1587182 for ; Wed, 16 Sep 2026 10:29:21 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= GCnUlcNtZPRsGZqWJYJql8R0YRzfm5KccrFhdBqwbwM=; b=o4EkMDsxqvIiUL0f O/O7FtyGvbXWh+BpnC/iLPg4V5ueAa+P4zMw7QLkudrPcWOZJF5jcRr8vyOt98iR Ixs1gC91jhdqI8mb1nhBA0XYtIq3V9vZnuLpASn92bArwL3ZOfBuUWbLs/SONYLC 6R8ViNuJZfHZ0wCRoNcNfCJUj8Ot7w1LAUQDY3Mz3/Wh3uXExeUCehLHBdvRr+i6 +OJ99ugNbtJj81X/jZvbEAUrwwD4UcJXAypkI/6wJKyBfgA5sG/IQTUjcOtRE04c rpQ0z3PEYjwIpnIpfoRSlEdNrIy4YaKPCn1o3qbVuGjh4qaYsI3cjQa8qLFIrzvZ g0CuDQ== Received: from mail-qk1-f199.google.com (mail-qk1-f199.google.com [209.85.222.199]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4gqageksau-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Wed, 16 Sep 2026 10:29:21 +0000 (GMT) Received: by mail-qk1-f199.google.com with SMTP id af79cd13be357-92e82060977so364197385a.1 for ; Wed, 16 Sep 2026 03:29:21 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1789554560; x=1790159360; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :content-type:mime-version:subject:date:from:from:to:cc:subject:date :message-id:reply-to:content-type; bh=GCnUlcNtZPRsGZqWJYJql8R0YRzfm5KccrFhdBqwbwM=; b=ZSHnkmYvnbk+o4Qb8JMYZd3iaYauWBK7i5ttpttEicVSjnFHlpWVFaXA/yetbIVz8J RYEJxg08cYl2rTaMzsjWoaL2CFo8QXZgsJZu7VDxETA5FsteF1XDLxmJQv151X+s8Zvu 7oVcVwh0ktuaSq+0AQ2cBEInIBH2dD+PYMnoaxCoVZMrW3k+uRJUc1tKsUDuH2khL6Tg ahF2fTSMiTEjJP3fPP/zdvUBBpVKj4l12+BR1EEDdie06KJ2h9uBYyC7Zj4jeuiOj+RQ C8GzVpFi30RWBA1TMwUzblmiO3Yetd0zwFs9qG/YaN7yhdEFLgcBagyYI09SZhh/MM/n 12Jw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20260707; t=1789554560; x=1790159360; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :content-type:mime-version:subject:date:from:x-gm-gg :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to :content-type; bh=GCnUlcNtZPRsGZqWJYJql8R0YRzfm5KccrFhdBqwbwM=; b=MkEVJ7/jkj/Zx4qkK/z5hLd4bd6vpBPsCI3t+AJPGMUYJ8QZMGrm9d2emgfmkzBzCj 96RiwyC/D7+bYZwHDqf3D+m69mUPXS7tJ7ncMD6oFgk+EcnGMHAkmB5rwMIb07b1FiCZ 10trb3bBRAiBF6ghTF/IAlhnlRUPSKw9BG8cE46e/8vEC9zFJICZCJ1JZHrnnLq2xXPK ThzfRcGyUrmT4YO8GXvvavQTnc9vZPxTDB6fG+lVTScbfdBzNHBxmScqjO8csabvQCwK /8W0rL+h8ns5jb90QpOX6/iPPqyiGyPo7+tWc+sY0BLnn0Myu9nmEbpgz2/g3kqDFcop issw== X-Forwarded-Encrypted: i=1; AKwUvBzYNAQ4bFVWEgTDLNB9TgeN5NuUODgIIKLCaVCyeELSouDwtUkqOaI5mPJpVt6HxBxZ87JRGmZvsS7wyKk=@vger.kernel.org X-Gm-Message-State: AFuF++kWfd8s0JS9st0kpzM1e/zT74g+Fu43ZMR2h9Pe+LyMuLG38QGs gmSLKzJcTzLDNj35dBTVCTUDNHec7MrS8TfIehky+ZpqbQAZwF+LSIYe/r28Acn6xC4KN52mzMD BNIaeFzHEwQASTqfURtKqldBr/5SsPO0QP8akM6XNpYv4jC5eoS0peMftDUOtltnA7Wo= X-Gm-Gg: AYBFou1qnBqp9LPH3L6yunz4kZAI08LXRdHteVAMSMAvBRdfQfh714JJZyPGrNRC7WA N21disHR3VHpUdSNnykdgFR5M9qI7KdzNs7m0eAKDvVQHVb2NIs2z0MHhg7e4SJHXh33Ws1kk7L nDr7duFAqCAS2Gn027HomKFiwjg/uvQzrv3NpDEoWxmQ0P8+SoSIPjEXlVyl5Z0bX36tUp4cNwX BRqurSDwlPIM4TrnfIREoxpdOAycNg6awVD6yAQJp7xlLECEue2dbaV2pxu/KXrazoa67A4M2RT BpufRwJvboGjfMAK0tkwdAkJ9EbvcGtJF2k+YyF3hl2JDisUO8PxrIAvp5cgo3jLybh0kIuU7Q8 fF2zWsFY= X-Received: by 2002:a05:620a:8399:b0:93a:ea:b00e with SMTP id af79cd13be357-93a346fa5f8mr866254085a.30.1789554560456; Wed, 16 Sep 2026 03:29:20 -0700 (PDT) X-Received: by 2002:a05:620a:8399:b0:93a:ea:b00e with SMTP id af79cd13be357-93a346fa5f8mr866252285a.30.1789554559959; Wed, 16 Sep 2026 03:29:19 -0700 (PDT) Received: from [127.0.1.1] ([86.121.170.232]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-49e83dbb0c1sm71633805e9.14.2026.09.16.03.29.18 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 16 Sep 2026 03:29:19 -0700 (PDT) From: Abel Vesa Date: Wed, 16 Sep 2026 13:28:18 +0300 Subject: [PATCH 02/48] clk: qcom: camcc-sc8280xp: Use common probe handling for always-on clocks Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20260916-clk-qcom-rework-legacy-always-on-clocks-v1-2-25a24e50f82a@oss.qualcomm.com> References: <20260916-clk-qcom-rework-legacy-always-on-clocks-v1-0-25a24e50f82a@oss.qualcomm.com> In-Reply-To: <20260916-clk-qcom-rework-legacy-always-on-clocks-v1-0-25a24e50f82a@oss.qualcomm.com> To: Bjorn Andersson , Abel Vesa , Stephen Boyd , Brian Masney , Jerome Brunet Cc: linux-arm-msm@vger.kernel.org, linux-clk@vger.kernel.org, linux-kernel@vger.kernel.org, Abel Vesa X-Mailer: b4 0.16-dev-0e65f X-Developer-Signature: v=1; a=openpgp-sha256; l=1701; i=abel.vesa@oss.qualcomm.com; h=from:subject:message-id; bh=5kVvtWRtMetQrC301SdF709Q+ZqaylTFJGaMMYBiDNI=; b=owEBbQKS/ZANAwAKARtfRMkAlRVWAcsmYgBqqm9M8p1vVtXBJ8zAcoN/xc+hTsMvLgAkqRbZq NG9r/mZ/lqJAjMEAAEKAB0WIQRO8+4RTnqPKsqn0bgbX0TJAJUVVgUCaqpvTAAKCRAbX0TJAJUV VlJbEAC4iheZL+LPE84bMRPp9qeUFPeNlkZnbnz9/51JABCtbS76XqCiM2uKxiwogopFWQKopyv 1GU+4aAz45o/oGd6cKXhdJAE3x4nc45Iojrfsn6X6L1obpzMZMtfnQHfef7OqaObDuiQmxASnBi ZGWG/QXHdOpYo4iqonOjcYuqcCJly+I3BDX4av42keaf0tuiHllA8BpZQQ46cwtojpS+/kx1Dvy 5HKDXu0/PLAg3NWVFJBuMAkXwg2N4a9zfEOh9IfC4QIMSdeAsMDtlRbIgdGSIvyBrwMUZIDOcC2 GhwxZAyIQGj7dX1qSwHKTehaybcNUOMnh/dOOM7/eexTbeoxx4YnZwN7OQ4b8BUwzJvt2V0L7jX DGhlpBjOqPOjJsNu6kOQM0VFu06mzE7U28YYS1+mWPPuMPFDx1olmofaOSkTtAnyYpIxCSmMt3u XL1LmT/qeY9lAtR50GzEIXSfKhUjhshYyI51eIa0xnzkhtd/zXq1Tpvjj0CnghFWJ9anwsraOGi PAxvNXnTmwyKuI58EtrGcsczG60s7UL/Ii8yMAJCCedX8KudjlgDPOw57XMBMEEQMS0e0oILr0s 9HgPS/0oqHr6mffHSS6+J3OcSFv776NnefXt50+nqWhuG2Iwyw1AHp++0YXUwauMrfunPCO6AQo ZOB+fURZyVCGz1A== X-Developer-Key: i=abel.vesa@oss.qualcomm.com; a=openpgp; fpr=6AFF162D57F4223A8770EF5AF7BF214136F41FAE X-Proofpoint-Spam-Info: AW1haW4tMjYwOTE2MDEzNyBTYWx0ZWRfXxWCN38SqlvhF hN4+VhMWNX2BBPBkSnNF/tWsvp5uUPee2XJQ4yXEqWV6eU/8n3kME2YU3be6acQcNK4+b5wvf2K g66rb3wAKF744UXcGGfVIaqorxusY/g= X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwOTE2MDEzNyBTYWx0ZWRfXwA3eXgB2TORs XpHkUR6nCAawFRJQ/FLvFgvxJeSqFngdFdaQoA6vYbjI03EEYi1THgYDCrF5kyKtFPoORURENRK Qmc33hcJ+xSp2yTPa9CRPL5U2qilrPPC/rHi+j43Grvk6A82leyy5BVZr/Zasx2lPPZCwUsl6fv 4IVsAxmanzOJT4DHqv8pBSAc7FcnFoGCXIle09OGfZI8MCK6/4GA2uBjngif8nzyxMscRt7fvAi Uh1ysHv9rxc0s5H0yG0Vql9ynTp/gTYtn0F8rW9N6HTvUZ8UiSebrqDK1EUFZ0/K9n5+hsIOv7l D9Xe1v8T4WJDhHOUvLBIe7AdKxVQQKN7LHJMGzdTaNVPaU5LKYll2coJTvRlVciFNyXtvF9Qih+ T75ZVwlShmG1yaxRvZpCOu1AQEzKjGqfB9DpFYeR2Cw/0G0Am+4/WZq0f7IH4ydRD5MffzEEZgg 27zojhj/Yfj+cU6kpDQ== X-Proofpoint-GUID: F9HAvYQlw0INysY_HeeOPYTAFu1VUVVD X-Proofpoint-ORIG-GUID: F9HAvYQlw0INysY_HeeOPYTAFu1VUVVD X-Authority-Analysis: v=2.4 cv=PcZqFShd c=1 sm=1 tr=0 ts=6aaa6f81 cx=c_pps a=HLyN3IcIa5EE8TELMZ618Q==:117 a=po8fGBi+ks8MzcVQGuqtFQ==:17 a=IkcTkHD0fZMA:10 a=VdqzKS8jKosA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=yx91gb_oNiZeI1HMLzn7:22 a=EUspDBNiAAAA:8 a=rrqsg2U6P9VQxLjfjP8A:9 a=QEXdDO2ut3YA:10 a=bTQJ7kPSJx9SKPbeHEYW:22 X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1176,Hydra:6.1.134,FMLib:17.12.100.49 definitions=2026-09-15_05,2026-09-15_02,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 spamscore=0 phishscore=0 suspectscore=0 malwarescore=0 impostorscore=0 clxscore=1015 lowpriorityscore=0 priorityscore=1501 adultscore=0 bulkscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2609040000 definitions=main-2609160137 Describe the always-on branches in a critical_cbcrs array and reference it through qcom_cc_driver_data. Let qcom_cc_really_probe() enable these branches instead of programming them directly in the driver's probe. Assisted-by: LLM Signed-off-by: Abel Vesa Reviewed-by: Konrad Dybcio --- drivers/clk/qcom/camcc-sc8280xp.c | 13 ++++++++++--- 1 file changed, 10 insertions(+), 3 deletions(-) diff --git a/drivers/clk/qcom/camcc-sc8280xp.c b/drivers/clk/qcom/camcc-sc8= 280xp.c index 660d8655d391..b0f1d40d1df5 100644 --- a/drivers/clk/qcom/camcc-sc8280xp.c +++ b/drivers/clk/qcom/camcc-sc8280xp.c @@ -2967,7 +2967,17 @@ static const struct regmap_config camcc_sc8280xp_reg= map_config =3D { .fast_io =3D true, }; =20 +static const u32 camcc_sc8280xp_critical_cbcrs[] =3D { + 0xc1e4, /* CAMCC_GDSC_CLK */ +}; + +static const struct qcom_cc_driver_data camcc_sc8280xp_driver_data =3D { + .clk_cbcrs =3D camcc_sc8280xp_critical_cbcrs, + .num_clk_cbcrs =3D ARRAY_SIZE(camcc_sc8280xp_critical_cbcrs), +}; + static const struct qcom_cc_desc camcc_sc8280xp_desc =3D { + .driver_data =3D &camcc_sc8280xp_driver_data, .config =3D &camcc_sc8280xp_regmap_config, .clks =3D camcc_sc8280xp_clocks, .num_clks =3D ARRAY_SIZE(camcc_sc8280xp_clocks), @@ -3011,9 +3021,6 @@ static int camcc_sc8280xp_probe(struct platform_devic= e *pdev) clk_lucid_pll_configure(&camcc_pll6, regmap, &camcc_pll6_config); clk_lucid_pll_configure(&camcc_pll7, regmap, &camcc_pll7_config); =20 - /* Keep some clocks always-on */ - qcom_branch_set_clk_en(regmap, 0xc1e4); /* CAMCC_GDSC_CLK */ - ret =3D qcom_cc_really_probe(&pdev->dev, &camcc_sc8280xp_desc, regmap); if (ret) goto err_disable; --=20 2.54.0 From nobody Fri Sep 25 05:31:34 2026 Received: from mx0b-0031df01.pphosted.com (mx0b-0031df01.pphosted.com [205.220.180.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 015EE4E66B9 for ; Wed, 16 Sep 2026 10:29:25 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.180.131 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1789554583; cv=none; b=YvbE9icDl2Sj3+nI2IAHnMV7ef1Y8p2h6ne/BF8CTC0Qv6kvekxWxZxQRABN/ytiuVXzJvUoeS8MENR+BRYAg47IdGLkj/5bh9U9+K3McQKUXbxn27tdNh8nuFsDA6DUeRRHXKEE9gpIEbm7u64X50zNd1mPGV2NUzIGfr1AHbk= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1789554583; c=relaxed/simple; bh=GnOuiy3DBg46aQA/28bQPDnc882/E7A730/MK6hlK3o=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=aarj21y5kw+5e0jEl6X3HlkZ/eSvnkOcYWdghyCYE98WuCuDAEk2DedC5kvrXWRP6wJqi9EKrAmNCVBrT6uReKgz7wPjNK2SKQLYRtYG1iLRVYWxc/nD4HFwA0nWDRxk+ZElt+9sjDSNwAQsfJqXvLLJuoyK9dwz0651ZAvQ4t8= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=NGPnTCsn; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=c/l3acIx; arc=none smtp.client-ip=205.220.180.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="NGPnTCsn"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="c/l3acIx" Received: from pps.filterd (m0279873.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 68G934EW2226525 for ; Wed, 16 Sep 2026 10:29:23 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= WTuG3pY4eN3mdqgbofE9B7HAU0+EYKfzvYm+mvUVot8=; b=NGPnTCsnacx8rA3u x+7nkfIbrnRAcHL05PWb8wcNlCX4N4EI9Yva4NRo74uU6LgQ/9ZwUEU2FETw8prI uibMTH3Su2zBmP6bK58WyX7Mt+3XxjiUnWvAovrQbI28wL7yPtK5YuYujw4HUKQF 7WhWgfSC309w3BsCHHhB0DUS8MNBpLPlF9FGrMX8DL3RxGUr+Z50zaTqQP1/XyKr rrdCfOxK5OYWneyeczipVA8XHUg+Dm2xghnM7vc3tNrLobzwPIQto6G3NBqTVtqW sDRMXiasJ0EGHQQBo8ri7VTPDZea6b4JppxOmCJAo2KH6q7l1sLhjPNfZO9ac2ty +TXJUw== Received: from mail-qk1-f200.google.com (mail-qk1-f200.google.com [209.85.222.200]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4gqah9usxr-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Wed, 16 Sep 2026 10:29:22 +0000 (GMT) Received: by mail-qk1-f200.google.com with SMTP id af79cd13be357-93a0050a554so1095026285a.1 for ; Wed, 16 Sep 2026 03:29:22 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1789554562; x=1790159362; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :content-type:mime-version:subject:date:from:from:to:cc:subject:date :message-id:reply-to:content-type; bh=WTuG3pY4eN3mdqgbofE9B7HAU0+EYKfzvYm+mvUVot8=; b=c/l3acIxNDmdZHh5PXvty/LHB2o3NZ0k+Vz3Wh0U9yevpyQVjTQ1gD40SPtTHMneEa rBSK89Dpe1ZoFMDCjXtH6LPzxg717cRN6CIgrKOsoUentOQnhUYlIZpgxK0szind3gz1 15Rfr14+cmbGorXEW9kc2v+2KxVSSnDhBSPkvTiZJW0uxrzccLLw31jhUsH/2R4kzbfr iNi6l+INoFVCRWrJ1727BHH+kNX5Cxqh4ewnRbCSSTPcPtIpvpOsem9+2mIaHUCVWocE 0fWgkcIp/12KD6y5w+UI32gjcpMxYNvcuNh/KX92f9NwBGj5J7cYgr2AeLvWgpcu6tKz Txxw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20260707; t=1789554562; x=1790159362; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :content-type:mime-version:subject:date:from:x-gm-gg :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to :content-type; bh=WTuG3pY4eN3mdqgbofE9B7HAU0+EYKfzvYm+mvUVot8=; b=I/ht85cy+WJv6wcqzHDtsR+D2DawQpkBPpwA035N0II+iQtac9FBUOhJPr/n3CZkqs ezorSX5UsSt2JeSflWhk9PD3pRtEkg4UCIh5EArutlKw5ihIkUzLQd/DX5bd13VSI/+k MyFBMIZcYj7AbBuqsEVXsdL+hRVfLL9S54Fj/CxkHBvdNUIcfb1ERWjUJ7tGOIOrOwxq SMALjm08Qkk2NGZJ/FL/rmDUXYbI9HSkqzOktCvawGbei8QMdF/7JEa9SjdvmIG163gP laXsDP/iuT2gAMI6RcY6iZQoiQbP6yeN3KzU29KQ2eCGb2vTYIIONi424UzOyq46Tb0I 5PIg== X-Forwarded-Encrypted: i=1; AKwUvBxSBIjqaPAViIMfF91tStzcsmTcSc9JsCbSTTd7hLYCEwZ42akMMOPbXJz0afEpaCFN5VSXQ5SCD2Yszgc=@vger.kernel.org X-Gm-Message-State: AFuF++lW0ReB3MXpT/opUx1Mdp5T3jPTtVPv24hF2tWtjAlRgYfMbmpg IaAhoS0j7yqQkI4PoCUUtEShPXFrfqY4bpuPdsXWm3tF3z6Pn82wHh4mm0He+H56eY0+1jORKtn Dmz6ke8F1OfB/HVMNu2zN6hc+1dfh2KeVciv4nbb6V7qENJbAakNTAANFbLgihlB16+g= X-Gm-Gg: AYBFou0r66QUBX3ONLgyAYreH0dPwVFW0PGAXJ5Obcd/8Mj9ZdaE7dQ21jnn9+IPBjt H15RHf5id2JVBO4ZI/ReQudQiYknBo8ygcR6tXuCiD+tnElG0DkzuKuWiTN9w1uocl8w/JEC5Sb 2LTlrrYKlRIJ1DbvrO7rUiIl1E3srePKeWPQOm5KoImB/nwcvfs5eTMgsvYMVX4iMIzrhoVO48V zoHNS3Vey/qDn5nMKP2+8p9FWr9+OX+FfH3WHlGcVCR6Yq+hHDRSqv+Lf7/8nVN7VZ/OuA8a5MC l3XqvBQ/gezKRFIuMZBkgwfJlvrO1rGNUsbVAowfRCvZ+fu71QfBZjho8bkmbodluQw05YArab3 wHs5994M= X-Received: by 2002:a05:620a:708d:b0:93a:3d71:c9ec with SMTP id af79cd13be357-93bb76e6cc3mr290702885a.7.1789554562297; Wed, 16 Sep 2026 03:29:22 -0700 (PDT) X-Received: by 2002:a05:620a:708d:b0:93a:3d71:c9ec with SMTP id af79cd13be357-93bb76e6cc3mr290698585a.7.1789554561763; Wed, 16 Sep 2026 03:29:21 -0700 (PDT) Received: from [127.0.1.1] ([86.121.170.232]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-49e83dbb0c1sm71633805e9.14.2026.09.16.03.29.20 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 16 Sep 2026 03:29:20 -0700 (PDT) From: Abel Vesa Date: Wed, 16 Sep 2026 13:28:19 +0300 Subject: [PATCH 03/48] clk: qcom: camcc-sm7150: Use common probe handling for always-on clocks Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20260916-clk-qcom-rework-legacy-always-on-clocks-v1-3-25a24e50f82a@oss.qualcomm.com> References: <20260916-clk-qcom-rework-legacy-always-on-clocks-v1-0-25a24e50f82a@oss.qualcomm.com> In-Reply-To: <20260916-clk-qcom-rework-legacy-always-on-clocks-v1-0-25a24e50f82a@oss.qualcomm.com> To: Bjorn Andersson , Abel Vesa , Stephen Boyd , Brian Masney , Jerome Brunet Cc: linux-arm-msm@vger.kernel.org, linux-clk@vger.kernel.org, linux-kernel@vger.kernel.org, Abel Vesa X-Mailer: b4 0.16-dev-0e65f X-Developer-Signature: v=1; a=openpgp-sha256; l=1641; i=abel.vesa@oss.qualcomm.com; h=from:subject:message-id; bh=GnOuiy3DBg46aQA/28bQPDnc882/E7A730/MK6hlK3o=; b=owEBbQKS/ZANAwAKARtfRMkAlRVWAcsmYgBqqm9NOMMChMCUL+DEcmWYx8QLJjA/Xw45MFbPe Vt5ixeZ/8yJAjMEAAEKAB0WIQRO8+4RTnqPKsqn0bgbX0TJAJUVVgUCaqpvTQAKCRAbX0TJAJUV ViieD/0VVLBypTiruuzx9m8YkiYfRBCUS20GSYFsmfTLNPyBgQXAYhlaXW9ep4s+VLki62pe0tb 52FmCFo+j3/hZJ3o619hxWYp7TjFkjkqjZDkwncE9SZ4n4227ejH7XxmHg/EIJ1qKH2WZN9E+HC vnG7ioNemB9xfAv+bVjClRYhG0yDB2sg4/U+20nlLE6RRF5jwKm71Umi0GFyG4YqV69hqHlBOtK CE5UXzX5rbixnuC/TiPDy4zWRdynSlqoDKT5/vOB8y9X0XDvWcTmVhCLKmAlPlvztEfrfw/vxka F0UKkj1J1la/eGpjA3lE3C4BsfCZHVvWAxID/pI+lEFBpQeAFz6+ukSHvN9ZLvdSAgMiGXKKwKo BfwZ+fThfEW0g6DKURrnYgSCywXsF6u9MzL2xmOVIta09tltl19p6/TAZFm1J7dILVMtSpCdJlM ZljY1hPvtm818+rnNYS3+evoGLuZQVRkUMatZb6QydvFGi9MHcdShOhp+NnhLPBUz+u/AdrTeLH ndcCKJkkZgR27DkrtC2uXCnfNRAqCdI5WEobcbRr99lIyxm1QeF8tr8EGP7au23tun8OATtSu6o i8wJ9Kh1BPLKqLOXUOvaAiYtuG+K0OIqZ3PPIJ1zf/Z3S1H6yUhhye5pnaLRSUbsnQ9N7YsxYmm ePHAhpZvHIyFfZQ== X-Developer-Key: i=abel.vesa@oss.qualcomm.com; a=openpgp; fpr=6AFF162D57F4223A8770EF5AF7BF214136F41FAE X-Authority-Analysis: v=2.4 cv=BtkIUoX5 c=1 sm=1 tr=0 ts=6aaa6f83 cx=c_pps a=hnmNkyzTK/kJ09Xio7VxxA==:117 a=po8fGBi+ks8MzcVQGuqtFQ==:17 a=IkcTkHD0fZMA:10 a=VdqzKS8jKosA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=rJkE3RaqiGZ5pbrm-msn:22 a=EUspDBNiAAAA:8 a=bQTroZZgG8CJslzDRBIA:9 a=QEXdDO2ut3YA:10 a=PEH46H7Ffwr30OY-TuGO:22 X-Proofpoint-ORIG-GUID: C1hA4O1QUkMgXc-zKjlgwwmhvd9ghafq X-Proofpoint-GUID: C1hA4O1QUkMgXc-zKjlgwwmhvd9ghafq X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwOTE2MDEzNyBTYWx0ZWRfX/BG3tRX8N7N0 UI5LafJSu+5WSWRWQwCLmX7O9k/6nh/nQxOW+9S9x+vBbD7NgsFLeOrPrEPHM4t2I7i9N1LPKVO TspLVUbgk4lYdMgmIRxb5UL5Ab2WMPt0ii0L1/5Ex7zHkBp1SJbq8aXYTXKuD4DqcAd8vV6Kmv6 s1JlQ0Qw2sa32uiv8++/OHGwecggEomajZv8i5hBLxPkfhnGoDPk5q+zfi585t5zIaGcd0X+0MX 1i9g1RudPLj9qjMboikdtVR5kYOamaU5zYccNPfWZ+yqNhzw/wUZpcEyALR5GhF00AEEgm0HgmL rmwTRqBdm0GRBWrZLmz5vJWj4dGdFoNr0FuhLh57QDkOYk3wuavizRi0l40CkuRhX8aMfv6ZSwb 5TgoCq+zJWX7QaZ5nm9VAvQf5ebOmUyadVMYfFN/O9pIml2Pko2hzcgDnIbBJNah9KF2ZsN582a KH0m1IDZ0U9M4R6L5rQ== X-Proofpoint-Spam-Info: AW1haW4tMjYwOTE2MDEzNyBTYWx0ZWRfX/0Ph9yJvHZjq H8sViVOkD6ky1w3+MnJR2muFj2hIGACuspkB+t/Mo9T/craa15a3MNMJaIdA9FarS5grjep62ss NZeCQrK+JqZHxV1UjZSOnAfWMek2puI= X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1176,Hydra:6.1.134,FMLib:17.12.100.49 definitions=2026-09-15_05,2026-09-15_02,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 priorityscore=1501 lowpriorityscore=0 spamscore=0 adultscore=0 malwarescore=0 impostorscore=0 bulkscore=0 clxscore=1015 phishscore=0 suspectscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2609040000 definitions=main-2609160137 Describe the always-on branches in a critical_cbcrs array and reference it through qcom_cc_driver_data. Let qcom_cc_really_probe() enable these branches instead of programming them directly in the driver's probe. Assisted-by: LLM Signed-off-by: Abel Vesa Reviewed-by: Konrad Dybcio --- drivers/clk/qcom/camcc-sm7150.c | 13 ++++++++++--- 1 file changed, 10 insertions(+), 3 deletions(-) diff --git a/drivers/clk/qcom/camcc-sm7150.c b/drivers/clk/qcom/camcc-sm715= 0.c index 6f75689e9847..d06258327ba7 100644 --- a/drivers/clk/qcom/camcc-sm7150.c +++ b/drivers/clk/qcom/camcc-sm7150.c @@ -2008,7 +2008,17 @@ static const struct regmap_config camcc_sm7150_regma= p_config =3D { .fast_io =3D true, }; =20 +static const u32 camcc_sm7150_critical_cbcrs[] =3D { + 0xc1a0, /* CAMCC_GDSC_CLK */ +}; + +static const struct qcom_cc_driver_data camcc_sm7150_driver_data =3D { + .clk_cbcrs =3D camcc_sm7150_critical_cbcrs, + .num_clk_cbcrs =3D ARRAY_SIZE(camcc_sm7150_critical_cbcrs), +}; + static const struct qcom_cc_desc camcc_sm7150_desc =3D { + .driver_data =3D &camcc_sm7150_driver_data, .config =3D &camcc_sm7150_regmap_config, .clk_hws =3D camcc_sm7150_hws, .num_clk_hws =3D ARRAY_SIZE(camcc_sm7150_hws), @@ -2038,9 +2048,6 @@ static int camcc_sm7150_probe(struct platform_device = *pdev) clk_fabia_pll_configure(&camcc_pll3, regmap, &camcc_pll3_config); clk_fabia_pll_configure(&camcc_pll4, regmap, &camcc_pll3_config); =20 - /* Keep some clocks always-on */ - qcom_branch_set_clk_en(regmap, 0xc1a0); /* CAMCC_GDSC_CLK */ - return qcom_cc_really_probe(&pdev->dev, &camcc_sm7150_desc, regmap); } =20 --=20 2.54.0 From nobody Fri Sep 25 05:31:34 2026 Received: from mx0a-0031df01.pphosted.com (mx0a-0031df01.pphosted.com [205.220.168.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 16E6C4AF665 for ; Wed, 16 Sep 2026 10:29:28 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.168.131 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1789554571; cv=none; b=ZLjC6KXNfF/AWM9z8I8N9QcAeYZcdpD3vmoDfW0r+/9Y63/CaiM02q8B4ztsDvhaHdanfs6Ib/Mf5CYEdEN6fKoryMbEycLGmJ/zhZcPqznIIZNPQ90ybqaa9arDmLa0ZY1xdTruojzgr1A3lfq201dYRdMFLNAhamVLYwaJ0ZA= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1789554571; c=relaxed/simple; bh=Zt1XtMcJTtBMmNvNRadDt4f3CZK1iu79tRUg4BM2u50=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=Z7AxjzQ6vpcRdwN/Mg8Z2O4gXjiFFz69vUE20DRdMlDVtnncHJF+0sJ+GAVxDveU9AF2oklGdR3SDURGbs9MO0UURULDK12EmzL9syyqfI3FmHJTgPCZtTQH+JOqK3xTvTjIurwBmPCy0aNG8s14PUR+LCzIAe6h9zW/TEOogUw= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=pE//wHjA; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=OBDw8PEn; arc=none smtp.client-ip=205.220.168.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="pE//wHjA"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="OBDw8PEn" Received: from pps.filterd (m0279864.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 68G92pv7978298 for ; Wed, 16 Sep 2026 10:29:25 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= X31xIlH+SeeyJrg8fCIZj2iiMFxIi6b+bf+Q6vfRneM=; b=pE//wHjAzzyPEYat 20PezwUp1UswrfxuPnQWYZfoAQ+svOkD91teh7Rh4cx5HBRTjZ6uUA0oym9/Si0d aTXoCg2C2tnhwXr9bgKxhpRcHwyJ7A/TBk85hYJTC5oEbt0R/FI2g5fL24Jmq9h9 e9cFrYGM8wqdxpGI2964Pz8yQoGhgYqa8S0a23XExJXxMIqkW+Bz/7TtiFu5TwoT KJCthsa3FXYgi2DWIivhxOHIUP3ihD6FlBo/hpkhx5/nqrFe9zRxcQAt2PLI6xnq l/OJxPrQYON/HYsdjHBdNC1D4w4/ZL7GkcLvSv8efMJWQ8LjmzidZlZS4cPV3sU0 64TmGA== Received: from mail-qk1-f198.google.com (mail-qk1-f198.google.com [209.85.222.198]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4gqqp3rfrs-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Wed, 16 Sep 2026 10:29:25 +0000 (GMT) Received: by mail-qk1-f198.google.com with SMTP id af79cd13be357-93903622880so379251985a.0 for ; Wed, 16 Sep 2026 03:29:25 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1789554564; x=1790159364; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :content-type:mime-version:subject:date:from:from:to:cc:subject:date :message-id:reply-to:content-type; bh=X31xIlH+SeeyJrg8fCIZj2iiMFxIi6b+bf+Q6vfRneM=; b=OBDw8PEnD7LN2vfhTZrzT9XMLQBWT0uUc15naShrqsG12mlyelasGZMV/GYNMhmbsy H714TxfQ0zjyGxrhepGxcjR1qvK3dCATNuBh7Yf6o9WIjqkf1mKR7pyVA+K2VCjoJeMz qCuR1PmV57PFERQGOfPv/gWiu9MsIkKSGoqnT1ceTcXs7ayoC0MiZ0eTOC8WuIf6dMKs DvqF/7xEx3NODfB0nyvOQ1tm3ajCY5+Ugpew5ZeSxHCdYNXpm8kY6hMVmmXZyMTL7EMW tEbu2G3N4XJr8He7FWuVs8cb8CJ2Ubi7aYnNaId7a8MmyngrtMwSOtkjveOEwQckSGc6 JQ1A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20260707; t=1789554564; x=1790159364; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :content-type:mime-version:subject:date:from:x-gm-gg :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to :content-type; bh=X31xIlH+SeeyJrg8fCIZj2iiMFxIi6b+bf+Q6vfRneM=; b=vODyDpbAdt7xCQ2+4zpvrrjOx/B5pe3NPfyCg21mkof4g98HNwSQl/me/21/SaAk5A LOrQt75bz5CAhQIbX116kRyVvt6MlIS2RmU8Ed3873dIawipy8Un7+3ORR/jWYK2qwDC wOcCQ6ZE1yklmG4vhXbdA15ZVRgy23Nz0L6KErkkC2Zrs0anyAaKmLpTd9v0iw2FLQGV 1RlKHFK6MHt77J2QMyPNkmoGRTNAkgb/v3i5Gj3B+NEDgCF6T/OTeBz6ehQAzoeyP+vO 72pxS5QojupPn8+Bw1cp8LiFWxBoBYFxOZBHQcINxgGx8rIklCjjpXSiJd3xlr/p4zpN 0ChA== X-Forwarded-Encrypted: i=1; AKwUvBy04+TLxpWcGiPpRQxfCAo33JrFH+bckfes+5VSt3vqX9smAC+NjhO0FdHsejj3yOInm4hZMnktPYSmLdg=@vger.kernel.org X-Gm-Message-State: AFuF++llGJF8ELh/NZATg2Y381D7pHEDfd87GKwKa38n3aKrqona7iPh f7637IUT3kEYrKDVfbVr1UJdHPaCJSEpeLDy7eSsg5xfORHZDqa37c9x/FIO1AResARkdaKbcpA Glsaje4r1WfqTdVYhbX8J9LpBQB+RHDKC33yeTNdlOAfwDzrOg0epNzsnV92mH4Nh6R8= X-Gm-Gg: AYBFou1UeKKFPL1l/E2ce0fFwIIev2mpfkRIUkWt2paF8gxQhD6d0vQrsTZA57vYr2g afcnag9CJ3eCyTqtWVs7NNQjPbX3RKi4hSCX4FEFPKnKvaE8QhJyqY4c10kGV3Ab4uOdpEkafzq PFZ5G61auL0dsVVMQTOdz6RaOmPgNrWr7i7mmucev0QoGS17ZzVA6uxRsL7vweZMOMFRqM0qmmq LAkBrEMA/uhmNaHlOFk2vKDi48w+Nd4feZpIyj/JdbGNFzCHymiKn1rWYkWhJlGzKP/RvtgWzGP n4PVbw1Q0tbA7Uc9t4ed3tgNSD9Fw15xMEq2ZiND+CIN4Hw515c2wVbdr0tzy0IGY1UWa6rT0Sf 7geR2Omg= X-Received: by 2002:a05:620a:6609:b0:939:b783:1748 with SMTP id af79cd13be357-93a345d7062mr967658385a.7.1789554564132; Wed, 16 Sep 2026 03:29:24 -0700 (PDT) X-Received: by 2002:a05:620a:6609:b0:939:b783:1748 with SMTP id af79cd13be357-93a345d7062mr967656185a.7.1789554563650; Wed, 16 Sep 2026 03:29:23 -0700 (PDT) Received: from [127.0.1.1] ([86.121.170.232]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-49e83dbb0c1sm71633805e9.14.2026.09.16.03.29.22 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 16 Sep 2026 03:29:22 -0700 (PDT) From: Abel Vesa Date: Wed, 16 Sep 2026 13:28:20 +0300 Subject: [PATCH 04/48] clk: qcom: camcc-sm8150: Use common probe handling for always-on clocks Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20260916-clk-qcom-rework-legacy-always-on-clocks-v1-4-25a24e50f82a@oss.qualcomm.com> References: <20260916-clk-qcom-rework-legacy-always-on-clocks-v1-0-25a24e50f82a@oss.qualcomm.com> In-Reply-To: <20260916-clk-qcom-rework-legacy-always-on-clocks-v1-0-25a24e50f82a@oss.qualcomm.com> To: Bjorn Andersson , Abel Vesa , Stephen Boyd , Brian Masney , Jerome Brunet Cc: linux-arm-msm@vger.kernel.org, linux-clk@vger.kernel.org, linux-kernel@vger.kernel.org, Abel Vesa X-Mailer: b4 0.16-dev-0e65f X-Developer-Signature: v=1; a=openpgp-sha256; l=1692; i=abel.vesa@oss.qualcomm.com; h=from:subject:message-id; bh=Zt1XtMcJTtBMmNvNRadDt4f3CZK1iu79tRUg4BM2u50=; b=owEBbQKS/ZANAwAKARtfRMkAlRVWAcsmYgBqqm9OQZyuYcb703KrDHQVw8AHr2mbq1+HGk8fI yB0k30mmP+JAjMEAAEKAB0WIQRO8+4RTnqPKsqn0bgbX0TJAJUVVgUCaqpvTgAKCRAbX0TJAJUV VpQpD/sHUfuV7j6h21ksZbSpy8zXHkGuk/PwiWT1ChMdp3rOCVzSRUp6SW9EzcdhQZH4+Xn9pUK 68Q0wkgG38DShgO/F7/1qg6r52TCTQQvYzjkZnlWN0iHjw5oFjK1H+0qcrWVGqzOyptvGVg3hLi W5MDJ9vexCVOg6Zubkg+9cWESB5QSBMl1Vdww3zONcYKDXHZpxFF2LuhZlUw3U4qwMnVWgddWO6 lHGpVCvdydCB9iUCF9MR7wLD/v8FWBP2raEZ9LcmTszu5wrXKuX1m6JLXJPC9kRwOWk+XPfu0dn pY1sAWaCXLfgWPjzl6nt3PPXn9XuLIV1Iq5aj3uJ0X/SR7b8uevDyMxLvCzvMJQKhgzc2JDDfBV LwTUa6Jn7LyN6kcOgjukW05bHcSQ4BR+hfZ+Wp3ooRxjlZwOqesI/0TFxpNicJlSXTeAzBxuZfH NGDo4oUW/nO93vINIAsIA1nAk58iYd8ZNg9mLi9XVr4U6qyE++Tqwe06iMP1Bl+sDVf/mYF3nTw Dwz3OxITOgOXa1cpSR/laLNSATj9J/fAskM1q24iQo98+uF785NA/BPbmbCsd88dTDVv1hkkDro KG4rUmKan09jEqR6tfrDnZRBtzM0pFUFG6d7tX1SPyiJd6ogKIwd5we86wvYXyesojhGMVVonZU Tha+BKUpVaO92Og== X-Developer-Key: i=abel.vesa@oss.qualcomm.com; a=openpgp; fpr=6AFF162D57F4223A8770EF5AF7BF214136F41FAE X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwOTE2MDEzNyBTYWx0ZWRfX17GB6ybGqlpI qC65QaPacgMVh+1gd5VBt2yMYqkiffCpof7mmAVtszoUrXX9veM8kT10pDa1xiZSiYAMp4/3N2z 5sN7GfwxWhxFdyWFuZy36w1hWC59pwbih9vswaI5gspxfemOqG4zhxOB6NxMeHvugP1tKx1FpRC CkfJFhO3SxFxO09Am9Lsh6/dv3lTVXr5MMh9c3mtiIsjae0Af4Q/tr55MLN+ReF2lwfnbnr/XAS 4FmVZEJMy8gPK0DEl6dbfG4pmXsb5hfFUgQcwwbJPf0oUFGc2LC2apCaoHXFC+r8JMGMpBlnDl6 cjr/5RaSFMqtYDZmQWhgSjiGnqA4dSLUIHxHB0PGkqQC+yaiU0hFFChDlUL9EwwHVEsXwNPoC9O FAlijA6xeRydwIlDzg4v0Ehz+D7Vxct+aOK307RRKccnCDtn6zdZ3lWk9GAEb0vmKOBHyj61M7e KWIQm+/Y3aqiHNEzLFQ== X-Proofpoint-GUID: q_br-FO2RCC4IUTZr6L1M5t27w_J86HY X-Proofpoint-Spam-Info: AW1haW4tMjYwOTE2MDEzNyBTYWx0ZWRfX2RjXeEZwCF1f 7uPlHlXQaJt4TBz/j4HgzPjlMOyQA6cyRBxDaSePfsK4UhZR4AicbMuguZKgGycFGrZHJJShFFf w+nyvHGr1VKUNyXCZUFgw0YIWlMCups= X-Proofpoint-ORIG-GUID: q_br-FO2RCC4IUTZr6L1M5t27w_J86HY X-Authority-Analysis: v=2.4 cv=F/DC5ahN c=1 sm=1 tr=0 ts=6aaa6f85 cx=c_pps a=qKBjSQ1v91RyAK45QCPf5w==:117 a=po8fGBi+ks8MzcVQGuqtFQ==:17 a=IkcTkHD0fZMA:10 a=VdqzKS8jKosA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=DJpcGTmdVt4CTyJn9g5Z:22 a=EUspDBNiAAAA:8 a=HACHd5sh_oZ471OAbCoA:9 a=QEXdDO2ut3YA:10 a=NFOGd7dJGGMPyQGDc5-O:22 X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1176,Hydra:6.1.134,FMLib:17.12.100.49 definitions=2026-09-15_05,2026-09-15_02,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 priorityscore=1501 malwarescore=0 adultscore=0 bulkscore=0 clxscore=1015 spamscore=0 phishscore=0 impostorscore=0 suspectscore=0 lowpriorityscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2609040000 definitions=main-2609160137 Describe the always-on branches in a critical_cbcrs array and reference it through qcom_cc_driver_data. Let qcom_cc_really_probe() enable these branches instead of programming them directly in the driver's probe. Assisted-by: LLM Signed-off-by: Abel Vesa Reviewed-by: Konrad Dybcio --- drivers/clk/qcom/camcc-sm8150.c | 13 ++++++++++--- 1 file changed, 10 insertions(+), 3 deletions(-) diff --git a/drivers/clk/qcom/camcc-sm8150.c b/drivers/clk/qcom/camcc-sm815= 0.c index fcbaff55fc27..27a51abddce2 100644 --- a/drivers/clk/qcom/camcc-sm8150.c +++ b/drivers/clk/qcom/camcc-sm8150.c @@ -2093,7 +2093,17 @@ static const struct regmap_config cam_cc_sm8150_regm= ap_config =3D { .fast_io =3D true, }; =20 +static const u32 cam_cc_sm8150_critical_cbcrs[] =3D { + 0xc1e4, /* CAM_CC_GDSC_CLK */ +}; + +static const struct qcom_cc_driver_data cam_cc_sm8150_driver_data =3D { + .clk_cbcrs =3D cam_cc_sm8150_critical_cbcrs, + .num_clk_cbcrs =3D ARRAY_SIZE(cam_cc_sm8150_critical_cbcrs), +}; + static const struct qcom_cc_desc cam_cc_sm8150_desc =3D { + .driver_data =3D &cam_cc_sm8150_driver_data, .config =3D &cam_cc_sm8150_regmap_config, .clks =3D cam_cc_sm8150_clocks, .num_clks =3D ARRAY_SIZE(cam_cc_sm8150_clocks), @@ -2134,9 +2144,6 @@ static int cam_cc_sm8150_probe(struct platform_device= *pdev) clk_trion_pll_configure(&cam_cc_pll3, regmap, &cam_cc_pll3_config); clk_trion_pll_configure(&cam_cc_pll4, regmap, &cam_cc_pll4_config); =20 - /* Keep the critical clock always-on */ - qcom_branch_set_clk_en(regmap, 0xc1e4); /* cam_cc_gdsc_clk */ - ret =3D qcom_cc_really_probe(&pdev->dev, &cam_cc_sm8150_desc, regmap); =20 pm_runtime_put(&pdev->dev); --=20 2.54.0 From nobody Fri Sep 25 05:31:34 2026 Received: from mx0b-0031df01.pphosted.com (mx0b-0031df01.pphosted.com [205.220.180.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id EDA794E3EEE for ; Wed, 16 Sep 2026 10:29:30 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.180.131 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1789554602; cv=none; b=ZsuLBydgplNlVjHrCowloGCeC/rWRr3yJBKTQfEBiq4L/Il6m8xUJLBUhtld3rjBQmEkMFS2lytqrx0HclDPpy9N3hoMBObEBDwu4Hb+E535yXYtsMk456bEZtBHm5mi29iP04Sl+wC/zm29u+4WolmzrSD8TADhSAXAMy9LUik= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1789554602; c=relaxed/simple; bh=f5Cdf+5sSRQr5GkLyAwVmLKPgMj8336Q2vryy4mWj+g=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=KaBX1ktTG0trUJGB4NNcc4nJ8fv9KT3nmw6Zt2AJE6PsGYG3ZmvO1iqnr/Axjzm57Fwl+wmS86S9RgB91cUKwiBs1fdJWI0agb+U0/E1aG1WmHQCgp5ZgL7ZIdWupZ+S9Ctvj3uwzPTVcgobWfdvUEtQo9wGu6fWLR3ykMWzRMc= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=Iw9pSlhg; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=V3pGayZu; arc=none smtp.client-ip=205.220.180.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="Iw9pSlhg"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="V3pGayZu" Received: from pps.filterd (m0279873.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 68G934P52226500 for ; Wed, 16 Sep 2026 10:29:27 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= 13UuE5xNHYGpc6mLMUjVrBiPgoulPDJ7WfxYCtDapwU=; b=Iw9pSlhgQoYTrkd7 KHcZl/ViGuM992BIr7DlHnJdftc0QLHRXeim1gBESUE8Hxu+WjaHFTl36VtpH/Vz Affk8du1HDM7iOCyFRGe4YpLZKACk2m3RNzkaAc1UcTINNOXPSd46ZsEQk6taHAd YtQUGn56YWiRtBkXZ9LU4y0xEoXaEkwph6vRku2z1Iq5tKUkC2uMfTLkbfvMK1fk qagwE+GQ96Ww1NHq/FXTZqfyjRfsGQXIqai2MAx7VR9Jt9uLEh1jtFKzZVJNQVPI FF6YbqaFhXgE+XCxPRJCCm3G0gMbKM+H4f3OzQ8XOue1hzbfYprLvAOfx8q1QRgD AdIvRQ== Received: from mail-qv1-f72.google.com (mail-qv1-f72.google.com [209.85.219.72]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4gqah9usy1-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Wed, 16 Sep 2026 10:29:26 +0000 (GMT) Received: by mail-qv1-f72.google.com with SMTP id 6a1803df08f44-90e98e74535so114211156d6.1 for ; Wed, 16 Sep 2026 03:29:26 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1789554566; x=1790159366; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :content-type:mime-version:subject:date:from:from:to:cc:subject:date :message-id:reply-to:content-type; bh=13UuE5xNHYGpc6mLMUjVrBiPgoulPDJ7WfxYCtDapwU=; b=V3pGayZuCOU1wLWnmEEWi2Y8izX4xMZ30E1lv98SgCJlni2H9vvxJdeNe+yaZZlT3M mwDyBPMF98NjesxeZZyrO5WA5vcZJc82/+I74QbcJXFTKo3DeDfRKCxLTO0qLRNbHpvC OT92Yy3I/ZQHTDgJNxu02gqIKLJdciX2JiW8bwq6Go/HIdoiC/Sd0YbQBk2XncSpylaR oUaKoe+7r04IqUdZCKTyIFbygXhyA0ltqJzRqYmfkIHM4XxKK707Zfgqe9yXC4dlAfun xCwe8dc+9xeTCwkEraiX/HN/3+O9kNM058P2UsqUg4/fJUfCugN8MLr0NEC6gZGn4hDJ AejQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20260707; t=1789554566; x=1790159366; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :content-type:mime-version:subject:date:from:x-gm-gg :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to :content-type; bh=13UuE5xNHYGpc6mLMUjVrBiPgoulPDJ7WfxYCtDapwU=; b=w+qj6+rBgbfNqcQik/iFv83jzfrGaOFfCDI+NDsOUKNAejjws/nFZOaM3l8kAh5PGK GVQFR9yvfW8gCEpIi7sVXwVUIbCaEMeY298krAss64auq+TJaEgU1KxILCrMlq8MTa8N +oVEwSuUTgjBa+yhHqiYuM1Rm1sTKzosDcDGEmA9vO2WG7/7njMWh9IOay75mAn/tzHA 3s1CThRCjAxLvuqja74/qgjQ2s4P2bfFszezJ4coMVdra9v3AQFG6j1sHiN+14uTDjTu FhGcr2PTfT/uInGAY1h8UnNdDxZRrtOl3+Y72P5qpiAHbSoGNwvASRMOrnEcD2ehvgLW JZEw== X-Forwarded-Encrypted: i=1; AKwUvBxcdNQckrucuNKmA5UgPWDpRSrssjlZOOxZRHxuS/wFvfGALwdDLEfcmYlq34okttrht0KEBjJ8g9AuWGA=@vger.kernel.org X-Gm-Message-State: AFuF++l6d7rgalb4IjGq1LZDA0tS+RkCg7i/yXFRGspO0QXgyYS1gCO8 pqym9E5JUmbIGbGz+/gzNlM9tF9LI6PohxHb1dHfXecPOXmG99z8z5c9I+ouH2chna2J/o2W3ds rQGboHhE/37XQlV5ymcaxqODy3hOSCw4Iwa+gVnEGP/f4LIcydWvNJSxuj8G2m71FC5Q= X-Gm-Gg: AYBFou3rkU57SqLefGX42uGNqgeYTNEbWPn8MPrWKlV9siW1wun1jSbRdxPi+lm/RZZ WLrmVkFS0pFj1MuLMFaoHb8h87NjD5nGGZl0o5nxeWC2MUSg0S8P8mN/XQNlc/UrH+C9zwMBxsX BhuP17C+kSqo9a+oq7418uEdMpz+5Sq9KF3gxXcgBPna3PKxLtL8Aj9UaPkZj5yTzNti5jVuBuQ 4zVGMa+g+UoXYVriaFUnXGJfX0t5OQIPezRPicb89pf53D6YKZLV+okOYxwXqMWBMIlgdBAuvX2 4tdkD1rDIOLN5I2IMPBzOq1i4/Qmfc1pHOkG+rlGm7PDYAxjxXU9SrFrk1QkDZeekIEnHswCOzX fpb3nRA8= X-Received: by 2002:a05:620a:2788:b0:930:9585:e08e with SMTP id af79cd13be357-93bb76ba93cmr329223585a.10.1789554566236; Wed, 16 Sep 2026 03:29:26 -0700 (PDT) X-Received: by 2002:a05:620a:2788:b0:930:9585:e08e with SMTP id af79cd13be357-93bb76ba93cmr329217585a.10.1789554565636; Wed, 16 Sep 2026 03:29:25 -0700 (PDT) Received: from [127.0.1.1] ([86.121.170.232]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-49e83dbb0c1sm71633805e9.14.2026.09.16.03.29.23 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 16 Sep 2026 03:29:24 -0700 (PDT) From: Abel Vesa Date: Wed, 16 Sep 2026 13:28:21 +0300 Subject: [PATCH 05/48] clk: qcom: dispcc-sc7280: Use common probe handling for always-on clocks Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20260916-clk-qcom-rework-legacy-always-on-clocks-v1-5-25a24e50f82a@oss.qualcomm.com> References: <20260916-clk-qcom-rework-legacy-always-on-clocks-v1-0-25a24e50f82a@oss.qualcomm.com> In-Reply-To: <20260916-clk-qcom-rework-legacy-always-on-clocks-v1-0-25a24e50f82a@oss.qualcomm.com> To: Bjorn Andersson , Abel Vesa , Stephen Boyd , Brian Masney , Jerome Brunet Cc: linux-arm-msm@vger.kernel.org, linux-clk@vger.kernel.org, linux-kernel@vger.kernel.org, Abel Vesa X-Mailer: b4 0.16-dev-0e65f X-Developer-Signature: v=1; a=openpgp-sha256; l=1604; i=abel.vesa@oss.qualcomm.com; h=from:subject:message-id; bh=f5Cdf+5sSRQr5GkLyAwVmLKPgMj8336Q2vryy4mWj+g=; b=owEBbQKS/ZANAwAKARtfRMkAlRVWAcsmYgBqqm9P2gsX20GE7BTjKPh3TzFlqRupdupLo4Dtw 90Tm+hzc4iJAjMEAAEKAB0WIQRO8+4RTnqPKsqn0bgbX0TJAJUVVgUCaqpvTwAKCRAbX0TJAJUV Vm5wEACPkc3Lu/WtosbVB/YKp78qYxejHQ0r8AGoGiAsZgBS0CNE2hmX5FooJEp2AY0VMNTYt6h VfU+zmIBY9LmZGhgTQPZP+emI4xa566LYj04OeHqHG48xLT2LCBvEOQNpMSjoFm1tj14CYVJ6qg MkpJJFbEzCwqLs96MjpxxgSyQRFhcnN7czGb4zhemnBCgpY3V3c3eix2WqGTUKlieEKm5QqUcfz vsUDcAti67yovxLhbJUY075bckxI7Cnekowc3quDOlXCqPSRTjuPPd0rxoRg4fAK8ixPzvMCihU h2zB7PZ67JZ0iohTU2GIcOtI0+fRU8uU6jNTBeq9foXULigl27Ke3w6JTrVC2NQBe1q0Z/oXnwg 1UyLmi2oK9xmsMJfqvptAerjGHi+NlDSVS7C5fw9dXpVJo/11Df8l9/D32HglcIa/uWmv89ey8r 2PtVSy/4WI5RVizvPdqPA+xd2bSJV3o9xEVNyWaueR2/FTE8nq+6PO6MY12rWnURAycABWrG7Il 8LHgyVZxDK/99LA6Qu6meDhJmXV09/unlBEYundsp7uo4tGWhmInf6e7EsDzMnvdnH7UPxkO9h4 pdclSy+MT0cBbajANQ6tPKPVtue72aLeWdHrFuf42WrcrS+UP7IcvxMloOfXD5Q8zINT7yCzIys upYVnDe0DEiJxgA== X-Developer-Key: i=abel.vesa@oss.qualcomm.com; a=openpgp; fpr=6AFF162D57F4223A8770EF5AF7BF214136F41FAE X-Authority-Analysis: v=2.4 cv=BtkIUoX5 c=1 sm=1 tr=0 ts=6aaa6f86 cx=c_pps a=7E5Bxpl4vBhpaufnMqZlrw==:117 a=po8fGBi+ks8MzcVQGuqtFQ==:17 a=IkcTkHD0fZMA:10 a=VdqzKS8jKosA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=rJkE3RaqiGZ5pbrm-msn:22 a=EUspDBNiAAAA:8 a=_TElPO2WjJGltpybzhUA:9 a=QEXdDO2ut3YA:10 a=pJ04lnu7RYOZP9TFuWaZ:22 X-Proofpoint-ORIG-GUID: ohqSyZJyxljEwGFEUMy6_WOraMfK6PDu X-Proofpoint-GUID: ohqSyZJyxljEwGFEUMy6_WOraMfK6PDu X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwOTE2MDEzNyBTYWx0ZWRfXwjXee+jo5csD TdCRL76DMIwC7GyMq5i0oModY+atulIMx4kbrTlE8T4dp7hBbwdQ4IOYM4ZnWAXvZcp9GH65NoI D+74h9ewvgT+dCRec7oZ4KAmomBw660Hz1/3Phi0dQil63H4E7WDgkWqd5bgedckJhfMaoBz6MU UTe5cjZTADKFWLpMhCHgdYNMA1V4yQnTxN4O+A4+1p0esRdlvxM+Xewjuj0gwoWA2lTJGRfRCEw Yn6AZeyKENW806zU2trdf1UAFzJj1nAJ0afZoo+C7PUlToHOMKpIIokZBp7cIG7BlAj35UMZ5lP XWvGErz6QwDQpWlDM4eu/41hz0j0JVTgM1SbiQJysUcmtVN203kBssG/bwMJIq7zt1To5jZdwjS 948r1koP5Mg1qiZbDZYDk7Gm//kaUAG3N/yZqVdTGhWZ4EikvySj2r55fO2lQ4Vc/ItkuSE6irT tiAoqmvCJALLy40xqcQ== X-Proofpoint-Spam-Info: AW1haW4tMjYwOTE2MDEzNyBTYWx0ZWRfX9HgsJnUY0Kg0 b6vE/9k8pPbohx4/VFTKS4EV7z6oLEGCUZtFEOdgycnp3rNuTlb68M0W5hmVWv6J7Dj8eUS27m1 9S8DNtJUe+O8zTzbaU3Idkkhm4Oujfw= X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1176,Hydra:6.1.134,FMLib:17.12.100.49 definitions=2026-09-15_05,2026-09-15_02,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 priorityscore=1501 lowpriorityscore=0 spamscore=0 adultscore=0 malwarescore=0 impostorscore=0 bulkscore=0 clxscore=1015 phishscore=0 suspectscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2609040000 definitions=main-2609160137 Describe the always-on branches in a critical_cbcrs array and reference it through qcom_cc_driver_data. Let qcom_cc_really_probe() enable these branches instead of programming them directly in the driver's probe. Assisted-by: LLM Signed-off-by: Abel Vesa Reviewed-by: Konrad Dybcio --- drivers/clk/qcom/dispcc-sc7280.c | 13 ++++++++++--- 1 file changed, 10 insertions(+), 3 deletions(-) diff --git a/drivers/clk/qcom/dispcc-sc7280.c b/drivers/clk/qcom/dispcc-sc7= 280.c index d11265debaf9..24a65cbb1ecf 100644 --- a/drivers/clk/qcom/dispcc-sc7280.c +++ b/drivers/clk/qcom/dispcc-sc7280.c @@ -860,7 +860,17 @@ static const struct regmap_config disp_cc_sc7280_regma= p_config =3D { .fast_io =3D true, }; =20 +static const u32 disp_cc_sc7280_critical_cbcrs[] =3D { + 0x5008, /* DISP_CC_XO_CLK */ +}; + +static const struct qcom_cc_driver_data disp_cc_sc7280_driver_data =3D { + .clk_cbcrs =3D disp_cc_sc7280_critical_cbcrs, + .num_clk_cbcrs =3D ARRAY_SIZE(disp_cc_sc7280_critical_cbcrs), +}; + static const struct qcom_cc_desc disp_cc_sc7280_desc =3D { + .driver_data =3D &disp_cc_sc7280_driver_data, .config =3D &disp_cc_sc7280_regmap_config, .clks =3D disp_cc_sc7280_clocks, .num_clks =3D ARRAY_SIZE(disp_cc_sc7280_clocks), @@ -886,9 +896,6 @@ static int disp_cc_sc7280_probe(struct platform_device = *pdev) =20 clk_lucid_pll_configure(&disp_cc_pll0, regmap, &disp_cc_pll0_config); =20 - /* Keep some clocks always-on */ - qcom_branch_set_clk_en(regmap, 0x5008); /* DISP_CC_XO_CLK */ - return qcom_cc_really_probe(&pdev->dev, &disp_cc_sc7280_desc, regmap); } =20 --=20 2.54.0 From nobody Fri Sep 25 05:31:34 2026 Received: from mx0b-0031df01.pphosted.com (mx0b-0031df01.pphosted.com [205.220.180.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 706354CB8D9 for ; Wed, 16 Sep 2026 10:29:34 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.180.131 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1789554590; cv=none; b=b+XjoLmTNzErU0asODo6R0vQ2yZP7qTXvTIIkGhyRdC9JTBtoJeZpT1K8qAopsX3BdyEPrZf7Rsa4bWNAusonSBYKmHUedLY1CC8HcRMwlyjfCbXYu3028+lojJjjayo63pyYf7r2I/NECkK8VNN0JyKiiIo8Ma4sci3yl7owXA= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1789554590; c=relaxed/simple; bh=rJL1L+iwp51yuk4Imk2Pp+gUtXaREErqbRDD6Zpuq00=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=M7MI4pjttX+Ke4IAHtHRWyxMv6lC5LjnOVlBVleTlJDrIMGt798qud1xED5D4AbYBpbPjpYN2TEgZMCOB78hkq/6RWQrmw+yNWArAEuRQxh6VVZifuXV6i6G4EIcJI+x6hGLTD0F+XpI6K1NIBrEgT9WrrluRXWSsPiYqx0GMaQ= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=R4j8zPxu; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=fgaFSlOI; arc=none smtp.client-ip=205.220.180.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="R4j8zPxu"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="fgaFSlOI" Received: from pps.filterd (m0279872.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 68G932k51587054 for ; Wed, 16 Sep 2026 10:29:29 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= lxMbCdaVL+Fc2ZqDAOPg/IOPnkFKbfFO/T/ZmAWxmAk=; b=R4j8zPxuDg6fGwFv 83CXfA8phrYSWNawk6BiTkeP9Z8LqQyASdXHcZE4+YHDpbS6z6GmcCbIzz3pmRMR e0K+JxXpH3IJJGrp6UYmkqGuuGNX3KPfCArHX5kILE/nzTBq2F5Keszf0+x+IPXb +0043CgxOyBs+innnEmY/MULfjqsPrlej/XHzq4SSpNHI04VHu5FCvKVf+ZtrImW 6JdRe3hdZuBYXRiRPpb4UNRpEqhKgvIEiO8JQ1RtXvcOOcmmkaU91/Qp+7v3Vmqs QEkCVYMXS3LAfiShBwleKLfdWNVh290cvfkutCf5X+xvLAsoZIAggCM/gtyY/b9n qVcZJA== Received: from mail-qk1-f199.google.com (mail-qk1-f199.google.com [209.85.222.199]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4gqageksbe-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Wed, 16 Sep 2026 10:29:28 +0000 (GMT) Received: by mail-qk1-f199.google.com with SMTP id af79cd13be357-93a3f673221so26638885a.0 for ; Wed, 16 Sep 2026 03:29:28 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1789554568; x=1790159368; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :content-type:mime-version:subject:date:from:from:to:cc:subject:date :message-id:reply-to:content-type; bh=lxMbCdaVL+Fc2ZqDAOPg/IOPnkFKbfFO/T/ZmAWxmAk=; b=fgaFSlOIftmzoSE6YEswOGSf/Z21QlDUyi5fVP4r5Tb5WF4rvEAXoTM4c5M2SdaqQq RxRpBfHwKz3MBUNInl8WlDfMzEP5/K/zR42xYTy0m35aAG3NENlzHYAsuRrM2XDhI/On ARc6ahFOqjCOhiIbx4kVZBLSZW/PMCYju0iN2QPRVqYm1ILACA693q7TzT0WCu0tXSx1 SXs41i1/77JZJsO8+4cD8fdTready1yr4N2kgjgMRF0OiTcVc2yVhgBoaB6DTA4dsISf H/nVkbs5nVVi4ywsuAGlyZFgDZqvaxnooH6te2qu5mCyjcsDa3zKwN9K5Z+0kcz3gtlC Qtmg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20260707; t=1789554568; x=1790159368; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :content-type:mime-version:subject:date:from:x-gm-gg :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to :content-type; bh=lxMbCdaVL+Fc2ZqDAOPg/IOPnkFKbfFO/T/ZmAWxmAk=; b=hcIXlvptW6sAmIq53k+U1pjXdKz4VR+UC2dX8c2dXem3TkWZBrqEoYeFym6rtsQSi5 RbdM+Vql5GLxVGakYRa4y6NP4wCfTGH0Cy7iudVQEqTSgD7GHUOJbR251yUel/sAuEww CG6/ndt4tK9DK0JW94TxiQfQpFkapCQSggqUKLodol5rqw/paz6wWwFrXUCTby27EzlM 4FxkhMwwUiEv3DnxAb5+z0e/Vatxr1JHeEhT/RgR9smGPFewQW0Yvb6DmyXyBrAusgQR 5ax9btQaIy+AlhVtPwH/c71vGc6+SVeNiKwhjye/6aaCKJGv/R6ujb0HlVKHVvrzJ1XI XTRg== X-Forwarded-Encrypted: i=1; AKwUvBwKQG40vJMxwCWIW7Cfa0agU+otSWiHz0/slCZfxHUY/7TnLX2fz3h6/LASIZJ3Nc3Prd8Z3dy3KcPSeMo=@vger.kernel.org X-Gm-Message-State: AFuF++kWYJh0sSPhv4tafXxwfOZ4BH7er7VCNjPYWJwCbyp2It1w2QFs DGQp/mVtKFNnvZNmb87CXTvQ9JSUAmGYb9a0fp0hcvTJQVsMAlJYeAwfBISac4sEu76gq6PqabM BOe9JOZEaE9cmkNqhU7hqS8pD71ME2iaGpvYdPogPlS11Jhzw0mLpUkpBMWVNs7UCrLA= X-Gm-Gg: AYBFou0ksUD6JAs8p7nUjeV9vOtC5DOapozRPbdieNZevTMBQXVffupw5eZ9IV/r8Gn fSMfQjmhPAzH5hTJMNmVboHSARg5DVQdo+Csw1jsKdNQSDOgRffZZCHH3X5Tv3yMV5qWIJli0FP oGifkBUZSkkRyKdX/JHduoLZjcFc0rAhmQKULgF5DfOxwWdz9B8pHeYLXodRbqk1+9DzZ4ot9dR njMLuo9GK6kGmcD82hUqheEc96Ilyvpvk5kB11QzhkwAxZpNSbdnVUyH13WfcNMpO4MPhteLc1d bK3eTiY8UsFA8YHhfRuPfnwMigRa6QjKqQOs2ktdxAE1xVXXkgj12w3p0ddQgi1p1YLz1JkZG3H aTQT1FWo= X-Received: by 2002:a05:620a:4409:b0:939:6de8:43db with SMTP id af79cd13be357-93bb79487e0mr296748085a.47.1789554568167; Wed, 16 Sep 2026 03:29:28 -0700 (PDT) X-Received: by 2002:a05:620a:4409:b0:939:6de8:43db with SMTP id af79cd13be357-93bb79487e0mr296744685a.47.1789554567693; Wed, 16 Sep 2026 03:29:27 -0700 (PDT) Received: from [127.0.1.1] ([86.121.170.232]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-49e83dbb0c1sm71633805e9.14.2026.09.16.03.29.25 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 16 Sep 2026 03:29:26 -0700 (PDT) From: Abel Vesa Date: Wed, 16 Sep 2026 13:28:22 +0300 Subject: [PATCH 06/48] clk: qcom: dispcc-sc8280xp: Use common probe handling for always-on clocks Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20260916-clk-qcom-rework-legacy-always-on-clocks-v1-6-25a24e50f82a@oss.qualcomm.com> References: <20260916-clk-qcom-rework-legacy-always-on-clocks-v1-0-25a24e50f82a@oss.qualcomm.com> In-Reply-To: <20260916-clk-qcom-rework-legacy-always-on-clocks-v1-0-25a24e50f82a@oss.qualcomm.com> To: Bjorn Andersson , Abel Vesa , Stephen Boyd , Brian Masney , Jerome Brunet Cc: linux-arm-msm@vger.kernel.org, linux-clk@vger.kernel.org, linux-kernel@vger.kernel.org, Abel Vesa X-Mailer: b4 0.16-dev-0e65f X-Developer-Signature: v=1; a=openpgp-sha256; l=2337; i=abel.vesa@oss.qualcomm.com; h=from:subject:message-id; bh=rJL1L+iwp51yuk4Imk2Pp+gUtXaREErqbRDD6Zpuq00=; b=owEBbQKS/ZANAwAKARtfRMkAlRVWAcsmYgBqqm9QBuI67EondQQlWsSA5YKz3g8vmaGns+xeo pGSxXnMcnKJAjMEAAEKAB0WIQRO8+4RTnqPKsqn0bgbX0TJAJUVVgUCaqpvUAAKCRAbX0TJAJUV Vs6xD/9U3b++Vm5F8gT8kvjfdeFYr/rh5MdHnwmTd71mRvmnd5NWDjMDMiRTVHKoaNKMFKOpGzu 2f6OTI2zYU3RTv58ur+W8tiF+xE8wTuRwVddPHr+vdM16xDPG0OsQQOHIZLBSBLETyuqwUqQIvS g/QAJzu+e28GpTWMClKcyLF3N4koo0DC50jeBSnpRljWABac64INh0Sxgao4dy0jCoTO6I4X3v/ jW/NdPcIwX552XaDdTXrTuHATKM1O3OvMW2AFjEXQAeDANrBsLoioIgf3MJxBURGPiH94YTlKLS IMsTIt/X/S1ndLLBkR8Y59jyJmAcH9zMlHxSoij/LApiEv3pc9ns2M+zM15Z7BrTQ55UELhEvjn mg3gdCm/uHuGoJMOdmTumx05y32haHXKIz4DzhxdH8wbJ3tKm1Hry/zjwm6ayUdwQ3oxWHRHeW8 RdZ29NvYYg912SvkLU+rdLXxmmr/tGbNpRzTMLCUtBbnzCRqogUmAk2J66c8zPCrwixLz03z4pw WJbjKZl/sU13X9iwHrS61jJIok8cyxyikXQiliEkErN60XNjB2t0BSufs9C/VEcmfq9U3XjCl5o RyQ8jBhy8HXGvjIMtPZCQXWkgQpXweO09QvtHQR5+o3MZ65h/4qwj4fV0Jh7Pr3vG4PoC9h2P0z uCetdPHzTC4xFkg== X-Developer-Key: i=abel.vesa@oss.qualcomm.com; a=openpgp; fpr=6AFF162D57F4223A8770EF5AF7BF214136F41FAE X-Proofpoint-Spam-Info: AW1haW4tMjYwOTE2MDEzNyBTYWx0ZWRfX+v8waxqr2EFw 6bj/cJKxkUdettf+KZNxGErdg6yLv6VshWK6Y4lRZfugJjKfx65A2rTQTS3eBF3rkQv/CDQfP4Z ao14UHW3YttcN5etBvPgO0NXvLDX20I= X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwOTE2MDEzNyBTYWx0ZWRfX4afKIUDnLyCj VYcUEJR/Hb40oOyV7lamtuO0uZwGI9Cy8Js/s51sHc/zHKeC+MlmdeG80ntFG9XZNJV9Nln802+ i+NhTrVxQ5cAGP4oSNItolOrVgb49U+YFr0dhBZppNcvW33KOVRPs46vgp/mFA1BYCDi9HmaYf7 LxdJz4FiFfhI52QYQTO4OTW8thHrb2Xo9Ro/Y17KCMO6ELw880SLdOxl/pZS5r2oVsuSWKcIPjS 4k8k+VjW3A+t4VWccHj16ZHXrM21HpOat2YiqvWK+89/DMT+uxVU92Nmh33t59395BB28Y5vg6R 1ge1XSDNzAlCld0GReXx9glBVYQFYkYgV8t+9mhI1TnxzB5L7wDhF+ajx8wNOi7GdleZCeAeS7L vRNQSMBkgWT/8Pl8HPMvM/tnvd1ibXkuB7Dy96g8hd7CgixNvxEKos5dtvmAZQLdUL1FYM6v2kU l38hjgjB2blYFpqTgrw== X-Proofpoint-GUID: CF9ig8wzv9wAjkEla4BH3EYjQLXgqu1F X-Proofpoint-ORIG-GUID: CF9ig8wzv9wAjkEla4BH3EYjQLXgqu1F X-Authority-Analysis: v=2.4 cv=PcZqFShd c=1 sm=1 tr=0 ts=6aaa6f88 cx=c_pps a=HLyN3IcIa5EE8TELMZ618Q==:117 a=po8fGBi+ks8MzcVQGuqtFQ==:17 a=IkcTkHD0fZMA:10 a=VdqzKS8jKosA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=yx91gb_oNiZeI1HMLzn7:22 a=EUspDBNiAAAA:8 a=JaSVaRig_KI77aDXWKAA:9 a=QEXdDO2ut3YA:10 a=bTQJ7kPSJx9SKPbeHEYW:22 X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1176,Hydra:6.1.134,FMLib:17.12.100.49 definitions=2026-09-15_05,2026-09-15_02,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 spamscore=0 phishscore=0 suspectscore=0 malwarescore=0 impostorscore=0 clxscore=1015 lowpriorityscore=0 priorityscore=1501 adultscore=0 bulkscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2609040000 definitions=main-2609160137 Describe the always-on branches in a critical_cbcrs array and reference it through qcom_cc_driver_data. Let qcom_cc_really_probe() enable these branches instead of programming them directly in the driver's probe. Share the CBCR data between the two display controller descriptors. The XO branch is now enabled by the common probe before clock registration. Assisted-by: LLM Signed-off-by: Abel Vesa Reviewed-by: Konrad Dybcio --- drivers/clk/qcom/dispcc-sc8280xp.c | 18 ++++++++++++------ 1 file changed, 12 insertions(+), 6 deletions(-) diff --git a/drivers/clk/qcom/dispcc-sc8280xp.c b/drivers/clk/qcom/dispcc-s= c8280xp.c index 96609bd5233f..96b3e5505279 100644 --- a/drivers/clk/qcom/dispcc-sc8280xp.c +++ b/drivers/clk/qcom/dispcc-sc8280xp.c @@ -3108,7 +3108,17 @@ static const struct regmap_config disp_cc_sc8280xp_r= egmap_config =3D { .fast_io =3D true, }; =20 +static const u32 disp_cc_sc8280xp_critical_cbcrs[] =3D { + 0x605c, /* DISP_CC_XO_CLK */ +}; + +static const struct qcom_cc_driver_data disp_cc_sc8280xp_driver_data =3D { + .clk_cbcrs =3D disp_cc_sc8280xp_critical_cbcrs, + .num_clk_cbcrs =3D ARRAY_SIZE(disp_cc_sc8280xp_critical_cbcrs), +}; + static const struct qcom_cc_desc disp0_cc_sc8280xp_desc =3D { + .driver_data =3D &disp_cc_sc8280xp_driver_data, .config =3D &disp_cc_sc8280xp_regmap_config, .clks =3D disp0_cc_sc8280xp_clocks, .num_clks =3D ARRAY_SIZE(disp0_cc_sc8280xp_clocks), @@ -3119,6 +3129,7 @@ static const struct qcom_cc_desc disp0_cc_sc8280xp_de= sc =3D { }; =20 static const struct qcom_cc_desc disp1_cc_sc8280xp_desc =3D { + .driver_data =3D &disp_cc_sc8280xp_driver_data, .config =3D &disp_cc_sc8280xp_regmap_config, .clks =3D disp1_cc_sc8280xp_clocks, .num_clks =3D ARRAY_SIZE(disp1_cc_sc8280xp_clocks), @@ -3167,13 +3178,8 @@ static int disp_cc_sc8280xp_probe(struct platform_de= vice *pdev) clk_lucid_pll_configure(clkr_to_alpha_clk_pll(desc->clks[DISP_CC_PLL2]), = regmap, &disp_cc_pll2_config); =20 ret =3D qcom_cc_really_probe(&pdev->dev, desc, regmap); - if (ret) { + if (ret) dev_err(&pdev->dev, "Failed to register display clock controller\n"); - goto out_pm_runtime_put; - } - - /* Keep some clocks always-on */ - qcom_branch_set_clk_en(regmap, 0x605c); /* DISP_CC_XO_CLK */ =20 out_pm_runtime_put: pm_runtime_put_sync(&pdev->dev); --=20 2.54.0 From nobody Fri Sep 25 05:31:34 2026 Received: from mx0b-0031df01.pphosted.com (mx0b-0031df01.pphosted.com [205.220.180.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 882C44BE449 for ; Wed, 16 Sep 2026 10:29:35 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.180.131 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1789554594; cv=none; b=pqjNkQwK4YoqpQz/hH2/aEewdfb82ddj2ayq+zxFxlgkqWhX3n4b2JnvZ5ioLbyZf5jIdJb79cTFQ33Z1/5uZpxxmjCzSgoyUYS99VmeMpzXmDB8jShMn7OtANVOtHINwFU9HFilcaAiljf9GVnLopyOsmCL1dz/H1dJM6Z4G70= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1789554594; c=relaxed/simple; bh=NEcyM91aSl6BFMYhR9y9z9Qnf62ZfDA4T0e9hLBaXio=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=hUG1rsnl2GJqqmmstG9ZFsj1qFHFSpUpZdCnl5SQaEiLbjj7fYwZIGDs/+9+5yuKxH2LOKY48WEka/bCbVADDuQYbQnGjkxjMh7ts+h6GxMn58i2ckZy1x9sPkEARezxya9MKULujFQSlqbbqIhEr8X1yVBmy9MVc2TbVsdBIa4= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=Of0R35aU; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=DApK4BKO; arc=none smtp.client-ip=205.220.180.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="Of0R35aU"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="DApK4BKO" Received: from pps.filterd (m0279873.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 68G935Yv2226633 for ; Wed, 16 Sep 2026 10:29:31 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= wn+EokI8YmyHqDNQRq31MkrfGIsBHcrZ0BrDK7mrilc=; b=Of0R35aUkQxxQPqi TgLhC0j/0u1Hd2Ll4fzopU7INhYBVIu/LWxc4KN2yGhsTfCaxAIC1yefZozJkQ2o LvLwy3BdWY7Po3H2NJNR5OKSz4MnmLrvL1z8/GZGVlrgV112Q98It4Y93YnmM7Tb 9gsOhwwOEJ+SAGV2NQP220G9Wt+2ju8+Q6unWGRjQ9d95mHgaFNn9FUsKQTG4OMu hYge2u6vloDyDIhOX0m+K49nBZWyjgjQTc3Cx7taPoReuuDpYwNm47bD+Kq0l1yt 6slPYSKmyyqEpCBGCsKzznD3HjRtKcWpzZ0Egy09OlMNTA43Avj/TRWC4t7tMen+ WwjPGw== Received: from mail-qv1-f70.google.com (mail-qv1-f70.google.com [209.85.219.70]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4gqah9usy7-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Wed, 16 Sep 2026 10:29:30 +0000 (GMT) Received: by mail-qv1-f70.google.com with SMTP id 6a1803df08f44-91214e93c2cso76681566d6.3 for ; Wed, 16 Sep 2026 03:29:30 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1789554570; x=1790159370; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :content-type:mime-version:subject:date:from:from:to:cc:subject:date :message-id:reply-to:content-type; bh=wn+EokI8YmyHqDNQRq31MkrfGIsBHcrZ0BrDK7mrilc=; b=DApK4BKOa6X1KBmWB0P44Pow6M0ddb7oUyOMR8AxFzk9TnT7TxW65YZS70t4FIx1AJ w3DfpzASaaH0uRVAZL+mIAqDDiiDW7D9cgttqcqsRQq5dz3KY3l2mTgEOFZ+inbBvJ7m abubPw0kyLxxyBFN13BBRF1+wfNUctyix9k+Z5SkDmfzUoXwnIoCZk3o88Amn1hRWLl6 Q8A/zhBvYsXh/FiIRwko3MLhrg8TIaN4G26m4j5pzwrMWrySDgULFSPKFLPsOAgDOyKx /a4K5FTdMP8x4iAMIKimO3gBbm1g4lWix8zEq8b+n/KYdviQGo7zyF/InNKO1GH70FU3 iGdg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20260707; t=1789554570; x=1790159370; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :content-type:mime-version:subject:date:from:x-gm-gg :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to :content-type; bh=wn+EokI8YmyHqDNQRq31MkrfGIsBHcrZ0BrDK7mrilc=; b=A2D1Bow1/Jn7b6oJDnscodA9kIEmKIRZhQetpBjmPbC8CsnGjpGASA/dlfTNrk0WFM 6zvTWR+kEl0o7EIhTVgA2YGNtJmXwz7uVCOu580HbCs+SGa2ZYcO8w/GP29GXJ7cl9uN EDACRSRfpC/s1jhRJKFV5C6IKHlkPpqLlHTiqw4W6idjZEVQrSZ6Dinu+fYy9/gaxEXJ z7V5QLeC741t6MhsQydUyLLwF+yCmUPzUuGJ66JptzYrgwfsxmRsw5tm4RHaEFUPWnnS i21GwTed5byr41CgUL29z2yn1uru2Iz7elZvSNZ+qb1G5vqRaOWI21lrLmCjHnyDLbPl R23g== X-Forwarded-Encrypted: i=1; AKwUvBymFO35RN8ST+bjndHWBMi9EacvC+lwvtV0sUwkKQtn4O17b39qRMSbPXdjAu87tDnVVDPGCKwVlJAbJ00=@vger.kernel.org X-Gm-Message-State: AFuF++lOvgmNaxSaS/5/Thx4BHoHYXdv9krHujbS6ABP+784FUgoobV+ GgZqL08ekfg25L2i+z7tgPgWlPl+inFAuBhmZyLPGc6vPy0ggfafJGbKqPI8Dr37OV0YTxuqawi pFq+bVaoF9kGY7xg9rDHnushXhZIP0zS2xtkR9S88qsVP5OAOqDyEJZIdaP4wGwFPe9o= X-Gm-Gg: AYBFou1YEfSAYPiTDIVy9Jb56hw969N7H94x6GIOeKYO8HV6tcPf/X7zwhjNI/IgE7r qDQExVOmLbm5QytY1h1bCqM63BOoq0U4Y7sU5NitsEDox115qV0LBpd4+RB0Df/XGl4YX4DvZkX AtJzXWQczJuHwgbVrVowBk3P/v8xRuUmRySFaOAElom7sdXD0eJXouamk5Wr0t7VwvNKCYVADEE j4MU80aJ6+j1ZbanFqW9dKquOTAlIRFKeMNKy+299hyPYcV5fObXpvC4rCTiBOoT9qjiWdOqoLq Gq61M+1PQ2htrON+wuXdzMmlItqDMkgHJpJCfD8X1s1czXCPkHmMdwFBIv7g/Dw6QCaD0eAIiHI v/yImK4I= X-Received: by 2002:a05:620a:800e:b0:939:993e:bffb with SMTP id af79cd13be357-93bb76fe856mr274693285a.22.1789554570215; Wed, 16 Sep 2026 03:29:30 -0700 (PDT) X-Received: by 2002:a05:620a:800e:b0:939:993e:bffb with SMTP id af79cd13be357-93bb76fe856mr274689585a.22.1789554569663; Wed, 16 Sep 2026 03:29:29 -0700 (PDT) Received: from [127.0.1.1] ([86.121.170.232]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-49e83dbb0c1sm71633805e9.14.2026.09.16.03.29.27 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 16 Sep 2026 03:29:28 -0700 (PDT) From: Abel Vesa Date: Wed, 16 Sep 2026 13:28:23 +0300 Subject: [PATCH 07/48] clk: qcom: dispcc-sm4450: Use common probe handling for always-on clocks Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20260916-clk-qcom-rework-legacy-always-on-clocks-v1-7-25a24e50f82a@oss.qualcomm.com> References: <20260916-clk-qcom-rework-legacy-always-on-clocks-v1-0-25a24e50f82a@oss.qualcomm.com> In-Reply-To: <20260916-clk-qcom-rework-legacy-always-on-clocks-v1-0-25a24e50f82a@oss.qualcomm.com> To: Bjorn Andersson , Abel Vesa , Stephen Boyd , Brian Masney , Jerome Brunet Cc: linux-arm-msm@vger.kernel.org, linux-clk@vger.kernel.org, linux-kernel@vger.kernel.org, Abel Vesa X-Mailer: b4 0.16-dev-0e65f X-Developer-Signature: v=1; a=openpgp-sha256; l=1792; i=abel.vesa@oss.qualcomm.com; h=from:subject:message-id; bh=NEcyM91aSl6BFMYhR9y9z9Qnf62ZfDA4T0e9hLBaXio=; b=owEBbQKS/ZANAwAKARtfRMkAlRVWAcsmYgBqqm9R79Wm5q30jug0+rTLSP17OAV31T+NhkDtd RUktM1VI+WJAjMEAAEKAB0WIQRO8+4RTnqPKsqn0bgbX0TJAJUVVgUCaqpvUQAKCRAbX0TJAJUV Vv9kD/4l5uxc0MkkntUSrqgCdg2bGsXBI/IyOAgqXRYZ1104elJFfZaqFel0H7IPp7BV8J7QFC4 veTkrazPG83YTUp1Lxa0bHse7+LfN9aM8K4f8l4tAe3/pTKfQ5C+c1AxtmAkE6h0sxxxQvQ5SGu HqdtAjRz5rey6pPxvXT8rJrMfzxbamn2owsMGjfw2krphbEqrmnde/G6FD1KSo3sbf23jBsPsI9 27YEzSoxBED/gaWZTgR6TSvDjCqQdjHBb1+Ycfiyv/gCtsi10MpklN6wdu1VGYl3UpVz6fGO2U3 NeBZ2Wz6hZt1qiCcO8HChIUC9aiX5qiRNF59y0/bJjMIptW2bH5A/zA73iGEHEadjCoXcLJ71fr Naovtf+4hM5PNT3ihtzQZweRMj9z3C5MJt1H2Lung3JKobMXCmWmNGvyeJEIuRe+UsOkZciEbnt rdztF4rN3kRRygtoj+5mFoYMFVkvYODV210zgZb0izuMdprbkk6XX4S55l0JYktvxdGJSNPxvlu WYr3tB+ON8O5YLtLBKhgAMlSWFq7kjCbLIEX7CPbekNn42aK4dmcahJI152LWP2qPQvO41ISJcy SDBZGJkTsX14ta/7ocyMnhePBy9PMl6kM31h0hnkORyq59UHEeq2a2qNgIDtfYwSuDnVJ5Ddh/G VAaDU2CZ2rYRIjA== X-Developer-Key: i=abel.vesa@oss.qualcomm.com; a=openpgp; fpr=6AFF162D57F4223A8770EF5AF7BF214136F41FAE X-Authority-Analysis: v=2.4 cv=BtkIUoX5 c=1 sm=1 tr=0 ts=6aaa6f8a cx=c_pps a=oc9J++0uMp73DTRD5QyR2A==:117 a=po8fGBi+ks8MzcVQGuqtFQ==:17 a=IkcTkHD0fZMA:10 a=VdqzKS8jKosA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=rJkE3RaqiGZ5pbrm-msn:22 a=EUspDBNiAAAA:8 a=Mkos_PfpLiWYs3bmBbQA:9 a=QEXdDO2ut3YA:10 a=iYH6xdkBrDN1Jqds4HTS:22 X-Proofpoint-ORIG-GUID: vZrT43pi56_BN2k5dEXkwQqmkT39Qs4p X-Proofpoint-GUID: vZrT43pi56_BN2k5dEXkwQqmkT39Qs4p X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwOTE2MDEzNyBTYWx0ZWRfX+B66x6wyDFVS XzX0gN4bfYRVs9jwaq/VNefycmaQpVqxLDtSCPEDr6sZxS7/eB8bC/wjPsWsXKodqtU0zQz4SoJ jwIdwWQbM8/+D2VOw2oneEkpQ8Q7IHF471ebN8nD8fqE9U4BVnd/B5x4ZZlXZ6LxYe6gevrk3Lk OIFMW0DhaLCCyRCkfQQenHXBPCO/clFj+a7NkzxE6hWkcWbBagSCtmZecjUKshaj9stPv3RQDXE ULmv4h+o+qWVYpE8UygBfJMa1zYtIm3R/KSnGFHIYazTERNeOhtKL+uOf3qHAQAx7u6CBC0Ry80 +XYw7UFAMKjJWRH7utQNzTb3G1rwrVajEhwTZ8OkigjoOEhI3itKkS2N11ww0ZQcCWE6kup4QZm oZ2NRuK6IAY/6WWwpEuGXlpxA8nRNOFbx+nsdXOuSre76fwUpUWYaTXMic0uuEFr+8nZLRj6dol qiS+iIzIzF563mAk6jw== X-Proofpoint-Spam-Info: AW1haW4tMjYwOTE2MDEzNyBTYWx0ZWRfX58+nJt8KUuUo AkDNrZ+MNiNTSQa9z/sDjun8VhM5zi8QwDQ4sCvreHAF1EdQx2WAa1KNQX5FAnH5FVc8QCS7S86 GvZDQ/gVTdTM0D0tRebECXhWrZJ76yw= X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1176,Hydra:6.1.134,FMLib:17.12.100.49 definitions=2026-09-15_05,2026-09-15_02,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 priorityscore=1501 lowpriorityscore=0 spamscore=0 adultscore=0 malwarescore=0 impostorscore=0 bulkscore=0 clxscore=1015 phishscore=0 suspectscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2609040000 definitions=main-2609160137 Describe the always-on branches in a critical_cbcrs array and reference it through qcom_cc_driver_data. Let qcom_cc_really_probe() enable these branches instead of programming them directly in the driver's probe. Assisted-by: LLM Signed-off-by: Abel Vesa Reviewed-by: Konrad Dybcio --- drivers/clk/qcom/dispcc-sm4450.c | 15 +++++++++++---- 1 file changed, 11 insertions(+), 4 deletions(-) diff --git a/drivers/clk/qcom/dispcc-sm4450.c b/drivers/clk/qcom/dispcc-sm4= 450.c index 4a4811db55dd..f39afa067cc6 100644 --- a/drivers/clk/qcom/dispcc-sm4450.c +++ b/drivers/clk/qcom/dispcc-sm4450.c @@ -719,7 +719,18 @@ static const struct regmap_config disp_cc_sm4450_regma= p_config =3D { .fast_io =3D true, }; =20 +static const u32 disp_cc_sm4450_critical_cbcrs[] =3D { + 0xe070, /* DISP_CC_SLEEP_CLK */ + 0xe054, /* DISP_CC_XO_CLK */ +}; + +static const struct qcom_cc_driver_data disp_cc_sm4450_driver_data =3D { + .clk_cbcrs =3D disp_cc_sm4450_critical_cbcrs, + .num_clk_cbcrs =3D ARRAY_SIZE(disp_cc_sm4450_critical_cbcrs), +}; + static const struct qcom_cc_desc disp_cc_sm4450_desc =3D { + .driver_data =3D &disp_cc_sm4450_driver_data, .config =3D &disp_cc_sm4450_regmap_config, .clks =3D disp_cc_sm4450_clocks, .num_clks =3D ARRAY_SIZE(disp_cc_sm4450_clocks), @@ -746,10 +757,6 @@ static int disp_cc_sm4450_probe(struct platform_device= *pdev) clk_lucid_evo_pll_configure(&disp_cc_pll0, regmap, &disp_cc_pll0_config); clk_lucid_evo_pll_configure(&disp_cc_pll1, regmap, &disp_cc_pll0_config); =20 - /* Keep some clocks always enabled */ - qcom_branch_set_clk_en(regmap, 0xe070); /* DISP_CC_SLEEP_CLK */ - qcom_branch_set_clk_en(regmap, 0xe054); /* DISP_CC_XO_CLK */ - return qcom_cc_really_probe(&pdev->dev, &disp_cc_sm4450_desc, regmap); } =20 --=20 2.54.0 From nobody Fri Sep 25 05:31:34 2026 Received: from mx0b-0031df01.pphosted.com (mx0b-0031df01.pphosted.com [205.220.180.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 91E3A4E66B0 for ; Wed, 16 Sep 2026 10:29:34 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.180.131 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1789554591; cv=none; b=TyUPk24Jjit2/DpkN55wHuQzCiC1cF2Sa+XN1yWVexNU+G0I20unSu3LNHxneHMk/Xx6lO5P6F7CqF3DfeSDmur3X/mH3oO+6/gJxmV0A4Iw2LwCoqRRPxVSNU9DYsCHD9eEijhvAtpfvkJxNhjOqJOWCEwHhCgT5qkYzxfAkXY= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1789554591; c=relaxed/simple; bh=9l1yH/TyKTh0nUOs+WYEyPBm3fUdzP6RQ05SEUY8blc=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=ZzTGEXkilNY06oW1etw/dZp2td61gAE0fBRSdd/ItbaDnwR48wC2D2C6TZN6r1t5qgta4QlsKXIsg1gq4uFUC1Vu5yg+o7AM3PhYGS7UWfEAs5qtzjpUHSLQ4Wp/3iCEcH0hvLegdvtOrxGdmKqsHUXlXEgqOi/6Zp8GuOzhmxc= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=As8qx8wG; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=dDxiHwML; arc=none smtp.client-ip=205.220.180.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="As8qx8wG"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="dDxiHwML" Received: from pps.filterd (m0279871.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 68G933qG2822936 for ; Wed, 16 Sep 2026 10:29:32 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= V8iVqh0BF8H+A5TE1wGLKJj3rQu75RTalRcZa+kjp0Y=; b=As8qx8wG8+S3Sb/3 gPGLb5VJX2A4/Oj+P4fddEqQKyvh30zmEy6rmOrBsF0LbQVat96eIm3OLeohXxhf VpCoIReVHSCpx2TwrDFR1ihe97fDovm+Cs6loaEREXdMJ8VaqsmT0WIcA6PtNIbZ pOmum28gGREBxW82ivQLqnhZs3qm1UKixWxVPyv7JW8CZLgDadZ6eeI5u44qwXgB C4Dep6/hYRJCfgySnT3qdbf097D72V7JuQAqBaeP77jZl/Cs7nZ3wcLzwLSYo/Kq yEtGJIPfTx1ziTqDmgWxOoA2xqgLzY02svlS8GUKbGvWfk+G8azHp4BuRkCNrTt6 4WHyFQ== Received: from mail-qk1-f200.google.com (mail-qk1-f200.google.com [209.85.222.200]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4gqfvfjb8c-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Wed, 16 Sep 2026 10:29:32 +0000 (GMT) Received: by mail-qk1-f200.google.com with SMTP id af79cd13be357-939f3426a7cso988629985a.0 for ; Wed, 16 Sep 2026 03:29:32 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1789554572; x=1790159372; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :content-type:mime-version:subject:date:from:from:to:cc:subject:date :message-id:reply-to:content-type; bh=V8iVqh0BF8H+A5TE1wGLKJj3rQu75RTalRcZa+kjp0Y=; b=dDxiHwMLz6yXFpZ8UVPG6N2D37Sfyr/JpYyH+QfvREZMa8Nm6N7gw8dgqwro/If+Jk LgF+mMWVAOQE7Lipx1M5xPhIqC4COvMmpXuKNkTdaM3cecvj6MaLKzNwlt9EqbjX6Klg 7Q5mMik8yOofQbIW1TuhA92O1PLyjC+B0lEu3k8P6lIqxmFWfkpDPX8uGNLliQxA+XhT k/pt5gAfDzAuUbV4qJ+d4cU6uWJNgzjYarA7xg10tfxEbYhnUkmTZLKfBq76aHpuHk3O QpBGXpNiVhm+3X8Erpsx0flf5CA7jPE8f+WJLxZSVTelKexCthmS8lnA+i0QEzyCkxHu t2VQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20260707; t=1789554572; x=1790159372; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :content-type:mime-version:subject:date:from:x-gm-gg :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to :content-type; bh=V8iVqh0BF8H+A5TE1wGLKJj3rQu75RTalRcZa+kjp0Y=; b=LUIAITY2TEVEVM0xvmC2R9VzeQJRoLt0fWS8D8obyxJc8hgIftzwAZQ6vtZjrwfH1l 9z3pebDiaJzx+iG8/OeLvf6W0xc5FvLubzC/qoZYPYNzr3YeAXJTpw9ra4ScAmV53y5D rTlEFWHAN+YZU7Ztd35reJ4/cjttML2Y65KAkcxrqPh1uu96kpL7Q2C41Ft4y7QAJDrl Odx5GOCx4dldy6tA4GGhEZ5VVjiwNh6aNqf+++woKBJy2hMAfXb1HSC6WkgEIpPwMfqm ohNmiT/TfD/dbK8VIaXE1BSjJxI3Bn6C4s91JFNAQdhzn5OGXlZ9dGZ7y5QXarZrJVEv iTkA== X-Forwarded-Encrypted: i=1; AKwUvBzZB7jpmNNpwEHoa8aQb5Bzx3twSUnvGkr9ZNC3uQvRPf68UB/LurQwzLuzmNs/EDh/A0vaDXdZEGQvYyM=@vger.kernel.org X-Gm-Message-State: AFuF++lZaIonfclW9K517Jr0TFskmj29PX4uPqFSU0uqWD2+oJLsNE69 lZntHcCTdJlRS3XEpPIsEXelAXwjs3jswzxePEmS4+GkVEZYIdIQN5LbppmZFGZ0tXHBJnSgZ0/ HyrJ2y3cFesCxVEmsa/L9EKNaqQdGfBw0udCi8siapixO4Slz5r1mftBswE5wVWN+nr8= X-Gm-Gg: AYBFou1GkklXQ/tF/lJt+SVhNHuiGfdyO+Ds8OiZNgufZPP/YLKcxBfXFoIq3KwKXWp 38Qlt1Nofc27ae6uJX1eyfMSDbvD0ATOV4vQzxO7IenGzK3VwJ6PbBRljt6YxqkylyArGEOT9uH QbUcGk6d9yKvPUnx7jyRm9mK8aWLGuXoENA8NIe95pFOhJ2O5vMO6smlITB5Mdj/4ZVaF+I07Di nwrY5zaIqSIN80oZgZWqxd5lj9oVAuZaxZj5rvG21x/km+1glk45UqnAr2t0s+oz2a0jw0guGd7 GlO2pxrAgUpdaAdwhjoypKmLf0z2c9tXMp25UOPNozPIgZLaQAvR+fwUPJtYIOwbh4ZYdZYZJNI xOa5atsI= X-Received: by 2002:a05:620a:2809:b0:915:a953:4b9c with SMTP id af79cd13be357-93bb76e380cmr318183185a.3.1789554572042; Wed, 16 Sep 2026 03:29:32 -0700 (PDT) X-Received: by 2002:a05:620a:2809:b0:915:a953:4b9c with SMTP id af79cd13be357-93bb76e380cmr318179385a.3.1789554571547; Wed, 16 Sep 2026 03:29:31 -0700 (PDT) Received: from [127.0.1.1] ([86.121.170.232]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-49e83dbb0c1sm71633805e9.14.2026.09.16.03.29.29 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 16 Sep 2026 03:29:30 -0700 (PDT) From: Abel Vesa Date: Wed, 16 Sep 2026 13:28:24 +0300 Subject: [PATCH 08/48] clk: qcom: dispcc-sm6115: Use common probe handling for always-on clocks Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20260916-clk-qcom-rework-legacy-always-on-clocks-v1-8-25a24e50f82a@oss.qualcomm.com> References: <20260916-clk-qcom-rework-legacy-always-on-clocks-v1-0-25a24e50f82a@oss.qualcomm.com> In-Reply-To: <20260916-clk-qcom-rework-legacy-always-on-clocks-v1-0-25a24e50f82a@oss.qualcomm.com> To: Bjorn Andersson , Abel Vesa , Stephen Boyd , Brian Masney , Jerome Brunet Cc: linux-arm-msm@vger.kernel.org, linux-clk@vger.kernel.org, linux-kernel@vger.kernel.org, Abel Vesa X-Mailer: b4 0.16-dev-0e65f X-Developer-Signature: v=1; a=openpgp-sha256; l=1674; i=abel.vesa@oss.qualcomm.com; h=from:subject:message-id; bh=9l1yH/TyKTh0nUOs+WYEyPBm3fUdzP6RQ05SEUY8blc=; b=owEBbQKS/ZANAwAKARtfRMkAlRVWAcsmYgBqqm9S6BRQIIkNxjkcRFfOiKoohORO+HWCy340Z uuKMPWV1WmJAjMEAAEKAB0WIQRO8+4RTnqPKsqn0bgbX0TJAJUVVgUCaqpvUgAKCRAbX0TJAJUV VkDHD/9Z93CpqY6+tb/srAdImnb6HGdyc7Mmd3tZeHaweH1AJ4fTOVwDX5NA7FrotdT/mTHpCe7 ZNNvPmkJW4T927L75GM4ShNmQV1CNEPaf8TxHRzj/h8UVrjAYA0DnE7W5GOuLU+ygqUZJkesB4V LFAHv+VqCWnEN93XFYIjJUQOiJMkF8YcqRmUa8j+Xx9pdXDdem6K1WARcIpl8utMIkHdykUAF9v u/rjpl/TAGW0KJ6c2vz54+onrdC92z9O5SFDPaHf74jhQnr7ncd9l7CEIv1OrK2YHqxn7Kj+PxE q1PFdnjtC82iOVd72clvFwZnt3bGKAd7J2jB/yEvN6UUzS7jlmcac9JUmADz2hJdzHsHg6huT3T 1SSUVj/mcCG/YNHFdHUTp7x07vxEQxAG/Bm5yqJmqT+hCbssn080rnL7impqM2jOC9rlEU5reb8 /MBOT3ECrmTdNNW1xlPdfBUxpnlKZ5VjjwSV3uadhhBJve3npcMCJzj4b3e7ntR98gQzT7kELka GkuH5hPrEBy+RSVxi/V/I95fsUJEY0/xEFgE2Nfgs3026HMGMaWWvwniTXmxTIb100uCyZ8hUd3 JsizQ5CQ8GaheRudJpq+gdkYfC3fp2QCDyR8+t+V88hlA5tQCceOYW7m8zBP5/y3adxer2DWuZp whrpvzGU/Lx6tpg== X-Developer-Key: i=abel.vesa@oss.qualcomm.com; a=openpgp; fpr=6AFF162D57F4223A8770EF5AF7BF214136F41FAE X-Authority-Analysis: v=2.4 cv=JYkpPkKV c=1 sm=1 tr=0 ts=6aaa6f8c cx=c_pps a=hnmNkyzTK/kJ09Xio7VxxA==:117 a=po8fGBi+ks8MzcVQGuqtFQ==:17 a=IkcTkHD0fZMA:10 a=VdqzKS8jKosA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=3WHJM1ZQz_JShphwDgj5:22 a=EUspDBNiAAAA:8 a=zyovT9EyBzSEY6lazxoA:9 a=QEXdDO2ut3YA:10 a=PEH46H7Ffwr30OY-TuGO:22 X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwOTE2MDEzNyBTYWx0ZWRfX4IuDalVTt5sN fZf5Oy+hlPW9/5dZZG5+qBK8/PCAX0Cqy5ZAB1E20jrh7RE8TCkbFyXKrc6/zSLDD2U/ZmXLLdp ogpKitBCdY8pwnqQPcljewIMEQoYWuxaPChYcZg9nHSnLkDrX0O41XD+gm9bsdGEZhsZmegp9N2 FT03VHohP/pHnkabEf2pd7AYwi9F0DFpe/j4/HcGUejDsFoNKBEq8VQLUvkS7VqaZ9kAC/+KS4u UKkhvFZ+Ruca9giI99+s2lFuA4XIIvR/yyM0yIoKvN5Xirc+dpwVFFgpgFTVdg1dqUqkTZHefui 9+/nmJ8ISQ9oA8xVd/vFbSnCAf1voD6im23GFOfQ9Bh9RvDXiiZPIIoJzpSVa5BZ4Jd6fMT8ZVb d9kHVpJPqk18cRaUXQECfvVc6HU6uNgz72x+wnkDo8EO00pgiEJ9ETBWbLcfUeePC/JRL906/5V 1Ng/b7Okplgfwx5qcVQ== X-Proofpoint-GUID: _AMkqd6KqN_MDRsMUaExXig5bMEkAEQW X-Proofpoint-ORIG-GUID: _AMkqd6KqN_MDRsMUaExXig5bMEkAEQW X-Proofpoint-Spam-Info: AW1haW4tMjYwOTE2MDEzNyBTYWx0ZWRfX+WizQ49Q/UzS CDKJA/K6rVy2P1WzPYD0RUVt18Q7gbVCxZcyJ2ZFctrtMgTNstz5iHumVAH/63vXF91NFPbh8Ds JcX8GOvzVGLZCvkMfO2GdB3ETt9plxE= X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1176,Hydra:6.1.134,FMLib:17.12.100.49 definitions=2026-09-15_05,2026-09-15_02,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 lowpriorityscore=0 phishscore=0 impostorscore=0 priorityscore=1501 spamscore=0 malwarescore=0 adultscore=0 clxscore=1015 bulkscore=0 suspectscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2609040000 definitions=main-2609160137 Describe the always-on branches in a critical_cbcrs array and reference it through qcom_cc_driver_data. Let qcom_cc_really_probe() enable these branches instead of programming them directly in the driver's probe. Assisted-by: LLM Signed-off-by: Abel Vesa Reviewed-by: Konrad Dybcio --- drivers/clk/qcom/dispcc-sm6115.c | 13 ++++++++++--- 1 file changed, 10 insertions(+), 3 deletions(-) diff --git a/drivers/clk/qcom/dispcc-sm6115.c b/drivers/clk/qcom/dispcc-sm6= 115.c index 9a7b8ad646ed..f6f5edf07f03 100644 --- a/drivers/clk/qcom/dispcc-sm6115.c +++ b/drivers/clk/qcom/dispcc-sm6115.c @@ -561,7 +561,17 @@ static const struct regmap_config disp_cc_sm6115_regma= p_config =3D { .fast_io =3D true, }; =20 +static const u32 disp_cc_sm6115_critical_cbcrs[] =3D { + 0x604c, /* DISP_CC_XO_CLK */ +}; + +static const struct qcom_cc_driver_data disp_cc_sm6115_driver_data =3D { + .clk_cbcrs =3D disp_cc_sm6115_critical_cbcrs, + .num_clk_cbcrs =3D ARRAY_SIZE(disp_cc_sm6115_critical_cbcrs), +}; + static const struct qcom_cc_desc disp_cc_sm6115_desc =3D { + .driver_data =3D &disp_cc_sm6115_driver_data, .config =3D &disp_cc_sm6115_regmap_config, .clks =3D disp_cc_sm6115_clocks, .num_clks =3D ARRAY_SIZE(disp_cc_sm6115_clocks), @@ -588,9 +598,6 @@ static int disp_cc_sm6115_probe(struct platform_device = *pdev) =20 clk_alpha_pll_configure(&disp_cc_pll0, regmap, &disp_cc_pll0_config); =20 - /* Keep some clocks always-on */ - qcom_branch_set_clk_en(regmap, 0x604c); /* DISP_CC_XO_CLK */ - ret =3D qcom_cc_really_probe(&pdev->dev, &disp_cc_sm6115_desc, regmap); if (ret) { dev_err(&pdev->dev, "Failed to register DISP CC clocks\n"); --=20 2.54.0 From nobody Fri Sep 25 05:31:34 2026 Received: from mx0b-0031df01.pphosted.com (mx0b-0031df01.pphosted.com [205.220.180.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 9DDFA4E80A0 for ; Wed, 16 Sep 2026 10:29:35 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.180.131 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1789554595; cv=none; b=TW+hw1xVGcdEk2ySAz9Mm7yBNq4jBILN4dIw7ThyMpgbrveYQn0AGwG+NC1rYvRtUXT/R2cYFItEbobv7ivSisqDhkCb2hD71EqzWguHtbaGMoWahShUQOC7/5oDQWUTCK3NS6gvyY5ybw8gKB4mnjCM3JPNoKxgGP7asyYXor4= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1789554595; c=relaxed/simple; bh=ypiCu47I4IEyPRo2zVhhtC5p2bQnKg6ynv1JvKvQ1gw=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=j46ge4PwTAMi2kVBP/ppOpR0+w4h1AKXgXJoMp393wY/T8VPywNmnqE30vRtvxU7+NXN32Gjj1fu5w332au2H533zF3T+i4ubApx2PYwT/R6riQJJJyYDb6Pa8eLyDA5bpPFnb+Z06wwSzzGR7iBOxo+Y7Q1SS/zC1trkua3j+Q= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=DOZbDpBP; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=IhieN8Df; arc=none smtp.client-ip=205.220.180.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="DOZbDpBP"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="IhieN8Df" Received: from pps.filterd (m0279871.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 68G92xex2822753 for ; Wed, 16 Sep 2026 10:29:34 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= zcnJqIehfozzPLFF0K4dR83d710JHr3Sb/hvkALSU+Y=; b=DOZbDpBPQtyKYM/1 5Cbpp/h5e+0Wmk3SAbM2xvZspF48eIDYA25iPS/AEzdkAYAGxj2Ul8cKcUjbQJ/o Aa4X9Mka05C/7ZxakOq9lGRhAKMeZBO8pfccHK87EXEVO7csZKqW3ilcd24Vgg1N 0gi8KsimCU8tI/B2Vkv1KFeco/FBcjW1eCN3pjmbFK6vicGYDnhhQNnXT10Ybhct jZyoMXW/qbG09vWZojzIVTUq6FLCugTkqisYjlnT9gkEJ+2Cc/SGtZcIwGAG9g86 blhia/7kefuMZ+CyuACSYQidv5JZ8y0/1eJOt3igFiGBQjpy/HdGhUHWRuPg3jqC fY5UIA== Received: from mail-qk1-f199.google.com (mail-qk1-f199.google.com [209.85.222.199]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4gqfvfjb8f-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Wed, 16 Sep 2026 10:29:34 +0000 (GMT) Received: by mail-qk1-f199.google.com with SMTP id af79cd13be357-936708f129aso834915285a.0 for ; Wed, 16 Sep 2026 03:29:34 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1789554574; x=1790159374; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :content-type:mime-version:subject:date:from:from:to:cc:subject:date :message-id:reply-to:content-type; bh=zcnJqIehfozzPLFF0K4dR83d710JHr3Sb/hvkALSU+Y=; b=IhieN8DfjWHN5Zy4uZLOAywzMLE7DYXx/NVnEeZyES11z/EYr9Ua0H04eLOm/uGvws YCOXLwSaAPjxTVI72RrPSlOa+eB+2p11o7sQ5MUR2oPzBkbiZRIpKKl2v2dDyyDMyy0S oBNX2cMCKlndVTpXR+utVAmcmv9tnTio7vQFao1wIzGHah8gQ2jmYMOz3VACI2tKqrA9 wBdoMNbOKDHbJ2TAfprYwoktBTsPcypCGP/ZKz6LRemqenY2B1aLZp7a9xZZDcGoPLr1 TuFcCNeyfmlPruSD2yBb7PY23v7BDglG1IYlYE9H+eWgEhJjqxNz40uY7O3lWLvahKEh BeBA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20260707; t=1789554574; x=1790159374; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :content-type:mime-version:subject:date:from:x-gm-gg :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to :content-type; bh=zcnJqIehfozzPLFF0K4dR83d710JHr3Sb/hvkALSU+Y=; b=LP/XDyoqvI4qJ3l1bfO/LZ6gZ4wEirMNzm6YNEJH0+jUW9pVJEbyLoE0UsH2Csa8qJ d7xZiHLC+6RtLcLnYudJ53CVykJPc6XgU/Ivn0BIpE9v+RkQYH20AxMtYETGrsgUORac xvzoOAMd93gsaIfj1b24T7aNStqlu24SJT1Pv4zA5oUGdYxzGR+IaQOg4tSxsSku2rkD dOiHFAdIzUY64NYzHAoOxVqiLqCv3ZEuywQQjyxgd+t12buA1gJUw0Es6lTvefNhdrS8 AlvphTljRsLkF3zkTuOm4yKSkHrv86yn02+yRp/qdIXtZlqY8lNF9eXlTQplX3UMOv9c K0yQ== X-Forwarded-Encrypted: i=1; AKwUvBxszJkC/x1E5nNzWvCj9i1ydkGiu8xREqalvTTBpgklYVvcC38zO1Rc1JD77L2cRSsFecTH4tQOE1DgEsM=@vger.kernel.org X-Gm-Message-State: AFuF++kTqYPRP7AaJ4rOZZnYusYe+DZvAfL8x1WaNFNNesUaKz3Bb5Aw 2CA5XzSY2r3YzItm5CvJevnNmHECYKOD8BcUbqFbPl+BAq0NpdCkMq3KC30Pa+KhBYPt34UPazk 7XvadJoaDvNa6ca4ebyZtYpiH/j1rJoN9R/6vvborx6YAy9fQQ9lsTk3sShTjUkfCtW4= X-Gm-Gg: AYBFou22P+b4eSSAz+8hRNRWjCDecSzadiK5PDvjcPtqC+f6ThhNMVM2sS4K6ErtNmT 7tn7WwI1O+IK308jnjhwLE8Bq59307m2eO11T9jSfCNA7BoBoVAOdiDdUTGamm8Y6zhrOoCm/Ll UgwciTH1qEWC9mH4nxZ4oJdQ8XUtzJ9xRgavoJws54z39dwlHoknp/W9iO1sdlMwcrzkgHK6fmY COF6etbTKlUAQzdIfl5ReP/XzVcatKXeKCu7ToRLBhuSEivfBhU7hbt9b3PMV9jAjGGf9Bdpj71 v60lGUcYbiObHAi05UuWdxq71YpUI1j2AwYzr1FaiI+McsQ8xuteNAy4nzItmnyZqbXBx1tSP0P pa0j1Eew= X-Received: by 2002:a05:620a:438e:b0:93a:13aa:1b6 with SMTP id af79cd13be357-93bb79aac6dmr330887985a.51.1789554573919; Wed, 16 Sep 2026 03:29:33 -0700 (PDT) X-Received: by 2002:a05:620a:438e:b0:93a:13aa:1b6 with SMTP id af79cd13be357-93bb79aac6dmr330883685a.51.1789554573411; Wed, 16 Sep 2026 03:29:33 -0700 (PDT) Received: from [127.0.1.1] ([86.121.170.232]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-49e83dbb0c1sm71633805e9.14.2026.09.16.03.29.31 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 16 Sep 2026 03:29:32 -0700 (PDT) From: Abel Vesa Date: Wed, 16 Sep 2026 13:28:25 +0300 Subject: [PATCH 09/48] clk: qcom: dispcc-sm7150: Use common probe handling for always-on clocks Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20260916-clk-qcom-rework-legacy-always-on-clocks-v1-9-25a24e50f82a@oss.qualcomm.com> References: <20260916-clk-qcom-rework-legacy-always-on-clocks-v1-0-25a24e50f82a@oss.qualcomm.com> In-Reply-To: <20260916-clk-qcom-rework-legacy-always-on-clocks-v1-0-25a24e50f82a@oss.qualcomm.com> To: Bjorn Andersson , Abel Vesa , Stephen Boyd , Brian Masney , Jerome Brunet Cc: linux-arm-msm@vger.kernel.org, linux-clk@vger.kernel.org, linux-kernel@vger.kernel.org, Abel Vesa X-Mailer: b4 0.16-dev-0e65f X-Developer-Signature: v=1; a=openpgp-sha256; l=1620; i=abel.vesa@oss.qualcomm.com; h=from:subject:message-id; bh=ypiCu47I4IEyPRo2zVhhtC5p2bQnKg6ynv1JvKvQ1gw=; b=owEBbQKS/ZANAwAKARtfRMkAlRVWAcsmYgBqqm9T+dOeYunGe9n2O6GSv40uxFl0RgFA92++G crYJo3GzC2JAjMEAAEKAB0WIQRO8+4RTnqPKsqn0bgbX0TJAJUVVgUCaqpvUwAKCRAbX0TJAJUV VniIEADGc1GuTU5f/6jIFVUDSinnIFolHL/2aJBLhrlt5AQgqrqnG1sctjZMkJg5BTabnTfBytK OiR1GNfEhOv3Wtr1Z3nBBdSaUaGJT+iBE02k/09FVSVDz3Q/Mmv3JlintZqgE90K0VsSbLHMChY SlaxOCNyhM94HifpDuI/pLfO2bzWR9n9N2Tqy2nuuoa2ry0jSbrwUsv1iGIVTVzQk8KiqB2e8h6 QIz/em9zCxIWSoVGCJjZPGUjgGy++2Ly0TCqfl3xXjF35VKNOjKimXstrcXv3nF0k8HKHhrxltN 2iD9k7wWAy4XDlYJCUsPfxNU25ODBmTw30ULZ/4t69ZzaMU4ROVCLsBfu7NVeG0mBqMihSURovl 7P87iavKv2YeM0RPlCq0MYgonoONJE7jesyh8U1JHkETK9CfVZCnP6oWOmrvsKiRBb/M6L/Urg/ 6HhoKZLiK2tE89u3wurzxE7hwmth1scxjDug7oxzcDGhZytE8BWEulQFPuXHoLz9pWIf39B4UnW ltS1aCETdR6M5Oppt39jxBDgCXvQGH2aKvUSfkpNmiTSeTjLr2Prndye2omOtboD5YX1vDdV8Lh yCFKVtR7cJjQQg9Nqn9bBoK2i26fDioNWx2luPt9swQj1OzaH7lZtAa2AnbokWO79lgSdvzgouc tckBs2vfJOZVYLw== X-Developer-Key: i=abel.vesa@oss.qualcomm.com; a=openpgp; fpr=6AFF162D57F4223A8770EF5AF7BF214136F41FAE X-Authority-Analysis: v=2.4 cv=JYkpPkKV c=1 sm=1 tr=0 ts=6aaa6f8e cx=c_pps a=HLyN3IcIa5EE8TELMZ618Q==:117 a=po8fGBi+ks8MzcVQGuqtFQ==:17 a=IkcTkHD0fZMA:10 a=VdqzKS8jKosA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=3WHJM1ZQz_JShphwDgj5:22 a=EUspDBNiAAAA:8 a=6fVa3aOakVPtjiFSkAIA:9 a=QEXdDO2ut3YA:10 a=bTQJ7kPSJx9SKPbeHEYW:22 X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwOTE2MDEzNyBTYWx0ZWRfXxtE/C3JhzfDs N8QieyCZB3ykhQTOMuAEPd7ed8/inNw46i7EWCmuSrI0ReMNxzsrfFSjfwjdSELMY4STG71dqJb jmEFoYS29/lycUDsotGq4hVp1/gjtdvKrepcB5YvW/w00l0LZQuHPcL5f86k+yFGHuzrx2zGpDY lYdMaf693rTDXZ7gYVcE4rZsojh4lIdCNZY3ANFKH7/DGiCOTO+NBWLc8zBeElRPKDyrKLd+B1f VcuXzdoC7EMGKLA+vJNA+dtWFQ29/oGmoz3cNpOc4OzHaz0daLyxV4BE3qus0swlmkzbxhIM7co l1IusXj3lym4K66YTh5efoav4AnnWBmKgFcmPMWtHXkiCQ8juEjo/AfURFxp/xgBGmfd5PeZfm8 AUIvCXjJ16jPIGWGH3tzPxbmCsVARvH/uWLwplHh4FCLDh2UUJruomOwZwPTdOHqboGq+x1DtjX 5yX8+Gi06Bry+iOlwvQ== X-Proofpoint-GUID: BM_JmRWngO1pq-rsbEJjNRJsWmFzhJDQ X-Proofpoint-ORIG-GUID: BM_JmRWngO1pq-rsbEJjNRJsWmFzhJDQ X-Proofpoint-Spam-Info: AW1haW4tMjYwOTE2MDEzNyBTYWx0ZWRfX+4Q4b2kiKF0q v6mByhEGo6TSyJKeWauIbAHm6JBLJK11HzP2dg2YyU1mK/bX3WNaMvDOQjUF3UE1eXeuPdtSM/C hKXAOxIpi3pzI53A6r/zZ403Z84VPDI= X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1176,Hydra:6.1.134,FMLib:17.12.100.49 definitions=2026-09-15_05,2026-09-15_02,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 lowpriorityscore=0 phishscore=0 impostorscore=0 priorityscore=1501 spamscore=0 malwarescore=0 adultscore=0 clxscore=1015 bulkscore=0 suspectscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2609040000 definitions=main-2609160137 Describe the always-on branches in a critical_cbcrs array and reference it through qcom_cc_driver_data. Let qcom_cc_really_probe() enable these branches instead of programming them directly in the driver's probe. Assisted-by: LLM Signed-off-by: Abel Vesa Reviewed-by: Konrad Dybcio --- drivers/clk/qcom/dispcc-sm7150.c | 13 ++++++++++--- 1 file changed, 10 insertions(+), 3 deletions(-) diff --git a/drivers/clk/qcom/dispcc-sm7150.c b/drivers/clk/qcom/dispcc-sm7= 150.c index b9df6153e50f..da7610856e56 100644 --- a/drivers/clk/qcom/dispcc-sm7150.c +++ b/drivers/clk/qcom/dispcc-sm7150.c @@ -963,7 +963,17 @@ static const struct regmap_config dispcc_sm7150_regmap= _config =3D { .fast_io =3D true, }; =20 +static const u32 dispcc_sm7150_critical_cbcrs[] =3D { + 0x605c, /* DISPCC_XO_CLK */ +}; + +static const struct qcom_cc_driver_data dispcc_sm7150_driver_data =3D { + .clk_cbcrs =3D dispcc_sm7150_critical_cbcrs, + .num_clk_cbcrs =3D ARRAY_SIZE(dispcc_sm7150_critical_cbcrs), +}; + static const struct qcom_cc_desc dispcc_sm7150_desc =3D { + .driver_data =3D &dispcc_sm7150_driver_data, .config =3D &dispcc_sm7150_regmap_config, .clks =3D dispcc_sm7150_clocks, .num_clks =3D ARRAY_SIZE(dispcc_sm7150_clocks), @@ -991,9 +1001,6 @@ static int dispcc_sm7150_probe(struct platform_device = *pdev) /* Enable clock gating for DSI and MDP clocks */ regmap_update_bits(regmap, 0x8000, 0x7f0, 0x7f0); =20 - /* Keep some clocks always-on */ - qcom_branch_set_clk_en(regmap, 0x605c); /* DISPCC_XO_CLK */ - return qcom_cc_really_probe(&pdev->dev, &dispcc_sm7150_desc, regmap); } =20 --=20 2.54.0 From nobody Fri Sep 25 05:31:34 2026 Received: from mx0b-0031df01.pphosted.com (mx0b-0031df01.pphosted.com [205.220.180.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 30B0A4E80CA for ; Wed, 16 Sep 2026 10:29:40 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.180.131 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1789554604; cv=none; b=dHxz9GSrBZlLBFSFIe9fDGmZmsiH2i3nc6O6l7Q1hdFQWkfoU6Ub/iMKKXlb9z03MMO3no3kPVi7NjHMlpclIJx4+EKjepflSXuT11NMHRnXpqT3BJlQlPXouFVMeiTFYmPtnsWTvv1HPVfjFJGNhJz4mD9hUnDhtQB6Op825No= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1789554604; c=relaxed/simple; bh=Zp5PDIm9VF8FmIcIyh/M1Vz68QOUnZO8wJa5myNtLsU=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=N87noDRuk96oz1ZGW3yfMF+EW7zQ+/SdudaOCu647uZbYwoR+UXM+QEyEpWViZxT2Lb7rOb+jo3utAiYsNcrEkXc+zFtMSBoJ39HncJFlUGkkF0bXP6Qv+lPpCE4C2L39F1FYxjVzNPODa0gZUpS1bK2XndWRtM5En0n9Siuu8k= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=c4ENCbRI; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=jtCaky32; arc=none smtp.client-ip=205.220.180.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="c4ENCbRI"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="jtCaky32" Received: from pps.filterd (m0279871.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 68G92xf22822753 for ; Wed, 16 Sep 2026 10:29:36 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= bRmelSw6+kdXBYDg5OpUqhIvT/5ocQAO5ePZLRWdL6E=; b=c4ENCbRIqFNjITsZ jFJKY25LMT78V00GKKjnhb5t34mGE9aMOopVBRmynxN8/MIXS93XeZpOYbJMlkuy p9JvFiKATqTNMBNm2wxxM3gaqxUbOeHGrmE62CO5khSirjfPmu5ZqpUt4TWhbX0v NL275pPk1bwMws8BtUbqwNyNwKk4JZ2bSwy6vW1xAU6ib+ToRd/Bb1TpWpMDoLWz +VQPHi9HJc5mlhptzdXbf/Zs0EwQ4KPkgVx3sgw9aKAOrYoTCi6Y49g2yMjD9v0G Uog4MmQzhVPj9pFUa9xeM44JG1AC/BqMzcjVbMLA9S9VdQac4TnQEyBbMpftWGVW 0CMovg== Received: from mail-qk1-f197.google.com (mail-qk1-f197.google.com [209.85.222.197]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4gqfvfjb8n-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Wed, 16 Sep 2026 10:29:36 +0000 (GMT) Received: by mail-qk1-f197.google.com with SMTP id af79cd13be357-93a0050a554so1095072385a.1 for ; Wed, 16 Sep 2026 03:29:36 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1789554576; x=1790159376; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :content-type:mime-version:subject:date:from:from:to:cc:subject:date :message-id:reply-to:content-type; bh=bRmelSw6+kdXBYDg5OpUqhIvT/5ocQAO5ePZLRWdL6E=; b=jtCaky3276f4f5wrmupB2HtR1yvXDX1SFb2S9OG1t8O5DBKgz2ne3gJ2PzktI2DFlT JgI5qAoZO/PkYaBWrLXqWnUhuT6roiazyd5YiSvgWyXdiEpa1CnuyeHxSzu+y61ZUO+3 f4OTI+BsLhcdTpTU8U9TYHIKx40qYl9GN77/cz9iCEq2K+Zh0UNlyIApVhtIgpOM0QOC nb90D3m08y49GcTZ1w8A2jCEXDXseWU4ErLIe5BKS5KMiba8RaqdwtPBqWpZg0B93HmN 12w8uJN1uIqnfdY9433Q9MmrSAnMWMRvHreavogBg55Du8OQsk1Nq5fjUgZ08oAEgbqb ZMuQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20260707; t=1789554576; x=1790159376; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :content-type:mime-version:subject:date:from:x-gm-gg :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to :content-type; bh=bRmelSw6+kdXBYDg5OpUqhIvT/5ocQAO5ePZLRWdL6E=; b=zuhwXKC8EFVC611ntqPh5TxBTFjmFtXRoWG23WFBwvVpPs8PyKWuP+Ip1CwfJ1xS5M +4SRnBb4n8mREY+ArhMib1zbmuRBTs1ayc21fG7TCIhaih/pIA0WypZGcunhxsp6IHDK sqrSMs7bAOf62LJxWMMNMFosC2bEmW2QySq4JV+vS2UJLbtj6pjf21E5tZwF23D1WM8R ABSnQvc7l0vR4uFEU4oHONd1ZnE58E3TeNJdIpklhbxsDWtz3SjytIyHq8r8yJ7te2m3 /g3jwCVKKfzUDL0VcopalRPaPIk+LqwsAEvruBuCCvvD4pRD8L8nyi/0PAfy968qjKM6 h6HQ== X-Forwarded-Encrypted: i=1; AKwUvBzMQeI/aIkw7gsQ6oSc0EmKxuLVdzuHGfY/SJ+TjBNrGFM3cfu/IWy8ISrSxh919tVdCwqPuIJCZAsfqHY=@vger.kernel.org X-Gm-Message-State: AFuF++kP4NmfPtiCDg9femQ/x+PXFFeIbQsX8xtgJCISIlLMjDjoIVa3 m3QpE6rzwRRSvHGdpIujLfrjIvKSxI6NPuC1GnPLoTc2oQD8w6SRDle4letgQk47+7Mu9ttp/LZ mPDsH+Z2I5+hdJeDyf/axo/qgFHyoAOzIMVrR4cW4EujKdLwVicdfY8Q+y+Zkz+15yqY= X-Gm-Gg: AYBFou2vOIU+egSpIyuX0YBT0Mz/BIA+g/DuRrLwthdsGN834HDJj59ueOdSHNqZbw/ lcLKjaI/dpTGU4LyJxQYvyMNx8zvhjUm05pPi2M0qbj5m+HW1F30AVEJ1ThaGvZH9j4pilo0kHf Iy/ynTCzmWKJf4WcRBnJ84yAUKlFWZ+GezHUoi2s49ALG1hyNpT5oCjBvHAhTUYO9jPBmU1zw1q s+A2E6yfQJAbbl1CkDYgy9PtWy1H/O+kYsT3kve9zZM08HOYTlCV9kYjkDaHojmoMdwSgyPAclt 1WzzTXlo0KcTn0pECnYcTAFY/zO2TcHBeqkehiUU9ByBRiyEBMbXJGniS7ZTfTq6u8XL/fa5G8G K44C3iwM= X-Received: by 2002:a05:620a:2b9c:b0:939:6dea:ce78 with SMTP id af79cd13be357-93bb796a45amr311659085a.46.1789554575732; Wed, 16 Sep 2026 03:29:35 -0700 (PDT) X-Received: by 2002:a05:620a:2b9c:b0:939:6dea:ce78 with SMTP id af79cd13be357-93bb796a45amr311654785a.46.1789554575253; Wed, 16 Sep 2026 03:29:35 -0700 (PDT) Received: from [127.0.1.1] ([86.121.170.232]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-49e83dbb0c1sm71633805e9.14.2026.09.16.03.29.33 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 16 Sep 2026 03:29:34 -0700 (PDT) From: Abel Vesa Date: Wed, 16 Sep 2026 13:28:26 +0300 Subject: [PATCH 10/48] clk: qcom: dispcc-sm8250: Use common probe handling for always-on clocks Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20260916-clk-qcom-rework-legacy-always-on-clocks-v1-10-25a24e50f82a@oss.qualcomm.com> References: <20260916-clk-qcom-rework-legacy-always-on-clocks-v1-0-25a24e50f82a@oss.qualcomm.com> In-Reply-To: <20260916-clk-qcom-rework-legacy-always-on-clocks-v1-0-25a24e50f82a@oss.qualcomm.com> To: Bjorn Andersson , Abel Vesa , Stephen Boyd , Brian Masney , Jerome Brunet Cc: linux-arm-msm@vger.kernel.org, linux-clk@vger.kernel.org, linux-kernel@vger.kernel.org, Abel Vesa X-Mailer: b4 0.16-dev-0e65f X-Developer-Signature: v=1; a=openpgp-sha256; l=1653; i=abel.vesa@oss.qualcomm.com; h=from:subject:message-id; bh=Zp5PDIm9VF8FmIcIyh/M1Vz68QOUnZO8wJa5myNtLsU=; b=owEBbQKS/ZANAwAKARtfRMkAlRVWAcsmYgBqqm9UgR8qNCDYipELjq/6MW2yZK+H/36V30V3G aSl2kivwnuJAjMEAAEKAB0WIQRO8+4RTnqPKsqn0bgbX0TJAJUVVgUCaqpvVAAKCRAbX0TJAJUV VuSzD/9t9B27rQeT2YcM8D6AsKHysbW7DRWKhaGseiPsS49g8/YJgZXnyowzvM6qJBRNEr2qvD9 93v9pPHmbrY8czLzhduPxblsSTHmTJBNA0ZRvfOZnOxTrL1yHwbAyDUVD45oJjVIkTF54zMAgXH E1oCjpRGLmvZloYwPv0+8wn6rC91mHI7C0XiRksh0es5Kp5C5+kfiM7AJksw6EeGWLvkAc9nXBe Qf3D/OK4ajSCTVgAzbwolseGIgxwsTsCcQIx73W22gS23gf3Tb+OV05wNBM/rdmAfLNS8cJT1mz ts79SExyFRXjrYb7qzDRKFUOeSiPg4eB03vgyn397Izb3FikRZTlrIIJMhA17uSOIHdgOkg6hQi 9XZT5BzxJ5dXddyEYA5WiH+q2LzwTYIi+Qj8muhKzeLsZhBz6xIczLq4n19DJrVeaiigIFWj/iX C128KuxdShcjOBlQMgM/trNhUM7h0e5qLUJlTA7GZWpI5UrzJQBMImk2JOGzXESjK4XaIIl7ynt c0cOUCXKTSwjL58j6O5wteATA7egk2sfiZUloVYshYmJumuAPrB3nRYvWihazboKOrGXUI7KSZo NJ+bDeDG3cSEM8Egi2MiQ/VFuq2uUZpwlfAdw2xDBI5fqRzEXAWsWIcsIX6xOpm923Nen4Bs0Aq MmcWQsExh1tocCA== X-Developer-Key: i=abel.vesa@oss.qualcomm.com; a=openpgp; fpr=6AFF162D57F4223A8770EF5AF7BF214136F41FAE X-Authority-Analysis: v=2.4 cv=JYkpPkKV c=1 sm=1 tr=0 ts=6aaa6f90 cx=c_pps a=50t2pK5VMbmlHzFWWp8p/g==:117 a=po8fGBi+ks8MzcVQGuqtFQ==:17 a=IkcTkHD0fZMA:10 a=VdqzKS8jKosA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=3WHJM1ZQz_JShphwDgj5:22 a=EUspDBNiAAAA:8 a=6NcTdUUM2wu3ikSZIO0A:9 a=QEXdDO2ut3YA:10 a=IoWCM6iH3mJn3m4BftBB:22 X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwOTE2MDEzNyBTYWx0ZWRfXzIr2A4bSAWOF mmF9XhYUl3Yd9mjgBjoqjLyeg1uIftOMO5xzinl8ruCNs/59ktEIzUlyC1DaPDhwHjsJfSLJrFZ 8j9Jeek97AiNm4cpA4XDPcY9HD6kOuCbPrzS1bmWyutiitdy62HMkX/gacIY5zx4UyxE/bHo+vt wMXhMxkuRvccXcX0QJMmasz+68eOdY72/DstzgazPmoHpEtZ1msYEiRJeGwXn7wCmmRUeNNhtQ9 lKbTr3t1ngFhec6/F44JZ24NxLIaza1ve7XThspmg8lJoIiUZ/2t2m2ivx/0goCRf3U8bLYJPAf 8yfd22DlGCgtpRggJut2FLwwEpF3BEPa+g5leHb5TfvCvrPb6ecuzoaAbFonV0f11LKa2iHttoG JYi6nVsQlZQysAbkFSi3r+w8s3M9dP2PXrcP3Xga2x5wlzw//FBmnYG7Qk78XmZf8+AMZEKJMoF 2e2ous7COjx+d361pLA== X-Proofpoint-GUID: M7dvdKWKbUy321s-SHEB0N6w0mr8vexg X-Proofpoint-ORIG-GUID: M7dvdKWKbUy321s-SHEB0N6w0mr8vexg X-Proofpoint-Spam-Info: AW1haW4tMjYwOTE2MDEzNyBTYWx0ZWRfX1ClhP3WBGib/ 1rM95apjVlNdxb+8jH1utrIlSphjZPAu6xzw8/6PFLbfOsp9brbO72JCDOO2si9Iz3hxIYWiLqa UXTHX3dMEQBX+jnMvmyUbrEpTqAWgQU= X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1176,Hydra:6.1.134,FMLib:17.12.100.49 definitions=2026-09-15_05,2026-09-15_02,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 lowpriorityscore=0 phishscore=0 impostorscore=0 priorityscore=1501 spamscore=0 malwarescore=0 adultscore=0 clxscore=1015 bulkscore=0 suspectscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2609040000 definitions=main-2609160137 Describe the always-on branches in a critical_cbcrs array and reference it through qcom_cc_driver_data. Let qcom_cc_really_probe() enable these branches instead of programming them directly in the driver's probe. Assisted-by: LLM Signed-off-by: Abel Vesa Reviewed-by: Konrad Dybcio --- drivers/clk/qcom/dispcc-sm8250.c | 13 ++++++++++--- 1 file changed, 10 insertions(+), 3 deletions(-) diff --git a/drivers/clk/qcom/dispcc-sm8250.c b/drivers/clk/qcom/dispcc-sm8= 250.c index fdc07323f298..dc62eb18deed 100644 --- a/drivers/clk/qcom/dispcc-sm8250.c +++ b/drivers/clk/qcom/dispcc-sm8250.c @@ -1232,7 +1232,17 @@ static const struct regmap_config disp_cc_sm8250_reg= map_config =3D { .fast_io =3D true, }; =20 +static const u32 disp_cc_sm8250_critical_cbcrs[] =3D { + 0x605c, /* DISP_CC_XO_CLK */ +}; + +static const struct qcom_cc_driver_data disp_cc_sm8250_driver_data =3D { + .clk_cbcrs =3D disp_cc_sm8250_critical_cbcrs, + .num_clk_cbcrs =3D ARRAY_SIZE(disp_cc_sm8250_critical_cbcrs), +}; + static const struct qcom_cc_desc disp_cc_sm8250_desc =3D { + .driver_data =3D &disp_cc_sm8250_driver_data, .config =3D &disp_cc_sm8250_regmap_config, .clks =3D disp_cc_sm8250_clocks, .num_clks =3D ARRAY_SIZE(disp_cc_sm8250_clocks), @@ -1370,9 +1380,6 @@ static int disp_cc_sm8250_probe(struct platform_devic= e *pdev) /* Enable clock gating for MDP clocks */ regmap_update_bits(regmap, 0x8000, 0x10, 0x10); =20 - /* Keep some clocks always-on */ - qcom_branch_set_clk_en(regmap, 0x605c); /* DISP_CC_XO_CLK */ - ret =3D qcom_cc_really_probe(&pdev->dev, &disp_cc_sm8250_desc, regmap); =20 pm_runtime_put(&pdev->dev); --=20 2.54.0 From nobody Fri Sep 25 05:31:34 2026 Received: from mx0b-0031df01.pphosted.com (mx0b-0031df01.pphosted.com [205.220.180.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 6E3B84E80D6 for ; Wed, 16 Sep 2026 10:29:40 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.180.131 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1789554585; cv=none; b=VXH/8O3dFE5l66WkImFIDvvMLe0iKfXBklCUufB7GxIh3fV54gB5KoJwep+APJ4Lot3opxNUl2oO4g93IeWK799DqllN/pKN5h8Ym5tfRXd2BeWzFhSrT204ANUzncQMyNo7YXEudfhNG9WgDQ8ufuzVM9A9/KoQ9agHvh9B/R8= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1789554585; c=relaxed/simple; bh=ddZpgrzvUbp1cuqzE7ilVSHV1084ZKP/Bw/rTPEw8vQ=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=q4bDa/0pLetC/GhIuueaUFtQ5NNi/Yr1GNnw3etIyw7x6RoOl58THHyWkG+cXDMd9RMadDXQVbo1e3WvOtplJqX1ScZ2Bw/xQExHU87nECBVuF2sjUB3uj+HJZUE5BqxnGQgC4DSiB8SqmqlFQrmPqd5SSbswkAn62pdfF5RSkw= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=GX0WYhW2; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=M3hVIdxr; arc=none smtp.client-ip=205.220.180.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="GX0WYhW2"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="M3hVIdxr" Received: from pps.filterd (m0279869.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 68G93C2Q2658365 for ; Wed, 16 Sep 2026 10:29:38 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= HsDN1TqVi6UMpuxEeMHRkj9cz52RGQHzM/5Tefv2JKE=; b=GX0WYhW2fprXUjrf fk7EjX63rRVrd5+rxYmhZ1jYHhUifWs7iZNMRzMYoazODzP9/Fafqi3YaZmORGdQ tlTcGMQLTxJUzrKKWG1kAqUg2H1A1bBYnouElNG2fIK5Hu9svJQHu5hQxt/1D/Uu lYg7TafIZ3KV509UEnq8VPAXjcnvHZfGmOBGrmudN/n9eXDrQrqYvf3yXusm1KJS gJsnSaCpX16xnSNtjCjsF+wu5Fend1M7s1KLeDHkohR2j+lLiQw22jNG1aM1Fi7j k+4kFGZDpsCS8avk1fDJtXxF+ZsMS2tQLi8VSbG0KwBVaF4pmfc48fGaLjWaktaf 8W/OVQ== Received: from mail-qk1-f198.google.com (mail-qk1-f198.google.com [209.85.222.198]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4gqftujanw-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Wed, 16 Sep 2026 10:29:38 +0000 (GMT) Received: by mail-qk1-f198.google.com with SMTP id af79cd13be357-93a1e564fd5so509388585a.1 for ; Wed, 16 Sep 2026 03:29:38 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1789554578; x=1790159378; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :content-type:mime-version:subject:date:from:from:to:cc:subject:date :message-id:reply-to:content-type; bh=HsDN1TqVi6UMpuxEeMHRkj9cz52RGQHzM/5Tefv2JKE=; b=M3hVIdxrS/26FFGYD6QN2/kKb+126YpaapGXTeQbqqjrQG46OtebjvLSHleXYVTK0b D5X0XtdsUgGmQFPp4Iov7pmIM9DH8tdBvDCbt0aPRx4eQtnC1ZmLw7mQsxg916pJCkKT w3XN/Nj0RnDHgZeMXOWeyufhDmLbqv7BGbuQMTUXGpmwlF8u4UfYGNGlMoGi2D9Uhs8/ asMwbKbz4xbrxla5yyUZp9co4jRYhb0kI07f8xUD2F9woh5wc6Jd/o59XN9EsTCjkCQU LAf0puW780Te4Xm3eDmgPVVoS9Xat8n470525TO4QWoLPUZAnItcu9Hx0EIGez9LQCuH 8Hfw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20260707; t=1789554578; x=1790159378; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :content-type:mime-version:subject:date:from:x-gm-gg :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to :content-type; bh=HsDN1TqVi6UMpuxEeMHRkj9cz52RGQHzM/5Tefv2JKE=; b=nMC4comP7bXpcJ8veu0XovFrAQP5/huRwUtHsxwsPpVRGMr2VQClplO7PKWYZod2uA /aInQvcYKMubHxuZFQSH8O0yD6Not3wPX8Z7xg2SRSnCeBTOH+WcBrW2OiTn38zlPxaQ 6up3WMQQ3HAp5lzi8W7rHKEBEo39BuwwDj76334qF1hhNNTHcDLHn89ET0SgIcBzkDRv Oa0B1nGpq29tfdGG59nQDM8rbIhIHckzeDcKLz7nUB9ajtQWAWc38QFcMSIMEvWcQjBA hvmonC91rV19niFI4auff18y3FpzxsYIfR8iKiIv3QMmga8vPh4jk5UqZCOYKRYmv4O6 72hQ== X-Forwarded-Encrypted: i=1; AKwUvBypFaPNdsuXurVGlU0TMGnlHh1CQk5s+wEtskk1KONLwYdAFZzY2ZyixLMiraYTl7b4XiooE96O3hhzIkE=@vger.kernel.org X-Gm-Message-State: AFuF++mPvf3VexruEfgtvkVBAzhx6k5h7LD4+ob7uWtDIAqbZ8ju8Hk9 e30cjar7nTn7tg5C9y31G6CsDTIUDTlgRBPz09xu2vFajFqgLg8jRI69CpujG5/YJARobAD4Zy9 f6E9bARWYEvOxIIZVIjdOXdbCRcYf7MrCnFaqqTiSnV+z1/KVLQVVN/qVzBbjw7eGSmI= X-Gm-Gg: AYBFou0k0/48nuVYeOqHKO7uy8vZ4zKxdD84CwfdvRWl52VKhNgZ0bWtSShGlG0dzQD Zd54sXOvQ7OMGXQWyX019tFjgb1SNGwbeOax7M6NL1GooFvK6bez910RXQHCV9X1LnWZSBunJGy MAhPZjryU9Ey0pS7Blqkn5evdqu/p+rX7CIVkFHUWv2PG8mwKDS3fPZT75XANiqN+sIpagb+cjc kwst/boHrFaecafJ+e0rDEMBPrMfgUhwhCgdIOgTToeCNxWtQesn4hBXtY4cY7+FAMWhsSPCcua Nvuxe88Kng+QNP2GsDO/DY1dnEqYvaO/cELJLDhffy1YrT+Ix4M4RnNRV3SXGxIAk4FEG+oO/oL F+fSl2nc= X-Received: by 2002:a05:620a:890e:b0:939:896f:3d8f with SMTP id af79cd13be357-93bb78f9fd9mr264925885a.33.1789554577921; Wed, 16 Sep 2026 03:29:37 -0700 (PDT) X-Received: by 2002:a05:620a:890e:b0:939:896f:3d8f with SMTP id af79cd13be357-93bb78f9fd9mr264921885a.33.1789554577378; Wed, 16 Sep 2026 03:29:37 -0700 (PDT) Received: from [127.0.1.1] ([86.121.170.232]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-49e83dbb0c1sm71633805e9.14.2026.09.16.03.29.35 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 16 Sep 2026 03:29:36 -0700 (PDT) From: Abel Vesa Date: Wed, 16 Sep 2026 13:28:27 +0300 Subject: [PATCH 11/48] clk: qcom: dispcc-sm8550: Use common probe handling for always-on clocks Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20260916-clk-qcom-rework-legacy-always-on-clocks-v1-11-25a24e50f82a@oss.qualcomm.com> References: <20260916-clk-qcom-rework-legacy-always-on-clocks-v1-0-25a24e50f82a@oss.qualcomm.com> In-Reply-To: <20260916-clk-qcom-rework-legacy-always-on-clocks-v1-0-25a24e50f82a@oss.qualcomm.com> To: Bjorn Andersson , Abel Vesa , Stephen Boyd , Brian Masney , Jerome Brunet Cc: linux-arm-msm@vger.kernel.org, linux-clk@vger.kernel.org, linux-kernel@vger.kernel.org, Abel Vesa X-Mailer: b4 0.16-dev-0e65f X-Developer-Signature: v=1; a=openpgp-sha256; l=1663; i=abel.vesa@oss.qualcomm.com; h=from:subject:message-id; bh=ddZpgrzvUbp1cuqzE7ilVSHV1084ZKP/Bw/rTPEw8vQ=; b=owEBbQKS/ZANAwAKARtfRMkAlRVWAcsmYgBqqm9VsHE2iOCeEH1t3v4N4BWahVojli8fQWsio 8KCn4HhNESJAjMEAAEKAB0WIQRO8+4RTnqPKsqn0bgbX0TJAJUVVgUCaqpvVQAKCRAbX0TJAJUV Vo2KD/4opYoOYXrtFt/U8c88WiXbuwXm4Dxg7e5yrr8auaBFmrWWJYlFbfbOT2RKc27bU5IZzWB CSnkW2iAgXEYCeBD50ko8M8zDOEQFluHJZshQgO7boPAoHSEApz2SlzZy6nBVc3AGDf3m1LxZ0u mVEr1bmiUcFUPmol7nRdKXhyc+jeZZVjAVpwlwLIVIJE8Wx0AjJgnwoyWqqfuKw1+DCJtR39o8E xBVQ5XcSslEpWaANfCeSZ+GSLZfCkwKHv5sT5KurlD2E/1+b7rZ8bqS6fBE5LH+8ayrywhjE8kC +XkgPgJ0Xa9qsTshkyXLQhAjOtACakvRDnT5paSlu5hApTINp1N/hvngfNQCp/1A1uZGKvrY6m8 n1GXyrbiXdtapzTqo6pgK5An46uY1O1CGbJfEjcy9uAEzvwhZQJJlIbRNdh3faaRq7zmh8cO2vr FdkNWgl65//YkydZjuomy24jm/aFxbR05qwC78RW+agCMXdt0HtxH13gDVmoobiodXN4V4xecg2 MqjLHvN4Xkpoi6xfwZE86DMhgAkbQPStq0r4/Fd0B3BiVFKp6+nsgSCQx/KrSjAKIjhfKxGUoqR jQni9QgJDmZOxATdzqIAk9WoopDPaqSg0wzg18cwOw+5VgmcPp1sWXhu1ITmXNThM65ppynvo3J jz+HrplNs1EaKqA== X-Developer-Key: i=abel.vesa@oss.qualcomm.com; a=openpgp; fpr=6AFF162D57F4223A8770EF5AF7BF214136F41FAE X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwOTE2MDEzNyBTYWx0ZWRfXzRwOKK+FKyjR QH2z1j3N7KB4JUP303RqMXrsKhqH7OV09U0IoL7xSKqpzl2DZCPr7cQse2LQYbfQxdQ4UUnGpvk HCP+BJE93IuK8q16raalsQUN5BdSK6mOoSDIHZFkEPorWQ3TW2E5iKz9F4e9yG8CJpitaYRXXTu wW983TETOAz5f2UHhFBrxufkQwR+v8sp37QtXhYuKWaBI/hkEeNKVLoPObAcAZAU6IDzKw0Sazq nMj/0pVxox+j4UYHsOVicNcjOsKCu4e8qS5EtsZucW5J9XGjZW3a000zSRAPvUKJfOm7A26iGp7 sdVGFy8mHK+XA4niZ5XPP5qEDRwJe9C6NySE+5IQz2MjlD/S56NxIr1Y/CrfLuN3TDWasob9tbG JgmIxmZbQkmPv69BYmvkyeLX+GIY61cUgeqos2hrhUiL8ewemfswfUJB9dy81hlaTgmaA3zvxvS LxRnoGUaqZX8FnSm0Ew== X-Authority-Analysis: v=2.4 cv=a5ulZkSF c=1 sm=1 tr=0 ts=6aaa6f92 cx=c_pps a=qKBjSQ1v91RyAK45QCPf5w==:117 a=po8fGBi+ks8MzcVQGuqtFQ==:17 a=IkcTkHD0fZMA:10 a=VdqzKS8jKosA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=_glEPmIy2e8OvE2BGh3C:22 a=EUspDBNiAAAA:8 a=Mkos_PfpLiWYs3bmBbQA:9 a=QEXdDO2ut3YA:10 a=NFOGd7dJGGMPyQGDc5-O:22 X-Proofpoint-Spam-Info: AW1haW4tMjYwOTE2MDEzNyBTYWx0ZWRfXw920Y95RdUQX kBAl1LlB2bq53RKeF8JZcHVvkwWyFnXorEsZnbwKzlyqgzDIVOzFKxWS9bIdwNEo20Dhhly48w4 JZZxB2I73olmijg3TmtX9UGILWWDl18= X-Proofpoint-GUID: U8qT3_wQSomlG9xjHmhmO0M157Y71Gi5 X-Proofpoint-ORIG-GUID: U8qT3_wQSomlG9xjHmhmO0M157Y71Gi5 X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1176,Hydra:6.1.134,FMLib:17.12.100.49 definitions=2026-09-15_05,2026-09-15_02,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 suspectscore=0 spamscore=0 clxscore=1015 priorityscore=1501 adultscore=0 impostorscore=0 malwarescore=0 lowpriorityscore=0 phishscore=0 bulkscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2609040000 definitions=main-2609160137 Describe the always-on branches in a critical_cbcrs array and reference it through qcom_cc_driver_data. Let qcom_cc_really_probe() enable these branches instead of programming them directly in the driver's probe. Assisted-by: LLM Signed-off-by: Abel Vesa Reviewed-by: Konrad Dybcio --- drivers/clk/qcom/dispcc-sm8550.c | 13 ++++++++++--- 1 file changed, 10 insertions(+), 3 deletions(-) diff --git a/drivers/clk/qcom/dispcc-sm8550.c b/drivers/clk/qcom/dispcc-sm8= 550.c index 418dcea20f00..030fc7ef1fbf 100644 --- a/drivers/clk/qcom/dispcc-sm8550.c +++ b/drivers/clk/qcom/dispcc-sm8550.c @@ -1744,7 +1744,17 @@ static const struct regmap_config disp_cc_sm8550_reg= map_config =3D { .fast_io =3D true, }; =20 +static const u32 disp_cc_sm8550_critical_cbcrs[] =3D { + 0xe054, /* DISP_CC_XO_CLK */ +}; + +static const struct qcom_cc_driver_data disp_cc_sm8550_driver_data =3D { + .clk_cbcrs =3D disp_cc_sm8550_critical_cbcrs, + .num_clk_cbcrs =3D ARRAY_SIZE(disp_cc_sm8550_critical_cbcrs), +}; + static const struct qcom_cc_desc disp_cc_sm8550_desc =3D { + .driver_data =3D &disp_cc_sm8550_driver_data, .config =3D &disp_cc_sm8550_regmap_config, .clks =3D disp_cc_sm8550_clocks, .num_clks =3D ARRAY_SIZE(disp_cc_sm8550_clocks), @@ -1800,9 +1810,6 @@ static int disp_cc_sm8550_probe(struct platform_devic= e *pdev) /* Enable clock gating for MDP clocks */ regmap_update_bits(regmap, DISP_CC_MISC_CMD, 0x10, 0x10); =20 - /* Keep some clocks always-on */ - qcom_branch_set_clk_en(regmap, 0xe054); /* DISP_CC_XO_CLK */ - ret =3D qcom_cc_really_probe(&pdev->dev, &disp_cc_sm8550_desc, regmap); if (ret) goto err_put_rpm; --=20 2.54.0 From nobody Fri Sep 25 05:31:34 2026 Received: from mx0b-0031df01.pphosted.com (mx0b-0031df01.pphosted.com [205.220.180.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 732734E8E02 for ; Wed, 16 Sep 2026 10:29:43 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.180.131 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1789554589; cv=none; b=fziC5pH+kjQz5HFv6NY5JAQZT8LYna1AWElxn44NsY+pIPxM2kKGwKTW/CVvczY13fUTru6x3I9cfDzzCEVfGuV3jsHaDZWrmtNkJT5/N71HV8Pf+BlyGrANEc+JsuzFBZb4lM9Brm1Iul7kzZTcgzO1YVds6LX2vx8R8O648Zo= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1789554589; c=relaxed/simple; bh=st9xlZKmZ48UF3uJ2bUZA6moRjATrWOgM/yr01YuaB0=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=MKd1DstFIm/EPZryqRchCNE4oEdKS2eHYQkNrJ6U6YPZFZPSAurB7NPLB4MFUZ4wmZjlSpCOd69H8xb0f002KYkvEe7r9pCMrvKOk5rkGWZrFuMqAbPa6Wc+cC7aJQhQX8qRVNghzzCjlyXzWvF7JqIlM6nigAJKl6CzhtIObr8= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=nE7pQlAo; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=HqrJSS79; arc=none smtp.client-ip=205.220.180.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="nE7pQlAo"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="HqrJSS79" Received: from pps.filterd (m0279870.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 68G934p02478420 for ; Wed, 16 Sep 2026 10:29:40 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= r2hXn33m4Qsw1kMDFpBlgq53rSQ/1SMHI+fdKa/pWaQ=; b=nE7pQlAoDNcFo8Pb bY9lTddhcWX5gao+NvS3TimhTsmdWfS46wFPsqmB5BpbH2oo40CAJ4jmNKgDl6Yb GAv0zW4ZlkuDUoDGtzybtiLZ5vL35useQJYFUZ2FbnR6AAO9OyjgWahlqaEgp8de hjQc3O14+9PJTXCuaVqVv0/4Ea7VwbJcr+pnDBOTHQbVse3OJUlwL0CELUXYmCu0 8QYsB4NZaVlNd/pd69p6cWgWdFMrY3q/d0jK548pgWIlDPxWctDUWtNjztvaeYtU jMQA33ZRXTTWsBYHmdtk8zSC0VL4SrtgUN1EoYnehAI6v5wtfOPJG3kHKdxu3Pl1 SK55Tg== Received: from mail-qk1-f200.google.com (mail-qk1-f200.google.com [209.85.222.200]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4gqjcksvdw-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Wed, 16 Sep 2026 10:29:40 +0000 (GMT) Received: by mail-qk1-f200.google.com with SMTP id af79cd13be357-9390a2c895bso1292224085a.0 for ; Wed, 16 Sep 2026 03:29:40 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1789554580; x=1790159380; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :content-type:mime-version:subject:date:from:from:to:cc:subject:date :message-id:reply-to:content-type; bh=r2hXn33m4Qsw1kMDFpBlgq53rSQ/1SMHI+fdKa/pWaQ=; b=HqrJSS798VIG/xl5WjsCTy99NWWumzU65E0Q2+x+N8iCEq+CQ1dyichuy7TDG1Baej LP80pGeLRrPCz6a2MntJo7iQDmqdzkbVoSGkktjdvqr59w1hrOnea4SozLmopjCGwu14 NSqnl8yYYxsYrRkENOsWqUmGtAvuExmITul/o7U5VFzWJO82Jemc+fFHKZ76eueRiAvU 16L23e/0mhrc4GOqs9PGnu35EVvDB1aJf8Nx/q7guJdLUu0BAfSiNtLsT6odtt88fhVs Wv+GKCCaUTJZo38AFd7VutYyeY03mYk15nDJUf2xMpmpt8QdeyXctGNw7hWEYavMRk2S +F0A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20260707; t=1789554580; x=1790159380; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :content-type:mime-version:subject:date:from:x-gm-gg :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to :content-type; bh=r2hXn33m4Qsw1kMDFpBlgq53rSQ/1SMHI+fdKa/pWaQ=; b=duOpyHVi73EHADTpXa3benRQbjKi0bEZqGfl8dLgxeM8tbR7K5sud37ct6jM3Njoy9 y5QWGMD7pVZFe4N0F3HMQ9zHw0AZSdFu1a7XRXQbKE4B9tqEXivLhW8l7nYL9lAZuk9t /xXotpnlmdXF7mXax9H5LGU689tQaG9sdBlK87EGPM1CoSx/q+8krcykdrKiv6Hl8XU1 XZpzKv6VjmpJsvzgxVnMtaX/5tPxMuhga5PPgg8uKelBYB2VNTuxOq6It1TnhJ2TalEC LS5zOw9gvANXZ9eOnag8FSCHqGLmbq+8W4LaotVelsehdTeAD2yrpNJpArMRK/oUDJWz 2EAQ== X-Forwarded-Encrypted: i=1; AKwUvBwcDa5RlszBRePOsM/8GvLh4q73YU+13PgrnTGXI5/LknkUglnTJN1VaaL+oKvHG3D8bFSngtRzBkKKzGI=@vger.kernel.org X-Gm-Message-State: AFuF++l1e6KKwQrz4LzfXLSdvvzgBF6qP1iAHV1px3p/L3UnsgckvGWp YWmOv329GDFsYfW7aPHjbaY9UAkkkmohCR0enu4Dz+ExNQrgiTbwO6jbUSIStEPVbO+pSmle6eQ rpOSkX7hqSHkYVzXimYfAZwDj5OYQKoCACNc8jp9I8t6wkyADm7KvrMBMG2IayZLmXZg= X-Gm-Gg: AYBFou3BTFp7s2uMvzsiMT8UehLDf++hZEP/6oRIO6Nj+KIUPVJZ72J27G6oZA4Fgyp 73IXFe5U6skUMq3C8/8+zx/9tfnLjSSnTqLUUEAiYLOXkGR9HwyQloOnJdANtO0/XeePuaas0D5 eCDiEbZyINACiHZmnYNSPSup7IS8wCHI+HvkVypk153kd4jiIowOcsA/1MGI29VFUAK9KFXvH02 WrbuZz6Z18wS11Xkd5QNHpKrmqUju8KtIeuDRjpEjUOaooxcKfDjtFST7LXF2biLd+S6r4XmcGr fhkf0gTrCUECmpLzLVDo8fvuKv/NmiR0A/ELU4sJ6iRY7byf+Vpf8J2g0G+8C48Yof7sjp4t9Cr WVtF2vek= X-Received: by 2002:a05:620a:17a1:b0:937:7836:1501 with SMTP id af79cd13be357-93bb7627d7emr315606585a.10.1789554579890; Wed, 16 Sep 2026 03:29:39 -0700 (PDT) X-Received: by 2002:a05:620a:17a1:b0:937:7836:1501 with SMTP id af79cd13be357-93bb7627d7emr315601785a.10.1789554579318; Wed, 16 Sep 2026 03:29:39 -0700 (PDT) Received: from [127.0.1.1] ([86.121.170.232]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-49e83dbb0c1sm71633805e9.14.2026.09.16.03.29.37 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 16 Sep 2026 03:29:38 -0700 (PDT) From: Abel Vesa Date: Wed, 16 Sep 2026 13:28:28 +0300 Subject: [PATCH 12/48] clk: qcom: dispcc-sm8750: Use common probe handling for always-on clocks Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20260916-clk-qcom-rework-legacy-always-on-clocks-v1-12-25a24e50f82a@oss.qualcomm.com> References: <20260916-clk-qcom-rework-legacy-always-on-clocks-v1-0-25a24e50f82a@oss.qualcomm.com> In-Reply-To: <20260916-clk-qcom-rework-legacy-always-on-clocks-v1-0-25a24e50f82a@oss.qualcomm.com> To: Bjorn Andersson , Abel Vesa , Stephen Boyd , Brian Masney , Jerome Brunet Cc: linux-arm-msm@vger.kernel.org, linux-clk@vger.kernel.org, linux-kernel@vger.kernel.org, Abel Vesa X-Mailer: b4 0.16-dev-0e65f X-Developer-Signature: v=1; a=openpgp-sha256; l=2012; i=abel.vesa@oss.qualcomm.com; h=from:subject:message-id; bh=st9xlZKmZ48UF3uJ2bUZA6moRjATrWOgM/yr01YuaB0=; b=owEBbQKS/ZANAwAKARtfRMkAlRVWAcsmYgBqqm9Wp1X0Jvy65lQ9uifZJ0T66saqV23rYsgoC gppy8CnIL2JAjMEAAEKAB0WIQRO8+4RTnqPKsqn0bgbX0TJAJUVVgUCaqpvVgAKCRAbX0TJAJUV VggYEACNd8bypCiSUkibCiYeozrb1TpQOX09x5i6q6zQhjoiqCXH90XPCJM/r52p6yJ8e7usPVf 0GMuuVv43nmnAiGkdyt77gYdMbl+5PQSVkky0wk1xLDXXItoPyDYCVv/XsgNCAZ5jVIwMImJ2Zw USnHsow2FrmEbV1BiLn42X+phez35y918T3O2xFWov/cat9FwJfVJyExqO7k6rXF2FUKLEtYdWd H1BqFletVz1WXViAymYwg/UQ1kH4b3eBFU496zKgThlzKRsY6XZo9pgCBiIERbp3aKV3po4VDJq lVwl4V5gK5t38/fKt4YIStRjEePXjtk5hw/jRiBV7bDQE/1d8Qoh+o23/uXVjflNi4MP1bTaklY 71QeXoytA1SuQibJUNG4Mk5FB9UxqjnQllZSQja35TR8DQMjq2Ze+uQM4QrxWLT/WhtgJsU/ZLl CKcEpZXXI7TiyxK1cFCOmR2txoJ/3e4/O5bb6+KWREp1EJdbKI6C9lSb3qS6czPhdE5RGBnNJo6 k0hxQTfpqhC6owi6LOxLIHBFQYatuOr5UqDAxZLPRMzjmAsMmr5B9xEEarY37z1+zz+d9TqRU0D byZqB5+qV20O7WJIf0iIv/EKDQ81VNxHUuRqv5ihRmHgBTuf4Kfh/l7FTQ0mDtL73912ytIoRgQ JXIZnV4PU2npgRg== X-Developer-Key: i=abel.vesa@oss.qualcomm.com; a=openpgp; fpr=6AFF162D57F4223A8770EF5AF7BF214136F41FAE X-Proofpoint-Spam-Info: AW1haW4tMjYwOTE2MDEzNyBTYWx0ZWRfX5w/P/pT+7RYG l44SdLOws+3r2JhOLJsnSFYb673C8uQRU6Y2/Tyof2dKCqGDQvCnHFgHU18P4PFjPjWRfRtyyaN 0bZswZ2oCWen/Q+YmeWeJNLpxHGK424= X-Authority-Analysis: v=2.4 cv=PsIG/AM3 c=1 sm=1 tr=0 ts=6aaa6f94 cx=c_pps a=hnmNkyzTK/kJ09Xio7VxxA==:117 a=po8fGBi+ks8MzcVQGuqtFQ==:17 a=IkcTkHD0fZMA:10 a=VdqzKS8jKosA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=gowsoOTTUOVcmtlkKump:22 a=EUspDBNiAAAA:8 a=FGioixOYZu2XGbO-fNgA:9 a=QEXdDO2ut3YA:10 a=PEH46H7Ffwr30OY-TuGO:22 X-Proofpoint-ORIG-GUID: vG2pXsYp0tfI1K5GuxuV-fvCs9r2hPeg X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwOTE2MDEzNyBTYWx0ZWRfX7cw/DR/WI92S 1WofXow7rjOWrXlWtyx9UAoa3JQSo3K3lcHmZ1s/UN3p3hB3p/yaGgD74aPVPA5Opc+RZ35z8rH eQjtQriI1B6iE/4qEA4nm50tkujPwlUtcKVTgR11+7dwhKX7UwoiupVb1r+uVplKRd0tGudbC24 mDm32m6xtorL3g5gnSsny3s/dm+o2E6wPGGuKSUtm2td/Tz86jWiANeVbgO5HScpUJB7z370Ri4 y0jiXneqwLwK9S6eMGXZLDPLfpN/ImO5VEN/uMEGw7zs/6aC+7+TU0JfQK4WPqhK7BVjbo8qNJL zLtFeYy+f7oiswx8PujLsPnc7EwfEH1HbcSz53TE8KdQ6T59d41R7FPKSpRokEzHOvyMeX4rW4X zzvnkYVzfZbdao1D1/Jy3tvOosXmDZZMwde+rtc+fjIccXi2q2jC+qOQI6rcJkh3Y7DX1BMGkzM lPFGT31mG+5+zXTe4Tg== X-Proofpoint-GUID: vG2pXsYp0tfI1K5GuxuV-fvCs9r2hPeg X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1176,Hydra:6.1.134,FMLib:17.12.100.49 definitions=2026-09-15_05,2026-09-15_02,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 impostorscore=0 lowpriorityscore=0 adultscore=0 priorityscore=1501 phishscore=0 spamscore=0 clxscore=1015 suspectscore=0 bulkscore=0 malwarescore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2609040000 definitions=main-2609160137 Describe the always-on branches in a critical_cbcrs array and reference it through qcom_cc_driver_data. Let qcom_cc_really_probe() enable these branches instead of programming them directly in the driver's probe. Assisted-by: LLM Signed-off-by: Abel Vesa Reviewed-by: Konrad Dybcio --- drivers/clk/qcom/dispcc-sm8750.c | 19 +++++++++++++------ 1 file changed, 13 insertions(+), 6 deletions(-) diff --git a/drivers/clk/qcom/dispcc-sm8750.c b/drivers/clk/qcom/dispcc-sm8= 750.c index 18e86b80e581..3205ce5c1ad9 100644 --- a/drivers/clk/qcom/dispcc-sm8750.c +++ b/drivers/clk/qcom/dispcc-sm8750.c @@ -1884,7 +1884,20 @@ static const struct regmap_config disp_cc_sm8750_reg= map_config =3D { .fast_io =3D true, }; =20 +static const u32 disp_cc_sm8750_critical_cbcrs[] =3D { + 0xe07c, /* DISP_CC_SLEEP_CLK */ + 0xe05c, /* DISP_CC_XO_CLK */ + 0xc00c, /* DISP_CC_MDSS_RSCC_AHB_CLK */ + 0xc008, /* DISP_CC_MDSS_RSCC_VSYNC_CLK */ +}; + +static const struct qcom_cc_driver_data disp_cc_sm8750_driver_data =3D { + .clk_cbcrs =3D disp_cc_sm8750_critical_cbcrs, + .num_clk_cbcrs =3D ARRAY_SIZE(disp_cc_sm8750_critical_cbcrs), +}; + static const struct qcom_cc_desc disp_cc_sm8750_desc =3D { + .driver_data =3D &disp_cc_sm8750_driver_data, .config =3D &disp_cc_sm8750_regmap_config, .clks =3D disp_cc_sm8750_clocks, .num_clks =3D ARRAY_SIZE(disp_cc_sm8750_clocks), @@ -1926,12 +1939,6 @@ static int disp_cc_sm8750_probe(struct platform_devi= ce *pdev) /* Enable clock gating for MDP clocks */ regmap_update_bits(regmap, DISP_CC_MISC_CMD, 0x10, 0x10); =20 - /* Keep some clocks always-on */ - qcom_branch_set_clk_en(regmap, 0xe07c); /* DISP_CC_SLEEP_CLK */ - qcom_branch_set_clk_en(regmap, 0xe05c); /* DISP_CC_XO_CLK */ - qcom_branch_set_clk_en(regmap, 0xc00c); /* DISP_CC_MDSS_RSCC_AHB_CLK */ - qcom_branch_set_clk_en(regmap, 0xc008); /* DISP_CC_MDSS_RSCC_VSYNC_CLK */ - ret =3D qcom_cc_really_probe(&pdev->dev, &disp_cc_sm8750_desc, regmap); if (ret) goto err_put_rpm; --=20 2.54.0 From nobody Fri Sep 25 05:31:34 2026 Received: from mx0b-0031df01.pphosted.com (mx0b-0031df01.pphosted.com [205.220.180.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 7D4344E80C2 for ; Wed, 16 Sep 2026 10:29:45 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.180.131 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1789554607; cv=none; b=fi4ZL0EG4n+9WRGSTmYnOJuupPh4ls8CF84jdDrBqDXeaKFKcgUuOYuB0Rsn4XQUHEDIFiYrI0KjeJUdOqde9co627HV5IfA2Ra/wVmQb0x0hGrXqxyXlY5h8YxZ7kMEgcazJwg7DRR5Znz7+f4jfrPT2k+Z9R1NJC4cVRqt7tg= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1789554607; c=relaxed/simple; bh=qlfNz4pd0+y4mAPYA9gJApqjJZuFHRKp75YT7U9cYs4=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=T4fJu6uXhz8ICvDi1vW1QM2am1Wsd0aNHwDyIf9mapB3/M1epBYBDXLjG706hPF/CcmKaAJeMIIgIhymGHnciZShob8+BZU8S69TmnjozD+0lWym5EAm5K0A1asUIUE29ijJwH9xfrny4XbGGTkNWOBy2osEQ+rxPmhlgs6IdP0= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=Uij9MzDh; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=EHLrY4By; arc=none smtp.client-ip=205.220.180.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="Uij9MzDh"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="EHLrY4By" Received: from pps.filterd (m0279873.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 68G934IK2226506 for ; Wed, 16 Sep 2026 10:29:42 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= N4V3xiwbplHoiKjEUNaFCzSGf2IrsjYKLcMWg+xw8Gw=; b=Uij9MzDhSjaKWX2O JaDSSvhbc3Sxm2MP7IZXOQf2q7qJN8NTiOdb3J63P766fsWqecCMYHbmjy99X6VT cQOZY3D+JsEGGwBHv7c79s5DtpUoOIcYLnrKYRQc8dc75Y/Eo4KjEINEJv69RylU ztpGmI3WOxMa04kMBqEZh8A7OfraoCV651/fc+AVHsN5buWBVCgjn3KklXeBYYFS K/Rl6dl3Lnr3IZ5w0MgKNHljQG1Rok8h6JOEzPGW/1ju+NZEdlX0NInX1+WalYFs akvE8SvBmEYFlXswOQgFi8QoeBH66VgkHFwZbCaRSMt6K0YzI0TlpjLvkkLLgmQL j5N+IQ== Received: from mail-qk1-f199.google.com (mail-qk1-f199.google.com [209.85.222.199]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4gqah9ut04-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Wed, 16 Sep 2026 10:29:42 +0000 (GMT) Received: by mail-qk1-f199.google.com with SMTP id af79cd13be357-93a1b824e84so685983185a.2 for ; Wed, 16 Sep 2026 03:29:42 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1789554582; x=1790159382; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :content-type:mime-version:subject:date:from:from:to:cc:subject:date :message-id:reply-to:content-type; bh=N4V3xiwbplHoiKjEUNaFCzSGf2IrsjYKLcMWg+xw8Gw=; b=EHLrY4ByPs1gmtjdArLGz6O+YfLnnqAdZDwJwX9BEF7kcSxDfKtCsr6YRtxO1u1CtQ ZmU1SoarsT+jMFEUxIlHqd+TKLO5Ya/nSf7CSnLRRemKgftz8l4h+NUJLZ9g0Lu4Y2XZ ZzeePhCIceRzTp/EHq4MTiJNJTAk6ell5K/idCit12ugyWllcutQgmUmUR/DlPix8egP Cz/ZlMHAU6tTjBWkTSQbg9Ov4/vRdRg5bgjR5P9VZJwguWB74DZDKWwUF9OWglj79JXJ eXQ2QeLlMSLrt5Ne0vdrSXhNvi4lRjvtVnDW9n+bIX30eCTF4okjJvPsUtTlr7dJkyui 4urg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20260707; t=1789554582; x=1790159382; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :content-type:mime-version:subject:date:from:x-gm-gg :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to :content-type; bh=N4V3xiwbplHoiKjEUNaFCzSGf2IrsjYKLcMWg+xw8Gw=; b=J+rQ8gNxD+7OYP/h2kKpIioA6LnrA3HXr9EHpInugy0IhkSpQFtnMCjD9vAtGCSNIl i57VEuQOA9mnhSH3CrUc3sdYnE//8MR0f+nbR7dDcEkhQljh01wi/hI+olp22wQk4bHd IF3NtQcyakr7GNwcOOO/Rz+C3L7y2bRX82469KeP+VLhHTwUz2K4KHahz+dIuZteodHR beA4idFb1nWL2fohBtT5stbKwk9xjaFUmBjDe1tEdt3v+YZIBDHARRqbHNFzrbj+mpGg O18O8vonylpKsmfx3qIlt/kNCtzqTCyO8ZFNVte/r2D6jyOaUfgbPVHh+TzyQKjKKufu tJXQ== X-Forwarded-Encrypted: i=1; AKwUvBwOhFHwed/8PMa8BCdyPjpN0c23dMswz8N5dDFyjEBvyrZ6jHfTbvcLJofIVpbzIgL6kmPxXbgjyMQoox8=@vger.kernel.org X-Gm-Message-State: AFuF++mdKfSaVGV1IHRH1EiQYbxCYQfeC8iFXFW0r085Bu0yIlltU9fk oWrpbivQOpcxEUwkwBmHSGFWUBG5hnFUxuUrQ02Bn7HcG2vC20UHwoUlTGiP+0c/ncN6JsJd6hb rVrDW2kUcEab/cd539nWMEqKnwelrqKLzk1RUlbxdvZvNng4X7XSPEy7t2BiqzxDl9YU= X-Gm-Gg: AYBFou3kx9QF8xnAO4MXeMFv/V2TV17VCIxB53alUJU65z+P/TKuAywCefeprESNNEY Sud22XJbGp8cHlppghoVW5yIjikMoF16mu7ngRe+Gh/Ov9HiFWop2Ornfaf9iswpGhanXazqsED 1ihqIT4JMKeknfDaFuLonAe+NAb7HioHamOP9oeXgUzRWiq+rfaW/blnubmHuD2eqNxoIUQ10tm MZ7n6f+aZo3dO5otXqZH7gl1AjvWu0SSN4Q5XUvEXQAuNKYyBC7e7O8XDxKEwySCKStwCB5d1Fq PrCs23tO9qWUuxURePEvnU8DBDm43dDg6coqEKxuz1p1uEw8MOP8PULsT9ZiH6KV0pZIkIzDu79 jUDpk+Ps= X-Received: by 2002:a05:620a:4512:b0:939:13a7:70f0 with SMTP id af79cd13be357-93bb770c2a0mr292102285a.5.1789554581626; Wed, 16 Sep 2026 03:29:41 -0700 (PDT) X-Received: by 2002:a05:620a:4512:b0:939:13a7:70f0 with SMTP id af79cd13be357-93bb770c2a0mr292099385a.5.1789554581099; Wed, 16 Sep 2026 03:29:41 -0700 (PDT) Received: from [127.0.1.1] ([86.121.170.232]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-49e83dbb0c1sm71633805e9.14.2026.09.16.03.29.39 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 16 Sep 2026 03:29:40 -0700 (PDT) From: Abel Vesa Date: Wed, 16 Sep 2026 13:28:29 +0300 Subject: [PATCH 13/48] clk: qcom: dispcc-x1e80100: Use common probe handling for always-on clocks Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20260916-clk-qcom-rework-legacy-always-on-clocks-v1-13-25a24e50f82a@oss.qualcomm.com> References: <20260916-clk-qcom-rework-legacy-always-on-clocks-v1-0-25a24e50f82a@oss.qualcomm.com> In-Reply-To: <20260916-clk-qcom-rework-legacy-always-on-clocks-v1-0-25a24e50f82a@oss.qualcomm.com> To: Bjorn Andersson , Abel Vesa , Stephen Boyd , Brian Masney , Jerome Brunet Cc: linux-arm-msm@vger.kernel.org, linux-clk@vger.kernel.org, linux-kernel@vger.kernel.org, Abel Vesa X-Mailer: b4 0.16-dev-0e65f X-Developer-Signature: v=1; a=openpgp-sha256; l=1802; i=abel.vesa@oss.qualcomm.com; h=from:subject:message-id; bh=qlfNz4pd0+y4mAPYA9gJApqjJZuFHRKp75YT7U9cYs4=; b=owEBbAKT/ZANAwAKARtfRMkAlRVWAcsmYgBqqm9XgIYWAAyWWO5S8pQ1375Ok4Z72pPaeI9SY GWnts4zZ2GJAjIEAAEKAB0WIQRO8+4RTnqPKsqn0bgbX0TJAJUVVgUCaqpvVwAKCRAbX0TJAJUV Vu20D/dJM25yhrbqyIQy8j6kaZPz8ScFaF+uOuX+6PO9yeN9q8jq1+lXoicjd8pse5BJrF7YfM2 PkCT5/eAbPXKqaSIxsYbyJ2a/BBssRzOT0cJC08F2kK4rrAw8veS20fT8T3FCaDhaT0siejTFvW R4guZ5o5qgKj1I6qSMUR6+tjUdOMJipRzTBYFMdPigFcyksJ00orVViYNHf3vJabGFsEvnWt6/q 0mWQksqh+XLLUyCuvnc01z1CYkjCN3I90kwkEsF0c3mQ/4g2Gh3+xGy1PlfSa98w21zxobbLqIH bZXRfemB7dPkqQUTaTlE4fyrUSr152iLBqM6/C0nJvXFrwTC2jO43bW6LRaZIk5c2q+GulsaSxf rMZtL8VftcDIvo18kWsRfg8BPl30ZnBB+jyHhtUM4Dy+10t9GY4p1HPO2ZABUrzthVi9cCeRjC2 l9KM7lL7Jx7HCpyzX9FvRRPccUUlj2qZL8/xjB1JBlt4LfW4DoCDTKKvLIKDhAxBZZu4JZLALxw v/jswUwSxLtx6jUjd2+VuKKpzOh3L9svSCVJkhyFh3WMP2rXajA85PqFRDzsElFaxHhnPX6MSRI dAxSbhb9vHBWY0scvP1arhV36Q27Au7JT6zd0RzA8Np5HAceixQQ0vgDeSb2G7ZxOjN1mXs/t2g HSyPrwoHSiFES X-Developer-Key: i=abel.vesa@oss.qualcomm.com; a=openpgp; fpr=6AFF162D57F4223A8770EF5AF7BF214136F41FAE X-Authority-Analysis: v=2.4 cv=BtkIUoX5 c=1 sm=1 tr=0 ts=6aaa6f96 cx=c_pps a=HLyN3IcIa5EE8TELMZ618Q==:117 a=po8fGBi+ks8MzcVQGuqtFQ==:17 a=IkcTkHD0fZMA:10 a=VdqzKS8jKosA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=rJkE3RaqiGZ5pbrm-msn:22 a=EUspDBNiAAAA:8 a=55LTGlQWyvwDnq5kMygA:9 a=QEXdDO2ut3YA:10 a=bTQJ7kPSJx9SKPbeHEYW:22 X-Proofpoint-ORIG-GUID: JjzEe2vY-vF72Pec3gtfSJnccqNwEESG X-Proofpoint-GUID: JjzEe2vY-vF72Pec3gtfSJnccqNwEESG X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwOTE2MDEzNyBTYWx0ZWRfX3oeDmhK4H1GH iQeJ+sm2rjbCrHl27PQ14MFHPPEQcBGfP8AfMDdhVR3V/EWcTfdGBENPTtGBIFiqvldyo2HKzXx Tumm1bOBf62o+6KtqlOz90mnhsg+6MJh6yRCtbmRbss/MsS7qNEEgy9/aVD21Axplkcmx0wW4tR zBTnQMoOr0sTROypM2UuY+F7uu5uJsgtrSYRZ49Q2GAoLJMdLvr/+fibPaN9LY6USLqRgRzbEhH P7Rpx01hNAkQ4vyf/LHWGrJp1QiZPfqjBXljBX3wwvWRi4EGI6FUW5lqVLWVY8h4J+Ks1J4cmFk P5f9IrMqM/3Uj7KoTADAtVRe61ubpJtX/fDVrtUCm9clYXZ69lYuRWS0pDVHOXHT/Bfu6lUexVO XwPn2ZRKQaKNnsbumHRrnINUE8C04GI1cZvUJvF3R82Ozl0HaNWBTbaRTiTDRR8+4kNiSq2wL2w 8Az47WBRGz26xhSHHOA== X-Proofpoint-Spam-Info: AW1haW4tMjYwOTE2MDEzNyBTYWx0ZWRfXxpAla89tQu3M W+2LWuGmAkCwB7xTdCNEN7t1+UUSoN/PkzOUrI5OSOEBlRAUnRgbziJ93N7UYXJyPpXhXk5AZk8 LfI1ud2azwcjZFtDzgoCGffBmM7i7E0= X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1176,Hydra:6.1.134,FMLib:17.12.100.49 definitions=2026-09-15_05,2026-09-15_02,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 priorityscore=1501 lowpriorityscore=0 spamscore=0 adultscore=0 malwarescore=0 impostorscore=0 bulkscore=0 clxscore=1015 phishscore=0 suspectscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2609040000 definitions=main-2609160137 Describe the always-on branches in a critical_cbcrs array and reference it through qcom_cc_driver_data. Let qcom_cc_really_probe() enable these branches instead of programming them directly in the driver's probe. Assisted-by: LLM Signed-off-by: Abel Vesa Reviewed-by: Konrad Dybcio --- drivers/clk/qcom/dispcc-x1e80100.c | 15 +++++++++++---- 1 file changed, 11 insertions(+), 4 deletions(-) diff --git a/drivers/clk/qcom/dispcc-x1e80100.c b/drivers/clk/qcom/dispcc-x= 1e80100.c index 795279609c0b..7366c6513035 100644 --- a/drivers/clk/qcom/dispcc-x1e80100.c +++ b/drivers/clk/qcom/dispcc-x1e80100.c @@ -1637,7 +1637,18 @@ static const struct regmap_config disp_cc_x1e80100_r= egmap_config =3D { .fast_io =3D true, }; =20 +static const u32 disp_cc_x1e80100_critical_cbcrs[] =3D { + 0xe074, /* DISP_CC_SLEEP_CLK */ + 0xe054, /* DISP_CC_XO_CLK */ +}; + +static const struct qcom_cc_driver_data disp_cc_x1e80100_driver_data =3D { + .clk_cbcrs =3D disp_cc_x1e80100_critical_cbcrs, + .num_clk_cbcrs =3D ARRAY_SIZE(disp_cc_x1e80100_critical_cbcrs), +}; + static const struct qcom_cc_desc disp_cc_x1e80100_desc =3D { + .driver_data =3D &disp_cc_x1e80100_driver_data, .config =3D &disp_cc_x1e80100_regmap_config, .clks =3D disp_cc_x1e80100_clocks, .num_clks =3D ARRAY_SIZE(disp_cc_x1e80100_clocks), @@ -1678,10 +1689,6 @@ static int disp_cc_x1e80100_probe(struct platform_de= vice *pdev) /* Enable clock gating for MDP clocks */ regmap_update_bits(regmap, DISP_CC_MISC_CMD, 0x10, 0x10); =20 - /* Keep clocks always enabled */ - qcom_branch_set_clk_en(regmap, 0xe074); /* DISP_CC_SLEEP_CLK */ - qcom_branch_set_clk_en(regmap, 0xe054); /* DISP_CC_XO_CLK */ - ret =3D qcom_cc_really_probe(&pdev->dev, &disp_cc_x1e80100_desc, regmap); if (ret) goto err_put_rpm; --=20 2.54.0 From nobody Fri Sep 25 05:31:34 2026 Received: from mx0b-0031df01.pphosted.com (mx0b-0031df01.pphosted.com [205.220.180.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 8C01E4D2EC4 for ; Wed, 16 Sep 2026 10:29:48 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.180.131 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1789554591; cv=none; b=Zo+3CAoVJTAhczUnCzlRwZ+Ud31mRVkHS/yRn9Do1PF3wtN/Mo78YsjgRagGOC935CI7uYSQ0idRYY1r/1R0/3Sc3+yPCZLFmccqJNbF+ogqW0scH4Tt1GqcGKPna2q/IgaM7XCU4v+Uo/NrzqbE7pmQ2VFs+U3eDZjE66UdPxo= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1789554591; c=relaxed/simple; bh=J8ELAhoIpjnImVTW8DOoahvNct88sOBJ3fkgSfxEmuQ=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=Je8IUQiTFc0PwRS3osQ/OJf1BSgnVGZtHkjn554XHFRZSNpqnnE+Bk1UWdM5GlC5V+lFc1n/J4pKqf6vr0hs7J3N1/Phpg9fnEPyBN15cLAYp8YoVjMAuCBNWI8Qh8DrWBWckO/WkQJvd1xb8s8I9Fksj6NBTez4p+kgOhVCd24= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=hjeDK2er; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=ELGEEedg; arc=none smtp.client-ip=205.220.180.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="hjeDK2er"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="ELGEEedg" Received: from pps.filterd (m0279871.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 68G930Ib2822773 for ; Wed, 16 Sep 2026 10:29:44 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= F9LDF97B2phcH9cg/WCxnzSZjo0ODbK2XBNEqzipB0g=; b=hjeDK2erWxCC6aYw gWqKX9PoHtlR9Y/2nkEW3nDa7H04kwUBrSjN6rDSFVo56h+v18biQIr90FYy8Xm4 jT/eWhQWmVwzLmhy1dlMg8hnLx/kiVf6JTlIxwCgmDV/Q91F5D/veIXNX67KOhkZ dnJySJQk2NpXzuctX+KAcLL1UBOIh5dg1gn83QMBlK1lF7P0+/CC3HnR0Zt071IV jGZcBGfDvhlUZOO7K1uLpnRWzK+98W/IFu42X4vKwrXrs41uN7Vosx+Ljw0xTdLq Odo0rW8FdKNohZWGy8AY9D15YGYcNd7vRDxZgai06rCoPVSA5tsDURBaHY2Xv7Kn NaPuXA== Received: from mail-qk1-f199.google.com (mail-qk1-f199.google.com [209.85.222.199]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4gqfvfjb94-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Wed, 16 Sep 2026 10:29:44 +0000 (GMT) Received: by mail-qk1-f199.google.com with SMTP id af79cd13be357-9393ac4961fso658923485a.2 for ; Wed, 16 Sep 2026 03:29:44 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1789554584; x=1790159384; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :content-type:mime-version:subject:date:from:from:to:cc:subject:date :message-id:reply-to:content-type; bh=F9LDF97B2phcH9cg/WCxnzSZjo0ODbK2XBNEqzipB0g=; b=ELGEEedgugdcEijt/Z0YcBz6LeANepoNcC1z4aIaL/RuxX6VmPZ5+V9h63yzvhHpU6 zui8NZ1Ob87/AZvQnRTJxVbZ3o6GAIXRVUjRBBt+3+LjrvajYU7TCkbqC9qM0O1AFzgV qY6OXvL/XnP7uG3pV0+YIvJmRhWi+dx9rNZ9AGvJQqFtyOQfdEtHqdqSF45sex4ih7e4 PODkkzP1xLEDPlumrTnzn0G0TVEFJ2mnBDNi6EPYNAbd8w+7Qxq4hEXlPMOMemGrwcV1 gV05GuosOpxB+EeKjJ0/jE4l14mT95beMNjLDCkRgeZydM+rH1DHEUfj7y0e57XIMYB7 KBGA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20260707; t=1789554584; x=1790159384; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :content-type:mime-version:subject:date:from:x-gm-gg :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to :content-type; bh=F9LDF97B2phcH9cg/WCxnzSZjo0ODbK2XBNEqzipB0g=; b=TWR38Or5ViGxKdo1jXGdgJOFtjkiqzCru8aPXcA3JgI5pqKpE0Gmf2uo0QMR8gZcXs Xi8nE+o2lhyOmjn7EyNq/gBEp33yZ9RktjrylZNrtiejBhdA2fXeLfAnNnwOcxcAKzPI v7KIfU9DzAIkXGurvHkVM1txqLfV47Kq/x0PC2KeyWIukNkuOT6ZxBL0EbfD+Cmaal3u LHm9Pfa//Ct2bH2yju4gxXyiHw9RstXnpaNG738eWlGTp+DgpFLu1hhEcu4kocHRqosC QHAva1Ek1Y0xXm5FzNPkkNXw+ipqDDWWxbJBbGYg8sPSPo0duFq3vSH3QcMYFOQUPFhX 2ebQ== X-Forwarded-Encrypted: i=1; AKwUvBwK1slaNKIuRTfLPNCYWD/BYCNyspy0IEDhS8QxhkaYcvntrBiV0xi3Nd0Kso4Y5Nwv23l717sYi5wUYVY=@vger.kernel.org X-Gm-Message-State: AFuF++kj4oXLrZ36+9CydlwtQeUlyqB5xdb11OPWHpXcv7IuEDxNx7Qe BLdLLsJr/15UmjRp4vkytFx9aIiyLichZYD6ETT1IZrB8Eqpon5uJ5GFeKyfG1oKOUZh9ml9O4Q FuIOzZvc0u+ooBk7v9VzRb86QBOq9/D31NQzKd3oBjSBf4h1NGWt2VYyLd7qQWNgzhAY= X-Gm-Gg: AYBFou0/QbmUCn9Wv948anxaLk7NGDAseMWmUZpM+DZxmvA60UCtfTpXqG2ov2BBKtY Y9oZF5pPVrhZmAg8hXtJ/qxABJFErUJ05TEoF7SHRW1IiRJ8LT5H7pnJXY+D+N6iHZQW9GoqkrG s+cfiLHpBfThXkBBnNii1wURdX3ICVpHk74zjBC9S53W+75kw0XWY0L1hcJoS0cWqNOsgyLHiM/ 82wC3vP3WTlX1yBxe9lrBz2HeLBv5rqPEVPxi/KVGW2IID2OTL5KALC8CLzBHYIDgb/mw+QG9Jt wNUJjZETNPnlbLz5dX5S/cZ+9oUhjBwUnBsI9lyO0Ook+ghLAKjuHzn+iYN35xPVjB3M51RtUAd PuGOvn4o= X-Received: by 2002:a05:620a:172a:b0:93b:6113:21c with SMTP id af79cd13be357-93bb772b093mr287588285a.10.1789554583568; Wed, 16 Sep 2026 03:29:43 -0700 (PDT) X-Received: by 2002:a05:620a:172a:b0:93b:6113:21c with SMTP id af79cd13be357-93bb772b093mr287584185a.10.1789554583028; Wed, 16 Sep 2026 03:29:43 -0700 (PDT) Received: from [127.0.1.1] ([86.121.170.232]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-49e83dbb0c1sm71633805e9.14.2026.09.16.03.29.41 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 16 Sep 2026 03:29:42 -0700 (PDT) From: Abel Vesa Date: Wed, 16 Sep 2026 13:28:30 +0300 Subject: [PATCH 14/48] clk: qcom: dispcc0-sa8775p: Use common probe handling for always-on clocks Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20260916-clk-qcom-rework-legacy-always-on-clocks-v1-14-25a24e50f82a@oss.qualcomm.com> References: <20260916-clk-qcom-rework-legacy-always-on-clocks-v1-0-25a24e50f82a@oss.qualcomm.com> In-Reply-To: <20260916-clk-qcom-rework-legacy-always-on-clocks-v1-0-25a24e50f82a@oss.qualcomm.com> To: Bjorn Andersson , Abel Vesa , Stephen Boyd , Brian Masney , Jerome Brunet Cc: linux-arm-msm@vger.kernel.org, linux-clk@vger.kernel.org, linux-kernel@vger.kernel.org, Abel Vesa X-Mailer: b4 0.16-dev-0e65f X-Developer-Signature: v=1; a=openpgp-sha256; l=1924; i=abel.vesa@oss.qualcomm.com; h=from:subject:message-id; bh=J8ELAhoIpjnImVTW8DOoahvNct88sOBJ3fkgSfxEmuQ=; b=owEBbQKS/ZANAwAKARtfRMkAlRVWAcsmYgBqqm9YtvMIg/QuEFt4BcIAGXva9SUvsaeSRly0R HPZD9so9vaJAjMEAAEKAB0WIQRO8+4RTnqPKsqn0bgbX0TJAJUVVgUCaqpvWAAKCRAbX0TJAJUV VkndD/48DNEa4rYbbZQ/jhhA/k9SVne4CZDHVRHhBJ4tHSRJsblzuvducvphq2zFfyW0Or0Q++M QLw0RnOZn5Swv1mf29GTCxOxg3M8s+W6sUwtpJOBVRS0BypWUV/gGRlkhbV5/GyvawKSJ2x9qRO A6fOJCBeEJFzUVD3+8fAi3BlyphtKyMlgYIRgt6CrHfE+6qgPrHa4Lxn8OCGdph3Srd9+2hFQ2z azMlH8BHQjsHMxOs3gBmYUwCQhKCF/8swFCmXfWe6n2ynMSzJrxAiFqF/5xt7hQs2QZmmk2Ukxp qpfqQ5x4x9wvo80hsWxN8Q4t0+J0kSME8fTceyeRLJNAC1JyNinzKkPV81/+J5wKv9fPKZLKxst qBOJ5LqSjqEpPIi0c/wpalt+haYEWh6DbW+Qd0o35LksbgaAyLZN2HYgS6+MRyAiEe0+T67qUkY UcQBHoQ0NNGH+hPnHlgeVgqhZ7vvu8zsp5xh60AmhvhcdF0Uv+n5g86oIxLzeBV+Fn3Tx42fYfA JEfRqTc6Mwol1QFnPmH5Ighj0PeA4a3geNjoOmTscFL6qT1u8qxsy+rNk3C50Li2IgUc5U2d/Ht BwSvR41owPTYehMED3oZYXf6X87rPcWodPdQFGiIwMi5/JSckPZq+L8emRpwogYmCeCpI4VYpsy hh3CaByVp0YVRXg== X-Developer-Key: i=abel.vesa@oss.qualcomm.com; a=openpgp; fpr=6AFF162D57F4223A8770EF5AF7BF214136F41FAE X-Authority-Analysis: v=2.4 cv=JYkpPkKV c=1 sm=1 tr=0 ts=6aaa6f98 cx=c_pps a=HLyN3IcIa5EE8TELMZ618Q==:117 a=po8fGBi+ks8MzcVQGuqtFQ==:17 a=IkcTkHD0fZMA:10 a=VdqzKS8jKosA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=3WHJM1ZQz_JShphwDgj5:22 a=EUspDBNiAAAA:8 a=15gMRk_Tn8l8Lfg2mfgA:9 a=QEXdDO2ut3YA:10 a=bTQJ7kPSJx9SKPbeHEYW:22 X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwOTE2MDEzNyBTYWx0ZWRfX1CAPoXguBxxP ArDkPdPwX5t+Qo5K6h91R6TyrQ6Uuu8IcnOWeTJddcJHPJr/fL4s7qTIS2ZVYjHUSfB+FyKWQ8p KrMWE+IuVlvIz+X13rrwZD+pNDKhdfW0wkGNG3Ticp2akS+UpXZdISx/38sxWVMOK/i6zReAucW jrPPz+Lt7GT7zqJKJlvMA4+o8871BMhM8mJKwOSGgvQc8cXeo2kObPhT1mtTWLYV5i10ugUfeM1 /hwlgLsrtbzF322O7DyIVx+Tduvs0I6JMqGMW059fIGSL3QFvMlk/Cuu6sZsK8j/cr8rRInXMNS X3BKg4hpndBaleum6gZclW8+w7y4/8ZcZx4QQ4wBJ/3vJ5fHUq2xj45ITIk0WQr1IJw9d7BDOt6 mK/ryaSoE95uwWZzRSkZBgOxhTdAmU/2zGdrUR32arTZyib7FfhVEm96O0OLxHsoIkzHLG8TAky x6D8G9SivOxr6JRk+zQ== X-Proofpoint-GUID: X6YZUvoI2OrMZsxO8vgOWq3YGmXdSsa7 X-Proofpoint-ORIG-GUID: X6YZUvoI2OrMZsxO8vgOWq3YGmXdSsa7 X-Proofpoint-Spam-Info: AW1haW4tMjYwOTE2MDEzNyBTYWx0ZWRfXxJ3Ll8lT+iXv R7XPwidHyOT1qp2No7lEWSKdjpTAxKeBoEORdtkUAL3UqC4iDSjBzvHuXJ2EDeAQ0ySL7wexQFw lgNPqcna7uRL4dQS2yQkwn92n03Ts0I= X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1176,Hydra:6.1.134,FMLib:17.12.100.49 definitions=2026-09-15_05,2026-09-15_02,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 lowpriorityscore=0 phishscore=0 impostorscore=0 priorityscore=1501 spamscore=0 malwarescore=0 adultscore=0 clxscore=1015 bulkscore=0 suspectscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2609040000 definitions=main-2609160137 Describe the always-on branches in a critical_cbcrs array and reference it through qcom_cc_driver_data. Let qcom_cc_really_probe() enable these branches instead of programming them directly in the driver's probe. Assisted-by: LLM Signed-off-by: Abel Vesa Reviewed-by: Konrad Dybcio --- drivers/clk/qcom/dispcc0-sa8775p.c | 15 +++++++++++---- 1 file changed, 11 insertions(+), 4 deletions(-) diff --git a/drivers/clk/qcom/dispcc0-sa8775p.c b/drivers/clk/qcom/dispcc0-= sa8775p.c index 0e976442834a..a1861cc8343e 100644 --- a/drivers/clk/qcom/dispcc0-sa8775p.c +++ b/drivers/clk/qcom/dispcc0-sa8775p.c @@ -1414,7 +1414,18 @@ static const struct regmap_config disp_cc_0_sa8775p_= regmap_config =3D { .fast_io =3D true, }; =20 +static const u32 disp_cc_0_sa8775p_critical_cbcrs[] =3D { + 0xc070, /* MDSS_0_DISP_CC_SLEEP_CLK */ + 0xc054, /* MDSS_0_DISP_CC_XO_CLK */ +}; + +static const struct qcom_cc_driver_data disp_cc_0_sa8775p_driver_data =3D { + .clk_cbcrs =3D disp_cc_0_sa8775p_critical_cbcrs, + .num_clk_cbcrs =3D ARRAY_SIZE(disp_cc_0_sa8775p_critical_cbcrs), +}; + static const struct qcom_cc_desc disp_cc_0_sa8775p_desc =3D { + .driver_data =3D &disp_cc_0_sa8775p_driver_data, .config =3D &disp_cc_0_sa8775p_regmap_config, .clks =3D disp_cc_0_sa8775p_clocks, .num_clks =3D ARRAY_SIZE(disp_cc_0_sa8775p_clocks), @@ -1452,10 +1463,6 @@ static int disp_cc_0_sa8775p_probe(struct platform_d= evice *pdev) clk_lucid_evo_pll_configure(&mdss_0_disp_cc_pll0, regmap, &mdss_0_disp_cc= _pll0_config); clk_lucid_evo_pll_configure(&mdss_0_disp_cc_pll1, regmap, &mdss_0_disp_cc= _pll1_config); =20 - /* Keep some clocks always enabled */ - qcom_branch_set_clk_en(regmap, 0xc070); /* MDSS_0_DISP_CC_SLEEP_CLK */ - qcom_branch_set_clk_en(regmap, 0xc054); /* MDSS_0_DISP_CC_XO_CLK */ - ret =3D qcom_cc_really_probe(&pdev->dev, &disp_cc_0_sa8775p_desc, regmap); =20 pm_runtime_put(&pdev->dev); --=20 2.54.0 From nobody Fri Sep 25 05:31:34 2026 Received: from mx0b-0031df01.pphosted.com (mx0b-0031df01.pphosted.com [205.220.180.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 53A694AFE25 for ; Wed, 16 Sep 2026 10:29:48 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.180.131 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1789554611; cv=none; b=GgqzVRJfP+Sw68lQ5QIDbqIuG+V5wMXqMZPVnaeyYNJg0C87K1jNKEGFxeh6NMDptnfecC3Bdg4Br7pChQuqNMkZhln73dQq5PILAznQxPnVWEBZwt3ObfXV9cJkbVyxGTWHgx9ecoifog1aFTw9RPjpRSQaipJXeWKJCeXjX1M= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1789554611; c=relaxed/simple; bh=S2AniEfyDrGOAXCv/dbv4sqVV3IlT7BHWm8yR6GgpKw=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=io+mwtAsnWXiHAEnZyRmNAHyhukohxp5zCt1215LvyJ6RmtOFBXFfy/MENRd/lp0X2PSAPp5mKwp2dyU68xfFqHsIKfLwoq8f1VOkzznANIz4dPjTXOkkRsfgxGz2Cim/rGFgYVVWqlAgFdN+wywUSIo749EzQ2Szke7wN0RaVk= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=TB5ji0XK; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=Z4AmHE0f; arc=none smtp.client-ip=205.220.180.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="TB5ji0XK"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="Z4AmHE0f" Received: from pps.filterd (m0279870.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 68G92gfR2477701 for ; Wed, 16 Sep 2026 10:29:46 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= Ak2yG22SGL7622OFPDrvu6S7qAHEydZFrUoJyLNOey0=; b=TB5ji0XKZDlCjMIa kdBIygmNBairBDvP2cu6yCJZpgfK5u89J6OxF2m6c0fEkFQ8qVUyjG1OypbLfICa Y6jATBVw3L/LmqKicyhMN2WG2hEXNn0mSUrtmV19ZZomKq+C7hnBL5Gqstni6zmq lSFW9w30Vyi8zXXjZ8gV6Eg/9Xt29r5VMOg6Sr1z2BwhKpIeoqHoUZP36r/5dIXm 1paRERhIM834hmJjXVWP1/HD+xvuEEScL5JLmSMjIq8HzW7uzolJF3wSUkXF3oJt RzYklrsISZSOFBGSAu80wzcVN3x+kHUJYuIZsg7Pu5Yd+TSWSN1PMpEmvY8vtMcu PLQakw== Received: from mail-qk1-f198.google.com (mail-qk1-f198.google.com [209.85.222.198]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4gqjcksveb-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Wed, 16 Sep 2026 10:29:46 +0000 (GMT) Received: by mail-qk1-f198.google.com with SMTP id af79cd13be357-939f248907fso438989485a.3 for ; Wed, 16 Sep 2026 03:29:46 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1789554586; x=1790159386; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :content-type:mime-version:subject:date:from:from:to:cc:subject:date :message-id:reply-to:content-type; bh=Ak2yG22SGL7622OFPDrvu6S7qAHEydZFrUoJyLNOey0=; b=Z4AmHE0f4mymZ0m5c4b46PqydNcMIvpstEutFoOcy4hFaMTGc13EtR/sRBcUUVU3gQ lpTwVvs84Rb1sIqimAFF0S+gqWYBydS7t/+0KPTJNq6vvO85+fvU8JA7ytbF/+AsUdVP lJ1CNtBhFIB+ihfxJKFfHS1E3ImXfI5iwfpcpy9yfCdFUjzkML9hiiEqsPZ2vCIKo+mS atYuT0e4iR+c/3KIndCmc0YkfnZkyFFEwy/CdV3eK1u61a8xicP9y9hncxW82BboGuhC 2hWwXiTLNJcatIEyL97n3eqFE3enIt2opbliW7cj0VhJBNu8I6T4Hdla0bkbUJl/4cwL 5QcA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20260707; t=1789554586; x=1790159386; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :content-type:mime-version:subject:date:from:x-gm-gg :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to :content-type; bh=Ak2yG22SGL7622OFPDrvu6S7qAHEydZFrUoJyLNOey0=; b=N7yhJyqtjgEBEaD8KPqrrULIdvT47K8WwafnGqXreuVMAH9DY2RRjCr7jO+wfjz/b+ BaBqGK7XmWFJ9ts9LEIRPqUVp7vG2aONsoJ5rQVFeHkie+Bs96g/A9Zi5MpOXR9ynqdN 1uyZS/ywgprAdNlM3sSoEI9Gv+3hqM6vXQrXoWhmdIwlG3XRHxkuekuakqdcwBzXJ20j wVwU1riwYqTlzQqEa4NOfCqt6BNVzHwO7o2sCgn8nxkCkO/+Z2sImFb2z1l2fSk1DT6G DBY/HXTGNMU4sC/MXPQBWezxgE6limkeNeolZOLLau0Yjlfb62y64mO29dSJPHQgdp1D 8lRw== X-Forwarded-Encrypted: i=1; AKwUvBy/ezxCAR1wSzDq+PK8R4L7a0RSgM6I9ys5Qf1gSwhmda6TQEcdCl0VHGvUBIk192C1Ovptrmvfiarb2CA=@vger.kernel.org X-Gm-Message-State: AFuF++k9KJCztB9t+7bJA4FJo1dONAIU4oH316B26UcvGKV1EgfvZ6tF Ao9vUqLx6EsrDH54v6Ye4fPfqMpNX8hWCt4M0cuIuwEqsWTA7zPur/c1H1KLxc59d6x64dEVKtU +p5inJgz61Vdxcu9ZB9tJ5y4/aUYkHCkrG8D0saw3oXJsW6YBP5lMgl/HSLhkFlMfQ5g= X-Gm-Gg: AYBFou17lw8n18z2NuvCYe7GtOUNN4bEfWHKP9O+1TzVl8SKnaDPtE8o0P4vZhB21kH ozgQgupjlUCuBAoi/FswwvtuaEit/G6EV/Wegxcz++oticBzey0bYVuQzh6MvecYHAI7iTuOf8B 9Q/IRRInFU0rK8Z5O5doLVm61hWMMO8FJCDk2v3DOFcl+8bbhMXoxGcKdTIgO/hvZhpPYtziq9V mih3XgxV5I++XAfrz0yroxRuGpkWklmRw06S5mEfzzCmhjNpbXJqla2De8WcmFYwlXi8cwMOHDG 3AyTqz5f+TS9f1pdgxm9dTxrX+DKbOMGZu68RF1TjICaMVM2Wo5a1wiKs6As7xfWO22WR+q5ysl RoVajwdE= X-Received: by 2002:a05:620a:3941:b0:939:6df7:73f1 with SMTP id af79cd13be357-93bb79fdb62mr316186385a.51.1789554585555; Wed, 16 Sep 2026 03:29:45 -0700 (PDT) X-Received: by 2002:a05:620a:3941:b0:939:6df7:73f1 with SMTP id af79cd13be357-93bb79fdb62mr316181785a.51.1789554585037; Wed, 16 Sep 2026 03:29:45 -0700 (PDT) Received: from [127.0.1.1] ([86.121.170.232]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-49e83dbb0c1sm71633805e9.14.2026.09.16.03.29.43 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 16 Sep 2026 03:29:44 -0700 (PDT) From: Abel Vesa Date: Wed, 16 Sep 2026 13:28:31 +0300 Subject: [PATCH 15/48] clk: qcom: dispcc1-sa8775p: Use common probe handling for always-on clocks Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20260916-clk-qcom-rework-legacy-always-on-clocks-v1-15-25a24e50f82a@oss.qualcomm.com> References: <20260916-clk-qcom-rework-legacy-always-on-clocks-v1-0-25a24e50f82a@oss.qualcomm.com> In-Reply-To: <20260916-clk-qcom-rework-legacy-always-on-clocks-v1-0-25a24e50f82a@oss.qualcomm.com> To: Bjorn Andersson , Abel Vesa , Stephen Boyd , Brian Masney , Jerome Brunet Cc: linux-arm-msm@vger.kernel.org, linux-clk@vger.kernel.org, linux-kernel@vger.kernel.org, Abel Vesa X-Mailer: b4 0.16-dev-0e65f X-Developer-Signature: v=1; a=openpgp-sha256; l=1924; i=abel.vesa@oss.qualcomm.com; h=from:subject:message-id; bh=S2AniEfyDrGOAXCv/dbv4sqVV3IlT7BHWm8yR6GgpKw=; b=owEBbQKS/ZANAwAKARtfRMkAlRVWAcsmYgBqqm9ZFTumNHO12xEU2gdf5L9bzh9pA5N2LD6Fg 55K78eEUg+JAjMEAAEKAB0WIQRO8+4RTnqPKsqn0bgbX0TJAJUVVgUCaqpvWQAKCRAbX0TJAJUV Vi8UD/9gmXI+u6/2q4wDrxT93woOSSnX+zMWRU9xM1T3dGVn7MPTeKtWKxWQza0WT15vyflJPoC zcdVH4RW2fA313qUJxwa6cc/DDF7dmBwCikIT/kCdN8ys5OQYQzrnwQyNY3X/PjnNXQ3AKUH/wN 50AGAY4R/SK2QWn6tFT3HC831yq3PZuixZIY3kvcHVyRj736iQ/GXXymmcf2b1ag04t7MXIrYjh OaZkhrWfBDtD8uhbWMXBydiXY/DiLmCSrs6yFFUvBT1Uxj6bKoSRYEVhp9gfsUhC8Yk6dKTmqIY b68hZOb1Z4RtRXgV5GwNwfX8dLUb1pWYQf2e+g2t2KsQZ94TUBOwqY6/Ps6PWHTCmJ8Fwcostcm iRyHHDJ/Xdhs4eKi0iNIDNQd8nPZUv8i46TYvxPHuZK+k0SH+440+5C/kIA6esLClXzmFC5xsxg 6Z5dJTHPCO/11j9FVPZpktzVFJViDnhQrF2N2gd6WJYk7queV3aCWpusknKQ5+dOdBKFFlBtN9o NDBrYk+ovMX+clYtg7ecDiVIRCSjXEsDiQtHW39zmH8ULykYLSP4vXO07pyxAnZyb3+BCYaUIeP 3z1d0jaCKFIB5A3hn1Zzaz0G70P0eewZexy8SFmoAJLfvaLNYNnwILvQpXDcTVPWbc/JzXwkF8k 8S7PVLk0FMVn9JQ== X-Developer-Key: i=abel.vesa@oss.qualcomm.com; a=openpgp; fpr=6AFF162D57F4223A8770EF5AF7BF214136F41FAE X-Proofpoint-Spam-Info: AW1haW4tMjYwOTE2MDEzNyBTYWx0ZWRfX0G6tAInzwFau YyYgwRot8dUW4R/3xk68prw7TCDmwqkgvnLfOMicXL8X9wp095H9j3QIPWGxJ7tyjT8gdwQ8DRK FNY8mYlUPtP8Tm0OwrhOLIFE9JwVzuA= X-Authority-Analysis: v=2.4 cv=PsIG/AM3 c=1 sm=1 tr=0 ts=6aaa6f9a cx=c_pps a=qKBjSQ1v91RyAK45QCPf5w==:117 a=po8fGBi+ks8MzcVQGuqtFQ==:17 a=IkcTkHD0fZMA:10 a=VdqzKS8jKosA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=gowsoOTTUOVcmtlkKump:22 a=EUspDBNiAAAA:8 a=xG6gKK67fXx6DpdPwiUA:9 a=QEXdDO2ut3YA:10 a=NFOGd7dJGGMPyQGDc5-O:22 X-Proofpoint-ORIG-GUID: lq-_potyblIjMkkdnh2_ckBw2iZgCqGm X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwOTE2MDEzNyBTYWx0ZWRfX//haoQAy5IZr OPT8dpeiaAe60D1tovuwrm+7Ify1vNLAQrNQt7ybClBnicTQCmveGQ8NF6F5dbcFXPPYLqCT84I Qw6HvEcvejbltXHPnGZBgc7Fe+hDKUx6am7LuJSg7+wM5KLdp9ufT9E3OcpidsiHOcWMrcliqv3 oL9InDcRXMJdXFjgvbEheNY4kTkKJBRyCXaKASKXVAZbd+fDX2c5nB/SGBWwPv978jIwKEEXT4G M7bALMJfg/LZVXsB1PXlbpoF7n61sxoMGK2QJ0qeq0jpXjz4NMFcnGaEspaOEk6iBmj2/ZXvTt0 hIHvFhWgMycKV+1hwCBO6LFb9Hl4hgYEcuiCpf+ueCG7Omkc8Y9yw+LNIesHT6hNpzZQd0hdHF2 KYjOW8Z/uUuBdwbuy+q4J/so9UgtUblovcNoBuxWwn+9hMiI/mHxklkXGVZGdKBSs2FkFPsid3J 1yYJxrQFs8m36zEgyjg== X-Proofpoint-GUID: lq-_potyblIjMkkdnh2_ckBw2iZgCqGm X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1176,Hydra:6.1.134,FMLib:17.12.100.49 definitions=2026-09-15_05,2026-09-15_02,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 impostorscore=0 lowpriorityscore=0 adultscore=0 priorityscore=1501 phishscore=0 spamscore=0 clxscore=1015 suspectscore=0 bulkscore=0 malwarescore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2609040000 definitions=main-2609160137 Describe the always-on branches in a critical_cbcrs array and reference it through qcom_cc_driver_data. Let qcom_cc_really_probe() enable these branches instead of programming them directly in the driver's probe. Assisted-by: LLM Signed-off-by: Abel Vesa Reviewed-by: Konrad Dybcio --- drivers/clk/qcom/dispcc1-sa8775p.c | 15 +++++++++++---- 1 file changed, 11 insertions(+), 4 deletions(-) diff --git a/drivers/clk/qcom/dispcc1-sa8775p.c b/drivers/clk/qcom/dispcc1-= sa8775p.c index 58008c1afc76..330d953b5e9e 100644 --- a/drivers/clk/qcom/dispcc1-sa8775p.c +++ b/drivers/clk/qcom/dispcc1-sa8775p.c @@ -1414,7 +1414,18 @@ static const struct regmap_config disp_cc_1_sa8775p_= regmap_config =3D { .fast_io =3D true, }; =20 +static const u32 disp_cc_1_sa8775p_critical_cbcrs[] =3D { + 0xc070, /* MDSS_1_DISP_CC_SLEEP_CLK */ + 0xc054, /* MDSS_1_DISP_CC_XO_CLK */ +}; + +static const struct qcom_cc_driver_data disp_cc_1_sa8775p_driver_data =3D { + .clk_cbcrs =3D disp_cc_1_sa8775p_critical_cbcrs, + .num_clk_cbcrs =3D ARRAY_SIZE(disp_cc_1_sa8775p_critical_cbcrs), +}; + static const struct qcom_cc_desc disp_cc_1_sa8775p_desc =3D { + .driver_data =3D &disp_cc_1_sa8775p_driver_data, .config =3D &disp_cc_1_sa8775p_regmap_config, .clks =3D disp_cc_1_sa8775p_clocks, .num_clks =3D ARRAY_SIZE(disp_cc_1_sa8775p_clocks), @@ -1452,10 +1463,6 @@ static int disp_cc_1_sa8775p_probe(struct platform_d= evice *pdev) clk_lucid_evo_pll_configure(&mdss_1_disp_cc_pll0, regmap, &mdss_1_disp_cc= _pll0_config); clk_lucid_evo_pll_configure(&mdss_1_disp_cc_pll1, regmap, &mdss_1_disp_cc= _pll1_config); =20 - /* Keep some clocks always enabled */ - qcom_branch_set_clk_en(regmap, 0xc070); /* MDSS_1_DISP_CC_SLEEP_CLK */ - qcom_branch_set_clk_en(regmap, 0xc054); /* MDSS_1_DISP_CC_XO_CLK */ - ret =3D qcom_cc_really_probe(&pdev->dev, &disp_cc_1_sa8775p_desc, regmap); =20 pm_runtime_put(&pdev->dev); --=20 2.54.0 From nobody Fri Sep 25 05:31:34 2026 Received: from mx0b-0031df01.pphosted.com (mx0b-0031df01.pphosted.com [205.220.180.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 73DBD4AF665 for ; Wed, 16 Sep 2026 10:29:52 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.180.131 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1789554634; cv=none; b=sm7zJo5Q5XFzxQ/2OPn1efcxY6eqrL2cdSwBoaFXpWmGmI8dKElDr9fjIb/264lqaWpwMGiVEEX4DnGu5tfQH91/eWrNy1sz3Xu0FuI26Aycl32inJzIEG5SvzHZ/41VYqzf+9BVKs3Fw+IP0kuCxVCVkEgjLpywBACsyuoKxaA= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1789554634; c=relaxed/simple; bh=ddwGgK1AMwuuaPXS1Js+aJ7kjNcNYNkRp12TPyDDed8=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=OFOFpNn2Txl9sTT8mXlrxhAS7pyIAwRO84seuJFKcXIX4lBoqrg/pbXUJ7oY4mUwR8RhC9G4nUC1umO91ihMUiUC9tLbpcJZUbrgpZkoVny+rotKnutrhVK1jEKZEaW8jBAGYJmGOJGoqp6GxyJN8AgCdcQ2GaPSL9hHefaL2kI= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=KqyqjPhZ; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=eW9fyqFu; arc=none smtp.client-ip=205.220.180.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="KqyqjPhZ"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="eW9fyqFu" Received: from pps.filterd (m0279872.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 68G932TM1587174 for ; Wed, 16 Sep 2026 10:29:49 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= dupVxO3Ux2B86utZCu4T9d1OT1Nghpc2qj/E1glcAGg=; b=KqyqjPhZZjh0mlbb bADULDENYTZgu6euVC2jspX0xt2E32wEKfoWP4TeQv8Sv4D7DYdM50fKGislg07o K4orAheEJAD3AW10vZE5YIHepdeFYAFw744sNW9xRy13y9NBcHtnza/Y0/OHllXa 4hkEJBz3Mi9kjsZghDZfVJrygFDeJAR1TAjRQHLObvCWQT5Q/+MfaJeeybf4sZ1p 0QmS037GYXWG9VkBe9P6EVBBErvuYDx0jAjUeOFr9Lmle6pXRZhApcH4bF++nZti s5qZ8hY5C32u6dHst+nMPmM77ANrdZM2hYoPPl0npJQhpRnxPY1mXQVFjFbLSXre ZOWSYA== Received: from mail-qk1-f199.google.com (mail-qk1-f199.google.com [209.85.222.199]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4gqagekscr-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Wed, 16 Sep 2026 10:29:48 +0000 (GMT) Received: by mail-qk1-f199.google.com with SMTP id af79cd13be357-93a0050a554so1095114585a.1 for ; Wed, 16 Sep 2026 03:29:48 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1789554588; x=1790159388; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :content-type:mime-version:subject:date:from:from:to:cc:subject:date :message-id:reply-to:content-type; bh=dupVxO3Ux2B86utZCu4T9d1OT1Nghpc2qj/E1glcAGg=; b=eW9fyqFuICzrRVYdmJZwyHLOs6HswWz+uik+FyU+3iLcUVkx5R+2cz7Jxy601Mj8h6 QEFS/0YWFcO7+BpdZTMjGoI16EpqMoemIWDhO6ajyplf/fNb5yZI4VTwExkr0ohLlxv5 qnhZwsUnXZfficKURjT9+Wq26eR7W3e4S/FYvTeWIFWLd9c/q4Wi0LDMv1blsbBAlL9Y w2K6ap/A/OIfoBcPdJt9ybAGAi0XUHb28pgPFpRmq3xg6UK1lijIqaIy1cZaIKwRXk5z K3DkcWmOZFKUsv6z6jdtX2rIgdhm3l6jYicBKaQyMy6nyZeWlM03xCR/LvcESzwBSb4x QJuA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20260707; t=1789554588; x=1790159388; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :content-type:mime-version:subject:date:from:x-gm-gg :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to :content-type; bh=dupVxO3Ux2B86utZCu4T9d1OT1Nghpc2qj/E1glcAGg=; b=detavIoN+7JUt/PG+u3Ij7wDXV6O5m5MQcpK9WcgL06QMznqoDIO+pwsU6WvpYeTJJ Ky6RuGxTe6fYlNe0IR70kGM3rfM8QFblPNUz+NmLT0qAqux1Qh9OpGR1WlZyoZH1urDD ZpbCv1FnYaWSll5nzo4MSEtKdqieAv/Ko1DYlN0IVCA5Q66m0ICPhG8eFB74Fs9LiEVy 09Wo2ZoXohnN7GIMV21liyTz0BvcxbmCerS34Fc8fCUiDvDJoXyTHssy4IFnDlCY/S+z barb7+9R7oF9F/rOjvwONpAegv54IFtwBIbEORDU5UfxO+oe+rOFQ/tbq21K0X7fr/SY y95w== X-Forwarded-Encrypted: i=1; AKwUvByLxeUv2M0Hr43x8HStlsf8UYSS+3eb3my0xzL98Dwj1DS7dTgvzxpzbzs9m4j3QwBlrci79KRkHdZfZvM=@vger.kernel.org X-Gm-Message-State: AFuF++m+0FvFe19PVspe2CXbiiVxiJG4ouPnrQd/+7DFE3qGONNlGFgN ODONIPau0Hb21qkizvxlvmpNtrkfRW+DNNux5VfkWm3mOQRYVpF531yawCHhlqHGRRyABvw2CWi FVFKz/N/PNRVbP4+tBjcfJfR3Tc1EdIeg1oBwKenEzoD6g6sHkMkeniA5UsQvW7Daf/c= X-Gm-Gg: AYBFou29V0M43pPinXbQQfzZYEZwlLLFI+2p9ACGtuyxBnEdMdx7Dt9M//xTz9hdOs/ GKIoSe1qQX2KlsE7VRoqhe6/dXeD/AHIlAPOEnbskidgmMT5Cx7WaYXFkXm6QXhpRaTMUKif+LK 4HU4Z0vSq/c5+ZAGHMHeRApkWypitL7MQGIl6ref2dZVhku0nkJCWIRQBpavAVYpY7ERGMHQO9M QYeRjPAL3d+KBdp96T5VhhryB3kdCSLK/ulGaiejPQaecOKTRLkYc6wOUnq3cBT7LZN79Kyx6MK 16rabeSnb+6tsNjIuas6UJ39LW3iNcyZu8XeOXvGraacnf/5T2vI/qp3hfTxEjYYRb/w9qs5Tla uQpH743M= X-Received: by 2002:a05:620a:4454:b0:915:9e84:85d1 with SMTP id af79cd13be357-93bb77923aemr312952185a.23.1789554587721; Wed, 16 Sep 2026 03:29:47 -0700 (PDT) X-Received: by 2002:a05:620a:4454:b0:915:9e84:85d1 with SMTP id af79cd13be357-93bb77923aemr312948485a.23.1789554587157; Wed, 16 Sep 2026 03:29:47 -0700 (PDT) Received: from [127.0.1.1] ([86.121.170.232]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-49e83dbb0c1sm71633805e9.14.2026.09.16.03.29.45 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 16 Sep 2026 03:29:46 -0700 (PDT) From: Abel Vesa Date: Wed, 16 Sep 2026 13:28:32 +0300 Subject: [PATCH 16/48] clk: qcom: gcc-qcs615: Use common clock controller probe data Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20260916-clk-qcom-rework-legacy-always-on-clocks-v1-16-25a24e50f82a@oss.qualcomm.com> References: <20260916-clk-qcom-rework-legacy-always-on-clocks-v1-0-25a24e50f82a@oss.qualcomm.com> In-Reply-To: <20260916-clk-qcom-rework-legacy-always-on-clocks-v1-0-25a24e50f82a@oss.qualcomm.com> To: Bjorn Andersson , Abel Vesa , Stephen Boyd , Brian Masney , Jerome Brunet Cc: linux-arm-msm@vger.kernel.org, linux-clk@vger.kernel.org, linux-kernel@vger.kernel.org, Abel Vesa X-Mailer: b4 0.16-dev-0e65f X-Developer-Signature: v=1; a=openpgp-sha256; l=3380; i=abel.vesa@oss.qualcomm.com; h=from:subject:message-id; bh=ddwGgK1AMwuuaPXS1Js+aJ7kjNcNYNkRp12TPyDDed8=; b=owEBbQKS/ZANAwAKARtfRMkAlRVWAcsmYgBqqm9aKhONHX31O23uGGxdRRlQf91bz16l/KO4V ZmrcgTtu+KJAjMEAAEKAB0WIQRO8+4RTnqPKsqn0bgbX0TJAJUVVgUCaqpvWgAKCRAbX0TJAJUV VvAAD/sFTyYpgugbf8SNNzY4b9ebMV0GNcmbX54SIK+ZzrV2NyigBIdDqk5tWo61SHqdqxvEn/a CtnXT1FFuMLENE0Efz3U3fDinTpLSUrFt9N6zmOXe/95cFA8gnlIVls0hajnYZAWuWzv90WvHQ4 UMs/u12MLQZ/9Sz256zjHOJgwdQsHQXbgaF4Pa0LM1KNJuPFmzqNQTPqukzYvpcrNFRnJB4l8DE RhI2bjzl9cHP4zERsQ130jFO8wrpVknxKnWd5UxQdiNYH6DHUVHE3n1f0nz4CU09/hfTzSh/pHU GQYAxtFEzFUxwCgp33CAXj+YMRKD3DfI1omyUTZnO3BPTu9GEe14HStLrhYNlEjSMW8rjepE9Ur Gqltc8o4cgVNxTD3zDFFQZBzyUw9rdoCdjEyA+do4lMDrUTIoppNbdIAjrSGyeYrtaLOwFFWP2o pGkpTTwTplRClA40cDIFKeG0nAMGnJ7vphQA9JgLB4f7RXp1ilw3NDG5rCZAfogdXO8mqj5SZhU /9Yu/gLWeIWW1Xig9KBboZm955/2W+8UZKn7RCLy0CA6X/aSK6T3ox50JwThYlKAsOeUXUszXWI HEAx71pZqBtzvEniqR/SVO3hmtL+pAiLJXxUT5Gb5mNM/BpLUR3EUp9Mh1s0WQePktGIhrOe6aI Hg+PhqfSwannLKQ== X-Developer-Key: i=abel.vesa@oss.qualcomm.com; a=openpgp; fpr=6AFF162D57F4223A8770EF5AF7BF214136F41FAE X-Proofpoint-Spam-Info: AW1haW4tMjYwOTE2MDEzNyBTYWx0ZWRfX0n3u7kinTaUr Qd/2iH17QAOdMJwI3fWKedw/vvxZ8kO9/Pw9ho5LxFAPN5mFmRkEUmRVPubGLZ0/UkuZUfTRy82 W/DI42l1bAMa8EoUkcrkkjQvcUC7+Bs= X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwOTE2MDEzNyBTYWx0ZWRfX3xlHPIrMHtpR BMrHXAfYIzBVFaMhbuvMfendS5R2JkbazAoyNQyUH0A8iZGn7o/gBIVsLy1qX8sMCYIlnhrHAmV vPWrtWYImFLCk5AlKCA76GnnwWmVJHiGN7zuzcZTLTfhewuY1RRZilossVfZavY4duWHmWdAXdK 2xd9m6fpdh2fXfnbh/3iuxPEajNgUc2hi/P8OkIJMRyCgF/uCm8RwHdo/lhTQd/ORo1BSkh76Su CIHR9J4RzoD01OIZkQIV0y7Ljf2iMkOBTrGpZhjxykjPuqKT6f12pgMYSSZCpJgN9/MrlV4Sd+i MYTiFkf4fOuo8XfjIXqEsumbn+ZjH/C5UKk40kG7Uu6B1pld3bjiq60LFWb7/ptvHmeM9cEhR6t YAcZnwqKhMcvvo8VeV5UnxKGzrfusrZujJiWA0OLomv82Qv3ElNw0u4uteG2BuR0r0U9r2gMS/V aJv5eApzBG3OgdpXLDw== X-Proofpoint-GUID: JjLxVE-6sEIzJdaaNQ_mOoZ6e5s-BCqV X-Proofpoint-ORIG-GUID: JjLxVE-6sEIzJdaaNQ_mOoZ6e5s-BCqV X-Authority-Analysis: v=2.4 cv=PcZqFShd c=1 sm=1 tr=0 ts=6aaa6f9c cx=c_pps a=HLyN3IcIa5EE8TELMZ618Q==:117 a=po8fGBi+ks8MzcVQGuqtFQ==:17 a=IkcTkHD0fZMA:10 a=VdqzKS8jKosA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=yx91gb_oNiZeI1HMLzn7:22 a=EUspDBNiAAAA:8 a=RW22A4phRzxp-fsVvwcA:9 a=QEXdDO2ut3YA:10 a=bTQJ7kPSJx9SKPbeHEYW:22 X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1176,Hydra:6.1.134,FMLib:17.12.100.49 definitions=2026-09-15_05,2026-09-15_02,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 spamscore=0 phishscore=0 suspectscore=0 malwarescore=0 impostorscore=0 clxscore=1015 lowpriorityscore=0 priorityscore=1501 adultscore=0 bulkscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2609040000 definitions=main-2609160137 Move the always-on branch register offsets into a critical_cbcrs array, describe the DFS RCGs through qcom_cc_driver_data and move the register programming into the clk_regs_configure callback. Use qcom_cc_probe() to perform the common initialization instead of open-coding it in the driver's probe. Assisted-by: LLM Signed-off-by: Abel Vesa Reviewed-by: Konrad Dybcio --- drivers/clk/qcom/gcc-qcs615.c | 57 +++++++++++++++++++++------------------= ---- 1 file changed, 28 insertions(+), 29 deletions(-) diff --git a/drivers/clk/qcom/gcc-qcs615.c b/drivers/clk/qcom/gcc-qcs615.c index 1a6a1e74e805..eda699883cf9 100644 --- a/drivers/clk/qcom/gcc-qcs615.c +++ b/drivers/clk/qcom/gcc-qcs615.c @@ -2958,7 +2958,34 @@ static const struct regmap_config gcc_qcs615_regmap_= config =3D { .fast_io =3D true, }; =20 +static const u32 gcc_qcs615_critical_cbcrs[] =3D { + 0xb008, /* GCC_CAMERA_AHB_CLK */ + 0xb044, /* GCC_CAMERA_XO_CLK */ + 0xb00c, /* GCC_DISP_AHB_CLK */ + 0xb048, /* GCC_DISP_XO_CLK */ + 0x71004, /* GCC_GPU_CFG_AHB_CLK */ + 0xb004, /* GCC_VIDEO_AHB_CLK */ + 0xb040, /* GCC_VIDEO_XO_CLK */ + 0x48004, /* GCC_CPUSS_GNOC_CLK */ +}; + +static void gcc_qcs615_regs_configure(struct device *dev, struct regmap *r= egmap) +{ + /* Disable the GPLL0 active input to MM blocks and GPU via MISC registers= . */ + regmap_update_bits(regmap, 0x0b084, BIT(0), BIT(0)); + regmap_update_bits(regmap, 0x9b000, BIT(0), BIT(0)); +} + +static const struct qcom_cc_driver_data gcc_qcs615_driver_data =3D { + .clk_cbcrs =3D gcc_qcs615_critical_cbcrs, + .num_clk_cbcrs =3D ARRAY_SIZE(gcc_qcs615_critical_cbcrs), + .dfs_rcgs =3D gcc_dfs_clocks, + .num_dfs_rcgs =3D ARRAY_SIZE(gcc_dfs_clocks), + .clk_regs_configure =3D gcc_qcs615_regs_configure, +}; + static const struct qcom_cc_desc gcc_qcs615_desc =3D { + .driver_data =3D &gcc_qcs615_driver_data, .config =3D &gcc_qcs615_regmap_config, .clk_hws =3D gcc_qcs615_hws, .num_clk_hws =3D ARRAY_SIZE(gcc_qcs615_hws), @@ -2978,35 +3005,7 @@ MODULE_DEVICE_TABLE(of, gcc_qcs615_match_table); =20 static int gcc_qcs615_probe(struct platform_device *pdev) { - struct regmap *regmap; - int ret; - - regmap =3D qcom_cc_map(pdev, &gcc_qcs615_desc); - if (IS_ERR(regmap)) - return PTR_ERR(regmap); - /* - * Disable the GPLL0 active input to MM blocks and GPU - * via MISC registers. - */ - regmap_update_bits(regmap, 0x0b084, BIT(0), BIT(0)); - regmap_update_bits(regmap, 0x9b000, BIT(0), BIT(0)); - - /* Keep some clocks always enabled */ - qcom_branch_set_clk_en(regmap, 0xb008); /* GCC_CAMERA_AHB_CLK */ - qcom_branch_set_clk_en(regmap, 0xb044); /* GCC_CAMERA_XO_CLK */ - qcom_branch_set_clk_en(regmap, 0xb00c); /* GCC_DISP_AHB_CLK */ - qcom_branch_set_clk_en(regmap, 0xb048); /* GCC_DISP_XO_CLK */ - qcom_branch_set_clk_en(regmap, 0x71004); /* GCC_GPU_CFG_AHB_CLK */ - qcom_branch_set_clk_en(regmap, 0xb004); /* GCC_VIDEO_AHB_CLK */ - qcom_branch_set_clk_en(regmap, 0xb040); /* GCC_VIDEO_XO_CLK */ - qcom_branch_set_clk_en(regmap, 0x48004); /* GCC_CPUSS_GNOC_CLK */ - - ret =3D qcom_cc_register_rcg_dfs(regmap, gcc_dfs_clocks, - ARRAY_SIZE(gcc_dfs_clocks)); - if (ret) - return ret; - - return qcom_cc_really_probe(&pdev->dev, &gcc_qcs615_desc, regmap); + return qcom_cc_probe(pdev, &gcc_qcs615_desc); } =20 static struct platform_driver gcc_qcs615_driver =3D { --=20 2.54.0 From nobody Fri Sep 25 05:31:34 2026 Received: from mx0b-0031df01.pphosted.com (mx0b-0031df01.pphosted.com [205.220.180.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 1BB584A8A16 for ; Wed, 16 Sep 2026 10:29:52 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.180.131 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1789554634; cv=none; b=A3d1kkI+agU3jXgZe6B3WVaWLFHTPA7N2NfSyNKgFU9tz4AztJ3/9bZTf4Ev73XmR3izP0wdTJWJVyCdYAacL2k/6hT2fE1v1h058e07T8h7Eq+zDo4/7bwYyt5km7BparHGiinxZEj+o3anrFahBwbzMwdLIl3jLcGPJepAa+g= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1789554634; c=relaxed/simple; bh=iXUNYaH4A1wy07zs/nnJgB8Uf+MSyhMYIfjrKnWdaUg=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=UEVkrqc0evQsmjePEwPOUKhslmIaygmEVM8x4/cnMi2ETjSjGueDBsKbHI3VLzgpMPszPvgOrBv8QU7DmTE4Hd6ijOtLsuLu3mWtCs7vYEpupkkSQiYT0IAvirietiT09GpDGrD6CTGoqjQuQnXXGC1QXzY46bjgLYl8qR72RMY= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=eE1YX2FG; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=kun6Tk+/; arc=none smtp.client-ip=205.220.180.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="eE1YX2FG"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="kun6Tk+/" Received: from pps.filterd (m0279869.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 68G93AMc2658311 for ; Wed, 16 Sep 2026 10:29:50 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= gTctgnsk+7+DKp13Yn5I3XzOkNFK4BQpKT9A6LCQGQE=; b=eE1YX2FGLQEW+594 yxtfQMNy274bTYynCJODx9VnptHd4/PkGXlWvRhf0KJRVVHQM4pj7uaI3u7KrWml 0V41qNJ4CGNbtiV6o4hTrdFTLBM7MmsXF8OWGU/HpHuDQLcz6oJWLLb8PB6xOFjU grakThKaMnz4NkgCH3Ava5wJnqx6xylghZapsvSneuLAOuVsarJMeJ5gZ+t1pM4J Bn5vnewgcY75PDcJ0qSS5+O+smBIxbZ/vDk4VTdT+QIhE+rAqpV0CR0vc6GivcMO c2trmUcX4my0fWL/cJrZ9mwVk/mSMs2J25uxEGEuu02UCCBfVPpt9//r67ebDX2q ucjYJA== Received: from mail-qk1-f198.google.com (mail-qk1-f198.google.com [209.85.222.198]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4gqftujape-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Wed, 16 Sep 2026 10:29:50 +0000 (GMT) Received: by mail-qk1-f198.google.com with SMTP id af79cd13be357-93a2d361e1aso18771785a.1 for ; Wed, 16 Sep 2026 03:29:50 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1789554589; x=1790159389; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :content-type:mime-version:subject:date:from:from:to:cc:subject:date :message-id:reply-to:content-type; bh=gTctgnsk+7+DKp13Yn5I3XzOkNFK4BQpKT9A6LCQGQE=; b=kun6Tk+//vWtZQvObDFhYs0AqJfHVNfdq3gn2eoNaClALZp8xVP5LDpQfGUq5+3G1g uiggELYVYKa/EEC+gSDA7pXv7uU6b8lfFCO8fqqBrg1HLjagdI6XOB8uTCO5h4I4+BBC So0wegoF2PvjObACwjkD5aBSJXqcCBEsn65htqAE1A7OgdPSAdr2ht6Gy9n+/X7/Io/n bQpLYRf+7qGMfIldx2dXjwP02ClEPWauQrXkw72DyBcYnqJxJPApW7C/gX3gqm828x6I FadyGARPt0etiQr6AyrR5qITBFVtBIYYGDvr+GKiNCPfKj1kf9fU8uJz0StiATB3o9OJ L67g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20260707; t=1789554589; x=1790159389; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :content-type:mime-version:subject:date:from:x-gm-gg :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to :content-type; bh=gTctgnsk+7+DKp13Yn5I3XzOkNFK4BQpKT9A6LCQGQE=; b=ag2yCLUqiemQnOJyQBLYV8FE/7VPtLRzfY1iUwER8d60AWrsN8+ZC+MGDQ8QAX+l7A FQGDraIM5vGeqBe1OIxXj7a0h8ihv7KeQW2/d4jqerXRgvplQZzYaoJjQuqVfu+eSEvm 41UBO31rVksxloxj4FYUlTNDgNdjCe+GG3Pw3DXkSjMSOnPhVhtAycD4euV5VySIXUW4 QpDmfJXJVKNm9zobgpswYgpeC9difBi3oS7KmSPEgisEGGA+EnW1D0QGV/Z1VCj7Isyw PpWgnWk8GgMUHH3w/Qk2dB3ny9ks+LyYWiayK8cs5ps8Tqq0AvSHaTBru5T4dzHYrVFz fD3A== X-Forwarded-Encrypted: i=1; AKwUvBxXgRsJgUmLxN3QCoKI0xD+wyX4V43M3vcD7CwfgOoIuIkhfSk2wbnWDmBuIldy+BjpLseUaOi/NxB7fcM=@vger.kernel.org X-Gm-Message-State: AFuF++lm9vi/GjeNABAXGVfxFryHxGc88w0OSMLn8+prT6W6fZuNuppH NLNGcxPf8P1MyEqufV4yMxBkrMzbeI6vZ/f0Zv8v6B4OzTWEiQPwjCS7tm/ZMYpnMjsrTaOXiGi om7YjTBbx4uy/H4DTsvtq5sAbNEmC2rPDZZqvHasO1CVlsm4HKBLl4djGaatIKijVWQw= X-Gm-Gg: AYBFou0oqC/TuVeBJcX3sPaDQIMELA40JLmhqGTJQ3ssxHzzm/+Xaxf+iw9Coiwdgi6 tiFAZ+ecZ5mVmrtzFSkR6XDhMeKT9Xh0j/ol2LrCbpXtJkMsO0eJPsNHtKK/2ffUOqmB3tAo/hG Yifl82g8P0oLVfiA/XGjZZAcsFVSgn8C8EEUhTwTO9XRovG8lrlsADihzw8FRD3aedmUmj2YYnI AZjU54QFoRkxKBilpYAMKN83CxyMURCDl+E/zPiSWFVYKU1WAyCd4M9u6blK1qLL3vEIkEFuIUZ pm7hUndF/3E3SgKGP8uGVhzGrx9x5duyojXStbsqMbhkTMpH8ldoowMwTgNTZHGJYyvMKfJ6+UM wFL/EFfw= X-Received: by 2002:a05:620a:648d:b0:92e:45e4:c6e with SMTP id af79cd13be357-93bb774e0c1mr329148585a.22.1789554589520; Wed, 16 Sep 2026 03:29:49 -0700 (PDT) X-Received: by 2002:a05:620a:648d:b0:92e:45e4:c6e with SMTP id af79cd13be357-93bb774e0c1mr329143985a.22.1789554589028; Wed, 16 Sep 2026 03:29:49 -0700 (PDT) Received: from [127.0.1.1] ([86.121.170.232]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-49e83dbb0c1sm71633805e9.14.2026.09.16.03.29.47 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 16 Sep 2026 03:29:48 -0700 (PDT) From: Abel Vesa Date: Wed, 16 Sep 2026 13:28:33 +0300 Subject: [PATCH 17/48] clk: qcom: gcc-qcs8300: Use common clock controller probe data Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20260916-clk-qcom-rework-legacy-always-on-clocks-v1-17-25a24e50f82a@oss.qualcomm.com> References: <20260916-clk-qcom-rework-legacy-always-on-clocks-v1-0-25a24e50f82a@oss.qualcomm.com> In-Reply-To: <20260916-clk-qcom-rework-legacy-always-on-clocks-v1-0-25a24e50f82a@oss.qualcomm.com> To: Bjorn Andersson , Abel Vesa , Stephen Boyd , Brian Masney , Jerome Brunet Cc: linux-arm-msm@vger.kernel.org, linux-clk@vger.kernel.org, linux-kernel@vger.kernel.org, Abel Vesa X-Mailer: b4 0.16-dev-0e65f X-Developer-Signature: v=1; a=openpgp-sha256; l=3169; i=abel.vesa@oss.qualcomm.com; h=from:subject:message-id; bh=iXUNYaH4A1wy07zs/nnJgB8Uf+MSyhMYIfjrKnWdaUg=; b=owEBbQKS/ZANAwAKARtfRMkAlRVWAcsmYgBqqm9bHdyf1pQUsGFGKbe1NTNuuW3GVZnsugBB7 RZUqtuQoSCJAjMEAAEKAB0WIQRO8+4RTnqPKsqn0bgbX0TJAJUVVgUCaqpvWwAKCRAbX0TJAJUV VnRFD/9aAyvenpt39gBdAL77al9ea8VCCnd3ONwZM5yjLEym2+QbuiTgYvTjXA8YOfecjxrxkBY /1hQuii2CfuX+PAshuqvOiYyCKVt3kpwvUG5GWmymi2rdHBuZsm+SES1WsGmV/3bzC+cheXt6bd psvfnHAKjct2pg4PfSQpn12iW4oUtBydRdfk4SymVimdcmYXx6mxz9ApdVDyHIsDgV5bjv83DJh VBd4f7/wLQH+vcVpnbfiCQ/UESNmRVwlVrEECvtnWsbDMDCGEXup05HeIp1/oWJzecnqUHe4ayC kw0ZEps6TcoWtKpvONdoEBfNePeO8kcXPh23wBKb/22pzaIjCOycRgEjfBM1g+S7Qn0Uu4Xy3p8 bWbzOW98DgsCrln4CBewz4N8D+zAf2644yaO2Qfo91KiKiJ5RORhjMk0mUSIYojZbvatvaIALz6 uiG40LvQDbYdpg3qATh2tEA/A10SuRP+uh6i6sd+/YPI81Sbdke5XLNqRzTvhr5hPOdqyu6pZP8 30wiI2aCq+uWagX0xpObGZ+mGwUOeILUz119yHn7dv5mddruJC8+WjUbjIucW1oMNaKG3F3CMoM WujGWdQiXYmvcKS2aLrZ2sjcq2ie2A+CClFNf0dqBf7FkrmsubsRIVGkwqVCZdhGPauZxqsCPjq A1Z/BvjKFpjtRsg== X-Developer-Key: i=abel.vesa@oss.qualcomm.com; a=openpgp; fpr=6AFF162D57F4223A8770EF5AF7BF214136F41FAE X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwOTE2MDEzNyBTYWx0ZWRfXylL0wWVIq2ZI 3WTi2I3xkzR7iJf6PI6wtPMmtdjSsDFZvrG/urrKurvZ3myCvNjFUXUGdTpuA2S7kTisPPmZxIP FTFvgDUIsyy0RE1C3dBq5mcRbdzgIfON6xy48LObGah9bCL2mNvbUSdz+KSp+uaM3qLlU1VOGXZ rM9CAOgFK9xzjp44xhOCUlGjYKfs9EgFwZsP8Jgb9Q/HHBiBNBwvYLaxnNBmaRHTG9UrIkPXwyO AY5y3thX0OgVKDLn44Ovro30j4feOW2QsYOlmIj8hZMmK2zvgTm+YQ4vWQuymshGWcsUx6U7BE3 jNfkVKI/913xu3Y7J+3bCgSgxwM1WU7kIz8Y2HmyCTWmb+EwonHD/qwJ6aE8XrX5zQfiFEKbDbJ F5xS57ePfeOKH+stV+oxmJHPYvvoPCGc/zdNSWaHHC5wG4qqCjrVLjIBsgxRQ7O50IhvaXORwPa NUFyelQRXjGJq/swRHw== X-Authority-Analysis: v=2.4 cv=a5ulZkSF c=1 sm=1 tr=0 ts=6aaa6f9e cx=c_pps a=qKBjSQ1v91RyAK45QCPf5w==:117 a=po8fGBi+ks8MzcVQGuqtFQ==:17 a=IkcTkHD0fZMA:10 a=VdqzKS8jKosA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=_glEPmIy2e8OvE2BGh3C:22 a=EUspDBNiAAAA:8 a=RW22A4phRzxp-fsVvwcA:9 a=QEXdDO2ut3YA:10 a=NFOGd7dJGGMPyQGDc5-O:22 X-Proofpoint-Spam-Info: AW1haW4tMjYwOTE2MDEzNyBTYWx0ZWRfX6U18mMtdWSP3 DqJOTpbm/M6FdKfKwixi2rWHfzAVFuRJaKQYUikwo7aGPbzdUw5pxNO1qsr6GpC5qMgg/qcfjI5 fkJLXSgBEyPQZGlNPBf43muNcdQAx14= X-Proofpoint-GUID: RqIUXajlp8RxH-55yNgDyGMhkFdocJ_e X-Proofpoint-ORIG-GUID: RqIUXajlp8RxH-55yNgDyGMhkFdocJ_e X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1176,Hydra:6.1.134,FMLib:17.12.100.49 definitions=2026-09-15_05,2026-09-15_02,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 suspectscore=0 spamscore=0 clxscore=1015 priorityscore=1501 adultscore=0 impostorscore=0 malwarescore=0 lowpriorityscore=0 phishscore=0 bulkscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2609040000 definitions=main-2609160137 Move the always-on branch register offsets into a critical_cbcrs array, describe the DFS RCGs through qcom_cc_driver_data and move the register programming into the clk_regs_configure callback. Use qcom_cc_probe() to perform the common initialization instead of open-coding it in the driver's probe. Assisted-by: LLM Signed-off-by: Abel Vesa Reviewed-by: Konrad Dybcio --- drivers/clk/qcom/gcc-qcs8300.c | 51 +++++++++++++++++++++-----------------= ---- 1 file changed, 26 insertions(+), 25 deletions(-) diff --git a/drivers/clk/qcom/gcc-qcs8300.c b/drivers/clk/qcom/gcc-qcs8300.c index 146b3b5dfead..1d2976aedc51 100644 --- a/drivers/clk/qcom/gcc-qcs8300.c +++ b/drivers/clk/qcom/gcc-qcs8300.c @@ -3673,7 +3673,32 @@ static const struct regmap_config gcc_qcs8300_regmap= _config =3D { .fast_io =3D true, }; =20 +static const u32 gcc_qcs8300_critical_cbcrs[] =3D { + 0x32004, /* GCC_CAMERA_AHB_CLK */ + 0x32020, /* GCC_CAMERA_XO_CLK */ + 0x33004, /* GCC_DISP_AHB_CLK */ + 0x33018, /* GCC_DISP_XO_CLK */ + 0x7d004, /* GCC_GPU_CFG_AHB_CLK */ + 0x34004, /* GCC_VIDEO_AHB_CLK */ + 0x34024, /* GCC_VIDEO_XO_CLK */ +}; + +static void gcc_qcs8300_regs_configure(struct device *dev, struct regmap *= regmap) +{ + /* FORCE_MEM_CORE_ON for ufs phy ice core clocks */ + qcom_branch_set_force_mem_core(regmap, gcc_ufs_phy_ice_core_clk, true); +} + +static const struct qcom_cc_driver_data gcc_qcs8300_driver_data =3D { + .clk_cbcrs =3D gcc_qcs8300_critical_cbcrs, + .num_clk_cbcrs =3D ARRAY_SIZE(gcc_qcs8300_critical_cbcrs), + .dfs_rcgs =3D gcc_dfs_clocks, + .num_dfs_rcgs =3D ARRAY_SIZE(gcc_dfs_clocks), + .clk_regs_configure =3D gcc_qcs8300_regs_configure, +}; + static const struct qcom_cc_desc gcc_qcs8300_desc =3D { + .driver_data =3D &gcc_qcs8300_driver_data, .config =3D &gcc_qcs8300_regmap_config, .clks =3D gcc_qcs8300_clocks, .num_clks =3D ARRAY_SIZE(gcc_qcs8300_clocks), @@ -3691,31 +3716,7 @@ MODULE_DEVICE_TABLE(of, gcc_qcs8300_match_table); =20 static int gcc_qcs8300_probe(struct platform_device *pdev) { - struct regmap *regmap; - int ret; - - regmap =3D qcom_cc_map(pdev, &gcc_qcs8300_desc); - if (IS_ERR(regmap)) - return PTR_ERR(regmap); - - ret =3D qcom_cc_register_rcg_dfs(regmap, gcc_dfs_clocks, - ARRAY_SIZE(gcc_dfs_clocks)); - if (ret) - return ret; - - /* Keep some clocks always enabled */ - qcom_branch_set_clk_en(regmap, 0x32004); /* GCC_CAMERA_AHB_CLK */ - qcom_branch_set_clk_en(regmap, 0x32020); /* GCC_CAMERA_XO_CLK */ - qcom_branch_set_clk_en(regmap, 0x33004); /* GCC_DISP_AHB_CLK */ - qcom_branch_set_clk_en(regmap, 0x33018); /* GCC_DISP_XO_CLK */ - qcom_branch_set_clk_en(regmap, 0x7d004); /* GCC_GPU_CFG_AHB_CLK */ - qcom_branch_set_clk_en(regmap, 0x34004); /* GCC_VIDEO_AHB_CLK */ - qcom_branch_set_clk_en(regmap, 0x34024); /* GCC_VIDEO_XO_CLK */ - - /* FORCE_MEM_CORE_ON for ufs phy ice core clocks */ - qcom_branch_set_force_mem_core(regmap, gcc_ufs_phy_ice_core_clk, true); - - return qcom_cc_really_probe(&pdev->dev, &gcc_qcs8300_desc, regmap); + return qcom_cc_probe(pdev, &gcc_qcs8300_desc); } =20 static struct platform_driver gcc_qcs8300_driver =3D { --=20 2.54.0 From nobody Fri Sep 25 05:31:34 2026 Received: from mx0b-0031df01.pphosted.com (mx0b-0031df01.pphosted.com [205.220.180.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id DB9F64EBAF4 for ; Wed, 16 Sep 2026 10:29:54 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.180.131 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1789554616; cv=none; b=CxBgOtAdbgQBqcxrPcfBEfxq4hbs0Ma0EHSuo8k71Pqzj90pAtMVzQ1URtbLpUCPhAiv/GrlZetc3FEMJLfoI+VINKSrs/3yYRIh+mH+aeI383XT9fBvqGuIseWBepsktOaVn4d11p2sY7gOxVRtraBdWIpZwbB9WqXSN1wmtj4= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1789554616; c=relaxed/simple; bh=tBxDKwK5dVUntUU8aUkyZy/853SQKi6jS2YjGz+1Qrc=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=lOJMv9PeYejgEEMIkSc7Ss/RpeamTy1l5kFZpeAB9pWWVpQ6ZrLPotjSYaNVhCfbo9tAHBYMPK+e2+CcKuQihdUAPXv8lM3q6ccCvM5TcwHhtf3zZXJ+yGw+Vlhu1xF7/cIG9H4E7waZGfYew6xAGwq+ZoIUe8/UXPJS1yq2gtk= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=ADIlGjXI; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=R93TQ0+V; arc=none smtp.client-ip=205.220.180.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="ADIlGjXI"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="R93TQ0+V" Received: from pps.filterd (m0279868.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 68G92lCa2122049 for ; Wed, 16 Sep 2026 10:29:52 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= LANd+7i+Gj5CJwN8EaR5yUOhoSzKJAAhbRaAV10vXpE=; b=ADIlGjXI1gOPFzKE Xr3N8HdkDkdFcJjg+UOgzbtp17ZaDDkTjj4Ca08UmOEkvDhowu59PTcak48tPo+a C/bNc03geewiPRM3Ii8288D0pwtU25Emhwt8rD4h3TrFiixjh24X2+LsjvQYtv9t jkbJUydXznnfNBWea82kSbI/gEt/ejN5vyojNqoJmuDTszb/Bx9sQqQd+hi9sA7L m6BNqa/FXESyFSRXZ6cXkd6N2/w5+SnfwIXz9OplGB1wa4c1BBntUiDDJN6vkRD5 FlGz7OY83rrvexuChA1NMbMawMw13jRMLS87jLlMx6CSQcK/v1phnfnr09BVbhkF pUS0/w== Received: from mail-qk1-f199.google.com (mail-qk1-f199.google.com [209.85.222.199]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4gqkv7hhrq-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Wed, 16 Sep 2026 10:29:52 +0000 (GMT) Received: by mail-qk1-f199.google.com with SMTP id af79cd13be357-939a6937513so845578385a.3 for ; Wed, 16 Sep 2026 03:29:52 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1789554592; x=1790159392; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :content-type:mime-version:subject:date:from:from:to:cc:subject:date :message-id:reply-to:content-type; bh=LANd+7i+Gj5CJwN8EaR5yUOhoSzKJAAhbRaAV10vXpE=; b=R93TQ0+V2Cph0QIFP8I8DUFb+kUnG4Jk5XrfL66KelO5FVNYcfq7zPWLCu4R8Nr6rX Q9u7dzleE2PtwQD6j0T9XyPOtRuJnJfA/zI0k2sqK84JeGhbB3nuoSuJ4ZZAg1xuHXRA iWwUEGE/2Bkgq1bCzKeOarGrqP/bUR+Le7eMvM5E0X1cBYQRxHn1U1Hfgtei3FI3UpMt 7+wu/zvko1l174l6iuaWq+VHnNVD7rnfY5e2LNbpMK9j8A7yT3d2VHF2U0Vc6GbDzrFt a9v2w9806JaHlbIUcBhHY5ddJXGsArvlXTfuCNdjX7p5G/XDXoCe4L5dnTNrDavr624+ zDSA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20260707; t=1789554592; x=1790159392; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :content-type:mime-version:subject:date:from:x-gm-gg :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to :content-type; bh=LANd+7i+Gj5CJwN8EaR5yUOhoSzKJAAhbRaAV10vXpE=; b=LiXWecaoNR88E3IRZ6+LToFuepQDnX+qX4xwLen0LY5aNJ+BmAXkczCfecvbCenyiO xQT6gL2vAq3QSh8NDKuNA+aSGL+by41y+oFfG3H7oLOFzy2ISdK7yUjC2LsnAQ9xkmzF ybycbMlt3LSJG1eCtEz+J++gtGEJTUrv1tm0qnWMd1XtJbCsVeA8Mwvi2YVH91/81d8n cT6kYBh8kSSBSO9lkqie8yhFjnlC23snovTuIB7b09r+38QNxzjKxFk6N3EEpYiltiNt xM7hhp9MkyjUDbH82fw8lkW+2atlmRuZ4i5rweQnnDDadTJR3E92x1z2x+34cVKwnqD5 FX2g== X-Forwarded-Encrypted: i=1; AKwUvBwORgqSPbCul6/u3NQpTqgsClQuUFKGcu0NkMiBd+BU5hCXvk/TXtxp7tHFPZL9G2kIFZ+o1f1I5/o0kB4=@vger.kernel.org X-Gm-Message-State: AFuF++kWrDRIXMLXzKOh/iCPPMWbU1L1PnWmvrjNWdMpKS80uuPtumXm QtXlWYHfAZSVAXN/mR7+sWE1QBF+UQt/YOrONTHuozooAXVhS6c9iolh9W1y1ISAk/XxgTd/Vqa M6N/nQYSyCEJSbfbLXXK9LWmiA4Ia+6kbecspQ8vQ+fkFi1EouuLadWMkg2ATKOFGlzM= X-Gm-Gg: AYBFou0qhUG1LPdGBPLcYvjSfQcA1PTECZiKxAwJyiMoLDc2YjpQKFLt2hH+8dpXONE 6XXFgqY85LkkeHOGiGAtLthTJZIgPIr78E8phJ322V506JociN4n/z7i7PuhqrDIrBgkWqzbJlu gJBDu03Xf8kBAZyLhKGNcU4suyztoR4VCT3sN9bRVAh0KbcVV7XO1Mh8D2xu2lPRhv+2alXlu1/ AGhYduRcm90qehC0Z0pevg/gM8EmpmFSoRcuisBnSohWod6mt0v89g5BcJYHbMDuQXpvee3jPAg 9SbSSrImwkurcDmNqVQqZyk0ZIhLbraOrNNw6K7SAle36R1l5jAey2uRQJouHaV5Tb0utFJc7mg rdsKAQJI= X-Received: by 2002:a05:620a:4381:b0:93a:2d2b:a5db with SMTP id af79cd13be357-93bb793c4a0mr289530785a.45.1789554591447; Wed, 16 Sep 2026 03:29:51 -0700 (PDT) X-Received: by 2002:a05:620a:4381:b0:93a:2d2b:a5db with SMTP id af79cd13be357-93bb793c4a0mr289527385a.45.1789554590916; Wed, 16 Sep 2026 03:29:50 -0700 (PDT) Received: from [127.0.1.1] ([86.121.170.232]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-49e83dbb0c1sm71633805e9.14.2026.09.16.03.29.49 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 16 Sep 2026 03:29:50 -0700 (PDT) From: Abel Vesa Date: Wed, 16 Sep 2026 13:28:34 +0300 Subject: [PATCH 18/48] clk: qcom: gcc-sa8775p: Use common clock controller probe data Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20260916-clk-qcom-rework-legacy-always-on-clocks-v1-18-25a24e50f82a@oss.qualcomm.com> References: <20260916-clk-qcom-rework-legacy-always-on-clocks-v1-0-25a24e50f82a@oss.qualcomm.com> In-Reply-To: <20260916-clk-qcom-rework-legacy-always-on-clocks-v1-0-25a24e50f82a@oss.qualcomm.com> To: Bjorn Andersson , Abel Vesa , Stephen Boyd , Brian Masney , Jerome Brunet Cc: linux-arm-msm@vger.kernel.org, linux-clk@vger.kernel.org, linux-kernel@vger.kernel.org, Abel Vesa X-Mailer: b4 0.16-dev-0e65f X-Developer-Signature: v=1; a=openpgp-sha256; l=3370; i=abel.vesa@oss.qualcomm.com; h=from:subject:message-id; bh=tBxDKwK5dVUntUU8aUkyZy/853SQKi6jS2YjGz+1Qrc=; b=owEBbQKS/ZANAwAKARtfRMkAlRVWAcsmYgBqqm9caxSwSKBXPyws7qZIgUQLuMy8Zrhob5t+e AxSkZ2dnViJAjMEAAEKAB0WIQRO8+4RTnqPKsqn0bgbX0TJAJUVVgUCaqpvXAAKCRAbX0TJAJUV Vld2EACkkm4XLqwVyXNVpzoTPm0m6ZiKYDSxjV7tSCoQ89n+EkcfL7rSndNzp2maK5C+9nq8aVy KSfbkYNabrh9LGjD7YOjPbDHXewEqCRdOOsIHQFdsRsXynUkcll+eOyKa64vliMSldan7eyysbN 9Qm3o2+gnH9p93Qp+NIeIW9EDbW9hbhBjQYMmZVofNEli8bSfG89ewAQPiKLTx5JJZe5TLJet2b GfZ/LZeOPPk1uBviQ35jrv/g2ipSMepQwPkp5B6VdY+4/Hs+8T20rPlWxzj3oVGDWmo1XDIL3CD fUbGrcHBcrCSTChyLV5TXPUw9CNXAtmOZ1iekFtfGeZQAGxYkQ4hXIA7GdHxaLuPdr03ETVOPof JWTEvBlMyRCrh/AQ+mRBi1bJTdZYDGsomAM9wrZwbk1I+BrdYEqlgF09JnczjJ/xJ8F9lOHVJeF 1lMImJdMzsqRpnewNBODwc90hPrcA1nsU1g9ZuiWKkBKN2CLQCTN1DUUDfRerMEq4KHdmQIdhdK 9o8j2w1ydDW6hB2GRxSFt1rEdI8bNBKCJUubvpk7pJuWTXjJlMz3JXsfxtEcM9j2ZrzTWuRpF+K mS5dMW9ud52ZcmDBW0Yvakla8BRYNjiRDAqUmfjXskq7Pd9rYsS+3k4xgyjn0OSsPN+E9vmgkDi 7kRgYxIqtFzuIaw== X-Developer-Key: i=abel.vesa@oss.qualcomm.com; a=openpgp; fpr=6AFF162D57F4223A8770EF5AF7BF214136F41FAE X-Proofpoint-ORIG-GUID: NFDW8PKOEfRiLzU2zuhX00AA_sgMCJb4 X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwOTE2MDEzNyBTYWx0ZWRfX9pLIe88WXhOK 7EMRjwyEWl9Nq4y5jB42336Y4rcf3kz2lUg2/B/2sKlb1nGDWnlM+OyemgAcQijaf18c/stOLv+ jJcV0FmJ15+EYkXnnUgTPfwiY+n9qYb5nVcfrND+ghCQLnVuiNgraUi0weF0B1A2Qh1ywzBoU8k HqZAkV8Kj0ywQDXyGBTutImJyawCg2Oq6vkmOhhJOGSUGZT8XykinY3YtDHdHwxTNxiUVstjUsj MVXlJ5UmPM/D0rXfp0nr70sHyFTotLXYeOyq43K1YC0p+nRmUw6WIbcdrG9Cq+oGgzXcBdnshp5 taERPlL4PUjijkxXRQ5h99ZQ9q6JCocr9/aiVhS7vQShGsxstzogt5+HqWhSzg0SmjGdOcWlnS/ cqDkjxClzwAX4c+GNWZOYGJJqteR5k3pz4oCDVY5zEZUPIa4Y6epGTpmdz4RORxVTkK7L7+m7Lq K906wJulaE94XzAfb1Q== X-Authority-Analysis: v=2.4 cv=eKmGH3p1 c=1 sm=1 tr=0 ts=6aaa6fa0 cx=c_pps a=HLyN3IcIa5EE8TELMZ618Q==:117 a=po8fGBi+ks8MzcVQGuqtFQ==:17 a=IkcTkHD0fZMA:10 a=VdqzKS8jKosA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=ZpdpYltYx_vBUK5n70dp:22 a=EUspDBNiAAAA:8 a=RW22A4phRzxp-fsVvwcA:9 a=QEXdDO2ut3YA:10 a=bTQJ7kPSJx9SKPbeHEYW:22 X-Proofpoint-Spam-Info: AW1haW4tMjYwOTE2MDEzNyBTYWx0ZWRfX7GIxLm89wSEB mDCMo5pRzI4CE9svG1oV7cT4xYiL+d06r0ILYWx2pmUfgsQGiwjPa0gOnhawwfP+9nwhzJAMA7m 06uyRS8vtfidQPj6/ei6B7ZB4i2sEwc= X-Proofpoint-GUID: NFDW8PKOEfRiLzU2zuhX00AA_sgMCJb4 X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1176,Hydra:6.1.134,FMLib:17.12.100.49 definitions=2026-09-15_05,2026-09-15_02,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 impostorscore=0 lowpriorityscore=0 adultscore=0 bulkscore=0 clxscore=1015 phishscore=0 spamscore=0 priorityscore=1501 malwarescore=0 suspectscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2609040000 definitions=main-2609160137 Move the always-on branch register offsets into a critical_cbcrs array, describe the DFS RCGs through qcom_cc_driver_data and move the register programming into the clk_regs_configure callback. Use qcom_cc_probe() to perform the common initialization instead of open-coding it in the driver's probe. Assisted-by: LLM Signed-off-by: Abel Vesa Reviewed-by: Konrad Dybcio --- drivers/clk/qcom/gcc-sa8775p.c | 55 +++++++++++++++++++++-----------------= ---- 1 file changed, 28 insertions(+), 27 deletions(-) diff --git a/drivers/clk/qcom/gcc-sa8775p.c b/drivers/clk/qcom/gcc-sa8775p.c index dca316decd0e..fa31710ef557 100644 --- a/drivers/clk/qcom/gcc-sa8775p.c +++ b/drivers/clk/qcom/gcc-sa8775p.c @@ -4644,7 +4644,34 @@ static const struct regmap_config gcc_sa8775p_regmap= _config =3D { .fast_io =3D true, }; =20 +static const u32 gcc_sa8775p_critical_cbcrs[] =3D { + 0x32004, /* GCC_CAMERA_AHB_CLK */ + 0x32020, /* GCC_CAMERA_XO_CLK */ + 0xc7004, /* GCC_DISP1_AHB_CLK */ + 0xc7018, /* GCC_DISP1_XO_CLK */ + 0x33004, /* GCC_DISP_AHB_CLK */ + 0x33018, /* GCC_DISP_XO_CLK */ + 0x7d004, /* GCC_GPU_CFG_AHB_CLK */ + 0x34004, /* GCC_VIDEO_AHB_CLK */ + 0x34024, /* GCC_VIDEO_XO_CLK */ +}; + +static void gcc_sa8775p_regs_configure(struct device *dev, struct regmap *= regmap) +{ + /* FORCE_MEM_CORE_ON for ufs phy ice core clocks */ + qcom_branch_set_force_mem_core(regmap, gcc_ufs_phy_ice_core_clk, true); +} + +static const struct qcom_cc_driver_data gcc_sa8775p_driver_data =3D { + .clk_cbcrs =3D gcc_sa8775p_critical_cbcrs, + .num_clk_cbcrs =3D ARRAY_SIZE(gcc_sa8775p_critical_cbcrs), + .dfs_rcgs =3D gcc_dfs_clocks, + .num_dfs_rcgs =3D ARRAY_SIZE(gcc_dfs_clocks), + .clk_regs_configure =3D gcc_sa8775p_regs_configure, +}; + static const struct qcom_cc_desc gcc_sa8775p_desc =3D { + .driver_data =3D &gcc_sa8775p_driver_data, .config =3D &gcc_sa8775p_regmap_config, .clks =3D gcc_sa8775p_clocks, .num_clks =3D ARRAY_SIZE(gcc_sa8775p_clocks), @@ -4662,33 +4689,7 @@ MODULE_DEVICE_TABLE(of, gcc_sa8775p_match_table); =20 static int gcc_sa8775p_probe(struct platform_device *pdev) { - struct regmap *regmap; - int ret; - - regmap =3D qcom_cc_map(pdev, &gcc_sa8775p_desc); - if (IS_ERR(regmap)) - return PTR_ERR(regmap); - - ret =3D qcom_cc_register_rcg_dfs(regmap, gcc_dfs_clocks, - ARRAY_SIZE(gcc_dfs_clocks)); - if (ret) - return ret; - - /* Keep some clocks always-on */ - qcom_branch_set_clk_en(regmap, 0x32004); /* GCC_CAMERA_AHB_CLK */ - qcom_branch_set_clk_en(regmap, 0x32020); /* GCC_CAMERA_XO_CLK */ - qcom_branch_set_clk_en(regmap, 0xc7004); /* GCC_DISP1_AHB_CLK */ - qcom_branch_set_clk_en(regmap, 0xc7018); /* GCC_DISP1_XO_CLK */ - qcom_branch_set_clk_en(regmap, 0x33004); /* GCC_DISP_AHB_CLK */ - qcom_branch_set_clk_en(regmap, 0x33018); /* GCC_DISP_XO_CLK */ - qcom_branch_set_clk_en(regmap, 0x7d004); /* GCC_GPU_CFG_AHB_CLK */ - qcom_branch_set_clk_en(regmap, 0x34004); /* GCC_VIDEO_AHB_CLK */ - qcom_branch_set_clk_en(regmap, 0x34024); /* GCC_VIDEO_XO_CLK */ - - /* FORCE_MEM_CORE_ON for ufs phy ice core clocks */ - qcom_branch_set_force_mem_core(regmap, gcc_ufs_phy_ice_core_clk, true); - - return qcom_cc_really_probe(&pdev->dev, &gcc_sa8775p_desc, regmap); + return qcom_cc_probe(pdev, &gcc_sa8775p_desc); } =20 static struct platform_driver gcc_sa8775p_driver =3D { --=20 2.54.0 From nobody Fri Sep 25 05:31:34 2026 Received: from mx0b-0031df01.pphosted.com (mx0b-0031df01.pphosted.com [205.220.180.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 687C44CB8A4 for ; Wed, 16 Sep 2026 10:29:56 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.180.131 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1789554599; cv=none; b=tGAmFnwedFe0r3yRjB7V4XyR2jFu+rVCurhBQM8EvADw78CunMGDoDe4pvOXbTyVD5LRD97h/rfHmae70LKjuBirY9bCBZI//GPXYsNB2IIiWIfoCExUPCFYFmMsabTFj07UGT9WfOCJgGo3YyrmCK+IvvO97uV3QXm5p3KefrM= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1789554599; c=relaxed/simple; bh=kjH4U7LYJXMjtRl02/2G1xh38BvQSw6adewBLYe/qq4=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=iYQX/zGC/jEdYtXciWiysrdt3LHvW3BXAyNbtfX0Vj4chnTgZLYNpPEDG+6GvI1D4zyIziB3rTtLsaF9SdullDO13/20N5IWmLS9P0+OPdc5DJ/sdP5iYpEmccWG68Yys5cVBGhpAeVODh29XTLvnYgPGvICMBvklRab8PKTFkY= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=lI2vOmYB; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=VCYt7HDn; arc=none smtp.client-ip=205.220.180.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="lI2vOmYB"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="VCYt7HDn" Received: from pps.filterd (m0279873.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 68G934PD2226500 for ; Wed, 16 Sep 2026 10:29:54 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= 6Pq00aNEwXnERpYAbSOyarBrxtxZMRIL85tSGWJa8JM=; b=lI2vOmYB4+Efa3zJ NM/xtppcOZS9HaFTJ1T00BzcV8OgGrpTxWwNNea7XLSOpQ92t0odV1IKSFpn8qLL PGE1x2utCdS5cBoJIDVTfbsFjBqYwyT3wfDkmVaFZQn4csvLkk+k0vBu6O4d4RJc +QArhV+NJuN0SKj8xaABira/OSrvlBn3+ds13oyg2X92iL3uwwsvNws65SXd7eYI bboHbnsxT70geJWOWnc3rpDUEUqSbjEnGOmEIdgF/6kp48o9iGF4vtPDRBUChFhA EmjBb7/Ab08WhWiXTng0ZAmkTz/p3yuiKPMasi/8Gjo2i3OMXG4AfJsA1InZRfkG SDLLsQ== Received: from mail-qk1-f200.google.com (mail-qk1-f200.google.com [209.85.222.200]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4gqah9ut15-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Wed, 16 Sep 2026 10:29:54 +0000 (GMT) Received: by mail-qk1-f200.google.com with SMTP id af79cd13be357-93a3f673221so26771585a.0 for ; Wed, 16 Sep 2026 03:29:54 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1789554593; x=1790159393; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :content-type:mime-version:subject:date:from:from:to:cc:subject:date :message-id:reply-to:content-type; bh=6Pq00aNEwXnERpYAbSOyarBrxtxZMRIL85tSGWJa8JM=; b=VCYt7HDnWYRPs2QOI5ZnIkrauN2GHZiK5UgeXYRhJoHS4Y/kY1auj4UyW3QmeGIQAV XU5F6ccFbejWceDHSsVDaunQlIZuXM0KCYCo13JGujiqiP3UVsihqPvGooVji1NAuR96 Rny3A15Q64lTzbPHbJU5nQjHMTjjidou1DZ8UT6YHpuzJIWH4DB2o2bmUT0Fwjjb32dm 0kwh75FtTB4mGUCusgdQ7FgWXskp+SxwQAkx5prJ0EKSGKBACaMgyfb+NcWMsgNtwUok P36CTmIAd5C/9Ni6SMhuD9UUuUsLeO9ua+75WtiIr5VNz3+GIJB03CfOfBUm/QEPWnZS NJbA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20260707; t=1789554593; x=1790159393; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :content-type:mime-version:subject:date:from:x-gm-gg :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to :content-type; bh=6Pq00aNEwXnERpYAbSOyarBrxtxZMRIL85tSGWJa8JM=; b=ymeFnoOzp9TKGUReGzlKqHhX5h7j7B/Jx9QoEMWoihX9wn4VFXPu3lx209rYtqBP4E BljD8+VeTsVSWF7h3+bBz0VXB6doG1naDa3PTp+ne7GgZhyCHriTCQdKOdE8YrdXRI+F 9do++EVk/JX3ccBGirVjmzGhMKl/IvILxyyRNDBHu/9HN7NSy4Iveatp63kUv02vrG5p JscoUrCNnXEWG0wZ0EV54XUFBqy8eL6rkmbAwZE7i1sy3M9M7T75lRsSCLJW8M50DGDo cQTGr6c228LjXtEUPh5seYtKjjZYu09RixlnKTfRvLjwX+RawPYO1oh0axVl+QqTjHLY PNoA== X-Forwarded-Encrypted: i=1; AKwUvBzxPjS7bOdwOGk3M2xKEE09lXmQi38QjRW78xvwk0mCnulZ33ldsWueeT5lTyEyT8sIvOl2gw5EJzfef3A=@vger.kernel.org X-Gm-Message-State: AFuF++k0TUBFWhYJvZLVZuRkhjdQ1rV9P+P5iQH74Pr2i0Voa8YYVbdu nBBWVVEMIIWK0nEhJcVTpfb0UsE9mZUPbOcxlembNnyT8o0+fSwzxROggJkCfHSDZKusjWICN50 9MU+ZHDTP/gRUgwhCL1qxDCMOteaq/NS//hQaanusUcEpa4m5ag9w2jYUrbJ5t7jngSw= X-Gm-Gg: AYBFou1NfsTpzlDr7j08dk9fcWH9p+foldkpq85cY++/fV3qgvNRemKsSgYtvHY8rBE OcYJ0AlcfnPVg9TLjSOExMNU3H4mXoZZjMtkkYzosC64OdwaS9JVyO3WUEpCl2RqlcKkaBhYMr+ MqyNPgMlikwTdIuITJdMd60mBbcTvPCWIYzliECCiokXthmdykHBGGZtGmAeInoR0gjqIW0ifXR 2pVEAs17ctF51TLK2+sbcYH7ujegKxTQO8cyUkHvJH47G9YahdtXhlmD0hCe+ASN5SJc7+LfecQ 8X3VmnlXgaH2jMvfYx8uKhwwfgNgfBSM9wo73WjnFpbcK/UG9o6kVYn0sMM8YYWvuZ4lZTQHSMX skmcvZH4= X-Received: by 2002:a05:620a:640b:b0:939:6de8:43de with SMTP id af79cd13be357-93bb7953614mr288353585a.50.1789554593355; Wed, 16 Sep 2026 03:29:53 -0700 (PDT) X-Received: by 2002:a05:620a:640b:b0:939:6de8:43de with SMTP id af79cd13be357-93bb7953614mr288347985a.50.1789554592846; Wed, 16 Sep 2026 03:29:52 -0700 (PDT) Received: from [127.0.1.1] ([86.121.170.232]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-49e83dbb0c1sm71633805e9.14.2026.09.16.03.29.51 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 16 Sep 2026 03:29:51 -0700 (PDT) From: Abel Vesa Date: Wed, 16 Sep 2026 13:28:35 +0300 Subject: [PATCH 19/48] clk: qcom: gcc-sar2130p: Use common clock controller probe data Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20260916-clk-qcom-rework-legacy-always-on-clocks-v1-19-25a24e50f82a@oss.qualcomm.com> References: <20260916-clk-qcom-rework-legacy-always-on-clocks-v1-0-25a24e50f82a@oss.qualcomm.com> In-Reply-To: <20260916-clk-qcom-rework-legacy-always-on-clocks-v1-0-25a24e50f82a@oss.qualcomm.com> To: Bjorn Andersson , Abel Vesa , Stephen Boyd , Brian Masney , Jerome Brunet Cc: linux-arm-msm@vger.kernel.org, linux-clk@vger.kernel.org, linux-kernel@vger.kernel.org, Abel Vesa X-Mailer: b4 0.16-dev-0e65f X-Developer-Signature: v=1; a=openpgp-sha256; l=2850; i=abel.vesa@oss.qualcomm.com; h=from:subject:message-id; bh=kjH4U7LYJXMjtRl02/2G1xh38BvQSw6adewBLYe/qq4=; b=owEBbQKS/ZANAwAKARtfRMkAlRVWAcsmYgBqqm9dbWqOt1O1g9WDLyMbnlHGIsNq/Bq6jM5jW MiDdAtIU02JAjMEAAEKAB0WIQRO8+4RTnqPKsqn0bgbX0TJAJUVVgUCaqpvXQAKCRAbX0TJAJUV Vo1CD/0R9BVX+HbFMDRcjg9h+jKWehS1rTcWOccAV5sdHzPPfqnMLscDAtGuW5aiiOfD64cutuy V9wA809FEcoT7MryADHApixYXSiEKYT1S8HAOhg5uYqynkQ2LLnx5uC4Fzvgqkdow58koaCa0gd 9U5Je4ER+G09oa1CBytff0BAKYWa58GriaT1RkVHfm8RYIM/g4PSMAAOPPh1viddRiadvPTAUtc nk7bI0zeHoDg+IU7XIyTWRN+3qah0hmUa4RmKXorB6y4vf8T9A5gEOgdnYr4X4hu+2tj0oWXvGG B2pwr26GJaznMNvG4QldgyoTgQijdU3kA0IKhzzTWW7yQBcrWrfaQyDiDvPGSbjRXVIlBSkpRAR pX/2MibCbEw56SNP4xvB7h4/DK9/yFIUnq7j3My2PNGzRAcoxQYuMUvdBX8reML/6ZEFZv4kGHE Zj0zTu822mEQdSFwMwMhEKsB2BwG3SXzo9ff4TxuLmkww7aDjRD+VQXUtkCQSzE/13WCyoYvPYp YZbfTE88JYFGSgVoZIW9IPIgwyUXJ5zgn+FxKkSdb/603mXTfIFZ/QKdoYLxmYAyYQQSyEGn+bl J8Sz9ZLx/inENm8mmqgmd8i9Jw6BGOkDoIYcUs8Ud7QxLFwqAcdKwPPND7cdO8SITSBVPp0Vnps 8lSasmctzoxBLew== X-Developer-Key: i=abel.vesa@oss.qualcomm.com; a=openpgp; fpr=6AFF162D57F4223A8770EF5AF7BF214136F41FAE X-Authority-Analysis: v=2.4 cv=BtkIUoX5 c=1 sm=1 tr=0 ts=6aaa6fa2 cx=c_pps a=hnmNkyzTK/kJ09Xio7VxxA==:117 a=po8fGBi+ks8MzcVQGuqtFQ==:17 a=IkcTkHD0fZMA:10 a=VdqzKS8jKosA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=rJkE3RaqiGZ5pbrm-msn:22 a=EUspDBNiAAAA:8 a=XazbkJH4cJJKrr3KiP8A:9 a=0bXxn9q0MV6snEgNplNhOjQmxlI=:19 a=QEXdDO2ut3YA:10 a=PEH46H7Ffwr30OY-TuGO:22 X-Proofpoint-ORIG-GUID: VoGDUa-KLZSJrH-ItXfxV1D1LeWKyupW X-Proofpoint-GUID: VoGDUa-KLZSJrH-ItXfxV1D1LeWKyupW X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwOTE2MDEzNyBTYWx0ZWRfX1wuz4gRhYiR8 6ZvTU4h557W5++9zu4rzdubAsX+1dgf/FKFXmmMvxZzXvko9hwxL39wayzJP3CniRL+RpLwkXtJ 8RhwCZoMDtQ1RqgWJT6IW/dcMHQaHv2eqEPqzWDzDqhL+TcP1i1sKNxiP7ijTu7EOke6hS8lFGZ vdcAqYq2awG0eq+rbSKLP8vpHDLphk8UE75syhhpu+upMDoOxSCfArVxbjLih9cGsMd5ZzTb5+c dE75WF59SHMtQNhywgyTyhZdzvEYaijCRpWoEqyRVN+j9EpGQxwby5ePGZ2eH2w0KamCn2H7xuk rw3TyPYyT3+qK0LLkQd79dBluj0iR23d9PYPrENfFcFF+CE0mh8nq7754pslY0bIuJe7osgdXG7 mADh2OJ8p7ufR6S+n/tTMUc558l98/eEJqJppqnfdJUp/81P+HNA+pjZdhs/I2jO0rdJJclzp6q agsw2Izepqtc0KtL3Ww== X-Proofpoint-Spam-Info: AW1haW4tMjYwOTE2MDEzNyBTYWx0ZWRfXxde6zQ1XxFUz X7BBl+7xEv3J8Dikz6qasx7FImEunnCUcFWpB9yyw3FCm9twJQY9m0/nn0DrBYRkqr0BsVlGvjA ubLxO2UianBIMHiM4ee1wRYn0uW4+6M= X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1176,Hydra:6.1.134,FMLib:17.12.100.49 definitions=2026-09-15_05,2026-09-15_02,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 priorityscore=1501 lowpriorityscore=0 spamscore=0 adultscore=0 malwarescore=0 impostorscore=0 bulkscore=0 clxscore=1015 phishscore=0 suspectscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2609040000 definitions=main-2609160137 Move the always-on branch register offsets into a critical_cbcrs array, describe the DFS RCGs through qcom_cc_driver_data and move the register programming into the clk_regs_configure callback. Use qcom_cc_probe() to perform the common initialization instead of open-coding it in the driver's probe. Assisted-by: LLM Signed-off-by: Abel Vesa Reviewed-by: Konrad Dybcio --- drivers/clk/qcom/gcc-sar2130p.c | 45 +++++++++++++++++++++----------------= ---- 1 file changed, 23 insertions(+), 22 deletions(-) diff --git a/drivers/clk/qcom/gcc-sar2130p.c b/drivers/clk/qcom/gcc-sar2130= p.c index 475e2cda3618..3882ec7424cf 100644 --- a/drivers/clk/qcom/gcc-sar2130p.c +++ b/drivers/clk/qcom/gcc-sar2130p.c @@ -2300,7 +2300,29 @@ static const struct regmap_config gcc_sar2130p_regma= p_config =3D { .fast_io =3D true, }; =20 +static const u32 gcc_sar2130p_critical_cbcrs[] =3D { + 0x37004, /* GCC_DISP_AHB_CLK */ + 0x42004, /* GCC_VIDEO_AHB_CLK */ + 0x42028, /* GCC_VIDEO_XO_CLK */ + 0x9b004, /* GCC_GPU_CFG_AHB_CLK */ +}; + +static void gcc_sar2130p_regs_configure(struct device *dev, struct regmap = *regmap) +{ + /* Clear GDSC_SLEEP_ENA_VOTE to stop votes being auto-removed in sleep. */ + regmap_write(regmap, 0x62204, 0x0); +} + +static const struct qcom_cc_driver_data gcc_sar2130p_driver_data =3D { + .clk_cbcrs =3D gcc_sar2130p_critical_cbcrs, + .num_clk_cbcrs =3D ARRAY_SIZE(gcc_sar2130p_critical_cbcrs), + .dfs_rcgs =3D gcc_dfs_clocks, + .num_dfs_rcgs =3D ARRAY_SIZE(gcc_dfs_clocks), + .clk_regs_configure =3D gcc_sar2130p_regs_configure, +}; + static const struct qcom_cc_desc gcc_sar2130p_desc =3D { + .driver_data =3D &gcc_sar2130p_driver_data, .config =3D &gcc_sar2130p_regmap_config, .clks =3D gcc_sar2130p_clocks, .num_clks =3D ARRAY_SIZE(gcc_sar2130p_clocks), @@ -2318,28 +2340,7 @@ MODULE_DEVICE_TABLE(of, gcc_sar2130p_match_table); =20 static int gcc_sar2130p_probe(struct platform_device *pdev) { - struct regmap *regmap; - int ret; - - regmap =3D qcom_cc_map(pdev, &gcc_sar2130p_desc); - if (IS_ERR(regmap)) - return PTR_ERR(regmap); - - ret =3D qcom_cc_register_rcg_dfs(regmap, gcc_dfs_clocks, - ARRAY_SIZE(gcc_dfs_clocks)); - if (ret) - return ret; - - /* Keep some clocks always-on */ - qcom_branch_set_clk_en(regmap, 0x37004); /* GCC_DISP_AHB_CLK */ - qcom_branch_set_clk_en(regmap, 0x42004); /* GCC_VIDEO_AHB_CLK */ - qcom_branch_set_clk_en(regmap, 0x42028); /* GCC_VIDEO_XO_CLK */ - qcom_branch_set_clk_en(regmap, 0x9b004); /* GCC_GPU_CFG_AHB_CLK */ - - /* Clear GDSC_SLEEP_ENA_VOTE to stop votes being auto-removed in sleep. */ - regmap_write(regmap, 0x62204, 0x0); - - return qcom_cc_really_probe(&pdev->dev, &gcc_sar2130p_desc, regmap); + return qcom_cc_probe(pdev, &gcc_sar2130p_desc); } =20 static struct platform_driver gcc_sar2130p_driver =3D { --=20 2.54.0 From nobody Fri Sep 25 05:31:34 2026 Received: from mx0b-0031df01.pphosted.com (mx0b-0031df01.pphosted.com [205.220.180.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id AEB634CC600 for ; Wed, 16 Sep 2026 10:30:01 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.180.131 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1789554640; cv=none; b=PFGFxksE4MJ4niK1TgnJtxg/S+ZPpIKdcbKRTSEVHue5TDyNnGFw1SsU+RY6nRHcwN3miM7zAuZdFGiL3Xch51omsKk0budQX4b7FzYq6Ve81to+iC8YT76Sv44KNCIoF9NmIv8O2PPhcAHdn+jt54o6V89aDjAEneHoV8NUsTY= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1789554640; c=relaxed/simple; bh=98qvKFowCzLFQ+OL+70mkncTytIHj+yglPqQLHeXZvQ=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=iyCypPvI/aasC02pQMHi1deQ/DX3uhzQMu9pCFHXpWnoATqVd/Thk1wNCygufT7sRfRBAo26PwNc9CUR0rN++Vs6ryC1CtzJViwdX1v4UKOgb2Pb0V7vG2fUDwebEk4CFlIHH1HOtgTXm04IDhwPnIx4CkJ1fZLh5fvVCNvz97o= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=jYHlT6ue; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=L0symaWH; arc=none smtp.client-ip=205.220.180.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="jYHlT6ue"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="L0symaWH" Received: from pps.filterd (m0279868.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 68G92ti42122651 for ; Wed, 16 Sep 2026 10:29:56 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= uabcToqzU7G8MyF/ZyucZ5HGCRyjcYDOkFYtchesHt0=; b=jYHlT6ueMCiGUqgs FXnJcwF+9OUe7OZSvXXI8c2zDegDyqpKQVOgRQF+ZPa5u/uEcMm2XAhZrEFikHHH PgEl50pjb6clXEhMoMLUgjT9a/bEhLCutyIzIcS1zZHMVRRhmuoLZqWcWMzXyKw3 /G0xIyRiW/ABMtMjKNH2z/TDJkj8oBNlQpmNjA+5tV8/2EiS50Sbq6lelcuyWidt nKk6EhrhNS+ixtJfOC8r2sb5XTmUSubZ01VOvxu5JN7orh2p0/5Grl3cJyLU34eB 5nfNMEd0kTndsEMaXQmpuB4Ps4lp2Av0EfPciTCX6t0gT9OoM2XdzmSC0YFweXgs qENpGQ== Received: from mail-qk1-f200.google.com (mail-qk1-f200.google.com [209.85.222.200]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4gqkv7hhrx-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Wed, 16 Sep 2026 10:29:55 +0000 (GMT) Received: by mail-qk1-f200.google.com with SMTP id af79cd13be357-939f925ba4eso19957985a.3 for ; Wed, 16 Sep 2026 03:29:55 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1789554595; x=1790159395; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :content-type:mime-version:subject:date:from:from:to:cc:subject:date :message-id:reply-to:content-type; bh=uabcToqzU7G8MyF/ZyucZ5HGCRyjcYDOkFYtchesHt0=; b=L0symaWHJiHvH6yB7omsv7c6XAgG2pQTXFP+1JcsYfOaOx4rNKwxSlEKrQC5cumfpD qCYAaHfXb9d9n8l+kNJ55dopV6NfgG/J7rvtuhhTqVlRODfTbQeHX0htv4DtXIz+18d4 /8PniCjX/vXGrtUkkh6uDsIU11OpqEbuZ7kq1AW1fbph0+1stK0spwvxzatPWONyti34 s5UYiE3dhpI5QDmlUWIvyoEkrFnDJlN3bCubY5qEL38BCCzsifPcHoascT2y28PkASDI tG5Ltzu2+c5ABwcZ6k/34PFQL4sT2M6ffoifh9Nstm7n+cP3mQF1hGh961qb/jCRxpCh IZWQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20260707; t=1789554595; x=1790159395; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :content-type:mime-version:subject:date:from:x-gm-gg :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to :content-type; bh=uabcToqzU7G8MyF/ZyucZ5HGCRyjcYDOkFYtchesHt0=; b=lcGUjBwvAtAyHRoHy1BGabqQKYVCqynWCbMLoKCC9ctkTha5Zdvig1I0TGjZShdfA5 0CsDV2wvxvX1Rc9T7ynhHnmLZxT3F5tozPmtghZmGilQrTbeWVDzIv1NEZmWfgoJlUNT irwpE2US9wyhuBvk/nTIL1EILdx5e1qxww3SaQRO9Du9sQE27WyWb9ZLaTcnQcdF/AV5 aPRHnnWxCXEyyvTKGVdItVW+Dptb8Xd8i4cMhXg/4AWGMP+7xd5JMMVppX5X4w4IUOda dtDoVzCJT7qP7ecuJArknw5jD4l6ioDAMBRNbf+HoBsJhxgjqr42Wrx0Z9r+yNcRe+JM Hq0Q== X-Forwarded-Encrypted: i=1; AKwUvBx4X8E2zQK7DmOuCgcbzjppUKp62jMQcQbxayfzSi9a+GIDFDtKnyzweKKu4nGg7ZYSXwJsB/00h3ouk3s=@vger.kernel.org X-Gm-Message-State: AFuF++lN6EaI2NLXgYsGM+PhdXuyN3w1YZ8UOKJrWJhLIWIRAOhptMlf BlSgWls0VRz1Z+FwUbJ4J0s4c2XoNZYm3cLwq8v/APA/g34f5E7SeMXAia2ox+EmQ7AI1H8Jelu RFvX6Z6v19eOXRylHbmNLIU2OkmNmW27XoZ8rX1lo2lYiqf+/CY6HJQ/E8A7KmCEZtX8= X-Gm-Gg: AYBFou1J4llcsZeMIo4YEslp9HB+imaei/VdeXA40h8M/wCCxvB3twZfV1KEmm75fei sjEmXJp+Nbax3876QOfKE7RLEnWbiXB6ugehuIA3G5SQN0hj2G2Ok6vPesVoBWDmUThc4BUR/JS KDLaa8epPmeHo70oGl4AwOJ3l+RtHEC/OY4+yexUf/kprwqImokQRBuktvElabOQDwa9Vm5dgUA eTs3o3rRtcG1FLSOR2CtB54ow4AyFmJaD2Y6CCBLkhzBNhspNHsGeBtXOGp/Dufh5BiCOa5mHEq 7AswdSWI7pmwg+FtkvDtimm+blOG/FAz9+4Mx7qXgwrwNF0TKcoLgPSGeSMFjuT1EkmfxDdoZZT 6cXVkFAI= X-Received: by 2002:a05:620a:1711:b0:939:e650:c80 with SMTP id af79cd13be357-93bb78f24e9mr282379885a.39.1789554595191; Wed, 16 Sep 2026 03:29:55 -0700 (PDT) X-Received: by 2002:a05:620a:1711:b0:939:e650:c80 with SMTP id af79cd13be357-93bb78f24e9mr282375785a.39.1789554594641; Wed, 16 Sep 2026 03:29:54 -0700 (PDT) Received: from [127.0.1.1] ([86.121.170.232]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-49e83dbb0c1sm71633805e9.14.2026.09.16.03.29.53 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 16 Sep 2026 03:29:53 -0700 (PDT) From: Abel Vesa Date: Wed, 16 Sep 2026 13:28:36 +0300 Subject: [PATCH 20/48] clk: qcom: gcc-sc7180: Use common clock controller probe data Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20260916-clk-qcom-rework-legacy-always-on-clocks-v1-20-25a24e50f82a@oss.qualcomm.com> References: <20260916-clk-qcom-rework-legacy-always-on-clocks-v1-0-25a24e50f82a@oss.qualcomm.com> In-Reply-To: <20260916-clk-qcom-rework-legacy-always-on-clocks-v1-0-25a24e50f82a@oss.qualcomm.com> To: Bjorn Andersson , Abel Vesa , Stephen Boyd , Brian Masney , Jerome Brunet Cc: linux-arm-msm@vger.kernel.org, linux-clk@vger.kernel.org, linux-kernel@vger.kernel.org, Abel Vesa X-Mailer: b4 0.16-dev-0e65f X-Developer-Signature: v=1; a=openpgp-sha256; l=3470; i=abel.vesa@oss.qualcomm.com; h=from:subject:message-id; bh=98qvKFowCzLFQ+OL+70mkncTytIHj+yglPqQLHeXZvQ=; b=owEBbQKS/ZANAwAKARtfRMkAlRVWAcsmYgBqqm9eZunXfqqoTv/+m9u1H682q4890hsdU4Uhl MyZS2XpxcqJAjMEAAEKAB0WIQRO8+4RTnqPKsqn0bgbX0TJAJUVVgUCaqpvXgAKCRAbX0TJAJUV VuYAD/kB5+JRTlHJWxaDs4owOZPuyFU40Lf0Nmwo5xuyE9PxFCYJjFAttruJhuCZMjGNymr80Rr Qa6KC9IT3A6j95HwDDqgLKkLMQMMM7NK7bsDkQB148Rmwqw9BdSrilYvzwJrRLTM5cGEeAUzR8q 6K6Wq3wFI+lFtmCNof1TqbOXTRhKa/Onl1LNRnGa6Joe6GpIpmHAuPcfLZbItOD7HRRJCxxp4Y/ INadloZ6UboHsiuTzuxEwH/LYrvIPPNLAFZIs34CrE4lcIGEeJp+qSpPodC2iiWZ6Vk+4Y2Na91 jVeingaDBCT0MEf70bNQwCcvjL4DDoY0Mneqvos4NBoRrokWLbCoRrbrc+QwJzRkr3qG5o5eYni 8PgaX0saTKrr8u3LBWjBZRx8uFF7zlcWYBU5bmGkZeut/JbWRf1IBy2NyHsm31CcKgWddmoMjfX jIysKJTbgSIPSTHP4bhNE3Cq8QBSvE1/P4Rm6XEdkAsgWGue9CaZVzzmV9QVv4kV8A28ECgu/EX mXw8yfwmTLHdFI6lLptQXbJAq7YQQLX5mIxLoOl26/W3w5CrGE+feRWJDmsKJR+v26FjFQaoUQq C/qZIY/2Dz2shJJbzvLnK5/Fad5Pn62lB3njDV1MlWbZNs3AcQIY+prgNYpkHfAIoRPaH7uNhte m6SKL26FhBeNZMA== X-Developer-Key: i=abel.vesa@oss.qualcomm.com; a=openpgp; fpr=6AFF162D57F4223A8770EF5AF7BF214136F41FAE X-Proofpoint-ORIG-GUID: E3A3hQl4ydlNHvI7_xPUTaLtsiKxj99A X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwOTE2MDEzNyBTYWx0ZWRfX76boqnsFIhTM QoxjXIbfTdtHmOFMVxR8Hn3XUuSx8qkc1MnoejitU42qg28CdQ2gufTuxnMh8ABBDlrYnRmjMB4 VTRrF8hnpIe8eeB4BaEBIRPcpYC40pjmkDupC2Ksz94sLG4Zfmdix+IZPXiIJcPN4yDs3+AXIaH RxsMjgNzHym9XG2mITh3Sxnu3/sELg2hoq2tY7/3diF+/jiP77PrFlxuw3ktovmWwQYFR2bvMik fqR8y69FXZgJ5/vbiTE9K1PFfeyXi4al/BkEz6Bqcl97Lm3nfUWKPqkYn0wR0ZBHi0/lmKlgkJS TVi4yacaz3EuB5pbGtpDzIkOXC7cMtvi0q1roFzVUB+1tlhx8YvhbUyg/eiCYMRny/w7gwMaygl Is02Rvu61fZvyKtGkG8n2/195Le0P7olyzMQx2wA2crogr5OnbP0zs9yv956ApDiaOwNSGJd6up 7lybJWtFedCT71aKozQ== X-Authority-Analysis: v=2.4 cv=eKmGH3p1 c=1 sm=1 tr=0 ts=6aaa6fa3 cx=c_pps a=hnmNkyzTK/kJ09Xio7VxxA==:117 a=po8fGBi+ks8MzcVQGuqtFQ==:17 a=IkcTkHD0fZMA:10 a=VdqzKS8jKosA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=ZpdpYltYx_vBUK5n70dp:22 a=EUspDBNiAAAA:8 a=RW22A4phRzxp-fsVvwcA:9 a=QEXdDO2ut3YA:10 a=PEH46H7Ffwr30OY-TuGO:22 X-Proofpoint-Spam-Info: AW1haW4tMjYwOTE2MDEzNyBTYWx0ZWRfX2iuTfsGE1JJ+ 1bfzQ0pdbOMrxvLyDr73Sil9fOlYw6ZwzcW8E0AbTWOw3jLqX0yKmW4lXTnDinEBHg5lXrvK06F UT4NdlF1I75usKSGnnOa28K8GJK8wZc= X-Proofpoint-GUID: E3A3hQl4ydlNHvI7_xPUTaLtsiKxj99A X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1176,Hydra:6.1.134,FMLib:17.12.100.49 definitions=2026-09-15_05,2026-09-15_02,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 impostorscore=0 lowpriorityscore=0 adultscore=0 bulkscore=0 clxscore=1015 phishscore=0 spamscore=0 priorityscore=1501 malwarescore=0 suspectscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2609040000 definitions=main-2609160137 Move the always-on branch register offsets into a critical_cbcrs array, describe the DFS RCGs through qcom_cc_driver_data and move the register programming into the clk_regs_configure callback. Use qcom_cc_probe() to perform the common initialization instead of open-coding it in the driver's probe. Assisted-by: LLM Signed-off-by: Abel Vesa Reviewed-by: Konrad Dybcio --- drivers/clk/qcom/gcc-sc7180.c | 60 +++++++++++++++++++++------------------= ---- 1 file changed, 29 insertions(+), 31 deletions(-) diff --git a/drivers/clk/qcom/gcc-sc7180.c b/drivers/clk/qcom/gcc-sc7180.c index 4a49ad7a9e5b..6d9ee31044a5 100644 --- a/drivers/clk/qcom/gcc-sc7180.c +++ b/drivers/clk/qcom/gcc-sc7180.c @@ -2408,7 +2408,35 @@ static const struct regmap_config gcc_sc7180_regmap_= config =3D { .fast_io =3D true, }; =20 +static const u32 gcc_sc7180_critical_cbcrs[] =3D { + 0x48004, /* GCC_CPUSS_GNOC_CLK */ + 0x0b004, /* GCC_VIDEO_AHB_CLK */ + 0x0b008, /* GCC_CAMERA_AHB_CLK */ + 0x0b00c, /* GCC_DISP_AHB_CLK */ + 0x0b02c, /* GCC_CAMERA_XO_CLK */ + 0x0b028, /* GCC_VIDEO_XO_CLK */ + 0x0b030, /* GCC_DISP_XO_CLK */ + 0x71004, /* GCC_GPU_CFG_AHB_CLK */ +}; + +static void gcc_sc7180_regs_configure(struct device *dev, struct regmap *r= egmap) +{ + /* Disable the GPLL0 active input to MM blocks, NPU and GPU via MISC regi= sters. */ + regmap_update_bits(regmap, 0x09ffc, 0x3, 0x3); + regmap_update_bits(regmap, 0x4d110, 0x3, 0x3); + regmap_update_bits(regmap, 0x71028, 0x3, 0x3); +} + +static const struct qcom_cc_driver_data gcc_sc7180_driver_data =3D { + .clk_cbcrs =3D gcc_sc7180_critical_cbcrs, + .num_clk_cbcrs =3D ARRAY_SIZE(gcc_sc7180_critical_cbcrs), + .dfs_rcgs =3D gcc_dfs_clocks, + .num_dfs_rcgs =3D ARRAY_SIZE(gcc_dfs_clocks), + .clk_regs_configure =3D gcc_sc7180_regs_configure, +}; + static const struct qcom_cc_desc gcc_sc7180_desc =3D { + .driver_data =3D &gcc_sc7180_driver_data, .config =3D &gcc_sc7180_regmap_config, .clk_hws =3D gcc_sc7180_hws, .num_clk_hws =3D ARRAY_SIZE(gcc_sc7180_hws), @@ -2428,37 +2456,7 @@ MODULE_DEVICE_TABLE(of, gcc_sc7180_match_table); =20 static int gcc_sc7180_probe(struct platform_device *pdev) { - struct regmap *regmap; - int ret; - - regmap =3D qcom_cc_map(pdev, &gcc_sc7180_desc); - if (IS_ERR(regmap)) - return PTR_ERR(regmap); - - /* - * Disable the GPLL0 active input to MM blocks, NPU - * and GPU via MISC registers. - */ - regmap_update_bits(regmap, 0x09ffc, 0x3, 0x3); - regmap_update_bits(regmap, 0x4d110, 0x3, 0x3); - regmap_update_bits(regmap, 0x71028, 0x3, 0x3); - - /* Keep some clocks always-on */ - qcom_branch_set_clk_en(regmap, 0x48004); /* GCC_CPUSS_GNOC_CLK */ - qcom_branch_set_clk_en(regmap, 0x0b004); /* GCC_VIDEO_AHB_CLK */ - qcom_branch_set_clk_en(regmap, 0x0b008); /* GCC_CAMERA_AHB_CLK */ - qcom_branch_set_clk_en(regmap, 0x0b00c); /* GCC_DISP_AHB_CLK */ - qcom_branch_set_clk_en(regmap, 0x0b02c); /* GCC_CAMERA_XO_CLK */ - qcom_branch_set_clk_en(regmap, 0x0b028); /* GCC_VIDEO_XO_CLK */ - qcom_branch_set_clk_en(regmap, 0x0b030); /* GCC_DISP_XO_CLK */ - qcom_branch_set_clk_en(regmap, 0x71004); /* GCC_GPU_CFG_AHB_CLK */ - - ret =3D qcom_cc_register_rcg_dfs(regmap, gcc_dfs_clocks, - ARRAY_SIZE(gcc_dfs_clocks)); - if (ret) - return ret; - - return qcom_cc_really_probe(&pdev->dev, &gcc_sc7180_desc, regmap); + return qcom_cc_probe(pdev, &gcc_sc7180_desc); } =20 static struct platform_driver gcc_sc7180_driver =3D { --=20 2.54.0 From nobody Fri Sep 25 05:31:34 2026 Received: from mx0b-0031df01.pphosted.com (mx0b-0031df01.pphosted.com [205.220.180.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id C92954EE840 for ; Wed, 16 Sep 2026 10:30:00 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.180.131 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1789554621; cv=none; b=NyWuvqaz9KZF+2xXXaM6o5796Gr/puWrQBdaP4fqxoo8m2sLeIRxaRtoPMcGEXnxHJc8IkVb13x9i3cSkqfYm+MbVNXg8QgA+dsqGwkVdVE9QUNElNvmBEEkvu1YGQeSpqRhJz/g/6BDfOIn1TQpo6bbxt5w3An/LHDM3DRUQBE= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1789554621; c=relaxed/simple; bh=jjpSEsuYLIeV3ZD1JGI6Fq2VkSzt0HuQGhCBFEHbBCI=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=Q1LiJCqK9x5yZC9KYIaXrvL2KX38+OiybnCUHkK9BwOXcGw55akIGZBHmJVBcR4zhUVBOH6V2g4abwg0Zb42XErEkcun9MLEN4Bu0t0pEsf9HVJtQi45WthGCv7h8q3zjuL0Rdk1j3BGH82kkSRWWTfw8EeEF7cedWFcCjCjXX0= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=dgaxQEpZ; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=S2jKBMed; arc=none smtp.client-ip=205.220.180.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="dgaxQEpZ"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="S2jKBMed" Received: from pps.filterd (m0279870.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 68G92gem2477693 for ; Wed, 16 Sep 2026 10:29:58 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= tDazfgkzhkNAsDVOAy7aO7vlveA6tIubG+a316jZefs=; b=dgaxQEpZKRJHAbBR 0dupKY5HEoPszmHKUZ2s/3t5vCvv3RX/Q6a0YxVtF2Z/1eq6VYjf7JqVtdckFdKM MbBLEKFeJZoA0i49GkmJSX7fDVom49Mn3c88OZrYlPPaE9lBvVfLMpRBPlssdcyp 0Dwa+HFJu8SJiGdRbk5vAZqivE0HGIse3ydnWeZCELjonnQx1YcceQAJeXb9xEzL KmUoz9k99K8Sb7UNp2s40089Fuid1okRuXa6CMgFYQykzUJNUfvcLw6pCDAoAZwy wKt408OmgBKjUcUfrbmzRrny5BVcd7+xolEeljtmBjNqCQyYegvEJuRir0ENMvUv MzZ15w== Received: from mail-qk1-f198.google.com (mail-qk1-f198.google.com [209.85.222.198]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4gqjcksvfg-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Wed, 16 Sep 2026 10:29:57 +0000 (GMT) Received: by mail-qk1-f198.google.com with SMTP id af79cd13be357-939a6937513so845596085a.3 for ; Wed, 16 Sep 2026 03:29:57 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1789554597; x=1790159397; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :content-type:mime-version:subject:date:from:from:to:cc:subject:date :message-id:reply-to:content-type; bh=tDazfgkzhkNAsDVOAy7aO7vlveA6tIubG+a316jZefs=; b=S2jKBMedXhvEn+j8lObwHYYCdVvpfYoi6inl+KhzzKFs1j/YhJRioZOIuV72/iGRHY uUobVBP3L8lfAMODX5wdMDhZpkKDsRR724BpQt/HwYXw8Usl27anWIA6EqckIAhEVB8u AxHpBfzQWLcIqPqlS64n33RioQTxXV9dcJrm2G3XAB+LBbo3S5aLMQof7tMzffVFKVpb DerC8dk3G4qUa815IdmOt5f1X7EOWuN5BXshcKcC6BF8DhoDpggLjZF8P+9KtrtLdmQE VHXaJGDaKztBn1a9Fp402/4bz1Xx6w1o+2qi18sSNxm1f4KG5sn0FwcURhjvWkESn3tg oD4Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20260707; t=1789554597; x=1790159397; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :content-type:mime-version:subject:date:from:x-gm-gg :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to :content-type; bh=tDazfgkzhkNAsDVOAy7aO7vlveA6tIubG+a316jZefs=; b=XFrOxSgwm6bIT0evHg7rHDgkgqX1LxGvXk2uR8TWR+M36Vum1wjMCJxqOy+4ZB4Api fZmfl/Tc0Y1SJvnCwiIrF8YEe0n3frTppClTRgFXDolbhtO4VE2iImUnK9DxJOU/ODLG zeoyLhUjquC6SJPr1jesGfcTh4nt5nfuT8hEwm0mtlGh7TQl2PwNRFphB8C4L0ys2Z2L BKJptl2gTZcoKgIkxvU880nS3oZriOvnqHMf//04SMOUM2D8brvoN7ie6XURCjLxidl7 zMn/dvKAs7J5D05krmWDqByA1xa3DAIVoRvSHSnWj5UIZIgP/isg5RopWIf1n+Vrb/M4 qnFA== X-Forwarded-Encrypted: i=1; AKwUvBxL4VAskNymYpbd+Zd7eBIp2oCzQpgwndeZLIyprmNIMuoPwlpmpkMsqreKrp81ycsrPRabzKA3Ea7f+ms=@vger.kernel.org X-Gm-Message-State: AFuF++kHf8FF032dEviO+D0+pNkLnan3NQ7tHt7zRinbMc6dSBLS1Epi dFEHgqAEMPGnjdJu6XLCFbQcthlE2bNI/tX3Se10m0P0l7fiMz9oXOXDd4ApXDEYnhVpr+3X+AS +8UbSf5ZL7GUWbSZMkwjoWSuGV2qyjOS4gOrGWfpmu4Vu1lEy3/zyRXgoQK5bWLNkQLA= X-Gm-Gg: AYBFou3YzZ826FzV86RsPkZsh9bkVtRjcbmNEq8Ww4nHxQg4F8qtj8HLsK5XhNRdsJd KXrV+YOgjSoaTBM7fbVaYGMgrH4zFZPXFrYeC2gnSdEfH9gdTxh5YWBiMpNYt09xsn7Xy6uoGI/ BYqS5KLWsTVM+nXjX+rLU3RPceT2ayj8v0D5jwzoZSHKTfBNkVjr/iBDbE9BcO+dKzjjDpW5cAA 3WkI3DydJ9T9Lt6P+Kd8PzzAPhwjWKH26/LzvmvbDFzcTnOEEMzil9HkYZm1agSjJVfMmI2zsw6 vqXzzwYC8Mk0ok9PPswz4kWEaV69VS5kOtX/Z8021KyA0XW1J3oX4FjDru7ZKv1FyaomAjquEUR VgOipD3k= X-Received: by 2002:a05:620a:608b:b0:939:f522:b2f7 with SMTP id af79cd13be357-93bb788111bmr306307485a.33.1789554597201; Wed, 16 Sep 2026 03:29:57 -0700 (PDT) X-Received: by 2002:a05:620a:608b:b0:939:f522:b2f7 with SMTP id af79cd13be357-93bb788111bmr306303285a.33.1789554596697; Wed, 16 Sep 2026 03:29:56 -0700 (PDT) Received: from [127.0.1.1] ([86.121.170.232]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-49e83dbb0c1sm71633805e9.14.2026.09.16.03.29.54 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 16 Sep 2026 03:29:55 -0700 (PDT) From: Abel Vesa Date: Wed, 16 Sep 2026 13:28:37 +0300 Subject: [PATCH 21/48] clk: qcom: gcc-sc7280: Use common clock controller probe data Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20260916-clk-qcom-rework-legacy-always-on-clocks-v1-21-25a24e50f82a@oss.qualcomm.com> References: <20260916-clk-qcom-rework-legacy-always-on-clocks-v1-0-25a24e50f82a@oss.qualcomm.com> In-Reply-To: <20260916-clk-qcom-rework-legacy-always-on-clocks-v1-0-25a24e50f82a@oss.qualcomm.com> To: Bjorn Andersson , Abel Vesa , Stephen Boyd , Brian Masney , Jerome Brunet Cc: linux-arm-msm@vger.kernel.org, linux-clk@vger.kernel.org, linux-kernel@vger.kernel.org, Abel Vesa X-Mailer: b4 0.16-dev-0e65f X-Developer-Signature: v=1; a=openpgp-sha256; l=3246; i=abel.vesa@oss.qualcomm.com; h=from:subject:message-id; bh=jjpSEsuYLIeV3ZD1JGI6Fq2VkSzt0HuQGhCBFEHbBCI=; b=owEBbQKS/ZANAwAKARtfRMkAlRVWAcsmYgBqqm9fT4rwBwVIiJQHL9565Ie2w4EFKDnPXG6Av 0rEVGgPSwWJAjMEAAEKAB0WIQRO8+4RTnqPKsqn0bgbX0TJAJUVVgUCaqpvXwAKCRAbX0TJAJUV VkdZEACflRlJc8+pQdLsh+FFM0qwPBcoWyk8X0z49KsntecR+weO6pTMVg1RqL2N5JGeo5RMnTG 2usJIVd52t3WFpMsmJwFOz5tLbTu00kIRa/NIN8SP17bQmz/o6a4AiOwjCTMY/PI0RLHAXr6Zbr dySCVIJs3EXTDPXPTYs1UXP3W3Rsi7oqqZB4cSMvipOzIGirjbpEHJHwboOoXbxvXz+r9OfjEJk /i9AY02rqduF1OQ5NqNntO9MhGmlPmMAWmD5lqTnGRrHr6Fj4bLYB+awn5H1DSrAZrPxejrJ3sQ ZgI6Osmte0oF3+pyUMlGFCUZn0aoyBgvzvGCY0zDzxCPnejIMQgwQafszV+efzNqO8i3yx7SO9e jUT2Q/ibwGq66NNQrXsG1tHXD4gKVJ7epYYrBZ0R1W1uX13ihuVhUU/iDrN3UQv+dL5Ex6ZoT/f 998GRDBuuhLgNmvhN7JblG+Wk27BTc9BsUuZ5EjuJgn7NjvFeTuPqAlSL+6CB4o54/1QlKt7YPo V6+QwkbTJkQKdmBO/8/oxnvbcobSwI6wB4tFFSD325MwGf/ijBaCFfGYi3Ut/uYw3YsPayKWPT5 k08XuEGElbG5SYL0mF9ubA1hnVSSObH6tq2EbahuFrOVqZ4Ghnwvgo1CDB+5YcT+OE2zB8i6pjo BbQPENv7KToVElw== X-Developer-Key: i=abel.vesa@oss.qualcomm.com; a=openpgp; fpr=6AFF162D57F4223A8770EF5AF7BF214136F41FAE X-Proofpoint-Spam-Info: AW1haW4tMjYwOTE2MDEzNyBTYWx0ZWRfX79oYmgeh5M2l gOmIc6BDfDAmI5DGXUFBU7U9K806SBsb1XEg/veAmGGI5ciQYKRsbHge2nBUm7k3nmlTBr216z7 EWXDcxdMoE004Rrel0jX5mEKSx/bWaU= X-Authority-Analysis: v=2.4 cv=PsIG/AM3 c=1 sm=1 tr=0 ts=6aaa6fa5 cx=c_pps a=qKBjSQ1v91RyAK45QCPf5w==:117 a=po8fGBi+ks8MzcVQGuqtFQ==:17 a=IkcTkHD0fZMA:10 a=VdqzKS8jKosA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=gowsoOTTUOVcmtlkKump:22 a=EUspDBNiAAAA:8 a=RW22A4phRzxp-fsVvwcA:9 a=QEXdDO2ut3YA:10 a=NFOGd7dJGGMPyQGDc5-O:22 X-Proofpoint-ORIG-GUID: oDyJZvSos8xjSSjPzGRyikkWvHgwX64X X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwOTE2MDEzNyBTYWx0ZWRfX5TRTOCGQNrpt GzQgq1tBxrk62fNH2DS60wkyRHDZ/DC1DcDsmFPIqOA6fQLkou3vDYUAOmWpQAq7WqtID4chlgc 2se5z7o13YnAvFS/G1YcCZyReF7Jwj5IfX/LcFOX99obyLepDIja9nA4szYbtRX63tSrwb9/A/N 7YeuW6cm4ybTUzgGACqYUnqV8bAZqkOKwl3mDD/tbtzd70Bfw9RL+AsU9Kub0qcaMQuhTlc4ZqU ZpVnDOzyo8ELbi3OpzPR5fsS61ypgAWHunF8cW8XtTnkxNWwrFiTxvP1QIbdIsIRCOucKQuhozY u6XQZBobfBtyi10pEvwD07wi8Nn0QgFKzDuGy7BWCpvh5qydVT4VheQPsMuTNPbYu0JfnjG6600 MxI5/zIeBbjW41NnAB8oRso8En3fTIphSrNqY+ugCKYBJd/WJUXDF3I+WQEfFmogciAG6EiijqQ /rYiPcnxJJ9Mc2qdhvA== X-Proofpoint-GUID: oDyJZvSos8xjSSjPzGRyikkWvHgwX64X X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1176,Hydra:6.1.134,FMLib:17.12.100.49 definitions=2026-09-15_05,2026-09-15_02,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 impostorscore=0 lowpriorityscore=0 adultscore=0 priorityscore=1501 phishscore=0 spamscore=0 clxscore=1015 suspectscore=0 bulkscore=0 malwarescore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2609040000 definitions=main-2609160137 Move the always-on branch register offsets into a critical_cbcrs array, describe the DFS RCGs through qcom_cc_driver_data and move the register programming into the clk_regs_configure callback. Use qcom_cc_probe() to perform the common initialization instead of open-coding it in the driver's probe. Assisted-by: LLM Signed-off-by: Abel Vesa Reviewed-by: Konrad Dybcio --- drivers/clk/qcom/gcc-sc7280.c | 54 ++++++++++++++++++++++-----------------= ---- 1 file changed, 28 insertions(+), 26 deletions(-) diff --git a/drivers/clk/qcom/gcc-sc7280.c b/drivers/clk/qcom/gcc-sc7280.c index 4502926a2691..03913ae16e8f 100644 --- a/drivers/clk/qcom/gcc-sc7280.c +++ b/drivers/clk/qcom/gcc-sc7280.c @@ -3438,7 +3438,34 @@ static const struct regmap_config gcc_sc7280_regmap_= config =3D { .fast_io =3D true, }; =20 +static const u32 gcc_sc7280_critical_cbcrs[] =3D { + 0x26004, /* GCC_CAMERA_AHB_CLK */ + 0x26028, /* GCC_CAMERA_XO_CLK */ + 0x27004, /* GCC_DISP_AHB_CLK */ + 0x2701c, /* GCC_DISP_XO_CLK */ + 0x28004, /* GCC_VIDEO_AHB_CLK */ + 0x28014, /* GCC_VIDEO_XO_CLK */ + 0x71004, /* GCC_GPU_CFG_AHB_CLK */ +}; + +static void gcc_sc7280_regs_configure(struct device *dev, struct regmap *r= egmap) +{ + regmap_update_bits(regmap, 0x7100C, BIT(13), BIT(13)); + + /* FORCE_MEM_CORE_ON for ufs phy ice core clocks */ + qcom_branch_set_force_mem_core(regmap, gcc_ufs_phy_ice_core_clk, true); +} + +static const struct qcom_cc_driver_data gcc_sc7280_driver_data =3D { + .clk_cbcrs =3D gcc_sc7280_critical_cbcrs, + .num_clk_cbcrs =3D ARRAY_SIZE(gcc_sc7280_critical_cbcrs), + .dfs_rcgs =3D gcc_dfs_clocks, + .num_dfs_rcgs =3D ARRAY_SIZE(gcc_dfs_clocks), + .clk_regs_configure =3D gcc_sc7280_regs_configure, +}; + static const struct qcom_cc_desc gcc_sc7280_desc =3D { + .driver_data =3D &gcc_sc7280_driver_data, .config =3D &gcc_sc7280_regmap_config, .clks =3D gcc_sc7280_clocks, .num_clks =3D ARRAY_SIZE(gcc_sc7280_clocks), @@ -3456,32 +3483,7 @@ MODULE_DEVICE_TABLE(of, gcc_sc7280_match_table); =20 static int gcc_sc7280_probe(struct platform_device *pdev) { - struct regmap *regmap; - int ret; - - regmap =3D qcom_cc_map(pdev, &gcc_sc7280_desc); - if (IS_ERR(regmap)) - return PTR_ERR(regmap); - - /* Keep some clocks always-on */ - qcom_branch_set_clk_en(regmap, 0x26004);/* GCC_CAMERA_AHB_CLK */ - qcom_branch_set_clk_en(regmap, 0x26028);/* GCC_CAMERA_XO_CLK */ - qcom_branch_set_clk_en(regmap, 0x27004);/* GCC_DISP_AHB_CLK */ - qcom_branch_set_clk_en(regmap, 0x2701c);/* GCC_DISP_XO_CLK */ - qcom_branch_set_clk_en(regmap, 0x28004);/* GCC_VIDEO_AHB_CLK */ - qcom_branch_set_clk_en(regmap, 0x28014);/* GCC_VIDEO_XO_CLK */ - qcom_branch_set_clk_en(regmap, 0x71004);/* GCC_GPU_CFG_AHB_CLK */ - regmap_update_bits(regmap, 0x7100C, BIT(13), BIT(13)); - - /* FORCE_MEM_CORE_ON for ufs phy ice core clocks */ - qcom_branch_set_force_mem_core(regmap, gcc_ufs_phy_ice_core_clk, true); - - ret =3D qcom_cc_register_rcg_dfs(regmap, gcc_dfs_clocks, - ARRAY_SIZE(gcc_dfs_clocks)); - if (ret) - return ret; - - return qcom_cc_really_probe(&pdev->dev, &gcc_sc7280_desc, regmap); + return qcom_cc_probe(pdev, &gcc_sc7280_desc); } =20 static struct platform_driver gcc_sc7280_driver =3D { --=20 2.54.0 From nobody Fri Sep 25 05:31:34 2026 Received: from mx0b-0031df01.pphosted.com (mx0b-0031df01.pphosted.com [205.220.180.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 7162F48988A for ; Wed, 16 Sep 2026 10:30:02 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.180.131 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1789554625; cv=none; b=X5qufCxvJk8bK6sk9Zy9xcTJ7cXOKp/fdZjIL1bLCOKUDEZkYyCJcwKX1vVmDfV5pKJfPBiAutxdRpW9dZtRQq/pc7zGBJJSxC+A4X8UnfKx7xnn1JaslNowdZHSfgEErJj3mkZnBB2NfiNFAdQVpr4fELpagnF+bnwjD31c9c0= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1789554625; c=relaxed/simple; bh=X4mrTovvzWU4pCQoDOQAcqFq4rqaImzZ2MR46kww2do=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=cdSXuPTrg+zL3JKJGYLJdtEVX6OuLUNrU2UW7xRngXGWJTagnbaDVRoJOXwborFUnAZ2gRO8WwYbs+Ekoy1ddzp20VTLU1KyqVup18ER/ptylI9l+r9o066LveilZqJgIoOFxf6w5Pya6yHHtu9MeePamJSYOyEwQ1yHc8/XLHg= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=X9D0S62O; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=bGcM7keG; arc=none smtp.client-ip=205.220.180.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="X9D0S62O"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="bGcM7keG" Received: from pps.filterd (m0279868.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 68G92jVp2121983 for ; Wed, 16 Sep 2026 10:30:00 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= 5WEOM3pZT2Sz5mDmvEF/K4tpmGZSJsKRSyBEHrIbj6A=; b=X9D0S62OcZ/f/2If 3yKcOHwklR/nMgjv19X4JU1rptQuMBhXni8Wa0rXtWa9BfiIFQDmVMmgoD5rDMEQ zx4nfaFZZQaEHqDS8vhh5OZqLPGzhcAea9v211I3/6Mjib6nD2DMOos+j65leRX6 D3J6xydOWKiGMq6RxXwrwxaB8GM6lR20OjVopc4o3lel430rjLqZY0pokvE1A1S7 FuChGRQzY2vFSd/M5OGhUGM9eQyZF0YFkVsVMl1b0Oc2osiL8KsMXkqscudKbKfc pxvwCGCGVhfNfsR6fj5A2ziVtjB02Nky4l6/OGDS3/32NplQE+k/Ss/70RTtuIeW dN3Zfw== Received: from mail-qk1-f198.google.com (mail-qk1-f198.google.com [209.85.222.198]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4gqkv7hhs6-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Wed, 16 Sep 2026 10:29:59 +0000 (GMT) Received: by mail-qk1-f198.google.com with SMTP id af79cd13be357-93a2d361e1aso18802685a.1 for ; Wed, 16 Sep 2026 03:29:59 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1789554599; x=1790159399; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :content-type:mime-version:subject:date:from:from:to:cc:subject:date :message-id:reply-to:content-type; bh=5WEOM3pZT2Sz5mDmvEF/K4tpmGZSJsKRSyBEHrIbj6A=; b=bGcM7keGiNkH+KqzqHHL4FpMyDfv40r74GJdNzRpWq+RcyQqYsAEkUv8dmCu2qqONY 64Bov6c+j//y6swUW0za9lIpx8YzUOX/WK0C+6j/naxu8nX2Wa3tDxOzey9nJAYpvjmc VH95wgJbNihJ70ePfVbXVkeqs5zcugZBFVDTdanMsWw4qdIKYnsHkGOEf1r32Suo9DZB bKb9oTV9yRd8xEjbYbsb+09r+JgTxoogOO9vCd3DGddf/fQmxz1W/XYtXaVM8Dm4QvGq gW5SFHKPTLPfW7orfYQRM5dKGAL1dD0qpo6RcraqJK0g2zH+UiaKnqObpRJ+UfP/Phq7 pYLQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20260707; t=1789554599; x=1790159399; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :content-type:mime-version:subject:date:from:x-gm-gg :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to :content-type; bh=5WEOM3pZT2Sz5mDmvEF/K4tpmGZSJsKRSyBEHrIbj6A=; b=upL0AjOEsZ9l849A4eHCrRtvdvD+2C/zOsJCin5eg+F4nqGu2M9oczmKLQVlTLNIbs 4AcOg33dp4bldF1p3nqujsj5LP17UV/3I7oTIo0+Vdykz10TNJhhfok3BCjTQs0TWeSX IinQFEAuqOugXOWK8C+QX0p/s0HrFFhk3uDcSvasxK6FlEaFGBbcGPnpx/QNYfbt/rZC SsD48xHSO4KLbEVOduWT57v3U0JPhKyb+nSiYMaLSPgjXBtGvBzzgvGBr7DA36BhkLlK v6ngHK4S9n2rJYXvmD//9/hZqiXedzP4W109ZHKuDaxPA0DI/+3bxHbLOA4SHyMbzt2o 9EVQ== X-Forwarded-Encrypted: i=1; AKwUvBxBW7y6G0iy/gadCnMdO0oMP2a3fgWR1fdpijxvZd21w007wTexoNmO5LOnskhx/0N2gSIq3oakbKCDAxk=@vger.kernel.org X-Gm-Message-State: AFuF++mkt7jORvOqP+O8p5u9S/X4/adONXzxqMhcDGQc2JMDtrer2oic T6NkyMEYkl98X+cz9x1+lw9SngCgYwQF1uhQVwQoVifIBRYeISpM23p3r+S1HiAkCzvUvAfYU33 bNHC5cLxZOjmy2NwbvnblzMlsxFwYtE8Vyk8LkpHNTHJqUGJAda+NUL62H8V6XHEblmo= X-Gm-Gg: AYBFou1sD0hrEOZ1apt9NVLWPPKZJ7IGEMUGSCCBoI66QpF4jcjYXe7gfHfIAW7x9M6 Kbehc92YCl10dArfRZEjJb5HHG3KMdJPMzGKmH0lDjsyLMKyUglGqB7lafLW1cUpLlQL0ZO3Es+ 4wkTEQ6FfUpoW4o9hZDG5+9hcCtD4oS4G2Xj51DEIbwk2eoVZWkioEMHob5EdqkZLP9Vbqg8X4M 90Jdte6my+5QCeXBsgPepIYIKTJYMbprT8qlwfDc0hVEY5x5/3j0D1+CEDTvpE7sm7rpIRFGnHo ax8WmfBrleNxcW/uujSbeRo/pk001R9H0lz5p7jP7lLqFfkgYYv5uNSrh5AxhH65fqA5Wd4/Jg7 bCD7CYIs= X-Received: by 2002:a05:620a:a18c:10b0:93b:bc51:b40 with SMTP id af79cd13be357-93bbc510c4dmr130502685a.2.1789554599193; Wed, 16 Sep 2026 03:29:59 -0700 (PDT) X-Received: by 2002:a05:620a:a18c:10b0:93b:bc51:b40 with SMTP id af79cd13be357-93bbc510c4dmr130499085a.2.1789554598592; Wed, 16 Sep 2026 03:29:58 -0700 (PDT) Received: from [127.0.1.1] ([86.121.170.232]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-49e83dbb0c1sm71633805e9.14.2026.09.16.03.29.56 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 16 Sep 2026 03:29:57 -0700 (PDT) From: Abel Vesa Date: Wed, 16 Sep 2026 13:28:38 +0300 Subject: [PATCH 22/48] clk: qcom: gcc-sc8280xp: Use common clock controller probe data Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20260916-clk-qcom-rework-legacy-always-on-clocks-v1-22-25a24e50f82a@oss.qualcomm.com> References: <20260916-clk-qcom-rework-legacy-always-on-clocks-v1-0-25a24e50f82a@oss.qualcomm.com> In-Reply-To: <20260916-clk-qcom-rework-legacy-always-on-clocks-v1-0-25a24e50f82a@oss.qualcomm.com> To: Bjorn Andersson , Abel Vesa , Stephen Boyd , Brian Masney , Jerome Brunet Cc: linux-arm-msm@vger.kernel.org, linux-clk@vger.kernel.org, linux-kernel@vger.kernel.org, Abel Vesa X-Mailer: b4 0.16-dev-0e65f X-Developer-Signature: v=1; a=openpgp-sha256; l=2673; i=abel.vesa@oss.qualcomm.com; h=from:subject:message-id; bh=X4mrTovvzWU4pCQoDOQAcqFq4rqaImzZ2MR46kww2do=; b=owEBbQKS/ZANAwAKARtfRMkAlRVWAcsmYgBqqm9g9I551LMLbD+EsKc3LDqTEvZR1TtX9WjnA pvo1MGJYKqJAjMEAAEKAB0WIQRO8+4RTnqPKsqn0bgbX0TJAJUVVgUCaqpvYAAKCRAbX0TJAJUV Vi2LD/96i7KL91hbFWT2FaeFarj9W7KGu6JTl6klg8MGWDovFQWZPCz0NAfx2Q+iJMsMq1RzCeQ aB6MuVKgu4kNgG0qyBr9+i4aSf81oeAHcSeIhPBb3N7HAhUQRkDXrcMqpfQlXtSJ3uIXc1olHd1 KArfnD/L6o2dwpb8xkaaUCLO1Vg1MXHcJ1nbRgoHdAhhJn8U3TTjIgT7tB0q5C2gPBMUI6zH4ry 7+w//NJiXWAa2fFCj+b9ppZHvfDWhoyrYKitezyp0GVCpFRSo5AcvtaoeBRGmEM5V+XvoE3kb2B eF8ktt/b5i2DgVLNtiES9xxbaRlO1hS1sSuzSdZCbUFYykXTmNeN9vqhGE90Ohx1AxLUbQehf3t iQrAS+/RQkAu6Kmg3yVcUaew1Vdjlg+bCjW9sebbxlW82NJYCdfavFnTYbGbohcujMC6bEO0jx5 0NgfnxswlHPv5VTR75uv8TWoJXXTuPB/Nplv30NnTodXR2M6hWayyxALP6Mlih7K9W9UHIb1gzY LXFqA3BnjGyEID8sViKIbyfpSdwkKtzNSDbEkx2LvxQFkNfdtYlDUgmxd8wlFAE2lKq5AHbuLA+ Zgya+vb+8vN03wsSzUloMNyQnbT9eOn5MFTeg7Ytq0HoJf/5VnCm7JBUkc/SePnm96aDI/7elt9 72SCeTDAsFS7W5Q== X-Developer-Key: i=abel.vesa@oss.qualcomm.com; a=openpgp; fpr=6AFF162D57F4223A8770EF5AF7BF214136F41FAE X-Proofpoint-ORIG-GUID: r2rp6Ap9G0C-KQCwFFOVmlos1eOcne1Z X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwOTE2MDEzNyBTYWx0ZWRfXxYuTcD2UrPuS QzTQdYtVyhmIXavO9xlMF/LTxjJ2fbcR64KSaW/nCNq1LbB7/pY44WC1ONVIRj8Vo1cYZ7hfJG/ 339VG0tGCSALf7IX+QkmuU+48mBxIOaV18SNqd8DJcC6DGeMW3jeXyB8W1h1QsCqHp26tPMQJd3 WaCU/DkBXdaeZpBcWQdzWcxE7HZC3k5+Vh7WYSdwBzcZubBhDnzq+mb7lk0Ala2v3kj4hHjMHP7 aUfKM0GM6VdvqoG9L0e/8DShVWrAOix1wHUII+1i1Zrn9NpZbqMdDOGQVcoEXQ80o4LAp1qRBZ3 PQz1LgTxBFuCMZubrRQLwS1Ez5oOa3dGcb3AKevxGfgLHiqfnKJgrKU6TSQ7Jb1CVM0U/6+7QHQ pNCYzjtx6fJu/50Mn+3asMl1jAg/7x17DOuyhRhHmEEbyUczQxCNHpQa30euMXOmaL1e1ZCFVNY 1cehQ8Gp039sj8eEZhg== X-Authority-Analysis: v=2.4 cv=eKmGH3p1 c=1 sm=1 tr=0 ts=6aaa6fa7 cx=c_pps a=qKBjSQ1v91RyAK45QCPf5w==:117 a=po8fGBi+ks8MzcVQGuqtFQ==:17 a=IkcTkHD0fZMA:10 a=VdqzKS8jKosA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=ZpdpYltYx_vBUK5n70dp:22 a=EUspDBNiAAAA:8 a=jsp9moliOvjHjNtoyGEA:9 a=QEXdDO2ut3YA:10 a=NFOGd7dJGGMPyQGDc5-O:22 X-Proofpoint-Spam-Info: AW1haW4tMjYwOTE2MDEzNyBTYWx0ZWRfX2y4VUyS/NNH9 zlDqHEt99UyTWdQ8FxZCOMZ5sUsFPkG+kal7C/gliFIPpUF3pL4Rz+y5BR5Ga+RuxYjHW4eUE0d tKI7TBdpPNUNEbbudCMqz2YSnNRF1Bo= X-Proofpoint-GUID: r2rp6Ap9G0C-KQCwFFOVmlos1eOcne1Z X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1176,Hydra:6.1.134,FMLib:17.12.100.49 definitions=2026-09-15_05,2026-09-15_02,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 impostorscore=0 lowpriorityscore=0 adultscore=0 bulkscore=0 clxscore=1015 phishscore=0 spamscore=0 priorityscore=1501 malwarescore=0 suspectscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2609040000 definitions=main-2609160137 Move the always-on branch register offsets into a critical_cbcrs array and describe the DFS RCGs through qcom_cc_driver_data. Delegate always-on branch and DFS initialization to the common probe path while retaining the device-specific setup in the driver's probe. Assisted-by: LLM Signed-off-by: Abel Vesa Reviewed-by: Konrad Dybcio --- drivers/clk/qcom/gcc-sc8280xp.c | 35 ++++++++++++++++++++--------------- 1 file changed, 20 insertions(+), 15 deletions(-) diff --git a/drivers/clk/qcom/gcc-sc8280xp.c b/drivers/clk/qcom/gcc-sc8280x= p.c index 2ab111585d7f..7fe5ad529de0 100644 --- a/drivers/clk/qcom/gcc-sc8280xp.c +++ b/drivers/clk/qcom/gcc-sc8280xp.c @@ -7509,7 +7509,27 @@ static const struct regmap_config gcc_sc8280xp_regma= p_config =3D { .fast_io =3D true, }; =20 +static const u32 gcc_sc8280xp_critical_cbcrs[] =3D { + 0x26004, /* GCC_CAMERA_AHB_CLK */ + 0x26020, /* GCC_CAMERA_XO_CLK */ + 0x27004, /* GCC_DISP_AHB_CLK */ + 0x27028, /* GCC_DISP_XO_CLK */ + 0x71004, /* GCC_GPU_CFG_AHB_CLK */ + 0x28004, /* GCC_VIDEO_AHB_CLK */ + 0x28028, /* GCC_VIDEO_XO_CLK */ + 0xbb004, /* GCC_DISP1_AHB_CLK */ + 0xbb028, /* GCC_DISP1_XO_CLK */ +}; + +static const struct qcom_cc_driver_data gcc_sc8280xp_driver_data =3D { + .clk_cbcrs =3D gcc_sc8280xp_critical_cbcrs, + .num_clk_cbcrs =3D ARRAY_SIZE(gcc_sc8280xp_critical_cbcrs), + .dfs_rcgs =3D gcc_dfs_clocks, + .num_dfs_rcgs =3D ARRAY_SIZE(gcc_dfs_clocks), +}; + static const struct qcom_cc_desc gcc_sc8280xp_desc =3D { + .driver_data =3D &gcc_sc8280xp_driver_data, .config =3D &gcc_sc8280xp_regmap_config, .clks =3D gcc_sc8280xp_clocks, .num_clks =3D ARRAY_SIZE(gcc_sc8280xp_clocks), @@ -7538,21 +7558,6 @@ static int gcc_sc8280xp_probe(struct platform_device= *pdev) goto err_put_rpm; } =20 - /* Keep some clocks always-on */ - qcom_branch_set_clk_en(regmap, 0x26004); /* GCC_CAMERA_AHB_CLK */ - qcom_branch_set_clk_en(regmap, 0x26020); /* GCC_CAMERA_XO_CLK */ - qcom_branch_set_clk_en(regmap, 0x27004); /* GCC_DISP_AHB_CLK */ - qcom_branch_set_clk_en(regmap, 0x27028); /* GCC_DISP_XO_CLK */ - qcom_branch_set_clk_en(regmap, 0x71004); /* GCC_GPU_CFG_AHB_CLK */ - qcom_branch_set_clk_en(regmap, 0x28004); /* GCC_VIDEO_AHB_CLK */ - qcom_branch_set_clk_en(regmap, 0x28028); /* GCC_VIDEO_XO_CLK */ - qcom_branch_set_clk_en(regmap, 0xbb004); /* GCC_DISP1_AHB_CLK */ - qcom_branch_set_clk_en(regmap, 0xbb028); /* GCC_DISP1_XO_CLK */ - - ret =3D qcom_cc_register_rcg_dfs(regmap, gcc_dfs_clocks, ARRAY_SIZE(gcc_d= fs_clocks)); - if (ret) - goto err_put_rpm; - ret =3D qcom_cc_really_probe(&pdev->dev, &gcc_sc8280xp_desc, regmap); if (ret) goto err_put_rpm; --=20 2.54.0 From nobody Fri Sep 25 05:31:34 2026 Received: from mx0a-0031df01.pphosted.com (mx0a-0031df01.pphosted.com [205.220.168.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 4235A4F0533 for ; Wed, 16 Sep 2026 10:30:05 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.168.131 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1789554611; cv=none; b=H9zGW+pvbC0gmhzCBNinTNqXMPVi3usLMnwcBfDz8Qo2O8d3HuACTkNqtuAJfveemTzJjlXsAbf2o0l4yA1YSQgqtxOw2SnnmBvOq8uSTzlOPQqnhXMKwxyPx2lvnD69Y5xs6zapKSG08NDLa+LKYte0yLk65Z7KS6ZjoAfh5l4= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1789554611; c=relaxed/simple; bh=q6WsPo4Sb7dMV3C/p7zOVruxQdz3njTR2SW+b+HeblE=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=ggOJPLPhC8+3XdoXqLQakeeDeLPh13NoUSqc5sy2hsTgPiSTSdc+D9FDPMJQynbvvEfPG237cxUdilWqiXW1SmoE1p86cM/45gFZtjXRp9jA2kgRpUt0UmqNtGIT4GJjtTqdk+4h38u2qHqUTLJOgbrZrNOZddM89UXZ1B7NRJg= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=oNXqg58a; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=hLuEhz+P; arc=none smtp.client-ip=205.220.168.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="oNXqg58a"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="hLuEhz+P" Received: from pps.filterd (m0279862.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 68G92ue81721210 for ; Wed, 16 Sep 2026 10:30:02 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= pY8CUDObNwxHwovpcARsp1Pjr3/ZYxUlvUYEuzUE33g=; b=oNXqg58a/EOyAOuB rvx0QHK3rusC8/8LbkpceZ/5mNVKXRV7cP8gqIgpT8Dvw5uKgzypf8d6fonQA8JJ bU9Bd0UGBRYEu+Rr/ojKUniGBRcG4D89G32RM0CYAlBSq1iwtUvyzXX16jNjMCMY hkO8O5/ksU7alU7HLnWo9MSuOgYEwupR+6oC7dZd30pU1o5du+mQb7BCpWMOeHVD 96SPCCOTb6Kv9SoxUc98BNtELVnCAmKXGxhmi9HQsJ2F7jEvZDAxIdYgHQ6IZhjM lGxaTNWyPi6D7WUEvhy6XimUxj1WP7d99YWXLU8RC46tCpuYs0+gRelLSg/F7Yca yLPi0g== Received: from mail-qk1-f200.google.com (mail-qk1-f200.google.com [209.85.222.200]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4gqbmnkbxt-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Wed, 16 Sep 2026 10:30:02 +0000 (GMT) Received: by mail-qk1-f200.google.com with SMTP id af79cd13be357-9394ad7f64aso885948885a.3 for ; Wed, 16 Sep 2026 03:30:02 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1789554601; x=1790159401; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :content-type:mime-version:subject:date:from:from:to:cc:subject:date :message-id:reply-to:content-type; bh=pY8CUDObNwxHwovpcARsp1Pjr3/ZYxUlvUYEuzUE33g=; b=hLuEhz+PIhKQPAO+PNeoemtemk1LkPmBNtmbUVZHe20cNSRKWVYiS8VJQQtbx0jbq5 KO2Rg4MZ03VAkEHZMt1b9PvvXu5ni9cNT2E5InsSXs+WdTzVgg2aYU8mlorMvqpZ2Q5d j2hDe9abe+JpAJKbElFP4DVL7PBciY4tKzAwqDnIVJFoADzjMzuTGwzJ/dhS0jSU2DJs qeRF33GfNV965+O6adXpbtOLAdJxqhjTDNCyLLsxoov9/FxxuT7mp6d7VizjFkGYjeMG RhXs3flldZUhzboIe0VaozPvNF2mm4oY4VqUQoXSRBBQO3emo6A0srnmPprPBfvppu5H vogg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20260707; t=1789554601; x=1790159401; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :content-type:mime-version:subject:date:from:x-gm-gg :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to :content-type; bh=pY8CUDObNwxHwovpcARsp1Pjr3/ZYxUlvUYEuzUE33g=; b=LjuST0brOhS/7guuCVEFHn+nZeaWL2rRmqMxf6LIJK970hTtJh/G85SmXWHDZDP6by PyLhUrgxuIX5lh27b21m47VL7e6pusIrebuuiBtsA/1S5ZHOUd/ZaAfX80+FTQC7FZG8 b6Cmd/Kuj2HtsoGpkpD3+cViFGtW5bTwurgd1a1m8f4P2dJjv0TArjT5PFz35Uzht9aJ 8S2baowknJlpJWhu8+XBddhmJ88mZa9JdDK8DYDzhbTJoHQ7hfNNWRC3HuyPJCfG5K1s lQEXEhOnRceWHhrqwGL8+QZwJ+uZXBuk2XnVaLgvUkOZxmingZ7h57MsYrpN6fHj4wkG gQ/g== X-Forwarded-Encrypted: i=1; AKwUvBwUa/r5TE4+O2qn/25BCLT5TZldpSzQznrOg4ZJgjafh34kjGp+gUi492QJojgwIsLE8MLrpJahL3PBrs8=@vger.kernel.org X-Gm-Message-State: AFuF++njfN18KMLVHR+SlMyU4r6D5kiWXx+fZDsLHstmPGzykDNmXTaO U88EaLlYseOHM+B7BAPpjUKJCsl4VvrHkF7RDKVLTJH2f+T/OvZ6MpsMbCN7CkzppjJfGZI6yCo 6/9y6oIs8UUCp7d0m1zb4reYYpJVkuLL6DUh8Vviabprapcw/6gcVLMVf6ZCzf7v2+GQ= X-Gm-Gg: AYBFou0PobH4jwCjA4LVvnWPvrE4eqybvnvWgOOI+xE7JjVvXiqruCG5vbTsuiOdKjO EjOq1e2rZUjBgbpnBAq70RtGXk+G75/XPY7oGgLiPh/ruesRDPrtJ0rF0d6MriQkjZRXDPuG9Bt yFWj1kJhW1IC07A2R4560ggkj1VYwKfcPp/NHgVAckgkHvK3gbkwTcOnZ/Kn/W9fpO808ex/AhD VaNZc3U+9Q4E0XMq4a8ZEMuI9t2lC7HXHTJHYiHg3E9Ie36/BSmkdZJKWFOjPCNjbqbML3QTDVU PANVArtVvvvhCHvXEfcCBIw5+tauXVo2FO+uryDSbvN2tQglciqKIw9n1C8tS4yV6KMUS1nPY0Q z7Ikyh4E= X-Received: by 2002:a05:620a:6008:b0:923:7821:dc0d with SMTP id af79cd13be357-93bb787cce2mr310412985a.33.1789554601088; Wed, 16 Sep 2026 03:30:01 -0700 (PDT) X-Received: by 2002:a05:620a:6008:b0:923:7821:dc0d with SMTP id af79cd13be357-93bb787cce2mr310408985a.33.1789554600585; Wed, 16 Sep 2026 03:30:00 -0700 (PDT) Received: from [127.0.1.1] ([86.121.170.232]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-49e83dbb0c1sm71633805e9.14.2026.09.16.03.29.58 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 16 Sep 2026 03:29:59 -0700 (PDT) From: Abel Vesa Date: Wed, 16 Sep 2026 13:28:39 +0300 Subject: [PATCH 23/48] clk: qcom: gcc-sdx55: Use common clock controller probe data Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20260916-clk-qcom-rework-legacy-always-on-clocks-v1-23-25a24e50f82a@oss.qualcomm.com> References: <20260916-clk-qcom-rework-legacy-always-on-clocks-v1-0-25a24e50f82a@oss.qualcomm.com> In-Reply-To: <20260916-clk-qcom-rework-legacy-always-on-clocks-v1-0-25a24e50f82a@oss.qualcomm.com> To: Bjorn Andersson , Abel Vesa , Stephen Boyd , Brian Masney , Jerome Brunet Cc: linux-arm-msm@vger.kernel.org, linux-clk@vger.kernel.org, linux-kernel@vger.kernel.org, Abel Vesa X-Mailer: b4 0.16-dev-0e65f X-Developer-Signature: v=1; a=openpgp-sha256; l=2331; i=abel.vesa@oss.qualcomm.com; h=from:subject:message-id; bh=q6WsPo4Sb7dMV3C/p7zOVruxQdz3njTR2SW+b+HeblE=; b=owEBbQKS/ZANAwAKARtfRMkAlRVWAcsmYgBqqm9h3El7ODq+vNnP0tl/+8g+kXxkCs6h3spem 7aV51gpoyeJAjMEAAEKAB0WIQRO8+4RTnqPKsqn0bgbX0TJAJUVVgUCaqpvYQAKCRAbX0TJAJUV VldwD/4m0Hwwxs8iai4qsYgB6V/DjyJTqFopMxAOJynBtlcbwL2wiElQG3ZCkQjou4uxgA1E0n2 3cIOZw9qJeBGwdlJOg8DzJ2RY6MkV678lxmv72HRTFSNy4+hthAqoL7GbmoGeMfOS2qhldoB4R2 CXqkgZ/VVZk3QPED+TiPBy+yjP7157Ft75ejcktgNhGnXTCwnEj3aj1IQ+qXdCOsw1m9ar6/Jhv ER1hgal1zrNGoXcFYtlXk0ZkRgpmKnHC099ECdhC2rw+Pm9v2R1tpFJ7ElhmzH9b59h+2+nE680 S8bF6g7JHgH3Zh+XUzd850jQ7D3etEm9QW1zcScuLa/pB/vDHV9lxBDZgTCM95+F4fvfQ/eh6OT 4cM55wBDjk6E5BFmm+IEVmUjvZAFxI7HlM7jYuNEk57oOApPaOr6tObh8zI3sI75FnbRAa7qvnm 1YOkrVlUL/lmMbXfffYWh83kDlRIe98K+UaO+tMzByVbHP4v+6/NCTE0Wb+K3jR9CeOfITdvfRk 3juu8vajoDiFNBROweIaD2GWTHMUuPADo6Cu6rDlFrypdodBB4kbsL4xJ8S5GoMUEgguXjpdCHM A0F19oyx8T74CkIcsNW2EE4UvoFFbu/+TmNgtERT4YgZzC0tOwP0D8aMqqO6z99CQ1ttdsWzYeC UD6mjgc63ArWQHw== X-Developer-Key: i=abel.vesa@oss.qualcomm.com; a=openpgp; fpr=6AFF162D57F4223A8770EF5AF7BF214136F41FAE X-Authority-Analysis: v=2.4 cv=POyaavqC c=1 sm=1 tr=0 ts=6aaa6faa cx=c_pps a=hnmNkyzTK/kJ09Xio7VxxA==:117 a=po8fGBi+ks8MzcVQGuqtFQ==:17 a=IkcTkHD0fZMA:10 a=VdqzKS8jKosA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=_K5XuSEh1TEqbUxoQ0s3:22 a=EUspDBNiAAAA:8 a=XazbkJH4cJJKrr3KiP8A:9 a=QEXdDO2ut3YA:10 a=PEH46H7Ffwr30OY-TuGO:22 X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwOTE2MDEzNyBTYWx0ZWRfX6LtZf5uzglD7 f75sWyfcRfM0JrlaDOhqspKS3H9YnqR+cHn5QZbOjIWNyDWGfEj6SIMnfLl1hntfkMnRHf6Ow8E b4i/rvZw3M3yovfAgI3GuIZ3ird/EvXX08Z5nVChHz1SoFCCb+er/XAjStEidarIQXcczD7AZK4 F2pAv3Aj4Qy8LWmBdeg9GwoSMGd1xgdNpdv6OsmXDNqQJ5gbyAKi+p4pSV8bq9yB8vZuiDD52op 38+ViS8wyS+lvuEVLPJNNuzbZwEoNUkS+wg9DL5P6D/7ZP+bcYS3hDf1qlIjB2+Vf0eWeExKsEo 06PiKZ0+e60RWyewBNGoNzt5gLEgPZIb3qHieYrAmBe7KEsM0uwWq/2MEOu/IUVbqQN3OHiP3y0 bbXTGwHmFLYcP9UYqP1wAtCrLPsnHLgn2XVCvav5aGPKay3fBd/kqezCBCOf/WrOYR5fO6uFokO /OcpsrlGRMApVikh+6g== X-Proofpoint-GUID: 2MwiHmaWiiF5NQnJaLauzyZNhzaSJcdI X-Proofpoint-Spam-Info: AW1haW4tMjYwOTE2MDEzNyBTYWx0ZWRfX7VcuHAGQIFNn IzDxNM5N+4Z5vAbrgS7fmj7KoPfCfKA0tkybS6tZjoT+WFcy/FjSQYx8FnK7x65xeYPhhp1+UmK 3nPUnM1ss/OBLGJ3QbdTx/Cf0rjAzUM= X-Proofpoint-ORIG-GUID: 2MwiHmaWiiF5NQnJaLauzyZNhzaSJcdI X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1176,Hydra:6.1.134,FMLib:17.12.100.49 definitions=2026-09-15_05,2026-09-15_02,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 priorityscore=1501 adultscore=0 bulkscore=0 clxscore=1015 phishscore=0 suspectscore=0 impostorscore=0 spamscore=0 lowpriorityscore=0 malwarescore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2609040000 definitions=main-2609160137 Move the always-on branch register offsets into a critical_cbcrs array and move the register programming into the clk_regs_configure callback. Use qcom_cc_probe() to perform the common initialization instead of open-coding it in the driver's probe. Assisted-by: LLM Signed-off-by: Abel Vesa Reviewed-by: Konrad Dybcio --- drivers/clk/qcom/gcc-sdx55.c | 31 +++++++++++++++++++------------ 1 file changed, 19 insertions(+), 12 deletions(-) diff --git a/drivers/clk/qcom/gcc-sdx55.c b/drivers/clk/qcom/gcc-sdx55.c index 84c507656e8f..7cede6d38747 100644 --- a/drivers/clk/qcom/gcc-sdx55.c +++ b/drivers/clk/qcom/gcc-sdx55.c @@ -1587,7 +1587,25 @@ static const struct regmap_config gcc_sdx55_regmap_c= onfig =3D { .fast_io =3D true, }; =20 +static const u32 gcc_sdx55_critical_cbcrs[] =3D { + 0x6d008, /* GCC_SYS_NOC_CPUSS_AHB_CLK */ +}; + +static void gcc_sdx55_regs_configure(struct device *dev, struct regmap *re= gmap) +{ + /* Keep some clocks always-on */ + regmap_update_bits(regmap, 0x6d008, BIT(21), BIT(21)); /* GCC_CPUSS_AHB_C= LK */ + regmap_update_bits(regmap, 0x6d008, BIT(22), BIT(22)); /* GCC_CPUSS_GNOC_= CLK */ +} + +static const struct qcom_cc_driver_data gcc_sdx55_driver_data =3D { + .clk_cbcrs =3D gcc_sdx55_critical_cbcrs, + .num_clk_cbcrs =3D ARRAY_SIZE(gcc_sdx55_critical_cbcrs), + .clk_regs_configure =3D gcc_sdx55_regs_configure, +}; + static const struct qcom_cc_desc gcc_sdx55_desc =3D { + .driver_data =3D &gcc_sdx55_driver_data, .config =3D &gcc_sdx55_regmap_config, .clks =3D gcc_sdx55_clocks, .num_clks =3D ARRAY_SIZE(gcc_sdx55_clocks), @@ -1605,18 +1623,7 @@ MODULE_DEVICE_TABLE(of, gcc_sdx55_match_table); =20 static int gcc_sdx55_probe(struct platform_device *pdev) { - struct regmap *regmap; - - regmap =3D qcom_cc_map(pdev, &gcc_sdx55_desc); - if (IS_ERR(regmap)) - return PTR_ERR(regmap); - - /* Keep some clocks always-on */ - qcom_branch_set_clk_en(regmap, 0x6d008); /* GCC_SYS_NOC_CPUSS_AHB_CLK */ - regmap_update_bits(regmap, 0x6d008, BIT(21), BIT(21)); /* GCC_CPUSS_AHB_C= LK */ - regmap_update_bits(regmap, 0x6d008, BIT(22), BIT(22)); /* GCC_CPUSS_GNOC_= CLK */ - - return qcom_cc_really_probe(&pdev->dev, &gcc_sdx55_desc, regmap); + return qcom_cc_probe(pdev, &gcc_sdx55_desc); } =20 static struct platform_driver gcc_sdx55_driver =3D { --=20 2.54.0 From nobody Fri Sep 25 05:31:34 2026 Received: from mx0a-0031df01.pphosted.com (mx0a-0031df01.pphosted.com [205.220.168.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 249753AAF70 for ; Wed, 16 Sep 2026 10:30:07 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.168.131 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1789554630; cv=none; b=VljPTjXv3ww3qhHjhUjzfXyYU3Qc3J/iKC+uvZT5tJIk9Qvb0AzzrMXW9HO6Szyj1uW4Z8XrhDI3HLbp9IRAXggJEkecaiHyKXuLLSxDGGKgP3aRWA4oNnu5g8sfYpzPPZ8hk0ms4f7UPBQuH8v7s/Q4Y5WXvM9m0jcmIC2z/uA= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1789554630; c=relaxed/simple; bh=b9VHnUQlJBlralyapGmuvtRphCZuwYIIiU7q4+OGFvU=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=WvPnwIJJ/pibtyzBZvWc3Ss708ePrZ80UrMXWuRAJqb6GfSFERLQNwv+S+JMhXPd7cXiGa7ipKVcBiIkYTK5MX0Bj3adrD03DeqB1fZHboo+ALenwah9mliLHsp6JjAPCwSzgGxDpL3qgYrfKEtaAAnAilJz527tMnHi9DBQL9w= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=LKVCswzx; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=E6a21dWr; arc=none smtp.client-ip=205.220.168.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="LKVCswzx"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="E6a21dWr" Received: from pps.filterd (m0279863.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 68G92eQ42348092 for ; Wed, 16 Sep 2026 10:30:04 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= XWVszUTdZADolc6oje0is2V3B8QC7Z0zk7QtBbC6fjw=; b=LKVCswzxuIiYDyFv wIw5HDQZy9O8YTNszyQkbRKiaR/qfawZuCKrVUuRI+XNEShDvJop7ohijYGoaisD cjln+OecttY/k/OlMDFZUEE6iX3xCH7khlXZWJBIcyjWnx4oLrbHLO/W53GSgLMF mJM0fy7ZX5ISW0gNXuJOeTIEJLuzQsMWOFw8PnvqzAJH4+zZbEFcjspSjn1VVVzB vgrjHIu7hIbU1kT6JKidBlK5yB5CnHMISsRhl0ZG+phhPYdjgxCgJ//mGg5leNl1 xMNjLzFSIpWOX3N+F2+OGHHa6nokEyCs0LDx31hvopOsBYcvyt7S3d4XdIyu8xHQ onBY1w== Received: from mail-qk1-f199.google.com (mail-qk1-f199.google.com [209.85.222.199]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4gqdywas6j-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Wed, 16 Sep 2026 10:30:04 +0000 (GMT) Received: by mail-qk1-f199.google.com with SMTP id af79cd13be357-936e393061dso868143485a.2 for ; Wed, 16 Sep 2026 03:30:04 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1789554603; x=1790159403; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :content-type:mime-version:subject:date:from:from:to:cc:subject:date :message-id:reply-to:content-type; bh=XWVszUTdZADolc6oje0is2V3B8QC7Z0zk7QtBbC6fjw=; b=E6a21dWru9T2oIkCdtevdv2f5c3ZKuHyMCEEV2Q16r4KqrbO/z0E1CZOv+xeHf2Ak7 QpQXrdDwTlBSuWTCeRw98y26EW8PdZw2sQqLWfGRz4TWAUkyQ5cJvQM4VvxfNR73ceBO 8Q7qKHVoFbQri35gWprA9Tcuhe+Oh14Ai9yKDiMyAHn6sGIX8OUPCTprEkypKGF5ycIQ Zapzs4WU2CtpZXI0HyIrGSzoaqtPzNAV0shbMenv4OREv46Lmh3vMDvslovVi8jnRk+/ Jux/3mOTe59OA2cu25j/qqJ/emAh9mE1Z1YLkxAhTU+rHZuniG6Dpx7qvXPtrcbX0P7R KUlQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20260707; t=1789554603; x=1790159403; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :content-type:mime-version:subject:date:from:x-gm-gg :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to :content-type; bh=XWVszUTdZADolc6oje0is2V3B8QC7Z0zk7QtBbC6fjw=; b=abI5vr6Y/Dp0l/XzrmaJb5PYRqRZQbLUOcvbBGAx4PbZEg7WEsN6XtRud8ue9lFe+Y Zd2ilehXBiAvX57ywFyy8/Re3yEpcw6U/vbI0JiUpF+aHbfWkXdNK71FwerlXYuL6i8Y wVqpREBbGKYC183Q4XxATl4sfK6hDfqypZVpvj0p90RPpoa7IdqzhSeAMq9WyHO8hQBM iSkGFgtvO8qkpC6pbIrfoRNPfsCOrbau6tM6palmzen+xpeLr8xOLBULB6HKy4Q1JtUu otodCQaSuttdWjvYjEcLNrUmJkMzXHdiHIj85+LKblolURG/tN83ne5DOgX6XJjctNqb W5QA== X-Forwarded-Encrypted: i=1; AKwUvBwR9KXENVgR0PLFdPVVgJ/0VKQLdOSX/3TQ7VTg6itdgVb4BzgNcTYHC3HxaY3pZ26BU4bklZ2Q+sNrmag=@vger.kernel.org X-Gm-Message-State: AFuF++nyBtsAxxMDdPie7R5ogl0/rYSgO4HonnjpTYmdd+4XFEAEH099 6Aez1LKOIa+M5by+VDVdV821cylBe/p45PyCEsh7+0aXwCxKlewvGYHvhfiWai7gXgkFJI7++bn EKSn1dlpWq7b72MBIE2pPCK8j8pzCcQxvVvfP2FmBFKQe6KE7LTaXs2MUYrUlFAecbz0= X-Gm-Gg: AYBFou0/pf9KFCO8V79/tky2OwQqyl2N9iEW8g1/OZc/e/oNPOlZca/oWmdGTm6tHZ6 XvouTHAXB0KeP1//bZ3K54wGjgBHQfMVpahgzHI/gdFuPNK8Ngd1n27KKE7UJm66lPOgsPBAiaL PQnpWW9fK6usqiv+bpasVYnlJUmDN5e6XA0UKLaxOabT81FYBWgwPaDSOHhrmDaDeuIkcIH5N+r VMNRCuvxtBpOcZ7RhpDGfE9K5Jj47tFZdXom5YTM1Qeu7jr7jReWCm2ymL29j8nnl5s+S5c6HwW q7ss4hOctW5b4oDk1aOQGkawJiW4vu5lS3/S1hsatt3dVWeon+lukWd7e9wnfvsTmYv47GvB6lM HUxcCnV0= X-Received: by 2002:a05:620a:7010:b0:939:b43f:341e with SMTP id af79cd13be357-93bb773b3d3mr286290685a.22.1789554603228; Wed, 16 Sep 2026 03:30:03 -0700 (PDT) X-Received: by 2002:a05:620a:7010:b0:939:b43f:341e with SMTP id af79cd13be357-93bb773b3d3mr286284385a.22.1789554602626; Wed, 16 Sep 2026 03:30:02 -0700 (PDT) Received: from [127.0.1.1] ([86.121.170.232]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-49e83dbb0c1sm71633805e9.14.2026.09.16.03.30.00 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 16 Sep 2026 03:30:01 -0700 (PDT) From: Abel Vesa Date: Wed, 16 Sep 2026 13:28:40 +0300 Subject: [PATCH 24/48] clk: qcom: gcc-sdx65: Use common clock controller probe data Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20260916-clk-qcom-rework-legacy-always-on-clocks-v1-24-25a24e50f82a@oss.qualcomm.com> References: <20260916-clk-qcom-rework-legacy-always-on-clocks-v1-0-25a24e50f82a@oss.qualcomm.com> In-Reply-To: <20260916-clk-qcom-rework-legacy-always-on-clocks-v1-0-25a24e50f82a@oss.qualcomm.com> To: Bjorn Andersson , Abel Vesa , Stephen Boyd , Brian Masney , Jerome Brunet Cc: linux-arm-msm@vger.kernel.org, linux-clk@vger.kernel.org, linux-kernel@vger.kernel.org, Abel Vesa X-Mailer: b4 0.16-dev-0e65f X-Developer-Signature: v=1; a=openpgp-sha256; l=2331; i=abel.vesa@oss.qualcomm.com; h=from:subject:message-id; bh=b9VHnUQlJBlralyapGmuvtRphCZuwYIIiU7q4+OGFvU=; b=owEBbQKS/ZANAwAKARtfRMkAlRVWAcsmYgBqqm9iZJozDeAT8qxLrIprCcsIcOt7wxVqFvfIl 41fwemsCviJAjMEAAEKAB0WIQRO8+4RTnqPKsqn0bgbX0TJAJUVVgUCaqpvYgAKCRAbX0TJAJUV Vo/LD/9aBnGc2gFGgl8AUWJxuP3L2SEHrmrT4V29PHFF9cgB/B66nsYTsNSLxqRMKPnjmTvs5vy E9mFSmGSDmzK29XpkZONYdgkE4OM4Z4Bep9VumJgWXuHf8Oogf3fRguRQdPK5pICyUIKjJn8TUs jQbaZ9RGBk3aReaCyHsYDROOdPkBr/r8PboMF4HPub95k+XXh7Ew4yQuGYUu0d2hCLOOj8WjJ02 blM9k4NsU0t0CS+T/tl09OehI4+TQqzPafUUB5kw42SNlmhzTB+Jy0gIbn0iWsSZWlVj4ovb8+4 5Fm8/n7Seh8KWHEIdexyjaPGLRae5hc73dYoxQS8TrRQZD1xLyfqBa3P2jmnFlXoRctCDjGtLKC LvqGYt7Tj+DS7mNKRWu4Vd2+wcykb+nHoFbpv7HUu3Xqf3bcVL6OBpqWRsixqiaYdK8e9z+uCL9 CDa5s1vYyP8qJaCdcJBc4lJ7vQ2BUOiMSrz/1x02xp2wE01iaGNEU6AE3DzEfgjDxPmS3i+Z80/ 5koHwDRc1jiWFC7S7oWCUeHpG8i8+k+zOfIglFiE/Kn5cPtuQ2LhzOVP3sHloqUk748IjQxE3OL sd7VQDVssXlYh+FBCTyjmCpIC0UpMPXIXFczZ8W/gKLFLmP/DeQwE5A0IlSoU8SCXZ5Y7rAa48x auOxa90A8SGPRdA== X-Developer-Key: i=abel.vesa@oss.qualcomm.com; a=openpgp; fpr=6AFF162D57F4223A8770EF5AF7BF214136F41FAE X-Proofpoint-GUID: HyWuXOARXdCv_kCgxWqAomMjdBOEqCwi X-Authority-Analysis: v=2.4 cv=aJ1lOr9m c=1 sm=1 tr=0 ts=6aaa6fac cx=c_pps a=HLyN3IcIa5EE8TELMZ618Q==:117 a=po8fGBi+ks8MzcVQGuqtFQ==:17 a=IkcTkHD0fZMA:10 a=VdqzKS8jKosA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=yOCtJkima9RkubShWh1s:22 a=EUspDBNiAAAA:8 a=XazbkJH4cJJKrr3KiP8A:9 a=QEXdDO2ut3YA:10 a=bTQJ7kPSJx9SKPbeHEYW:22 X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwOTE2MDEzNyBTYWx0ZWRfX33bDgkjl0ePf 7iC6T2aBZJGZP4xs6On6lgBg+TAUQh2k+C6zIV6EAc0qf+7KASyliayP1YuiLnHQgheHSL7GoWr j6zAWLM2QkbBZh5QmQfRjQvADp+/Gqbg4Nc3tpLLsBtoT8ngKw6PE3+itMUyQ8K1UgI1UP5dccR o6VtUFQ9mBu+c7SFHvcvRYZyvHjXRM8KLNm4gZEg9GiS98JgpWY9hNqLkIcMKIIMS0D2/gKk0dX j3RS/hE9o1hvumTJdUbnvtSu74hvZywSZlwVHMp0Z9V9frPiqKL4t0VLljC5G+01dJ7KfFW4Rm6 /5Z5GKArakcLM9Lb1Qv9c9k0VLSzjj7xWFfnAFhszASQVrz6aAAapzuzFeu+HSVrTujV2fym/q7 1/qLfx2STuWVmBDS4qHkK+dwCVaKiho8HRgzEh0duXud26bIS0oMqpLFTt9fPzaMKNurYahkGkG 8Cs0GIZaitCb9PBa1dw== X-Proofpoint-ORIG-GUID: HyWuXOARXdCv_kCgxWqAomMjdBOEqCwi X-Proofpoint-Spam-Info: AW1haW4tMjYwOTE2MDEzNyBTYWx0ZWRfX2oveZPM2Y4Iv AkTTvdH5Lfbb2mpciHYcBWHC/2nKFPnXw1mq9948aLyiMPblfK/hsGcF9QSUPnmhVN2umpIfw11 8Iz1QhTEn8WDbB4FHSAU0HhWWAgtFps= X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1176,Hydra:6.1.134,FMLib:17.12.100.49 definitions=2026-09-15_05,2026-09-15_02,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 adultscore=0 impostorscore=0 phishscore=0 suspectscore=0 bulkscore=0 malwarescore=0 clxscore=1015 priorityscore=1501 spamscore=0 lowpriorityscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2609040000 definitions=main-2609160137 Move the always-on branch register offsets into a critical_cbcrs array and move the register programming into the clk_regs_configure callback. Use qcom_cc_probe() to perform the common initialization instead of open-coding it in the driver's probe. Assisted-by: LLM Signed-off-by: Abel Vesa Reviewed-by: Konrad Dybcio --- drivers/clk/qcom/gcc-sdx65.c | 31 +++++++++++++++++++------------ 1 file changed, 19 insertions(+), 12 deletions(-) diff --git a/drivers/clk/qcom/gcc-sdx65.c b/drivers/clk/qcom/gcc-sdx65.c index fe297c606f97..ee054e6f029c 100644 --- a/drivers/clk/qcom/gcc-sdx65.c +++ b/drivers/clk/qcom/gcc-sdx65.c @@ -1551,7 +1551,25 @@ static const struct regmap_config gcc_sdx65_regmap_c= onfig =3D { .fast_io =3D true, }; =20 +static const u32 gcc_sdx65_critical_cbcrs[] =3D { + 0x6d008, /* GCC_SYS_NOC_CPUSS_AHB_CLK */ +}; + +static void gcc_sdx65_regs_configure(struct device *dev, struct regmap *re= gmap) +{ + /* Keep some clocks always-on */ + regmap_update_bits(regmap, 0x6d008, BIT(21), BIT(21)); /* GCC_CPUSS_AHB_C= LK */ + regmap_update_bits(regmap, 0x6d008, BIT(22), BIT(22)); /* GCC_CPUSS_GNOC_= CLK */ +} + +static const struct qcom_cc_driver_data gcc_sdx65_driver_data =3D { + .clk_cbcrs =3D gcc_sdx65_critical_cbcrs, + .num_clk_cbcrs =3D ARRAY_SIZE(gcc_sdx65_critical_cbcrs), + .clk_regs_configure =3D gcc_sdx65_regs_configure, +}; + static const struct qcom_cc_desc gcc_sdx65_desc =3D { + .driver_data =3D &gcc_sdx65_driver_data, .config =3D &gcc_sdx65_regmap_config, .clks =3D gcc_sdx65_clocks, .num_clks =3D ARRAY_SIZE(gcc_sdx65_clocks), @@ -1569,18 +1587,7 @@ MODULE_DEVICE_TABLE(of, gcc_sdx65_match_table); =20 static int gcc_sdx65_probe(struct platform_device *pdev) { - struct regmap *regmap; - - regmap =3D qcom_cc_map(pdev, &gcc_sdx65_desc); - if (IS_ERR(regmap)) - return PTR_ERR(regmap); - - /* Keep some clocks always-on */ - qcom_branch_set_clk_en(regmap, 0x6d008); /* GCC_SYS_NOC_CPUSS_AHB_CLK */ - regmap_update_bits(regmap, 0x6d008, BIT(21), BIT(21)); /* GCC_CPUSS_AHB_C= LK */ - regmap_update_bits(regmap, 0x6d008, BIT(22), BIT(22)); /* GCC_CPUSS_GNOC_= CLK */ - - return qcom_cc_really_probe(&pdev->dev, &gcc_sdx65_desc, regmap); + return qcom_cc_probe(pdev, &gcc_sdx65_desc); } =20 static struct platform_driver gcc_sdx65_driver =3D { --=20 2.54.0 From nobody Fri Sep 25 05:31:34 2026 Received: from mx0a-0031df01.pphosted.com (mx0a-0031df01.pphosted.com [205.220.168.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 3CCE74E80D6 for ; Wed, 16 Sep 2026 10:30:09 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.168.131 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1789554631; cv=none; b=USZeOnfXBcs97VNzTanR4YPjbrt+tu/27dj3W9bber7NBlu5clGK1dI4c611g15mKzrzlOi1AbDQiiqA1UyJSHVZHvbDxGI4Gr8kN0Cny85qnJXWJZGCUmiyThSBFWbCgKjx7MIq73toKBLQqBPcT0TORwpTquPP2B0XH4kREKQ= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1789554631; c=relaxed/simple; bh=H40n+mvt5HXpOzvWMVvPPk12LQpk/ikH2qup6sMR2FM=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=iPByXebYB7oGDyOFvzTsu1y0+TNdcvaNH4Pe2S0HnFymNo0Q/+Wf2l8ESLNAikxLGOyjmIN/K2pHNVUqb6SkjaPoIvHOHxhwqinzzpQW1QBEEYNDe/Hr5cnHfuWKvrCd+pIAKNU93IesUTSgu52oQTYFUQxNfwZrRxicq7ah0dw= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=LEZuK4s3; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=je/5A0NV; arc=none smtp.client-ip=205.220.168.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="LEZuK4s3"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="je/5A0NV" Received: from pps.filterd (m0279865.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 68G92gn63169121 for ; Wed, 16 Sep 2026 10:30:06 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= S+k67sqJegtHeFtOHr+Fy8Ofd7nepynOHVRQFUJdphc=; b=LEZuK4s35QyEzcoK 7EPbH3XY/cmCHhQh807eytXpSgazZWKHGIDHECBqzmNq338zCBzHBCCprK1uz0of VKPjQjl9vazz9Te312RRVPCtqhvtBYlaydAdEj+PdHI6v2sPlivfWy2llNbkg7gL y7iMXKyiQSitumbsPJRM94NnZ62LG4HygZOxLjQYY28mqKecv0BOc7LdmDUCmIEh nnfS+g9FlhAt/mwX5UszfX+FTzKIVTOrrZxxcsbb/2RuZ3IwLdgBPAxemVfNQbAO xm3rywRiRzbZ5+9WukKCoEkbf27FMI2ISSi7Zslo0iWCesCUkg9DaJctXObPcXd7 DPSoSg== Received: from mail-qk1-f200.google.com (mail-qk1-f200.google.com [209.85.222.200]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4gqpu2rq0n-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Wed, 16 Sep 2026 10:30:06 +0000 (GMT) Received: by mail-qk1-f200.google.com with SMTP id af79cd13be357-93ae8e7e546so193970385a.1 for ; Wed, 16 Sep 2026 03:30:06 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1789554605; x=1790159405; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :content-type:mime-version:subject:date:from:from:to:cc:subject:date :message-id:reply-to:content-type; bh=S+k67sqJegtHeFtOHr+Fy8Ofd7nepynOHVRQFUJdphc=; b=je/5A0NVNugiML0WRRUDhJ07T2sS5EJhJ18pDwXGJ3e6NVM/F3JvaiygWZMGHYf9Ve zVC78GJtUyYxSv3BRz7wpyOyrI22NI/hJFZrFu8hHKknsp5QV3jD7736SasJGY7I56WT WUz3OP4cJv+F/uS/mSelllMeZK2vJHqt5XQIjKrIqz5OYaqMOPM7w3ofSC41FLEGc2V4 /hwooi8g9l9ue76U+W+JjGW07pVakV9UU+19OHlCB9jTMj9e+cyJk8HUKeTsr0ESVByG qVRqxu4doTGG5pC9tvngASbg4Tios8VDateKHBPDAWiYffCZVpwJVMGJnh2Q7A+gwUpz Z0wg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20260707; t=1789554605; x=1790159405; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :content-type:mime-version:subject:date:from:x-gm-gg :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to :content-type; bh=S+k67sqJegtHeFtOHr+Fy8Ofd7nepynOHVRQFUJdphc=; b=E2oroRXulkbVHij+YbqpQUS9vYMZb8lpVuVL49QvsIHMmoR1A2aEJFh3J29Ih60kh8 qAA0Fm3H16HymV3y4z4j9v/4Xh+9L/FN7QeA9sr6lhMml5jgmpOSilLcSqiIYalVmQSF Q1bvb358TTG2gzEcstSRzyk2ZqzbOeAYUTCf6eCS0iFq+/t2aHOARm3bP3HqEa0nKfd/ 9yYslf8FkUwx1rylj5bwS12+zzHFyKiUthiqT+kjI0Lyd8nlLJkCKTYHKuhRLdicHJDG Mhp0ibFsy2F3eKAL3Mu1OJakdSEb+2hLNrxP3zSdoi0hUSLjHZ48Y71huzsyNVvwQwOB PA1A== X-Forwarded-Encrypted: i=1; AKwUvByCN8Y23nkr/zMMZFNndt8czs5b1HaIJCa9Mf5gfKHAjxWYzf/GCgni+u7YatUN145LhRp6rBcDth20UIw=@vger.kernel.org X-Gm-Message-State: AFuF++knPA+kjK/pLIRpWXCVGpJw42JvO5ueK7nqn+C/9EiAg7hO8//h hu/Af7uGhyfxlKKI+fPoYmR3YVJIfhuIC8xZ1gDjeMBWzuOGbII0J3m+d3qCBYeuCtjnznrXpti QJe9r3H3JVo45IXTYkAafunFuwdOmc3ccmVwwGgg+3VDXae+liw3rzoCgaiXa7tAEhqQ= X-Gm-Gg: AYBFou3Q0Z5uqdBOPfbWIZxGcurJzF93cQrXA18Zvx4LAKdnoBFzqJ0Cp3/6BCt14xK uPu6kiXgz9Nn/ybwh7ADDmZ0S8o6Lt3ZUGrgFU8KLZMFzf+Y3hlHz1jrMOOo/5S7hwnrW1xJWPc J+eMuz9Au9xdaj0LjNNKNF3Xfu1eQ/lD7AvcIU8bP97sN1avkS1hl4E/r43W/VfKGOmJqJKkQay 2e1+pPo98pkFevCx9EVKbDXKcTr1Gu+TDSsdEc28PflfyCiDjgCXAvLnNkPEFu/epw4BIhxmoyu cwdVO8Ne6Aj8QE/Ni/klj8qqlS9d6BZR/kaNCCfKGRK2yT9ilL8so1bFs43gkKMeA6j9ue8ewvA RmdMwgW8= X-Received: by 2002:a05:620a:3713:b0:939:3626:558b with SMTP id af79cd13be357-93bb76a62f6mr299435385a.5.1789554605113; Wed, 16 Sep 2026 03:30:05 -0700 (PDT) X-Received: by 2002:a05:620a:3713:b0:939:3626:558b with SMTP id af79cd13be357-93bb76a62f6mr299430185a.5.1789554604627; Wed, 16 Sep 2026 03:30:04 -0700 (PDT) Received: from [127.0.1.1] ([86.121.170.232]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-49e83dbb0c1sm71633805e9.14.2026.09.16.03.30.02 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 16 Sep 2026 03:30:03 -0700 (PDT) From: Abel Vesa Date: Wed, 16 Sep 2026 13:28:41 +0300 Subject: [PATCH 25/48] clk: qcom: gcc-sdx75: Use common clock controller probe data Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20260916-clk-qcom-rework-legacy-always-on-clocks-v1-25-25a24e50f82a@oss.qualcomm.com> References: <20260916-clk-qcom-rework-legacy-always-on-clocks-v1-0-25a24e50f82a@oss.qualcomm.com> In-Reply-To: <20260916-clk-qcom-rework-legacy-always-on-clocks-v1-0-25a24e50f82a@oss.qualcomm.com> To: Bjorn Andersson , Abel Vesa , Stephen Boyd , Brian Masney , Jerome Brunet Cc: linux-arm-msm@vger.kernel.org, linux-clk@vger.kernel.org, linux-kernel@vger.kernel.org, Abel Vesa X-Mailer: b4 0.16-dev-0e65f X-Developer-Signature: v=1; a=openpgp-sha256; l=2127; i=abel.vesa@oss.qualcomm.com; h=from:subject:message-id; bh=H40n+mvt5HXpOzvWMVvPPk12LQpk/ikH2qup6sMR2FM=; b=owEBbQKS/ZANAwAKARtfRMkAlRVWAcsmYgBqqm9jhMSt/VB5IalTTXQibEni93TF2viJxxd5K wBUOaQ/1Y6JAjMEAAEKAB0WIQRO8+4RTnqPKsqn0bgbX0TJAJUVVgUCaqpvYwAKCRAbX0TJAJUV VquqD/wI/T5UfJT4bVsMPWUos4cpPaNpVrY6/WzH6Qx51KCWlzNoCCNoJIQbevt8Viho37aTcLi 9NHj1aRxW5EXYuuPpXR/E2LwIgsCoQyeXF4YxYJjjBWdvVvugQFcm+oidp3y7ipioW4S9KOSb5R +G5YwcytxWnWNB28QkRLKG5x4DIU+aAYdeET3QCjqf4QG0edIQ/0V0Oer4ySXIKCtoa7NEh4yxg cXRE/3ZxMpat1mL7/YMbpzzn/6hGPARqALSUa5cTwRqxOpfdeZHB8ZNvdZkVda+k/5Bdiqn01Cr bT7uG4unqA5dHBaLuJIiXyBmyg6fPSxADiW9JcYmVh265ZkBY+ZxZWOvLFCpGqrq4/FiN04diB9 fMDUtPB+cDqPzv5ci6t6frfUesn2uUKK4cV6kgxRWy+1mf0qs8kHNvxyqMYgbTtdYTjIWVho5bX 5wrwTbLFQW+QsVCwIwrFFvCIhFFY8GJpT7OFdAQxFeQ3FlN6Sekmo44Zr+mhliGAzAKzmU6jlXy +HPY/6ab0MwdE5HUVwJOyO0YkDVD32X9OhWV/b7/2yHyrNBl3tCWK5xe5kvIXFKZPu7XGu/L58b NyaLRmStMoXNq2slGnKFOIHx2v4jErv5ELSYkNKWyUruYUgL+VZncjQsTAJEZt1iue9uOHZVw2+ XPSlHjNF2dKQWDA== X-Developer-Key: i=abel.vesa@oss.qualcomm.com; a=openpgp; fpr=6AFF162D57F4223A8770EF5AF7BF214136F41FAE X-Proofpoint-ORIG-GUID: 8OJHKlgxLvQ1v-XAAdUrnH_RBcr1Euez X-Authority-Analysis: v=2.4 cv=NelzRGD4 c=1 sm=1 tr=0 ts=6aaa6fae cx=c_pps a=hnmNkyzTK/kJ09Xio7VxxA==:117 a=po8fGBi+ks8MzcVQGuqtFQ==:17 a=IkcTkHD0fZMA:10 a=VdqzKS8jKosA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=Um2Pa8k9VHT-vaBCBUpS:22 a=EUspDBNiAAAA:8 a=XazbkJH4cJJKrr3KiP8A:9 a=QEXdDO2ut3YA:10 a=PEH46H7Ffwr30OY-TuGO:22 X-Proofpoint-GUID: 8OJHKlgxLvQ1v-XAAdUrnH_RBcr1Euez X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwOTE2MDEzNyBTYWx0ZWRfXxmXKbbKP7cLV 4y1tEPiEBJjar2Qr5r2PgdaXy1IpdMaPWaHTbVUP6637+voQHrcbca52r1WtbhO0m5P2v+Bogu4 +4DMu+NqGPjIdiBUI1O7uWvLYjIC5o0Fwvu2GLHrPoe16koy2lrmy/xaH4pzu6Zgc92B8w4t2rF SNFee7mERNs89WgJFYj+05uS2NT2IDa5WsAj/tui2Ht7dgkYFRyIH6TakBr5Lz2W/hGcfaFthv3 slqTBMF9xw2Hmueqa4TYO2kboO6qtp7lxvynTuROVUYI/CXTMiNFVbaTO5VEuo3ZMrhG2ixiH22 pXYHG7tcL6Dlk8yqQtbTNddsFiPPKRYQaL9cpWNI9uhTrkb6VAKvjQGmXk6+XQ9aX22+ursraJx cpDG/mjx0K8eyxzM9Wd36pjAn7UjS/sAa/GDRLlQxlHXw9SSbUxXOVoWHINg883/F3xKxZX+jRf bPw5fv89qWQi7UFdoxA== X-Proofpoint-Spam-Info: AW1haW4tMjYwOTE2MDEzNyBTYWx0ZWRfX55NyckdzI+Fn LJvMZVx//Cm5KfQYE35UoswEZPDXqjp9S4qlePCWnETfbbV9Ohz6ykhImrvHchzJp2gDzresVBw uqXyFex1cAaG8bi3oMp5ZvHYbKbzf28= X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1176,Hydra:6.1.134,FMLib:17.12.100.49 definitions=2026-09-15_05,2026-09-15_02,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 priorityscore=1501 adultscore=0 impostorscore=0 spamscore=0 clxscore=1015 bulkscore=0 malwarescore=0 suspectscore=0 lowpriorityscore=0 phishscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2609040000 definitions=main-2609160137 Move the always-on branch register offsets into a critical_cbcrs array and describe the DFS RCGs through qcom_cc_driver_data. Use qcom_cc_probe() to perform the common initialization instead of open-coding it in the driver's probe. Assisted-by: LLM Signed-off-by: Abel Vesa Reviewed-by: Konrad Dybcio --- drivers/clk/qcom/gcc-sdx75.c | 31 ++++++++++++++----------------- 1 file changed, 14 insertions(+), 17 deletions(-) diff --git a/drivers/clk/qcom/gcc-sdx75.c b/drivers/clk/qcom/gcc-sdx75.c index 6712e76f875c..ddc368a9db39 100644 --- a/drivers/clk/qcom/gcc-sdx75.c +++ b/drivers/clk/qcom/gcc-sdx75.c @@ -2905,7 +2905,20 @@ static const struct regmap_config gcc_sdx75_regmap_c= onfig =3D { .fast_io =3D true, }; =20 +static const u32 gcc_sdx75_critical_cbcrs[] =3D { + 0x3e004, /* GCC_AHB_PCIE_LINK_CLK */ + 0x3e008, /* GCC_XO_PCIE_LINK_CLK */ +}; + +static const struct qcom_cc_driver_data gcc_sdx75_driver_data =3D { + .clk_cbcrs =3D gcc_sdx75_critical_cbcrs, + .num_clk_cbcrs =3D ARRAY_SIZE(gcc_sdx75_critical_cbcrs), + .dfs_rcgs =3D gcc_dfs_clocks, + .num_dfs_rcgs =3D ARRAY_SIZE(gcc_dfs_clocks), +}; + static const struct qcom_cc_desc gcc_sdx75_desc =3D { + .driver_data =3D &gcc_sdx75_driver_data, .config =3D &gcc_sdx75_regmap_config, .clks =3D gcc_sdx75_clocks, .num_clks =3D ARRAY_SIZE(gcc_sdx75_clocks), @@ -2923,23 +2936,7 @@ MODULE_DEVICE_TABLE(of, gcc_sdx75_match_table); =20 static int gcc_sdx75_probe(struct platform_device *pdev) { - struct regmap *regmap; - int ret; - - regmap =3D qcom_cc_map(pdev, &gcc_sdx75_desc); - if (IS_ERR(regmap)) - return PTR_ERR(regmap); - - ret =3D qcom_cc_register_rcg_dfs(regmap, gcc_dfs_clocks, - ARRAY_SIZE(gcc_dfs_clocks)); - if (ret) - return ret; - - /* Keep some clocks always-on */ - qcom_branch_set_clk_en(regmap, 0x3e004); /* GCC_AHB_PCIE_LINK_CLK */ - qcom_branch_set_clk_en(regmap, 0x3e008); /* GCC_XO_PCIE_LINK_CLK */ - - return qcom_cc_really_probe(&pdev->dev, &gcc_sdx75_desc, regmap); + return qcom_cc_probe(pdev, &gcc_sdx75_desc); } =20 static struct platform_driver gcc_sdx75_driver =3D { --=20 2.54.0 From nobody Fri Sep 25 05:31:34 2026 Received: from mx0b-0031df01.pphosted.com (mx0b-0031df01.pphosted.com [205.220.180.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 60A2F4A8A2F for ; Wed, 16 Sep 2026 10:30:14 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.180.131 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1789554635; cv=none; b=OF3YYrQK9eJgpjKc9C3xw+DEsruVgxd82klyi4sm38BZzoAEv/KBzqusFxC+BfPtVs1QWpaRO6ck1ci2GyeiXac27C5aqeunHtACe+axcd6lmgMnhcdAPPTN2cmc7XAZzwGWq0uHqW2orqa4X6w3iEIRLsSp/bT7eNR1m+oPbeQ= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1789554635; c=relaxed/simple; bh=N+HmXCdTzCHtsU952EonArMOSy8WiO3S8aIl7REabXg=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=UA3OrEPTxWiIhZiSC+I/khOExlqXtGod0ybh21vzscpg2pd/JUSjoLIZLDs7Le3/8ZtbGhfV3BiRHwK+szEIIFL4bHbeh10QZheJXYbRMqs+4+Xgo9ekDlRAwEHBFfV6wQuNwIgQpZ6DEY80kL1D4brqBi6L88aIdskEL24SZI8= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=cRR29ZUt; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=fWv672x/; arc=none smtp.client-ip=205.220.180.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="cRR29ZUt"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="fWv672x/" Received: from pps.filterd (m0279873.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 68G934k82226507 for ; Wed, 16 Sep 2026 10:30:11 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= O82bOoWRfdyi2RWvHQNhLrcFnnZraxub/08fychyubA=; b=cRR29ZUtl/2IvxXq D61c19+OcWty8Nn45oMy4wtvvVXjSDG9s107s6fW1tpVgC1LgUoLeh5geL49JAS7 YjkrOdXVgsb3nnlp1qi0k1FZeh9jGBSJX+H7Zc642DgubbgKTg/JjWORSQ/75Ys3 U74Cs+ZgOl67jgSOhzUvRxAvefQqwGqBwmfAfwcKirHpBSSL5ugoJhUN1fPfL2ij JILFHdz7P2jBq6cvNumbeyFwRBQAaApR/rUPGrfkaTIWLH33grL6UayTqaXZBDGA QeDlpRQQ9I0H1i6gXa1wTcr99vEzfV9rgWrGe7yiQt01otV/w55fKmG4Cmqy1sSU 0/MYIA== Received: from mail-qk1-f198.google.com (mail-qk1-f198.google.com [209.85.222.198]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4gqah9ut2j-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Wed, 16 Sep 2026 10:30:11 +0000 (GMT) Received: by mail-qk1-f198.google.com with SMTP id af79cd13be357-939d6c515deso1104212085a.3 for ; Wed, 16 Sep 2026 03:30:11 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1789554611; x=1790159411; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :content-type:mime-version:subject:date:from:from:to:cc:subject:date :message-id:reply-to:content-type; bh=O82bOoWRfdyi2RWvHQNhLrcFnnZraxub/08fychyubA=; b=fWv672x/pA2bWw7Z/WRvXDWmJUCNdYLWy6aNMFhZBtRdPfnTdZPrj4p5p/qha9WpbK PrGFe3AWXNp7kuq+Zahy+OCE79Ril/JrNEqOnlxfrYwT+prSHv+xF7VKrLyYKV2tPQq3 OhCx3p5Jumpdwy5/E9Y/Ad/1H/roAh2PXREOpGXJ8yAReXek9WeVhY5K/DrdLsueE6Fn r61O6X5RnrC+S4+kQlyIqcTgosq29HMrDhFYh23OHAwP3/l8NfH5o+dYQGZny9GbaYKE 3w/+n1Dh9GffHT/gfhY3p9Ci1qy9L1gJmWgECtlqNMBQi6BWI7C9+NqHuT9l3jA+ALcC 1PhA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20260707; t=1789554611; x=1790159411; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :content-type:mime-version:subject:date:from:x-gm-gg :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to :content-type; bh=O82bOoWRfdyi2RWvHQNhLrcFnnZraxub/08fychyubA=; b=hdzB9LhbNcoHhkCVF/va54WokWKzOC8kReNFB4o2KDg99yfWLlv8MHeXD0f+Z68m5w FwkxVJjUMzdwSHHnPpSFf+6xN6G28Wv319GyqTvurrx5OY03ki7g8bIKiTuMOjqMDayX EAFGY3vagIyvdHP10BaLI5qqH1OkqilYUNfWxJOBVWhf/DncavT8rcGeww2n8i9lXU55 IYfuvWlExSEQqzJiKGEDUiUjxQC84KzUuABlpZfKEN8QItRYxIvkKuPtA7KkBfufcdF3 B4I1KrMND40tubkodwqKzCmURY27SXTcbIMhN31HytELHqnYP2LCT8HsTgWZwG50DMgy X60A== X-Forwarded-Encrypted: i=1; AKwUvBxlQWls496L+yt2wbJwsqjgZOgGTqJmhJL+AudykMMxoJuHrBS+KpPLPPvEEqfJp8YUyQiev8NPrk26Q/I=@vger.kernel.org X-Gm-Message-State: AFuF++m4pxvLmjYfVdZFRi5zNcAsgB8l8YyYqt0TF2aIg+YnBRbZzNTf +5+iuRj4Qp0jY0W0OMj3SKTh05KUMQutC6uYxuGwjWcJJuznix9GYv/mV5zadve2z+8MATk7NwR BWu50Y/+cdQoENyXxnzq1us3m2UuLjKip77btp84a/Spj7obJeBCt6KkdGxc67sVYScU= X-Gm-Gg: AYBFou1L27izMYQTtCFzqyw2ZvUOcd70YpKoP9cK98fYqLUjRAy9zwSxDTS1YdQNAQn 1ESSDWh9+QVI5nWJioiPI+HbsFJdSOhD+AoMpB839kxqwi9zsFFKzk+WiEHsNG9Ri0LF0HAu9a/ Cdftuup/tEkfhgXeW9ejp3c8CgFWs98haAsukM9LXUd6AbgXkb4Z7MMH08Bf1/+A2wMNdQW/GrU dL/jFX8AEitrw2FIaQI7KSEhxssuS9lV88Ntz51C1/9pZdXXFvLwhGD0luqowJE3iAscWkLbgqE vph6Ieg9+0+OyTMaFWMlpR396Ml8XODukCjiQ1b4oqVFoF+QeRUqQUBedcKF1Z46SSBsJ9C8z3Q tdAx0bk0= X-Received: by 2002:a05:620a:640f:b0:939:a6eb:735d with SMTP id af79cd13be357-93bb76e72bfmr295857685a.10.1789554608298; Wed, 16 Sep 2026 03:30:08 -0700 (PDT) X-Received: by 2002:a05:620a:640f:b0:939:a6eb:735d with SMTP id af79cd13be357-93bb76e72bfmr295840685a.10.1789554607052; Wed, 16 Sep 2026 03:30:07 -0700 (PDT) Received: from [127.0.1.1] ([86.121.170.232]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-49e83dbb0c1sm71633805e9.14.2026.09.16.03.30.04 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 16 Sep 2026 03:30:05 -0700 (PDT) From: Abel Vesa Date: Wed, 16 Sep 2026 13:28:42 +0300 Subject: [PATCH 26/48] clk: qcom: gcc-sm4450: Use common clock controller probe data Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20260916-clk-qcom-rework-legacy-always-on-clocks-v1-26-25a24e50f82a@oss.qualcomm.com> References: <20260916-clk-qcom-rework-legacy-always-on-clocks-v1-0-25a24e50f82a@oss.qualcomm.com> In-Reply-To: <20260916-clk-qcom-rework-legacy-always-on-clocks-v1-0-25a24e50f82a@oss.qualcomm.com> To: Bjorn Andersson , Abel Vesa , Stephen Boyd , Brian Masney , Jerome Brunet Cc: linux-arm-msm@vger.kernel.org, linux-clk@vger.kernel.org, linux-kernel@vger.kernel.org, Abel Vesa X-Mailer: b4 0.16-dev-0e65f X-Developer-Signature: v=1; a=openpgp-sha256; l=4252; i=abel.vesa@oss.qualcomm.com; h=from:subject:message-id; bh=N+HmXCdTzCHtsU952EonArMOSy8WiO3S8aIl7REabXg=; b=owEBbQKS/ZANAwAKARtfRMkAlRVWAcsmYgBqqm9kUKqaLaqFdfQ88jwq68Xdzqjto/pq5YQlf Q6wslb3oreJAjMEAAEKAB0WIQRO8+4RTnqPKsqn0bgbX0TJAJUVVgUCaqpvZAAKCRAbX0TJAJUV Vr5lEACxMFWA+xVtK4NAWGzUx+zdRzkz72wOTWPaHhSYdb+dOVxTzloeXzAgNPIZ1B/DbUT9Opr BM1VHKtYfMH50hL6/L99NAx6c6dIdDrqbq28K5YuOi4nGoIlAai6gAXn1oxfq9hiqu37kZefaUi M3sbNOxuI7tdZVjnkRmLcIBO6A0xesbhhiG0bwxWvPsBliVNll0osvpO58EVSZBqh0brSvw9Euc NAYPRuoGv+Ht+8upEETSP/bIdlBc4TcyUtBdNg4K54kdg3+QOFLxQ/hM54+s9Prafu7uCQxIWsQ mhyWBeW8zmxw8UpwBhRStK5tmfqZFE+q5HDz41AbMktX1/o1b6la0kF1ToRk7W9L6CZPwEiQL4c 0ygzxvxuKz/ef5e6CBC2rNaXrx06QrKv79w4AxIPXHuR1RDbj27h/Ldnf9l6ZVaCI8CBSTRhU3a iItdrNDDa87dMDrw9VcIdid062oIPVpU55r1gCDvC2eVKZA8ZC0lssXUYtdw0l4JTArxfCDI5YX jHW2a4ds14DPutwE23VJ7PBcbzA3hBGW2jbvrZzcVUT8GW53MJqc4ogjGOfKdxQQ40naE/Tqluw kF1Dw9m2ZJH8qSQLO2CMYO9mq2WPLigDjzphTJuZg4l1WB0XjQOhpwEcY4doYryJoRJi7EkzdcA QJzhnhq/eW2R3+g== X-Developer-Key: i=abel.vesa@oss.qualcomm.com; a=openpgp; fpr=6AFF162D57F4223A8770EF5AF7BF214136F41FAE X-Authority-Analysis: v=2.4 cv=BtkIUoX5 c=1 sm=1 tr=0 ts=6aaa6fb3 cx=c_pps a=qKBjSQ1v91RyAK45QCPf5w==:117 a=po8fGBi+ks8MzcVQGuqtFQ==:17 a=IkcTkHD0fZMA:10 a=VdqzKS8jKosA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=rJkE3RaqiGZ5pbrm-msn:22 a=EUspDBNiAAAA:8 a=rMBTewrK3YKLiG1KudIA:9 a=QEXdDO2ut3YA:10 a=NFOGd7dJGGMPyQGDc5-O:22 X-Proofpoint-ORIG-GUID: 31uapOtU4R6UQP9GGPIXy9LZuxec0lU1 X-Proofpoint-GUID: 31uapOtU4R6UQP9GGPIXy9LZuxec0lU1 X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwOTE2MDEzNyBTYWx0ZWRfX7pwu6QMUB7Fp 1nHdRmk1KsIztn7p7OUdUbo79y8q0WtEjCUQDzKX33Fm/oV/RfyGhV8r6iwAmIbD9vJ6Toffeld P0N9YxtnMMnChHzRlydQfQ34TmKGcZ9iDaB4FpsQMBp9QUWEzdzQRmZTl5bXLlGP6QnF+F6Z9ob T3Cx0ftQgEx2jMQSw149Z65n2njuzlYpZMlXk9TSHG4+GiRPc42TEQ5esnM5rOJ+hOW0bNHK5EG DPWkHurP6RQEO5gUDXE7phvOayeuRj3QpAXW0sAPZlYvSLm+ATNr6PKRqdMkfYIEsFFIL9ViqxB wKv8s8EpvV1JQlEkwib96sdegj3Bb9xw8papWS4WLojOOZzENGQJyHHYsesogfCXJXgNkvxBOlC wPl/xU+o5T7F8Kqvbuodp6rohRQ/6D290igkhX5zapuubm12Yg0lzuE6MNQcLtJ6NUVv7fG5GDm G1IeSXrQQlCyP4QyUhg== X-Proofpoint-Spam-Info: AW1haW4tMjYwOTE2MDEzNyBTYWx0ZWRfX3GrEjHmFmtgR XtoNcYAgCCt8bqqqQ9YOM1+dQzf90jJoyq+UdX+Dv/1UXpjj3ruEAp1YC5qwmhjBbXms3w7mEjl StPElWcIHY88x59Y6ABfFvJ/lRRbkHg= X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1176,Hydra:6.1.134,FMLib:17.12.100.49 definitions=2026-09-15_05,2026-09-15_02,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 priorityscore=1501 lowpriorityscore=0 spamscore=0 adultscore=0 malwarescore=0 impostorscore=0 bulkscore=0 clxscore=1015 phishscore=0 suspectscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2609040000 definitions=main-2609160137 Describe the always-on branches, DFS RCGs and GPLL3 through qcom_cc_driver_data. Associate GPLL3 with its existing configuration so the common PLL setup invokes the Lucid EVO configuration helper. Move the UFS PHY ICE core FORCE_MEM_CORE_ON setting and the video branch register update into the clk_regs_configure callback. This moves the UFS setting after the always-on branch enables. Those branches serve the camera, display, GPU and video blocks, not the UFS PHY ICE core clock. The UFS setting is still applied before GDSC and CCF clock registration, while GPLL3 configuration still precedes the branch enables. Use qcom_cc_probe() for the resulting common initialization sequence instead of open-coding it in gcc_sm4450_probe(). Assisted-by: LLM Signed-off-by: Abel Vesa Reviewed-by: Konrad Dybcio --- drivers/clk/qcom/gcc-sm4450.c | 64 ++++++++++++++++++++++++---------------= ---- 1 file changed, 36 insertions(+), 28 deletions(-) diff --git a/drivers/clk/qcom/gcc-sm4450.c b/drivers/clk/qcom/gcc-sm4450.c index 30fc7af09930..f9361f906396 100644 --- a/drivers/clk/qcom/gcc-sm4450.c +++ b/drivers/clk/qcom/gcc-sm4450.c @@ -140,6 +140,7 @@ static const struct alpha_pll_config gcc_gpll3_config = =3D { }; =20 static struct clk_alpha_pll gcc_gpll3 =3D { + .config =3D &gcc_gpll3_config, .offset =3D 0x3000, .vco_table =3D lucid_evo_vco, .num_vco =3D ARRAY_SIZE(lucid_evo_vco), @@ -2815,7 +2816,41 @@ static const struct regmap_config gcc_sm4450_regmap_= config =3D { .fast_io =3D true, }; =20 +static struct clk_alpha_pll *gcc_sm4450_plls[] =3D { + &gcc_gpll3, +}; + +static const u32 gcc_sm4450_critical_cbcrs[] =3D { + 0x36004, /* GCC_CAMERA_AHB_CLK */ + 0x36018, /* GCC_CAMERA_SLEEP_CLK */ + 0x3601c, /* GCC_CAMERA_XO_CLK */ + 0x37004, /* GCC_DISP_AHB_CLK */ + 0x37014, /* GCC_DISP_XO_CLK */ + 0x81004, /* GCC_GPU_CFG_AHB_CLK */ + 0x42004, /* GCC_VIDEO_AHB_CLK */ + 0x42018, /* GCC_VIDEO_XO_CLK */ +}; + +static void gcc_sm4450_regs_configure(struct device *dev, struct regmap *r= egmap) +{ + /* FORCE_MEM_CORE_ON for the UFS PHY ICE core clock */ + qcom_branch_set_force_mem_core(regmap, gcc_ufs_phy_ice_core_clk, true); + + regmap_update_bits(regmap, 0x4201c, BIT(21), BIT(21)); +} + +static const struct qcom_cc_driver_data gcc_sm4450_driver_data =3D { + .alpha_plls =3D gcc_sm4450_plls, + .num_alpha_plls =3D ARRAY_SIZE(gcc_sm4450_plls), + .clk_cbcrs =3D gcc_sm4450_critical_cbcrs, + .num_clk_cbcrs =3D ARRAY_SIZE(gcc_sm4450_critical_cbcrs), + .dfs_rcgs =3D gcc_dfs_clocks, + .num_dfs_rcgs =3D ARRAY_SIZE(gcc_dfs_clocks), + .clk_regs_configure =3D gcc_sm4450_regs_configure, +}; + static const struct qcom_cc_desc gcc_sm4450_desc =3D { + .driver_data =3D &gcc_sm4450_driver_data, .config =3D &gcc_sm4450_regmap_config, .clks =3D gcc_sm4450_clocks, .num_clks =3D ARRAY_SIZE(gcc_sm4450_clocks), @@ -2833,34 +2868,7 @@ MODULE_DEVICE_TABLE(of, gcc_sm4450_match_table); =20 static int gcc_sm4450_probe(struct platform_device *pdev) { - struct regmap *regmap; - int ret; - - regmap =3D qcom_cc_map(pdev, &gcc_sm4450_desc); - if (IS_ERR(regmap)) - return PTR_ERR(regmap); - - clk_lucid_evo_pll_configure(&gcc_gpll3, regmap, &gcc_gpll3_config); - ret =3D qcom_cc_register_rcg_dfs(regmap, gcc_dfs_clocks, - ARRAY_SIZE(gcc_dfs_clocks)); - if (ret) - return ret; - - qcom_branch_set_force_mem_core(regmap, gcc_ufs_phy_ice_core_clk, true); - - /* Keep some clocks always-on */ - qcom_branch_set_clk_en(regmap, 0x36004); /* GCC_CAMERA_AHB_CLK */ - qcom_branch_set_clk_en(regmap, 0x36018); /* GCC_CAMERA_SLEEP_CLK */ - qcom_branch_set_clk_en(regmap, 0x3601c); /* GCC_CAMERA_XO_CLK */ - qcom_branch_set_clk_en(regmap, 0x37004); /* GCC_DISP_AHB_CLK */ - qcom_branch_set_clk_en(regmap, 0x37014); /* GCC_DISP_XO_CLK */ - qcom_branch_set_clk_en(regmap, 0x81004); /* GCC_GPU_CFG_AHB_CLK */ - qcom_branch_set_clk_en(regmap, 0x42004); /* GCC_VIDEO_AHB_CLK */ - qcom_branch_set_clk_en(regmap, 0x42018); /* GCC_VIDEO_XO_CLK */ - - regmap_update_bits(regmap, 0x4201c, BIT(21), BIT(21)); - - return qcom_cc_really_probe(&pdev->dev, &gcc_sm4450_desc, regmap); + return qcom_cc_probe(pdev, &gcc_sm4450_desc); } =20 static struct platform_driver gcc_sm4450_driver =3D { --=20 2.54.0 From nobody Fri Sep 25 05:31:34 2026 Received: from mx0a-0031df01.pphosted.com (mx0a-0031df01.pphosted.com [205.220.168.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 115CC4E80B0 for ; Wed, 16 Sep 2026 10:30:13 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.168.131 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1789554655; cv=none; b=AjdXqJ+oBOsUjWCNRqsVaKuDunvq4gcgXFzvYS2kwabN1jmCNoqRAvckJ1j7QonWTidHUgYL3el2Zj8BT85li+t+faCnVKEMZNuFNDNwddM271uOWUrWbupY4+CXsgEEKXawoN2xRDOjyZVqvCdo/VLgLvHWr6jFm7XcX1ccVWk= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1789554655; c=relaxed/simple; bh=lfSrimWZThdcUoiBKBc73gKP6/y+jyHpWjqj21yuyYs=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=pMoVKeZE51a5f9QwL+e07osEpHO+HGVC8p1wUC//SSMYI7euAZFnP3NmpunO+c1YnvQpaBqdmcwHeKDN+hzjFt1FY5YtgZ0kWc7nlImiEQM5DJ0UqsAQ8KZEsoi/fRwkGs9bqRp4RIgOJ/eYQ9cPkpFmHBG/rL/uOSMSyaptQIc= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=A5Ki0Mzp; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=kJCP8q3B; arc=none smtp.client-ip=205.220.168.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="A5Ki0Mzp"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="kJCP8q3B" Received: from pps.filterd (m0279862.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 68G92v0e1721223 for ; Wed, 16 Sep 2026 10:30:11 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= aV8OrKimcjcHkzC+e+EE71QbF1fQjuljOHzNPxa4Twk=; b=A5Ki0MzpoodGdllX U3JchBtdnLx5MePx4+2pAXX82gkuEFDtHl7v4EpblmWeBxR6hiC6PSi9wk9WTYAv 0L7QoecIxBvJ23rBQegwqiPeO6bs4xH1xuh+ZdfnrDkSRZnVvHuymllcLFGpZS/d kOGR88Lh17hN7v2Wudsa0BtwT+9EIBTW8M2npHRLhMNMLmjxNhtMwY7bRMpX0vSy QG2933pmn0nwYPcL4zoeCvv49UBiC4pROrlQFGMTlhAUTVfH8ZwE2OjfM5X7F8wP h8iTLp8Vlb/37zNGmYffNr5DOxNcsO3a/ZyLOOdI5shGcamYvOn3ZOvUYGZsrj6X YB7LbQ== Received: from mail-qk1-f197.google.com (mail-qk1-f197.google.com [209.85.222.197]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4gqbmnkbya-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Wed, 16 Sep 2026 10:30:10 +0000 (GMT) Received: by mail-qk1-f197.google.com with SMTP id af79cd13be357-93a1de6d5c3so667774485a.3 for ; Wed, 16 Sep 2026 03:30:10 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1789554610; x=1790159410; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :content-type:mime-version:subject:date:from:from:to:cc:subject:date :message-id:reply-to:content-type; bh=aV8OrKimcjcHkzC+e+EE71QbF1fQjuljOHzNPxa4Twk=; b=kJCP8q3BKtSTJPUMIfPmHpgnJjr48S3Dp5z4SS3+zeIlgX/cJvpug/swJ6wwtJS7nD s1xK1Xz4XyVJWbX65qs59Uro54mWuHOLVf6gstRPGCcXqjHTzQUvDynOhH+uXK+Umkp3 DQNZhOM3REbc22Cbv/Tkd/PaLQcA2zN5s4Lq6gJmuyN3z7iD/S6/q2Dtc476RxTCpAQQ pLpjtbLmYTt6OZOCkh1q6ussCpvygYXHEcNklrU5rNkAxELvFJKRdFVBK9/9GeSknKVw RsUU+towzer4CY2A48IZ/aMNFAar70qlyDgLjnBuTSkk5NuluBUpptsd2t9fK4urn2/n t++w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20260707; t=1789554610; x=1790159410; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :content-type:mime-version:subject:date:from:x-gm-gg :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to :content-type; bh=aV8OrKimcjcHkzC+e+EE71QbF1fQjuljOHzNPxa4Twk=; b=fQiDBWkDSSxUP2ft1tCplToqCDJJaTEBA9dYOAUtXNSWBkbSOHn0cm/YOOCouhCvZ/ sw0+CbFXACXmOllbNXcEZ104n7G1c4iCY0uzORuK4Efm8Tu0p5GKP+dHrMDCdxBBqL0k 68W96rWfEU/p5hDIHFL1X2PmLd7rpvoiMBI7GxU4+1uWxzlZ9esBMqoFjVf1Gip1kt9J f/heFzamTyu+1pLws2Bk7nlBdaGXDydIu0l6FwrQeX0rC4alRHhZXgFrn+q9Uu+lGUV2 Wxjzdya3Iw5BwcxbgT0zMoky70tuNjOC7azSpOv19iLnvHxaAP/PnngNlM3nxh3Fmqoz 6xBw== X-Forwarded-Encrypted: i=1; AKwUvBxh9sGhT2NzUEhnczNi7JYd0bSc0C2DjjgWFVSpiSGfn4/Hyeh5PG2/xI2JD1vYAgGGtxW74CGHtqjPhNM=@vger.kernel.org X-Gm-Message-State: AFuF++mr1WvXhjCdIXLozWJWSfo7tJGgLgKzvF3i5RDcwDXxSsBRh+5e /isZ+pd7qV4P+EGBL1cLoD3UJnUyXY3rkzF6RGnsWV6nJZuv/N4X6427GiLXZAtW4X02mzMnWRq ujsGoPS6n8d4IQ9HsMznSe8qPROuDD3+Vu2EVRlrPezSAIQy0un0sJLpMBHkFUfE0qyI= X-Gm-Gg: AYBFou3zZeA1bFEaPFmd/SKRUOVtZgsCySk03xC4E3tovRic/AXyjYAFzWwBmwwggLX g80Uavr3SLYDtU9KPmUb6cPSrMYb98CRI3KcVi8NYqsIltE45cPPWYQ2QIXkVBiLXhyPXtvSrGz e+UCMjoiyXzdyo9wldMbBeKGZXh5q/JDimmF1RXskDBb2if9ZcD5eWrXYIQpRXyRK6dE4fftMuH R9XGIUxD6s+7ZV5fXsxEFniCd2dmcI6p0qPjV5ODByE46Xm1Tq253Cq9d3Lu+AYqyO/HRkSpW2m SAmSNc6nMnXgVeE6cLqDcF/X9lzDIoUOpm30pij90OKTsS6cuOkPvaFoCXTP14d5AqcH5T8YZJU PcFwar+4= X-Received: by 2002:a05:620a:6889:b0:939:aa01:99fe with SMTP id af79cd13be357-93bb78d5a7emr323636285a.51.1789554609817; Wed, 16 Sep 2026 03:30:09 -0700 (PDT) X-Received: by 2002:a05:620a:6889:b0:939:aa01:99fe with SMTP id af79cd13be357-93bb78d5a7emr323629085a.51.1789554609332; Wed, 16 Sep 2026 03:30:09 -0700 (PDT) Received: from [127.0.1.1] ([86.121.170.232]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-49e83dbb0c1sm71633805e9.14.2026.09.16.03.30.07 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 16 Sep 2026 03:30:08 -0700 (PDT) From: Abel Vesa Date: Wed, 16 Sep 2026 13:28:43 +0300 Subject: [PATCH 27/48] clk: qcom: gcc-sm6375: Use common clock controller probe data Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20260916-clk-qcom-rework-legacy-always-on-clocks-v1-27-25a24e50f82a@oss.qualcomm.com> References: <20260916-clk-qcom-rework-legacy-always-on-clocks-v1-0-25a24e50f82a@oss.qualcomm.com> In-Reply-To: <20260916-clk-qcom-rework-legacy-always-on-clocks-v1-0-25a24e50f82a@oss.qualcomm.com> To: Bjorn Andersson , Abel Vesa , Stephen Boyd , Brian Masney , Jerome Brunet Cc: linux-arm-msm@vger.kernel.org, linux-clk@vger.kernel.org, linux-kernel@vger.kernel.org, Abel Vesa X-Mailer: b4 0.16-dev-0e65f X-Developer-Signature: v=1; a=openpgp-sha256; l=3185; i=abel.vesa@oss.qualcomm.com; h=from:subject:message-id; bh=lfSrimWZThdcUoiBKBc73gKP6/y+jyHpWjqj21yuyYs=; b=owEBbQKS/ZANAwAKARtfRMkAlRVWAcsmYgBqqm9l6HFWpAPHkes9ACaOzpzl++9pwX+YBsceb tFOb75yboKJAjMEAAEKAB0WIQRO8+4RTnqPKsqn0bgbX0TJAJUVVgUCaqpvZQAKCRAbX0TJAJUV Vrm9D/9DnV4vBZ/oj7sp7jHCORWOIsaiKza+HEkKyGMwSqP9G9YEeqJflyn7Z8WXpVvB7LO9n2v Ptvmjm7M6cqsdRCFZDcBAvEsQ4dimlB7lt3WZM82djoqhne71bVqsswgVyb8smL09D6P9awaoLe gc0X9QpKD00O6iKbTtePPkQjdZ4qMuFB28LiTe5D7v5C37sFMYQXRmjtQE2AoBVcpgJMQtL+Ny+ gUDERQ7jNx6GDaOGPiONsgX4QlO+CXscFC+7pm//Qg8UNs61RvrPlAy04tXhR6vpoquiVokala1 Szt0EiJGSnfNPcH07d5HLxLXTlg9Jy54Y8a0LwLbwoxPGIjnui45RhYYOJI14WlCpt9kUhGKHe5 0jZKP9Y3xYDy/bwdspKsD1mV/cfNWGBU5YT+oi576r43YeM7uCCy/TsTOrn3cGVeQf2UZpTUZD2 7PXWW52rvtP8lRqIpkiEA6WoyKucr3L26akLdDHzpdVQPisq2dUGkcudRHXWPch6zGahbiQV/BA V4kdwcimwAbYoe9pDG7fiiCjoSoO/BY2sEfjknrjk2V3ZCDKQn8NTmTYafQ+WIbmcWcExCEevbh yuyK+hd0gj8r08S709kwRgeMDVr0BVD0539AkyU3oTRlp8f4P4QxKFNE5R8Hu0DmLzNz58yXsBX 6oWZP2EaceaNacA== X-Developer-Key: i=abel.vesa@oss.qualcomm.com; a=openpgp; fpr=6AFF162D57F4223A8770EF5AF7BF214136F41FAE X-Authority-Analysis: v=2.4 cv=POyaavqC c=1 sm=1 tr=0 ts=6aaa6fb2 cx=c_pps a=50t2pK5VMbmlHzFWWp8p/g==:117 a=po8fGBi+ks8MzcVQGuqtFQ==:17 a=IkcTkHD0fZMA:10 a=VdqzKS8jKosA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=_K5XuSEh1TEqbUxoQ0s3:22 a=EUspDBNiAAAA:8 a=wnEm36D4OOU7-cSD6GIA:9 a=QEXdDO2ut3YA:10 a=IoWCM6iH3mJn3m4BftBB:22 X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwOTE2MDEzNyBTYWx0ZWRfX9dnrx7rzKmiI 17nx5BeU42bIvD9ndBvz9NMp66f70lKyr3L1h8w/dkXe3pTGp3Yqpm6ArSX/3bAhbNK1T1PaRj2 4nOUo0GQ7Qt4UqaVCcZJc91jR76h3L7UIXTltkfimldVBWPmtULi9+tpRGQ4aqZfew9JzRy633G jyxqzpFRhTp0CDv9vM1w4VRK/hkDVhmVTw5zBF9Y9KU7URnjptOkZDdKGLLfQJghjzl/1jGxNnI cKkldb+yRjkpk/5eHFcIBPVAPdLCvHtbzB6Iz6r48aeVLsS83mgqRrkYXekVlJN0jNG6iJynK49 Z6Ztgf+ws9XmG/DMbjGXKUYSTQxChQUFuikFtf99Ks/Y4+V0JQ3RuEdzryQDZKyZc+IIYt5rEf3 6IHCTM/r0IQmZ+aFvoEl6xrrVo0e8iQakuX8AmCwfWFaNln3CDQcnR64bVX3w8rgU0SzyqYIH2X wWGR2c7C+MvZzhfvXOg== X-Proofpoint-GUID: 0T50gHkHxIrV1RGKax2YWKpy565bkKMM X-Proofpoint-Spam-Info: AW1haW4tMjYwOTE2MDEzNyBTYWx0ZWRfX3x1LjX246k6+ wbeRHvSUZvn9HQeQKUnjMGvhjVGjGg+yyzAgUuDcsk3ByEE1VQdf/59J+2Pt2Z0OG4dwpcdUr/p J2mXc8KScxgjm6X/yj7xPQqH1c6aDio= X-Proofpoint-ORIG-GUID: 0T50gHkHxIrV1RGKax2YWKpy565bkKMM X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1176,Hydra:6.1.134,FMLib:17.12.100.49 definitions=2026-09-15_05,2026-09-15_02,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 priorityscore=1501 adultscore=0 bulkscore=0 clxscore=1015 phishscore=0 suspectscore=0 impostorscore=0 spamscore=0 lowpriorityscore=0 malwarescore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2609040000 definitions=main-2609160137 Move the always-on branch register offsets into a critical_cbcrs array and describe the DFS RCGs through qcom_cc_driver_data. Move the configuration of GPLL10, GPLL11, GPLL8 and GPLL9 into the clk_regs_configure callback. This preserves the existing ordering of enabling the always-on branches before configuring these four PLLs. Using the alpha_plls array instead would configure the PLLs before the CBCR enables in the common probe path. Use qcom_cc_probe() to perform the common initialization instead of open-coding it in the driver's probe. Assisted-by: LLM Signed-off-by: Abel Vesa Reviewed-by: Konrad Dybcio --- drivers/clk/qcom/gcc-sm6375.c | 46 ++++++++++++++++++++++-----------------= ---- 1 file changed, 24 insertions(+), 22 deletions(-) diff --git a/drivers/clk/qcom/gcc-sm6375.c b/drivers/clk/qcom/gcc-sm6375.c index f47dc2808095..d125243ac6cb 100644 --- a/drivers/clk/qcom/gcc-sm6375.c +++ b/drivers/clk/qcom/gcc-sm6375.c @@ -3853,7 +3853,30 @@ static const struct regmap_config gcc_sm6375_regmap_= config =3D { .fast_io =3D true, }; =20 +static const u32 gcc_sm6375_critical_cbcrs[] =3D { + 0x17028, /* GCC_CAMERA_XO_CLK */ + 0x2b004, /* GCC_CPUSS_GNOC_CLK */ + 0x1702c, /* GCC_DISP_XO_CLK */ +}; + +static void gcc_sm6375_regs_configure(struct device *dev, struct regmap *r= egmap) +{ + clk_lucid_pll_configure(&gpll10, regmap, &gpll10_config); + clk_lucid_pll_configure(&gpll11, regmap, &gpll11_config); + clk_lucid_pll_configure(&gpll8, regmap, &gpll8_config); + clk_zonda_pll_configure(&gpll9, regmap, &gpll9_config); +} + +static const struct qcom_cc_driver_data gcc_sm6375_driver_data =3D { + .clk_cbcrs =3D gcc_sm6375_critical_cbcrs, + .num_clk_cbcrs =3D ARRAY_SIZE(gcc_sm6375_critical_cbcrs), + .dfs_rcgs =3D gcc_dfs_clocks, + .num_dfs_rcgs =3D ARRAY_SIZE(gcc_dfs_clocks), + .clk_regs_configure =3D gcc_sm6375_regs_configure, +}; + static const struct qcom_cc_desc gcc_sm6375_desc =3D { + .driver_data =3D &gcc_sm6375_driver_data, .config =3D &gcc_sm6375_regmap_config, .clks =3D gcc_sm6375_clocks, .num_clks =3D ARRAY_SIZE(gcc_sm6375_clocks), @@ -3871,28 +3894,7 @@ MODULE_DEVICE_TABLE(of, gcc_sm6375_match_table); =20 static int gcc_sm6375_probe(struct platform_device *pdev) { - struct regmap *regmap; - int ret; - - regmap =3D qcom_cc_map(pdev, &gcc_sm6375_desc); - if (IS_ERR(regmap)) - return PTR_ERR(regmap); - - ret =3D qcom_cc_register_rcg_dfs(regmap, gcc_dfs_clocks, ARRAY_SIZE(gcc_d= fs_clocks)); - if (ret) - return ret; - - /* Keep some clocks always-on */ - qcom_branch_set_clk_en(regmap, 0x17028); /* GCC_CAMERA_XO_CLK */ - qcom_branch_set_clk_en(regmap, 0x2b004); /* GCC_CPUSS_GNOC_CLK */ - qcom_branch_set_clk_en(regmap, 0x1702c); /* GCC_DISP_XO_CLK */ - - clk_lucid_pll_configure(&gpll10, regmap, &gpll10_config); - clk_lucid_pll_configure(&gpll11, regmap, &gpll11_config); - clk_lucid_pll_configure(&gpll8, regmap, &gpll8_config); - clk_zonda_pll_configure(&gpll9, regmap, &gpll9_config); - - return qcom_cc_really_probe(&pdev->dev, &gcc_sm6375_desc, regmap); + return qcom_cc_probe(pdev, &gcc_sm6375_desc); } =20 static struct platform_driver gcc_sm6375_driver =3D { --=20 2.54.0 From nobody Fri Sep 25 05:31:34 2026 Received: from mx0a-0031df01.pphosted.com (mx0a-0031df01.pphosted.com [205.220.168.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 966D44EBAFB for ; Wed, 16 Sep 2026 10:30:19 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.168.131 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1789554655; cv=none; b=abIhO8gjl5XaX93drSlGpjxuAiLe9Rgr5qcTeofC6mpFfMdKrVgn52/cG7XgLVu1XOX/M0Ebf4uHXHWDNuZw6lZJGIe96WeRq9yptO9tHiAITAB87PkP6SRfBNf6gtY3QEcEoUDoO3ptktQMkdpxEH26ad4FtXYREJ6za46XaVA= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1789554655; c=relaxed/simple; bh=1xxZF/x+vvknFqcI4/E7SyLdAmvk7uNfuS5qhEWDuak=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=u7UAmvLQF3Q87RB4+e+jsjOmNV2FBe4wgS4+JODFQv7nfbMq/anJzAeu/fhRhhoOphmW/c6RCeDHWz5kT8DycY3aOIAK9CNl9gNF8icOsDC/Mxkgl5fjxTesDyjsz9XbgL1NNizJL8jNaF2C5fFdv9XrMBE6ZRdCw2YCOFPl0Cw= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=EFKXqX6M; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=BxgPiE5m; arc=none smtp.client-ip=205.220.168.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="EFKXqX6M"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="BxgPiE5m" Received: from pps.filterd (m0279864.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 68G92qEm978385 for ; Wed, 16 Sep 2026 10:30:15 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= tGPRPUC+vD5SbbGdAAxZ6wkgGEtlllFZCy8xvEPLSNk=; b=EFKXqX6Mzbka4fyj +SZr0lRDQRLLBqDkV8rhc4QOmJw9Rr/EhWagmK8/b1QQmKyXDZa8tttOLk+fcABs gW4AiloV2BtHjUSUlH4WKaTUUC5QiFjDoUVZgac8AwSjL3Ebi27O5YoHMuvaGw+k XZkGxfD4A0FmWDBn79MqUII0LMvAyMf31lJbcyytFApvRFK8rx8rkx5mwqasbUSx NNWkiX04IwujJv0gB5Wp/T1bJcLpmBu5f6Fj60KeX3hB+Wy04HM06WNc6JoOv8UB 5MZZ4QJD475Bc+S2GvMO8pN1N9fIQjKLJrk+aIUn77BkxVFA6OgQ5A2tQtAm0BF8 LSgvqg== Received: from mail-qk1-f199.google.com (mail-qk1-f199.google.com [209.85.222.199]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4gqqp3rfur-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Wed, 16 Sep 2026 10:30:15 +0000 (GMT) Received: by mail-qk1-f199.google.com with SMTP id af79cd13be357-939f3426a7cso988845985a.0 for ; Wed, 16 Sep 2026 03:30:14 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1789554614; x=1790159414; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :content-type:mime-version:subject:date:from:from:to:cc:subject:date :message-id:reply-to:content-type; bh=tGPRPUC+vD5SbbGdAAxZ6wkgGEtlllFZCy8xvEPLSNk=; b=BxgPiE5mA7N4gCRA+Tr1u+bLWrKPFJBS8/mqfn0+OAww0l5gOBEO2ttdLHAdOmy1Eo S3prZen2P2Qy0biELuDo/5IK+xfuFr3SNfMvxtgp+vTcc7Jyo+IyyBRMLV7L0Hz1AXai wPPtLZiqophratAKqT2gzm/6K4v+VaE1SX5wPP9ZUsTv4PoJzvJAIKuEXsnlIbAh9FJ6 ZAitLDb7dO3q77rIuGs0aPpKv1qyYNnPq9xrIMvcrCj+AQqOGgISgyp1HuQQNpaRktEi chZdAetiO/DUXLpAjc4oRCkjj+evQGLpUtf+3jZhybsyAXNUYTkkjDMFtKDQW/KYe2AN GOwQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20260707; t=1789554614; x=1790159414; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :content-type:mime-version:subject:date:from:x-gm-gg :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to :content-type; bh=tGPRPUC+vD5SbbGdAAxZ6wkgGEtlllFZCy8xvEPLSNk=; b=TalLdVQmZz5u3wFkHrH6/iIrLCrEmORZcIsN7DZs3zIZAmf8ioTCjv4pIF8tiXKeQj QX+osNsiHmBzlL4yXoDc83YQK3B0UE8mep67gFbwGFu4dWYGs9Qy3vjuLIncp/7IyY3N /UUlMe2zaum5oP8YUPzoOQpErXz1+rfJtpBz29TvkoN6c8KgF0v0DCAGTZMJ79wC0iQJ 4NjcOWPfqcmI8KbZw5qi0TWnAtW3ER+hofuTuQKcDf2HAxesHAIUmUEbs1U8G+y5BAS/ ErzLCNSt50pfHa4bGVN4czPBYZgM0FNmeFP8vzsgn/DbaiGYjuAOhbLkOexol/P3B/Vw Xo4w== X-Forwarded-Encrypted: i=1; AKwUvBw12suBT01N5j/1BFo6KyzchOLFOP0+knNOfl9iVY5XVcsHcqqwtRThcrpnow+dXHPNLgmsbt6qUpkrGIc=@vger.kernel.org X-Gm-Message-State: AFuF++nISKt9f3dFU9cRnQyqvSsIznivjUIECvfxiScT0/VGXE2/U7SN 4/MmHQuzPdYUymHE7vL1PDjcr/DIF1jFBgWHvePv7uCOVezjnIIZdcSnkIT/ZnxZfrTrK+nLInS EYhNgEAfb0fvXmLFiERHqJAPkJ4FU55F210cL3wl7k9FLwOIJqqZqXoCyUEC+H/uCOr0= X-Gm-Gg: AYBFou3Y4+Z5rO4Z6uEd9A42A+JdArPMFR1g9dc0qSN6bU+uHeDPNJ4pLz9S6jEBtQb gxaWpmq5jAoJNX9Dj8T+p2qQTW5W/S8S7pG0XM7ctDtJfRIUGiQhvi6IcOLE9yNKKHqGPlMdMCW 23aQl3USWuATTEMzjbG/ZP5rAzixeSKNLu2HoYQQPCYn73pYVPJ9utqBxEw8ylXpXfpzse6eHUV UJM+PrP0UUpHOjYbGoaTXXqAsFI7mrjUljgEKMyqO1TtLDQSnoiPYzaAD5x0nRozsmdSekb0+3s VkneedMtGiJVGjwMt9fGVUCvrgvOnt4VM6q1wb98GVbPy2/7SBAUN57jBFyYu7FwWKpv83uBO7H V1kxi1nM= X-Received: by 2002:a05:620a:450c:b0:939:6dfa:48fc with SMTP id af79cd13be357-93bb796a4c8mr310222785a.50.1789554613946; Wed, 16 Sep 2026 03:30:13 -0700 (PDT) X-Received: by 2002:a05:620a:450c:b0:939:6dfa:48fc with SMTP id af79cd13be357-93bb796a4c8mr310212385a.50.1789554613258; Wed, 16 Sep 2026 03:30:13 -0700 (PDT) Received: from [127.0.1.1] ([86.121.170.232]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-49e83dbb0c1sm71633805e9.14.2026.09.16.03.30.09 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 16 Sep 2026 03:30:11 -0700 (PDT) From: Abel Vesa Date: Wed, 16 Sep 2026 13:28:44 +0300 Subject: [PATCH 28/48] clk: qcom: gcc-sm7150: Use common clock controller probe data Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20260916-clk-qcom-rework-legacy-always-on-clocks-v1-28-25a24e50f82a@oss.qualcomm.com> References: <20260916-clk-qcom-rework-legacy-always-on-clocks-v1-0-25a24e50f82a@oss.qualcomm.com> In-Reply-To: <20260916-clk-qcom-rework-legacy-always-on-clocks-v1-0-25a24e50f82a@oss.qualcomm.com> To: Bjorn Andersson , Abel Vesa , Stephen Boyd , Brian Masney , Jerome Brunet Cc: linux-arm-msm@vger.kernel.org, linux-clk@vger.kernel.org, linux-kernel@vger.kernel.org, Abel Vesa X-Mailer: b4 0.16-dev-0e65f X-Developer-Signature: v=1; a=openpgp-sha256; l=3490; i=abel.vesa@oss.qualcomm.com; h=from:subject:message-id; bh=1xxZF/x+vvknFqcI4/E7SyLdAmvk7uNfuS5qhEWDuak=; b=owEBbQKS/ZANAwAKARtfRMkAlRVWAcsmYgBqqm9mDcszbdyEA9dPE6tA+RBxqrLA8reSxhRaW Ta3PR27F1KJAjMEAAEKAB0WIQRO8+4RTnqPKsqn0bgbX0TJAJUVVgUCaqpvZgAKCRAbX0TJAJUV VqkHD/4mx+8LFptJEyEJnKWMn9ppytOGfIX2OeFlzGUJl1YsZC0fy9Er9cjR1iPN4z+6hrq1d/Y EcdsCkhK6mBnX2Uu5U35QwILKklKfbI3FVQAFVbTpPq34vVxkYYeqAgkoG30rtH7tkcTW6U+blm RGR6lHoAhbE9+nhFyF1y5OYyWoWlhib9TUSLBjRX4jZggdYUqUJ9UArzgfXtm6gwC3jhKrARDJM lstQeKKPETiEsUubkGBlgphVDt8aLYjuKs5LWpys72KAlms061W25JoJ7+uyD83WBsCudYykLdF dTljINDH1srzQP6nU8+IKqrGgj/or1x0Z6rtjxeWGFq39aNMRoMVW+gD61jXB5VQjpQPACLioUR ddR2inyvl+fhndPjIPfhmOhgWsAYpoft5nlsnZmuX4wBeCzHOhz3WRjhDQ0CD+BJqCz4X2TNoOF PzjUwTxqsYnfGpSJhc4/hkzguM7daCvlpJkmk7V7TLCjxmGp5yeLXVo7oBABXePQjHyf7T6ccnt CGLV7AxV3W44qW98dEvB6KcuU/KrHlpohdbvpfygAsPFIz5SyfS4FLXINFFZjHK3pgrSQ9BpKWO HyJZ/ZaLVLWbtgkmPsK1Pg9kBj427nHbE/YGZDim0xHtxFCy7TzOWlp+uO9agwAfJfCCPk+PpQd mezpu3PDDv4pqtA== X-Developer-Key: i=abel.vesa@oss.qualcomm.com; a=openpgp; fpr=6AFF162D57F4223A8770EF5AF7BF214136F41FAE X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwOTE2MDEzNyBTYWx0ZWRfX9JYcOvuI9zXl gZjCSm/KdIVKGh6XJMLlYnDQC+Pwdx9iCt+Fdls79c5slXNL1P+V/awoA+kdNnTIqYE14zPNyG7 bWUAVVkDstpC848qkTk6OByQeex0hi4f0Z/7h2LcxQs6yifj/iGW2Wnd30WbXQpngaoHI9uBuQ2 K34xvJSMJv/Pv2Bz8LZmzT92vIKk4+sYFrgGwPFMAF/uz7JDfIubQrVqj0tp58ZS0IDWQi706LE 8U3McZlk53tOQwjvjIHhseaTq1WUbaw5WqEPm5GEwu24nRudvTTPKp/pnmF/R/FxFPp2jX1ZZfO fcJC2J85bC8lXUufoaJe7DwCtFSk6lx2X4lmixkSu8ZJoezYbUSxvq0cnCmWJAJWgG60hyJTpIl Qiupsp1FEZg+8DRY86xynJKTyMBZ0Xoo59V80cte3F8WV6r/qNONDygFjDGNrPQ/frqjmWieJxZ Y8qcYu3iBRKJub5IbBQ== X-Proofpoint-GUID: vB26BHAtzsmHXrkssbRcyPNf6XEvz8IE X-Proofpoint-Spam-Info: AW1haW4tMjYwOTE2MDEzNyBTYWx0ZWRfX/IjMzDdK9PjS r2upgQ22saAeWZkJAAV74zT5HpFE4ZrEFVq+X9DgI15qPacBebh5N3ZvJNzWYNUVw8+9yjwN1UP dgr8gjo6Ilnby8azXuncoeUSGK7qnHs= X-Proofpoint-ORIG-GUID: vB26BHAtzsmHXrkssbRcyPNf6XEvz8IE X-Authority-Analysis: v=2.4 cv=F/DC5ahN c=1 sm=1 tr=0 ts=6aaa6fb7 cx=c_pps a=HLyN3IcIa5EE8TELMZ618Q==:117 a=po8fGBi+ks8MzcVQGuqtFQ==:17 a=IkcTkHD0fZMA:10 a=VdqzKS8jKosA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=DJpcGTmdVt4CTyJn9g5Z:22 a=EUspDBNiAAAA:8 a=RW22A4phRzxp-fsVvwcA:9 a=QEXdDO2ut3YA:10 a=bTQJ7kPSJx9SKPbeHEYW:22 X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1176,Hydra:6.1.134,FMLib:17.12.100.49 definitions=2026-09-15_05,2026-09-15_02,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 priorityscore=1501 malwarescore=0 adultscore=0 bulkscore=0 clxscore=1015 spamscore=0 phishscore=0 impostorscore=0 suspectscore=0 lowpriorityscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2609040000 definitions=main-2609160137 Move the always-on branch register offsets into a critical_cbcrs array, describe the DFS RCGs through qcom_cc_driver_data and move the register programming into the clk_regs_configure callback. Use qcom_cc_probe() to perform the common initialization instead of open-coding it in the driver's probe. Assisted-by: LLM Signed-off-by: Abel Vesa Reviewed-by: Konrad Dybcio --- drivers/clk/qcom/gcc-sm7150.c | 60 +++++++++++++++++++++------------------= ---- 1 file changed, 29 insertions(+), 31 deletions(-) diff --git a/drivers/clk/qcom/gcc-sm7150.c b/drivers/clk/qcom/gcc-sm7150.c index dcb5d82a1a31..9fec45a4837c 100644 --- a/drivers/clk/qcom/gcc-sm7150.c +++ b/drivers/clk/qcom/gcc-sm7150.c @@ -2966,7 +2966,35 @@ static const struct regmap_config gcc_sm7150_regmap_= config =3D { .fast_io =3D true, }; =20 +static const u32 gcc_sm7150_critical_cbcrs[] =3D { + 0x48004, /* GCC_CPUSS_GNOC_CLK */ + 0x0b004, /* GCC_VIDEO_AHB_CLK */ + 0x0b008, /* GCC_CAMERA_AHB_CLK */ + 0x0b00c, /* GCC_DISP_AHB_CLK */ + 0x0b02c, /* GCC_CAMERA_XO_CLK */ + 0x0b028, /* GCC_VIDEO_XO_CLK */ + 0x0b030, /* GCC_DISP_XO_CLK */ + 0x71004, /* GCC_GPU_CFG_AHB_CLK */ +}; + +static void gcc_sm7150_regs_configure(struct device *dev, struct regmap *r= egmap) +{ + /* Disable the GPLL0 active input to MM blocks, NPU and GPU via MISC regi= sters. */ + regmap_update_bits(regmap, 0x09ffc, 0x3, 0x3); + regmap_update_bits(regmap, 0x4d110, 0x3, 0x3); + regmap_update_bits(regmap, 0x71028, 0x3, 0x3); +} + +static const struct qcom_cc_driver_data gcc_sm7150_driver_data =3D { + .clk_cbcrs =3D gcc_sm7150_critical_cbcrs, + .num_clk_cbcrs =3D ARRAY_SIZE(gcc_sm7150_critical_cbcrs), + .dfs_rcgs =3D gcc_sm7150_dfs_desc, + .num_dfs_rcgs =3D ARRAY_SIZE(gcc_sm7150_dfs_desc), + .clk_regs_configure =3D gcc_sm7150_regs_configure, +}; + static const struct qcom_cc_desc gcc_sm7150_desc =3D { + .driver_data =3D &gcc_sm7150_driver_data, .config =3D &gcc_sm7150_regmap_config, .clk_hws =3D gcc_sm7150_hws, .num_clk_hws =3D ARRAY_SIZE(gcc_sm7150_hws), @@ -2986,37 +3014,7 @@ MODULE_DEVICE_TABLE(of, gcc_sm7150_match_table); =20 static int gcc_sm7150_probe(struct platform_device *pdev) { - struct regmap *regmap; - int ret; - - regmap =3D qcom_cc_map(pdev, &gcc_sm7150_desc); - if (IS_ERR(regmap)) - return PTR_ERR(regmap); - - /* - * Disable the GPLL0 active input to MM blocks, NPU - * and GPU via MISC registers. - */ - regmap_update_bits(regmap, 0x09ffc, 0x3, 0x3); - regmap_update_bits(regmap, 0x4d110, 0x3, 0x3); - regmap_update_bits(regmap, 0x71028, 0x3, 0x3); - - /* Keep some clocks always-on */ - qcom_branch_set_clk_en(regmap, 0x48004); /* GCC_CPUSS_GNOC_CLK */ - qcom_branch_set_clk_en(regmap, 0x0b004); /* GCC_VIDEO_AHB_CLK */ - qcom_branch_set_clk_en(regmap, 0x0b008); /* GCC_CAMERA_AHB_CLK */ - qcom_branch_set_clk_en(regmap, 0x0b00c); /* GCC_DISP_AHB_CLK */ - qcom_branch_set_clk_en(regmap, 0x0b02c); /* GCC_CAMERA_XO_CLK */ - qcom_branch_set_clk_en(regmap, 0x0b028); /* GCC_VIDEO_XO_CLK */ - qcom_branch_set_clk_en(regmap, 0x0b030); /* GCC_DISP_XO_CLK */ - qcom_branch_set_clk_en(regmap, 0x71004); /* GCC_GPU_CFG_AHB_CLK */ - - ret =3D qcom_cc_register_rcg_dfs(regmap, gcc_sm7150_dfs_desc, - ARRAY_SIZE(gcc_sm7150_dfs_desc)); - if (ret) - return ret; - - return qcom_cc_really_probe(&pdev->dev, &gcc_sm7150_desc, regmap); + return qcom_cc_probe(pdev, &gcc_sm7150_desc); } =20 static struct platform_driver gcc_sm7150_driver =3D { --=20 2.54.0 From nobody Fri Sep 25 05:31:34 2026 Received: from mx0a-0031df01.pphosted.com (mx0a-0031df01.pphosted.com [205.220.168.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id B03454F55CE for ; Wed, 16 Sep 2026 10:30:21 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.168.131 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1789554642; cv=none; b=nA9aSTi7bUtJ+M7btQkskyJibOCSHC7xLAkNJwEeA4ZsTojj5aJ4qTA6fgbzMUVdj9snbpde+zx6KiBXhDOHs3V3pVokCCjiWe7gIii1Byy6Ltf6UdhAjdxbz7J9vC805d2xvcCWwgq6s0VCdvpE+kf13dfjp1rQ1JwZHFjyUfg= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1789554642; c=relaxed/simple; bh=QChgSQqvnf6c/lIB4mn0G+lFoP91Je7jvpkAWsYg9KI=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=osDHz3ITuEU8NrYOtKJKlr27fo1pB4qeQyOmT+57CGSf8Z/Uk1R3TswfiEOJ9TLjSMdTib8KHwSCWmMluuF2utO/F1bUmmcfssO5NEtN+qqxf9hB7I8oRD6RPVWgzeEFeBDyMlUymm8GuQ51jlZfVdIMCzgeTr2C8i0gQyr9d6I= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=hWIUT/Ah; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=fCm5XR3+; arc=none smtp.client-ip=205.220.168.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="hWIUT/Ah"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="fCm5XR3+" Received: from pps.filterd (m0279862.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 68G92vT01721238 for ; Wed, 16 Sep 2026 10:30:17 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= NWKFqRYP1BXZSJYeZ9+388TaOWZejTGN2ObzubjSvaE=; b=hWIUT/Ah+4aVZwDv 7TQOxZ0+4HYSwRMfmKxpn7092coc/Y8BkHBINikRtwvhylWyGPyPGKLYR1lPz4fB /PanSPV8/jgnqJBKZ2HWfjG01fY2R+DD+wxd5x1qYXzsIY4Cc/vcYGHeinfAcaSp oCDJii280lyb0cWPRJgvHMcxiJb531HNOFietJ2kYWF61iNd8n7ktqFZ8aSG1Q6v EiM+sEl6sVu0BANnuYUDz8DmONNt2pxKuG9PEDa+KPZIyqlOL2WNvdAREDdWbGff 6mPcqwmDNRNU6JpeQObdwM/7tubGcfuIwbIg2uLpgZvgpxzCe7x1Kp27fo57AtTh QGl5Tw== Received: from mail-qk1-f200.google.com (mail-qk1-f200.google.com [209.85.222.200]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4gqbmnkbyq-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Wed, 16 Sep 2026 10:30:17 +0000 (GMT) Received: by mail-qk1-f200.google.com with SMTP id af79cd13be357-936708f129aso835005985a.0 for ; Wed, 16 Sep 2026 03:30:16 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1789554616; x=1790159416; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :content-type:mime-version:subject:date:from:from:to:cc:subject:date :message-id:reply-to:content-type; bh=NWKFqRYP1BXZSJYeZ9+388TaOWZejTGN2ObzubjSvaE=; b=fCm5XR3+HDfqp6qjgqISw4FviPK7V2O93J85p7rjh4XmIl6iaOGffXHIoJb4+Ev5tN imHaJXvwcJcBRnZr1K7uqSV+mJ4Kf4KWD/mGbHzOGS8h//uAxNn1wDfSJHmdEYNPUi0Z 4puCOlJTHtRtqutAXXrelMnP2dU0mpz8Az8u6vqb/P0K+OFqRjho3bBp20u5lRDKsixM 9oRqIWui0R9eyyLWaQf8IYJ5x9oMdk7L1p+GnIB0QNsgAXTnwY1PUByBM1RBmQVpYrhp 1gqXPRhUBzYI6NT5slW1gGqipIayQaETd3O66NcTkDLRDXDJRit7K9+0X1mbSbZvIk/G af3g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20260707; t=1789554616; x=1790159416; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :content-type:mime-version:subject:date:from:x-gm-gg :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to :content-type; bh=NWKFqRYP1BXZSJYeZ9+388TaOWZejTGN2ObzubjSvaE=; b=gWXXj3T3TIgTc6NOpdxVPjNn5oynXlrmzbZLVp0uDwCY1nRDeCvKJqZ1bD7y5BaECq fKxm1iZeMk5WXQ/mH66CQsj7FATvsSjPsnCPmtX62+q6psn56YDDnnDpRoP+pHSkJmrA /5tYSYWvJ4MTG2c822v3SxFsY7xlyOiwgU0TR7TKjPug97KKdpjMVWkJfvaxrekGwAvz /hsszYCiDNCaGSBzRN4bljpXuC3ZfeEFCw7xe1OeuTGWsdswc+oI2+DH4D+QYGB9dLsM B6q57eNRfA3l54dYVVVaM1IOnHZkce2KOtpfw6zm9BKpiIkOfnSMU6M4hvWu5hD/cOHH KghQ== X-Forwarded-Encrypted: i=1; AKwUvBwTOIsSq3PpetGCqD1tpFx2udYHb1wEPM5xKcHRBYdbb7AXBaSQcLLwws1lVqyp2Ohtpgy0IoeK8dbiYkg=@vger.kernel.org X-Gm-Message-State: AFuF++nPswFhzGTmTXZMbhEt2+MtdOVrWOnh5bf8U5v6FmoUOQNcjNPd YP1x2Lc7VC3XzuXQK6WX42q7+MJaHq5US2qx8xfZ5VSWNGHMsE0uGr/fgXrgrf5s2B4fQtR1ivk QxYeYtEVEELoO8eBHzY3JFkcFTKrlov7FUIXyujqLA6owcEQOqhHTsqulmDdHrfvyeP4= X-Gm-Gg: AYBFou2LLf63OyVNQvZgmJOUhkbeozrBDIU8uOc0B5pBv4bYXTl/MeKFKqtUjDHSCTH P9R3P+M6cJnz+/YUjFRiTqAC69DFuHqRN2RZuajkv4pJ8E51bOpikxHG6xhkldIvI9OGY8vthSY iLgjH/iv7o1LBIWgOr6talLA091P/FzP3+1ZosYrMzGV+6pbDSPRx6Kp+rb+37BGvSAqTzud2hJ ZWGKK/Lp9bnT/ABDpaUAEHCNB912kM9QyAeTgPRKBvTI1S6RVvy2ZTXlNDnBYVTLv47dGY1POfc gfW5mxW+zmuEu9vi+mFahNBCmp6pwfHtezJwa3UVvLTQhigtcX94x23SbDaTiKR7/i05GPiTwqk T/0N6xaY= X-Received: by 2002:a05:620a:4385:b0:939:b482:d474 with SMTP id af79cd13be357-93bb79096femr296785085a.35.1789554616021; Wed, 16 Sep 2026 03:30:16 -0700 (PDT) X-Received: by 2002:a05:620a:4385:b0:939:b482:d474 with SMTP id af79cd13be357-93bb79096femr296775085a.35.1789554615301; Wed, 16 Sep 2026 03:30:15 -0700 (PDT) Received: from [127.0.1.1] ([86.121.170.232]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-49e83dbb0c1sm71633805e9.14.2026.09.16.03.30.13 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 16 Sep 2026 03:30:14 -0700 (PDT) From: Abel Vesa Date: Wed, 16 Sep 2026 13:28:45 +0300 Subject: [PATCH 29/48] clk: qcom: gcc-sm8250: Use common clock controller probe data Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20260916-clk-qcom-rework-legacy-always-on-clocks-v1-29-25a24e50f82a@oss.qualcomm.com> References: <20260916-clk-qcom-rework-legacy-always-on-clocks-v1-0-25a24e50f82a@oss.qualcomm.com> In-Reply-To: <20260916-clk-qcom-rework-legacy-always-on-clocks-v1-0-25a24e50f82a@oss.qualcomm.com> To: Bjorn Andersson , Abel Vesa , Stephen Boyd , Brian Masney , Jerome Brunet Cc: linux-arm-msm@vger.kernel.org, linux-clk@vger.kernel.org, linux-kernel@vger.kernel.org, Abel Vesa X-Mailer: b4 0.16-dev-0e65f X-Developer-Signature: v=1; a=openpgp-sha256; l=3657; i=abel.vesa@oss.qualcomm.com; h=from:subject:message-id; bh=QChgSQqvnf6c/lIB4mn0G+lFoP91Je7jvpkAWsYg9KI=; b=owEBbQKS/ZANAwAKARtfRMkAlRVWAcsmYgBqqm9nGW/po7DlXDbCnzMFWHg/wPB4Zbavnq/u9 bvyjjfG4AGJAjMEAAEKAB0WIQRO8+4RTnqPKsqn0bgbX0TJAJUVVgUCaqpvZwAKCRAbX0TJAJUV VsQfD/9ZkYJOlhePKgXiN+F4WttNdw4OPOMEnv0X4HsZHUoovdo3SJVkcbnJ/C/Tkk43nKWIm/k aPy51rYrOkwNjl6XhkkDshPN+degCNT6GgJJxrW+jhlLSDmbQsf7yTeua6MDMfstp+oR3J5cUZJ /6mk0gWd8ZE1HaAeJhcVWjIm2iCKKQC+GLeH2Xf+t/IdqIz2cEItKcaG79jfGirQ+aZcMpFqkfO 79KrkeW95i2NUp8UNc9Ymy5NNLR/aFlQXnczC9ML8CV+ed8RS4aCFbwUaTcCsjaIzfyH0fVzqZ9 VQSVsxJxBN/RVaqnuYPqqSGUIPm12TjeQbcJXDsH+kypVhhIAzCuOP27Jc42OexksNTExlKkpXF BZl3GMzchVUGirL1EK6DJez5YuOze/eep4+7A12jYYoOn5I0suCTGet5GWv7XIzgG98Zf3OH+q1 pXF4xnAu+X7Fbe9Go7CoN2RR3O1BxrJitrrb/0dQMyG2Fm/L2rs0S5apFjhC69qpDFLKVzc73UY hgLs1V0Q+HV0ltwzDLXWNchQhvqma5esJfI9FsN0YKYbmNZcAiijy3Ah03IKFUFPzhYdbJ/Lelz tY+x7WB3wPiRCZu+K+4rb9CbTyMfc/vICFVk845cBze44CvyRs0tT63b7B/pXRavd5oWR2xzqBu PjXQbc9Mt91LHWA== X-Developer-Key: i=abel.vesa@oss.qualcomm.com; a=openpgp; fpr=6AFF162D57F4223A8770EF5AF7BF214136F41FAE X-Authority-Analysis: v=2.4 cv=POyaavqC c=1 sm=1 tr=0 ts=6aaa6fb9 cx=c_pps a=hnmNkyzTK/kJ09Xio7VxxA==:117 a=po8fGBi+ks8MzcVQGuqtFQ==:17 a=IkcTkHD0fZMA:10 a=VdqzKS8jKosA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=_K5XuSEh1TEqbUxoQ0s3:22 a=EUspDBNiAAAA:8 a=RW22A4phRzxp-fsVvwcA:9 a=QEXdDO2ut3YA:10 a=PEH46H7Ffwr30OY-TuGO:22 X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwOTE2MDEzNyBTYWx0ZWRfX3uTQJPPpvvnQ CQL3ACAunpwIsceQfpBOtH3bXnkWNYxvPxcwHMWayHc8NdXQnez731elP6godKUTdjcXZRyBSQD Bov2Bp7ARcLf6eM7feOqaOiOdUfy8kD0nSpfpMCHsM5HvkHbiIHcHAZOFLHBuTymxJhErl+btV0 Sjvbal6wzPz4WWDTVs84+aczZm8tNJ1zGKge9iLfrupqdm9A0eSffmi9eOO147q/XnHmaUEcgL3 Bs0zwZOyFUHr8i3ZuVK3u5iyJnliQE+kvCGuoBbttlUCvyKbakdpqOZkkcB7tUu36qetnCY2P2L jOne0y/f6qYk0UpEf8q4N2rUDYtfsLZloDblJ30VGpxvCr9rYwUVxssUr8bgAQVnz+dHB6OMQIt C0SgIbAX6n+7PC9bw/BGYujXUbPs3d3MUoBzhi7tNHgXU99wtzpZWKCTW/cFNjLMmqY/qRmkhPY gP9jYT7HSNvYF/mi/FA== X-Proofpoint-GUID: 3E2v7wQSecQYxcULGRHr_-4pBB2Y5JtQ X-Proofpoint-Spam-Info: AW1haW4tMjYwOTE2MDEzNyBTYWx0ZWRfX3IcZ9iw3V8wC f1ISfnR7V34okHqMiDBSbbFPKe3gQ3MrQk/YbA/gksiowNpHqOIXSYJdvQTS3T3sjduNfYgGDTy lQDQSMWZ4lbc4I1yXaBIuWfrJD4uDfs= X-Proofpoint-ORIG-GUID: 3E2v7wQSecQYxcULGRHr_-4pBB2Y5JtQ X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1176,Hydra:6.1.134,FMLib:17.12.100.49 definitions=2026-09-15_05,2026-09-15_02,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 priorityscore=1501 adultscore=0 bulkscore=0 clxscore=1015 phishscore=0 suspectscore=0 impostorscore=0 spamscore=0 lowpriorityscore=0 malwarescore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2609040000 definitions=main-2609160137 Move the always-on branch register offsets into a critical_cbcrs array, describe the DFS RCGs through qcom_cc_driver_data and move the register programming into the clk_regs_configure callback. Use qcom_cc_probe() to perform the common initialization instead of open-coding it in the driver's probe. Assisted-by: LLM Signed-off-by: Abel Vesa Reviewed-by: Konrad Dybcio --- drivers/clk/qcom/gcc-sm8250.c | 57 ++++++++++++++++++++++-----------------= ---- 1 file changed, 29 insertions(+), 28 deletions(-) diff --git a/drivers/clk/qcom/gcc-sm8250.c b/drivers/clk/qcom/gcc-sm8250.c index 1c59d70e0f96..f6ce572261bb 100644 --- a/drivers/clk/qcom/gcc-sm8250.c +++ b/drivers/clk/qcom/gcc-sm8250.c @@ -3603,6 +3603,15 @@ static const struct clk_rcg_dfs_data gcc_dfs_clocks[= ] =3D { DEFINE_RCG_DFS(gcc_qupv3_wrap2_s5_clk_src), }; =20 +static const u32 gcc_sm8250_critical_cbcrs[] =3D { + 0x0b004, /* GCC_VIDEO_AHB_CLK */ + 0x0b008, /* GCC_CAMERA_AHB_CLK */ + 0x0b00c, /* GCC_DISP_AHB_CLK */ + 0x4818c, /* GCC_CPUSS_DVM_BUS_CLK */ + 0x71004, /* GCC_GPU_CFG_AHB_CLK */ + 0x52000, /* GCC_SYS_NOC_CPUSS_AHB_CLK */ +}; + static const struct regmap_config gcc_sm8250_regmap_config =3D { .reg_bits =3D 32, .reg_stride =3D 4, @@ -3611,6 +3620,24 @@ static const struct regmap_config gcc_sm8250_regmap_= config =3D { .fast_io =3D true, }; =20 +static void gcc_sm8250_regs_configure(struct device *dev, struct regmap *r= egmap) +{ + /* + * Disable the GPLL0 active input to NPU and GPU + * via MISC registers. + */ + regmap_update_bits(regmap, 0x4d110, 0x3, 0x3); + regmap_update_bits(regmap, 0x71028, 0x3, 0x3); +} + +static const struct qcom_cc_driver_data gcc_sm8250_driver_data =3D { + .clk_cbcrs =3D gcc_sm8250_critical_cbcrs, + .num_clk_cbcrs =3D ARRAY_SIZE(gcc_sm8250_critical_cbcrs), + .dfs_rcgs =3D gcc_dfs_clocks, + .num_dfs_rcgs =3D ARRAY_SIZE(gcc_dfs_clocks), + .clk_regs_configure =3D gcc_sm8250_regs_configure, +}; + static const struct qcom_cc_desc gcc_sm8250_desc =3D { .config =3D &gcc_sm8250_regmap_config, .clks =3D gcc_sm8250_clocks, @@ -3619,6 +3646,7 @@ static const struct qcom_cc_desc gcc_sm8250_desc =3D { .num_resets =3D ARRAY_SIZE(gcc_sm8250_resets), .gdscs =3D gcc_sm8250_gdscs, .num_gdscs =3D ARRAY_SIZE(gcc_sm8250_gdscs), + .driver_data =3D &gcc_sm8250_driver_data, }; =20 static const struct of_device_id gcc_sm8250_match_table[] =3D { @@ -3629,34 +3657,7 @@ MODULE_DEVICE_TABLE(of, gcc_sm8250_match_table); =20 static int gcc_sm8250_probe(struct platform_device *pdev) { - struct regmap *regmap; - int ret; - - regmap =3D qcom_cc_map(pdev, &gcc_sm8250_desc); - if (IS_ERR(regmap)) - return PTR_ERR(regmap); - - /* - * Disable the GPLL0 active input to NPU and GPU - * via MISC registers. - */ - regmap_update_bits(regmap, 0x4d110, 0x3, 0x3); - regmap_update_bits(regmap, 0x71028, 0x3, 0x3); - - /* Keep some clocks always-on */ - qcom_branch_set_clk_en(regmap, 0x0b004); /* GCC_VIDEO_AHB_CLK */ - qcom_branch_set_clk_en(regmap, 0x0b008); /* GCC_CAMERA_AHB_CLK */ - qcom_branch_set_clk_en(regmap, 0x0b00c); /* GCC_DISP_AHB_CLK */ - qcom_branch_set_clk_en(regmap, 0x4818c); /* GCC_CPUSS_DVM_BUS_CLK */ - qcom_branch_set_clk_en(regmap, 0x71004); /* GCC_GPU_CFG_AHB_CLK */ - qcom_branch_set_clk_en(regmap, 0x52000); /* GCC_SYS_NOC_CPUSS_AHB_CLK */ - - ret =3D qcom_cc_register_rcg_dfs(regmap, gcc_dfs_clocks, - ARRAY_SIZE(gcc_dfs_clocks)); - if (ret) - return ret; - - return qcom_cc_really_probe(&pdev->dev, &gcc_sm8250_desc, regmap); + return qcom_cc_probe(pdev, &gcc_sm8250_desc); } =20 static struct platform_driver gcc_sm8250_driver =3D { --=20 2.54.0 From nobody Fri Sep 25 05:31:34 2026 Received: from mx0a-0031df01.pphosted.com (mx0a-0031df01.pphosted.com [205.220.168.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 1981B3A2E12 for ; Wed, 16 Sep 2026 10:30:22 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.168.131 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1789554640; cv=none; b=R+qPB5yQ+F32JGLMzkW1JrsxSNQGGxS9PtYAZdKk9bPJuzTe9a966tqH5DeSSGXXwlr1ZO/4jurNY0/SWD4yahPJddUxbhFKVPqtEf/NFvaR73rKXASGoyWYU7gKRsMbAfdFU0Lbp4e8CsDjDpIOJRsOzyTfa8E4LwAO4KzZxp4= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1789554640; c=relaxed/simple; bh=2FNtl6FgL6swZmbTyEzvU77vBhEq1DWGMQXVqzNacrk=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=SaNJ+On4b6MZ5yD+BCMaJRWawWxOshAng7XWgm0/6f5GOESCBjv9fXymDq2LpWQNj1vdAZ+GqS/Jt5xJ3cJVTYaf7fo998aRoCXiOHUga+pxG8wSvtMIcaH8D77X26c88ehGcEwp7U6r/RabLD5yOzMEAVLSvOMLorjc4mxUqQc= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=SdRRzVBZ; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=OasBkZz+; arc=none smtp.client-ip=205.220.168.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="SdRRzVBZ"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="OasBkZz+" Received: from pps.filterd (m0279863.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 68G92eur2348114 for ; Wed, 16 Sep 2026 10:30:19 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= 4eDSg+wuxm2DvPHbiPGZ2PZRKDFr5EuuqL8y8q6hc+0=; b=SdRRzVBZCYEIfSXY +nn4gy3M9Iglev+t5bfNv16jrX8iEDW2P0KZ2LLLOrcPZOq3vfhM0flK0pAUto0h hvsbtFMm1FOZVbe1ryAtg1ky6n3ZxCkiXxLRtFiRzTqJzFldGCNJJ1sPGxXgFDc6 AE1YShl9Co2u8PpAF8H3H8cakOCt0ebi0GqdHlN6/YYa2EoL4KGYZpvOkiKGdy7t LMCCmJsluGLo99EwmB4gVE87mqQJAV7e1NoJU5E01yNfooWeYoBqgqakhYfnUvdB c6KgitTvX8WkNJY7XxxKOVmpPUmrKXFWSLgMnq7p1WboyS7jjvDtD/hNy70D7bCS gk26JA== Received: from mail-qk1-f197.google.com (mail-qk1-f197.google.com [209.85.222.197]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4gqdywas7e-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Wed, 16 Sep 2026 10:30:19 +0000 (GMT) Received: by mail-qk1-f197.google.com with SMTP id af79cd13be357-939f925ba4eso20066185a.3 for ; Wed, 16 Sep 2026 03:30:19 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1789554618; x=1790159418; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :content-type:mime-version:subject:date:from:from:to:cc:subject:date :message-id:reply-to:content-type; bh=4eDSg+wuxm2DvPHbiPGZ2PZRKDFr5EuuqL8y8q6hc+0=; b=OasBkZz+xBnaBJjXReq8zVwSf5emieSKdyCph0Ng2SEl+sKxtNaCZNjFVzTDrI0fSN +63GuwmOF5satvCLhTkpw/1xCKvrta/Yo6mI090ngKlH/HrOqMtTFSFrjwdMx2mPr0cQ xHkdGp6BuCren/Xov86QLCqrrzaclMXr5NJMWcgPRcT9tOCMNk24LCyLBLwsVM2fHoL9 PWN8SMPUqW6b2K9ssPxY5yYn9c3+6q1VU8drvZQ6yhC9p0RARhcFYcb3uamOLDtBSeZG Fsjolsb9tXGwS7RhzSm4pf20Xp20M54KcXNkFMlngBOVTrh+CD+oDvtQF/YcRbsZiTsg pVRg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20260707; t=1789554618; x=1790159418; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :content-type:mime-version:subject:date:from:x-gm-gg :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to :content-type; bh=4eDSg+wuxm2DvPHbiPGZ2PZRKDFr5EuuqL8y8q6hc+0=; b=fhQcKVKiD9TREP0OM2ez1xeZYiao2TH7UmCkB1N+4IC+V1xS9lOCVFiolpE7VS1IVz khUHT6oARjlVJWArVLkGAQE0Ghp/ipM4a81dpzieqCMUved+CQqDRMlgDJ63wDRNnWmx L65cGMJIuvODm09g8HYSKkXeuHLx8rIuhqEYb+vezq5cFsAVz6/zn2PJ0jTv+L6TUqBh i/0iOCJlXee9fCaKl+BATcQ/q0XYBq6piNpZxEBU88OtpbCN+HSUR691w6JPNar01H/8 7uHq0o9ARNtM0jaxguygHdiPVYRDeNkyGL5TA+parC/1RlbQ2DjrVx1wZ1WqvHuhXgXy oCeg== X-Forwarded-Encrypted: i=1; AKwUvBxWASHmZ9Z215JIU4DKmOEfEz6Qw2fWqsmYJvEyHZK8wU393bpRGXtCuSjJC5XPy+yewUXHV6ThgBO53gY=@vger.kernel.org X-Gm-Message-State: AFuF++nXyAESBUYoHEOC2CZQwaxKijUo5oOyDd5YkOXmp5XdguRlY4QU +JLJwvQvuThqzfD40II4xCbMFk8kw6M5+pE2f+ZsMMAaieQhkTH2+UQCqOpP4p/hUcHATHrQKkt 7Oayt51Okag556HdnKkBmuuFIpOpw0IIPntzHgzgqXgpp4ZQVqiRQdTiACF1oP2paPm4= X-Gm-Gg: AYBFou2R1TxFiCHqN0k9AdT7EKE8YHKESquKCvS62gMpAH7EKSJbeEIZp5cFO4yS6WZ srFriUxzbc8jjX3K+gDh41yihwXsuSmSnTwWYahIKMJ6y3AxtIFnKT7G4182J7b2hQvNQXG/Sqb mBviTs4cko5QhyF/8Jj6YPrm9MCUYJYmFVyup0/D56hZwUk86eHZp0lUCRuQPbY5+WP4B52zXMD vfhV7Tk1BuLVqODpMZzqOrrJaSYFguiH43b3J0pKdaPfvi0S4EOFPrsTvBIh3H51+1/hBnt7Klj nlw0rLF8f3KDMWdN9S2GT9xF0HhyIE/Cn9IFBy7Z7ATrXxVD8PyojFozCZvdiMN4XN36hU0dvzu r8nVFwro= X-Received: by 2002:a05:620a:a40b:10b0:939:f89:3688 with SMTP id af79cd13be357-93bb79005f6mr202505385a.42.1789554617910; Wed, 16 Sep 2026 03:30:17 -0700 (PDT) X-Received: by 2002:a05:620a:a40b:10b0:939:f89:3688 with SMTP id af79cd13be357-93bb79005f6mr202499285a.42.1789554617397; Wed, 16 Sep 2026 03:30:17 -0700 (PDT) Received: from [127.0.1.1] ([86.121.170.232]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-49e83dbb0c1sm71633805e9.14.2026.09.16.03.30.15 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 16 Sep 2026 03:30:16 -0700 (PDT) From: Abel Vesa Date: Wed, 16 Sep 2026 13:28:46 +0300 Subject: [PATCH 30/48] clk: qcom: gcc-sm8350: Use common clock controller probe data Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20260916-clk-qcom-rework-legacy-always-on-clocks-v1-30-25a24e50f82a@oss.qualcomm.com> References: <20260916-clk-qcom-rework-legacy-always-on-clocks-v1-0-25a24e50f82a@oss.qualcomm.com> In-Reply-To: <20260916-clk-qcom-rework-legacy-always-on-clocks-v1-0-25a24e50f82a@oss.qualcomm.com> To: Bjorn Andersson , Abel Vesa , Stephen Boyd , Brian Masney , Jerome Brunet Cc: linux-arm-msm@vger.kernel.org, linux-clk@vger.kernel.org, linux-kernel@vger.kernel.org, Abel Vesa X-Mailer: b4 0.16-dev-0e65f X-Developer-Signature: v=1; a=openpgp-sha256; l=3212; i=abel.vesa@oss.qualcomm.com; h=from:subject:message-id; bh=2FNtl6FgL6swZmbTyEzvU77vBhEq1DWGMQXVqzNacrk=; b=owEBbQKS/ZANAwAKARtfRMkAlRVWAcsmYgBqqm9odCKknZiAbQ0hlhxlFoWscJNVjABibjsw0 LefSxMKTyOJAjMEAAEKAB0WIQRO8+4RTnqPKsqn0bgbX0TJAJUVVgUCaqpvaAAKCRAbX0TJAJUV Vr4KEACjoCkzSwXYdAaOV1fzIFfFziIJ5pWwvE/JwsqIXSdB5LAYrvmWeU2sPji82x8nVvYvony DOScEMIVpnen/imN1OcMatEJf0TtJA21PT1Mps90R4sWgF7zVmvbGtXbzQRQ49ztQSEXjgsD6EY sk1kG2q8cq2Kw9lA0EqjNehhPPn99MUIFWOpG4NSPWgjfClow4hf0IQSxAxXOSCTSj1L5av8Pui IljgIbcqb4+2SkOcNYu7RRIk8QnzccydwuqM3fTTptJDKURICdih7N72GLjU42Nc2Y1PpvGv6qp sEHkvviuGWJMLp2nIgsH3b7XL6VFPxglQXBo/+Ily+dU7cpHxpgCxgy3Ho1lzXRK0SY2mfvElMU CXajHPXsAKP+rRwYXlDc8l56Z9/5kAxrFT6/sp851u73ReGubGA1EqFdpPcomJfWTsH3n45mP0a 61XTKM4acqIRpcuTnDeM68gkHAdcMp3p1+McbYeU01qNG5QziQrhEF4/Ws6a1n/Zt3aoRZ3bVh3 1DQV4isf0YUl/j70BPqwWyLJZWEXKuvFmTFAmposppZ4q2ELt9AR/ELFwTNktLNC6tSOR+metk/ 0m+jXHIHtEgPcqZ9o4m8foWMyzWK7HPspGVF+rlNBrAIPcx7INJInckTqBDkSC9hPuTB7hKz1il KYISYoD1CNojM1w== X-Developer-Key: i=abel.vesa@oss.qualcomm.com; a=openpgp; fpr=6AFF162D57F4223A8770EF5AF7BF214136F41FAE X-Proofpoint-GUID: NexV9EIY16opfSJihE70K_6WVN4Uf6J4 X-Authority-Analysis: v=2.4 cv=aJ1lOr9m c=1 sm=1 tr=0 ts=6aaa6fbb cx=c_pps a=50t2pK5VMbmlHzFWWp8p/g==:117 a=po8fGBi+ks8MzcVQGuqtFQ==:17 a=IkcTkHD0fZMA:10 a=VdqzKS8jKosA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=yOCtJkima9RkubShWh1s:22 a=EUspDBNiAAAA:8 a=RW22A4phRzxp-fsVvwcA:9 a=QEXdDO2ut3YA:10 a=IoWCM6iH3mJn3m4BftBB:22 X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwOTE2MDEzNyBTYWx0ZWRfXyOxhaNyFll7A NrORrzpoSiGX0U4fNKaBXuXuuAlLdOl7Vtmq7CYRcNTYV6ge0r31tfT5mRyKfgrB5VDD3mZ4QwY BiMIQHLNrqZm4sLUK4aLSXGgf9KEbpXBqXgE5ADCEa0pWV9m84odP86SFaSxNSJIcPtVpSj6ysS TxxC7/dvKMhi0GiiDDkQGo3jg2wwje2czal0sw6l4LPnZ4hA9Gs+KpSAF/OWNkkgjpplZiRvV5b PaLUM0V6hidxTL2oZVl8wvXN0AG6I/20xE3gEEG1dWu2Lq5bxJBcaXLvwwgBS4XGEWmLTjVEA+p axBAFV1tiAho2FtjYKkvZnMH/AG7eOkLLWKVp+Xn4MCfygtuyW3d2wtVLBkjabhc/9sDFjaDxqv h0BnmFyF5KQOhfFHCKFUz6FiRtPiLbOYu3v3CzM5S9icYnHjO+7ZNMWV0PSQ9nabMmC0XtRblTM a0T+4NJVvYNa9cP7SjQ== X-Proofpoint-ORIG-GUID: NexV9EIY16opfSJihE70K_6WVN4Uf6J4 X-Proofpoint-Spam-Info: AW1haW4tMjYwOTE2MDEzNyBTYWx0ZWRfX6EPfGHhe+HWW Z7EbR8unS9bmAFHFbVhgsRip+I58FBw1Kv0LDvsAVphq9HU8XiWSMUeq02dXABDLMB+LdXhxNJq D6QF/CO3TX0hOjSX/lvXdlDbyCkESDw= X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1176,Hydra:6.1.134,FMLib:17.12.100.49 definitions=2026-09-15_05,2026-09-15_02,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 adultscore=0 impostorscore=0 phishscore=0 suspectscore=0 bulkscore=0 malwarescore=0 clxscore=1015 priorityscore=1501 spamscore=0 lowpriorityscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2609040000 definitions=main-2609160137 Move the always-on branch register offsets into a critical_cbcrs array, describe the DFS RCGs through qcom_cc_driver_data and move the register programming into the clk_regs_configure callback. Use qcom_cc_probe() to perform the common initialization instead of open-coding it in the driver's probe. Assisted-by: LLM Signed-off-by: Abel Vesa Reviewed-by: Konrad Dybcio --- drivers/clk/qcom/gcc-sm8350.c | 52 +++++++++++++++++++++------------------= ---- 1 file changed, 26 insertions(+), 26 deletions(-) diff --git a/drivers/clk/qcom/gcc-sm8350.c b/drivers/clk/qcom/gcc-sm8350.c index 2d94f3046b71..850ad9f291c5 100644 --- a/drivers/clk/qcom/gcc-sm8350.c +++ b/drivers/clk/qcom/gcc-sm8350.c @@ -3779,7 +3779,32 @@ static const struct regmap_config gcc_sm8350_regmap_= config =3D { .fast_io =3D true, }; =20 +static const u32 gcc_sm8350_critical_cbcrs[] =3D { + 0x26004, /* GCC_CAMERA_AHB_CLK */ + 0x26018, /* GCC_CAMERA_XO_CLK */ + 0x27004, /* GCC_DISP_AHB_CLK */ + 0x2701c, /* GCC_DISP_XO_CLK */ + 0x71004, /* GCC_GPU_CFG_AHB_CLK */ + 0x28004, /* GCC_VIDEO_AHB_CLK */ + 0x28020, /* GCC_VIDEO_XO_CLK */ +}; + +static void gcc_sm8350_regs_configure(struct device *dev, struct regmap *r= egmap) +{ + /* FORCE_MEM_CORE_ON for ufs phy ice core clocks */ + regmap_update_bits(regmap, gcc_ufs_phy_ice_core_clk.halt_reg, BIT(14), BI= T(14)); +} + +static const struct qcom_cc_driver_data gcc_sm8350_driver_data =3D { + .clk_cbcrs =3D gcc_sm8350_critical_cbcrs, + .num_clk_cbcrs =3D ARRAY_SIZE(gcc_sm8350_critical_cbcrs), + .dfs_rcgs =3D gcc_dfs_clocks, + .num_dfs_rcgs =3D ARRAY_SIZE(gcc_dfs_clocks), + .clk_regs_configure =3D gcc_sm8350_regs_configure, +}; + static const struct qcom_cc_desc gcc_sm8350_desc =3D { + .driver_data =3D &gcc_sm8350_driver_data, .config =3D &gcc_sm8350_regmap_config, .clks =3D gcc_sm8350_clocks, .num_clks =3D ARRAY_SIZE(gcc_sm8350_clocks), @@ -3797,32 +3822,7 @@ MODULE_DEVICE_TABLE(of, gcc_sm8350_match_table); =20 static int gcc_sm8350_probe(struct platform_device *pdev) { - struct regmap *regmap; - int ret; - - regmap =3D qcom_cc_map(pdev, &gcc_sm8350_desc); - if (IS_ERR(regmap)) { - dev_err(&pdev->dev, "Failed to map gcc registers\n"); - return PTR_ERR(regmap); - } - - /* Keep some clocks always-on */ - qcom_branch_set_clk_en(regmap, 0x26004); /* GCC_CAMERA_AHB_CLK */ - qcom_branch_set_clk_en(regmap, 0x26018); /* GCC_CAMERA_XO_CLK */ - qcom_branch_set_clk_en(regmap, 0x27004); /* GCC_DISP_AHB_CLK */ - qcom_branch_set_clk_en(regmap, 0x2701c); /* GCC_DISP_XO_CLK */ - qcom_branch_set_clk_en(regmap, 0x71004); /* GCC_GPU_CFG_AHB_CLK */ - qcom_branch_set_clk_en(regmap, 0x28004); /* GCC_VIDEO_AHB_CLK */ - qcom_branch_set_clk_en(regmap, 0x28020); /* GCC_VIDEO_XO_CLK */ - - ret =3D qcom_cc_register_rcg_dfs(regmap, gcc_dfs_clocks, ARRAY_SIZE(gcc_d= fs_clocks)); - if (ret) - return ret; - - /* FORCE_MEM_CORE_ON for ufs phy ice core clocks */ - regmap_update_bits(regmap, gcc_ufs_phy_ice_core_clk.halt_reg, BIT(14), BI= T(14)); - - return qcom_cc_really_probe(&pdev->dev, &gcc_sm8350_desc, regmap); + return qcom_cc_probe(pdev, &gcc_sm8350_desc); } =20 static struct platform_driver gcc_sm8350_driver =3D { --=20 2.54.0 From nobody Fri Sep 25 05:31:34 2026 Received: from mx0b-0031df01.pphosted.com (mx0b-0031df01.pphosted.com [205.220.180.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 0A1AE4EBAD0 for ; Wed, 16 Sep 2026 10:30:23 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.180.131 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1789554647; cv=none; b=FzcO/wR9l90lZXJjAUCjYAV+K/IQpYWZTH/Uga2lxbXYoBDA0MQgzFCymxMWug7GzWYvvoHxxAnTuMwnPGu+XiWXsSyFhfpYNKZOCNaANUbLGx4d2K9nnoPFdpiePNRwqv8bjPV6RMU232BnDU5tFnPfwhXMg0SHJQbOcP2P66k= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1789554647; c=relaxed/simple; bh=xux2LST8xwir1FkQSENASfPbgYAGg/mYsd8LaSFevs4=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=BZwqWgI3pTMEsfLxzbY2wPIbj29mCHHXgnG2SN7TjCldnbSeMGCoiPgFMa10n/u/zDPH3fUUBmG9lNoZWO0xImQy8l412X4fHB951u12Qjx1ryLvMWJzaX5HeOCfOTr88oAA3e/NMFk85XzG64TevElO4sEonBfp1KSISUGx530= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=BEPzxi5o; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=Q3OaUHDD; arc=none smtp.client-ip=205.220.180.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="BEPzxi5o"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="Q3OaUHDD" Received: from pps.filterd (m0279872.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 68G932kC1587054 for ; Wed, 16 Sep 2026 10:30:20 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= 7XX3EFpvysfu1gUnUdLZB4FxWj20d/RsepVeR0k7x1g=; b=BEPzxi5oAxwgb6Qa Avt6EHSRfKIoIhjx0obrDH0EeGQOiue1Md8jGUdhs/x/5CNYUKM8eTxe4ubyNEgb DRqsTA/i2nvjD/t3hHGEuXXyE2b8XYuvALsecbpnl7E3TaLpEk0nERySOzL6yWtx nSCOLXuBoEEtiEwtsnb+LTOiVF06um0YmS2cyG58EE6cw9aF2Vc/L8IQ7RKpY1B/ 6RjJAN/1zn2r41Z4px+0Y9g788ZpDDigD8urONIkJqItOPouC9s7+9P/3oVIjRIG STZEsIJvDVHwxJKp/cf9//7+VvUTI3GMuTwBTTbMCAzfNJ5MoA/OLq8DcJuvehX/ MfbQ9g== Received: from mail-qk1-f200.google.com (mail-qk1-f200.google.com [209.85.222.200]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4gqagekset-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Wed, 16 Sep 2026 10:30:20 +0000 (GMT) Received: by mail-qk1-f200.google.com with SMTP id af79cd13be357-939d6c515deso1104262585a.3 for ; Wed, 16 Sep 2026 03:30:20 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1789554620; x=1790159420; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :content-type:mime-version:subject:date:from:from:to:cc:subject:date :message-id:reply-to:content-type; bh=7XX3EFpvysfu1gUnUdLZB4FxWj20d/RsepVeR0k7x1g=; b=Q3OaUHDDAToUJ0u5qsmqikkqq1p5lBNgULgMzAfR3/j5bxqcjtic9JMI+EX+ZbzhRh DYy8b1xsyBbLXphp6zkrGzc8DwmzxjGwPj6vZiNT4t0cMwVb8aOtPY8S6PVYScEHxfob dZoVKZ65RaeHaNLzoOBWqapSKOaYAk3j5I4uO6q0c5f0eqr6LSiiYTyeqYwT6W46ju/b A1Uuhh0iAJTBmm5QL5v/ZtzspPy9MSRrXwzhDRtOXzrMFnT2BZsVj2+puynA2rz6NZM/ iWCvFbaBbwE4NqeeQhFJ/3ofA2N7wCxdCVdhsyn6rl32zeGgPGA6/xBTVVRZ2heviOT8 ZOzg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20260707; t=1789554620; x=1790159420; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :content-type:mime-version:subject:date:from:x-gm-gg :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to :content-type; bh=7XX3EFpvysfu1gUnUdLZB4FxWj20d/RsepVeR0k7x1g=; b=vHr1ZdhbthAifbSunhVPVtWX/g3kiBoIVJoVjObnuH3fz68rMPLDP9qtoGmT8xDUFO qCyPIT2GOddjrApBFLsKs7/0BQuU6s/tOCw3AjifGzZVIrlCmsbnTYZhkbp/40RsH7uU VxuO/kX6JMVerhp/ll4Eu5GUDj+q4zrQ2M3L/jqjSUFJnqXlSsAYc6rTN1v7porwTkUc VmMVFVwnbzko4bRRJajnc++IRoLLrXxrk3R1A/A5xfJaRc7aaggJYO0WPhl28JenliFQ RlpVwxMKKUDdzMpmGfYdxfQ+KdrwH4VO2Q+C1rPUKhyrTjLaoz5f3HoU/6b3SHdwPoa4 BBJQ== X-Forwarded-Encrypted: i=1; AKwUvBzuHoW5tEiG/X9qBFfumP6vCaWt1LGq6mybpTHyQwwmp6L0qtlug+Vz8VR9RmC+2Jd/SiWE0CkOt97fJ9Q=@vger.kernel.org X-Gm-Message-State: AFuF++kFTnCuE5OGMAX7CUkErXRUQ6kEDwR9UxkPTnCOwp0632uANlDY cD8YfnHzeSpqepqReyKFJ9AbeWn9BvIIdP1V/pJmmdusBGeNyIVFrC/j+sIbgnSF34/yai9EP8s 0eVTI4C9TcVIRe6W2mcAI3fEGY3L5OzvQcn9GQd9Zejp+4EwMKwmPDJeFhxofeRMq9G0= X-Gm-Gg: AYBFou3Q5q9XafaVCBlhj9UbzRwBHG6lAdKmmSkbUkYh+m1cLa+viZvi6EmvVoBltLX wvCyWTaU3N+CM/hTTZf/CXOAQpy/z3UlAU83LZzv7nt012XtXdJHoosoCHNSB9chRgbmO8Ch7hS a4/lkUKWCS92XlDkJoyXwNRQmjSD1Rt3IWwN2y24a5yJTa9p56slEKVtQUbCGdJe/41WhkZQI8k so05rr5soeY47MRDIdHPQ92awsdPhXMAboy5Y0YrnlafmcQ3Rqu4ZN2grGyVPZpCjZBccNlOI5B pMdj/PfyeXASlyiuzIKMIOOAmHxtIR6ZzdRujXzD05DsEbFe7PFtBOFK9hegq+9RHzHUpoOOP8K QZ6zl7Ps= X-Received: by 2002:a05:620a:6504:b0:93a:48a:171 with SMTP id af79cd13be357-93bb798e710mr289695285a.51.1789554619947; Wed, 16 Sep 2026 03:30:19 -0700 (PDT) X-Received: by 2002:a05:620a:6504:b0:93a:48a:171 with SMTP id af79cd13be357-93bb798e710mr289686185a.51.1789554619271; Wed, 16 Sep 2026 03:30:19 -0700 (PDT) Received: from [127.0.1.1] ([86.121.170.232]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-49e83dbb0c1sm71633805e9.14.2026.09.16.03.30.17 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 16 Sep 2026 03:30:18 -0700 (PDT) From: Abel Vesa Date: Wed, 16 Sep 2026 13:28:47 +0300 Subject: [PATCH 31/48] clk: qcom: gcc-sm8450: Use common clock controller probe data Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20260916-clk-qcom-rework-legacy-always-on-clocks-v1-31-25a24e50f82a@oss.qualcomm.com> References: <20260916-clk-qcom-rework-legacy-always-on-clocks-v1-0-25a24e50f82a@oss.qualcomm.com> In-Reply-To: <20260916-clk-qcom-rework-legacy-always-on-clocks-v1-0-25a24e50f82a@oss.qualcomm.com> To: Bjorn Andersson , Abel Vesa , Stephen Boyd , Brian Masney , Jerome Brunet Cc: linux-arm-msm@vger.kernel.org, linux-clk@vger.kernel.org, linux-kernel@vger.kernel.org, Abel Vesa X-Mailer: b4 0.16-dev-0e65f X-Developer-Signature: v=1; a=openpgp-sha256; l=3821; i=abel.vesa@oss.qualcomm.com; h=from:subject:message-id; bh=xux2LST8xwir1FkQSENASfPbgYAGg/mYsd8LaSFevs4=; b=owEBbQKS/ZANAwAKARtfRMkAlRVWAcsmYgBqqm9p5BLy09XicihrlHUF7+8+oHeBaRSdMHPyc MFEg2S1pCuJAjMEAAEKAB0WIQRO8+4RTnqPKsqn0bgbX0TJAJUVVgUCaqpvaQAKCRAbX0TJAJUV VpblD/4ku3RgQf5az/4ylh0bSX5w0PZtyOG9uiL4N4LmbPhrZY/NJfj1/6Z0MbJYXCGWlEMrqdL 7AX1yAHakLGfoydlS/NAQOuTxPQyj/DwPWa2nMa4yxidd7oP2VsJOOkOPrcMqgDtVPJT6RTtWz4 /AcGguZNMHVQnLxhX8x/ECugUFHxvutMrEZuTdbVuvsmhkHzHKWQcHT54A+Rkox1b8bvBfU3Iws kDjz9MEoSxmcQtVL7vVaRVyANT2KNHXFbttdYPDImmq2DZw9HhRzqit4fbi3dKxx/EppbCeA7I3 kqHX/SssGvPBapTIvYVsRho7I/hfZlDGSVA+4+hOiZ0VVOTuPFYvAkavut/t1Yor8QTUAbaGhx4 PovAu7aOL1B4NQyZxvi7cbkBw8XOMnGJ5nJhh7hD0RYFPr5PAPErHaVjTtzocRq8R6kRVNzfLPt 0tdA11dLnX15DUqzKml798MTrF5yRwgToJXihTYbCrGaWT6e9Ha1Ezo8OuhH4uL9mPzQ3aXJhgH UtWfsm8gYZHsqzdZhRdbKVDb1Tkw1RfpEFaNDCrE7LdddV61uTuDGPX20R8EMBva+u/1wykDZ/x nk/GsdwU7fGAOw/QqR3V2Az68sVxQdRloc2ERP/v+PPOpOp5bEjwOUWB6Ck0pmlfR9iTovJ7dJR U1fxZV0YuIM24LQ== X-Developer-Key: i=abel.vesa@oss.qualcomm.com; a=openpgp; fpr=6AFF162D57F4223A8770EF5AF7BF214136F41FAE X-Proofpoint-Spam-Info: AW1haW4tMjYwOTE2MDEzNyBTYWx0ZWRfXzIp2Q9wjBR4Q mvnSnIdHUQ3IgROV3HiedmAkbVDv3TBKE5J1+QP46eqp9ZTt9ywbCYFcW6pLDhHy7LiTm+U3qGP uBdkVnxcxceioIjA1TdYISVZbbkclSY= X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwOTE2MDEzNyBTYWx0ZWRfX9oNyjx48j2rN h0KGsu1lJooRn8cEvuFc37MlW1K9zItMQbrwwvljpAwULw3wxvUqJj6vNN5VTA5zQnDqZLQLZdm ZW0w8lScO3Cga13yxQXCpmJwdGkmpZ4KvXytD8oBbXiv5CO42T4LdxtMIuuuPWhk7wHpFIlC/0w +HpI2mGjWyr6u1W+4/kWRT/Xxx89jiSQuNcVz0Sm+W8gxuW20vINnXTaCMewzGrsFbuD2ZWUEDL XbwtPMWVKF8Ms7llAKBip5YClnV84XKBalx1+1CM3FzS565oJB8Gr+66WqJh+h6Y7MwM0LhNw6v jDKMTJzJHQ80/4qfOWTWSm0N32oTxG1urSMduMh27O/Iy8Sn63+kgza/puesDg0IvynSPxsJZEs rqZ/vCvl9nS7rUzpVk/9GOBdaKjHzGzRxaOcAOhk98UGvtUnyTtzTOi6JA6FmkNEWlqHXQipxFw BfmXE2hVIzzYM88bwRQ== X-Proofpoint-GUID: 0naOG6D10zPp2JQSiwjmeqHzj8o2DVI4 X-Proofpoint-ORIG-GUID: 0naOG6D10zPp2JQSiwjmeqHzj8o2DVI4 X-Authority-Analysis: v=2.4 cv=PcZqFShd c=1 sm=1 tr=0 ts=6aaa6fbc cx=c_pps a=hnmNkyzTK/kJ09Xio7VxxA==:117 a=po8fGBi+ks8MzcVQGuqtFQ==:17 a=IkcTkHD0fZMA:10 a=VdqzKS8jKosA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=yx91gb_oNiZeI1HMLzn7:22 a=EUspDBNiAAAA:8 a=39i0T9gdeGRrow2g5OEA:9 a=QEXdDO2ut3YA:10 a=PEH46H7Ffwr30OY-TuGO:22 X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1176,Hydra:6.1.134,FMLib:17.12.100.49 definitions=2026-09-15_05,2026-09-15_02,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 spamscore=0 phishscore=0 suspectscore=0 malwarescore=0 impostorscore=0 clxscore=1015 lowpriorityscore=0 priorityscore=1501 adultscore=0 bulkscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2609040000 definitions=main-2609160137 Move the always-on branch register offsets into a critical_cbcrs array and describe the DFS RCGs through qcom_cc_driver_data. Move the UFS PHY ICE core FORCE_MEM_CORE_ON setting into the clk_regs_configure callback. This moves the UFS setting after the always-on branch enables. Those branches serve the camera, display, GPU and video blocks, not the UFS PHY ICE core clock. The UFS setting is still applied before GDSC and CCF clock registration. Keep the SM8475-specific PLL and RCG adjustments in the driver's probe before calling qcom_cc_probe(), which now handles register mapping and the common initialization sequence. Assisted-by: LLM Signed-off-by: Abel Vesa Reviewed-by: Konrad Dybcio --- drivers/clk/qcom/gcc-sm8450.c | 51 ++++++++++++++++++++++-----------------= ---- 1 file changed, 26 insertions(+), 25 deletions(-) diff --git a/drivers/clk/qcom/gcc-sm8450.c b/drivers/clk/qcom/gcc-sm8450.c index b18bb34889ab..0d3ed24628fc 100644 --- a/drivers/clk/qcom/gcc-sm8450.c +++ b/drivers/clk/qcom/gcc-sm8450.c @@ -3392,7 +3392,32 @@ static const struct regmap_config gcc_sm8450_regmap_= config =3D { .fast_io =3D true, }; =20 +static const u32 gcc_sm8450_critical_cbcrs[] =3D { + 0x36004, /* GCC_CAMERA_AHB_CLK */ + 0x36020, /* GCC_CAMERA_XO_CLK */ + 0x37004, /* GCC_DISP_AHB_CLK */ + 0x3701c, /* GCC_DISP_XO_CLK */ + 0x81004, /* GCC_GPU_CFG_AHB_CLK */ + 0x42004, /* GCC_VIDEO_AHB_CLK */ + 0x42028, /* GCC_VIDEO_XO_CLK */ +}; + +static void gcc_sm8450_regs_configure(struct device *dev, struct regmap *r= egmap) +{ + /* FORCE_MEM_CORE_ON for ufs phy ice core clocks */ + regmap_update_bits(regmap, gcc_ufs_phy_ice_core_clk.halt_reg, BIT(14), BI= T(14)); +} + +static const struct qcom_cc_driver_data gcc_sm8450_driver_data =3D { + .clk_cbcrs =3D gcc_sm8450_critical_cbcrs, + .num_clk_cbcrs =3D ARRAY_SIZE(gcc_sm8450_critical_cbcrs), + .dfs_rcgs =3D gcc_dfs_clocks, + .num_dfs_rcgs =3D ARRAY_SIZE(gcc_dfs_clocks), + .clk_regs_configure =3D gcc_sm8450_regs_configure, +}; + static const struct qcom_cc_desc gcc_sm8450_desc =3D { + .driver_data =3D &gcc_sm8450_driver_data, .config =3D &gcc_sm8450_regmap_config, .clks =3D gcc_sm8450_clocks, .num_clks =3D ARRAY_SIZE(gcc_sm8450_clocks), @@ -3411,18 +3436,6 @@ MODULE_DEVICE_TABLE(of, gcc_sm8450_match_table); =20 static int gcc_sm8450_probe(struct platform_device *pdev) { - struct regmap *regmap; - int ret; - - regmap =3D qcom_cc_map(pdev, &gcc_sm8450_desc); - if (IS_ERR(regmap)) - return PTR_ERR(regmap); - - ret =3D qcom_cc_register_rcg_dfs(regmap, gcc_dfs_clocks, - ARRAY_SIZE(gcc_dfs_clocks)); - if (ret) - return ret; - if (of_device_is_compatible(pdev->dev.of_node, "qcom,sm8475-gcc")) { /* Update GCC PLL0 */ gcc_gpll0.regs =3D clk_alpha_pll_regs[CLK_ALPHA_PLL_TYPE_LUCID_OLE]; @@ -3456,19 +3469,7 @@ static int gcc_sm8450_probe(struct platform_device *= pdev) gcc_sm8450_desc.clks[SM8475_GCC_GPLL3] =3D &sm8475_gcc_gpll3.clkr; } =20 - /* FORCE_MEM_CORE_ON for ufs phy ice core clocks */ - regmap_update_bits(regmap, gcc_ufs_phy_ice_core_clk.halt_reg, BIT(14), BI= T(14)); - - /* Keep some clocks always-on */ - qcom_branch_set_clk_en(regmap, 0x36004); /* GCC_CAMERA_AHB_CLK */ - qcom_branch_set_clk_en(regmap, 0x36020); /* GCC_CAMERA_XO_CLK */ - qcom_branch_set_clk_en(regmap, 0x37004); /* GCC_DISP_AHB_CLK */ - qcom_branch_set_clk_en(regmap, 0x3701c); /* GCC_DISP_XO_CLK */ - qcom_branch_set_clk_en(regmap, 0x81004); /* GCC_GPU_CFG_AHB_CLK */ - qcom_branch_set_clk_en(regmap, 0x42004); /* GCC_VIDEO_AHB_CLK */ - qcom_branch_set_clk_en(regmap, 0x42028); /* GCC_VIDEO_XO_CLK */ - - return qcom_cc_really_probe(&pdev->dev, &gcc_sm8450_desc, regmap); + return qcom_cc_probe(pdev, &gcc_sm8450_desc); } =20 static struct platform_driver gcc_sm8450_driver =3D { --=20 2.54.0 From nobody Fri Sep 25 05:31:34 2026 Received: from mx0b-0031df01.pphosted.com (mx0b-0031df01.pphosted.com [205.220.180.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 835894F0535 for ; Wed, 16 Sep 2026 10:30:26 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.180.131 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1789554646; cv=none; b=EQOMIp+787/FNmyd7D01NELJp4/fht49oIBmloC9PRULduZFOz0/1Tp8oHI6knmM5aHr7CpJnuk8kR9V6TAIJxRn85q4sX15HoEmMcndqLW+0mXkJciWEhIilKU1PgEsEdJ1j3oXbff0L3TQevBC3fkaABwxx0PxTjXyg4jcujI= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1789554646; c=relaxed/simple; bh=2UaU7R3Klsyvl2wWmbPnmjteeasW2un+bpN/PVjJb6I=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=CSAYLhQSGaQGj80qjcNIj/Uan0Ab0YQApOIwDFBRrNuVGvFNQ7Uhr+1XTwEE2BUIctAIvYShpgZJC1SZ5yHKWZJfwgqdYG8EIjKAZn+LASmSh8UY2tL9saq2twFj/IbxClQfn/09aWq/0hY+u07o02rJKlrlaK6+zmTWvi3BJdE= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=DEd6gRct; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=YiKfnHt1; arc=none smtp.client-ip=205.220.180.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="DEd6gRct"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="YiKfnHt1" Received: from pps.filterd (m0279869.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 68G93AOe2658235 for ; Wed, 16 Sep 2026 10:30:23 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= Z1Sf97NFKUaUqW6VmDXtLv92KAWnBnsE42F8yV4CgO4=; b=DEd6gRctHCbTpgrU 9y22YIuK5oDurM/X90Nfm/M8p0c6LYabztYeFHWI7IrzZ5GiDR21ZVG3s9PXKHRr 6rMhO40mSvT//L/rH3GovP1lygqyLdRS5Bvbcl9tHvGAsqcF2ELqpT/OW8ufd1/s 2cCBKc8PJNllOx4rZAa+OvTtIUxYDcMhznUiDQaRN2nQj6YnyWxUn73ub+fO2FHh eIcZV//KYrRiFGZ8iGU9LYiaV9pau9I5zPbHXH7mkZ9kQEgkoJmoSysKHM1pNXUC QYoawUTX30J4nO+unrKqh444VwTuiEITV/4OO4FdCAdjfXpxNfCGAFu2A/CgQrjD g4slrw== Received: from mail-qk1-f198.google.com (mail-qk1-f198.google.com [209.85.222.198]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4gqftujas2-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Wed, 16 Sep 2026 10:30:22 +0000 (GMT) Received: by mail-qk1-f198.google.com with SMTP id af79cd13be357-936708f129aso835024185a.0 for ; Wed, 16 Sep 2026 03:30:22 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1789554622; x=1790159422; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :content-type:mime-version:subject:date:from:from:to:cc:subject:date :message-id:reply-to:content-type; bh=Z1Sf97NFKUaUqW6VmDXtLv92KAWnBnsE42F8yV4CgO4=; b=YiKfnHt17S2PJ8BcBbL8ZIFnQy+yQSY0CWKkNpsmK3+X9ydvcPe5QtGp9RcvI1ekRM hy9dqnwngCvotfKico1gbhaef6zeIE6udYOJ1IcDGp5lGpn49iU9kPNgY3NXdkJrx632 C2SyBUpuJvlMSCtxmm9r5yo1bO/DAPSH/ARz4w6QAOrK/MNg+lRBZx+uY0XWHFDMqzX8 xjsQPVhCdwAeTWySbSXnNChcJ0zISnYQcxgE4+ExKc9YUzjcmjUKaQLKbtaF58LaU+pK pTieApPENRXDD9NALuIyVIDedAk+BDJaM4Gjm0ehLStoh2cWCXWoUe0znNrVl8euGNkm awpw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20260707; t=1789554622; x=1790159422; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :content-type:mime-version:subject:date:from:x-gm-gg :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to :content-type; bh=Z1Sf97NFKUaUqW6VmDXtLv92KAWnBnsE42F8yV4CgO4=; b=Hi7i3OPK7iifOi4K1YWVZIJoRP/PZ+Eq7MBm+aiL3KKB+pvOjdb48njVRt5Ql2u5i4 o58z7XtGTxRtpcrYLuU04ocRKn3ew1MJkn6kX8mO3hmflIk9i9lmqxw/0sZ7JmgFG7M4 wNN2oKCbOUVUDvGPFxxxJUcyu5HLOCFSKVniIt/qFTnL+BP+ALdyYRbxTsN1kKsr3zQG cSysQKAOXPvoGYHO1U/lXJS68mShGdDJpAIu1uRbCkxT61kaTfE/DT2zWjtod6SV+x9C Up7bg0f8QIeDv7V/5LQG2Rfgb/65LmK7obBikcqUEdevsV3SfFQycpf6Nv71woxA3mD1 dvgA== X-Forwarded-Encrypted: i=1; AKwUvBzVIG9LbudRLFlAnfcMxybUs/mbbGstOU/xark576PlCGPJPUOE2S7LlH7yjJp+opOgPbIURG/Vr3Cl6rc=@vger.kernel.org X-Gm-Message-State: AFuF++nSOxiV8wtQkMxmFNVAS08Oy/8kK/DeTb9ipAWnJEbgQqYBEUkA kfXrGftOjxaBncNm+TgNHEY8au9zBaCkt8fWaeZk8IJEIhQqcir7hemETIFMPIlvUaH5QyR4sjb Edd7050OJFJZhmLVGFEpwEbLUyR45Yb9SFMzF5Miq63mV/tSG9ZGqCcBK90iBkD83f7Q= X-Gm-Gg: AYBFou1thi/L/Tw7nlb4BNgX9HNDmMJVCtxgb5k/S8iskBydr2t2hDw0HxyGgAAH0dX LCOxmsCL2QBPtNaPTWi0CPQ2GhfvxTYF3DwisM7HPQPuiVn6qsR26lE4yC7Ts8Q4LbRLjHdmlr7 j0kNFhA+OLKKpR4lKsaAScBlIzT+nLQnKtQecT4kimEhbMmQer3LG5s87ww0T5eBd2M4UgrZebJ Rr06+Mlq3jEL48aPvonkyrLO+VoV1zpB3WAxwI+bkDyo8ckONrRy2fxDxtCzf76eDFIWECLTVfz l8oE+jxIMJXDHmTTCkNdqaEoejGJi4kjNLxGM2KZqhWhZ6h4xB/B3lrtGF1JPeinJ/N0w1y4DC3 xciIKBs8= X-Received: by 2002:a05:620a:1726:b0:939:7f14:ebc6 with SMTP id af79cd13be357-93bb76bb193mr292577085a.3.1789554622015; Wed, 16 Sep 2026 03:30:22 -0700 (PDT) X-Received: by 2002:a05:620a:1726:b0:939:7f14:ebc6 with SMTP id af79cd13be357-93bb76bb193mr292569185a.3.1789554621405; Wed, 16 Sep 2026 03:30:21 -0700 (PDT) Received: from [127.0.1.1] ([86.121.170.232]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-49e83dbb0c1sm71633805e9.14.2026.09.16.03.30.19 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 16 Sep 2026 03:30:20 -0700 (PDT) From: Abel Vesa Date: Wed, 16 Sep 2026 13:28:48 +0300 Subject: [PATCH 32/48] clk: qcom: gcc-sm8550: Use common clock controller probe data Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20260916-clk-qcom-rework-legacy-always-on-clocks-v1-32-25a24e50f82a@oss.qualcomm.com> References: <20260916-clk-qcom-rework-legacy-always-on-clocks-v1-0-25a24e50f82a@oss.qualcomm.com> In-Reply-To: <20260916-clk-qcom-rework-legacy-always-on-clocks-v1-0-25a24e50f82a@oss.qualcomm.com> To: Bjorn Andersson , Abel Vesa , Stephen Boyd , Brian Masney , Jerome Brunet Cc: linux-arm-msm@vger.kernel.org, linux-clk@vger.kernel.org, linux-kernel@vger.kernel.org, Abel Vesa X-Mailer: b4 0.16-dev-0e65f X-Developer-Signature: v=1; a=openpgp-sha256; l=3400; i=abel.vesa@oss.qualcomm.com; h=from:subject:message-id; bh=2UaU7R3Klsyvl2wWmbPnmjteeasW2un+bpN/PVjJb6I=; b=owEBbQKS/ZANAwAKARtfRMkAlRVWAcsmYgBqqm9pRzt6zcSHKcFZCSTUWhXZf6Nk0cg6V8EDu 5lGQGsJvqmJAjMEAAEKAB0WIQRO8+4RTnqPKsqn0bgbX0TJAJUVVgUCaqpvaQAKCRAbX0TJAJUV VkeXD/9ehP+Lz5BOO2Njg9IIymYBBm/k+XyNrFwd3mxET/HLz4wVgYqyBzxZBZ3Y0PW6s7+Ht0g kTWVYbZ/ljJiihojDM8xZ+uv2xc7b/uyQ1Tf7XEKzzFtSqaGZKMQO6yoJ6We4PQUwuhrx6pGU4F vbnqeRuWCWLY7hy1AP60uvgGvcxsyHIDQjuDoRfUAivU9TOhjOfp4iMP8ZzcuHdo848aamSBinf /VHcyahw6woVIN6g1VqRLxYVNzikYx7/V4g7GYQHwuK3z5tKZtnF8IseE0GhTeCvzDVqCv9ZAwx le8gBpXRun9Juhc+u7sLk+3ODJDesqaKbMm/BQ8Fec0herBbh3r/xT/h1KWErgxu7Oc+CcFpp1i NDjIqmF2Is0M9c4zCdDIqSNwQtG/EOLSo1+Ckyx+V5gWcZxPDkZWRCjydyZlE1KnsLpIGDkDf49 jC9+XNwubYbcu9I/Ujj7ocksB7kjv2PS6Hwo4OdAQdk1CgAvIbTmm1b/A0S5GROOzLbvJLvfE/U jw7e5zZIkRJypdqoxyI0ozDifK4s3KBdtop7NrKW0qBjOH0sp4Y98gx+So9hqahRnOej5izOguH d4YwNljnLviU3da/p372P9dsriDT++cje4ZDzAvd2COqyz5feiJ99H1z+jeG2KR3/TZiPkzIPkh KIniaY1DOs5rUOQ== X-Developer-Key: i=abel.vesa@oss.qualcomm.com; a=openpgp; fpr=6AFF162D57F4223A8770EF5AF7BF214136F41FAE X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwOTE2MDEzNyBTYWx0ZWRfX0FzJujmXLWLW v3vxt03AKXBjQnPtnIRBnk/EJ1nE7EHJrxVAP5BEO6MFXXXUeRrEKCzbDFMjNg9t3tWmF9i3c84 q+Pqz2zZseJ0YgGHNe2Itqy1N6cKcuIBlhDyIAN0xVVzbfathgnCyliYQ7n4j7/QVcIVuYsv9MA oMJKqKccOJTemqFc3Jn9wV8UgjEAklQzjqJeRXAvuNCfa9LXuF0SXwijmXE1dyE0cf8f8h8OrNh v9thPwr3CQi5giBptPlD2k1uQrnpGSSsypJkVTGXTgWFWFt9fZc7mSMzpLdYOVEaQTjSo03gI5D eyvfJMmXV5ENUDNCfr5Mzd+TnUxJOyI/EB6JpsW27KZtNJKCS3JWWfWh83up5XtLN69tOW/zS7z SEvAZXvGQv/X8R32gmW2PbLJ4t/YE7jjaBKQ+ooIZ1bRtML38MRTcmKywAFbT/fQ7f7t9AtgwqU yZ2basAFEmaw58St0yg== X-Authority-Analysis: v=2.4 cv=a5ulZkSF c=1 sm=1 tr=0 ts=6aaa6fbe cx=c_pps a=qKBjSQ1v91RyAK45QCPf5w==:117 a=po8fGBi+ks8MzcVQGuqtFQ==:17 a=IkcTkHD0fZMA:10 a=VdqzKS8jKosA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=_glEPmIy2e8OvE2BGh3C:22 a=EUspDBNiAAAA:8 a=RW22A4phRzxp-fsVvwcA:9 a=QEXdDO2ut3YA:10 a=NFOGd7dJGGMPyQGDc5-O:22 X-Proofpoint-Spam-Info: AW1haW4tMjYwOTE2MDEzNyBTYWx0ZWRfX3kJtn2BENb1c Td4xMsQ7qJ5Vo8oW6eXEj0pV9NP/hT9xb8I0bXG+bE3PSZwRcsoj3iWkO290+p6GMrpusLipZN1 g4p3zLK2762I864vAyfaAU4CQpjhwUM= X-Proofpoint-GUID: WqJpxYHk7w_o9KBYl9f7xkzV4e7XyjTG X-Proofpoint-ORIG-GUID: WqJpxYHk7w_o9KBYl9f7xkzV4e7XyjTG X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1176,Hydra:6.1.134,FMLib:17.12.100.49 definitions=2026-09-15_05,2026-09-15_02,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 suspectscore=0 spamscore=0 clxscore=1015 priorityscore=1501 adultscore=0 impostorscore=0 malwarescore=0 lowpriorityscore=0 phishscore=0 bulkscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2609040000 definitions=main-2609160137 Move the always-on branch register offsets into a critical_cbcrs array, describe the DFS RCGs through qcom_cc_driver_data and move the register programming into the clk_regs_configure callback. Use qcom_cc_probe() to perform the common initialization instead of open-coding it in the driver's probe. Assisted-by: LLM Signed-off-by: Abel Vesa Reviewed-by: Konrad Dybcio --- drivers/clk/qcom/gcc-sm8550.c | 57 ++++++++++++++++++++++-----------------= ---- 1 file changed, 29 insertions(+), 28 deletions(-) diff --git a/drivers/clk/qcom/gcc-sm8550.c b/drivers/clk/qcom/gcc-sm8550.c index 36a5b7de5b55..8a8c541ccc10 100644 --- a/drivers/clk/qcom/gcc-sm8550.c +++ b/drivers/clk/qcom/gcc-sm8550.c @@ -3319,7 +3319,35 @@ static const struct regmap_config gcc_sm8550_regmap_= config =3D { .fast_io =3D true, }; =20 +static const u32 gcc_sm8550_critical_cbcrs[] =3D { + 0x26004, /* GCC_CAMERA_AHB_CLK */ + 0x26028, /* GCC_CAMERA_XO_CLK */ + 0x27004, /* GCC_DISP_AHB_CLK */ + 0x27018, /* GCC_DISP_XO_CLK */ + 0x71004, /* GCC_GPU_CFG_AHB_CLK */ + 0x32004, /* GCC_VIDEO_AHB_CLK */ + 0x32030, /* GCC_VIDEO_XO_CLK */ +}; + +static void gcc_sm8550_regs_configure(struct device *dev, struct regmap *r= egmap) +{ + /* FORCE_MEM_CORE_ON for ufs phy ice core clocks */ + regmap_update_bits(regmap, gcc_ufs_phy_ice_core_clk.halt_reg, BIT(14), BI= T(14)); + + /* Clear GDSC_SLEEP_ENA_VOTE to stop votes being auto-removed in sleep. */ + regmap_write(regmap, 0x52024, 0x0); +} + +static const struct qcom_cc_driver_data gcc_sm8550_driver_data =3D { + .clk_cbcrs =3D gcc_sm8550_critical_cbcrs, + .num_clk_cbcrs =3D ARRAY_SIZE(gcc_sm8550_critical_cbcrs), + .dfs_rcgs =3D gcc_dfs_clocks, + .num_dfs_rcgs =3D ARRAY_SIZE(gcc_dfs_clocks), + .clk_regs_configure =3D gcc_sm8550_regs_configure, +}; + static const struct qcom_cc_desc gcc_sm8550_desc =3D { + .driver_data =3D &gcc_sm8550_driver_data, .config =3D &gcc_sm8550_regmap_config, .clks =3D gcc_sm8550_clocks, .num_clks =3D ARRAY_SIZE(gcc_sm8550_clocks), @@ -3337,34 +3365,7 @@ MODULE_DEVICE_TABLE(of, gcc_sm8550_match_table); =20 static int gcc_sm8550_probe(struct platform_device *pdev) { - struct regmap *regmap; - int ret; - - regmap =3D qcom_cc_map(pdev, &gcc_sm8550_desc); - if (IS_ERR(regmap)) - return PTR_ERR(regmap); - - ret =3D qcom_cc_register_rcg_dfs(regmap, gcc_dfs_clocks, - ARRAY_SIZE(gcc_dfs_clocks)); - if (ret) - return ret; - - /* FORCE_MEM_CORE_ON for ufs phy ice core clocks */ - regmap_update_bits(regmap, gcc_ufs_phy_ice_core_clk.halt_reg, BIT(14), BI= T(14)); - - /* Keep some clocks always-on */ - qcom_branch_set_clk_en(regmap, 0x26004); /* GCC_CAMERA_AHB_CLK */ - qcom_branch_set_clk_en(regmap, 0x26028); /* GCC_CAMERA_XO_CLK */ - qcom_branch_set_clk_en(regmap, 0x27004); /* GCC_DISP_AHB_CLK */ - qcom_branch_set_clk_en(regmap, 0x27018); /* GCC_DISP_XO_CLK */ - qcom_branch_set_clk_en(regmap, 0x71004); /* GCC_GPU_CFG_AHB_CLK */ - qcom_branch_set_clk_en(regmap, 0x32004); /* GCC_VIDEO_AHB_CLK */ - qcom_branch_set_clk_en(regmap, 0x32030); /* GCC_VIDEO_XO_CLK */ - - /* Clear GDSC_SLEEP_ENA_VOTE to stop votes being auto-removed in sleep. */ - regmap_write(regmap, 0x52024, 0x0); - - return qcom_cc_really_probe(&pdev->dev, &gcc_sm8550_desc, regmap); + return qcom_cc_probe(pdev, &gcc_sm8550_desc); } =20 static struct platform_driver gcc_sm8550_driver =3D { --=20 2.54.0 From nobody Fri Sep 25 05:31:34 2026 Received: from mx0b-0031df01.pphosted.com (mx0b-0031df01.pphosted.com [205.220.180.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 6B6084D0A1C for ; Wed, 16 Sep 2026 10:30:30 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.180.131 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1789554655; cv=none; b=VvwsERS0ZuI7OE/aEV0+CGOuLRktdp38FKFwKaSa8wNXbvatZMmNnbnb5hlBObGEot0hNLabE5fGy8LyGp+YlvNr2B7l8mp6m0lsiE9VSwwFP9zJ45DCdHt5wPWggDsCzTpXZKVXsOfOnbb3ohLq+Ykp18EOUzCsnph9W6ZX1RA= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1789554655; c=relaxed/simple; bh=dOWcPm4PMu7C26gubY+szdZhIzmbdhBFQ2hjzKZc9HM=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=WcFLX5XTvZl4eyoPZgWeZRLvyBWfJfa8VvECu4kbPZzbgbp0ylrM88A1Gvi0as6MEZgVtvlZLmXOflO/dfI0OHevxNdKpCVUDaPg8uRQK3uvOKBrmIgArzc5AsohMTwc/PykGKMounFG6mPAxNrWzaQMBqeFb3yGAqP22CDNFRU= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=mf2F+YXC; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=EKgnSija; arc=none smtp.client-ip=205.220.180.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="mf2F+YXC"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="EKgnSija" Received: from pps.filterd (m0279873.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 68G934tB2226492 for ; Wed, 16 Sep 2026 10:30:25 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= zIifXueKGL64mhkXpHFF3L9lYKQ6XACTTZUiT4her98=; b=mf2F+YXCefj2IZti tMCfeS2NvMn1OGI8KVY2lEpZBlXAsyHjayvD9xgnjX8Gn88+qBwMLIsLeWgcYQnc FcRHsm0ZEMFQ/gc17Io6Iem7+1LhxNF+73+iXy6KH52+6+gDzCtvzrU2SEn4ReXx 9tazXtPqA8ldTYO65hGZGLzrQSgcDTXnePV6Aicm0rGgqkDEVRNV9VUeC7sqx1md K2aphoBBBwMFn/uXH5G2EwqZIOna3mzyECbtQ15lzTNDq580wP8Idw38dJhg18jP Hd6fNseUkfVdTd+G8a4EOEfhl3E5acc2D0iWy6pOMs8+D1VHhSCVGN3jMEHeVew6 OvnY4w== Received: from mail-qk1-f198.google.com (mail-qk1-f198.google.com [209.85.222.198]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4gqah9ut3q-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Wed, 16 Sep 2026 10:30:25 +0000 (GMT) Received: by mail-qk1-f198.google.com with SMTP id af79cd13be357-934963b2bc0so1117340385a.3 for ; Wed, 16 Sep 2026 03:30:25 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1789554624; x=1790159424; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :content-type:mime-version:subject:date:from:from:to:cc:subject:date :message-id:reply-to:content-type; bh=zIifXueKGL64mhkXpHFF3L9lYKQ6XACTTZUiT4her98=; b=EKgnSijaF6bR8PQWLlvE/wUXGjrjYdowUuF51yGoEjs938kfAa2Yhy+bzWRUS7+BbA iQmziLufvlql2ZWt9IkLMcyPKoqmYu+NlGUjb/I4CEPTX2bN+hrjiQoXzIbXJPNUTuZy PYIfDFAREK3nIkzBMMvHcH7aq3qp4zhboRfuO6P13CohU3lGY/keJM5Izc/Ua9jIqKyc nwXfztLASFSmwQ/shdirjSwhPGXq5DZ3zToMeDS1wU3I3ulrdZYnSAc4v3Y5WHUnWEEJ 5xzuyfqFajDF4jf0SBLzG6u/xBVEapljsB2yuhhvw1jJJV0MUBznUvc70wjlrCsWemDm aIwA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20260707; t=1789554624; x=1790159424; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :content-type:mime-version:subject:date:from:x-gm-gg :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to :content-type; bh=zIifXueKGL64mhkXpHFF3L9lYKQ6XACTTZUiT4her98=; b=vJGcqVF9oLoiVjDBimScx0LShaH8k2MWHq3M4pSuzYHyn24k5nvuInxfrdA0vm47IZ z1VTpWXWV/Lh7N+hNGpqJJWT90ZdW4Bu1yzHKaSjHKGpqll4y9ChnJpzTCd5VWi2zDWv BhAcreK/w7C5G9y+rtr4k18eYXFLakNxo/xcPffwbe7lQCiTNv+dkvlu/5kHKrpNGD06 p73BPbTANpVNLR7wmr0RSvj0mNuGyhQXWb80bLp6dUG3rkKLMqAkBIuBSANSBpqOmq6G Squn3PGTVL8UkWXkjfI18drSd/A+RRorOYkSvv014kGqRSXoYJN9vWW3IeZ2X8jCGPxm T6XA== X-Forwarded-Encrypted: i=1; AKwUvBzuODIgBOj9IdNGUoGXyHLZo0PhJNi4H6Bts+YFuJxCe8WALUHo2yQzFDuMdyfQ4uWDCbVsrye9BmAhC4Q=@vger.kernel.org X-Gm-Message-State: AFuF++mislX0n6/hb0tqSA1FKYkJF9vC7zBBa3m2LmsgGqmxz+kiUCCr 5jZVHkgYL3oaAGek6DD9qZA8qBn7wDNvHwcrw1mXJ73urf7Ds6Qf/JpTdQQsIIhOEj8aELFJIWP IiFyQP7s8nDUecDXcUYL737fqOZKYC88zHxgnp+5HebM1Tml12f1gBMVyUMAbf8MDWaU= X-Gm-Gg: AYBFou3W9vueOJXb874UocLlqW7ULNy2NPlEgCCXivB6ojLWO5tDsYKZXWHHJ8SO+jf YHFpNqKj3HDQ0DOpBjAQd6o4KUk4pamsPEdpmmh7KSDLBhKLwpx9XXCTp/K9QwRGBwvg1hkmMz/ NMiokbRuigbH3V2crZg9HoNxZXNYM36nfgaFfcXLDFM1c8ESP/9yzJamptVrOp3SBSytdBbRrMI FFDxi09t2D81s3Ce8Ixm6/V1eAt5bB9O/wb7D/xHCusJkUJGaNdahTovECkr+vpLFqgNTw2HpMc ucjey918M8EcD0daqal87D7KYSM1yA8oQoSs8TLuh/A2ABp6rifgj+cUbETQq8VgUsYFnDP43vu tGZRNEL4= X-Received: by 2002:a05:620a:3726:b0:939:6d2a:6e38 with SMTP id af79cd13be357-93bb789cf2cmr317102985a.33.1789554624306; Wed, 16 Sep 2026 03:30:24 -0700 (PDT) X-Received: by 2002:a05:620a:3726:b0:939:6d2a:6e38 with SMTP id af79cd13be357-93bb789cf2cmr317095185a.33.1789554623755; Wed, 16 Sep 2026 03:30:23 -0700 (PDT) Received: from [127.0.1.1] ([86.121.170.232]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-49e83dbb0c1sm71633805e9.14.2026.09.16.03.30.21 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 16 Sep 2026 03:30:22 -0700 (PDT) From: Abel Vesa Date: Wed, 16 Sep 2026 13:28:49 +0300 Subject: [PATCH 33/48] clk: qcom: gcc-sm8650: Use common clock controller probe data Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20260916-clk-qcom-rework-legacy-always-on-clocks-v1-33-25a24e50f82a@oss.qualcomm.com> References: <20260916-clk-qcom-rework-legacy-always-on-clocks-v1-0-25a24e50f82a@oss.qualcomm.com> In-Reply-To: <20260916-clk-qcom-rework-legacy-always-on-clocks-v1-0-25a24e50f82a@oss.qualcomm.com> To: Bjorn Andersson , Abel Vesa , Stephen Boyd , Brian Masney , Jerome Brunet Cc: linux-arm-msm@vger.kernel.org, linux-clk@vger.kernel.org, linux-kernel@vger.kernel.org, Abel Vesa X-Mailer: b4 0.16-dev-0e65f X-Developer-Signature: v=1; a=openpgp-sha256; l=3563; i=abel.vesa@oss.qualcomm.com; h=from:subject:message-id; bh=dOWcPm4PMu7C26gubY+szdZhIzmbdhBFQ2hjzKZc9HM=; b=owEBbQKS/ZANAwAKARtfRMkAlRVWAcsmYgBqqm9q/YvA/KNqUjhxVtrP76Ct6z5wHw4avj/Zu EH7oKxgW+2JAjMEAAEKAB0WIQRO8+4RTnqPKsqn0bgbX0TJAJUVVgUCaqpvagAKCRAbX0TJAJUV ViwBD/9eMxOPyBo6cKX2DupZuINkkHUElVULOP3PT24lBJrXBxZ7cBGZvX0pygZTw+CpWzNXTh/ 5OeXPiWOjpXeiEWHilTE+iBOvORY+QaIxgJNlkCZ+zqUWdNoLngNGJPl2s5J4H94ysJ34sfDaCg PA9cpUv/LQjOzJJgjnuL5Mmdh9P1iREfVM+z5cnOkQcLoSliOSC/ZJg9mnK4QtVRaWN6eQMBfje phgU96utaPhqIPA04KJ+6ULw98W9Ks21mtg4BjvewvhjLEK4ha3qaHw27Dc1SttdtPMUCpsVe37 tm5vPri6dVqI8wgfSU8eA/DpwWYCZah50eUPIH6di+kEj4QmrA/iLatAbOzO9jYFoVJrcSEMj80 RFKEZgoXLCs0ihTSoSxpDaQyKjGFWLCSQ87/V0jR2WjQXc4Obf6vYAujrxCOBg462TR6nXZ09d4 mWyk5AYe+gRB/WxxdZgVQqrQbn/FnAYYXOwEMnbyARZsRKBls/EfSKdRaKPowobpDYt1TDFVhL4 MhKmPxaNyKMblI0QAW/l2ibWIh6uj10mpO7ZGFx3djZbmbcixguKiDp6E6ccYokoD/tCSa+72WL 14K+j+ufndXMzvMlc9ccv6eSsAfhfGVnU6W4dOr+STHrnOrPwHqiTxfFq90A/eJimP49/19xPwX wTt0aDtb8eslb+w== X-Developer-Key: i=abel.vesa@oss.qualcomm.com; a=openpgp; fpr=6AFF162D57F4223A8770EF5AF7BF214136F41FAE X-Authority-Analysis: v=2.4 cv=BtkIUoX5 c=1 sm=1 tr=0 ts=6aaa6fc1 cx=c_pps a=qKBjSQ1v91RyAK45QCPf5w==:117 a=po8fGBi+ks8MzcVQGuqtFQ==:17 a=IkcTkHD0fZMA:10 a=VdqzKS8jKosA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=rJkE3RaqiGZ5pbrm-msn:22 a=EUspDBNiAAAA:8 a=zVTGKPmrq-ksKY0k6ekA:9 a=QEXdDO2ut3YA:10 a=NFOGd7dJGGMPyQGDc5-O:22 X-Proofpoint-ORIG-GUID: TCldjZU2XITYkDINbGQwvFcUTRJTvgmk X-Proofpoint-GUID: TCldjZU2XITYkDINbGQwvFcUTRJTvgmk X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwOTE2MDEzNyBTYWx0ZWRfX6pFoudnQlsh+ oKSzDkGYxzpGAZah1+btJkyvg6q3ohQsfAR9ApAo3JSoZjgquIwLQMA9gsryoMx+OXjymyz1Rxs vIXdhKqCp0w6zGHOkrI0EtQoHN4szsH5oftLbV9yDrz8/KDekp+szSXdPbd4Z9vfVZdk/N3C2J6 KnB9bY5G2bpdtDsgbBAygw4oKKu5uj45Wo/9NJnrBazfCpAcHDDfaVXv8+ImqsvjGT3i09/FJ/W ET9AdMCORR0tmYCYRwCqBIBUnSBkzpZv4k9CNH8t1Y4FE6me1j3iCqmyBZQ85DtDFmIV/QQCt+v +II46mor9eugM7rZWYL6y4tifw9D9e5Rn1nz0ahaZrRAmCeJOXVYn8DE3auwmDO9qoV5pm54SVt VTZ46ECdQ/FoEXuWouZA8McIAa2PSOin84tQtmI9OcF8I+YcUjk78AFhs087FPFZuQJ3LcI0/tK Y9FPCTsSeaNSOJtnK+Q== X-Proofpoint-Spam-Info: AW1haW4tMjYwOTE2MDEzNyBTYWx0ZWRfX88JaGsKZc5gn a8p1ipAJuq2uaI/2oZk5Vh0DoED2D297K3ZWboyh1Vh+YDzYhy24HZCRRfJxNrgNaY+ctbb0C/1 hsZDkrCK3gUfuGfyuQ4mCLyN/SvP5Pg= X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1176,Hydra:6.1.134,FMLib:17.12.100.49 definitions=2026-09-15_05,2026-09-15_02,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 priorityscore=1501 lowpriorityscore=0 spamscore=0 adultscore=0 malwarescore=0 impostorscore=0 bulkscore=0 clxscore=1015 phishscore=0 suspectscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2609040000 definitions=main-2609160137 Move the always-on branch register offsets into a critical_cbcrs array, describe the DFS RCGs through qcom_cc_driver_data and move the register programming into the clk_regs_configure callback. Use qcom_cc_probe() to perform the common initialization instead of open-coding it in the driver's probe. Assisted-by: LLM Signed-off-by: Abel Vesa Reviewed-by: Konrad Dybcio --- drivers/clk/qcom/gcc-sm8650.c | 59 ++++++++++++++++++++++-----------------= ---- 1 file changed, 30 insertions(+), 29 deletions(-) diff --git a/drivers/clk/qcom/gcc-sm8650.c b/drivers/clk/qcom/gcc-sm8650.c index f7e2d7ec60c9..b9f9657e9d4a 100644 --- a/drivers/clk/qcom/gcc-sm8650.c +++ b/drivers/clk/qcom/gcc-sm8650.c @@ -3777,7 +3777,36 @@ static const struct regmap_config gcc_sm8650_regmap_= config =3D { .fast_io =3D true, }; =20 +static const u32 gcc_sm8650_critical_cbcrs[] =3D { + 0x26004, /* GCC_CAMERA_AHB_CLK */ + 0x26028, /* GCC_CAMERA_XO_CLK */ + 0x27004, /* GCC_DISP_AHB_CLK */ + 0x27018, /* GCC_DISP_XO_CLK */ + 0x71004, /* GCC_GPU_CFG_AHB_CLK */ + 0x32004, /* GCC_VIDEO_AHB_CLK */ + 0x32030, /* GCC_VIDEO_XO_CLK */ +}; + +static void gcc_sm8650_regs_configure(struct device *dev, struct regmap *r= egmap) +{ + /* FORCE_MEM_CORE_ON for ufs phy ice core and gcc ufs phy axi clocks */ + qcom_branch_set_force_mem_core(regmap, gcc_ufs_phy_ice_core_clk, true); + qcom_branch_set_force_mem_core(regmap, gcc_ufs_phy_axi_clk, true); + + /* Clear GDSC_SLEEP_ENA_VOTE to stop votes being auto-removed in sleep. */ + regmap_write(regmap, 0x52150, 0x0); +} + +static const struct qcom_cc_driver_data gcc_sm8650_driver_data =3D { + .clk_cbcrs =3D gcc_sm8650_critical_cbcrs, + .num_clk_cbcrs =3D ARRAY_SIZE(gcc_sm8650_critical_cbcrs), + .dfs_rcgs =3D gcc_dfs_clocks, + .num_dfs_rcgs =3D ARRAY_SIZE(gcc_dfs_clocks), + .clk_regs_configure =3D gcc_sm8650_regs_configure, +}; + static const struct qcom_cc_desc gcc_sm8650_desc =3D { + .driver_data =3D &gcc_sm8650_driver_data, .config =3D &gcc_sm8650_regmap_config, .clks =3D gcc_sm8650_clocks, .num_clks =3D ARRAY_SIZE(gcc_sm8650_clocks), @@ -3795,35 +3824,7 @@ MODULE_DEVICE_TABLE(of, gcc_sm8650_match_table); =20 static int gcc_sm8650_probe(struct platform_device *pdev) { - struct regmap *regmap; - int ret; - - regmap =3D qcom_cc_map(pdev, &gcc_sm8650_desc); - if (IS_ERR(regmap)) - return PTR_ERR(regmap); - - ret =3D qcom_cc_register_rcg_dfs(regmap, gcc_dfs_clocks, - ARRAY_SIZE(gcc_dfs_clocks)); - if (ret) - return ret; - - /* Keep some clocks always-on */ - qcom_branch_set_clk_en(regmap, 0x26004); /* GCC_CAMERA_AHB_CLK */ - qcom_branch_set_clk_en(regmap, 0x26028); /* GCC_CAMERA_XO_CLK */ - qcom_branch_set_clk_en(regmap, 0x27004); /* GCC_DISP_AHB_CLK */ - qcom_branch_set_clk_en(regmap, 0x27018); /* GCC_DISP_XO_CLK */ - qcom_branch_set_clk_en(regmap, 0x71004); /* GCC_GPU_CFG_AHB_CLK */ - qcom_branch_set_clk_en(regmap, 0x32004); /* GCC_VIDEO_AHB_CLK */ - qcom_branch_set_clk_en(regmap, 0x32030); /* GCC_VIDEO_XO_CLK */ - - /* FORCE_MEM_CORE_ON for ufs phy ice core and gcc ufs phy axi clocks */ - qcom_branch_set_force_mem_core(regmap, gcc_ufs_phy_ice_core_clk, true); - qcom_branch_set_force_mem_core(regmap, gcc_ufs_phy_axi_clk, true); - - /* Clear GDSC_SLEEP_ENA_VOTE to stop votes being auto-removed in sleep. */ - regmap_write(regmap, 0x52150, 0x0); - - return qcom_cc_really_probe(&pdev->dev, &gcc_sm8650_desc, regmap); + return qcom_cc_probe(pdev, &gcc_sm8650_desc); } =20 static struct platform_driver gcc_sm8650_driver =3D { --=20 2.54.0 From nobody Fri Sep 25 05:31:34 2026 Received: from mx0b-0031df01.pphosted.com (mx0b-0031df01.pphosted.com [205.220.180.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 997E94F6493 for ; Wed, 16 Sep 2026 10:30:30 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.180.131 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1789554655; cv=none; b=RxLsZvS0pZqLx0Sd74KYJi5iJqMF8XZOrDNxX4skygw1aBSAvnc/h2mJdSGC8bUh5wkuTEffZakX4BAnOLnCx2PJlsiQjXmJxwFcVCu5dkts1Cr0mhxoljWoe8YLrRLXgWbx4nD+FjGhLFrBODQn2eVbZLHR67Y4x6fe1mipAcI= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1789554655; c=relaxed/simple; bh=UuHusSAWdgM6WkJmOEybYXRkNsToWIC4FGkiG1wyVbs=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=oagzOTmOQPRsISebjisZX7jNRDyEUmdMYQg9zRMm1o7cNcCS+UOo6ITuPIzXWXHQxgQ5IUYnOBKyNAlQdt4asYnheuJcZKDCxeYa4QbRRYVsFIVxoLt2gm9OiAnkzUZmecUbcN1MFOFiI5WTQtVhp3w6D6ExYhmZwGnLjD8B10M= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=DFiBKRjb; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=WPTh8BYB; arc=none smtp.client-ip=205.220.180.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="DFiBKRjb"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="WPTh8BYB" Received: from pps.filterd (m0279868.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 68G92okI2122499 for ; Wed, 16 Sep 2026 10:30:28 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= pfJk6jGdIjBTLREvvzoYUDH1lXmRiQ/Skb3AdwLGEZo=; b=DFiBKRjbK8O+a4Tx 9FONAbCY2OHCy0EUHUWRoBM0BUJDj04uJAVMdbXp+7u9VPJmXXbcg/B9KRhw+qBN pFhqOBygssjd+iD+jgO1qoNf2elA+cukKDXIl7wpgYP5screEMHJ5DWCnfhsdCQ/ R4KBownxbyLaGISlUAmFbvGo8khpYv62uHwrRuzBj6BQmnoCvnb4HUejXrGKDSU7 iYErRLBMVCnPZBGUz6UNKQRm8CnXyxXV940ts7tbaVOXXZN/YdJYhTgCpAquLEhw bPMhjPv6jpkotl8lwcoewPCp4QlqsnZ5KarJkITqbAKSI7NNbugAn8AimB84Du94 Oe2DhA== Received: from mail-qk1-f199.google.com (mail-qk1-f199.google.com [209.85.222.199]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4gqkv7hhu0-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Wed, 16 Sep 2026 10:30:27 +0000 (GMT) Received: by mail-qk1-f199.google.com with SMTP id af79cd13be357-939a6937513so845727285a.3 for ; Wed, 16 Sep 2026 03:30:27 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1789554627; x=1790159427; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :content-type:mime-version:subject:date:from:from:to:cc:subject:date :message-id:reply-to:content-type; bh=pfJk6jGdIjBTLREvvzoYUDH1lXmRiQ/Skb3AdwLGEZo=; b=WPTh8BYBEs1bxrxHhahfsxJPuJ8LAv3dqFCHTX+4bmLPIUDfh2CvEcXaz4ZcTJPOml 7ZqIAfDQcXK4UV/M6oJ+asemQFZk9py7OmBurS8EDujw6l7Ob3ie05x0b89qtWG2pHro Qx2XtDG+CSccEWU39RKlU/JOuYuUxcagIR7HKryGWIkr13b6cb37XIlpP5EaWuKPQBV4 C3dzD+5BXyuZX51GMg6HLRYN8OlCkDRsKHPGvBjpPA+rxFFASUflmWV+vs6AV59N6uu0 H8Jgz54nEGQFnV7pwopdnoG4YQTGYg99HY9qvuDbjx6znp13mkvJdWdVG/yRbtRq+FPv Mzzw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20260707; t=1789554627; x=1790159427; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :content-type:mime-version:subject:date:from:x-gm-gg :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to :content-type; bh=pfJk6jGdIjBTLREvvzoYUDH1lXmRiQ/Skb3AdwLGEZo=; b=z3BaR330dCWsswX8a2rAa7+fa/BqLW4aDp6nJyk3sHuvGcCvPs3b1s+RA6YFr2PGN8 6zXUFYEuf7ae24cZtEVg5D6Qv6QdoMbkoSvqi2LDPP2pnxUsq+qZHpYXa+QwcbZd4XwI l0NrJz0YfLCJGafprlNasShml5Bi4FEj6uCegE/5SlAiV96oLo4rA/NehctM5tTchWG5 OEXY+WoERT0tbn5EUQq+eFjL8Yyz7Yspr4TlRii3A9mRonk7EGUv5WBKAzilVlHQ8zFx f61o0hPv7sSaWYwa+Ewy0E9OH3U1Yc/0ApWBYbyF+hxtqKFC9htFqcZd95PlgBe1P/Qg r0Bg== X-Forwarded-Encrypted: i=1; AKwUvByre3QiLPjR1+wr4iUvYf10yc95+q5GCN/aC5/a3sLqEPxRn/S1QuIQCh8fZ7Nsc8yU1WIZh7TUT6sx3Ow=@vger.kernel.org X-Gm-Message-State: AFuF++mh9vgMJXSwpqsqrhlsucX08m4Ajpzbb4xH4B8mxgpDBUPvZjzi R3VNfJLwl4YU2T0IRxAZilxmj+YLgBkU64TSntYPZ28JEBKI/yoyZiSPKSoOEjMiubrUkE4wW0K bqu6p3sKSEJ1/EzZOb/fLkaH3w98IzcZPDc15E244ADFqMJERt0oLSiJYMopAuhb0wAE= X-Gm-Gg: AYBFou3bsp2rbhYn23OqfEGT6MEvnROIuiQQz4mme68VTdCz0Ihr7wH7x5Ewm9MUDY6 MxTIt/cQnmxAJnlrPGc8CTaHoeHoO2dd6DRAeAQ03wuIdK85ENSz2QeDXAx7/v43CEJVLc/fEat I/ikJ3X+qCi8qvl83u1WuJhLAGKXzqVtegkaKgNa0cUW+Pr//G8TlspAiduH29vgopyVpU/Ol8/ DFOAzBSPUhJWWdByYkDEsBKlk9jbMFrRavzaP1hoYCobaRNyNhv2EyJQqBKPPVP1t48kj5yI7ra cN7skvgRR9YrgPsaczaxuOpaTO9PGatzwMdVFBXZi5RyDManwD3C0ZkuPvMLvmdWMcWrUmFf9L4 xCmn1GQA= X-Received: by 2002:a05:620a:4889:b0:939:a199:45b4 with SMTP id af79cd13be357-93bb78f1df5mr294728585a.39.1789554626743; Wed, 16 Sep 2026 03:30:26 -0700 (PDT) X-Received: by 2002:a05:620a:4889:b0:939:a199:45b4 with SMTP id af79cd13be357-93bb78f1df5mr294718285a.39.1789554626001; Wed, 16 Sep 2026 03:30:26 -0700 (PDT) Received: from [127.0.1.1] ([86.121.170.232]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-49e83dbb0c1sm71633805e9.14.2026.09.16.03.30.23 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 16 Sep 2026 03:30:24 -0700 (PDT) From: Abel Vesa Date: Wed, 16 Sep 2026 13:28:50 +0300 Subject: [PATCH 34/48] clk: qcom: gcc-sm8750: Use common clock controller probe data Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20260916-clk-qcom-rework-legacy-always-on-clocks-v1-34-25a24e50f82a@oss.qualcomm.com> References: <20260916-clk-qcom-rework-legacy-always-on-clocks-v1-0-25a24e50f82a@oss.qualcomm.com> In-Reply-To: <20260916-clk-qcom-rework-legacy-always-on-clocks-v1-0-25a24e50f82a@oss.qualcomm.com> To: Bjorn Andersson , Abel Vesa , Stephen Boyd , Brian Masney , Jerome Brunet Cc: linux-arm-msm@vger.kernel.org, linux-clk@vger.kernel.org, linux-kernel@vger.kernel.org, Abel Vesa X-Mailer: b4 0.16-dev-0e65f X-Developer-Signature: v=1; a=openpgp-sha256; l=3920; i=abel.vesa@oss.qualcomm.com; h=from:subject:message-id; bh=UuHusSAWdgM6WkJmOEybYXRkNsToWIC4FGkiG1wyVbs=; b=owEBbQKS/ZANAwAKARtfRMkAlRVWAcsmYgBqqm9sK3hfkdcbjz2HW87sbXaJ24B7GuspbFAaF u1WIolVPc2JAjMEAAEKAB0WIQRO8+4RTnqPKsqn0bgbX0TJAJUVVgUCaqpvbAAKCRAbX0TJAJUV VqckD/0cRCuD8D3cv57PEVeFoqb8QKcXRUktU0Ihs0/u0CjOw/Z144+U4VtOnMHGOWV+ZrjTP/k exHTyKMAFWR3XO30mtgwwbduVQqDXDBShcRGH+89bSKIxfA9NsB0231NPY5dIVYMoAo0aHoRIf/ hmBckCMV7O3eb8Qo+1W8WjwaYotV30Va6CIc9DmHQSzUZ3Fyo7KYuMTYkSMGxItv0ZGvyr2y0TV Yqp2B6TIYnTCkdu0zAK2oLslJF7aU5035rhkWeBTNIViMonglAG3OJUjvNeQoq8maG4raMBLOBC HZ0/nSIMrkg6EH5A2Ck9jFyO5STLt23Db3kDHLJmPixsNdFifo3ApfsYsO1GKB9j0tF8SSeiRQF CR3N7T6J5GVQy+78MO5F2g61cuv/grhUQ9WChanyVR5kBqPZuc7MvOaK0a12NKqBkrVUlMjNJHI 2JqOghST4F53RqTEIVII+vrc7PIYS4ZoAE/VOUOlrCncJaGMqwpDthqD52qvMIdRpGtz0kNW6b6 KYzaTyDFDACkOLTAw0yHBq2BbiorF91ioACdAFtU4FmjbnxYKYtRVmFwtLGyfaG+XbH5STkRDmx kohZeKKN+BSk6EEiRBkBXeg1mgXICAJQr3t0mzPFA/fDdJ1pBIE3frDtg2kf9hBDZBgR7np+rR6 H8ykjTq3XRn6jww== X-Developer-Key: i=abel.vesa@oss.qualcomm.com; a=openpgp; fpr=6AFF162D57F4223A8770EF5AF7BF214136F41FAE X-Proofpoint-ORIG-GUID: nqL1m_b20LgfwtX9eYwxEpWW9bXeSHvL X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwOTE2MDEzNyBTYWx0ZWRfXw40QNik7F+K4 R4yZjwkUrL8rOrIhwFaGZr0YMsEyU8/QI5ktAcPfv6JXBMwPHUkBe1vPxV2WaLNzGWcG3UHOJln t2DX/nU/K2Ea1m0DUEhHBzYlsipTVqLLuLZtWCZXFPi4VxWSVTtfcV1EJrSN2XrQdDEpmemZyNq Dooitl56MAtYAPHq2+7fj44MvAlh4GXqQBkavYjfMGzekE+x8/3OHDpgIzrISyV2lD/6l/mykFb mg3AqKSd76Kfg2P8M7KUQlkC9Fa0OOcd0SxiGikNI8aOrTCRSb+gDbOEmVRq0jimDJZ7W6Cc3aa hKMa8lTeR3H03dE1G8y3YnK+njG35sMXTsTasEhAG0k51QM3+Fru1kW3q4xr0hEPB/SSp6S4qku 3yV1rFWTpQJ/Rg6tpB+t6ih1cJd4XQhkCCLnbZyPr8+EnMSl7AihZTcotY4+FfB8hjnXcHsYUXE bNJ8dZf1iklEq3bk31w== X-Authority-Analysis: v=2.4 cv=eKmGH3p1 c=1 sm=1 tr=0 ts=6aaa6fc3 cx=c_pps a=HLyN3IcIa5EE8TELMZ618Q==:117 a=po8fGBi+ks8MzcVQGuqtFQ==:17 a=IkcTkHD0fZMA:10 a=VdqzKS8jKosA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=ZpdpYltYx_vBUK5n70dp:22 a=EUspDBNiAAAA:8 a=xSywTFWZ64xYcUwTHGYA:9 a=QEXdDO2ut3YA:10 a=bTQJ7kPSJx9SKPbeHEYW:22 X-Proofpoint-Spam-Info: AW1haW4tMjYwOTE2MDEzNyBTYWx0ZWRfX1ipNCWNT/Css CUVZHcMiqkgS5WaZJMWhcizxOCPPTptByD5kR5MHRIkOymPU7J/c1eAsMMAfDNKP+zxQoRRY7ta bLYPNq3b5QogsVhI5Y7C8vx2tEahwTY= X-Proofpoint-GUID: nqL1m_b20LgfwtX9eYwxEpWW9bXeSHvL X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1176,Hydra:6.1.134,FMLib:17.12.100.49 definitions=2026-09-15_05,2026-09-15_02,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 impostorscore=0 lowpriorityscore=0 adultscore=0 bulkscore=0 clxscore=1015 phishscore=0 spamscore=0 priorityscore=1501 malwarescore=0 suspectscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2609040000 definitions=main-2609160137 Move the always-on branch register offsets into a critical_cbcrs array, describe the DFS RCGs through qcom_cc_driver_data and move the register programming into the clk_regs_configure callback. Use qcom_cc_probe() to perform the common initialization instead of open-coding it in the driver's probe. Assisted-by: LLM Signed-off-by: Abel Vesa Reviewed-by: Konrad Dybcio --- drivers/clk/qcom/gcc-sm8750.c | 76 +++++++++++++++++++--------------------= ---- 1 file changed, 33 insertions(+), 43 deletions(-) diff --git a/drivers/clk/qcom/gcc-sm8750.c b/drivers/clk/qcom/gcc-sm8750.c index 6cfe90122268..2adda0c8b95c 100644 --- a/drivers/clk/qcom/gcc-sm8750.c +++ b/drivers/clk/qcom/gcc-sm8750.c @@ -3188,7 +3188,39 @@ static const struct regmap_config gcc_sm8750_regmap_= config =3D { .fast_io =3D true, }; =20 +static const u32 gcc_sm8750_critical_cbcrs[] =3D { + 0xa0004, /* GCC_CAM_BIST_MCLK_AHB_CLK */ + 0x26004, /* GCC_CAMERA_AHB_CLK */ + 0x26034, /* GCC_CAMERA_XO_CLK */ + 0x27004, /* GCC_DISP_AHB_CLK */ + 0x9f004, /* GCC_EVA_AHB_CLK */ + 0x9f01c, /* GCC_EVA_XO_CLK */ + 0x71004, /* GCC_GPU_CFG_AHB_CLK */ + 0x32004, /* GCC_VIDEO_AHB_CLK */ + 0x32038, /* GCC_VIDEO_XO_CLK */ +}; + +static void gcc_sm8750_regs_configure(struct device *dev, struct regmap *r= egmap) +{ + /* Keep GCC_PCIE_RSCC_CFG_AHB_CLK and GCC_PCIE_RSCC_XO_CLK enabled. */ + regmap_update_bits(regmap, 0x52010, BIT(20), BIT(20)); + regmap_update_bits(regmap, 0x52010, BIT(21), BIT(21)); + + /* FORCE_MEM_CORE_ON for ufs phy ice core and gcc ufs phy axi clocks */ + qcom_branch_set_force_mem_core(regmap, gcc_ufs_phy_ice_core_clk, true); + qcom_branch_set_force_mem_core(regmap, gcc_ufs_phy_axi_clk, true); +} + +static const struct qcom_cc_driver_data gcc_sm8750_driver_data =3D { + .clk_cbcrs =3D gcc_sm8750_critical_cbcrs, + .num_clk_cbcrs =3D ARRAY_SIZE(gcc_sm8750_critical_cbcrs), + .dfs_rcgs =3D gcc_dfs_clocks, + .num_dfs_rcgs =3D ARRAY_SIZE(gcc_dfs_clocks), + .clk_regs_configure =3D gcc_sm8750_regs_configure, +}; + static const struct qcom_cc_desc gcc_sm8750_desc =3D { + .driver_data =3D &gcc_sm8750_driver_data, .config =3D &gcc_sm8750_regmap_config, .clks =3D gcc_sm8750_clocks, .num_clks =3D ARRAY_SIZE(gcc_sm8750_clocks), @@ -3206,49 +3238,7 @@ MODULE_DEVICE_TABLE(of, gcc_sm8750_match_table); =20 static int gcc_sm8750_probe(struct platform_device *pdev) { - struct regmap *regmap; - int ret; - - regmap =3D qcom_cc_map(pdev, &gcc_sm8750_desc); - if (IS_ERR(regmap)) - return PTR_ERR(regmap); - - ret =3D qcom_cc_register_rcg_dfs(regmap, gcc_dfs_clocks, - ARRAY_SIZE(gcc_dfs_clocks)); - if (ret) - return ret; - - /* - * Keep clocks always enabled: - * gcc_cam_bist_mclk_ahb_clk - * gcc_camera_ahb_clk - * gcc_camera_xo_clk - * gcc_disp_ahb_clk - * gcc_eva_ahb_clk - * gcc_eva_xo_clk - * gcc_gpu_cfg_ahb_clk - * gcc_video_ahb_clk - * gcc_video_xo_clk - * gcc_pcie_rscc_cfg_ahb_clk - * gcc_pcie_rscc_xo_clk - */ - qcom_branch_set_clk_en(regmap, 0xa0004); - qcom_branch_set_clk_en(regmap, 0x26004); - qcom_branch_set_clk_en(regmap, 0x26034); - qcom_branch_set_clk_en(regmap, 0x27004); - qcom_branch_set_clk_en(regmap, 0x9f004); - qcom_branch_set_clk_en(regmap, 0x9f01c); - qcom_branch_set_clk_en(regmap, 0x71004); - qcom_branch_set_clk_en(regmap, 0x32004); - qcom_branch_set_clk_en(regmap, 0x32038); - regmap_update_bits(regmap, 0x52010, BIT(20), BIT(20)); - regmap_update_bits(regmap, 0x52010, BIT(21), BIT(21)); - - /* FORCE_MEM_CORE_ON for ufs phy ice core and gcc ufs phy axi clocks */ - qcom_branch_set_force_mem_core(regmap, gcc_ufs_phy_ice_core_clk, true); - qcom_branch_set_force_mem_core(regmap, gcc_ufs_phy_axi_clk, true); - - return qcom_cc_really_probe(&pdev->dev, &gcc_sm8750_desc, regmap); + return qcom_cc_probe(pdev, &gcc_sm8750_desc); } =20 static struct platform_driver gcc_sm8750_driver =3D { --=20 2.54.0 From nobody Fri Sep 25 05:31:34 2026 Received: from mx0b-0031df01.pphosted.com (mx0b-0031df01.pphosted.com [205.220.180.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 328444EA370 for ; Wed, 16 Sep 2026 10:30:36 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.180.131 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1789554656; cv=none; b=KsqzUy74CoTzyadOgYn1HQEwvdSnuC6B4b5mJo06eljpdK7pXg791JhyiN+jdVkQ+Nq7x4jJCar1xS+Qw91eiVIe3BxRGaV86fJOyUGHv80HWRsLGK/p5/CHoIov9bntAlW9b15Yb4cmtOxx/oaEO4uWLz86N0ru6Ct4XGdmdgs= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1789554656; c=relaxed/simple; bh=fR+QNqt66RcwAL1KPanC4gMbaMKXHhKCMmJQy6o4IiQ=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=RumejaTaQUxDIQjpLkTccxBL1cBZLaeFan1cOkfy/wFFyjb7TGpP0JApyVhGfrhGQkBc8EBQsaO46WYjBjypv+Zjwsba7CA8vQkXzAIwuZvXwiG6CfJ5NaV8FZpZxNIjUPz4dpk6keMNFWhxEAyN4kPs6Md/wacm32Fu/5OW4a4= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=Rte8fK4V; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=hu4311W0; arc=none smtp.client-ip=205.220.180.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="Rte8fK4V"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="hu4311W0" Received: from pps.filterd (m0279870.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 68G92gqF2477698 for ; Wed, 16 Sep 2026 10:30:30 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= 09Vbw+V0BNVZt49aE7j3dPPO+Gyf986E8iIZPb4OUVY=; b=Rte8fK4VXDI+M9p6 Yrdw10vWb5u6wHfqBdXEsBo0hCQdZ0bDte2nfWVRaTp+Cgr1Sg2UUZb53eNjgPrQ 9RoE6MeqyFL9Zk3XOCj+XBPWR2fZWG+Jh6m077cvWe1yWJJMG2A/1LVCErDOTGoF qK1VlpdiloF9O7oWSwn9Ihy5tk8htukLXObzaS9IZvRQOTxZx9cw+lmOy8yTthMU iB8yYp8pW54JAdD7uD0iVCKYPC645YR2zxLZWw7mtm1pkZaen2JOUKVOX6pOFauM f0MEke4W/4rohTWr8rTHiINS5YgZxkIDLbDWdffHDDqBGujgYw2VRNSG/Wmpr0FK 0k5qjg== Received: from mail-qk1-f198.google.com (mail-qk1-f198.google.com [209.85.222.198]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4gqjcksvhh-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Wed, 16 Sep 2026 10:30:29 +0000 (GMT) Received: by mail-qk1-f198.google.com with SMTP id af79cd13be357-93a1bffc2eeso912722485a.2 for ; Wed, 16 Sep 2026 03:30:29 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1789554629; x=1790159429; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :content-type:mime-version:subject:date:from:from:to:cc:subject:date :message-id:reply-to:content-type; bh=09Vbw+V0BNVZt49aE7j3dPPO+Gyf986E8iIZPb4OUVY=; b=hu4311W0JYi2JLoY8CTjKX6niyocglOAOJ+zrYly1BB6n010feMEseN9neNhN2lGhn 4kxQMUGKvl49RhWre5YwrivCEr/wOKUtncNmdn7COtUjInZfXCTX+6FE2Ar2KWOq0SQM UFjeLCbc8+6VlZJh6aqCgvn7onOh2EcV7yuMOdJ/G8R43Ms/3y79jB2K2MURJRi+rcK8 AMo7hqdpCjrnPhazrDizUr/by36Nyt9ocBf0SlmVSS72VozXhigz+gkpwtGR/rBsQium lVXz3eP4wdj43lKU9+XgasTe85zOSb6olloldXO3wnquwf9ujXJPBK75mfeVE42P5gRm AU0A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20260707; t=1789554629; x=1790159429; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :content-type:mime-version:subject:date:from:x-gm-gg :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to :content-type; bh=09Vbw+V0BNVZt49aE7j3dPPO+Gyf986E8iIZPb4OUVY=; b=E3qvfIq0F9+nQkIIP9cVaxa7s2e+7OmRVaDWw/PE0cPQ/zZesL3pBH8UWyjsYaZ8dd hUdiMzSkG46v3sA52x7ezPNxELpt0JbG4o36TZyB5sw6ARHKaUxoQTHUmFwR0y1pH0Sx CaHY+JpmTuh1JzjuRWRGuR2/xrUxciWhXs0QptK6fk7Pe0UFVaQp/jiRfnwwLUcF9Laa jQL8HLvpqZow4gJP/rXjVOYC3TD1SowFQt6PwKCrcRfQ6vvySTP2ZW/Rd8zB2hS1dFDq PV3TVHFZf/n+ezWthWMWaR2YgD5mIys8owqkyVsGzLNDCw3OzV/BRaBx9lZJltIvqDaV Z9/Q== X-Forwarded-Encrypted: i=1; AKwUvByZVEDtVvbnRAO6W4SaIPZWSNjpS5o1caiAsSdnvDhVkulpuQG79am0AF6iWpjd1j3Y5Ehub81sxAJPYIQ=@vger.kernel.org X-Gm-Message-State: AFuF++lxj8h6HeGb78F82Fxe1pb3ouK2EulDto9ONyTV5e42ExGUg2lj 2JKN4pc27rJtZi7af4h4ZCvt4M6+DGH759yBdZtMMvJa/KuBhSbZuYtObJHuYwoasrQAqs2qvlF WNOTW3q5ilEYcXOB3d29yEczp+tUzfYPGcKo3sg9H1KfdqAx/tY1kBzF7GAyIWs/Q09g= X-Gm-Gg: AYBFou0tT5rMqNTKRiY/AnKWee0/TiEDnZKJ5lEET9qW+mPPKUyRCcLf2mPXX0tKr3s K9zVdvqMA9AQhT7y/QstDDpgJkvFRQFU4IvU9FqpvrqgFWVrvUC1PXoWHvHMDhZkhdWqSgvx1Rj j0IllXySg4ETjRFZATwDhKB3LKoqRFlnB3sjONN00MWTUKoTo2hSVrr3bbvtZBUVpiOcuPs4Nfs jyWqqipbpbk5Gkic8NCEAce034xS0vnPIctmu9Wxe5FpRdLrAo06StaAqFpaDW3qSPn4jXgnooH 5Fnf46nNRoFQ0rnmoendsJInUMasC+eEi+Ou1wqtSwUHBJA2jvn0KYUU9zleeJEZeZfJ6gUARSd kpFqELpY= X-Received: by 2002:a05:620a:2a14:b0:936:dfbf:85b0 with SMTP id af79cd13be357-93bb783445dmr299929385a.35.1789554628875; Wed, 16 Sep 2026 03:30:28 -0700 (PDT) X-Received: by 2002:a05:620a:2a14:b0:936:dfbf:85b0 with SMTP id af79cd13be357-93bb783445dmr299918285a.35.1789554628025; Wed, 16 Sep 2026 03:30:28 -0700 (PDT) Received: from [127.0.1.1] ([86.121.170.232]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-49e83dbb0c1sm71633805e9.14.2026.09.16.03.30.26 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 16 Sep 2026 03:30:27 -0700 (PDT) From: Abel Vesa Date: Wed, 16 Sep 2026 13:28:51 +0300 Subject: [PATCH 35/48] clk: qcom: gcc-x1e80100: Use common clock controller probe data Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20260916-clk-qcom-rework-legacy-always-on-clocks-v1-35-25a24e50f82a@oss.qualcomm.com> References: <20260916-clk-qcom-rework-legacy-always-on-clocks-v1-0-25a24e50f82a@oss.qualcomm.com> In-Reply-To: <20260916-clk-qcom-rework-legacy-always-on-clocks-v1-0-25a24e50f82a@oss.qualcomm.com> To: Bjorn Andersson , Abel Vesa , Stephen Boyd , Brian Masney , Jerome Brunet Cc: linux-arm-msm@vger.kernel.org, linux-clk@vger.kernel.org, linux-kernel@vger.kernel.org, Abel Vesa X-Mailer: b4 0.16-dev-0e65f X-Developer-Signature: v=1; a=openpgp-sha256; l=3757; i=abel.vesa@oss.qualcomm.com; h=from:subject:message-id; bh=fR+QNqt66RcwAL1KPanC4gMbaMKXHhKCMmJQy6o4IiQ=; b=owEBbQKS/ZANAwAKARtfRMkAlRVWAcsmYgBqqm9sW9VFotN/xZ8nlf046gxwkgzBnnfPkueCo +Zh8DUoZVyJAjMEAAEKAB0WIQRO8+4RTnqPKsqn0bgbX0TJAJUVVgUCaqpvbAAKCRAbX0TJAJUV VqLdD/9FNgYEP4E13VQsW4BZwdPMolsgEblPCPOzt4uNMRjJg6f/F9o3szk004/2xF4HcR0sEYJ PZGCtzPRate1GxKL12pMslAQEN7xbw6M4OCrKo3/oqmMcMT1gu626PqQ/CoCDNPdEG0/qO5iKWX ood4PjrId61ummg7ZQUBFR8CNjJQbstMYO1MfPBEfDizWlDp8vl6NHXbtolvuCClagM6jDxb1fU gS3zFDw7N8kIr4SFyWeiwrds/IR6fj1sZJEsJWqMQIWBdM3EMqkP2IaDnknDpe5jdl/i4+W6hvE lvWbQ1pLU1wnwUMI/oGpXPpedqgFfU8tOKrpP1nSSuLkFGdsEhgJvSHTKKKd8JkH1udi/FEsg0b aRFPdadv+0oATgPycm1GFSEmXu+BuSIr8Qi9FgnifuxoPOHwSVxRU5KjESn6pZKS2cIUAGTOiw3 LW6zmCqqOZKZaWmQJgZPIJgmUFYyi/N7RfAQKDnvjELdByAYW7HHFUehHF9GZRpwBrXyVx5+s5L tJA7/03JPzoZ1hJz2MTul9jjtBVO8JAukKQEkOGZOdI+V7uoCPjDRS8+qSIMfIL/Bs65ETb70ZT J8nVRx3PIHzPcbEVw9fDwbJHiPyGmrEw3fi9oHShJsgFOEeuQDhiOQZUnquInblOVLFex8jbvM4 YdsJCiVxnpncV7Q== X-Developer-Key: i=abel.vesa@oss.qualcomm.com; a=openpgp; fpr=6AFF162D57F4223A8770EF5AF7BF214136F41FAE X-Proofpoint-Spam-Info: AW1haW4tMjYwOTE2MDEzNyBTYWx0ZWRfX11HwFpaKN7YV diVRXQJuK6Jk/f5Nc9lJoQi6xuA0bXxTWPFbsT/wwq8hGvfWiBdYtsi7rGhTjDyt92sXIXDeame NqSrIIijPAt4x0wfzn+RL6ci34jQMCs= X-Authority-Analysis: v=2.4 cv=PsIG/AM3 c=1 sm=1 tr=0 ts=6aaa6fc6 cx=c_pps a=qKBjSQ1v91RyAK45QCPf5w==:117 a=po8fGBi+ks8MzcVQGuqtFQ==:17 a=IkcTkHD0fZMA:10 a=VdqzKS8jKosA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=gowsoOTTUOVcmtlkKump:22 a=EUspDBNiAAAA:8 a=RW22A4phRzxp-fsVvwcA:9 a=QEXdDO2ut3YA:10 a=NFOGd7dJGGMPyQGDc5-O:22 X-Proofpoint-ORIG-GUID: 2imYfZanE81a_2Bn09BA1gnJtAoucMJ0 X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwOTE2MDEzNyBTYWx0ZWRfX9iFP5+zqYHMC 9yVwvrxIbY+jNaS2z6yCrsYiDe93X4qU6EWm32W8yLuD7duRNVNC9Q49ZDmN5Ibh25rgs0B3FVE V6g332Pt7OgIOHkPmC+Apg1uIzC8NDM/MCFb36hJldfdPZMwYZjnpVdCRXorZedSyCUQWUcP4gQ qp/MkF1+lqPQsnS06fqAgFXHi9FpuUxaLJEnVNO2ph4Qb1FPU9R0tBT4YNfbd9QmNBd7hkh9Duh 5WIPUCI6dl0IRUYG8m24CossrIMchbt2rLVlDu6SC2Zt8Nq9MgsVvkNVTHBKuzxxNjJ0nARuCrF v1Pb27RGVe4tDYPOPR3J97x9r3VFUAlvHe/BDIigr/HI94CsvkXWLWgtbHnVMvUxzfJWLmmRlUH Idr11NPEeyVeVKnoHL/4m/W18ffqiYEKLGltzqnHW2Z7OWcAbLK1cM1S36vmPiesZCFHDfjAQUQ z13uBgo0wOGjJP1rpWg== X-Proofpoint-GUID: 2imYfZanE81a_2Bn09BA1gnJtAoucMJ0 X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1176,Hydra:6.1.134,FMLib:17.12.100.49 definitions=2026-09-15_05,2026-09-15_02,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 impostorscore=0 lowpriorityscore=0 adultscore=0 priorityscore=1501 phishscore=0 spamscore=0 clxscore=1015 suspectscore=0 bulkscore=0 malwarescore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2609040000 definitions=main-2609160137 Move the always-on branch register offsets into a critical_cbcrs array, describe the DFS RCGs through qcom_cc_driver_data and move the register programming into the clk_regs_configure callback. Use qcom_cc_probe() to perform the common initialization instead of open-coding it in the driver's probe. Assisted-by: LLM Signed-off-by: Abel Vesa Reviewed-by: Konrad Dybcio --- drivers/clk/qcom/gcc-x1e80100.c | 61 +++++++++++++++++++++----------------= ---- 1 file changed, 31 insertions(+), 30 deletions(-) diff --git a/drivers/clk/qcom/gcc-x1e80100.c b/drivers/clk/qcom/gcc-x1e8010= 0.c index 8c146d62c077..65c4df8b7d69 100644 --- a/drivers/clk/qcom/gcc-x1e80100.c +++ b/drivers/clk/qcom/gcc-x1e80100.c @@ -7441,7 +7441,37 @@ static const struct regmap_config gcc_x1e80100_regma= p_config =3D { .fast_io =3D true, }; =20 +static const u32 gcc_x1e80100_critical_cbcrs[] =3D { + 0x26004, /* GCC_CAMERA_AHB_CLK */ + 0x26028, /* GCC_CAMERA_XO_CLK */ + 0x27004, /* GCC_DISP_AHB_CLK */ + 0x27018, /* GCC_DISP_XO_CLK */ + 0x32004, /* GCC_VIDEO_AHB_CLK */ + 0x32030, /* GCC_VIDEO_XO_CLK */ + 0x71004, /* GCC_GPU_CFG_AHB_CLK */ + 0x7d01c, /* GCC_HLOS1_VOTE_AGGRE_NOC_MMU_USB_QTB_CLK */ +}; + +static void gcc_x1e80100_regs_configure(struct device *dev, struct regmap = *regmap) +{ + /* Clear GDSC_SLEEP_ENA_VOTE to stop votes being auto-removed in sleep. */ + regmap_write(regmap, 0x52224, 0x0); + + /* FORCE_MEM_CORE_ON for ufs phy ice core and gcc ufs phy axi clocks */ + qcom_branch_set_force_mem_core(regmap, gcc_ufs_phy_ice_core_clk, true); + qcom_branch_set_force_mem_core(regmap, gcc_ufs_phy_axi_clk, true); +} + +static const struct qcom_cc_driver_data gcc_x1e80100_driver_data =3D { + .clk_cbcrs =3D gcc_x1e80100_critical_cbcrs, + .num_clk_cbcrs =3D ARRAY_SIZE(gcc_x1e80100_critical_cbcrs), + .dfs_rcgs =3D gcc_dfs_clocks, + .num_dfs_rcgs =3D ARRAY_SIZE(gcc_dfs_clocks), + .clk_regs_configure =3D gcc_x1e80100_regs_configure, +}; + static const struct qcom_cc_desc gcc_x1e80100_desc =3D { + .driver_data =3D &gcc_x1e80100_driver_data, .config =3D &gcc_x1e80100_regmap_config, .clks =3D gcc_x1e80100_clocks, .num_clks =3D ARRAY_SIZE(gcc_x1e80100_clocks), @@ -7459,36 +7489,7 @@ MODULE_DEVICE_TABLE(of, gcc_x1e80100_match_table); =20 static int gcc_x1e80100_probe(struct platform_device *pdev) { - struct regmap *regmap; - int ret; - - regmap =3D qcom_cc_map(pdev, &gcc_x1e80100_desc); - if (IS_ERR(regmap)) - return PTR_ERR(regmap); - - ret =3D qcom_cc_register_rcg_dfs(regmap, gcc_dfs_clocks, - ARRAY_SIZE(gcc_dfs_clocks)); - if (ret) - return ret; - - /* Keep some clocks always-on */ - qcom_branch_set_clk_en(regmap, 0x26004); /* GCC_CAMERA_AHB_CLK */ - qcom_branch_set_clk_en(regmap, 0x26028); /* GCC_CAMERA_XO_CLK */ - qcom_branch_set_clk_en(regmap, 0x27004); /* GCC_DISP_AHB_CLK */ - qcom_branch_set_clk_en(regmap, 0x27018); /* GCC_DISP_XO_CLK */ - qcom_branch_set_clk_en(regmap, 0x32004); /* GCC_VIDEO_AHB_CLK */ - qcom_branch_set_clk_en(regmap, 0x32030); /* GCC_VIDEO_XO_CLK */ - qcom_branch_set_clk_en(regmap, 0x71004); /* GCC_GPU_CFG_AHB_CLK */ - qcom_branch_set_clk_en(regmap, 0x7d01c); /* GCC_HLOS1_VOTE_AGGRE_NOC_MMU_= USB_QTB_CLK */ - - /* Clear GDSC_SLEEP_ENA_VOTE to stop votes being auto-removed in sleep. */ - regmap_write(regmap, 0x52224, 0x0); - - /* FORCE_MEM_CORE_ON for ufs phy ice core and gcc ufs phy axi clocks */ - qcom_branch_set_force_mem_core(regmap, gcc_ufs_phy_ice_core_clk, true); - qcom_branch_set_force_mem_core(regmap, gcc_ufs_phy_axi_clk, true); - - return qcom_cc_really_probe(&pdev->dev, &gcc_x1e80100_desc, regmap); + return qcom_cc_probe(pdev, &gcc_x1e80100_desc); } =20 static struct platform_driver gcc_x1e80100_driver =3D { --=20 2.54.0 From nobody Fri Sep 25 05:31:34 2026 Received: from mx0a-0031df01.pphosted.com (mx0a-0031df01.pphosted.com [205.220.168.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 8AF7C4E8DF8 for ; Wed, 16 Sep 2026 10:30:37 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.168.131 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1789554669; cv=none; b=LOgJaNREW7fOTSSusPfjLB4CO3eZii5rq6LiReLQMXKy1w1iocwRCbHGjr07bpKkU+OFOchZrmfr4LDdeExb1TZoTDGR9jA9jkxN0HA69yO4fZmiY8G2Z9p+JyC65NLKwx8Y4L5g2+1VdOweXkz7jxkujMOzDBzLVx6zJ+3vmBE= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1789554669; c=relaxed/simple; bh=0T4dQbu29oPHtUNJMaj4IA4JQ3pucb+UYD+sfPAtCoc=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=uxon2iNB5mMvGZUj0O3cgafwkrcPwrLywYl379l0EpSx05NN8YKHRejR+rtULxiQDKXfMY6XNQWQ05Rn4fnpgwBsygWjY9sJPmsNc8XPQQx8Tbp4ZZBKtCR+WElHYQrwvRSf4hfkbgFzbRGW8xrnHcnhZBC3moj66cVkqLs3O/Q= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=Ydux3VNA; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=aj4gI02H; arc=none smtp.client-ip=205.220.168.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="Ydux3VNA"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="aj4gI02H" Received: from pps.filterd (m0279867.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 68G92pTB3377391 for ; Wed, 16 Sep 2026 10:30:32 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= PSSUosnYV8bVdtrO8uA7tDw0GoPQ4dpOoCCpY3yu9hU=; b=Ydux3VNACXLfeysb CdWisWTkE6rbUvCT5Sz00cGKq1mosh7AAPvdwMJhAY5NH6sw/g+yeG2dOkxm1IeT LO66QNNqdNcG/Bk9iaialIEQjT7IVl06iSreopleSpQLDczDwvpZDMq9GBGJWw5N rnkRZndbCBs/QzxstNtRxK+ZhukHG8XoWHPfGJ22T7+282IgBGGY4UUnKbPv/OMJ hj2OEYDgr0JDJO6Rcpc4X4wpGIauHiTXT6wqAvTh4xCSNH+HjM3+bn3TTHElTKD8 8iHdoHc0/QLrlTNJpsf2S+gr0vRnAwLk4iKHJD4z89TRDwOi/+CUzclJ6UMvUTuc kaksTQ== Received: from mail-qk1-f199.google.com (mail-qk1-f199.google.com [209.85.222.199]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4gqefpanpw-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Wed, 16 Sep 2026 10:30:32 +0000 (GMT) Received: by mail-qk1-f199.google.com with SMTP id af79cd13be357-934956beec8so1016912385a.0 for ; Wed, 16 Sep 2026 03:30:31 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1789554631; x=1790159431; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :content-type:mime-version:subject:date:from:from:to:cc:subject:date :message-id:reply-to:content-type; bh=PSSUosnYV8bVdtrO8uA7tDw0GoPQ4dpOoCCpY3yu9hU=; b=aj4gI02HWDN/CoVNEDCGoRnpTCNNnBnJzDrwMYEkL6K7eAa/kT0o9uwJ6HPPqrgkmf bHwy+xdq2t0NmmdIUCWhoRQPfwLBU6mj7UIu7k+oY4Rrv2KL0qALMcb5AoHX3JBMymz9 n0pAyd6z57wB2qjc7vdAamYTmhgRdipkplTlReQOQxI0eYrmn1JDEw/V231B+z3ZCPLb tkNlxbEDkobdiu2/6bJJEb/dCx9RuDEaPGeuRvS7+xgdM65OD9lsidiB4SMzpBbncX71 f3QAHglOhNvbMagyv3NZl3cy7wtKLmkKx0DiKvEVWtCSMRzvFOYkE4A4IjnJ+DIPfi5x D7MA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20260707; t=1789554631; x=1790159431; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :content-type:mime-version:subject:date:from:x-gm-gg :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to :content-type; bh=PSSUosnYV8bVdtrO8uA7tDw0GoPQ4dpOoCCpY3yu9hU=; b=Kw8kCYShNOEHDwXwiOxlDw95MxsIuONME9RW4cvwW+v9WKoL8fsm4llchFGZ0el2qY DAUtCA/E0wVfxGk3fNbLEek3ub+mNPi4E7xs//IUajv9GUrt+gciLKOKeFME540qMgW1 fRJu65PDzTaxAzstaXSKfcK7/tiPVKp8XQxC4EQG91lGmDjzEwTVCjTqETAScG6AW48i tbeDqNqkJ47vSb8MlyBhNj+C8dZoAXOEdwNDw1yCkbTMInk/Kk1JFpz36r/6LHUwvO7d QAt8cpkeia24RHsy+Xdw3iF1zyh14TXAvDmq2+0Ayq0E8TlHiraWEG/kz4uOEdwoHvyK v3sg== X-Forwarded-Encrypted: i=1; AKwUvBx7i+wL4Gj2QaVfZZeAPdTPHQZNvpHZoTXrP7qLPsY5cfYTGtNmjwQRPBO6sDcetW+Eh0hsuxJC1pa/Fp0=@vger.kernel.org X-Gm-Message-State: AFuF++kpWJkKEPYskjpWdoOFLAPvdhdPvSTyolIx0FdedlQozCLJ/Yqs S1XoLR4vSN/LMsvVGb4ZmnAtV8hC1Y99vrfENEPUblaqSWCyyGG9ZpHcP0EqxjkF5FKy0xdOa9d hpeXMjoxq4V1b269w8HSlaUsi1iM52TlFPlqO9UkSYhGMUNA7C1wzEVmOHjIVRc26HP5EcGO1NS E= X-Gm-Gg: AYBFou1TDfAPrIyAeUFmvTrKp2SoZTqMVn4wAEPUPg9W5vypHV5gqS5X77blyh+yczZ z9Fe/3cAmag+1J+bbBVxWkKOFRaeXtz8QCt6ejJvDG6kEMa2wCu4+3FZK56m1FRmz7SdYu7TVrk dDxA8j/wNdguw4lt6IOslguZU4wTRzU7PRGoi4R1YZWrfLNd9vZrzmtElZKyEr2asVhxTqF837J WYVPomGP1tZc8hz+hqTqp9QZSGPdHRf808+1/tD1UggLSJri1x6sJGXGIqWPcDEg/TIjAg+DjPM 09l69z2MZMhjkz5GCBr6lmHTX6wltS2EK8HBLUt1j+cns1UOkBtoVzIas+FulwCkN6wAUxLUE5d grLBeFOo= X-Received: by 2002:a05:620a:648d:b0:914:afc1:c66d with SMTP id af79cd13be357-93bb7667c54mr281834785a.11.1789554630972; Wed, 16 Sep 2026 03:30:30 -0700 (PDT) X-Received: by 2002:a05:620a:648d:b0:914:afc1:c66d with SMTP id af79cd13be357-93bb7667c54mr281826885a.11.1789554630426; Wed, 16 Sep 2026 03:30:30 -0700 (PDT) Received: from [127.0.1.1] ([86.121.170.232]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-49e83dbb0c1sm71633805e9.14.2026.09.16.03.30.28 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 16 Sep 2026 03:30:29 -0700 (PDT) From: Abel Vesa Date: Wed, 16 Sep 2026 13:28:52 +0300 Subject: [PATCH 36/48] clk: qcom: gpucc-sar2130p: Use common probe handling for always-on clocks Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20260916-clk-qcom-rework-legacy-always-on-clocks-v1-36-25a24e50f82a@oss.qualcomm.com> References: <20260916-clk-qcom-rework-legacy-always-on-clocks-v1-0-25a24e50f82a@oss.qualcomm.com> In-Reply-To: <20260916-clk-qcom-rework-legacy-always-on-clocks-v1-0-25a24e50f82a@oss.qualcomm.com> To: Bjorn Andersson , Abel Vesa , Stephen Boyd , Brian Masney , Jerome Brunet Cc: linux-arm-msm@vger.kernel.org, linux-clk@vger.kernel.org, linux-kernel@vger.kernel.org, Abel Vesa X-Mailer: b4 0.16-dev-0e65f X-Developer-Signature: v=1; a=openpgp-sha256; l=1692; i=abel.vesa@oss.qualcomm.com; h=from:subject:message-id; bh=0T4dQbu29oPHtUNJMaj4IA4JQ3pucb+UYD+sfPAtCoc=; b=owEBbQKS/ZANAwAKARtfRMkAlRVWAcsmYgBqqm9tx0E7IbD7dx9ixcFQo4kmobzbcTPvrlgv2 ocNRkzPAzeJAjMEAAEKAB0WIQRO8+4RTnqPKsqn0bgbX0TJAJUVVgUCaqpvbQAKCRAbX0TJAJUV Vo8YD/4p0sJSzsnCt4aXkQH8gjr0nYkUCQTaxvkSrF7W1ffFkbD6c0Uez240WX8IXEnSU5xCOJF zS8WABTsM4RjjIxV8YOzFSUBkfpFx1yJgWHWDKjapLlM4XxLBGXwKJhQulhmpz6kKrXuYc7WoUh 2UTHaW693dyzmJMy9Kdul2JLoDDqq+rO0E1XSU7+P5D1wa9lnJjrdsNWO6+/90+0cOj9dBAcvDa 4uGKlRw6+uRmFtMlnZ7R3UFO1Xf2usbjaOMeFvVsbsPHDdeusE6KhgTiyj9TRwd/laBfE7Pyko9 0bsHyy0FV0K56aV3iNrDqOqV/9BKR3RwYTUUhDORouleu6PqG8G3yjI6/QhZniOYzTT+/Qwm+PS h8+oTEXxPjAxQUQxiYzuaZjRp64ObD+81pkfl8EYfa1uKUpRFXc6TK5mUVLz+n8FgjXUtq5VOWh qPguMe+Q0yZtfyet+rMPYJRa7Lt3ooP/4dYIHmiMFWYbPKUGZ57xQYam0uNkI/1ycmFys7Z5uQR Xs815GRHHNxNMEcRDkGTveudrX3gDCEQRTvGETaNahKxnj6lkVmVfQ4/XCt/4tkG9mAwxGUNJoi lsadJGZ0QDmmm2lrVIZg+IX/B2f/Tu+3C/Zs3dDmyQaoH7Bvgjn97Xk6LqgevprNSLw531Ju4zu nSoX1lm7eWnC19Q== X-Developer-Key: i=abel.vesa@oss.qualcomm.com; a=openpgp; fpr=6AFF162D57F4223A8770EF5AF7BF214136F41FAE X-Proofpoint-Spam-Info: AW1haW4tMjYwOTE2MDEzNyBTYWx0ZWRfXyut8CTL700zq f+Pi0an8RJdYaEbVh+w7/0p/KEjVxy5CVYo2cJK9i+CAH6F7lM84fbmoxaXIztlrC2agxteeZSs bDSXVlhkJUjZqZyigrZWmyriRAKzFRY= X-Authority-Analysis: v=2.4 cv=HrTjiETS c=1 sm=1 tr=0 ts=6aaa6fc8 cx=c_pps a=HLyN3IcIa5EE8TELMZ618Q==:117 a=po8fGBi+ks8MzcVQGuqtFQ==:17 a=IkcTkHD0fZMA:10 a=VdqzKS8jKosA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=eoimf2acIAo5FJnRuUoq:22 a=EUspDBNiAAAA:8 a=ED4nYY0oUM9iKWp7kXQA:9 a=QEXdDO2ut3YA:10 a=bTQJ7kPSJx9SKPbeHEYW:22 X-Proofpoint-ORIG-GUID: 7I9SZHpnBaXCJnTcZ0LV7XhyjJlAojWl X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwOTE2MDEzNyBTYWx0ZWRfX6DrQER1fOIsf /WY1o3o6UH8MhIoXFEOhPmY+nSdULpE9+amvzYYT57EaD1LvsjW9OW49FXV13UjSxZM5EuG1paH zFE1fA5aXCF03w/TH9p2CcDusm/k6FgrfY9AhDhLShyQX4EWaSWNkTyML5EHvPZUCMyXT7EPRZP p3OE6wqnTdJHhHViycrcFWqUjO6amu82zeECJMqLGIszGORtMiG0YCX7FDY14dZdffXcfeiIPSq bl2UsAW116kbr8YIxDloIvrfW0TS2SQ/TNBmgUR3Pa9FI9rGf4MVKe53vw5nbxBZ9yVei9/sVvh 4m40Po5W6BTnZDxAC9xHBfkkNekfbfovvC4+iDyta9A5t+VPORH+J2S7fUqZ6cmDeFWrYr0Ow6e 1NezioxLg/GuM8pKcHsCn9gTrHd4Rzo7iXaA0egeOlu6bt3xS7gNqFt4G0xxB3htRAXDAB0MY0R VKCQ5Q/hjVOZRbVRb5A== X-Proofpoint-GUID: 7I9SZHpnBaXCJnTcZ0LV7XhyjJlAojWl X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1176,Hydra:6.1.134,FMLib:17.12.100.49 definitions=2026-09-15_05,2026-09-15_02,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 suspectscore=0 lowpriorityscore=0 impostorscore=0 bulkscore=0 phishscore=0 malwarescore=0 clxscore=1015 priorityscore=1501 spamscore=0 adultscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2609040000 definitions=main-2609160137 Describe the always-on branches in a critical_cbcrs array and reference it through qcom_cc_driver_data. Let qcom_cc_really_probe() enable these branches instead of programming them directly in the driver's probe. Assisted-by: LLM Signed-off-by: Abel Vesa Reviewed-by: Konrad Dybcio --- drivers/clk/qcom/gpucc-sar2130p.c | 13 ++++++++++--- 1 file changed, 10 insertions(+), 3 deletions(-) diff --git a/drivers/clk/qcom/gpucc-sar2130p.c b/drivers/clk/qcom/gpucc-sar= 2130p.c index dd72b2a48c42..fa261664c1bf 100644 --- a/drivers/clk/qcom/gpucc-sar2130p.c +++ b/drivers/clk/qcom/gpucc-sar2130p.c @@ -455,7 +455,17 @@ static const struct regmap_config gpu_cc_sar2130p_regm= ap_config =3D { .fast_io =3D true, }; =20 +static const u32 gpu_cc_sar2130p_critical_cbcrs[] =3D { + 0x900c, /* GPU_CC_DEMET_CLK */ +}; + +static const struct qcom_cc_driver_data gpu_cc_sar2130p_driver_data =3D { + .clk_cbcrs =3D gpu_cc_sar2130p_critical_cbcrs, + .num_clk_cbcrs =3D ARRAY_SIZE(gpu_cc_sar2130p_critical_cbcrs), +}; + static const struct qcom_cc_desc gpu_cc_sar2130p_desc =3D { + .driver_data =3D &gpu_cc_sar2130p_driver_data, .config =3D &gpu_cc_sar2130p_regmap_config, .clks =3D gpu_cc_sar2130p_clocks, .num_clks =3D ARRAY_SIZE(gpu_cc_sar2130p_clocks), @@ -483,9 +493,6 @@ static int gpu_cc_sar2130p_probe(struct platform_device= *pdev) clk_lucid_ole_pll_configure(&gpu_cc_pll0, regmap, &gpu_cc_pll0_config); clk_lucid_ole_pll_configure(&gpu_cc_pll1, regmap, &gpu_cc_pll1_config); =20 - /* Keep some clocks always-on */ - qcom_branch_set_clk_en(regmap, 0x900c); /* GPU_CC_DEMET_CLK */ - return qcom_cc_really_probe(dev, &gpu_cc_sar2130p_desc, regmap); } =20 --=20 2.54.0 From nobody Fri Sep 25 05:31:34 2026 Received: from mx0b-0031df01.pphosted.com (mx0b-0031df01.pphosted.com [205.220.180.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 75DA84F798F for ; Wed, 16 Sep 2026 10:30:37 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.180.131 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1789554654; cv=none; b=LucF3iL9i6m/X/PDTJijnUdT8RRvuG2cFnbrjcubBYof/Sk1PKMbgdVmI59jqJ2r3AwJg2ktiFbZcxkMxFGlDr+pv/SBENQ9Thj+h5mqi4JN/79w5TLt0lUdrX7MzfU7sBTfYYrr7jngS3DIv9m1A5pLg/ameg/IwxCZ7whqVkQ= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1789554654; c=relaxed/simple; bh=jZ1F4WC21Az3jEkyItdyWmwptqda8S/3m5px6frmneM=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=qIFMzeAad80XoKEtXiAm9UTdSpPhvc3k5+KRX3mulhfA9Xq+eYV9LzlXExdxr9oNcyqdkaIdcn/UB++8NF3HkWdt7N3vIMPrGGuJdUnwjANWJaNnwR1RQm1xH3G8bhdM3aj3dPJCGZHTgsll3sfoLqQBIG9Yf4tXatJur7zfZLE= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=EivbjGY3; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=hAhjQ9Bi; arc=none smtp.client-ip=205.220.180.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="EivbjGY3"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="hAhjQ9Bi" Received: from pps.filterd (m0279872.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 68G9330R1587228 for ; Wed, 16 Sep 2026 10:30:34 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= EV82cBN71TZEmGHMYnfIYynbqB0wUkL/qmo9KXqyVRA=; b=EivbjGY34PWMqlv0 hxhoJUtCXyp5eNzh99ZFLxbsKcXNvOem4QlJpPxdOtQAVfyEq1ld5gYd6Tj4kYbr 6Y8o3tx5yjJw4R/QqoKgGmRYZIMiZlMLx56H+bZ4xGU8nxPuuiTkE6mFTY22+sz7 Tt6Dxd98nA329Or7eYswJs5nONZuik27WFVZ4ijAG7NSmE4ErDWhKH00Rz6/bkZC xZlvga6vVEdRdeuaFVx6VJUtaSnKZvFiP3SrpYWdhXTkQIzGp9w75Vhk7blxxamK dRIS+SIJi1ARKXvfgxrxN0PXlWpGmExEfN8E+mE+ipX2CoBA0MIrqGYiY1Uzoi2Y x/+kcw== Received: from mail-qk1-f197.google.com (mail-qk1-f197.google.com [209.85.222.197]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4gqageksfj-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Wed, 16 Sep 2026 10:30:34 +0000 (GMT) Received: by mail-qk1-f197.google.com with SMTP id af79cd13be357-939a6937513so845757885a.3 for ; Wed, 16 Sep 2026 03:30:34 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1789554634; x=1790159434; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :content-type:mime-version:subject:date:from:from:to:cc:subject:date :message-id:reply-to:content-type; bh=EV82cBN71TZEmGHMYnfIYynbqB0wUkL/qmo9KXqyVRA=; b=hAhjQ9Bir6k6+1C2rCx+KPVRmzyMymMc4zOVWtpq5fd9bvoaPnI1tTufrxkv1pihxB ANNO0m3YKzNDCIs6PBgMIfsgLyLABjPLGGYvQJF75vcYyiR4+xVWupiV1lfuFw/bRnh/ BfQcj6G0cXdOvmUf/qhJBRyRMeTqVaolwlD04s7IDV597a77zdqd6A4ofGxOUboEm+wR GH4hW5uM9drcCeoa0aBv0cnZCS+BkNoEvdBvKLKkFgRuowPOoVMPjrM5suQ1CNpKjAq0 ZiIlVcs08uC8vee7F6LbliVZ4B+sqDqD2p6ydYadnJrD7XYc55r0wMQhXvNFFk36ZSwr yEvQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20260707; t=1789554634; x=1790159434; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :content-type:mime-version:subject:date:from:x-gm-gg :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to :content-type; bh=EV82cBN71TZEmGHMYnfIYynbqB0wUkL/qmo9KXqyVRA=; b=kYaQV68vP7iR3bAWNrdeaup8ZQ87rSyp2UqH9qBpg8srUUmiFLOwyFx4s15wRuiLmN iyY7pOVr8bELiprlDpyCU3lyCUoJvhg92J6APE2ZO01ehoLetyvxaENrpNTj8Y7z61wc hXCAQ1FP2H8OV/f8gTt/CiFv7bTjaR96NFZvo5O+a3SimRIBPD6MdQlOtbEbIuWGywAt ANh3oEw/5+Q4CptAL+9tSCwa2yw9f/DTPAzK47nRHJldqnGiCMR706ClCXvisTAGnyrO TG/dI8AeqHA0AEBpZOIZ8/EQ2NCyflAW/M2wQnEhCxWm8oZOggfUH7xPLh5JUJAcOIGK 44lQ== X-Forwarded-Encrypted: i=1; AKwUvBz7ZUOQF0zD6G3wG8yqOivA34AR1PmiQ9sJ5zy9pLk62Q2GzrCN3IOk1JDNSEtdmVDxr79gVoieDt/gL90=@vger.kernel.org X-Gm-Message-State: AFuF++l6IbaLP6pjHnzYXKOlJGg3vkjNbhOL2210fy/h+NrcZJ50KwcW 1vMRXAQFeekz5/5SfAvZL7P1MTz8zIirJcHca8hBXTKTpzn5kti0eFah+cfWa+Nhmk+SzoWKReL vzASmIrpe2Z9l2OhfMegzk9/DXp7blG7STGEfvGI1MPf/rJsk+Jv7bh1mRdpFDRPQVJU= X-Gm-Gg: AYBFou1w0VEZ6yW+TDZz7QrPkNO4o3WxBeBcR9oHOI0p8vWbMOg8jY2kcDEa7IlEaIR F+sE7vsSfx3nuyBY0cNhMxUWt8ie5KUpp+1l3TZo294KkvDh5VhDuOvo0I0CNTAbFWI0Vs57E9i D9GghI3eQkqTDKBHqbzaXjP80kD/R/QkNSd1M+Eo+F2dQbzQneK84zRxo/TK9gfTRudGLX6GNYo UsTExQoTjAgztG8W22ndogHCNbdgP0Uldpe8M3kMdr7XuQzhQme9XMFGCIRZFfOwyUY2/04/FVz E5SU0hIAkDtbmXiSBEHvN+HIU5cDYHe95NDmfq0bGgbTewi/f258IyBUPOeRSgakucocTbdBBJ9 4e6kpQL0= X-Received: by 2002:a05:620a:800e:b0:939:e5a3:10dd with SMTP id af79cd13be357-93bb76e2cfcmr326486885a.2.1789554633649; Wed, 16 Sep 2026 03:30:33 -0700 (PDT) X-Received: by 2002:a05:620a:800e:b0:939:e5a3:10dd with SMTP id af79cd13be357-93bb76e2cfcmr326476785a.2.1789554633097; Wed, 16 Sep 2026 03:30:33 -0700 (PDT) Received: from [127.0.1.1] ([86.121.170.232]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-49e83dbb0c1sm71633805e9.14.2026.09.16.03.30.30 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 16 Sep 2026 03:30:31 -0700 (PDT) From: Abel Vesa Date: Wed, 16 Sep 2026 13:28:53 +0300 Subject: [PATCH 37/48] clk: qcom: gpucc-sc7280: Use common probe handling for always-on clocks Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20260916-clk-qcom-rework-legacy-always-on-clocks-v1-37-25a24e50f82a@oss.qualcomm.com> References: <20260916-clk-qcom-rework-legacy-always-on-clocks-v1-0-25a24e50f82a@oss.qualcomm.com> In-Reply-To: <20260916-clk-qcom-rework-legacy-always-on-clocks-v1-0-25a24e50f82a@oss.qualcomm.com> To: Bjorn Andersson , Abel Vesa , Stephen Boyd , Brian Masney , Jerome Brunet Cc: linux-arm-msm@vger.kernel.org, linux-clk@vger.kernel.org, linux-kernel@vger.kernel.org, Abel Vesa X-Mailer: b4 0.16-dev-0e65f X-Developer-Signature: v=1; a=openpgp-sha256; l=2086; i=abel.vesa@oss.qualcomm.com; h=from:subject:message-id; bh=jZ1F4WC21Az3jEkyItdyWmwptqda8S/3m5px6frmneM=; b=owEBbQKS/ZANAwAKARtfRMkAlRVWAcsmYgBqqm9uR24WEoaYzlFM9U0lA3l1k4QFzmiD3Q8Ba jsLXqsPk4SJAjMEAAEKAB0WIQRO8+4RTnqPKsqn0bgbX0TJAJUVVgUCaqpvbgAKCRAbX0TJAJUV VoEOD/sF8rRigchS5Y9B3F4XifcZuTcbaKr/HANbNCmrvYfVUuKagOKBCwlF47rh3EZ8hDyCzVx fLyweH0FOgJNxvowq4b0NxJQyd3+r5YfDoWCCiHxUSRrcQZ93uQ7waDUHrWzbWtrDwblM1LcVkp aszrBtW/dARUc0IMPdSs9jP8gi2gBxcZr0xYVjvsAzjgy5T/6t17Ag3g79IULiPPHD7qsIK5f66 Q5LAJc+dRkNt2mu/7xxGzRDzeU6/C3Eq74JKKwBpZebcTItB/UhgoBqZDc6QFI0QokKa09WsCqb 1Hn3qgxKlhDKyVBmH0E7uXmyDz4aFqDw/upFRWlZ665UKp5+DJnN0g07dFmY7VxygPRDd2DLuD6 73iOeSuORDdLILxThMLfQ4hni82ipEiE7i5dzd74lTh3q1HL2oQi96mEthmicks05uLWFWnP3hZ zedpodgzt+nkJpO6fZWNyiGawethDGDqli0jQo9vDrJcq2LXQvY+cPOiOQaOOpjs1Eq+9s+EQJD OA8WIncS75pdAPmEPJxbHvn1aRP8STmZhjx/c6qLe/n8EfanYSlozwvAK73GNELSZERW6xe+jc6 mXbn47MCUBQvzGOsaZT7hTKwjlZ3WG5Gls6hhRVsFwNh937R146yLW7s2JUSjYWDB/yVAxlR4Xg d16G6lckvgz+CSw== X-Developer-Key: i=abel.vesa@oss.qualcomm.com; a=openpgp; fpr=6AFF162D57F4223A8770EF5AF7BF214136F41FAE X-Proofpoint-Spam-Info: AW1haW4tMjYwOTE2MDEzNyBTYWx0ZWRfX0hXQVY5lBJMd ccI7bZivOBBj/LjeYTurJNOWaXUxJ8jcinhJqEwMKeqFFYrRO+USrsl0DrP05qJRs57K7ovrAPO GZDnAZyh8EnR3GtWy+UnNbgTM9QoPKk= X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwOTE2MDEzNyBTYWx0ZWRfX9cfdyULWqSuQ b9M1WPpYqakIOFjgdYpTpRNjEMmj3Cfsf94fI30jGxx6hV07wdR5a9/ZIYL790hzyG4vy+CfH7a gVlAfh/JwKeh3h+N13vO/BFZGKvY9iRZqFOacPXVkxSCMa8r/6j/QKlJvR8V3nJWCGYh5g6viHO q4dNpl3uvPoFxeu2Bt9BAdO1vl4JjiONEvFjKQL7woIU5KTDT7HA1jz2W5NnCHIf2q+DiHSqXAf 7jRr1g5E1H4oGo+XON+orYcqnIpfCoCqaDnI2LR/y3sukgAqFemK18MQyOY7Keq1ZMz5f4twRYi /Pg/ynAPb9BFjsbY5/9JvaM/ryCycqZhnRAU8VjzGNpY0+JeDzPV9WBt8wjY67TjRR9pAl6NbZR TgNOrwrQ+Qv7caXSOGut4BbHIl5FpLU3MEDWDPOCS3+9vFimm9S98CSHEH0k8lJ1KrNCuXAQLWY 8LJGp69WIL9n3V1netg== X-Proofpoint-GUID: N1DE7yXNS0MFaIi0oQCwLj1XyhddFdwE X-Proofpoint-ORIG-GUID: N1DE7yXNS0MFaIi0oQCwLj1XyhddFdwE X-Authority-Analysis: v=2.4 cv=PcZqFShd c=1 sm=1 tr=0 ts=6aaa6fca cx=c_pps a=50t2pK5VMbmlHzFWWp8p/g==:117 a=po8fGBi+ks8MzcVQGuqtFQ==:17 a=IkcTkHD0fZMA:10 a=VdqzKS8jKosA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=yx91gb_oNiZeI1HMLzn7:22 a=EUspDBNiAAAA:8 a=W2O9Cv0nt9n2xGTIkqUA:9 a=QEXdDO2ut3YA:10 a=IoWCM6iH3mJn3m4BftBB:22 X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1176,Hydra:6.1.134,FMLib:17.12.100.49 definitions=2026-09-15_05,2026-09-15_02,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 spamscore=0 phishscore=0 suspectscore=0 malwarescore=0 impostorscore=0 clxscore=1015 lowpriorityscore=0 priorityscore=1501 adultscore=0 bulkscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2609040000 definitions=main-2609160137 Describe the always-on branches in a critical_cbcrs array and reference it through qcom_cc_driver_data. Let qcom_cc_really_probe() enable these branches instead of programming them directly in the driver's probe. Move the GMU branch register update into the clk_regs_configure callback so it still follows the always-on branch enables. Assisted-by: LLM Signed-off-by: Abel Vesa Reviewed-by: Konrad Dybcio --- drivers/clk/qcom/gpucc-sc7280.c | 22 +++++++++++++++++----- 1 file changed, 17 insertions(+), 5 deletions(-) diff --git a/drivers/clk/qcom/gpucc-sc7280.c b/drivers/clk/qcom/gpucc-sc728= 0.c index bd699a624517..9b267276eac7 100644 --- a/drivers/clk/qcom/gpucc-sc7280.c +++ b/drivers/clk/qcom/gpucc-sc7280.c @@ -440,7 +440,24 @@ static const struct regmap_config gpu_cc_sc7280_regmap= _config =3D { .fast_io =3D true, }; =20 +static const u32 gpu_cc_sc7280_critical_cbcrs[] =3D { + 0x1170, /* GPU_CC_CB_CLK */ + 0x1098, /* GPUCC_CX_GMU_CLK */ +}; + +static void gpu_cc_sc7280_regs_configure(struct device *dev, struct regmap= *regmap) +{ + regmap_update_bits(regmap, 0x1098, BIT(13), BIT(13)); +} + +static const struct qcom_cc_driver_data gpu_cc_sc7280_driver_data =3D { + .clk_cbcrs =3D gpu_cc_sc7280_critical_cbcrs, + .num_clk_cbcrs =3D ARRAY_SIZE(gpu_cc_sc7280_critical_cbcrs), + .clk_regs_configure =3D gpu_cc_sc7280_regs_configure, +}; + static const struct qcom_cc_desc gpu_cc_sc7280_desc =3D { + .driver_data =3D &gpu_cc_sc7280_driver_data, .config =3D &gpu_cc_sc7280_regmap_config, .clks =3D gpu_cc_sc7280_clocks, .num_clks =3D ARRAY_SIZE(gpu_cc_sc7280_clocks), @@ -464,11 +481,6 @@ static int gpu_cc_sc7280_probe(struct platform_device = *pdev) =20 clk_lucid_pll_configure(&gpu_cc_pll1, regmap, &gpu_cc_pll1_config); =20 - /* Keep some clocks always-on */ - qcom_branch_set_clk_en(regmap, 0x1170); /* GPU_CC_CB_CLK */ - qcom_branch_set_clk_en(regmap, 0x1098); /* GPUCC_CX_GMU_CLK */ - regmap_update_bits(regmap, 0x1098, BIT(13), BIT(13)); - return qcom_cc_really_probe(&pdev->dev, &gpu_cc_sc7280_desc, regmap); } =20 --=20 2.54.0 From nobody Fri Sep 25 05:31:34 2026 Received: from mx0a-0031df01.pphosted.com (mx0a-0031df01.pphosted.com [205.220.168.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 746DF4FB9D8 for ; Wed, 16 Sep 2026 10:30:43 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.168.131 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1789554660; cv=none; b=XRFFJt+urKr3PeAQ0T0Kt07Tz8unZN41oNaA+qF5Aa5L1odO/D3jy57c5DVvrxU7rmmw+gsDsSWPPKn8C9Zhm42yE31Dzq8UE3S+l76Er/4J5LMVoVWlx2igdYP6t5oC1k0Xa+NBXXz2kfbv5QfQj/QvkxVpAhcRf89cv3K6SDk= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1789554660; c=relaxed/simple; bh=U+9VQRVM4S7Z8VJMwjV5ugP/YnxuxuAFNy2XnC0w9rA=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=OB7IPuUCbjlPWcdB2kA/8q7ZNx3FB/4C4e6SHojBQi+PEgWRDxiH2ck3e8oFblpbh6otAR62LvsiEgqP1xCZYlTjr/0G5aqmGEePX1o0DQe8fB4qYdOmodvmHHQwHFkgQ9jtGMpCBGwpRDjmEKvpxu99Pm9wJY2IZGmsWWfsrQo= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=ijOEB+xU; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=d/vUmvpV; arc=none smtp.client-ip=205.220.168.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="ijOEB+xU"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="d/vUmvpV" Received: from pps.filterd (m0279862.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 68G92uhV1721215 for ; Wed, 16 Sep 2026 10:30:38 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= GN46dMW3MStQFHvocVLrbP88+rGtR199PBAALuRhwHU=; b=ijOEB+xUc1ldJsYD 8n+G+Yw4K/CXadTfC1v2d9tDp8YkHjYJgzAUKGv1GfciAQlybUDzrdzK/wJBJ0Cv A3oo3mgPZDn2NoDxgOrONE0lQ0IkQiJ7GACLcqZUPhoujCVbGFDkjBjQCsh5vEeJ LfA7BhlCn+KXms+Yv2TjouIVY3nd6p1s7sF/aRdETkjVk15Fx/v1mGuC0t65jG3s PLGtaMUzCHUr5CzA8LMW423dEDnveU8VkTLTKTBJjIjv5SvR/uUI/52pcnpN7j82 605Wtxls8vBgUR0aRxa+Fn38+FsBdh2fAjbSdIYX2ZtFI+j/b/ou4W9Y1NCM8rxr 9zBGbw== Received: from mail-qk1-f200.google.com (mail-qk1-f200.google.com [209.85.222.200]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4gqbmnkc10-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Wed, 16 Sep 2026 10:30:38 +0000 (GMT) Received: by mail-qk1-f200.google.com with SMTP id af79cd13be357-936708f129aso835078085a.0 for ; Wed, 16 Sep 2026 03:30:38 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1789554637; x=1790159437; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :content-type:mime-version:subject:date:from:from:to:cc:subject:date :message-id:reply-to:content-type; bh=GN46dMW3MStQFHvocVLrbP88+rGtR199PBAALuRhwHU=; b=d/vUmvpVJAFt9w8anmnXkKWUTPYE1wymokPmvNupDtXQkljok/bzgHFalA3KOFPjL1 1hvSWD+5pKJdpuHgKmkqyRitrYP6+QrpoUftYOO3hIL5A9cWss5aG+aY92JVjJdid3fI WIXXy1V6YUlrB4y9rQSo13p5pZ8pT7R3Ks6LkAHuoaJrpCQDuE76CV/P9ZYz/QFmR5yy ZryMJ9U8wY2R7MRhcXrMjIDC4T2x8VkzXUj9AFdZnGXaCYRby+YMZ57KysER/3ZyLw+n pDdLpClr7frLOu58QudYlQuU63L/HEuRk2aPs00wSbCgw/YfJA6iViU45ZHztvrUmsB2 i1dQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20260707; t=1789554637; x=1790159437; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :content-type:mime-version:subject:date:from:x-gm-gg :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to :content-type; bh=GN46dMW3MStQFHvocVLrbP88+rGtR199PBAALuRhwHU=; b=dmMLZRXJfSUhryMKAgk0QiIJihG4XyB9bJZKqnC9Lmg01hq92mC/tYN9pD9yA/lJRQ UVbZ40s8oxRHRV6SzCMV2M8ZCc/HyO36ctmbrxv+N4KDEdI6vX+0CTqn1i9dQQr8oM0r WgQmCv7imEVjqjxIqtF2tGR2SDcVYB8zEwgs6hXyJMIBt2YdRgMODeec+ueqIsXP1eJi 4hS7TN1O19mjaBPGad9KtMhVov2IhWn5A2BYdr1e0O6KwN4Pe+YAjkg0+YiOu9lkclhf FeAmen52nab/xySUudcn7Sff01v3yj7MaYD4dhVPXQJQkBkF2pn+1VgZvmT0wfLZWv5B xs6w== X-Forwarded-Encrypted: i=1; AKwUvBwZ/ImTVmSfO1swu9HOUvKqEVeo+9/S3hmlyM7CMyUMKxio6zb8sdg10EKrvgjQe5F+CrWg0oblm7wSXX0=@vger.kernel.org X-Gm-Message-State: AFuF++luNrEqBIYSPyBT38zu6xlm8vDUVF6XeNJ0EQ05BTuqNau+XMdj +4RPXXCPIokvjM6MZVMs0IvzIjoFO+62qL7rBv24jeEzltyPn2E7QP9OXrJfur1rsAj9HqSu83k axH4AnueH7VlwR9F7waZnDziEkd5OsTYNhCdqAZucLKj7MjEMnKaLGFgIYvJiMYAtgs8= X-Gm-Gg: AYBFou17P72caMWU5tYtjH8Z+vzg9QCtIxFyl8o2EEO9hRE6cgagTMtWqsTZatHUnRE oyF99/zO3a8a8pQwiVuAdiP+FIeHBHAHr17VuSw7XJCNP+U9ZAXrti4joziy337yK9IcBSrLmpT s9+8xrmWLvUEaUhyX7GUZVESUqzkiXB6C5Z+knOGftAM6baZJtB2pRdDBfK+rc/30MsGM6EK0CB 7JZI9aT7Ca1A6LE40z6P17e2DgE1nu8VaqNqHLHAFnbz75paU/A0wRJlvCn01CpZOnEqT1GCwI3 qjmVEUEjDZSYh2XhjadbxxXcp0V8DzTp75wC8aXscoixsd3SuK/dBjB/4IuIIpIcDvQ5f3p86ff iRVVAf1E= X-Received: by 2002:a05:620a:2618:b0:939:f7e4:4f8a with SMTP id af79cd13be357-93bb76bba90mr333783885a.5.1789554637130; Wed, 16 Sep 2026 03:30:37 -0700 (PDT) X-Received: by 2002:a05:620a:2618:b0:939:f7e4:4f8a with SMTP id af79cd13be357-93bb76bba90mr333776585a.5.1789554636547; Wed, 16 Sep 2026 03:30:36 -0700 (PDT) Received: from [127.0.1.1] ([86.121.170.232]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-49e83dbb0c1sm71633805e9.14.2026.09.16.03.30.33 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 16 Sep 2026 03:30:33 -0700 (PDT) From: Abel Vesa Date: Wed, 16 Sep 2026 13:28:54 +0300 Subject: [PATCH 38/48] clk: qcom: gpucc-sc8280xp: Use common probe handling for always-on clocks Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20260916-clk-qcom-rework-legacy-always-on-clocks-v1-38-25a24e50f82a@oss.qualcomm.com> References: <20260916-clk-qcom-rework-legacy-always-on-clocks-v1-0-25a24e50f82a@oss.qualcomm.com> In-Reply-To: <20260916-clk-qcom-rework-legacy-always-on-clocks-v1-0-25a24e50f82a@oss.qualcomm.com> To: Bjorn Andersson , Abel Vesa , Stephen Boyd , Brian Masney , Jerome Brunet Cc: linux-arm-msm@vger.kernel.org, linux-clk@vger.kernel.org, linux-kernel@vger.kernel.org, Abel Vesa X-Mailer: b4 0.16-dev-0e65f X-Developer-Signature: v=1; a=openpgp-sha256; l=1810; i=abel.vesa@oss.qualcomm.com; h=from:subject:message-id; bh=U+9VQRVM4S7Z8VJMwjV5ugP/YnxuxuAFNy2XnC0w9rA=; b=owEBbQKS/ZANAwAKARtfRMkAlRVWAcsmYgBqqm9vNtZ1AAAaxGDuuEJBhH2VfyTKPfvGCdG39 L6eSxuqyMqJAjMEAAEKAB0WIQRO8+4RTnqPKsqn0bgbX0TJAJUVVgUCaqpvbwAKCRAbX0TJAJUV VqucEACCd9UTuZo6IC2p8zfCsgUYsm6g/49ObJnDkUBIIltUy7btBOAu/DBjaFkjQXTiLl06L5R AK5qdzCX7vuAXFERVajKMjGbZjBlUNsOf3LgE1IZ2yqYbLMh2IiXspWKeEOHoAAu2Grdi2MCf1J DQErmraCBnmR2gfZliuOeQUrLm3GsT4WlA22Ny/SpCrNRxYHukEb1FqUAsinNhjBeYX2Z9O2sxJ HbjsuC2D7Jo0hXfJQ8OnrKy8SrdtgWdG7TK2uGkZ28vMczauC8jca6egqhWEuP43SgfrWyrpqHH ik3X2+pAnvmYm57wl5pPODYuUJbGtLvkoHpt/4Og05WGMF/MW4u9GOXhxeiRus3QkDdfuCTr7Xz 558A2uZ20rSRu6KroTwsGRScxqgxKaa1Knvg2u+PXzENUixAiD5VH9FM7ijoeI72/umaJ36Xnug GQ1QXOnEKFbPUxGWyQoNfPd4bm51oYNb7nDQl60wPmOisb2qGfeg7IgcAdWZQv065rXFYa2sf4e WxcDpI6DY+wsyKmDQRcCHMxTCFQdP4HI7G74YAHujhl28Gc84dZshqkmZHoxjh1w9bvN3kjngyg xi0PXu8QpxjZLMRngEjEqLcufP/TZRXq5KKwrzoaGtxa2F3ago73qEQ+TC/KjYrnWJ4pC5ZbWWT 8FB6lXm7wdvfuAg== X-Developer-Key: i=abel.vesa@oss.qualcomm.com; a=openpgp; fpr=6AFF162D57F4223A8770EF5AF7BF214136F41FAE X-Authority-Analysis: v=2.4 cv=POyaavqC c=1 sm=1 tr=0 ts=6aaa6fce cx=c_pps a=hnmNkyzTK/kJ09Xio7VxxA==:117 a=po8fGBi+ks8MzcVQGuqtFQ==:17 a=IkcTkHD0fZMA:10 a=VdqzKS8jKosA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=_K5XuSEh1TEqbUxoQ0s3:22 a=EUspDBNiAAAA:8 a=tHUDbLQnBSC955iDWYgA:9 a=QEXdDO2ut3YA:10 a=PEH46H7Ffwr30OY-TuGO:22 X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwOTE2MDEzNyBTYWx0ZWRfX8WRkhj+hg6nn IcuULTKHvkedQjZMDVGPTJfSZUD+yB1JX8qcRB7PAgushyN2A3MWMydJe6j28nGgrc6vVqgNuee 62lEPjKQX48b561Sz+6cTXENj3sAT/AWor0+28CNSamkl5VPC0dkF1j4VGFrqhR/SKKrI2aw0og 6hFGDeHa908qzfrKsajSr0oA6I2wfhzQNn9IUsZap22b43vKGdDTwce4BbZPoA2seoRDFUMFFjK Fh51eHfyglou2/34zUJw05mNw7LXemk6zXBkiLQCKedhypRNf19NwFBUKaMVyU7f5MaaY0s9fm3 hh2+y6n8FFYMkbo8sBWIVo+l4MWbDPSr8zb3cQo1bRQo8719YojU1P1JJhC/t0UU7uhc8aj70Gc +HgHgN6SY21LdIQ6XiswLTquFDx0Phzf/Oy7W+LnmfAhHONGOjfFRIdYD2qlLIsQs2dQ/Vr3Cxh DphRFiceRUq3XbLadxw== X-Proofpoint-GUID: GC5vJ6EpqgoDThjCmRp-HGl41oItSAIG X-Proofpoint-Spam-Info: AW1haW4tMjYwOTE2MDEzNyBTYWx0ZWRfX6wCRW+lGX4tu DlNgt7XJ/WeSw3CX4xYTdq6lJrk9t0MBl2EFUt93u5gbOrNvwzxXdz/bBDow+GFniW4fSNnAISm pNS7OPlZQp4pmQPKg1g4ptBgHgfgFTA= X-Proofpoint-ORIG-GUID: GC5vJ6EpqgoDThjCmRp-HGl41oItSAIG X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1176,Hydra:6.1.134,FMLib:17.12.100.49 definitions=2026-09-15_05,2026-09-15_02,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 priorityscore=1501 adultscore=0 bulkscore=0 clxscore=1015 phishscore=0 suspectscore=0 impostorscore=0 spamscore=0 lowpriorityscore=0 malwarescore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2609040000 definitions=main-2609160137 Describe the always-on branches in a critical_cbcrs array and reference it through qcom_cc_driver_data. Let qcom_cc_really_probe() enable these branches instead of programming them directly in the driver's probe. Assisted-by: LLM Signed-off-by: Abel Vesa Reviewed-by: Konrad Dybcio --- drivers/clk/qcom/gpucc-sc8280xp.c | 15 +++++++++++---- 1 file changed, 11 insertions(+), 4 deletions(-) diff --git a/drivers/clk/qcom/gpucc-sc8280xp.c b/drivers/clk/qcom/gpucc-sc8= 280xp.c index 5dd90b854afb..2ccc083a4f98 100644 --- a/drivers/clk/qcom/gpucc-sc8280xp.c +++ b/drivers/clk/qcom/gpucc-sc8280xp.c @@ -415,7 +415,18 @@ static const struct regmap_config gpu_cc_sc8280xp_regm= ap_config =3D { .fast_io =3D true, }; =20 +static const u32 gpu_cc_sc8280xp_critical_cbcrs[] =3D { + 0x1170, /* GPU_CC_CB_CLK */ + 0x109c, /* GPU_CC_CXO_CLK */ +}; + +static const struct qcom_cc_driver_data gpu_cc_sc8280xp_driver_data =3D { + .clk_cbcrs =3D gpu_cc_sc8280xp_critical_cbcrs, + .num_clk_cbcrs =3D ARRAY_SIZE(gpu_cc_sc8280xp_critical_cbcrs), +}; + static const struct qcom_cc_desc gpu_cc_sc8280xp_desc =3D { + .driver_data =3D &gpu_cc_sc8280xp_driver_data, .config =3D &gpu_cc_sc8280xp_regmap_config, .clks =3D gpu_cc_sc8280xp_clocks, .num_clks =3D ARRAY_SIZE(gpu_cc_sc8280xp_clocks), @@ -445,10 +456,6 @@ static int gpu_cc_sc8280xp_probe(struct platform_devic= e *pdev) clk_lucid_pll_configure(&gpu_cc_pll0, regmap, &gpu_cc_pll0_config); clk_lucid_pll_configure(&gpu_cc_pll1, regmap, &gpu_cc_pll1_config); =20 - /* Keep some clocks always-on */ - qcom_branch_set_clk_en(regmap, 0x1170); /* GPU_CC_CB_CLK */ - qcom_branch_set_clk_en(regmap, 0x109c); /* GPU_CC_CXO_CLK */ - ret =3D qcom_cc_really_probe(&pdev->dev, &gpu_cc_sc8280xp_desc, regmap); pm_runtime_put(&pdev->dev); =20 --=20 2.54.0 From nobody Fri Sep 25 05:31:34 2026 Received: from mx0a-0031df01.pphosted.com (mx0a-0031df01.pphosted.com [205.220.168.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 36F6F4EBAF4 for ; Wed, 16 Sep 2026 10:30:43 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.168.131 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1789554663; cv=none; b=mYSV5l8c3aAR6NJ7KpAKn8WuLO94QbsJt/JI+B24733Bd0gLFZxbLoo0/5erw5Bae5tuUOal623JA74w967zBQx6B3pPE7VXSLvtfiOMeqa0lb1n6n/pVn3CggAp/IQfUDurJHPwnEmStRpwVYTADZeMPQOvo5T/12mSkcRxgD0= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1789554663; c=relaxed/simple; bh=YjM7ZKJiyjuCW7sDpZ8xDtZxtp1hd2L+vcbDmTf29FE=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=M61p9rSvtoiLpYuJTaGlcSrBxWViMbjEeyaLpqh0QtXdZklDOJ9vhDUcF2BhKrUX0ErYjVXW4OO33GHC0EdiJhFpID4oaXWHgE+apuNlZI9mr/SGpEceKq2kTlCYdRwUC5jstw+YCd7+R0K7jamMclMfQhyn3zEKtTHgSfhqjRU= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=Z94fFudr; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=KVb3xYyi; arc=none smtp.client-ip=205.220.168.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="Z94fFudr"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="KVb3xYyi" Received: from pps.filterd (m0279864.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 68G92njw978261 for ; Wed, 16 Sep 2026 10:30:40 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= 6qBjpCKiA2EPrjgUsDuc3+hQCoJfL0LBOHGblx+hp5A=; b=Z94fFudrWKyXpDaZ D9dhDBRv5uWLaahlGrLxrg5C36val7iXyaDAv/BDf30lkzgiM2G2enuF5yQK/q9X wH8jftJO5kf63uIcX3UJNtgyi04r8XA+BWLJ/GGDEHLjOjOMbCW5XFYnlWIBptn2 RmkLqs9x6FZ7kG8d0wl1Q4pZxrZ8uC5KH2UZQkVhrL2MwZPMxTVPaEPgC4+1mf0W WYL+E66Le+0fKRdoHa+CkYWVezE824vqAbcmuvKUHcckGpJYj9UleVcSt/rK8y1g eBCMpI4XzeNTJN13sHXDpBG3HXFMTFUPY5iJXuxJ0/m2mKs9nJfgx4KBrRvwzI9P oC4IIw== Received: from mail-qk1-f197.google.com (mail-qk1-f197.google.com [209.85.222.197]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4gqqp3rfwm-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Wed, 16 Sep 2026 10:30:40 +0000 (GMT) Received: by mail-qk1-f197.google.com with SMTP id af79cd13be357-93a1b824e84so686207885a.2 for ; Wed, 16 Sep 2026 03:30:40 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1789554639; x=1790159439; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :content-type:mime-version:subject:date:from:from:to:cc:subject:date :message-id:reply-to:content-type; bh=6qBjpCKiA2EPrjgUsDuc3+hQCoJfL0LBOHGblx+hp5A=; b=KVb3xYyiOKTgvcV0kNPUFHFuwH2CSduMtuxTshe+inUx5o/QfCsxuruUjLtn1KLLtQ 5q4FA8rFJoZNi1ch+S0SnnxFavWDQbiQrdHPOx18v2P3miHvz1L9hEQCfuOo2rdC/C4I VNZoT1cyWFHKyx+FIxCeVA9/mQ7uK4SOI+nXEGhXNp+9ViX01WWbgfgOlJR0PMDbkaYj HA1r5XMKGScEIB/FIwittY4uHlrbvFzC53oz6rLY1LY9f9TlVpsrVq9MbmrhHAq2dK3y EoOSae0Rln3p08U9xWbcs6RMi5s2xq44No8QPY1Ngh+BtmCOYTHTnARtnCClrbuv67KQ HmGQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20260707; t=1789554639; x=1790159439; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :content-type:mime-version:subject:date:from:x-gm-gg :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to :content-type; bh=6qBjpCKiA2EPrjgUsDuc3+hQCoJfL0LBOHGblx+hp5A=; b=EJb8OoBVqE76dVmhMh9PBtLwKhi4iW7Mw7w6ppNw3sLjeYYNtSWXHmDLQwERZEkBDo G7q7YcgPxXH5At9xXbAHC1hEsmqHkEXq/ZXUAiOhRtUEzf1mZ8/lMM4ssKXzM/M8tan1 PwxT1eqNMBfGry8so71GMJSnrtlkcjTKyYQ/VCLA2Cq40aCNgFr/6qdue1zcE4OrnIQA +BcPeUFuDmDTH/O2CfU1/PElgGjHfSZeSXqBCMYajW4gy4S9/ft9pTxqUcZ12mQhHQj1 E4/vx6KfrNwqMw691ORs/Xjbg8J6b/X7AexI10kPOaYcgxaqpy+9xgGjWDBGyN6MPs5H UeiA== X-Forwarded-Encrypted: i=1; AKwUvByEO16tSGtQoAUeyDUyDTb9p3hL78kNdY43OBrgxvBAkEmeRBXdOEBjYEHCtoN64CF65ZIjhZzK1tYcQZo=@vger.kernel.org X-Gm-Message-State: AFuF++niY2KSmKfPK+l2MhwYhrBIeEhulGPBhDBQDKH/JxXYUxIx2M16 jHoLf/T+5lrgmGzrpVn+8SQUAc1CiE3Rd8O7sLkayshPcouZnow6qzW6QMT9sQQ4NVOzWV3nXcM CHlIO2xQLNLTlo/XVUQTpr8PN2lU/pYfwLD4j37OXdrkA7G7SctVSce1rSptazep51mI= X-Gm-Gg: AYBFou2odcq0DFcVC5UXX9eWDR2aPtuEEyqx+OCHq+sxV/X8x48D8NGmZhacE6bgtm9 uKfPmm6R1S3OSTDAYDENwg9ytSgydTPe9VHJiyFdMmvF/5O1DcKY0zA+jj5I2SFwUgqsmheIi+t y80z719dlUC4SvtXkx0dJPAk3BSMVGc3THwBXQWxQAGm5X4PjVnllWzL4V2gGuvNuNNTBay8Do0 FjYSWuF06iIe5MCBzh5RPj8IC+BA2ohk4zG4euDfwhNUqtl6zzg/So7r0q0m5xJIuxCZbBZzfuI a1KYBhCrp1K14LczFyIUMAgUXZVvdy6nXKYj9v9rvuqFVrSv0rNelxRh5e1s8WJKFFxqlq9i1qv q9cJ0msg= X-Received: by 2002:a05:620a:1707:b0:939:d78c:eb0c with SMTP id af79cd13be357-93bb770858emr308915285a.11.1789554639226; Wed, 16 Sep 2026 03:30:39 -0700 (PDT) X-Received: by 2002:a05:620a:1707:b0:939:d78c:eb0c with SMTP id af79cd13be357-93bb770858emr308906885a.11.1789554638677; Wed, 16 Sep 2026 03:30:38 -0700 (PDT) Received: from [127.0.1.1] ([86.121.170.232]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-49e83dbb0c1sm71633805e9.14.2026.09.16.03.30.36 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 16 Sep 2026 03:30:37 -0700 (PDT) From: Abel Vesa Date: Wed, 16 Sep 2026 13:28:55 +0300 Subject: [PATCH 39/48] clk: qcom: gpucc-sm4450: Use common probe handling for always-on clocks Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20260916-clk-qcom-rework-legacy-always-on-clocks-v1-39-25a24e50f82a@oss.qualcomm.com> References: <20260916-clk-qcom-rework-legacy-always-on-clocks-v1-0-25a24e50f82a@oss.qualcomm.com> In-Reply-To: <20260916-clk-qcom-rework-legacy-always-on-clocks-v1-0-25a24e50f82a@oss.qualcomm.com> To: Bjorn Andersson , Abel Vesa , Stephen Boyd , Brian Masney , Jerome Brunet Cc: linux-arm-msm@vger.kernel.org, linux-clk@vger.kernel.org, linux-kernel@vger.kernel.org, Abel Vesa X-Mailer: b4 0.16-dev-0e65f X-Developer-Signature: v=1; a=openpgp-sha256; l=1873; i=abel.vesa@oss.qualcomm.com; h=from:subject:message-id; bh=YjM7ZKJiyjuCW7sDpZ8xDtZxtp1hd2L+vcbDmTf29FE=; b=owEBbQKS/ZANAwAKARtfRMkAlRVWAcsmYgBqqm9wkVAKoVHYZmpq3t/wGp5aKjqOSziJlLtgW 7zIG2nwlqiJAjMEAAEKAB0WIQRO8+4RTnqPKsqn0bgbX0TJAJUVVgUCaqpvcAAKCRAbX0TJAJUV VuTkD/9qaxtejPTXFpC/YJPjkmfUczzLIcU7eSMMB5DfqAYafaGqIxjlZOVvykYhYEqhGuVVcn3 IpFd2IqgL+AJ1F1SdYTDgiCJVWzDNksPnmH9E0tl8wqsmy3Vk0p1tcfm9zsd5EoHYgtXs5QYxAf d0HkyvVh68tBNZGqR7kj+f+Wcw1ZFfc4wQg88BfBk9Wai1gEs6P6SMp0lpeW/tz6DGcaBC76Ngp XpjMtB90afbUG1cgPpCXD7nlmtSDMGsMKpdf02XuAQ9YPapgOTHCEE8rwL4BAIxehtNWu4+hveq Q4ePhp2E/QMd7kj6dP+T/mV9YScz7Pq5EGGt/OmOug3xpVcuB1VSQLcK0niX/TD7/n+3WcIztdB Gy4O6MR/IbduJq3RC6eGenz68svI/oPqMNcpKKZ/AC86qglaQmNh3rW9w69vH0nHPL7A0En83Sx t562oSv1FN0QJm3TM8DEHeJ10LJXhnMOXMCfVf6owTpUrfTOXM2tsiRU/Cz5vUAajZbBE/MWGOW 2LJUR+C5wwZjuIIRzlHdF8mcBkR6lOcbtriLnD65L/TgK1WkM+fp4GfYvqd3vESHA9LyiylOFBC dxLhCNOYYbcklRkcjRhuq0KG9/d1ohAZMfzHEjw2z1XYadpx5Wbsp9dmDZ49LDBgu5vqLZnhTll tMkG16A51X64Zcw== X-Developer-Key: i=abel.vesa@oss.qualcomm.com; a=openpgp; fpr=6AFF162D57F4223A8770EF5AF7BF214136F41FAE X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwOTE2MDEzNyBTYWx0ZWRfX+OVBG6IPc1X5 Rgyd3FKpLanV49OL25moR65jbmQD13C12xUga6vHAd2Q7bkpDMQ4F8VvMpADK/luICXP1TqjYN/ HVOGWf1k3v+5jNXPwym1PCB+y9o6/NgbCu0E0X0t7qOtnROp5LlqBlkW92Zwi4NIhB8CRAqOLcM jIfDZgFfCfHxxszrdSrOox/GLQiUABgDIRdJyT8qNwx+LQ6Dzo8sBXDgYOpRvjLwvk4uvwuTcd/ fV+smmk7X1s2C1BVraFT3iTG0D47vynjFh0qIHfk0kDfZITsu14w+9N3wjHIR1CgAnFuPsJV+91 DLIBMjiwph0tWt9gbI+ckf8fhFBZQeepURHsgoooigmdq4IB8T3xJV/DAmaKP3m87L6JOZazyRb Jd9OIyn0YhsCU86lvKgYc+WInB1dvZDH0i9txjBAve29npCshXcYrGQxsTk0mhcsDoQ4dgKoAq3 vCpwPElsF9tuBYo6amA== X-Proofpoint-GUID: lMWdeHRNt6AQqdC-XIdtGiLi5p9x7RNV X-Proofpoint-Spam-Info: AW1haW4tMjYwOTE2MDEzNyBTYWx0ZWRfX5wJw+oCRq+N6 ASpMVKpEFndMtObH/VlXuWdqSuAker1lXRit8R/US4LFrTNwooimu2ATDPrNlRhL9zb7HYsnHOU 3O3gGMmQAoc5Puw+3U+COqsbM2azszE= X-Proofpoint-ORIG-GUID: lMWdeHRNt6AQqdC-XIdtGiLi5p9x7RNV X-Authority-Analysis: v=2.4 cv=F/DC5ahN c=1 sm=1 tr=0 ts=6aaa6fd0 cx=c_pps a=50t2pK5VMbmlHzFWWp8p/g==:117 a=po8fGBi+ks8MzcVQGuqtFQ==:17 a=IkcTkHD0fZMA:10 a=VdqzKS8jKosA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=DJpcGTmdVt4CTyJn9g5Z:22 a=EUspDBNiAAAA:8 a=ED4nYY0oUM9iKWp7kXQA:9 a=QEXdDO2ut3YA:10 a=IoWCM6iH3mJn3m4BftBB:22 X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1176,Hydra:6.1.134,FMLib:17.12.100.49 definitions=2026-09-15_05,2026-09-15_02,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 priorityscore=1501 malwarescore=0 adultscore=0 bulkscore=0 clxscore=1015 spamscore=0 phishscore=0 impostorscore=0 suspectscore=0 lowpriorityscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2609040000 definitions=main-2609160137 Describe the always-on branches in a critical_cbcrs array and reference it through qcom_cc_driver_data. Let qcom_cc_really_probe() enable these branches instead of programming them directly in the driver's probe. Assisted-by: LLM Signed-off-by: Abel Vesa Reviewed-by: Konrad Dybcio --- drivers/clk/qcom/gpucc-sm4450.c | 17 ++++++++++++----- 1 file changed, 12 insertions(+), 5 deletions(-) diff --git a/drivers/clk/qcom/gpucc-sm4450.c b/drivers/clk/qcom/gpucc-sm445= 0.c index 808b1eaa59d1..bd0f3fc2b726 100644 --- a/drivers/clk/qcom/gpucc-sm4450.c +++ b/drivers/clk/qcom/gpucc-sm4450.c @@ -754,7 +754,19 @@ static const struct regmap_config gpu_cc_sm4450_regmap= _config =3D { .fast_io =3D true, }; =20 +static const u32 gpu_cc_sm4450_critical_cbcrs[] =3D { + 0x93a4, /* GPU_CC_CB_CLK */ + 0x9004, /* GPU_CC_CXO_AON_CLK */ + 0x900c, /* GPU_CC_DEMET_CLK */ +}; + +static const struct qcom_cc_driver_data gpu_cc_sm4450_driver_data =3D { + .clk_cbcrs =3D gpu_cc_sm4450_critical_cbcrs, + .num_clk_cbcrs =3D ARRAY_SIZE(gpu_cc_sm4450_critical_cbcrs), +}; + static const struct qcom_cc_desc gpu_cc_sm4450_desc =3D { + .driver_data =3D &gpu_cc_sm4450_driver_data, .config =3D &gpu_cc_sm4450_regmap_config, .clks =3D gpu_cc_sm4450_clocks, .num_clks =3D ARRAY_SIZE(gpu_cc_sm4450_clocks), @@ -781,11 +793,6 @@ static int gpu_cc_sm4450_probe(struct platform_device = *pdev) clk_lucid_evo_pll_configure(&gpu_cc_pll0, regmap, &gpu_cc_pll0_config); clk_lucid_evo_pll_configure(&gpu_cc_pll1, regmap, &gpu_cc_pll1_config); =20 - /* Keep some clocks always enabled */ - qcom_branch_set_clk_en(regmap, 0x93a4); /* GPU_CC_CB_CLK */ - qcom_branch_set_clk_en(regmap, 0x9004); /* GPU_CC_CXO_AON_CLK */ - qcom_branch_set_clk_en(regmap, 0x900c); /* GPU_CC_DEMET_CLK */ - return qcom_cc_really_probe(&pdev->dev, &gpu_cc_sm4450_desc, regmap); } =20 --=20 2.54.0 From nobody Fri Sep 25 05:31:34 2026 Received: from mx0a-0031df01.pphosted.com (mx0a-0031df01.pphosted.com [205.220.168.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 42F574FB9CE for ; Wed, 16 Sep 2026 10:30:46 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.168.131 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1789554652; cv=none; b=RnkE9mZcHW0IzmiSKLqbKM60Pr8ZbsgdRd3l4I14HroVg4nfj4W1nBl50xF6fG+nl0gSQFxvE8RT1hbloO3omt1a8kkVPPCRBIGkfklG/ni/sWthz7ktz41RvUuJovfu5LjutqeyzmlMmM7Jt3mtle7YPU5PktiE8NnD3GPamps= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1789554652; c=relaxed/simple; bh=pSSoS2tEcsFgF1U0zVrrCZYyIxjblpEIIYMk3CVK4Qg=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=WnXzI6z79n2/EoDGr0Z3iYWbj7g9U9EzKeChzGlP1U4I200CbCcxImKj7hX+vJB/6EIt/Oz4sAmKu3wKrs6xn+GmHhkMxbsHcjCmZ0fssLemV+Oh8LN0MqOFRuoq0CUIgm8KcgZUg4c5P7I71MT4hBWB0aP2KOFzTlC/XvIyWlA= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=BW5CJSpN; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=Ko1tR8Cl; arc=none smtp.client-ip=205.220.168.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="BW5CJSpN"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="Ko1tR8Cl" Received: from pps.filterd (m0279864.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 68G92q2C978379 for ; Wed, 16 Sep 2026 10:30:43 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= 7OZzacR1OHnJn5NTaxUrew9BnSpVY5ERc2Ll3Di9WLo=; b=BW5CJSpNZ40xfzMr +TAdrrEv04tSPUVf+qBxXTsOugyEuxGcgMHxWw8wWajsCEoTl1lFZhF0it9yoTeZ onZGZyvelsNH9koEbIgeL1BHFVjk685kECuSrZ+qyEyRUoAVQoev8MuF7wEnYTci 5sAWbzHatL5fBKSFjU4SHBND27ODQuSyKcBJjV2BWU5zhLZjUwJ5+C0bvOQR/bs3 p/ZJ6lBSoXKgQIL1+QlS867u0+oLNbR7m60kD0wOR/6vwBWAUJG4e0GGU+0NyoeV mdUmqtcS0Yx6gtJRIBFDNf1HELzc1b90D7NpohPV4mnvMd/SqzYpex6Fo8y90ROJ x2PxDw== Received: from mail-qk1-f200.google.com (mail-qk1-f200.google.com [209.85.222.200]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4gqqp3rfwu-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Wed, 16 Sep 2026 10:30:42 +0000 (GMT) Received: by mail-qk1-f200.google.com with SMTP id af79cd13be357-936aa34873bso968148285a.3 for ; Wed, 16 Sep 2026 03:30:42 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1789554641; x=1790159441; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :content-type:mime-version:subject:date:from:from:to:cc:subject:date :message-id:reply-to:content-type; bh=7OZzacR1OHnJn5NTaxUrew9BnSpVY5ERc2Ll3Di9WLo=; b=Ko1tR8Clp7OxQ1K0F8W9lw6GQUgO+5rYbKeQmO57iO6qcfAbMneeMfCywk6k6glWyz 35DiQNU42yZE4qyrwGhnA7xZwlHeA2PddD1Gsl2AGkGCxm8oM0WI/UqaZYq5DpLbCPd4 f8XLnzJfVSPk7ddZrOe7ROXH70+twHTj5OYSbuxmUxM8CrbYd/duwGsgzAE1swrgTjGh XbB8BsVKKwOXcca5nlmHAD0PbSeUnYF/nAm8I3joguTnrdxFpdpHvpXKid2xeaecva8S cUJRGf6YBaIFnHGimXOatRMONJN70D2fulbstZqKkHiSd12un2cpHzPJeMHohJD6uBsm Udrw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20260707; t=1789554641; x=1790159441; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :content-type:mime-version:subject:date:from:x-gm-gg :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to :content-type; bh=7OZzacR1OHnJn5NTaxUrew9BnSpVY5ERc2Ll3Di9WLo=; b=TI2KelM0Lks+3bWT0asoEdG9bRCRHXZFyAr7f4xmN9PvzZ4BmV3Fn4OGLP50Fkhvl7 CqFhRwaJtAl/HujEAuHD5my3llz3Qlt9qgGnuTyP5CVsX2TO/i0y28Uy/CxYVHBTvlGE cOjqXmNlPdmaKq1hqE8StkTICqKlGWgk0LfuugdbPADabxOEOpcTuz7CHsItWEkBWZQV KGH8O/3nnV9Cs69Ty8bw+hUjPX5brB034Gh0PBTKLFq5o1nN2/u1UqhsU0cAPsMRn6Ky s98+eHSxfjCW97Ohw5xqmHXtfwxrCkhnhfFegQfc48rWc4YT9Zmtmjw8Fp+m56fyjEED CpmA== X-Forwarded-Encrypted: i=1; AKwUvBwC9P8Zjyz5upJY2bKarSiA1sE0aYDgGRDP7jPVBlHPQuPu5jdrFIluNiaFYCWfb86uSl/VIEIrs4Mc5sM=@vger.kernel.org X-Gm-Message-State: AFuF++mPd8w5S4+xwXAaqONJVQoSLAmx/PSzRPVahNAg1Rwc69xDTNfN k95QzI6eba6lfMeEk99rQX6QtXAimfpjAWMRiMus6qFCZITsiB0hnqfAkCB2qv5ijWVLokBlohB l6EwfEKNxn5iDXPUg7HSyF7G8C3iWMn7O+ZmOIsTe7Bo/3Ef1dcv0BSqDxQQLwPpn12A= X-Gm-Gg: AYBFou2vUr9GpN014ZML72CjBiTRvPZy1RQ8Qrnrqe5Gyo/nNV81VDv9SAWHJSB0vE+ /bDfuverSBTVT+bmR66MLT25QANcyqG/tyXFd3k+1kIVNdjoHzxVY0XcvMGpXhS69rRtEfE6dET EMRYXkfWcjq9ZMaO1E8oLmaOTYNgjooEJpan55i/xfQaqQ3qWfoHA9uwfWa84mmkv/sWIhlKVXt IVWSKBViER7NpOEwFa3lrwQ5xZCv8d1Qmf8ARhxLoI3e+mXW2SzgeVHP1RUWJ9MAqoraG/LpBAO Pb4tUiVDoaxfpx/omgtLSSp/gQz9PZveVCfhm39scddRe3bGNHE9XYZ3X7stdG2cwEzTOsexE6s /FcRwkAQ= X-Received: by 2002:a05:620a:17a3:b0:939:9f51:29a0 with SMTP id af79cd13be357-93bb79b3ea5mr312358985a.50.1789554641340; Wed, 16 Sep 2026 03:30:41 -0700 (PDT) X-Received: by 2002:a05:620a:17a3:b0:939:9f51:29a0 with SMTP id af79cd13be357-93bb79b3ea5mr312352185a.50.1789554640783; Wed, 16 Sep 2026 03:30:40 -0700 (PDT) Received: from [127.0.1.1] ([86.121.170.232]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-49e83dbb0c1sm71633805e9.14.2026.09.16.03.30.38 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 16 Sep 2026 03:30:39 -0700 (PDT) From: Abel Vesa Date: Wed, 16 Sep 2026 13:28:56 +0300 Subject: [PATCH 40/48] clk: qcom: gpucc-sm8550: Use common probe handling for always-on clocks Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20260916-clk-qcom-rework-legacy-always-on-clocks-v1-40-25a24e50f82a@oss.qualcomm.com> References: <20260916-clk-qcom-rework-legacy-always-on-clocks-v1-0-25a24e50f82a@oss.qualcomm.com> In-Reply-To: <20260916-clk-qcom-rework-legacy-always-on-clocks-v1-0-25a24e50f82a@oss.qualcomm.com> To: Bjorn Andersson , Abel Vesa , Stephen Boyd , Brian Masney , Jerome Brunet Cc: linux-arm-msm@vger.kernel.org, linux-clk@vger.kernel.org, linux-kernel@vger.kernel.org, Abel Vesa X-Mailer: b4 0.16-dev-0e65f X-Developer-Signature: v=1; a=openpgp-sha256; l=1772; i=abel.vesa@oss.qualcomm.com; h=from:subject:message-id; bh=pSSoS2tEcsFgF1U0zVrrCZYyIxjblpEIIYMk3CVK4Qg=; b=owEBbQKS/ZANAwAKARtfRMkAlRVWAcsmYgBqqm9xOwspMtgT6lEUuxHQmYoRhEUCTa8h0wj/+ 11o2LdcbVeJAjMEAAEKAB0WIQRO8+4RTnqPKsqn0bgbX0TJAJUVVgUCaqpvcQAKCRAbX0TJAJUV VjrqD/wP6SMAUvn1365MCMj6Bs+lX5e2qf82AjrgftnzO7eQFFIErcaKrkOnCADXe9YuXMwhkDI T/JWeRWOsubXhBhY9UgM3xDgMuG9pX5cDjEsqisByRXrtPYgDlex3oM1wcSGkvW/BXCPiAyRrmu HtOUiWPRlEWLj36Vyvxkorg6fnFZiGOrLNjBx63IOcRHyCqxlEi6iFhNZ1duwiFZqTtMl9WdneF THLdJvpIlu0Bip4n6H5CKhSzxHodip0TLoR8nNzgnWJcH/aCwA24GNUtNkU+nIcThgZKA0qJSJc xrvUP5tvZSbuvJpNU1Ml4HHieO6vTw6w9UUdkC/JBpxLTx/HeJ3q19F5dC069U+hPOpcon+LDbK qRwFTauaphDSipG9eRfHrXRrgJLPobbSXjwGeuzudaaGZ7AzTbQ+KTlUJW8Fhhh4FzzH+Wgf1h0 y9t/HlWmRrEjQ66W4NVu20G3qH8a39FLi8zgfqVnLwJeeKCSHTocwzldtNnCxXsQy/GfJHlF5/i tW1UEQJAHn89X/ipXpRYF3c3QA68hZvKULVWcJOlIIQD4XvCb/+UyVnriuhkhkhH8znERO43+Pj +1gdi3x2E8HIx4Eg/yFH4bP5ihrAqFKij7J7R9/50S3rAOHUUXd2hZ/QFiq3feV033cHfJNcfgH yQMn1qNKMtFnLSg== X-Developer-Key: i=abel.vesa@oss.qualcomm.com; a=openpgp; fpr=6AFF162D57F4223A8770EF5AF7BF214136F41FAE X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwOTE2MDEzNyBTYWx0ZWRfXy4iVlDQwVtBU MzcunE27ibicvT9skZfzm18LASnTpGun0vXYqMTYjUYwo4A2zvizFv2WKkZFuaUY+PWE8RiW3OQ 6OCx6bFlRzYUfO8W8KUu3ainOMPsvjKpXBO1p/KZjNv2nWWu3K0mBg7qtuGr4aT4KjBbUi8oq/K BC+sOjVVbWrUBQloMCALuTSU94YQmRKs8cnt2aIfCT1FZhkBXSFqZVHZGh/lM++N6rtWwuxK1Xd m9YWPLGKWpWKZz7SBZup1esLw/XNPdk1L0u81oQkkT05+ixp3NWFrtVsqO1J+lhYcvqqKeiocep 82SjSJblYWhGy15+awPBic6z3wuZF3tQA3U0cjoHFylpoBCkJ7F2dAqlNFFQgFLFj9mPrUU8Y/3 7VdfOy85Nc8xzMn8xWgOTSlVpTJllSEw9LCmRbkgS5CdXBdO7B0lEc5/NbFmBhg4GcH+kpnbF4g KHX+Xch30HGq5sumyUw== X-Proofpoint-GUID: RYt1ae5mDkkICvH3Bee0iZMFJ1Au8NMu X-Proofpoint-Spam-Info: AW1haW4tMjYwOTE2MDEzNyBTYWx0ZWRfXxKSmD1S8vXrX Zil1ct2DzvkepLGL/2GH8JZJHIT9ZQXLnKhJ003DWgEcNvB8H2sRBROax/Koj3zlYq7uHpfWNEa UI/eBroIuN/UcO3A634qF7u4Hz8PX8c= X-Proofpoint-ORIG-GUID: RYt1ae5mDkkICvH3Bee0iZMFJ1Au8NMu X-Authority-Analysis: v=2.4 cv=F/DC5ahN c=1 sm=1 tr=0 ts=6aaa6fd2 cx=c_pps a=hnmNkyzTK/kJ09Xio7VxxA==:117 a=po8fGBi+ks8MzcVQGuqtFQ==:17 a=IkcTkHD0fZMA:10 a=VdqzKS8jKosA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=DJpcGTmdVt4CTyJn9g5Z:22 a=EUspDBNiAAAA:8 a=ED4nYY0oUM9iKWp7kXQA:9 a=QEXdDO2ut3YA:10 a=PEH46H7Ffwr30OY-TuGO:22 X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1176,Hydra:6.1.134,FMLib:17.12.100.49 definitions=2026-09-15_05,2026-09-15_02,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 priorityscore=1501 malwarescore=0 adultscore=0 bulkscore=0 clxscore=1015 spamscore=0 phishscore=0 impostorscore=0 suspectscore=0 lowpriorityscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2609040000 definitions=main-2609160137 Describe the always-on branches in a critical_cbcrs array and reference it through qcom_cc_driver_data. Let qcom_cc_really_probe() enable these branches instead of programming them directly in the driver's probe. Assisted-by: LLM Signed-off-by: Abel Vesa Reviewed-by: Konrad Dybcio --- drivers/clk/qcom/gpucc-sm8550.c | 15 +++++++++++---- 1 file changed, 11 insertions(+), 4 deletions(-) diff --git a/drivers/clk/qcom/gpucc-sm8550.c b/drivers/clk/qcom/gpucc-sm855= 0.c index 53614e980b26..f8dd1727c080 100644 --- a/drivers/clk/qcom/gpucc-sm8550.c +++ b/drivers/clk/qcom/gpucc-sm8550.c @@ -547,7 +547,18 @@ static const struct regmap_config gpu_cc_sm8550_regmap= _config =3D { .fast_io =3D true, }; =20 +static const u32 gpu_cc_sm8550_critical_cbcrs[] =3D { + 0x9004, /* GPU_CC_CXO_AON_CLK */ + 0x900c, /* GPU_CC_DEMET_CLK */ +}; + +static const struct qcom_cc_driver_data gpu_cc_sm8550_driver_data =3D { + .clk_cbcrs =3D gpu_cc_sm8550_critical_cbcrs, + .num_clk_cbcrs =3D ARRAY_SIZE(gpu_cc_sm8550_critical_cbcrs), +}; + static const struct qcom_cc_desc gpu_cc_sm8550_desc =3D { + .driver_data =3D &gpu_cc_sm8550_driver_data, .config =3D &gpu_cc_sm8550_regmap_config, .clks =3D gpu_cc_sm8550_clocks, .num_clks =3D ARRAY_SIZE(gpu_cc_sm8550_clocks), @@ -574,10 +585,6 @@ static int gpu_cc_sm8550_probe(struct platform_device = *pdev) clk_lucid_ole_pll_configure(&gpu_cc_pll0, regmap, &gpu_cc_pll0_config); clk_lucid_ole_pll_configure(&gpu_cc_pll1, regmap, &gpu_cc_pll1_config); =20 - /* Keep some clocks always-on */ - qcom_branch_set_clk_en(regmap, 0x9004); /* GPU_CC_CXO_AON_CLK */ - qcom_branch_set_clk_en(regmap, 0x900c); /* GPU_CC_DEMET_CLK */ - return qcom_cc_really_probe(&pdev->dev, &gpu_cc_sm8550_desc, regmap); } =20 --=20 2.54.0 From nobody Fri Sep 25 05:31:34 2026 Received: from mx0b-0031df01.pphosted.com (mx0b-0031df01.pphosted.com [205.220.180.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id CCC034F30CC for ; Wed, 16 Sep 2026 10:32:10 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.180.131 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1789554735; cv=none; b=JAXul7Ptuuxbz1y9uxYA5V3tkT2t0nxsrUKU7g65MdmvcB0u2WhHlhhJT6IzUyIORtW3sYGXBWWkiIjaiSwZjQzowyMq3hjz6H05shwpfAzXazyxEqKFV5AYhNa8UWmlxXEUKGgAq24ROBFLOkfK8+DoLBljxabVexv7vLYokwg= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1789554735; c=relaxed/simple; bh=1iyxdTFCgs0fvXex+Hkh9Q3PZiZOUVA+VIIF9U+lR+c=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=ehyui80Onn7zNL1uj7na/XCyA0qoH+tEqLfAz5XcvMZLQsWKmX9C6pkk6Ivgw4EhDSFNtf6AweIeqcoon+PX/x+j3M0MqsRX47WPhr8bT512mTnoXXGXXmODnr6zrt3eq4LblQW08nVZ/WT8RyqsNDyyY/HEte0J15MRF7O4Eas= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=WGHLE9Lf; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=VjmpGUlx; arc=none smtp.client-ip=205.220.180.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="WGHLE9Lf"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="VjmpGUlx" Received: from pps.filterd (m0279873.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 68G934Es2226525 for ; Wed, 16 Sep 2026 10:32:03 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= +2IkqqEDVer7+tcXkK31/3lm9kPq64fRR4JiXgYJOuI=; b=WGHLE9Lf/qARqFyT hYFz8eQwF6kk3YNqvoHiMHvAXYfbKzXCtOYgCluw40UMk0ZQWQgJnGA2f8oT3Z7b XMTLz7DjSHpJzSXpwLRWrncEviTilk1pkmPtNsT0oQH964nppeTy8cnww/BVv45X lFi4y81KVS5CD9Bd1hNVkvQNRWS8gyAAL9OfECRuRkZwUdUCgTimLayFKhwhdbUk a4Jh+ub+Mns0KuWNMkHIWKSWE5Uo4bm5jx4PbWLgs4clupQD5D2Je+Hj9HttDI+C jocR/SFnsQhOYkQSbS7C+7iuhTkK+dvly2zS1V9IGINZXEwS09vw995pV0e2whNf 57qIcA== Received: from mail-qk1-f197.google.com (mail-qk1-f197.google.com [209.85.222.197]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4gqah9utaq-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Wed, 16 Sep 2026 10:32:03 +0000 (GMT) Received: by mail-qk1-f197.google.com with SMTP id af79cd13be357-93a1b824e84so686479385a.2 for ; Wed, 16 Sep 2026 03:32:03 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1789554723; x=1790159523; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :content-type:mime-version:subject:date:from:from:to:cc:subject:date :message-id:reply-to:content-type; bh=+2IkqqEDVer7+tcXkK31/3lm9kPq64fRR4JiXgYJOuI=; b=VjmpGUlx8Ks5qwwTKG55II7im0KtAa307GBPdD6zsinFnJhEAJlihu4XjLWkZdIYU4 4S+inhKxT4h0v9LSjcNAK5kJoZed5eGFTKe26gqmTPz3A58lMq1pGgr5dE/1E6egK7gI LIz7TSkq8dWyTiDmtHVtOvOx3rRLmSkXk2hoDG3uT47qR8MJDeNEH9uJ/4TwTxGR614q +ujJQbuN+mp2ItEJE/ArvmD7+fCDR80mjFl4ues7S858feXmBCi3wsdOaiQ4+u0SW01I H60jit4d/wGCvW2bGDb4E5GjSbAzY5QEGUW1L/5mMfxW3ByVKgq7HmrTgmLmEIedoAIv lycA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20260707; t=1789554723; x=1790159523; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :content-type:mime-version:subject:date:from:x-gm-gg :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to :content-type; bh=+2IkqqEDVer7+tcXkK31/3lm9kPq64fRR4JiXgYJOuI=; b=xTE7LopjmeuQ4GJa0uVacVEKJvpITCu689Jvbf17LGSe/3jKUw7zESRSufq8TOwKR3 G9lPx5+kJeDbGkVd0z64MftGj3apjxeBDZpIHga9rzjaK4PYfZL0AN4ti24Gn+A3J0Lf LoRBd9XJrakj4iXTBjzPcT4NVXgR948bV8o4+izfX1RaNesbSxPc/f2uFTjGOFO1y/yR xOpkue1Su48n/64MFyN8cd9IN74er/DLIOH3WnNf/NID1YmKLJFu56cq4MoAV358RgDm vn4U8OUG6ALavkgmnluU5yiKj7zzP6fv0OMP0Y61CguzIXjZLtYE8RDyUdYKLKT1Rgei MQng== X-Forwarded-Encrypted: i=1; AKwUvBwF+VYOyuHMtj00NsghbeDCt85lC4KhORg0GKxERfaWPysC4NiOdvEVBf/6FtLPoDszYXIGxYzUv3Pz0nQ=@vger.kernel.org X-Gm-Message-State: AFuF++kJeosFmoI/yghPIGRfSo0nFLI5ocpjY4S973oUHq+OD7XruWzv PxtE2u5ZIsDqqw7akpNa6NmA8iKdrmYbMcaYtdYsFttCphXRhuOmLwFs3aMzqxyzMtcHwfElUri DVh0eyMfLHd/u5aalVDtzZLq9v55v54deHBFqhGzn+acUKh0JgbxMF10PGjyGsStijYc= X-Gm-Gg: AYBFou1QH/28OHaEaez5JMBPCp8YwxtG45UgXD2GWBeK2dkEMscCLuexyMY/qWtxTba XWXuUvNoBMIb1jpBQ5ZWbgdOzsSNtngwOcx+qW1d0S9ljHI2eRoYcnPC1vcC9zfjeuFUtAoHLr/ +LUnGJNcSHG/WbawzKOQX5dseRvw4M6oQiZTP3JzWjSJrPlqoYcqxlzLDUJhs/wkfo7HoBKC/GX xXQnYjjg9Ognokz3SXiENcsuTbqOHlZqXpY1lMJcCsRfdnxynJeM086duSZge2a9aCd2kua4ZrV Sdx8ZqiF/H1Emo5RjksKEgpnWIEdnn2+tAFs1p/WWknXIv03HLP5X1VKr4bSktqOun4JEBaIGAq EARVLtHI= X-Received: by 2002:a05:620a:1720:b0:939:ad19:c5a4 with SMTP id af79cd13be357-93bb795032fmr294552085a.39.1789554678599; Wed, 16 Sep 2026 03:31:18 -0700 (PDT) X-Received: by 2002:a05:620a:1720:b0:939:ad19:c5a4 with SMTP id af79cd13be357-93bb795032fmr293985185a.39.1789554642791; Wed, 16 Sep 2026 03:30:42 -0700 (PDT) Received: from [127.0.1.1] ([86.121.170.232]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-49e83dbb0c1sm71633805e9.14.2026.09.16.03.30.40 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 16 Sep 2026 03:30:41 -0700 (PDT) From: Abel Vesa Date: Wed, 16 Sep 2026 13:28:57 +0300 Subject: [PATCH 41/48] clk: qcom: gpucc-x1e80100: Use common probe handling for always-on clocks Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20260916-clk-qcom-rework-legacy-always-on-clocks-v1-41-25a24e50f82a@oss.qualcomm.com> References: <20260916-clk-qcom-rework-legacy-always-on-clocks-v1-0-25a24e50f82a@oss.qualcomm.com> In-Reply-To: <20260916-clk-qcom-rework-legacy-always-on-clocks-v1-0-25a24e50f82a@oss.qualcomm.com> To: Bjorn Andersson , Abel Vesa , Stephen Boyd , Brian Masney , Jerome Brunet Cc: linux-arm-msm@vger.kernel.org, linux-clk@vger.kernel.org, linux-kernel@vger.kernel.org, Abel Vesa X-Mailer: b4 0.16-dev-0e65f X-Developer-Signature: v=1; a=openpgp-sha256; l=1689; i=abel.vesa@oss.qualcomm.com; h=from:subject:message-id; bh=1iyxdTFCgs0fvXex+Hkh9Q3PZiZOUVA+VIIF9U+lR+c=; b=owEBbQKS/ZANAwAKARtfRMkAlRVWAcsmYgBqqm9yZKPdBHW0rMcqMSXrMdf/2KkEh7oUvhnVY pyPKFM/E1mJAjMEAAEKAB0WIQRO8+4RTnqPKsqn0bgbX0TJAJUVVgUCaqpvcgAKCRAbX0TJAJUV VgS7D/4/+yGGszF5q5sp/dUCjPGenMIbYCiNQpBCDSpuIQbNoUbh/mKrHnhvh1jHMhK8iKdqz9d Idu2d5Nz+q734pCI50tpO6WaHMHKVeoLKmGGEYJKnaWVmVJBoZtXx/J7IYzNIQX5FioL7ShVO81 8AMrvsreO2L4yE5wuF3tepEFndtq9l9vbYUtB3HRZ4k8hDgzfNfz5O7BP21u9S1Twdo8Y6MGsVz hsT4F4v+NJBoY/fyY32pXelsgD1u1fUeou6ypvKdAFECHDlKxPNZyLx/6NhR5b0RRxdlvuDrMUT Y/+Ma8VW+LtZysPcfIL7ynQWW9b6UDyBKa0Z0fMkIMF+miaxuggp7M1PyuEirADmXnBrCH7HUgH aKp2UD2ps2ha55zQxRY/zGrigMuwDub4LXZ/kiyHIw61SNim+0qxwnsaeAWMihoYUbUGYwmIAFj qpLT78bz6T690aUc/5KVgZ0r8iaDOzqJFhDAZp9Zye00uihCwkaaTf6iVALlVzjnbZ+Td2rpSMP XDS8oF/i+hxX3FEGghwmuBBKCRIWDwLUfXk4O9A/0UmMSjpsGXxPpYSdnddHaBGGsyLFWTETBTl 3QSAuGJl+7pQ7+e4Ac+1KxWeDmDLwT7qp/K+QCj4y9KjZLRCAPehWtJawp66bNSACIx25u0r+zh K3dWPFlVI0OmnYw== X-Developer-Key: i=abel.vesa@oss.qualcomm.com; a=openpgp; fpr=6AFF162D57F4223A8770EF5AF7BF214136F41FAE X-Authority-Analysis: v=2.4 cv=BtkIUoX5 c=1 sm=1 tr=0 ts=6aaa7023 cx=c_pps a=50t2pK5VMbmlHzFWWp8p/g==:117 a=po8fGBi+ks8MzcVQGuqtFQ==:17 a=IkcTkHD0fZMA:10 a=VdqzKS8jKosA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=rJkE3RaqiGZ5pbrm-msn:22 a=EUspDBNiAAAA:8 a=Q3WM7qoV2j0wxbEI33wA:9 a=QEXdDO2ut3YA:10 a=IoWCM6iH3mJn3m4BftBB:22 X-Proofpoint-ORIG-GUID: bEkksIKDeiem5VUOu7cJsJPbAGkFL0tG X-Proofpoint-GUID: bEkksIKDeiem5VUOu7cJsJPbAGkFL0tG X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwOTE2MDEzNyBTYWx0ZWRfX4A1a2sB4eUZh 2VX8BG9aSNXve/0tr4+bu2KHKbvbn8Pu7T+Ft86YZOfcnCJxN+/ZAvjUknYcDype0aU62ioHjbL onAm4/d/8jk1ABr225hgU9AkIHEF4wQiwFL+tPObmPXKyAtry9yCk+Rf1t4ycG/cfZIIhjTH0VW 8FuL3SwO0PALJleg7rUhXoOsltOoHKo6XUaK5WRRRaQCgYMQtZQawKUH+grKR0WxL/QuLaKYhSd IBjoyiyhO/bSXSsUGKAVXtMclaKZrZ5TFTqMtCSYubpXDfm784HjA/9vrCMb9NgkB2GK47IHyD1 sTXPr/VNeavFgpqfKafsAXg4hWZM1csZLoELFyMC4gJttSXnrirgrFFB60cgpUJqdI2c+I7ai+c f8zbQj7emPELXg4kdjfcRe2WwVyMyrBIw1An/WaZicvXeILizAuhSM61cyQTs46C6/iBzaL3BYL niXXW+0TE+nu2Uk3Ozg== X-Proofpoint-Spam-Info: AW1haW4tMjYwOTE2MDEzNyBTYWx0ZWRfX+YYR36ERUBbr 4pnfHp+ZFVaysQjVWFjT+YC9W0/IMXjZlEjKY3lIf5CDVLwmIY72yNYCPoOttSFGFhwYqirGwpn IvHrTKA6XbatkXeQsE1sO6xH+kJDy2k= X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1176,Hydra:6.1.134,FMLib:17.12.100.49 definitions=2026-09-15_05,2026-09-15_02,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 priorityscore=1501 lowpriorityscore=0 spamscore=0 adultscore=0 malwarescore=0 impostorscore=0 bulkscore=0 clxscore=1015 phishscore=0 suspectscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2609040000 definitions=main-2609160137 Describe the always-on branches in a critical_cbcrs array and reference it through qcom_cc_driver_data. Let qcom_cc_really_probe() enable these branches instead of programming them directly in the driver's probe. Assisted-by: LLM Signed-off-by: Abel Vesa Reviewed-by: Konrad Dybcio --- drivers/clk/qcom/gpucc-x1e80100.c | 13 ++++++++++--- 1 file changed, 10 insertions(+), 3 deletions(-) diff --git a/drivers/clk/qcom/gpucc-x1e80100.c b/drivers/clk/qcom/gpucc-x1e= 80100.c index f9161dbaedd7..10a0b11927e3 100644 --- a/drivers/clk/qcom/gpucc-x1e80100.c +++ b/drivers/clk/qcom/gpucc-x1e80100.c @@ -609,7 +609,17 @@ static const struct regmap_config gpu_cc_x1e80100_regm= ap_config =3D { .fast_io =3D true, }; =20 +static const u32 gpu_cc_x1e80100_critical_cbcrs[] =3D { + 0x93a4, /* GPU_CC_CB_CLK */ +}; + +static const struct qcom_cc_driver_data gpu_cc_x1e80100_driver_data =3D { + .clk_cbcrs =3D gpu_cc_x1e80100_critical_cbcrs, + .num_clk_cbcrs =3D ARRAY_SIZE(gpu_cc_x1e80100_critical_cbcrs), +}; + static const struct qcom_cc_desc gpu_cc_x1e80100_desc =3D { + .driver_data =3D &gpu_cc_x1e80100_driver_data, .config =3D &gpu_cc_x1e80100_regmap_config, .clks =3D gpu_cc_x1e80100_clocks, .num_clks =3D ARRAY_SIZE(gpu_cc_x1e80100_clocks), @@ -636,9 +646,6 @@ static int gpu_cc_x1e80100_probe(struct platform_device= *pdev) clk_zonda_pll_configure(&gpu_cc_pll0, regmap, &gpu_cc_pll0_config); clk_lucid_evo_pll_configure(&gpu_cc_pll1, regmap, &gpu_cc_pll1_config); =20 - /* Keep clocks always enabled */ - qcom_branch_set_clk_en(regmap, 0x93a4); /* GPU_CC_CB_CLK */ - return qcom_cc_really_probe(&pdev->dev, &gpu_cc_x1e80100_desc, regmap); } =20 --=20 2.54.0 From nobody Fri Sep 25 05:31:34 2026 Received: from mx0b-0031df01.pphosted.com (mx0b-0031df01.pphosted.com [205.220.180.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 9AD5C499F22 for ; Wed, 16 Sep 2026 10:30:48 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.180.131 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1789554666; cv=none; b=qW7ZTneCbx947dLgSNQkuRUWU/jmmqcFss/X1FWRu+EW7KYFjUfj7UGotFlF011yAH9nLCpBZlewwWWVcVJhn7EOwjQidqw3LsbUz1Xo6qkYo48tY7qOW6uxzM+neu5u9zJPIbEyVvErmM6W3Y76lq0uDoe2ZrmBMcMChKI+16I= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1789554666; c=relaxed/simple; bh=c4S9D7xkKFu8M3uO9imMybdUjuODrfmq2FnzGW6fsfo=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=qoJXi7WjjlbT9bVlzKLnqkDqMzpITWbGutqAZ+SQ2UeYN1ebwlG8sxbLjIn8VUFILMGIFREE/p0nF0817VDiBxgiPH6UuShXOCz26gMRR5n6mIKLaooWq6u5HYBd1iXM2ZgITIHFfxo1PbOdkxt7FdrlUNlgEuM1b0Hah+UKfpg= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=naZvRrRR; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=P6eFPSNf; arc=none smtp.client-ip=205.220.180.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="naZvRrRR"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="P6eFPSNf" Received: from pps.filterd (m0279873.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 68G934rT2226555 for ; Wed, 16 Sep 2026 10:30:46 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= B2N3h0PvEVaJIhwWOlEG9IkFO+5IaOL2fHxO/9nHn2M=; b=naZvRrRRyjtAAVha 8RLMh9I1Ea8qZQ2prxsM4Z2q9IVQ4qXYtnhXaOKCyWRYy/KQF0WrHxUudvNNFT3E ScdlrI68GAW+b+ICr4xYvVDvt4dxLG2TiM1NKkeRyMYOZtWOnA38cuZS5K+KCFhP JSaJ6p+gUxlQj+pzZ6DV12YrkB6Sz1hvBGC/Dhi7gCDeH8XcZW+x0A7MXU4yvpca Gtvt5BDDjgSpLUZtFooRh3phXMGps0xKSpRP3CMHA2OIgsfyI+vr9Ztjk43nDPYF zN8Gz5BLbf9E9Qc783rDZI24WL7p6qKQWhELH8eC5jVBOQUnmrc7lFwaQ/mDsHTS ByrGdw== Received: from mail-qk1-f198.google.com (mail-qk1-f198.google.com [209.85.222.198]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4gqah9ut52-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Wed, 16 Sep 2026 10:30:46 +0000 (GMT) Received: by mail-qk1-f198.google.com with SMTP id af79cd13be357-93a00c70d28so646750185a.0 for ; Wed, 16 Sep 2026 03:30:46 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1789554646; x=1790159446; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :content-type:mime-version:subject:date:from:from:to:cc:subject:date :message-id:reply-to:content-type; bh=B2N3h0PvEVaJIhwWOlEG9IkFO+5IaOL2fHxO/9nHn2M=; b=P6eFPSNfBDgkoVaRaOxm+XOUVET6akTONR0Fx0BdhyRa9cMZymWx+UIADBZbcYMX9M T60iBjEqhDSvM5nIhcfFe+5w+zO5/282k1F0rcOZLgK2PQsxvwewsB/Oyg3MmubVbx0A ihQu/FI3fK1IqbJncFWOm67C6rBP9977O/RI27hKfGga5tpu1yw863U755sWZ9Aq0E+Z j1G9udtoFDpYamfCGMgtlqDjjAPyXdKc9T+9rq7mGQQZ7KPy2zJ2X2zbiWCv9zdDnXdf b6VdipcekatbBVbsWLS1QVOQJ+rqNgxUKI+mOOSrlnoPgdpAsK2XAmwMc87iK6XK19S1 UgRw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20260707; t=1789554646; x=1790159446; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :content-type:mime-version:subject:date:from:x-gm-gg :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to :content-type; bh=B2N3h0PvEVaJIhwWOlEG9IkFO+5IaOL2fHxO/9nHn2M=; b=V2VDKlFoQW4g6aPB1Ur4RbfIW7JSgzdqHrox/VieWWxqYqapfCvt5vsf0x+32Y3b5d Tvh4o9YorKabW7/gnWpdXaK8L0+3nXFz0Cm8U0DxtJM7IY8o8xLSf17TGw8moNWil/NI FwwVx7X+W1HJ7InWJ3YtQSKixh3XQVKLpCPkz+VfwF2RyorfJbkniNEfU3CNPeieg2bd RTsUWMnO6lZXacWu2s28EBdrOA8rRHrg1MCCN6hdMUR25JRevtAAPtF2zu0tvG+JzG3X Ar/epnW8ezPe/UznUWPQbLzCSLFHib/JXCxEnluNRgSBTnFHLR72mSO+gaddbL7UE3xJ Ix6A== X-Forwarded-Encrypted: i=1; AKwUvBwnk2xC4wEz/1G4SNU0+gXQUYXevhNIDhOnmJJGOopu7PP4lKYIwprOs6dvwWiMhvDzFU1wxubYd46mbEI=@vger.kernel.org X-Gm-Message-State: AFuF++lAGEcmV90+2sEShQ+HK84nVZGxVXIAQBcBXwrkFrUlL92+D0Ks QRrZsriqGTI55jrquoaxD6zggAafDeYF8EtO+IqXTo5cYC/WsOsHI9ltjHQIqN3kASeFvMcweFx 6hkTfKPwJitz7apub5NvB+5/Sd1Arnr/p+ueBIhfck2iKexTSonC8fsQ8slUbYt2ETds= X-Gm-Gg: AYBFou1UUWV2VSfAmBciS5cBy95jT+o9iXaHswZxbjBLMHIRufePOp5pTpasSa2tPDe Lwuib+86Sx6IaR8h+faMpB8TPAgo12iJinJNrayQaAdhqhHd4KJJJkK41uMsXLmHZPFEglVc9nH xGTihecRNGN2qkIJvdhYgGtMDF2BKFhn/uy49iCCgdYxDpNiDxMRWYIp/MiIU8aiv+LSntBElhG lwh3mfIl6NQgB4t6Hz1lwDIWnyugAoxOnvhLagDKWesZEqxLIgwfYeFjU4CppDvGh9ES904Us7M 5I65NOAmsJqBx08MtJ6S+6c0l2IYTn9RvQOudKQ9ZGKUYZOSKZDnMryKZb6RDJWkVzddV4c3gc4 TDtyRYIQ= X-Received: by 2002:a05:620a:4728:b0:93a:2bdc:cd57 with SMTP id af79cd13be357-93bb77085edmr305791285a.2.1789554645483; Wed, 16 Sep 2026 03:30:45 -0700 (PDT) X-Received: by 2002:a05:620a:4728:b0:93a:2bdc:cd57 with SMTP id af79cd13be357-93bb77085edmr305784885a.2.1789554644951; Wed, 16 Sep 2026 03:30:44 -0700 (PDT) Received: from [127.0.1.1] ([86.121.170.232]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-49e83dbb0c1sm71633805e9.14.2026.09.16.03.30.43 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 16 Sep 2026 03:30:44 -0700 (PDT) From: Abel Vesa Date: Wed, 16 Sep 2026 13:28:58 +0300 Subject: [PATCH 42/48] clk: qcom: gpucc-x1p42100: Use common probe handling for always-on clocks Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20260916-clk-qcom-rework-legacy-always-on-clocks-v1-42-25a24e50f82a@oss.qualcomm.com> References: <20260916-clk-qcom-rework-legacy-always-on-clocks-v1-0-25a24e50f82a@oss.qualcomm.com> In-Reply-To: <20260916-clk-qcom-rework-legacy-always-on-clocks-v1-0-25a24e50f82a@oss.qualcomm.com> To: Bjorn Andersson , Abel Vesa , Stephen Boyd , Brian Masney , Jerome Brunet Cc: linux-arm-msm@vger.kernel.org, linux-clk@vger.kernel.org, linux-kernel@vger.kernel.org, Abel Vesa X-Mailer: b4 0.16-dev-0e65f X-Developer-Signature: v=1; a=openpgp-sha256; l=1933; i=abel.vesa@oss.qualcomm.com; h=from:subject:message-id; bh=c4S9D7xkKFu8M3uO9imMybdUjuODrfmq2FnzGW6fsfo=; b=owEBbQKS/ZANAwAKARtfRMkAlRVWAcsmYgBqqm9zkpqZZxcWOWG3N1kpaQigtD1YexLocJsCr 63rvv8oMAyJAjMEAAEKAB0WIQRO8+4RTnqPKsqn0bgbX0TJAJUVVgUCaqpvcwAKCRAbX0TJAJUV Vg7dEACswX0C7wofWJ457w7mTs54ioeJUK/exiPsultDpNSOHelV02YWQorDH+dH7ko5ccjrIDN xDgLrp8NUFdR3RHY6If+u8OXDulNKVFBWSiduRTQX6dvTUu7Ph8ex9GgDKaj1qJ6Ow5iw+Mbbh6 xbO2NrGaXqfApxbOXWJCz4qrX/6E+TE676KD8hbMQn3x/fXfhY8SLZfrxrl7XedJuoPuoMeTkM0 H1VL54ZcyAf8e0k3FdW9jB9IgljHwNyJgR/Btl6XIzw3D/igsHS4Ur/7FXrkiwI0svOCGxNg6WT zWXW/+V/t6nnIpO6u7CIQBLCxPet7ypcT7u4CdxQ+zVzGR/xVTJgtNiUzt7neXwPjxM2DNHaMgt MLJhVBWWQBPYGhnn7xfK0V3uFbWduKCCri3xJY0CT7PzxFSVvFmfblB0w8hNEbfXuJWTTbELKPs /pSciksVYQ+Dm+wTlKE3YMNIhbeHSXFbb2Fw+5yejmg+Hcb+6WhW5TSUEjjqzsjdMQEJreNssD9 zJnS9pIAvruNoy5CJnNotP/m/zsFSlpqZrf09XcTH9+vH9LtfSoxHMySEWdj3gbqO6rqolrnwVY jtdXGYz+hmTjW0mQx0TQOKPgPDpPNnFQQP9RsalTPV5NZP2kzWc4DHUf2C1Wo9BP0uVdTWU3ftG sNM5lqe7vwTFxvA== X-Developer-Key: i=abel.vesa@oss.qualcomm.com; a=openpgp; fpr=6AFF162D57F4223A8770EF5AF7BF214136F41FAE X-Authority-Analysis: v=2.4 cv=BtkIUoX5 c=1 sm=1 tr=0 ts=6aaa6fd6 cx=c_pps a=qKBjSQ1v91RyAK45QCPf5w==:117 a=po8fGBi+ks8MzcVQGuqtFQ==:17 a=IkcTkHD0fZMA:10 a=VdqzKS8jKosA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=rJkE3RaqiGZ5pbrm-msn:22 a=EUspDBNiAAAA:8 a=ED4nYY0oUM9iKWp7kXQA:9 a=QEXdDO2ut3YA:10 a=NFOGd7dJGGMPyQGDc5-O:22 X-Proofpoint-ORIG-GUID: fQCVTpGpwUZ74m03gZvtnk1Vr8YgJaCa X-Proofpoint-GUID: fQCVTpGpwUZ74m03gZvtnk1Vr8YgJaCa X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwOTE2MDEzNyBTYWx0ZWRfX9Esf5UnpaKho l4CmKkT7e8iQ24tf7+7Q5fYT74C0IPfEtGczQ85cNQ/xsef2r1f4uD8Xlzqbr6cS4dRxzpc35xV Lt7f5W8ZYW6/JItbGo0rVhaZAzD0CniP4rr4WhFFnx8roODg8b6WgfQybaxBPnlcfyhWUJAkvDZ EgBRDjlH0rJbi0pv0Si/bUyMYIZmYr3SrRMbQ+OqC9c8HDqQH+i5XdIEj/cYg2gIhWNSL/A/nmg 6Mh1GovxDvr9rxUA1YVSJKrnGWOsvrwjJ9kJmOIpY2J5IPaI3wpmPQHe2+VN7ehTHHyB6sLHWTJ xawi4HXuuALeBizHOQXHKusNUJpPZT+dRZvYmMRFJjfRwl0XKO7m9v7d9X2CAs3gQ3+GZKVWjAf 2w9JV5Gg41GENu3erssDIQ6/HsSKcGPy8JWLg6WlYwjTXkfFV51rzX8H9Um9O7ErLAqxD4XAjbH dV1dprjC/e8+oBxd+vw== X-Proofpoint-Spam-Info: AW1haW4tMjYwOTE2MDEzNyBTYWx0ZWRfX7/KJi5CmbKIC eDD6F3FeaVfeazIG/hk5BGURP9BGeGqDT8JltzfJY662cm6f9dZ7S833L6IpdH9G/5JXXbPHULI XjWKJYwjYqO+dtrAirA1WD3W2K8vGmM= X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1176,Hydra:6.1.134,FMLib:17.12.100.49 definitions=2026-09-15_05,2026-09-15_02,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 priorityscore=1501 lowpriorityscore=0 spamscore=0 adultscore=0 malwarescore=0 impostorscore=0 bulkscore=0 clxscore=1015 phishscore=0 suspectscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2609040000 definitions=main-2609160137 Describe the always-on branches in a critical_cbcrs array and reference it through qcom_cc_driver_data. Let qcom_cc_really_probe() enable these branches instead of programming them directly in the driver's probe. Assisted-by: LLM Signed-off-by: Abel Vesa Reviewed-by: Konrad Dybcio --- drivers/clk/qcom/gpucc-x1p42100.c | 17 ++++++++++++----- 1 file changed, 12 insertions(+), 5 deletions(-) diff --git a/drivers/clk/qcom/gpucc-x1p42100.c b/drivers/clk/qcom/gpucc-x1p= 42100.c index cfc34e0fd290..3f3fec257f2d 100644 --- a/drivers/clk/qcom/gpucc-x1p42100.c +++ b/drivers/clk/qcom/gpucc-x1p42100.c @@ -522,7 +522,19 @@ static const struct regmap_config gpu_cc_x1p42100_regm= ap_config =3D { .fast_io =3D true, }; =20 +static const u32 gpu_cc_x1p42100_critical_cbcrs[] =3D { + 0x93a4, /* GPU_CC_CB_CLK */ + 0x9004, /* GPU_CC_CXO_AON_CLK */ + 0x900c, /* GPU_CC_DEMET_CLK */ +}; + +static const struct qcom_cc_driver_data gpu_cc_x1p42100_driver_data =3D { + .clk_cbcrs =3D gpu_cc_x1p42100_critical_cbcrs, + .num_clk_cbcrs =3D ARRAY_SIZE(gpu_cc_x1p42100_critical_cbcrs), +}; + static const struct qcom_cc_desc gpu_cc_x1p42100_desc =3D { + .driver_data =3D &gpu_cc_x1p42100_driver_data, .config =3D &gpu_cc_x1p42100_regmap_config, .clks =3D gpu_cc_x1p42100_clocks, .num_clks =3D ARRAY_SIZE(gpu_cc_x1p42100_clocks), @@ -560,11 +572,6 @@ static int gpu_cc_x1p42100_probe(struct platform_devic= e *pdev) clk_lucid_ole_pll_configure(&gpu_cc_pll0, regmap, &gpu_cc_pll0_config); clk_lucid_ole_pll_configure(&gpu_cc_pll1, regmap, &gpu_cc_pll1_config); =20 - /* Keep some clocks always enabled */ - qcom_branch_set_clk_en(regmap, 0x93a4); /* GPU_CC_CB_CLK */ - qcom_branch_set_clk_en(regmap, 0x9004); /* GPU_CC_CXO_AON_CLK */ - qcom_branch_set_clk_en(regmap, 0x900c); /* GPU_CC_DEMET_CLK */ - ret =3D qcom_cc_really_probe(&pdev->dev, &gpu_cc_x1p42100_desc, regmap); =20 pm_runtime_put(&pdev->dev); --=20 2.54.0 From nobody Fri Sep 25 05:31:34 2026 Received: from mx0a-0031df01.pphosted.com (mx0a-0031df01.pphosted.com [205.220.168.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 5116D4FC8F5 for ; Wed, 16 Sep 2026 10:30:55 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.168.131 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1789554691; cv=none; b=jtocEdMpwjraxCox/PPtChS2FiPeJ6vm+EX0Yb9pRWIhq8ZyOsc+pwP7FER6mlRAuxeY7hgoko7KOfo5CW39u/R1X4sbyUREKN7lCIYEbU8KRoKmWBZIJoUcAKJ+m48EwrIOT6VWy5LsSXElqtwu5ExNsz1XdpUhktvqxUn1CM0= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1789554691; c=relaxed/simple; bh=iZ7pKk3T8R3JKCttBUFqM1emU2wLfSi3zZs1CzHqSOc=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=kLigFgLqO3zqUMdTM7kB1Tsw8ZFH5BgYwvRLluheCGgVwknwow0VeQHAhX/yXBRXPv3JV+Ffsly19EJL9kcI2sw14c4PUTjrKhq92MsYfzHP/9+J50ed8X687ciyg6QV9yda9xcMhzIS0yhHjPwAQPxUVc2daW7djG/Eu05wj3s= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=a1IhajgJ; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=G57dzcvS; arc=none smtp.client-ip=205.220.168.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="a1IhajgJ"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="G57dzcvS" Received: from pps.filterd (m0279862.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 68G92vT51721238 for ; Wed, 16 Sep 2026 10:30:51 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= hQ+D7wuoF2Ufg85b23tzb6dwCm2k7tYYoaL/Hlf1zvc=; b=a1IhajgJ4m9UaCub Vx6+ul/89wu4nfbSmOXRrW/5pMl2dNlmtjUIq6X0by1+h+opYE7eekLWCZ5Vf5Tw Yb7P0t2DocB1ffVPx0OP5H8eCNlQ5sHCqfVTQrR1otjNKkb/oMIhXuz2JAxKlQkk lQmYaxK4v2cMRugDLBGRwe3ylcLjjRWCsozZi26dbvA3caPUWRu09CvqX+eG2vRm b+vvlOXi8lbv3DxLK8OnnLER19dsu1XOeCj/McFMh4SqFG8qM4kecJ0USW70UuTv oRzkPolfBVbueE17rFXBOYW95RNPr7eBOOBqmQzHy1j/eoMGCqB3XsekAbNka2q0 Ou0Nfg== Received: from mail-qk1-f197.google.com (mail-qk1-f197.google.com [209.85.222.197]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4gqbmnkc1p-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Wed, 16 Sep 2026 10:30:50 +0000 (GMT) Received: by mail-qk1-f197.google.com with SMTP id af79cd13be357-93a1de6d5c3so667964385a.3 for ; Wed, 16 Sep 2026 03:30:50 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1789554650; x=1790159450; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :content-type:mime-version:subject:date:from:from:to:cc:subject:date :message-id:reply-to:content-type; bh=hQ+D7wuoF2Ufg85b23tzb6dwCm2k7tYYoaL/Hlf1zvc=; b=G57dzcvSUHshCHK++1GIUYrJ2oNddjv8Prcuq5hiuigsjMKtwzPiNQRjxdY763tWYQ qLIycLHdBVOHPWlbJBPQG0Hms1SbYYTId9HGCqxE25Df0FbbsPvq9dmb3LvwEiXkfKvJ zQUI27DiAtEsrVpbEYbE/FxVc8VzPKrYy7LTsAUjNxzYhLzV3pcvwlCPj548D9FpbWbN RQupyOE4megBShnkymlD6KyJ5hglVvLHA5k44ajnhV/qrXT/4uCYn8NexE2UbhA8Pz7g OCq/ivlfdbMaZnap3VyR7PgZNM/lSL3o1AUfdrRsrjmnBg8oMVmUO/oiRDXfl1u+JQcT MRZw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20260707; t=1789554650; x=1790159450; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :content-type:mime-version:subject:date:from:x-gm-gg :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to :content-type; bh=hQ+D7wuoF2Ufg85b23tzb6dwCm2k7tYYoaL/Hlf1zvc=; b=Wk6yKzTbPBOMXDkybd/xZ6LsFAQA5SMu6ff1s21jp04bqAn5Y11NoV7X8Czhgcx240 sLcM3f82GnxtOezB9Z3lPtAeMvm2ZQpUsWUzq1AR9iJn0VDvcErFOx8F41/34sI28QCq Mw25QdSsATvx2omx4gA2Wxo2gXml9CMZ/lvPJXsVt2jgbFhmuojdvYMQZFCehIdv47Fn +NT/+b8lFKofBsNHsDoAXLV8+EsqKbWkGIDwgqHmJCUrn2LRL8WuSx/cAdL06Fw96i9v GxZoF99//juQNj0g0cK0VNdIn9Nhz1zcbI/loJ+wnfJaCgnvo9Stuh4jfKGXrVrgNmUe PYtg== X-Forwarded-Encrypted: i=1; AKwUvBwKqMzTb0rQ6N+u2FiYAzWi25dxrRCuU1zrsEEX0fHhgh1lDgupvsmFic0kE6NEOMPYKygbYIeFLzM7gtA=@vger.kernel.org X-Gm-Message-State: AFuF++lBQoueRcSsPlsEffG62nCH6TurJcSzcWQnNAZXvr7M85vCAD6y kE76a3/4dZHT1j3AA7u5pfpMih0baWxLA/l2vpa/ug/+WKMkwxeV3UtGqw90Oev+wXI5h4l0K/0 3pspWcg2TJ7Au8FxoQ/aF1i5Kw2LxeLpobZoVGD7/jhO0I3z/ADHnwlu5/dD0jmOUtgw= X-Gm-Gg: AYBFou09QPcK3S8KD37OhmyW7S4A5xTvQ4ez4iG160Xv/CBR9u312gsuPUCIT7uPjcU I3jb6Bu0edkoExo/Sekem1CQ01TGtBVklMPWP8AIDXPzd2+RA1M7lzLxhF5wZageQmFtn96a5YW UXU+Ahnauf01008AsB42wOlLnuHFIGkrOCv6t7t6NIycBct/GQa4ilQ4K7nCBBjkh7mhU10hr12 MUUp+nJdYVzzVxoxnIUP9xYbtHAOSsDYezAGZci6RlUwP9ZjpaiZhwJfuVJdRnelQC90RfzIAL0 PK1J8UL65XYxkDc/LAdfrdgUDUs0483120lviC6iBbZ29opiojhYHnw5WwNMw/uaW4QZSfgu73F vFVXFHc0= X-Received: by 2002:a05:620a:4707:b0:93a:3d22:3122 with SMTP id af79cd13be357-93bb76289e3mr318856985a.3.1789554648785; Wed, 16 Sep 2026 03:30:48 -0700 (PDT) X-Received: by 2002:a05:620a:4707:b0:93a:3d22:3122 with SMTP id af79cd13be357-93bb76289e3mr318837585a.3.1789554647115; Wed, 16 Sep 2026 03:30:47 -0700 (PDT) Received: from [127.0.1.1] ([86.121.170.232]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-49e83dbb0c1sm71633805e9.14.2026.09.16.03.30.45 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 16 Sep 2026 03:30:45 -0700 (PDT) From: Abel Vesa Date: Wed, 16 Sep 2026 13:28:59 +0300 Subject: [PATCH 43/48] clk: qcom: lpasscorecc-sc7180: Use common probe handling for always-on clocks Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20260916-clk-qcom-rework-legacy-always-on-clocks-v1-43-25a24e50f82a@oss.qualcomm.com> References: <20260916-clk-qcom-rework-legacy-always-on-clocks-v1-0-25a24e50f82a@oss.qualcomm.com> In-Reply-To: <20260916-clk-qcom-rework-legacy-always-on-clocks-v1-0-25a24e50f82a@oss.qualcomm.com> To: Bjorn Andersson , Abel Vesa , Stephen Boyd , Brian Masney , Jerome Brunet Cc: linux-arm-msm@vger.kernel.org, linux-clk@vger.kernel.org, linux-kernel@vger.kernel.org, Abel Vesa X-Mailer: b4 0.16-dev-0e65f X-Developer-Signature: v=1; a=openpgp-sha256; l=2537; i=abel.vesa@oss.qualcomm.com; h=from:subject:message-id; bh=iZ7pKk3T8R3JKCttBUFqM1emU2wLfSi3zZs1CzHqSOc=; b=owEBbQKS/ZANAwAKARtfRMkAlRVWAcsmYgBqqm90GrbN/Ojr6Cpf0pCXlh4B5xojAW4Ag6I0P YR0Q6BIMYiJAjMEAAEKAB0WIQRO8+4RTnqPKsqn0bgbX0TJAJUVVgUCaqpvdAAKCRAbX0TJAJUV Vni6EADL2z4yt+Xd9XcQt110ATi7dhY/nm28M9M/eL0vLVsO42d3xMVYtBF6cElBqxe0qovzTJN YVwOjmhyP6fClauDxGDG6zKvzo/NpcA8geC3lP18rqZ68NmLwIzT3VeLK5WwykeCX+asEYBVI4P yqTpwkfyZ4+5bfxYpBYOMCCQWGLMdhIEf+PawX9Be6cdZBeNWIAxDpLmmdVp0EGTChRFKZg4NDv wxvB6OrZeirI5a+R0aSymJmRy3/F3G7iv6kdZ3PfAgoiZEhNnraNJjM5JVGZWY1djyEbwDzY9y2 MqXrFsSl0Z3CxY7phhfdbnS1s/TXD2Ck3lN6PK79CndkTvoVBPjLBJE+AW3XrkPmsKjtihTr37N wQJMbGeyUW7quQtf8oOqzLwDy291bgTVeW9BnBtIHNph03Pb2FYCOMN2lcZNVc3usMgfwq4+DQh ESpiLyR+Fh9eB7wcBah8mrBQ4lQ4A8X6Ar56GOzdRl/h3Uf2AfcKFjq9eLqgUC3R3c/OtGKpMnB 9Am+QCKvfv0Z/wWsNLsZjevcGs2GimmCMcRowM81D/e0OOXC/i1V92EHz0j+jqqPiRfFq76Ktr1 wT4zEyoJuLrW1a8urbKlDJgf7vpVcb5T30ATEz1j4iJYhI55S3rCCnNdxAFwCZ0zusN82y+7K27 +fTFshHYR65ku5g== X-Developer-Key: i=abel.vesa@oss.qualcomm.com; a=openpgp; fpr=6AFF162D57F4223A8770EF5AF7BF214136F41FAE X-Authority-Analysis: v=2.4 cv=POyaavqC c=1 sm=1 tr=0 ts=6aaa6fda cx=c_pps a=50t2pK5VMbmlHzFWWp8p/g==:117 a=po8fGBi+ks8MzcVQGuqtFQ==:17 a=IkcTkHD0fZMA:10 a=VdqzKS8jKosA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=_K5XuSEh1TEqbUxoQ0s3:22 a=EUspDBNiAAAA:8 a=6y-cbsPRrUJUYPj_W9gA:9 a=QEXdDO2ut3YA:10 a=IoWCM6iH3mJn3m4BftBB:22 X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwOTE2MDEzNyBTYWx0ZWRfX14BE4A8bxnxj 9/KqSzUcd8n5iirtRbweKS0f1E6Rlw0UQ7Fuk17+3C97hUP3onIosySMNY7+calfHuNWWOKkCh3 Xag9C1oN+/v1rcUkIqBaQnbn/iu0yqg5te9qhMUwhNRwXmfa7NZILZgOyNTYTPg2DbULD3sd2Ml taz1t6UN/ycgTmXasdsRGsNyYgHKn4ZhXXVJpwQPlv1IEiwbQoZ1fggJOZ288Id3nO3NZhS5DIU mEqojXZ9j+iKCo2aHBZvOz4WjKgsm7PS9LU7XQN5nUHB++hOP3P6obbj7gAuTlG1Rk9WjtEded2 06Q+5wlkSEqi7bRwtqERwt4i9FoXJ1hoi5n843P0CgF/PfjHO/qaiia8TWc3GamWgSAfu76gcv7 kBKpvAvAgPiuduWiC5gcZdPgwqqZwVTpG1Czj+ogoRpinRgbU09pmt285++v8/qG/US18VIndgx GnM5rA63YT03a6GVpQQ== X-Proofpoint-GUID: KI_FAgB2qymVg9Gk1vMjZ7XmyEiHIye- X-Proofpoint-Spam-Info: AW1haW4tMjYwOTE2MDEzNyBTYWx0ZWRfX0N7ruXSVFac0 pfDwJFNdCd4e0iLUTumnCqb3URLmIPAmndgoyiELKM4ddyCCoMf9/ckuDeuGzlQuk8t6KuVirhq ZPLegtjTZmZdbIfghGOFwcSP8Fp83Z0= X-Proofpoint-ORIG-GUID: KI_FAgB2qymVg9Gk1vMjZ7XmyEiHIye- X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1176,Hydra:6.1.134,FMLib:17.12.100.49 definitions=2026-09-15_05,2026-09-15_02,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 priorityscore=1501 adultscore=0 bulkscore=0 clxscore=1015 phishscore=0 suspectscore=0 impostorscore=0 spamscore=0 lowpriorityscore=0 malwarescore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2609040000 definitions=main-2609160137 Describe the always-on branches in a critical_cbcrs array and reference it through qcom_cc_driver_data. Let qcom_cc_really_probe() enable these branches instead of programming them directly in the driver's probe. Move the PLL register setup into the clk_regs_configure callback so it still follows the SYSNOC branch enable. Attach this data only to the LPASS core clock controller descriptor. Assisted-by: LLM Signed-off-by: Abel Vesa Reviewed-by: Konrad Dybcio --- drivers/clk/qcom/lpasscorecc-sc7180.c | 31 +++++++++++++++++++++---------- 1 file changed, 21 insertions(+), 10 deletions(-) diff --git a/drivers/clk/qcom/lpasscorecc-sc7180.c b/drivers/clk/qcom/lpass= corecc-sc7180.c index 5174bd3dcdc5..af28da5f04b3 100644 --- a/drivers/clk/qcom/lpasscorecc-sc7180.c +++ b/drivers/clk/qcom/lpasscorecc-sc7180.c @@ -343,7 +343,28 @@ static const struct qcom_cc_desc lpass_core_hm_sc7180_= desc =3D { .num_gdscs =3D ARRAY_SIZE(lpass_core_hm_sc7180_gdscs), }; =20 +static const u32 lpass_core_cc_sc7180_critical_cbcrs[] =3D { + 0x24000, /* LPASS_AUDIO_CORE_SYSNOC_SWAY_CORE_CLK */ +}; + +static void lpass_core_cc_sc7180_regs_configure(struct device *dev, struct= regmap *regmap) +{ + /* PLL settings */ + regmap_write(regmap, 0x1008, 0x20); + regmap_update_bits(regmap, 0x1014, BIT(0), BIT(0)); + + clk_fabia_pll_configure(&lpass_lpaaudio_dig_pll, regmap, + &lpass_lpaaudio_dig_pll_config); +} + +static const struct qcom_cc_driver_data lpass_core_cc_sc7180_driver_data = =3D { + .clk_cbcrs =3D lpass_core_cc_sc7180_critical_cbcrs, + .num_clk_cbcrs =3D ARRAY_SIZE(lpass_core_cc_sc7180_critical_cbcrs), + .clk_regs_configure =3D lpass_core_cc_sc7180_regs_configure, +}; + static const struct qcom_cc_desc lpass_core_cc_sc7180_desc =3D { + .driver_data =3D &lpass_core_cc_sc7180_driver_data, .config =3D &lpass_core_cc_sc7180_regmap_config, .clks =3D lpass_core_cc_sc7180_clocks, .num_clks =3D ARRAY_SIZE(lpass_core_cc_sc7180_clocks), @@ -400,16 +421,6 @@ static int lpass_core_cc_sc7180_probe(struct platform_= device *pdev) goto exit; } =20 - /* Keep some clocks always-on */ - qcom_branch_set_clk_en(regmap, 0x24000); /* LPASS_AUDIO_CORE_SYSNOC_SWAY_= CORE_CLK */ - - /* PLL settings */ - regmap_write(regmap, 0x1008, 0x20); - regmap_update_bits(regmap, 0x1014, BIT(0), BIT(0)); - - clk_fabia_pll_configure(&lpass_lpaaudio_dig_pll, regmap, - &lpass_lpaaudio_dig_pll_config); - ret =3D qcom_cc_really_probe(&pdev->dev, &lpass_core_cc_sc7180_desc, regm= ap); =20 exit: --=20 2.54.0 From nobody Fri Sep 25 05:31:34 2026 Received: from mx0a-0031df01.pphosted.com (mx0a-0031df01.pphosted.com [205.220.168.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 8E0734EA37B for ; Wed, 16 Sep 2026 10:30:55 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.168.131 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1789554692; cv=none; b=T/+5I9mXTqSOuuqJdxC+JsNlk4C9V2TJbwhXkZIPRX3nimpJ7IptjgHkm6A0aRT9OQaGGzhAK2JuCe4VX/Y5/6UzaPXYbDbfBC/cJN6BHvI0FtTkHOdz8Sj3kwtNYhsuqsHNkgIspBrV1nlDDk6zU6L3UTn48ZaEGzuoQavNz7I= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1789554692; c=relaxed/simple; bh=16EboWEhK2pj2Pfnz97zp9Iu11Al0FAmwMXJMbuvGJ4=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=V37C6i8JlaufH5PcYah/rz0X7w3dhNxTQvcUaNwJGY+GYkOLBCOMkNnw0Qz3rCOnP68d4zgJ4mFt5Upi1r79CZcu6x+//QgK1cERfVbve55dy8j+4+6GGZwoINfuEsMhjm2aGluRDOZ5shXr8TuqAREF/VZMCVSvX0JWHQq+IEQ= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=KF7dYozR; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=B1JVuY5m; arc=none smtp.client-ip=205.220.168.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="KF7dYozR"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="B1JVuY5m" Received: from pps.filterd (m0279863.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 68G92p2L2348415 for ; Wed, 16 Sep 2026 10:30:51 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= CIExri27Fu3tkFXyJAX6gm5zvhx2iZpPShmz2r5/eT0=; b=KF7dYozRMFsgIeho QUf54NfX15HtQ4V5BiEoNEew9EyqtnzQErr4dWc+htSpQdrhBC7VlVTaTWXBHHP4 uMQKMM3DDAtEqmYR/FAEm9z1qaLxN51exk85u0S4I+DCTg4BHCSUygcsVkiwQiie SOxCF9DO4EyxLIMzC8UIjs5DV34MY90en5bFKOM1LPxzUd1IIDvaqvyR3FadvhKX 5k1amrp3wDY+7y4UUsH6j3FjpAn5HBG6eFaVwP2TfBOgyNvFbBodxCEcGuX8lnNO byj8gvK2sFfaBakgq2k0RneyNuXLgXtFyRJ8Ux/97BbMl8eFLITBMiWVRjlyvBSz qEFXrw== Received: from mail-qk1-f198.google.com (mail-qk1-f198.google.com [209.85.222.198]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4gqdywas8t-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Wed, 16 Sep 2026 10:30:51 +0000 (GMT) Received: by mail-qk1-f198.google.com with SMTP id af79cd13be357-93909014c85so1034084285a.0 for ; Wed, 16 Sep 2026 03:30:51 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1789554651; x=1790159451; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :content-type:mime-version:subject:date:from:from:to:cc:subject:date :message-id:reply-to:content-type; bh=CIExri27Fu3tkFXyJAX6gm5zvhx2iZpPShmz2r5/eT0=; b=B1JVuY5mRk6JNW9PNvt0+9ETggQu4WVJ+Q+W9d3IO+7vGu5c9Bc40hXS597hT0lN23 2lMjv3nPJr3BLdwOdpqvuPI6/fQCUSv+udK+0q2yHgdJaSuDH8DHA1emUDYjaaF883Nq RyRXhhPXn52zMuhEQLDggUOV7L0V5Iu+2eqy+puNpQzvYXmfA4xpXL0RyZWZ3Ll5Jh1n 6YzFL7Z9BDYp46HVp7OzbCqm1seK2vb8+tOnQFlpUXcK3bSZce7Rm1On7Po/kRhsbtAA dmKTCZWjUqo+guIgTd4yFnQSG3e9jf3clpiAv5Y4LDyU+7oTdiRlk6CFqj2G0fapvMk4 apSg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20260707; t=1789554651; x=1790159451; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :content-type:mime-version:subject:date:from:x-gm-gg :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to :content-type; bh=CIExri27Fu3tkFXyJAX6gm5zvhx2iZpPShmz2r5/eT0=; b=k2NdNa7aNu1ldMOFKIjxsbawwrXrdZD9zvEltFJlNAwzbUwDhYKmUZvxckyFcW0lI3 +dgfPx9EWspyVrcIJSrzx7MPng4TG9WfeTUR5sj69cRB4TH0Ior1B8qN9BMaZvkZiWMW PqG+3oC0ksYHjc8XAtlskxEKfYCz1GWMzhi3p0e0v59UL/N1WVVR7iQiUXBvWWqKlqBo XNyWLdfdj4NRnQsah7SMk5kC7ry8734Vl0mNVTKRffFiReaF1/+7/sbC6o2gjB4pchUs xDcT+39G65F0LhrdfAGln3ikziZh0NOC2oA58++XCyDGuWjEcQS9GN/IeQ0/nWNd5AS0 ZJng== X-Forwarded-Encrypted: i=1; AKwUvBzAZxbnLzuimSxb2kJXNXj9w26k2Evg1rIwknwg3R7tgL1hDfUvgD90ZVF2vWnZpli10o19VmtnWKEzl5w=@vger.kernel.org X-Gm-Message-State: AFuF++lmwwvGrTQijpj7KZCbuCp9dwbaaNDKbdmL+QB7mbZGNKI1ypiL cd/6JXMIj42SuxBiFxBxGchMdjQYFnTrQktBhVZBqohmaREakF107FflVA7dFTvYEfvviLsjYYY kINMXS0JuQ00tXzl87JGmyAg6EGY6rxXuTtYensRZjhaWHAt89IeEG+gNKMoUF1xMWe5O/4E5kr w= X-Gm-Gg: AYBFou2XGnF225DlCqsg3ldGLXGC1KXOpzYUul26kLZFp4TaKs5f6RKht5qaJVDuwOc TseJo8N7xwiYTHEQftNFWMuwawEjT/SE6qUpbkNRdHGRqbU5O/M+xffzeixnrgDRkUoDwbYmFEP 892l7a9xFBXaUbz0TPwtl3a+utHqJe4RbX2KzqPPE28cciYaJf8glnKRexviCIdEAcvx4rMdF1a +uNR0MsUXiFtHRNV2sUWfpqMhB2Ui56HKMPC86/I4YUl9NcmHDYuwWWRWSfPB2D9bzRB2YrLTHf VGqI60BDU0uWmrGYjr1pThgip5D4xqBe0VZMYHM3MOD+v+OcfOc0XHYufqZtgXBZRwjNRPw2+PM 3FbGSPXE= X-Received: by 2002:a05:620a:4481:b0:937:3a1d:175a with SMTP id af79cd13be357-93bb76e6cb6mr315684085a.3.1789554650353; Wed, 16 Sep 2026 03:30:50 -0700 (PDT) X-Received: by 2002:a05:620a:4481:b0:937:3a1d:175a with SMTP id af79cd13be357-93bb76e6cb6mr315669785a.3.1789554649117; Wed, 16 Sep 2026 03:30:49 -0700 (PDT) Received: from [127.0.1.1] ([86.121.170.232]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-49e83dbb0c1sm71633805e9.14.2026.09.16.03.30.47 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 16 Sep 2026 03:30:48 -0700 (PDT) From: Abel Vesa Date: Wed, 16 Sep 2026 13:29:00 +0300 Subject: [PATCH 44/48] clk: qcom: videocc-sa8775p: Use common probe handling for always-on clocks Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20260916-clk-qcom-rework-legacy-always-on-clocks-v1-44-25a24e50f82a@oss.qualcomm.com> References: <20260916-clk-qcom-rework-legacy-always-on-clocks-v1-0-25a24e50f82a@oss.qualcomm.com> In-Reply-To: <20260916-clk-qcom-rework-legacy-always-on-clocks-v1-0-25a24e50f82a@oss.qualcomm.com> To: Bjorn Andersson , Abel Vesa , Stephen Boyd , Brian Masney , Jerome Brunet Cc: linux-arm-msm@vger.kernel.org, linux-clk@vger.kernel.org, linux-kernel@vger.kernel.org, Abel Vesa X-Mailer: b4 0.16-dev-0e65f X-Developer-Signature: v=1; a=openpgp-sha256; l=1945; i=abel.vesa@oss.qualcomm.com; h=from:subject:message-id; bh=16EboWEhK2pj2Pfnz97zp9Iu11Al0FAmwMXJMbuvGJ4=; b=owEBbQKS/ZANAwAKARtfRMkAlRVWAcsmYgBqqm9127Djy28rq2CimIujWCBAE7XQ+ihK2ln6p aDDUoHrB/mJAjMEAAEKAB0WIQRO8+4RTnqPKsqn0bgbX0TJAJUVVgUCaqpvdQAKCRAbX0TJAJUV Vp3qEACPGKh2o0SFQaZLB0gTdar+Ye3Z2dau+IeQUwbmdlBR628TD+SwIJa2OaEap0wpdjC7TKF wWKaTFHL2kR8772zs7AZm7Own3QlRRP1uSOVwsT+MmKRRO5nTioOEHLkkCZCsGxWBP/gsUDeu3I waT/nqQgxYPoc2emCO5NDgLvtDHB/HdhWNFfVLN7S+UIAu7rXbOXwLU5/2Hhby387hQFhfC5jt/ XWFyDzb2Nf7a5JxINbF+Boul3JJOuziooGnMb/fDhzfvk3LNVWCMQLBWm8q9AJGfraZm3/VFcBz 4A9tqs+rQyI+o2JoIjl9yINoKjlOPLU7Xt8bUzEzK4K1CabjoFKSDQFh3K/nAJ3CvINpp92nEiK sPbQMDIZY0AJiKzwVB13fbTOUhiTeUMhd/Mp6KZdotqrSscpUT8wc5dSfVe2gTBQjMhxC/0O2Wa xAf2mOU6RtellVKtOzwxesQdz6Gvuw0dEB6TLAOsGVMrGnNsAnHWUlGPJoxWZy3wI7Sx/5a87Hn nyRjEiUIkTq/D+CcwCbYYceBIfdtolpBHNlDXFLlJXQMnZYcrxRH4imS4iHOC69A7kuRo/fz1gO zA6IREMC9qG/dzn7oysogOtuUqZIYqNusRxFd46H5e9Bto5++l875cd2ThRCfOcFWNS4SrfzMI2 M7DTIipvO78fpxg== X-Developer-Key: i=abel.vesa@oss.qualcomm.com; a=openpgp; fpr=6AFF162D57F4223A8770EF5AF7BF214136F41FAE X-Proofpoint-GUID: V4WysGXp84GgnMgXLknK_aLV8sjCOPtg X-Authority-Analysis: v=2.4 cv=aJ1lOr9m c=1 sm=1 tr=0 ts=6aaa6fdb cx=c_pps a=qKBjSQ1v91RyAK45QCPf5w==:117 a=po8fGBi+ks8MzcVQGuqtFQ==:17 a=IkcTkHD0fZMA:10 a=VdqzKS8jKosA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=yOCtJkima9RkubShWh1s:22 a=EUspDBNiAAAA:8 a=i-6CURGfGzB18q9V7KIA:9 a=QEXdDO2ut3YA:10 a=NFOGd7dJGGMPyQGDc5-O:22 X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwOTE2MDEzNyBTYWx0ZWRfX3hx/9qhiAlVh 26B/Z9DyBvQl2UdK+O0PEeWrz4mD4VijTZT47TjDcICUO4xccs/n4CIxfWuzYKO1KhH2ZTPQ9A5 0mZvp8r/nsvW9qqCdGMNN5AWkTLY5UtK5h+yt3DGxuccoz6hqFm5Pja8aBdPj8KN6zFQ8Mf/9MD cRbSperzLigEMF68WauLG2nFDfXvbkVSnY7SXfeP0vjJwGD8Ty8qSx03tjbm0b5z/UAiabU72dG 5zvDtfOg2b5i5h0EgeysmCJ5/6QCDxMrPg65c2ynnYFDUiXnWUxQBAPl66wjR9eyoXiFmGETpg4 ZXxxIjYD7ARzAIAw0qI6O5pQYv53+JuAq5KHDvvIdgSvlDCPJlZDrVtr2Jcb5b/LqweGIusnQP0 QKLppDDrK0v5LFj1dhhA9LuqtEVXa4nqIZ6tlOhlQJYfJXP4gTHnHIjjFCY2wqJGiPCGiLvLTRj +HgXv22aV29VeskMtEA== X-Proofpoint-ORIG-GUID: V4WysGXp84GgnMgXLknK_aLV8sjCOPtg X-Proofpoint-Spam-Info: AW1haW4tMjYwOTE2MDEzNyBTYWx0ZWRfX7f25ymtAjGWn lLYpz8545Sx79kiYL0uSb+eB2z8OeFk67X9o/vK41GfRL7iYzcOdk1IOgDf7D2zfL7sFy8CyUN1 iumlNlSDq3sge5vbo2biHFmyoMBHcEA= X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1176,Hydra:6.1.134,FMLib:17.12.100.49 definitions=2026-09-15_05,2026-09-15_02,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 adultscore=0 impostorscore=0 phishscore=0 suspectscore=0 bulkscore=0 malwarescore=0 clxscore=1015 priorityscore=1501 spamscore=0 lowpriorityscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2609040000 definitions=main-2609160137 Describe the always-on branches in a critical_cbcrs array and reference it through qcom_cc_driver_data. Let qcom_cc_really_probe() enable these branches instead of programming them directly in the driver's probe. Assisted-by: LLM Signed-off-by: Abel Vesa Reviewed-by: Konrad Dybcio --- drivers/clk/qcom/videocc-sa8775p.c | 17 ++++++++++++----- 1 file changed, 12 insertions(+), 5 deletions(-) diff --git a/drivers/clk/qcom/videocc-sa8775p.c b/drivers/clk/qcom/videocc-= sa8775p.c index 65a2d5bafea6..2ca78af8c20c 100644 --- a/drivers/clk/qcom/videocc-sa8775p.c +++ b/drivers/clk/qcom/videocc-sa8775p.c @@ -511,7 +511,19 @@ static const struct regmap_config video_cc_sa8775p_reg= map_config =3D { .fast_io =3D true, }; =20 +static const u32 video_cc_sa8775p_critical_cbcrs[] =3D { + 0x80ec, /* VIDEO_CC_AHB_CLK */ + 0x8144, /* VIDEO_CC_SLEEP_CLK */ + 0x8128, /* VIDEO_CC_XO_CLK */ +}; + +static const struct qcom_cc_driver_data video_cc_sa8775p_driver_data =3D { + .clk_cbcrs =3D video_cc_sa8775p_critical_cbcrs, + .num_clk_cbcrs =3D ARRAY_SIZE(video_cc_sa8775p_critical_cbcrs), +}; + static const struct qcom_cc_desc video_cc_sa8775p_desc =3D { + .driver_data =3D &video_cc_sa8775p_driver_data, .config =3D &video_cc_sa8775p_regmap_config, .clks =3D video_cc_sa8775p_clocks, .num_clks =3D ARRAY_SIZE(video_cc_sa8775p_clocks), @@ -557,11 +569,6 @@ static int video_cc_sa8775p_probe(struct platform_devi= ce *pdev) if (of_device_is_compatible(pdev->dev.of_node, "qcom,qcs8300-videocc")) regmap_write(regmap, video_cc_mvs0c_div2_div_clk_src.reg, 2); =20 - /* Keep some clocks always enabled */ - qcom_branch_set_clk_en(regmap, 0x80ec); /* VIDEO_CC_AHB_CLK */ - qcom_branch_set_clk_en(regmap, 0x8144); /* VIDEO_CC_SLEEP_CLK */ - qcom_branch_set_clk_en(regmap, 0x8128); /* VIDEO_CC_XO_CLK */ - ret =3D qcom_cc_really_probe(&pdev->dev, &video_cc_sa8775p_desc, regmap); =20 pm_runtime_put(&pdev->dev); --=20 2.54.0 From nobody Fri Sep 25 05:31:34 2026 Received: from mx0a-0031df01.pphosted.com (mx0a-0031df01.pphosted.com [205.220.168.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 6EDD64EBAC1 for ; Wed, 16 Sep 2026 10:30:58 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.168.131 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1789554680; cv=none; b=LSz8orj2eCkoSBAd/wtpjCk1YRBYvlXK/mqWlcQeqYIGVCECbqbCvKA0hqSUXiyhZudV076NnNLKtuv0JNfie0FPF+5kcvCO+g/TktQDHF0I+HtusaBOcl9McEWGsLdOeDqdLH9UU75T+AYEa/m3QLvcqBsT/JcCeqffmLDgntg= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1789554680; c=relaxed/simple; bh=ceySCAJ2UKzCOMrGPaWITOdmnUsWyZZP02Z5z4V1xcU=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=kGeLdLGeyQSMutfTSNAyJ17mBy8C1MB+lTf0/GQUYn14RnihXTUXCyhY1w1lSCo7GILwEFtN68wkZ5Rk3R5pjnH0W/JayZaWXqepB+vLNd2ESPznJLANhah4+6fggtUhyftbXrqV4qyepJp95CVf24SAsNC+E/rYTqMmbXDPNXc= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=N97EmyEi; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=ZiplyQVW; arc=none smtp.client-ip=205.220.168.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="N97EmyEi"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="ZiplyQVW" Received: from pps.filterd (m0279867.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 68G92q603377415 for ; Wed, 16 Sep 2026 10:30:53 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= tpRg3+sla39rNmV5CVX30fzQnRmtP0Sx9McGTSZpuPM=; b=N97EmyEirXHuBPaw +cVBN9i95JhL5fcfPVDMN2J+sLxrO16TzgJ+Of4tMXM9vY9q4u+0uRCJQx1gjIYM h3NIVPFKvUqKKxWAhyvE7LjU+1XTd4s/BJIV4yGR72K1BGep4Ilsw7DiJgzWvEcJ SP/DJ5z1YqAo8cDRtrhx1BrU69rQIaaJEQJ2DD3ZxQQd+k6svVx/jXy4Z3l1jgjl 5x0HI9Fkoysue9bVq2jpM4+/mffTy35YBlL/2FfOBtFdHZRe6SHXIHcxeptf9iFU KhbwV/dCts4ITGXIIEf8rzFz5+afRmAZU8paE+c6LfDF8oGYCrUJuFalMy1U5sx2 58eXIQ== Received: from mail-qk1-f198.google.com (mail-qk1-f198.google.com [209.85.222.198]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4gqefpanr9-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Wed, 16 Sep 2026 10:30:52 +0000 (GMT) Received: by mail-qk1-f198.google.com with SMTP id af79cd13be357-93a00c70d28so646764485a.0 for ; Wed, 16 Sep 2026 03:30:52 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1789554652; x=1790159452; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :content-type:mime-version:subject:date:from:from:to:cc:subject:date :message-id:reply-to:content-type; bh=tpRg3+sla39rNmV5CVX30fzQnRmtP0Sx9McGTSZpuPM=; b=ZiplyQVWIjS/yiROCbeY7gLkFZBvpCdXop+mU2ZhdDfXfanYYShsnULJ0ntfmPXgnH Xy8KGtTRwSR5l1cejC/5JcWLZnxQ7Ij/coFzVlysin9cJc0KRp5JFpRpys9aV7Zf/kUM l80BIeTp8h8wfkxO7yL+60xlqxYhxrDk1WSe7p/yoLjO7W6CaI/hGYphSupnEQxteSXb LcloENvCRFfBEw5Bky+QJOf+AFdVqwMx2wUKG7DD3IzB6MXf6kDga7qkWcoDxgQslMdo sh1gIef3gGbI33+txREHkREYBTpImjw2eg4Gd6/0jjpBpeFSz0V7bxl+Ph7Bk11N6SQU /NBA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20260707; t=1789554652; x=1790159452; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :content-type:mime-version:subject:date:from:x-gm-gg :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to :content-type; bh=tpRg3+sla39rNmV5CVX30fzQnRmtP0Sx9McGTSZpuPM=; b=eDvF9MzEDqJ+BrB2Egsz7wOEqtLpZCBmnzdWRFkPZoudXMgGhqMvL9XaPfTCJDjoS1 2nyM2i7mEc1TZEtGxIf4vtQVcLloLepYHo20qPOG+skeIr/hnjBsSRYiTzAt5tmrqfQV v/PmO4ApTYpHX7BOz1k1hmt27ptWPqZdYDzlBBei74TGOLJ+x1avLFcrs1MJsfmHXUeU SAG/5LOZfwaQQOkvqqLxNw2mQ8J5ThjgoW3sfRf5tqsxH9TqZodlJX8IlO3itEmmQ1h3 V0XMRgzEpC2nu1DbQ0/bLsE9VQ6pOmhVA4BOqsgsiIMw+vk8lgbVaM+rLfhRHXnGTxnn u+3w== X-Forwarded-Encrypted: i=1; AKwUvBxOk0ric5c0ag7/d/QsGwWIttJ/2tfD8LMg3m6y5Pm4CWo8nDuv4rU+ByW3K5fTW37jfuwcQ6rn9QyJGD8=@vger.kernel.org X-Gm-Message-State: AFuF++khCz/shJ6ePasgBCrHM0PYWohlL91+zzWzOHNNQi3Fg7iNy4Us Oq26leWXN/CfSGWLJ1wmvQ6Ai1OQlZWyggdOWaDRmAfm8OpWVm2u7AFIDDkEd+WBRWxASz+P9Jk UqejVNTlfFFGk2h6oqDor2ljRY8JkF5rxKx6y+ECbwsWHMm7syQ0PvuwqSsErwW8QGCs= X-Gm-Gg: AYBFou1mfvIYJLiAU0o1gTKdRgNU03hjn2w7hvnjx7/z2ZI0fpPYCtBLLpe9UCcTaNH aZtUCQF5fQLxrvaKL/Jcfzb2xx1SINTQSzv9g/rzmoZjX8skyhfK/JHgCX8YfPXV9cJUHuBL0EW BYuYU6H8HBJW0C1vm+BWL+X4801pH1PuGy6OUbQ0fi/lrcHf7Y+d3VnZinSpsTsSvIEOfE7yC2i f/3F8vod6EtIS8d8fRn5Q2sd0Ntsng56JZGTPhzgtCUy8fw6rrnpAuYXLKVdOBUjIh/nnk4LdbA 7c747OOi/515kLf+oLn7QYwk8/j+dsRkCwjxzpAYj2lc/4LyDsp8K6kjQEMM4+2k0Gn+jBmEaE1 DaUw+ahs= X-Received: by 2002:a05:620a:640b:b0:93a:344e:3d3d with SMTP id af79cd13be357-93bb7952c30mr299732585a.42.1789554651924; Wed, 16 Sep 2026 03:30:51 -0700 (PDT) X-Received: by 2002:a05:620a:640b:b0:93a:344e:3d3d with SMTP id af79cd13be357-93bb7952c30mr299726085a.42.1789554651414; Wed, 16 Sep 2026 03:30:51 -0700 (PDT) Received: from [127.0.1.1] ([86.121.170.232]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-49e83dbb0c1sm71633805e9.14.2026.09.16.03.30.49 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 16 Sep 2026 03:30:50 -0700 (PDT) From: Abel Vesa Date: Wed, 16 Sep 2026 13:29:01 +0300 Subject: [PATCH 45/48] clk: qcom: videocc-sm6350: Use common probe handling for always-on clocks Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20260916-clk-qcom-rework-legacy-always-on-clocks-v1-45-25a24e50f82a@oss.qualcomm.com> References: <20260916-clk-qcom-rework-legacy-always-on-clocks-v1-0-25a24e50f82a@oss.qualcomm.com> In-Reply-To: <20260916-clk-qcom-rework-legacy-always-on-clocks-v1-0-25a24e50f82a@oss.qualcomm.com> To: Bjorn Andersson , Abel Vesa , Stephen Boyd , Brian Masney , Jerome Brunet Cc: linux-arm-msm@vger.kernel.org, linux-clk@vger.kernel.org, linux-kernel@vger.kernel.org, Abel Vesa X-Mailer: b4 0.16-dev-0e65f X-Developer-Signature: v=1; a=openpgp-sha256; l=1619; i=abel.vesa@oss.qualcomm.com; h=from:subject:message-id; bh=ceySCAJ2UKzCOMrGPaWITOdmnUsWyZZP02Z5z4V1xcU=; b=owEBbQKS/ZANAwAKARtfRMkAlRVWAcsmYgBqqm92lpQdDIVhwJtswhgBbYl1PCWCOshBFDv1C Hvt8eTpRqaJAjMEAAEKAB0WIQRO8+4RTnqPKsqn0bgbX0TJAJUVVgUCaqpvdgAKCRAbX0TJAJUV VkCpD/9p25/TDcjmOxsChTCBndL0w4M0yWLJqolwW2LcmMwmcSJyyEd07FP88ANnK9xdj9ZE+0A IqAxoIaldFSuqUgpgXmNqhhnuh1rZifZNxEEfcmWUvgLFaGhKr0FpD7g3fOM+AEWGlMHz56i2pH y1j3pcF8YatrFAjis+aFLXxZ9gDH27Ipcpxi6PA8icVVXlaC2pzk9GBrHyP7J5hwGbwY13ywXbu SNkK3PocsYHTEGdLcLHuRn4U+kA2sla3RDDHYQ1Zz05oUQMVbHc8B1rsGFe56BDA90g1l9naTZg OmIuKzXgzEqSeDSA9WsV3sixeNUrSYPlLpsaRE4+GbCJuG4gqY18dujA/spxlY4i7OiyV7bsY8v +4DOYIU/VfFvRwu7Bu2M38rr3dgUNYE+EKuDRuV4al8IsNQcG+OARDOtnn7ngAK4iOVHIEFCvAh LjBVz0aX7Tu5714EOCZk0loAXf5WH4osv+q2NvBFHCmngOuNbyHEBmdp01c8Aa/QYQIPNBzkxdc C/lO1ufJ5cCXuvSmNKkPIrBsdA2egsr5A9OptTXILUA3MiJWSeQCa1BxHxxsNJwzOAWhpb7Kbpt 7E6ureuuSp2oMvPQqYwt/ijs38X9zZAFYoPbwrat2TnMHxAbpt28NHK2zSmi0K3WwFzd7Qw9a/f KxsU0+3oFbUnyUw== X-Developer-Key: i=abel.vesa@oss.qualcomm.com; a=openpgp; fpr=6AFF162D57F4223A8770EF5AF7BF214136F41FAE X-Proofpoint-Spam-Info: AW1haW4tMjYwOTE2MDEzNyBTYWx0ZWRfX1/UeucM7BLVt j+n/O+skYnz/arQPTbkrlWCjDsT1iqX9YnAZGJ74quclv4Xi4Gjhrg95eYhgR6cORhsta/y/0Nu yCXmiwnHzw+PPGDgmAe/T5PFKRdCNUk= X-Authority-Analysis: v=2.4 cv=HrTjiETS c=1 sm=1 tr=0 ts=6aaa6fdc cx=c_pps a=qKBjSQ1v91RyAK45QCPf5w==:117 a=po8fGBi+ks8MzcVQGuqtFQ==:17 a=IkcTkHD0fZMA:10 a=VdqzKS8jKosA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=eoimf2acIAo5FJnRuUoq:22 a=EUspDBNiAAAA:8 a=35KR4dZN77wT4OcJcwEA:9 a=QEXdDO2ut3YA:10 a=NFOGd7dJGGMPyQGDc5-O:22 X-Proofpoint-ORIG-GUID: eG6NO7BW7t20OpwAXNNDxiNRa2KIeY6A X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwOTE2MDEzNyBTYWx0ZWRfX2H4n+2a9VfHP YqufW7/l+AhOiNpdFyi9tf9V5j/1jMv/AZxMxNn7oZaXpZdjnT062RZfnGYyLb8Tam1tnsN6OCc K6oMrNI5FvWkyd4yLzVVFwN8aOWHELOxUBgjtxCdV64ef2SOcE74vjqtEKxHENPPdeZzMoeR6XD X3GWK09IKhjDE663cgeM2nL4P5Sd7ureZeaisX92gsJaHDQJiX7NJzZXkuQ+lfAwFaC8IwvZPL1 4za2eXs4eSgPcLw3BaEbGGQTYsbLO1d4zUf5dldcVG4rD3glmhoZ6Sqejjjrbh1k9Uf1B6smJC1 1Kxf9KaLsPnnGCo8GM3uL9BXanaBTRjvinMHIquta24qOc0MwPw6qlIVmzfs+O4YazdFmVbi2sv rjpqq/CB9riX0PfQ7pkJE8qrU0zVA6lyGe/2cuEXCzaIt3z9ZHs0TcdHwFTjzEgnLbyT1+uynOn tJ+ROX8yJxJMkXTnx8w== X-Proofpoint-GUID: eG6NO7BW7t20OpwAXNNDxiNRa2KIeY6A X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1176,Hydra:6.1.134,FMLib:17.12.100.49 definitions=2026-09-15_05,2026-09-15_02,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 suspectscore=0 lowpriorityscore=0 impostorscore=0 bulkscore=0 phishscore=0 malwarescore=0 clxscore=1015 priorityscore=1501 spamscore=0 adultscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2609040000 definitions=main-2609160137 Describe the always-on branches in a critical_cbcrs array and reference it through qcom_cc_driver_data. Let qcom_cc_really_probe() enable these branches instead of programming them directly in the driver's probe. Assisted-by: LLM Signed-off-by: Abel Vesa Reviewed-by: Konrad Dybcio --- drivers/clk/qcom/videocc-sm6350.c | 13 ++++++++++--- 1 file changed, 10 insertions(+), 3 deletions(-) diff --git a/drivers/clk/qcom/videocc-sm6350.c b/drivers/clk/qcom/videocc-s= m6350.c index 34bdc5aa865a..d3926f87497c 100644 --- a/drivers/clk/qcom/videocc-sm6350.c +++ b/drivers/clk/qcom/videocc-sm6350.c @@ -311,7 +311,17 @@ static const struct regmap_config video_cc_sm6350_regm= ap_config =3D { .fast_io =3D true, }; =20 +static const u32 video_cc_sm6350_critical_cbcrs[] =3D { + 0x7018, /* VIDEO_CC_XO_CLK */ +}; + +static const struct qcom_cc_driver_data video_cc_sm6350_driver_data =3D { + .clk_cbcrs =3D video_cc_sm6350_critical_cbcrs, + .num_clk_cbcrs =3D ARRAY_SIZE(video_cc_sm6350_critical_cbcrs), +}; + static const struct qcom_cc_desc video_cc_sm6350_desc =3D { + .driver_data =3D &video_cc_sm6350_driver_data, .config =3D &video_cc_sm6350_regmap_config, .clks =3D video_cc_sm6350_clocks, .num_clks =3D ARRAY_SIZE(video_cc_sm6350_clocks), @@ -335,9 +345,6 @@ static int video_cc_sm6350_probe(struct platform_device= *pdev) =20 clk_fabia_pll_configure(&video_pll0, regmap, &video_pll0_config); =20 - /* Keep some clocks always-on */ - qcom_branch_set_clk_en(regmap, 0x7018); /* VIDEO_CC_XO_CLK */ - return qcom_cc_really_probe(&pdev->dev, &video_cc_sm6350_desc, regmap); } =20 --=20 2.54.0 From nobody Fri Sep 25 05:31:34 2026 Received: from mx0a-0031df01.pphosted.com (mx0a-0031df01.pphosted.com [205.220.168.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 0D2F24F55B9 for ; Wed, 16 Sep 2026 10:30:58 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.168.131 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1789554678; cv=none; b=e4p2IujuvAv8CF85rgj5gb2OC0juqoG+5Ozs6JMXfB8SjZoI1GpV7dFCMK38DuGIErr9YWMXXxffBSaOLhVG1cOIPLxpoqpStbT2EeNSiuIEGMDz0PnCR/cvkUUfNvEwButG2fKz2z7C6m6P7xpL2qSuZsevBQDrfpWWtyKFvdI= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1789554678; c=relaxed/simple; bh=iz3ufEAKkkYlJRxzb+jInn8jCy6Z8EJIEctOZKqgVTs=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=o3u+/oDvhULnKRq7pvwreQll1fuCJw1CfiuM4kxtWZuMnLTnSbzRWTIz6cC69gSW2Qv0FGKBbSDvqgLBrdifc1ACbA6Bu55kBfyE81KxgENP+cZgVFhyOqx4DLktWEhVW5iVgqnVhKiz3xzqxrGt660i7ZoErZrqyI0dfQfai+w= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=IkUz9txc; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=bfbDXT0v; arc=none smtp.client-ip=205.220.168.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="IkUz9txc"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="bfbDXT0v" Received: from pps.filterd (m0279863.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 68G92g3G2348128 for ; Wed, 16 Sep 2026 10:30:55 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= aNZ7T/K1K/h3C/amGLynz6dtFRmOnZ0U+RH3dZePgE8=; b=IkUz9txc+4g7/Z2V cXzCxvVZOIDkj5pPQvUVOVjia6pJZODID4H3Vw1vriFiwW2SKEIubvMmX02jIm+p sMBy1zhRH3IINJR+VZfI742XvWvibFlVn2uDVZ9P3Mp8kGywT3szAWIX2EtwxkzO W/qHWSTsa776RssS46FH1Y83SkAzABjcUXmE2xJESP8mL8vyg3lvuN1i9FmAHM2t j9qOzhUBQNKK2F5apCHgCdcvcw+xTAj8CJXEPdDlySXYcynaQ4iGzB9hDAFP44Lt IES3tA4MjKn5jjrP4tltzrqOSO6kU0anoWn9H7eerDpZIIBvD3P1TiFtKVqlpv6K AbSe4w== Received: from mail-qk1-f200.google.com (mail-qk1-f200.google.com [209.85.222.200]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4gqdywas96-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Wed, 16 Sep 2026 10:30:55 +0000 (GMT) Received: by mail-qk1-f200.google.com with SMTP id af79cd13be357-93903622880so379584385a.0 for ; Wed, 16 Sep 2026 03:30:55 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1789554654; x=1790159454; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :content-type:mime-version:subject:date:from:from:to:cc:subject:date :message-id:reply-to:content-type; bh=aNZ7T/K1K/h3C/amGLynz6dtFRmOnZ0U+RH3dZePgE8=; b=bfbDXT0vjeTBSGZiay8XgvCYtINYzjEdnt6+XSO/ycUZLzRrwUk8BevzNLAOIjrBy2 tQ1HTIvlxsjQ9WhUw56igJvwp/9PZ7XUhDYTx/OaASUAqgbV2nPveSslS92lBKT5pl9a sRdHn67EcmYmF4sJwPBEcRYBzyUGId7YCZCG2BteVpgGf44xDk9M9R0MbDp9nbY9xCb2 XVwTLaDxAcXIY/gWPccdLQnbT14ar3W+jPulVrSz+thMzxILv89/3+g3jL1IKmUxnDIK kFcGWXKRN3PXi6nj222tlWpFibGGyoj8uCkk36CnRL8DggypHGnt2kLVSahjzijuHiry fciw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20260707; t=1789554654; x=1790159454; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :content-type:mime-version:subject:date:from:x-gm-gg :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to :content-type; bh=aNZ7T/K1K/h3C/amGLynz6dtFRmOnZ0U+RH3dZePgE8=; b=CszL3V1LJpsxWpRgZeL+eukdmMyfAPZawIQ9EYLW2Zh5kNwp+QO1yzyyg2AFl7QxjR FXVM3p09KwbOCtvPggFmJ2EoDEyJUQU5k2SdJRt2/TLfdp+pr+ywa7rjEs+Nf7i+lRIV tSaiGf8ARt8SdwdU7gN825juX3FV9v6u28iatBMeNdt3S0snauKbjYLgE07sRiDNa8yR ItFgqBRpOwYBzfnM1sa4EEGRIcTkv3K6PRzXSX/cgzIr9HiDINtngpH2yYBkWri3qZBG 7LLep5vFA9KQtZdJzSVwYCrX/PnqenYalM5EoRSojex29vuVQggXN/+EL/0HbP1yd+JI 4YDQ== X-Forwarded-Encrypted: i=1; AKwUvBw2HtbMQGiCc5kZBPB3w2aXEI3ufdm8YGQd7wwf+hEXWVIHLCTtdWNzAiIkTX4ZEo6p6Z5bAZGCk/gKHQo=@vger.kernel.org X-Gm-Message-State: AFuF++maRGKaDi+vnclbGrKAjJtBYoTTPIFsopvXL2zF+dk6L1J8Ch+6 bV78e6m8mRO7vn8tBw/HTFeulizuYtkoNs8vUxAM0DZmMlVMK+pKlm++rbJQVfEmptutnbNPf7B nz/dYH8z9XHQ5PeyrfYOlq58BKpQuYqTjdcBq7RGxzOTTeDQupefFkLpwH9zauTX67ro= X-Gm-Gg: AYBFou2ZC2EOw2m1IedvVD4xnof3x+trXuaj52LiWfTTB41FIMDp9dL8CcO+oHXojGC yY5AppaoSrRUiO+KRed21dPHjI85MYdFTfmqR9nqYH0gl8X3YsusRpK4hrmLuDoc2AGyhQVhdVq eyTREXpgb1x0TavebJgXfLki9YFosOerX1elLUKTS5yITcYUmCiPlxWYEYxWFdhAl33Hhmh6l+4 GAXtRX1cgyofd0p7gWU1hWIO1+O9lbuodgh8zW3Tsjcz3dxL5Ji0QP+JBaKcX5lKcTnLPgrRwk1 3USPeWiRiVBDkNo49vojEEqMR5d+6S7z1Wtl5GMtLYVZKf8CHT1FWw+xi8oDnnqy1+Br8MD+g/T 2UmRq+YM= X-Received: by 2002:a05:620a:44ca:b0:939:db29:4c11 with SMTP id af79cd13be357-93a3477c99fmr1003072085a.46.1789554654157; Wed, 16 Sep 2026 03:30:54 -0700 (PDT) X-Received: by 2002:a05:620a:44ca:b0:939:db29:4c11 with SMTP id af79cd13be357-93a3477c99fmr1003064685a.46.1789554653617; Wed, 16 Sep 2026 03:30:53 -0700 (PDT) Received: from [127.0.1.1] ([86.121.170.232]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-49e83dbb0c1sm71633805e9.14.2026.09.16.03.30.51 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 16 Sep 2026 03:30:52 -0700 (PDT) From: Abel Vesa Date: Wed, 16 Sep 2026 13:29:02 +0300 Subject: [PATCH 46/48] clk: qcom: videocc-sm7150: Use common probe handling for always-on clocks Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20260916-clk-qcom-rework-legacy-always-on-clocks-v1-46-25a24e50f82a@oss.qualcomm.com> References: <20260916-clk-qcom-rework-legacy-always-on-clocks-v1-0-25a24e50f82a@oss.qualcomm.com> In-Reply-To: <20260916-clk-qcom-rework-legacy-always-on-clocks-v1-0-25a24e50f82a@oss.qualcomm.com> To: Bjorn Andersson , Abel Vesa , Stephen Boyd , Brian Masney , Jerome Brunet Cc: linux-arm-msm@vger.kernel.org, linux-clk@vger.kernel.org, linux-kernel@vger.kernel.org, Abel Vesa X-Mailer: b4 0.16-dev-0e65f X-Developer-Signature: v=1; a=openpgp-sha256; l=1607; i=abel.vesa@oss.qualcomm.com; h=from:subject:message-id; bh=iz3ufEAKkkYlJRxzb+jInn8jCy6Z8EJIEctOZKqgVTs=; b=owEBbQKS/ZANAwAKARtfRMkAlRVWAcsmYgBqqm93T8BN4//sQDc+JC+1958KF0tw9CeD0HByz 2SnsgYqwGaJAjMEAAEKAB0WIQRO8+4RTnqPKsqn0bgbX0TJAJUVVgUCaqpvdwAKCRAbX0TJAJUV VspbD/9IGQ0GrBZx7Fd6zDEFrSrBT5WoGqwAhzcN18I0Vo1A81GsCEf57KuKITJZGhZgyeXym5/ GlhyHz1w4IoWWoMmt8D7e1edaBsmwb3zeq4pyb9wWneldHvPlF5+nMPgCSTJUUhvF7rilNp5olL f33af+VdEmro7Z94w83y6tZAy/y1mH/pZgNMbIbHDi++BRJSlcRAxLi0a+OpK8495dBc80immXa L3S75uebT8oX+O4E54P3KOwWS4cHu8adqVxzTzw0Duayeg2fQ+bDFIjMpOUNyviSm6EmoUzGC2u OLElPWo4vGq9hY/76OTIzxTCVURWTNebgVZdHunoUZR8S9Wkitfaxl7qGTqokszwTwESUKlQtKa /eHe8ByGbfCxTYULj2SqF2INz9tV1hrFnEaD/c1eCvUWPzO1AjXZ1SbGFag/Re/4526raTRyyLU 9lD0GrYfUmWQWCmthqW0dG1u1u870KiWWMTjj0sQu/UAsUtCTPIvMUR/59pGYYnJkWwEldBHsBw cChh/SHxF6Ud95ajWI31I0ypbb8MISIlRikfMvLWJ8L9Ta8Z8iN9hKuOmMJX18Ykvp9yqrEsEJU MNB3IZplnJiJpEaE9sVQxK275wzE7alh9YMYCu7fS+ocBgjlB9XuE+itG5QMxsb/v6HGJKSCaFs rxTZK3dxQuH0Dcw== X-Developer-Key: i=abel.vesa@oss.qualcomm.com; a=openpgp; fpr=6AFF162D57F4223A8770EF5AF7BF214136F41FAE X-Proofpoint-GUID: nDjTX0ABO1qhAfbbjboIpO6r32-uKldN X-Authority-Analysis: v=2.4 cv=aJ1lOr9m c=1 sm=1 tr=0 ts=6aaa6fdf cx=c_pps a=hnmNkyzTK/kJ09Xio7VxxA==:117 a=po8fGBi+ks8MzcVQGuqtFQ==:17 a=IkcTkHD0fZMA:10 a=VdqzKS8jKosA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=yOCtJkima9RkubShWh1s:22 a=EUspDBNiAAAA:8 a=sYFbF2zXfO1Ub-DH1h4A:9 a=QEXdDO2ut3YA:10 a=PEH46H7Ffwr30OY-TuGO:22 X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwOTE2MDEzNyBTYWx0ZWRfXxtyMKF/YJRkV cruiGqbsKWUWSGiHXFsSchCcOzO0qnp5x599aS7GXvqlYvl7JqZlV10SmHuoEJauffYEQuugc28 fh1ynsMNPxa1Tc++F2lUqpbpKYvWsxJoGeJu/DrgP6x5UQMhtZ/MxbddnNL8kuQv9BygSaP6kfD Eewmc4rsfOiPdwmkbXf23OoC1YJgUuBnqs3aDrgU1mgxJn8uZsa73/UWWSqq3uiAdDErMO00Umk yAiMEI2G8UDPX5ZGPTU17OAWGck1AH10tKIbkWn2TykBqyvOoP71AWb97CkivpK1/73eRIGwE+u dlFf+jSgSPVqvbttHUKLPwP3v7WvyxfazSZezAfn2QvLGTXpIysB6h1YDIpH2sVql5/JbiitLa3 ODrdx4lLNt2XyUj+iXvZc6LUKwz/JffgNOLiKdWXjGUxuUf/3LnxeoRNEPTxFDjGziFzgrWBj4S bQ3HG7pD+21ANinqnww== X-Proofpoint-ORIG-GUID: nDjTX0ABO1qhAfbbjboIpO6r32-uKldN X-Proofpoint-Spam-Info: AW1haW4tMjYwOTE2MDEzNyBTYWx0ZWRfX1QyTC8wOjXue ZUzIatXUmGSo1eyAd/ualzh6jfo++6eGccxDfFlRGbdWa9uJFWAv6z8QbwSbB3MKV5ZP6tY14Ci RT4y+51KCCou/4e9BrxehDVrQf9GwaU= X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1176,Hydra:6.1.134,FMLib:17.12.100.49 definitions=2026-09-15_05,2026-09-15_02,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 adultscore=0 impostorscore=0 phishscore=0 suspectscore=0 bulkscore=0 malwarescore=0 clxscore=1015 priorityscore=1501 spamscore=0 lowpriorityscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2609040000 definitions=main-2609160137 Describe the always-on branches in a critical_cbcrs array and reference it through qcom_cc_driver_data. Let qcom_cc_really_probe() enable these branches instead of programming them directly in the driver's probe. Assisted-by: LLM Signed-off-by: Abel Vesa Reviewed-by: Konrad Dybcio --- drivers/clk/qcom/videocc-sm7150.c | 13 ++++++++++--- 1 file changed, 10 insertions(+), 3 deletions(-) diff --git a/drivers/clk/qcom/videocc-sm7150.c b/drivers/clk/qcom/videocc-s= m7150.c index 8d2e00799f96..32bad5e09056 100644 --- a/drivers/clk/qcom/videocc-sm7150.c +++ b/drivers/clk/qcom/videocc-sm7150.c @@ -313,7 +313,17 @@ static const struct regmap_config videocc_sm7150_regma= p_config =3D { .fast_io =3D true, }; =20 +static const u32 videocc_sm7150_critical_cbcrs[] =3D { + 0x984, /* VIDEOCC_XO_CLK */ +}; + +static const struct qcom_cc_driver_data videocc_sm7150_driver_data =3D { + .clk_cbcrs =3D videocc_sm7150_critical_cbcrs, + .num_clk_cbcrs =3D ARRAY_SIZE(videocc_sm7150_critical_cbcrs), +}; + static const struct qcom_cc_desc videocc_sm7150_desc =3D { + .driver_data =3D &videocc_sm7150_driver_data, .config =3D &videocc_sm7150_regmap_config, .clks =3D videocc_sm7150_clocks, .num_clks =3D ARRAY_SIZE(videocc_sm7150_clocks), @@ -337,9 +347,6 @@ static int videocc_sm7150_probe(struct platform_device = *pdev) =20 clk_fabia_pll_configure(&videocc_pll0, regmap, &videocc_pll0_config); =20 - /* Keep some clocks always-on */ - qcom_branch_set_clk_en(regmap, 0x984); /* VIDEOCC_XO_CLK */ - return qcom_cc_really_probe(&pdev->dev, &videocc_sm7150_desc, regmap); } =20 --=20 2.54.0 From nobody Fri Sep 25 05:31:34 2026 Received: from mx0a-0031df01.pphosted.com (mx0a-0031df01.pphosted.com [205.220.168.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id C1F0F4EC65C for ; Wed, 16 Sep 2026 10:30:59 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.168.131 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1789554681; cv=none; b=X2/bcw29qIQgDOu2JsjMK6/PdmYulTXBYn3vywewp5ETm7vW+rkfstjvjTMErAhXn9sXiqjFYDUTZtNIDGWteoOFuhKXFYV0Jc+KE2ki88EMHE8zTCmK07FALJb+ar938ZX5s89j3sljjX66gdMsk0/wwxuRlaVPluXktEUzl3g= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1789554681; c=relaxed/simple; bh=3rAc86SAe8f9DGEWeZ9p92FJCjKy05IFaeUgSXFCFIY=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=mFKzP8mT+pC8mRPtHgHlCgqCO/phjBSQyOHX2TV+IS99SMH1ojtrXILsvU68qvwfQhXHDml//RRZKe2JFTMV1vMUVSvNxDrYK/qk3PR69pS4NkNebTOXFAj/LfKihmhucilMsNmdDy+o85jRyFk8+OkzFXJohdTDDiqA6uuLLUE= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=RfBl7szR; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=bLmUxz/Q; arc=none smtp.client-ip=205.220.168.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="RfBl7szR"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="bLmUxz/Q" Received: from pps.filterd (m0279863.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 68G92g3H2348128 for ; Wed, 16 Sep 2026 10:30:57 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= vBBrVQhaf70Wipe9bGWZ3gZ34yPtOrrQmP9XE++j+uY=; b=RfBl7szRIl2WBAWO XSqK9DfrKCmFbPNRbwiCIARxc09zRCJFtnqwP46X0NmvIsQo77BAawLuVsuLg8KF U9r+61rNXybk8nYsdvu7PahedPriDcKSTqN1BxLHG3Z1HbxBeWVmvcE31lhCuO4Z dw3q+9kwaTlMz2kngDiQccDqChrPcPn+ihTOPBA2vs9gAixzlwlgTZ3M5OnyRfAt yBAw5MqSOx06MwNvOLZm3RiKxzreA+51fp2l+XW6XKPqUz0//pKq/U3oxkZhEF9X 6GYa9e6cXCk+fqwQ+9hWYMk7TXDIhYR6KhcBLMdrsx8gp6HSWd12megpEMkkJg41 NfKGWw== Received: from mail-qk1-f200.google.com (mail-qk1-f200.google.com [209.85.222.200]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4gqdywas9d-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Wed, 16 Sep 2026 10:30:57 +0000 (GMT) Received: by mail-qk1-f200.google.com with SMTP id af79cd13be357-93a08ff8451so657912885a.2 for ; Wed, 16 Sep 2026 03:30:57 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1789554656; x=1790159456; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :content-type:mime-version:subject:date:from:from:to:cc:subject:date :message-id:reply-to:content-type; bh=vBBrVQhaf70Wipe9bGWZ3gZ34yPtOrrQmP9XE++j+uY=; b=bLmUxz/QrsVCvCBnuZhZTdC66F8wLaVvLtn/1MjwDaV65r2y9M4hm3k1Vic8fbgq7m fInwCLRFWrDc/1k0K5F8gKqW5qUoBtiqcPSef6b5s2xhgf/BmW8jHwbTGCr4ZhQ8yyxY DyJiCrWFniuFwIr11if4EgjT8br/sl1lcvQQCT4E8+W6lbbcBwXG28NRgxQd2X/7iQ1J 1PXBfLk3CL8QfhOIZ2A7vBZQ9hfniQQkb2ysFTxGBbem+FOwyAhLfN9C4bn2k9aQh3pJ XtFnLRJYguTuMayKRSqpaPqGhGQpN5COEO6+gid+KY/q2CPTHM6Uy+8m+veuPKWgtrY9 Ho9w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20260707; t=1789554656; x=1790159456; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :content-type:mime-version:subject:date:from:x-gm-gg :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to :content-type; bh=vBBrVQhaf70Wipe9bGWZ3gZ34yPtOrrQmP9XE++j+uY=; b=eN/EwOaX+wr3ORw4YjOjpvbe8h2JYaH4NpzCr9w/q55mlcGn9SK4diQjnOVHutOo9j AMVdlHdqnzgSImFwiazbmOFidgBYUyG+y4a2LQn/vbVkMnklXlIi186aOEXxsRmPwrtS 9nxOOx0/Mejx0DY/5MeTS3i+jDHI8DeqXc+xvMeTallwgAwyz4hqtbzJFCvn2Efg9a7f GTvlwYCISuI2JXHiKpi9gdpOr6xxHCGbk0v0OfBXrlJubboApdlbZ3vJttUKPDuxJi0Q q4utd9LOh1GpjI5IwRyWGBSf92NJccfoB17DgfmeAEunqP7k/FwloRRRZu6sKfi3pbkn JJLw== X-Forwarded-Encrypted: i=1; AKwUvByKK31Z0WXbdAIZsdvzMLPc1fmWyfQMiSJy4E3yYQ+b13hy1HbP0RUSRVmEWgbqoS3MxRSic8hI+j5DM+w=@vger.kernel.org X-Gm-Message-State: AFuF++k5f7eRnvp++K0pjcHXB3ANWwy/ugKRkGOgU97XHXky2oyIwBME BMAqFRWLUGIcVOi+ebJnjB69U0j4sUvQR6+LdrUleXcTLdc7yu2tw694RhKkcU09KhsBxAh8Stt +1ttiIJObbDZZH+rERMnog1fVEsD2/606zkOJnVxGnwlASBDEUDjKtCYIoNedGEq5Ubw= X-Gm-Gg: AYBFou3sQ6RbjWIgsXG9pOHd2pO3t0hy9a9/xTVx8dBaLWwaWd73V7aOm4CpENw2H2H zuOns63zeEAhH7AEc+wRNgDA7xUWhd9RiQuXKOp7HtVGJGQuwdDpeh6OFSNJYz0FQF1v5o6F206 W284vACnOwNBm9yCgChZVSPSLcKzZqDunQri3/PZHk4BzNW5/TUhv0g0vG/aCvKhu88PJbs5+HT mD1FdZyYFsZLjSkGBeKWwcBbuEcEY65k8+OLkH21QHo2FiNHidQ0Yi0WbJPgsR3FG0RN3tebMeZ yG6mAtebKMmsMigeDrXqweFF/p7ourz3ykW3insWQXKiQVuLxJ9nPpM+H1Gm+XjaETtuHOlorWY BwgJqDYM= X-Received: by 2002:a05:620a:890b:b0:93a:2ea6:4c6e with SMTP id af79cd13be357-93bb794cb7cmr318028985a.45.1789554656174; Wed, 16 Sep 2026 03:30:56 -0700 (PDT) X-Received: by 2002:a05:620a:890b:b0:93a:2ea6:4c6e with SMTP id af79cd13be357-93bb794cb7cmr318021385a.45.1789554655592; Wed, 16 Sep 2026 03:30:55 -0700 (PDT) Received: from [127.0.1.1] ([86.121.170.232]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-49e83dbb0c1sm71633805e9.14.2026.09.16.03.30.53 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 16 Sep 2026 03:30:54 -0700 (PDT) From: Abel Vesa Date: Wed, 16 Sep 2026 13:29:03 +0300 Subject: [PATCH 47/48] clk: qcom: videocc-sm8250: Use common probe handling for always-on clocks Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20260916-clk-qcom-rework-legacy-always-on-clocks-v1-47-25a24e50f82a@oss.qualcomm.com> References: <20260916-clk-qcom-rework-legacy-always-on-clocks-v1-0-25a24e50f82a@oss.qualcomm.com> In-Reply-To: <20260916-clk-qcom-rework-legacy-always-on-clocks-v1-0-25a24e50f82a@oss.qualcomm.com> To: Bjorn Andersson , Abel Vesa , Stephen Boyd , Brian Masney , Jerome Brunet Cc: linux-arm-msm@vger.kernel.org, linux-clk@vger.kernel.org, linux-kernel@vger.kernel.org, Abel Vesa X-Mailer: b4 0.16-dev-0e65f X-Developer-Signature: v=1; a=openpgp-sha256; l=1810; i=abel.vesa@oss.qualcomm.com; h=from:subject:message-id; bh=3rAc86SAe8f9DGEWeZ9p92FJCjKy05IFaeUgSXFCFIY=; b=owEBbQKS/ZANAwAKARtfRMkAlRVWAcsmYgBqqm94EnovDHGLJ+03v7fpgm7QWClslVzwmA8YC PP9Y5HgrnuJAjMEAAEKAB0WIQRO8+4RTnqPKsqn0bgbX0TJAJUVVgUCaqpveAAKCRAbX0TJAJUV VouMEACpemPheWxRgLy+jnzYQ7F6u5LFo16dAtXnX5HsxySTE4u2PW93e/tqm2JqW+zFDQJ7Pp0 VWgT/gquNis63hZ//Swk8lMDGxMjv3uzzJvixCELbZxmwF7QLZee74QKMpalc9zLWKnHdH1+L02 T18a8aTdk82vEuBlbEaBD4m/oWD+bnbJzo9nEqF1gqL8j9xiykFLOa+x1CVehC1o2NIG3z6DMqK efXe/QPBnJ5Iyo3uua4bcSw193RfWdauxBXv84Fgecc5OpOWDcvNVKpqn9tNfczCR2VDkpcqJqM xYY19dJj5d3c+JwC6XCX+zOmlGEhKNQCUtgxEIllbfUIm1tKTuRQiVM2ooK15291ahBhwh96HxB 7Nmg1jcqRRUvPKQVkHO4Gu/USyGqJ0SdOUSQyYB6TSbf76BkzaPIetEe8xRLyjMF3caoldL5seY pl/EhjSLQE2wpYYkkgKk4udTK21n5QeptZI4iN2gt0DnEVUxUxrWSBuBB0qdIgBaHdMVFYEMe+E ETRnlXeuXUXsWSVuN8GVlaq2yIF6E9Ca3S7txMC0IrayxVkW4G1IqE7V8I1fCvtgXGl/VIBgIzQ 3vnnOFyl9X3dEEbYMHQ1AePQVNRl7SGnQhud/IfCvtxBKTJhYMJEUlP+XXMFpzqyhQt1kRsx3B4 k9Gmhtkm4ysislQ== X-Developer-Key: i=abel.vesa@oss.qualcomm.com; a=openpgp; fpr=6AFF162D57F4223A8770EF5AF7BF214136F41FAE X-Proofpoint-GUID: bViq_8mCfYrA86DNwpC-FMfAgbPk6mRV X-Authority-Analysis: v=2.4 cv=aJ1lOr9m c=1 sm=1 tr=0 ts=6aaa6fe1 cx=c_pps a=hnmNkyzTK/kJ09Xio7VxxA==:117 a=po8fGBi+ks8MzcVQGuqtFQ==:17 a=IkcTkHD0fZMA:10 a=VdqzKS8jKosA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=yOCtJkima9RkubShWh1s:22 a=EUspDBNiAAAA:8 a=w5mbRZx1dI4nJrn9fZAA:9 a=QEXdDO2ut3YA:10 a=PEH46H7Ffwr30OY-TuGO:22 X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwOTE2MDEzNyBTYWx0ZWRfX4vMCGhXneLBS rF2oqtK3EJXz7MAbUfUPXH8+Enk0RBZ4ILuR5POgeu26MwU2I/PmShu9g+0FynY3GiclUNRVhTY UDJ19SIObLO6UnHHfTJkeSmbxclEzmmCFKCKR5rZmX1lq35VVZksJWxMufbfdyN2e/pdwyDQjRB c4OvOJ1vQBHH0zNomgdMOcyoPHQj1lyZssA1XiKR2GcZKTXagvYHcs8GlX6XeEMGE3i+0jLzdwc D6mUFKJKmNdBzXQzG8Ee5DrvVhQF6hQmnM0JsauFNKuUPF/nLICV5P05/P2chELstd6vxhOn4/L GGj9vnhjX6R3spROmHFn0qX18eTYaLb/sSX/dW709yCBHWlJ4wmj4OZn3PDOsjfw62sCYE8zvf5 cvuUh1vACQAO3FBEMrr8XtUI4OaD/gJhTKvfapA+xYPrkCeFLDIrTr41SQ8jddaEUiKuYluPOAn MRG/vjOFYBYaYo5cvxQ== X-Proofpoint-ORIG-GUID: bViq_8mCfYrA86DNwpC-FMfAgbPk6mRV X-Proofpoint-Spam-Info: AW1haW4tMjYwOTE2MDEzNyBTYWx0ZWRfX/5ElYmaNkJDc FrpEZPV3EzsCD8l/ouZmZT/iMBr2TrTiK6oSu7vcgmTLmKWBmLjjcsScaYqnX8Jq/kDA+QPUbp8 d7LSpp+hLMswWDyoTtcMz6anNdhaLfw= X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1176,Hydra:6.1.134,FMLib:17.12.100.49 definitions=2026-09-15_05,2026-09-15_02,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 adultscore=0 impostorscore=0 phishscore=0 suspectscore=0 bulkscore=0 malwarescore=0 clxscore=1015 priorityscore=1501 spamscore=0 lowpriorityscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2609040000 definitions=main-2609160137 Describe the always-on branches in a critical_cbcrs array and reference it through qcom_cc_driver_data. Let qcom_cc_really_probe() enable these branches instead of programming them directly in the driver's probe. Assisted-by: LLM Signed-off-by: Abel Vesa Reviewed-by: Konrad Dybcio --- drivers/clk/qcom/videocc-sm8250.c | 15 +++++++++++---- 1 file changed, 11 insertions(+), 4 deletions(-) diff --git a/drivers/clk/qcom/videocc-sm8250.c b/drivers/clk/qcom/videocc-s= m8250.c index df479a69cddd..d29d64138508 100644 --- a/drivers/clk/qcom/videocc-sm8250.c +++ b/drivers/clk/qcom/videocc-sm8250.c @@ -345,7 +345,18 @@ static const struct regmap_config video_cc_sm8250_regm= ap_config =3D { .fast_io =3D true, }; =20 +static const u32 video_cc_sm8250_critical_cbcrs[] =3D { + 0xe58, /* VIDEO_CC_AHB_CLK */ + 0xeec, /* VIDEO_CC_XO_CLK */ +}; + +static const struct qcom_cc_driver_data video_cc_sm8250_driver_data =3D { + .clk_cbcrs =3D video_cc_sm8250_critical_cbcrs, + .num_clk_cbcrs =3D ARRAY_SIZE(video_cc_sm8250_critical_cbcrs), +}; + static const struct qcom_cc_desc video_cc_sm8250_desc =3D { + .driver_data =3D &video_cc_sm8250_driver_data, .config =3D &video_cc_sm8250_regmap_config, .clks =3D video_cc_sm8250_clocks, .num_clks =3D ARRAY_SIZE(video_cc_sm8250_clocks), @@ -383,10 +394,6 @@ static int video_cc_sm8250_probe(struct platform_devic= e *pdev) clk_lucid_pll_configure(&video_pll0, regmap, &video_pll0_config); clk_lucid_pll_configure(&video_pll1, regmap, &video_pll1_config); =20 - /* Keep some clocks always-on */ - qcom_branch_set_clk_en(regmap, 0xe58); /* VIDEO_CC_AHB_CLK */ - qcom_branch_set_clk_en(regmap, 0xeec); /* VIDEO_CC_XO_CLK */ - ret =3D qcom_cc_really_probe(&pdev->dev, &video_cc_sm8250_desc, regmap); =20 pm_runtime_put(&pdev->dev); --=20 2.54.0 From nobody Fri Sep 25 05:31:34 2026 Received: from mx0a-0031df01.pphosted.com (mx0a-0031df01.pphosted.com [205.220.168.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 0A1C43AAF70 for ; Wed, 16 Sep 2026 10:31:03 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.168.131 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1789554667; cv=none; b=fg0cVixd9+jEtuVrCln/+CDmqXyTvbrH2zRggHFFIcRFM7ZAl5FL8EhwN28OOAc0918I0uldEIBfw/UctVg5tv+Io7BCYv5Ouy4q0swDsua9vq6GqSqpEzpi+IKUzLYI4CyT42RXXnuNOKvhufN557AKZ/wezEtySDAFFuLNHlI= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1789554667; c=relaxed/simple; bh=rMtNd5inLLPVsBRg9EFQAd6EW0dUSKpKAosDfVpFy08=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=bo7lhBWoBaR099Bf2+zF8PD8cdnaPKVMs5HilYD8LQvBjh+VtJcxPuv0xeIZcOPL7beIUAaDwEDI/9N3R+5/lO7jHKpkvgY/NW/bUcEqCI7O96twO4X2FqpBeo8FZJy16tkTRI7PrtkV0GvlX1uBhulM6cveihu/Gr5jjW46CYY= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=LdbBrf7s; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=Z/r6OTu9; arc=none smtp.client-ip=205.220.168.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="LdbBrf7s"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="Z/r6OTu9" Received: from pps.filterd (m0279865.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 68G92hha3169140 for ; Wed, 16 Sep 2026 10:31:01 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= AB9zMkKYXVpm67YJvqjEfp31mZrTUmWg/tW5iEZ5TTs=; b=LdbBrf7sV3uj9rf1 4DNP42lNk6Io3BySgeIlh4ZY+N5JGRUkfK4Lg6MhZfxwylcNEGP+GCK5MUmH6egW x/0apcpIjlXYXIQzLTZMrl1sm2fAqZUP9CVs4CQGVYoshTG74vnQ1pPXGBQKiMoi Bna4PndQjq0yXi3D5s0BZLz8V6JRHFFfBeUs0UnhZYHWE/tQaHBEXgwEOCNg5FtQ 6151nxYVlr/pme79N4fF+x/NP5qHxMFfZz6wu/vFg8uoQa8xYYFE+npdRiv3Xm+S En9tjuE19zJM02uXx/gQzhsKHV77jt3rQeVE1mjhxh8KRXauTSdrRs1zN96ut9w5 6IhOhw== Received: from mail-qk1-f197.google.com (mail-qk1-f197.google.com [209.85.222.197]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4gqpu2rq3h-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Wed, 16 Sep 2026 10:31:00 +0000 (GMT) Received: by mail-qk1-f197.google.com with SMTP id af79cd13be357-9308eafb465so21683085a.2 for ; Wed, 16 Sep 2026 03:31:00 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1789554660; x=1790159460; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :content-type:mime-version:subject:date:from:from:to:cc:subject:date :message-id:reply-to:content-type; bh=AB9zMkKYXVpm67YJvqjEfp31mZrTUmWg/tW5iEZ5TTs=; b=Z/r6OTu9/lZijiii9yHOx/HOfgrjFBFjd6yE/zgH/cZI9M9nnBziJGcmV2XAYEHW6X pU5l711piF+gyoEqvYtD74rYnRuGmtlagZDftem8vRCfkcCaiMmtLFNfqph0hD8nXD9c MsJE2Rphcum68aS8kW9IaB03cIimZuQhcndHzHxwPhrGxwWM5tupC8V3ISOtyERoHZLM MwKn+BrwFlej/qiQRp8X0lorpW5o2UzlcWjrSP3q1ctV4vxod04W9xp31+BTv+K9F5Gu s2lEf1WWdkElZvM0Hk8V5Vd0sb/d0qOif81YBHjR1n7diaG9g5c61KeUPLvkKHEku1Qr POxA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20260707; t=1789554660; x=1790159460; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :content-type:mime-version:subject:date:from:x-gm-gg :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to :content-type; bh=AB9zMkKYXVpm67YJvqjEfp31mZrTUmWg/tW5iEZ5TTs=; b=d/XMHfDuBF2yQkUKcpqMr2Z28SfJYcRMrKM222Bc/hv/uykvCfL16Tmn+sImRRv041 8l5dz4+KjGXEV3VyxsjngS0YbBiRId1MkGSZIFX1xOFsUbUX92u2W3S7GInAMh6ZZBpd C5MxszdvWLZ7+aFAv+ilfBeMsmrWREh/2z7WQwteokWrV6OT8SJV9EkYhtkP8/6v3VYs XnKblhrz4zao2aXmruWe1ORP85mPmWngRNcVfd19b0MsudjhOGY3zG8ml8xFdu7Gb+CR SZ1al2kUpWYdf35y/2KIiX/a0mJuSq+kB/Zd+KfRRBWM7JVqwZE0oRSh/DHTxqrarIKE Wenw== X-Forwarded-Encrypted: i=1; AKwUvBz0XXZyJubxN3Hg4EFC8/Q55weUvM+W6ClfdxsblypZr6YT/Zvc6W6PTgnjeiPIyZjgAEAb3Z2ta6FYpx4=@vger.kernel.org X-Gm-Message-State: AFuF++ljAjL7tkLyN1rAnQ7g6hWEhOXouQWM4UR6GXSw4LGQLHsTZVIH g8OjixlLIsgkXmLfP2AubbbClRjDeF8BDBoMXDM68u2Xr7cO/ZG39zUBT5NQedCIHt70TIa1quh jI4tJki+kTbqh/WGkjP9f2/pVZyMYAon0vq2AF81Cu3HJ1Mw6c6c/ty8O0ItaNrJYa74= X-Gm-Gg: AYBFou145/1nLwS1t/rBJO+wHYxT6/ImRhtEM/T6KtBY5+xBs0dIrr4p3JKM62PEA5k c24sq6xTVnvuKKfpYd/iFH7ARIFUe09wGwNkIedvFyFgO1HSWvYnvCtsHsDLMJ7hDeg73oJG/G1 NJOPFWyz6k8C7ekJoAOfUk6ZCnJEUt7mjDJRrRgVAoCy9BFAIXEG+rzr0GXj97xMGFSDunWz1wo D1cOunGSE324DKRjKmLv//SS2fGt6BQ+YbeeZlHfyzp57qUTpyZHQcB6/JDqO3I3wVG/ubWCQNf 64PTzH6QQPjs5OpvhQ8sWlcuWzHooNi2i1ccw6KMTnG7YghcCCE8siZVtbRLHxUBmPPyzpIGzWO 974RR3tU= X-Received: by 2002:a05:620a:1b84:b0:937:1097:feb8 with SMTP id af79cd13be357-93bb785a7a8mr333206185a.24.1789554659635; Wed, 16 Sep 2026 03:30:59 -0700 (PDT) X-Received: by 2002:a05:620a:1b84:b0:937:1097:feb8 with SMTP id af79cd13be357-93bb785a7a8mr333199785a.24.1789554659120; Wed, 16 Sep 2026 03:30:59 -0700 (PDT) Received: from [127.0.1.1] ([86.121.170.232]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-49e83dbb0c1sm71633805e9.14.2026.09.16.03.30.55 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 16 Sep 2026 03:30:56 -0700 (PDT) From: Abel Vesa Date: Wed, 16 Sep 2026 13:29:04 +0300 Subject: [PATCH 48/48] clk: qcom: videocc-sm8350: Use common probe handling for always-on clocks Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20260916-clk-qcom-rework-legacy-always-on-clocks-v1-48-25a24e50f82a@oss.qualcomm.com> References: <20260916-clk-qcom-rework-legacy-always-on-clocks-v1-0-25a24e50f82a@oss.qualcomm.com> In-Reply-To: <20260916-clk-qcom-rework-legacy-always-on-clocks-v1-0-25a24e50f82a@oss.qualcomm.com> To: Bjorn Andersson , Abel Vesa , Stephen Boyd , Brian Masney , Jerome Brunet Cc: linux-arm-msm@vger.kernel.org, linux-clk@vger.kernel.org, linux-kernel@vger.kernel.org, Abel Vesa X-Mailer: b4 0.16-dev-0e65f X-Developer-Signature: v=1; a=openpgp-sha256; l=3067; i=abel.vesa@oss.qualcomm.com; h=from:subject:message-id; bh=rMtNd5inLLPVsBRg9EFQAd6EW0dUSKpKAosDfVpFy08=; b=owEBbQKS/ZANAwAKARtfRMkAlRVWAcsmYgBqqm95wf4fTycs6dfIv2bVwj/rNy9SsFZ8weo5a J2iDqVjbmaJAjMEAAEKAB0WIQRO8+4RTnqPKsqn0bgbX0TJAJUVVgUCaqpveQAKCRAbX0TJAJUV VrSOD/9DRaFrnFC7FqAfn4FkpGEwD7CY3hBn6l6ZmIgdeK3Mn/RCRA21TCVRHG1A6eC9pGISAiO /zugxMATdqGwOwTChGwKDAzwR6dkjJcYyTm3wdOTxnoNtETloDm2HUxqEnnl97+wBGQKFx/wI9n uUGZ00PYFrnDdsyBA+Ea5frdg3iYsK7dTkyTs/a80gM+YNQnil46FzaRFxVt/jxdo4rN8TAKIal kkwN/bfceJk03OuLwBOM7x5voiSG9S9+mqheCKTkIT4gG3gdiGayr094lBlV53LeIf9hk6Porbt SKfepreYW+UF3z6A4mxo0JCWEqd38m63zbYSeTW3SRNCPzucKi76Tyrtk2n2pDUTJAgp0LxBsUs eQR10AoBmfJx/PESWBtnrEDsB2vMW6gAFmlPkFIlO8fssY/9xomHQLPSBvxCqo+zxLxOvx182Ta MT8U0mFDhTwRFZnAEBlPyGxy1GOPCF46cwQ8ScLidj+Wvi/UuqAFy4NiXpqXijNihz0SvkB6BBD ME7nPcQoKQrNr+j8GBJB9SdfPi8ypjEDPEdP+yv5oINq1ZE/bDDT8nR7r/+xFlHRWavGpCa0o7Q SrNz7O8VPDeMSmdYHG40RIJ8c3vef2mVrh9VcGhM0U59wJt9sdbD+A3in9EgCgnBQm7kY9fwKh1 bDQXcxmKtxnGefg== X-Developer-Key: i=abel.vesa@oss.qualcomm.com; a=openpgp; fpr=6AFF162D57F4223A8770EF5AF7BF214136F41FAE X-Proofpoint-ORIG-GUID: Ela7H8NG5-3-7pLs5NNLqk4rASqXrWod X-Authority-Analysis: v=2.4 cv=NelzRGD4 c=1 sm=1 tr=0 ts=6aaa6fe4 cx=c_pps a=50t2pK5VMbmlHzFWWp8p/g==:117 a=po8fGBi+ks8MzcVQGuqtFQ==:17 a=IkcTkHD0fZMA:10 a=VdqzKS8jKosA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=Um2Pa8k9VHT-vaBCBUpS:22 a=EUspDBNiAAAA:8 a=8NXlPAYpUir2QwZKpCEA:9 a=QEXdDO2ut3YA:10 a=IoWCM6iH3mJn3m4BftBB:22 X-Proofpoint-GUID: Ela7H8NG5-3-7pLs5NNLqk4rASqXrWod X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwOTE2MDEzNyBTYWx0ZWRfX9GPK6AcKw1A1 WKIXvyt7AAYUk+CUHAyJX/x7grNG+vDpb9c4fa5NxHth/aiCfXvVJdujyAVKQ7ENc+mJFoppqJQ oTaAnzTqcQOY6HVXHxoLmbdWSjuWcQGWxuTlYr/+QFaRJc9WWhjyxUEIvDSKd/NAx5hzibuZqFX t/VvT6Exg2+mG8ryOdoBcBL1kPdhgHrElSs8n3Tv2mlLI3QE5K3ExbXARHSft3FR/CQF4xJh2qc G/mg6I1YO6aZXYXzd5jLMr1GHhgPBlHZrYN8zqjSc6q4CT03X5urNTpyE0KckRiQa+NS9+JnjZq Kh31//8x02seurVmZzihTJz7JtSocoD07BuBwvvpzhuKpJyfLbObbrtQCd326SU6KZgSI3UrXPJ MhAeQIMFB9eyp554gg/84jA9M5Ml7oNsO1p+kRNR1VxiF15s1azA23pYDWS34KL3/ToCNUPCohr R28NWiy7E5zE7Ln07mw== X-Proofpoint-Spam-Info: AW1haW4tMjYwOTE2MDEzNyBTYWx0ZWRfXxTsXQwtoWcnj jCjTnTjLaah4gad3JNRcBtVhatKqeK3bbgLcRu6HBDIlCU3PqtE0fhFC///CQTOLXI1PeDKrCkl AXk/IpZwa5k2Lr14UdWx55dW26BU9Is= X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1176,Hydra:6.1.134,FMLib:17.12.100.49 definitions=2026-09-15_05,2026-09-15_02,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 priorityscore=1501 adultscore=0 impostorscore=0 spamscore=0 clxscore=1015 bulkscore=0 malwarescore=0 suspectscore=0 lowpriorityscore=0 phishscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2609040000 definitions=main-2609160137 Describe the always-on branches in a critical_cbcrs array and reference it through qcom_cc_driver_data. Let qcom_cc_really_probe() enable these branches instead of programming them directly in the driver's probe. Keep separate CBCR arrays for SM8350 and SC8280XP to preserve their different XO clock register offsets. Assisted-by: LLM Signed-off-by: Abel Vesa Reviewed-by: Konrad Dybcio --- drivers/clk/qcom/videocc-sm8350.c | 31 ++++++++++++++++++++++++------- 1 file changed, 24 insertions(+), 7 deletions(-) diff --git a/drivers/clk/qcom/videocc-sm8350.c b/drivers/clk/qcom/videocc-s= m8350.c index 057a9474894a..8528aeb3a342 100644 --- a/drivers/clk/qcom/videocc-sm8350.c +++ b/drivers/clk/qcom/videocc-sm8350.c @@ -510,7 +510,28 @@ static const struct regmap_config video_cc_sm8350_regm= ap_config =3D { .fast_io =3D true, }; =20 +static const u32 video_cc_sm8350_critical_cbcrs[] =3D { + 0xe58, /* VIDEO_CC_AHB_CLK */ + 0xeec, /* VIDEO_CC_XO_CLK */ +}; + +static const u32 video_cc_sc8280xp_critical_cbcrs[] =3D { + 0xe58, /* VIDEO_CC_AHB_CLK */ + 0xf34, /* VIDEO_CC_XO_CLK */ +}; + +static const struct qcom_cc_driver_data video_cc_sm8350_driver_data =3D { + .clk_cbcrs =3D video_cc_sm8350_critical_cbcrs, + .num_clk_cbcrs =3D ARRAY_SIZE(video_cc_sm8350_critical_cbcrs), +}; + +static const struct qcom_cc_driver_data video_cc_sc8280xp_driver_data =3D { + .clk_cbcrs =3D video_cc_sc8280xp_critical_cbcrs, + .num_clk_cbcrs =3D ARRAY_SIZE(video_cc_sc8280xp_critical_cbcrs), +}; + static const struct qcom_cc_desc video_cc_sm8350_desc =3D { + .driver_data =3D &video_cc_sm8350_driver_data, .config =3D &video_cc_sm8350_regmap_config, .clks =3D video_cc_sm8350_clocks, .num_clks =3D ARRAY_SIZE(video_cc_sm8350_clocks), @@ -522,7 +543,7 @@ static const struct qcom_cc_desc video_cc_sm8350_desc = =3D { =20 static int video_cc_sm8350_probe(struct platform_device *pdev) { - u32 video_cc_xo_clk_cbcr =3D 0xeec; + struct qcom_cc_desc desc =3D video_cc_sm8350_desc; struct regmap *regmap; int ret; =20 @@ -539,7 +560,7 @@ static int video_cc_sm8350_probe(struct platform_device= *pdev) video_cc_sleep_clk.halt_reg =3D 0xf58; video_cc_sleep_clk.clkr.enable_reg =3D 0xf58; video_cc_xo_clk_src.cmd_rcgr =3D 0xf14; - video_cc_xo_clk_cbcr =3D 0xf34; + desc.driver_data =3D &video_cc_sc8280xp_driver_data; =20 video_pll0.vco_table =3D video_pll1.vco_table =3D lucid_5lpe_vco_8280xp; /* No change, but assign it for completeness */ @@ -558,11 +579,7 @@ static int video_cc_sm8350_probe(struct platform_devic= e *pdev) clk_lucid_pll_configure(&video_pll0, regmap, &video_pll0_config); clk_lucid_pll_configure(&video_pll1, regmap, &video_pll1_config); =20 - /* Keep some clocks always-on */ - qcom_branch_set_clk_en(regmap, 0xe58); /* VIDEO_CC_AHB_CLK */ - qcom_branch_set_clk_en(regmap, video_cc_xo_clk_cbcr); /* VIDEO_CC_XO_CLK = */ - - ret =3D qcom_cc_really_probe(&pdev->dev, &video_cc_sm8350_desc, regmap); + ret =3D qcom_cc_really_probe(&pdev->dev, &desc, regmap); pm_runtime_put(&pdev->dev); =20 return ret; --=20 2.54.0