From nobody Fri Sep 25 06:10:51 2026 Received: from mx0b-0031df01.pphosted.com (mx0b-0031df01.pphosted.com [205.220.180.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id E59B245FFAA for ; Wed, 16 Sep 2026 08:14:32 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.180.131 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1789546480; cv=none; b=YqaqQNCh47lCdLXsrl1AOqEoJzoWuUHZpgSgD6qTaTNzU+RIEUBFdNiciSLA8c9V7eJg2TWMpjEP7oSCFcNCEWvLTBvjc9+Kg0s3OU19GfIZHZdIUD8ggNHrlTaS4VtCk6GKsBJIIKjNsKqFEfnvB+LnMTsykILvb4AnAdVQkao= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1789546480; c=relaxed/simple; bh=x1vhhVD+EuvAa4tTslqnDNk7SPeox8b2RX+e5N5FKM0=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:To:Cc; b=OzkliE1CQGW7wtgvoQe5TYFRB2pJi3qc3F2ZLbipPdmRfEAt+peD5iuIBc++Z715VMWnATKCXlebyNdC+2HmxPYZToy4Uivn35KrmnODTzQ1nt9YeS5nsdUD4mvMjpP7Ufgdl2S+CYD2fS8FoKYrObSg/H0mW9l5cVpPszijv+A= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=nfMLhjpz; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=NtJrmawF; arc=none smtp.client-ip=205.220.180.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="nfMLhjpz"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="NtJrmawF" Received: from pps.filterd (m0279869.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 68G68j3c2264844 for ; Wed, 16 Sep 2026 08:14:30 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:message-id :mime-version:subject:to; s=qcppdkim1; bh=bHxC3t0bD0slbmkhbjDTNk yF+TrRMkmAt/z97iqNV0o=; b=nfMLhjpzNLfHQB59gmW6t13cPpfIdEZlpoKtem ZZaLxdcranDf5X3UUKsfF2kjvq2fIX2R9ZIwce4/x/GyrGEvLmRmqagz069pwXCE dsfmKw1tR6/+wkoiAXwMiYT5TX0nDZgctytbSepmPOeIl9VFjrtWKXH9Zrz0r7kP KTCETlDnResYygLt/nC+eCGmnqHq4dXKjqZ/y5g34o54NhVYlfbwL2MO1icvOs5P 9R/vb3kAhTeWsksLoZ1tuZwKOc8p+WEJQmDaL7fyhWvUN9/1OsIVwxDjtPis6ZHa UZ1hgwiYszaIERFZzoyU5WZtMb6L/OOd7v4xwxJclJHV2qwA== Received: from mail-pj1-f70.google.com (mail-pj1-f70.google.com [209.85.216.70]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4gqftuhs0j-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Wed, 16 Sep 2026 08:14:29 +0000 (GMT) Received: by mail-pj1-f70.google.com with SMTP id 98e67ed59e1d1-39e1bbe2c30so955091a91.2 for ; Wed, 16 Sep 2026 01:14:29 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1789546469; x=1790151269; darn=vger.kernel.org; h=cc:to:message-id:content-transfer-encoding:content-type :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to:content-type; bh=bHxC3t0bD0slbmkhbjDTNkyF+TrRMkmAt/z97iqNV0o=; b=NtJrmawFoEY2waT6mlxiNqBNwb9Oo/jMYFHoishLeRbTozT9jCdcxNlD6pWOH8T32m 8hsvx4XmWwiIqzuUju04VeJlnA1pROjTJtlyMiRyGVavKu5R9paWLYsaycnibdW5CREK gKts8goo2FipulL0HssQ4ls4dKrmZcDBcXEW9qTncv0iRQ+7Ng2MY6103ubbrU76thKG ds41Ra6gfZozAnwQWwZ1SE7+toaA5Th244F5wWpbEaeVhxg9IKNv1SjWrC7FKmSKwnua PzESLlufLw3x3afJIvLJ4Yhmdv/nobGQJGcWa8uiZcR1JC8L7KfRMGImxqzz2ITT3TLB 16Pg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20260707; t=1789546469; x=1790151269; h=cc:to:message-id:content-transfer-encoding:content-type :mime-version:subject:date:from:x-gm-gg:x-gm-message-state:from:to :cc:subject:date:message-id:reply-to:content-type; bh=bHxC3t0bD0slbmkhbjDTNkyF+TrRMkmAt/z97iqNV0o=; b=eEx9E95UNS8wJEsa8pUKsn8M1q+ScbnT0lwyiomQgc/E83+knuFoTv/NjFQ/ock+Ve UEn3uDpSLeGNRoCL680jipRoAF4rb50Zi/3orUs6vHa+lG6h7FRxyvNL0SL77ZN/1Lgn WgJ5TntlUNmNH937cHa0JMI06Ooxh0lXh9BPgNr5kSblQWJXVKfekSFEXUehr7k2UmK4 7XlvP2PGy2xVHrbViXMct6AuHRIpNEg/96WkmTc4eER/TJXkPs508JYxMFq2eyUqBCOr OjSIPjCM4WmjngWyI7VwT+wNy6H+BirdAD6jBtoblhKhZ/1mx17g8g7QI2TP7oqXpPI4 md9Q== X-Forwarded-Encrypted: i=1; AKwUvByl8VrUUr+RbhP1y9MzYxKJhTsS8IVJuzi9tRDzXl80GmKHLji6wKsIRWL8wuDiwq3GefweuIjc4HPU7Fg=@vger.kernel.org X-Gm-Message-State: AFuF++nbsY/6+IiZmnYLzd13RqUdEFFUXwepl0kIXRrlvR/qVMj6UEn4 VCMrVUFzCS6no1CCbHHa9H38GpsS5Gab+8HjitmWOM83UX+QA1UQt2tLMOOOJ825Di9O5Ux680s qicjIUHxK8LaPOkcMMA0V7Fgvmx4LqmI1wq2aBggYu+dEab2glQhV29MPM7/KV+S3f2sKUVovuS A= X-Gm-Gg: AYBFou3X86dihtyNzvVnoQ2mcZ7pVHTvOPWGRCzhvpQS2TWtf6fFDE4EyQ+ssuI1Nln WHvwoEwOhalx8laXGx36yicEAeRXZu+IKRcQBpBCpZWZ5gI9ESw/7Qo8VLidMPAW1lmAzhbLJ4K e0r2IkNJ4rSjn29zonHfWlW+mcWoGtWYPHTkLYOtpLCLlzFyBTAKJ7BttcCI+3v5aUqB+mOLIL1 hMf/cHZYDiMsf6V/2AEqNS0lp49bj1VcrKraWZDZkuE+VCo6u26CvLAFyLVpbHzDt895I7H/vqC +HL1OQ81Pb2RTP4lrYCkT/R5HII6j7EYnPaylep0l7NKrQABkNuPU7gXtdvKHf2f6UoL4fXUIIu raMZ4JEjb0ER6yAzFNvrztdrxoKII99rNpr/Kqw== X-Received: by 2002:a17:90b:4cc8:b0:398:c292:ac80 with SMTP id 98e67ed59e1d1-39e1e330a2dmr4483267a91.10.1789546468765; Wed, 16 Sep 2026 01:14:28 -0700 (PDT) X-Received: by 2002:a17:90b:4cc8:b0:398:c292:ac80 with SMTP id 98e67ed59e1d1-39e1e330a2dmr4483195a91.10.1789546468238; Wed, 16 Sep 2026 01:14:28 -0700 (PDT) Received: from hu-anupvish-hyd.qualcomm.com ([202.46.23.25]) by smtp.gmail.com with ESMTPSA id 5a478bee46e88-33bf5b2753csm11734328eec.31.2026.09.16.01.14.25 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 16 Sep 2026 01:14:27 -0700 (PDT) From: Anup Vishwakarma Date: Wed, 16 Sep 2026 13:44:22 +0530 Subject: [PATCH] remoteproc: qcom_q6v5_mss: Fix off-by-one in regulator enable error unwind Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20260916-b4-q6v5_mss_regulator_enable_unwind_upstream-v1-1-858e8fb0c279@oss.qualcomm.com> X-B4-Tracking: v=1; b=H4sIAN5PqmoC/yXNTQ6CMBBA4auQWduEAjbRqxjT9GfAMVCg06IJ4 e5WXX6b93ZgjIQM12qHiBsxzaFAnipwDxMGFOSLoakbVV+kErYTq9rOemLWEYc8mjRHjcHYEXU OLwpe54VTRDMJp2TrW9s1DnsoySViT+/f7nb/m7N9okvfBxzHB1C+W5GQAAAA X-Change-ID: 20260916-b4-q6v5_mss_regulator_enable_unwind_upstream-c613d3b42cef To: Bjorn Andersson , Mathieu Poirier Cc: linux-arm-msm@vger.kernel.org, linux-remoteproc@vger.kernel.org, linux-kernel@vger.kernel.org, Anup Vishwakarma X-Mailer: b4 0.16.0 X-Developer-Signature: v=1; a=ed25519-sha256; t=1789546465; l=1782; i=anup.vishwakarma@oss.qualcomm.com; s=20260805; h=from:subject:message-id; bh=x1vhhVD+EuvAa4tTslqnDNk7SPeox8b2RX+e5N5FKM0=; b=/cvYCXeQ33IK95EIknj/fLHqdm4Wcbp76X5qJGdZcyxvEdg4SJ72QDSiZ3x9cDK3aCQFt++KL l2/90qQEEFuBmQ+aT6CvdARZotA4bJjlkhbhSzKdSYmp1Rf4B76HEY/ X-Developer-Key: i=anup.vishwakarma@oss.qualcomm.com; a=ed25519; pk=Y9ilCu91UQrzHOM14SG2IjnmQ1QSroH5uVeBSWEmEDM= X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwOTE2MDEwNiBTYWx0ZWRfX9IN33kvSoxsF 3+wsNp1uEiUKsMC5J6rMVFAZ7WcGT0cE8h76Oy4T/X/trDe07t07CgUb6XHV/yJDx2IEJT1m4vG o/Na29xc5jjiYizT+eobuiPLYgShab5u7ULoxoKInmzj7Qb0miutZlYLLVtIM7cKFLQaDj03DlO q2jkw2QbjSJUGf0D2WQgw52F15/votHY8KXC25RuLhmt7Yub8aL7ifkSdpKMFI6eqBN0B0cP5np FU3ZnaSCYs/QRZD070PI40GNtWdrKFN+0QRpNIfvxxXDzjgNDlM7L6TZhnoQADYCwXEwO6g19YW SyxwEpPnwGB8xd6cyDAZ6W4u57YUVeOm7WbsyGwetVQxUKruy0CdhPbO6A5cn7TA3j6wxotg02O 4uEcDSbKhQxq76C3ailz7GMTfcRU3JnYMaYNBL6KH9Q3OGuLXJ8KmzMN/9dL9+ljV9tkH2nIYiO v6oJ34a1oUu5ypQDwGQ== X-Authority-Analysis: v=2.4 cv=a5ulZkSF c=1 sm=1 tr=0 ts=6aaa4fe5 cx=c_pps a=0uOsjrqzRL749jD1oC5vDA==:117 a=ZePRamnt/+rB5gQjfz0u9A==:17 a=IkcTkHD0fZMA:10 a=VdqzKS8jKosA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=_glEPmIy2e8OvE2BGh3C:22 a=EUspDBNiAAAA:8 a=SFYdgmKYQZucr7GQzh0A:9 a=QEXdDO2ut3YA:10 a=mQ_c8vxmzFEMiUWkPHU9:22 X-Proofpoint-Spam-Info: AW1haW4tMjYwOTE2MDEwNiBTYWx0ZWRfXzTvjV8RpBTQN 0K7RT3j5RYRDiWp2mN1ZJCMKeDYL2QrC0w8ZWPo3dq7eiFJsi1VWfpevUDmcNFtK8z2ekwZDfj2 RenuJHvFv0c/urFEkINF2kZqIk1upDU= X-Proofpoint-GUID: J64cszb4hNlursNqSnkStYt6FBcpPdrV X-Proofpoint-ORIG-GUID: J64cszb4hNlursNqSnkStYt6FBcpPdrV X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1176,Hydra:6.1.134,FMLib:17.12.100.49 definitions=2026-09-15_05,2026-09-15_02,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 suspectscore=0 spamscore=0 clxscore=1015 priorityscore=1501 adultscore=0 impostorscore=0 malwarescore=0 lowpriorityscore=0 phishscore=0 bulkscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2609040000 definitions=main-2609160106 On failure inside q6v5_regulator_enable()'s enable loop, the err: label's unwind loop starts from the same index i that just failed, calling regulator_disable() on a regulator that was never successfully enabled by this call (and may not even have reached regulator_enable() if the failure was in regulator_set_voltage() or regulator_set_load()). This can trip the regulator core's unbalanced disable warning, or spuriously drop another consumer's vote on a shared rail. Fix this by decrementing i before the unwind loop, so it only disables regulators that were actually enabled. The current index i may still have a voltage or load constraint applied from before the failure, so clear that explicitly ahead of the loop rather than dropping it along with the erroneous disable() call. Signed-off-by: Anup Vishwakarma --- drivers/remoteproc/qcom_q6v5_mss.c | 8 +++++++- 1 file changed, 7 insertions(+), 1 deletion(-) diff --git a/drivers/remoteproc/qcom_q6v5_mss.c b/drivers/remoteproc/qcom_q= 6v5_mss.c index 2f71ed2feff6..a40a8614758e 100644 --- a/drivers/remoteproc/qcom_q6v5_mss.c +++ b/drivers/remoteproc/qcom_q6v5_mss.c @@ -336,7 +336,13 @@ static int q6v5_regulator_enable(struct q6v5 *qproc, =20 return 0; err: - for (; i >=3D 0; i--) { + if (regs[i].uV > 0) + regulator_set_voltage(regs[i].reg, 0, INT_MAX); + + if (regs[i].uA > 0) + regulator_set_load(regs[i].reg, 0); + + for (i--; i >=3D 0; i--) { if (regs[i].uV > 0) regulator_set_voltage(regs[i].reg, 0, INT_MAX); =20 --- base-commit: e6e35979777d646fe3c7c94dca7dd32fb25d45f4 change-id: 20260916-b4-q6v5_mss_regulator_enable_unwind_upstream-c613d3b42c= ef Best regards, -- =20 Anup Vishwakarma