From nobody Fri Sep 25 07:22:46 2026 Received: from mail-pz2-f20.google.com (mail-pz2-f20.google.com [74.125.228.20]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 4AF483D79FD for ; Tue, 15 Sep 2026 15:03:30 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=74.125.228.20 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1789484612; cv=none; b=VM8O3ggeFJmQnhK0zWurGgv4k0IgDA+g5dy8oY5fMQjaTIYphpXnzD7NetPT0PRgUHNF/cTTGYFSMWnytgZJkqTsYU22+kJyxw70GPiZ7EVmo1RPtkTd8zchfxjctbf1q1pFLKjSNvaDnlJARsV6vMGvX4meBqEoTM+ZAoFzfwE= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1789484612; c=relaxed/simple; bh=ZxcOEZm2h5gq0oopxQGQnrU+9rOuzRx+cCXYve5p7C8=; h=From:To:Cc:Subject:Date:Message-ID:MIME-Version; b=n/ZA52zYwWdq81ANRO7diJJbphSAE0ZaT7R5KUriJl+Vyu5lFwxAmtxE8fKMkzOyCgIfgLnBr7uNUIeXqc9QxcI/3ga+ngAHY/eXuf3bJdY6oI2hfyJreIxNyCJ7Llxg9klbF47xXNTMglbE1i1mVMQAU/vszoOmQxkgGv2lZWo= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=bYhj57al; arc=none smtp.client-ip=74.125.228.20 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="bYhj57al" Received: by mail-pz2-f20.google.com with SMTP id 41be03b00d2f7-cc4ae61629fso2464820a12.2 for ; Tue, 15 Sep 2026 08:03:30 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1789484610; x=1790089410; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to:content-type; bh=RnoFATftpooOx4JQEkcutKyMZ8fnscChHfdP4CjfQ0g=; b=bYhj57almlknnku1zHJDxN6L0ktJqknCYE2luWkbj0WtkZKfchZHnaWCFYtjSVjo84 15mCIodT7vPcKb2OzRh/z/qAGUdGMwAUFMexLSiKQtDfatMjCO60qZQ1a0ntlVLGyoP9 C5kw1icnocUtPun0vvZrv3wO3KoOMFc4ZpGhegm5/utFnqwqUohHZJXlt5q6XZRlVTHt wdI/hHfN/bKucntbbMtd5z9DOsJBUrB2Qidg1Bei/VIA5XP28npgMzKvN3T+Lxr/YvCM Sw4RxJW3yThVYVJvMuqjyybVWE0w6WjMz+hcki/HfDCTfBYsk1Jml9jl4jx4dgf9eM1O znog== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20260707; t=1789484610; x=1790089410; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to:content-type; bh=RnoFATftpooOx4JQEkcutKyMZ8fnscChHfdP4CjfQ0g=; b=Fkx5Ky5pAjoT680E4btm2Fs88bsTSWTV+tg31Y8k60R7H9M8jy8xQbkqfgaXE6dLIm 4iuuTkyQdilxsxEZ2OjAWIhDeHFGBNPIxXH+ryOAq1jTvlaResHosCN/aLhaX88l5rqU SKb7SdzIcZ6sCroahWxwjSKjNTKvzz0kVm5JK7C6OuRJGnRsWYHGx1wYZRP8eRrM5o7T RSIKFnM9BJRyMstRFkUPNfV0yzc8Hp9KSlQwgro7bZt/KLN+4gTMNAaSGsU7cShWt3pV LNao8nr5G1zIuQFtIqtFTTGJc9z2y2QdeAQCfw+2UoyP8/W8kFkAZpQ/ZUHs5ZOEH2Rv XjVg== X-Forwarded-Encrypted: i=1; AKwUvBy6t/fUtgCwi2VLFj/2nudK989G2mM5F5EDCfkqX5Uodd0DlaMwciD1pSaNLDx+LBYMAVP47TlMpWq5XBY=@vger.kernel.org X-Gm-Message-State: AFuF++mEeeecxP5lf2aRBagq0pOoGm075/SpLH2WNGAzPjp3sbEoDwWz BJ9WcuW+QxLC28DKC9BCtCMOa0XuWpzrewGsJT+OlFWmGWj2gviTk7qg X-Gm-Gg: AYBFou3FL0tol0rEIfE8ySpcLBKaKT5QB8d6BSMW95PuYrklC3rH8Zah8H+Q1LC2sKR wpmUxAZiG8SBoaNS5KyoZXxeZ9Wp0kZNcp1CAy1nMNdQWNyvETaxhOfIK8KsL7u4Hi2bOdp/FMq cx/5D9oAFLK2AREqoTmH7lYd+iQ30wqmmCNNqc6ddfVF82EqhEO2ldGacgBg8ddE5UANOdAbFse 7ebyKnJkPnxNEwmfN71Y61GRi0d/tzrxYxYQv/3dMKkbRkOw95zuRx7QXTHK3CO+G9Eld2ZfonK JPbzsN5krnMZZ2e2PEdgbUVqAoWm6cgiq0KaW4pTqHxLgMD9qOZaDOFuR+7FXMpcxUzVT6rowd/ RSZK6GT12X5E1Kb+a7wwdCDBkC4sT7ZOKxWBtdS2eaO+RFJ9Kz+ZoJD3cq8hiNaQ012vat5Rjmx aVCBoDHIftGhR1uCaC47VBYKcxdCYwdia7WuLYyi/zytCAWepgGsK0M0nI5gqtzMUZbA== X-Received: by 2002:a17:90b:2789:b0:39d:f2a1:2a with SMTP id 98e67ed59e1d1-39df2a103d6mr15547653a91.19.1789484610100; Tue, 15 Sep 2026 08:03:30 -0700 (PDT) Received: from lgs.. ([2001:250:5800:1002::de93]) by smtp.gmail.com with ESMTPSA id 98e67ed59e1d1-39dfda8bdf4sm6105716a91.12.2026.09.15.08.03.25 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 15 Sep 2026 08:03:29 -0700 (PDT) From: Guangshuo Li To: Maxim Levitsky , Alex Dubov , Ulf Hansson , Kees Cook , Maoyi Xie , Guangshuo Li , Andrew Morton , linux-mmc@vger.kernel.org, linux-kernel@vger.kernel.org Cc: stable@vger.kernel.org Subject: [PATCH] memstick: ms_block: destroy io_queue workqueue on removal Date: Tue, 15 Sep 2026 23:03:17 +0800 Message-ID: <20260915150317.2444609-1-lgs201920130244@gmail.com> X-Mailer: git-send-email 2.43.0 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" msb_init_disk() allocates msb->io_queue with alloc_ordered_workqueue(), while msb_remove() does not destroy the workqueue. The probe failure path releases the workqueue with destroy_workqueue(), but the normal removal path only flushes it through msb_stop(). Flushing a workqueue does not release the workqueue itself, so each card insert/remove cycle leaks the workqueue and its worker. Destroy io_queue during removal after the outstanding work has been drained. Fixes: 0ab30494bc4f ("memstick: add support for legacy memorysticks") Cc: stable@vger.kernel.org Signed-off-by: Guangshuo Li --- drivers/memstick/core/ms_block.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/drivers/memstick/core/ms_block.c b/drivers/memstick/core/ms_bl= ock.c index ce33907bfc24..65154e569a9e 100644 --- a/drivers/memstick/core/ms_block.c +++ b/drivers/memstick/core/ms_block.c @@ -2204,6 +2204,8 @@ static void msb_remove(struct memstick_dev *card) msb_data_clear(msb); mutex_unlock(&msb_disk_lock); =20 + destroy_workqueue(msb->io_queue); + put_disk(msb->disk); memstick_set_drvdata(card, NULL); } --=20 2.43.0