From nobody Fri Sep 25 07:56:39 2026 Received: from BL2PR02CU003.outbound.protection.outlook.com (mail-eastusazon11011031.outbound.protection.outlook.com [52.101.52.31]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 2714149362F; Tue, 15 Sep 2026 11:19:58 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=fail smtp.client-ip=52.101.52.31 ARC-Seal: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1789471200; cv=fail; b=t/s++oDAqI03uMvlaBsGMucZ9gymUUOrXUWNY8/01jeeI8wrniq6dpufGl766W7f3OuuwX+Ohps1345MvvYRAfixlWCzYtSGbHrNpolCd5/IFvoTrwna2rJsszFacOcJ1UbqCL+PTrgc1FGo5CBz7dBPz15SH+4kvjopp6z3iRA= ARC-Message-Signature: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1789471200; c=relaxed/simple; bh=oataAgDKL++D0kj40eolVORHj2fXQiN77C63d02RP2s=; h=From:To:CC:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=aJGtEfV6uGLL1DiU52lfGrz9aYfKTAkIMnTXjOHZaxIAxlcZh+y3eb+PqxnN52OqoLscNraDnK8yIM6EfIcsfOIdBQoTsjCLrbj9eyMUD54q/gkHFonaMGYKWWXEar86zmdIVK2Z2dmQqT3MSteqW9ohWkbumjhJNSkDYz0XXzk= ARC-Authentication-Results: i=2; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=nvidia.com; spf=fail smtp.mailfrom=nvidia.com; dkim=pass (2048-bit key) header.d=Nvidia.com header.i=@Nvidia.com header.b=fd5DPym5; arc=fail smtp.client-ip=52.101.52.31 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=nvidia.com Authentication-Results: smtp.subspace.kernel.org; spf=fail smtp.mailfrom=nvidia.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=Nvidia.com header.i=@Nvidia.com header.b="fd5DPym5" ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=WLsK3gcEdyeIQwfD+rTWKVPLgqp+pdUGfGEYwVUTgrdlV6JeKtWJfwpty2SAjraClfpFiBGaviGRkWpAZ8jgKzt+agTeA60pCYwlZonQsUEhkkgzcxqEtpv7M9iBKQIj/xzBkKHJ/OGGCbZqQHpB9uU2RtHB5YQjLkHwBETKbx4lzWR4Jc3rLH+Ts7PGuGUKkGV0rEaoXJiuMbiPx9cigXxgwlksnjs4WcN1soFh1DGiDe9GCnNvIBDrIDdKwvM/euQ2wSbw6baDyE+oPyXzPibew4MSx5M/N9kpdxv0KmOUqTskFYrCgASZrM/EBulbYUX5n6mEy8VSbLNCxxyF5Q== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=8jBWt4cScxKTStuxip0cE8UUHcug5PAejMgag28C4SU=; b=m+gVCiM3kv6cR6KXSlaExT89pfu22azOhIqx65ooTKN8mpyX/JtmUJ6yxQgc93xgJwTbVGk9WaPC9Q3leJn9ZOjljFfH8j5/tAdsW9ETIuEa9S3hlBsomun3JHg8cdXRKu3rztSRwm2p5FU1pVgyNEE8uBl1fILyQm3k/NHK5JpvBGQ/g+M4z1xSRQ6r1A5PQnTT6zrfoQ3p8Php1hZlylkOfuOOZza8n9Tu3Pd91X2WYn4I8XsHPTD4p8wBq/xRYqtX+rBtP9uKvhcu3elcraM8v2TICMois7VxZEjCDW50DcMVUB0gd7q0H+LY4ntpEdLImcEjXTWvUSpNZFxu7g== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 216.228.118.233) smtp.rcpttodomain=lunn.ch smtp.mailfrom=nvidia.com; dmarc=pass (p=reject sp=reject pct=100) action=none header.from=nvidia.com; dkim=none (message not signed); arc=none (0) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Nvidia.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=8jBWt4cScxKTStuxip0cE8UUHcug5PAejMgag28C4SU=; b=fd5DPym5Z0u4So1eelbntVyX8HlYxW3LhTs0S1FgJvVkfiaIUwpNO0/tC1nUWQrKd/Kk3XB3FmCCN7AmwO23MJTJtgyBiPiAvG9EKw3VXxBMSmo3OKhjpx22PROjKFnmWs4SUi0B9hlr4ncVYWJlPgCg2gCq49Xg7Sbcf7NKuJjPQVQ6Wl/YE/xl6NsxJMYllORMAaXM8QmgKECM2EQ0hG9uPseKB80qnA9ZmZKj/tNsrxxq1XfOnB+LJHQ2xsappzyK7wElbkAwyYGqYasqluNnI5bkbGXSryv07WF8cPAs9Aa22Yu8j9U45VvPPROg54c4f3fhmLRKWLlsW8WqDw== Received: from DS7PR05CA0093.namprd05.prod.outlook.com (2603:10b6:8:56::17) by SN7PR12MB6929.namprd12.prod.outlook.com (2603:10b6:806:263::11) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.21.406.12; Tue, 15 Sep 2026 11:19:50 +0000 Received: from DS2PEPF000061C4.namprd02.prod.outlook.com (2603:10b6:8:56:cafe::5c) by DS7PR05CA0093.outlook.office365.com (2603:10b6:8:56::17) with Microsoft SMTP Server (version=TLS1_3, cipher=TLS_AES_256_GCM_SHA384) id 15.21.428.8 via Frontend Transport; Tue, 15 Sep 2026 11:19:50 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 216.228.118.233) smtp.mailfrom=nvidia.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=nvidia.com; Received-SPF: Pass (protection.outlook.com: domain of nvidia.com designates 216.228.118.233 as permitted sender) receiver=protection.outlook.com; client-ip=216.228.118.233; helo=mail.nvidia.com; pr=C Received: from mail.nvidia.com (216.228.118.233) by DS2PEPF000061C4.mail.protection.outlook.com (10.167.23.71) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.21.428.7 via Frontend Transport; Tue, 15 Sep 2026 11:19:49 +0000 Received: from drhqmail202.nvidia.com (10.126.190.181) by mail.nvidia.com (10.127.129.6) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.2562.49; Tue, 15 Sep 2026 04:19:37 -0700 Received: from drhqmail203.nvidia.com (10.126.190.182) by drhqmail202.nvidia.com (10.126.190.181) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.2562.46; Tue, 15 Sep 2026 04:19:33 -0700 Received: from vdi.nvidia.com (10.127.8.10) by mail.nvidia.com (10.126.190.182) with Microsoft SMTP Server id 15.2.2562.46 via Frontend Transport; Tue, 15 Sep 2026 04:19:29 -0700 From: Tariq Toukan To: Andrew Lunn , "David S. Miller" , Eric Dumazet , Jakub Kicinski , , Paolo Abeni CC: Erez Shitrit , Gal Pressman , "Leon Romanovsky" , open list , , Mark Bloch , Saeed Mahameed , Tariq Toukan , Yevgeny Kliteynik Subject: [PATCH net-next 1/6] net/mlx5: HWS, Return meaningful error code in hws_send_wqe_fw Date: Tue, 15 Sep 2026 14:19:07 +0300 Message-ID: <20260915111912.3926585-2-tariqt@nvidia.com> X-Mailer: git-send-email 2.44.0 In-Reply-To: <20260915111912.3926585-1-tariqt@nvidia.com> References: <20260915111912.3926585-1-tariqt@nvidia.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-NV-OnPremToCloud: ExternallySecured X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: DS2PEPF000061C4:EE_|SN7PR12MB6929:EE_ X-MS-Office365-Filtering-Correlation-Id: 3c62463d-20c1-406a-f990-08df131b41d4 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|36860700016|23010399003|82310400026|376014|1800799024|18002099003|10067099003|22082099003|56012099006|11063799006; X-Microsoft-Antispam-Message-Info: fv5Ep9Q6g6yIKxNv2cvkzbQ65H/qKK0j6rlaDbTPLgE8sNZakLM+14sbIQABAjvDR98wAGt4fmB61XT8GI5E5iDTupe4K+goi5uR/K2Tv/4CjSakDYt+EcarA/jHv3N7pzovuz3xEb8M+qR4qGaDIdn56ZUD9XcK/6LGeluBX/ajVzekLAKGD+o2BZEdi7IAOuRLFSsyAQUDsutzGS41YTC3ApOBty29YLA9xsX1LbOX7UWYZlO3R1w7aHdNR8l7GTm7PTh4dd55kfKNxm2LPSX2X3T6js54kjPqDS6jFUUSTiROLUrb3t1pE6CYwdY/JHukj0qnk7aZSWgKBjZ+n9hg1RTwgLY6svUfDKPe2XyF3RQZZVxeMWzI3+IJA3G14nz3hbkWpyhQerm7gnP5zVEr7XhnKTrzgetkUheVHKkc1qTqCBzd97d/K/8bt60c1VmFQAITw31YIHw4GuwWlp3KKOSpgZNnZYF7fZNAjcYwmsyQAQEmDTGfYdD93w1hbu06BnD9BGQGAMlay6xCEQfqwc+RNRJCykXPdm0fIzsDMaUp+0oxmRgI17UdO0uVS0hqd0IACF7L8+BSWctg6BDqCpz2cPB9enBjJ1inpnFGvPMqCKnRfF0HlAblZSv3r/QfVyZLBx9Wj+h3XRjVIAW1CA+q9tMXUwA8GW0iyXHWJxvlJWdDJTEPUoQxRm7GRHbVh2ic+Enbjtr9wnzKig== X-Forefront-Antispam-Report: CIP:216.228.118.233;CTRY:US;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:mail.nvidia.com;PTR:dc7edge2.nvidia.com;CAT:NONE;SFS:(13230040)(36860700016)(23010399003)(82310400026)(376014)(1800799024)(18002099003)(10067099003)(22082099003)(56012099006)(11063799006);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: QRLXSrH61Zm73FxgDzbqB6IJ2nFDCMmK6AXK7M6mfocN0DCKL+cpMqcUwaCSgGUZg2ampzB4J4qfHvoDb55cv4hhVNh5qgnugO7+th6ghwa9DUsmA2oBphcjNQGSDY7MUhsNgQSFSooECKgEN1GrMyY+WUBUOjYhpy6xajdEEqXfDpM2g7A/ezo+PRXQF9K55U4jpmwtSAbVYHZWkEk9yk0NyIeZEOYeIt7sUK08ucSe5uEh4V/a4g8LFI0JyKuMGlxe8WvvjXdrVwnlC1naasGIW1cbWM3VWzm21FHF9Von44507B8jSFTgvV0zlW2Z3KaXqSK07RPOsOcDKEpZw++3rZihHDRyATQtHBf92JeTxLPqN4yuV01kAQ1vYg5JeWpOGaX8IqgjC0dqcmnmI8HKth71q2gUdIsY1g8BIrX5UJcmm7H5wMZakWmTcuTa X-OriginatorOrg: Nvidia.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 15 Sep 2026 11:19:49.7878 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 3c62463d-20c1-406a-f990-08df131b41d4 X-MS-Exchange-CrossTenant-Id: 43083d15-7273-40c1-b7db-39efd9ccc17a X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=43083d15-7273-40c1-b7db-39efd9ccc17a;Ip=[216.228.118.233];Helo=[mail.nvidia.com] X-MS-Exchange-CrossTenant-AuthSource: DS2PEPF000061C4.namprd02.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: SN7PR12MB6929 Content-Type: text/plain; charset="utf-8" From: Yevgeny Kliteynik Returning '-1' is non-idiomatic in kernel code. Use a meaningful error code instead. Signed-off-by: Yevgeny Kliteynik Reviewed-by: Erez Shitrit Signed-off-by: Tariq Toukan --- drivers/net/ethernet/mellanox/mlx5/core/steering/hws/send.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/ethernet/mellanox/mlx5/core/steering/hws/send.c b/= drivers/net/ethernet/mellanox/mlx5/core/steering/hws/send.c index df3b93499eeb..ae3ff232c63b 100644 --- a/drivers/net/ethernet/mellanox/mlx5/core/steering/hws/send.c +++ b/drivers/net/ethernet/mellanox/mlx5/core/steering/hws/send.c @@ -1305,7 +1305,7 @@ hws_send_wqe_fw(struct mlx5_core_dev *mdev, goto send_wqe; } =20 - return -1; + return -EIO; } =20 void mlx5hws_send_stes_fw(struct mlx5hws_context *ctx, --=20 2.44.0 From nobody Fri Sep 25 07:56:39 2026 Received: from BL2PR02CU003.outbound.protection.outlook.com (mail-eastusazon11011071.outbound.protection.outlook.com [52.101.52.71]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 0AC2E486E62; Tue, 15 Sep 2026 11:19:57 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=fail smtp.client-ip=52.101.52.71 ARC-Seal: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1789471199; cv=fail; b=RPz0WLrhsVIkceWBaYnl1JphmK1O8jphqGIW5Iljjd6HsTy/z5MwTj4EQJcrcRyOrSq9gOSESl/DBiYfk/vTsrO5xhLtn2RMG7Y+V0+zmoGWRA4CS9U3Kff15kV8MdG5pTa4nQMJk8whe46FgHGprjlOhp30WSHK6JxRRCJppuk= ARC-Message-Signature: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1789471199; c=relaxed/simple; bh=zXXfrJYgUkmAYYO0l+E5ULTnHVFXfZUNYmAGYM1m1pA=; h=From:To:CC:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=nyP0bVCBxjy6Z2g/CE5TwNCKdG1tf3KWMqal4sw3TLZkcAYb53vwNPibrByecG/CNi1gjiAhgGH7ADIfFfvcExpjJgH3P2lo809dTre9SWbNWDuP8oNANCzb4+1yYaA9xGoKnfDevuLyVMrScT7T9Mr6j7klCc9yo0AOu0dI9mo= ARC-Authentication-Results: i=2; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=nvidia.com; spf=fail smtp.mailfrom=nvidia.com; dkim=pass (2048-bit key) header.d=Nvidia.com header.i=@Nvidia.com header.b=tdQ1YVom; arc=fail smtp.client-ip=52.101.52.71 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=nvidia.com Authentication-Results: smtp.subspace.kernel.org; spf=fail smtp.mailfrom=nvidia.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=Nvidia.com header.i=@Nvidia.com header.b="tdQ1YVom" ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=OyN+8uzeGjLkB7gOOhCAj9wF2uOIufKSaGG2g+TnQwhvRCjtsdEhzTEc4WNnO/ici0GZLx6yDwjIKLtWnKxCNKwR5p9J8eLF2ZcdzZQm5/wkFvUiwB/dgEuclapSctK41WbFkA58eCp36PgArX2lJX9rgO7WGorJ1+5UhBSSBoGKEM3gonmhIgRpZsH/NTOd6UNjevoAjAb82nZTFRskPaVZOHG6QvDOsAymOWrmYSty8Hcs7ldy4nzuZjWkF2lrWvJkDwA/pPyoNOJ+Khawb1zKpGBZn/kZepZkZCd0GpZCpC7dn5yYeJXDA30TD63Jjh/uVCduMGNQ3ETJqOJP6w== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=kjVu0NXm+G+bGHpRZ+HBqCzsgj0wRUb9CRP+f2Zaywk=; b=gU+ZQ0aDLfF67QggOGbfwCqdifl3quPwi/xIKJ+VgqakNx+jCDMee3Dgjj8ddt/MSRFUUGO2+V0ACJDIIij2jW7MjNo+wWGfGkwKzxrwKu7IUgm3O1JIMb02bobcrwFZGw1P7/8k6SWiAFHLATvX+vGREiqsjV+reHbnQ9yeMgye8IA4Dh010vAw7wsDpEEUTj6E2db46a7szT34WhtS0qgYw4HqexYHWbEEKLaPzTeWH8mgfGjOnuZQXezMTT0jJjd2ozJV2vnG9gw1rz9i2VdMSN5QmkMBuhJghkUNhHuKNOouh/FBLdtvasspi3Tvp9p+BkWy4SYHUHMUWoaZQw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 216.228.118.233) smtp.rcpttodomain=lunn.ch smtp.mailfrom=nvidia.com; dmarc=pass (p=reject sp=reject pct=100) action=none header.from=nvidia.com; dkim=none (message not signed); arc=none (0) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Nvidia.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=kjVu0NXm+G+bGHpRZ+HBqCzsgj0wRUb9CRP+f2Zaywk=; b=tdQ1YVomrvPUCT/bjXJzDQCMg6Um0V+bsDOCfdY2jMFKhBR/pjifEFpUyQZQag9Wg8rrgmXK1aSH5n8tocfuM1NqndaCJ1IHMa19KSKTPN7dq/MZGFWqIlUUNjdSaM6DUSPLhwyfhBbtA438UGxKjvGqa3126IRzrLNsGc/7Od3zLCFebPeZJDkhWAV0QIlQ3q7Xy5vQTbKlHeTT0XJvRuUv+7EPCwXupVgj8t7KN77qSate1dMTu1LZpLaBdP8j1XInf/K1XcdXSW/ldv01VomiZCbx3ZnmVhTAMyI27J2Hj9PP55x/FwT2keDwsxb9SQ5o+SuQ5OWaDossM0IgcA== Received: from CH5PR02CA0002.namprd02.prod.outlook.com (2603:10b6:610:1ed::14) by MN6PR12MB8489.namprd12.prod.outlook.com (2603:10b6:208:474::10) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.21.406.12; Tue, 15 Sep 2026 11:19:53 +0000 Received: from DS2PEPF000061C3.namprd02.prod.outlook.com (2603:10b6:610:1ed:cafe::80) by CH5PR02CA0002.outlook.office365.com (2603:10b6:610:1ed::14) with Microsoft SMTP Server (version=TLS1_3, cipher=TLS_AES_256_GCM_SHA384) id 15.21.428.9 via Frontend Transport; Tue, 15 Sep 2026 11:19:53 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 216.228.118.233) smtp.mailfrom=nvidia.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=nvidia.com; Received-SPF: Pass (protection.outlook.com: domain of nvidia.com designates 216.228.118.233 as permitted sender) receiver=protection.outlook.com; client-ip=216.228.118.233; helo=mail.nvidia.com; pr=C Received: from mail.nvidia.com (216.228.118.233) by DS2PEPF000061C3.mail.protection.outlook.com (10.167.23.70) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.21.428.7 via Frontend Transport; Tue, 15 Sep 2026 11:19:52 +0000 Received: from drhqmail202.nvidia.com (10.126.190.181) by mail.nvidia.com (10.127.129.6) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.2562.49; Tue, 15 Sep 2026 04:19:38 -0700 Received: from drhqmail203.nvidia.com (10.126.190.182) by drhqmail202.nvidia.com (10.126.190.181) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.2562.46; Tue, 15 Sep 2026 04:19:37 -0700 Received: from vdi.nvidia.com (10.127.8.10) by mail.nvidia.com (10.126.190.182) with Microsoft SMTP Server id 15.2.2562.46 via Frontend Transport; Tue, 15 Sep 2026 04:19:33 -0700 From: Tariq Toukan To: Andrew Lunn , "David S. Miller" , Eric Dumazet , Jakub Kicinski , , Paolo Abeni CC: Erez Shitrit , Gal Pressman , "Leon Romanovsky" , open list , , Mark Bloch , Saeed Mahameed , Tariq Toukan , Yevgeny Kliteynik Subject: [PATCH net-next 2/6] net/mlx5: HWS, Fix error message in mlx5hws_cmd_generate_wqe Date: Tue, 15 Sep 2026 14:19:08 +0300 Message-ID: <20260915111912.3926585-3-tariqt@nvidia.com> X-Mailer: git-send-email 2.44.0 In-Reply-To: <20260915111912.3926585-1-tariqt@nvidia.com> References: <20260915111912.3926585-1-tariqt@nvidia.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-NV-OnPremToCloud: ExternallySecured X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: DS2PEPF000061C3:EE_|MN6PR12MB8489:EE_ X-MS-Office365-Filtering-Correlation-Id: 48785123-8253-44c7-c92d-08df131b4395 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|82310400026|1800799024|376014|36860700016|23010399003|56012099006|11063799006|18002099003|22082099003|10067099003; X-Microsoft-Antispam-Message-Info: LjHvs3EK+PN0vV7FGP01o8sOZlOIPOm3rl70AiEnH4UNRIOrj32IjFivGlY4jLuFlbNCYrb1PLuEIbVYAoJk4Z+MOl26SERUluPqJqEhLDcvJc8lZ+z0JkogrpsmEgOwNtpHpDlD2ob3RBwDJTbaupocrLyzURGPfrdUujFfX8T/VumKOVTte54QCTJkr2PMBa2pjbedtH64KhkcasjozRw7bsVaE3nkmJo8pYA1FlkRPLZA4H3YfkCmlZxqqkb1Sy7YI70e+MvWxccnFvxpoDN2E4xr7e44T5hz1P45RuHnSF8Zb/zIyLktD65E0PN4rPINfTHbxOs9twiPsS38cVaMj9L2EsC89EOaMDoVgpETgatevqqfrRAEkQeLbGJNHGGuLLmbyPEk5e6hzdcD4v7po5yMXaDyU8m023QnRFRGaKGdjTp3cErMXZq29G8EIArMR7WLJdz9KNxkUefVpIABhQFLcKDbma+vfzyS+fs0ayGIgL7eIZd9FGX+pIcUys7G+gCOVh7Ejs4GNWwN9yW3VghgoKXzYyjQx5+E8QzUJD9DjSh1+ZUFl438VjW55t897ypkSnpI6XseelbYNkTjG/1gRizNLWkGBxwG04AN89WvT59Y3ZcaHJQk5pZAmhbq+Rs0Yij24Nd2nFKFp2ETZrhozTDVMlhvNEMRxBKAYBE0e4nIKVV/DtU+VUghf5eXiNVz4xYcqsXfo14PvQ== X-Forefront-Antispam-Report: CIP:216.228.118.233;CTRY:US;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:mail.nvidia.com;PTR:dc7edge2.nvidia.com;CAT:NONE;SFS:(13230040)(82310400026)(1800799024)(376014)(36860700016)(23010399003)(56012099006)(11063799006)(18002099003)(22082099003)(10067099003);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: CkvB0FUYgGYWQxs6DcvF81qG1tRGVaj9MQ6kYKstnsNLuLuPl1G2nr+1+pn+mzI2r2CEdHy2Z7JXYHrZOnodKJRdUz9tr2LUbeLRAKBMBNlHxVrCoq7vvuGm1AbZAKcvZW/VutoDHPM1dU188losgM/bEYrxFmNGKIHJtUicd/utgUFw7iveA3RbGustfFpLGQ811+ULCAE2cs+aGGGkzN6bVARilf6/SIDU1NXy1NSXYE4H8NQY0kLTskjF0Wkuz2lpwQU8lKcfbvw3FA35gma08i1cawPraOOXlqohwSNbYg+hpdtovRxiTy0aFySukz1/5J30ZHotdfvuQyi/ejYeRpj+rl4/ymg5jI6T+oGIJ1lOBdeoH/ob6LIS0o/gOUd7NatsqoCLGZotsZpxYavh0RkOHxIx+nsHzUHbKmu92uasfkxli71hPN4CQ+vJ X-OriginatorOrg: Nvidia.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 15 Sep 2026 11:19:52.7492 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 48785123-8253-44c7-c92d-08df131b4395 X-MS-Exchange-CrossTenant-Id: 43083d15-7273-40c1-b7db-39efd9ccc17a X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=43083d15-7273-40c1-b7db-39efd9ccc17a;Ip=[216.228.118.233];Helo=[mail.nvidia.com] X-MS-Exchange-CrossTenant-AuthSource: DS2PEPF000061C3.namprd02.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: MN6PR12MB8489 Content-Type: text/plain; charset="utf-8" From: Yevgeny Kliteynik Kernel log messages should end with '\n' for proper formatting. Signed-off-by: Yevgeny Kliteynik Reviewed-by: Erez Shitrit Signed-off-by: Tariq Toukan --- drivers/net/ethernet/mellanox/mlx5/core/steering/hws/send.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/ethernet/mellanox/mlx5/core/steering/hws/send.c b/= drivers/net/ethernet/mellanox/mlx5/core/steering/hws/send.c index ae3ff232c63b..80cfd0ddba08 100644 --- a/drivers/net/ethernet/mellanox/mlx5/core/steering/hws/send.c +++ b/drivers/net/ethernet/mellanox/mlx5/core/steering/hws/send.c @@ -1287,7 +1287,7 @@ hws_send_wqe_fw(struct mlx5_core_dev *mdev, send_wqe: ret =3D mlx5hws_cmd_generate_wqe(mdev, &attr, &cqe); if (ret) { - mlx5_core_err(mdev, "Failed to write WQE using command"); + mlx5_core_err(mdev, "Failed to write WQE using command\n"); return ret; } =20 --=20 2.44.0 From nobody Fri Sep 25 07:56:39 2026 Received: from MW6PR02CU001.outbound.protection.outlook.com (mail-westus2azon11012068.outbound.protection.outlook.com [52.101.48.68]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 8E0AA49502D; Tue, 15 Sep 2026 11:20:06 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=fail smtp.client-ip=52.101.48.68 ARC-Seal: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1789471209; cv=fail; b=tseV++uEdSv0cAYHf5cdi0aIpguaWvJeal7yirjqFcLvHgLg+JqF8/RuBUe7tQCOQ9rXoyy/3HdSd++BKDpUEI1YgkC9cD3xcFK46YJ/NpMnQlk7ekyjDhYLab+btDUpTqd3z/LVs0Z1paIGDZVhPwdBzr9bd7+fLVYT69BrS4A= ARC-Message-Signature: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1789471209; c=relaxed/simple; bh=d/8shBU73F5s4hWV5FI8sNhFnV4SIs5KQrGxhZ2HnrA=; h=From:To:CC:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=IDH+6NsMl5Xaaj026/PM1RerP8kRzTUlVGQeAKMxhIaZljfmAYeFTiK+cqlNAeJuunoNRcEQdrwNsCR5OEw0G3pBYsSQ9Ae0fCyl1t6DE41Ny7fBx2sqnWYDNEEff3D/FkZ4aZruyWirvYcb7h96JyZ0cua+stZXo+U4crfwNo4= ARC-Authentication-Results: i=2; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=nvidia.com; spf=fail smtp.mailfrom=nvidia.com; dkim=pass (2048-bit key) header.d=Nvidia.com header.i=@Nvidia.com header.b=MdFXBV8a; arc=fail smtp.client-ip=52.101.48.68 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=nvidia.com Authentication-Results: smtp.subspace.kernel.org; spf=fail smtp.mailfrom=nvidia.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=Nvidia.com header.i=@Nvidia.com header.b="MdFXBV8a" ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=lUg1A3Ld7al4fKNZvEeS4fxuNrddjI0zA/A2nyiPfHN546ZVclWYNfXVSHawIh80/dGyGtf6RuWGGpCZxmptva7hvzYFlOeed8OdmH+UpKCbS7NW5rw+GPbsz0bVud0oeDnr4gH13BKbbYkuP8GLPVqu2YnJxk4iV1c51oNfsuh/2GW9+sZiZj0Cm5YxdJNL1dxO/mSTkSm5MGexB3pdHX45d99mO6Bxsrj/8SiE5JyNqsX/kvHc8+dMMDZo2cyKCj88JKBlliDwp/aqLYaowCW4mLaWGbQLexuZ8HiOU3IXXh5hWRpiFE27/An8qXJlLYhuTFZHMG7oMwdzEI01CQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=cCH2MFEFmtiTEaDwA16ZdZJ4Ii+lXHEm413rFfJf38A=; b=CeCAu4hh5oE5auJGtr06d9n5BdiuGSQeIiY87qrJ52umBznfzZc19Xgk7q0uvg45TffBhrzD0I+B1xbjUQscywAJ/gF/Q6kv9t8o+/kqGrBiuk882oVmiuYEsZRbYay9y9jgprLbvEP37Kv/JqgTiqpZBV6Znzjq+mFZnMlOL2YH3By1462mYwECl5GDSFeuESV0FpSmabrIBlKBxaAtJSl+/tbVmfsgRCKrx0GA+plmIeW5I6PZDhnFjNEQOY3sIARqASUTWZjp0WkmfUk92/6RY49tPgdndyQno4MZqYmsbw1xdbLvl/98uh7wtS0PlJww++0KdRoBXDJhFhHrUQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 216.228.118.232) smtp.rcpttodomain=lunn.ch smtp.mailfrom=nvidia.com; dmarc=pass (p=reject sp=reject pct=100) action=none header.from=nvidia.com; dkim=none (message not signed); arc=none (0) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Nvidia.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=cCH2MFEFmtiTEaDwA16ZdZJ4Ii+lXHEm413rFfJf38A=; b=MdFXBV8agjKaUJ6ZY+ldhlD3hERnglDaUdS6AKiSBLdpO8AGCZXVxNrm0U4B6Zk2ysbhmGZBG1wrGpWDvrOWD41UjMe0lpf/aEgAPeDTPsXlvOg6ll64B8+SLK3VLNkox/h4gfShSI30zn8J/PN+rRfOn0qa1j0GbGoDbsEKwF9QtExjujbMuEh5OIWv+XKb88i0VwQcM53H49El+Is0hkhl2DPc3+NzKgHt/dREbmvAbT2thbt8CFWmZbxwS1fLY1fihp+hSfLH1kWaywrCCcyS8ad4s0t/LIpt5lN/KJzf5yzTfvdcob9dD5vDXOAf+l8b93wr3cRrYQvKWWs2Ig== Received: from BN0PR04CA0168.namprd04.prod.outlook.com (2603:10b6:408:eb::23) by MW6PR12MB8759.namprd12.prod.outlook.com (2603:10b6:303:243::13) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.21.406.12; Tue, 15 Sep 2026 11:19:59 +0000 Received: from BN3PEPF00022BBC.namprd04.prod.outlook.com (2603:10b6:408:eb:cafe::78) by BN0PR04CA0168.outlook.office365.com (2603:10b6:408:eb::23) with Microsoft SMTP Server (version=TLS1_3, cipher=TLS_AES_256_GCM_SHA384) id 15.21.406.12 via Frontend Transport; Tue, 15 Sep 2026 11:19:59 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 216.228.118.232) smtp.mailfrom=nvidia.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=nvidia.com; Received-SPF: Pass (protection.outlook.com: domain of nvidia.com designates 216.228.118.232 as permitted sender) receiver=protection.outlook.com; client-ip=216.228.118.232; helo=mail.nvidia.com; pr=C Received: from mail.nvidia.com (216.228.118.232) by BN3PEPF00022BBC.mail.protection.outlook.com (10.167.248.118) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.21.428.7 via Frontend Transport; Tue, 15 Sep 2026 11:19:58 +0000 Received: from drhqmail202.nvidia.com (10.126.190.181) by mail.nvidia.com (10.127.129.5) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.2562.49; Tue, 15 Sep 2026 04:19:41 -0700 Received: from drhqmail203.nvidia.com (10.126.190.182) by drhqmail202.nvidia.com (10.126.190.181) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.2562.46; Tue, 15 Sep 2026 04:19:41 -0700 Received: from vdi.nvidia.com (10.127.8.10) by mail.nvidia.com (10.126.190.182) with Microsoft SMTP Server id 15.2.2562.46 via Frontend Transport; Tue, 15 Sep 2026 04:19:37 -0700 From: Tariq Toukan To: Andrew Lunn , "David S. Miller" , Eric Dumazet , Jakub Kicinski , , Paolo Abeni CC: Erez Shitrit , Gal Pressman , "Leon Romanovsky" , open list , , Mark Bloch , Saeed Mahameed , Tariq Toukan , Yevgeny Kliteynik Subject: [PATCH net-next 3/6] net/mlx5: HWS, Replace kzalloc with kzalloc_obj Date: Tue, 15 Sep 2026 14:19:09 +0300 Message-ID: <20260915111912.3926585-4-tariqt@nvidia.com> X-Mailer: git-send-email 2.44.0 In-Reply-To: <20260915111912.3926585-1-tariqt@nvidia.com> References: <20260915111912.3926585-1-tariqt@nvidia.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-NV-OnPremToCloud: ExternallySecured X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: BN3PEPF00022BBC:EE_|MW6PR12MB8759:EE_ X-MS-Office365-Filtering-Correlation-Id: 722115b0-83f4-46db-eed2-08df131b46e5 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|376014|82310400026|1800799024|23010399003|36860700016|10067099003|56012099006|11063799006|22082099003|18002099003; X-Microsoft-Antispam-Message-Info: fYfOVmS33e2AFSHvPzFbT24csQsbusadfbT3hRHJBRfEBmZom8ErI+y2iAxFkkFXJeLtrBM+npJXQ+yXbEuQ1OJ2Idqf0W9xTQshIPWe21JuPm0pFNGHcDliTCNk/R79afUBvqA/XfwMeWETOqAY3a4HzB1mPT40Klouw23Z9huADkekoAeeeVrtwT+quKDP8NvPuWVS84rmRnlnGrHQUrcvRHuZTTZhWKT4KvuvfZx3el6Kw8RzuFBGltJhO4BOZocHuT//Dlg1U/ug/CV7jLbzG8ILME6fr2/3JPPtXUJ9myLMIQT5S3uKQZnkiERoK1rqIirw+bknBTGEI/3X6csm9BREza1Z2kPzKRgDlSk99aFu1YA0s6p2glTQiEC0R38Xvufb8ppBlmtCxQii9DHMf9WAxqZRxki05ao7We4AkHpkk4viShtWneiHIrcKBMseQ82VzLztDretzflkse5EmEllgqpAq56Pfp/z59f2x1xFbulNkb+0Xn1LPpMN/wQFPO9LaO7vuukEPtIcqKXNcyIC+b9tkagawGWZT1MdwoCxBV5ilhXy/W2X2ahRP1MeYJyf/MwAUKlRaXFZhrsllIkrBiKSwgCg/y4DkOiGokhPnEuHDz1Lg7RFnA5JVUMDSAvc/9X2XjnzeEzVj8nMFcaEQY1J01i+eVEPdfYk5MNy+wlPYa/gwlhjljjOtx+b11cSgGDUM2ABmLPUBA== X-Forefront-Antispam-Report: CIP:216.228.118.232;CTRY:US;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:mail.nvidia.com;PTR:dc7edge1.nvidia.com;CAT:NONE;SFS:(13230040)(376014)(82310400026)(1800799024)(23010399003)(36860700016)(10067099003)(56012099006)(11063799006)(22082099003)(18002099003);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: P/39x0bZrM0LIJZCYxPoLLOh43DHuU8e5TGTc3pJ9+IROTAaH1VkcVuxomRj55L4VwiuXls6XvUR7ogKsNjBSOP1UryJfj2gQn0O627f3anyaXAfYgU7jpcDBq9CsqEhfPSOE5Smk4DTzTthxngZgjNwjM0kDF2NO1GSvzfKw+7wvqTuIILtUJEvXXuXopZbaGJK5YIbvIV5fjLSQbTGTzPth3OXXkw943PLgI2iuLBKSF8deKEycOFuXVWzvC+tjH/A1dny5qKLAsV7SlribE+IY+VjYCs/xhpgfXNBZ2d465wRI7BBKNjcOKRMo/dFqWAgqdP0NphiKPMKnbkawDwZPjjaWr0roEi/S0yAp4yYa5WkbXy4IZCgvpmeJ7v4/7+++M5L6j0m+PI725Ml0K2BnJ9MVn34MgHBhbceKiMmx1aSmWr0vRpd6YMzKmhI X-OriginatorOrg: Nvidia.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 15 Sep 2026 11:19:58.3031 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 722115b0-83f4-46db-eed2-08df131b46e5 X-MS-Exchange-CrossTenant-Id: 43083d15-7273-40c1-b7db-39efd9ccc17a X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=43083d15-7273-40c1-b7db-39efd9ccc17a;Ip=[216.228.118.232];Helo=[mail.nvidia.com] X-MS-Exchange-CrossTenant-AuthSource: BN3PEPF00022BBC.namprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: MW6PR12MB8759 Content-Type: text/plain; charset="utf-8" From: Yevgeny Kliteynik Replace kzalloc with the newer kzalloc_obj allocation function. Signed-off-by: Yevgeny Kliteynik Reviewed-by: Erez Shitrit Signed-off-by: Tariq Toukan --- drivers/net/ethernet/mellanox/mlx5/core/steering/hws/send.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/ethernet/mellanox/mlx5/core/steering/hws/send.c b/= drivers/net/ethernet/mellanox/mlx5/core/steering/hws/send.c index 80cfd0ddba08..49dee44d0bef 100644 --- a/drivers/net/ethernet/mellanox/mlx5/core/steering/hws/send.c +++ b/drivers/net/ethernet/mellanox/mlx5/core/steering/hws/send.c @@ -732,7 +732,7 @@ static int hws_send_ring_alloc_sq(struct mlx5_core_dev = *mdev, goto destroy_wq_cyc; } =20 - sq->wr_priv =3D kzalloc(sizeof(*sq->wr_priv) * buf_sz, GFP_KERNEL); + sq->wr_priv =3D kzalloc_objs(*sq->wr_priv, buf_sz); if (!sq->wr_priv) { err =3D -ENOMEM; goto free_dep_wqe; --=20 2.44.0 From nobody Fri Sep 25 07:56:39 2026 Received: from PH0PR06CU001.outbound.protection.outlook.com (mail-westus3azon11011035.outbound.protection.outlook.com [40.107.208.35]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 04D3449E5F5; Tue, 15 Sep 2026 11:20:03 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=fail smtp.client-ip=40.107.208.35 ARC-Seal: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1789471205; cv=fail; b=XTn+jy3O+Y4fWspZvbkcsKLHmYniBuhFyfx7Xzp9JzpSaS/Y8YNvBHUXdrBdTax6f1nODcpptaxRYBpQdQIP9mCAgn0kA+mO/5HW8ApWdvdnYI9eHlzUSl0EKUqC+xV9h9rrzQ/Pd6+Ej/pD5NMzCWxeGjDuqcnunEcyTFrhqys= ARC-Message-Signature: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1789471205; c=relaxed/simple; bh=mdqW8wSqTpbqrcgfzQh5DVf2w8/Yqp5w9VOPyawJ6bA=; h=From:To:CC:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=PJ7PB+e0XpXq45Q1QpiOTQN0yJ0zpMwktJsUVfB4dA0uMwmgkcbs09Wn0efc0gl7Ohnk/Fq++xdRXECu/xo87LztdxMI2SiNX1oDgWCg0fFWlwc20ERgRGTsPq0I3gP9yZrgfa4FC3++J5qZPEkVqRcI+ZAu9VA/1TiZK12okXU= ARC-Authentication-Results: i=2; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=nvidia.com; spf=fail smtp.mailfrom=nvidia.com; dkim=pass (2048-bit key) header.d=Nvidia.com header.i=@Nvidia.com header.b=YVpECWi6; arc=fail smtp.client-ip=40.107.208.35 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=nvidia.com Authentication-Results: smtp.subspace.kernel.org; spf=fail smtp.mailfrom=nvidia.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=Nvidia.com header.i=@Nvidia.com header.b="YVpECWi6" ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=xajNQ4IQ9iMYv41lyigwBHw1Z3/7Csq0/KOjN9beJMA9OPqWE8jdX3CYIXInp4/TC1DrWXqZfkltbAsFhCLPfwKbtWGcbu1wXUv/YZzT3mBKxIi/aYhRN2MsHIjG+loEURMn+HxReL7ugBhM4P3N5fnxuDlAAcEgbu6UjLAY/xFLZGj02RTn/QFb8GU0kW9yBrz5/TFWpYEWcOdLMZzSCSzJuzh+6/BuNM4Ma9EyEBKFrsQbyTcRBLuZv46Uqnat8VPn1Rq1oHuLTiNDGS3zrn4EtM8vXSD29cpO7Pw3JqIHd9kpXQP4FBwJUrNkp5vqs99meUZs2qo5pRZ4Z82CKw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=bZSx7DvrBwt/7v37s+xH3b78giZR2XId6c4QpjQ6ZSo=; b=Z9FbnHeaqUBMpgSjRAsH+r/Tjkj6SNKFccn+lw5yP/bugaecIeOrYPMHDc3iWORXxqq7CxrTnNYZxEfOFYLHb6kuCSl1fDmbNi/JAt7q1wag+XfkhKxLor/FL2apogHUU0DDBl8B/H/Xo1dJ5AdUBY4QEKNDlZxrz0o6FfvHygzIgzD3QbmmEzmvVrXANtDOoTY4hBv6LIjPW+scmAHRCAZPmBL0Evwu/4CY0UdcItKgsX9/carIwE+ZDPdMGBraR/S7Eb96Id/hkURbgrxJtYOLAoL98fFfpsWqG0rEi6MzKWcIxCQE5IWMgAIndMdm2gPykQajoi3yfzlxTV3l8A== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 216.228.118.233) smtp.rcpttodomain=lunn.ch smtp.mailfrom=nvidia.com; dmarc=pass (p=reject sp=reject pct=100) action=none header.from=nvidia.com; dkim=none (message not signed); arc=none (0) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Nvidia.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=bZSx7DvrBwt/7v37s+xH3b78giZR2XId6c4QpjQ6ZSo=; b=YVpECWi6SKhWMlHedj3+nmgZfveIwX+6sylaUDj/EPU7AbXgH0m/ltpDp76HnnAWOZVK/ZMZePeXvyVzXyHJvuQp7OsC4e12b3eZgPSSvPOPnEj0+Rq6Ykz8wvGJ/1gOcIA7A+6PqYATK5p8yqyzOi/vd3tYfcMLNiAi+Gc+6qS+bQA8hVSCd8isbWkIulFJtYS9Kp3omEC+sKYf2LQ7b8LH4h9v716bva44lN3kbRHKAaVan+25+HQwPyonoZN/FggpsKDj7s9bwfgTJPa2hYYAI0nIBRYjTVreXpXwOdtS3I9YIX5RWt6XKr+QJpDMUT/cNRadnsKGZ9Ec6mzQYQ== Received: from DS7PR05CA0107.namprd05.prod.outlook.com (2603:10b6:8:56::25) by DM6PR12MB4060.namprd12.prod.outlook.com (2603:10b6:5:216::15) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.21.406.12; Tue, 15 Sep 2026 11:19:58 +0000 Received: from DS2PEPF000061C4.namprd02.prod.outlook.com (2603:10b6:8:56:cafe::80) by DS7PR05CA0107.outlook.office365.com (2603:10b6:8:56::25) with Microsoft SMTP Server (version=TLS1_3, cipher=TLS_AES_256_GCM_SHA384) id 15.21.428.9 via Frontend Transport; Tue, 15 Sep 2026 11:19:58 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 216.228.118.233) smtp.mailfrom=nvidia.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=nvidia.com; Received-SPF: Pass (protection.outlook.com: domain of nvidia.com designates 216.228.118.233 as permitted sender) receiver=protection.outlook.com; client-ip=216.228.118.233; helo=mail.nvidia.com; pr=C Received: from mail.nvidia.com (216.228.118.233) by DS2PEPF000061C4.mail.protection.outlook.com (10.167.23.71) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.21.428.7 via Frontend Transport; Tue, 15 Sep 2026 11:19:58 +0000 Received: from drhqmail201.nvidia.com (10.126.190.180) by mail.nvidia.com (10.127.129.6) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.2562.49; Tue, 15 Sep 2026 04:19:45 -0700 Received: from drhqmail203.nvidia.com (10.126.190.182) by drhqmail201.nvidia.com (10.126.190.180) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.2562.49; Tue, 15 Sep 2026 04:19:45 -0700 Received: from vdi.nvidia.com (10.127.8.10) by mail.nvidia.com (10.126.190.182) with Microsoft SMTP Server id 15.2.2562.46 via Frontend Transport; Tue, 15 Sep 2026 04:19:41 -0700 From: Tariq Toukan To: Andrew Lunn , "David S. Miller" , Eric Dumazet , Jakub Kicinski , , Paolo Abeni CC: Erez Shitrit , Gal Pressman , "Leon Romanovsky" , open list , , Mark Bloch , Saeed Mahameed , Tariq Toukan , Yevgeny Kliteynik Subject: [PATCH net-next 4/6] net/mlx5: HWS, Add timeout mechanism to draining send queues Date: Tue, 15 Sep 2026 14:19:10 +0300 Message-ID: <20260915111912.3926585-5-tariqt@nvidia.com> X-Mailer: git-send-email 2.44.0 In-Reply-To: <20260915111912.3926585-1-tariqt@nvidia.com> References: <20260915111912.3926585-1-tariqt@nvidia.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-NV-OnPremToCloud: ExternallySecured X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: DS2PEPF000061C4:EE_|DM6PR12MB4060:EE_ X-MS-Office365-Filtering-Correlation-Id: c91e07c2-6bf0-4e28-a24a-08df131b46f1 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|36860700016|23010399003|376014|1800799024|82310400026|56012099006|11063799006|10067099003|22082099003|18002099003; X-Microsoft-Antispam-Message-Info: PjAfv9nZpX3DIKcUH40/GWlbNzZd3Lc0UGMQBjqe4INGYluSCNQ2V7G4P4vWks+FHBR+aHxDd1w0pIW7zxdghL9yuZXlra09+JXNeyTgxNVD58ij+T4AiUxZ0+GeKLehXlEvGUSuPCf+l7TE4ZdJYGBPRdQrN5v9MdwQQSsJHXCG9nKYyHKuPwej+FPQk4iMIgul6v8y0U+kRypnL5ci3DXhpqU+gW3xCN/mGE8Oo4DGAZZ+/5DYo/H7lwl4KyF7gLhVbDTQpns7Omsz9U0yyOTo4AZaABVfpW0jOm88uMuQj7hq6OirA7hBQSeFT+Jg+ZCYL9nKCkTQyNztzIePrBduCedTyMAMN1kc2JquUuAxzkH7J9OhKIPg5MZYygf+0Zz61tCK3tZMeUU2qkvjZjEZVfn5r3EY40WEdbt4QO8aiND7d6U1uY+0e9+SaaKgcJr/fYChFk100jFIMTqveqgmKU3OWBu2tfPr/wE8GpgoghMmI7HfTjvtwNpmVl1zhyKBNXxtHJjIunw9A8yDU0YenXK/C6HbSCUOfpCpO9Z7hK+omxLAJxBl07up3t9hW9vcgYp7fdKqspG36xzfKdh7chYMX6pbcbZQRoeaCQA7sxdCt247dMTMBBMQ000iiOEEtUPhD8NEiVcKhb3ZUOq26Jq405sUWbOiZwyjIw5HaErjmh7J9GX8qiVxOv9JzwtxmSjgWAKRRDd14ZO9Jg== X-Forefront-Antispam-Report: CIP:216.228.118.233;CTRY:US;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:mail.nvidia.com;PTR:dc7edge2.nvidia.com;CAT:NONE;SFS:(13230040)(36860700016)(23010399003)(376014)(1800799024)(82310400026)(56012099006)(11063799006)(10067099003)(22082099003)(18002099003);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: fX0rUuVauLFtoLgEWCG64AUWOzBWH+Vybk4cc6WjGUnrbUPNiZuSm7IO3bTsZEPmGkq9R4477hSibwFU5ZKFlaMSstfYk5dUlp8kEc+rWctVs6U7YbCEKaKydXz2IuQmuOCMw7bQVUGtPBLoGxXgX4KOS8ZSqjlb61rbTkOVi5oQ3vpw/f+WgeXZhqum4vgDYhoz//pLaL+pLjXGlQkNse2ZvrkqRNIKTGVQKgbpDhZKFvB4nE/VELkVXyAL6GKbJ5lWyIjZ9SYmGFmp6Bufuij70/P0gCSOMSLN0jn3PN6fb8J8X8nTm5ZIzsPW4JihzXjtIM8JMBvhsKe3h1bom+fCJML0Kpwsx/94gPXRTlUIQCrxTQNc+be82KV7Us11H8ZXuBvekCOFtFPINErtanDns2i0iYjbpGC7AqoPBRjjgJTGD9bFtUGyqLzKFVik X-OriginatorOrg: Nvidia.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 15 Sep 2026 11:19:58.3729 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: c91e07c2-6bf0-4e28-a24a-08df131b46f1 X-MS-Exchange-CrossTenant-Id: 43083d15-7273-40c1-b7db-39efd9ccc17a X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=43083d15-7273-40c1-b7db-39efd9ccc17a;Ip=[216.228.118.233];Helo=[mail.nvidia.com] X-MS-Exchange-CrossTenant-AuthSource: DS2PEPF000061C4.namprd02.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM6PR12MB4060 Content-Type: text/plain; charset="utf-8" From: Yevgeny Kliteynik HWS has a timeout mechanism for usual polling for completion, but it was missing such a mechanism for draining the send queues. Signed-off-by: Yevgeny Kliteynik Reviewed-by: Erez Shitrit Signed-off-by: Tariq Toukan --- .../ethernet/mellanox/mlx5/core/steering/hws/bwc.c | 4 +++- .../ethernet/mellanox/mlx5/core/steering/hws/send.c | 13 ++++++++++++- 2 files changed, 15 insertions(+), 2 deletions(-) diff --git a/drivers/net/ethernet/mellanox/mlx5/core/steering/hws/bwc.c b/d= rivers/net/ethernet/mellanox/mlx5/core/steering/hws/bwc.c index 3bcf412a08c4..14a2bb9167a4 100644 --- a/drivers/net/ethernet/mellanox/mlx5/core/steering/hws/bwc.c +++ b/drivers/net/ethernet/mellanox/mlx5/core/steering/hws/bwc.c @@ -460,7 +460,9 @@ int mlx5hws_bwc_queue_poll(struct mlx5hws_context *ctx, got_comp =3D !!ret; =20 if (unlikely(!got_comp && time_after(jiffies, timeout))) { - mlx5hws_err(ctx, "BWC poll error: polling queue %d - TIMEOUT\n", queue_= id); + mlx5hws_err(ctx, + "BWC poll error: polling queue %d - TIMEOUT (%d sec)\n", + queue_id, MLX5HWS_BWC_POLLING_TIMEOUT); return -ETIMEDOUT; } } diff --git a/drivers/net/ethernet/mellanox/mlx5/core/steering/hws/send.c b/= drivers/net/ethernet/mellanox/mlx5/core/steering/hws/send.c index 49dee44d0bef..9ff109fc8230 100644 --- a/drivers/net/ethernet/mellanox/mlx5/core/steering/hws/send.c +++ b/drivers/net/ethernet/mellanox/mlx5/core/steering/hws/send.c @@ -1192,6 +1192,8 @@ int mlx5hws_send_queue_action(struct mlx5hws_context = *ctx, u16 queue_id, u32 actions) { + unsigned long timeout =3D jiffies + + secs_to_jiffies(MLX5HWS_BWC_POLLING_TIMEOUT); struct mlx5hws_send_ring_sq *send_sq; struct mlx5hws_send_engine *queue; bool wait_comp =3D false; @@ -1213,9 +1215,18 @@ int mlx5hws_send_queue_action(struct mlx5hws_context= *ctx, mlx5hws_send_engine_flush_queue(queue); =20 /* Poll queue until empty */ - while (wait_comp && !mlx5hws_send_engine_empty(queue)) + while (wait_comp && !mlx5hws_send_engine_empty(queue)) { hws_send_engine_poll_cq(queue, NULL, &polled, 0); =20 + if (unlikely(time_after(jiffies, timeout))) { + mlx5hws_err(ctx, + "Error draining send queue %d - TIMEOUT (%d sec)\n", + queue_id, + MLX5HWS_BWC_POLLING_TIMEOUT); + return -ETIMEDOUT; + } + } + break; default: return -EINVAL; --=20 2.44.0 From nobody Fri Sep 25 07:56:39 2026 Received: from CH1PR05CU001.outbound.protection.outlook.com (mail-northcentralusazon11010021.outbound.protection.outlook.com [52.101.193.21]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 8D8C049502D; Tue, 15 Sep 2026 11:20:15 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=fail smtp.client-ip=52.101.193.21 ARC-Seal: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1789471217; cv=fail; b=SO3IK4MmbJ7U8xtf4Vp55cZhjrczX9bdTI9ylUy2E+8D3NfsyDrO1uCktg1soUWPxRsiI5QFIlkflVrw1LMuTDOLaPbClL1XL2ZwZtk353HAiBBg70P5ND71yRDzUv52muobrJdPZXLKK4XyjtVYs+SxAu55tV9e0RLyf2dtpBY= ARC-Message-Signature: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1789471217; c=relaxed/simple; bh=gg1yEEvcr3PTiiAdwPPu//pdvZyfVfBpxL4mA8kTks8=; h=From:To:CC:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=pVKKLhizXwOKdrpobDEHp7AUw2DxNqDU9wYu8Gm/9hAvgrljrIWtKOCXyaOyN91XjIEqjUuWTkNXu6tEO92wpJAgojEtZy+WopAYAT79ovsGXJlrBbX+TIrOOW5j5fpqtEc6vCbo7eLREI5tIAm/Nwm6bpKMqtS9orSB82EYeI4= ARC-Authentication-Results: i=2; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=nvidia.com; spf=fail smtp.mailfrom=nvidia.com; dkim=pass (2048-bit key) header.d=Nvidia.com header.i=@Nvidia.com header.b=YaZQYtRT; arc=fail smtp.client-ip=52.101.193.21 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=nvidia.com Authentication-Results: smtp.subspace.kernel.org; spf=fail smtp.mailfrom=nvidia.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=Nvidia.com header.i=@Nvidia.com header.b="YaZQYtRT" ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=Cfo/85e7sBUM2Uzc7qtfMymnB0tLmrhIrauHCXI8Sybef3TAzrZTXlG2U/Q/vwg6gRdv4HUfIbCtcFpKb5FAaGFbuIj0whddbndFhXS8s+bE/LiEGmbBp+/rdHwbgG1E2h3Zxo/6mw+ahnJj2M1WAkeFBdrWqNdAoQF4XOLe9CRPR3yFfsMH4r0659Ryp7ymnxfOEnyt8R8F2VfLD1bps4CXOcLYNkFixtctx6PSteFPVWrcVfMYYv+Mw+u40QQiQNNjw81JlvQVV1V2DDboe4SZX/H0thV00XQ87Z6ZErdiVSHB5JEm8/omUWvQEj2Aiig2cTtyoQnICJ7ombHdlg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=JzPllBcsW+JCwTm6NHh0cMdyS6rhUDpPf8tkA4881l0=; b=Gpk95niQqj5EGelMMWLq6OtFMy31r70Q+n0B+RtN5k+DE1kXlYP6p7pSBfZ4OanvHIEW/x3knlWoGjtwQ0i9NOOA8a9mBAz7g2le3cDRdLaD1+Ul5LEqqyGfohMoSfC8Gz/5HpA43n/8afI8m2QztiSiokI+1nog/ua7yBEEjpnIkGVo47RZKvY0itZEvx0iOKoH3UpN8UV3WPoxzT3fibYyepcEbF7eDvEXwN+DextqNiCPd0gDdOc6WZ2RkZfRXFj45jaEbwtcE2npiiAxggT/yYu3m011nfubU0lgmpEvP5LC0W3nGFBHiG4s4ysrbnAoN0YG/6sES6V7UJW1ww== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 216.228.118.232) smtp.rcpttodomain=lunn.ch smtp.mailfrom=nvidia.com; dmarc=pass (p=reject sp=reject pct=100) action=none header.from=nvidia.com; dkim=none (message not signed); arc=none (0) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Nvidia.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=JzPllBcsW+JCwTm6NHh0cMdyS6rhUDpPf8tkA4881l0=; b=YaZQYtRTAF0xsHuZabnXfUKf98QOQjYIQbxvGDccaiZkBCDVkdjFiA7H09IpZEZgHNfUDvj2COMxG3Cv/mr5+VDtb6in6goOKsz2HSrYw+EZvhz2EbxEcXC48dBPN2LBUP0mgTRisstO3goz3l7EN4iYSoegvC8NxSQvyce64eHPDH9a+vnlBovx/uliGs72P4VU+tbDeqhMxpM/NXdyVwnZsqWGBoSYAWb4j6l+GSv0Fk/Din4CZNud8rWh+l6ggfW+J4bw7hBhfc0Jrlus42kCpkvVuk8ZLNH4yuPWALY8JLF4Tj7l1m4F0uVyD9y3GInYuWAgHhpMhDCU8p6lcw== Received: from BN0PR04CA0140.namprd04.prod.outlook.com (2603:10b6:408:ed::25) by BL3PR12MB6619.namprd12.prod.outlook.com (2603:10b6:208:38e::5) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.21.406.12; Tue, 15 Sep 2026 11:20:10 +0000 Received: from BN3PEPF00022BBA.namprd04.prod.outlook.com (2603:10b6:408:ed:cafe::8b) by BN0PR04CA0140.outlook.office365.com (2603:10b6:408:ed::25) with Microsoft SMTP Server (version=TLS1_3, cipher=TLS_AES_256_GCM_SHA384) id 15.21.428.9 via Frontend Transport; Tue, 15 Sep 2026 11:20:10 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 216.228.118.232) smtp.mailfrom=nvidia.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=nvidia.com; Received-SPF: Pass (protection.outlook.com: domain of nvidia.com designates 216.228.118.232 as permitted sender) receiver=protection.outlook.com; client-ip=216.228.118.232; helo=mail.nvidia.com; pr=C Received: from mail.nvidia.com (216.228.118.232) by BN3PEPF00022BBA.mail.protection.outlook.com (10.167.248.116) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.21.428.7 via Frontend Transport; Tue, 15 Sep 2026 11:20:10 +0000 Received: from drhqmail203.nvidia.com (10.126.190.182) by mail.nvidia.com (10.127.129.5) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.2562.49; Tue, 15 Sep 2026 04:19:49 -0700 Received: from drhqmail203.nvidia.com (10.126.190.182) by drhqmail203.nvidia.com (10.126.190.182) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.2562.46; Tue, 15 Sep 2026 04:19:49 -0700 Received: from vdi.nvidia.com (10.127.8.10) by mail.nvidia.com (10.126.190.182) with Microsoft SMTP Server id 15.2.2562.46 via Frontend Transport; Tue, 15 Sep 2026 04:19:45 -0700 From: Tariq Toukan To: Andrew Lunn , "David S. Miller" , Eric Dumazet , Jakub Kicinski , , Paolo Abeni CC: Erez Shitrit , Gal Pressman , "Leon Romanovsky" , open list , , Mark Bloch , Saeed Mahameed , Tariq Toukan , Yevgeny Kliteynik Subject: [PATCH net-next 5/6] net/mlx5: HWS, Handle timeout draining the send queue for FW STEs Date: Tue, 15 Sep 2026 14:19:11 +0300 Message-ID: <20260915111912.3926585-6-tariqt@nvidia.com> X-Mailer: git-send-email 2.44.0 In-Reply-To: <20260915111912.3926585-1-tariqt@nvidia.com> References: <20260915111912.3926585-1-tariqt@nvidia.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-NV-OnPremToCloud: ExternallySecured X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: BN3PEPF00022BBA:EE_|BL3PR12MB6619:EE_ X-MS-Office365-Filtering-Correlation-Id: b217407c-9596-40d8-ac7e-08df131b4dfd X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|376014|82310400026|1800799024|23010399003|36860700016|10067099003|56012099006|11063799006|22082099003|18002099003; X-Microsoft-Antispam-Message-Info: MyPPSNm3FuHmZQKJG/7eS6I1fETyQrXzwRz9B+U5K/CKly0GgaEY7+ncRi/+29e9ELpLJY6p3GLQaPF0RHBpLAJEXOAuN5dtRBL6XqC+6NQHHAWP714B+iq1LJvKlrcpH6BLOtMDV/RWHlWMwSBnvSqEOIMGbzD7kCfbFoTaX7amPcvpe9P4yffjyT7Z/GnpoKRJDXAyFVC5wj3RwXQOFo713NML0WFm+ICk4UJSZRhl2UO21JcIbtnKBeU53PmD3ter1fnpgeGy8PMn4sZvygCftuLh6+WEiDEymtu407uTn6CEnF2uNb18fKmrqsCG+s4kMPAFheq0Bibeipyu1NQexSWJCl1kAG1mKn83ki9Eg4qpuDhOHhBbIi8ApNxnJZLZCX7GY6WXhxWumarAjNFKsv/cQmb+R8ktOvw2QzN21INsG2tAbqbLjkifVFkKlNpwsK3QYohKvVVVdX9068AivujADoUBJN7K19Zwc50KkhYp4NEoECcB35QkhvvQVdfDZNNGC5awu+sFwjWnDzHjzwmCbNKx/nrvn2NzxJridGtQJXn8REcn+5ae7I4GI6Fq5bYfysacq1E6ExJURFsaV9jjJjWi0uAGT5STJSIEwHBUppxB475786JkahBm6RYwg/5PemVfC+xSscBkgVsF1IPHeT0Yf+fBB+aLe8iEfoPGodWRmc8o4/yWUW2Nax0zhooyJlyK01K1TU+j8w== X-Forefront-Antispam-Report: CIP:216.228.118.232;CTRY:US;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:mail.nvidia.com;PTR:dc7edge1.nvidia.com;CAT:NONE;SFS:(13230040)(376014)(82310400026)(1800799024)(23010399003)(36860700016)(10067099003)(56012099006)(11063799006)(22082099003)(18002099003);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: ni4WCNTFbwqJq7jOPjBBkB4ysCLYZrTbU9DeDmGvZjTNh5o++HZbMIw6RKtZ7xNC2L5LJq9z0Z4k5BUMxi3CuTLbaEcGsYWyFqks896x6g12QuHL6n+ydUbJQHjoR6axN56Qq1iPoPD7kdqyipiGRd5V2AemOCAoqiWTYOWnn4tas/FvC/AlhmVsp9b+r73lDHiWWos8YyMn7xhzotMDmuJ4BjDSGQvdEWzAWugIxnhkXNSOGTzOGSynE7tP7mTkQmv4FIFLIe7IyWGwm+v0TC4sEmcpyBUnOEQoK15aO3XLgavNQ+tNj4gsvFli4TGnEiqDY9gTu09gr2JuHMcUkIfIu7Zh28p8G3vxlOAxTd13zwPUUqpBY9X1OSJgyJi5UjN05eSGmbMthrOSKDrsl22oiGwQAHdQJRwwmA91qsbStYpFyiByopl0mahBXL9N X-OriginatorOrg: Nvidia.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 15 Sep 2026 11:20:10.1339 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: b217407c-9596-40d8-ac7e-08df131b4dfd X-MS-Exchange-CrossTenant-Id: 43083d15-7273-40c1-b7db-39efd9ccc17a X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=43083d15-7273-40c1-b7db-39efd9ccc17a;Ip=[216.228.118.232];Helo=[mail.nvidia.com] X-MS-Exchange-CrossTenant-AuthSource: BN3PEPF00022BBA.namprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: BL3PR12MB6619 Content-Type: text/plain; charset="utf-8" From: Yevgeny Kliteynik Handle a case in mlx5hws_send_stes_fw where draining a queue fails with timeout. Signed-off-by: Yevgeny Kliteynik Reviewed-by: Erez Shitrit Signed-off-by: Tariq Toukan --- .../ethernet/mellanox/mlx5/core/steering/hws/send.c | 12 ++++++++---- 1 file changed, 8 insertions(+), 4 deletions(-) diff --git a/drivers/net/ethernet/mellanox/mlx5/core/steering/hws/send.c b/= drivers/net/ethernet/mellanox/mlx5/core/steering/hws/send.c index 9ff109fc8230..bddac018b44b 100644 --- a/drivers/net/ethernet/mellanox/mlx5/core/steering/hws/send.c +++ b/drivers/net/ethernet/mellanox/mlx5/core/steering/hws/send.c @@ -1335,10 +1335,14 @@ void mlx5hws_send_stes_fw(struct mlx5hws_context *c= tx, pdn =3D ctx->pd_num; =20 /* Writing through FW can't HW fence, therefore we drain the queue */ - if (send_attr->fence) - mlx5hws_send_queue_action(ctx, - queue_id, - MLX5HWS_SEND_QUEUE_ACTION_DRAIN_SYNC); + if (send_attr->fence) { + enum mlx5hws_send_queue_actions drain =3D + MLX5HWS_SEND_QUEUE_ACTION_DRAIN_SYNC; + + ret =3D mlx5hws_send_queue_action(ctx, queue_id, drain); + if (ret) + goto fail_rule; + } =20 if (ste_attr->rtc_1) { send_attr->id =3D ste_attr->rtc_1; --=20 2.44.0 From nobody Fri Sep 25 07:56:39 2026 Received: from SA9PR02CU001.outbound.protection.outlook.com (mail-southcentralusazon11013026.outbound.protection.outlook.com [40.93.196.26]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 6AD6F4A204F; Tue, 15 Sep 2026 11:20:14 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=fail smtp.client-ip=40.93.196.26 ARC-Seal: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1789471216; cv=fail; b=a4Wi+6AXSF9ou7cDBfbzUo37PFVGHjOjx65hYfRMq61wpDHi1FpNltYJ9H9gaH0jOj7ovsnuNWX1GiPX99t4AzVqooLX4IMyTcWzLqZDnEAjLYyk0k5tcmRRjwN+N9jIV+qNU6CgqI97mZUjdFvOOKq4kU8FjKcoUbCswRvipc0= ARC-Message-Signature: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1789471216; c=relaxed/simple; bh=jfi+zfQfXZsDy7xj41tIlv601FdM4cUyVR0ihfCwE4M=; h=From:To:CC:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=c9AaTrtjyfFDmj3F72tAlo/hlHtScedCo6pZNOhIngu9c8aF4/ePXXlGNYAvT/gyCUDJp0AkfVwTKYycIlqDREmirLALXoCJuUTBz0MUruQBa+q0JNCWKAqFIYg+CZ7O8W5KjJuYA+7cQ2D2oQvz2aV92Zgq/JK1JIQQ/0NAC5g= ARC-Authentication-Results: i=2; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=nvidia.com; spf=fail smtp.mailfrom=nvidia.com; dkim=pass (2048-bit key) header.d=Nvidia.com header.i=@Nvidia.com header.b=d1OAnp7z; arc=fail smtp.client-ip=40.93.196.26 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=nvidia.com Authentication-Results: smtp.subspace.kernel.org; spf=fail smtp.mailfrom=nvidia.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=Nvidia.com header.i=@Nvidia.com header.b="d1OAnp7z" ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=pPP7I8YmXWXJXf+K0MiZgESiJLkHUfp3v8FQAvxOJ3e3cYLgiANsVTFcqbmGkzYAkfUKJzA0XU8ZLuklSZNSnAX4v4syvXDa2XPhxTtq0RDPiKswS2vm4s0VuwCJIcZh4oERx+sFhHq++J7oEUAViwhSB6w5ppMESD+2URbAiMOlpyDO6NUuy9/Y5e2sENSlPQ9QJ0Byvcl52FCeWDNtrBFisxMpDTVhF5I0ZG1Ai2GCyzyjsOwn+5UCwXI2ZWHknSRdypNFBwVPtVlgVdcKnzg10M3Xcuc6YX9Ey+RshI4fZGPTBqHW0ouMBKzL1cUehITm67MsxTY7wcaAIUeygg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=tcrWdU4yZbBCPInaHyX/pqgGA79fcTjdJFPINGseoAw=; b=mTPjdx45XQv2/CZkf1EKdStyhGmMI1DmS2uDCYJ4/EMpTc3qpsT6B9N8G5kL1LC9wZ7FapDMPiYQnOhfObpnL1X8xVzgeECfjPsgB2Wt8OP6NxjkKLyEVGlxnbsjvQNAaP5cr2DccQ/Hq2j+BdTzvr9/RTa8el8jqmZgp1qJFt/FSKn82NC3AT/GxXZ6ksuuaF+Q+t9R8mpGTfqz2Y0BFD/RpY+nGJisX3DfqxOFfc5jpyXxsI0QH8i5vfffkKYkigVLlB/9qtxUqUYyqVQ3ntoP+O/KqzYuukR3objknmnukPtDXcHnqu0Ma6n5XD3b6qq88vpSiP1C7dNWKwf7CA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 216.228.118.233) smtp.rcpttodomain=lunn.ch smtp.mailfrom=nvidia.com; dmarc=pass (p=reject sp=reject pct=100) action=none header.from=nvidia.com; dkim=none (message not signed); arc=none (0) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Nvidia.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=tcrWdU4yZbBCPInaHyX/pqgGA79fcTjdJFPINGseoAw=; b=d1OAnp7zqJupPr3clbjsLnbouDAD3sci/dZeaoPuoRIeTVe5xjY/L6JEzWux9OxbURa/BUsaJtYL27j+P3PNuc0H7EL83lDSuZrT9qoGNW3th46mk6d3orTlKVCAwI5fVaEk86oraBS5lJtV1AccAVpwia75nx0dER7/VK+2IOl8K1pwTlYdPwrZqPBpmjDBv27e4Jzu40DGjXwJuViKgjdu9v3J3O4jkowqVeMTZ9tSvstY1786t4610pz0MttnDW5Ldzs9hKKVTfVbFut/rvOKIo2GtesVu+SXNNKPBosTfGKQWNOKVkuLqAJRTabyAvO49xUQObC7w+9CJbiZTw== Received: from CH5PR02CA0014.namprd02.prod.outlook.com (2603:10b6:610:1ed::18) by DS7PR12MB9551.namprd12.prod.outlook.com (2603:10b6:8:24f::13) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.21.406.12; Tue, 15 Sep 2026 11:20:06 +0000 Received: from DS2PEPF000061C3.namprd02.prod.outlook.com (2603:10b6:610:1ed:cafe::4) by CH5PR02CA0014.outlook.office365.com (2603:10b6:610:1ed::18) with Microsoft SMTP Server (version=TLS1_3, cipher=TLS_AES_256_GCM_SHA384) id 15.21.428.9 via Frontend Transport; Tue, 15 Sep 2026 11:20:06 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 216.228.118.233) smtp.mailfrom=nvidia.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=nvidia.com; Received-SPF: Pass (protection.outlook.com: domain of nvidia.com designates 216.228.118.233 as permitted sender) receiver=protection.outlook.com; client-ip=216.228.118.233; helo=mail.nvidia.com; pr=C Received: from mail.nvidia.com (216.228.118.233) by DS2PEPF000061C3.mail.protection.outlook.com (10.167.23.70) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.21.428.7 via Frontend Transport; Tue, 15 Sep 2026 11:20:06 +0000 Received: from drhqmail202.nvidia.com (10.126.190.181) by mail.nvidia.com (10.127.129.6) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.2562.49; Tue, 15 Sep 2026 04:19:53 -0700 Received: from drhqmail203.nvidia.com (10.126.190.182) by drhqmail202.nvidia.com (10.126.190.181) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.2562.46; Tue, 15 Sep 2026 04:19:53 -0700 Received: from vdi.nvidia.com (10.127.8.10) by mail.nvidia.com (10.126.190.182) with Microsoft SMTP Server id 15.2.2562.46 via Frontend Transport; Tue, 15 Sep 2026 04:19:49 -0700 From: Tariq Toukan To: Andrew Lunn , "David S. Miller" , Eric Dumazet , Jakub Kicinski , , Paolo Abeni CC: Erez Shitrit , Gal Pressman , "Leon Romanovsky" , open list , , Mark Bloch , Saeed Mahameed , Tariq Toukan , Yevgeny Kliteynik Subject: [PATCH net-next 6/6] net/mlx5: HWS, Remove unneeded WRITE_ONCE in post send Date: Tue, 15 Sep 2026 14:19:12 +0300 Message-ID: <20260915111912.3926585-7-tariqt@nvidia.com> X-Mailer: git-send-email 2.44.0 In-Reply-To: <20260915111912.3926585-1-tariqt@nvidia.com> References: <20260915111912.3926585-1-tariqt@nvidia.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-NV-OnPremToCloud: ExternallySecured X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: DS2PEPF000061C3:EE_|DS7PR12MB9551:EE_ X-MS-Office365-Filtering-Correlation-Id: 1b5a4671-d902-4423-bb4e-08df131b4b9b X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|36860700016|376014|23010399003|1800799024|82310400026|56012099006|11063799006|10067099003|18002099003|22082099003; X-Microsoft-Antispam-Message-Info: Mrp4Z6hGqqHEYLymKZI16KnWJRaLgu9ia8nmxdce4wfRyWq5bsYNtp8DuC1ai129t1e+qw3rRovWfFVPqt7Drc8fNEseTvoXPC0tpfH6HTNHsoO9lL/7RNLYeTrgIF8RCcvrIhFT02e9Z0B0eTEUoRq2YTWgjsIVFZ9xnvBJdSikVl0RvWw8NbU8YJiuxC+mOf1QGWlvnYcFbz9X20ODus0ttTwiebXlT6asC3s9VNk1UeI58VklB44Gx5h4iGvKUUWgzjfsqbfRT4tapejeZA5gHC1gmsWcVSGGN2rRA4vPsjIQ7TFLAgZ5xtvgB5t1OLOPhvzHxH06UnJ2KnUQ/o9mneTPmANGd/J9ZxKIhIEXO5rS2e5qKwOZvETcXmD8NH3wJXxfQrTmS9yIvFJ1iXfnw7viucA/x0Wntm5igFODOwBp3PisgSNZTJSsPjrHpLiuyV1h1N9qEc8X0+g/NU0HcDuHyrgB4dIjeSWb5/qPjKXfBl00Wv5za7dBzYHlgSsRipZ1QsdMhprFjH2HX6Ao+slMQFjLAjj3IJZWTBEkSRKLAkBxqCTaK4FhTB8ZuXxquWvF9LX9KGhmjPA8shZfMJTd9UfyWCeFtBWKIyg+3uuGMBtPzXJsk3ni/+KuYMwqle+y7RkBIgHkKyELUFJMq4Q5wjwclnb3pmP70S8OhTeOZ0sJa8n8nZJC9bCCEA7oQY+F2481dTUxoqPlKg== X-Forefront-Antispam-Report: CIP:216.228.118.233;CTRY:US;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:mail.nvidia.com;PTR:dc7edge2.nvidia.com;CAT:NONE;SFS:(13230040)(36860700016)(376014)(23010399003)(1800799024)(82310400026)(56012099006)(11063799006)(10067099003)(18002099003)(22082099003);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: CXSMrf/FLD1OrqS/XryyaAJZWLZ0dFof81Kdp1JQokAfXB/UhpzkhJ5ijA6NKFjAlxi1y6Dn/6j78BzlHrCmUQ2zKdGJ4U49dZy1I8EvMXc5xGzdzytEtfEi2hPAiAqmG+UPbHbx9FKX5jo8vPIdMh+nUjDis9agrPC9WAkFkizNYFBk/Mx93V9YPeoQYcgrzCZw+PFYJDPJDirz70FguMAGN9I1Eo7o9jHzCYQQE1HZpe5j4aJ/6lX05hSi0my6Qyb6gIPvChx0mqaEgcEhwA+OE5UiewoNaKVVK62iG6UnYDYjCktZsiSN1gLfniWQjRrfHcS3Hn8cPLREZ6Ya+wDE9jNZ7TCURoQXTpSU+fuygXV0FaXKG672sSlA6GtUZrMkEs/n9krwLAW/fi8P83UlAbcEXcF3BNf/Z1avF5Z0aKq1hiTC6oFonP/gz182 X-OriginatorOrg: Nvidia.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 15 Sep 2026 11:20:06.2004 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 1b5a4671-d902-4423-bb4e-08df131b4b9b X-MS-Exchange-CrossTenant-Id: 43083d15-7273-40c1-b7db-39efd9ccc17a X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=43083d15-7273-40c1-b7db-39efd9ccc17a;Ip=[216.228.118.233];Helo=[mail.nvidia.com] X-MS-Exchange-CrossTenant-AuthSource: DS2PEPF000061C3.namprd02.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: DS7PR12MB9551 Content-Type: text/plain; charset="utf-8" From: Yevgeny Kliteynik Remove the unneeded WRITE_ONCE, for two reasons: a) This write is erroneous - it just writes to a local variable and doesn't have any effect. b) This code originated from another place (copy-paste bug), where there was actually a CQ polling right after this line, and the WRITE_ONCE was writing to another place. Signed-off-by: Yevgeny Kliteynik Reviewed-by: Erez Shitrit Signed-off-by: Tariq Toukan --- drivers/net/ethernet/mellanox/mlx5/core/steering/hws/send.c | 3 --- 1 file changed, 3 deletions(-) diff --git a/drivers/net/ethernet/mellanox/mlx5/core/steering/hws/send.c b/= drivers/net/ethernet/mellanox/mlx5/core/steering/hws/send.c index bddac018b44b..8b70040eaca0 100644 --- a/drivers/net/ethernet/mellanox/mlx5/core/steering/hws/send.c +++ b/drivers/net/ethernet/mellanox/mlx5/core/steering/hws/send.c @@ -111,9 +111,6 @@ static void hws_send_engine_post_ring(struct mlx5hws_se= nd_ring_sq *sq, wmb(); =20 mlx5_write64((__be32 *)doorbell_cseg, sq->uar_map); - - /* Ensure doorbell is written on uar_page before poll_cq */ - WRITE_ONCE(doorbell_cseg, NULL); } =20 static void --=20 2.44.0