From nobody Fri Sep 25 07:56:39 2026 Received: from mail-ej2-f12.google.com (mail-ej2-f12.google.com [74.125.228.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 56A9F3AAF76 for ; Tue, 15 Sep 2026 09:02:56 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=74.125.228.140 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1789462978; cv=none; b=ghbTgVn3auJTC+eV4Wornu3DZsRAph25UId6uCROYuQrehBFS+lFzsH9+ZtponE7NS3eblKGfGmsT5OnXqMzS8kXvD9qaVfu0tWSjmJ6d3uslQaAeIlC5Zu9j8vxYr+Bjt0SW8XBXhFE6qT+PFGTZLKfGEvGXS+/Cb+0CmtXBIg= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1789462978; c=relaxed/simple; bh=WHzBXw3Vfp/jx3HNdEqzwg/ei+fttabtBIAcfjiy6Kc=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=aa8YP562NS2MU6an/K3nsJ5S5nkbKj0RDigUQ39tPNqFxUSnltCgA0zFGFq/+mSmIZ7kAMsgt5ZWa7qpKEFevqrFStmeg/p6QoLDYpktOdtNa2sQr9a+12AwBpK7TGiCVKxDuH8C3Mhc+YZs4vxaKjAVKujjnYxK/sz9NxpTjWQ= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=AfK7t6Sq; arc=none smtp.client-ip=74.125.228.140 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="AfK7t6Sq" Received: by mail-ej2-f12.google.com with SMTP id a640c23a62f3a-c29d33431c8so7550466b.2 for ; Tue, 15 Sep 2026 02:02:56 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1789462975; x=1790067775; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to:content-type; bh=chLjM5CTnb50HHVQx65I0WAjKAwm9kU8MWpPfnwKwJY=; b=AfK7t6SqrhvJNGvaT5XeMxcFQ7vRkJOrN8YQ1NATGlhuZ5sBt2jPARvZe6RNeka2At 29/6fWT/Wr02orRNuebvHyZMyz/WynCUvdLyteq2rCn4e0lfB7Yj9I7bm3qHZmckoeXc +5AEZvMmwr0xjhndzUZeHYM8KwfsXqDsaRehdoJoDYBn10h1wYCHG9Wl9EiYtx37spn7 ZkO1y4Rs3+0UiCH7taognZx1+sbF1UEgIryTredC0xTaFXEBPaNkp5WoaopnBPZEgM4r /J/KRVAk7UaPbpgS4fhFen9rEP1i/S2tLd0lQ2/Db1Z/QwlAga3MPaHXUOTLT4t6ZuMA iO2A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20260707; t=1789462975; x=1790067775; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to:content-type; bh=chLjM5CTnb50HHVQx65I0WAjKAwm9kU8MWpPfnwKwJY=; b=Vg3dPvCjJ9WKF0ncINF71kASo15ZqVvQnVua2hfU6IsNiuHYGibiq+BP3dZpY3X8NP 6QDRRxi3E6bYAc0s+Nk8E3CEZTIVx+wi9UbLvd0mi49ptGrJmt/9U1nJxNvg9m9zGY55 YWGF1AcA4t8GQruCmUnImwgQURz6ILStZJGz5XKRlci7Runr09UJwBO4KFqLSesBNNW+ FFziUxPjTAvdXuCT6161747jVaGiwgNYcRFvFshV3ge7ksFJpcbdZK19gGVZAzPA+nBn QcW536qs5N9aoS9VpGZMXMM6IktXLFSKv+U0MF0GW4dMsHARaLrBFvqv22dWEF08+lFU J6Ww== X-Forwarded-Encrypted: i=1; AKwUvBxSARZL5OE+t8CnbhfMBhMrlo4IOoCqKPwk1a0b8sJuhnU6v0OhZ8l+osD9fu8ZO7O6sfAqqcwFGbjIzAs=@vger.kernel.org X-Gm-Message-State: AFuF++nG+kFMS9xd5GFtOvHHZxMHugIckTO8YgzCwG/f6p2x3LnBI5ip HJR6XGhooVTcZqckACo3SvxPqeJjfcND+MLuQ/H85Mx/E608gZsVI2Bvwl73qyEbxdwsLg== X-Gm-Gg: AYBFou1tgdg5xawkTQIzPczT9Y3y617uL09UktOAduljICwt2TfCR5eG96CMtpiJEsc YKUh7K2lVl3ljSESS6UGgslFpQOqL8ZLd4Rq1J7R5/wYBLdgsT72CjMjgF7u/Py2D7pPgKOTpTE 6BVd3EDg2o3syH1ufWxUqn4NH9CPYrgneerWnhdeU1f1JFyIA84pYgwvFn4iSHr5zpM3hQ0JmHS 5cIPQkr+bGaDD8t4gbUkXVQ87RhAylVadWvzU5pXcye/ObATylxOpuoUe6tb4+ucfjRzQNj4IyM 0VRUCzjd3vnTezTlCtCYlc04v/1KFI7aX2Cp9lH4Q6UX9iiDQPkap0q7M5F+Fbfhb7WInCJU3se zjTXoF1AGj9c+h75+qxAe9SLqyU9eh6hoOQMh3yWXaGIs7LJWRLql/RIMkb3sX6URnVWq7crJdf xasnB5UUO2ry1tf2j7ST9cF5HhnG8VPEqqXTg3odSke+4jPoooUbTlGYI5zPjCIjT6SIVpZPIbW AqqJh+FbEL6hgvC95W5msgGAoOM4nVqcWuCszaJvTgHIF4GdRftBSlDD3uyBrcjIJ9iWh4Wiwcm z/ZnFhs6Z5fGd4cSEsf/MSYPrVIl1aachP9Edq/pN5MKbY1QBT7OgjjX0PqQ9aS0+1ggx9VquHW jFZHycdCwIFaj7nAl2Ed/BjMNXCGKyJ1OCaamOzPzbp6fesYF4oDpsiAWiYTPuLSA4se0lIqFrx nyuVJLLh6wIII1RF0ADMtatAJ9ic3xOkoAHpgDLiFm1WbTo8Oo8A0Hsrvi5MaRa9axJWYU7sJxk 8LFyh8hUEw= X-Received: by 2002:a17:907:948c:b0:c29:49fd:c98 with SMTP id a640c23a62f3a-c29d7926fbfmr13664366b.32.1789462974448; Tue, 15 Sep 2026 02:02:54 -0700 (PDT) Received: from cs-280612103108-default.europe-west4-b.c.oa7bb030819b2a894-tp.internal (88.71.12.34.bc.googleusercontent.com. [34.12.71.88]) by smtp.gmail.com with ESMTPSA id a640c23a62f3a-c2965c4cf01sm546369266b.1.2026.09.15.02.02.53 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 15 Sep 2026 02:02:54 -0700 (PDT) From: Joshua Crofts To: Peter Chen , Pawel Laszczak , Roger Quadros , Greg Kroah-Hartman , Mathias Nyman , Chunfeng Yun , Matthias Brugger , AngeloGioacchino Del Regno , Heikki Krogerus Cc: linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-mediatek@lists.infradead.org, stable@vger.kernel.org Subject: [PATCH 1/6] usb: core: add missing pm_runtime_dont_use_autosuspend() call Date: Tue, 15 Sep 2026 09:02:18 +0000 Message-ID: <20260915090223.1346-2-joshua.crofts1@gmail.com> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20260915090223.1346-1-joshua.crofts1@gmail.com> References: <20260915090223.1346-1-joshua.crofts1@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" The fail label in usb_new_device() disables pm_runtime on failure, but doesn't call pm_runtime_dont_use_autosuspend(), causing resource leaks. Add the missing pm_runtime_dont_use_autosuspend() call. Found using Coccinelle. Fixes: fcc4a01eb866 ("USB: use the runtime-PM autosuspend implementation") Cc: Signed-off-by: Joshua Crofts Acked-by: Alan Stern --- drivers/usb/core/hub.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/usb/core/hub.c b/drivers/usb/core/hub.c index 3345b3298daf..dec6d5c49759 100644 --- a/drivers/usb/core/hub.c +++ b/drivers/usb/core/hub.c @@ -2745,6 +2745,7 @@ int usb_new_device(struct usb_device *udev) fail: usb_set_device_state(udev, USB_STATE_NOTATTACHED); pm_runtime_disable(&udev->dev); + pm_runtime_dont_use_autosuspend(&udev->dev); pm_runtime_set_suspended(&udev->dev); return err; } --=20 2.47.3 From nobody Fri Sep 25 07:56:39 2026 Received: from mail-ej2-f12.google.com (mail-ej2-f12.google.com [74.125.228.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 2DE783A8753 for ; Tue, 15 Sep 2026 09:02:58 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=74.125.228.140 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1789462980; cv=none; b=YqNCpTvyNJzyDt/Qjlj5qxUWolojS8gN/UDTCAEhbO69S5CXRuF60JoRfvEAj0Nb9K+2zRN9z2KpCACKcG5h7AUfM5NFiH/uvQO6oKVLgmeQX+ElJFXi5qd7VtT3QjSSb1HKWxvgKmOsEg2PpeI378y9fcWev9Lddn1vKRvghb8= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1789462980; c=relaxed/simple; bh=m9YQCnZ4wuu+r3kwEyUolM5dCU8c97GRk7G81aGdFR8=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=pEL+jQUiJzbzmbF3XWxOTrNzpDi8cUGalcckCo5xTFy/ilzkLH+21VJBeH/ny4kF6VCnaGXqdu/xIymkWkYmMmo/qJjbIQEuy08vyCx/mrLb4qBegMcW0/7MNKjPMCCz199IMHgehl1i7JKbDKEs6f09gezwvYWCGapXAfXRtXI= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=kKqV/k7u; arc=none smtp.client-ip=74.125.228.140 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="kKqV/k7u" Received: by mail-ej2-f12.google.com with SMTP id a640c23a62f3a-c254f6c7a58so341357166b.2 for ; Tue, 15 Sep 2026 02:02:58 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1789462976; x=1790067776; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to:content-type; bh=6QV6AlfXXw+r11qGovTiPwbiifuuf1ZUfq2GxVsn5iw=; b=kKqV/k7uJEeSyZTnhKaXCxXp7QeU2mYEu+6D7Q244jXM9CJASVLdYF1/E9yIp/eJpD spGig9UQYIKNYaUlTPJGzWd0qxmVvD8E6AMJ0xfLffN5+v/LD1sW35YeTiRTYsiHD1Qb tPFmmRBTWWSJiyyPoRIAS5/Ty2zoOwU6GqAmzoWuYT6D1emwhsnv4PO6LL5zuEgv/VDr +5U+emCeBfh2S1ROyHxxjeRphcEPJUVHoTc3K9s+OqGswr3f/lbGR+D8L8cT7KqyRWGi 2n/ABsAblWdjCJsx8hQ66STSUhx628cLwRRvvbpyACzcVFa6q9R7lYb1Wluw7Yln5Z5x uQAg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20260707; t=1789462976; x=1790067776; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to:content-type; bh=6QV6AlfXXw+r11qGovTiPwbiifuuf1ZUfq2GxVsn5iw=; b=GUt7MH30RaxFInUD5iut+U34vtXYR2AcUXTxUWLjI9T+TfSG+MKwZ4MJbgA8w30NMH Sfo00JpBj0izHTd1S3+X0qBj8kCpGqaNaxFqjVXkNSKcO2PhHVYoTstqe03bfGxXVTek /OpsSKcaUfrPjiexntnAUkMVRPXyj0WDJgeKHQS/a/iG5tEPNRyrtySe9cEfhNJ+gBpE +P1ppPagsLWs2/dZKOa6T8T7y8V/4z2WNUQXaezgDLdschWXqvcRkzIbZtStzDPp5MLw O4Wu7aqCjFG/TzY3/irw+X0MkibwjY03OQ9Oto14+Wsgsoa3PG3qsNFpol5JURb7Z0GY FU+g== X-Forwarded-Encrypted: i=1; AKwUvByQe3uCEzJwZjx5GSCDf1dB/4OJhGLQn+fKuhERbsr9LrUi4Lxkf6gDCAbYXgKfKtxirbwpNBTRTCjOlDc=@vger.kernel.org X-Gm-Message-State: AFuF++lpuovJI135Dkol45qiH9jn1o81lHU7NmrQHwq79IWncdZeiEI6 lHvWnOzxBa5tCC6th4TfhUBhbAYlTYCCHSf/sIIVLUkzyubPsK/iH88M X-Gm-Gg: AYBFou2G3BazE8BVo6/sNR23kJS+HTYX343hw9Duv4RNy0NYoMKtxXdbE0LhL55z6a8 /T5MXmlf8vNkXjDas1Em/kELf2WOqQf/8+7JwyvAwh1h0ErUUWvpr7QnVrtaIe0cjgNaxUO/DNs kp1wtxtF94gPTyDO7tLCl73PMNkrLFWNU5y9bbdgEuR+tVf/xHUCO+mtd/dHtZDOfxPFwNW5x+Z 3c/vl301kaZAouXGyTIoirvD3145uCG6tDfP6CBxGW97QMSDru+NvQZLtKygOy/+9oV+pHGJRTz iuUYRQOeM2qguiGUQ7U4jLO7Q9Tw8f+DhwxlG7/2y3O5VeaooriLZ4X8YR/6KFs33TFJdFSXQDT ACD9jiUpNfHqBxzv9EsGK0DDKUbDnFhc/i7eJNL9eumyX9AUJ8ooHEYRYJW8CskDleaues3Z7LD /pHi5qkcSwkZKJo78jEEmNF/Q5SxwZ+/5G9HOZ1Zin71vy1OLhmQdYajYUKJsA4A8nfkOSoYA9Z ml1Xcd96cJ6ub0n/Yp6qaftUEktVxveeOhH61ud5HCnpbJXXtCJhoHsYI7C3oZhCYuqR7geue0q z4N9VIQNNlU1kwk84BrB3PKw+Bvonm/HrTdkVgFmRlFw4HjZKquvi0bHIFBCb0Q+uHleDqd+/Ge MW3exAVJWY68KJq1ebO8Yy685AVVnsalcSfOxSRtyK5wnp8dqeXOLLtGWwxGiA/W8sU+SuteHrz 0nWgcSrZwdkr7Mo0h1EWSIcjkC9G1uragwiIvHYx44D/r2ajmNpL4J/Y7wlH3ByNhAsjgUDqu9v 5ZBC977A/M= X-Received: by 2002:a17:907:720d:b0:c26:1649:47b4 with SMTP id a640c23a62f3a-c29b87180e1mr401204766b.42.1789462976048; Tue, 15 Sep 2026 02:02:56 -0700 (PDT) Received: from cs-280612103108-default.europe-west4-b.c.oa7bb030819b2a894-tp.internal (88.71.12.34.bc.googleusercontent.com. [34.12.71.88]) by smtp.gmail.com with ESMTPSA id a640c23a62f3a-c2965c4cf01sm546369266b.1.2026.09.15.02.02.54 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 15 Sep 2026 02:02:54 -0700 (PDT) From: Joshua Crofts To: Peter Chen , Pawel Laszczak , Roger Quadros , Greg Kroah-Hartman , Mathias Nyman , Chunfeng Yun , Matthias Brugger , AngeloGioacchino Del Regno , Heikki Krogerus Cc: linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-mediatek@lists.infradead.org, stable@vger.kernel.org Subject: [PATCH 2/6] usb: xhci-mtk: add missing pm_runtime_dont_use_autosuspend() call Date: Tue, 15 Sep 2026 09:02:19 +0000 Message-ID: <20260915090223.1346-3-joshua.crofts1@gmail.com> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20260915090223.1346-1-joshua.crofts1@gmail.com> References: <20260915090223.1346-1-joshua.crofts1@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" The disable_pm label in xhci_mtk_probe() and xhci_mtk_remove() both call pm_runtime_disable() on error or device teardown, but don't call pm_runtime_dont_use_autosuspend(), causing resource leaks. Add the missing pm_runtime_dont_use_autosuspend(). Found using Coccinelle. Fixes: 0cbd4b34cda9 ("xhci: mediatek: support MTK xHCI host controller") Fixes: 04284eb74e0c ("usb: xhci-mtk: add support runtime PM") Cc: Signed-off-by: Joshua Crofts Reviewed-by: AngeloGioacchino Del Regno --- drivers/usb/host/xhci-mtk.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/drivers/usb/host/xhci-mtk.c b/drivers/usb/host/xhci-mtk.c index 60af5fe29bd4..eb483a267bf6 100644 --- a/drivers/usb/host/xhci-mtk.c +++ b/drivers/usb/host/xhci-mtk.c @@ -700,6 +700,7 @@ static int xhci_mtk_probe(struct platform_device *pdev) disable_pm: pm_runtime_put_noidle(dev); pm_runtime_disable(dev); + pm_runtime_dont_use_autosuspend(dev); return ret; } =20 @@ -731,6 +732,7 @@ static void xhci_mtk_remove(struct platform_device *pde= v) regulator_bulk_disable(BULK_VREGS_NUM, mtk->supplies); =20 pm_runtime_disable(dev); + pm_runtime_dont_use_autosuspend(dev); pm_runtime_put_noidle(dev); pm_runtime_set_suspended(dev); } --=20 2.47.3 From nobody Fri Sep 25 07:56:39 2026 Received: from mail-ej2-f12.google.com (mail-ej2-f12.google.com [74.125.228.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id A5CD5429CEE for ; Tue, 15 Sep 2026 09:02:58 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=74.125.228.140 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1789462981; cv=none; b=Nb3Lqo7tfk+1uC0OJ853+L6HbnZdfuKcxJc+hgWa3Y029b5tHMNdtOD0Q9hKGa89wrQHGzH9JRq1fZNWxmO+Q0SXegt5Ji9LtdSC64GemrPkkXXtsgAhK539gPQ+WqTALQV7e1nIOt77XiyWTWRPDgFGpBT6phY1dbj5SQlIekY= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1789462981; c=relaxed/simple; bh=ZI01giqCOg4r2BC/31Ii/Jx+mxfuzQ3xbAm6e2K6C8o=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=KCkCg+KUbWa9AMFCQjFxe6nTMHYuccA4OyXK/dTZ2a/SztKBaS0lL4EyFvojt6hsiYmW+kUrVd8vfVr3WezF38HuNx9Z9FhWBq/bQLrHzVvZQhCiC6tV1Yq6L2lg8MQS6RfPJgrD9LDVcGjMP9UY09HRhgNWzCA2P6gIczI7Inw= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=H8jYbAq/; arc=none smtp.client-ip=74.125.228.140 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="H8jYbAq/" Received: by mail-ej2-f12.google.com with SMTP id a640c23a62f3a-c254fa663bfso572324966b.1 for ; Tue, 15 Sep 2026 02:02:58 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1789462977; x=1790067777; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to:content-type; bh=96B/n0qyp7z+ICJfhqaTshDbMoTzd8gumlBOo7qhHZw=; b=H8jYbAq/k24Q6j1MuXjRsZ9lDK81mFluOzrjRTNB6BOrSQOKLSomPRo9KhNfQFGZP9 637gAhVJ66x6oFv/Y/rtIFEJBkOagQjIPdMiZ/IzOlInEtQ5jbaeTC7mK+fFWuAXCe0B OBF5KHyrL0Sr7bLezopx0wtPTMTp9XTk3JSwHxccLtnQSLDdQYY0Wes0ktYgIJ3g6a0w fDtjTPeFMeqhVuCTYm/uNrY48lb5VVlMlgNjjgRvzWGB4WfkzyuscgR/DqqUitovnhwO Yr8WhscD9oA3gWOXZGLDRkBYaEAUGZYUmsICqqBjePOkwCO5p4Pe15ADWhrBtFrGYENc GUMQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20260707; t=1789462977; x=1790067777; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to:content-type; bh=96B/n0qyp7z+ICJfhqaTshDbMoTzd8gumlBOo7qhHZw=; b=VbUg5wKglwS0tvXsJnt8h0vCrOUnx8mP0Gt/Wa23Prf0FVdf87KKtrZ+FWmc1KWQ1L BSqxaTRRsf9amCZQ+6Lb5N8tCBklVHt+Xpjz7rn+kiMP1ULirT6IBqMHiYBxDrYGQByk L4MrO8mGAq1O+4ZJJO5rf83EU/mANKF2J0JlloDtt6M6EpJCe5iOuwuTF9ZXAOB24tml ZZfUH2ttBQ8oUEGvLDkuG2IRIo8Aa6XrwS5a/sRREOSWikKgBKJK855YQKfMah6zfZ/V 2+FJ5KICIkyLZee9VOIAplYlG9BiraDJQosaQSnsaUScIJfJilzn7KffKsV2Bk3Ejtqm abcQ== X-Forwarded-Encrypted: i=1; AKwUvBw2n1yRR2VsofPsMjB1ULSpKWeNcH3BzzIxJlnqZGXJ30Uy1Rtcy63Fne5xE82XfpClnukrSLcsWVbr8EE=@vger.kernel.org X-Gm-Message-State: AFuF++lJWMNDW6fYgxb4FKWki48klc9NAQ63wOeXPCpGiCt6k1XDupxa IQ23HrvZQ+GQQzjuezAK48wzjRKVdIavsxr4y/u4zf6wr2AaZlA5fjo1 X-Gm-Gg: AYBFou0088P8gD+IZPoixP1pHkH8VVSu7r20ySJW/wHWvX8wiCwkYui9w6khZLQN6Sk ZMDYpreyMOADLIhDxp3GAjdFZeIa5ervMD9kwEd1P3EQ9Olq5Kq8214dT/qLIiaWD0R1ONy2G0Y 0UKj72A37uKiXkV17podQKxeeoA1Yv3BF6Y2EfXH3+Cir7EdpY/MUdgQ3tT+o1B9bJ/k9sfJ2PN pBn45+/vnXI/ZSX3Yu3rmoKCTuz3EC3hJ5ifTwE0NCiYEMJ2icR2CwK/EbxNklG81rY0TrsuUiw OVSDV++AD/RyLRcIkfNf4hvlmQgsE4t2NSTMnj9fl0HL94P3oups5nakym2WxDj6RZIVNsavUkb ECE5zYLVptRLaN4H3gykoXxP5JtodsEPwx17oeMfVDGPqvVXEz7z4TUb00MSpcIGs3/oGIziFoi V0i/lsLGG45tUOL99C+6IKJadnsX2Fyw4BhyaMTqxt1lR5OG000BBGOaJtRid7VJ9buqhFw1SDq w2jtmqVlFynGwIsO8kSWrHzO10/i/E0D6SYeZqWnPxh3SZFGZ037Y05hIjMshRTMbpniT+JZKm/ i+GcUBobElAzqc3zX0gGt7GGelrXHkWE4/dPdwPJqGY1bZBGXK9ACv8BbecOOK0saLIppTE2jSn XbHMa/h+29ckL66HP8HJqB5CVdeptDoGcWEqij/Q2sJ6Az5Wn8YSAnYfpcIg1GxLN7omI5dUsb4 BaWdQLm3/eC0OrX/ippVQvOVN4EE4GJmeVJ0uT1X5Ks6lkAt9N6C3Go3NMEgx31hzt5cIB1On3K DSxQF7x60s= X-Received: by 2002:a17:906:7309:b0:c25:47a4:fedc with SMTP id a640c23a62f3a-c29b839a057mr853572666b.2.1789462976636; Tue, 15 Sep 2026 02:02:56 -0700 (PDT) Received: from cs-280612103108-default.europe-west4-b.c.oa7bb030819b2a894-tp.internal (88.71.12.34.bc.googleusercontent.com. [34.12.71.88]) by smtp.gmail.com with ESMTPSA id a640c23a62f3a-c2965c4cf01sm546369266b.1.2026.09.15.02.02.56 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 15 Sep 2026 02:02:56 -0700 (PDT) From: Joshua Crofts To: Peter Chen , Pawel Laszczak , Roger Quadros , Greg Kroah-Hartman , Mathias Nyman , Chunfeng Yun , Matthias Brugger , AngeloGioacchino Del Regno , Heikki Krogerus Cc: linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-mediatek@lists.infradead.org, stable@vger.kernel.org Subject: [PATCH 3/6] usb: xhci: add missing pm_runtime_dont_use_autosuspend() calls Date: Tue, 15 Sep 2026 09:02:20 +0000 Message-ID: <20260915090223.1346-4-joshua.crofts1@gmail.com> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20260915090223.1346-1-joshua.crofts1@gmail.com> References: <20260915090223.1346-1-joshua.crofts1@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" The disable_runtime label in xhci_plat_probe() and xhci_plat_remove() both call pm_runtime_disable() on error or device teardown, but don't call pm_runtime_dont_use_autosuspend(), causing resource leaks. Add the missing pm_runtime_dont_use_autosuspend(). Found using Coccinelle. Fixes: b0c69b4bace3 ("usb: host: plat: Enable xHCI plat runtime PM") Cc: Signed-off-by: Joshua Crofts --- drivers/usb/host/xhci-plat.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/drivers/usb/host/xhci-plat.c b/drivers/usb/host/xhci-plat.c index 6fd595f81a30..29e743d6868e 100644 --- a/drivers/usb/host/xhci-plat.c +++ b/drivers/usb/host/xhci-plat.c @@ -388,6 +388,7 @@ int xhci_plat_probe(struct platform_device *pdev, struc= t device *sysdev, const s disable_runtime: pm_runtime_put_noidle(&pdev->dev); pm_runtime_disable(&pdev->dev); + pm_runtime_dont_use_autosuspend(&pdev->dev); =20 return ret; } @@ -461,6 +462,7 @@ void xhci_plat_remove(struct platform_device *dev) usb_put_hcd(hcd); =20 pm_runtime_disable(&dev->dev); + pm_runtime_dont_use_autosuspend(&dev->dev); pm_runtime_put_noidle(&dev->dev); pm_runtime_set_suspended(&dev->dev); } --=20 2.47.3 From nobody Fri Sep 25 07:56:39 2026 Received: from mail-ed2-f12.google.com (mail-ed2-f12.google.com [74.125.228.76]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 8E843463B9F for ; Tue, 15 Sep 2026 09:02:59 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=74.125.228.76 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1789462981; cv=none; b=CNckdDNpThzSArZHtJ8wj2JmAiHw+Spn9//r0mIdC2MR76+Brg0sM+4+3J+w4W/EVk/f7vTwC66/LYhLCdFERAGbaS6tLrAJa24JgU0ZQYd3Pk5lMOYFJjBYx8Lju1DiTyayB8qySy8BsUtoaHP00BSDXX1GdGdc8ssA0tlLBKw= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1789462981; c=relaxed/simple; bh=NZRchLVy5n31XYbiS5i8BQVcxRXCGTbKv1t0C+lcWuQ=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=nZqmPrgGG2G6uPqHLeWNOsnVXmrzqVB0/EZg8OnSKk2HjkpPmUN2JHKq3n7+3vYqFqoMMV3kP4aTYOspJcsVDoyd3uMzvEDuUVyyWRLxhrUMZTtmzwS95WlirwSo9I7bbnc/HXGSGimSFjkcFVhfm6kk2T6uMkb2mbmlfjKs/IM= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=r63vqtep; arc=none smtp.client-ip=74.125.228.76 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="r63vqtep" Received: by mail-ed2-f12.google.com with SMTP id 4fb4d7f45d1cf-6a9c0cd47bbso4625533a12.1 for ; Tue, 15 Sep 2026 02:02:59 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1789462978; x=1790067778; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to:content-type; bh=qexTWbdmW8eEb6vSlsUiXVjBfkjIzpmrkaoJ6YlOyks=; b=r63vqtepd53cEOx6fnhk2GMJuUhErH34LrZgVUhSFTY3r/1oS1as8t+bfGQGzn+8C1 o36ZjLZU2UjIuUY+cnOoyM07KzBFh7MEkjxh0COVLMZqnxQNjYwfK3TM0vyRXP/wtr4+ hKneX4S1r9gzPwWKH1/3YvrpFcbso9eXvkKosoUWeeIZUaq4xzGrSqW1pkG+J/uuzPTo 7710zKIKrjBN+1vSG4GG3a03iBYKjHK4uPtLkvYvkEJfaefnDBDX8uSSJIHaXo38Doos BxsBnKQ1XlvXxaBjRZChqAtZoeOpcWH+lXIMFBx54m4frT9qF+achk+4U8I+TPuffqPn EXzA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20260707; t=1789462978; x=1790067778; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to:content-type; bh=qexTWbdmW8eEb6vSlsUiXVjBfkjIzpmrkaoJ6YlOyks=; b=SjuWdcPpGGM1TEaoVs+/MN989r4JzkFdlMhi2JjML7wBzLQRLtN4MlKEL6Pbr2HaW2 3ItX0HOq2YIk4gHm/MRDQsvO3q0fUXRDrtAMLLiEc6dpSKhf9KfNfrWoGdeYekXHYkXd CxU5hKHaYeQVlQ6sgLJ8V3pTjG+oFMauP+avRNjsT37fJD8UOvcUv7eKo2/AIBDsudjK fKJ0dzNpUe/mBnJVXidvNKk5SXqN64OO0cycd5d4rY9dNYnMmfTj1yy62UKONxaznBq7 am18jNJ5lx5GQB9grdYSHzWK9sjij7dDHlwsaXd4hI26w0UTlbcM1r4zU/yoXrCwUg/U DWUw== X-Forwarded-Encrypted: i=1; AKwUvBxqoqkL5ZnK5xl7le/jL2OjoqIFt/9Z0r8radsrbnrXfT3jO7SmcjQQWjoXQkY9gMH07CL25ss6vcNBCm8=@vger.kernel.org X-Gm-Message-State: AFuF++lWRAhyPNlcvawAqwYsCgL4tt7kdJXICGlwihsVjF921OFTyhTT ZQv9i14Chg6iN8Tp05dtvBStyKvKZhb8oze51NdFoWYQprzm1QbGShcJ X-Gm-Gg: AYBFou0fLmMWXOVoOav1CB5PONuczLC0C6PIoAhV5lW5BjkOItpYqfb84TiiL/AMeNo /tOnUAT2U2bu+brAL6j/ijWzgopKpsu/VuZHtpYk0NpZoFRPiE1rmw7usXGOM00HLhiUBQHXLoM vIaWNW5j/8Ey37AaebHKLTMvJzxOXgnIUwrLoqIJsEiB7C0lIClVrCvbOva4ktFVrFvI7hXzICv pOK5RQ3oSQkG98K9TWZejQeTgHwwKFe03En1AXBgqnHI364gij61cV/yVLbNR47TyGXTQUHdNCt Iw3DFrbctIthskk70uL1u4fXRFMHkxepfwpJtVlM/GTrBdFNtYmCjXcU5JhH0j8gVzO8f/AQaVL bsgbNC72RXhsuX3tuDQtTkdBvFS+M6F2tC1PAfbFvRs36fVOa5U17QL40pLFc4Y2Y6Cqe1AcWZQ kVOnTJr+eb+DHKrv/xhYVECvjqJ+9onwciS0iueFkOanjeVoMBYTfs9tPCH9fUNYLIJvqmhZOEt uez0m4j44CcHiW4rasMsba+aiBqujp9HmBSVPXw4pV8y19Rqe2tBdc/Q+XyTEswYlomMTbH0beo PGo1Iokj0v06Ijs5Cdcdj0JZZ/bzm1uiUH8v1/oUcd38ckoGWXSmt910+GhaBPW3+dJcKkhd/Qh PeUnWp7dp7kXsncw0Z8p+RPwDK40cIbfFtzouG1r5kfhGFb7iUXSLb9KwkALz0OmaSaSxhUysEd v8ktyWevn76hfVAABjWrw2ByKxP6ZklSYoytmtJLQ4/lmmeojOc8ABHrHRqA7Q5cskOvVxG1Igg ASUvgK9m0A= X-Received: by 2002:a17:906:f597:b0:c19:45e3:2f57 with SMTP id a640c23a62f3a-c29b84c7106mr395967466b.9.1789462977606; Tue, 15 Sep 2026 02:02:57 -0700 (PDT) Received: from cs-280612103108-default.europe-west4-b.c.oa7bb030819b2a894-tp.internal (88.71.12.34.bc.googleusercontent.com. [34.12.71.88]) by smtp.gmail.com with ESMTPSA id a640c23a62f3a-c2965c4cf01sm546369266b.1.2026.09.15.02.02.56 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 15 Sep 2026 02:02:56 -0700 (PDT) From: Joshua Crofts To: Peter Chen , Pawel Laszczak , Roger Quadros , Greg Kroah-Hartman , Mathias Nyman , Chunfeng Yun , Matthias Brugger , AngeloGioacchino Del Regno , Heikki Krogerus Cc: linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-mediatek@lists.infradead.org, stable@vger.kernel.org Subject: [PATCH 4/6] usb: typec: ucsi: ccg: add missing pm_runtime_dont_use_autosuspend() call Date: Tue, 15 Sep 2026 09:02:21 +0000 Message-ID: <20260915090223.1346-5-joshua.crofts1@gmail.com> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20260915090223.1346-1-joshua.crofts1@gmail.com> References: <20260915090223.1346-1-joshua.crofts1@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" ucsi_ccg_remove() disables PM runtime on teardown, but doesn't call pm_runtime_dont_use_autosuspend(), causing resource leaks. Add the missing pm_runtime_dont_use_autosuspend() call. Found using Coccinelle. Fixes: a94ecde41f7e ("usb: typec: ucsi: ccg: enable runtime pm support") Cc: Signed-off-by: Joshua Crofts Reviewed-by: Heikki Krogerus --- drivers/usb/typec/ucsi/ucsi_ccg.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/usb/typec/ucsi/ucsi_ccg.c b/drivers/usb/typec/ucsi/ucs= i_ccg.c index 91c2958a708c..9d3ebb255de7 100644 --- a/drivers/usb/typec/ucsi/ucsi_ccg.c +++ b/drivers/usb/typec/ucsi/ucsi_ccg.c @@ -1519,6 +1519,7 @@ static void ucsi_ccg_remove(struct i2c_client *client) =20 cancel_work_sync(&uc->pm_work); cancel_work_sync(&uc->work); + pm_runtime_dont_use_autosuspend(uc->dev); pm_runtime_disable(uc->dev); ucsi_unregister(uc->ucsi); free_irq(uc->irq, uc); --=20 2.47.3 From nobody Fri Sep 25 07:56:39 2026 Received: from mail-ej2-f12.google.com (mail-ej2-f12.google.com [74.125.228.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 7D93D46EF64 for ; Tue, 15 Sep 2026 09:03:00 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=74.125.228.140 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1789462983; cv=none; b=cE1mT3SWmkFF9VHhcme9SsTBpqe8ZrIQm4c426232OEdM5qhSmK3dSvDohnwpxoAOPufQpEDVmVkLRe44QQHxESdB6eDyVEC1hknGos3Qzv4UhvmjSTVv8hywZs0mhMPD6DkHzxHIs17JVlpBQqIKddr+TKXPRCmRfCcIlkeuhY= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1789462983; c=relaxed/simple; bh=I1E5aCaEBVe8ChMV1fF1cL0PZhqlKxPCI5YYxzTLLHM=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=dF0GhuMOkF9Tx34tV4ssDN+OJ/q+HJihFi1nC2YndWMRtY6P1iy+9bYhz8NooyqqmZdgwTCGwTJQwmdrLZ1r0Ql31xzQLrYjbfMNJp3usOjlvpU60JS6IYaRSXUf5hAptm4xzq1pYBxI4/PEBGEpgORPTByPBM5608bQ9D8aW2E= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=cxs0A2e6; arc=none smtp.client-ip=74.125.228.140 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="cxs0A2e6" Received: by mail-ej2-f12.google.com with SMTP id a640c23a62f3a-c254f9f7dbeso6992266b.0 for ; Tue, 15 Sep 2026 02:03:00 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1789462979; x=1790067779; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to:content-type; bh=kLWSmlyXJzRPOS1GeQ3EyJF1epHoFNqr/jbcGqxOmCY=; b=cxs0A2e6v1ibZcAaQAnCXppZFBX3CV9HA3x50ukFhPhdPtVVjeF7gWgnlBkORvB1pG Rj7dGj19s8jvW2jGAeg/0CG0kwqXbtO95nvg3bOxoC4FwZ3+3xnfZlgMcnq0XH9tdv9X OldPSR2SUQIW7Hi/AzLb4qkrARZ9867HdusBLTa/3WuuutzumHgA4mQepD0kJsSAIwS0 Nxi7C1j9qhcKK3ChMeNKRZw00Ww5GknXFmrdFg0GyYJeXfsLMZwpbsFWfVKPbSJo3OgZ dc6C7FljpV1Q7TF12I+LHWrerLWMqqTt8nsmbnF3b6rlmGU4kxKavopuxUimNcgDCF8N yfnA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20260707; t=1789462979; x=1790067779; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to:content-type; bh=kLWSmlyXJzRPOS1GeQ3EyJF1epHoFNqr/jbcGqxOmCY=; b=qEHfwSwWd9S/pTetO2pcCMODiTfI/vKe3KBDl4LBVyjn7NSuiRROSTgulOiTjsVxo4 l/5Qj9iMWfxut38ypa/zqWLlZaGZvjbTgyAsjm+l+fVFUbjkoIUbKxPxW3zGffe/Jja+ RhOce85QIEpEM73ji+JPpLzhLyDLl63z/Ib+deZeHrP5qRoOM6PhboQh9QB73PXeChpx nyO7SlDSdYPXMBTVN1qRMdAceFJ6MwCyUSdluoamRSVkIS+Fg9pjyGq637DioZm5qKLh ZuyFbAcGvCmY4yNJIsirEh5xSzaIqOoL3SgX0ocdzUkgVZLG25LA7jEb0X6dQ7HgLsxB YMOg== X-Forwarded-Encrypted: i=1; AKwUvBwLvSl2SJ8nNlPBZf9JcUJZmtJePOjFlfvou4w+yec3gi+MTSLkMAg+WYZ1vv+NmVvBa/mHCKd+xwdo3m0=@vger.kernel.org X-Gm-Message-State: AFuF++kWMP0v9Qzhibtxjlx/8lUIQdnVM1vt/rp4EwO7cUHXzx96Ozkj zgeYjOdGocqvbz/1+FNeFfitYpBValrB52dneZIdCStwr7gGu9Oe4CqC X-Gm-Gg: AYBFou3nl0AXj7a5UqW//RdElBO2g4mkLKrvWq7+XMizpnyYknJMyUEFbSsWIUhWEyQ XoTnowtZOMScy94lHaUeQXKUgV2c59Hqerr0OodImrs70erBTWapzgUMZpsEkqDUYt5UG9l8z3X 7iDl5Dfi5kQvzm70EzpD6tY/k4f8iapvDrByxoLVi2qH+5oPAfQAr3xkZdKaSOGZ1VFcEjFacif G3TO27VKhJ9l+ChuFqZ9zeM/561HG7dl7aFJ6Nb2mgz7cPlq+C/EbwJuhUCykfBnxnujqKV0ew0 JyHOdZg1KuQgh4wF78aaFnBIzi236H47Q8lNPzlaiWtNo/CIyp+nsE1gRvZ28xkmD27mCYRD4aD NZMUoNycXgUk5FqZbupAZHGetvmNjFQcixGbnZReiKocAG/Y9p3m7D4G6v0IQvVQz8Ba1UeSaGw wKxEU+ImKYSplU9gSiQyFkFb/IJxtXE2f7gC0N1PjflK0eiHF2LLTO+IfAXyiGjbv5+kza3vtc7 K6cY68UJH3cvRISPAioqL7k1Z2H8zQQneOQovz1p91pZxeImSb2pwWoiTQlMMv5toYzBRBO3BdS Y8wk9pZZyIByRTpWBZaMHI6YkRtojizNJEqUtYW2AhHetQHwpt/MxSQPwek/m9AIsQTbtNZn0aH rjXuWstc+tRrl8u0y9OsSyWensYaXcww+ycgIWM4ie7mT9tIuLYgvMoKy8LeotBalu3oLZIK0Gx Oc7tpDuzQC5VUfFr0YvOPJwXknO8NCrbgW2A/sTA9NB9+KG6digBHMac5rQmBSNtEBqjGj4w7pL zm7YwUk+LA= X-Received: by 2002:a17:907:9407:b0:c29:4634:5c99 with SMTP id a640c23a62f3a-c29d771747dmr18032566b.4.1789462978527; Tue, 15 Sep 2026 02:02:58 -0700 (PDT) Received: from cs-280612103108-default.europe-west4-b.c.oa7bb030819b2a894-tp.internal (88.71.12.34.bc.googleusercontent.com. [34.12.71.88]) by smtp.gmail.com with ESMTPSA id a640c23a62f3a-c2965c4cf01sm546369266b.1.2026.09.15.02.02.57 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 15 Sep 2026 02:02:57 -0700 (PDT) From: Joshua Crofts To: Peter Chen , Pawel Laszczak , Roger Quadros , Greg Kroah-Hartman , Mathias Nyman , Chunfeng Yun , Matthias Brugger , AngeloGioacchino Del Regno , Heikki Krogerus Cc: linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-mediatek@lists.infradead.org, stable@vger.kernel.org Subject: [PATCH 5/6] usb: mtu3: add missing pm_runtime_dont_use_autosuspend() calls Date: Tue, 15 Sep 2026 09:02:22 +0000 Message-ID: <20260915090223.1346-6-joshua.crofts1@gmail.com> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20260915090223.1346-1-joshua.crofts1@gmail.com> References: <20260915090223.1346-1-joshua.crofts1@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" The comm_init_err label in mtu3_probe() and mtu3_remove() both call pm_runtime_disable() on error or device teardown, but don't call pm_runtime_dont_use_autosuspend(), causing resource leaks. Add the missing pm_runtime_dont_use_autosuspend(). Found using Coccinelle. Fixes: df2069acb005 ("usb: Add MediaTek USB3 DRD driver") Fixes: fa6f59e28c61 ("usb: mtu3: support runtime PM for host mode") Cc: Signed-off-by: Joshua Crofts Reviewed-by: AngeloGioacchino Del Regno --- drivers/usb/mtu3/mtu3_plat.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/drivers/usb/mtu3/mtu3_plat.c b/drivers/usb/mtu3/mtu3_plat.c index b4f4c776adb9..ce64c36a98f7 100644 --- a/drivers/usb/mtu3/mtu3_plat.c +++ b/drivers/usb/mtu3/mtu3_plat.c @@ -445,6 +445,7 @@ static int mtu3_probe(struct platform_device *pdev) comm_init_err: pm_runtime_put_noidle(dev); pm_runtime_disable(dev); + pm_runtime_dont_use_autosuspend(dev); ssusb_debugfs_remove_root(ssusb); =20 return ret; @@ -483,6 +484,7 @@ static void mtu3_remove(struct platform_device *pdev) ssusb_rscs_exit(ssusb); ssusb_debugfs_remove_root(ssusb); pm_runtime_disable(&pdev->dev); + pm_runtime_dont_use_autosuspend(&pdev->dev); pm_runtime_put_noidle(&pdev->dev); pm_runtime_set_suspended(&pdev->dev); } --=20 2.47.3 From nobody Fri Sep 25 07:56:39 2026 Received: from mail-ej2-f12.google.com (mail-ej2-f12.google.com [74.125.228.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 3C3D24718CC for ; Tue, 15 Sep 2026 09:03:01 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=74.125.228.140 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1789462983; cv=none; b=r1zp7KIpMfn8kyAulddBcU8f3VYrjML9mzAK4iBRozNx+uN4ivqAGWc2Piutv84HqPnC9DLyNq1cLlO2tVlZuXj0xP2rvChr7d6lVoO2iQuw6lQEvFMQSkJ1Jt4hpUWM52OMyRUDYESGfkeAy958Be2gaLOYcsDxTe+3q265s1U= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1789462983; c=relaxed/simple; bh=SU0lEeXHIti5ysNgnJklZ5vgIPS1RNGl7D8jm31yYEs=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=j82kEyV9yWiGvvQsjYmzvWq5pIXbePKuydDrQhjqoK9l2b/GVjsIdf39vNs/OijJw/JNPvTEpBUdg0j5kTzP3XkZIS6FZPYqDe0VBYBxAh5lQ1rz1BsX0zCkI3OCAUvqHLNvcIDny6IoERw8evovv9TMzpX8YFqGaWb7XKiWT5o= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=UVkz5j77; arc=none smtp.client-ip=74.125.228.140 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="UVkz5j77" Received: by mail-ej2-f12.google.com with SMTP id a640c23a62f3a-c254f56039dso7178366b.3 for ; Tue, 15 Sep 2026 02:03:00 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1789462979; x=1790067779; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to:content-type; bh=eb3xZy75NQGOxtpcjzjk4/qG4sLL2mvyNHZ62g17sL0=; b=UVkz5j77RjpAaK0y/jNeuHj0ZHg+B1g5NmpH9THqtTxkiZ+uOZuYp0HIkjUqpO3l+5 y9gM0JT0/m8yekq9HFO64OpAISrUSILIh4hPnwhcmitY6JBwptAeGjdvP7o77KvQ56Ys iEmR782OZA0Ha7ct7fZXkI8Au9Lo7d4XMtR88B9Aoh1eWTG8Ah6YtJb2NGQAId3EUQ+Z L1dU+O3NDj82gkz9KNA4lZ5PqUfK+A54UDlszBE08ilapTUtYu4mhbw+A+1fIiQW9Wk0 MD2nVkuVBFXwzz2xysEHuL58H1j2vfF1u61QJ+hWTePudpdxc4H3Z8xCSfuw/0fx1A+C bBpA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20260707; t=1789462979; x=1790067779; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to:content-type; bh=eb3xZy75NQGOxtpcjzjk4/qG4sLL2mvyNHZ62g17sL0=; b=0PGbPUZl2nf18j9LBa3svZtAptf/CBC9HGqb35Lt/f532aK/r6LpQDnAvDYBff64U3 1f4QgVKVX/dhj/RqKW3+JVMwVIHxwxmqNyRN4Muj+XZqdvZ8dsNGt6oMhBB93txXGqVE mMLPEsW5LSQCR01XVcqd7WxEmnwGD1pgFpp/BjiSm2SlsCaIFF72kpyT393V2+kKHm6P Hk7GnnZ7Ld6fgQej0tohFrM01e/wcYuXB/SRC5kJXo3SuKDChy8PfHajK3yU0nreS64L mSFEcDpi6+PiXLpCzSzSS8fxGgmnaUmiF0orRpMV3EHxocm49zS+I9/RgRRAp3pqiW+7 pkQg== X-Forwarded-Encrypted: i=1; AKwUvBwHlQb6yWQ+Lsgn9bw7QTuwIFet8SDBL0966H9yOwsXE1TVgVlBi9eUdmpnVfCinosCT/GbHJl0enw0nSU=@vger.kernel.org X-Gm-Message-State: AFuF++nroWcNTWwgAc6NuvhtVWGVKT4H7lA94qY4yAbmOAPX7egSxHSl CxyvHQzFUsxVw86kec5nPpaeylj1YfPzybznPIyLOObkMxtwDND+GzK5 X-Gm-Gg: AYBFou0cZIF3mapIhGkTzHxtJDu+/Y75GojWe/nsJrmCpqu8k8xEK7lZIIfibfQb1e4 qDw80PX8NIoE80uYNHzfs5ENrJ/aJp8Fmkwc/2DQBvW5doXOkXqiINA5KTXJTzvejSAaG0JB/Ww psEQcrZ55DawyWMKdFyJywo87O6GVIe03xNxxTSaX6wOeTMaUQJolL4HVxcgCWFYBMiBM7K74nk EM3g2FUa/jfvCdSeC7qSxAHxETzQB/FyjrDwURRj6PRlBqF+jUtbgdHXvuyfgeFpyIsw16HhGL8 HWXPpCBJpQqt/GAeNFwK6yebGJ1yTr9Tz+gPMIuje2gBwN22Qm1zK6ugKBFazeAh7L5oqlmMxXT 7obZNCAJOJDFM4kzQjhUik8x0izRMORjRrfpUqkfKxgL8+f+UTkjRtteEr5JCbp1UFphi6YYDaR rrEeFsnd3a1znF60aGgvmc5u+UcSyZzf6qFPZ/GXvQ3chg3XgI7JGsYZpeCzRpFccX3NtV3zaHm BkbisECR7TD/COGVnTlRy9HXS9CRLZc/rbJUNoluqMco0jm941CH6RqZMgghCleFY+iozTLGxwD PMCUssbotDrv21Eq6NjgVA8qCxS3zAQqZ9ywvTPxFeNaFXWvxPvEO0VNwPH9l4rpgccqdKne509 XwTJyMOL31QVgVHKA/+vsQKUzwdr/GHO0wvRA82NuOX2yGa4JTIPm14TrSgvyY9jBZwC1dACn8A kt9Ivrf20AyLGKzq6svmYhPIzKhH42PhHrIghcdtem0EutzVohzueiLQeLVDc1PRoyxZd6lmdHC T3h9I/TYWc= X-Received: by 2002:a17:907:3c86:b0:c29:60c1:7e55 with SMTP id a640c23a62f3a-c29d7794becmr17686466b.12.1789462979111; Tue, 15 Sep 2026 02:02:59 -0700 (PDT) Received: from cs-280612103108-default.europe-west4-b.c.oa7bb030819b2a894-tp.internal (88.71.12.34.bc.googleusercontent.com. [34.12.71.88]) by smtp.gmail.com with ESMTPSA id a640c23a62f3a-c2965c4cf01sm546369266b.1.2026.09.15.02.02.58 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 15 Sep 2026 02:02:58 -0700 (PDT) From: Joshua Crofts To: Peter Chen , Pawel Laszczak , Roger Quadros , Greg Kroah-Hartman , Mathias Nyman , Chunfeng Yun , Matthias Brugger , AngeloGioacchino Del Regno , Heikki Krogerus Cc: linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-mediatek@lists.infradead.org, stable@vger.kernel.org Subject: [PATCH 6/6] usb: cdns3: add missing pm_runtime_dont_use_autosuspend() call Date: Tue, 15 Sep 2026 09:02:23 +0000 Message-ID: <20260915090223.1346-7-joshua.crofts1@gmail.com> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20260915090223.1346-1-joshua.crofts1@gmail.com> References: <20260915090223.1346-1-joshua.crofts1@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" cdns3_plat_remove() calls pm_runtime_disable() on device teardown, but doesn't call pm_runtime_dont_use_autosuspend(), causing resource leaks. Add the missing pm_runtime_dont_use_autosuspend() call. Found using Coccinelle. Fixes: f738957277ba ("usb: cdns3: Split core.c into cdns3-plat and core.c f= ile") Cc: Signed-off-by: Joshua Crofts --- drivers/usb/cdns3/cdns3-plat.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/usb/cdns3/cdns3-plat.c b/drivers/usb/cdns3/cdns3-plat.c index e3f32c3e9535..b85d5d1c48fd 100644 --- a/drivers/usb/cdns3/cdns3-plat.c +++ b/drivers/usb/cdns3/cdns3-plat.c @@ -219,6 +219,7 @@ static void cdns3_plat_remove(struct platform_device *p= dev) if (!(cdns->pdata && (cdns->pdata->quirks & CDNS3_DEFAULT_PM_RUNTIME_ALLO= W))) pm_runtime_allow(dev); =20 + pm_runtime_dont_use_autosuspend(dev); pm_runtime_disable(dev); pm_runtime_put_noidle(dev); cdns_remove(cdns); --=20 2.47.3