From nobody Fri Sep 25 07:57:13 2026 Received: from mail-pz2-f42.google.com (mail-pz2-f42.google.com [74.125.228.42]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id DFC3E37E5ED for ; Tue, 15 Sep 2026 07:55:31 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=74.125.228.42 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1789458933; cv=none; b=nNdFx9U7z3/A99TwPgi+/Xh/EY5TmP3WFhzKfI3lvA5fT3FfBADnhc0Gcy6bnEYVB2cExcvDzd77fPUCTMaW/Jc/ANkEdMD3RyiTqliN0INv8i1DjfK9b1dUzicaUdO/4ZypdvwN0Tw9f7hA0ttbudtByQLDiwFipUsK1MAG19o= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1789458933; c=relaxed/simple; bh=tCmrY8bbWX/n5rVI3Gf1grWS2sFWfnCZLxtu4re3KDU=; h=From:To:Cc:Subject:Date:Message-ID:MIME-Version; b=JVyxeZKx04v8vm5Aj0cKQ4XTToOWrg6WjpRwCaPWee2NMFdV0UpZKfcIQbBUYEG7wA/O6kSuGKe5xJNdssj+MdGdimceJUeJN24CZp0wPIngxdRrjhPnMuTW4OEbOFWzIaOH6Cjxv7V4IGurcROlXfpkE0SGigX7Fbm7P3PBJ68= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=bE4uWn6F; arc=none smtp.client-ip=74.125.228.42 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="bE4uWn6F" Received: by mail-pz2-f42.google.com with SMTP id d2e1a72fcca58-86e6d007703so1866899b3a.0 for ; Tue, 15 Sep 2026 00:55:31 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1789458931; x=1790063731; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to:content-type; bh=VKOice3d+d9oEFyie9yQ2tllBkQHbuzBZLWo6vl/Ptg=; b=bE4uWn6FQXPPHeSYqFLTJMcg9+Mt7PlBT1NSIR7QJfn2w2Y5PVjKrnKviaj5pRu5PT VCykXEEmWcRGeRO0TeokyK49x+LkYVNMNBvQKBYGqCC2puGGsgtw1IghDfNMXdLzMPho 4dPNgKZEpNILE9CfdQXl+GdjcTWDbhLy2G5vjFiixsNaT9ks2ueL+iCM5mfOOPD385Ia GJfBtssZdZC8SFRowQ7X9i+DHo0v875wA4B3EQ9O1ZoqPzsWE0lFXzmqdQhnSL032Sxv ueHFWhD7ILT6GziQZW/NB4mHdsRElQXQ3vHEUl0bvLONWplk3Y4Hv1VmOD85R0OLrmAX dOVg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20260707; t=1789458931; x=1790063731; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to:content-type; bh=VKOice3d+d9oEFyie9yQ2tllBkQHbuzBZLWo6vl/Ptg=; b=fj8xwrIXqedg17q+pF+zLflCZpXH++SlwL/a7WgJfTKUi7MhsvNz79KfLrL1fHQqIC /kedj9p9ww7Wy++4nRtbZ/9pOLCVVw4LhXgUgxBEKmH+yfrGH/IHsN/XxICln7A3p8VG adz9V6NjCnV8Qh0rH6lDobAqDKtZmAU0VwsfyeJjMNUfJe5TRtQdxy7WcxbPrdhHRtr5 up2PWu/5wf0jI6qKpmac/qoLAA7bCqy0slDbXn1kw36g81ujO4y497IZQWiGBD3+VjFP kwx9YJMc7yklGfLmfNnE7gnKzE5C6rVUSKkh/TeZm6Nv7ssKpoyAWWF3fwvn+tdA1Lef S3rA== X-Forwarded-Encrypted: i=1; AKwUvByotshfbTMD0+0iIC/b2zWomRdFq/YFiUU5oJaxGcMTGySe038A9iscQD+rjORoOu8Hp4TPwYXoTc35sFA=@vger.kernel.org X-Gm-Message-State: AFuF++kqdBmE1F4TFNG6porG+2bNg38xmBd8RWuPU8e1MSUSQ/UuI98u 6+uaJrANNmQvJumdadE66t17ahH0geKivC7YmEB8LUnkbQ0LW0OOzew7 X-Gm-Gg: AYBFou1M11IdX5vFJgNHj8b7R+Vc8BvbtOTmH5Y00leJSOGE4TE29b1xgJcXC2FMpgh zVeChmmuax6kHi3I8l7X/lB/PavqdHF99ynFGCNv3fxtmYGwaLVmAtuS0lu7cz0M1rCfIgI7ipS 7ZLjgz0KZzYiiGYvk4hpyonh774wgUKHC//CBCIP7yLFWbBrCVqP9ThZxmTyZ3dQuEn+0LKXtFF 9nf7MhEVG0dlrwhOtWntcaeVRNDk6LZJmwZIBZEFsBMsP8JVwVdA+PGCDql27017ZAFQj1P6674 4Ue8BhewakKiPkRAjttw/SfAP9gnPoXBoI6sxQrO/Gv0tcVIPz8mY3thuV8XVkQj7Jey0QBqpex XiQPF8dxatM8jC7Ci44IduiD6aY/Ft0gZlCY/iivk2azRK/lxHmFiJTyA8E6A+JsfGX4THcozGY PbNZCwzB4wCAN96B4iEcQzHXKbMdeeesqIKfOCGdh5PzkbcQMvmpVkOQ== X-Received: by 2002:a05:6a00:2d88:b0:845:cf73:c1d8 with SMTP id d2e1a72fcca58-86f85106b87mr11748969b3a.14.1789458931018; Tue, 15 Sep 2026 00:55:31 -0700 (PDT) Received: from lgs.. ([2001:250:5800:1002::de93]) by smtp.gmail.com with ESMTPSA id 41be03b00d2f7-cc4c659b9a3sm6172351a12.29.2026.09.15.00.55.27 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 15 Sep 2026 00:55:30 -0700 (PDT) From: Guangshuo Li To: Sakari Ailus , =?UTF-8?q?Krzysztof=20Ha=C5=82asa?= , Mauro Carvalho Chehab , linux-media@vger.kernel.org, linux-kernel@vger.kernel.org Cc: Guangshuo Li Subject: [PATCH] media: i2c: ar0521: remove duplicate media entity cleanup Date: Tue, 15 Sep 2026 15:55:20 +0800 Message-ID: <20260915075520.2122757-1-lgs201920130244@gmail.com> X-Mailer: git-send-email 2.43.0 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" The error path taken when ar0521_power_on() fails calls media_entity_cleanup() at the disable label and then falls through to the entity_cleanup label, where media_entity_cleanup() is called again. There is no need to clean up the media entity twice. Remove the first call and let all error paths converge on the common entity_cleanup label. This issue was found by manual code inspection. Fixes: 852b50aeed15 ("media: On Semi AR0521 sensor driver") Signed-off-by: Guangshuo Li Acked-by: Krzysztof Ha=C5=82asa --- drivers/media/i2c/ar0521.c | 1 - 1 file changed, 1 deletion(-) diff --git a/drivers/media/i2c/ar0521.c b/drivers/media/i2c/ar0521.c index ed324c2d87aa..be68789eb8f5 100644 --- a/drivers/media/i2c/ar0521.c +++ b/drivers/media/i2c/ar0521.c @@ -1142,7 +1142,6 @@ static int ar0521_probe(struct i2c_client *client) =20 disable: v4l2_async_unregister_subdev(&sensor->sd); - media_entity_cleanup(&sensor->sd.entity); free_ctrls: v4l2_ctrl_handler_free(&sensor->ctrls.handler); entity_cleanup: --=20 2.43.0