From nobody Fri Sep 25 08:47:14 2026 Received: from cstnet.cn (smtp21.cstnet.cn [159.226.251.21]) (using TLSv1.2 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 1AC6B43F8A5; Tue, 15 Sep 2026 05:57:11 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=159.226.251.21 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1789451837; cv=none; b=mj/KB+lgi8GPEit41oHJC1TjsBvV3vC9r2cASSUPmH0WueHLvuYemRva5PeyQjMZ/E8QlUcjHj5ShWHDppH3uS2+YTHXzJBQ52V6IJ1leAEkrUopkfEyHwhGUWAVUhx6e2BOBJI3e1zPtn6PBoC5f93u4M/6STPg/AjQnMbMcss= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1789451837; c=relaxed/simple; bh=tLV2xGiTDg2YBjhLCI/PNppwmzdUqU5vJ76gQRacHf0=; h=From:To:Cc:Subject:Date:Message-Id:MIME-Version; b=bMMsulVZt3s587z4maRT68ERaXEXh7TOjUhNau4BQQVYDjTYLrzXfOZb4GYIaWNfMsuCAMrbtxEAg4aiOucaH2YOWYvOx9GB3MYXcZgH7QhwaYBp/HcEtvxeH0ys7pWgS5TVPLVMQV5+s7iR3U1v7YP/zUF/wF5ypq/bLN6Uj88= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=iscas.ac.cn; spf=pass smtp.mailfrom=iscas.ac.cn; arc=none smtp.client-ip=159.226.251.21 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=iscas.ac.cn Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=iscas.ac.cn Received: from dfae2b116770.home.arpa (unknown [36.110.52.2]) by APP-01 (Coremail) with SMTP id qwCowADXq+8r3qhqb1IKCA--.33350S2; Tue, 15 Sep 2026 13:57:00 +0800 (CST) From: Wentao Liang To: Frank.Li@nxp.com Cc: abelvesa@kernel.org, bmasney@redhat.com, festevam@gmail.com, imx@lists.linux.dev, kernel@pengutronix.de, linux-arm-kernel@lists.infradead.org, linux-clk@vger.kernel.org, linux-kernel@vger.kernel.org, mturquette@baylibre.com, peng.fan@nxp.com, s.hauer@pengutronix.de, sboyd@kernel.org, shawnguo@kernel.org, Wentao Liang , stable@vger.kernel.org Subject: [PATCH] clk: imx: Fix clock reference leak in imx_obtain_fixed_clock_hw() Date: Tue, 15 Sep 2026 05:56:31 +0000 Message-Id: <20260915055631.1730231-1-vulab@iscas.ac.cn> X-Mailer: git-send-email 2.34.1 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-CM-TRANSID: qwCowADXq+8r3qhqb1IKCA--.33350S2 X-Coremail-Antispam: 1UD129KBjvJXoW7uw18CFWkXw1fJFy7KF4fAFb_yoW8Gr1kpr 4kWrWYk3ySkryS9F17Jr4UZF9Yga1kZFyUK3s3W3W8ur9xXay7tF18C34vgr40yrZYkw13 XF1agFn5KF4YyF7anT9S1TB71UUUUU7qnTZGkaVYY2UrUUUUjbIjqfuFe4nvWSU5nxnvy2 9KBjDU0xBIdaVrnRJUUU9I14x267AKxVW8JVW5JwAFc2x0x2IEx4CE42xK8VAvwI8IcIk0 rVWrJVCq3wAFIxvE14AKwVWUJVWUGwA2ocxC64kIII0Yj41l84x0c7CEw4AK67xGY2AK02 1l84ACjcxK6xIIjxv20xvE14v26ryj6F1UM28EF7xvwVC0I7IYx2IY6xkF7I0E14v26F4j 6r4UJwA2z4x0Y4vEx4A2jsIE14v26rxl6s0DM28EF7xvwVC2z280aVCY1x0267AKxVW0oV Cq3wAS0I0E0xvYzxvE52x082IY62kv0487Mc02F40EFcxC0VAKzVAqx4xG6I80ewAv7VC0 I7IYx2IY67AKxVWUtVWrXwAv7VC2z280aVAFwI0_Gr1j6F4UJwAm72CE4IkC6x0Yz7v_Jr 0_Gr1lF7xvr2IYc2Ij64vIr41lF7I21c0EjII2zVCS5cI20VAGYxC7M4IIrI8v6xkF7I0E 8cxan2IY04v7MxkF7I0En4kS14v26r1q6r43MxAIw28IcxkI7VAKI48JMxC20s026xCaFV Cjc4AY6r1j6r4UMI8I3I0E5I8CrVAFwI0_Jr0_Jr4lx2IqxVCjr7xvwVAFwI0_JrI_JrWl x4CE17CEb7AF67AKxVW8ZVWrXwCIc40Y0x0EwIxGrwCI42IY6xIIjxv20xvE14v26r1I6r 4UMIIF0xvE2Ix0cI8IcVCY1x0267AKxVWxJVW8Jr1lIxAIcVCF04k26cxKx2IYs7xG6r1j 6r1xMIIF0xvEx4A2jsIE14v26r4j6F4UMIIF0xvEx4A2jsIEc7CjxVAFwI0_Gr1j6F4UJb IYCTnIWIevJa73UjIFyTuYvjfUogAwDUUUU X-CM-SenderInfo: pyxotu46lvutnvoduhdfq/1tbiDAMLA2qowzNfoQAAsL Content-Type: text/plain; charset="utf-8" imx_obtain_fixed_clock_hw() obtains the clock through imx_obtain_fixed_clock_from_dt(), which creates a consumer reference via of_clk_get_from_provider(). The reference is discarded right after __clk_get_hw() returns the hardware pointer, leaking it. Keep the imx_clk_fixed() fallback unchanged and drop the DT-obtained consumer reference with clk_put() once the hardware pointer has been extracted. Fixes: a4a4069f4523 ("clk: imx: Add imx_obtain_fixed_clock clk_hw based var= iant") Cc: stable@vger.kernel.org Signed-off-by: Wentao Liang --- drivers/clk/imx/clk.c | 9 +++++++-- 1 file changed, 7 insertions(+), 2 deletions(-) diff --git a/drivers/clk/imx/clk.c b/drivers/clk/imx/clk.c index e113e30514fa..49e51e949f71 100644 --- a/drivers/clk/imx/clk.c +++ b/drivers/clk/imx/clk.c @@ -95,11 +95,16 @@ struct clk_hw *imx_obtain_fixed_clock_hw( const char *name, unsigned long rate) { struct clk *clk; + struct clk_hw *hw; =20 clk =3D imx_obtain_fixed_clock_from_dt(name); if (IS_ERR(clk)) - clk =3D imx_clk_fixed(name, rate); - return __clk_get_hw(clk); + return __clk_get_hw(imx_clk_fixed(name, rate)); + + hw =3D __clk_get_hw(clk); + clk_put(clk); + + return hw; } =20 struct clk_hw *imx_obtain_fixed_of_clock(struct device_node *np, --=20 2.34.1