From nobody Fri Sep 25 08:47:19 2026 Received: from cstnet.cn (smtp21.cstnet.cn [159.226.251.21]) (using TLSv1.2 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id D477043F4BC; Tue, 15 Sep 2026 05:54:20 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=159.226.251.21 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1789451664; cv=none; b=m0eBd6V0vpMO71LLoikNAaY6tku/bwCyoaQtvdMHvM89kF3CFnBxd1Xb5u3AHjSV9GgxufjzCgbHtoqh34GyM9UMKDOeM6haq5lmD+TmD1FoKSvSD5GD0TUC6Psqj7x7Wef4d+Pu5GvUNuIJdFmNVJAjZYyMuaz5ndCOgjZPFEA= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1789451664; c=relaxed/simple; bh=3sYecSxeNgB02wiERP5ba/DfG+sYZLpEY0/l22a56V0=; h=From:To:Cc:Subject:Date:Message-Id:MIME-Version; b=cF/YUXeMbuZXWSmya3BXWvOnqVQDDnRQP37aaqjiG760CIIkVkUTfunk55gB7eGCQvCz+gbdyqQ8fKcGBgN/irQ+/zcCoXuUYCSq/puY3CIdcHFNAKYd1U1W7E3gkkJxlxp5Akp/dpPmtlwEjWGjSNa7u8mky/Dfsd31HnoMC/g= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=iscas.ac.cn; spf=pass smtp.mailfrom=iscas.ac.cn; arc=none smtp.client-ip=159.226.251.21 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=iscas.ac.cn Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=iscas.ac.cn Received: from dfae2b116770.home.arpa (unknown [36.110.52.2]) by APP-01 (Coremail) with SMTP id qwCowAB3TPCE3ahqLUUKCA--.2511S2; Tue, 15 Sep 2026 13:54:12 +0800 (CST) From: Wentao Liang To: alim.akhtar@samsung.com Cc: bmasney@redhat.com, cw00.choi@samsung.com, krzk@kernel.org, linux-arm-kernel@lists.infradead.org, linux-clk@vger.kernel.org, linux-kernel@vger.kernel.org, linux-samsung-soc@vger.kernel.org, mturquette@baylibre.com, s.nawrocki@samsung.com, sboyd@kernel.org, semen.protsenko@linaro.org, Wentao Liang , stable@vger.kernel.org Subject: [PATCH] clk: samsung: Fix parent clock reference leak on enable failure Date: Tue, 15 Sep 2026 05:53:43 +0000 Message-Id: <20260915055343.1730045-1-vulab@iscas.ac.cn> X-Mailer: git-send-email 2.34.1 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-CM-TRANSID: qwCowAB3TPCE3ahqLUUKCA--.2511S2 X-Coremail-Antispam: 1UD129KBjvJXoW7CF15AFy7JFyUGryxuw1DGFg_yoW8XFy5pF Z7CrWYyFW5GrWUKF43Kr1qgr1aqw45CFy3WryfCa4kWwn0yryDAF1rGa4qv3Z8JrWrJFWr trsrtFZ5CF18ZaDanT9S1TB71UUUUU7qnTZGkaVYY2UrUUUUjbIjqfuFe4nvWSU5nxnvy2 9KBjDU0xBIdaVrnRJUUU9214x267AKxVW8JVW5JwAFc2x0x2IEx4CE42xK8VAvwI8IcIk0 rVWrJVCq3wAFIxvE14AKwVWUJVWUGwA2ocxC64kIII0Yj41l84x0c7CEw4AK67xGY2AK02 1l84ACjcxK6xIIjxv20xvE14v26ryj6F1UM28EF7xvwVC0I7IYx2IY6xkF7I0E14v26F4j 6r4UJwA2z4x0Y4vEx4A2jsIE14v26rxl6s0DM28EF7xvwVC2z280aVCY1x0267AKxVW0oV Cq3wAS0I0E0xvYzxvE52x082IY62kv0487Mc02F40EFcxC0VAKzVAqx4xG6I80ewAv7VC0 I7IYx2IY67AKxVWUtVWrXwAv7VC2z280aVAFwI0_Gr1j6F4UJwAm72CE4IkC6x0Yz7v_Jr 0_Gr1lF7xvr2IYc2Ij64vIr41lF7I21c0EjII2zVCS5cI20VAGYxC7M4IIrI8v6xkF7I0E 8cxan2IY04v7MxkF7I0En4kS14v26r1q6r43MxAIw28IcxkI7VAKI48JMxC20s026xCaFV Cjc4AY6r1j6r4UMI8I3I0E5I8CrVAFwI0_Jr0_Jr4lx2IqxVCjr7xvwVAFwI0_JrI_JrWl x4CE17CEb7AF67AKxVWUtVW8ZwCIc40Y0x0EwIxGrwCI42IY6xIIjxv20xvE14v26r1j6r 1xMIIF0xvE2Ix0cI8IcVCY1x0267AKxVW8JVWxJwCI42IY6xAIw20EY4v20xvaj40_Jr0_ JF4lIxAIcVC2z280aVAFwI0_Gr0_Cr1lIxAIcVC2z280aVCY1x0267AKxVW8Jr0_Cr1UYx BIdaVFxhVjvjDU0xZFpf9x0JULo7NUUUUU= X-CM-SenderInfo: pyxotu46lvutnvoduhdfq/1tbiBwULA2qowpBb1AABsU Content-Type: text/plain; charset="utf-8" In exynos_arm64_enable_bus_clk(), when dev is NULL the parent clock is obtained with of_clk_get_by_name() and then handed to clk_prepare_enable(). On the enable failure path the function returns directly without clk_put(), leaking the consumer reference. Store the clk_prepare_enable() return value and release the reference with clk_put() before returning on failure. Fixes: 454e8d296ce4 ("clk: samsung: Extract parent clock enabling to common= function") Cc: stable@vger.kernel.org Signed-off-by: Wentao Liang --- drivers/clk/samsung/clk-exynos-arm64.c | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/drivers/clk/samsung/clk-exynos-arm64.c b/drivers/clk/samsung/c= lk-exynos-arm64.c index 35d4de233cc1..05c4a15dfe99 100644 --- a/drivers/clk/samsung/clk-exynos-arm64.c +++ b/drivers/clk/samsung/clk-exynos-arm64.c @@ -149,6 +149,7 @@ static int __init exynos_arm64_enable_bus_clk(struct de= vice *dev, struct device_node *np, const struct samsung_cmu_info *cmu) { struct clk *parent_clk; + int ret; =20 if (!cmu->clk_name) return 0; @@ -167,7 +168,11 @@ static int __init exynos_arm64_enable_bus_clk(struct d= evice *dev, if (IS_ERR(parent_clk)) return PTR_ERR(parent_clk); =20 - return clk_prepare_enable(parent_clk); + ret =3D clk_prepare_enable(parent_clk); + if (ret) + clk_put(parent_clk); + + return ret; } =20 static int __init exynos_arm64_cmu_prepare_pm(struct device *dev, --=20 2.34.1