From nobody Fri Sep 25 08:47:13 2026 Received: from cstnet.cn (smtp21.cstnet.cn [159.226.251.21]) (using TLSv1.2 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 0A5A63C1F54; Tue, 15 Sep 2026 05:00:40 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=159.226.251.21 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1789448443; cv=none; b=pkaTiT2uxT27nJN7wuYCI/w/DJJGEXvN4vA6S2JNLvcG3CnhP9k6Xwi3AW7DXv1MlM8Roh+gD0dMbfGpyBresycrKARReZT1M4DZAy54zmlgM0570XiOw92SEw3jMUa19vSz8SzuiVWmxNCI3FCBvP7uxLvs3fZuX07twOcS31E= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1789448443; c=relaxed/simple; bh=SVUszxCcUQhe5DJLRvnZoeKO4YFQkOlERiAqe2apPVI=; h=From:To:Cc:Subject:Date:Message-Id:MIME-Version; b=XDiCeLZt81SqIzMVtbNSGKKgYsY1BYze7430SeuXL0zTGGABybpTJvab5d3loVMvKtBKoR9dhcG+1QOpVDEcRIyiuaXUS8FoV4WvExb1N2JLzK5DXOPjy7H2ymLzda/CQO+n59DoXBHV2eO5mqNE+FqrIq/c8+s5YZzVlOh3/OI= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=iscas.ac.cn; spf=pass smtp.mailfrom=iscas.ac.cn; arc=none smtp.client-ip=159.226.251.21 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=iscas.ac.cn Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=iscas.ac.cn Received: from dfae2b116770.home.arpa (unknown [36.110.52.2]) by APP-01 (Coremail) with SMTP id qwCowADXqOzy0Khqp0cJCA--.668S2; Tue, 15 Sep 2026 13:00:34 +0800 (CST) From: Wentao Liang To: alexandre.belloni@bootlin.com Cc: claudiu.beznea@tuxon.dev, daniel.lezcano@kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, nicolas.ferre@microchip.com, tglx@kernel.org, lkml@vger.kernel.org, Wentao Liang , stable@vger.kernel.org Subject: [PATCH] clocksource/drivers/timer-atmel-pit: Fix mck reference leak in error paths Date: Tue, 15 Sep 2026 05:00:05 +0000 Message-Id: <20260915050005.1727060-1-vulab@iscas.ac.cn> X-Mailer: git-send-email 2.34.1 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-CM-TRANSID: qwCowADXqOzy0Khqp0cJCA--.668S2 X-Coremail-Antispam: 1UD129KBjvJXoWxJFyDtw4kXw1xJF1DuFWDXFb_yoW5JFWkpr Wjqw45tr1kWay29rs2yFWDZr1kt3yIkFy7urW5C34fZwsxuryrXFW8Aa4UZFWDCF4kuanI q3Z7tFy8uFyDAF7anT9S1TB71UUUUU7qnTZGkaVYY2UrUUUUjbIjqfuFe4nvWSU5nxnvy2 9KBjDU0xBIdaVrnRJUUU9214x267AKxVW8JVW5JwAFc2x0x2IEx4CE42xK8VAvwI8IcIk0 rVWrJVCq3wAFIxvE14AKwVWUJVWUGwA2ocxC64kIII0Yj41l84x0c7CEw4AK67xGY2AK02 1l84ACjcxK6xIIjxv20xvE14v26ryj6F1UM28EF7xvwVC0I7IYx2IY6xkF7I0E14v26F4j 6r4UJwA2z4x0Y4vEx4A2jsIE14v26rxl6s0DM28EF7xvwVC2z280aVCY1x0267AKxVW0oV Cq3wAS0I0E0xvYzxvE52x082IY62kv0487Mc02F40EFcxC0VAKzVAqx4xG6I80ewAv7VC0 I7IYx2IY67AKxVWUAVWUtwAv7VC2z280aVAFwI0_Gr1j6F4UJwAm72CE4IkC6x0Yz7v_Jr 0_Gr1lF7xvr2IYc2Ij64vIr41lF7I21c0EjII2zVCS5cI20VAGYxC7M4IIrI8v6xkF7I0E 8cxan2IY04v7MxkF7I0En4kS14v26r1q6r43MxAIw28IcxkI7VAKI48JMxC20s026xCaFV Cjc4AY6r1j6r4UMI8I3I0E5I8CrVAFwI0_Jr0_Jr4lx2IqxVCjr7xvwVAFwI0_JrI_JrWl x4CE17CEb7AF67AKxVWUtVW8ZwCIc40Y0x0EwIxGrwCI42IY6xIIjxv20xvE14v26r1I6r 4UMIIF0xvE2Ix0cI8IcVCY1x0267AKxVW8JVWxJwCI42IY6xAIw20EY4v20xvaj40_Jr0_ JF4lIxAIcVC2z280aVAFwI0_Gr0_Cr1lIxAIcVC2z280aVCY1x0267AKxVW8Jr0_Cr1UYx BIdaVFxhVjvjDU0xZFpf9x0JUJWrAUUUUU= X-CM-SenderInfo: pyxotu46lvutnvoduhdfq/1tbiBwULA2qowpAzMQAAsY Content-Type: text/plain; charset="utf-8" at91sam926x_pit_dt_init() obtains the mck clock with of_clk_get() but the exit label only frees the pit_data, leaking the clock reference on every error path that reaches it. Once the clock has been prepared and enabled, later failures leave it enabled as well, and the clk_prepare_enable() failure path leaks the reference even though the clock was never enabled. Add disable_clk and put_clk labels so the mck reference is always released on error: clk_put() when prepare+enable fails, and clk_disable_unprepare() followed by clk_put() when aborting after the clock has been enabled. Error paths before the clock is obtained keep jumping to exit, and the success path keeps the clock enabled for the lifetime of the timer. Fixes: a17686c46244 ("clocksource/drivers/timer-atmel-pit: Drop at91sam926x= _pit_common_init") Cc: stable@vger.kernel.org Signed-off-by: Wentao Liang --- drivers/clocksource/timer-atmel-pit.c | 12 ++++++++---- 1 file changed, 8 insertions(+), 4 deletions(-) diff --git a/drivers/clocksource/timer-atmel-pit.c b/drivers/clocksource/ti= mer-atmel-pit.c index 888b06731e54..794b4ce4d700 100644 --- a/drivers/clocksource/timer-atmel-pit.c +++ b/drivers/clocksource/timer-atmel-pit.c @@ -191,7 +191,7 @@ static int __init at91sam926x_pit_dt_init(struct device= _node *node) ret =3D clk_prepare_enable(data->mck); if (ret) { pr_err("Unable to enable mck\n"); - goto exit; + goto put_clk; } =20 /* Get the interrupts property */ @@ -199,7 +199,7 @@ static int __init at91sam926x_pit_dt_init(struct device= _node *node) if (!data->irq) { pr_err("Unable to get IRQ from DT\n"); ret =3D -EINVAL; - goto exit; + goto disable_clk; } =20 /* @@ -227,7 +227,7 @@ static int __init at91sam926x_pit_dt_init(struct device= _node *node) ret =3D clocksource_register_hz(&data->clksrc, pit_rate); if (ret) { pr_err("Failed to register clocksource\n"); - goto exit; + goto disable_clk; } =20 /* Set up irq handler */ @@ -237,7 +237,7 @@ static int __init at91sam926x_pit_dt_init(struct device= _node *node) if (ret) { pr_err("Unable to setup IRQ\n"); clocksource_unregister(&data->clksrc); - goto exit; + goto disable_clk; } =20 /* Set up and register clockevents */ @@ -256,6 +256,10 @@ static int __init at91sam926x_pit_dt_init(struct devic= e_node *node) =20 return 0; =20 +disable_clk: + clk_disable_unprepare(data->mck); +put_clk: + clk_put(data->mck); exit: kfree(data); return ret; --=20 2.34.1