From nobody Fri Sep 25 08:47:21 2026 Received: from cstnet.cn (smtp21.cstnet.cn [159.226.251.21]) (using TLSv1.2 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 7584843A7E3; Tue, 15 Sep 2026 04:54:58 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=159.226.251.21 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1789448104; cv=none; b=m7mYStuEhJClTvDpj9enxoTRc4zqCE0feM/SvDRjpOn0IXIAnzrTQm5xj+Kwu4RMefyFebadmXk0VPB5y2xpVP7E6R/btxjZjcQ9HIOAlRUV2pIpTmQNG9EPFkeMWFrvRnTCuTDI604Ywf5nXQQ5MiinlzRWbTZlgJtxo7YDMes= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1789448104; c=relaxed/simple; bh=4MzyD8YqIR6tWPD2zdecbgpXKKJImh1f38v+p92D9Cc=; h=From:To:Cc:Subject:Date:Message-Id:MIME-Version; b=h6RYaECyRNEVyvK9OtbTmkyTBRNzL7QB4xI+fNoWTy3QqZvEvDvoXr2NqWhAK2X+6JGUnnZX7pPxS/tSuQVNzXNexRAJ6weiqJ534xRxVpaEEtnqJisQjufomV2j82Y+ge5GZyR+GGHbWtuoCfBRQ1aAOmRraehBt8C0Bpjov48= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=iscas.ac.cn; spf=pass smtp.mailfrom=iscas.ac.cn; arc=none smtp.client-ip=159.226.251.21 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=iscas.ac.cn Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=iscas.ac.cn Received: from dfae2b116770.home.arpa (unknown [36.110.52.2]) by APP-01 (Coremail) with SMTP id qwCowABXLvKfz6hqGSsJCA--.6161S2; Tue, 15 Sep 2026 12:54:55 +0800 (CST) From: Wentao Liang To: daniel.lezcano@kernel.org Cc: linusw@kernel.org, linux-kernel@vger.kernel.org, tglx@kernel.org, lkml@vger.kernel.org, Wentao Liang , stable@vger.kernel.org Subject: [PATCH] clocksource/drivers/fttmr010: Fix clk reference leak in error paths Date: Tue, 15 Sep 2026 04:54:26 +0000 Message-Id: <20260915045426.1726805-1-vulab@iscas.ac.cn> X-Mailer: git-send-email 2.34.1 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-CM-TRANSID: qwCowABXLvKfz6hqGSsJCA--.6161S2 X-Coremail-Antispam: 1UD129KBjvJXoW7ZrW5Cw13Kry8GryDCF45KFg_yoW8XF17pr W2yw4a9rnxX3yIgrsrJr4vqas0yw42kFyxGa4fC3Z3Zrn8ArW7Zay8Jas0qF45Cry8ZwsI qFsYyFWDAF1Uur7anT9S1TB71UUUUU7qnTZGkaVYY2UrUUUUjbIjqfuFe4nvWSU5nxnvy2 9KBjDU0xBIdaVrnRJUUUkK14x267AKxVW8JVW5JwAFc2x0x2IEx4CE42xK8VAvwI8IcIk0 rVWrJVCq3wAFIxvE14AKwVWUJVWUGwA2ocxC64kIII0Yj41l84x0c7CEw4AK67xGY2AK02 1l84ACjcxK6xIIjxv20xvE14v26r4j6ryUM28EF7xvwVC0I7IYx2IY6xkF7I0E14v26r4j 6F4UM28EF7xvwVC2z280aVAFwI0_GcCE3s1l84ACjcxK6I8E87Iv6xkF7I0E14v26rxl6s 0DM2AIxVAIcxkEcVAq07x20xvEncxIr21l5I8CrVACY4xI64kE6c02F40Ex7xfMcIj6xII jxv20xvE14v26r1Y6r17McIj6I8E87Iv67AKxVW8Jr0_Cr1UMcvjeVCFs4IE7xkEbVWUJV W8JwACjcxG0xvY0x0EwIxGrwACjI8F5VA0II8E6IAqYI8I648v4I1lc7CjxVAaw2AFwI0_ JF0_Jw1l42xK82IYc2Ij64vIr41l4I8I3I0E4IkC6x0Yz7v_Jr0_Gr1lx2IqxVAqx4xG67 AKxVWUJVWUGwC20s026x8GjcxK67AKxVWUGVWUWwC2zVAF1VAY17CE14v26r126r1DMIIY rxkI7VAKI48JMIIF0xvE2Ix0cI8IcVAFwI0_Jr0_JF4lIxAIcVC0I7IYx2IY6xkF7I0E14 v26r4j6F4UMIIF0xvE42xK8VAvwI8IcIk0rVWUJVWUCwCI42IY6I8E87Iv67AKxVW8JVWx JwCI42IY6I8E87Iv6xkF7I0E14v26r4UJVWxJrUvcSsGvfC2KfnxnUUI43ZEXa7VUbWv35 UUUUU== X-CM-SenderInfo: pyxotu46lvutnvoduhdfq/1tbiBwMLA2qowpAvOgAAsJ Content-Type: text/plain; charset="utf-8" fttmr010_common_init() obtains the PCLK reference with of_clk_get_by_name() but never calls clk_put(). If clk_prepare_enable() fails the reference is leaked directly, and every error path that jumps to out_disable_clock only calls clk_disable_unprepare(), which releases the prepare/enable state but not the reference obtained from of_clk_get_by_name(). Add clk_put() to the clk_prepare_enable() failure path and to the out_disable_clock label so the clock reference is no longer leaked. The success path keeps PCLK enabled for the lifetime of the timer and is left untouched. Fixes: dd98442e17a6 ("clocksource/drivers/fttmr010: Drop Gemini specifics") Cc: stable@vger.kernel.org Signed-off-by: Wentao Liang Reviewed-by: Linus Walleij --- drivers/clocksource/timer-fttmr010.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/drivers/clocksource/timer-fttmr010.c b/drivers/clocksource/tim= er-fttmr010.c index 308f94bfbaed..c2553851e8d6 100644 --- a/drivers/clocksource/timer-fttmr010.c +++ b/drivers/clocksource/timer-fttmr010.c @@ -292,6 +292,7 @@ static int __init fttmr010_common_init(struct device_no= de *np, ret =3D clk_prepare_enable(clk); if (ret) { pr_err("failed to enable PCLK\n"); + clk_put(clk); return ret; } =20 @@ -432,6 +433,7 @@ static int __init fttmr010_common_init(struct device_no= de *np, kfree(fttmr010); out_disable_clock: clk_disable_unprepare(clk); + clk_put(clk); =20 return ret; } --=20 2.34.1