From nobody Fri Sep 25 08:46:01 2026 Received: from mail-qv2-f12.google.com (mail-qv2-f12.google.com [74.125.230.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 247D0318ED2 for ; Tue, 15 Sep 2026 01:20:28 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=74.125.230.140 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1789435230; cv=none; b=PZdTcbqVHMRa8ALsh8G9oWAavbop2yJlQxYM3yDr0RD2+eEsJnTO6ENUDM5zKdu6Lu6gm9z4OpSIekWEhgq6PHGE3v/73g8sC3R/HGKS6JhSKpF380hqjlmJv/Ys5n3oT67ssxxmY+H9QvwBWXIn7zOKZJQjTaI2zFDiSVppWLI= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1789435230; c=relaxed/simple; bh=CKKoXinNIPjaJ7mWM3TvEUEq1iXPeisQkm64XntF2Zg=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=d1sEz7f+ky1Nb9aArf0R+T47OsLt6D5DrDClY638gCb07NmvXBcmfELDKlLVAzqM2BCFAAPD6arAzhZaWZDLT68N0jPaekemeCmXFTQxYguByQ0Djb+Mwu9kVwRRz6cm2XUIALTv0GtMPu+tkx5Tna8vPlZlpjXtNfJt4zijIEc= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=bKDH2hy8; arc=none smtp.client-ip=74.125.230.140 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="bKDH2hy8" Received: by mail-qv2-f12.google.com with SMTP id 6a1803df08f44-90cdfbd148aso30609466d6.2 for ; Mon, 14 Sep 2026 18:20:27 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1789435227; x=1790040027; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to:content-type; bh=wCRBWGGFnF1Ry6hzDyS1vYmZsFfXfi71bfZ207Oj8vA=; b=bKDH2hy88roSbWAbthQ36jUz4Y0jCVs7cNPSiqCFShYtQL8PzkxO57EEh8OwbrsGKE PI7upf2d0tAOHKSJ+BdD9TyT+3WcRz0WbvMwU//wMxAio4P8Xu8BHgcygCDIleLUb7qZ 1knmaDQgS6L7eyyrVVtREKUkjE86DxvfVSkaoWXj7qU3lOICKNWCdzPxgcMqbaDXjdY2 Cr99vKTnZzDoBgsK6bKramFb0uWCejvg2jzgmcu7GFtJHfMyeBc7xDbF7nZcDyF/s8UX N2UEly39mJdi2C51kkSW3ra9lb3QzvYV5BLjXKt/2hcNhEuayC/GA5MyhyiRtrFTEaUZ J4PQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20260707; t=1789435227; x=1790040027; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to:content-type; bh=wCRBWGGFnF1Ry6hzDyS1vYmZsFfXfi71bfZ207Oj8vA=; b=s9tu5SC9luPXrG3tXk29hFHyVtwOffzaCxEN6MaCSyS3ReKKoaFRc1F+MJp8ZetsQQ DSgfe4q6lRch0I3Txu129Q+SSayJymJdP9+GmorGllz1PHz9BHqOJjf1ZnF7HrKSWwET Kd+/uZ264ElXgA14qxno9hPXOP0V00RDfJTvl+uov51IsUaiWzbsR9F1KEP5uqAO+Mw+ zOJ+MtHk8CRoWDGBSNR80kJcSjgK18V3cyQ+n14EWwMZi5aDS4Ut2rxln3YggfRQ8mPS 4bee2cmXVDS77MdkDu1yHrLu+vj0DuY/BhO1JTUmJ9wOv1St5xuZbNXnkf8U9zeQxekV m/Eg== X-Forwarded-Encrypted: i=1; AKwUvBycQt+fypkIbbDMMhntwvRq1dxsAS3uuZ9tN9vBG/Q8RFIWKiXyjc7zf6U4fFDZo8tHQEgpIIAztl+/mXw=@vger.kernel.org X-Gm-Message-State: AFuF++k1LMEBd8ybA5cTCK+pcK0c5IhDffDFP7qTZK9Wca2ftdSU4Rrh 2D6ZOgSu+AHPVyHJg+vNqszV5LD87VlrOR23LYt1e8tjJJDuMy/pgo0= X-Gm-Gg: AYBFou3L9n5Pv2DKEOkQKyb/OnEhBFS4kY9JC2VaoR2woDNWmqo4XPAH/prS44YiJcP Z0CU4Xmnfhbal7S1rqOaACVB125A82H6buoV6GxztxMUFiBXayZOy80q3kwnPBG8p1MIwHlIdha jFnfMauJUPiiOiS9c4lBvYL5qqX4MxgdMhxSpSIlbrX9oZ7sQDcebkEtzoxsDwEakOeBkQcDYKp 78y3DyyfN0ispoxLQlZYMy2dyj46lxjTh75DIAJKNXBuZyUi4sPqILoJBZq9I+Q1tHUUGxXCILE zOCbT9lrtvnMhXK7LDeMgmL7lV2LQiEOnHTrki23WnnhtxlY3DgSvurfb/t6bM1WYrcYx3oNKHY Kn69akKxzON2MGbL3YgqEpu8OatoFKqNClNnu52P2Z41Al832QtaLFZUrQLSAvIDmjLm+L2LNlE 51pBOTYfVNM/UNoKVJb7FHXxA+qn9S6zAfNVDOu5vCQqe60PBwEwm8o0seYMZfMArDyPUgJ5iUw lI2cMSzfOGZZ/3Mng01bCIzkLFEUOJvHGyIGA3giGiNRt1SXfYR9sTdcuuudRUe6JTOfEpbfVoY tARgQU5bwqPxyX4zmH3SRoPXl+I6/PEIcFVuVrXGkM34dasQduV5ADx9KeyXo9Gflsrn+K7SNaC DlzSzFg== X-Received: by 2002:a05:6214:590c:b0:8f0:3b98:d6af with SMTP id 6a1803df08f44-9122e660530mr96067806d6.26.1789435222335; Mon, 14 Sep 2026 18:20:22 -0700 (PDT) Received: from 6e-wmo5420-02.ad.psu.edu.net (6e-wmo5420-02.ad.psu.edu. [104.39.213.233]) by smtp.gmail.com with ESMTPSA id 6a1803df08f44-9121a62b783sm91141946d6.23.2026.09.14.18.20.20 (version=TLS1_3 cipher=TLS_CHACHA20_POLY1305_SHA256 bits=256/256); Mon, 14 Sep 2026 18:20:20 -0700 (PDT) From: Myeonghun Pak To: Alan Stern , Greg Kroah-Hartman Cc: Krzysztof Kozlowski , Peter Griffin , Alim Akhtar , Patrice Chotard , linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-samsung-soc@vger.kernel.org, stable@vger.kernel.org Subject: [PATCH 1/4] usb: ohci-da8xx: disable controller wakeup on cleanup Date: Mon, 14 Sep 2026 21:20:08 -0400 Message-ID: <20260915012011.61874-2-mhun512@gmail.com> X-Mailer: git-send-email 2.47.1 In-Reply-To: <20260915012011.61874-1-mhun512@gmail.com> References: <20260915012011.61874-1-mhun512@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" The OHCI core marks controllers with RemoteWakeupConnected as wakeup-capable. Probe enables wakeup, but neither removal nor a later notifier registration failure disables it, leaving the wakeup source attached. Disable controller wakeup after removing the HCD on both paths. This issue was identified during our ongoing static-analysis research while reviewing kernel code. Fixes: a6eeeb9f45b5 ("USB: Update USB default wakeup settings") Cc: stable@vger.kernel.org Assisted-by: LLM Co-developed-by: Ijae Kim Signed-off-by: Ijae Kim Signed-off-by: Myeonghun Pak Acked-by: Alan Stern --- drivers/usb/host/ohci-da8xx.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/drivers/usb/host/ohci-da8xx.c b/drivers/usb/host/ohci-da8xx.c --- a/drivers/usb/host/ohci-da8xx.c +++ b/drivers/usb/host/ohci-da8xx.c @@ -447,6 +447,7 @@ =20 err_remove_hcd: usb_remove_hcd(hcd); + device_wakeup_disable(hcd->self.controller); err: usb_put_hcd(hcd); return error; @@ -457,5 +458,6 @@ struct usb_hcd *hcd =3D platform_get_drvdata(pdev); =20 usb_remove_hcd(hcd); + device_wakeup_disable(hcd->self.controller); usb_put_hcd(hcd); } From nobody Fri Sep 25 08:46:01 2026 Received: from mail-qv2-f12.google.com (mail-qv2-f12.google.com [74.125.230.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 45D182C15B0 for ; Tue, 15 Sep 2026 01:20:26 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=74.125.230.140 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1789435229; cv=none; b=R4c+lXYlD+aBKPNkFBxbHN32Hsg7oBrmLbP+wrp+SfTfTo5Tr6lk2POcMxXCEVGEPRKtHUSbUT1QZ8yaxbGmLfjfMApBu0x051RB1cjVmVPKmVixLJZzCf9QrbYuIxKaievxsy0Ir9u6q1MbP7AiJ5dVxCVRZmovfRMyCpB5vOs= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1789435229; c=relaxed/simple; bh=WGU7/JMb3Apf6nVCL6jDk8mWhlmHbK7srTQ8Ag0GJPI=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=Qz4/j/2y2SloyHb+tebkDrwHePOa7wEibpPSJnE3u6MdkfnAjSuL+2pV0xyzNg7s00gTIIhUk3iDhgvQPNZErUlk3b1PcsrzCu4bm2gu68iTg4yEA0E+MVpKl2pVptYxe27RNGsij2ru6rnrVZcmvwNlKz6WFIlWg6RVn7q+Npk= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=q70+f9D3; arc=none smtp.client-ip=74.125.230.140 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="q70+f9D3" Received: by mail-qv2-f12.google.com with SMTP id 6a1803df08f44-9105d241693so28934186d6.0 for ; Mon, 14 Sep 2026 18:20:25 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1789435224; x=1790040024; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to:content-type; bh=8bAgcAeT8h1GjhtSyhK4NU9n9kJiBEpb3mWf8LmEtbk=; b=q70+f9D378mv0oplvqwtYnLQOz8q+f+4PZRI8RtM9qSddiKKJ4NtBp57We2lrDKeT6 uylKOERaUVqc6HXJ1gdW5p4M40gwNIdyVOxpHh1g/8ypWETO5NL07Vis6ln4c7knVlnp 4JuOlRmTul13brTbmegxC6TgOb/lpnchrjvSE06CZ+zvtO2Q+r1uH9kCOHiIm1+bBx6r wBCJVXmg0l9DmPzCCeX724F0A8qk0Dam7HHYAKk+CXTl9Sq5rDco6UT/dXfbhVBAUFBP 3AEjpgtYp/FBx/4HUty+DRaI8Lvuv4RWvfcYUdliOzzQkZWxua6Yy9Gas0i+GO9eCiav AOkw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20260707; t=1789435224; x=1790040024; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to:content-type; bh=8bAgcAeT8h1GjhtSyhK4NU9n9kJiBEpb3mWf8LmEtbk=; b=W8qHKtjcPQsRDT+1aOSDf2tk/J/e4Tvnf0Cw6sWrO5JpKpVPnN91ceP5FJDlmsS6Tk bT6PxIcHdGdzUZpvgXfun1fY7D0ICPr4PsC1BHUF+d9kE0FborgPBryPPH+UsMIR5BdH EDbC8lVBR3QrtYVYGjoV5FrGMos36U87y5Anoal75OF5B81wfqmnyYeEJYsWrC8xZZeQ e7W0QSV+9jCXMQ3mtwcCBW33m71eiS2hGm7PtRUb6ytx7da/hCJJuPC3s4u60uEsJF40 CCxL2h6Kvp4Tv1GVesyqIOUXcTF7lF9SEmRss6eb5Aux+Oe5D0SIPJTtpJusxKVrAFYi 2X6g== X-Forwarded-Encrypted: i=1; AKwUvBwA6sJDK259EG7+X87J81Jy0Cm/l6+rffQyR1NkID75mKBV3dh5jNwzXgUt23U75BdeneWUlHsVJw3TtNU=@vger.kernel.org X-Gm-Message-State: AFuF++lzxMdf5p4d1I9PC5SYzcUFUz/CEzEgB4L4W9lIV23TkqlTNfxa X84thg/3P0d38ECMEm3vtc6BYivPpJ7NBNdFAvC+8fUlcTy+X9cJET4= X-Gm-Gg: AYBFou3xFcpWobxPTxjK0kXT3GXcfw6sywlKcC7ggybq4G4dyPqaUU+A4G1JSxyq9oV Za+DnEL+g6XRoUepfAjrZur8mOR9s8rztBHI6rkIJi7HwpPBWlOb0QflqRA9Cjm8+O/0Xa28umS vbKWFbroRXlbChfRF0hzAD9DbUolT/nqo+wRJ2rw/XALgwWUJZp2aBSC7RX5TwnHJOT5OnzXa5u k4U0cx/AKdac7tnZjYWDwwh1wB74uBUkGhbWdOhAXSIaxkBlGVg5d83q7XDPGr3pphkT6FqJAeu 25NRP4j8/p9AOz7i7EGFrIGsvREGqmH8ha535qkCF3MrKdm+k+Q4s6FRrfhvKzb7eHwuV1nan61 OvkdzfnHxkxNqNV9HvkJLlkLBhBRxc2K7Z7a6BK6EI3lH/6bT/9JM+3MGEixElAdhRZxwJT9EPQ ZKXNjZ4DJ2bF4j3JVyqffhlq6K0Xequp+o2+XZyFhgC0zrTB5ksDI0svf2Lzlatnl59fx91NvDT 0FVFBxvkiTE2pXCZZ33VuPrmde2zimgNJT9SUbGkg3vXwMCajYk1PZo2LsegnZU/lSYuxVe6luo AaNobVeydloy3Ntd3leFa2dKwW8ZsA8MbbwUHVUblle4QoJyiT2qt9+CLlWHW+ertx4NKNoUl9V /qhEGlQ== X-Received: by 2002:a05:6214:2f0a:b0:910:3453:9011 with SMTP id 6a1803df08f44-9122e66e23bmr95006006d6.35.1789435224176; Mon, 14 Sep 2026 18:20:24 -0700 (PDT) Received: from 6e-wmo5420-02.ad.psu.edu.net (6e-wmo5420-02.ad.psu.edu. [104.39.213.233]) by smtp.gmail.com with ESMTPSA id 6a1803df08f44-9121a62b783sm91141946d6.23.2026.09.14.18.20.22 (version=TLS1_3 cipher=TLS_CHACHA20_POLY1305_SHA256 bits=256/256); Mon, 14 Sep 2026 18:20:23 -0700 (PDT) From: Myeonghun Pak To: Alan Stern , Greg Kroah-Hartman Cc: Krzysztof Kozlowski , Peter Griffin , Alim Akhtar , Patrice Chotard , linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-samsung-soc@vger.kernel.org, stable@vger.kernel.org Subject: [PATCH 2/4] usb: ohci-s3c2410: disable controller wakeup on removal Date: Mon, 14 Sep 2026 21:20:09 -0400 Message-ID: <20260915012011.61874-3-mhun512@gmail.com> X-Mailer: git-send-email 2.47.1 In-Reply-To: <20260915012011.61874-1-mhun512@gmail.com> References: <20260915012011.61874-1-mhun512@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Probe enables controller wakeup after the OHCI core marks controllers with RemoteWakeupConnected as wakeup-capable. Removal does not undo this, so the wakeup source can remain attached after driver unbind. Disable controller wakeup after removing the HCD. This issue was identified during our ongoing static-analysis research while reviewing kernel code. Fixes: a6eeeb9f45b5 ("USB: Update USB default wakeup settings") Cc: stable@vger.kernel.org Assisted-by: LLM Co-developed-by: Ijae Kim Signed-off-by: Ijae Kim Signed-off-by: Myeonghun Pak Acked-by: Alan Stern --- drivers/usb/host/ohci-s3c2410.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/usb/host/ohci-s3c2410.c b/drivers/usb/host/ohci-s3c241= 0.c --- a/drivers/usb/host/ohci-s3c2410.c +++ b/drivers/usb/host/ohci-s3c2410.c @@ -335,6 +335,7 @@ struct usb_hcd *hcd =3D platform_get_drvdata(dev); =20 usb_remove_hcd(hcd); + device_wakeup_disable(hcd->self.controller); s3c2410_stop_hc(dev); usb_put_hcd(hcd); } From nobody Fri Sep 25 08:46:01 2026 Received: from mail-qk2-f13.google.com (mail-qk2-f13.google.com [74.125.230.205]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 51E012EB0F for ; Tue, 15 Sep 2026 01:20:31 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=74.125.230.205 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1789435237; cv=none; b=Nx7RxxkjZjz/wbIoIhg+PkORhBBAOFJ1oGjy15RHApy+UO2KEArW94UccA3VnmptM92H0aHVTKhkIo3trOibIOvs8gFrCLD6utHsu/qTD3pOPBxsC+ChT2glTBF6DyI//4Smu0ZbwWH9ILOpXEYxxLFYEMpc4CXBShlEzsOcqTc= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1789435237; c=relaxed/simple; bh=CLoTbPNnFD7Nf/FWMZIj87k9uF5C+XkJTmib7IEKVno=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=rbJFafZGP8J4LLMRZ5vHQd4ATeLmkdoEOsHOlLxLbV3wOGa55sAgqAPMjFg6HJtHasBPjy0f6sSYHUd1Ja1Hypk/mTs1ERqef9uSHv2vev/aJRjBPk983dTNMSwxO08MT/Jt5syzncQ2LCECW2Aa1LS3Zn09+xHKgolN+d8Sv/c= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=LlKJnuek; arc=none smtp.client-ip=74.125.230.205 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="LlKJnuek" Received: by mail-qk2-f13.google.com with SMTP id d75a77b69052e-530e28a62abso43000971cf.1 for ; Mon, 14 Sep 2026 18:20:31 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1789435230; x=1790040030; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to:content-type; bh=qFEVv4dcy08X3Ik3HgrSf1qU8ho0jjZ5Mt4Ngu5dZIw=; b=LlKJnuekpTYOvLF203ixtRfg2YfTgXIfAJ6c8MOe/6akF3oOyTPXLxOpd5LPDdUTzD kbed14k/V33uMFqHASt5oScMev/oITKYdfuHSWSf04LhAOmUEQpdqIEtyW2gtvpYN2f6 0LLakiEQ6lWm4wQ27wV5KLYEZ11Z40lw4wuedXBpL3x29ilDR1Rz2DGbwqBnvR992XsY ETEg8e80fKMs8qZAd443y06Km0AHqyiGbjofe1hPcBMaD3FMbG0wYXRSiznBMT4nH/Xc f7ZnEN9MtNHwIK5ZqNmcdTRKFW1u+gQhBdG7sUMYPgqEQ1MU5lME+Hx3LhtZ2VIvhkyw SudA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20260707; t=1789435230; x=1790040030; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to:content-type; bh=qFEVv4dcy08X3Ik3HgrSf1qU8ho0jjZ5Mt4Ngu5dZIw=; b=DMdxa0c1NNGaO/TXFXRw0mXV1ZgpVxKeoQwD8dLDgb8yvt0HVJMiyHNHwfO0MQF2JO BtPMgiO2YojAtRiaF+IF6dNDv3u2WJFtTt5Gn6LKe7q9/iRzlvchK59K5ePv3cAXHo84 a7ru9DEhYt8YkMiH5F1rDvhxJFfGcjNyB4pOuNat0miYuWbRpUdis1DTT0jSQUHumjVv P5Kf8ulMFUprMOmOdin2f9sZValnFXqb4g0NbYhfdEcqJx2aDq1xVQLLGZznqplSFeAP ucIOIulwjD4sn/e3QDK8GGuHvKgeAf+U6rY5uQpmWX1a5gS/RNAxjW2IupyuEp+7vEkA CXqw== X-Forwarded-Encrypted: i=1; AKwUvBx7mvY2k20FbeCRVASxuA6hm+68BQE6PcvbStqmE3xxJTXZ0P97q++zpN4vflG6H7QOxVNJKqyUqSTuH7A=@vger.kernel.org X-Gm-Message-State: AFuF++khihfU3jmSVSbUsjja2OXzSBtzK4v3y4+TIfovf6WNJ5YXxb90 d4xRqojDQlk9Ln3KXKykv3enLxflpF/g/NR/N5w+GkwaRxrn0pgXnbQ= X-Gm-Gg: AYBFou0YUgfBOZA3Q+iNM/LTgGoVcfbzx6KxA9qK2wZolYK82GyBaV9kwrJ4Rsgq2Ns OiMTDp07c8mDzENQo72Xxw5GXphmKeFMWmk8s+dgfJHjSwLCSm7VeXK8G6efRyTxX7lteixKiUU Oh1nBC0ymprDFX9efobAF5tcV2CjVzsAfUcmjpSegqNi1HfJRqzk7H4HB3Vl7nrGZwR/cDarkgs ZSJgnYTFbvckRj/+MsIUd8Ghtu7avRfkEs0VNr+pVArPegvb2IF+HjXFjxIeuwMd5mmwbsnwiwl KOh7tVYzAMWaz0MP0qLNgNEeiOlgQn1Ued6b3zJTf1vrbjhHz5lMDc0d/dznD4G3GjzI8wC6Yfu oE7s0zRHL3M2cHgmFJwkGplPNDwAzdHBc4UZl9hLjxsr4E3lM8BLIjX0MrvBQSrsZm7jvOP4a7G /Ts7Q15Fll+HfXdaiI9QtBCSRNPLEueAkF5+yPfa6oYwRRJWVsXH2f+lQOYnd+TPR/Oa+osMJtW NMNbfFIDcYQho4irOUHXuHR3mtOPoyKSH9wx8E2+pFLqDj+LX0Edur5uk9a9UjtOkWHjpdfGYcR dkvqyiqKOK4CBu27AxowrUKOxG3TwysU6ue/u892vHVuVx+hDarGUrJCJqv9StynScBn9Q== X-Received: by 2002:a05:622a:1bab:b0:531:164:fa73 with SMTP id d75a77b69052e-5310d0005camr81499831cf.32.1789435230101; Mon, 14 Sep 2026 18:20:30 -0700 (PDT) Received: from 6e-wmo5420-02.ad.psu.edu.net (6e-wmo5420-02.ad.psu.edu. [104.39.213.233]) by smtp.gmail.com with ESMTPSA id 6a1803df08f44-9121a62b783sm91141946d6.23.2026.09.14.18.20.24 (version=TLS1_3 cipher=TLS_CHACHA20_POLY1305_SHA256 bits=256/256); Mon, 14 Sep 2026 18:20:24 -0700 (PDT) From: Myeonghun Pak To: Alan Stern , Greg Kroah-Hartman Cc: Krzysztof Kozlowski , Peter Griffin , Alim Akhtar , Patrice Chotard , linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-samsung-soc@vger.kernel.org, stable@vger.kernel.org Subject: [PATCH 3/4] usb: ohci-spear: disable controller wakeup on removal Date: Mon, 14 Sep 2026 21:20:10 -0400 Message-ID: <20260915012011.61874-4-mhun512@gmail.com> X-Mailer: git-send-email 2.47.1 In-Reply-To: <20260915012011.61874-1-mhun512@gmail.com> References: <20260915012011.61874-1-mhun512@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Probe enables controller wakeup after the OHCI core marks controllers with RemoteWakeupConnected as wakeup-capable. Removal does not undo this, so the wakeup source can remain attached after driver unbind. Disable controller wakeup after removing the HCD. This issue was identified during our ongoing static-analysis research while reviewing kernel code. Fixes: a6eeeb9f45b5 ("USB: Update USB default wakeup settings") Cc: stable@vger.kernel.org Assisted-by: LLM Co-developed-by: Ijae Kim Signed-off-by: Ijae Kim Signed-off-by: Myeonghun Pak Acked-by: Alan Stern --- drivers/usb/host/ohci-spear.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/usb/host/ohci-spear.c b/drivers/usb/host/ohci-spear.c --- a/drivers/usb/host/ohci-spear.c +++ b/drivers/usb/host/ohci-spear.c @@ -103,6 +103,7 @@ struct spear_ohci *sohci_p =3D to_spear_ohci(hcd); =20 usb_remove_hcd(hcd); + device_wakeup_disable(hcd->self.controller); clk_disable_unprepare(sohci_p->clk); =20 usb_put_hcd(hcd); From nobody Fri Sep 25 08:46:01 2026 Received: from mail-qv1-f47.google.com (mail-qv1-f47.google.com [209.85.219.47]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id E1F3A33C1AD for ; Tue, 15 Sep 2026 01:20:37 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.219.47 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1789435249; cv=none; b=gnVdzEnvw5JTBS6mLLVNnbqjgG064qcI5QHs3GCrUKtVSqgk74yCXnxn7GI/sQFnGF1ZHueHvEgcQQSYUatWbB8UtnQvVPris0NEjL2/8zAN5zEcH/VQjy9H9qcOi4IeFjduBZDtts2DRwp9crHwJfcAI9gfUM51l2ippWwEepg= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1789435249; c=relaxed/simple; bh=cSt7jQUGq64ZD/zrBvItYaOU0WRDoEfcG5mlUjJSbrI=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=Oh4crdb2YJvzSaN3kVO/jOPGuUGX0fY+a0gMU44DLl2E2xTIk0nFTk952dAmHxISvY5xR6oCV+G1GZ/+ghNHeWBMpm2XNyLRsfN2nCAThy6D6woI4WUZFjajw6vA1IyJhlY/UcvkxotWWujN6SYfoibvWP9ri8SRt6d7b0e5zJo= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=RfcC+YrX; arc=none smtp.client-ip=209.85.219.47 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="RfcC+YrX" Received: by mail-qv1-f47.google.com with SMTP id 6a1803df08f44-90cc64570deso4992256d6.0 for ; Mon, 14 Sep 2026 18:20:37 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1789435237; x=1790040037; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to:content-type; bh=OmgxL+YzDrrZHo0jFAYUF9npAPr+/wsk6K1vfZ01BB4=; b=RfcC+YrXivdXRHIpt5VoSMDzj1Ea94+c0Cu2S05YGW4cJV4EhiBzwroLjL0BnPN4wM f2E2RP1VNZpwHT5XuCWXiXU30/LBxVtwpSoZpXg4sWOr6rq7SR7VC/+Dw7iAP245UaUY bb43GOcdPGhenirAnPEqQ5IQekysDQ15/vv3lIqOE8L0lILS1nk8NX7NO/QloQuyYbqS F5UDQLh1phEJojodbvg4NDEOicB+X+75/AgJCR0xYeEz4YKK9lgQTFZRwlNJnPtli0lD jiUkgRPwgUJrd1GpYVwt0fX6RsusdJXE/dl+8MizIZN5jCkpBE697qDExF5IJkvLZp74 R68w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20260707; t=1789435237; x=1790040037; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to:content-type; bh=OmgxL+YzDrrZHo0jFAYUF9npAPr+/wsk6K1vfZ01BB4=; b=uWciOsQlgAQTA//vVL0TykXagd0FKL0JdEQJAJxUQ00geJyc+1KaOv6coXBlIdk9bD SoRcKlzsZlS26XAa27Brj18rH9FfGOJFxUmR96DfOIB1SsbLpkYnkzfytRxWRqpve7dd FmxHt5hNL7QVrH8GV2OouoZKtRMgLpjutR3ijhuo4Q/B+V8L0qpiuo5P+0/xajWz2MdJ K9SqoEZJqaToQf0FP036Xv/AK/vK+EdTEakzquQgUl+8jGeJfyLyrWmfNk9sYNaE++Ed 6gEJLTairNcoxaSPsjZI4U5xiqf/89dGvgmpAuyjy4QJEvWSH32YzXKFwSoxCCCeri1q u4Fw== X-Forwarded-Encrypted: i=1; AKwUvBzAXOu4TlDY8CpZUxiPK8MtW0ghq8QPSJEfcU92rOHVjH/EpP7TfDcTPCEcFjmjcqOonczLcl3sBnJlq9M=@vger.kernel.org X-Gm-Message-State: AFuF++l2oDxVLU9EpOqL6dDhPnVpUIvjfefLydx2TXy1qbjYMZ+Fy1jU r1xBtJlBIgR+Q8B1Oji0m9WF/POiEWuuFx8YFtwuB28tUMUMP5rz5fE= X-Gm-Gg: AYBFou3vGA/GwfdUrrDXpQ6m/Rc51hj7KHU146eD0OBM9M3unTyLpULfd9ZLlK1ayAh vvbDKg3YmgK9uUg14tAzN5vDp32AHjk6C6Q/ojU6dbvd7XlTTjZJMguBcZCGLuIbZwVlKwAm+Ll 1GBm4K+DGXqmWAObLzuXzMluCyDmThjrH0LfeItF0FEVAD3GH5C0sWTJ5udqnYWsvACLqH/gpir 3Jx0D+lYXA6l8Wr76kDcTm8z1XNjw0rg/+ith8JGG3jJBIW7a4vcNZUm9CsieBfoQT7QYyb4T05 KYL+pwPUs/8RpLaDAwIQoejsDgCN1kXnMXkxj8EUPBkiBkz8RMsZ/Kakqf/mT1qcGLPff3wfaBT UB7ltUvvKnRLgoElXWewMdp2oJQRmhsBXCmLZto4LjTtl/8WRDI3OyHLvpooMm32gjE8bkJwFyF iqnn9Iu/+w35hSTwi8LGpOJ+V02ggyDh/vb6kChQU3fNaHosDvy7p5J69mtZU5Rg6UG35JoIzCP TZ5NRDXrAhdF3KeTalrEWUeMbnnlf8oaX1oNnRwDbKl+nDyynGTuu+cjK/HqlSzo6h37/2M24sT 0HJXNUV+zIrHOovDhSAC1Fa31Rsig2j+4iB3LT+3eeQQ6RbNFMU7XMpBBtiq8Sh817P08A== X-Received: by 2002:a05:6214:4383:b0:910:42f3:958e with SMTP id 6a1803df08f44-9123441de5dmr26302696d6.27.1789435232163; Mon, 14 Sep 2026 18:20:32 -0700 (PDT) Received: from 6e-wmo5420-02.ad.psu.edu.net (6e-wmo5420-02.ad.psu.edu. [104.39.213.233]) by smtp.gmail.com with ESMTPSA id 6a1803df08f44-9121a62b783sm91141946d6.23.2026.09.14.18.20.30 (version=TLS1_3 cipher=TLS_CHACHA20_POLY1305_SHA256 bits=256/256); Mon, 14 Sep 2026 18:20:30 -0700 (PDT) From: Myeonghun Pak To: Alan Stern , Greg Kroah-Hartman Cc: Krzysztof Kozlowski , Peter Griffin , Alim Akhtar , Patrice Chotard , linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-samsung-soc@vger.kernel.org, stable@vger.kernel.org Subject: [PATCH 4/4] usb: ohci-st: disable controller wakeup on removal Date: Mon, 14 Sep 2026 21:20:11 -0400 Message-ID: <20260915012011.61874-5-mhun512@gmail.com> X-Mailer: git-send-email 2.47.1 In-Reply-To: <20260915012011.61874-1-mhun512@gmail.com> References: <20260915012011.61874-1-mhun512@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Probe enables controller wakeup after the OHCI core marks controllers with RemoteWakeupConnected as wakeup-capable. Removal does not undo this, so the wakeup source can remain attached after driver unbind. Disable controller wakeup after removing the HCD. This issue was identified during our ongoing static-analysis research while reviewing kernel code. Fixes: d115837259ad ("usb: host: ohci-st: Add OHCI driver support for ST ST= B devices") Cc: stable@vger.kernel.org Assisted-by: LLM Co-developed-by: Ijae Kim Signed-off-by: Ijae Kim Signed-off-by: Myeonghun Pak Acked-by: Alan Stern Reviewed-by: Patrice Chotard --- drivers/usb/host/ohci-st.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/usb/host/ohci-st.c b/drivers/usb/host/ohci-st.c --- a/drivers/usb/host/ohci-st.c +++ b/drivers/usb/host/ohci-st.c @@ -235,6 +235,7 @@ int clk; =20 usb_remove_hcd(hcd); + device_wakeup_disable(hcd->self.controller); =20 if (pdata->power_off) pdata->power_off(dev);