From nobody Fri Sep 25 12:05:54 2026 Received: from mx0a-0002e601.pphosted.com (mx0a-0002e601.pphosted.com [148.163.150.75]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 11EFD47D473; Tue, 15 Sep 2026 09:56:11 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=fail smtp.client-ip=148.163.150.75 ARC-Seal: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1789466174; cv=fail; b=JWQt7rX9RSXTGI7QG+P7YLyjLG2Zuwg4PLuSGH1ypvVtME7OKtC/2d2beVDUtekABjpG18NH2DANEBoX+p/xNtHaVgBpbDHYFLL4qjpdDyGWtZu91JADpNU88o9eqpavaBimobONXGSH3G95ixV9EEw1KP4ofEfRi1ulnWQ3QTk= ARC-Message-Signature: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1789466174; c=relaxed/simple; bh=+itU1zoEDblt4BeOHHLj6FPDb3FT0saSeGIkQ62EVh4=; h=From:Date:Subject:MIME-Version:Content-Type:Message-ID:References: In-Reply-To:To:CC; b=DzpzC23yWkUUA4xniETRriMS3aefisIJaW+r9IeEkZJz65sbBm33o1D3TeyGsxzXv3Lwqn6vq6zPfnMmGAySdR9+gjZEA8nHMVaCkbJEUpJQ89/PmPBa75h1In2kXOV53gWQdQWbwRRYb+dyIKOZv0moF8gUbQMqbj7boMugakk= ARC-Authentication-Results: i=2; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=ti.com; spf=pass smtp.mailfrom=ti.com; dkim=pass (2048-bit key) header.d=ti.com header.i=@ti.com header.b=o4xPEE5G; dkim=pass (1024-bit key) header.d=ti.com header.i=@ti.com header.b=WUWQR+dD; arc=fail smtp.client-ip=148.163.150.75 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=ti.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=ti.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=ti.com header.i=@ti.com header.b="o4xPEE5G"; dkim=pass (1024-bit key) header.d=ti.com header.i=@ti.com header.b="WUWQR+dD" Received: from pps.filterd (m0380145.ppops.net [127.0.0.1]) by m0380145.ppops.net (8.18.1.11/8.18.1.11) with ESMTP id 68F9esbd3889298; Tue, 15 Sep 2026 04:56:08 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ti.com; h=cc :content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s= proofpoint-05-2026; bh=L0ZmU+v6fEYxeuTXwR3Xj8jsgCDa72UDoo98cqKF9 Ro=; b=o4xPEE5GS3OJrVIc0YxJKp+dAPXBIElC+Sw4dsPVxoZ2KqbyTy+i0szdw fNYmjaaXXBaVPe9IvneHBOfv9q7RIZtm2DfI3zQU2G635qZ97eTRKvctWkQdgBRD WnSpUx1QQutou/zXmMMuMYc9Wyi87a7kbRAGve5Fbzzj4Lr9ITny4ZY4OCFUQgwP Fd0tmTpuPcEFFNUYyeGvc9lsLtf6o4zTEzjVXgToXHp49/60KDsrSd2+OCg/Js6x E8FC2eHljjrKF+jY7lT59QVJcXqxv6/tizWtHhes5qhX0w7AIOxBZogpfL1eWcE7 NujGYlHR0ZbNyeF7nWJurLpMWCyhA== Received: from sj2pr03cu001.outbound.protection.outlook.com (mail-westusazon11012027.outbound.protection.outlook.com [52.101.43.27]) by m0380145.ppops.net (PPS) with ESMTPS id 4gppxsm9f2-1 (version=TLSv1.3 cipher=TLS_AES_256_GCM_SHA384 bits=256 verify=NOT); Tue, 15 Sep 2026 04:56:08 -0500 (CDT) ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=OJfFwXxJIWnGfmdV1cE8nMuP5fXLFmImOW0ewatr5Xc/5cIQP4huyS3gRSIaxnTekMUuPxcDxb3sxNd19AXNI2rgnEFH5SfnX+LsN92Brbeo9vKfBJKhEh6aj/awUGtEgu+2e5F76Yp9Nfc5nhusQA9VIL2ml/0ICTRDL/y+OpxsR2AdqvdjITdGcMv7Ya/s0PijBhE9Prr5VbaT2Xx8f2WWgZqQc6gmZ7XVe3ZlYYS9ADFGs3N8TYrjgDDKQcBVRLLidASmeHErnVGI9PulYSpkonmnVxF1t8wGHfCq+Ttad7rF58EuA63/ja/7YYQTsFFM1/YO8WBMJS69d7BqTg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=L0ZmU+v6fEYxeuTXwR3Xj8jsgCDa72UDoo98cqKF9Ro=; b=LsqpXLmfWt9I0jcjoc8L1Bzf64i2poMIeKp2oAulomebDyPxVMMyE3SjaUEB9HUt3xGGQ2IaFg4uVoHirA3Wi9xMPTTDRERhPtLo6V1spkNuF74tM/GSdFPQtQmOWtdiUPazzu57yjkBh7FE6F9zGLL+V5PVB0l/TCQ2HdCIGqARmcInHfRSlwrzgOYJv7T6xpJnvQQIq89lBrWcCs5OciA+3kQlOuxVnfkDIrq6yOfmXuHyI44F5j2K+0UUbAW0MYdJCUNRTqYQW4oeWUJH6L1DZ1yivMkUApKu2VjbZqspWftxm5pC3MORKhYogbptnYGiJ+Kui8w94/alWUDH7g== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 198.47.21.195) smtp.rcpttodomain=vger.kernel.org smtp.mailfrom=ti.com; dmarc=pass (p=quarantine sp=none pct=100) action=none header.from=ti.com; dkim=none (message not signed); arc=none (0) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ti.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=L0ZmU+v6fEYxeuTXwR3Xj8jsgCDa72UDoo98cqKF9Ro=; b=WUWQR+dDZmwHAQJrocPy/fAjENVvG1q/EjPgHsZ8vgCmCTb61E+V6TCIS+XkIczNxdCS00RvVibygYLPHYpVGjIh9i+Uh5C0mPsupXmPlqMWXLz/GvhhXkAcQ1/gATzxX2y+pWZSCrw/Fn2bdZpwD+/Re+0LIcvMP758sCg3feg= Received: from SJ2P220CA0006.NAMP220.PROD.OUTLOOK.COM (2603:10b6:a03:5da::19) by SA1PR10MB7853.namprd10.prod.outlook.com (2603:10b6:806:3ac::7) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.21.428.9; Tue, 15 Sep 2026 09:56:02 +0000 Received: from MWH0EPF000C6187.namprd02.prod.outlook.com (2603:10b6:a03:5da:cafe::67) by SJ2P220CA0006.outlook.office365.com (2603:10b6:a03:5da::19) with Microsoft SMTP Server (version=TLS1_3, cipher=TLS_AES_256_GCM_SHA384) id 15.21.428.9 via Frontend Transport; Tue, 15 Sep 2026 09:56:02 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 198.47.21.195) smtp.mailfrom=ti.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=ti.com; Received-SPF: Pass (protection.outlook.com: domain of ti.com designates 198.47.21.195 as permitted sender) receiver=protection.outlook.com; client-ip=198.47.21.195; helo=flwvzet201.ext.ti.com; pr=C Received: from flwvzet201.ext.ti.com (198.47.21.195) by MWH0EPF000C6187.mail.protection.outlook.com (10.167.249.119) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.21.428.7 via Frontend Transport; Tue, 15 Sep 2026 09:56:01 +0000 Received: from DFLE202.ent.ti.com (10.64.6.60) by flwvzet201.ext.ti.com (10.248.192.32) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.2562.45; Tue, 15 Sep 2026 04:55:19 -0500 Received: from DFLE207.ent.ti.com (10.64.6.65) by DFLE202.ent.ti.com (10.64.6.60) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.2562.45; Tue, 15 Sep 2026 04:55:19 -0500 Received: from lelvem-mr06.itg.ti.com (10.180.75.8) by DFLE207.ent.ti.com (10.64.6.65) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.2562.45 via Frontend Transport; Tue, 15 Sep 2026 04:55:19 -0500 Received: from uda0497581-ant.dhcp.ti.com (uda0497581-ant.dhcp.ti.com [10.24.51.159]) by lelvem-mr06.itg.ti.com (8.18.1/8.18.1) with ESMTP id 68F9tB7p3000901; Tue, 15 Sep 2026 04:55:16 -0500 From: Manorit Chawdhry Date: Tue, 15 Sep 2026 15:25:07 +0530 Subject: [PATCH 01/30] crypto: sa2ul - remove dead code Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-ID: <20260915-b4-upstream-sa2ul-cleanup-v1-1-57ab34e97162@ti.com> References: <20260915-b4-upstream-sa2ul-cleanup-v1-0-57ab34e97162@ti.com> In-Reply-To: <20260915-b4-upstream-sa2ul-cleanup-v1-0-57ab34e97162@ti.com> To: Herbert Xu , "David S. Miller" , Keerthy , Colin Ian King CC: Andrew Davis , Pratham T , "Kamlesh Gurudasani" , Udit Kumar , , , "Manorit Chawdhry" X-Mailer: b4 0.15.2 X-Developer-Signature: v=1; a=ed25519-sha256; t=1789466112; l=1849; i=m-chawdhry@ti.com; s=20231127; h=from:subject:message-id; bh=+itU1zoEDblt4BeOHHLj6FPDb3FT0saSeGIkQ62EVh4=; b=1lZ8r46PEmSthrL8EO0qvWW1P7TdcYirME8U0YySUDDjId3hPR5LHcwOTBABNPwV5cVuqIl4k VhYeB9epK9MAVx8qcHo9KszDxmI1C/jpwLc9lEauYEB9BNeGtTBfYIA X-Developer-Key: i=m-chawdhry@ti.com; a=ed25519; pk=fsr6Tm39TvsTgfyfFQLk+nnqIz2sBA1PthfqqfiiYSs= X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: MWH0EPF000C6187:EE_|SA1PR10MB7853:EE_ X-MS-Office365-Filtering-Correlation-Id: 2c52e2f7-90f0-4393-fed2-08df130f8c7d X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|36860700016|23010399003|376014|82310400026|1800799024|10067099003|56012099006|18002099003|22082099003; X-Microsoft-Antispam-Message-Info: FrpEyHFCNivwvdIT40PJwaAqqySkxeOXVtz7NsVPV4UywyuwTyNS9uXDnjmcX4UKO2cszl2Nfzp0E6a97fimgtnsbkyewc0oOrLoDjUbWh7IxlxgZpe/t1c8QuiEOphttbrdyNGk1K4Sc4dqOhfoPdYiJ7Yd3xLkNJr0hyCQPRf+sjG5xiJFgkR7pDhMeHYUfken6KktYL6BUv8cJPrfGEHlHVf/7S11Ie6J/OPE9BDkjLLInQ7t7ECCpehoHfa44IQAm9vTAiZlBZq2kJm9HB8mkf2jvobkpMWmidOz5ukKUq7kBH4wDKs2veInCIF+LH3091lwfcgg3gSgFOma9Qr63KdHUFPfOFd9HerLF8mNUKFpWMPlBpHMiMe1d83NXl0HCr4WIEVKFA11oMyt7k17QXbqiyu6WeWN0RRRweknqBu99NWNTjRR15wpX0jA1D1SLTf0lSpyNXlQLHgGI8cW/ImOu8mGknM6usDuCCbsj/37IUA9LMCPpFFwPSduTPuZqmEqn+skBHSRJ4SdMrSLNIoMSeXUOM93JUvqjYfV+f7Irjb8g24zp6itQY8Pvh9Z8tL8tveM2U7BRo/C8D3rgLwDSuW0+VRUw2O/JflbIegSSrz2psVTSb0PimJ2ab85edFZi6doMcLzb+WPI50vuuVV82vXqcJprqjJsbry1TG2vwX8AKv08MgihAdHCYkrN4b6zw0deC0VSyL8+g== X-Forefront-Antispam-Report: CIP:198.47.21.195;CTRY:US;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:flwvzet201.ext.ti.com;PTR:ErrorRetry;CAT:NONE;SFS:(13230040)(36860700016)(23010399003)(376014)(82310400026)(1800799024)(10067099003)(56012099006)(18002099003)(22082099003);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: XNbf+YnevXjmbORc3gplxzDtb1U33VNvPYCWN0qP6E9uzFw86uacW1cI95wPm7A0E2ZJ8aFSVjb59+C82YlInkQ1Ro2bdw3q7RY38EZwAx1yMdtobNmg5mHBHv/zd8UaZht6ulFQ4cV4/4D+LUI4XtqHFPu8ocspFrGwSmej2kjLx2dguvtA3sZ0ZM5o0Cog5p1psYp2T7RG3p8eGB6RloMiIeIQIh6VSksOGFG8q8pl+ip0IGp8qTVhsA3vG4HCifvAGPiR8xQmyviX2824+RNznqD/75edMMX9rsDAE9yRr7yL0MQPh9EBhuEn/NPYoLRevcUGO6u6Z9KWXcmCE3O7XgmdA23913WToIKMhtwS0Ee4e5NVaoIQlBETxdpzPU1ZWHCN6DmmE8iKc2NQdIM3gYjajwrWH9Q3y6mIQdDjrDQ9qs7xo40qvZNR30ZG X-Exchange-RoutingPolicyChecked: tzKo0ipdPzDykCfqRkQWPRCSNWxXPT52VHmCLL8M1yRbzbXjEtuolKAMD2PLz/XOKPGz2ICz5HyaNkniVHyzfg136ww3VXJiv0pFwOS6gCuxwBBj7DAe/I6pje2gKv4oWPa33IyhuWuUfIfzzzOm/DgFI3bzoQooPsLwMBW7J43bBLH6Fp5G2NjE0Teuj18oNwfrFbHFO7ktCP7Y7CIjYBho5AbcmRpfuVDRq2aRKwG+yS/l3k+5KEph3TMXujKU+n5Rp753307APXAwBwGT2HhQwhNcELJbh44iULGrqf8a72KXAw1Grsp3AurKOjybMcqKyyQlkOAgAG8r1dZ/Vw== X-OriginatorOrg: ti.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 15 Sep 2026 09:56:01.1172 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 2c52e2f7-90f0-4393-fed2-08df130f8c7d X-MS-Exchange-CrossTenant-Id: e5b49634-450b-4709-8abb-1e2b19b982b7 X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=e5b49634-450b-4709-8abb-1e2b19b982b7;Ip=[198.47.21.195];Helo=[flwvzet201.ext.ti.com] X-MS-Exchange-CrossTenant-AuthSource: MWH0EPF000C6187.namprd02.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: SA1PR10MB7853 X-Proofpoint-GUID: KOrSCsyK9pcfdui8JLTjFhSsg0TvsqIq X-Proofpoint-ORIG-GUID: KOrSCsyK9pcfdui8JLTjFhSsg0TvsqIq X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwOTE1MDE0MyBTYWx0ZWRfX7jW+mitkqxfj XHl0Cv0lhh8YZSXxlZPReDLQlzuY9PjWxQIRZUs1LJns0fX3w9fFP2A4RttsL7+b86XZoQYmOyc qBoiMLJr5LLoDSAqe9F3f9FlzkBfY4UDABSZJryXi3RAK4tuwaGSgpgavpfpAUQKrYY1kUY+48H mQ68CKhI6ad+bHRBKjOCae5pokEQVUqSxeFF5YDZbyKnjbdhm/iVsgYgRqfrU0a/pooPj2mPn53 91noDRdcdGJDVX/ezA2KDnviMKfM92JvZFPkTuEbDmBg1kqzMU/jgmmT1BxNWzqli0FoFhxCqk5 NFlpHEJaqCAbPC1XLc7q21Pwr0hABKoCpBxhzJW/jobsf/mbOnPYHSi4Yb4PZ1UEwMTyYrYetNl //7H+o6dWH+zqwyE62EbQC6EEeriztzxovTqmrGlNViozuwVmM5fEmmQoOxwW4JyeU3pb16ZyuD nhyXmnd0arSfTRk1jjw== X-Authority-Analysis: v=2.4 cv=bYP+w+PB c=1 sm=1 tr=0 ts=6aa91638 cx=c_pps a=8g4i1X1tkAMDiabECo8pFg==:117 a=tJyPKKxUohctrY4NYmUjkA==:17 a=6eWqkTHjU83fiwn7nKZWdM+Sl24=:19 a=IkcTkHD0fZMA:10 a=VdqzKS8jKosA:10 a=V5UXEbMT0ywA:10 a=VkNPw1HP01LnGYTKEx00:22 a=Z8NIEmU8O1QQgoT56wFK:22 a=gO1vWkAQAl3rybz1DQOp:22 a=sozttTNsAAAA:8 a=tq7M4MuTrJI18TnFGxsA:9 a=QEXdDO2ut3YA:10 X-Proofpoint-Spam-Info: AW1haW4tMjYwOTE1MDE0MyBTYWx0ZWRfX/OXana9qPEKc IVe6TuGgAru0Hw6M5X/yZZJ0z5tRXnOkF3puR6ucK7p13Dva4AfZHSFniYke3K/dGhFRzv+Yalp hsNVGg/Z4ivIJkvExbY2boOWLIJ2cRY= X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1176,Hydra:6.1.134,FMLib:17.12.100.49 definitions=2026-09-15_03,2026-09-14_02,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 clxscore=1015 lowpriorityscore=0 priorityscore=1501 impostorscore=0 adultscore=0 suspectscore=0 phishscore=0 malwarescore=0 bulkscore=0 spamscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2609040000 definitions=main-2609150143 The following codepath is not used at all as SA_CMDL_UPD_AUTH_IV and SA_CMDL_UPD_AUX_KEY are never set. Remove it. Assisted-by: Sisyphus:claude-sonnet-4-6 Signed-off-by: Manorit Chawdhry --- drivers/crypto/sa2ul.c | 24 ------------------------ 1 file changed, 24 deletions(-) diff --git a/drivers/crypto/sa2ul.c b/drivers/crypto/sa2ul.c index 0dce2b98886a..f7e4f58c02c2 100644 --- a/drivers/crypto/sa2ul.c +++ b/drivers/crypto/sa2ul.c @@ -41,8 +41,6 @@ #define SA_CMDL_UPD_ENC 0x0001 #define SA_CMDL_UPD_AUTH 0x0002 #define SA_CMDL_UPD_ENC_IV 0x0004 -#define SA_CMDL_UPD_AUTH_IV 0x0008 -#define SA_CMDL_UPD_AUX_KEY 0x0010 =20 #define SA_AUTH_SUBKEY_LEN 16 #define SA_CMDL_PAYLOAD_LENGTH_MASK 0xFFFF @@ -551,17 +549,6 @@ static void sa_set_sc_auth(struct algo_data *ad, const= u8 *key, u16 key_sz, } } =20 -static inline void sa_copy_iv(__be32 *out, const u8 *iv, bool size16) -{ - int j; - - for (j =3D 0; j < ((size16) ? 4 : 2); j++) { - *out =3D cpu_to_be32(*((u32 *)iv)); - iv +=3D 4; - out++; - } -} - /* Format general command label */ static int sa_format_cmdl_gen(struct sa_cmdl_cfg *cfg, u8 *cmdl, struct sa_cmdl_upd_info *upd_info) @@ -670,17 +657,6 @@ static inline void sa_update_cmdl(struct sa_req *req, = u32 *cmdl, cmdl[upd_info->auth_offset.index] |=3D FIELD_PREP(SA_CMDL_SOP_BYPASS_LEN_MASK, req->auth_offset); - if (upd_info->flags & SA_CMDL_UPD_AUTH_IV) { - sa_copy_iv((void *)&cmdl[upd_info->auth_iv.index], - req->auth_iv, - (upd_info->auth_iv.size > 8)); - } - if (upd_info->flags & SA_CMDL_UPD_AUX_KEY) { - int offset =3D (req->auth_size & 0xF) ? 4 : 0; - - memcpy(&cmdl[upd_info->aux_key_info.index], - &upd_info->aux_key[offset], 16); - } } } =20 --=20 2.43.0 From nobody Fri Sep 25 12:05:54 2026 Received: from mx0a-0002e601.pphosted.com (mx0a-0002e601.pphosted.com [148.163.150.75]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id C4DAC47F3C8; Tue, 15 Sep 2026 09:56:12 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=fail smtp.client-ip=148.163.150.75 ARC-Seal: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1789466175; cv=fail; b=Yr37oypmRQ/dwBVZ5Bv764CnUjzm83jT+ZrEiuZVrZfpDB9Ug2FS2H78ujC4Q0eAlp8k9Y/0pnwfTef7D8kO1qmWG+LJg5UqeAD+h1FV+DyRiGLj7XWwy+IS2VjpiSR6G4kSS9VQf4kH3FaBpQhtnIi3QALJ95FoVx0up7oSI90= ARC-Message-Signature: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1789466175; c=relaxed/simple; bh=JbDOFfCx/9J1eG2894Q98RVIKK5wZoZYzMTcOlINDcg=; h=From:Date:Subject:MIME-Version:Content-Type:Message-ID:References: In-Reply-To:To:CC; b=GEgbk5Jn0tdAU0klToBrRxHdEXeO9WeVk+Sl8KG7dythXD+2oxmNgpNIterPIyzRNrGIxYjQcOuQ7iZTGcpA6VmW8fse+vxBDD2YAz/Su4/poSn0IFAMxMYn/teE/bGGdHLDnTr1Q/C1ZfSNPcxq7PIZsOV6eAeH1qHbHdgnIPc= ARC-Authentication-Results: i=2; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=ti.com; spf=pass smtp.mailfrom=ti.com; dkim=pass (2048-bit key) header.d=ti.com header.i=@ti.com header.b=hkXiFl2k; dkim=pass (1024-bit key) header.d=ti.com header.i=@ti.com header.b=Ii5xGbZK; arc=fail smtp.client-ip=148.163.150.75 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=ti.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=ti.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=ti.com header.i=@ti.com header.b="hkXiFl2k"; dkim=pass (1024-bit key) header.d=ti.com header.i=@ti.com header.b="Ii5xGbZK" Received: from pps.filterd (m0384305.ppops.net [127.0.0.1]) by m0384305.ppops.net (8.18.1.11/8.18.1.11) with ESMTP id 68F9ejRQ1480545; Tue, 15 Sep 2026 04:56:08 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ti.com; h=cc :content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s= proofpoint-05-2026; bh=G8bfsZEiry1Yq7cwt7N0Gs7S8uGMDmazhrxnv7ORb Mk=; b=hkXiFl2k3VPOx5pVdwUaAGlbUvf4uvCUB8NluzCX7p7IMR1VjtHfjErrE aSoi3jvWztP1jD+KYuCar6QCYIj7YFItXf46tMdlH1BS2iKQYyc9q5MxmXJ3X2Ay ACkbzj9to6iiHaqkrb/TO5b97iqo2ihSCPJWe0VtO47qLuGtfsxA3l7PnnWCOG/0 RIHep/aNYjGdkVzSKOvA/w8X5fjC9FlMi1iGC00Jp9KnkZRbaofl8DE74sDreMnq nJjSG7KZ0apwCW/GN3eTpSrD4jYZXxJxLCTp8TL5pkkUMouK3BjwU4vuIL+5iKvS Df+CdLAQWLIWwiqip9KFW/u2rA74Q== Received: from ch5pr02cu005.outbound.protection.outlook.com (mail-northcentralusazon11012028.outbound.protection.outlook.com [40.107.200.28]) by m0384305.ppops.net (PPS) with ESMTPS id 4gpvpa2hyp-1 (version=TLSv1.3 cipher=TLS_AES_256_GCM_SHA384 bits=256 verify=NOT); Tue, 15 Sep 2026 04:56:08 -0500 (CDT) ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=ZsMxtVRmnUBJR2lnvNa42TihxdagLhG3Uw5enMR57zzdkqlxVRtJqV4DsaNGHVIhGpZIRU9jWlryTUi9NlZ0wikV01e/TbkPxKBPbpiJ7jSK2RZCS7AAhdIA7hclWYN9lSRkv5mf2Y2yPRifOGMU1Wm7ujSMXiXSs4rWf2cyrxa3XVVITnanpS5QYtoisth9qdS44wu3S2yeoJDRDUfde1ORY512S74oeHwin4yMAsILufIKRjzqNUdVdmu9OBxMODSj6SKCZyu+p4DQEH69K4nQj3W4Y2wFNXbuoJ3YPLdgoF6K1oKNcxJi/Pmuz8voZE901WAyjDQF7UGhUTXQdA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=G8bfsZEiry1Yq7cwt7N0Gs7S8uGMDmazhrxnv7ORbMk=; b=GdRlAGHPReOw2XlWt8Gcr0vMcMPK5u1gvkatoyDepr4kML9u5f4R2bryJY5lhRbmAwh0Jy4pmaOcQN9cFKNScC6FqLKNIy0ZFjhM+D+I9FszBgu/nbIolyQmWVVfdAtp0b31mFW4O0cMkdsMTkhhaHEEYPNJ+QYHL2XgUwD5vlfxDuauw5sXFZKxsqkJmfnQE9/aEjX/B4zIv3t3nulZg4YFI5q4V0+Y9e8UjKZxYwhINGOYUqZy9YJDQ9k4/fSmR2RRMdcTUMr3H+x/kbD/cDqC8M3Zss+0t11UxC8MKTQQcxCw5lZ+IYuMnSvheOBsgv2GvL68rqaEFdCoRsOiyQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 198.47.21.195) smtp.rcpttodomain=vger.kernel.org smtp.mailfrom=ti.com; dmarc=pass (p=quarantine sp=none pct=100) action=none header.from=ti.com; dkim=none (message not signed); arc=none (0) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ti.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=G8bfsZEiry1Yq7cwt7N0Gs7S8uGMDmazhrxnv7ORbMk=; b=Ii5xGbZKReaOORlav26M9WUmtBrcpkgUl7lJ1fOjMWRVxeKW42zQ6i195LioQIIVmFbRyn4AjL7ys1YuIzAv9ZQylzqH/6H4Ag5qTGslqhjUfa4TaEvC7wZYA5YtSfFoMAxKNmm5NiVAgG6EYf0M2cEliQ/++GsOpqSDki/GXgI= Received: from SJ2P221CA0012.NAMP221.PROD.OUTLOOK.COM (2603:10b6:a03:5db::16) by DM3PPF424CCE606.namprd10.prod.outlook.com (2603:10b6:f:fc00::c23) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.21.428.9; Tue, 15 Sep 2026 09:56:06 +0000 Received: from MWH0EPF000C6186.namprd02.prod.outlook.com (2603:10b6:a03:5db:cafe::2b) by SJ2P221CA0012.outlook.office365.com (2603:10b6:a03:5db::16) with Microsoft SMTP Server (version=TLS1_3, cipher=TLS_AES_256_GCM_SHA384) id 15.21.406.12 via Frontend Transport; Tue, 15 Sep 2026 09:56:05 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 198.47.21.195) smtp.mailfrom=ti.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=ti.com; Received-SPF: Pass (protection.outlook.com: domain of ti.com designates 198.47.21.195 as permitted sender) receiver=protection.outlook.com; client-ip=198.47.21.195; helo=flwvzet201.ext.ti.com; pr=C Received: from flwvzet201.ext.ti.com (198.47.21.195) by MWH0EPF000C6186.mail.protection.outlook.com (10.167.249.118) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.21.428.7 via Frontend Transport; Tue, 15 Sep 2026 09:56:03 +0000 Received: from DFLE205.ent.ti.com (10.64.6.63) by flwvzet201.ext.ti.com (10.248.192.32) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.2562.45; Tue, 15 Sep 2026 04:55:22 -0500 Received: from DFLE208.ent.ti.com (10.64.6.66) by DFLE205.ent.ti.com (10.64.6.63) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.2562.45; Tue, 15 Sep 2026 04:55:22 -0500 Received: from lelvem-mr06.itg.ti.com (10.180.75.8) by DFLE208.ent.ti.com (10.64.6.66) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.2562.45 via Frontend Transport; Tue, 15 Sep 2026 04:55:22 -0500 Received: from uda0497581-ant.dhcp.ti.com (uda0497581-ant.dhcp.ti.com [10.24.51.159]) by lelvem-mr06.itg.ti.com (8.18.1/8.18.1) with ESMTP id 68F9tB7q3000901; Tue, 15 Sep 2026 04:55:19 -0500 From: Manorit Chawdhry Date: Tue, 15 Sep 2026 15:25:08 +0530 Subject: [PATCH 02/30] crypto: sa2ul - remove totally unused structure fields Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-ID: <20260915-b4-upstream-sa2ul-cleanup-v1-2-57ab34e97162@ti.com> References: <20260915-b4-upstream-sa2ul-cleanup-v1-0-57ab34e97162@ti.com> In-Reply-To: <20260915-b4-upstream-sa2ul-cleanup-v1-0-57ab34e97162@ti.com> To: Herbert Xu , "David S. Miller" , Keerthy , Colin Ian King CC: Andrew Davis , Pratham T , "Kamlesh Gurudasani" , Udit Kumar , , , "Manorit Chawdhry" X-Mailer: b4 0.15.2 X-Developer-Signature: v=1; a=ed25519-sha256; t=1789466112; l=2917; i=m-chawdhry@ti.com; s=20231127; h=from:subject:message-id; bh=JbDOFfCx/9J1eG2894Q98RVIKK5wZoZYzMTcOlINDcg=; b=0f9Wn9q8DEvFGNXiiDw1yXBci2UWXE5k1h1EWtHRrOfV+g6SjZWhFuvnVB4HnsGCsAVCGy5Wf js+tqkCVFSADlR/sLIptrgY6VZrhB7kBfvGi4jS8H5oH+R9RYhMxIsG X-Developer-Key: i=m-chawdhry@ti.com; a=ed25519; pk=fsr6Tm39TvsTgfyfFQLk+nnqIz2sBA1PthfqqfiiYSs= X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: MWH0EPF000C6186:EE_|DM3PPF424CCE606:EE_ X-MS-Office365-Filtering-Correlation-Id: 01b5cd53-23df-452c-9660-08df130f8e33 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|82310400026|376014|1800799024|23010399003|36860700016|10067099003|6133799003|3023799007|56012099006|22082099003|18002099003; X-Microsoft-Antispam-Message-Info: k/zbF6o1yh2mJKZFb3SyZW6eTApKBWdfMG4jIetbrYEHxRD4X6WL/kkzc0MGfBPRM6BSgLzYXqMp4ihrEwG/yp5SBqAb+7sIVtk308tXSxqE7ztV0ThRAZc43ksgHMQme72XgqlpNCIy4ShM1MKrh2Vgifpiyu4zcKIWJwNXMc3l7OkzICnjF5eN5l2xCIqspf2GyY6qmdwateCv0XLMacBIer4dbTfA6veb/xofIKQAZTuSWutK8C7HqzCVtRdXVuols4ChLhEoqyMTfwspQpnPWcBwHGHtktfOwQlzU9C6scDNCAaJftBK9gY1Xn2aaeyQUsrQw0dmi+7FaG4xKJZ+OmgRsLn1zAgVbnTIxMyT4ICNVXZXeqvyhkYQQgAp9GuD+B8IYwrjZ3/qkhBXh9FiXgh3PEc9qS55LLpjNoKPzvYQVVSj3T1+CuXGoAgSrMmJAJ8DoTimcXtb9mN8DgDjcO/ckJmjwBDPpr/ZLLC9useIhaYKDx4PeNcJB4VZGcnQ07aPDBjER1uT8fzrEHbpsXr4ksIO6YK9mZ06raOB7owzJclHemlJ2a/RmiO5emUnpb6s7QfUtdzpXFN/1Oc2W501V1YqjSvdPq5XFF05Qvl7vF/Bp4ArCIc985/L7PIZQ4VyGiM2IQLebH15e68IaOjf/8vIXCi04rQMPtLQduXIhNFKQsnLULIa8qzY87QxBdbMa/4BpFM65cOC3Q== X-Forefront-Antispam-Report: CIP:198.47.21.195;CTRY:US;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:flwvzet201.ext.ti.com;PTR:ErrorRetry;CAT:NONE;SFS:(13230040)(82310400026)(376014)(1800799024)(23010399003)(36860700016)(10067099003)(6133799003)(3023799007)(56012099006)(22082099003)(18002099003);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: 6caq8Nlqwr3Ycm3XZFqDNrJzg2/TIiJsgkt31QybimQXIRLGjFBJbj6bNC54Fa/XMENptN7l1z8QXdnpdTN59JH2N5fdCfkWckbNKe6DlmzfPiBxLh3h2x8eoEi1bjVczX2hV6dlc+66krOog/6wXxVivvCYg7F/wImRvTT1Tt1ME8jXvFgVxZw9nlZqNeIqMIHDfyPXo+ZdVl0oaGUTYHC0jguDE/jO+lqomQGW5FIFA2kKQMBK92QL+dQbu2ZI2uiO6k3ZRNPhumCHbqGKHDs6agyemVmc7ThjsCH3QSDP+tGszZOgx39LtH+eWGyBqqbyhGM8dSJswZD4MGPLXU2xIFLLVcNzd6fNDHSzVhtvLuimqhOg7qT8vhL1KLiZSLAp/8ZOJbQc+LcKLmucrNLTlih8SfrC8cO4fwxJn0QXkMFH7LG5jEacmSiDpLJY X-Exchange-RoutingPolicyChecked: MN/Kuv96/EUDqM2gdxUWJh3wa8OFfU6F/lWAfzbMkzeAMKgXBv8ClBaKkY8H5KD1q8haCh6O7Dft1RgXfRBQVH/2I2maU7xQzCOY3J2W7ycmjrV4jzO06Wrca9AsIv9lZi5VqLIT3qm9+cghO/tGV0PxHVcIyKUNRSvaZ9gPWHalIKSwSavNyS48yuU3Bm/7wd4eysoWe7qwf9gmyi6uG+h7v4l+xREldqHU3IsuvEKHKhDHwQhr+ijj5kSnibN1rZTXF8yy12781rzExZOsQ2IUeKy0REhXRgjZOFJRDsumoKe9DFFzY1wVTT40R+3cGDEIp5huBV+vnqnk6K3KrQ== X-OriginatorOrg: ti.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 15 Sep 2026 09:56:03.9826 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 01b5cd53-23df-452c-9660-08df130f8e33 X-MS-Exchange-CrossTenant-Id: e5b49634-450b-4709-8abb-1e2b19b982b7 X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=e5b49634-450b-4709-8abb-1e2b19b982b7;Ip=[198.47.21.195];Helo=[flwvzet201.ext.ti.com] X-MS-Exchange-CrossTenant-AuthSource: MWH0EPF000C6186.namprd02.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM3PPF424CCE606 X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwOTE1MDE0MyBTYWx0ZWRfX2fkrE+I1fe3J b7ADdFLomBAaYOeKG/a8u/lLcKn7jLGpMviIIInKvHP227wQQuRyBR4GK1ZNZ6ogbt8dqe7jQT7 t5KAGzbT52auN/IRCrtyamb9y5VmK4PmJFXyKJiGb9qOvP9AOUUT8dftEo7c+eap28b9K4YuMne Ezg7kZzxWJksXBrcL1UcfezTpzQ0lD/OaQnTr0ujR2JONxpnhJLj18Z9HrcLxswKCTPquC6y7pk rvoGecpuGltvsOWZfY1qd4qCMCcjmmRNdvMSMUA3Wv/CKgxQF3ABp7t1HUZQl9gk5ZWQt60plK2 g/hJHWWV1NJ89UfaDDcoIeUv3qtseCKLrp4n0mwYfi7JZLqJ5o30tBKtSCLLNr4kG4Dj7Isi5U6 DN+CRt+4irQyTsQNPvh+izCxAseib4ZzXSDbrThMboJVqG1KDLUZXNMSxLWzv6Ik1NS3zqqzmyJ tcCMcZjKXhzSUlhUFJw== X-Proofpoint-ORIG-GUID: 4zjTpnslM6IToHxH4oBBaeRAyiGsCBE_ X-Authority-Analysis: v=2.4 cv=U7cHnuru c=1 sm=1 tr=0 ts=6aa91638 cx=c_pps a=7whtcbPCeBOLW6TxF+pv5A==:117 a=tJyPKKxUohctrY4NYmUjkA==:17 a=6eWqkTHjU83fiwn7nKZWdM+Sl24=:19 a=IkcTkHD0fZMA:10 a=VdqzKS8jKosA:10 a=V5UXEbMT0ywA:10 a=VkNPw1HP01LnGYTKEx00:22 a=Z8NIEmU8O1QQgoT56wFK:22 a=taLDd7a_hP9WKsMzeGRc:22 a=sozttTNsAAAA:8 a=eUW96QGmFViiXR4GRiQA:9 a=QEXdDO2ut3YA:10 X-Proofpoint-GUID: 4zjTpnslM6IToHxH4oBBaeRAyiGsCBE_ X-Proofpoint-Spam-Info: AW1haW4tMjYwOTE1MDE0MyBTYWx0ZWRfX40n65z8/M2On IU00uyaPWg9JlShXCMbh42GQ/i3VSPtX6NLOfW0UQz6HJ3p2GkAJKiQJyir4/Yd8yL601wc8kFr wqhZReYJJNwTNl0T2ZXbD/0VLYHEj8Q= X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1176,Hydra:6.1.134,FMLib:17.12.100.49 definitions=2026-09-15_03,2026-09-14_02,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 priorityscore=1501 phishscore=0 lowpriorityscore=0 suspectscore=0 impostorscore=0 malwarescore=0 bulkscore=0 clxscore=1015 spamscore=0 adultscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2609040000 definitions=main-2609150143 The following have never been used in code. Remove them. Assisted-by: Sisyphus:claude-sonnet-4-6 Signed-off-by: Manorit Chawdhry --- drivers/crypto/sa2ul.h | 44 -------------------------------------------- 1 file changed, 44 deletions(-) diff --git a/drivers/crypto/sa2ul.h b/drivers/crypto/sa2ul.h index 12c17a68d350..847d6586c036 100644 --- a/drivers/crypto/sa2ul.h +++ b/drivers/crypto/sa2ul.h @@ -230,35 +230,19 @@ struct sa_cmdl_param_info { * @flags: flags in command label * @submode: Encryption submodes * @enc_size: Size of first pass encryption size - * @enc_size2: Size of second pass encryption size * @enc_offset: Encryption payload offset in the packet * @enc_iv: Encryption initialization vector for pass2 - * @enc_iv2: Encryption initialization vector for pass2 - * @aad: Associated data - * @payload: Payload info * @auth_size: Authentication size for pass 1 - * @auth_size2: Authentication size for pass 2 * @auth_offset: Authentication payload offset - * @auth_iv: Authentication initialization vector - * @aux_key_info: Authentication aux key information - * @aux_key: Aux key for authentication */ struct sa_cmdl_upd_info { u16 flags; u16 submode; struct sa_cmdl_param_info enc_size; - struct sa_cmdl_param_info enc_size2; struct sa_cmdl_param_info enc_offset; struct sa_cmdl_param_info enc_iv; - struct sa_cmdl_param_info enc_iv2; - struct sa_cmdl_param_info aad; - struct sa_cmdl_param_info payload; struct sa_cmdl_param_info auth_size; - struct sa_cmdl_param_info auth_size2; struct sa_cmdl_param_info auth_offset; - struct sa_cmdl_param_info auth_iv; - struct sa_cmdl_param_info aux_key_info; - u32 aux_key[SA_MAX_AUX_DATA_WORDS]; }; =20 /* @@ -307,7 +291,6 @@ struct sa_tfm_ctx { struct sa_crypto_data *dev_data; struct sa_ctx_info enc; struct sa_ctx_info dec; - struct sa_ctx_info auth; int keylen; int iv_idx; u32 key[AES_KEYSIZE_256 / sizeof(u32)]; @@ -333,13 +316,6 @@ struct sa_sha_req_ctx { struct ahash_request fallback_req; }; =20 -enum sa_submode { - SA_MODE_GEN =3D 0, - SA_MODE_CCM, - SA_MODE_GCM, - SA_MODE_GMAC -}; - /* Encryption algorithms */ enum sa_ealg_id { SA_EALG_ID_NONE =3D 0, /* No encryption */ @@ -374,26 +350,6 @@ enum sa_aalg_id { SA_AALG_ID_AES_XCBC /* AES Extended Cipher Block Chaining */ }; =20 -/* - * Mode control engine algorithms used to index the - * mode control instruction tables - */ -enum sa_eng_algo_id { - SA_ENG_ALGO_ECB =3D 0, - SA_ENG_ALGO_CBC, - SA_ENG_ALGO_CFB, - SA_ENG_ALGO_OFB, - SA_ENG_ALGO_CTR, - SA_ENG_ALGO_F8, - SA_ENG_ALGO_F8F9, - SA_ENG_ALGO_GCM, - SA_ENG_ALGO_GMAC, - SA_ENG_ALGO_CCM, - SA_ENG_ALGO_CMAC, - SA_ENG_ALGO_CBCMAC, - SA_NUM_ENG_ALGOS -}; - /** * struct sa_eng_info: Security accelerator engine info * @eng_id: Engine ID --=20 2.43.0 From nobody Fri Sep 25 12:05:54 2026 Received: from mx0b-0002e601.pphosted.com (mx0b-0002e601.pphosted.com [148.163.154.28]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id AE56D480DD3; Tue, 15 Sep 2026 09:56:18 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=fail smtp.client-ip=148.163.154.28 ARC-Seal: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1789466181; cv=fail; b=Y1hKbga4dNwRLyIzfBnPpIe2AVaEUV7/wlrE0bJkg13LcOAYoZIPFnY2PdouHHH1a+JybYB/MTVR7O01oX1jGa4iSo5GbSKiF3p4OcKj++k/ogPP597/YYwJal90k9doLQoyuWFEMU7/xaSrtV1IP21JJT+fMnDwLKqD+DP/bTQ= ARC-Message-Signature: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1789466181; c=relaxed/simple; bh=X+vlVKmp+L7sIy+7bps2uygyt+kkr+LDb2zTj6q9suI=; h=From:Date:Subject:MIME-Version:Content-Type:Message-ID:References: In-Reply-To:To:CC; b=qBT+VJH9Wqu7bDdpN/cvthFw3F1jvpnvUo0RlaKg266PlO1TZCiR+Z2Yv7st1JhMYZ039tMQqhtf34TaeoSOVozG6CWuANLjiau7ZGIqOkerAX1Lq3cE10Dus3pxS57fQy08Bm+e6Hw/03Pn0rU5rAOwCi3bqdfGbFcNUwkgjO0= ARC-Authentication-Results: i=2; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=ti.com; spf=pass smtp.mailfrom=ti.com; dkim=pass (2048-bit key) header.d=ti.com header.i=@ti.com header.b=Hn5InGpm; dkim=pass (1024-bit key) header.d=ti.com header.i=@ti.com header.b=hP3AYyvs; arc=fail smtp.client-ip=148.163.154.28 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=ti.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=ti.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=ti.com header.i=@ti.com header.b="Hn5InGpm"; dkim=pass (1024-bit key) header.d=ti.com header.i=@ti.com header.b="hP3AYyvs" Received: from pps.filterd (m0374955.ppops.net [127.0.0.1]) by mx0b-0002e601.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 68F9fLVB4098112; Tue, 15 Sep 2026 04:56:14 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ti.com; h=cc :content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s= proofpoint-05-2026; bh=L9yjm25NU5IcRHFTyU+vw73TYQHwaZz28rjyo3mTw Tw=; b=Hn5InGpmAE6Zamsbw6rDuUXXbhpG6KszT8Yl9VHevpWi4REBGXlt06RWL Sc9nNbLO4lhpsXhViRlaSMJfHIi1k/UFYAT8ADwLPN0TQqtyQs2r3hB5lmPcL7JC SDHlxvJvFt2LV1mIRvLe/bnrRk7zlWpY5+Powo6FGVN8s/fx2miPqa3Q7+2ktODd Nxevzis7It6h+JzGsq6L8A79QU3oD4rDbUWBf/ea3IuHMdmclaIahq4rRHr0flkg TTY+ot6X3k+5YN/SsY6z4JOTy78fCEPgipSKU/BBMcOhfGEnJNQcx0Jqs1lFjd3f icK1FzyyinJ8qz4zYJk842onXc5Kw== Received: from co1pr03cu002.outbound.protection.outlook.com (mail-westus2azon11010010.outbound.protection.outlook.com [52.101.46.10]) by mx0b-0002e601.pphosted.com (PPS) with ESMTPS id 4gpvpjakff-1 (version=TLSv1.3 cipher=TLS_AES_256_GCM_SHA384 bits=256 verify=NOT); Tue, 15 Sep 2026 04:56:13 -0500 (CDT) ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=YHTMrGqqWBtRJuHLpwRq0aMtfkS/45d45HyFlZbEMPnSQW6hbTvdS3MmQjnswpwBonrunKvmIrtVoMsFQiibz2hXcINCfI5eP3xUY4Fc8pts1OtsfH7yDhYmklIk//PuLm2DwmBNhlXj+RGLD2xN4e3aMHjCEiswdnMpLhxgijfFwczSUS3fIO0yQ8V0p9w8j5rdtQOPBCJ76u8/zTuIPrYO44bs5SzvXlaLq2Hps88Hhbbnxq20B6qmqvDCJ7yMmtWly0MvhXblSY0WNGfh0uzFRawxUHg17T/Hr7EDehPyRD8WnGsrUmryyTT0LyFoipCoalTryPAn3Sw++vi0xA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=L9yjm25NU5IcRHFTyU+vw73TYQHwaZz28rjyo3mTwTw=; b=OiylQsoQ1huomk167heJm+YhoUHBFTVr42held0BmztWU+uXyt20I28l2uXEOLOnVsq4xlh5tr7KllZDd0fa/2asqp9qoC4kVoeA9aQ+10ndv3ql5s2qVzadTNcX1MYjVk1mtu5JOaPCeEluTxVa8z9ZyrLJ7hrFzbnApHNp7TCbjlJUdtr2JESaDxdqg4L3aWwX+BXosYVSpUh0C5n0+SFIPW7rRfQ2LL6AEy4j5H5Hd4MB9Ey0oFbgqJ5Y7dPgbMXV32mCv8LN+7iajgawCKfuFGm7ri7F8foiHXizUZoXGrJFWCKstcKH2XkTZ30aetdXB632wa9rMrwa/Ue4ug== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 198.47.21.195) smtp.rcpttodomain=vger.kernel.org smtp.mailfrom=ti.com; dmarc=pass (p=quarantine sp=none pct=100) action=none header.from=ti.com; dkim=none (message not signed); arc=none (0) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ti.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=L9yjm25NU5IcRHFTyU+vw73TYQHwaZz28rjyo3mTwTw=; b=hP3AYyvs0a2BMi+Z02PbACzfSfkA6idGZju2Dn54HlV8YVZeLnVd20AVDwZGCIOZ+JBBkfHhsoIjpHv+LlKUscJ7LuCRePV8cBrdP6EcQOSiGxQPtV7v4iYQJ3oeFeesopJTd7D58y+Nas0ktNSKfmeYegPGk1/hKUAx2Q1qHMY= Received: from SJ2P220CA0005.NAMP220.PROD.OUTLOOK.COM (2603:10b6:a03:5da::17) by DS7PR10MB7177.namprd10.prod.outlook.com (2603:10b6:8:e1::18) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.21.428.9; Tue, 15 Sep 2026 09:56:09 +0000 Received: from MWH0EPF000C6187.namprd02.prod.outlook.com (2603:10b6:a03:5da:cafe::32) by SJ2P220CA0005.outlook.office365.com (2603:10b6:a03:5da::17) with Microsoft SMTP Server (version=TLS1_3, cipher=TLS_AES_256_GCM_SHA384) id 15.21.428.9 via Frontend Transport; Tue, 15 Sep 2026 09:56:08 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 198.47.21.195) smtp.mailfrom=ti.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=ti.com; Received-SPF: Pass (protection.outlook.com: domain of ti.com designates 198.47.21.195 as permitted sender) receiver=protection.outlook.com; client-ip=198.47.21.195; helo=flwvzet201.ext.ti.com; pr=C Received: from flwvzet201.ext.ti.com (198.47.21.195) by MWH0EPF000C6187.mail.protection.outlook.com (10.167.249.119) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.21.428.7 via Frontend Transport; Tue, 15 Sep 2026 09:56:07 +0000 Received: from DFLE214.ent.ti.com (10.64.6.72) by flwvzet201.ext.ti.com (10.248.192.32) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.2562.45; Tue, 15 Sep 2026 04:55:25 -0500 Received: from DFLE207.ent.ti.com (10.64.6.65) by DFLE214.ent.ti.com (10.64.6.72) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.2562.45; Tue, 15 Sep 2026 04:55:25 -0500 Received: from lelvem-mr06.itg.ti.com (10.180.75.8) by DFLE207.ent.ti.com (10.64.6.65) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.2562.45 via Frontend Transport; Tue, 15 Sep 2026 04:55:25 -0500 Received: from uda0497581-ant.dhcp.ti.com (uda0497581-ant.dhcp.ti.com [10.24.51.159]) by lelvem-mr06.itg.ti.com (8.18.1/8.18.1) with ESMTP id 68F9tB7r3000901; Tue, 15 Sep 2026 04:55:22 -0500 From: Manorit Chawdhry Date: Tue, 15 Sep 2026 15:25:09 +0530 Subject: [PATCH 03/30] crypto: sa2ul - remove unused algorithm ID fields Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-ID: <20260915-b4-upstream-sa2ul-cleanup-v1-3-57ab34e97162@ti.com> References: <20260915-b4-upstream-sa2ul-cleanup-v1-0-57ab34e97162@ti.com> In-Reply-To: <20260915-b4-upstream-sa2ul-cleanup-v1-0-57ab34e97162@ti.com> To: Herbert Xu , "David S. Miller" , Keerthy , Colin Ian King CC: Andrew Davis , Pratham T , "Kamlesh Gurudasani" , Udit Kumar , , , "Manorit Chawdhry" X-Mailer: b4 0.15.2 X-Developer-Signature: v=1; a=ed25519-sha256; t=1789466112; l=6314; i=m-chawdhry@ti.com; s=20231127; h=from:subject:message-id; bh=X+vlVKmp+L7sIy+7bps2uygyt+kkr+LDb2zTj6q9suI=; b=gWA27bQoJMSgF/npngNDCdOVqh28H/iCJg+EctEp+VE4qwYfuolqfhBPn7unOL9tOSWnBPHml 60PCssZDzO3A+pAtbkO/trP83AChT+xkAf7Dg0r6vCdG9j9bND5P8Q0 X-Developer-Key: i=m-chawdhry@ti.com; a=ed25519; pk=fsr6Tm39TvsTgfyfFQLk+nnqIz2sBA1PthfqqfiiYSs= X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: MWH0EPF000C6187:EE_|DS7PR10MB7177:EE_ X-MS-Office365-Filtering-Correlation-Id: eb9db906-0669-4347-f2cb-08df130f9051 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|376014|23010399003|82310400026|36860700016|1800799024|56012099006|10067099003|22082099003|18002099003|6133799003|3023799007; X-Microsoft-Antispam-Message-Info: 9uXdVI89Il8ky3JOew+D1zRo0mtQIelN76qs/Eqy83eesROiHIwNRrreBwE4zoJomWlSpememtjCPynSfxVvepqZAKO1btBIs9FZQelr41uvpFRYdLQjXTUzEJ0Z2HleEnfaUar9KLa6IJAdfRbf1413U2OyDlhzVZ59JiFXDYumzOxFMbyJZk4GjIuUVF8bS24TC4dxxr2LF7498WTS0lseclkrZ5cbswR5WHUcG8wwSgd6EjkU36V43grsPGLQ3lh5NBg1zM+9IlCAJDaX+9CqUuuceL+mqjyWChyMiUoPb7GeBhNMevpmJTWLatYp2lWpiKPjW8lbExeUx7ISvTlADI3rQUvKuaNUu7jpDYgQC6om1i0a9MXmtTH3txNs4HEpXUOwEPuOI2/cU+QcjZoyP0SpiqfNrxboAClrZbnLddpfVci+r0cYOMrqyJQUvCMZ2pKIYQ+ASDmbtpf8a7oIcJU5Q4oHdNysv9juPnQtVC3/W0VtoQMFRGAN4yNolSECGeE7U0Bd0qLoZZUykjuy+YMH+/1iVNvaLja7gSCltf+OvgBM1144rsAe1P1WteeTQZArjP7S3gbQxjmQ6J+e6BZqopY+Bt8vHQZ1nP5G6bhxloSIaCOwQ7sP3XqZBUBClUW0zQ5PhqoiOiurCntiItiU/JnO3LCTcSVr0LlvSqJZEE/7X5He9TOvYd1i2eth5R0f4Tr9F5S45T0o9A== X-Forefront-Antispam-Report: CIP:198.47.21.195;CTRY:US;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:flwvzet201.ext.ti.com;PTR:ErrorRetry;CAT:NONE;SFS:(13230040)(376014)(23010399003)(82310400026)(36860700016)(1800799024)(56012099006)(10067099003)(22082099003)(18002099003)(6133799003)(3023799007);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: rwxFwWJvMNKrUmEXF4hCo1ER8fdAe5xD2kNWjfDULG9+Vv1B3feG/bdmp2dN3sBlJmNIzEv6+qwY81aUtb9ooGqG39GB5RGUemvrMpfKzN5Y6y8WeQ/dhiIHKUcsfRAH5pvhBl5s/efmtNPixupbLU5kcVogT2QqlflH5UVvtY6m5veixc2X1jnS52GdPALwBJr9x129W0bpPOymOrC8l2TJ1GColt0kY6bFJx9U/jIM+7swRVQjvkX9NGmidjU02ijo0XWnCdzT4TJMBck6bJiN4vNb/FnH0x4xEoY+NEHLouNhE2YwLE4DIlDgsI+CnwhSFGD7gEanasvyBY4Sd5ogF6YMKY9eigawrY1TmiaHnsCFyZ4zXhsUA8hEz1CKAZVZHDb+0pEo5Tq52J8WYlg9aOHM7+shIfDX1k/qW9UDkEEZ/hrqxEvNqctyFL8N X-Exchange-RoutingPolicyChecked: YIG85A1E7qpqXVFVfyQbWTui5ZfU1vw3gPUazYXjaAB8mJMrwPiubqEZW/qKi1RLcOsz6bpcq656QgLL/Z/H/Jjrz8A2RI5E4++tM6EsGpgvwE58FP8bFg7pRtAPWPir1B5EsRKIxMXSMpk+i3SCR1BBQt+gw2yb3OMTqfZx30wRDQzUXcRjO2dt/Gd8CqomxVEZUtIxf8TkajiprdB54V3wgUy+ydf8pBAAHshGMwOFzZNO1H/doAbJdbPFgrI+nkzeuYDz/IwzXZRraYxLkcBzxFWSCukIq9X88WfmyD9uEfZ2M8FOsovIIN5whE0uQ+lpe5E4xKg7/8GoyXpLDA== X-OriginatorOrg: ti.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 15 Sep 2026 09:56:07.5381 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: eb9db906-0669-4347-f2cb-08df130f9051 X-MS-Exchange-CrossTenant-Id: e5b49634-450b-4709-8abb-1e2b19b982b7 X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=e5b49634-450b-4709-8abb-1e2b19b982b7;Ip=[198.47.21.195];Helo=[flwvzet201.ext.ti.com] X-MS-Exchange-CrossTenant-AuthSource: MWH0EPF000C6187.namprd02.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: DS7PR10MB7177 X-Proofpoint-Spam-Info: AW1haW4tMjYwOTE1MDE0MyBTYWx0ZWRfXwcMq45AUkUJb KOYaUCuWIyX50KWEnYKmsvw47Fqy9wAgPgghhilTaJTcNlt+a0Nq7Nx+NQkIL+BOoiBXIkrArIL aunVTqhoDM0twnBd/TtN5hUZGAWWdDM= X-Authority-Analysis: v=2.4 cv=KvnYSmWN c=1 sm=1 tr=0 ts=6aa9163d cx=c_pps a=Szpykk5hBk3mC7HHiWFpbQ==:117 a=tJyPKKxUohctrY4NYmUjkA==:17 a=6eWqkTHjU83fiwn7nKZWdM+Sl24=:19 a=IkcTkHD0fZMA:10 a=VdqzKS8jKosA:10 a=V5UXEbMT0ywA:10 a=VkNPw1HP01LnGYTKEx00:22 a=Z8NIEmU8O1QQgoT56wFK:22 a=fPAWb5peG099m5CrUpKH:22 a=sozttTNsAAAA:8 a=luWjcLmAkgMxxOjGXh0A:9 a=QEXdDO2ut3YA:10 X-Proofpoint-ORIG-GUID: _Zl3NFgOHD0t_hxhHsoTPb4iAWXtdqXd X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwOTE1MDE0MyBTYWx0ZWRfX+1mE7gqK8Awm LT5CNd6lWvxYxBYcCuB9q0FvBaRkIYrwMoeK3kh8FsafV/Ww9fr1c0xXDZTgr/ka/Ldo5eLKld7 7X28lJhsFgFjC/w+mZh4EiJkvEWHeqgEb0omcIl1l22QqgDqhLKCObYPS34SwEicuhxVEu8Uf+P /vqcNec2NWsjzQA65TOagI3RC+edvrzNYqI/PaKlSv073bSku48pm5RtX+F0k2j8DCu6SBfdu6+ LqUFYPjlk/S/E9aDs1IaMabBjyaMh1tprhMDeB+iMUwqnYnk+aoEG2ZR6hFX0GtsR2QDLPphCzA v+hqRKMmFv8BT8UD5FiCdaTFlRXYblTLadp0DL0NV8S4v2Y2cWY7OxwORU8/wzq4crq7oJJjdn3 eOKAc+WFCdxS1C154nHFhOVyJVmLGAUwGYIBdIJgKhZwaryNw+PzmgDuZlBiOIcyMlplju8Hi5g Fj7UltoZuIwn83HlLZw== X-Proofpoint-GUID: _Zl3NFgOHD0t_hxhHsoTPb4iAWXtdqXd X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1176,Hydra:6.1.134,FMLib:17.12.100.49 definitions=2026-09-15_03,2026-09-14_02,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 lowpriorityscore=0 clxscore=1011 priorityscore=1501 impostorscore=0 suspectscore=0 spamscore=0 bulkscore=0 adultscore=0 phishscore=0 malwarescore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2609040000 definitions=main-2609150143 These algorithm ID fields were never referenced. Remove them. Assisted-by: Sisyphus:claude-sonnet-4-6 Signed-off-by: Manorit Chawdhry --- drivers/crypto/sa2ul.c | 19 ------------------- drivers/crypto/sa2ul.h | 34 ---------------------------------- 2 files changed, 53 deletions(-) diff --git a/drivers/crypto/sa2ul.c b/drivers/crypto/sa2ul.c index f7e4f58c02c2..3297a25d9d9d 100644 --- a/drivers/crypto/sa2ul.c +++ b/drivers/crypto/sa2ul.c @@ -92,7 +92,6 @@ static struct device *sa_k3_dev; =20 /** * struct sa_cmdl_cfg - Command label configuration descriptor - * @aalg: authentication algorithm ID * @enc_eng_id: Encryption Engine ID supported by the SA hardware * @auth_eng_id: Authentication Engine ID * @iv_size: Initialization Vector size @@ -101,7 +100,6 @@ static struct device *sa_k3_dev; * @enc: True, if this is an encode request */ struct sa_cmdl_cfg { - int aalg; u8 enc_eng_id; u8 auth_eng_id; u8 iv_size; @@ -118,8 +116,6 @@ struct sa_cmdl_cfg { * @hash_size: Size of digest * @iv_idx: iv index in psdata * @iv_out_size: iv out size - * @ealg_id: Encryption Algorithm ID - * @aalg_id: Authentication algorithm ID * @mci_enc: Mode Control Instruction for Encryption algorithm * @mci_dec: Mode Control Instruction for Decryption * @inv_key: Whether the encryption algorithm demands key inversion @@ -134,8 +130,6 @@ struct algo_data { u8 hash_size; u8 iv_idx; u8 iv_out_size; - u8 ealg_id; - u8 aalg_id; u8 *mci_enc; u8 *mci_dec; bool inv_key; @@ -934,7 +928,6 @@ static int sa_aes_cbc_setkey(struct crypto_skcipher *tf= m, const u8 *key, ad.mci_enc =3D mci_cbc_enc_array[key_idx]; ad.mci_dec =3D mci_cbc_dec_array[key_idx]; ad.inv_key =3D true; - ad.ealg_id =3D SA_EALG_ID_AES_CBC; ad.iv_idx =3D 4; ad.iv_out_size =3D 16; =20 @@ -954,7 +947,6 @@ static int sa_aes_ecb_setkey(struct crypto_skcipher *tf= m, const u8 *key, ad.mci_enc =3D mci_ecb_enc_array[key_idx]; ad.mci_dec =3D mci_ecb_dec_array[key_idx]; ad.inv_key =3D true; - ad.ealg_id =3D SA_EALG_ID_AES_ECB; =20 return sa_cipher_setkey(tfm, key, keylen, &ad); } @@ -966,7 +958,6 @@ static int sa_3des_cbc_setkey(struct crypto_skcipher *t= fm, const u8 *key, =20 ad.mci_enc =3D mci_cbc_3des_enc_array; ad.mci_dec =3D mci_cbc_3des_dec_array; - ad.ealg_id =3D SA_EALG_ID_3DES_CBC; ad.iv_idx =3D 6; ad.iv_out_size =3D 8; =20 @@ -1429,7 +1420,6 @@ static int sa_sha_setup(struct sa_tfm_ctx *ctx, struc= t algo_data *ad) =20 memset(ctx->authkey, 0, bs); memset(&cfg, 0, sizeof(cfg)); - cfg.aalg =3D ad->aalg_id; cfg.enc_eng_id =3D ad->enc_eng.eng_id; cfg.auth_eng_id =3D ad->auth_eng.eng_id; cfg.iv_size =3D 0; @@ -1577,7 +1567,6 @@ static int sa_sha1_cra_init(struct crypto_tfm *tfm) =20 sa_sha_cra_init_alg(tfm, "sha1"); =20 - ad.aalg_id =3D SA_AALG_ID_SHA1; ad.hash_size =3D SHA1_DIGEST_SIZE; ad.auth_ctrl =3D SA_AUTH_SW_CTRL_SHA1; =20 @@ -1593,7 +1582,6 @@ static int sa_sha256_cra_init(struct crypto_tfm *tfm) =20 sa_sha_cra_init_alg(tfm, "sha256"); =20 - ad.aalg_id =3D SA_AALG_ID_SHA2_256; ad.hash_size =3D SHA256_DIGEST_SIZE; ad.auth_ctrl =3D SA_AUTH_SW_CTRL_SHA256; =20 @@ -1609,7 +1597,6 @@ static int sa_sha512_cra_init(struct crypto_tfm *tfm) =20 sa_sha_cra_init_alg(tfm, "sha512"); =20 - ad.aalg_id =3D SA_AALG_ID_SHA2_512; ad.hash_size =3D SHA512_DIGEST_SIZE; ad.auth_ctrl =3D SA_AUTH_SW_CTRL_SHA512; =20 @@ -1770,12 +1757,10 @@ static int sa_aead_setkey(struct crypto_aead *authe= nc, ad->mci_dec =3D mci_cbc_dec_no_iv_array[key_idx]; ad->inv_key =3D true; ad->keyed_mac =3D true; - ad->ealg_id =3D SA_EALG_ID_AES_CBC; ad->prep_iopad =3D sa_prepare_iopads; =20 memset(&cfg, 0, sizeof(cfg)); cfg.enc =3D true; - cfg.aalg =3D ad->aalg_id; cfg.enc_eng_id =3D ad->enc_eng.eng_id; cfg.auth_eng_id =3D ad->auth_eng.eng_id; cfg.iv_size =3D crypto_aead_ivsize(authenc); @@ -1831,8 +1816,6 @@ static int sa_aead_cbc_sha1_setkey(struct crypto_aead= *authenc, { struct algo_data ad =3D { 0 }; =20 - ad.ealg_id =3D SA_EALG_ID_AES_CBC; - ad.aalg_id =3D SA_AALG_ID_HMAC_SHA1; ad.hash_size =3D SHA1_DIGEST_SIZE; ad.auth_ctrl =3D SA_AUTH_SW_CTRL_SHA1; =20 @@ -1844,8 +1827,6 @@ static int sa_aead_cbc_sha256_setkey(struct crypto_ae= ad *authenc, { struct algo_data ad =3D { 0 }; =20 - ad.ealg_id =3D SA_EALG_ID_AES_CBC; - ad.aalg_id =3D SA_AALG_ID_HMAC_SHA2_256; ad.hash_size =3D SHA256_DIGEST_SIZE; ad.auth_ctrl =3D SA_AUTH_SW_CTRL_SHA256; =20 diff --git a/drivers/crypto/sa2ul.h b/drivers/crypto/sa2ul.h index 847d6586c036..097a496067e1 100644 --- a/drivers/crypto/sa2ul.h +++ b/drivers/crypto/sa2ul.h @@ -316,40 +316,6 @@ struct sa_sha_req_ctx { struct ahash_request fallback_req; }; =20 -/* Encryption algorithms */ -enum sa_ealg_id { - SA_EALG_ID_NONE =3D 0, /* No encryption */ - SA_EALG_ID_NULL, /* NULL encryption */ - SA_EALG_ID_AES_CTR, /* AES Counter mode */ - SA_EALG_ID_AES_F8, /* AES F8 mode */ - SA_EALG_ID_AES_CBC, /* AES CBC mode */ - SA_EALG_ID_DES_CBC, /* DES CBC mode */ - SA_EALG_ID_3DES_CBC, /* 3DES CBC mode */ - SA_EALG_ID_CCM, /* Counter with CBC-MAC mode */ - SA_EALG_ID_GCM, /* Galois Counter mode */ - SA_EALG_ID_AES_ECB, - SA_EALG_ID_LAST -}; - -/* Authentication algorithms */ -enum sa_aalg_id { - SA_AALG_ID_NONE =3D 0, /* No Authentication */ - SA_AALG_ID_NULL =3D SA_EALG_ID_LAST, /* NULL Authentication */ - SA_AALG_ID_MD5, /* MD5 mode */ - SA_AALG_ID_SHA1, /* SHA1 mode */ - SA_AALG_ID_SHA2_224, /* 224-bit SHA2 mode */ - SA_AALG_ID_SHA2_256, /* 256-bit SHA2 mode */ - SA_AALG_ID_SHA2_512, /* 512-bit SHA2 mode */ - SA_AALG_ID_HMAC_MD5, /* HMAC with MD5 mode */ - SA_AALG_ID_HMAC_SHA1, /* HMAC with SHA1 mode */ - SA_AALG_ID_HMAC_SHA2_224, /* HMAC with 224-bit SHA2 mode */ - SA_AALG_ID_HMAC_SHA2_256, /* HMAC with 256-bit SHA2 mode */ - SA_AALG_ID_GMAC, /* Galois Message Auth. Code mode */ - SA_AALG_ID_CMAC, /* Cipher-based Mes. Auth. Code mode */ - SA_AALG_ID_CBC_MAC, /* Cipher Block Chaining */ - SA_AALG_ID_AES_XCBC /* AES Extended Cipher Block Chaining */ -}; - /** * struct sa_eng_info: Security accelerator engine info * @eng_id: Engine ID --=20 2.43.0 From nobody Fri Sep 25 12:05:54 2026 Received: from mx0a-0002e601.pphosted.com (mx0a-0002e601.pphosted.com [148.163.150.75]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id A13514718D3; Tue, 15 Sep 2026 09:55:50 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=fail smtp.client-ip=148.163.150.75 ARC-Seal: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1789466154; cv=fail; b=coYaEl8chkP2lUxes/hBbUe8f6Tois9aLDuIjjEwuuk0HAMYFspBwMnq3n++fh0yzecCD92osVMMbgaq9PfLcw9/LxIyf17NAFATLcCvZRu0NTNc8le4CYwM8RzNgf5TsGSujpxWS6dAl3wjixtvpzZRT9eALPPcsnFKawXvwiU= ARC-Message-Signature: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1789466154; c=relaxed/simple; bh=t9opaBmY+K9yLqyOMEfwgkFj58cJL30E+3tEIdYlplg=; h=From:Date:Subject:MIME-Version:Content-Type:Message-ID:References: In-Reply-To:To:CC; b=FV+cxVROj4RxxMVReTOmCPcCAHYuHSN0lN3TVy5o6tBbmZ5IvUI01cFoxFvmWLSdc8AvcVIPMy+VCuiwB3jPhnsKeItw9C+gA9mpFfRiWXsbNWJk5m1h6ftQWM/Fj/wMR1a0ywZ7ho7X0DCjFN77jjMStxXaKPqFjiSDaFZMrV8= ARC-Authentication-Results: i=2; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=ti.com; spf=pass smtp.mailfrom=ti.com; dkim=pass (2048-bit key) header.d=ti.com header.i=@ti.com header.b=laej/6lE; dkim=pass (1024-bit key) header.d=ti.com header.i=@ti.com header.b=szS3yupA; arc=fail smtp.client-ip=148.163.150.75 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=ti.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=ti.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=ti.com header.i=@ti.com header.b="laej/6lE"; dkim=pass (1024-bit key) header.d=ti.com header.i=@ti.com header.b="szS3yupA" Received: from pps.filterd (m0384305.ppops.net [127.0.0.1]) by m0384305.ppops.net (8.18.1.11/8.18.1.11) with ESMTP id 68F9ejvr1480564; Tue, 15 Sep 2026 04:55:45 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ti.com; h=cc :content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s= proofpoint-05-2026; bh=5Q6nE3RKr7fV+rXdtjdum+akrQZbv7f9wnaenV28O 94=; b=laej/6lE2Wixwc1BYPNLlad11dVMG3MJYVo+2eotm6XI0t4qVXQCxJJu5 EQJGyHRaK/j2OPK9qUx2VEVUJKa3ME4P9Sl14/rSlVlwD7z42iEaZISvgVv5wodL kcEpbuJMPbFvccEjCws6XVL6bd8+hnM+xnlwQUllK2NLx6GoqufipeVC9a0SCQrX beRwhAA47kfnjZWTZEqiG8j16T2LE24gWWytCx9ONMYLfGVJ6KT5XptbbUuASNcm yNBdYto/HD63wdDmtGEq6RBkzao8nSg9/5/xwGLALrualPYmNsfUcy42Q1Qi4Tu4 oLycmB/sCx1P4QQDYKvc/ePvTPRzw== Received: from co1pr03cu002.outbound.protection.outlook.com (mail-westus2azon11010032.outbound.protection.outlook.com [52.101.46.32]) by m0384305.ppops.net (PPS) with ESMTPS id 4gpvpa2hx4-1 (version=TLSv1.3 cipher=TLS_AES_256_GCM_SHA384 bits=256 verify=NOT); Tue, 15 Sep 2026 04:55:45 -0500 (CDT) ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=TRqkMOsPpWYOS0W5pNyfwuCj0i4EpNc18p7CFAY1upU6URtdK+EjZVQItIC8H//MQvfhnw3xK+QMYncfwwYwgrohh5c1qN/foSRIdQr0ggSoFDxYPsoLKyUOoYpIh2q00Ywn8/Suz1QdN5T2HnSERyjCi0FVCIgQ5rMqX3f7gaVEJ/LXQUZcvj8IsllmB3YcOAiznw1ESrUzwUbt4TV/bDqNhDzp0x0JgGi9Z4rjnriGbNRVe1A+CLFmWwPsf0kAoHqRCMqJgnKflWWp2DZ/kdSSOPw/BLBD/bYw8E5rfuVCKwYSUOSA2eBLKWs5eP4XxGeqQm1joNfZNdR5azVvEg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=5Q6nE3RKr7fV+rXdtjdum+akrQZbv7f9wnaenV28O94=; b=wBrku5itQRHKlM3JmNPE/48VFf6v+78mgv+jsdtNqTdaVFt45JvsKM36VX1cdF/hjaoePTsUcTDfOGoUykgYWvosAZyhICfl6mgdTJGvEXg7UveFqo9kDRZnbDjuJOkHtu6CxVVNiknBQXVcINhsYRT/wZ5SN54yqPlsjSygpk2KB0KgbLdBnSTZSaIZxCzbdNhrqpKe0cQvuS5HnlLgYTJT7LKCFciQMNf3YfTnoVPkcBcQwoHWqWMnSzDP0Yo5l6ryEccuuVcqnYkfQgLsqFultybAxqtmU4lJ3dml8SjzlnmIzahZBklZrO5K8Rx6wRNlH6pBq5gPiLlFiRa2uA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 198.47.23.195) smtp.rcpttodomain=vger.kernel.org smtp.mailfrom=ti.com; dmarc=pass (p=quarantine sp=none pct=100) action=none header.from=ti.com; dkim=none (message not signed); arc=none (0) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ti.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=5Q6nE3RKr7fV+rXdtjdum+akrQZbv7f9wnaenV28O94=; b=szS3yupA7dvLYPs/e14cMNXYYH9QLm9VyPMxmlyVNvQUEykBCX3GgHt864PT6qqkRrumkeICEetsEBRwDlsMsOkXrdj9C4p1ED2VkwAH/NesWVp4szE3Mf/mh1brHSvT599P3vQaHbxmhm5IiPBksBG1BAP4TXMn7M5Q1I3+Yq0= Received: from BN9PR03CA0543.namprd03.prod.outlook.com (2603:10b6:408:138::8) by DS0PR10MB8030.namprd10.prod.outlook.com (2603:10b6:8:1f7::9) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.21.428.8; Tue, 15 Sep 2026 09:55:42 +0000 Received: from LV8PEPF0000006B.namprd03.prod.outlook.com (2603:10b6:408:138:cafe::6e) by BN9PR03CA0543.outlook.office365.com (2603:10b6:408:138::8) with Microsoft SMTP Server (version=TLS1_3, cipher=TLS_AES_256_GCM_SHA384) id 15.21.406.9 via Frontend Transport; Tue, 15 Sep 2026 09:55:42 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 198.47.23.195) smtp.mailfrom=ti.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=ti.com; Received-SPF: Pass (protection.outlook.com: domain of ti.com designates 198.47.23.195 as permitted sender) receiver=protection.outlook.com; client-ip=198.47.23.195; helo=lewvzet201.ext.ti.com; pr=C Received: from lewvzet201.ext.ti.com (198.47.23.195) by LV8PEPF0000006B.mail.protection.outlook.com (10.167.248.40) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.21.428.7 via Frontend Transport; Tue, 15 Sep 2026 09:55:42 +0000 Received: from DLEE201.ent.ti.com (157.170.170.76) by lewvzet201.ext.ti.com (10.4.14.104) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.2562.45; Tue, 15 Sep 2026 04:55:28 -0500 Received: from DLEE213.ent.ti.com (157.170.170.116) by DLEE201.ent.ti.com (157.170.170.76) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.2562.45; Tue, 15 Sep 2026 04:55:28 -0500 Received: from lelvem-mr06.itg.ti.com (10.180.75.8) by DLEE213.ent.ti.com (157.170.170.116) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.2562.45 via Frontend Transport; Tue, 15 Sep 2026 04:55:28 -0500 Received: from uda0497581-ant.dhcp.ti.com (uda0497581-ant.dhcp.ti.com [10.24.51.159]) by lelvem-mr06.itg.ti.com (8.18.1/8.18.1) with ESMTP id 68F9tB7s3000901; Tue, 15 Sep 2026 04:55:25 -0500 From: Manorit Chawdhry Date: Tue, 15 Sep 2026 15:25:10 +0530 Subject: [PATCH 04/30] crypto: sa2ul - remove unused fields from sa_cmdl_cfg Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-ID: <20260915-b4-upstream-sa2ul-cleanup-v1-4-57ab34e97162@ti.com> References: <20260915-b4-upstream-sa2ul-cleanup-v1-0-57ab34e97162@ti.com> In-Reply-To: <20260915-b4-upstream-sa2ul-cleanup-v1-0-57ab34e97162@ti.com> To: Herbert Xu , "David S. Miller" , Keerthy , Colin Ian King CC: Andrew Davis , Pratham T , "Kamlesh Gurudasani" , Udit Kumar , , , "Manorit Chawdhry" X-Mailer: b4 0.15.2 X-Developer-Signature: v=1; a=ed25519-sha256; t=1789466112; l=1630; i=m-chawdhry@ti.com; s=20231127; h=from:subject:message-id; bh=t9opaBmY+K9yLqyOMEfwgkFj58cJL30E+3tEIdYlplg=; b=Y2ZbrZHG9/y9e8siK/JQO2lH/q6WnpaMiC2Hr+A0WN1d2dnUkA1jtAW9L1Rc3T00BFZgNe/pk YrdnSkVpMp1BK++yIINFuixY5+JW7/7l26wJ2N7k1+8YF1rfkPT5JOn X-Developer-Key: i=m-chawdhry@ti.com; a=ed25519; pk=fsr6Tm39TvsTgfyfFQLk+nnqIz2sBA1PthfqqfiiYSs= X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: LV8PEPF0000006B:EE_|DS0PR10MB8030:EE_ X-MS-Office365-Filtering-Correlation-Id: 027cee5c-4561-4aa2-c9e6-08df130f8172 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|1800799024|376014|36860700016|82310400026|23010399003|6133799003|10067099003|56012099006|18002099003|22082099003; X-Microsoft-Antispam-Message-Info: VeD53SXtEg64t00VtRvLGsh66CCucKvHajhf7ab9UgtKR9mf3lLfyKC1+vy1L7GYcIsE5r7RZtqn6zU2drUHTV7rSLL7tujREmri7ZVnVbZPORlbgAJreGt7FA25iAUKNMet2GLVfPFd/wh+pSx/tWw55yhqcgadkWmI6M+cwIPg7tEpn4lPUN8AkVZXbMnkwwlt2g78QA12X0PvjPqbKJlzQZxZ1sjEC9RkzOHfXCDd/9SqOt0QZoDZKuDzvy4lGsaGs8Ky/Z/c7zJk63vmMB5JeiN1PkhHCdb0WGm4WUz3c3m24U2aDgd+OAMR7SNVmUItp3mbKfjfQX9dQTH8xvHn2MHhjdP45TVGlSNEvC5uBLo/1blwKaE0bGubJA5L2viWv+8M68+9AATyYOLqwkppZjXxUnAR4xR6MsLY5QeHXgHkUAbCWNY/WKD7OLtm9aGsP8SYE9GNs4j3eZ52FdVGUIjSVNdvqjaJuCCj3WYby6g+PkHOWqiSpDsjXiIzPn09McTj3BOYqSTsiUw4tmDc2QgpNRlzcqdqAusYDRHTle5JdJorydTVy+dcODSgev3BfE8B0DvBiO/jlVslJBb0lvjlr/+UOGIVchy85odp34Sl050XpPvyJyT0e+fHfRIZAQGNjje9rhJfsDc1NgRRU0lXPnZ+La/7izS1KPgbvenn8RtlWJsEOicuJzvtJt7GYaxl/oJwNgxgmwIKxQ== X-Forefront-Antispam-Report: CIP:198.47.23.195;CTRY:US;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:lewvzet201.ext.ti.com;PTR:InfoDomainNonexistent;CAT:NONE;SFS:(13230040)(1800799024)(376014)(36860700016)(82310400026)(23010399003)(6133799003)(10067099003)(56012099006)(18002099003)(22082099003);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: 6AEHPWR13TdepA9olYPMirQhba3kGMd9ONCRmtoOvFwmJik5YNJ0us/UDHQ2vriqdXFAiruuA5tRgpQEezAnUJTb+OvTVDDNLY1DG1Q58L6+zhzUWoxRQoEFv1NdZf+yx7PpyP/+ET1oyydax4XL1MwWGjiwfwJZlqXOUQ3LeTHA3cPDTKJRKjJcsPVTN5KYoXJ8CKDFJztIZQ5Kem2oDwAlLcMHEVH1IaxnitsRZLI3gQsAQw9su3WTGx4hig4SLbavDGOk2QT3Ol+mdSN/0nkG0hS56NQ8jeNZxdLM9mXzksBuqRKh8NaDCIRcIkO73HmdDMVmhBQI2lVqNta1mpfua+1xoD0gC0qnhaZkFTop9PmGzsQfP+i9lrnt246vArmK8Bs8ULqvGY06MpSBgufiPFyqerpeZUCdwemw7h3q2YwjSYnIjwKaDU6NyREp X-Exchange-RoutingPolicyChecked: QUH1bZnStCuwQ0va4Eqw6nljxapZlHtRCR/cXiPf/FWNHL4QSpwHEP3naw5DvLzpuHIWQodUhi5z+GBvbbe3p3Y5sNHR+tqCqekhPkPeNDv+djRcgtKCsVRGwCkJIQi5UfK2b3tqyvOSDsYqSVVOLeSRVXm5+2h4r3WvooH9h44wsEIuK0bvesHv0OSh1r5LZE+Z97JeXytbWS0RiTN8yVNPUeT30V7vEVzTYfL36h6P77gHYJh+kdbvDbFA99113TQ1pZgbV0YU1KdxS9GnCOI5L/uomIWAUpzZ3Eo72fLwPBcSBKmYn8iFB5AMOxhlFCRnAfe7rHQE5/ZzX6eDRA== X-OriginatorOrg: ti.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 15 Sep 2026 09:55:42.5872 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 027cee5c-4561-4aa2-c9e6-08df130f8172 X-MS-Exchange-CrossTenant-Id: e5b49634-450b-4709-8abb-1e2b19b982b7 X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=e5b49634-450b-4709-8abb-1e2b19b982b7;Ip=[198.47.23.195];Helo=[lewvzet201.ext.ti.com] X-MS-Exchange-CrossTenant-AuthSource: LV8PEPF0000006B.namprd03.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: DS0PR10MB8030 X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwOTE1MDE0MyBTYWx0ZWRfX9yi0YUH5ZJUs auh/rvhGIM6MWeBklML42zGQS0fllkNIgWXYVK7Zfx1dECULVLN5wRzdfs8gaBEQ98VJUnjE7+c dMbqTQ0nclYUOPwahg5X186vhX3Qu4kgFA0D0WjImtyLnaTTudwhQ5VwFReP5GQkYGPxJc/LW4y fjOf2VITR8ScUxyaNUj2tCe6HmChkrEFgNPcEPGEVqdRyYdN8M27KEAsYqoMQmVcQWO/5BLGyH9 2b+YaaKMdjp7aYDvrU4dcW07xaZpqFT7RHmsdX5VcEV/eD0HmIgyZLLwQFvLNRciuDlWzKSAkAE eEpfGQ738ugQubtsTcB2a9YNzLqYgVNM532/MoLDBcQBLVCUYh8Me2Wicqr2uuOeNZ8J+vbDxZy UiSbjUUthrnMGxtMECe7qR7ygsGn7vLHxPb78rsNq10vcVZ7yvY3pn2TMffRW1J4hga5gwFNgkg c5v2Ze31aWmO/LBsGEQ== X-Proofpoint-ORIG-GUID: uM33ziilSjzKk7z2olrJ3MJjtAGDX3sE X-Authority-Analysis: v=2.4 cv=U7cHnuru c=1 sm=1 tr=0 ts=6aa91621 cx=c_pps a=aSTqfDprWv2neSIyXEkWYQ==:117 a=f+v6EHfkeJbVwR46tk4DMg==:17 a=6eWqkTHjU83fiwn7nKZWdM+Sl24=:19 a=IkcTkHD0fZMA:10 a=VdqzKS8jKosA:10 a=s63m1ICgrNkA:10 a=V5UXEbMT0ywA:10 a=VkNPw1HP01LnGYTKEx00:22 a=Z8NIEmU8O1QQgoT56wFK:22 a=taLDd7a_hP9WKsMzeGRc:22 a=sozttTNsAAAA:8 a=IihQRFl1KD1MKXbbWYkA:9 a=QEXdDO2ut3YA:10 X-Proofpoint-GUID: uM33ziilSjzKk7z2olrJ3MJjtAGDX3sE X-Proofpoint-Spam-Info: AW1haW4tMjYwOTE1MDE0MyBTYWx0ZWRfX7ZPBdC7G1JdC P3va7qqtXerJOtzc9GAvw6LiFyC0VyI59B+1x1GWr8E7PvoUsw3S57ToBRjytC50TBbCWriCjIw 92U4IBppJYMHnzgiYptAA3WTSyuEOz0= X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1176,Hydra:6.1.134,FMLib:17.12.100.49 definitions=2026-09-15_03,2026-09-14_02,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 priorityscore=1501 phishscore=0 lowpriorityscore=0 suspectscore=0 impostorscore=0 malwarescore=0 bulkscore=0 clxscore=1011 spamscore=0 adultscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2609040000 definitions=main-2609150143 These are assigned but never used. Remove them. Assisted-by: Sisyphus:claude-sonnet-4-6 Signed-off-by: Manorit Chawdhry --- drivers/crypto/sa2ul.c | 8 -------- 1 file changed, 8 deletions(-) diff --git a/drivers/crypto/sa2ul.c b/drivers/crypto/sa2ul.c index 3297a25d9d9d..e49cb741074f 100644 --- a/drivers/crypto/sa2ul.c +++ b/drivers/crypto/sa2ul.c @@ -95,16 +95,12 @@ static struct device *sa_k3_dev; * @enc_eng_id: Encryption Engine ID supported by the SA hardware * @auth_eng_id: Authentication Engine ID * @iv_size: Initialization Vector size - * @akey: Authentication key - * @akey_len: Authentication key length * @enc: True, if this is an encode request */ struct sa_cmdl_cfg { u8 enc_eng_id; u8 auth_eng_id; u8 iv_size; - const u8 *akey; - u16 akey_len; bool enc; }; =20 @@ -1423,8 +1419,6 @@ static int sa_sha_setup(struct sa_tfm_ctx *ctx, struc= t algo_data *ad) cfg.enc_eng_id =3D ad->enc_eng.eng_id; cfg.auth_eng_id =3D ad->auth_eng.eng_id; cfg.iv_size =3D 0; - cfg.akey =3D NULL; - cfg.akey_len =3D 0; =20 ctx->dev_data =3D dev_get_drvdata(sa_k3_dev); /* Setup Encryption Security Context & Command label template */ @@ -1764,8 +1758,6 @@ static int sa_aead_setkey(struct crypto_aead *authenc, cfg.enc_eng_id =3D ad->enc_eng.eng_id; cfg.auth_eng_id =3D ad->auth_eng.eng_id; cfg.iv_size =3D crypto_aead_ivsize(authenc); - cfg.akey =3D keys.authkey; - cfg.akey_len =3D keys.authkeylen; =20 /* Setup Encryption Security Context & Command label template */ if (sa_init_sc(&ctx->enc, ctx->dev_data->match_data, keys.enckey, --=20 2.43.0 From nobody Fri Sep 25 12:05:54 2026 Received: from mx0a-0002e601.pphosted.com (mx0a-0002e601.pphosted.com [148.163.150.75]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 9E54B3F5BE6; Tue, 15 Sep 2026 09:55:50 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=fail smtp.client-ip=148.163.150.75 ARC-Seal: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1789466156; cv=fail; b=gFfHSDVbRsp6a/3m6GJ3oRkVpKo/K+3vMTgSJGXEtBfV4bmx0U0qHbTqkc0XBXB5qjPI+U2xIEdKYvB0Ryf8bhZ1wqGC2BWaMNortBb8xWEM2/D3ywqEJxXPgrg1yeqsxodOj8zcc2q5lhYfv33111E0VDpesHts1cWmPecvO/Q= ARC-Message-Signature: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1789466156; c=relaxed/simple; bh=f776/xSGZNmFlHqNFJsC4rS5WI7Ha0k5aagWwm4uup4=; h=From:Date:Subject:MIME-Version:Content-Type:Message-ID:References: In-Reply-To:To:CC; b=JITX0V15nF2HPfiMj4yMCiPDq+gGhBWmY7Z0o60cQhI7JcHkgKbRm5RG0HpxVmqQdfuWv2lejR4PJDX+P934+t6CZb334izVZ5wcUdMsTGww6bfqwZAV7bwEwoDfnB/Na5fkvOm98WhdlfxbDWEtMaHcOGwIL825rliiI2Hhrlw= ARC-Authentication-Results: i=2; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=ti.com; spf=pass smtp.mailfrom=ti.com; dkim=pass (2048-bit key) header.d=ti.com header.i=@ti.com header.b=Mricg0Go; dkim=pass (1024-bit key) header.d=ti.com header.i=@ti.com header.b=KZ7nv/kw; arc=fail smtp.client-ip=148.163.150.75 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=ti.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=ti.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=ti.com header.i=@ti.com header.b="Mricg0Go"; dkim=pass (1024-bit key) header.d=ti.com header.i=@ti.com header.b="KZ7nv/kw" Received: from pps.filterd (m0384305.ppops.net [127.0.0.1]) by m0384305.ppops.net (8.18.1.11/8.18.1.11) with ESMTP id 68F9eiA51480537; Tue, 15 Sep 2026 04:55:43 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ti.com; h=cc :content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s= proofpoint-05-2026; bh=Yn4dkRkqN0VzEoTnsOy6XnQbkaduRmXMVTPgZoRpd yE=; b=Mricg0GoPBit/8rMhvmwFfjg+v+DCWodv5ZFuA0HSEBgjnQ1KlAm82JGc DFRzzIwgp9lmJYQXGrTHKDP6Eesr+w9MGfG9kR12LOJgTUMxsXiIoncAJrLorOF4 BtRsXa+iJn9HCyKNo9ku/o/X07bIs66SuC+lUUHqJHtTEL71/YBSW/jOcL3Nygo6 Ie9KprZXb0lBY4/Otftrz/nRJkKRL4l9DLl/FH/UmByvWFCjZRqMOZyGu3hJc0DV h1wp3IvEAVGbnsYV+DkauWGHD99GGIRvTqM6PYbV2oLukIh1rjL7PM20+bJWumBW XdlpWSXiCa9lOFAlof6zxmhWDSpNw== Received: from sn4pr2101cu001.outbound.protection.outlook.com (mail-southcentralusazon11012050.outbound.protection.outlook.com [40.93.195.50]) by m0384305.ppops.net (PPS) with ESMTPS id 4gpvpa2hwu-1 (version=TLSv1.3 cipher=TLS_AES_256_GCM_SHA384 bits=256 verify=NOT); Tue, 15 Sep 2026 04:55:43 -0500 (CDT) ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=OLpR5XAuqiX2xq7mUS/ac1Y9kkto008IAAYZvPqJpp7J0LhCX8v9XcVSGqmP5hD44w3uTWnSDmXQvN3aRdayp6C3bVdjv7LGos9C/2hKe+peYLAgeqoWCf9SmJ7G9k3pwx6RGyepIM/pSIKsbhLskjT0QB3H3lKTbZNL90E02xqDNCx0/pFFfps066HvwKMAuSmq+7AsCmqbDvzJ0n6S88bLaxahlJQ7m6yeWPEKecl93l6+pO+5ex0gH8YwzRMC3J2T+mp0UF14U4AD0m9Aq8fI9LMuWRmu9+e+pU+HW1a2Ivs5NYisgSMw5DvDd/Bck+2qXet1JmUALfYIkdfhkQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=Yn4dkRkqN0VzEoTnsOy6XnQbkaduRmXMVTPgZoRpdyE=; b=pb9dt+kMZyrmF+7FcNiujlZBcypVe1TwVNCKU5r7rIi77cWXJuitG8YQRAS/ALT305StjClal9dr/lK9r6ogQJ7f/+8XaDamV5FXqLDni7Dc4pOkcvV0F991HbSHq//fvJz62PG3tzqQQZ5VDLLs5xcuzDISEmndoym5j6sDX5imFCbXVc61MS6TrbeSYAKB3QvN5IHmzSmPSNakf2mbPuzVd0RX41GOwcopf3pyvxB7n7Zl+Rgl7lqZT8pFddLuaktuVJnz0nZD3lfkkfhPqPpacmQp4EOlNu1L1bIZFcUzd/qEo3r0VEy3XUF4tqS8M3cqOgmC9bspxlVVe1OggA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 198.47.23.194) smtp.rcpttodomain=vger.kernel.org smtp.mailfrom=ti.com; dmarc=pass (p=quarantine sp=none pct=100) action=none header.from=ti.com; dkim=none (message not signed); arc=none (0) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ti.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=Yn4dkRkqN0VzEoTnsOy6XnQbkaduRmXMVTPgZoRpdyE=; b=KZ7nv/kwyVa3Hf+g1nFKKkfKAvq3tgeXtMZOgTOGMx4ClK5kHVG2Hk//g/E3RptykXjMsK/COP6/QnilId9as1Cu4HUiR6FW/CuPSOAtAYLUIW5BN2xN9EB/pH6ERjSGNIJjtJnqSdBfiHhAewYL8p9o9EEWntO+aIRwjrDUcOQ= Received: from BY1P220CA0047.NAMP220.PROD.OUTLOOK.COM (2603:10b6:a03:59e::9) by IA1PR10MB7261.namprd10.prod.outlook.com (2603:10b6:208:3f6::11) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.21.428.8; Tue, 15 Sep 2026 09:55:40 +0000 Received: from SJ5PEPF000001CD.namprd05.prod.outlook.com (2603:10b6:a03:59e:cafe::2a) by BY1P220CA0047.outlook.office365.com (2603:10b6:a03:59e::9) with Microsoft SMTP Server (version=TLS1_3, cipher=TLS_AES_256_GCM_SHA384) id 15.21.406.12 via Frontend Transport; Tue, 15 Sep 2026 09:55:40 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 198.47.23.194) smtp.mailfrom=ti.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=ti.com; Received-SPF: Pass (protection.outlook.com: domain of ti.com designates 198.47.23.194 as permitted sender) receiver=protection.outlook.com; client-ip=198.47.23.194; helo=lewvzet200.ext.ti.com; pr=C Received: from lewvzet200.ext.ti.com (198.47.23.194) by SJ5PEPF000001CD.mail.protection.outlook.com (10.167.242.42) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.21.428.7 via Frontend Transport; Tue, 15 Sep 2026 09:55:40 +0000 Received: from DLEE205.ent.ti.com (157.170.170.85) by lewvzet200.ext.ti.com (10.4.14.103) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.2562.45; Tue, 15 Sep 2026 04:55:32 -0500 Received: from DLEE207.ent.ti.com (157.170.170.95) by DLEE205.ent.ti.com (157.170.170.85) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.2562.45; Tue, 15 Sep 2026 04:55:32 -0500 Received: from lelvem-mr06.itg.ti.com (10.180.75.8) by DLEE207.ent.ti.com (157.170.170.95) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.2562.45 via Frontend Transport; Tue, 15 Sep 2026 04:55:32 -0500 Received: from uda0497581-ant.dhcp.ti.com (uda0497581-ant.dhcp.ti.com [10.24.51.159]) by lelvem-mr06.itg.ti.com (8.18.1/8.18.1) with ESMTP id 68F9tB7t3000901; Tue, 15 Sep 2026 04:55:29 -0500 From: Manorit Chawdhry Date: Tue, 15 Sep 2026 15:25:11 +0530 Subject: [PATCH 05/30] crypto: sa2ul - remove unused fields from sa_tfm_ctx Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-ID: <20260915-b4-upstream-sa2ul-cleanup-v1-5-57ab34e97162@ti.com> References: <20260915-b4-upstream-sa2ul-cleanup-v1-0-57ab34e97162@ti.com> In-Reply-To: <20260915-b4-upstream-sa2ul-cleanup-v1-0-57ab34e97162@ti.com> To: Herbert Xu , "David S. Miller" , Keerthy , Colin Ian King CC: Andrew Davis , Pratham T , "Kamlesh Gurudasani" , Udit Kumar , , , "Manorit Chawdhry" X-Mailer: b4 0.15.2 X-Developer-Signature: v=1; a=ed25519-sha256; t=1789466112; l=1389; i=m-chawdhry@ti.com; s=20231127; h=from:subject:message-id; bh=f776/xSGZNmFlHqNFJsC4rS5WI7Ha0k5aagWwm4uup4=; b=gKqeTyk24k8wEMMBXIJlr6+zY7ayyFc2WNtq2hyGO+ti6bap2RLFCeJKp/o3LYS8vjlsuVYtP y537Ic0//+RALQaqLFKDAQRtpJ623k9PERwasXEc0DfkjFgugwXU7oF X-Developer-Key: i=m-chawdhry@ti.com; a=ed25519; pk=fsr6Tm39TvsTgfyfFQLk+nnqIz2sBA1PthfqqfiiYSs= X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: SJ5PEPF000001CD:EE_|IA1PR10MB7261:EE_ X-MS-Office365-Filtering-Correlation-Id: af2bdf00-7fd3-4f45-0902-08df130f801f X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|23010399003|1800799024|82310400026|376014|36860700016|18002099003|22082099003|56012099006|10067099003; X-Microsoft-Antispam-Message-Info: ZOwJp2pQY3fjQKh/FU9HSfvx2+nMXE0/tizZK2mEl+Jsj7Ib92SzN5gW4FLgHJ/VZYM9g/PMOh3A9kDBvnDjrf5idNLk+EMqPT6JNSaYJeK6mKNUndIgXA/G6h2cNvOhZ/O8X3ZPAun/Sa7hWXhV0W3JHkQ2ZmMmXgAzGq15WLV+ACQA/IhBR/6HjyKd4FOAjiwsWoRUNVT1Pyzkc8+/O+j3lrMPiLR+GbWTdR1o5d2IVujm/cm45EC0KIDfiCyXYjxM6/GrEpfsrs8E0R8BZY2/T3RoRREyNgKIjbKI9XrYw9bDmosQHYpA1hzRhBhjfUGnna7yNitE+PjdSpSyXBKjO5oab41OWKl2xNN69GsUToeagI5L5TGjbrIW6dKdiByz0ezmYb4PvmCOM8/ku2FJ2TJGVrsoOZw0h/Qiu8dntntZZKb3YLW8LVMYAO6WA7JEzsd3yHoY84O+dWC5IGJBRclo0RMmJd6I+YmTG+UrkLUhMWxXINENX3Ajw6qDiTUS1tnftSnG3lD5iuxcXxPc2n2y8ZK6YRW7SvahVvKbjn5PvqFXai5vH5A/MPuzb+t81Zkm0TRC7rdxtNTcWymn8slL0ZqIO7Yj6wR3g8FPMEWS0h4ZrhtBeQXgsGnoFYHAJ3eNHvZWlL7PW3iBrlfFzvv3TK8aC+VQrEN8OCbkoW28dBghQBnpk3PJog3uIUfuwRRPsM0OE3dzd+skOA== X-Forefront-Antispam-Report: CIP:198.47.23.194;CTRY:US;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:lewvzet200.ext.ti.com;PTR:InfoDomainNonexistent;CAT:NONE;SFS:(13230040)(23010399003)(1800799024)(82310400026)(376014)(36860700016)(18002099003)(22082099003)(56012099006)(10067099003);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: n46UngNE+MF7zD4yX71v/x0pC992eN87i5WK2qEMGEa2dkeDcu6zN+O7LceV3jJ18+ZbFQH7NrpdQ3ff/D7iwDlE+vvAHRomwsiw7anr5wx9zYXTZwVnxQE6IjYOZqz53C3h/msVxmw6GbRKRpj/jFYogS1+xFqqCnuWVSf33aEYUvtWu1BPOVZdhIcnWwCQhiWxxvbOI6ouc7Out47s35G5oneeaYyvFGjCctbI5epCJ4gkCpdiiagFwdvgA6UOqZRgdtRVAdTbX98pLzLSDGLekYMdBw0t8tw7QQi/Lp3rQKSn5tGO+iOlmujzRfFSp0WgT3rvpSlB1Gi31iWDYzQsx8+hn+POB/WX65O+NmwwztxU05U2V3S/ZbmCoihJABoktHICJ/8gi0iN7vqJ1jPOw+hPaIiBqFSWP3qZi/eW2sEd+ktc3AGWN4niPyAt X-Exchange-RoutingPolicyChecked: n5CbPlMfuzXVeu8Ntx58uf/UWw82vZ1SB4RJHUYWoYijXQN03ef6CuI3K7p7pAm5A/dNhaAPXAa013yZ16PUFRu7s4uOomD9HEObW/nqO2cSdCjTRpmTsDn1/ci7hzQZZu9cXMWzZyhhUta2wfH/nj3Tr9xCFhWT3809ZbXD1slqf5Rzz/pUt+GFfdcTc2SVhf5gcrgsdiTHnGd8PnryYINa8mXG0RRvJYZb10m4/zzFFD8t8CUAZmGucOH6t3npR1wizwANr/6FpgGFDGDvDDA+LKiZDofMojWyXqxkd+ajergA4T+EGaBrO0NcteW4Zruuv7psax0iEF8H3KoH2g== X-OriginatorOrg: ti.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 15 Sep 2026 09:55:40.3539 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: af2bdf00-7fd3-4f45-0902-08df130f801f X-MS-Exchange-CrossTenant-Id: e5b49634-450b-4709-8abb-1e2b19b982b7 X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=e5b49634-450b-4709-8abb-1e2b19b982b7;Ip=[198.47.23.194];Helo=[lewvzet200.ext.ti.com] X-MS-Exchange-CrossTenant-AuthSource: SJ5PEPF000001CD.namprd05.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: IA1PR10MB7261 X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwOTE1MDE0MyBTYWx0ZWRfX4mB2ayhdp6Cb ltT3EshApBLGBtHNlry+Y3n0xoNrt93SmaCXqIrvd3L1wbHYGTFOhNzW/cYnXWnZekYWNS6h2+R nXx5qKH/Bu10dBxI1N2XncE/yzqCEknnVUNIMlj3Cakty/2Fmn7O4uNKp5u+dDmipsc3+DBJJd3 LSdr5RsGWSSVar6SkfkLh+Z2ANXbvXgaIz+Ag+iJlqz4lZ7NlzEKfInN1+9mS8OuHYelK+QdHC7 r4YRcb3aaTjSB4Q7iw2iLxehTreH/XqqA3yloAl140PQL3Vg4zist6PgAmjzQ2/6eLG+NkfvZqE edHU+vMEiJrS15U7YmoEwcukTxCEabaQEhhFn3/N8m9F/7yuagsVeMs4BT9yhi1Uqs+3vURT4xS VBja+maG1TqitJ8e9MXbA5QUFbfEpwa723D4mZcv2ZSOEZ7lgIx8DqSjVbukkDaRwHPjM6fUSve CJK5mhNDsfvk19iDqXA== X-Proofpoint-ORIG-GUID: W0XCx7ou0ZMNEgd1sepiKNEwadyVR1pg X-Authority-Analysis: v=2.4 cv=U7cHnuru c=1 sm=1 tr=0 ts=6aa9161f cx=c_pps a=SMA1khf41ao6nOkIv5XeTA==:117 a=WotqVVQAdb04rnGuttW3Kw==:17 a=6eWqkTHjU83fiwn7nKZWdM+Sl24=:19 a=IkcTkHD0fZMA:10 a=VdqzKS8jKosA:10 a=s63m1ICgrNkA:10 a=V5UXEbMT0ywA:10 a=VkNPw1HP01LnGYTKEx00:22 a=Z8NIEmU8O1QQgoT56wFK:22 a=taLDd7a_hP9WKsMzeGRc:22 a=sozttTNsAAAA:8 a=Tr8g2v-ZAkrEVrEOxdQA:9 a=QEXdDO2ut3YA:10 X-Proofpoint-GUID: W0XCx7ou0ZMNEgd1sepiKNEwadyVR1pg X-Proofpoint-Spam-Info: AW1haW4tMjYwOTE1MDE0MyBTYWx0ZWRfXxSZeSXUzWKlm ns3kdwleFa9b/teTHiyHIMFV+Xig32ILa20ej2ma81EV9CUSUxKsDQVXWIdzyWoHXrY3xhs64YQ BZMa1vApok0NGRevx86TkbMA6ocPUcY= X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1176,Hydra:6.1.134,FMLib:17.12.100.49 definitions=2026-09-15_03,2026-09-14_02,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 priorityscore=1501 phishscore=0 lowpriorityscore=0 suspectscore=0 impostorscore=0 malwarescore=0 bulkscore=0 clxscore=1011 spamscore=0 adultscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2609040000 definitions=main-2609150143 Dead assignment. Remove it. Assisted-by: Sisyphus:claude-sonnet-4-6 Signed-off-by: Manorit Chawdhry --- drivers/crypto/sa2ul.c | 2 -- drivers/crypto/sa2ul.h | 2 -- 2 files changed, 4 deletions(-) diff --git a/drivers/crypto/sa2ul.c b/drivers/crypto/sa2ul.c index e49cb741074f..b36437d76891 100644 --- a/drivers/crypto/sa2ul.c +++ b/drivers/crypto/sa2ul.c @@ -1406,7 +1406,6 @@ static int sa_sha_run(struct ahash_request *req) =20 static int sa_sha_setup(struct sa_tfm_ctx *ctx, struct algo_data *ad) { - int bs =3D crypto_shash_blocksize(ctx->shash); int cmdl_len; struct sa_cmdl_cfg cfg; =20 @@ -1414,7 +1413,6 @@ static int sa_sha_setup(struct sa_tfm_ctx *ctx, struc= t algo_data *ad) ad->auth_eng.eng_id =3D SA_ENG_ID_AM1; ad->auth_eng.sc_size =3D SA_CTX_AUTH_TYPE2_SZ; =20 - memset(ctx->authkey, 0, bs); memset(&cfg, 0, sizeof(cfg)); cfg.enc_eng_id =3D ad->enc_eng.eng_id; cfg.auth_eng_id =3D ad->auth_eng.eng_id; diff --git a/drivers/crypto/sa2ul.h b/drivers/crypto/sa2ul.h index 097a496067e1..f29e0b9ac82f 100644 --- a/drivers/crypto/sa2ul.h +++ b/drivers/crypto/sa2ul.h @@ -293,8 +293,6 @@ struct sa_tfm_ctx { struct sa_ctx_info dec; int keylen; int iv_idx; - u32 key[AES_KEYSIZE_256 / sizeof(u32)]; - u8 authkey[SHA512_BLOCK_SIZE]; struct crypto_shash *shash; /* for fallback */ union { --=20 2.43.0 From nobody Fri Sep 25 12:05:54 2026 Received: from mx0a-0002e601.pphosted.com (mx0a-0002e601.pphosted.com [148.163.150.75]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 7C1FF47ECFE; Tue, 15 Sep 2026 09:55:58 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=fail smtp.client-ip=148.163.150.75 ARC-Seal: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1789466161; cv=fail; b=FbFhFKy7Gi/tZCdwOC82LcDu7hB9xddA36j+m3eb6cY4nxdSHXwtvl1VmjFm/wAgrErU40GuHORoQ/GfneLrhkXVImkSjWnfOKoPZ0fHiEM72u8nOLZANnw2yThjam03F9cy7PBtPy3qxlKXKD4D+N/KH5GjWLcP1UGneVuE9EU= ARC-Message-Signature: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1789466161; c=relaxed/simple; bh=KnkPKMAyjq2bR6cmRQloZFb0uvKnPoxSF4KsztwSNLY=; h=From:Date:Subject:MIME-Version:Content-Type:Message-ID:References: In-Reply-To:To:CC; b=HBPnKHwCedUxEchlob/mtnXJau65rVquLH78wV8/X7wBSCeDp3fhqW1I0+5dRfUw3jsp1Xz87ycldRGJ2g6iH70ayr5ApHpeo3b4dME5Mel3bUBPdNiph6d7XkH2CCxl/BSS3Ax37cQa6SYa8B4NhWILvSbHwJIJ/oExMxT1WsQ= ARC-Authentication-Results: i=2; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=ti.com; spf=pass smtp.mailfrom=ti.com; dkim=pass (2048-bit key) header.d=ti.com header.i=@ti.com header.b=UmGaARqc; dkim=pass (1024-bit key) header.d=ti.com header.i=@ti.com header.b=KD6JYSXv; arc=fail smtp.client-ip=148.163.150.75 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=ti.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=ti.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=ti.com header.i=@ti.com header.b="UmGaARqc"; dkim=pass (1024-bit key) header.d=ti.com header.i=@ti.com header.b="KD6JYSXv" Received: from pps.filterd (m0380145.ppops.net [127.0.0.1]) by m0380145.ppops.net (8.18.1.11/8.18.1.11) with ESMTP id 68F9etXH3889353; Tue, 15 Sep 2026 04:55:53 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ti.com; h=cc :content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s= proofpoint-05-2026; bh=fb8wyf/18tssSNzOAPMIsBnpi/X7UN2LaPte23nvB 14=; b=UmGaARqcb55ex7e2KM0j62vjMT+iXx4WQojAZSNeF7PR5BKcd+AnQ3g15 0lv+EvKOMjOt/ULEE/py14c1GpdeHnb9JeBtb/WscFfzlefGepg+0PQs9qhOPLXX kbC6td0Qq8k6cOHpCoPs+qftC4Jk3qVRrZL4SP2lcVj1xnSfdPXixLaCW4GTT0m/ fU1y58HiFunZkCoGlXRXu7bCYPUVahwqt8uUo/YEvnSy9oHcu2bxC+C2OKWLoyjv 5vLjilN/iIbkxdwBbo8TQWs5WJNBv/BPL9eIIu3bStY9jiVmXhRNvyzYkNx4kPv/ lEe9kK9tbFM9KdhxBTMeuQkwwt3oQ== Received: from dm1pr04cu001.outbound.protection.outlook.com (mail-centralusazon11010001.outbound.protection.outlook.com [52.101.61.1]) by m0380145.ppops.net (PPS) with ESMTPS id 4gppxsm9eg-1 (version=TLSv1.3 cipher=TLS_AES_256_GCM_SHA384 bits=256 verify=NOT); Tue, 15 Sep 2026 04:55:53 -0500 (CDT) ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=q/KHC83DiXu3vzrQhNP7QifzstWsJ/cDpfmn/y87rKpBFpk5j6OjG81XpJXoNd+aS+Tq9XpgqKX/0dLgMNbIvqnciONTrVahV3B0BXfmyAYP3AzVB9/ZOPhVP/Vqkx574lmHWAhWDdn9+0sQd6ZYXT4AiWZQWmzzv9c5ZGPiyEdu8L/i0hA+ysCElGbJZSEsN0kGkQ/tuDvitmS2j1Mmof7qW34DEXQtDHIuPrQCDnLrJYNm0koWg53t3HBmBSh/giyNUk6ud9o8/EMLnlSBuD9FwItufWKbXfbMXBYHOwMZXKWky9s8VtvAAEvy9voU/Pns0aUvt3U1NjElKwYPeQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=fb8wyf/18tssSNzOAPMIsBnpi/X7UN2LaPte23nvB14=; b=MC0ERPNJwjwKEDdda2pwmUk8d1Lcj61ZKtkxqm06ct9AlCgx+eRphpY+7/6ppbX+ineJZ5UZm3cWG+3je0HssKWtR0m0ku9dcXqFcsivHh2wCMJCiRltWmMfdPhd4iQdTIgHFjwSGdcPefIh33PmC1eSXugSxwoqyEB7UQASViuJ+qH1UHk5cxOTVDfDrC+/Dlbby5TnRvevztM0AWa1hF/Sg/Q5V/J8GiFo/Q6NGCeLCN7kjZz9ZZWMZiec7rHU/ifDBSPFCwKNTA9mHMVUvtBCk7zItREOOZ8rsgdcLCZo9/9AQuhRR8w88TK58Y2aAJ7GhBBI6qAXFvGeoF+7vg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 198.47.23.195) smtp.rcpttodomain=vger.kernel.org smtp.mailfrom=ti.com; dmarc=pass (p=quarantine sp=none pct=100) action=none header.from=ti.com; dkim=none (message not signed); arc=none (0) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ti.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=fb8wyf/18tssSNzOAPMIsBnpi/X7UN2LaPte23nvB14=; b=KD6JYSXvKqckol610oNrYj+hf19HmGPapPkaVOyHeIDU0mOo3j0FjkAeojl0RX3Q/ZW0/O0KKwQGfj/hqzOp4JwlRkH3Xu2h9N+7ZC6zwf8YkyyjklrkThfL4JIL4wIPCmFkdQPrcdnqO9L9zK2wbrXj/4n+cgYxFfUhufB90Js= Received: from BN9PR03CA0553.namprd03.prod.outlook.com (2603:10b6:408:138::18) by CY8PR10MB6514.namprd10.prod.outlook.com (2603:10b6:930:5e::17) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.21.428.7; Tue, 15 Sep 2026 09:55:50 +0000 Received: from LV8PEPF0000006B.namprd03.prod.outlook.com (2603:10b6:408:138:cafe::10) by BN9PR03CA0553.outlook.office365.com (2603:10b6:408:138::18) with Microsoft SMTP Server (version=TLS1_3, cipher=TLS_AES_256_GCM_SHA384) id 15.21.406.10 via Frontend Transport; Tue, 15 Sep 2026 09:55:50 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 198.47.23.195) smtp.mailfrom=ti.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=ti.com; Received-SPF: Pass (protection.outlook.com: domain of ti.com designates 198.47.23.195 as permitted sender) receiver=protection.outlook.com; client-ip=198.47.23.195; helo=lewvzet201.ext.ti.com; pr=C Received: from lewvzet201.ext.ti.com (198.47.23.195) by LV8PEPF0000006B.mail.protection.outlook.com (10.167.248.40) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.21.428.7 via Frontend Transport; Tue, 15 Sep 2026 09:55:50 +0000 Received: from DLEE204.ent.ti.com (157.170.170.84) by lewvzet201.ext.ti.com (10.4.14.104) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.2562.45; Tue, 15 Sep 2026 04:55:35 -0500 Received: from DLEE210.ent.ti.com (157.170.170.112) by DLEE204.ent.ti.com (157.170.170.84) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.2562.45; Tue, 15 Sep 2026 04:55:35 -0500 Received: from lelvem-mr06.itg.ti.com (10.180.75.8) by DLEE210.ent.ti.com (157.170.170.112) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.2562.45 via Frontend Transport; Tue, 15 Sep 2026 04:55:35 -0500 Received: from uda0497581-ant.dhcp.ti.com (uda0497581-ant.dhcp.ti.com [10.24.51.159]) by lelvem-mr06.itg.ti.com (8.18.1/8.18.1) with ESMTP id 68F9tB7u3000901; Tue, 15 Sep 2026 04:55:32 -0500 From: Manorit Chawdhry Date: Tue, 15 Sep 2026 15:25:12 +0530 Subject: [PATCH 06/30] crypto: sa2ul - remove unused macro definitions Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-ID: <20260915-b4-upstream-sa2ul-cleanup-v1-6-57ab34e97162@ti.com> References: <20260915-b4-upstream-sa2ul-cleanup-v1-0-57ab34e97162@ti.com> In-Reply-To: <20260915-b4-upstream-sa2ul-cleanup-v1-0-57ab34e97162@ti.com> To: Herbert Xu , "David S. Miller" , Keerthy , Colin Ian King CC: Andrew Davis , Pratham T , "Kamlesh Gurudasani" , Udit Kumar , , , "Manorit Chawdhry" X-Mailer: b4 0.15.2 X-Developer-Signature: v=1; a=ed25519-sha256; t=1789466112; l=1126; i=m-chawdhry@ti.com; s=20231127; h=from:subject:message-id; bh=KnkPKMAyjq2bR6cmRQloZFb0uvKnPoxSF4KsztwSNLY=; b=smY/zG90CLDwf/97BUaipVhviBYNOXUnl0fccTfcHrcf7WSVtieGVurZZv18r/pEAyKyA6zoP fd9Evph7PRjBh/k35JVR4P13MzbFtEz34N3+69J7ukMMOTziUDxw6lO X-Developer-Key: i=m-chawdhry@ti.com; a=ed25519; pk=fsr6Tm39TvsTgfyfFQLk+nnqIz2sBA1PthfqqfiiYSs= X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: LV8PEPF0000006B:EE_|CY8PR10MB6514:EE_ X-MS-Office365-Filtering-Correlation-Id: 2804e1cb-ee42-40b3-00b8-08df130f8604 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|36860700016|23010399003|82310400026|376014|1800799024|10067099003|6133799003|56012099006|22082099003|18002099003; X-Microsoft-Antispam-Message-Info: eap6sgLJAEoUPWtG0zsWQxSMajgMTJFH8heALCTWTIJKfOtB/ePnCZ9/ryFvRdzBz0YWZmlgGW58Cft8cuI9GnOkF75nEDswq2NOkvNsCjrqh2HiLE0dQSTFeKKfeqbUD4YwAsdFTcdslfUV5xVQ3vWQy/DgBlhyVhOE+RueIpVG14gBq0D37Rk60UAXl4X3V8svCpSVpbMvb/LbvqxJNqonQkBFam2yVoCaF4fJYr8bklB1lMgrW2skuEhkdjRrhF3YEV5lSPog3pE5wVnc0d7/9wJ3eQhvvMP5hZYRQG+DH9bWvZLnz2updoNbzSOo8c+OSLjx5dRx4Fi08ed29zn+6iNMT+kN0b3A4c/UG4Ed2v4jBNZcgdGLfqFIgOF46GjQpTuzJwxKrGwA0pn9RNRudqT68k6V1aS8lRbvJ47K8v7mC+45MUyyBUqquL0Fc/IGRllN0gefF3OkFKYHiJg8sTuyNujIKJY+an+QfoDas5bGqU8hwCSqL7JRNyJtxYHtgm951G8FK64APXAdFxbIXDmyBV7p6636ei18yx+axAqUuoEkxhbRlMeEIwXOhWXn1xAKe2uzFDDk4m8LqM7UEDyaIwP0lHVm/OGddPjErleTHsId3cQzdiJJApZs7otL73EkAz1xAlQkev+Vd+eazYhcNclRvDYxqZ+sA1oeeT3+MRzuWImsiSlUtujG37I9SMsepmoEXbVIMCnBwA== X-Forefront-Antispam-Report: CIP:198.47.23.195;CTRY:US;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:lewvzet201.ext.ti.com;PTR:InfoDomainNonexistent;CAT:NONE;SFS:(13230040)(36860700016)(23010399003)(82310400026)(376014)(1800799024)(10067099003)(6133799003)(56012099006)(22082099003)(18002099003);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: nv42sE8AXOp4DLX2AluPZ1ockgDRsKrx4RW0LFs4BjL4s/rLhsr9a3cnTjUQmAgjxr2b87JKdD4nRBNl9BANf/Hab95zZEbCPvxzg4tti4lGw8DvsuW+KxkCcRpp7zsZXOMzFgpCW5zT+COPELa/WQTAkW7we789W03EFvE8DDdTPvFVcP+2c6USJYsxSJv/ODKr7kk/krG7JbPFFaZ2dv5Xz0XRVjvSnoEna+6erqbDXEmouddVxtIYhzqscegor6OhgP3SQjZoQwtLBvPsjg3CZiTq7s6ixbs54Jh6WWhZ4Sh+TBCRvdcCXQ9L+hgtq9Qk4RgwJHHm2PFXUH1xgcSMls73Mb3dFYC5vi6n4hkCiVZ0SECFooYLPJjY94ZQpc82EMoZLnNBuNP0UiRCTTIcjNKcj1JDSL7J4xC6mNdb+Vwcz9GPJhZPLvfT4uRd X-Exchange-RoutingPolicyChecked: IP7DebumZSQndGOJcRiOTvlNcDf7Ujy5aUIzhLdZYrdvHGYE54C5gtgQd6djejovlzkcrZACWnF9dNfx17I62JYiqy1OjfKvlWQOMCeHvvMG/2i0cUBkEACZDdELxpJdGlCzqx7ptakm+/LCevgrlT7ueW3UDG2aI9oZgMWtZLmg0N0QdMfWThe1KBWm9c7xyn4dj0vVBn93nBSK+vzNvDiZ6FrYc2+Bwaa5YvxBca9/89lGWECchenWk5lxnOStNyKV94AjDzXKcBbBY2UVmmGyifGHOkiCDoe0jwWYvi3x4iWteuX9A2bqbOK3mNqvHFx0phb6oPUQI4wKWjDtAg== X-OriginatorOrg: ti.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 15 Sep 2026 09:55:50.2528 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 2804e1cb-ee42-40b3-00b8-08df130f8604 X-MS-Exchange-CrossTenant-Id: e5b49634-450b-4709-8abb-1e2b19b982b7 X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=e5b49634-450b-4709-8abb-1e2b19b982b7;Ip=[198.47.23.195];Helo=[lewvzet201.ext.ti.com] X-MS-Exchange-CrossTenant-AuthSource: LV8PEPF0000006B.namprd03.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: CY8PR10MB6514 X-Proofpoint-GUID: isKS_Y4xexiDCYbrv6--bqO4Ys_-DRPd X-Proofpoint-ORIG-GUID: isKS_Y4xexiDCYbrv6--bqO4Ys_-DRPd X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwOTE1MDE0MyBTYWx0ZWRfX5+rvJhJ5dWsT 9ZEMzhhiA9vXUxorJRlsbc9GMiEMo/KA7IzG8CTyMeu6ejvk0AwfBwbOo+eACHTcAGjFt/6PYqN LLYouc6178suAVhT4sj9l/FO79/mDHwh6uEmY8dpqi4nGBpTz4yWxqGi3EnK0ACU7pHzCuoO/yW VOpGtLOkfCYJxHzjxJ4cv+cw1I0mNYSvOb+/5QNdMkka1HCbrqQg24ytmxc+TTnayxbQhS8Mn+r nBHgL1Kwl94Ljv05QlIKW0cox5IXd85HW0gbe8IkaszU2WjyNJOohN+hUjdJOMQvwZf/DJBvh52 nTMIcbheesZEY85+wAl1QB1QrsBjLR80YvztG7xJ0pSC+SoaG/6OfNzZljsAiEGpEDJ6EiPvfxI RZ16w+nr7qyKyHhufFr3ti6NmQXp7sTUmBhUnzixpYmthhx5ow5vL37TCeBimjD6XoVSXJbwb53 EZW+FKOo7RLHVOySJvQ== X-Authority-Analysis: v=2.4 cv=bYP+w+PB c=1 sm=1 tr=0 ts=6aa91629 cx=c_pps a=j7tsCyGgeYHcZD8MHzM6Gw==:117 a=f+v6EHfkeJbVwR46tk4DMg==:17 a=6eWqkTHjU83fiwn7nKZWdM+Sl24=:19 a=IkcTkHD0fZMA:10 a=VdqzKS8jKosA:10 a=s63m1ICgrNkA:10 a=V5UXEbMT0ywA:10 a=VkNPw1HP01LnGYTKEx00:22 a=Z8NIEmU8O1QQgoT56wFK:22 a=gO1vWkAQAl3rybz1DQOp:22 a=sozttTNsAAAA:8 a=nOuOkeuyneYG-oPHXcEA:9 a=QEXdDO2ut3YA:10 X-Proofpoint-Spam-Info: AW1haW4tMjYwOTE1MDE0MyBTYWx0ZWRfX+poloP+c2fC9 9TA+ZJKg/RofkstQQ1HyHubxnUeBllyUeRTkN0RstlUGkyNYQ+YrQF7MLZjOd8sjO1O3m7r93Wr hcooaM2XVIE9ax1T7Zao80uAklbEvs8= X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1176,Hydra:6.1.134,FMLib:17.12.100.49 definitions=2026-09-15_03,2026-09-14_02,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 clxscore=1011 lowpriorityscore=0 priorityscore=1501 impostorscore=0 adultscore=0 suspectscore=0 phishscore=0 malwarescore=0 bulkscore=0 spamscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2609040000 definitions=main-2609150143 Remove unused macro definitions for auth functions (SA_MK_U32_AUTH, SA_AUTHSW_VALID, SA_AUTHSW_*, SA_AUTH_OP_*) and related constants. These macros were defined but never used. Assisted-by: Sisyphus:claude-sonnet-4-6 Signed-off-by: Manorit Chawdhry --- drivers/crypto/sa2ul.c | 1 - drivers/crypto/sa2ul.h | 1 - 2 files changed, 2 deletions(-) diff --git a/drivers/crypto/sa2ul.c b/drivers/crypto/sa2ul.c index b36437d76891..09cefd766c95 100644 --- a/drivers/crypto/sa2ul.c +++ b/drivers/crypto/sa2ul.c @@ -42,7 +42,6 @@ #define SA_CMDL_UPD_AUTH 0x0002 #define SA_CMDL_UPD_ENC_IV 0x0004 =20 -#define SA_AUTH_SUBKEY_LEN 16 #define SA_CMDL_PAYLOAD_LENGTH_MASK 0xFFFF #define SA_CMDL_SOP_BYPASS_LEN_MASK 0xFF000000 =20 diff --git a/drivers/crypto/sa2ul.h b/drivers/crypto/sa2ul.h index f29e0b9ac82f..0aa6a36c0f20 100644 --- a/drivers/crypto/sa2ul.h +++ b/drivers/crypto/sa2ul.h @@ -46,7 +46,6 @@ struct sa_tfm_ctx; =20 /* Number of 32 bit words in PS data */ #define SA_DMA_NUM_PS_WORDS 16 -#define NKEY_SZ 3 #define MCI_SZ 27 =20 /* --=20 2.43.0 From nobody Fri Sep 25 12:05:54 2026 Received: from mx0a-0002e601.pphosted.com (mx0a-0002e601.pphosted.com [148.163.150.75]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 8B24647F2CC; Tue, 15 Sep 2026 09:56:21 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=fail smtp.client-ip=148.163.150.75 ARC-Seal: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1789466183; cv=fail; b=qmEF3BgsmN4Vb5zhj6pUWMR0+1XsjD8oCcv93TkIyFDDUmDeJn3XrNDRlSmj1mqY5DyW91xO+QU1kYxG5qXAHwHJWcsHE4ym4PHMWn3WcsbSbDGYDf62MU/znGbTfOl9Ufab1lEH5+SbSscI/VX0D5DJeh2gheC2s0uWUoSZkVg= ARC-Message-Signature: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1789466183; c=relaxed/simple; bh=jmsa6jNIoeZ+DbILI0C5EiO1X3L0rub0JqcahmYXZLw=; h=From:Date:Subject:MIME-Version:Content-Type:Message-ID:References: In-Reply-To:To:CC; b=T0cKhslpsxWVqxu17kMLSTGhcWheiP8UeQ2jpZNiCEW/Jt4gii7Yq8pjsf9vixuBL5Df+i29nVJTF5GgUB/ixILhPAA8tuFXc1CKh2kCEd7tN8QZOxvez8Qs5PaVuK3gX2ENkQA4pyuJzu3nZwlT/kctq3Pc8HcSt3FHdHg5B78= ARC-Authentication-Results: i=2; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=ti.com; spf=pass smtp.mailfrom=ti.com; dkim=pass (2048-bit key) header.d=ti.com header.i=@ti.com header.b=XKQIAQZs; dkim=pass (1024-bit key) header.d=ti.com header.i=@ti.com header.b=BA73tGoQ; arc=fail smtp.client-ip=148.163.150.75 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=ti.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=ti.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=ti.com header.i=@ti.com header.b="XKQIAQZs"; dkim=pass (1024-bit key) header.d=ti.com header.i=@ti.com header.b="BA73tGoQ" Received: from pps.filterd (m0384305.ppops.net [127.0.0.1]) by m0384305.ppops.net (8.18.1.11/8.18.1.11) with ESMTP id 68F9eiAC1480537; Tue, 15 Sep 2026 04:56:18 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ti.com; h=cc :content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s= proofpoint-05-2026; bh=2cM2MT78SvV0O2h2a5u3sFk8QsOGIP2+m8UFGDpsV sc=; b=XKQIAQZshF7vTMPsk0xl4tRbj+R4F/K8erPCFJWtl5uetmv22CRq2k2ny x/1ymNU+WkiaXRbippT3/5c4cyEeA2pViQ+706hILkZBQsrKs8B6Ga2WLjss8ur/ uNbQBaQZzF/9DbACPcFgTQinszbDgjtFZdZQSBCb7Yy6XzZBAYk4bX4oSvA2WBnU PE/ax0R2+uBuSDl/jM7r/U5Ambs5/QU4Ip96ae8WV/V6OWXLdMdNPwvtyGyQFOYo moECQI4q6APEJnDkXWQ0CSedsw02zAbChvI2ALABhw8d+FtjWe7ktDXS9Za3Ep/e eOvccjqw0mCBxVHirqZTaDd3qitdQ== Received: from sn4pr0501cu005.outbound.protection.outlook.com (mail-southcentralusazon11011060.outbound.protection.outlook.com [40.93.194.60]) by m0384305.ppops.net (PPS) with ESMTPS id 4gpvpa2j0g-1 (version=TLSv1.3 cipher=TLS_AES_256_GCM_SHA384 bits=256 verify=NOT); Tue, 15 Sep 2026 04:56:18 -0500 (CDT) ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=CiZeJ+AMaGVPrKK1UTkRnfHX9cgEdzTr8hqD51lMCmc1xdcIPNGjCbof7utDvT29XHsBz368P87QWxVZbiTsXLP9aToAKVzKYBnHM4AHeNX+2C6hk1RaaeChf08puULh476pG8sW8WGrYZZaWtBVqWXjnRvJSo7QcTEn+VvFkp2WUdhYPmyKUvaGXWkjmwRYvZSiobxRxikwCt51o0xqH9KxDAZb+ypi+d/uJT7MDTSy2NV+ZEHNSeBK6JedboY5YBX9LvKMIVC+/pahSVO+tweXnTJfClRe8IF0B/2UzV5UPae2uxAbFZ/5t65ik6WkTp4vm9CMsB6CZTysc7hCow== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=2cM2MT78SvV0O2h2a5u3sFk8QsOGIP2+m8UFGDpsVsc=; b=mDp3g6ggSFMUxzh6hmOcLvpoUd2GDqTrJQMLUSaiv6zGFumlWRy8dnXuYt7UH+pGqx4rYif/C9BGmoiwpCPmZytyMvEcs/G6CPZ4zYzU1rKLyG3HSLSb+TGvWzwovtf4E6xW3TkXBw28h96aGr2XaNPN1YAF9pWcBrLtDiEk6u8bAF4vi6Wk739wSKJeUYOXQFm2e0olLscijGa8YdEGOitkPINU8k5Y4qqV/xJyVqbrxeM3XKWFdTAceDQKTvJ/AfJD0lzlVhhNTvdciUsYz04AtnDmzadXuOUbimmMHz6tjBvmkfELXU+uJxuon9eETFzytGwrUHRj9WgGL1WC9A== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 198.47.21.194) smtp.rcpttodomain=vger.kernel.org smtp.mailfrom=ti.com; dmarc=pass (p=quarantine sp=none pct=100) action=none header.from=ti.com; dkim=none (message not signed); arc=none (0) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ti.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=2cM2MT78SvV0O2h2a5u3sFk8QsOGIP2+m8UFGDpsVsc=; b=BA73tGoQ0ldjgg6d/q5CcGqdQosTRFioa7DwfAWh1h4E3632IKt+fnKcbDcwOOxN6xx8rjmsm1kF4+Ak9L7wXJ6Cdpze0XzEcM8t50iAaUcr/cecgtFAPZSmRpdzP/A8HTnyLVHGE1mqfervP1nliKEqdoqcrcVtoVU+pzLdh44= Received: from CH2PR10CA0013.namprd10.prod.outlook.com (2603:10b6:610:4c::23) by PH0PR10MB4568.namprd10.prod.outlook.com (2603:10b6:510:41::13) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.21.428.9; Tue, 15 Sep 2026 09:56:14 +0000 Received: from CH2PEPF0000013C.namprd02.prod.outlook.com (2603:10b6:610:4c:cafe::4d) by CH2PR10CA0013.outlook.office365.com (2603:10b6:610:4c::23) with Microsoft SMTP Server (version=TLS1_3, cipher=TLS_AES_256_GCM_SHA384) id 15.21.406.11 via Frontend Transport; Tue, 15 Sep 2026 09:56:14 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 198.47.21.194) smtp.mailfrom=ti.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=ti.com; Received-SPF: Pass (protection.outlook.com: domain of ti.com designates 198.47.21.194 as permitted sender) receiver=protection.outlook.com; client-ip=198.47.21.194; helo=flwvzet200.ext.ti.com; pr=C Received: from flwvzet200.ext.ti.com (198.47.21.194) by CH2PEPF0000013C.mail.protection.outlook.com (10.167.244.73) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.21.428.7 via Frontend Transport; Tue, 15 Sep 2026 09:56:12 +0000 Received: from DFLE201.ent.ti.com (10.64.6.59) by flwvzet200.ext.ti.com (10.248.192.31) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.2562.45; Tue, 15 Sep 2026 04:55:38 -0500 Received: from DFLE211.ent.ti.com (10.64.6.69) by DFLE201.ent.ti.com (10.64.6.59) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.2562.45; Tue, 15 Sep 2026 04:55:38 -0500 Received: from lelvem-mr06.itg.ti.com (10.180.75.8) by DFLE211.ent.ti.com (10.64.6.69) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.2562.45 via Frontend Transport; Tue, 15 Sep 2026 04:55:38 -0500 Received: from uda0497581-ant.dhcp.ti.com (uda0497581-ant.dhcp.ti.com [10.24.51.159]) by lelvem-mr06.itg.ti.com (8.18.1/8.18.1) with ESMTP id 68F9tB7v3000901; Tue, 15 Sep 2026 04:55:35 -0500 From: Manorit Chawdhry Date: Tue, 15 Sep 2026 15:25:13 +0530 Subject: [PATCH 07/30] crypto: sa2ul - consolidate encryption offset definitions Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-ID: <20260915-b4-upstream-sa2ul-cleanup-v1-7-57ab34e97162@ti.com> References: <20260915-b4-upstream-sa2ul-cleanup-v1-0-57ab34e97162@ti.com> In-Reply-To: <20260915-b4-upstream-sa2ul-cleanup-v1-0-57ab34e97162@ti.com> To: Herbert Xu , "David S. Miller" , Keerthy , Colin Ian King CC: Andrew Davis , Pratham T , "Kamlesh Gurudasani" , Udit Kumar , , , "Manorit Chawdhry" X-Mailer: b4 0.15.2 X-Developer-Signature: v=1; a=ed25519-sha256; t=1789466112; l=7390; i=m-chawdhry@ti.com; s=20231127; h=from:subject:message-id; bh=jmsa6jNIoeZ+DbILI0C5EiO1X3L0rub0JqcahmYXZLw=; b=lZHrqx3youcaPifpg/wC2ZXy5/rDOp7hm67bOuz9Im//t3H/5n0JD1XJ5jsx9OPxSSm7y5aEe xzwb/SmXkG/DUEgiZCTq9kq75ly5VRjlxx2dLBo4XWNkjrcLE1JTEUK X-Developer-Key: i=m-chawdhry@ti.com; a=ed25519; pk=fsr6Tm39TvsTgfyfFQLk+nnqIz2sBA1PthfqqfiiYSs= X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: CH2PEPF0000013C:EE_|PH0PR10MB4568:EE_ X-MS-Office365-Filtering-Correlation-Id: 85c6272a-34c1-4f57-f6f8-08df130f9379 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|376014|23010399003|1800799024|82310400026|36860700016|3023799007|56012099006|22082099003|18092099006|18002099003|10067099003; X-Microsoft-Antispam-Message-Info: v5dwrRqy8GqFWgxNM1aG/ec/UFItPSim9lw2YQLPVaMGCr7CpXH1mfGnMkVlKlkQg6X6f3EBZROqBFBZMq+otb+O5axFFEwEBRBlmE5V8d1PYcUYGiKmWfYfCbPIaJg9JUnYcTmNdnP58hSFcZ9vwIO1DQyuTxh7abWDJ6pGOyOBDINQukwRwj+rqUTDYOo0OhgBOrGAYgeyUwRL0Sp1nd8tKM+r9Q/Urf2Ss6WxWyo1joZUkvE1KQAi6VNLJ85gzt9fPsI8XNxHGaThjkif6F6byD0uLIm6VNLZLtTuZz9hs3/CukUsYa6+GTNyoRXBXRyYzkANTf+hBqc9UUnz9Rmpx3JY6eTuM+5d1T3AZAvJ+zdPFv8kKm6QucszqnsibVumuPLmY4hBmWNk7H6dClIaebFwc0Nky/ojyEJCmOS9expZc5mNsf+ZFd8QsXkgzzCWSqg+4Rb++YFdP1gpDpQtwIkMJzNpScfTsJMoPPwpRstR+BtqGt9NssH3aECu6GRXSRu7sddCgve+Gv7EVv02YzxzY/GJZT4UyTnTZtxu5zNLJLd7zlmO6uEW4z5ZJ8iVIF5IT0Rk4qJDHKGMwwS6sT6Pv7Dn80/avX/p29dEaunw6bj0avZoU3myPZTL8E3rMcDdL4x2WCr6U6EHhcy2KDyTbXE6CrUrzBpfGj2YTbbjkRTGM7muuGKqVZzIo2pjIxelVo6HU8pAnXGUcw== X-Forefront-Antispam-Report: CIP:198.47.21.194;CTRY:US;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:flwvzet200.ext.ti.com;PTR:ErrorRetry;CAT:NONE;SFS:(13230040)(376014)(23010399003)(1800799024)(82310400026)(36860700016)(3023799007)(56012099006)(22082099003)(18092099006)(18002099003)(10067099003);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: UhwROGgZVWHIIcFE31XVdI58oKFkRpRLr5ah4yiRulxK8MT1PgJVQ8+w6KqKrhD/gvd2gxEZ9c8oXUhfo/Aez0hbDPSk/N69Xxj2BYomfTIQ+K2Ck40kFtZHUC1NNJh1Uw5/M35xxiNy/zeKhUezOL4TPczsLgEQyI3o7Tngrugjm1SAVcOSGxO3wsAvrItpr6KJV7e/oNi3Vwi/YNw46gIXUDXeHPhHCZ9OBpnf1P0b95xmarUopjua8jbu+4/5rNmqI69kgsZvMyFjTLr+4SGhGuMMhcyTfnp3ILfc8HXnSYNXWR+9JRsU+a3yPpYr67Y8dQsHtSD5eYOjtcEQoAeU2LZUFDN3qRkxcKtjamYfh42PKgIeRcqu08Sd0V3TNlroht6m0H+2wWZhfsz6vJ0xcDn3zYo+Jn991eDytNpiK76+d0UfxHb3nUX6nPAU X-Exchange-RoutingPolicyChecked: Sk8NPuHNxA73SBiNpbj9q5Wu7yWH47ZdlC6/TL0T8tVhFdDR4cK1KO3Ahot0IQQFYYucyUVy7XdwdtFeJpHQzW3FSIw8mpMEOPwrcvySQECh6Caz3cJXKoPXJ1ZwC4tm890ppVm29j/m+8IWV7TpwsI8+If1lqe0GqEdyx0UGoV+wYdG11xl5EilPT1lhsyCtABigLFEWzVn05ILkllfQHXfKRa3OkVbh7RmcHLJZUvT/AtFBYQn374KKPjoyZx2ntNTEi24WzspKo60a1R4PGPMKEZSmP9db3VEmdAuVjV/xcugolAPI+++3mRpyawzmlEUTim6VpdKoYrGja7QMw== X-OriginatorOrg: ti.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 15 Sep 2026 09:56:12.8618 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 85c6272a-34c1-4f57-f6f8-08df130f9379 X-MS-Exchange-CrossTenant-Id: e5b49634-450b-4709-8abb-1e2b19b982b7 X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=e5b49634-450b-4709-8abb-1e2b19b982b7;Ip=[198.47.21.194];Helo=[flwvzet200.ext.ti.com] X-MS-Exchange-CrossTenant-AuthSource: CH2PEPF0000013C.namprd02.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH0PR10MB4568 X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwOTE1MDE0MyBTYWx0ZWRfX+RqAtS5uzpWw o6AcgbrqPvK6azg28c2DBTSXLsb6zBrC2cdSvyMJ2HWBG3CpkjC2Pg9zsKNGJXy4ZupMhKoQz0o toxzYE1wg4suaazyEcuW9ojtMDa95Y6nLNQ7aINSG1i2VqkvPLZJKJcemA4Uf61FjUSmK2XSvHg YV+xDvEhwjHt9MW4Fqoqscf+3tr3+k1QlbS53ZEAF1Q0K27aAZ3ZoABjhI+IzhWCdRe2Et5vPTc xLrqksY728EusIQPa5Lbb3oVGZVpzbx6Z9L8apobNAqMM2VyAJJ6xf0JesIj1TDP2/CG9bZ60Nb yoZ37zYntTr/bt2fN0mp9NR7vD9nUBq4VVF9MZZfO6plpdjXFhIbFMLURfOb+T8dDr+OICYHUeE NT9OOB3fkYGMhfZ9V9HzKGHTOQLVnk5rfRiEwhxFRFzcAwe+oeCALK10CDwUzFvhjraKfLk9dET vcgFalultS/Jv/el1pA== X-Proofpoint-ORIG-GUID: wVpNPa1X2yoM78i12zFwQVbXMMkzbICm X-Authority-Analysis: v=2.4 cv=U7cHnuru c=1 sm=1 tr=0 ts=6aa91642 cx=c_pps a=kwi3Ow37oS+QRMqxGNLpqg==:117 a=iwqwCZQqcuTv3JOpYdM7/Q==:17 a=6eWqkTHjU83fiwn7nKZWdM+Sl24=:19 a=IkcTkHD0fZMA:10 a=VdqzKS8jKosA:10 a=V5UXEbMT0ywA:10 a=VkNPw1HP01LnGYTKEx00:22 a=Z8NIEmU8O1QQgoT56wFK:22 a=taLDd7a_hP9WKsMzeGRc:22 a=sozttTNsAAAA:8 a=3sdfgBQbHt-tfeuNKwgA:9 a=QEXdDO2ut3YA:10 X-Proofpoint-GUID: wVpNPa1X2yoM78i12zFwQVbXMMkzbICm X-Proofpoint-Spam-Info: AW1haW4tMjYwOTE1MDE0MyBTYWx0ZWRfX2ozi4+RIv5zg Fn7o9bDK5N5M1HseElM5d7aYBOotFyXWEttnNS9DxJv0CmkFNJaLAL5G/N/jJ+mK/+jG5JU1KFd T57U9L/J7Jkdt+yf0Xd0DCF5WQpz7qA= X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1176,Hydra:6.1.134,FMLib:17.12.100.49 definitions=2026-09-15_03,2026-09-14_02,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 priorityscore=1501 phishscore=0 lowpriorityscore=0 suspectscore=0 impostorscore=0 malwarescore=0 bulkscore=0 clxscore=1015 spamscore=0 adultscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2609040000 definitions=main-2609150143 Move all SA2UL encryption offset macro definitions to a single location for better maintainability. No functional change. Assisted-by: Sisyphus:claude-sonnet-4-6 Signed-off-by: Manorit Chawdhry --- drivers/crypto/sa2ul.c | 44 ++++++++++++++++++++++++++++---------------- drivers/crypto/sa2ul.h | 13 ------------- 2 files changed, 28 insertions(+), 29 deletions(-) diff --git a/drivers/crypto/sa2ul.c b/drivers/crypto/sa2ul.c index 09cefd766c95..cde08686f27a 100644 --- a/drivers/crypto/sa2ul.c +++ b/drivers/crypto/sa2ul.c @@ -33,10 +33,23 @@ =20 #include "sa2ul.h" =20 -/* Byte offset for key in encryption security context */ -#define SC_ENC_KEY_OFFSET (1 + 27 + 4) -/* Byte offset for Aux-1 in encryption security context */ -#define SC_ENC_AUX1_OFFSET (1 + 27 + 4 + 32) +#define SC_ENC_MODESEL_OFFSET (0) +#define SC_ENC_MODESEL_SIZE (1) + +#define SC_ENC_MCI_OFFSET (SC_ENC_MODESEL_SIZE) +#define SC_ENC_MCI_SIZE (27) + +#define SC_ENC_KEY_OFFSET (SC_ENC_MCI_OFFSET + SC_ENC_MCI_SIZE + 4) +#define SC_ENC_KEY_SIZE 32 + +#define SC_ENC_AUX1_OFFSET (SC_ENC_KEY_OFFSET + SC_ENC_KEY_SIZE) +#define SC_ENC_AUX1_SIZE 32 + +#define SC_ENC_AUX2_OFFSET (SC_ENC_AUX1_OFFSET + SC_ENC_AUX1_SIZE) +#define SC_ENC_AUX2_SIZE 16 + +#define SC_ENC_AUX3_OFFSET (SC_ENC_AUX2_OFFSET + SC_ENC_AUX2_SIZE) +#define SC_ENC_AUX3_SIZE 16 =20 #define SA_CMDL_UPD_ENC 0x0001 #define SA_CMDL_UPD_AUTH 0x0002 @@ -45,7 +58,6 @@ #define SA_CMDL_PAYLOAD_LENGTH_MASK 0xFFFF #define SA_CMDL_SOP_BYPASS_LEN_MASK 0xFF000000 =20 -#define MODE_CONTROL_BYTES 27 #define SA_HASH_PROCESSING 0 #define SA_CRYPTO_PROCESSING 0 #define SA_UPLOAD_HASH_TO_TLR BIT(6) @@ -229,7 +241,7 @@ struct sa_req { * Mode Control Instructions for various Key lengths 128, 192, 256 * For CBC (Cipher Block Chaining) mode for encryption */ -static u8 mci_cbc_enc_array[3][MODE_CONTROL_BYTES] =3D { +static u8 mci_cbc_enc_array[3][SC_ENC_MCI_SIZE] =3D { { 0x61, 0x00, 0x00, 0x18, 0x88, 0x0a, 0xaa, 0x4b, 0x7e, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00 }, @@ -245,7 +257,7 @@ static u8 mci_cbc_enc_array[3][MODE_CONTROL_BYTES] =3D { * Mode Control Instructions for various Key lengths 128, 192, 256 * For CBC (Cipher Block Chaining) mode for decryption */ -static u8 mci_cbc_dec_array[3][MODE_CONTROL_BYTES] =3D { +static u8 mci_cbc_dec_array[3][SC_ENC_MCI_SIZE] =3D { { 0x71, 0x00, 0x00, 0x80, 0x8a, 0xca, 0x98, 0xf4, 0x40, 0xc0, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00 }, @@ -261,7 +273,7 @@ static u8 mci_cbc_dec_array[3][MODE_CONTROL_BYTES] =3D { * Mode Control Instructions for various Key lengths 128, 192, 256 * For CBC (Cipher Block Chaining) mode for encryption */ -static u8 mci_cbc_enc_no_iv_array[3][MODE_CONTROL_BYTES] =3D { +static u8 mci_cbc_enc_no_iv_array[3][SC_ENC_MCI_SIZE] =3D { { 0x21, 0x00, 0x00, 0x18, 0x88, 0x0a, 0xaa, 0x4b, 0x7e, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00 }, @@ -277,7 +289,7 @@ static u8 mci_cbc_enc_no_iv_array[3][MODE_CONTROL_BYTES= ] =3D { * Mode Control Instructions for various Key lengths 128, 192, 256 * For CBC (Cipher Block Chaining) mode for decryption */ -static u8 mci_cbc_dec_no_iv_array[3][MODE_CONTROL_BYTES] =3D { +static u8 mci_cbc_dec_no_iv_array[3][SC_ENC_MCI_SIZE] =3D { { 0x31, 0x00, 0x00, 0x80, 0x8a, 0xca, 0x98, 0xf4, 0x40, 0xc0, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00 }, @@ -326,25 +338,25 @@ static u8 mci_ecb_dec_array[3][27] =3D { * For CBC (Cipher Block Chaining) mode and ECB mode * encryption and for decryption respectively */ -static u8 mci_cbc_3des_enc_array[MODE_CONTROL_BYTES] =3D { +static u8 mci_cbc_3des_enc_array[SC_ENC_MCI_SIZE] =3D { 0x60, 0x00, 0x00, 0x18, 0x88, 0x52, 0xaa, 0x4b, 0x7e, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, }; =20 -static u8 mci_cbc_3des_dec_array[MODE_CONTROL_BYTES] =3D { +static u8 mci_cbc_3des_dec_array[SC_ENC_MCI_SIZE] =3D { 0x70, 0x00, 0x00, 0x85, 0x0a, 0xca, 0x98, 0xf4, 0x40, 0xc0, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, }; =20 -static u8 mci_ecb_3des_enc_array[MODE_CONTROL_BYTES] =3D { +static u8 mci_ecb_3des_enc_array[SC_ENC_MCI_SIZE] =3D { 0x20, 0x00, 0x00, 0x85, 0x0a, 0x04, 0xb7, 0x90, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, }; =20 -static u8 mci_ecb_3des_dec_array[MODE_CONTROL_BYTES] =3D { +static u8 mci_ecb_3des_dec_array[SC_ENC_MCI_SIZE] =3D { 0x30, 0x00, 0x00, 0x85, 0x0a, 0x04, 0xb7, 0x90, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, @@ -494,7 +506,7 @@ static int sa_set_sc_enc(struct algo_data *ad, const u8= *key, u16 key_sz, const u8 *mci =3D NULL; =20 /* Set Encryption mode selector to crypto processing */ - sc_buf[0] =3D SA_CRYPTO_PROCESSING; + sc_buf[SC_ENC_MODESEL_OFFSET] =3D SA_CRYPTO_PROCESSING; =20 if (enc) mci =3D ad->mci_enc; @@ -502,7 +514,7 @@ static int sa_set_sc_enc(struct algo_data *ad, const u8= *key, u16 key_sz, mci =3D ad->mci_dec; /* Set the mode control instructions in security context */ if (mci) - memcpy(&sc_buf[1], mci, MODE_CONTROL_BYTES); + memcpy(&sc_buf[SC_ENC_MCI_OFFSET], mci, SC_ENC_MCI_SIZE); =20 /* For AES-CBC decryption get the inverse key */ if (ad->inv_key && !enc) { @@ -585,7 +597,7 @@ static int sa_format_cmdl_gen(struct sa_cmdl_cfg *cfg, = u8 *cmdl, SA_CMDL_HEADER_SIZE_BYTES + cfg->iv_size; =20 cmdl[enc_offset + SA_CMDL_OFFSET_OPTION_CTRL1] =3D - (SA_CTX_ENC_AUX2_OFFSET | (cfg->iv_size >> 3)); + (SC_ENC_AUX2_OFFSET | (cfg->iv_size >> 3)); total +=3D SA_CMDL_HEADER_SIZE_BYTES + cfg->iv_size; } else { cmdl[enc_offset + SA_CMDL_OFFSET_LABEL_LEN] =3D diff --git a/drivers/crypto/sa2ul.h b/drivers/crypto/sa2ul.h index 0aa6a36c0f20..94101300736c 100644 --- a/drivers/crypto/sa2ul.h +++ b/drivers/crypto/sa2ul.h @@ -46,7 +46,6 @@ struct sa_tfm_ctx; =20 /* Number of 32 bit words in PS data */ #define SA_DMA_NUM_PS_WORDS 16 -#define MCI_SZ 27 =20 /* * Maximum number of simultaeneous security contexts @@ -60,12 +59,6 @@ struct sa_tfm_ctx; #define SA_CTX_SIZE_TO_DMA_SIZE(ctx_sz) \ ((ctx_sz) ? ((ctx_sz) / 32 - 1) : 0) =20 -#define SA_CTX_ENC_KEY_OFFSET 32 -#define SA_CTX_ENC_AUX1_OFFSET 64 -#define SA_CTX_ENC_AUX2_OFFSET 96 -#define SA_CTX_ENC_AUX3_OFFSET 112 -#define SA_CTX_ENC_AUX4_OFFSET 128 - /* Next Engine Select code in CP_ACE */ #define SA_ENG_ID_EM1 2 /* Enc/Dec engine with AES/DEC core */ #define SA_ENG_ID_EM2 3 /* Encryption/Decryption enginefor pass 2 = */ @@ -142,12 +135,6 @@ struct sa_tfm_ctx; */ #define SA_CTX_SCCTL_OWNER_OFFSET 0 =20 -#define SA_CTX_ENC_KEY_OFFSET 32 -#define SA_CTX_ENC_AUX1_OFFSET 64 -#define SA_CTX_ENC_AUX2_OFFSET 96 -#define SA_CTX_ENC_AUX3_OFFSET 112 -#define SA_CTX_ENC_AUX4_OFFSET 128 - #define SA_SCCTL_FE_AUTH_ENC 0x65 #define SA_SCCTL_FE_ENC 0x8D =20 --=20 2.43.0 From nobody Fri Sep 25 12:05:54 2026 Received: from mx0a-0002e601.pphosted.com (mx0a-0002e601.pphosted.com [148.163.150.75]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 9DF294825B6; Tue, 15 Sep 2026 09:56:28 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=fail smtp.client-ip=148.163.150.75 ARC-Seal: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1789466190; cv=fail; b=c8Qk5vkqVxMGcers5w3ncvGtElcgghdK/8cP0WGpE0CQH6Brw6etdtAWjWmXk0cT9vDcvQlrU5Zww/GXKi9W5/HGWC/l/sg/d5gofWjpL9SabsoNuDg8lnnmHgCp6f/TNJ+Mhs6OQHRJ3vsQ6JdRdmTcDonBNDOb6Rm+BjfFqOE= ARC-Message-Signature: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1789466190; c=relaxed/simple; bh=TiikugB4BN+4H2nOcalKzmlja42GvMEL0mexg5t7grg=; h=From:Date:Subject:MIME-Version:Content-Type:Message-ID:References: In-Reply-To:To:CC; b=RlulsQpZyHVZKVtHEhaHgMorbFLYbm1kU64MitVaW37JUL2wQzr/4rpnSx3WcRi86TX2cskVMl7fHK4aUvkFZsItl2rKUEN5dy+hbSfN9XeZLLvIhGG/ROp4yJ3TwUsYYgfXKvFnQ3e55q9SHmVhVNBv7DkPxbNIMMex5jIDiXY= ARC-Authentication-Results: i=2; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=ti.com; spf=pass smtp.mailfrom=ti.com; dkim=pass (2048-bit key) header.d=ti.com header.i=@ti.com header.b=QvgtSJFU; dkim=pass (1024-bit key) header.d=ti.com header.i=@ti.com header.b=dqEn2zVz; arc=fail smtp.client-ip=148.163.150.75 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=ti.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=ti.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=ti.com header.i=@ti.com header.b="QvgtSJFU"; dkim=pass (1024-bit key) header.d=ti.com header.i=@ti.com header.b="dqEn2zVz" Received: from pps.filterd (m0380145.ppops.net [127.0.0.1]) by m0380145.ppops.net (8.18.1.11/8.18.1.11) with ESMTP id 68F9esNQ3889302; Tue, 15 Sep 2026 04:56:25 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ti.com; h=cc :content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s= proofpoint-05-2026; bh=93Xr9EjkkeRy8d48Fqse8mucm7g+g4+FfJWz5XlvJ H4=; b=QvgtSJFUGw0WD6wvJy3hf3ZE3ZSSS4XXIj08XY3BjtMdvkuPfnRCL0Z5l FBE+ASgRAD3Ls8V9S/vac95sjsaVEOkkFuPB24KLNr5ifjyKvNW5yXIIhA//JExs mRyEor3OVs5ERGKznBZb+8oCOi8Vc+YGSXgRWZCP0CBHZ1KQ7sMv6ZnG1cFePkZw IPc3grMsxdLSiBwteforagYyiOS2TL4ICZI0tb3Oa/fz+l7RuldsdAqqNa3dsI42 /yy274WzqlzD+TDAFPZy5EaVird29+JE4WoCm7Xm+OwA5kSwNd7X2vfGXUiKDs8b ASw+w9NoNfSCTT4Ag32kl8LoZFJXA== Received: from mw6pr02cu001.outbound.protection.outlook.com (mail-westus2azon11012018.outbound.protection.outlook.com [52.101.48.18]) by m0380145.ppops.net (PPS) with ESMTPS id 4gppxsm9g4-1 (version=TLSv1.3 cipher=TLS_AES_256_GCM_SHA384 bits=256 verify=NOT); Tue, 15 Sep 2026 04:56:25 -0500 (CDT) ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=Mb9razroGvAfo2gYidzquO+Kg0b+82HioXgE1/I6TPuwC26gztXkc3qRqLW1Q/oh4gWAc/gZKeSorcH5yEemb0s7XY5Mb0t1Dvzgx4H9IorbqXyvQZH4msacp1pfBsYCSCl80tpX1XwxZZIRRU4TAC1Y5RRjXkinbBNd2mo37EuNurp8As7rLsrPqdas2Ktlf7qVwvrHb5idzuJH8RmXd4NOV8eBZt7JEh+Enb47o+DIPbL670yazWvH6YqLMI+CQTD3MftgjIJ20RhHwnIcispudezoByTAb4K5LmXbTVgoG3OiVUepleLKm2f70SJ7dPNbOlJX6zO1/Swi+zKuQg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=93Xr9EjkkeRy8d48Fqse8mucm7g+g4+FfJWz5XlvJH4=; b=a2Dzy8FJDM/RJG0WTb1tIHL6iRwvU7MZDH7BQfXuua9MGlDnRVZaO/Z53GIYyYcFtqKEzvr8/1DUDb4fKXLkLug6BoB6faRzd7A5Bvj0XJlZzdWdgfc2BTt2e52mpS7hqgw439Ah3gFL4HjcstYtnM5aEyub+sNkbvRGGJM+D/zZuidh+tdP8lmBybm1Zn/Qnp9X+6dds5fhsntaeVlE1kPtBXTaKdKOdhyApwhvVRfM/OUBh91m7ImPVRoPSs/2RyFlsGy/gwayfabJv5JhkyfgZ7aP3/LzqDl4vl0cyhXboV7JUAqJE8otSsyp9+vbMmbNFuKBSl5DQyQ2QU3+/w== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 198.47.21.194) smtp.rcpttodomain=vger.kernel.org smtp.mailfrom=ti.com; dmarc=pass (p=quarantine sp=none pct=100) action=none header.from=ti.com; dkim=none (message not signed); arc=none (0) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ti.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=93Xr9EjkkeRy8d48Fqse8mucm7g+g4+FfJWz5XlvJH4=; b=dqEn2zVzwEZ24JzvF12bSGJLNjfqfGLEonWL0ACAJ4XfWQ0VHXNUlwTfUHOmBh9SuGXcEnb5vfoamgG0oZ9cShnemh9jUSsOLS6mH9ETSOP5F89nfCmAMZRsBaGGWn0KAy0+kuzYnyPwmcQEgnzWmbiciVSUJJ13zGOvUFPngTQ= Received: from CH2PR10CA0009.namprd10.prod.outlook.com (2603:10b6:610:4c::19) by DS7PR10MB5136.namprd10.prod.outlook.com (2603:10b6:5:38d::11) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.21.428.9; Tue, 15 Sep 2026 09:56:20 +0000 Received: from CH2PEPF0000013C.namprd02.prod.outlook.com (2603:10b6:610:4c:cafe::36) by CH2PR10CA0009.outlook.office365.com (2603:10b6:610:4c::19) with Microsoft SMTP Server (version=TLS1_3, cipher=TLS_AES_256_GCM_SHA384) id 15.21.406.11 via Frontend Transport; Tue, 15 Sep 2026 09:56:20 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 198.47.21.194) smtp.mailfrom=ti.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=ti.com; Received-SPF: Pass (protection.outlook.com: domain of ti.com designates 198.47.21.194 as permitted sender) receiver=protection.outlook.com; client-ip=198.47.21.194; helo=flwvzet200.ext.ti.com; pr=C Received: from flwvzet200.ext.ti.com (198.47.21.194) by CH2PEPF0000013C.mail.protection.outlook.com (10.167.244.73) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.21.428.7 via Frontend Transport; Tue, 15 Sep 2026 09:56:18 +0000 Received: from DFLE210.ent.ti.com (10.64.6.68) by flwvzet200.ext.ti.com (10.248.192.31) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.2562.45; Tue, 15 Sep 2026 04:55:42 -0500 Received: from DFLE205.ent.ti.com (10.64.6.63) by DFLE210.ent.ti.com (10.64.6.68) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.2562.45; Tue, 15 Sep 2026 04:55:42 -0500 Received: from lelvem-mr06.itg.ti.com (10.180.75.8) by DFLE205.ent.ti.com (10.64.6.63) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.2562.45 via Frontend Transport; Tue, 15 Sep 2026 04:55:42 -0500 Received: from uda0497581-ant.dhcp.ti.com (uda0497581-ant.dhcp.ti.com [10.24.51.159]) by lelvem-mr06.itg.ti.com (8.18.1/8.18.1) with ESMTP id 68F9tB7w3000901; Tue, 15 Sep 2026 04:55:39 -0500 From: Manorit Chawdhry Date: Tue, 15 Sep 2026 15:25:14 +0530 Subject: [PATCH 08/30] crypto: sa2ul - remove unused SC ID range tracking Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-ID: <20260915-b4-upstream-sa2ul-cleanup-v1-8-57ab34e97162@ti.com> References: <20260915-b4-upstream-sa2ul-cleanup-v1-0-57ab34e97162@ti.com> In-Reply-To: <20260915-b4-upstream-sa2ul-cleanup-v1-0-57ab34e97162@ti.com> To: Herbert Xu , "David S. Miller" , Keerthy , Colin Ian King CC: Andrew Davis , Pratham T , "Kamlesh Gurudasani" , Udit Kumar , , , "Manorit Chawdhry" X-Mailer: b4 0.15.2 X-Developer-Signature: v=1; a=ed25519-sha256; t=1789466112; l=1906; i=m-chawdhry@ti.com; s=20231127; h=from:subject:message-id; bh=TiikugB4BN+4H2nOcalKzmlja42GvMEL0mexg5t7grg=; b=58GeFloJ+DeNMIw1/UbQsZmssx/qK21z9VrXHosTtPGuG1Dyoo95ShzCaDGK4YN9rH+TcCwrN jDYvL6ln0qUDm3Ve6XoRzdfapiQG8hr/c8+xrBp+kMEkh1puPXb3Kui X-Developer-Key: i=m-chawdhry@ti.com; a=ed25519; pk=fsr6Tm39TvsTgfyfFQLk+nnqIz2sBA1PthfqqfiiYSs= X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: CH2PEPF0000013C:EE_|DS7PR10MB5136:EE_ X-MS-Office365-Filtering-Correlation-Id: 24236ae6-90b1-42de-0d15-08df130f96ee X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|82310400026|36860700016|23010399003|376014|1800799024|56012099006|10067099003|22082099003|18002099003; X-Microsoft-Antispam-Message-Info: MBGpt5WPqfK6/dx7tnHxU4YFKXwjvgShIPhBFt+wnv8WklhNp3MeKJ0W9j/CosCgn0WnwN2x+VxNJwlqY305KdqeBjAcM+Ko3b0LTmk5QSnrk1KwnZDTB96OdoJ/RtTUXjr6Z/3UcVLMgAthM/4Pp1cj7AU3H5K30//dtrFwPCY8FWpUEUvOu2Cwa98DPXvSYQNW+sIOwNE6hfy5q5UlQNzaf7y0moinHIehGiKvytsUSaIvWaaw7iRSbiLNIQCGuv77H/2V4qLghSd3pL8JS3Y7BtprdkMGQ3tOAIxSHW44D2J6+DVteorDdLc1bqqT6Csd3U6IbrzXy+j68f6W6RfwvindRY3SXBF7L/JZ+QOTr2CPgMMXxiv6y0O1xKhg4fB/kWnBXaZKlvf9TnBJZG1lUtBI1mp7fKDWYMPMrh/CbEiNajOEj+o3Nc+QPNpLV7t63RdO/O8mRQvH5koPSu1+rCSSktqLm4kV07xi6C2EJZkwOLhZL7V5oHSnAznkcKYfHmjUrybv/am0a8cAnuGz1h+L7pekqQw15HWAVGSkH8beNV/RtQnu42AdQsRDKoVZjxPtrmHvQVZX04pR3T6B0zujVD9Mzrqw+GcXoOCTt1vyqHwetM9/Sgn1lwCHhNUoEe9k0zQBewLK4SIBAggiDVSYJL9PhNDppIOjJ8g3RgQp1hUmXLHRtxxql1hzWtpkHisjgmN0CvzGQg5F2g== X-Forefront-Antispam-Report: CIP:198.47.21.194;CTRY:US;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:flwvzet200.ext.ti.com;PTR:ErrorRetry;CAT:NONE;SFS:(13230040)(82310400026)(36860700016)(23010399003)(376014)(1800799024)(56012099006)(10067099003)(22082099003)(18002099003);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: 92AXUY8/MryG6dFbYrUGWKWzYXgCgEwUplVa6/dvHOF7baBJZglSRHuQQX34NAvsx7t7J7f8RU8hqhotgYb5DKKWsl+cieYgcE4q6AgUy7waKzghC3ZTr6SMOSdh8pdri+t1yGgCWvUWh/rCI2yVF9lo+Fm1r1CWsO3vL1n5QX6yKtshQpdzWTRMalOhwTTGslk4GjEJbVHwKiRe0ozM4w8amx6odOZfiJr84MMxBMFY1zChh9mn9gIvU0Y9JYo8DjFNvjibhY8pWY5vS7+RSYfShHKREFGYRVfdBgC/Ky+cFQZEiCYrVKOuziQA8pf3xogqeBtLvrDR1B+3gO+eLqeRKkgBgPiCMgsFvhLhO1XQrDCbuO4kseohVcd/IV38K72rs3EYX5Pkep61kyIeZP0uDUYBZEKC1l8VmHorcH/zIdBxgEokiLqDbwMWxcM8 X-Exchange-RoutingPolicyChecked: hMOdEjHk5H6Qqvy8OoMZi9ILNyu6l8NqNOSpZ9cEOmWiXOAnOCsyEoUXuOIUupJl2cf+jT2K7OQYi65ZrkABG3wAmRd9czxg3A8NpEI0yCanbLhBj1QE44AotmiNgGy9Bjb1b6F4N1jo+eErnOsqAMxGbzfeeZmGdodYsyiKF5dw248Oh3fvyN2nehP/jjmI/6fPb7bQSwFqjkmhEQFXSfY+QWqG+nBOn/JIkJWRsOzZWXMvx6wC79L1bLruwhuRW9Cjy/Z0yjcNhUlXoOisT2915p/YZXuda+p77TjqjNErIT6Mb8zt5VQRTxDdIKwoo8j0w4OdTuRvyWGp1b+Sfg== X-OriginatorOrg: ti.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 15 Sep 2026 09:56:18.6580 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 24236ae6-90b1-42de-0d15-08df130f96ee X-MS-Exchange-CrossTenant-Id: e5b49634-450b-4709-8abb-1e2b19b982b7 X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=e5b49634-450b-4709-8abb-1e2b19b982b7;Ip=[198.47.21.194];Helo=[flwvzet200.ext.ti.com] X-MS-Exchange-CrossTenant-AuthSource: CH2PEPF0000013C.namprd02.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: DS7PR10MB5136 X-Proofpoint-GUID: Ad8qyWuQsO0RHXaw47XNp_5c0XgSAuoa X-Proofpoint-ORIG-GUID: Ad8qyWuQsO0RHXaw47XNp_5c0XgSAuoa X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwOTE1MDE0MyBTYWx0ZWRfX6YWgTsA7nTns 2v+5ehTsmNC583BktagLxK8iQMKaKJU6xzLPDDyRfjnjzZ+Bmv2OXGH7i3p9P6caJBYawT21Zck OOwiNm/0mYBJZ4e746Num4suiPh9FBOty7N6nBCinzfFGffHjYW4Z4Y3tK5NqkRQdNMknFzeOb5 /TKRCxmmMWqbPeXRoKxfliyZRCZke+blbVZASS3PHDZvWwe9tWUB7G2eindGrs2d+wNYFaY9P5Z 8M42FuPwjBZfc93C868GM0mK3enukrcsPvX3zU7DNCKKCcUZtM5vwXK2tqUXOYTENO1VtEcWHTX 71lsoavxXXS4XDwOKv/gPIKVAlcQFWe8Rb/87w5RPHm8xKa63H8hCNzf2km+VUCAzPg+l1zSM10 r1drihECP1NAZHrOWjrcrmq6N3TNQE7U7ogwSoeeWdvt/hxGzc4TW+PfRyZNG2asLwOvqDlT1AR PI59Ssv/YKhdbneaobg== X-Authority-Analysis: v=2.4 cv=bYP+w+PB c=1 sm=1 tr=0 ts=6aa91649 cx=c_pps a=HLJbjerEQdjma44f6ZsklA==:117 a=iwqwCZQqcuTv3JOpYdM7/Q==:17 a=6eWqkTHjU83fiwn7nKZWdM+Sl24=:19 a=IkcTkHD0fZMA:10 a=VdqzKS8jKosA:10 a=V5UXEbMT0ywA:10 a=VkNPw1HP01LnGYTKEx00:22 a=Z8NIEmU8O1QQgoT56wFK:22 a=gO1vWkAQAl3rybz1DQOp:22 a=sozttTNsAAAA:8 a=TZd5T8kqcK8ENkXl4jYA:9 a=QEXdDO2ut3YA:10 X-Proofpoint-Spam-Info: AW1haW4tMjYwOTE1MDE0MyBTYWx0ZWRfX0AOp+xp3K2B6 ZdBJY1I0uo4w9zYHbvL0mZIGPNxuObDGjnwr0g3Vtu0EAVrWbMgesrwM/aSTA6oS03fBWBTx24/ VnQj4CISQyNVI2Z/FHfnHTrDQ7XJ2Dk= X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1176,Hydra:6.1.134,FMLib:17.12.100.49 definitions=2026-09-15_03,2026-09-14_02,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 clxscore=1011 lowpriorityscore=0 priorityscore=1501 impostorscore=0 adultscore=0 suspectscore=0 phishscore=0 malwarescore=0 bulkscore=0 spamscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2609040000 definitions=main-2609150143 Remove unused sc_id_start and sc_id_end fields from sa_dev_data. These were intended for security context ID management but were never used in the driver. Assisted-by: Sisyphus:claude-sonnet-4-6 Signed-off-by: Manorit Chawdhry --- drivers/crypto/sa2ul.c | 4 ++-- drivers/crypto/sa2ul.h | 4 ---- 2 files changed, 2 insertions(+), 6 deletions(-) diff --git a/drivers/crypto/sa2ul.c b/drivers/crypto/sa2ul.c index cde08686f27a..72be29820859 100644 --- a/drivers/crypto/sa2ul.c +++ b/drivers/crypto/sa2ul.c @@ -764,7 +764,7 @@ static void sa_free_ctx_info(struct sa_ctx_info *ctx, { unsigned long bn; =20 - bn =3D ctx->sc_id - data->sc_id_start; + bn =3D ctx->sc_id; spin_lock(&data->scid_lock); __clear_bit(bn, data->ctx_bm); data->sc_id--; @@ -788,7 +788,7 @@ static int sa_init_ctx_info(struct sa_ctx_info *ctx, data->sc_id++; spin_unlock(&data->scid_lock); =20 - ctx->sc_id =3D (u16)(data->sc_id_start + bn); + ctx->sc_id =3D (u16)bn; =20 ctx->sc =3D dma_pool_alloc(data->sc_pool, GFP_KERNEL, &ctx->sc_phys); if (!ctx->sc) { diff --git a/drivers/crypto/sa2ul.h b/drivers/crypto/sa2ul.h index 94101300736c..c41c688687f5 100644 --- a/drivers/crypto/sa2ul.h +++ b/drivers/crypto/sa2ul.h @@ -168,8 +168,6 @@ struct sa_match_data; * @sc_pool: security context pool * @dev: Device pointer * @scid_lock: secure context ID lock - * @sc_id_start: starting index for SC ID - * @sc_id_end: Ending index for SC ID * @sc_id: Security Context ID * @ctx_bm: Bitmap to keep track of Security context ID's * @ctx: SA tfm context pointer @@ -185,8 +183,6 @@ struct sa_crypto_data { struct device *dev; spinlock_t scid_lock; /* lock for SC-ID allocation */ /* Security context data */ - u16 sc_id_start; - u16 sc_id_end; u16 sc_id; unsigned long ctx_bm[DIV_ROUND_UP(SA_MAX_NUM_CTX, BITS_PER_LONG)]; --=20 2.43.0 From nobody Fri Sep 25 12:05:54 2026 Received: from mx0b-0002e601.pphosted.com (mx0b-0002e601.pphosted.com [148.163.154.28]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id C224648425A; Tue, 15 Sep 2026 09:56:31 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=fail smtp.client-ip=148.163.154.28 ARC-Seal: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1789466195; cv=fail; b=YIoTKtvKO2kU6yqrkBBxTtST60S4tUDT0e9lUtg7u25181yrfwP+ZIewLbDQVIhE2nQUKhNxZOb+RfhOqwiTuXwSQ7UGN4xjaKBwDPOOMa/Q1h1Auur6tTeNHfJtkcwwYvilWY1cM/wQbIeg3BcgeGwRPnAGdC1avzMr60ynXFQ= ARC-Message-Signature: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1789466195; c=relaxed/simple; bh=9kZE5JB3CRPQtGL/5itWrkNLkVpynYj2w5s82Snn4Ms=; h=From:Date:Subject:MIME-Version:Content-Type:Message-ID:References: In-Reply-To:To:CC; b=D+XDF89xTi6nIv9KjqCAeIlFg/n01gn9RuGUCEXw1aRX5YKJRNWX8pl3teWgcZpslEzokU1BZtda4JBV4/JYwo/+sayV0uR3A+YTLvEI6wv1kbRLT3cufz7cU+U88mScDob3SpzxDNI2SqGcwaO6SwnTmL65NT46FYcUpHog83g= ARC-Authentication-Results: i=2; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=ti.com; spf=pass smtp.mailfrom=ti.com; dkim=pass (2048-bit key) header.d=ti.com header.i=@ti.com header.b=hKmbTdTK; dkim=pass (1024-bit key) header.d=ti.com header.i=@ti.com header.b=fPnlE9BH; arc=fail smtp.client-ip=148.163.154.28 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=ti.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=ti.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=ti.com header.i=@ti.com header.b="hKmbTdTK"; dkim=pass (1024-bit key) header.d=ti.com header.i=@ti.com header.b="fPnlE9BH" Received: from pps.filterd (m0374955.ppops.net [127.0.0.1]) by mx0b-0002e601.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 68F9fL394098131; Tue, 15 Sep 2026 04:56:26 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ti.com; h=cc :content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s= proofpoint-05-2026; bh=+Xv5smcd/JID4OrzNuw+OTuRIpg8xnF82b4frNjBJ Fk=; b=hKmbTdTKTifW7KKBNmXX/btWE4sTWfz1k5M28DgJAgUwlLTDsetnh7WGy +LXfGQOXUQRabULNLbZaw1LM3lMnHBcmiHqAMoXpM7ZB0OcH3OUVIj+4/hTudFvz N2MAaHo7CrVmxLoUafXUuDHTVN4G/XZmTaeNip+AZWVx20hE73L/44/wx8AoKW98 SJaBTldq94evAiUvw7BrXYVu86m7z7c6ZQKpCSe2BXaLf57ytqeS/F9NgkXVNHKZ t68I0iId7fLL2MPXT2oQ9ofCh+ljiPo0OCEC4briGZeC7F/K/JhfDcNWLE2kt7Zp 6DuSFvju0so+0mV8bh/EpPwDA5efQ== Received: from bl2pr02cu003.outbound.protection.outlook.com (mail-eastusazon11011054.outbound.protection.outlook.com [52.101.52.54]) by mx0b-0002e601.pphosted.com (PPS) with ESMTPS id 4gpvpjakh9-1 (version=TLSv1.3 cipher=TLS_AES_256_GCM_SHA384 bits=256 verify=NOT); Tue, 15 Sep 2026 04:56:26 -0500 (CDT) ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=ygMUHJoAcqonMHRZPuwG9eA2NPgNpHePdLPT8/WsP52xfH0r1CruY/siYUEj+2q6zT0IjMEyxpVKxnhZbM0dXIA0nV6B7WbKMDtrrJVxDYwBQMCzAHLVlQQOVv96p+lvdr67GRGdfbHXrdUemR9p8MHcMU3G1MSInvXBgGRjpJSIyi/fQt0q8Af11x2pDDnKdOKZO+Bxbt3/9Ya4tpeHOuTNwzvv3u72ij94VolEbbXdegT6QWQpRcR2fBWc5oCPMIwPoQxbq7/4HxndQgHkB6OCXLVbPWVQUYjOqUv08El4d2n7Jp/cGGHzNRkqCGq5UlxlmDEMieaxSHbo9GacqQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=+Xv5smcd/JID4OrzNuw+OTuRIpg8xnF82b4frNjBJFk=; b=rbABmb5y4cWj+6HBJdDCLG5whIs4DqYnuJx/HFYSL5VFFu1nJkcKnVcwQjhlu8jt/DlEtvXlmIs654nq8nsF551XsGEaw1iwb6ShXijXJ4B7/RtKv2tUUPRn2LkWdZ4OY/SvVJuR+ZoDILytBM18wj2Q9i6IDyTkGnLRQRHV0oJLMnPyakU6GmJD0IfyXljV47JW2UvjCqZ/P5AOcAVe2gUjvPRV9/hQp9IefSolf6XK8GRK70Lc1JhC8n/B8qaX4IuIYcoW99J7fmtiSgaQo/B2xIYCUPf8YdCNTLIrS6vrWK+dgL8IpDfiGfurPdyeoho6YqHaf0dcjRa7jOkPJg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 198.47.21.195) smtp.rcpttodomain=vger.kernel.org smtp.mailfrom=ti.com; dmarc=pass (p=quarantine sp=none pct=100) action=none header.from=ti.com; dkim=none (message not signed); arc=none (0) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ti.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=+Xv5smcd/JID4OrzNuw+OTuRIpg8xnF82b4frNjBJFk=; b=fPnlE9BH85sE3XUTPbc5znZlVqj6e8E7gqpDHLwEMIfJErEeWGQ7uUQHL1x/adq2PkwDtDEBxE/pMzk6ml5xXVYMbmeTC8WRsOqpBWHCmjTRpPWgSQYbpHm0VU6BliEQDPw5tc/6m+BMXVEgMC6D7si7LqsMu5uCXdKWFcv8Z5Y= Received: from SJ2P221CA0009.NAMP221.PROD.OUTLOOK.COM (2603:10b6:a03:5db::13) by CO6PR10MB5553.namprd10.prod.outlook.com (2603:10b6:303:140::6) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.21.428.8; Tue, 15 Sep 2026 09:56:24 +0000 Received: from MWH0EPF000C6186.namprd02.prod.outlook.com (2603:10b6:a03:5db:cafe::2) by SJ2P221CA0009.outlook.office365.com (2603:10b6:a03:5db::13) with Microsoft SMTP Server (version=TLS1_3, cipher=TLS_AES_256_GCM_SHA384) id 15.21.406.12 via Frontend Transport; Tue, 15 Sep 2026 09:56:23 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 198.47.21.195) smtp.mailfrom=ti.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=ti.com; Received-SPF: Pass (protection.outlook.com: domain of ti.com designates 198.47.21.195 as permitted sender) receiver=protection.outlook.com; client-ip=198.47.21.195; helo=flwvzet201.ext.ti.com; pr=C Received: from flwvzet201.ext.ti.com (198.47.21.195) by MWH0EPF000C6186.mail.protection.outlook.com (10.167.249.118) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.21.428.7 via Frontend Transport; Tue, 15 Sep 2026 09:56:22 +0000 Received: from DFLE203.ent.ti.com (10.64.6.61) by flwvzet201.ext.ti.com (10.248.192.32) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.2562.45; Tue, 15 Sep 2026 04:55:45 -0500 Received: from DFLE204.ent.ti.com (10.64.6.62) by DFLE203.ent.ti.com (10.64.6.61) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.2562.45; Tue, 15 Sep 2026 04:55:45 -0500 Received: from lelvem-mr06.itg.ti.com (10.180.75.8) by DFLE204.ent.ti.com (10.64.6.62) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.2562.45 via Frontend Transport; Tue, 15 Sep 2026 04:55:45 -0500 Received: from uda0497581-ant.dhcp.ti.com (uda0497581-ant.dhcp.ti.com [10.24.51.159]) by lelvem-mr06.itg.ti.com (8.18.1/8.18.1) with ESMTP id 68F9tB7x3000901; Tue, 15 Sep 2026 04:55:42 -0500 From: Manorit Chawdhry Date: Tue, 15 Sep 2026 15:25:15 +0530 Subject: [PATCH 09/30] crypto: sa2ul - remove unused base register pointer Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-ID: <20260915-b4-upstream-sa2ul-cleanup-v1-9-57ab34e97162@ti.com> References: <20260915-b4-upstream-sa2ul-cleanup-v1-0-57ab34e97162@ti.com> In-Reply-To: <20260915-b4-upstream-sa2ul-cleanup-v1-0-57ab34e97162@ti.com> To: Herbert Xu , "David S. Miller" , Keerthy , Colin Ian King CC: Andrew Davis , Pratham T , "Kamlesh Gurudasani" , Udit Kumar , , , "Manorit Chawdhry" X-Mailer: b4 0.15.2 X-Developer-Signature: v=1; a=ed25519-sha256; t=1789466112; l=1463; i=m-chawdhry@ti.com; s=20231127; h=from:subject:message-id; bh=9kZE5JB3CRPQtGL/5itWrkNLkVpynYj2w5s82Snn4Ms=; b=9aHuKLzmH2GBaw4DqRcjayIN+lkG9jqE70SzWgY/RX/iOuPazY5pliDTpdsdYXwTUWM+FW5GK gqTBGJDqmL6DAgIfU8zF6tir9QdmVKWfJzBrBZ/7sVtDDJB+2TkgdNz X-Developer-Key: i=m-chawdhry@ti.com; a=ed25519; pk=fsr6Tm39TvsTgfyfFQLk+nnqIz2sBA1PthfqqfiiYSs= X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: MWH0EPF000C6186:EE_|CO6PR10MB5553:EE_ X-MS-Office365-Filtering-Correlation-Id: 1634bec4-f3bd-4d67-e3ce-08df130f990a X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|36860700016|82310400026|376014|1800799024|23010399003|56012099006|10067099003|22082099003|18002099003; X-Microsoft-Antispam-Message-Info: /RfkWLb3Mc93KWd2FprZPEdVJ440NbPCkDVpplMkcDckbyl0Uz/nklIUIj+0bcSIEqn/qvEvm7t/05kDi2Xg2SzVo9Kb58flBuAGHqZLKqU2Mjx5QFiExKIGA5MdTqc1XVeZ41pxq4E2FutLeztrSzj3BVNyfI4weiAGiZoK2bwaryX/Gs0uud55V7iYj0yG73gMQdOOXG0It+bCA7SeAGMNdQdO/qA4CjDTVu3bZbPYDuDRY73MbxrD4sH/VVrrb1og9ydyqThQBPMNEhH7MEIPo2K2U/SE50m2oVlunvbEnu2K4baihK9o6c5suiBOTQ9Zuf4/E5qbOirnrJbvOVF9zwb93ZSeSM9docsNgaWJzX0i8J1inP7Rosc1/r44Iy1/mgfaNBY8panZwtlr9asykpKZRwLf3Ie96HkY8EmUor0v04NZp/2dtS9X4qjwxtgOE/4dAGGsQG6qJ6Fcv5llpvgUGp5FE9oxqQJkNv/M+RGaEfeLG/2ZxZr+Q4TXpFRwTf8xwT9pDga41lmXdQIgX+y5gKfXB2f+Ze4sOBrQ3fhLA/vFCnuSCd1gDtDMO4xipzavGOsJ3MnUDLYDcD7iKtPu1EIGwx4PhjmPwZTPOZAj7hiNPc6UjfHUuBsNOH1O0cFGtw8UCkNsAKVg/klSLDz9xEmK0U4T4UNL7bZxQEbj4075fRHyLM54zzWwa9+OdMtPRCEYBToRUNf6wA== X-Forefront-Antispam-Report: CIP:198.47.21.195;CTRY:US;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:flwvzet201.ext.ti.com;PTR:ErrorRetry;CAT:NONE;SFS:(13230040)(36860700016)(82310400026)(376014)(1800799024)(23010399003)(56012099006)(10067099003)(22082099003)(18002099003);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: MEPhUwZMstnxsYKloyIn5y1Km6HKvFX1fgQiyI4mgf2JvlS4KPSW7dEFdbupPylJxW/0K+Q9TI6mFdQORbCDmU0siNl2QXXMvncMtsD4w1tTMxezlaQiPGba1+izMcXb8duHyQn/3a62wN6PjrlZXt4+wokMAOqSAqe1DTQtnKKPBi6M1BHp/9qTgNE+hUwpCs4KnaADWS3VcFHFP6tANa/s8s2bT0lGjpKX8PnO5Nqd7gW7YuunkUT+fffFNOecxquOxvJGTLt6NBL3WHSM/4emwQksnQUkLAx2YRVMvrWFKvjwjR3ySTnXeqtO2yIxMF3tl692+kDRmFhIO3JHrExJEKOurTo5ixoZUMb2QWh5SbRsgX4wdQf9ADLD8OEM95TFMlzC84YZIUy2Xn9hLOlOGWCSI4MV63LEnq6JAI/74PxpVvwpWMuCAzw57BAq X-Exchange-RoutingPolicyChecked: bIcgVyE37dOSQhndT7NTlb8s9ifu65Uom9QJ9EnGGkGKh2bA9e3jk55xJ3TuGpfXgOj2SDO19vjWTBg5Yte/fpEXa3vv7pl1/ENNH8mGHe4olmiGaGxpNkdejrZobO3Ijl179qJntqWgv098CroLJH+EVMaRb1lg2s73cPMN2NMnN+4Ygy4kiA2U9R3bTtr4+yAP70LgXKxcsf+Au8+AfDHm0mFT/sR4WByGNP74MxOWcrL0WySq5K32/RhrJKhkmlUd00k4B9wq8HInO3MMN5+rq5+1dDLaHp9sPtjj8GYKR2Dl9ti6Or5FPUGaP0MhNlare/A2fEOFDZL/CJwVXQ== X-OriginatorOrg: ti.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 15 Sep 2026 09:56:22.1703 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 1634bec4-f3bd-4d67-e3ce-08df130f990a X-MS-Exchange-CrossTenant-Id: e5b49634-450b-4709-8abb-1e2b19b982b7 X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=e5b49634-450b-4709-8abb-1e2b19b982b7;Ip=[198.47.21.195];Helo=[flwvzet201.ext.ti.com] X-MS-Exchange-CrossTenant-AuthSource: MWH0EPF000C6186.namprd02.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: CO6PR10MB5553 X-Proofpoint-Spam-Info: AW1haW4tMjYwOTE1MDE0MyBTYWx0ZWRfXxYzz85UOunp+ Z17zJSYxxk/8/f+djvS0jjSrjm1hEQapeEpRKPbXTlviJveesXL3lpBYrxTsNj9HCM16NCfgUCd geTAvauCT7+PCd59izzFJs5jG+Rix/8= X-Authority-Analysis: v=2.4 cv=KvnYSmWN c=1 sm=1 tr=0 ts=6aa9164a cx=c_pps a=i69ZgmgbQZPDBD2C4G6j1A==:117 a=tJyPKKxUohctrY4NYmUjkA==:17 a=6eWqkTHjU83fiwn7nKZWdM+Sl24=:19 a=IkcTkHD0fZMA:10 a=VdqzKS8jKosA:10 a=V5UXEbMT0ywA:10 a=VkNPw1HP01LnGYTKEx00:22 a=Z8NIEmU8O1QQgoT56wFK:22 a=fPAWb5peG099m5CrUpKH:22 a=sozttTNsAAAA:8 a=BT56tlt6Ecdp_ngW-zEA:9 a=0bXxn9q0MV6snEgNplNhOjQmxlI=:19 a=QEXdDO2ut3YA:10 X-Proofpoint-ORIG-GUID: KihycopRBZEwwu4j7T9Ji5zbApGc4tjZ X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwOTE1MDE0MyBTYWx0ZWRfX2pJwO0Y1ZY/r K03JHpwj817Ek8CyTZPmgevZKn0MdLGwdnBLmiVtuBncWP1HmV7VPuw11W3PozuZ49MjV2iOgY2 38Rr+h9CNhJ/XnBk+uNjmeIidGTpWJKHzSArzbUip7Qh3vx7ZpAByymwz676GFbJGyb5yjHnSAc Kp6UVuCOcZgWPASD94bttEIPb5x5Bz5x84int1bDXG2mc6SSQb+3dhepiZWsHZn2ZoUejnAqTaY zpDww77ng3yPZrpeGhGa74MO2LDC8Kl7PUKXQbOIC444EqkivpF8k21Nomx8qAZuNZJTAwPjSpg aiZJT6imZ1O6N0ROSvBexsSnGWwtJe1t40ZVWOWRA7xUW/lWFcZdlrNo1bk/oWSog9gwohnHaPR JtDTUkI5eB64nG4YBUiqPi3LPE7H8vjfeG2PvXwJ8elc1yyOPOWcz/QwVVu060yIbsi3pLTQC3Q sI/h5t2hSJTpK3oAO6w== X-Proofpoint-GUID: KihycopRBZEwwu4j7T9Ji5zbApGc4tjZ X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1176,Hydra:6.1.134,FMLib:17.12.100.49 definitions=2026-09-15_03,2026-09-14_02,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 lowpriorityscore=0 clxscore=1015 priorityscore=1501 impostorscore=0 suspectscore=0 spamscore=0 bulkscore=0 adultscore=0 phishscore=0 malwarescore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2609040000 definitions=main-2609150143 Remove unused base register pointer from sa_dev_data structure. The driver uses the psilss_base pointer instead for all register accesses. Assisted-by: Sisyphus:claude-sonnet-4-6 Signed-off-by: Manorit Chawdhry --- drivers/crypto/sa2ul.c | 1 - drivers/crypto/sa2ul.h | 2 -- 2 files changed, 3 deletions(-) diff --git a/drivers/crypto/sa2ul.c b/drivers/crypto/sa2ul.c index 72be29820859..13e941f58c4b 100644 --- a/drivers/crypto/sa2ul.c +++ b/drivers/crypto/sa2ul.c @@ -2342,7 +2342,6 @@ static int sa_ul_probe(struct platform_device *pdev) sa_k3_dev =3D dev; dev_data->dev =3D dev; dev_data->pdev =3D pdev; - dev_data->base =3D saul_base; platform_set_drvdata(pdev, dev_data); dev_set_drvdata(sa_k3_dev, dev_data); =20 diff --git a/drivers/crypto/sa2ul.h b/drivers/crypto/sa2ul.h index c41c688687f5..48ed1933ecae 100644 --- a/drivers/crypto/sa2ul.h +++ b/drivers/crypto/sa2ul.h @@ -162,7 +162,6 @@ struct sa_match_data; =20 /** * struct sa_crypto_data - Crypto driver instance data - * @base: Base address of the register space * @soc_data: Pointer to SoC specific data * @pdev: Platform device pointer * @sc_pool: security context pool @@ -176,7 +175,6 @@ struct sa_match_data; * @dma_tx: Pointer to DMA TX channel */ struct sa_crypto_data { - void __iomem *base; const struct sa_match_data *match_data; struct platform_device *pdev; struct dma_pool *sc_pool; --=20 2.43.0 From nobody Fri Sep 25 12:05:54 2026 Received: from mx0a-0002e601.pphosted.com (mx0a-0002e601.pphosted.com [148.163.150.75]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id C1F0C47FB0E; Tue, 15 Sep 2026 09:56:31 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=fail smtp.client-ip=148.163.150.75 ARC-Seal: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1789466195; cv=fail; b=f5AbfNO5LjrfGvhcECzurBQojWi9c+r36+Dye4l1o7xQHDnISQDZqdazcfiXd6GvpX3eFQZ+HDbkzISWJ1GdbURTpo+2/OdA6ngGwkLIxZ667/q+Rofsz/RmPmRNCbIX2oLCSYl+KZx6MbxHQ6sTmfA6Q7mQ+SF5x5QRacQ6+CY= ARC-Message-Signature: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1789466195; c=relaxed/simple; bh=Jv0yhRQLpdO1SSTC2Nznwlk+WMpus/ZnO9swKgHbfBI=; h=From:Date:Subject:MIME-Version:Content-Type:Message-ID:References: In-Reply-To:To:CC; b=p6e+a270GijdoXuEolujGRIa4Od8L5Mkg49mFi4RJu3KIXtwRN1URWFT+1XBjTzfVZYpzQEaTd66Mmz8buV28lnkuqnqMfAlRXtAKWOoAzbODUbjhEnARHO0tuZ8CvPidvN1TKoFTDcCyHaFo25XsxDmFVa4MkFFVltpEeyt1yA= ARC-Authentication-Results: i=2; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=ti.com; spf=pass smtp.mailfrom=ti.com; dkim=pass (2048-bit key) header.d=ti.com header.i=@ti.com header.b=NTTiH65b; dkim=pass (1024-bit key) header.d=ti.com header.i=@ti.com header.b=IDsjhizR; arc=fail smtp.client-ip=148.163.150.75 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=ti.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=ti.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=ti.com header.i=@ti.com header.b="NTTiH65b"; dkim=pass (1024-bit key) header.d=ti.com header.i=@ti.com header.b="IDsjhizR" Received: from pps.filterd (m0384305.ppops.net [127.0.0.1]) by m0384305.ppops.net (8.18.1.11/8.18.1.11) with ESMTP id 68F9ejHG1480546; Tue, 15 Sep 2026 04:56:28 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ti.com; h=cc :content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s= proofpoint-05-2026; bh=e+rF0G4pKgUYgAtbp3kUCoJlkLgk2rkNSqITfyWb9 bc=; b=NTTiH65bcxHZj/nTAhHLWyBPSUjkLwiNBKowfr/NYF47AcfrwCmouNIuo upQm7mjdH5Ct+IADwwE04y2JpSNg80r4RbJWEa+SV+FOglblJV4d0I0E4mxEyTFA u6BwlO5t4ujp0DThTjbG+xzIjo68Bf92Un1ZP7hMO+zsc2jIWYfQr2MZb7Du50OO EojqJ4699v39AyOGFLbc6VOYuS41Tw7SrDyRZk3PMYp0zfuMA8Yripwcxc27SRQv STwqhvp8j0oQaOE6am8g3TnOQ1qzv3AjYx4fVtMjm1z+xrb/X1rSA3O8fsTuEgMz iyiG6sA4pUztme1uQnri03Q57hOug== Received: from ph8pr06cu001.outbound.protection.outlook.com (mail-westus3azon11012058.outbound.protection.outlook.com [40.107.209.58]) by m0384305.ppops.net (PPS) with ESMTPS id 4gpvpa2j1m-1 (version=TLSv1.3 cipher=TLS_AES_256_GCM_SHA384 bits=256 verify=NOT); Tue, 15 Sep 2026 04:56:28 -0500 (CDT) ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=UARzVI/7bjnJGGjRkc3LYGQxPhs0ZEcW7v31icARj2Ym2o3jEvY3MqBykozKrIL32ktL5+nbmLdur5TdBw209g7O0KfoEfKxIOsyrzmUTISWWofM065MmLArdRbiGpV5lg0cgD0uzl3wtdiX+K2CrSklYeA2S/W8nf2ALdQT2IuEnLBfZNINFgfGQBNWlA+U79GSkJK+kSUMN8iLTXLM17ynjavvCEojca/7B5KaGvmOceH1ij1Gupj1DXTXDCq5KRRgPWWR8XDLy8ZnHeO1HlQoodKyD6UN+PKG472qKQV+2ojLDE7r8hZ0u+vytLaISpLx7/KWPLYwt60PYuZdzA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=e+rF0G4pKgUYgAtbp3kUCoJlkLgk2rkNSqITfyWb9bc=; b=rvPqprDaaH9oefU0fOrkuAA8itv5iSz0gEOVH5dD23QX5gnDJerqJkOrOa+FjYXgw9ANpR7vZEyuTGBMS3qIEIOhIQsyjrZrkQVkE1Q4rUSAw2kNHl1P9eeLktFvlOJTaEm0qbcEW/HbfFWolZsl4AkHxWgTfrvpAQvOVEsiWOPC4jczosoGG0AZTtBPrDmjL9shMS2YwRaGSuCml/iY8FcIl9Kf2cES6d8gZ5lpt54YyjNuCukW2UpCWouLA7Zv1w/RIynePs7tPUDbkpm9YVbj111GZCI8xc9vJZwaf3aQXrSiwBzsaq1FVT8/2vzPSP0YQ2wjWDFRbsqra/WYig== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 198.47.21.194) smtp.rcpttodomain=vger.kernel.org smtp.mailfrom=ti.com; dmarc=pass (p=quarantine sp=none pct=100) action=none header.from=ti.com; dkim=none (message not signed); arc=none (0) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ti.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=e+rF0G4pKgUYgAtbp3kUCoJlkLgk2rkNSqITfyWb9bc=; b=IDsjhizRUHGuFp02zwkKK7xDR062uu8+OSg7vZijQMPiibsMCr5XxN2VYh+08LkvqH+8IqwpeHlKIVvunTLYxsaYK8XQjdY+tgo188VxmK47Hc+EKyrHIzKYPlxEUMLmEun+bMALmBjfBUwYdLGP3M5lxg6gIiH8omlhRd2jt+Q= Received: from CH2PR12CA0014.namprd12.prod.outlook.com (2603:10b6:610:57::24) by IA0PR10MB6841.namprd10.prod.outlook.com (2603:10b6:208:437::19) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.21.428.9; Tue, 15 Sep 2026 09:56:23 +0000 Received: from CH2PEPF0000013D.namprd02.prod.outlook.com (2603:10b6:610:57:cafe::46) by CH2PR12CA0014.outlook.office365.com (2603:10b6:610:57::24) with Microsoft SMTP Server (version=TLS1_3, cipher=TLS_AES_256_GCM_SHA384) id 15.21.406.12 via Frontend Transport; Tue, 15 Sep 2026 09:56:23 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 198.47.21.194) smtp.mailfrom=ti.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=ti.com; Received-SPF: Pass (protection.outlook.com: domain of ti.com designates 198.47.21.194 as permitted sender) receiver=protection.outlook.com; client-ip=198.47.21.194; helo=flwvzet200.ext.ti.com; pr=C Received: from flwvzet200.ext.ti.com (198.47.21.194) by CH2PEPF0000013D.mail.protection.outlook.com (10.167.244.69) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.21.428.7 via Frontend Transport; Tue, 15 Sep 2026 09:56:21 +0000 Received: from DFLE206.ent.ti.com (10.64.6.64) by flwvzet200.ext.ti.com (10.248.192.31) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.2562.45; Tue, 15 Sep 2026 04:55:48 -0500 Received: from DFLE205.ent.ti.com (10.64.6.63) by DFLE206.ent.ti.com (10.64.6.64) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.2562.45; Tue, 15 Sep 2026 04:55:48 -0500 Received: from lelvem-mr06.itg.ti.com (10.180.75.8) by DFLE205.ent.ti.com (10.64.6.63) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.2562.45 via Frontend Transport; Tue, 15 Sep 2026 04:55:48 -0500 Received: from uda0497581-ant.dhcp.ti.com (uda0497581-ant.dhcp.ti.com [10.24.51.159]) by lelvem-mr06.itg.ti.com (8.18.1/8.18.1) with ESMTP id 68F9tB803000901; Tue, 15 Sep 2026 04:55:45 -0500 From: Manorit Chawdhry Date: Tue, 15 Sep 2026 15:25:16 +0530 Subject: [PATCH 10/30] crypto: sa2ul - remove unused includes and defines Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-ID: <20260915-b4-upstream-sa2ul-cleanup-v1-10-57ab34e97162@ti.com> References: <20260915-b4-upstream-sa2ul-cleanup-v1-0-57ab34e97162@ti.com> In-Reply-To: <20260915-b4-upstream-sa2ul-cleanup-v1-0-57ab34e97162@ti.com> To: Herbert Xu , "David S. Miller" , Keerthy , Colin Ian King CC: Andrew Davis , Pratham T , "Kamlesh Gurudasani" , Udit Kumar , , , "Manorit Chawdhry" X-Mailer: b4 0.15.2 X-Developer-Signature: v=1; a=ed25519-sha256; t=1789466112; l=4651; i=m-chawdhry@ti.com; s=20231127; h=from:subject:message-id; bh=Jv0yhRQLpdO1SSTC2Nznwlk+WMpus/ZnO9swKgHbfBI=; b=JU298eChqPqOx/sqTcUrb4RBySpXJUSTeFqT9EK0sRySNYFlbgfZsnVBeEnU4Yxp9YkxVo6HF sBp0rElo2xIDBoOrw013gSd2qi4GNegHkum5RqdeV9BkTr5UV1nfm2w X-Developer-Key: i=m-chawdhry@ti.com; a=ed25519; pk=fsr6Tm39TvsTgfyfFQLk+nnqIz2sBA1PthfqqfiiYSs= X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: CH2PEPF0000013D:EE_|IA0PR10MB6841:EE_ X-MS-Office365-Filtering-Correlation-Id: f10e1148-f873-4c6a-e908-08df130f9883 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|23010399003|36860700016|376014|82310400026|1800799024|56012099006|10067099003|22082099003|18002099003|6133799003|3023799007; X-Microsoft-Antispam-Message-Info: 8LtYb2yrfmQiVhLPX4dx2d+a17YFLenGU62CKmPjU9SwLAWv32lIGY+nZM2lwDTz9oGawgHr196RZrvDducNTJ3why0vLw59KGKrxILYnNY9DjUNXwjaL9D3LxGH3PizTxHJquuhETecreVaRcxDD6xcG3JjtJN3j5DyoqwVCM0u838Fucawuu1hI01UugO4EbyYlJFJ9GfBbrgQAsYPZP8WzEdS+RkeuBK2JE29G1P0p+Uv2AYhGWCfc0H8YXOcKdd3iPslvYlMQvJmsHOWp71vdFgkGgC4fvNfW+pDZJhYdm2nCBd4IYlz4Fj48YkKnc8H2EKxS36kijmuK13q/6WvZ+s9JsZ+ZPGxDC29KKkx3wSyijA1h+/HUejZrLriebvyvNC4ouDllDfYnkk4W/q+9d6p9cbcHQoQNzav7x3EX7R3af3246ey1Fv0Y7lwWjrToK+DZmMAEiaqzs66ozX9GpCo/hzaPQviJdr0L0/9cbE2rUW0wCsW9zVhJnPUVbk+W7SEHGUtcS0p0Uhcom77JJx0KucwOJAppMxN+g49JfR59UB5ElnWBSXN0yF6MdL9zb6o+kIP6Nq+/cLWbUESiQDynDn+H/VNYYy6satbjD9rDGtTbKpYzesCqG/Sug0R9HJoXEQu7LNok0J8TE2fVu4O2oHuFDZSqY/PjB3cd1pLqVP9K4SVa7e9e4FOS3OjnTX3Ng1W81I13IQbmg== X-Forefront-Antispam-Report: CIP:198.47.21.194;CTRY:US;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:flwvzet200.ext.ti.com;PTR:ErrorRetry;CAT:NONE;SFS:(13230040)(23010399003)(36860700016)(376014)(82310400026)(1800799024)(56012099006)(10067099003)(22082099003)(18002099003)(6133799003)(3023799007);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: dDw7dNGlx4+ggNn9so+nqWu0rAKiNXGKHcb1A770HR7I8kkgRZTMm70naPYXWoiJSwGA8XZC+7XIsy3opr5A0A6+Jd8urJAxqx1x126tDZtcY4ns5+uNEVtNsqPMyCEb/r2bd+EGNxZg5Fnf/wFoC5lhI7N6IHhdFWWCdYPVJUiyL7/rB/XfFkLvdwZbTN8oCBCeib/uh03XYTzLuTQUirEldAlGrLnZ3omWiNEyrks+Hhz7gGQyTWNUBn0B8J+Wp+q5A5l5pNrmB7Xz0Aghbrvx8ocBKG9l0otexK1t062bs6APIWW2pKUZK8Wq4Fm6oPUvWv62Pfe5TxiqmyxBtjijyVFzw3s54vdxbKWvimedK5lTvdUX3X3cvc0soQxH75zEcT4zIJwzf9NHWiX2QXWHbRXvD4dqFHX4DY13UbitIV1n4y3MiljiBgGoELo+ X-Exchange-RoutingPolicyChecked: vM55ektsThUjak1K6o7nEAcgp5Zh1+ja0hdtYS4XUcQWbeelssGl6rPzAgra+J9Q6g4cfnxda73+vVHQCb2Iv5z//u76eFykwXKNd6D0NYkOfCbX/EzQX9wtVDgL/juFe6ZTOGsItKyBrG8ktKwM0Vq7XTHT8fmh9tjXc9hQdxxWBJmi/PfH0JyfSHymE53RdPNZx2AG3E8Hii24ittQKYn1HCW4jC0M12E13fTY46+1ZJQ+fU6KPTkePiAeHCXUXwZghuNnnUovwIg1cfG772bkozdhO4ybXo3hlUtzRhXPwb6T0wMs1RFgo6hvYdNnLjk8g3pvUlrit02sw82GLw== X-OriginatorOrg: ti.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 15 Sep 2026 09:56:21.3121 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: f10e1148-f873-4c6a-e908-08df130f9883 X-MS-Exchange-CrossTenant-Id: e5b49634-450b-4709-8abb-1e2b19b982b7 X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=e5b49634-450b-4709-8abb-1e2b19b982b7;Ip=[198.47.21.194];Helo=[flwvzet200.ext.ti.com] X-MS-Exchange-CrossTenant-AuthSource: CH2PEPF0000013D.namprd02.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: IA0PR10MB6841 X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwOTE1MDE0MyBTYWx0ZWRfX42qVtTNNWIjN c1BFwsEBBkcGQvUo7Y43M1JgjIKbYznQVyEZFGO6MjVZRY4R/drECde9tIpSRbPBFjAjYAVDqi+ 2qFa64MgcVKl3ndPu37OClRLV4G/lp6WaVq+Bfsm094/e2Bip/J4QkvtOLiEIAHzQYNo+dsNcs9 zIhsw83wF81bnQXw5PvIxENdTbd5LGISRJtmfu2dFIKctHQBko4y0JRqe/C2HPCjeXOm5WM1ecK 0w9wNrZn08jyC2e0LLuQxQap+mO97rFstEJsdwRqi3bHpV+zDBe3gvCuRsHYlNJsnarwWHvv6Rv 8wi95zVhpcZGpS/bpQGCad4/MXRaZKxF4cKzUmax4IQ4vOkRCFT795ojGTOKtq9zqCouN2Yarsj 0pDeiW8+uF+GLXfBLsJe4FD3xJsX4XQ9WplYaYO0S+rpSXHslZHv6YcO8YOaT+nDs0a9tw7arVa ocHrH3jR8o131PJsnGA== X-Proofpoint-ORIG-GUID: y3gE6iXd_yUbtLkMFNcmbSczPILHstub X-Authority-Analysis: v=2.4 cv=U7cHnuru c=1 sm=1 tr=0 ts=6aa9164c cx=c_pps a=dnat/ZFdcaejr8kp+uhwWQ==:117 a=iwqwCZQqcuTv3JOpYdM7/Q==:17 a=6eWqkTHjU83fiwn7nKZWdM+Sl24=:19 a=IkcTkHD0fZMA:10 a=VdqzKS8jKosA:10 a=V5UXEbMT0ywA:10 a=VkNPw1HP01LnGYTKEx00:22 a=Z8NIEmU8O1QQgoT56wFK:22 a=taLDd7a_hP9WKsMzeGRc:22 a=sozttTNsAAAA:8 a=4-SKDGY5lZiqGY3zoJ4A:9 a=QEXdDO2ut3YA:10 X-Proofpoint-GUID: y3gE6iXd_yUbtLkMFNcmbSczPILHstub X-Proofpoint-Spam-Info: AW1haW4tMjYwOTE1MDE0MyBTYWx0ZWRfX5MWxeaxOHyBf P8I3qvo6ZjNnrwUHRh7fVhcJ0fmtzkOr236XWPEhPWFUhMKupkJAwQ1KUNOfb4k15PT/3rxSN06 MA5YWy2/j9jCo+8JUM4REVCeot53xFs= X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1176,Hydra:6.1.134,FMLib:17.12.100.49 definitions=2026-09-15_03,2026-09-14_02,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 priorityscore=1501 phishscore=0 lowpriorityscore=0 suspectscore=0 impostorscore=0 malwarescore=0 bulkscore=0 clxscore=1015 spamscore=0 adultscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2609040000 definitions=main-2609150143 Remove unused includes and define statements that are not referenced anywhere in the driver. Assisted-by: Sisyphus:claude-sonnet-4-6 Signed-off-by: Manorit Chawdhry --- drivers/crypto/sa2ul.c | 13 ------------- drivers/crypto/sa2ul.h | 12 ------------ 2 files changed, 25 deletions(-) diff --git a/drivers/crypto/sa2ul.c b/drivers/crypto/sa2ul.c index 13e941f58c4b..f98d199729d0 100644 --- a/drivers/crypto/sa2ul.c +++ b/drivers/crypto/sa2ul.c @@ -9,7 +9,6 @@ * Tero Kristo */ #include -#include #include #include #include @@ -70,14 +69,6 @@ #define SA_SW2_EGRESS_LENGTH 0xFF000000 #define SA_BASIC_HASH 0x10 =20 -#define SHA256_DIGEST_WORDS 8 -/* Make 32-bit word from 4 bytes */ -#define SA_MK_U32(b0, b1, b2, b3) (((b0) << 24) | ((b1) << 16) | \ - ((b2) << 8) | (b3)) - -/* size of SCCTL structure in bytes */ -#define SA_SCCTL_SZ 16 - /* Max Authentication tag size */ #define SA_MAX_AUTH_TAG_SZ 64 =20 @@ -199,14 +190,12 @@ struct sa_rx_data { =20 /** * struct sa_req: SA request definition - * @dev: device for the request * @size: total data to the xmitted via DMA * @enc_offset: offset of cipher data * @enc_size: data to be passed to cipher engine * @enc_iv: cipher IV * @auth_offset: offset of the authentication data * @auth_size: size of the authentication data - * @auth_iv: authentication IV * @type: algorithm type for the request * @cmdl: command label pointer * @base: pointer to the base request @@ -218,14 +207,12 @@ struct sa_rx_data { * @mdata_size: metadata size passed to DMA */ struct sa_req { - struct device *dev; u16 size; u8 enc_offset; u16 enc_size; u8 *enc_iv; u8 auth_offset; u16 auth_size; - u8 *auth_iv; u32 type; u32 *cmdl; struct crypto_async_request *base; diff --git a/drivers/crypto/sa2ul.h b/drivers/crypto/sa2ul.h index 48ed1933ecae..7c0ca2ca966e 100644 --- a/drivers/crypto/sa2ul.h +++ b/drivers/crypto/sa2ul.h @@ -169,7 +169,6 @@ struct sa_match_data; * @scid_lock: secure context ID lock * @sc_id: Security Context ID * @ctx_bm: Bitmap to keep track of Security context ID's - * @ctx: SA tfm context pointer * @dma_rx1: Pointer to DMA rx channel for sizes < 256 Bytes * @dma_rx2: Pointer to DMA rx channel for sizes > 256 Bytes * @dma_tx: Pointer to DMA TX channel @@ -184,7 +183,6 @@ struct sa_crypto_data { u16 sc_id; unsigned long ctx_bm[DIV_ROUND_UP(SA_MAX_NUM_CTX, BITS_PER_LONG)]; - struct sa_tfm_ctx *ctx; struct dma_chan *dma_rx1; struct dma_chan *dma_rx2; struct dma_chan *dma_tx; @@ -193,12 +191,10 @@ struct sa_crypto_data { /** * struct sa_cmdl_param_info: Command label parameters info * @index: Index of the parameter in the command label format - * @offset: the offset of the parameter * @size: Size of the parameter */ struct sa_cmdl_param_info { u16 index; - u16 offset; u16 size; }; =20 @@ -208,7 +204,6 @@ struct sa_cmdl_param_info { /** * struct sa_cmdl_upd_info: Command label updation info * @flags: flags in command label - * @submode: Encryption submodes * @enc_size: Size of first pass encryption size * @enc_offset: Encryption payload offset in the packet * @enc_iv: Encryption initialization vector for pass2 @@ -217,7 +212,6 @@ struct sa_cmdl_param_info { */ struct sa_cmdl_upd_info { u16 flags; - u16 submode; struct sa_cmdl_param_info enc_size; struct sa_cmdl_param_info enc_offset; struct sa_cmdl_param_info enc_iv; @@ -262,7 +256,6 @@ struct sa_ctx_info { * @dev_data: struct sa_crypto_data pointer * @enc: struct sa_ctx_info for encryption * @dec: struct sa_ctx_info for decryption - * @keylen: encrption/decryption keylength * @iv_idx: Initialization vector index * @key: encryption key * @fallback: SW fallback algorithm @@ -271,7 +264,6 @@ struct sa_tfm_ctx { struct sa_crypto_data *dev_data; struct sa_ctx_info enc; struct sa_ctx_info dec; - int keylen; int iv_idx; struct crypto_shash *shash; /* for fallback */ @@ -284,13 +276,9 @@ struct sa_tfm_ctx { =20 /** * struct sa_sha_req_ctx: Structure used for sha request - * @dev_data: struct sa_crypto_data pointer - * @cmdl: Complete command label with psdata and epib included * @fallback_req: SW fallback request container */ struct sa_sha_req_ctx { - struct sa_crypto_data *dev_data; - u32 cmdl[SA_MAX_CMDL_WORDS + SA_PSDATA_CTX_WORDS]; struct ahash_request fallback_req; }; =20 --=20 2.43.0 From nobody Fri Sep 25 12:05:54 2026 Received: from mx0b-0002e601.pphosted.com (mx0b-0002e601.pphosted.com [148.163.154.28]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 0BE2447ACCC; Tue, 15 Sep 2026 09:56:07 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=fail smtp.client-ip=148.163.154.28 ARC-Seal: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1789466169; cv=fail; b=avATW1JHI+j1tc2cbfPD2qvrNTnWBB4nFy+7548iqG7uwiD1E3vUJBdqPg06SsdIwChuWLN0iyjAwXBkEgW3KFtZc6KL85y9IWi+IbM8ZEJpTBtuPpmZS+4v4KrD+i+KFmxhI/w9mTaV5NtMVkyrtZZWivXPyOPUYM6i76iMDq8= ARC-Message-Signature: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1789466169; c=relaxed/simple; bh=lMNWcW5nQ187Y8oArj4VdaO+eE7Y4ni8tV1JjNJLlG8=; h=From:Date:Subject:MIME-Version:Content-Type:Message-ID:References: In-Reply-To:To:CC; b=P1AGwgRMNyyIRpXQaPQOGkP9lN0ZTQ5VlIp4RltdWJaokFLStLo/yHDW0wKYcfUKA3OaULLmbraqrdpZmo6TaCnQVwlkmqGpfZyZ9I88WkFSPWlluFqcsHAgM92Qwu05JKeNzSWITqLJbBLoHGZsN5mCPUE/YlLMfpT/80M9qbs= ARC-Authentication-Results: i=2; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=ti.com; spf=pass smtp.mailfrom=ti.com; dkim=pass (2048-bit key) header.d=ti.com header.i=@ti.com header.b=oFVKkRgE; dkim=pass (1024-bit key) header.d=ti.com header.i=@ti.com header.b=e7z6pg29; arc=fail smtp.client-ip=148.163.154.28 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=ti.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=ti.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=ti.com header.i=@ti.com header.b="oFVKkRgE"; dkim=pass (1024-bit key) header.d=ti.com header.i=@ti.com header.b="e7z6pg29" Received: from pps.filterd (m0374955.ppops.net [127.0.0.1]) by mx0b-0002e601.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 68F9fLV94098112; Tue, 15 Sep 2026 04:56:02 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ti.com; h=cc :content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s= proofpoint-05-2026; bh=dEquf+rJBeu87KW+5hJcN5LV+z4T+kj8tW0rS4ZeV 3o=; b=oFVKkRgE1/Z0nGit/Xh25E+zTvbOGajY5YETtYpoUnTrR6BdwbuiQBqBQ 12fSOcG+yn4PWlTLZjySMxVVsBjQePKtUbgfWYMp57mnq/myGS28gqiICZ+LvwTQ y6Ij2zY7ZlDieYdR5r2EGGWeXW14tnHZ77digx4yhUc5YufnL8hDihICC5qQetrD IvEg66jqMfj3RBrqRjP/HCHtCZ8Z+fm5sx+YgpbVBZR99H65jyuUZvN4Ebv05p3r DSyLHLQvxUVpF3hAnKCdjNzUT0QeMwK3nS3bovgHUL0GYg4RKdrx0CoVjvGZCWGR 9iFD+qsU3JQ30HRWXmn0coKSIPbLQ== Received: from co1pr03cu002.outbound.protection.outlook.com (mail-westus2azon11010068.outbound.protection.outlook.com [52.101.46.68]) by mx0b-0002e601.pphosted.com (PPS) with ESMTPS id 4gpvpjakeq-1 (version=TLSv1.3 cipher=TLS_AES_256_GCM_SHA384 bits=256 verify=NOT); Tue, 15 Sep 2026 04:56:02 -0500 (CDT) ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=LHNlm8rVrNfzGXCqAGc2iHdAYO0Sco+e8WahKl1ZRMk87P2QMiAQvng8uj3i1G1t7O/uPlbZhLvjM26YghSVqN0Mtf1CVIr4zj8U4wEr/GMax6QLU7Uj8DamATqpn2LUdhl5NfkpInQlBMikJHZ44ASblUXssRLhCCoWgUnXeH/96jPhMhdMwVQBcIFthO8YXOtbYS4KjFH79J92bOjNotX94dpUMCdggHDzkY4DAS7iPv1Hw7onu9lnNz/bhAkDKJ51oS1oNNFrgA4MzBp3LcLtezvVTbg2D+KVX97jKROw0g59N24UwbWVF5wpvob8bxz8P5+OF49QEkpeJONV9w== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=dEquf+rJBeu87KW+5hJcN5LV+z4T+kj8tW0rS4ZeV3o=; b=uZbjUVooHpArg9dMydRxBtPLv6jC1DYqsIK4aUsZrbmpph+EQ1QsesEHtAyn+2AdiOvHQVDA3A54FrvIvvZAZrBgjiQ8cfdzJj0Gg/JpBDZ30hdW62W31F0MhDJ67S+w3rC4ipS/oPPrXni456akN/CUCEaswfqnX6Uisa3a1dEz82fRe4NJ3r2dwdton2oWQAp36NYWjSYuVbgtfr1juT/INOfsSh4aW7J0LyVtktSHTQKInO2ub6w7MXt3VgBHTSiw4pbcWcp1usEtSJeHmTVtI3VtZs8rj/euwAU2dgMvPG1zAtqJLMfW1/AUJFncL+519mOdDf2ls4mHS5ARyg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 198.47.23.195) smtp.rcpttodomain=vger.kernel.org smtp.mailfrom=ti.com; dmarc=pass (p=quarantine sp=none pct=100) action=none header.from=ti.com; dkim=none (message not signed); arc=none (0) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ti.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=dEquf+rJBeu87KW+5hJcN5LV+z4T+kj8tW0rS4ZeV3o=; b=e7z6pg29kB6XlapLDnXR+acA8aUzlQqtX6T4JHuMIf+dcdw9IzWtkUKFaMsfiKUXufu4io5lC9EBRJ8FQ7/BJVnFEQ0S4delxWuK/R9MzLOKL2IoyRdmCyB3D0DTlMzwG0fQhsobWBchBmvH05rH7cQDf90AvkqoM1PKsrfs3uc= Received: from BN9PR03CA0061.namprd03.prod.outlook.com (2603:10b6:408:fc::6) by CH3PR10MB7808.namprd10.prod.outlook.com (2603:10b6:610:1ba::10) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.21.428.9; Tue, 15 Sep 2026 09:55:59 +0000 Received: from LV8PEPF00000068.namprd03.prod.outlook.com (2603:10b6:408:fc:cafe::58) by BN9PR03CA0061.outlook.office365.com (2603:10b6:408:fc::6) with Microsoft SMTP Server (version=TLS1_3, cipher=TLS_AES_256_GCM_SHA384) id 15.21.406.10 via Frontend Transport; Tue, 15 Sep 2026 09:55:59 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 198.47.23.195) smtp.mailfrom=ti.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=ti.com; Received-SPF: Pass (protection.outlook.com: domain of ti.com designates 198.47.23.195 as permitted sender) receiver=protection.outlook.com; client-ip=198.47.23.195; helo=lewvzet201.ext.ti.com; pr=C Received: from lewvzet201.ext.ti.com (198.47.23.195) by LV8PEPF00000068.mail.protection.outlook.com (10.167.248.41) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.21.428.7 via Frontend Transport; Tue, 15 Sep 2026 09:55:59 +0000 Received: from DLEE213.ent.ti.com (157.170.170.116) by lewvzet201.ext.ti.com (10.4.14.104) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.2562.45; Tue, 15 Sep 2026 04:55:52 -0500 Received: from DLEE202.ent.ti.com (157.170.170.77) by DLEE213.ent.ti.com (157.170.170.116) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.2562.45; Tue, 15 Sep 2026 04:55:51 -0500 Received: from lelvem-mr06.itg.ti.com (10.180.75.8) by DLEE202.ent.ti.com (157.170.170.77) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.2562.45 via Frontend Transport; Tue, 15 Sep 2026 04:55:51 -0500 Received: from uda0497581-ant.dhcp.ti.com (uda0497581-ant.dhcp.ti.com [10.24.51.159]) by lelvem-mr06.itg.ti.com (8.18.1/8.18.1) with ESMTP id 68F9tB813000901; Tue, 15 Sep 2026 04:55:48 -0500 From: Manorit Chawdhry Date: Tue, 15 Sep 2026 15:25:17 +0530 Subject: [PATCH 11/30] crypto: sa2ul - remove unused line Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-ID: <20260915-b4-upstream-sa2ul-cleanup-v1-11-57ab34e97162@ti.com> References: <20260915-b4-upstream-sa2ul-cleanup-v1-0-57ab34e97162@ti.com> In-Reply-To: <20260915-b4-upstream-sa2ul-cleanup-v1-0-57ab34e97162@ti.com> To: Herbert Xu , "David S. Miller" , Keerthy , Colin Ian King CC: Andrew Davis , Pratham T , "Kamlesh Gurudasani" , Udit Kumar , , , "Manorit Chawdhry" X-Mailer: b4 0.15.2 X-Developer-Signature: v=1; a=ed25519-sha256; t=1789466112; l=681; i=m-chawdhry@ti.com; s=20231127; h=from:subject:message-id; bh=lMNWcW5nQ187Y8oArj4VdaO+eE7Y4ni8tV1JjNJLlG8=; b=0EwS4TDDXUeVjXxtEEJl+i8qJaiAptgtY6vPPF5zT5SJhEOBoX1vp08J9XmYXPze7OpEvbHIw a6WuCib7P1rAR56m4esY7eeeFBLvMDf+GlDfxQ5e6kU5YJV1yU6g/Zs X-Developer-Key: i=m-chawdhry@ti.com; a=ed25519; pk=fsr6Tm39TvsTgfyfFQLk+nnqIz2sBA1PthfqqfiiYSs= X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: LV8PEPF00000068:EE_|CH3PR10MB7808:EE_ X-MS-Office365-Filtering-Correlation-Id: 9bc41515-5fee-4567-f285-08df130f8b7d X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|82310400026|1800799024|36860700016|23010399003|376014|22082099003|18002099003|56012099006|10067099003; X-Microsoft-Antispam-Message-Info: xF+YKt2Y2QHGDCohKfzDdBVHoJftpfDtvJeX18re7UyrflVSsUI4gJMURqUgDfUo/4SOuM92csvNnIDnSaTyvK4yxI88YRY2RHmeZayKEowggDlX8r+Lj0+WkU91umUObL+UUmtsKV0RR2J1+EeMtguQGQ0ZFeYbnQE2H4CKhaeHHPBFVA43YdszgO81c/0scX8Eyjmy/fOfXB2FQ+QJW2vpSrkpPSJ/Irf1UCAlpSDDW2HSBlxqzO7PFxyeIaU76Yzzl7vOC/egvOKaWz9IBZ4DXOX+uuwlyH3mddcLhxCk1t8GBS2xdGkif9Mp/o3XU04RHd5KRomEBH2F8V659ktTDmx5QtUmMADzdl5B9DiRbpPU0otiBft3SL7RW9ppvaOoMg0QineIPbzB0vY4DagBAlUQnQyDnIr8ZNJV/fduMb5oxA90k23FliaE00DYzGNCRmEcK+H7n/CxdjGOg53zbjpUuCXgK/aljdiYFCvTytuOvi8lwwyeeV5apYBg7tJahk68i7IDMKz4LqzsSa1J7gtt8rkVwXY7h9jgYuma0hvCZCqEreM4rKR9Jwr+pERpukNuBQm1dIml3vXjptl4a38F/xKGGMo7Bv95K1Zd68qTC3a6ocbKcMySJ19EBz8fuKGMyDg1amS97+xLo9p/4tov1DFtd55xp4RYX2OqFxHwO33Wme5VxbCL8dCViszMVOEhePXV0ULyBhJ5mA== X-Forefront-Antispam-Report: CIP:198.47.23.195;CTRY:US;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:lewvzet201.ext.ti.com;PTR:InfoDomainNonexistent;CAT:NONE;SFS:(13230040)(82310400026)(1800799024)(36860700016)(23010399003)(376014)(22082099003)(18002099003)(56012099006)(10067099003);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: Y4lI8zd3lLltgyAFxk5IiYNlQuC7KM26maFjo/eCbbttlSZh09M7ZSZ9rfddNIJsP7mNaLUWdaWRjbYEXBWmOJBYgnx0BWI45YSnq6qhVt/RDEJeMXnd0paaHvB3mwu+SPD1WmBl5SFEStRuTahZYa/IfrJQT8xabQVlrZS3YZlf5F+T0XCP5Lbs5s9G1xjdGVkD3nMzQ6ZdHaGMvREXOlw4CKrfnJ3qHmVQeGp5K/UX5oneokcBFEVsP8wnkDu+R1A0KmMVfMBJLCQgi+zHz/Ex57eAROyOv+dropJgu5PhJ11rCB1tiNd/qd44YFc3/VAVERXsTETrh7PbYVdphTWsViN0eZYj90OMpYm32jiDmi1CoAQxZBw21Y5KOiIy4Sx7htGH77/Ow51QlYvEjKhoSuJaVIWvr3RqpSB+P4L3XQjCUQTyaaIksSZkQ1iQ X-Exchange-RoutingPolicyChecked: qCuV2AVMnvLoDr2+i+G8Bmrxlp8S3F35Iz5CDeelgLHPVTx3gYiLlROQN2rOXrfalzx4rLktJztxDSP++AH1Q2U812Ww2eV41Wb9AZY/klyYi5LIeGDqVwCmtWk+JFvokru7XztCy4N0Y5+gkkd62pAcbFIAH1UqKZtx23XK+vjrdyQicVUO9ww05+x737Vz1zSo4d83l7Q8JGOsx1qmNW+U+7UdLFxOXwKIfewKa17spEL1O+YII8XsD0MGnkRGSpbA9KGQIFzpFpQKc05wKbeK0OoTyVrPiVYSJ3cwCPmUuBb6AUv2nsHBdwDIbLE3mfGuMXPvQshYWEn7Sbv+pw== X-OriginatorOrg: ti.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 15 Sep 2026 09:55:59.4353 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 9bc41515-5fee-4567-f285-08df130f8b7d X-MS-Exchange-CrossTenant-Id: e5b49634-450b-4709-8abb-1e2b19b982b7 X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=e5b49634-450b-4709-8abb-1e2b19b982b7;Ip=[198.47.23.195];Helo=[lewvzet201.ext.ti.com] X-MS-Exchange-CrossTenant-AuthSource: LV8PEPF00000068.namprd03.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: CH3PR10MB7808 X-Proofpoint-Spam-Info: AW1haW4tMjYwOTE1MDE0MyBTYWx0ZWRfX5te99zSv+XcU kxR5xZFmwJajR/i0zFTfv0863JoiuMJWCDwoDJR2G3IFhwdiikwXUXnAKNwrOjbhxZSDPbEnF/i LYbH3aDMQdUXhjoenaGigTGxuFFICg8= X-Authority-Analysis: v=2.4 cv=KvnYSmWN c=1 sm=1 tr=0 ts=6aa91632 cx=c_pps a=bquUzJqYOqw1EpBvECFzMQ==:117 a=f+v6EHfkeJbVwR46tk4DMg==:17 a=6eWqkTHjU83fiwn7nKZWdM+Sl24=:19 a=IkcTkHD0fZMA:10 a=VdqzKS8jKosA:10 a=s63m1ICgrNkA:10 a=V5UXEbMT0ywA:10 a=VkNPw1HP01LnGYTKEx00:22 a=Z8NIEmU8O1QQgoT56wFK:22 a=fPAWb5peG099m5CrUpKH:22 a=sozttTNsAAAA:8 a=mT09JPwF7r0fN5Lx0jUA:9 a=QEXdDO2ut3YA:10 X-Proofpoint-ORIG-GUID: slDAvFJqfJiFPkJrS6XyP3Xbd5srcw-T X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwOTE1MDE0MyBTYWx0ZWRfX6dUHTHF5zEbr ZAslTR4sAbnPtzGrwkdatR2gbPxGBHptZmWX95xhqv3P2eGz4s55vxJ1B8GTypilH0lVQlf9EWa 0FlvA2RvH4mACLtcox09jzwjx7ol6P8trhqs5f6aW8nNB99VEXdY8JBgqOxK+tPwwnzljcvBuSe n7qQNHZDug9CM3Z89PoEY1LM+Q82AAtuC7nPy3aqeq4YWBTYNnZ1YC1GefJc3U/QLdtzwBbQ3Hq txCUiS945MA+aRf5Of8zos2mWbeekQQkEYCyb7fs2t29iMg0SMSE0LKQCowdBakbBPqhccnFHZ1 Q/Kh1+g/5w+mlYU6DFCLlodotmyWhPLUB9aY1r7v6Y2MNvEaCxuE80xwnfIisMqz58zfDfWNiA3 su1BRiRUeb842yuMe1IkHypJUS4eiumDNLAylVqkB9PwPJtsGtu1QF9VhvvVJUTUVBt8WXMyRz7 DGTGZPTuAcdR8/eysBw== X-Proofpoint-GUID: slDAvFJqfJiFPkJrS6XyP3Xbd5srcw-T X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1176,Hydra:6.1.134,FMLib:17.12.100.49 definitions=2026-09-15_03,2026-09-14_02,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 lowpriorityscore=0 clxscore=1015 priorityscore=1501 impostorscore=0 suspectscore=0 spamscore=0 bulkscore=0 adultscore=0 phishscore=0 malwarescore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2609040000 definitions=main-2609150143 Remove an unused line from the driver. Assisted-by: Sisyphus:claude-sonnet-4-6 Signed-off-by: Manorit Chawdhry --- drivers/crypto/sa2ul.c | 1 - 1 file changed, 1 deletion(-) diff --git a/drivers/crypto/sa2ul.c b/drivers/crypto/sa2ul.c index f98d199729d0..c774447e7a5a 100644 --- a/drivers/crypto/sa2ul.c +++ b/drivers/crypto/sa2ul.c @@ -1239,7 +1239,6 @@ static int sa_run(struct sa_req *req) sizeof(u32))), cmdl, sizeof(sa_ctx->epib), sa_ctx->epib); =20 - ml =3D sa_ctx->cmdl_size + (SA_PSDATA_CTX_WORDS * sizeof(u32)); dmaengine_desc_set_metadata_len(tx_out, req->mdata_size); =20 dmaengine_submit(tx_out); --=20 2.43.0 From nobody Fri Sep 25 12:05:54 2026 Received: from mx0b-0002e601.pphosted.com (mx0b-0002e601.pphosted.com [148.163.154.28]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id CA19B496D42; Tue, 15 Sep 2026 09:56:49 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=fail smtp.client-ip=148.163.154.28 ARC-Seal: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1789466212; cv=fail; b=A12q/Jl6bmRlEWcYxCyEBuMZh2/z1q5R5/iAfGmwNIlrIPox5GePUzrbDIReu9/JmtoovUnb823ViQEqW0lagmxkNZtN57bjlN/Ci2Z3D6A4H2TzZMbmQbB6OxfPo6EsK6xsyawSBIoJy+Rw47FaXSUJCwCocslvJESHtpsJFJU= ARC-Message-Signature: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1789466212; c=relaxed/simple; bh=RTU9a9Jfk+9KKkW4SLFWJDg6vliwPpbeJTjMsGaxils=; h=From:Date:Subject:MIME-Version:Content-Type:Message-ID:References: In-Reply-To:To:CC; b=tDkzNFq67VstoQg9v0iZRLqE+v3pn1/f9w2xsGChd0X8gucpf9yenVHBD+cJpTtzH4HZAItV6YcqVocfRt5EgTi7hknTA2vg9tUb0iRj3juXDXVQkFhunXd8hEspdbSq6qRyPE3+MOkYwpRrat4cKTroKdO0oNe9oS678d8yBo8= ARC-Authentication-Results: i=2; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=ti.com; spf=pass smtp.mailfrom=ti.com; dkim=pass (2048-bit key) header.d=ti.com header.i=@ti.com header.b=lZw8Lcad; dkim=pass (1024-bit key) header.d=ti.com header.i=@ti.com header.b=GNtbHJQf; arc=fail smtp.client-ip=148.163.154.28 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=ti.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=ti.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=ti.com header.i=@ti.com header.b="lZw8Lcad"; dkim=pass (1024-bit key) header.d=ti.com header.i=@ti.com header.b="GNtbHJQf" Received: from pps.filterd (m0374956.ppops.net [127.0.0.1]) by mx0b-0002e601.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 68F9fBmF3810825; Tue, 15 Sep 2026 04:56:44 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ti.com; h=cc :content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s= proofpoint-05-2026; bh=ezgsnIVBbD5j1+lkPVQxk+QbT7H1Tei7WoYan47Q5 E4=; b=lZw8Lcad5NGV20DAdZo48Iil9ioOHCgd+niJIyvcS2Oh3CSdIolLS1GCU JrsBGMw8lvXqvE24rukrOYMdqCU4LroMJ6esCsEPBK/mx/J/5pAqhVlc4H6eFtjP al1gvNMCysV9nWiIUJIqcGJG9mpF1NKZPv7hh5jZPS88hGIPLZamHR1FPk1uhw7y HtSOBCBuypH0FKcDGLG0RUxAWbo2JJIcAXR/11sBD3dq6wzuDCBP22RrrkTLOC3D a3PUQLiEl8aan/f7x9MD0Fkd8SNiGuyasbPmr2eebIPMRRdgI4X/eYkv1gET82Vn eyq4uihhopaEDT5wFEM9qLfyfXlWg== Received: from ch5pr02cu005.outbound.protection.outlook.com (mail-northcentralusazon11012048.outbound.protection.outlook.com [40.107.200.48]) by mx0b-0002e601.pphosted.com (PPS) with ESMTPS id 4gq362r9yr-1 (version=TLSv1.3 cipher=TLS_AES_256_GCM_SHA384 bits=256 verify=NOT); Tue, 15 Sep 2026 04:56:44 -0500 (CDT) ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=P411Fg+qfzKb9vUUGgGXLGqVj7yzctn6cT+sGySh7AlAMTJraKFjY0u7VayK3plQlj+43NfvS4M75OczjM3EbN64S5VWFX5sO4DH5eXDtXV3BYUuwffJLcR8sGwGB9MjNYjOQnZpA1s46J5p85RqAT/NPjmtYfjYXTSd7B0IlLFre9GQ5P8VM2UAKfDqkPQR4FIJRsJckIt+/9sHRPUvBe/9+l7YHYmEu20MLM732Ng3evTwZyttLigLSdCGF6KP9R9reG4kqJPaYhDNEKkm1ikgjMxV+9CEigvf4NEIGVb/dv8CeQZAQsGjp0n/PUjioQwcTltInT4pxr3nJst72A== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=ezgsnIVBbD5j1+lkPVQxk+QbT7H1Tei7WoYan47Q5E4=; b=TFdyDn+yLUhxmrH20h/ts5Hr+B1U844Wp1AelmYIKPg4CgRpMZdoo+vE0bQTU+/gxpyzTbttA5uMaGxoesV4HubKXJKWuK7LLdDy48+Hj+5+5ibUOFXOqqY4pYK6luZn68TusBqdpT4pJVXNgF5qDZuJUqWraZALe8QlWqy1tMWQqfcTsCootiqc5TFRnnOGsKnCl0GcQ8mCMUrMly6IxSKrmiT9690GGTm2hfmQQHntqsmppik5DATz7shVlcodQIS+Jpej7emcx4wEj7QlFk73Zz3Eq25JRov3Ia0O1QdW5ozTHKazSxe8uclc1GKjTSHuBR9l/P5bkUYT1FT+Rw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 198.47.21.195) smtp.rcpttodomain=vger.kernel.org smtp.mailfrom=ti.com; dmarc=pass (p=quarantine sp=none pct=100) action=none header.from=ti.com; dkim=none (message not signed); arc=none (0) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ti.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=ezgsnIVBbD5j1+lkPVQxk+QbT7H1Tei7WoYan47Q5E4=; b=GNtbHJQfVBIYnZ8C9/viV71uFKvS6OZwn+XRvXt3F0T+hFDOP2tBu1VU2bzvicI30jnduFGu91Vcj0nKP9nhTimLN3T1VvDwE8yQUpbPLQMun0ZpeMU9LG18fxZbDy5xQnucbAg1G9+CiZK0sR9itXA2JsX9iW2FpxcsKDX5HJM= Received: from SJ2P221CA0012.NAMP221.PROD.OUTLOOK.COM (2603:10b6:a03:5db::16) by IA4PR10MB8659.namprd10.prod.outlook.com (2603:10b6:208:56b::6) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.21.428.8; Tue, 15 Sep 2026 09:56:36 +0000 Received: from MWH0EPF000C6186.namprd02.prod.outlook.com (2603:10b6:a03:5db:cafe::27) by SJ2P221CA0012.outlook.office365.com (2603:10b6:a03:5db::16) with Microsoft SMTP Server (version=TLS1_3, cipher=TLS_AES_256_GCM_SHA384) id 15.21.406.12 via Frontend Transport; Tue, 15 Sep 2026 09:56:35 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 198.47.21.195) smtp.mailfrom=ti.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=ti.com; Received-SPF: Pass (protection.outlook.com: domain of ti.com designates 198.47.21.195 as permitted sender) receiver=protection.outlook.com; client-ip=198.47.21.195; helo=flwvzet201.ext.ti.com; pr=C Received: from flwvzet201.ext.ti.com (198.47.21.195) by MWH0EPF000C6186.mail.protection.outlook.com (10.167.249.118) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.21.428.7 via Frontend Transport; Tue, 15 Sep 2026 09:56:34 +0000 Received: from DFLE203.ent.ti.com (10.64.6.61) by flwvzet201.ext.ti.com (10.248.192.32) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.2562.45; Tue, 15 Sep 2026 04:55:55 -0500 Received: from DFLE202.ent.ti.com (10.64.6.60) by DFLE203.ent.ti.com (10.64.6.61) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.2562.45; Tue, 15 Sep 2026 04:55:55 -0500 Received: from lelvem-mr06.itg.ti.com (10.180.75.8) by DFLE202.ent.ti.com (10.64.6.60) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.2562.45 via Frontend Transport; Tue, 15 Sep 2026 04:55:55 -0500 Received: from uda0497581-ant.dhcp.ti.com (uda0497581-ant.dhcp.ti.com [10.24.51.159]) by lelvem-mr06.itg.ti.com (8.18.1/8.18.1) with ESMTP id 68F9tB823000901; Tue, 15 Sep 2026 04:55:52 -0500 From: Manorit Chawdhry Date: Tue, 15 Sep 2026 15:25:18 +0530 Subject: [PATCH 12/30] crypto: sa2ul - remove redundant sa_sha_digest() wrapper Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-ID: <20260915-b4-upstream-sa2ul-cleanup-v1-12-57ab34e97162@ti.com> References: <20260915-b4-upstream-sa2ul-cleanup-v1-0-57ab34e97162@ti.com> In-Reply-To: <20260915-b4-upstream-sa2ul-cleanup-v1-0-57ab34e97162@ti.com> To: Herbert Xu , "David S. Miller" , Keerthy , Colin Ian King CC: Andrew Davis , Pratham T , "Kamlesh Gurudasani" , Udit Kumar , , , "Manorit Chawdhry" X-Mailer: b4 0.15.2 X-Developer-Signature: v=1; a=ed25519-sha256; t=1789466112; l=1724; i=m-chawdhry@ti.com; s=20231127; h=from:subject:message-id; bh=RTU9a9Jfk+9KKkW4SLFWJDg6vliwPpbeJTjMsGaxils=; b=S2QKNZyBecFpKPveoQsJHPJqupvh2Svf9G3cGOC8XwJCd/OP897cv8bqwbZGbojHjk9Gshbbx Fsq2Pi6XDLQDZBv5ndyJL4tQYfvxbNao51Wkjb/2miHZzeQ0xH15YlA X-Developer-Key: i=m-chawdhry@ti.com; a=ed25519; pk=fsr6Tm39TvsTgfyfFQLk+nnqIz2sBA1PthfqqfiiYSs= X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: MWH0EPF000C6186:EE_|IA4PR10MB8659:EE_ X-MS-Office365-Filtering-Correlation-Id: 53c52097-bb5e-4c71-f1b8-08df130fa05c X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|36860700016|376014|1800799024|23010399003|82310400026|56012099006|10067099003|18002099003|22082099003; X-Microsoft-Antispam-Message-Info: SjoouWh7EYPSQBc0SiU8ImXFJZbsXODrvHkfG2SHkAdiGhyzJUpxh2N52W1dECdZmWxz8Fv9Hn6PgZOxk+/c15KkXWnZA++Sa9GnA8WCSCAQpce3LrvKsUZHXQweXKJ+KeTz4mOK22JjvOVRYkXnAeyo4jciioSf/aVmhIjWY8pTg/8AYSPDO4x/qhLUB2v1TNzBdabUxd3iZk09lqX0JqlnbjsYTzVHU4JOz6zrv37oQstvhavp1xUuz6V1aZMGawMDTM4tvFgxRZsQ5wh/GhbhVaTzR0yc9WmCVrWqrt9tlnXTwLQKH24A/tpgUJY77LqVGukC9oWdcdKjIhdWI5uop39G/EIqj03ugglcY/7CZZbEKWxwZgubUjepGoJEvSvVxnI6W9aJ0+ZlHIeeuUSSbU4Z+AzVousYp+X68wE+244G8kZGTmLpjuM1MumIsftFbefvYXJz7j/Mq4j3WgYyt0iAjRy4Gu46J6AT0KwyH58HdLXALDS3QqSIIaWz/CNf93sT6dGFPVgKCzXxJvWUuRiyQQq6cMYvkQKJujEy3N3mkN2zY6SKavJ3awI+TgbdOYCOaJLxWv92ow2uN0ETCvCzLbIvzSrXZtD3AwJ6NnuN7zQVK6gQ/3yAyxKNLp53gYxbTJmS8JDRVsCD9RZSXQOFXL/WaMd0/2WHX2ux2jfnCz+szoFtJAc1FYII7sXtSJNHNo/jYvasQFRTAw== X-Forefront-Antispam-Report: CIP:198.47.21.195;CTRY:US;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:flwvzet201.ext.ti.com;PTR:ErrorRetry;CAT:NONE;SFS:(13230040)(36860700016)(376014)(1800799024)(23010399003)(82310400026)(56012099006)(10067099003)(18002099003)(22082099003);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: 5nE9X8Q4hvhJVmGhdOO3nOMb3HHL6C2XqBMw+PFUe7h4qwUr8/jfY/T2uNNH2uyU8XA4rgkVOEJQatSRH5b+RA7p9S1hP2QESF1O9mtfMCES3Kg/bvp7/6WyeGI9jllewCVp1/lx04fpzyk+iWh8lyTYtx9AIrQHDrrR6GdSm9ewMMTbkVOAgAdImv+SBe2aqUpzluM7Khey+ZBzRL3NcCaMp6VZoecHTUZPCBVXlJZ796YVOySwWd9ulY9+t2GOw65/nbS+tebemDR3Fuldkh8CzMZBZsFFrlV+ry/0G+4FX+SN3fDRHPOGEotLJDVZqaSFce07xmNf09qlLjeugN0TuH0s+uhDqA6CrB4qu9EqPfg7HR9igxmF3l8Ze4tRk4rlengbarzqF52HYxtgP5b89eAURBH7k4bzxoWQFPig46zOUFddD/3+htgcDoRL X-Exchange-RoutingPolicyChecked: 3XIQxMamfajxbxhced69U/3hc9Jo2VWjoCBNEoNAAUK/hz/ShNtQGuRHCkY+F8u45fviKBzNw8eEZNV5pfJkitbZ4WqOfwzhaXX49OaiXA8Je3wWmOgR4vRL1sGFJZ/FPPXCaR16I8UJMfeSPOySLbusjQ13/jdsytj8eWr05Fif69GlFo7DF6AAF9dKj0HO8FoVPD1dKr70D767dTKpg7O1jtxyqGEDGOQ3mfYBgjgdpFvimGgqw465/HuUJxGq5lJy/Cjm+5AH0eYlIkaJx+L1V+I5qX0DaNgoj2oNPlPoMCsms0JuRzlXOnsgtBR35jjixESPBibfyXBROVxPRg== X-OriginatorOrg: ti.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 15 Sep 2026 09:56:34.4422 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 53c52097-bb5e-4c71-f1b8-08df130fa05c X-MS-Exchange-CrossTenant-Id: e5b49634-450b-4709-8abb-1e2b19b982b7 X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=e5b49634-450b-4709-8abb-1e2b19b982b7;Ip=[198.47.21.195];Helo=[flwvzet201.ext.ti.com] X-MS-Exchange-CrossTenant-AuthSource: MWH0EPF000C6186.namprd02.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: IA4PR10MB8659 X-Authority-Analysis: v=2.4 cv=P9yvFSAu c=1 sm=1 tr=0 ts=6aa9165c cx=c_pps a=JJStoDgKLvGmSPu1zToK9A==:117 a=tJyPKKxUohctrY4NYmUjkA==:17 a=6eWqkTHjU83fiwn7nKZWdM+Sl24=:19 a=IkcTkHD0fZMA:10 a=VdqzKS8jKosA:10 a=V5UXEbMT0ywA:10 a=VkNPw1HP01LnGYTKEx00:22 a=Z8NIEmU8O1QQgoT56wFK:22 a=jwouBfj2j3NM8CExmVVE:22 a=sozttTNsAAAA:8 a=SUp_HzdAlOlFxKILCdgA:9 a=QEXdDO2ut3YA:10 X-Proofpoint-GUID: wInvk3OOdvv61eUtn3BghPIDroFZ4FKo X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwOTE1MDE0MyBTYWx0ZWRfXw5zUDXXBroVx Od7VqyGJTJ1yxYuulZP5M8WKhvL9BjKnhNlDxTkRnxzt/dVJlsLK2cnYvNOfxR1Oz+vMRFL21Lz nSwWhdF2zOpop66efBW59BtW+TzN+o6/0JqVbuiDsUkuoug/Joor97xOKedJxtaor6+LsSfKqkK T4b9Wz3wnaP9hhnpuk28o2pca0GWzdjauMWuMoJQ8zxzCuCE7inGZkecNjS51ZYJvWaoEN2t6dc nLc52ncMNaPLfChDj1cVk8Rwk57qd0S3dE/rd3Jkf2zSOsGicvb837NoTIBAQdCpJjBViEG57HZ Ze42TJbMa6oHLBtk2aNbWoE5ZLaqnOsbMMGxqWEbBN3GpsnvvBu2ZqDLCYT+t7rv5TYnA9tpoXa taKKZVdcU0dOZvm52JWhEeDIKHc9j8UN7Ha7V6zCD/KfAtHwLTzzSYUoxvFfHis/1mxGoiPKiBL S2MJ4XJnDTp9pfYKzLg== X-Proofpoint-ORIG-GUID: wInvk3OOdvv61eUtn3BghPIDroFZ4FKo X-Proofpoint-Spam-Info: AW1haW4tMjYwOTE1MDE0MyBTYWx0ZWRfX/u7M9IFoR288 01eU1bZdWf6a3qdIN2aE0BxlMVO7AWhFZN04xohen51Yh9U8OKbbJSAcBNx5uCwjxH6g+X+h10t jMft2ZuBgWsV4hsGQniuog4Zy7hKtgU= X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1176,Hydra:6.1.134,FMLib:17.12.100.49 definitions=2026-09-15_03,2026-09-14_02,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 phishscore=0 adultscore=0 bulkscore=0 suspectscore=0 priorityscore=1501 spamscore=0 impostorscore=0 lowpriorityscore=0 malwarescore=0 clxscore=1015 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2609040000 definitions=main-2609150143 Remove the sa_sha_digest() function which was a simple wrapper that only called crypto_shash_digest(). Replace all calls with direct crypto_shash_digest() calls. Assisted-by: Sisyphus:claude-sonnet-4-6 Signed-off-by: Manorit Chawdhry --- drivers/crypto/sa2ul.c | 11 +++-------- 1 file changed, 3 insertions(+), 8 deletions(-) diff --git a/drivers/crypto/sa2ul.c b/drivers/crypto/sa2ul.c index c774447e7a5a..673cd1458948 100644 --- a/drivers/crypto/sa2ul.c +++ b/drivers/crypto/sa2ul.c @@ -1476,11 +1476,6 @@ static int sa_sha_cra_init_alg(struct crypto_tfm *tf= m, const char *alg_base) return 0; } =20 -static int sa_sha_digest(struct ahash_request *req) -{ - return sa_sha_run(req); -} - static int sa_sha_init(struct ahash_request *req) { struct crypto_ahash *tfm =3D crypto_ahash_reqtfm(req); @@ -1997,7 +1992,7 @@ static struct sa_alg_tmpl sa_algs[] =3D { .update =3D sa_sha_update, .final =3D sa_sha_final, .finup =3D sa_sha_finup, - .digest =3D sa_sha_digest, + .digest =3D sa_sha_run, .export =3D sa_sha_export, .import =3D sa_sha_import, }, @@ -2026,7 +2021,7 @@ static struct sa_alg_tmpl sa_algs[] =3D { .update =3D sa_sha_update, .final =3D sa_sha_final, .finup =3D sa_sha_finup, - .digest =3D sa_sha_digest, + .digest =3D sa_sha_run, .export =3D sa_sha_export, .import =3D sa_sha_import, }, @@ -2055,7 +2050,7 @@ static struct sa_alg_tmpl sa_algs[] =3D { .update =3D sa_sha_update, .final =3D sa_sha_final, .finup =3D sa_sha_finup, - .digest =3D sa_sha_digest, + .digest =3D sa_sha_run, .export =3D sa_sha_export, .import =3D sa_sha_import, }, --=20 2.43.0 From nobody Fri Sep 25 12:05:54 2026 Received: from mx0b-0002e601.pphosted.com (mx0b-0002e601.pphosted.com [148.163.154.28]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 9F94F489880; Tue, 15 Sep 2026 09:56:37 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=fail smtp.client-ip=148.163.154.28 ARC-Seal: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1789466200; cv=fail; b=RlNXWXvvhuFjBx3rgBgyHy6HSMstq8rMGNXZIlq9TEBr/xaxk5G1btvj6RdfNKUgSddBtJ1QM9bueB5eVzwH/qRF9WpJkEuosmBVss7UkiT8lFB9cc2oWx/AlvDaqUSpNlT3Rv9Oxlf4PwSzJkP4pRrnI+lyojMiLAp8OwZys4I= ARC-Message-Signature: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1789466200; c=relaxed/simple; bh=ZgQNzFQwy5Bm25q7i4u6MuBiNs5zBjwT+dWYrGEw6UE=; h=From:Date:Subject:MIME-Version:Content-Type:Message-ID:References: In-Reply-To:To:CC; b=m3+UIPeTxJmCM7+kjgvuI5+yzi1iVg/m4JpFV0JFvxWpJymRsfrW+02tvGFS5G+qqidNsS0RPj0n9Xka0uqwtfkyPG41DREiT8tnRz5NWolgq47Dqx9XDGy6jHnndaKIa7TFobrb5FMlCVEf5vKRxv5nAzhF+W9IFhPH0C76wro= ARC-Authentication-Results: i=2; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=ti.com; spf=pass smtp.mailfrom=ti.com; dkim=pass (2048-bit key) header.d=ti.com header.i=@ti.com header.b=kW/Mcz3+; dkim=pass (1024-bit key) header.d=ti.com header.i=@ti.com header.b=G9QZbU83; arc=fail smtp.client-ip=148.163.154.28 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=ti.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=ti.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=ti.com header.i=@ti.com header.b="kW/Mcz3+"; dkim=pass (1024-bit key) header.d=ti.com header.i=@ti.com header.b="G9QZbU83" Received: from pps.filterd (m0374956.ppops.net [127.0.0.1]) by mx0b-0002e601.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 68F9fCNB3811029; Tue, 15 Sep 2026 04:56:33 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ti.com; h=cc :content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s= proofpoint-05-2026; bh=ILDOmEwf1i0BmaeYTLLHUOIT4vwwkilIwjVe7qP2k JY=; b=kW/Mcz3+/eNYvSBug5Y8DDt9rpcn4QjGyuvRuzk0X0rvSKkukUFgpxWiL 9L6OEmGXn2Y/Dg4td3urNdl8Llyu7cV6xor8JFs6jMcGUjK12y1QM+CBouEQQDNp oX3WnEv+KqyZJyXJovpaHfGg0xTZV8bYY891+rpVSo/K3be4xeYWmrpCL/rdVug+ ucRemqSiiF97wGKWZPxs+gX0jxGLzJ7WoKu/q/3QZsYB2KwKUHtImNCXAfOKvAMf wGwwIb5+Tt+eKICutpYKKm32s0HWtiwtaVicmXN7XPWFv6Oii4isnMjwbeT4cgdX tirbir6sx/UoHDmnXmSHvLbzcF6eQ== Received: from mw6pr02cu001.outbound.protection.outlook.com (mail-westus2azon11012034.outbound.protection.outlook.com [52.101.48.34]) by mx0b-0002e601.pphosted.com (PPS) with ESMTPS id 4gq362r9xd-1 (version=TLSv1.3 cipher=TLS_AES_256_GCM_SHA384 bits=256 verify=NOT); Tue, 15 Sep 2026 04:56:32 -0500 (CDT) ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=mmG6uJfM4+YHfZ7R+kf0CyCZl/pQCTuUYCk2ux5XbXr6pquFSSBMgBFrWXMNPUNzZ1P5OpmHgHDBTxOyA74vXf4+EdbHZ4UO1BXpHJDH5CvIRKq+NCtIrfrZ4Lc1kiTdK9sNosZNvNSpPQO0+hxMQ+lU0htAX5tlDazhJzDT5fVVsd7dlrlq1U39DGeJYYR4KvoI2VLTLXldWH6WECjCHC1gKYfjE9QBLgbc1oV/bVChw2oPPb3QRQ9w27XYLlkI6wzamwdskvQrD9aKIvlF/T+X17Tqt3SWN8wlXkjPDg8euYz3hn5PF1uUjMogopwcpBsBT1bQBg92+yg56Phtnw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=ILDOmEwf1i0BmaeYTLLHUOIT4vwwkilIwjVe7qP2kJY=; b=eRCEbE4R38XkosCHnuGaDem1U8rjC1iEnpDsP4lk80c2GGyMjIgxuFPAnezUUigcJb4I6BBzABKZg9Od7yTdKiH5GUtnmaT+Wk2waEWGuae80W5d7MIVZ8eH9ZgF7pXG8L+YEmrH4TlZrSvzRkUw67bi7Txk4XAi5uJtajunSbYcZAuDisQu+b7uB2rM+HN9IUXBFMc6zNN/eptJXR/JjBg2NinnRoe4Ti84knAui7VyyfKk4nkgyqjT1ggJ27yTVCanr7qMzddlMPcU3IvekFcXrc2PM+X69RuHl0yBMqwABINzYH/tObVr3WzvWwtgNFVE8iZqaN8k1fgdd77fEw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 198.47.21.194) smtp.rcpttodomain=vger.kernel.org smtp.mailfrom=ti.com; dmarc=pass (p=quarantine sp=none pct=100) action=none header.from=ti.com; dkim=none (message not signed); arc=none (0) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ti.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=ILDOmEwf1i0BmaeYTLLHUOIT4vwwkilIwjVe7qP2kJY=; b=G9QZbU83xV2C8c/6v49GxemFSf8GnrIBc457lTjRtW894b8cmiYTn9TNxKFkoFOoUHJEi06/sxPSZeUekZHxW4ez5FyYijLzyx0u/K2jPJNnaAA8gbL5LpgyWtD825Jjl7f/yAtTOhISzys+BCi3TooUBcfF0PIWhTh3/v2y75Y= Received: from CH2PR12CA0008.namprd12.prod.outlook.com (2603:10b6:610:57::18) by SN7PR10MB6449.namprd10.prod.outlook.com (2603:10b6:806:2a0::15) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.21.428.8; Tue, 15 Sep 2026 09:56:30 +0000 Received: from CH2PEPF0000013D.namprd02.prod.outlook.com (2603:10b6:610:57:cafe::61) by CH2PR12CA0008.outlook.office365.com (2603:10b6:610:57::18) with Microsoft SMTP Server (version=TLS1_3, cipher=TLS_AES_256_GCM_SHA384) id 15.21.406.12 via Frontend Transport; Tue, 15 Sep 2026 09:56:30 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 198.47.21.194) smtp.mailfrom=ti.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=ti.com; Received-SPF: Pass (protection.outlook.com: domain of ti.com designates 198.47.21.194 as permitted sender) receiver=protection.outlook.com; client-ip=198.47.21.194; helo=flwvzet200.ext.ti.com; pr=C Received: from flwvzet200.ext.ti.com (198.47.21.194) by CH2PEPF0000013D.mail.protection.outlook.com (10.167.244.69) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.21.428.7 via Frontend Transport; Tue, 15 Sep 2026 09:56:28 +0000 Received: from DFLE210.ent.ti.com (10.64.6.68) by flwvzet200.ext.ti.com (10.248.192.31) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.2562.45; Tue, 15 Sep 2026 04:55:58 -0500 Received: from DFLE202.ent.ti.com (10.64.6.60) by DFLE210.ent.ti.com (10.64.6.68) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.2562.45; Tue, 15 Sep 2026 04:55:58 -0500 Received: from lelvem-mr06.itg.ti.com (10.180.75.8) by DFLE202.ent.ti.com (10.64.6.60) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.2562.45 via Frontend Transport; Tue, 15 Sep 2026 04:55:58 -0500 Received: from uda0497581-ant.dhcp.ti.com (uda0497581-ant.dhcp.ti.com [10.24.51.159]) by lelvem-mr06.itg.ti.com (8.18.1/8.18.1) with ESMTP id 68F9tB833000901; Tue, 15 Sep 2026 04:55:55 -0500 From: Manorit Chawdhry Date: Tue, 15 Sep 2026 15:25:19 +0530 Subject: [PATCH 13/30] crypto: sa2ul - fix struct documentation for match_data Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-ID: <20260915-b4-upstream-sa2ul-cleanup-v1-13-57ab34e97162@ti.com> References: <20260915-b4-upstream-sa2ul-cleanup-v1-0-57ab34e97162@ti.com> In-Reply-To: <20260915-b4-upstream-sa2ul-cleanup-v1-0-57ab34e97162@ti.com> To: Herbert Xu , "David S. Miller" , Keerthy , Colin Ian King CC: Andrew Davis , Pratham T , "Kamlesh Gurudasani" , Udit Kumar , , , "Manorit Chawdhry" X-Mailer: b4 0.15.2 X-Developer-Signature: v=1; a=ed25519-sha256; t=1789466112; l=778; i=m-chawdhry@ti.com; s=20231127; h=from:subject:message-id; bh=ZgQNzFQwy5Bm25q7i4u6MuBiNs5zBjwT+dWYrGEw6UE=; b=JXGmy3xc3BatJPU3EseJFpZ4deaQOIPxpkHFWssMDzKt7sx8CKftY4V/6PQPc24La6QKntcbb mVuIlTOuLEjAC30Rr+59btHUFooU+8L89tpfuifNQ/MAyulu5c1XBR2 X-Developer-Key: i=m-chawdhry@ti.com; a=ed25519; pk=fsr6Tm39TvsTgfyfFQLk+nnqIz2sBA1PthfqqfiiYSs= X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: CH2PEPF0000013D:EE_|SN7PR10MB6449:EE_ X-MS-Office365-Filtering-Correlation-Id: 28fc820d-8616-407d-dcea-08df130f9ce4 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|376014|23010399003|36860700016|1800799024|82310400026|10067099003|56012099006|18002099003|22082099003; X-Microsoft-Antispam-Message-Info: /xOLXF5PVLQ6wwCgokfMSUrNxLSa3faBNpWu7oUaXf6cuf0R3SvuLTMK0zK6iLoczOChE0BnNERO+kzQodAikwVkpYvWifdDylMk6jmRRt/j0ajhXA9H0wXivkkMCTP5STYo/MlzYmdZcEWhiEkL/cHY3oJSoTQcqUHq7v4Q0eQk8Ujz/00Yf/7Y1e+xZb6/cNRIolfX1opSktwjylrygQ0tXKHP+ALx+UbVXFjH86ydO6jYoGs/FKWgBRx17FZRR3Toi9aWcwxrenhDc68h4Z8Cbj6nMB2jhjjt/wkDKaRoJEUXJhNeCpNTqoXJc9TsbczIKedi4gXYZGHgGWWTAV5Xv16VNKwpsl/LMCRyo6VekOyhEN1PqDDomFLgU+sPvAvBl2HT9//Na+EPeJ5/XxSTvTl9CbF2UHwsJpJwmWBIXBby+5oixOatAYeQQR2H5rYcgGQtMQxLRZzK4wUgIdQmtommwciO/bOL+fo9DJGTuDDnPTjtOKpB8LVTf5g5UgKRunStwXKq55dJSvmGT3tUBehpmPtCiIa/Csp33T8kBA6ZHoNQfDfs+F3DugwvoWLiMAz8mBPotFr9quSCu1WdZLkb2PDscBNZY4G5WCosFIP2l77AyMtwE2qgzIcWrVMvJqJLkkZn8lU/OfpAffTCf6X1CPIi6fvjM1xDgH6+qwzmd12NMj6MRo7oUM/nUOomcVi8dCg0JiByInA8hA== X-Forefront-Antispam-Report: CIP:198.47.21.194;CTRY:US;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:flwvzet200.ext.ti.com;PTR:ErrorRetry;CAT:NONE;SFS:(13230040)(376014)(23010399003)(36860700016)(1800799024)(82310400026)(10067099003)(56012099006)(18002099003)(22082099003);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: 59LL6thcvPhxUqCcSpHwT40+yaFlQ1ZeJwA4Zucktta7lpdRswsb86OUBlmqpiqrOvxgu+9ROZTwKi9hpLTc/4MiNsrFaBNmfKwjn/HufUjxo5U+E0+YJw7NvbM0mDuDfMiuEb7boic7gOB2oRyEKDf9opNpMT4wsXgdIop5FQxUiMY74435My2p+8FdM+ntG3enU8VQx2SOTm0sn9jC5iA4Hn6416JV59vcFZSuFwHacDFhxe4z+oibUM8EwC/n55IzEYr7w/vPwXDefMq2Ff38BzRIExPj5sfyZn8MOYO31uI745PLolB2KC6TjW4TNwK6/8FFCp6wLW+/iRRaNTIlOol0WcFPxrFVq7SCjKYN3Y/cglDuOXGsbJ6LEZoRNfc0bX3ESDPLJU+5DEvbEHAAxc38d7T7OCrJM/udKqHbDjBG6RvQk+vvsUXypEIt X-Exchange-RoutingPolicyChecked: UBn2W5w+RkFRAw/Pe2ZW/PNPO53+5Dx+tu3lj2KNVVATJec3lNbIyAqgLQROnXBr5BiyFYAoERLUUedznET/yR1Y91jERvigWoPisG4TmWsCtXAmLdWQG8/wRNCjMj9Tc+eO3iGBEaNgR8wnglph6c3faTyvO4GgrXBuBMOHfqTLtpJA+SYxD7G9URrvkArxXvrFDcbHth2OCjunP6/M8jECBsvEI8PHLWE6a98mP5c5T1Pgk4cMvd3KGNTlRjpIC4srPGVfINB9Re9mq+PNvMv80tFI3ZRYZcNc6oWF4qigaZ8F7h+XC/53/qbkoBqzlhn2T4IOl5YjVZkXRUxd5g== X-OriginatorOrg: ti.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 15 Sep 2026 09:56:28.6701 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 28fc820d-8616-407d-dcea-08df130f9ce4 X-MS-Exchange-CrossTenant-Id: e5b49634-450b-4709-8abb-1e2b19b982b7 X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=e5b49634-450b-4709-8abb-1e2b19b982b7;Ip=[198.47.21.194];Helo=[flwvzet200.ext.ti.com] X-MS-Exchange-CrossTenant-AuthSource: CH2PEPF0000013D.namprd02.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: SN7PR10MB6449 X-Authority-Analysis: v=2.4 cv=P9yvFSAu c=1 sm=1 tr=0 ts=6aa91650 cx=c_pps a=Vk4XJBOTeTkE7YKYzYQsKA==:117 a=iwqwCZQqcuTv3JOpYdM7/Q==:17 a=6eWqkTHjU83fiwn7nKZWdM+Sl24=:19 a=IkcTkHD0fZMA:10 a=VdqzKS8jKosA:10 a=V5UXEbMT0ywA:10 a=VkNPw1HP01LnGYTKEx00:22 a=Z8NIEmU8O1QQgoT56wFK:22 a=jwouBfj2j3NM8CExmVVE:22 a=sozttTNsAAAA:8 a=SBzYsTgxBfknYJ6lt_UA:9 a=QEXdDO2ut3YA:10 a=ZXulRonScM0A:10 X-Proofpoint-GUID: 0ib1Fv18guMZ2RZQ7V9bGL-gjX5-oyOS X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwOTE1MDE0MyBTYWx0ZWRfX25IsLbUwM6zv zIOTRDUO2spgqNCuNNhwvQHaIc9+On8DAQniu4CUH689cYSyQihs7Kf0+BER9JcbGJKomfhYve0 v/Eww7h2sq4dpfNSUZUB+kZuhrfIIbm6luPHVgdll9ZZloh9KA7YbgAARpG8bWXMKMpSEaXE1ms W670Zip4DXCtFx0z4QHxirr/tO6MfU2PrYfG5+DEV15RXI/+556QpPWIRU2ORzIFqUUikBmN385 QL6raB2mcxVa0MJ2HK17RSIdB0XA1cUrwh9zgikXMKffiYWrqjsVu5FihEzJXVMRHVtgij6Lv6E aDKbu7Ai+hj9IL1uDJViHbk9R77RGHdh29vKRfPDmXMn9Iou72JXo5Iy1cKN0UsDLxJJWJmJjBJ n2miHoy/CrWChVh9s4qUqUKeR9Gmgwc6r94/TrTzIcbiRwHEZpKWjk9UsfXxvEsA7H+wFBEAMRk zuknVLqVFv/0kq1XaAQ== X-Proofpoint-ORIG-GUID: 0ib1Fv18guMZ2RZQ7V9bGL-gjX5-oyOS X-Proofpoint-Spam-Info: AW1haW4tMjYwOTE1MDE0MyBTYWx0ZWRfX6585Om0XtJZg heK+hgGKeOxROEcieSyZS0zxRpG5sRShsA1Q3R+By5VdYAfTl34pGhz1JsY40YeKRvmmT1kli+R yTgHPkQYtJW3C6QILYWppT+4ji+v2Y8= X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1176,Hydra:6.1.134,FMLib:17.12.100.49 definitions=2026-09-15_03,2026-09-14_02,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 phishscore=0 adultscore=0 bulkscore=0 suspectscore=0 priorityscore=1501 spamscore=0 impostorscore=0 lowpriorityscore=0 malwarescore=0 clxscore=1015 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2609040000 definitions=main-2609150143 Update structure name in documentation comment from sa_of_data to sa_match_data to match the actual structure definition. Assisted-by: Sisyphus:claude-sonnet-4-6 Signed-off-by: Manorit Chawdhry --- drivers/crypto/sa2ul.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/crypto/sa2ul.h b/drivers/crypto/sa2ul.h index 7c0ca2ca966e..04669bf7fcb5 100644 --- a/drivers/crypto/sa2ul.h +++ b/drivers/crypto/sa2ul.h @@ -162,7 +162,7 @@ struct sa_match_data; =20 /** * struct sa_crypto_data - Crypto driver instance data - * @soc_data: Pointer to SoC specific data + * @match_data: Pointer to match data * @pdev: Platform device pointer * @sc_pool: security context pool * @dev: Device pointer --=20 2.43.0 From nobody Fri Sep 25 12:05:54 2026 Received: from mx0a-0002e601.pphosted.com (mx0a-0002e601.pphosted.com [148.163.150.75]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 853CF49B1E6; Tue, 15 Sep 2026 09:56:49 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=fail smtp.client-ip=148.163.150.75 ARC-Seal: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1789466211; cv=fail; b=PEcHkqoHgjVgTmNkUoB95+lghcjv7ErM/jL5r7oSkQZeYjoYzwhiRpnSgDGDXvTySmSAMQKryh9UcW4J6IhxDQE/C7Zynvr0Bls8rpfnK893r5r4mVzpz1r8q7D0wilSAPmZFhCMXW5b10E6SLIa9HwS+Yp45Hl2BtrYDLryBz0= ARC-Message-Signature: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1789466211; c=relaxed/simple; bh=YT2fgHyhAYvApSca0aCLhNDXmLOXy6lMivaejSvuoLQ=; h=From:Date:Subject:MIME-Version:Content-Type:Message-ID:References: In-Reply-To:To:CC; b=ndKdxj4On5WlfrhcyZNkDex1KUPd6o7ze27b+kfm3eSpvRUXYYDCqBh/o+qmG2Oo5Rbwpaa5EME0qvzd2p8XuS2RZELN2SUBPtyc1zB92SoMP1YKvU4E/1WIKLh0Eo7zfXWaBhchps/IGmwb6lTYtSwBze7KX6itoDQ98hbB+ck= ARC-Authentication-Results: i=2; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=ti.com; spf=pass smtp.mailfrom=ti.com; dkim=pass (2048-bit key) header.d=ti.com header.i=@ti.com header.b=p5vsSAQn; dkim=pass (1024-bit key) header.d=ti.com header.i=@ti.com header.b=Y+xGR+u4; arc=fail smtp.client-ip=148.163.150.75 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=ti.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=ti.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=ti.com header.i=@ti.com header.b="p5vsSAQn"; dkim=pass (1024-bit key) header.d=ti.com header.i=@ti.com header.b="Y+xGR+u4" Received: from pps.filterd (m0384305.ppops.net [127.0.0.1]) by m0384305.ppops.net (8.18.1.11/8.18.1.11) with ESMTP id 68F9eiAD1480537; Tue, 15 Sep 2026 04:56:46 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ti.com; h=cc :content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s= proofpoint-05-2026; bh=49rv22ZPc0LzP/W53xcpAe9Gayw3cNJ/ZcZ807dGk 6g=; b=p5vsSAQnve2vCZpnKgaiDzAUxn/qeF3nqN6SvM3u7pz0q3CryYd4NzX/n zD+joEpp6RDhAVYS/i1/LlYs3xd+uhiFYU724N0jdF3GbY4KE13MRpe+dWp0By/O M1QF+qUnOP7qCloj7ZDBi2xhZzGp4W/ej51/R9T0rONDB9+MNYCwZKuyeiY/cgl7 tbZ6pL9CTlDTOUrAY3cZLhLYkaZkVuGC2vQWbn8+ooOvT2Chqje2pdAw4k9jWNgO Jr3OPDKkBhfYefgjedvi3vSGlQG9ZOvuYbdNl0VjoKzAjgV4/fay8hhhXZsASMFq V8VpPTYni5lAQ1hFQlr8kmN9PNHrw== Received: from cy3pr05cu001.outbound.protection.outlook.com (mail-westcentralusazon11013030.outbound.protection.outlook.com [40.93.201.30]) by m0384305.ppops.net (PPS) with ESMTPS id 4gpvpa2j2r-1 (version=TLSv1.3 cipher=TLS_AES_256_GCM_SHA384 bits=256 verify=NOT); Tue, 15 Sep 2026 04:56:46 -0500 (CDT) ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=HT3G0vQIh2usyIFtt8/ioR8nyG4lZvPkSqrPdClGcO0gLWjv4Fexm2Esl0Im+8zv6ILPhntlg87hBJIt40N1Ka9EuUQezDDqL4a7AdTSXrrJItMsMgFIIDEMgX/WhI12vwLXn03a4wS4Ukk0oKqclCDiB9JOaX81oxyiasQwRu9mcvRnswwfCM77/QgcoccISE1FRTk1cODhoc69zYRgxg2c+RpzqE8SjbssdjxBOk/npV7j9tmUdoEcEkWRgUOxs51wmRaK/mD6jiSSSriJfa7Dctv0ZuPOfnLblKVbhk0VE97DIhIjwVRVIAwEFXu9Up0zmrpIhTE5WrC+smH2Eg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=49rv22ZPc0LzP/W53xcpAe9Gayw3cNJ/ZcZ807dGk6g=; b=ogYEYtHaC9JdeUlHCpc4AcF0tCDEq0OPCqf9UILYYt9xsHwUI5NoxEjiEj1fU6sqf/yVTvIqevcUlMf58zQFLofVn8FzeY2USf+CG3vafwboHJ4d+BpE7IZE8jD2JsTUIHDfdjLgiOS+woUdDtPLilyZbkurteSUIJJncbnrmiSDBofZBWQP0HJb2emGvwteEwJYbeQ1lxph4ICrc+g4R4nDHGjsRZKQ1SWfhFGpLpUArY6ksB1xViSXI8s5yHNqJ+6zCdTU49VHXISsgLwjDyvZ8k+BoFH2GAuzeMe+p/pPC/rJE0hnSclAzFHjybzkW4+02Cz6MSOCwgtEey4UGA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 198.47.21.195) smtp.rcpttodomain=vger.kernel.org smtp.mailfrom=ti.com; dmarc=pass (p=quarantine sp=none pct=100) action=none header.from=ti.com; dkim=none (message not signed); arc=none (0) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ti.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=49rv22ZPc0LzP/W53xcpAe9Gayw3cNJ/ZcZ807dGk6g=; b=Y+xGR+u40aoHHoYhEGXRo5jE/8gbeI5ImJZIViS+h9oPvWkQlCDIZQN7K6oow9KFsQBWLrJfFXEc6yBdz16p+Mrg8tRoCY8Ggr3awkDiqIkq3jQeox0FoTUmjRZkknT07MpxcZiKG3wR/ZjOEFGpmHM3LPSN8xF30IjJnUMUy6Y= Received: from SJ2P221CA0012.NAMP221.PROD.OUTLOOK.COM (2603:10b6:a03:5db::16) by DS4PPF80E5E852F.namprd10.prod.outlook.com (2603:10b6:f:fc00::d2e) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.21.428.9; Tue, 15 Sep 2026 09:56:43 +0000 Received: from MWH0EPF000C6186.namprd02.prod.outlook.com (2603:10b6:a03:5db:cafe::34) by SJ2P221CA0012.outlook.office365.com (2603:10b6:a03:5db::16) with Microsoft SMTP Server (version=TLS1_3, cipher=TLS_AES_256_GCM_SHA384) id 15.21.406.12 via Frontend Transport; Tue, 15 Sep 2026 09:56:42 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 198.47.21.195) smtp.mailfrom=ti.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=ti.com; Received-SPF: Pass (protection.outlook.com: domain of ti.com designates 198.47.21.195 as permitted sender) receiver=protection.outlook.com; client-ip=198.47.21.195; helo=flwvzet201.ext.ti.com; pr=C Received: from flwvzet201.ext.ti.com (198.47.21.195) by MWH0EPF000C6186.mail.protection.outlook.com (10.167.249.118) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.21.428.7 via Frontend Transport; Tue, 15 Sep 2026 09:56:41 +0000 Received: from DFLE210.ent.ti.com (10.64.6.68) by flwvzet201.ext.ti.com (10.248.192.32) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.2562.45; Tue, 15 Sep 2026 04:56:01 -0500 Received: from DFLE200.ent.ti.com (10.64.6.58) by DFLE210.ent.ti.com (10.64.6.68) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.2562.45; Tue, 15 Sep 2026 04:56:01 -0500 Received: from lelvem-mr06.itg.ti.com (10.180.75.8) by DFLE200.ent.ti.com (10.64.6.58) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.2562.45 via Frontend Transport; Tue, 15 Sep 2026 04:56:01 -0500 Received: from uda0497581-ant.dhcp.ti.com (uda0497581-ant.dhcp.ti.com [10.24.51.159]) by lelvem-mr06.itg.ti.com (8.18.1/8.18.1) with ESMTP id 68F9tB843000901; Tue, 15 Sep 2026 04:55:58 -0500 From: Manorit Chawdhry Date: Tue, 15 Sep 2026 15:25:20 +0530 Subject: [PATCH 14/30] crypto: sa2ul - zero out security context on free Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-ID: <20260915-b4-upstream-sa2ul-cleanup-v1-14-57ab34e97162@ti.com> References: <20260915-b4-upstream-sa2ul-cleanup-v1-0-57ab34e97162@ti.com> In-Reply-To: <20260915-b4-upstream-sa2ul-cleanup-v1-0-57ab34e97162@ti.com> To: Herbert Xu , "David S. Miller" , Keerthy , Colin Ian King CC: Andrew Davis , Pratham T , "Kamlesh Gurudasani" , Udit Kumar , , , "Manorit Chawdhry" X-Mailer: b4 0.15.2 X-Developer-Signature: v=1; a=ed25519-sha256; t=1789466112; l=731; i=m-chawdhry@ti.com; s=20231127; h=from:subject:message-id; bh=YT2fgHyhAYvApSca0aCLhNDXmLOXy6lMivaejSvuoLQ=; b=U5AL0656GHv92pQOCBFLgZ5Iq4BStdZVkn5iz5XLHtShCEnkfcGWIL9BiFJ0PYdcAqxaZdUbC t6aXsWfjZAbC+29qaHsFwy0XYMdBUgnznbZANq4NqGMQrSSgJLS0Hk4 X-Developer-Key: i=m-chawdhry@ti.com; a=ed25519; pk=fsr6Tm39TvsTgfyfFQLk+nnqIz2sBA1PthfqqfiiYSs= X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: MWH0EPF000C6186:EE_|DS4PPF80E5E852F:EE_ X-MS-Office365-Filtering-Correlation-Id: 8ebcce93-f4ac-4086-a6c7-08df130fa476 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|82310400026|376014|1800799024|36860700016|23010399003|22082099003|18002099003|10067099003|56012099006; X-Microsoft-Antispam-Message-Info: OrW10sr+jRthpIrsxX+0QXrTO58cLgdGOj+nBhCUUeFtcYqw2mscomgesRfdr4OBmlvWbXS7oC63UxF06izl9k3d2ShVqKDvwKyZ8aHA7R0cSye8n46Oa8+kNp+wsHOzomo4gtQ4mg6b/B6wzYPyOZesQaA0LlX6WO6/ixpjcfZHcAQ8eevs6MDh7YjN76hOhBFUdV6ouKTNQ1YyhdPd9EvMeahsxSO8qFHARDsw8O2FaaeVAwLzcholY4MqfFpwNM2ikVh3ui9rBbfnMikvh/Zl6N709Dd5wjeS9TnmelD4vzqbLz3Oa0s/blR7D/955geNLpiHwSgb6DNjW8gDSxGt3xjazOQaPkXhhuPIMe61lqA5vC2Wt6P18i6lf/9X0N9I59v6gMfAvjFxw1yhuUhfsFGt9MlQwBKHvXq8Rf/BDuyAEeNxXOh7CfH5UVrlLcezlz02L7iT6Bs9ekO8cnbbdugYdYut9PZhHvGdL8244JbMu2jUwTdzNnPQS3OpS6xPwgNJOQlnTQNABEAvSm27rigFsgIBL0D5IE+ExKjcpyS5Z5Pa85OVFkOPbaQ2cRpJs9qp3DChKfZvB2MNc4owmqXyLA7suL0JQyWLhtegqk+VrOB0ILxdws7w8+xuIEjeBfKsYKwpsHeoJyTl3qy6ayL2eMn3nrAStgZpduwWGmB3DjksNkVDfG92iW9eb8liOOQMNy3YlQrquBbd3g== X-Forefront-Antispam-Report: CIP:198.47.21.195;CTRY:US;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:flwvzet201.ext.ti.com;PTR:ErrorRetry;CAT:NONE;SFS:(13230040)(82310400026)(376014)(1800799024)(36860700016)(23010399003)(22082099003)(18002099003)(10067099003)(56012099006);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: GY6UVv8175K6j3Pp9sYI39YJPxic1S5wCsONWbbP8RV8Ih57jTMooDQlZ/R8gCky3NSpPPMkgcvG4GyXJOJMeQA+9YzE/UmOr4ktP99fW19pGCg/bAkCeO0dRxlB+ad872czbQ9yAE5RblI4GqUhjc+k+X7ggm2swCX9mSUyqftxrDBIykmuoU0b/PYyjJF/ZzS2b6EEPJi0/gVeY9e3tvdAKRaEwWWnwYgJXo70oZUlbefgtT+HgnTTw+dRYCvxSgqs+B5aAcSGxuWseWhccaQztzv1ldJdCJevrY5uDzpVdBfGRoZD9zOQwFqfqyMHXwNfB/y3/fSEe8ovDy9qFOnY4jKxQenPg22dSBYPFkLf15Wxa+MnL5aCDdNtqVUxSCdKRwvpi1PUObMStF9zqM6WFkcUUkKgWNAYpaWpukhzr6jlKHcTYgxAYMD80T13 X-Exchange-RoutingPolicyChecked: eJN3fksgK9Js5Zb9muTizl+6q6qV6l9a3CokwdtOx4iE0jjENBmHed5VR1m4nUFRO3e2yJ+76AeR8fuQMaVb0ICMGC1jG/PG0oOcdNiinhnqvEdZLtDa7SIzKm/lbEsm/2Hq/m06bI5aH5weEszYDcRNN7VjnDlnRGcJvFX+41yspXVW37Npt39VjbWSG1Pm8UrcUTXQ3omo972ItqUxGnhNj3TECRH8uVIDsPmW80QHhSl3//Jyft2PWeuzPMoypF74nuUskxTZzfk3cD7W32+LVYbrNljCLvzh8Z+FYjw8qVeUju6KRCh9rf6WccQV95O9Dmg+RUdQDz3NN6RtYg== X-OriginatorOrg: ti.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 15 Sep 2026 09:56:41.3314 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 8ebcce93-f4ac-4086-a6c7-08df130fa476 X-MS-Exchange-CrossTenant-Id: e5b49634-450b-4709-8abb-1e2b19b982b7 X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=e5b49634-450b-4709-8abb-1e2b19b982b7;Ip=[198.47.21.195];Helo=[flwvzet201.ext.ti.com] X-MS-Exchange-CrossTenant-AuthSource: MWH0EPF000C6186.namprd02.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: DS4PPF80E5E852F X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwOTE1MDE0MyBTYWx0ZWRfX1jDeyVhBocy/ /s0zVJpVP6ZcPO/21JJPj77WNCRVhPrVDLnhrt0ncVbHre/zoguR4yhkry6BGWNBv+b8Og2Nzjn I+iZp7nyAdsruInGeYj+GHy3Q/zM7DCXCIHvRe0hwcWgxfQ5Cu3uD14/D3J/QWDrCh3S9fssv2+ EEEH+Q06zRh50emlP0i0F995NxPeXxEJyOKB32j6L7rhqSO3E0mlHFEFVNpbtGGAVM/g4i+pSyh cfn1Axdw7JPpRNREI4yhPFgZrtUAXRiDTu/KrrHg/1DE9Nz6hbNL9chLq71EZ5BViZ6rtGByP3J ZjGUtZRPuHaqSrV1MDcJC79KfRFCtssxOjWk8eGs+WopVBtr+wiBuKvs5ijsUG3ACYmcIqHW7Lo CfNdUkqqqiRol4IeGt53uuBSv56eAaLthHfqkCRK4XwM5gVC4pVU2r0SlMSCfiq5m/sD9YcvuNM 5J2PXjQMJiFimKCwYiw== X-Proofpoint-ORIG-GUID: xTCPvN1qX7iomdpspYYR6HC2LWbQMWMs X-Authority-Analysis: v=2.4 cv=U7cHnuru c=1 sm=1 tr=0 ts=6aa9165e cx=c_pps a=9fOKxQ6q+1oHddUNM5AUXA==:117 a=tJyPKKxUohctrY4NYmUjkA==:17 a=6eWqkTHjU83fiwn7nKZWdM+Sl24=:19 a=IkcTkHD0fZMA:10 a=VdqzKS8jKosA:10 a=V5UXEbMT0ywA:10 a=VkNPw1HP01LnGYTKEx00:22 a=Z8NIEmU8O1QQgoT56wFK:22 a=taLDd7a_hP9WKsMzeGRc:22 a=sozttTNsAAAA:8 a=QMk6ud2451SdQzNupOYA:9 a=QEXdDO2ut3YA:10 a=ZXulRonScM0A:10 X-Proofpoint-GUID: xTCPvN1qX7iomdpspYYR6HC2LWbQMWMs X-Proofpoint-Spam-Info: AW1haW4tMjYwOTE1MDE0MyBTYWx0ZWRfX6u2GzSMuOTIF li3F/zgruDmjdgesIQ2ErQ8UgV501DEN9LdhsQayDhzZqNw7PyuUCZccs2K0Pd3maYe6cM6Dmae cj9/dnP4pD0AGcrGZNRfzE5OqIPy0uQ= X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1176,Hydra:6.1.134,FMLib:17.12.100.49 definitions=2026-09-15_03,2026-09-14_02,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 priorityscore=1501 phishscore=0 lowpriorityscore=0 suspectscore=0 impostorscore=0 malwarescore=0 bulkscore=0 clxscore=1015 spamscore=0 adultscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2609040000 definitions=main-2609150143 Zero out the security context memory before freeing to prevent potential information leakage of cryptographic keys and state. Assisted-by: Sisyphus:claude-sonnet-4-6 Signed-off-by: Manorit Chawdhry --- drivers/crypto/sa2ul.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/crypto/sa2ul.c b/drivers/crypto/sa2ul.c index 673cd1458948..7ec048136114 100644 --- a/drivers/crypto/sa2ul.c +++ b/drivers/crypto/sa2ul.c @@ -758,6 +758,7 @@ static void sa_free_ctx_info(struct sa_ctx_info *ctx, spin_unlock(&data->scid_lock); =20 if (ctx->sc) { + memzero_explicit(ctx->sc, SA_CTX_MAX_SZ); dma_pool_free(data->sc_pool, ctx->sc, ctx->sc_phys); ctx->sc =3D NULL; } --=20 2.43.0 From nobody Fri Sep 25 12:05:54 2026 Received: from mx0b-0002e601.pphosted.com (mx0b-0002e601.pphosted.com [148.163.154.28]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id A75C7483BC8; Tue, 15 Sep 2026 09:56:29 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=fail smtp.client-ip=148.163.154.28 ARC-Seal: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1789466191; cv=fail; b=uOR5HIlb/ImuvrXrxAwxtb4u4dajuczSOgituUmaA6Ol8Z4PcmaNAPFMq/KP+N3nU4xQcuST34MS8INVQVF037wpgfK9OaNEmcNaM4UOxFvLPmYn/lIkaIgF9GkIlh3I0qEvbqLGhnCcEVWKJwmGEaVLhPiBD6gFn4r+9kWEqdo= ARC-Message-Signature: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1789466191; c=relaxed/simple; bh=U0FOGrMlGFAZT4TKiZLTMpmME/UnVJHZYZaCVn/3oyo=; h=From:Date:Subject:MIME-Version:Content-Type:Message-ID:References: In-Reply-To:To:CC; b=ZsROC1v3UmwziJB1S+2AkvyucavawsQBNMwT/twAAc2WFte7xomOTQEJKMrDnVn3eAtHA495O0Wam7RK75ICmJg2iVuXvYtETROtQv7cUmGD+HF+Ty9J33wM66AE8z9g1tdYTn9TDimsg819B05zNF7QF/hXLPCHypsSS9iEDrM= ARC-Authentication-Results: i=2; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=ti.com; spf=pass smtp.mailfrom=ti.com; dkim=pass (2048-bit key) header.d=ti.com header.i=@ti.com header.b=cU5gooiv; dkim=pass (1024-bit key) header.d=ti.com header.i=@ti.com header.b=OF0wyuyv; arc=fail smtp.client-ip=148.163.154.28 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=ti.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=ti.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=ti.com header.i=@ti.com header.b="cU5gooiv"; dkim=pass (1024-bit key) header.d=ti.com header.i=@ti.com header.b="OF0wyuyv" Received: from pps.filterd (m0374955.ppops.net [127.0.0.1]) by mx0b-0002e601.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 68F9fQTX4098406; Tue, 15 Sep 2026 04:56:24 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ti.com; h=cc :content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s= proofpoint-05-2026; bh=8m2H1rJlypLZ8RTLhY4pDM7SPUOIp+qt43ev4/tz0 kE=; b=cU5gooivf+kUicB87oBFccZ20zM4B2KBFqmh9lDxFxwCRpzOTnc7shG1D qU+STH9Fd0LuFm++smihOwsz6314mGF2t8X19A/SW7gy+0UvETRrFrUY1Z49NmgY 2RsHR12OJQYCXs1mo45wb65tTNRkAT1pN6cn/QxZDklHX/cATbrYcNihHjQP7Giq WaXAYgMrUfyy9z/BOc0qv3Tjrep6jAHH3Xi54rrU4KA0IceFRWK1vrYjR/M+SLwI KRrW77Hb8UtAiWemh0vj5Ex55uBeb/LyHBDYZVcfMrCeRWUyRrv81WdNlLMSzgEF C3wCI0I54mcZfHp7CsguGTLY2ZaCw== Received: from mw6pr02cu001.outbound.protection.outlook.com (mail-westus2azon11012063.outbound.protection.outlook.com [52.101.48.63]) by mx0b-0002e601.pphosted.com (PPS) with ESMTPS id 4gpvpjakgy-1 (version=TLSv1.3 cipher=TLS_AES_256_GCM_SHA384 bits=256 verify=NOT); Tue, 15 Sep 2026 04:56:24 -0500 (CDT) ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=PnkNHnyiehx16hfijnB4jphcMNnhoddGKmV8C4qGeSMULNZiaklg1+0T5GO+2UTd/LmOSmNuC2sS7CjUhgLtSjkDk/UG5FRYSjnawPtfP/GiAx+3m3hNeHgs9MfLx+8+hRuUPprP4NNU7qix/OZ/AOoq1NNxD+0D6lncC0zyNpaYYoGRB7qj5dadLgBPqXyPFOLt7ME4UqDy9iMfVY5HMRBFka4psmroNoFerTn4PnpFl0V0cNMcevdixjYFgOUKb5A0uDB+6jpsSoieeeho954JST9OYuPCBxa3+k8MUDVj5PjAhpeTZqU0rs0EQcbAXvWUkqA1kKF6HdjRXlogpA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=8m2H1rJlypLZ8RTLhY4pDM7SPUOIp+qt43ev4/tz0kE=; b=I4wmDDV6K3QlZDTvvOnBMeWyUYJE+OkKrzm8xLU/ufkZEYs/cVVKVGISpQepw2CRXGtgnogFqYnO5UPSCUnmu8vwtJNhZfzNRNrmKO22iyq09WG+2IuYspoqkucq7xs2f/5aGFF9+OT/Yp3K8sZcm1qCdh/MSjolxbCpqgqF5wqSJVIn8fTHiqGf/BZM64xVFA5PHOyI9MFcB/2tR/U0zMLeHzT9/pMFOQ/SoNWhMMpJb958DTfXf6/LgLwpBY5bgp3IjE5deWe+R5Z7V0vGIwF6UgoY2S5G+vP2X4yAxNzsD2TSDH5KgoUkhxHzPLANCMZRjyXCxzQuudDNs3VsPA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 198.47.23.194) smtp.rcpttodomain=vger.kernel.org smtp.mailfrom=ti.com; dmarc=pass (p=quarantine sp=none pct=100) action=none header.from=ti.com; dkim=none (message not signed); arc=none (0) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ti.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=8m2H1rJlypLZ8RTLhY4pDM7SPUOIp+qt43ev4/tz0kE=; b=OF0wyuyvpuRJzQDOG6/1m1RJD0/DKEQCJK0ygoiDr1RUKvQDdlDmfCm+NKw3cDzWEfHAKyclgVS9OS77hqutpVtELLIZIm0rSdJDqwfK3EjhKg+JS1tN1upn2SbBzZqO0u6Hj8OcEWh4zRisWxsdL2cRiSM4EtuzSOYjagTOevM= Received: from CH5PR04CA0002.namprd04.prod.outlook.com (2603:10b6:610:1f4::20) by DS7PR10MB5973.namprd10.prod.outlook.com (2603:10b6:8:9f::12) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.21.428.7; Tue, 15 Sep 2026 09:56:20 +0000 Received: from BN2PEPF0000449F.namprd02.prod.outlook.com (2603:10b6:610:1f4:cafe::9c) by CH5PR04CA0002.outlook.office365.com (2603:10b6:610:1f4::20) with Microsoft SMTP Server (version=TLS1_3, cipher=TLS_AES_256_GCM_SHA384) id 15.21.428.9 via Frontend Transport; Tue, 15 Sep 2026 09:56:20 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 198.47.23.194) smtp.mailfrom=ti.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=ti.com; Received-SPF: Pass (protection.outlook.com: domain of ti.com designates 198.47.23.194 as permitted sender) receiver=protection.outlook.com; client-ip=198.47.23.194; helo=lewvzet200.ext.ti.com; pr=C Received: from lewvzet200.ext.ti.com (198.47.23.194) by BN2PEPF0000449F.mail.protection.outlook.com (10.167.243.150) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.21.428.7 via Frontend Transport; Tue, 15 Sep 2026 09:56:20 +0000 Received: from DLEE207.ent.ti.com (157.170.170.95) by lewvzet200.ext.ti.com (10.4.14.103) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.2562.45; Tue, 15 Sep 2026 04:56:04 -0500 Received: from DLEE209.ent.ti.com (157.170.170.98) by DLEE207.ent.ti.com (157.170.170.95) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.2562.45; Tue, 15 Sep 2026 04:56:04 -0500 Received: from lelvem-mr06.itg.ti.com (10.180.75.8) by DLEE209.ent.ti.com (157.170.170.98) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.2562.45 via Frontend Transport; Tue, 15 Sep 2026 04:56:04 -0500 Received: from uda0497581-ant.dhcp.ti.com (uda0497581-ant.dhcp.ti.com [10.24.51.159]) by lelvem-mr06.itg.ti.com (8.18.1/8.18.1) with ESMTP id 68F9tB853000901; Tue, 15 Sep 2026 04:56:01 -0500 From: Manorit Chawdhry Date: Tue, 15 Sep 2026 15:25:21 +0530 Subject: [PATCH 15/30] crypto: sa2ul - fix context release on errors Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-ID: <20260915-b4-upstream-sa2ul-cleanup-v1-15-57ab34e97162@ti.com> References: <20260915-b4-upstream-sa2ul-cleanup-v1-0-57ab34e97162@ti.com> In-Reply-To: <20260915-b4-upstream-sa2ul-cleanup-v1-0-57ab34e97162@ti.com> To: Herbert Xu , "David S. Miller" , Keerthy , Colin Ian King CC: Andrew Davis , Pratham T , "Kamlesh Gurudasani" , Udit Kumar , , , "Manorit Chawdhry" X-Mailer: b4 0.15.2 X-Developer-Signature: v=1; a=ed25519-sha256; t=1789466112; l=1469; i=m-chawdhry@ti.com; s=20231127; h=from:subject:message-id; bh=U0FOGrMlGFAZT4TKiZLTMpmME/UnVJHZYZaCVn/3oyo=; b=TLEqfn+/wS+5B0Rx/YKpuk2SgHQzNZoUSqdssNvWkL3GfSfgCRQQ9npSZTg0L0Wx2UCdNRoTo kC5905vN289BvxbYLtLxxIBEKaU8ekO3ZQI/v7GnB4RT1IbDU1cQ/Ei X-Developer-Key: i=m-chawdhry@ti.com; a=ed25519; pk=fsr6Tm39TvsTgfyfFQLk+nnqIz2sBA1PthfqqfiiYSs= X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: BN2PEPF0000449F:EE_|DS7PR10MB5973:EE_ X-MS-Office365-Filtering-Correlation-Id: 68446338-cd71-4860-8502-08df130f9807 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|376014|23010399003|36860700016|82310400026|1800799024|56012099006|10067099003|22082099003|18002099003; X-Microsoft-Antispam-Message-Info: ZhQKHCzEdpqP6yIzDp2hUWcJYd8QputBvDWpeOEX6eMv1UtbaSP5D1JlDALVspvUA9n/aMP5dDAtZeGaX/EeXulUaS6h0CRWKqpn60GaL9UfIu35FMRpfvgUxErybCmg6+ux2KA9DuT8LqdLUUvTYDUaRrGTK0BtYc76KtrsSG4bcTqj2Pt/JeLNCeNKeDr831Z3O6V22zD2RDgVY1/+2HxiDOblEHVvRgqpGfO437T8K8y9yYYgCFl1f/CDtz4c78tN8R/ZcQiuyi+NEVfLWuw/CnTYNGxqsQuwhJuy9oBXoUDrrvFWAWgSUDY65xKpUS2Xz9xDHAs+r//jyAX6A5zmYOsu+Ripyw1CgNH78juxsKntWmUTXxuB9FHYkV0iAnGkUo61DwEtZlTYOOPrq0DGBTIRV3/WnxqWMEMO0Zza3TtdOk+fqjWfqpZ1lSLVTlo+JSjFGbHBqaci/YWaNKflArvok6xnuqPsKHX/HCEpFgzT6xICjlBmZgzawEqKIadUf2W08EGOqfm+TwpLDAOSkrd1NTZTrtC0XR/YrdwjqEo8l+SuW7IFa5pkhqjjHdAVUmz5zHL3gf5wSFtKRuPO0C/bQNN60R4RsAhFI6qSWAxxPv6Qia9NIXjO/871AmoGe4ECntKZMpYGKyWzwGxDJ/OPHnutcgiFVYPk8TehNGSaq1KwV+FptISR+0ldjk+E8urs78Isx3D9lc/Ywg== X-Forefront-Antispam-Report: CIP:198.47.23.194;CTRY:US;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:lewvzet200.ext.ti.com;PTR:InfoDomainNonexistent;CAT:NONE;SFS:(13230040)(376014)(23010399003)(36860700016)(82310400026)(1800799024)(56012099006)(10067099003)(22082099003)(18002099003);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: ZKd8emZKhXX3TrxPBaQsijJM+tdpO/HfSCMNORzXKtjrY83Agh0LeWGrnjcKT9gS0RIavgrnMihO97KUlhSnTAIXPSVGhoxgctI4v6SU1h+UPzfI79LA3a6HI1k1uRRq9sCXiElNMA1QjOf4HK6jpdEr07Xc/aBq/PCMKj4Z/a23pElt+x2LvK89g0kCEWmE0G7ghc1o9VsQLX3LaEBGUx+U0kIwbqMzdTtGKn5eCdHMTErn2R06612r/2bY1dc7epb+o2ge0pvJMh99pGf6q71bpaunYQk4Rm9b/0ujzxigXt9Cy2d8j/0w3MAxjXMOzmQcdBGu8vKUh7qaBAdDBtbCmYe/yciC1eoidRxF/YRC+KGtFDsnNjJgZoNN0I/Xr9gOiP0EWl+3XYJ6RvbGdmObfcop2b31Ox6pmNvaEdn8mvcsdoyNV1Jm4OdlKCCU X-Exchange-RoutingPolicyChecked: Q6FWOqPTIERGxiM+QDndz9ER2lHA9jrZ5PQewZQmS46mQ4fQh3wi+iufAWx3nLjARUSd9WhbigvqSjWF9eOpY2p+iHmFGqY1+f4WaYKxbJRCyfJ8k+7KVIoGnsC/19w1DdJQIF01v0jBdEjD+rXFUOts/UWcJqztGOfUGa9EPjXjQ04MyUOWH5HGmwe7bp1GksMIqcZ1bT2bpeAPD6+UrT3/f1gEIj2mUlX+j5KpQwwaFqRMoywxiVKCYGCmANmFRhTYpZqMAc/Spu9R0TapLjTiV3obQlz+aB2nzFm1QcO5e570znK/WgfKCqapVlwG6Z+1L3KYCzilD/gyQSggew== X-OriginatorOrg: ti.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 15 Sep 2026 09:56:20.4603 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 68446338-cd71-4860-8502-08df130f9807 X-MS-Exchange-CrossTenant-Id: e5b49634-450b-4709-8abb-1e2b19b982b7 X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=e5b49634-450b-4709-8abb-1e2b19b982b7;Ip=[198.47.23.194];Helo=[lewvzet200.ext.ti.com] X-MS-Exchange-CrossTenant-AuthSource: BN2PEPF0000449F.namprd02.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: DS7PR10MB5973 X-Proofpoint-Spam-Info: AW1haW4tMjYwOTE1MDE0MyBTYWx0ZWRfX5m+gVRfrPBmH Gy4gIIbx+dMa8xQu2k7houDIQ38KVPX/AhGJS6FEsQ4CF69zFlCL2PvfuTuN5eVtEuZDfN8lYZd H80jrQVD8qgA4PQoc6Q54ZkWLlfyLa4= X-Authority-Analysis: v=2.4 cv=KvnYSmWN c=1 sm=1 tr=0 ts=6aa91648 cx=c_pps a=m+Y8nsmXU8Fd5URmI4pqsQ==:117 a=WotqVVQAdb04rnGuttW3Kw==:17 a=6eWqkTHjU83fiwn7nKZWdM+Sl24=:19 a=IkcTkHD0fZMA:10 a=VdqzKS8jKosA:10 a=s63m1ICgrNkA:10 a=V5UXEbMT0ywA:10 a=VkNPw1HP01LnGYTKEx00:22 a=Z8NIEmU8O1QQgoT56wFK:22 a=fPAWb5peG099m5CrUpKH:22 a=sozttTNsAAAA:8 a=rbbrXJFpQEzXrE5zXqEA:9 a=QEXdDO2ut3YA:10 X-Proofpoint-ORIG-GUID: Cf6j-NEJMsl8d0PEw24sgVT1hYwz39z7 X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwOTE1MDE0MyBTYWx0ZWRfX5xEdhJxsQrr1 oKSd23OO211M5isFmLYmWFG8jx1mV4wef/HFISSgvUdMkKcCnuC8Y2ktxoOtBTwB2zcWWgBpvlR aeeV/R4CRo9l9xOR3NrYxz2hnZl2Q8qD7+lZErHbC9SeLtz992j90n/svySWgTES+pxmMOZjMsZ saTTv1P5EF+BzQxVnIV41eFV8cKn0ohV5qtoI3rPSdgjwF3Yb0xS03wQfETJ0iwMnz6/GGfW4ud QaEnLfiD/NqoMpXOXG4K+VTx5Fr98HOSZSLA3HOJIc8GYW9aCIY7y6KiKF5y7rl1uKd9/DWMHNA jSvdvd5uJ/YMAFCmXq3eoWJTt3dBy4WGo7iIPuENh/pZIjqkGqz8DFSftnRp7Vz4Swdih6ZPnl0 MZXbgunb2edBeNcTfcQaqDp7pghunIntUqtcRoUuHulyek3RQX6fdpPTIAiLxliIgWW4aC1jKYR kwWguoBQowa+LFq5KvQ== X-Proofpoint-GUID: Cf6j-NEJMsl8d0PEw24sgVT1hYwz39z7 X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1176,Hydra:6.1.134,FMLib:17.12.100.49 definitions=2026-09-15_03,2026-09-14_02,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 lowpriorityscore=0 clxscore=1015 priorityscore=1501 impostorscore=0 suspectscore=0 spamscore=0 bulkscore=0 adultscore=0 phishscore=0 malwarescore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2609040000 definitions=main-2609150143 Fix security context cleanup in error paths to prevent memory leaks when crypto operations fail. Fixes: 7694b6ca649f ("crypto: sa2ul - Add crypto driver") Assisted-by: Sisyphus:claude-sonnet-4-6 Signed-off-by: Manorit Chawdhry --- drivers/crypto/sa2ul.c | 15 +++++++++------ 1 file changed, 9 insertions(+), 6 deletions(-) diff --git a/drivers/crypto/sa2ul.c b/drivers/crypto/sa2ul.c index 7ec048136114..cd80a2dabc99 100644 --- a/drivers/crypto/sa2ul.c +++ b/drivers/crypto/sa2ul.c @@ -826,16 +826,14 @@ static int sa_cipher_cra_init(struct crypto_skcipher = *tfm) if (ret) return ret; ret =3D sa_init_ctx_info(&ctx->dec, data); - if (ret) { - sa_free_ctx_info(&ctx->enc, data); - return ret; - } + if (ret) + goto ctx_dec_err; =20 child =3D crypto_alloc_skcipher(name, 0, CRYPTO_ALG_NEED_FALLBACK); - if (IS_ERR(child)) { dev_err(sa_k3_dev, "Error allocating fallback algo %s\n", name); - return PTR_ERR(child); + ret =3D PTR_ERR(child); + goto alloc_err; } =20 ctx->fallback.skcipher =3D child; @@ -846,6 +844,11 @@ static int sa_cipher_cra_init(struct crypto_skcipher *= tfm) __func__, tfm, ctx->enc.sc_id, &ctx->enc.sc_phys, ctx->dec.sc_id, &ctx->dec.sc_phys); return 0; +alloc_err: + sa_free_ctx_info(&ctx->dec, data); +ctx_dec_err: + sa_free_ctx_info(&ctx->enc, data); + return ret; } =20 static int sa_cipher_setkey(struct crypto_skcipher *tfm, const u8 *key, --=20 2.43.0 From nobody Fri Sep 25 12:05:54 2026 Received: from mx0a-0002e601.pphosted.com (mx0a-0002e601.pphosted.com [148.163.150.75]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 2EB6D486647; Tue, 15 Sep 2026 09:56:35 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=fail smtp.client-ip=148.163.150.75 ARC-Seal: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1789466199; cv=fail; b=mTqYUX1VotcLS9cI2EIl4n0Q1t1tQD3hABl5BvpscDopXf2oae2j+WHNIAVjCBRxelkO9M5k5bGZ6Iyim1j/pUceAqVch055hqzOZ10GysoNmsDyPq3eo8lB0exEMtJ1izvZ77D4Mx4TaMXh1hO5L1iZiy1M93SdtZ42pEjWvzg= ARC-Message-Signature: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1789466199; c=relaxed/simple; bh=rT3SC/hCXL7KlyVJ01lf9BiHNu59V5uYF3pCMmVTNJA=; h=From:Date:Subject:MIME-Version:Content-Type:Message-ID:References: In-Reply-To:To:CC; b=cBEkIElIkbhaBJJQsmvlWZk67eAb1oPNvw0EFbrCdsx75LJz5jUhaag2x++RmJZb+KfkIMIKuU3BDxLWdrGXnPIZubJAFsXfy1E0buY64qlT5cqgZ1ZPZ3VWdMeO0wjRisdOiFHGQCmJcgrokmmc20KSbfFoNrELNx/iSQI93Gg= ARC-Authentication-Results: i=2; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=ti.com; spf=pass smtp.mailfrom=ti.com; dkim=pass (2048-bit key) header.d=ti.com header.i=@ti.com header.b=G6tsRzmZ; dkim=pass (1024-bit key) header.d=ti.com header.i=@ti.com header.b=nHK2ZV9W; arc=fail smtp.client-ip=148.163.150.75 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=ti.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=ti.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=ti.com header.i=@ti.com header.b="G6tsRzmZ"; dkim=pass (1024-bit key) header.d=ti.com header.i=@ti.com header.b="nHK2ZV9W" Received: from pps.filterd (m0384305.ppops.net [127.0.0.1]) by m0384305.ppops.net (8.18.1.11/8.18.1.11) with ESMTP id 68F9eksg1480570; Tue, 15 Sep 2026 04:56:32 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ti.com; h=cc :content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s= proofpoint-05-2026; bh=FNsE+Cx7gDJmVML3m/K7srnVVdFVYpjmpzAoYV0w8 ig=; b=G6tsRzmZ1rQIiy68L+7B8ypLeLy+bAkNAYtFUit1g8RZ7F3/7L1SjciaK 8S95TOJ9qRaxVPnq73xhqSZ0k7fWKaMkXzSF5taeDHyfaRAiYrUNvH5KJTjg5TYF U9G1cV6YsdBTYpwWr4olJiHwian1AD6xWsveNqyjYHXX223fvjeq3VPNk/kRYj+O wRX+UsjqQXBIa+Jzr55pFow195lRmt256C24Mc7U/0Le2p9iE+HvkaoWu2s/QTEe LAqj2NToiJYm/wXEhCxRtR0Aw6F4mGXutaAQZLYAwRmYtvwxVIczMG3i4XfD/KbD /wZ8qCI/9xRrqH15d1nJOXfxYr6+g== Received: from ph0pr06cu001.outbound.protection.outlook.com (mail-westus3azon11011069.outbound.protection.outlook.com [40.107.208.69]) by m0384305.ppops.net (PPS) with ESMTPS id 4gpvpa2j1v-1 (version=TLSv1.3 cipher=TLS_AES_256_GCM_SHA384 bits=256 verify=NOT); Tue, 15 Sep 2026 04:56:32 -0500 (CDT) ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=rf+dkjkAFMkEXBWBhJBxPbpkMp0UFvLcrN3kKnHcpNfa8NubT6aRaG/za7nQVjYk8GhgqZajBQBnC3HSs23jxb1t98nflD0++Q+jfc3FS58sCmKoTPSwsv4KLxxWLOcmJinlDF37QIG+QaN4u5ADth87Z0WRx7Vcbh6MwoU6mrF/yCKydGtXA92X/6/dNr5ShpiBoyWaz5And8KpjveWxf/I90F1nvVYd+ipFva+K8SVfJlsVLFS3PDNHUVJNn9qWghKLjehMs62213zXLQbmQGv5xi7GA+ckKF6J24RjRjKmeoj2/ODl12Scjjq6bM+SrlSOIFeIdn0KSherrNyLg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=FNsE+Cx7gDJmVML3m/K7srnVVdFVYpjmpzAoYV0w8ig=; b=pNN5ha1pvJhq6baWj6tWu1LEAK/DpEc6kOCG4mG7JA6ZNCVCPekaxaGYcy9szTX4aC1IawFivgeqfrXzEF6Fmyr/GC68lcIHcaprHIKpFnuflLKpvcAWBtE7Jf3qKSDC2Lf518iBfXg4yt1jlD16HfzWzlh8e8KL7nrxJBqfbscmvw5b+u68jITY1XlnIOk2g32yq3I1l4WmXuJqHpS2AWMQ6Zg5K1qMIdSjgOCuEAx6zMrPgGNW/2L10EGaLHEbKMkxJbpeYvyJIALZVJI7l8pdyf/kUQTZmQnxQx3qRrTtRzVu2P+sw73gyD4/GUypZrXrt0KyxwLEntN5zb631g== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 198.47.23.194) smtp.rcpttodomain=vger.kernel.org smtp.mailfrom=ti.com; dmarc=pass (p=quarantine sp=none pct=100) action=none header.from=ti.com; dkim=none (message not signed); arc=none (0) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ti.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=FNsE+Cx7gDJmVML3m/K7srnVVdFVYpjmpzAoYV0w8ig=; b=nHK2ZV9WgEYqNExbRVmresYL4KiEqKHkod1Pq7gSGw3fYsJGZWjVs/Y5VLHSPcP6i0sZuyFRVxjL5xmW36lglfLO+NpUZbkKDJyvSij4LJhB+5BtW6TJ279JGaymKMeSr3xwQ2xOgMVFwJ1VjM+eNdv5VMrjeW+HYSjgbrSuyQQ= Received: from BN0PR03CA0051.namprd03.prod.outlook.com (2603:10b6:408:e7::26) by CY8PR10MB6491.namprd10.prod.outlook.com (2603:10b6:930:5d::18) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.21.428.7; Tue, 15 Sep 2026 09:56:26 +0000 Received: from BN2PEPF0000449F.namprd02.prod.outlook.com (2603:10b6:408:e7:cafe::6e) by BN0PR03CA0051.outlook.office365.com (2603:10b6:408:e7::26) with Microsoft SMTP Server (version=TLS1_3, cipher=TLS_AES_256_GCM_SHA384) id 15.21.406.12 via Frontend Transport; Tue, 15 Sep 2026 09:56:26 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 198.47.23.194) smtp.mailfrom=ti.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=ti.com; Received-SPF: Pass (protection.outlook.com: domain of ti.com designates 198.47.23.194 as permitted sender) receiver=protection.outlook.com; client-ip=198.47.23.194; helo=lewvzet200.ext.ti.com; pr=C Received: from lewvzet200.ext.ti.com (198.47.23.194) by BN2PEPF0000449F.mail.protection.outlook.com (10.167.243.150) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.21.428.7 via Frontend Transport; Tue, 15 Sep 2026 09:56:26 +0000 Received: from DLEE204.ent.ti.com (157.170.170.84) by lewvzet200.ext.ti.com (10.4.14.103) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.2562.45; Tue, 15 Sep 2026 04:56:08 -0500 Received: from DLEE205.ent.ti.com (157.170.170.85) by DLEE204.ent.ti.com (157.170.170.84) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.2562.45; Tue, 15 Sep 2026 04:56:08 -0500 Received: from lelvem-mr06.itg.ti.com (10.180.75.8) by DLEE205.ent.ti.com (157.170.170.85) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.2562.45 via Frontend Transport; Tue, 15 Sep 2026 04:56:08 -0500 Received: from uda0497581-ant.dhcp.ti.com (uda0497581-ant.dhcp.ti.com [10.24.51.159]) by lelvem-mr06.itg.ti.com (8.18.1/8.18.1) with ESMTP id 68F9tB863000901; Tue, 15 Sep 2026 04:56:05 -0500 From: Manorit Chawdhry Date: Tue, 15 Sep 2026 15:25:22 +0530 Subject: [PATCH 16/30] crypto: sa2ul - fix resource leak of sha in init_alg() error path Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-ID: <20260915-b4-upstream-sa2ul-cleanup-v1-16-57ab34e97162@ti.com> References: <20260915-b4-upstream-sa2ul-cleanup-v1-0-57ab34e97162@ti.com> In-Reply-To: <20260915-b4-upstream-sa2ul-cleanup-v1-0-57ab34e97162@ti.com> To: Herbert Xu , "David S. Miller" , Keerthy , Colin Ian King CC: Andrew Davis , Pratham T , "Kamlesh Gurudasani" , Udit Kumar , , , "Manorit Chawdhry" X-Mailer: b4 0.15.2 X-Developer-Signature: v=1; a=ed25519-sha256; t=1789466112; l=845; i=m-chawdhry@ti.com; s=20231127; h=from:subject:message-id; bh=rT3SC/hCXL7KlyVJ01lf9BiHNu59V5uYF3pCMmVTNJA=; b=UoaTyq9mkbRxt6ALDt0LYX7k7SNvTLcshnpbB5EQGehyDUOr/j0ewDB4Y1o62p4i30cQIaIZz z0Zo68BjSaLCMg66tveFNu1LfA93/TBjm5Jn01EN9aRxDCTuWnfHvoX X-Developer-Key: i=m-chawdhry@ti.com; a=ed25519; pk=fsr6Tm39TvsTgfyfFQLk+nnqIz2sBA1PthfqqfiiYSs= X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: BN2PEPF0000449F:EE_|CY8PR10MB6491:EE_ X-MS-Office365-Filtering-Correlation-Id: dc7b014f-5918-417c-68dd-08df130f9b7a X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|1800799024|82310400026|376014|36860700016|23010399003|18002099003|22082099003|10067099003|56012099006; X-Microsoft-Antispam-Message-Info: pIc0tjAQi5+cBnsFNrr3Cz+w1L3sdgcXZxPJ2t5iuA7EeqEGV6l9+yrWHFok9lvaUNDHEUPFKCrsitmcO86p0nSOBiwbM5BMc3zFoG/dwMdACdjL3PDezSF66/1k5VI3yZkXuBR7KKXo1ur/DqQn6Onja8p77H4BPbvIU6TsbzvQSSZi0ESXRVszT3eNAax2njkPYRWUjLcs9CTVPABsPHo0/Jrq55h41NL98z7I1NQ666Qc2t4AtBHeObwInYVajUls6qxmXV9KTF7FgG/GX67mz5ircs20GtZ44oLwMPD4ysuZEbbeTmpYcvFxCrstlJEXTP70Aa5cL2E0ds7K1WnKtsg6z3ExfNIfHsODl0xome9SY2CBKTiY4zZ3phbY1zbq2etAmGvHYxsYoc53+/wg4DHYtDESV8JJesaCeg1qLlRvqP1IwtZxFKks/FILxMqhR+AbFQqkwkY02H2QpabIrP7PAso/CWrn4uSOUa22xovOHvHIsQipnmePS4OMFdI4rzDEuFcAaIXKb/9QPgP/Q2VRnuYR/+1QdSqXBUw0LDBhOJVR7DEo/ShPr9PBAuUoeuJnUU9ZWuoF5r7Ik+4fgI6IMae+sBj4lsl+1ojAA8FFe4aTPgqZgI+Mov+fy9hk7OnM+cxALEuC8CRiNzuouYspzsDg9ht4v7CewgsUBYbKmHvaYIM0jM6jxGHgscMryq3pt5dAx9j5GjPEYQ== X-Forefront-Antispam-Report: CIP:198.47.23.194;CTRY:US;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:lewvzet200.ext.ti.com;PTR:InfoDomainNonexistent;CAT:NONE;SFS:(13230040)(1800799024)(82310400026)(376014)(36860700016)(23010399003)(18002099003)(22082099003)(10067099003)(56012099006);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: VyD1MkNxFEOqFi02cAyUNYqS5s33y4DfHVGOf/8nEejPAGcCINEmRslOOGQ3+M4F5Esq6FFnBA7dMRVdq6lB7kK0/pkjI23ksbKWfULExc7k+F6/eKmGOqkAsitHRkU9uPOkcqSG3mU6zoDet/v+vVgtgeAptLlotFfZuWURFVODU2aw5svL+5m+5sQMMiPIinlVgJCE2Qr8oxzSZ9CawCRCcqgdAmNHPxo7SDad5cM+eUT8Yqs5txrPWL9+O8mb+pmhKUtymXyfjtb7ACWmJTq+s1E3XCRmQYtInMH8H2tSftjcYlF2/33PFYGan0dU1Odxr+hgr1cN0FAcNYK+YoSuHqKzH3YKanBiwUtnEBw4+suY/mLHqdvEJ43QWa8WcVfRW+oXJejm41VXMyE5zy+sd3zeve8MrmocUIuSoWXRQan1DvGPSSahfPXCI8As X-Exchange-RoutingPolicyChecked: hJDHeSaw2kmV/S7ullYrNjw9ezdYKLUvykQZ1h6rNIVmwWGfaAkHkrVTICByeslzsFcWrdSJGVnp38TQX1qUkEXc1T+jKisIJZ+dP1sUfm76Tl2z6KLBhTvF3b6jkWRWD1E9ui5MZCas2Ti416TiXQF2WdcQ+YWjR/0/2vTYgjr20pRHufZkXP0RSROK7HTTnwWaau7riwFG7qtcv3yVuAymrecclsnoZRnKBl15+KVyT5xvcD/ZFhTIkaqWDxTXd2KZtFqzvNMbvPzROoMvl1uWXSP7JqwlCUkb32oStjE5ZmCWKFrez6eymRIxtC/Lo5N0gBxl0oUfZ1opO/3fgg== X-OriginatorOrg: ti.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 15 Sep 2026 09:56:26.2529 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: dc7b014f-5918-417c-68dd-08df130f9b7a X-MS-Exchange-CrossTenant-Id: e5b49634-450b-4709-8abb-1e2b19b982b7 X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=e5b49634-450b-4709-8abb-1e2b19b982b7;Ip=[198.47.23.194];Helo=[lewvzet200.ext.ti.com] X-MS-Exchange-CrossTenant-AuthSource: BN2PEPF0000449F.namprd02.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: CY8PR10MB6491 X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwOTE1MDE0MyBTYWx0ZWRfX7H1jZeWvnabN C1/2WvOwGnZ2xfByvjh9RRfPNUxSo/QYJqZeOf0WABocI89Ii/muz1zmRlkOEea/GZnFumVcU1l VIJ8cVb7IsOw4waqVoSp/qPPf/sUL7hJnNHNLTTSwCvrG/20o7CLAUUdHFoJ0ZqOTGBPtRc8VNK de0UbSqDrSKJOf235x5zlERtvGKOp8Agj7PcLITPoTNvO/Tse53loYfFfMyr3TNeYKgRdjt+aMV Q5lTdgWLvLw+YyEOtr7ciXYyf6zM8AZZR9TYiQUHMnd2xvnQYGfoB/5eUqF5HbP0yx5Hq4FDOYn 3y+7LhioBFg9c0iQlch8ZXH9e5lC2oAMiAzrlqMs1Vud+/0eYhfpUUGX49mygSyiNk+Z9FImqIW nNOPVc4XzrPdHRqufEW9+2crjTdekJ7SDJRu3EDpz4FtGU2mI4OHK+rFxc473RPwLAyDq8vtHS5 KIBIfqu3hjtbYW0xBcw== X-Proofpoint-ORIG-GUID: 493BBxp55cmAUVLZBHoZWKA7sfR8YUnA X-Authority-Analysis: v=2.4 cv=U7cHnuru c=1 sm=1 tr=0 ts=6aa91650 cx=c_pps a=6F5B6RZBoOcbxKr4+OQwLg==:117 a=WotqVVQAdb04rnGuttW3Kw==:17 a=6eWqkTHjU83fiwn7nKZWdM+Sl24=:19 a=IkcTkHD0fZMA:10 a=VdqzKS8jKosA:10 a=s63m1ICgrNkA:10 a=V5UXEbMT0ywA:10 a=VkNPw1HP01LnGYTKEx00:22 a=Z8NIEmU8O1QQgoT56wFK:22 a=taLDd7a_hP9WKsMzeGRc:22 a=sozttTNsAAAA:8 a=rz5iBERWMEUT3MW84tAA:9 a=QEXdDO2ut3YA:10 X-Proofpoint-GUID: 493BBxp55cmAUVLZBHoZWKA7sfR8YUnA X-Proofpoint-Spam-Info: AW1haW4tMjYwOTE1MDE0MyBTYWx0ZWRfX7NnNMJfh+ZiF FzBo8/YS/MoruKtl1Mq7MnpYTaOwOt0+bTbcP8JfyLYp1E+AW+N2steJbkiVDU2W9TmLKmaA7Te M1UYY+e0+5Qy7sy+ouIcAunuQCz7WW4= X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1176,Hydra:6.1.134,FMLib:17.12.100.49 definitions=2026-09-15_03,2026-09-14_02,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 priorityscore=1501 phishscore=0 lowpriorityscore=0 suspectscore=0 impostorscore=0 malwarescore=0 bulkscore=0 clxscore=1015 spamscore=0 adultscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2609040000 definitions=main-2609150143 Add crypto_free_shash() call before returning the error to properly clean up the resource allocated in the previous call. Fixes: 2dc53d004745 ("crypto: sa2ul - add sha1/sha256/sha512 support") Assisted-by: Sisyphus:claude-sonnet-4-6 Signed-off-by: Manorit Chawdhry --- drivers/crypto/sa2ul.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/crypto/sa2ul.c b/drivers/crypto/sa2ul.c index cd80a2dabc99..9379d1271698 100644 --- a/drivers/crypto/sa2ul.c +++ b/drivers/crypto/sa2ul.c @@ -1465,6 +1465,7 @@ static int sa_sha_cra_init_alg(struct crypto_tfm *tfm= , const char *alg_base) if (IS_ERR(ctx->fallback.ahash)) { dev_err(ctx->dev_data->dev, "Could not load fallback driver\n"); + crypto_free_shash(ctx->shash); return PTR_ERR(ctx->fallback.ahash); } } --=20 2.43.0 From nobody Fri Sep 25 12:05:54 2026 Received: from mx0b-0002e601.pphosted.com (mx0b-0002e601.pphosted.com [148.163.154.28]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id AAB6F485949; Tue, 15 Sep 2026 09:56:36 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=fail smtp.client-ip=148.163.154.28 ARC-Seal: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1789466199; cv=fail; b=DsLVxsAZyPnG5hPxFYQsaXqFuJW0P1mY9UrXHucSxa9SGhdLnmIIsfLgUA8MjZcSeDGxLceyxlaBijXY6HDWHpm68jEOiAGMHhlAZAgJQPY0BI8/01SCChu7kP+aoxh9JPAAlnVepcHhzxQw5JiU1Gb50Rko38atfIGHbCsqI2c= ARC-Message-Signature: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1789466199; c=relaxed/simple; bh=7hKzUduRIbIpCnCdraHXnKtxd2wsf7ynx5yjrGbLHfs=; h=From:Date:Subject:MIME-Version:Content-Type:Message-ID:References: In-Reply-To:To:CC; b=ENHvEG22WokS+9cRIbvLihB7sv6WGll5Fjuf3X2q3HY2w1hTEivHiAsRayeqM1TFXrfQVr1jOW2rruL/ET8G/KlzNbZcmcxZyjXqTpvuFY3NaUY+AaypEzMiEJTwnHigiJrzK1tGTTun5aZRadoO6wSUGTcf4VI17AZfUUsFl+Y= ARC-Authentication-Results: i=2; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=ti.com; spf=pass smtp.mailfrom=ti.com; dkim=pass (2048-bit key) header.d=ti.com header.i=@ti.com header.b=Oj5Szlcx; dkim=pass (1024-bit key) header.d=ti.com header.i=@ti.com header.b=ZHV4ku/5; arc=fail smtp.client-ip=148.163.154.28 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=ti.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=ti.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=ti.com header.i=@ti.com header.b="Oj5Szlcx"; dkim=pass (1024-bit key) header.d=ti.com header.i=@ti.com header.b="ZHV4ku/5" Received: from pps.filterd (m0374956.ppops.net [127.0.0.1]) by mx0b-0002e601.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 68F9fCEP3811021; Tue, 15 Sep 2026 04:56:31 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ti.com; h=cc :content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s= proofpoint-05-2026; bh=paNOlWd1sNIi3ld9FPKkhqvOmIqIdVEdv2oI6YYts gM=; b=Oj5Szlcx01nfIgPi35lokzK7wxf/XsYeTl62Pq7ksH/o/AuNhfweWcn/6 2dUIxRgIZi9r+h67v6EMLsxZm4XCJSOJrhZM3AiFHMXRUqIwjGj71Wfzu59b2EPh P+up+6T5qAqMPZIHdaKU42fVh9DKGJQ2jALFdZHOJuBG7oBYIJleKenn50fyXaVc Br5Q/gpjtpMZnzrjUfHn1Fj6pI2JTTmVPH4Xdq+w2oF6TrFl/Gz0j3YS6vGcuvmn ge/PkBCzBHlBLKqU9g3KUe1TkFfSPyOzxP1SzMc5/AO0jP2vUb3MXhAHoww5bj4Q bDVfkGaS8+/0+3bSrMPGZtqkU8YRA== Received: from ch5pr02cu005.outbound.protection.outlook.com (mail-northcentralusazon11012027.outbound.protection.outlook.com [40.107.200.27]) by mx0b-0002e601.pphosted.com (PPS) with ESMTPS id 4gq362r9xa-1 (version=TLSv1.3 cipher=TLS_AES_256_GCM_SHA384 bits=256 verify=NOT); Tue, 15 Sep 2026 04:56:31 -0500 (CDT) ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=T6kQ75jZAOptobdemU9OymHpOWenmZQVBSfZP+9zJqDMtBR4Ll6NSk/G6gFR+bxnwMywIfvUZrARJiKsjXgbZYRZCIRSYPtAN/GOSXF7P0nXHXR650wr/8F9TwCT3zJ/Oo+5oj9c0Pz8z4TIb6sg8TpCAPVuD7yme3eyLB00o+T1Ac3fW2Re6ouCObGrCgR9hlrT3mZ5Td0r97hAbZaATV6MDyOEd6w+wyHK4KbXKPvnZ7A8DN4u464MODpWlk79Daja2w/GvdavYC5BURo0lVyl0tXkba1Gkjws/WALs+i4Xq4MSijfzChALQHus5y3hMdXSc5oA0h6jJ69Q/F8OQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=paNOlWd1sNIi3ld9FPKkhqvOmIqIdVEdv2oI6YYtsgM=; b=M4iAcfMRxUonWFzcx2KgMJsQfzu3dUsQxnmlY8yeUR3x3zx1EzfGZHY4tmXFauxTAjoZhOljzu+/sINGXNVQDu7pRZmlPnU7QC5MSnx6glJoYZwDxSk1N9TT28bMcRWEj5O3xSX1L7fVi8oiH4ZC7LEm4OAHF5wQyBQp6ZorSvQfyG6yxe3IrV92Kx3a+aHlAdWTKA/Cg7CXyRoB76HldOgfV23yGT323kJsi4sLuqikB2ysU3FNyjnGpS8UXs6mSHPqUqpF5WBfUX7uQs6CkGDGbHtnhTNQt6bCP2474byqWOtwLw5ioJSo5PRNDK+3Up3JSiMSH1LcyLW2nBw44Q== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 198.47.23.195) smtp.rcpttodomain=vger.kernel.org smtp.mailfrom=ti.com; dmarc=pass (p=quarantine sp=none pct=100) action=none header.from=ti.com; dkim=none (message not signed); arc=none (0) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ti.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=paNOlWd1sNIi3ld9FPKkhqvOmIqIdVEdv2oI6YYtsgM=; b=ZHV4ku/5cY9nH0BJuq92ZzW9NqTYUVIrP/S+6cBgVMmoMI+dOCFGOkDTUtbh7HpVSXdL8+pQQPa3SSzk86qTivQprnBGmwtGooeDKtCQruaL2WZksjP2qOROa9XAdn+A7gzwqyugGDBhdPJdFZ2Hl11GTixecBmuOTJnKjk06nQ= Received: from BN9PR03CA0290.namprd03.prod.outlook.com (2603:10b6:408:f5::25) by SJ1PR10MB5906.namprd10.prod.outlook.com (2603:10b6:a03:48b::9) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.21.428.7; Tue, 15 Sep 2026 09:56:25 +0000 Received: from LV8PEPF00000066.namprd03.prod.outlook.com (2603:10b6:408:f5:cafe::72) by BN9PR03CA0290.outlook.office365.com (2603:10b6:408:f5::25) with Microsoft SMTP Server (version=TLS1_3, cipher=TLS_AES_256_GCM_SHA384) id 15.21.406.12 via Frontend Transport; Tue, 15 Sep 2026 09:56:25 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 198.47.23.195) smtp.mailfrom=ti.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=ti.com; Received-SPF: Pass (protection.outlook.com: domain of ti.com designates 198.47.23.195 as permitted sender) receiver=protection.outlook.com; client-ip=198.47.23.195; helo=lewvzet201.ext.ti.com; pr=C Received: from lewvzet201.ext.ti.com (198.47.23.195) by LV8PEPF00000066.mail.protection.outlook.com (10.167.248.38) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.21.428.7 via Frontend Transport; Tue, 15 Sep 2026 09:56:24 +0000 Received: from DLEE206.ent.ti.com (157.170.170.90) by lewvzet201.ext.ti.com (10.4.14.104) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.2562.45; Tue, 15 Sep 2026 04:56:11 -0500 Received: from DLEE213.ent.ti.com (157.170.170.116) by DLEE206.ent.ti.com (157.170.170.90) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.2562.45; Tue, 15 Sep 2026 04:56:11 -0500 Received: from lelvem-mr06.itg.ti.com (10.180.75.8) by DLEE213.ent.ti.com (157.170.170.116) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.2562.45 via Frontend Transport; Tue, 15 Sep 2026 04:56:11 -0500 Received: from uda0497581-ant.dhcp.ti.com (uda0497581-ant.dhcp.ti.com [10.24.51.159]) by lelvem-mr06.itg.ti.com (8.18.1/8.18.1) with ESMTP id 68F9tB873000901; Tue, 15 Sep 2026 04:56:08 -0500 From: Manorit Chawdhry Date: Tue, 15 Sep 2026 15:25:23 +0530 Subject: [PATCH 17/30] crypto: sa2ul - fix resource leak of AEAD in init_alg() error path Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-ID: <20260915-b4-upstream-sa2ul-cleanup-v1-17-57ab34e97162@ti.com> References: <20260915-b4-upstream-sa2ul-cleanup-v1-0-57ab34e97162@ti.com> In-Reply-To: <20260915-b4-upstream-sa2ul-cleanup-v1-0-57ab34e97162@ti.com> To: Herbert Xu , "David S. Miller" , Keerthy , Colin Ian King CC: Andrew Davis , Pratham T , "Kamlesh Gurudasani" , Udit Kumar , , , "Manorit Chawdhry" X-Mailer: b4 0.15.2 X-Developer-Signature: v=1; a=ed25519-sha256; t=1789466112; l=833; i=m-chawdhry@ti.com; s=20231127; h=from:subject:message-id; bh=7hKzUduRIbIpCnCdraHXnKtxd2wsf7ynx5yjrGbLHfs=; b=M2fmpnzsZOOLzmPCmBgSN5JDOWym0BIefJsX1lXwZTlyXE3tlA/UjDytU1ahvKRotU8iSEKwH 48k+PzmPK36ABBohbon+0VQv9PzewJxl5n1evLeCnzvZdpuTpQLr0f8 X-Developer-Key: i=m-chawdhry@ti.com; a=ed25519; pk=fsr6Tm39TvsTgfyfFQLk+nnqIz2sBA1PthfqqfiiYSs= X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: LV8PEPF00000066:EE_|SJ1PR10MB5906:EE_ X-MS-Office365-Filtering-Correlation-Id: c7ca37aa-9703-481e-d402-08df130f9ab5 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|36860700016|376014|1800799024|82310400026|23010399003|10067099003|56012099006|22082099003|18002099003; X-Microsoft-Antispam-Message-Info: tCmSIv4Cjvs+j/9T0YzA5smsD5wQTz7VkmGkemtjsCInybnnENw//yvTs1NcZJFmyF/m9a0xRrYK8iwc9dB7dkEqL/srL92reiyHpxMSG356hxTvU3tq8NoA8dxbx37+OQGj35F0jfrbAgh+U6Bs/tM9/L5toaBuqRqrlRZScS37XgfaLzhayjSIa97++h0VFe2ATDPE2xGizNrcImmeJ0cAU0Rf2O6cV+9SKvac8JnYA72Czj5w8HCmLFzWPGObmvDSf21TJVieCnPLSZjfzGEDQFcLxA9QchVF1p5njH60tQe884lr8akDAIvd3rY0PK3je2kgjhUAsCmW0bTc20O0bt+f8ZYCafQ1LKHz9ORvMiFCAfnR8Uux12FpCcy/PV2C1wQfo1KxW9IgxHQ+SNwO0OWs1I7DSjKMyKJqT3A2uY5poVaFzjXtnOw5prqVd21Cl+TTTF8xepPmSaM5MZ5/OJl6pxPguboYH7hIjYDchbkmrhv7h2iWcjtdzzD312weEPI/I7YS5nqLSskwDbYf0uvmwYPawKZ900DDJJNicWIOlv77ZzP2i6/H75Ub2KbmwbN+zn9KrWXe5DtXyY+mwCh4PRmTMxuKx+udxKQ/s6puNzNBx6LjILOggA3hN1LrndSAK4NoRELs2Iacx0tgrKxiPlWVdtks0q3nqrXgLAdYAVkD0zp2IXdLRRetwpMWfSI/es2SVcwAE2ZSmg== X-Forefront-Antispam-Report: CIP:198.47.23.195;CTRY:US;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:lewvzet201.ext.ti.com;PTR:InfoDomainNonexistent;CAT:NONE;SFS:(13230040)(36860700016)(376014)(1800799024)(82310400026)(23010399003)(10067099003)(56012099006)(22082099003)(18002099003);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: Ljkf1mu/ZsQSNw7xiKjswC7OgufEqu+BCNEA5wyNlnh+arj9XTDHLFwnMeioEGLJK9QNirxiDz1qzJVzodFUNF05rrNtPhyziHMMn2BCXExOhDu+3TSieXQkAy9mXULyM8wozbo0oVffjh0p/hIJoyT4WrfLoK7ZZazlK8CNDjRJkoYceUuu+6zPWXAOaMJmhsiOA2t1U1DFq3Gil4GgXsTIxrK6mjSMs3ZJXx3SdE3DsrOV0l55F1hSDSh0a/b+BTfI5EUTNto5H3hS0TKU0viXOoyeVK3N9qX7fNIy99ma5DEpfafmGWu3AoZwxKLK5CLhRMswykOTN3Y8QbbHbNK6sJIadzzRsey0VzDHODN2Xr9bB2Xjju3krMaAe+vFfar48swf7DRuUczBrrRkzxKh3bJfSIUh9VeW/bR2Zof0q101OIAVQ8LgMu+YAZSh X-Exchange-RoutingPolicyChecked: wVfy+GytWV/X8OUAAfYEFq05kH0tUK8DlgTHET+qQbOKujIYu8UAqtYQsZlz2xxswHhJlkLQ1hSqbGc1hqVgpypoFy1T8Y2bJO/mgmhySlzyl91/rCi3TPQQJkILkT3wqYs4ftg0ZkR9qfACsxL9bRDWp17T+cDZfLbPVSyKwth90t4WN+TI4CmGry8L8aa0GjcwFrnvkG7PtgfqvgEPwnrFwjcWK9jJKaqUOce0nu9Bye7PysmXFJcHF9fHbqwOaWbbnUDkRyYgmU+9S3GHNR4hLDzCzdLCmcHeIdh3CRDPh80iRXpN7geC4akB74gY/eLOcs/efPaPDHMpf+xWTA== X-OriginatorOrg: ti.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 15 Sep 2026 09:56:24.9673 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: c7ca37aa-9703-481e-d402-08df130f9ab5 X-MS-Exchange-CrossTenant-Id: e5b49634-450b-4709-8abb-1e2b19b982b7 X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=e5b49634-450b-4709-8abb-1e2b19b982b7;Ip=[198.47.23.195];Helo=[lewvzet201.ext.ti.com] X-MS-Exchange-CrossTenant-AuthSource: LV8PEPF00000066.namprd03.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: SJ1PR10MB5906 X-Authority-Analysis: v=2.4 cv=P9yvFSAu c=1 sm=1 tr=0 ts=6aa9164f cx=c_pps a=ScYCyfYCeG8NXYeL6jRcjA==:117 a=f+v6EHfkeJbVwR46tk4DMg==:17 a=6eWqkTHjU83fiwn7nKZWdM+Sl24=:19 a=IkcTkHD0fZMA:10 a=VdqzKS8jKosA:10 a=s63m1ICgrNkA:10 a=V5UXEbMT0ywA:10 a=VkNPw1HP01LnGYTKEx00:22 a=Z8NIEmU8O1QQgoT56wFK:22 a=jwouBfj2j3NM8CExmVVE:22 a=sozttTNsAAAA:8 a=RRP3fSzFpKSzbr2H2cAA:9 a=QEXdDO2ut3YA:10 X-Proofpoint-GUID: 5fvQAiL07mBJsVkzv3RHATfKD3IiGM2H X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwOTE1MDE0MyBTYWx0ZWRfXwXgwtSyIERwW BwyKFW8nTkL7Erz+4Fpdu+LpcR34rvdTfyPh6yYl9KrhXfqYq3bOebdgAz6GSz8UsFptIeS5vKk vsWHKX2NViMPk8rD36jihq4YqDsJJJ5SD/Q+2YBcgRTCy0y35qOGH0baATu03fnvMjnenXzMwHo 2ccUYsXV6TfsWjkb7sAVjJVWhEVQRYglF81Xx+iq+//+yNsD3nNeTiURsqFEHcvEc2hxKyt8htq Yr3cESq1Hs/0BKCt2NjFy0osip17UriD8Jz6kha5ZQyOp22AU5YYhGUAEish8s/i/hJ0ixTa5uC 3PnO3iyblyDzjACOWvdd6xSz1tXUOPYbZiZVMZqmlO0sGKXNratgSbnC4h+CtX2IwBB/MST0xHR XM3lBCfZliqcBxGY3lZvbDkX7wvIABqNtcfya/Mu7Giu27HN4YB0zWjCNKXMEGeHuIb4q9RDIC4 HqK1a4pvq051qoQlcTw== X-Proofpoint-ORIG-GUID: 5fvQAiL07mBJsVkzv3RHATfKD3IiGM2H X-Proofpoint-Spam-Info: AW1haW4tMjYwOTE1MDE0MyBTYWx0ZWRfX9vfS8GZrqxJ5 EHxk3+a9aZ1pCm0Z/M75ditdylzx3HcwhFdatVTCLTp5V5DyTQham+I1f5LkBcpE6cCPc5/jk+1 ucI+AD8mFa67V0HAm8vmiO/iF3rFy1Y= X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1176,Hydra:6.1.134,FMLib:17.12.100.49 definitions=2026-09-15_03,2026-09-14_02,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 phishscore=0 adultscore=0 bulkscore=0 suspectscore=0 priorityscore=1501 spamscore=0 impostorscore=0 lowpriorityscore=0 malwarescore=0 clxscore=1015 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2609040000 definitions=main-2609150143 Add crypto_free_shash() call before returning the error to properly clean up the resource allocated in the previous call. Fixes: d2c8ac187fc9 ("crypto: sa2ul - Add AEAD algorithm support") Assisted-by: Sisyphus:claude-sonnet-4-6 Signed-off-by: Manorit Chawdhry --- drivers/crypto/sa2ul.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/crypto/sa2ul.c b/drivers/crypto/sa2ul.c index 9379d1271698..dcddb81dc842 100644 --- a/drivers/crypto/sa2ul.c +++ b/drivers/crypto/sa2ul.c @@ -1671,6 +1671,7 @@ static int sa_cra_init_aead(struct crypto_aead *tfm, = const char *hash, if (IS_ERR(ctx->fallback.aead)) { dev_err(sa_k3_dev, "fallback driver %s couldn't be loaded\n", fallback); + crypto_free_shash(ctx->shash); return PTR_ERR(ctx->fallback.aead); } =20 --=20 2.43.0 From nobody Fri Sep 25 12:05:54 2026 Received: from mx0b-0002e601.pphosted.com (mx0b-0002e601.pphosted.com [148.163.154.28]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 78DD8490C02; Tue, 15 Sep 2026 09:56:41 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=fail smtp.client-ip=148.163.154.28 ARC-Seal: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1789466204; cv=fail; b=AQX4D+710TU8SDnZ3+U8zKUna6M3N3MCPBV86f5qv01j0QR0SuhzPp8jWL7tYnzjGoq2Dm5SMt5BYLKAtdiD9bkyVptIttVpbtwGEEbifXSY32NBsj8b6OAGB6qHmoH5KdZDHJiOgYqpEd6dxy12MbFnJTziHax7tqCk6I8PK9Q= ARC-Message-Signature: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1789466204; c=relaxed/simple; bh=h0WywXGimDevL3nyU3/YU6gAZ6oBfYPKruZ3WjoSuQo=; h=From:Date:Subject:MIME-Version:Content-Type:Message-ID:References: In-Reply-To:To:CC; b=OJ9EFBYRxafpVtFTeQSw1IF/2GCz5fCRhalfxE8EgIFcAOZ8pwBIzd9fqXEYxyDTqoDW+/qkS3pmBEFOqxNXKTQY4mbb4axxfVa6ZhD/le+e781M5SF9sKf87yO0e3tsgNrPeRc+GTZEVIgLB7wk9s5c67vXwu2EQQ93DiWTgnI= ARC-Authentication-Results: i=2; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=ti.com; spf=pass smtp.mailfrom=ti.com; dkim=pass (2048-bit key) header.d=ti.com header.i=@ti.com header.b=nCkXa9wL; dkim=pass (1024-bit key) header.d=ti.com header.i=@ti.com header.b=G/N/R6Px; arc=fail smtp.client-ip=148.163.154.28 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=ti.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=ti.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=ti.com header.i=@ti.com header.b="nCkXa9wL"; dkim=pass (1024-bit key) header.d=ti.com header.i=@ti.com header.b="G/N/R6Px" Received: from pps.filterd (m0374956.ppops.net [127.0.0.1]) by mx0b-0002e601.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 68F9fB7g3810880; Tue, 15 Sep 2026 04:56:36 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ti.com; h=cc :content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s= proofpoint-05-2026; bh=LjQM2xNtey5RHPjupIRuYvHxEi5D7bQMDIQ0/DFoy Yk=; b=nCkXa9wLphK3o0VEmPRz7TX5gGq/emQ3TkFXmvf1bgBuEQjs3GbUlIeSe fmK8ERufCztRX2kgNj1tPOWWZnCgPDbXamhH7DuNKb5bDCtoRBsZVHMDxTYbPUBd 4CKO74fjzw3xDydgwlSzW3BmrTPjG2j7jvl8Uz1TDvHegPTbl21sUDgwE4rrqg6f J0EGUmaWHsTVC6Vp7QDvDhpSlv2k41ohU66eHTlzpuflz/XvPz3ZynZY1digml6I lOVagAFtk2o7zTUBB/wNKq0BHSHMFrwkbaxDakRrq4EcUoKMlCuUhSQKC4+tvF8a AUXGZPhhc63yEhw0muMFZY/aiLQvA== Received: from bl2pr02cu003.outbound.protection.outlook.com (mail-eastusazon11011035.outbound.protection.outlook.com [52.101.52.35]) by mx0b-0002e601.pphosted.com (PPS) with ESMTPS id 4gq362r9xq-1 (version=TLSv1.3 cipher=TLS_AES_256_GCM_SHA384 bits=256 verify=NOT); Tue, 15 Sep 2026 04:56:36 -0500 (CDT) ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=qDFk++H4sa0D3y9hA9AQUl+QgOHPJ/Hb3FA38GYE9sGr3w7GmRnKuiHHZVOtNtegXp73SdJxLSvxYpj7yjM6qBCQA71g53QboDvE0L/7IOh195egUvCXVSfwRcHU/1sLeMvdXzLxcKA/p043UatQqYC1hjxRrq/gh6PR5nGpD1pjK0WqD+65KlTq6JtAhWJdtoDBZPVUl8hNyxwaOQ1zrBN054tae5y3S7W7pz759qpXFONrr4Fk693gHpmKeAgyHJAENHm6FSvLeu6+BqiT4Q5RB1fAcmsrYb/4CCltA16B83FjiMvLrZkQhAdK9BuQLIkG0XTUiIGsBmFvM5R8PA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=LjQM2xNtey5RHPjupIRuYvHxEi5D7bQMDIQ0/DFoyYk=; b=fWyW85Io6ZhUHUqmZFZlX7u6AM8JZ01m1jFjcZbxXjqnbGqMoHkDeXPp7VfQ5EZ5foRHZH7WPoqFYbk4SHSl/oe2pnCmm1pZmf9g/3ZuX87ekuqJwPtXPOQ0W62IFam6Tt++veUOs0X+2ciAJ7p8tZoaAnQlSDdYgbWR3nqBNjyOy624vrhT/0wTtni5KDx2sIcFe3xWzuzLtO5rY2dpPFDZ3Taz6kbqyC41H32eBp3P9V4TtTrEKBKTN20jqdFYsYwA3uDHexJ9wOXNwDvTixC7Yzom9x9UNRM/fDHVq9lsYUTtMQLuYlvS7GdLu9SCQ0e+g1dTqHtnYFaTSpQFIg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 198.47.23.194) smtp.rcpttodomain=vger.kernel.org smtp.mailfrom=ti.com; dmarc=pass (p=quarantine sp=none pct=100) action=none header.from=ti.com; dkim=none (message not signed); arc=none (0) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ti.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=LjQM2xNtey5RHPjupIRuYvHxEi5D7bQMDIQ0/DFoyYk=; b=G/N/R6PxEkVGmBQeYLjPY80FIyG+92hRSLdWm9/1sOJo9HJk8qSyO+6OoE18pJSphKKR8fvUnxfg93R/gbkLR8kLe8dIprePE1FlgtYvm0P4r4YjqNSsq7KTPVp8oPEQqJOp5Wha/29XbhYN/vRVB2jk644FyuBkF9XyOSBY1Wg= Received: from BN9PR03CA0221.namprd03.prod.outlook.com (2603:10b6:408:f8::16) by DM3PPFBBE6F5DB9.namprd10.prod.outlook.com (2603:10b6:f:fc00::c45) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.21.428.9; Tue, 15 Sep 2026 09:56:29 +0000 Received: from BN2PEPF0000449F.namprd02.prod.outlook.com (2603:10b6:408:f8:cafe::32) by BN9PR03CA0221.outlook.office365.com (2603:10b6:408:f8::16) with Microsoft SMTP Server (version=TLS1_3, cipher=TLS_AES_256_GCM_SHA384) id 15.21.406.12 via Frontend Transport; Tue, 15 Sep 2026 09:56:29 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 198.47.23.194) smtp.mailfrom=ti.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=ti.com; Received-SPF: Pass (protection.outlook.com: domain of ti.com designates 198.47.23.194 as permitted sender) receiver=protection.outlook.com; client-ip=198.47.23.194; helo=lewvzet200.ext.ti.com; pr=C Received: from lewvzet200.ext.ti.com (198.47.23.194) by BN2PEPF0000449F.mail.protection.outlook.com (10.167.243.150) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.21.428.7 via Frontend Transport; Tue, 15 Sep 2026 09:56:29 +0000 Received: from DLEE207.ent.ti.com (157.170.170.95) by lewvzet200.ext.ti.com (10.4.14.103) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.2562.45; Tue, 15 Sep 2026 04:56:14 -0500 Received: from DLEE209.ent.ti.com (157.170.170.98) by DLEE207.ent.ti.com (157.170.170.95) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.2562.45; Tue, 15 Sep 2026 04:56:14 -0500 Received: from lelvem-mr06.itg.ti.com (10.180.75.8) by DLEE209.ent.ti.com (157.170.170.98) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.2562.45 via Frontend Transport; Tue, 15 Sep 2026 04:56:14 -0500 Received: from uda0497581-ant.dhcp.ti.com (uda0497581-ant.dhcp.ti.com [10.24.51.159]) by lelvem-mr06.itg.ti.com (8.18.1/8.18.1) with ESMTP id 68F9tB883000901; Tue, 15 Sep 2026 04:56:11 -0500 From: Manorit Chawdhry Date: Tue, 15 Sep 2026 15:25:24 +0530 Subject: [PATCH 18/30] crypto: sa2ul - fix DMA mapping leak in sa_run() error paths Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-ID: <20260915-b4-upstream-sa2ul-cleanup-v1-18-57ab34e97162@ti.com> References: <20260915-b4-upstream-sa2ul-cleanup-v1-0-57ab34e97162@ti.com> In-Reply-To: <20260915-b4-upstream-sa2ul-cleanup-v1-0-57ab34e97162@ti.com> To: Herbert Xu , "David S. Miller" , Keerthy , Colin Ian King CC: Andrew Davis , Pratham T , "Kamlesh Gurudasani" , Udit Kumar , , , "Manorit Chawdhry" X-Mailer: b4 0.15.2 X-Developer-Signature: v=1; a=ed25519-sha256; t=1789466112; l=1457; i=m-chawdhry@ti.com; s=20231127; h=from:subject:message-id; bh=h0WywXGimDevL3nyU3/YU6gAZ6oBfYPKruZ3WjoSuQo=; b=/m/fv3ZOs3REGTtKov0pxeL7Alwr6rTpYpjoEFi7QBMQhF41Xtb1jJ2mmjuXHiq+ZoUcX1n0p MTWKEg6Fm1sBXHJWqiMLCOY6to5o1pwUwS2Uaw2mDwbz6ZGbuvxWBYO X-Developer-Key: i=m-chawdhry@ti.com; a=ed25519; pk=fsr6Tm39TvsTgfyfFQLk+nnqIz2sBA1PthfqqfiiYSs= X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: BN2PEPF0000449F:EE_|DM3PPFBBE6F5DB9:EE_ X-MS-Office365-Filtering-Correlation-Id: 89f798c0-1748-4e5e-3a1c-08df130f9d6c X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|36860700016|376014|23010399003|1800799024|82310400026|10067099003|56012099006|18002099003|22082099003; X-Microsoft-Antispam-Message-Info: BnNzFvdGdxbh5aMRov/EfTew884xSTcHSZZ1b1pT83tAEFnXigEoygTCiCy7wC/AZUXYVXxTTVTLAQjhAJjuozcOKOp7R9mHdbWbv5uuVezFzKjDaK6ORmkWwUF3rAOoQWcFFarpKp4/2FzhJa4hT/SDqkQxnhhw3d+q0IO2gTNkyTacwWjY0oe9YkdB9SjuPC0qobONU/LVjDCVufL8XBnU4dEBMdpxC1KOgUSxP8qiVCB4HTDqVYRDBroPw1YcuEKbO+pc6wGNg7wu6AHctysLJNwabUjVGY/SUkFSclcAjrNB4X0lSQZdyG1jBjFCxGA9/s+I1lM41FXfyI4GfD2K40bk9MTcPbS05jFVXTwej3tCjKBtLNRstFmCYT7SD2roa6RjDo7oCrl4YrP6Z9RwVhAF79x0VPvLhhPU6wTXLORegBiAccesPb5lrQlIGdDi7EtNrsLKoG6HfxIAEjnVTYzFt0dmKytpgsKrsqRIDLdrKkx6f8VrKXfVbeKWwFveajKKmi4jVOh78380sgSZtEofDU8H5Fzah6wIxjPhLxLU+iDUQ4zLLueDgRa17cLDnJs9cEvK/Ra7zvO8CqIlCroOeX8PZc8XKKkDKbWZHU8Sb1EwdsnRiikMHxqWiY2HsqB627b4pP+Zgk3VjkFLzFaL5EavyKgJg+9V41tkouow3LzrCGefiomnY90yIwD4/rx1236htLPwbRz+6Q== X-Forefront-Antispam-Report: CIP:198.47.23.194;CTRY:US;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:lewvzet200.ext.ti.com;PTR:InfoDomainNonexistent;CAT:NONE;SFS:(13230040)(36860700016)(376014)(23010399003)(1800799024)(82310400026)(10067099003)(56012099006)(18002099003)(22082099003);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: NkFqlLm3eiMpHV0nkufc4XFo+XSAmEbRgpBvkDRZL/0JScP9arU/9iyMBpiEyVLOb+CV4CsJIGr1Yts9yz+R8nwCokk6swZFanAxVScKtjXX8iL0XKWZITbvG6lq7TRiahMXw/quljIi4JpY8UofT9soTXYoqMDcdkkiixmiL9L0GE+KGIhB7ahmIMjp2ZCBTpsUBDrkUIFHW8gwRP9+UzYwUyjpA6ojqbcVudWvgv8nucuekEOFQMjsc8fOgfagAzqeGRoPhfDx9d3NysDcIQ3RQ03GfxUbhK/rzFMR90QDirtMbi5u9hVpur2mTWiuE+AYCl7p6S70uCgMHHkZivylpe321SFl6Gpn/v7x+J4FTEj70AMfx6Opr5dGP+KgqCJq3jpRdZBBRaT1iM0VXjigttsIysmBs0usSalgxZnBFs0etktVda/AHdyaciLu X-Exchange-RoutingPolicyChecked: Hi0WxIux1VF56gZZZCNfOD23iilKSGTl3ufp9Li9wW/ThK/3yZrZCRXs8snqvrJTdsCArf0H81xqmmIxPWH+e8lTQmYZfjS+y7M/scFeQGcFIDwJzUjg+NoTuAu3RvaENKUxokA3k8LqgXDGm8+mSosSrqcEiyKFWeUvcx3EKJ3YoU3jEDc+blU6txU2BJY2Sf3h1DlM6CQZwgHTkFyshop/Ik/+73sSXt5xSgKnQLlBdz+cP4mN85xIUkrR68k8Aidyox9S2vInDQGNIg5B5WYf/hUtAWVRUAIkWez9mnl3Dg/5eygwOH3ebQvrnFwpinWDeQ2WDjdjJGg8gLXj8g== X-OriginatorOrg: ti.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 15 Sep 2026 09:56:29.5077 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 89f798c0-1748-4e5e-3a1c-08df130f9d6c X-MS-Exchange-CrossTenant-Id: e5b49634-450b-4709-8abb-1e2b19b982b7 X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=e5b49634-450b-4709-8abb-1e2b19b982b7;Ip=[198.47.23.194];Helo=[lewvzet200.ext.ti.com] X-MS-Exchange-CrossTenant-AuthSource: BN2PEPF0000449F.namprd02.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM3PPFBBE6F5DB9 X-Authority-Analysis: v=2.4 cv=P9yvFSAu c=1 sm=1 tr=0 ts=6aa91654 cx=c_pps a=2EogD3SZGC0twO92opjmhQ==:117 a=WotqVVQAdb04rnGuttW3Kw==:17 a=6eWqkTHjU83fiwn7nKZWdM+Sl24=:19 a=IkcTkHD0fZMA:10 a=VdqzKS8jKosA:10 a=s63m1ICgrNkA:10 a=V5UXEbMT0ywA:10 a=VkNPw1HP01LnGYTKEx00:22 a=Z8NIEmU8O1QQgoT56wFK:22 a=jwouBfj2j3NM8CExmVVE:22 a=sozttTNsAAAA:8 a=_O0z_oWXeRW8WQ6wGaAA:9 a=QEXdDO2ut3YA:10 X-Proofpoint-GUID: mPiGiPQyCYTOzdhixSHCbSftMtXw3Fj_ X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwOTE1MDE0MyBTYWx0ZWRfX/Al31vMZI6im rnivseCmZx2rmGaMbQjE6DZ2R3jgs5oD6byepD/rARhXerInpvrIDy1h2SxH79a7Fy0WFdcCUnv P0HQUhkxr6K84NhV0599Dq/Cy1ZIMFzmq4736sVAO4L8/oPjS6ba0+eZSUM2cPVYpJTtj/0vyWl zYB+00AT2q4Qxirg5SSfGCTmmLM8KR7eGD/5KGFcjiadxfZ15SJRhd3sI1VQJF9DaOH4+kN5xOw 9b+SOMVc+a0jcZjUxXdJ2hsHoLiPr5DgxNImhMao49hUCfaYOaZsbqD2/B3aKiKLA1keyMNIEhk 1ZB68aO8Wqa91KCG7ljKRMPzTBi/Y+Aap+vN5IxibCCH45AknEP4UVPIqJmKwCV+rmVT1pV30UB M7aXIu2fnT9ugOgRi1hODdRjfjRr2VzFe34QmSPMIER9k2Xzm6z1Drdf8qHWCEhAn+f0PT7s+dF VfQ96QNzsO+NkV3cMzA== X-Proofpoint-ORIG-GUID: mPiGiPQyCYTOzdhixSHCbSftMtXw3Fj_ X-Proofpoint-Spam-Info: AW1haW4tMjYwOTE1MDE0MyBTYWx0ZWRfX/mC2jWcaZbUX 0lb5E0tzecFZgxd00Gaw1pkhFKGFl8aaiep/r6wYSjO1fSIuXNEXkIcWC7DLHYoZLc8e0NEFcTk qRuUSRWkHgiCapJaASA/xDLugtpA9fc= X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1176,Hydra:6.1.134,FMLib:17.12.100.49 definitions=2026-09-15_03,2026-09-14_02,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 phishscore=0 adultscore=0 bulkscore=0 suspectscore=0 priorityscore=1501 spamscore=0 impostorscore=0 lowpriorityscore=0 malwarescore=0 clxscore=1015 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2609040000 definitions=main-2609150143 In sa_run(), when dma_map_sgtable() fails, the code was using kfree(rxd) directly instead of sa_free_sa_rx_data(rxd). This is problematic because if an earlier DMA mapping succeeded, it won't be unmapped, leading to a DMA resource leak. The sa_free_sa_rx_data() function properly checks the mapped flag and unmaps any successfully mapped buffers before freeing the rxd structure. Replace kfree(rxd) with sa_free_sa_rx_data(rxd) in both early error paths to ensure proper cleanup of any partial DMA mappings. Fixes: 854b77371998 ("crypto: sa2ul - Fix memory leak of rxd") Assisted-by: Sisyphus:claude-sonnet-4-6 Signed-off-by: Manorit Chawdhry --- drivers/crypto/sa2ul.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/crypto/sa2ul.c b/drivers/crypto/sa2ul.c index dcddb81dc842..cc9f2881efda 100644 --- a/drivers/crypto/sa2ul.c +++ b/drivers/crypto/sa2ul.c @@ -1131,7 +1131,7 @@ static int sa_run(struct sa_req *req) mapped_sg->sgt.orig_nents =3D src_nents; ret =3D dma_map_sgtable(ddev, &mapped_sg->sgt, dir_src, 0); if (ret) { - kfree(rxd); + sa_free_sa_rx_data(rxd); return ret; } =20 @@ -1142,7 +1142,7 @@ static int sa_run(struct sa_req *req) mapped_sg->sgt.orig_nents =3D sg_nents; ret =3D dma_map_sgtable(ddev, &mapped_sg->sgt, dir_src, 0); if (ret) { - kfree(rxd); + sa_free_sa_rx_data(rxd); return ret; } =20 --=20 2.43.0 From nobody Fri Sep 25 12:05:54 2026 Received: from mx0a-0002e601.pphosted.com (mx0a-0002e601.pphosted.com [148.163.150.75]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id ED3684963D1; Tue, 15 Sep 2026 09:56:45 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=fail smtp.client-ip=148.163.150.75 ARC-Seal: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1789466208; cv=fail; b=Zw48pC/SSGiiPxBqvO7Iz7yt/e4pQT1s0Jq9NdAcz+EkI+S0hriV17BnRNtUTksbz/ycVendYxi7oyK3QM3nGhx6a5GyEDLkkuufShLDBGaIz16DKazOCENvX7k0a5M7ngfYOQd0jlSASXskCJxhZ4rDAGIRyOiFTxqlzc9T38U= ARC-Message-Signature: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1789466208; c=relaxed/simple; bh=oWMtxN1/gD2kQoX7CeePf7DmmmtGpiRB0m/PrSh3XM8=; h=From:Date:Subject:MIME-Version:Content-Type:Message-ID:References: In-Reply-To:To:CC; b=RrvpWW4h9XL2XkfVyhIL+HK+v04A8HEVzRvxmQaJHqiptduiQg3AnxrQtB4S1dBTTVonJ/OlJVN7sz3SuYM5Eid9dY0tRg4bY1svg4GCLtUIV8hamzViMgNKdF/AFt2KPtV2BX1NkSHYV4vvzOxUQ66n/sNm8n/WSIaTsMahAjc= ARC-Authentication-Results: i=2; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=ti.com; spf=pass smtp.mailfrom=ti.com; dkim=pass (2048-bit key) header.d=ti.com header.i=@ti.com header.b=PjTa166V; dkim=pass (1024-bit key) header.d=ti.com header.i=@ti.com header.b=QO1pyqOO; arc=fail smtp.client-ip=148.163.150.75 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=ti.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=ti.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=ti.com header.i=@ti.com header.b="PjTa166V"; dkim=pass (1024-bit key) header.d=ti.com header.i=@ti.com header.b="QO1pyqOO" Received: from pps.filterd (m0380145.ppops.net [127.0.0.1]) by m0380145.ppops.net (8.18.1.11/8.18.1.11) with ESMTP id 68F9er543889296; Tue, 15 Sep 2026 04:56:42 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ti.com; h=cc :content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s= proofpoint-05-2026; bh=ZP2XJY9k7f0ffWq7FVpHtK+X9lyZQYEKpZaFoJs0o PI=; b=PjTa166V7/4Y0QdcJO3RoFr+jaDpzOXCJCnYCQ8Ghn0A4rQq2oc4AM8Gv ROHn7nEDVqHvt+IpIcPQzApfoq9ZMf4X94nTq+lda/pbyvAQBOzTlgOg8V/zM4wO IpSAXPjm2ZIyPUNrt6ZY3ZMsVAvU2vO7oiZh+pW4HX83QjyXlsm3ycr84P3qYVqG 6gaIqjMlKjCCQdUErvEinJkNqZgT7BimOUkOH/qxvGw1cy2Do5kPRcO+AjDTiKIn lMUL31fgPdK6MTM2PRt/+g392H0w9RSJ+1Im3Hc75JJ+yarNCePXaDipDMrH+YX0 4h6u3lGHL1+MieRNBSmlvRpMVBELA== Received: from byapr05cu005.outbound.protection.outlook.com (mail-westusazon11010043.outbound.protection.outlook.com [52.101.85.43]) by m0380145.ppops.net (PPS) with ESMTPS id 4gppxsm9hc-1 (version=TLSv1.3 cipher=TLS_AES_256_GCM_SHA384 bits=256 verify=NOT); Tue, 15 Sep 2026 04:56:41 -0500 (CDT) ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=e0Ne+CUAy8sxUKzzE7Jwchiys8rY/rHQ/Ll2DZRUy7bbpHNmIiEruZJph0rxI2vkTv6iMixiIdSehP+GDOcNH/OLB0Yoc4tcR5au5xN1Iyf9LS+S9xH7SOGJU0SjqzLfgfu+9QwBFH8YgVGO76YRjENTgknFuwSZGbiBspavJjEN7YphRDMI+fkcwhzqLJlGCuuXWcvt1n9YJ4MvIbZqlZIrLXTvl2Nh/+Vv6VJQoLP4vAl3hWeHefQQWN8NPrJjH2XndX4ZPPJrV2Z1EpNYFnXr66dV2/PGOHABDWHomFOLG8PvolYv7WLY1tKP9M/Q+xy2YEWjyz327fR/sn1YMg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=ZP2XJY9k7f0ffWq7FVpHtK+X9lyZQYEKpZaFoJs0oPI=; b=xBPYW8DzMwQtD1/kRsaCcohlmAPRgLhdNo5IHzO+LppkoPCvPiBl8qOmrIUkW+hzWSYRaIsSKfNacO6tsoqRmVEuxcd464gFCltvcD2udCO440RxFtrZvQ3MHgdTqmvYaQas0BNENPGqTITlfo7M9tAywDgxIuh3aD1TNMEH8HrZjmEFoYxn34PN3mcPEQPEE1LgL31xomDIs7GQ+hUOO46CF+2eLqJBI4E+3ZKUEbEVWwK7ozwPuEuxs8oHIomWoHGWxOHAbaBPnhRsfA43rqJm5MZn8sDp9hyvjqeuSwQToOzHolr+E3BNKCMv4NCWOquZN1meVW5tGj9+gu8dLA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 198.47.23.194) smtp.rcpttodomain=vger.kernel.org smtp.mailfrom=ti.com; dmarc=pass (p=quarantine sp=none pct=100) action=none header.from=ti.com; dkim=none (message not signed); arc=none (0) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ti.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=ZP2XJY9k7f0ffWq7FVpHtK+X9lyZQYEKpZaFoJs0oPI=; b=QO1pyqOO3+02OezGtZuBCi5VLKS9AYsAG2k6u8zcpKe+TwT7CcQrBpHe7XzqkipBftf2c6LkUdjLg+ILZAmKjbyi3qqIgynaREFnLeu4aLy0ZN3tMfz2YbsaKNoKaKQc9yqGRAfcPN55RoYnhuWnbVZfPcWkqX/0dcJmWhNmgWs= Received: from BN9PR03CA0239.namprd03.prod.outlook.com (2603:10b6:408:f8::34) by MW5PR10MB5666.namprd10.prod.outlook.com (2603:10b6:303:19b::21) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.21.428.7; Tue, 15 Sep 2026 09:56:35 +0000 Received: from BN2PEPF0000449F.namprd02.prod.outlook.com (2603:10b6:408:f8:cafe::e) by BN9PR03CA0239.outlook.office365.com (2603:10b6:408:f8::34) with Microsoft SMTP Server (version=TLS1_3, cipher=TLS_AES_256_GCM_SHA384) id 15.21.406.12 via Frontend Transport; Tue, 15 Sep 2026 09:56:34 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 198.47.23.194) smtp.mailfrom=ti.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=ti.com; Received-SPF: Pass (protection.outlook.com: domain of ti.com designates 198.47.23.194 as permitted sender) receiver=protection.outlook.com; client-ip=198.47.23.194; helo=lewvzet200.ext.ti.com; pr=C Received: from lewvzet200.ext.ti.com (198.47.23.194) by BN2PEPF0000449F.mail.protection.outlook.com (10.167.243.150) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.21.428.7 via Frontend Transport; Tue, 15 Sep 2026 09:56:34 +0000 Received: from DLEE213.ent.ti.com (157.170.170.116) by lewvzet200.ext.ti.com (10.4.14.103) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.2562.45; Tue, 15 Sep 2026 04:56:17 -0500 Received: from DLEE212.ent.ti.com (157.170.170.114) by DLEE213.ent.ti.com (157.170.170.116) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.2562.45; Tue, 15 Sep 2026 04:56:17 -0500 Received: from lelvem-mr06.itg.ti.com (10.180.75.8) by DLEE212.ent.ti.com (157.170.170.114) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.2562.45 via Frontend Transport; Tue, 15 Sep 2026 04:56:17 -0500 Received: from uda0497581-ant.dhcp.ti.com (uda0497581-ant.dhcp.ti.com [10.24.51.159]) by lelvem-mr06.itg.ti.com (8.18.1/8.18.1) with ESMTP id 68F9tB893000901; Tue, 15 Sep 2026 04:56:14 -0500 From: Manorit Chawdhry Date: Tue, 15 Sep 2026 15:25:25 +0530 Subject: [PATCH 19/30] crypto: sa2ul - generate dynamic metadata length Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-ID: <20260915-b4-upstream-sa2ul-cleanup-v1-19-57ab34e97162@ti.com> References: <20260915-b4-upstream-sa2ul-cleanup-v1-0-57ab34e97162@ti.com> In-Reply-To: <20260915-b4-upstream-sa2ul-cleanup-v1-0-57ab34e97162@ti.com> To: Herbert Xu , "David S. Miller" , Keerthy , Colin Ian King CC: Andrew Davis , Pratham T , "Kamlesh Gurudasani" , Udit Kumar , , , "Manorit Chawdhry" X-Mailer: b4 0.15.2 X-Developer-Signature: v=1; a=ed25519-sha256; t=1789466112; l=4700; i=m-chawdhry@ti.com; s=20231127; h=from:subject:message-id; bh=oWMtxN1/gD2kQoX7CeePf7DmmmtGpiRB0m/PrSh3XM8=; b=B9spH3iPZoT1hUuYLardGG53dbrLWlCYcOLYdkBQ+t/HZW9xPePfcyo8ivh/JZ93+TotQftTN U9vJtfA7q1iCO+Bseop7HjDgIxkBXcRl5oCHYAtG4dN1+Nbn7uPidM6 X-Developer-Key: i=m-chawdhry@ti.com; a=ed25519; pk=fsr6Tm39TvsTgfyfFQLk+nnqIz2sBA1PthfqqfiiYSs= X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: BN2PEPF0000449F:EE_|MW5PR10MB5666:EE_ X-MS-Office365-Filtering-Correlation-Id: 726db987-cfe4-4ad4-2608-08df130fa08b X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|36860700016|376014|23010399003|82310400026|1800799024|56012099006|10067099003|22082099003|18002099003; X-Microsoft-Antispam-Message-Info: O4duBdsbgXzNhzghtMtPQGbTQw9hVIMWwehYTtxKBT4CDyGsOMNmHBftWog316NsAduLaw4Y0YWl1aXmsUimUlIhMTkSi+6HMSTZOHcCi6anFpr0zaB46CU2lQybanrH+BQ0gTFr2MXnh5QKOvr1pgk+K4NNHN/RQmuXLs0GPyXPMGnnFiPMs4Mycz+KF/xLTTYgFE79ByqaNjN7VaFgf1LhlMsGEIn1/DbgrKWzLtI/2KaDGMSTQEqq+NFbEG0vCxcK83LUiVQi9VEo3P4Hq/eNx+MJ3k6YLRtE96D7n0AQObREZ+9HQ62iXQhVZFfR768yxlIeFdRO32VgHhImuDmlF+uesabNYsT5zXd4YGbKZ3l6AhG+omY/SBgMyDbXX8R8bTHO44w21t88E24AjHyjKAerNvzBLhvIHAke40mtBFmClctWpmj2kydCGOOuDmUpS4Vg8c2+gZuouSk6pkwjc25w4m4ogvk9PIW9wdb6fWlelCc6RYX4goo2pWF17/zdaxKBeC8WFokmXwYuErl37pHbBikJmbmQWoyjEQcSkmdN4BoIIwQFKMmaw8BrdxtIy3BewtpGzfkHjgseAWrcZ1pkqqxoUUi7I5xBppzlH+c2ECjhPGvCuZYRzuv190eZNbIVxsrnndNMua6hN7mPZub8a/jOTMEdqjhrtsDWnqCTASBpW5iSkCJUsdI+ X-Forefront-Antispam-Report: CIP:198.47.23.194;CTRY:US;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:lewvzet200.ext.ti.com;PTR:InfoDomainNonexistent;CAT:NONE;SFS:(13230040)(36860700016)(376014)(23010399003)(82310400026)(1800799024)(56012099006)(10067099003)(22082099003)(18002099003);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: oJYZ3IMGw4TwFZPUq8EYmrPcQJcHM3LHqKzRQQ1oVzebgYtUr9PdBtxsbbnEyFbYaYQFqBs+85vBvupThz9Rxx7w/kB0zYcFEPRdN4PF0Mb6rKE+qabUzDCyzaKGNfXPZX4TKqMCvV1Foxo08vki6+Jnubo2re2R8GOCugiF1uqcmDr3cAfKzLYXCWM8qQW6iBhEupuVJ5Rcmi/zofVeijjl18RLPUfvusA0bnFmyeYKBkrI8QTCOBOdfpKVcqqvDpIy3/XRM7MBjj9jCt5MwZE7pbbl9CH4aVlpoZlPiqc2nerSj1w4B8n5YPm0k1niuKzqmEyCRxzsNgp3FOYPPjk1xyz3Ugbatqm2opL0sxV6/izLIV9wCDrl+PKo8MlZdNnU79lQNfzIYPyBRj5+DasNzQZuKQHiN+O9HwyqbS2mqTUGsxsYcEuyy8K3Zcmq X-Exchange-RoutingPolicyChecked: CoUR3ohYfYNdjVSsR6VGIRlPn9J+6eSJ77r44rWOWZp3gmLq+FyUF3huGXp03qQbxfCgTaCq5YHSPT4EPrzsJI39/cZRHw0ZjgR3ZnBPmM2pqk9o7zdCy2NztrZHVjKjTXXM1gL6s+RSjCJ9Oq680fnhhM1nte2aq/Wn8zjQm2ZIevDAWopAqJph0G75j5isc5DUTSY98k/AhXXI8tHv7xgG6Ypui6P5+C940lc6UUyRYbcdGsgxsk5BPUhYNZe+PDa/jXmop0sUEHdLpaKGsPzuvPkJJihzI8wBzMhT1ycfgDT0GbKgAUrmWwt05OrhPwYmcTzmw/IP0ro28+MenQ== X-OriginatorOrg: ti.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 15 Sep 2026 09:56:34.7421 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 726db987-cfe4-4ad4-2608-08df130fa08b X-MS-Exchange-CrossTenant-Id: e5b49634-450b-4709-8abb-1e2b19b982b7 X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=e5b49634-450b-4709-8abb-1e2b19b982b7;Ip=[198.47.23.194];Helo=[lewvzet200.ext.ti.com] X-MS-Exchange-CrossTenant-AuthSource: BN2PEPF0000449F.namprd02.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: MW5PR10MB5666 X-Proofpoint-GUID: dBdmXqtRRpU8G3qoS6uJ4zBDV4SgHqnG X-Proofpoint-ORIG-GUID: dBdmXqtRRpU8G3qoS6uJ4zBDV4SgHqnG X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwOTE1MDE0MyBTYWx0ZWRfX2tseZUvxnnUF 4kxXEr4PcJWKFzu9ezKtj4xr4cw7IWZfNNqwNW55dFtN2xfugoyukWQz6NAh86UOMUUGuoFsIy8 Qhy4kOICF948IyDur9rUx5XambukhghC8xMwuIX99APDCqOABrn0svkSiiCX4ZcT+k07k4hsyp7 s49W190nQkWy3mf7zFbQAxiwKABYp5TjS62Y7GxzLRUzecAvxzgmX0xpr13UhTGMrYxLMikxviJ H0TOnvwIVMPc8wHHGGru8+PN04NYWpBnTcOs4FJFIr6QnCb+/j58UVWvtMqe3NXwhfXg2un+r45 xkkany44vx1N6PfPgdypslmhx5BpgPAsTjOykFBJftVaMrVidKacdB+c3PW2+l+VQAvCKpsQUAw LcORDW0eBKO9fznekjPNm1s+IW9f1xgC94ImA5EfrFoKSjJGdDAkUdujW/tKn64WzDM7p+mcLI6 Anobr85MurVDfVpFtvg== X-Authority-Analysis: v=2.4 cv=bYP+w+PB c=1 sm=1 tr=0 ts=6aa9165a cx=c_pps a=630MGKGvePsHimlcG8SYgw==:117 a=WotqVVQAdb04rnGuttW3Kw==:17 a=6eWqkTHjU83fiwn7nKZWdM+Sl24=:19 a=IkcTkHD0fZMA:10 a=VdqzKS8jKosA:10 a=s63m1ICgrNkA:10 a=V5UXEbMT0ywA:10 a=VkNPw1HP01LnGYTKEx00:22 a=Z8NIEmU8O1QQgoT56wFK:22 a=gO1vWkAQAl3rybz1DQOp:22 a=sozttTNsAAAA:8 a=iV7YQO2jEIXJtVvt9CkA:9 a=QEXdDO2ut3YA:10 X-Proofpoint-Spam-Info: AW1haW4tMjYwOTE1MDE0MyBTYWx0ZWRfX8oPYgCxP8MOR 5VDv9tyj2avq+5zq/Oo1yzGCsoGL29tce5A/rU+lTr4NoxbwMrA503nPWpv11RzD73wQb+EwvaC 1AopSO8nEwprumHHNbXC240Oy5R8hHg= X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1176,Hydra:6.1.134,FMLib:17.12.100.49 definitions=2026-09-15_03,2026-09-14_02,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 clxscore=1011 lowpriorityscore=0 priorityscore=1501 impostorscore=0 adultscore=0 suspectscore=0 phishscore=0 malwarescore=0 bulkscore=0 spamscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2609040000 definitions=main-2609150143 Calculate metadata length dynamically based on actual algorithm requirements instead of using a fixed value and remove the code that is not in the spec and not required to be passed to sa2ul. Aligns the index as well after the removal of those extra bytes. Assisted-by: Sisyphus:claude-sonnet-4-6 Signed-off-by: Manorit Chawdhry --- drivers/crypto/sa2ul.c | 25 +++++++------------------ drivers/crypto/sa2ul.h | 23 +---------------------- 2 files changed, 8 insertions(+), 40 deletions(-) diff --git a/drivers/crypto/sa2ul.c b/drivers/crypto/sa2ul.c index cc9f2881efda..a60b968c21f3 100644 --- a/drivers/crypto/sa2ul.c +++ b/drivers/crypto/sa2ul.c @@ -956,7 +956,7 @@ static int sa_3des_cbc_setkey(struct crypto_skcipher *t= fm, const u8 *key, =20 ad.mci_enc =3D mci_cbc_3des_enc_array; ad.mci_dec =3D mci_cbc_3des_dec_array; - ad.iv_idx =3D 6; + ad.iv_idx =3D 4; ad.iv_out_size =3D 8; =20 return sa_cipher_setkey(tfm, key, keylen, &ad); @@ -1028,7 +1028,7 @@ static void sa_aes_dma_in_callback(void *data) skcipher_request_complete(req, 0); } =20 -static void +static int sa_prepare_tx_desc(u32 *mdptr, u32 pslen, u32 *psdata, u32 epiblen, u32 *e= pib) { u32 *out, *in; @@ -1041,6 +1041,8 @@ sa_prepare_tx_desc(u32 *mdptr, u32 pslen, u32 *psdata= , u32 epiblen, u32 *epib) for (out =3D &mdptr[5], in =3D psdata, i =3D 0; i < pslen / sizeof(u32); i++) *out++ =3D *in++; + + return epiblen + sizeof(u32) + pslen; } =20 static int sa_run(struct sa_req *req) @@ -1097,16 +1099,6 @@ static int sa_run(struct sa_req *req) =20 sa_update_cmdl(req, cmdl, &sa_ctx->cmdl_upd_info); =20 - if (req->type !=3D CRYPTO_ALG_TYPE_AHASH) { - if (req->enc) - req->type |=3D - (SA_REQ_SUBTYPE_ENC << SA_REQ_SUBTYPE_SHIFT); - else - req->type |=3D - (SA_REQ_SUBTYPE_DEC << SA_REQ_SUBTYPE_SHIFT); - } - - cmdl[sa_ctx->cmdl_size / sizeof(u32)] =3D req->type; =20 /* * Map the packets, first we check if the data fits into a single @@ -1239,9 +1231,9 @@ static int sa_run(struct sa_req *req) */ mdptr =3D (u32 *)dmaengine_desc_get_metadata_ptr(tx_out, &pl, &ml); =20 - sa_prepare_tx_desc(mdptr, (sa_ctx->cmdl_size + (SA_PSDATA_CTX_WORDS * - sizeof(u32))), cmdl, sizeof(sa_ctx->epib), - sa_ctx->epib); + req->mdata_size =3D sa_prepare_tx_desc(mdptr, sa_ctx->cmdl_size, + cmdl, sizeof(sa_ctx->epib), + sa_ctx->epib); =20 dmaengine_desc_set_metadata_len(tx_out, req->mdata_size); =20 @@ -1298,7 +1290,6 @@ static int sa_cipher_run(struct skcipher_request *req= , u8 *iv, int enc) sa_req.type =3D CRYPTO_ALG_TYPE_SKCIPHER; sa_req.enc =3D enc; sa_req.callback =3D sa_aes_dma_in_callback; - sa_req.mdata_size =3D 44; sa_req.base =3D &req->base; sa_req.ctx =3D ctx; =20 @@ -1398,7 +1389,6 @@ static int sa_sha_run(struct ahash_request *req) sa_req.enc =3D true; sa_req.type =3D CRYPTO_ALG_TYPE_AHASH; sa_req.callback =3D sa_sha_dma_in_callback; - sa_req.mdata_size =3D 28; sa_req.ctx =3D ctx; sa_req.base =3D &req->base; =20 @@ -1862,7 +1852,6 @@ static int sa_aead_run(struct aead_request *req, u8 *= iv, int enc) sa_req.type =3D CRYPTO_ALG_TYPE_AEAD; sa_req.enc =3D enc; sa_req.callback =3D sa_aead_dma_in_callback; - sa_req.mdata_size =3D 52; sa_req.base =3D &req->base; sa_req.ctx =3D ctx; sa_req.src =3D req->src; diff --git a/drivers/crypto/sa2ul.h b/drivers/crypto/sa2ul.h index 04669bf7fcb5..fbea98981f10 100644 --- a/drivers/crypto/sa2ul.h +++ b/drivers/crypto/sa2ul.h @@ -31,22 +31,9 @@ struct sa_tfm_ctx; #define SA_EEC_CPPI_PORT_IN_EN 0x00000200 #define SA_EEC_CPPI_PORT_OUT_EN 0x00000800 =20 -/* - * Encoding used to identify the typo of crypto operation - * performed on the packet when the packet is returned - * by SA - */ -#define SA_REQ_SUBTYPE_ENC 0x0001 -#define SA_REQ_SUBTYPE_DEC 0x0002 -#define SA_REQ_SUBTYPE_SHIFT 16 -#define SA_REQ_SUBTYPE_MASK 0xffff - /* Number of 32 bit words in EPIB */ #define SA_DMA_NUM_EPIB_WORDS 4 =20 -/* Number of 32 bit words in PS data */ -#define SA_DMA_NUM_PS_WORDS 16 - /* * Maximum number of simultaeneous security contexts * supported by the driver @@ -219,16 +206,8 @@ struct sa_cmdl_upd_info { struct sa_cmdl_param_info auth_offset; }; =20 -/* - * Number of 32bit words appended after the command label - * in PSDATA to identify the crypto request context. - * word-0: Request type - * word-1: pointer to request - */ -#define SA_PSDATA_CTX_WORDS 4 - /* Maximum size of Command label in 32 words */ -#define SA_MAX_CMDL_WORDS (SA_DMA_NUM_PS_WORDS - SA_PSDATA_CTX_WORDS) +#define SA_MAX_CMDL_WORDS 24 =20 /** * struct sa_ctx_info: SA context information --=20 2.43.0 From nobody Fri Sep 25 12:05:54 2026 Received: from mx0a-0002e601.pphosted.com (mx0a-0002e601.pphosted.com [148.163.150.75]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id D532E47A86D; Tue, 15 Sep 2026 09:57:14 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=fail smtp.client-ip=148.163.150.75 ARC-Seal: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1789466237; cv=fail; b=TRp+I8DzHOAJtNg/v7ORKZGvSic1REZ9EpPNOoOG4tdURgfdTdIgWD5X+LnIqeN3vB64PAWBL8A2OapKXFipmKNNw4BwoTI/8P3/xiRjN7Rm753RuAGLNiBCDrNa1OqtFYoUiwo6R2DZV8dAkEwUcv+8pMHsDY03b5iuuHhvvkQ= ARC-Message-Signature: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1789466237; c=relaxed/simple; bh=sL4XRV9D1NA0Br4IlhtT/3KNoJwSVL9wHsuj5r2AEoM=; h=From:Date:Subject:MIME-Version:Content-Type:Message-ID:References: In-Reply-To:To:CC; b=nKgBhjLhhPpTMTX/xnRSPy/TPC5eP2HqH2yJf05nBjr6fFv1jxrF54oKHIm9zQOoWntG9p4FNVXSaXSjNU6icuTn739LdOnYW+zRt+q9P+xcfHLD16FAuJUO9RtsfnaBOELzi2BZ+zjT+bvVwCeQy6PgP/P47SgJs6kgTR30pX0= ARC-Authentication-Results: i=2; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=ti.com; spf=pass smtp.mailfrom=ti.com; dkim=pass (2048-bit key) header.d=ti.com header.i=@ti.com header.b=VuGc7KBo; dkim=pass (1024-bit key) header.d=ti.com header.i=@ti.com header.b=QAt4C4nU; arc=fail smtp.client-ip=148.163.150.75 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=ti.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=ti.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=ti.com header.i=@ti.com header.b="VuGc7KBo"; dkim=pass (1024-bit key) header.d=ti.com header.i=@ti.com header.b="QAt4C4nU" Received: from pps.filterd (m0380145.ppops.net [127.0.0.1]) by m0380145.ppops.net (8.18.1.11/8.18.1.11) with ESMTP id 68F9esNX3889302; Tue, 15 Sep 2026 04:57:11 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ti.com; h=cc :content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s= proofpoint-05-2026; bh=TFbCitKYv9i3kJUkCLaJHMG/vBIF0b2me+WXqh6Eu NE=; b=VuGc7KBoYO/pqra6I3osKVwxl4KGy3bh4eJvqgMU0cQuiX1adyY4eAEAS jtYRhE0Ny0q57+llrWLU12XC3fxHxigN4hv4wc8a61uR4FovgOzLWQPMUAPbkT5p uu0jzUsD5MXrFtHBX7pxx+HbZHgpKlaYINMoYsCzEAMjPMg3qXN3zXOsQtIxheIW d9+8FH006MNvNznPUqWERLkcdVWKBMEX7QrobePRQnqLu2uCJDPeUIq17ZN4axdN +MIIpYbFmuEdqKwDgqrHTJp7Byorhk+sqiaGd0A9OUrafVKqcSJ5vsvJXw+j+vX+ ZEPyAUbkZOjrAXOyPLV7Q0slszsVQ== Received: from bl2pr02cu003.outbound.protection.outlook.com (mail-eastusazon11011023.outbound.protection.outlook.com [52.101.52.23]) by m0380145.ppops.net (PPS) with ESMTPS id 4gppxsm9ka-1 (version=TLSv1.3 cipher=TLS_AES_256_GCM_SHA384 bits=256 verify=NOT); Tue, 15 Sep 2026 04:57:10 -0500 (CDT) ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=yZRIZE7X/pXWjiV4R8yGiju8vmV/q/2+2Z9IhGunzInFDxOVYxaPkSKB7fopxtbr1GtwwVAr0bbVGs76pOcx3ZGcspVcBYkO3KJeIhzM6vzbvUhsy4hlMW+MvpwbYeeK7u1uX7UHhUaxJvFbyLX5WZQbaO1DwGG6c+HdfcxoGdGPWKqQiSZ+BcpI5SG6Br/vFeO8ryVHPvAcowST5fLBh0SpGB9kK/M2zOAkom3QmPmDGof9DEY13Q7CzHVPVWpulPkHSO2d9ZBpH4tS6keir7NqTkkYdEQfARN7jjHWC/qWnHGd72HsidjO7cajIsLQvF08yReCmJzKn56C3x/MXQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=TFbCitKYv9i3kJUkCLaJHMG/vBIF0b2me+WXqh6EuNE=; b=egbDpmm3HYg4YT6vAClsWL7eHyVVmc5rQhacdOrYPNqVmH+kBXkhNrn4Q5Umy0b9ue7FUl39MjPrgAcNcJ7wQc391v/e1/isNIeVZa/5L6eudo4zo609K6D1r4Lp1ZFOhTQ0hQeMKxWSksCgIKTe8nbD86CuHf9WoJ28Bj/tn5zpg/of6UOsjc7Y+XROzx+kwAKQDLqdRZWCsrT3z67W2WUQSJ4WG+pasp1vxtXOZJs1SMEdZOzfLgQqi7/BAAfhvhcF3QwMepmL9xd4uHQBtoxM4K2+Y8U1P6NH5yYCmG3fEgHiptl5hHMFIiEDe30WfWlJfN05rmT0UXAjXuUY6w== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 198.47.21.195) smtp.rcpttodomain=vger.kernel.org smtp.mailfrom=ti.com; dmarc=pass (p=quarantine sp=none pct=100) action=none header.from=ti.com; dkim=none (message not signed); arc=none (0) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ti.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=TFbCitKYv9i3kJUkCLaJHMG/vBIF0b2me+WXqh6EuNE=; b=QAt4C4nUGPP1ty+1AB62hlcCFgU6PdyK7WV5HuiUUoc4LQJiBs3ilFXdcfjOw5yE1lZm4VuTC8DO+s2aAbNgRMSjMbBlDwYhXQc7b6duOz/YW0zbgZmb894/G0PKXk1pzt+AOFUL+DGJAsy4rFwdYCgS9NzkQG3Pb9er+Df1JMM= Received: from MW4PR04CA0033.namprd04.prod.outlook.com (2603:10b6:303:6a::8) by BY5PR10MB4369.namprd10.prod.outlook.com (2603:10b6:a03:204::11) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.21.428.9; Tue, 15 Sep 2026 09:57:07 +0000 Received: from MWH0EPF000C6188.namprd02.prod.outlook.com (2603:10b6:303:6a:cafe::1d) by MW4PR04CA0033.outlook.office365.com (2603:10b6:303:6a::8) with Microsoft SMTP Server (version=TLS1_3, cipher=TLS_AES_256_GCM_SHA384) id 15.21.406.12 via Frontend Transport; Tue, 15 Sep 2026 09:57:06 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 198.47.21.195) smtp.mailfrom=ti.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=ti.com; Received-SPF: Pass (protection.outlook.com: domain of ti.com designates 198.47.21.195 as permitted sender) receiver=protection.outlook.com; client-ip=198.47.21.195; helo=flwvzet201.ext.ti.com; pr=C Received: from flwvzet201.ext.ti.com (198.47.21.195) by MWH0EPF000C6188.mail.protection.outlook.com (10.167.249.120) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.21.428.7 via Frontend Transport; Tue, 15 Sep 2026 09:57:05 +0000 Received: from DFLE211.ent.ti.com (10.64.6.69) by flwvzet201.ext.ti.com (10.248.192.32) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.2562.45; Tue, 15 Sep 2026 04:56:21 -0500 Received: from DFLE201.ent.ti.com (10.64.6.59) by DFLE211.ent.ti.com (10.64.6.69) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.2562.45; Tue, 15 Sep 2026 04:56:21 -0500 Received: from lelvem-mr06.itg.ti.com (10.180.75.8) by DFLE201.ent.ti.com (10.64.6.59) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.2562.45 via Frontend Transport; Tue, 15 Sep 2026 04:56:21 -0500 Received: from uda0497581-ant.dhcp.ti.com (uda0497581-ant.dhcp.ti.com [10.24.51.159]) by lelvem-mr06.itg.ti.com (8.18.1/8.18.1) with ESMTP id 68F9tB8A3000901; Tue, 15 Sep 2026 04:56:18 -0500 From: Manorit Chawdhry Date: Tue, 15 Sep 2026 15:25:26 +0530 Subject: [PATCH 20/30] crypto: sa2ul - fix command label stack corruption Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-ID: <20260915-b4-upstream-sa2ul-cleanup-v1-20-57ab34e97162@ti.com> References: <20260915-b4-upstream-sa2ul-cleanup-v1-0-57ab34e97162@ti.com> In-Reply-To: <20260915-b4-upstream-sa2ul-cleanup-v1-0-57ab34e97162@ti.com> To: Herbert Xu , "David S. Miller" , Keerthy , Colin Ian King CC: Andrew Davis , Pratham T , "Kamlesh Gurudasani" , Udit Kumar , , , "Manorit Chawdhry" X-Mailer: b4 0.15.2 X-Developer-Signature: v=1; a=ed25519-sha256; t=1789466112; l=2525; i=m-chawdhry@ti.com; s=20231127; h=from:subject:message-id; bh=sL4XRV9D1NA0Br4IlhtT/3KNoJwSVL9wHsuj5r2AEoM=; b=/knuG+xlKmy18u9vGOqfTfS04tRUs6niwEeXh4x/YLOstSTREw6P3Wbmjm2kh8NM17u4sAEjn g3fX39MrTsLDOOjlMqSEnpjO0kVq3Ik5+2oM2pBwMgNjcjSuANv6+Ad X-Developer-Key: i=m-chawdhry@ti.com; a=ed25519; pk=fsr6Tm39TvsTgfyfFQLk+nnqIz2sBA1PthfqqfiiYSs= X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: MWH0EPF000C6188:EE_|BY5PR10MB4369:EE_ X-MS-Office365-Filtering-Correlation-Id: f3a1e240-d060-46a7-df0c-08df130fb2a6 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|376014|82310400026|36860700016|23010399003|1800799024|10067099003|22082099003|18002099003|56012099006; X-Microsoft-Antispam-Message-Info: nrbJ4lYN3oM1sjd43ooBfc0Wa7ARJaPRiktcKRMvbmxJN+TeGf/2eKzY8wnK13KV3eNSrP0ADM8tq7QAI0aNWZigVkbOwOCb9xPHYKoUkhUnLFClcx+5H3Bw0QqNparqHduYlok3p6SDzj8DBFhnSMfzd76RwwzO0z1igIveFlTavxix6zLe4lKZVHMphqZC+8VOZ/0KTkCf+huV/asV6CKGj20RomAMrcWnXgvrUjohqqi5yXp1/arHDDo8n7q8TLSaHyR9NlDBF5eYiOdYbeBUxhgGX7bHmnHJmotWouIwZDFqhFZlw3E2zyycCsH6+bXqje+jxF2wp22fOx8RzdBqsY5eAwEo80NDwVAm7UiC9Yj0ukeAjJK5+7OoHk4n5vs5BvSUogW9dISQvmRxIoWh4r+nKg10zzSFER7iuXs1fLriUXcjOZhEtluykr9Sh4+MKBRUnXh8fSe0NwtezmTBRWuzsSkbo/cvC01v2Fw6z360aTUV0YOVb10ytI/6vkJvfdxPzbNypom0ROt4ztRTMsMTZHJ6RQnHpwG3KshvMt+/UaUgYuohfo0slKpD/APW8MNtrlO3UP31wP1NsJKB5JwBpg2jDRfay3xQCGSizRxpyk1ejCF3v/NNfkw/WDxrMsoG80WUKHMcndJ7FfHTErnr0zyGoj1Qm+sjWBI3Aibnk/lQEl4vSoMPeh4LR9LrEzcSkQFI/UH6n19SzA== X-Forefront-Antispam-Report: CIP:198.47.21.195;CTRY:US;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:flwvzet201.ext.ti.com;PTR:ErrorRetry;CAT:NONE;SFS:(13230040)(376014)(82310400026)(36860700016)(23010399003)(1800799024)(10067099003)(22082099003)(18002099003)(56012099006);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: 7ETLETtXD3aoTdGZ68LVuIBz/uNySiENgNczEriHW5rAGi4ApOhjlRjT1BlAkxHTjQckA5oz5f469Hg4Tgt17HepJJJtcSs2j0qGojZpICD8UejbEVFi8SjL0yV6BJpchS7uPI6EN+YR/mpEDzNmOeZDu7i91u+wRHo4ySABxWCJ5X7qT1ldRZPaThzx31TvOhQqn6X235x10C4sdfjcj1tNPlgeYPc69oLy8dFnWkVGVuPrXvpqbx3XJxSx9T2AZwboZ1isTTo+ZiJx7z/LjFV/Nbsj/KymEBKp1WNku7AQCes4PRLPR2Gj8QYMGkYWETeyCbBcnvvKyP+vUmYc8D0L0f0FBaIl9pz+USfV+7W8z1qbs3nUiQvjKg1j+i/qwn9Kstc/L7aq8E5fnDOG9DjS+0v9SCkO/bUTkfvOOzjYQKxmvL42zgCyevAObvdw X-Exchange-RoutingPolicyChecked: gch8KFMCdRNYMmJNnr+B7lVN4iueFOEHF13fVrQdfIBoJVLwNbp0lOOnLIwMo8C63shcMeeneV3an31EGWSpaZPwvw5gfnTKmd+3CcUsoRzOxzFI1Eoq96znH6KZJkaGMg3lZ8URVdnnxGTNB20lO0MZu02Lz3G44uv3fN2HhM9gDCG1JJwDFBez4NNSQem4IDUyGYyypyqDE74CGUj/I4DeM29GR8HpFdZAn032GAnKqiEWYWbAhI4uCkr7oIHnu8q0toh1ENi7K/vcmkk7L15oPGO3nve+W29XSoMjTR4g7lbe9ACWZC9BILk8fKNkjysiJtuCeWlvfIS7/Lbdng== X-OriginatorOrg: ti.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 15 Sep 2026 09:57:05.1213 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: f3a1e240-d060-46a7-df0c-08df130fb2a6 X-MS-Exchange-CrossTenant-Id: e5b49634-450b-4709-8abb-1e2b19b982b7 X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=e5b49634-450b-4709-8abb-1e2b19b982b7;Ip=[198.47.21.195];Helo=[flwvzet201.ext.ti.com] X-MS-Exchange-CrossTenant-AuthSource: MWH0EPF000C6188.namprd02.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: BY5PR10MB4369 X-Proofpoint-GUID: RnjF6zVvkzC_IgkCSbH3NBVIAMSvYggq X-Proofpoint-ORIG-GUID: RnjF6zVvkzC_IgkCSbH3NBVIAMSvYggq X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwOTE1MDE0MyBTYWx0ZWRfX//2ZEGtEAdrU NsmcDbXiFyVPS18zOkkmsPJwTc4xgTxzENdWGLepW6HnS/JOQK7SBeeKjBSHnRNJHGyQYz+DcXh u+oaULiC/hH3mS9g4UjWGViIQX+zvssyZaKHBMigmjHP6qsbkf3cJV73rTKaWYxgC6dKTtla6Wy rChbRGEGgEdpZr6YHSmaYJeDN+IH5Q6LBt/elAc5JXjEpA31HYsunQUG7W22dj9QcHBFaJg7cNn u2/xHStgNTZZj+ZFQ77eiMZR9teh7kXhj4QYxqNw1vCKxZ+5+EWc5jZOlLeKTwPBJlc2P7RMVQN d9H0Suw9qjf/GivajxfjBCCYbOpHIOVeETJiuRMz/u8HjcBSYaYdDbcROYQuulnnI+7azpQpl+G uF6gGOEnHd+Tqd27DKWTcOR6H3MVX7JKeqTcS2iiN9wxaxCWlEGImjJwlnS8Bw1IeWviqBHkTn4 yzd7DMkp8MRHjcQOgHg== X-Authority-Analysis: v=2.4 cv=bYP+w+PB c=1 sm=1 tr=0 ts=6aa91676 cx=c_pps a=g4Zu/129bcKSj1q/f/8ScQ==:117 a=tJyPKKxUohctrY4NYmUjkA==:17 a=6eWqkTHjU83fiwn7nKZWdM+Sl24=:19 a=IkcTkHD0fZMA:10 a=VdqzKS8jKosA:10 a=V5UXEbMT0ywA:10 a=VkNPw1HP01LnGYTKEx00:22 a=Z8NIEmU8O1QQgoT56wFK:22 a=gO1vWkAQAl3rybz1DQOp:22 a=sozttTNsAAAA:8 a=v72KZYpWpeSd1KIG7lMA:9 a=QEXdDO2ut3YA:10 X-Proofpoint-Spam-Info: AW1haW4tMjYwOTE1MDE0MyBTYWx0ZWRfXzZE9S7VFF0HG o6yn7Cy8rprlTRIKFOWYHbOkfHcYKzCR1VFjz2SmQJgoU+53zkQZ/XwT3DMKd1/FwW2uPmlor9q A5AYT1MN2VHG1PDgIoDI0f6+DcsXQzc= X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1176,Hydra:6.1.134,FMLib:17.12.100.49 definitions=2026-09-15_03,2026-09-14_02,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 clxscore=1015 lowpriorityscore=0 priorityscore=1501 impostorscore=0 adultscore=0 suspectscore=0 phishscore=0 malwarescore=0 bulkscore=0 spamscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2609040000 definitions=main-2609150143 Fix a race between sa_run() reading sa_ctx->cmdl_size and sa_ctx->cmdl_upd_info and a concurrent setkey() call reallocating or replacing sa_ctx. sa_run() already copies the command label template into a per-request stack buffer, but it read the shared context's size and update-info fields directly while building that copy, so a concurrent setkey() replacing sa_ctx underneath an in-flight request could corrupt the per-request command label. Snapshot sa_ctx->cmdl_size and sa_ctx->cmdl_upd_info into local variables before using them, isolating the in-flight request from a concurrent setkey(). Fixes: 7694b6ca649f ("crypto: sa2ul - Add crypto driver") Assisted-by: Sisyphus:claude-sonnet-4-6 Signed-off-by: Manorit Chawdhry --- drivers/crypto/sa2ul.c | 13 +++++++++---- 1 file changed, 9 insertions(+), 4 deletions(-) diff --git a/drivers/crypto/sa2ul.c b/drivers/crypto/sa2ul.c index a60b968c21f3..9e86b9531366 100644 --- a/drivers/crypto/sa2ul.c +++ b/drivers/crypto/sa2ul.c @@ -1050,6 +1050,8 @@ static int sa_run(struct sa_req *req) struct sa_rx_data *rxd; gfp_t gfp_flags; u32 cmdl[SA_MAX_CMDL_WORDS]; + u16 cmdl_size; + struct sa_cmdl_upd_info cmdl_upd_info; struct sa_crypto_data *pdata =3D dev_get_drvdata(sa_k3_dev); struct device *ddev; struct dma_chan *dma_rx; @@ -1095,9 +1097,12 @@ static int sa_run(struct sa_req *req) ddev =3D dmaengine_get_dma_device(pdata->dma_tx); rxd->ddev =3D ddev; =20 - memcpy(cmdl, sa_ctx->cmdl, sa_ctx->cmdl_size); + /* Snapshot TFM context to local copies for isolation from setkey() */ + cmdl_size =3D sa_ctx->cmdl_size; + cmdl_upd_info =3D sa_ctx->cmdl_upd_info; + memcpy(cmdl, sa_ctx->cmdl, cmdl_size); =20 - sa_update_cmdl(req, cmdl, &sa_ctx->cmdl_upd_info); + sa_update_cmdl(req, cmdl, &cmdl_upd_info); =20 =20 /* @@ -1211,7 +1216,7 @@ static int sa_run(struct sa_req *req) rxd->req =3D (void *)req->base; rxd->enc =3D req->enc; rxd->iv_idx =3D req->ctx->iv_idx; - rxd->enc_iv_size =3D sa_ctx->cmdl_upd_info.enc_iv.size; + rxd->enc_iv_size =3D cmdl_upd_info.enc_iv.size; rxd->tx_in->callback =3D req->callback; rxd->tx_in->callback_param =3D rxd; =20 @@ -1231,7 +1236,7 @@ static int sa_run(struct sa_req *req) */ mdptr =3D (u32 *)dmaengine_desc_get_metadata_ptr(tx_out, &pl, &ml); =20 - req->mdata_size =3D sa_prepare_tx_desc(mdptr, sa_ctx->cmdl_size, + req->mdata_size =3D sa_prepare_tx_desc(mdptr, cmdl_size, cmdl, sizeof(sa_ctx->epib), sa_ctx->epib); =20 --=20 2.43.0 From nobody Fri Sep 25 12:05:54 2026 Received: from mx0b-0002e601.pphosted.com (mx0b-0002e601.pphosted.com [148.163.154.28]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 311A948EC89; Tue, 15 Sep 2026 09:56:41 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=fail smtp.client-ip=148.163.154.28 ARC-Seal: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1789466206; cv=fail; b=IYcJ9RcMx1LpVPZ2t5Q9+Fbzf34LhIBIXybwfwACzVWRv5SD2f6ZNyiFTK8Ba18YnYoWXtXQtYJPqewxXtsZrkJjHP0okmT8lEs7Z39IexVZ4Z1b+MxsfYJNY3e1aCeG+MHfRuDE+E7yGddGCHKdtlqqhJ/mWgcr/gpFeJjeRAo= ARC-Message-Signature: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1789466206; c=relaxed/simple; bh=jJD122KvC2Ro1YSER8fKZ3D+NYvoM2oI/GA4yLGo0xA=; h=From:Date:Subject:MIME-Version:Content-Type:Message-ID:References: In-Reply-To:To:CC; b=c42j7Mju9lVm7/uZp+OSPs7a5cT549yF+QPzWL5G+ZigIid3uxzkQ8CZe4nxnSNy92WCxdor12PxhHSLfWRQbyb8lQFfMWaHzjRuhfV+8Z8QyVZNBKa2mj6B7bFMiJsKM02RLqi0qb92JZG6Vs1L210Psm6P+r7XOOislypQKcc= ARC-Authentication-Results: i=2; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=ti.com; spf=pass smtp.mailfrom=ti.com; dkim=pass (2048-bit key) header.d=ti.com header.i=@ti.com header.b=KueECvZ4; dkim=pass (1024-bit key) header.d=ti.com header.i=@ti.com header.b=bJhJN6fJ; arc=fail smtp.client-ip=148.163.154.28 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=ti.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=ti.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=ti.com header.i=@ti.com header.b="KueECvZ4"; dkim=pass (1024-bit key) header.d=ti.com header.i=@ti.com header.b="bJhJN6fJ" Received: from pps.filterd (m0374956.ppops.net [127.0.0.1]) by mx0b-0002e601.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 68F9fBOJ3810849; Tue, 15 Sep 2026 04:56:37 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ti.com; h=cc :content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s= proofpoint-05-2026; bh=CYe86O8SGcINloqMZIlqf1FLwKzbr6kv19C/xpokv e4=; b=KueECvZ45Fpzez0yLr1YYKai/RkJDzm04Pd8ijuRx26rLGQ3rfxTyu7XN DqMIShaaSCzgGvRVg11Na1W6xXmfKOolGzvtntGOj3qoLPtRlB0h83ozJP5wvlYj DFcp+V18m5rlGKueEzZFq2HioDAMFIZ1/TDcQVAztm7BAkIYs7APmc0IBXSfux30 4aDmwFo66/acQMdGuI+g/v6HVufXbgHgYn24fBbMnRuaM4uOQfQWEamP+w4+mK3a mZrh+X9lHY8t13xlxfLw+OAK4TGbHNQVVW6iALh+XkW+EkQ7N6kEhc3tsR/sLi8D Ft0jVs/Kymdp83uRntHjCs71JkJFg== Received: from ph8pr06cu001.outbound.protection.outlook.com (mail-westus3azon11012059.outbound.protection.outlook.com [40.107.209.59]) by mx0b-0002e601.pphosted.com (PPS) with ESMTPS id 4gq362r9xv-1 (version=TLSv1.3 cipher=TLS_AES_256_GCM_SHA384 bits=256 verify=NOT); Tue, 15 Sep 2026 04:56:37 -0500 (CDT) ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=YwiGgisQdMLm5ftyNbKMhXdx1ikQP7J2kxqUbTT+eNRNO+6wrdnxlFPUPEy0EVrcpbMc5PjZNkIARhq2EzWi801cbdCRrxQ3BP7rHzxwmKKMp8mz4oGhADTQPjq0qRpzs4D5nQyYVZQLU/KKLTdMtR9kT7MHAcG5kf9X/6Nzg+M/lgK+x7QiknykscV5yRhFGl6E67wrrgTnnEMdUZoWiMkwxShsvOWD9B6eoT+QlCYYV2g8QZQjHcoGME2cDyQw+7XARDtzZioc77vzYRtmVpUzs8FUYs6npfJdGMprdTfrGihRWrLCqupk/3h2CXYW/ig51lwoVuLAmLUWiCsr+Q== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=CYe86O8SGcINloqMZIlqf1FLwKzbr6kv19C/xpokve4=; b=s4rqq+6keA8YoqfBfbISTJJ5nreO6xBmrDxrfRblQWBUVFQj+gdfQQIGKAdrhqYWWR1/lX80HhNadGGk7RjVSCQLv/CCM1xkOeMv7qVsXfIAeKZQiZvDY7w0PaQZSuWF3GKHzk8RcLnxtukqnLsicy3YbFKUrMQG5kfdbGTq7ATMZNqmkWEUpp5m3+eSgpcc4jFKif2yKC8s8Io7rpqnkORVBZDex0yakHzdNl2ZF3RRrL3HtNnT4qz+VmyLmuNiaqkL6CuOSuhCsJmF4tXtO3K1RgLz21eSZMprdUD/ZfNYm9p9s+cvwjypRit9egxZ/QA1DfM7Ujmxms5jHlEimw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 198.47.23.195) smtp.rcpttodomain=vger.kernel.org smtp.mailfrom=ti.com; dmarc=pass (p=quarantine sp=none pct=100) action=none header.from=ti.com; dkim=none (message not signed); arc=none (0) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ti.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=CYe86O8SGcINloqMZIlqf1FLwKzbr6kv19C/xpokve4=; b=bJhJN6fJ9jItle8K98Q0p9Mvmuc2At7saxLhfabnB5SzL6/NbfHMD37JRcr5FrU6NuJ11x3Y4WeVGVidz/oOKEYF5Uk/LYPp8DljRldYOMwu0g8fw43vMYqrxeGoXFLPHeB0IqrcyR1iRaO3Tr+AhzVtDsSh63Kr/v+dT4Ke6uo= Received: from BN9PR03CA0804.namprd03.prod.outlook.com (2603:10b6:408:13f::29) by SA1PR10MB7832.namprd10.prod.outlook.com (2603:10b6:806:3a9::19) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.21.428.7; Tue, 15 Sep 2026 09:56:33 +0000 Received: from LV8PEPF00000067.namprd03.prod.outlook.com (2603:10b6:408:13f:cafe::2) by BN9PR03CA0804.outlook.office365.com (2603:10b6:408:13f::29) with Microsoft SMTP Server (version=TLS1_3, cipher=TLS_AES_256_GCM_SHA384) id 15.21.406.12 via Frontend Transport; Tue, 15 Sep 2026 09:56:32 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 198.47.23.195) smtp.mailfrom=ti.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=ti.com; Received-SPF: Pass (protection.outlook.com: domain of ti.com designates 198.47.23.195 as permitted sender) receiver=protection.outlook.com; client-ip=198.47.23.195; helo=lewvzet201.ext.ti.com; pr=C Received: from lewvzet201.ext.ti.com (198.47.23.195) by LV8PEPF00000067.mail.protection.outlook.com (10.167.248.39) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.21.428.7 via Frontend Transport; Tue, 15 Sep 2026 09:56:32 +0000 Received: from DLEE212.ent.ti.com (157.170.170.114) by lewvzet201.ext.ti.com (10.4.14.104) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.2562.45; Tue, 15 Sep 2026 04:56:24 -0500 Received: from DLEE200.ent.ti.com (157.170.170.75) by DLEE212.ent.ti.com (157.170.170.114) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.2562.45; Tue, 15 Sep 2026 04:56:24 -0500 Received: from lelvem-mr06.itg.ti.com (10.180.75.8) by DLEE200.ent.ti.com (157.170.170.75) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.2562.45 via Frontend Transport; Tue, 15 Sep 2026 04:56:24 -0500 Received: from uda0497581-ant.dhcp.ti.com (uda0497581-ant.dhcp.ti.com [10.24.51.159]) by lelvem-mr06.itg.ti.com (8.18.1/8.18.1) with ESMTP id 68F9tB8B3000901; Tue, 15 Sep 2026 04:56:21 -0500 From: Manorit Chawdhry Date: Tue, 15 Sep 2026 15:25:27 +0530 Subject: [PATCH 21/30] crypto: sa2ul - fix error handling in sa_prepare_iopad Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-ID: <20260915-b4-upstream-sa2ul-cleanup-v1-21-57ab34e97162@ti.com> References: <20260915-b4-upstream-sa2ul-cleanup-v1-0-57ab34e97162@ti.com> In-Reply-To: <20260915-b4-upstream-sa2ul-cleanup-v1-0-57ab34e97162@ti.com> To: Herbert Xu , "David S. Miller" , Keerthy , Colin Ian King CC: Andrew Davis , Pratham T , "Kamlesh Gurudasani" , Udit Kumar , , , "Manorit Chawdhry" X-Mailer: b4 0.15.2 X-Developer-Signature: v=1; a=ed25519-sha256; t=1789466112; l=6265; i=m-chawdhry@ti.com; s=20231127; h=from:subject:message-id; bh=jJD122KvC2Ro1YSER8fKZ3D+NYvoM2oI/GA4yLGo0xA=; b=DcPTZpPSnB3+SZNV8AqA1M4S6jUWE7T/QUndjyrbkWaFEamapqBhV7WZYHAsLhHSnL0agWy5j 0YL7x+muc5SBNLXSKzkNk2rrVro3E0IEwGrBYNpTxySAHDxupXEf+pd X-Developer-Key: i=m-chawdhry@ti.com; a=ed25519; pk=fsr6Tm39TvsTgfyfFQLk+nnqIz2sBA1PthfqqfiiYSs= X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: LV8PEPF00000067:EE_|SA1PR10MB7832:EE_ X-MS-Office365-Filtering-Correlation-Id: aab09aca-4677-464d-50dd-08df130f9f45 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|376014|23010399003|1800799024|82310400026|36860700016|18092099006|18002099003|22082099003|10067099003|56012099006; X-Microsoft-Antispam-Message-Info: mWwC7ZvN5JWcA2crRkJb/LWS7xmpXDxrrMzZcqUNJQX1CJN96tUo45FgsMuYxVjKn3Xe/w+q/We/Vs2QYtg+AJJztGkro6mf1EmDhYlSmon97kqq4Rn9fzYga3DJf3rhsX8fLStKxWBS0dW8G9zwFZlh5esxljHYtvQ0VHRd4KtTObnpuEu7H+Ub1MWxom6yazg5jm/7l2qBNk7Rw1gGcXIskFVTkFTK066ZEcBHel5Ys4XHJCeBXZ6WEMJ47Xg98a/fGTJv+LjKfUkSze2UWyYUcRd/oUyoM6srI/e2p94Fs4JeVUXJYEqyUmv5REhX50+nOEQorfEAr4sxoVsY6UnFLvp0xyUJOWTSw/U3qXVKBPumo1JwHA5q01kf4315GFgQSmJLEGHbefSqufOWiqr2IDKJPCfP3mNCteLxKiACn/ZMCfWQYdXberCKspmXzV/DAxrQnB5wKH0ibBx/O4aGDTfx/J1UyJLwf/1mY57GnY7he37+yR6DATorcb61zPjnG2DlThc7MlmZHR2wjNYcMIca1Zb4vPMUyhVNLn0Evaha7beGqo/XkBVw67TPUpjuJj7+rJK7TA8Baw1W5t36EGYa//oO3ajE2LRU/sIPVTWBu365eCrgd4U7f5IBmBH4FrJ8j3Y6LmHsMfmbLzadhMtsLhZ60f+WaYAiQYNrmGDha4qGDDVpBNMMT/eY0dXgJwzgoOr1TxaF3/Da9w== X-Forefront-Antispam-Report: CIP:198.47.23.195;CTRY:US;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:lewvzet201.ext.ti.com;PTR:InfoDomainNonexistent;CAT:NONE;SFS:(13230040)(376014)(23010399003)(1800799024)(82310400026)(36860700016)(18092099006)(18002099003)(22082099003)(10067099003)(56012099006);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: y7PVDMZVGF9YJDlZm+rsQl1r8n3SR1MQn1XpyhY4zDsBWfpj15uPESVu7o14OHPyhCsYb9IIdfTeAs8mObOIxQ5v6HUnfpIrRo3bz8cJ6DEcy3vI4XpqciqWUEo+9gnOX5bqNaqbkDpjRSCovQDK2fN9k5zqU30bxySktNP3lS5GOJHbqdH0CzB6lFtDyjw0Fb4B37NBS98E4TvKJLPR4it/xOlnwCMXYk7zmpoDJxC9wUDt6/HRT6CiJLmJIw89Qajdm6SH9C+f/8tyOouUx4ZOTRCpVQTZfJ/3HG2MNJ3fNQqwZ4fIIvkldNL/hIrvrkBl7uMJKWwZk9GMcYIzKApDGiRBRVb6EvqMYUxX80C1AnvfRf648oMqmMnJ2iD7xXmP18zD4JqtaDHKmQOxGqBA1ZyDAAuSg7Kef7cMTXmkwqxH91N51EzVW1jIwT5D X-Exchange-RoutingPolicyChecked: YUvvSWW7F5yJNN7YNt85HWzzMBEqz6RnGIdamZZYzmCAs0T5yxjXR3DsfLjvmtUARoGCPacf2OPaZevp8Q8TyVntpMNZTOLSbn+Ag5r6MVOhUIGNBN3Y7mppOFizps1nhLvmLOt4+Kr7e+svzsA9LVHD8Z1mZD70Gb9aVUsN1Do/0h1hYx9nJHwtBC2fQujvhfYdNno3xaAVNXikgcX+wXIhx8lNr0xF7Lbom+DNtzLsFsohs7WUFbDd3kRX2wozGNqc+zTtegIRSsuqJ/5N32vFER15J6MrwEb9bxwIigGgU8cLg541tb9NVre1h2s1mAOMxX4x2GRryUYJe3KoYA== X-OriginatorOrg: ti.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 15 Sep 2026 09:56:32.6254 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: aab09aca-4677-464d-50dd-08df130f9f45 X-MS-Exchange-CrossTenant-Id: e5b49634-450b-4709-8abb-1e2b19b982b7 X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=e5b49634-450b-4709-8abb-1e2b19b982b7;Ip=[198.47.23.195];Helo=[lewvzet201.ext.ti.com] X-MS-Exchange-CrossTenant-AuthSource: LV8PEPF00000067.namprd03.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: SA1PR10MB7832 X-Authority-Analysis: v=2.4 cv=P9yvFSAu c=1 sm=1 tr=0 ts=6aa91655 cx=c_pps a=e24IK3jsPB00aLvKg+wNHQ==:117 a=f+v6EHfkeJbVwR46tk4DMg==:17 a=6eWqkTHjU83fiwn7nKZWdM+Sl24=:19 a=IkcTkHD0fZMA:10 a=VdqzKS8jKosA:10 a=s63m1ICgrNkA:10 a=V5UXEbMT0ywA:10 a=VkNPw1HP01LnGYTKEx00:22 a=Z8NIEmU8O1QQgoT56wFK:22 a=jwouBfj2j3NM8CExmVVE:22 a=sozttTNsAAAA:8 a=AnTYPz4I4B_XLNGOx7IA:9 a=QEXdDO2ut3YA:10 X-Proofpoint-GUID: S9uYek_Q7k90oZ3ePrEsqjbdJf8gy6eW X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwOTE1MDE0MyBTYWx0ZWRfXw67vVeFpnk8A eQ5KLWwU9AZCvF8iy4FU+kd4VkISOAInre7a05pAjpfRPJ9er6wjKJylcDhFIN70GDXf8Z1kFz6 vnkzZdol5xxII4vjbbeHQSgd7y1W377Z1jvkL2jBbFRmmL3gZojvU3zrKFRnBdbsO9OmsjLSR73 hPQZgoj7/lOADoYK6Oxt2N3xJop0iFyw40nOCavFBsykbfPGYcAuDYcBOzk8rSb1kE6aWL0HQaM 0gHXVm0k9Kj+/iWqYO0uANOg6FJRQ+IvNceADOInmZ2Y8BmZRS+ssKSszsYx58gcoNN5gtt6kTi aB5ikg5xCmCHDz10LJoKcvrgHhYwJvSPoPuw03JF9v64LxN5pn66me5y/9WrHR8rxzGPo9YKHFX gz6Som8tnv7ExfyaEZpzgimtM4q4iVMbvKzva6aK2mHbqzrGwsRH86dYOrC5929UFN+gsaYj37U qwwr3altKFDOtlu/FfQ== X-Proofpoint-ORIG-GUID: S9uYek_Q7k90oZ3ePrEsqjbdJf8gy6eW X-Proofpoint-Spam-Info: AW1haW4tMjYwOTE1MDE0MyBTYWx0ZWRfX+Xaco1mRWbp4 gjp6D9B67q7GOLEi0nKOuXCXkJQzlR3RUfEA1lE9E0ZvqvXDXoWLNA5vsMOAQ3GFisbrINQfpll mH+1YtCdIj5I7D98oR04xmqsuEhGa0A= X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1176,Hydra:6.1.134,FMLib:17.12.100.49 definitions=2026-09-15_03,2026-09-14_02,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 phishscore=0 adultscore=0 bulkscore=0 suspectscore=0 priorityscore=1501 spamscore=0 impostorscore=0 lowpriorityscore=0 malwarescore=0 clxscore=1015 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2609040000 definitions=main-2609150143 Fixes the call stack for sa_prepare_iopad to start returning errors incase of failures. Also fix sa_export_hash to propagate the errors as well as it comes in the same call chain. Fixes: d2c8ac187fc9 ("crypto: sa2ul - Add AEAD algorithm support") Assisted-by: Sisyphus:claude-sonnet-4-6 Signed-off-by: Manorit Chawdhry --- drivers/crypto/sa2ul.c | 101 ++++++++++++++++++++++++++++++++++++++-------= ---- 1 file changed, 79 insertions(+), 22 deletions(-) diff --git a/drivers/crypto/sa2ul.c b/drivers/crypto/sa2ul.c index 9e86b9531366..f89e84c5529b 100644 --- a/drivers/crypto/sa2ul.c +++ b/drivers/crypto/sa2ul.c @@ -133,8 +133,8 @@ struct algo_data { bool inv_key; struct sa_tfm_ctx *ctx; bool keyed_mac; - void (*prep_iopad)(struct algo_data *algo, const u8 *key, - u16 key_sz, __be32 *ipad, __be32 *opad); + int (*prep_iopad)(struct algo_data *algo, const u8 *key, + u16 key_sz, __be32 *ipad, __be32 *opad); }; =20 /** @@ -392,12 +392,13 @@ static void prepare_kopad(u8 *k_opad, const u8 *key, = u16 key_sz) k_opad[i] =3D 0x5c; } =20 -static void sa_export_shash(void *state, struct shash_desc *hash, - int digest_size, __be32 *out) +static int sa_export_shash(void *state, struct shash_desc *hash, + int digest_size, __be32 *out) { struct sha1_state *sha1; struct sha256_state *sha256; u32 *result; + int ret =3D 0; =20 switch (digest_size) { case SHA1_DIGEST_SIZE: @@ -411,20 +412,29 @@ static void sa_export_shash(void *state, struct shash= _desc *hash, default: dev_err(sa_k3_dev, "%s: bad digest_size=3D%d\n", __func__, digest_size); - return; + return -EINVAL; } =20 - crypto_shash_export(hash, state); + ret =3D crypto_shash_export(hash, state); + if (ret) { + dev_err(sa_k3_dev, "%s: crypto_shash_export failed\n", + __func__); + return ret; + } =20 cpu_to_be32_array(out, result, digest_size / 4); + + return ret; } =20 -static void sa_prepare_iopads(struct algo_data *data, const u8 *key, - u16 key_sz, __be32 *ipad, __be32 *opad) +static int sa_prepare_iopads(struct algo_data *data, const u8 *key, + u16 key_sz, __be32 *ipad, __be32 *opad) { SHASH_DESC_ON_STACK(shash, data->ctx->shash); int block_size =3D crypto_shash_blocksize(data->ctx->shash); int digest_size =3D crypto_shash_digestsize(data->ctx->shash); + int ret =3D 0; + union { struct sha1_state sha1; struct sha256_state sha256; @@ -435,18 +445,49 @@ static void sa_prepare_iopads(struct algo_data *data,= const u8 *key, =20 prepare_kipad(sha.k_pad, key, key_sz); =20 - crypto_shash_init(shash); - crypto_shash_update(shash, sha.k_pad, block_size); - sa_export_shash(&sha, shash, digest_size, ipad); + ret =3D crypto_shash_init(shash); + if (ret) { + dev_err(sa_k3_dev, "%s: %d: crypto_shash_init for ipad failed, ret=3D%d\= n", + __func__, __LINE__, ret); + return ret; + } + ret =3D crypto_shash_update(shash, sha.k_pad, block_size); + if (ret) { + dev_err(sa_k3_dev, "%s: %d: crypto_shash_update for ipad failed, ret=3D%= d\n", + __func__, __LINE__, ret); + return ret; + } + ret =3D sa_export_shash(&sha, shash, digest_size, ipad); + if (ret) { + dev_err(sa_k3_dev, "%s: %d: sa_export_shash for ipad failed, ret=3D%d\n", + __func__, __LINE__, ret); + return ret; + } =20 prepare_kopad(sha.k_pad, key, key_sz); =20 - crypto_shash_init(shash); - crypto_shash_update(shash, sha.k_pad, block_size); - - sa_export_shash(&sha, shash, digest_size, opad); + ret =3D crypto_shash_init(shash); + if (ret) { + dev_err(sa_k3_dev, "%s: %d: crypto_shash_init for opad failed, ret=3D%d\= n", + __func__, __LINE__, ret); + return ret; + } + ret =3D crypto_shash_update(shash, sha.k_pad, block_size); + if (ret) { + dev_err(sa_k3_dev, "%s: %d: crypto_shash_update for opad failed, ret=3D%= d\n", + __func__, __LINE__, ret); + return ret; + } + ret =3D sa_export_shash(&sha, shash, digest_size, opad); + if (ret) { + dev_err(sa_k3_dev, "%s: %d: sa_export_shash for opad failed, ret=3D%d\n", + __func__, __LINE__, ret); + return ret; + } =20 memzero_explicit(&sha, sizeof(sha)); + + return ret; } =20 /* Derive the inverse key used in AES-CBC decryption operation */ @@ -516,11 +557,12 @@ static int sa_set_sc_enc(struct algo_data *ad, const = u8 *key, u16 key_sz, } =20 /* Set Security context for the authentication engine */ -static void sa_set_sc_auth(struct algo_data *ad, const u8 *key, u16 key_sz, - u8 *sc_buf) +static int sa_set_sc_auth(struct algo_data *ad, const u8 *key, u16 key_sz, + u8 *sc_buf) { __be32 *ipad =3D (void *)(sc_buf + 32); __be32 *opad =3D (void *)(sc_buf + 64); + int ret =3D 0; =20 /* Set Authentication mode selector to hash processing */ sc_buf[0] =3D SA_HASH_PROCESSING; @@ -529,12 +571,20 @@ static void sa_set_sc_auth(struct algo_data *ad, cons= t u8 *key, u16 key_sz, sc_buf[1] |=3D ad->auth_ctrl; =20 /* Copy the keys or ipad/opad */ - if (ad->keyed_mac) - ad->prep_iopad(ad, key, key_sz, ipad, opad); + if (ad->keyed_mac) { + ret =3D ad->prep_iopad(ad, key, key_sz, ipad, opad); + if (ret) { + dev_err(sa_k3_dev, "%s: %d: sa_prepare_iopads failed, ret=3D%d\n", + __func__, __LINE__, ret); + return ret; + } + } else { /* basic hash */ sc_buf[1] |=3D SA_BASIC_HASH; } + + return 0; } =20 /* Format general command label */ @@ -688,6 +738,7 @@ int sa_init_sc(struct sa_ctx_info *ctx, const struct sa= _match_data *match_data, u8 *sc_buf =3D ctx->sc; u16 sc_id =3D ctx->sc_id; u8 first_engine =3D 0; + int ret =3D 0; =20 memzero_explicit(sc_buf, SA_CTX_MAX_SZ); =20 @@ -727,9 +778,15 @@ int sa_init_sc(struct sa_ctx_info *ctx, const struct s= a_match_data *match_data, } =20 /* Prepare context for authentication engine */ - if (ad->auth_eng.sc_size) - sa_set_sc_auth(ad, auth_key, auth_key_sz, - &sc_buf[auth_sc_offset]); + if (ad->auth_eng.sc_size) { + ret =3D sa_set_sc_auth(ad, auth_key, auth_key_sz, + &sc_buf[auth_sc_offset]); + if (ret) { + dev_err(sa_k3_dev, "%s: Error in setting authentication context\n", + __func__); + return ret; + } + } =20 /* Set the ownership of context to CP_ACE */ sc_buf[SA_CTX_SCCTL_OWNER_OFFSET] =3D 0x80; --=20 2.43.0 From nobody Fri Sep 25 12:05:54 2026 Received: from mx0b-0002e601.pphosted.com (mx0b-0002e601.pphosted.com [148.163.154.28]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 82EC549C4A7; Tue, 15 Sep 2026 09:56:53 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=fail smtp.client-ip=148.163.154.28 ARC-Seal: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1789466216; cv=fail; b=rD57LE4fayWa6DitxVBWfn8dUHd55SJRtExT38AJb73YEt/DAluoCf7QjZy+GVCXyqecI2cWxApn4bHct8Kk7DqIH7mnAVcYpi7tA8ctiv6s07DTTsdDkJoHbfV0VCk2iKFY+nyYq1GFr2n5sC0IJsZMT/sz0K2Q4L9H4EqigLY= ARC-Message-Signature: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1789466216; c=relaxed/simple; bh=yqCnj295rHUFvyLN8h/SkHu6C4x53WmqJry9YsUx5XA=; h=From:Date:Subject:MIME-Version:Content-Type:Message-ID:References: In-Reply-To:To:CC; b=TE2HHa9ZACAJ0T44eF08cDBHR3vs2PVM+0u4W3/O3VVawhu79eEWpb6RhhY7Gm+NZjfyTQYUr7F1gV2u6KZicc/RaqS50Qh+E/mHazME5YdUcqPeoexp4PGgdYwtPUAu5v5yt5tHVcUo+eqJeHBYky9RINDVsJ5FT6RuseWT4h4= ARC-Authentication-Results: i=2; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=ti.com; spf=pass smtp.mailfrom=ti.com; dkim=pass (2048-bit key) header.d=ti.com header.i=@ti.com header.b=QFiRcwq1; dkim=pass (1024-bit key) header.d=ti.com header.i=@ti.com header.b=EL/e3TSR; arc=fail smtp.client-ip=148.163.154.28 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=ti.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=ti.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=ti.com header.i=@ti.com header.b="QFiRcwq1"; dkim=pass (1024-bit key) header.d=ti.com header.i=@ti.com header.b="EL/e3TSR" Received: from pps.filterd (m0374955.ppops.net [127.0.0.1]) by mx0b-0002e601.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 68F9fKs24098103; Tue, 15 Sep 2026 04:56:49 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ti.com; h=cc :content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s= proofpoint-05-2026; bh=nJjECqSuOeQXjtQq5t5cfv+U6pzrkLIQ9nBhlUIgF EA=; b=QFiRcwq1KPvE1yzCajC4SjJo7I4RUXuJhw0h7+BkMOoWOTj8Ff4uZmwAh XmJoC52r620U7Zt7pdgBoCNikNWT4hq5z2cz4UYroCh0UCNbHk0omJEtE2nvz+Ax Bo0P+7HvMRACOvkK8wJLcnzRUYfJ94Af413AYKrcKTLTC1M9r2W2MhgJ0TswLGBI asp5iyd2zhADEQRqrBNeYLA8nKeT0pPkuH/sWzqyvbaQGzzDd7kQINezMFjTJwU7 c4v0RoLkqh1TD6o0eYFezvlxmbKRzTlv153KJjOONuq7Ad1BhuNqIpsooXgJMQAJ yR1uSaV8o6RZ+or5Gsqubp6drv34Q== Received: from sj2pr03cu001.outbound.protection.outlook.com (mail-westusazon11012022.outbound.protection.outlook.com [52.101.43.22]) by mx0b-0002e601.pphosted.com (PPS) with ESMTPS id 4gpvpjakjx-1 (version=TLSv1.3 cipher=TLS_AES_256_GCM_SHA384 bits=256 verify=NOT); Tue, 15 Sep 2026 04:56:49 -0500 (CDT) ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=uEDcjc3Uy6XB14Q212obZagsRswVutDrYGdVYkZnannCeRq3vc45f5usdn2ay/XKPEGuNsFatUmHCX3RKujXELxVBj1xK/XuBhXIXQcso2nkRvQ2t2zDWlq4BY2ETatOXV8k8NC8Td8oVEAfkJA8bKBb04gZj06Ml63ElS/uP1df8iZngBpVrmDBEqlJewo1dQ8c6wKpA4T6JUZsH73MjRbxEgrgiKBTZMFJhQqulP5H7fmjfIY51T/pwW3RWcTy3tF4qxJJJx1lTB16/GPjvETzY0OsE3piBTcAYhFuDSjSj6UUWiW6UjAoisuni0u5yMj6JgqilgRg7Z+B2BbcRg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=nJjECqSuOeQXjtQq5t5cfv+U6pzrkLIQ9nBhlUIgFEA=; b=Fwtg+/E0JyBT8IHLryEvwUJuO/3vWPP4wWoMuQO5uscpsbKP0SSde+gAqoLQma4KrnXhlfLBuv+Vr8X5UR8786mnOyx87qQXVGqHZuIaeOMnJMsP+ths0FR3PVEdneVygki2oVjyoZm6IH3Gl0t6G/KAQLx4DWPSqBYpg+JFpTYgPxJnlNXOGH2wzfqV7gEZjkvWjOObpfYW6txiMMnac5oFMtdjDI8prTQx1u3HbvFPLOVdKaMO9zeBa+fLHuAoIsr5qSqlP3lJbDtoj74s08SJTUK76hlWuPKoHdX0WzeYdYdLoFnZfa4SwpGDQvD0cxPdYDUfY7ZJdXFnE1Vifg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 198.47.23.194) smtp.rcpttodomain=vger.kernel.org smtp.mailfrom=ti.com; dmarc=pass (p=quarantine sp=none pct=100) action=none header.from=ti.com; dkim=none (message not signed); arc=none (0) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ti.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=nJjECqSuOeQXjtQq5t5cfv+U6pzrkLIQ9nBhlUIgFEA=; b=EL/e3TSRWg1gpPmY/JdtVbmhqjpWSg/pQJI8qiGNk7cdRmhxo61dBuM6L0XHtcdDPdU5z5p2JAgJ1XL0D80sYf6mqzkrMT8QNIR8Ls89X3oQ2dZCDUNgGJZt72hX3wM1JYdZDkC065BWjz8a0/QcVbsZ74CyN1CbZtebfR0vILA= Received: from BN0PR03CA0014.namprd03.prod.outlook.com (2603:10b6:408:e6::19) by PH8PR10MB6388.namprd10.prod.outlook.com (2603:10b6:510:1c3::22) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.21.428.7; Tue, 15 Sep 2026 09:56:45 +0000 Received: from BN2PEPF000044A4.namprd02.prod.outlook.com (2603:10b6:408:e6:cafe::25) by BN0PR03CA0014.outlook.office365.com (2603:10b6:408:e6::19) with Microsoft SMTP Server (version=TLS1_3, cipher=TLS_AES_256_GCM_SHA384) id 15.21.428.9 via Frontend Transport; Tue, 15 Sep 2026 09:56:45 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 198.47.23.194) smtp.mailfrom=ti.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=ti.com; Received-SPF: Pass (protection.outlook.com: domain of ti.com designates 198.47.23.194 as permitted sender) receiver=protection.outlook.com; client-ip=198.47.23.194; helo=lewvzet200.ext.ti.com; pr=C Received: from lewvzet200.ext.ti.com (198.47.23.194) by BN2PEPF000044A4.mail.protection.outlook.com (10.167.243.155) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.21.428.7 via Frontend Transport; Tue, 15 Sep 2026 09:56:44 +0000 Received: from DLEE206.ent.ti.com (157.170.170.90) by lewvzet200.ext.ti.com (10.4.14.103) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.2562.45; Tue, 15 Sep 2026 04:56:27 -0500 Received: from DLEE201.ent.ti.com (157.170.170.76) by DLEE206.ent.ti.com (157.170.170.90) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.2562.45; Tue, 15 Sep 2026 04:56:27 -0500 Received: from lelvem-mr06.itg.ti.com (10.180.75.8) by DLEE201.ent.ti.com (157.170.170.76) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.2562.45 via Frontend Transport; Tue, 15 Sep 2026 04:56:27 -0500 Received: from uda0497581-ant.dhcp.ti.com (uda0497581-ant.dhcp.ti.com [10.24.51.159]) by lelvem-mr06.itg.ti.com (8.18.1/8.18.1) with ESMTP id 68F9tB8C3000901; Tue, 15 Sep 2026 04:56:24 -0500 From: Manorit Chawdhry Date: Tue, 15 Sep 2026 15:25:28 +0530 Subject: [PATCH 22/30] crypto: sa2ul - move export to appropriate location. Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-ID: <20260915-b4-upstream-sa2ul-cleanup-v1-22-57ab34e97162@ti.com> References: <20260915-b4-upstream-sa2ul-cleanup-v1-0-57ab34e97162@ti.com> In-Reply-To: <20260915-b4-upstream-sa2ul-cleanup-v1-0-57ab34e97162@ti.com> To: Herbert Xu , "David S. Miller" , Keerthy , Colin Ian King CC: Andrew Davis , Pratham T , "Kamlesh Gurudasani" , Udit Kumar , , , "Manorit Chawdhry" X-Mailer: b4 0.15.2 X-Developer-Signature: v=1; a=ed25519-sha256; t=1789466112; l=1368; i=m-chawdhry@ti.com; s=20231127; h=from:subject:message-id; bh=yqCnj295rHUFvyLN8h/SkHu6C4x53WmqJry9YsUx5XA=; b=M1w4bAkTaYp0V8z+jO7DMIR085c8f1RpZ3Ddi+mn76xu02QDcUuWnHFMMcYLMJ+cRIhQm/nh5 fdTwp1q7gCVBtkdkDzanrCBO2/4CkdvVPSeqjYjWjrZsovBrtD6oP4F X-Developer-Key: i=m-chawdhry@ti.com; a=ed25519; pk=fsr6Tm39TvsTgfyfFQLk+nnqIz2sBA1PthfqqfiiYSs= X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: BN2PEPF000044A4:EE_|PH8PR10MB6388:EE_ X-MS-Office365-Filtering-Correlation-Id: 581a88fe-b696-43bf-e467-08df130fa69f X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|82310400026|36860700016|376014|1800799024|23010399003|56012099006|10067099003|18002099003|22082099003; X-Microsoft-Antispam-Message-Info: 831IYc0mRQjtUzHtNY7UtlUWp7kzIo5Y7S3yyYsGDCAxyw923bizZJqS5BeCAL+wJP9GabbB2+rfCn7BLDimyIoVAhiHsZ6LPGDDap0mdpvUHTmEaJ8EQ4YgDZsawjTIrkve86eELGra5eQO3wKgvocukEs8R2yUSvYcev+OJZkTzSuWxA89J2WFlI+acmNRCUCN8sLasUJEfuh/5iLDbRDzbuFL7MPoWbIWJIvBXUXLqbxsyj6tL0LeyTGsbMgfNXoQorx9hFTCoqCMhp2cvo2aQz3CmK8Vya0CXm82baeXgvWTTkHPLcgr04TV+iFjTHeD2NNQgpSvqeSL3jxz+BtN/v8hGrWcgqZP0BCKGLydM9U2gH4Ftcj0mPk0nRSkofjXqUcHWHp5pGpV/vA4FoIZKa+dmoKTAcsXHL7kCac7zXseMaA0qDQ1eYI3MbGpvSebYeT36XA1UxLw4/5D7vPe5XelAPlLOBQWOntf6b+p+Q1yPn63eoZp3nqZZ1DSXRoSu0XHFES38DE3upeezNsrtspPM6vtxBoUimKjISivc6yKXV5q5mOw4PSQ2fQKwSzIKP5nvpatfDHkcV1Jf3uEALnibyL62XkuLQ7C0a8OSKqJNaYZmvNJRVuFJRteC6veV4RkZcDigTNdWEjQR0xXBA3hLRZZfuwNxiQ9Oh0EhKbjXyp/+BjPgv4V3hiXBrmGuqPWxfNcOfjJrCxxJw== X-Forefront-Antispam-Report: CIP:198.47.23.194;CTRY:US;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:lewvzet200.ext.ti.com;PTR:InfoDomainNonexistent;CAT:NONE;SFS:(13230040)(82310400026)(36860700016)(376014)(1800799024)(23010399003)(56012099006)(10067099003)(18002099003)(22082099003);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: LmXx9HhXgPtGgpyfRYBsb958PwcF407sz4eWf7SUsvFXkjKBvJQt6N1uGjYYsC93da/baJA5ZvqyhaJtLKtBcFfVqsazG4ul0bkGyOQabHXDItrkhCFkqRWJ/LPjiVLw/cF0xihQcziOh9+oA76CjDQ2eNnvwM86IWYwlD6UP5RE4WqleHtz4FNNfDvl2HwfPbtSpNz2cxE+BPLxVPJs2cEwU2sGAZx/VlCJrr9EvUjVN12Z48yKpHGR6nZF6mR/jBGj3oR7UFIfIMunyjctV3Ytja7CQQ5ARZHcAs/ftnJf2r4O4h4Dax3f1CtWIjeeKyXZCLCw2CRc8wJOw+1i3MMXi1AVQ56n6S6HWARyEbmHGu7Mc7E//bO3if4E25BHLrUzMUrdRVeFH00VxgA38wyN27mJenMc3DEASLdGfCLE/Q6eAFveoM4IR9iGAlP3 X-Exchange-RoutingPolicyChecked: k6B6WpwmG49QmevLfn6tBWI9cXgE9olsChEC3I2kZtuU0r03ObeHUMNuJ8reP37al7CF4oN352nixwSPT44svMztqjPul3Z7bSGjM0hoL3ECWim17fWV5x9sCFzgqQdPW7V0n7uZfeCSYZWFZbgibithGuNZhXPc0H6hm4SAz1TQ70BifPY/AZjDO6UtSk3WRn+IqliXq2rrEeusnaxk5A83Vc9fXfcG7RVyillidSQ45rS1cB+UpciCZR/N2OcDp9PJa33oVyYhsZoWj24Xh4s1XzVyyXLPRr2g/16YT69cOgKke/TxdwaFg3+a9q+npXJ2s9o3xW7o91ZsXxPaBg== X-OriginatorOrg: ti.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 15 Sep 2026 09:56:44.9573 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 581a88fe-b696-43bf-e467-08df130fa69f X-MS-Exchange-CrossTenant-Id: e5b49634-450b-4709-8abb-1e2b19b982b7 X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=e5b49634-450b-4709-8abb-1e2b19b982b7;Ip=[198.47.23.194];Helo=[lewvzet200.ext.ti.com] X-MS-Exchange-CrossTenant-AuthSource: BN2PEPF000044A4.namprd02.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH8PR10MB6388 X-Proofpoint-Spam-Info: AW1haW4tMjYwOTE1MDE0MyBTYWx0ZWRfXyuugHSQ3c0h0 CFLjSte90GP7EM1HE8NJnZDBDXNCMyPKuyWOlHynhJ7tnbxFuYy1K0+z65Eku8fh9L+YzseQokH 7s7t9BSK+r8RAy5AIKemMUm7qomJRmQ= X-Authority-Analysis: v=2.4 cv=KvnYSmWN c=1 sm=1 tr=0 ts=6aa91661 cx=c_pps a=DKBbczBT0NfZzOMt9NccUg==:117 a=WotqVVQAdb04rnGuttW3Kw==:17 a=6eWqkTHjU83fiwn7nKZWdM+Sl24=:19 a=IkcTkHD0fZMA:10 a=VdqzKS8jKosA:10 a=s63m1ICgrNkA:10 a=V5UXEbMT0ywA:10 a=VkNPw1HP01LnGYTKEx00:22 a=Z8NIEmU8O1QQgoT56wFK:22 a=fPAWb5peG099m5CrUpKH:22 a=sozttTNsAAAA:8 a=tAoYmFjvGA8ZcGrWVaQA:9 a=QEXdDO2ut3YA:10 X-Proofpoint-ORIG-GUID: IysCiCcs2UoqGCvZ9DnP7wCutp9GVta- X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwOTE1MDE0MyBTYWx0ZWRfX13tZC/VkfDOG t/4bjxJcaYteDxNbUwfj5swtjKwV/f37G9z6mIHSVWL3vmp8lRJ/r5c8cn+QDZNGfqPrWwDReYu by6O4/QbQYpyoi/woiLn9AffLLmECF7u0zg+t/nslR4LLF8Y8qQi6xXB8FCaTQ13SQHbvcB6Jbv JRQKgwRXkp3es+vBOHkdHLo3Go8ZXQDGPvhHWvnF5QkbFiwKakYOoBDQGgiPWfjfVYaBXfPlATg Q0ikOj1UifSiJwRVAc2J3HIInAptNl6IMwnCEwjGGtRWVr+Is40Y/N9VQFKBgbHBhM+1Qwagrh/ /PaGfNpjQyvJ0i70ec6jzLEJxp5zBRs8FoLts7SlupHEyVziKn1TQbkfQshMq9ciUxgQXQK9Cd7 quglEWyyMtdKm6kA9He0fTGkx+gOl7hhRfPaiWtEB//+aqnNCNkptxoeLQ5Ts7JaJuJ+hJuSSk/ SIypgydXRiZ31CHZN3A== X-Proofpoint-GUID: IysCiCcs2UoqGCvZ9DnP7wCutp9GVta- X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1176,Hydra:6.1.134,FMLib:17.12.100.49 definitions=2026-09-15_03,2026-09-14_02,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 lowpriorityscore=0 clxscore=1015 priorityscore=1501 impostorscore=0 suspectscore=0 spamscore=0 bulkscore=0 adultscore=0 phishscore=0 malwarescore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2609040000 definitions=main-2609150143 The current code just writes ipad/opad into the sa2ul context but SA2UL requires the intermediate digest to be programmed into it. Export the intermediate hash state before big endian processing to program the correct state in SA2UL. Assisted-by: Sisyphus:claude-sonnet-4-6 Signed-off-by: Manorit Chawdhry --- drivers/crypto/sa2ul.c | 15 ++++++++------- 1 file changed, 8 insertions(+), 7 deletions(-) diff --git a/drivers/crypto/sa2ul.c b/drivers/crypto/sa2ul.c index f89e84c5529b..36c8403b5713 100644 --- a/drivers/crypto/sa2ul.c +++ b/drivers/crypto/sa2ul.c @@ -400,6 +400,14 @@ static int sa_export_shash(void *state, struct shash_d= esc *hash, u32 *result; int ret =3D 0; =20 + /* Export the intermediate digest to program into SA2UL */ + ret =3D crypto_shash_export(hash, state); + if (ret) { + dev_err(sa_k3_dev, "%s: crypto_shash_export failed\n", + __func__); + return ret; + } + switch (digest_size) { case SHA1_DIGEST_SIZE: sha1 =3D state; @@ -415,13 +423,6 @@ static int sa_export_shash(void *state, struct shash_d= esc *hash, return -EINVAL; } =20 - ret =3D crypto_shash_export(hash, state); - if (ret) { - dev_err(sa_k3_dev, "%s: crypto_shash_export failed\n", - __func__); - return ret; - } - cpu_to_be32_array(out, result, digest_size / 4); =20 return ret; --=20 2.43.0 From nobody Fri Sep 25 12:05:54 2026 Received: from mx0b-0002e601.pphosted.com (mx0b-0002e601.pphosted.com [148.163.154.28]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id AC79E49C4CF; Tue, 15 Sep 2026 09:56:57 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=fail smtp.client-ip=148.163.154.28 ARC-Seal: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1789466221; cv=fail; b=ena84Sm/TCezpK8ztCUQzSj1Zsgwn7Pqzogcehl+0z9lYQ7zG2HCxpafE0NmRUbkG7FR2Jziqcn06ol7B3kmNYG0cu5T+LW4zzIfe9DC9QnqjrgA1NYAiQTi9WHLgQBumGWs71+Xg+R9JD1xciM9NnK5eWlPgSH2rcO2pZ4cqYI= ARC-Message-Signature: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1789466221; c=relaxed/simple; bh=ApNPlj/D2OLJpS6qqeB46sofqIuOmu6hWxom1CIotxQ=; h=From:Date:Subject:MIME-Version:Content-Type:Message-ID:References: In-Reply-To:To:CC; b=mKc6aJcUU/vnmkc38hl5EKKKOwBQ7aQmPsQRarKnFGxhX8P7rnCaEFbO5GlYRnWNfo7xfdW9WpZ6L+fFtvAdJn3VNpHv2PCfvbsLK/CldmR/vfBLwZXPLtTnQqkUz6N5SUO5UNLLVXiogMv+n6cgezR/YWXAXXR+UDgb6PZlyYQ= ARC-Authentication-Results: i=2; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=ti.com; spf=pass smtp.mailfrom=ti.com; dkim=pass (2048-bit key) header.d=ti.com header.i=@ti.com header.b=kbi7Xojv; dkim=pass (1024-bit key) header.d=ti.com header.i=@ti.com header.b=Diwq2Hi8; arc=fail smtp.client-ip=148.163.154.28 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=ti.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=ti.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=ti.com header.i=@ti.com header.b="kbi7Xojv"; dkim=pass (1024-bit key) header.d=ti.com header.i=@ti.com header.b="Diwq2Hi8" Received: from pps.filterd (m0374955.ppops.net [127.0.0.1]) by mx0b-0002e601.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 68F9fLlK4098113; Tue, 15 Sep 2026 04:56:52 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ti.com; h=cc :content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s= proofpoint-05-2026; bh=issG/CnsMWnjoEfnrIxZ9pnEnbbkg41rbgZNslhU1 DI=; b=kbi7Xojv1ojoiDo1YZKuccWuGqBvgcW/cLTGhAtjKdExRV/on2cXOT3Pd oh7sh2NVQE5TAdtMu/EzYpiGWZw3UIeIuODJL0a6OZvjB0OX16jXNnlq92RBdxJn sfASvA1mLH3GF05KEuxQvNlqsResP2lYbtoeWlxuVJDd6hpOaLjYwOfjH5csqwX6 RxhR08aOdO2qjm2jd8KwYt8Z50r0hwZZ6SD0u/Xe8kQJEhvnF6e9OkUjtpwGSGjg fQ9dBlXHM1sb7Txz5ZV4cRySN4vjFSp4KdAFAg2iAlW21aaO5m2iM7pnV18S4sH9 JZBpqY1taKh54J/ilK9pGx+GMH5kg== Received: from bn1pr04cu002.outbound.protection.outlook.com (mail-eastus2azon11010022.outbound.protection.outlook.com [52.101.56.22]) by mx0b-0002e601.pphosted.com (PPS) with ESMTPS id 4gpvpjakkf-1 (version=TLSv1.3 cipher=TLS_AES_256_GCM_SHA384 bits=256 verify=NOT); Tue, 15 Sep 2026 04:56:52 -0500 (CDT) ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=Bz0TO83IrUoG5x6Wk+CDi9gr562EPNXDN0xasz8Rq++sFHJEGN853eXGm9vDIRDFo3R/B7zyuoOiB7y+ikawAG1C2muQFQjlhORC3RcvdN2NLG+5KT2zserHLCGBzDSjl//HWHZzliasMEATebUajcUw25kuxV1W70F4bF9ooBU/NDU8A+Ng3EW8H+2tcg9QQ/6jYk8cy7wY0Z+hM27goA3LYmiVgwp8pMYYo8rXwGK49xt0N7/IsXh77+Y/+xdFRFr9g3NZIb2Zc0/+6w8HYTzM6uguSOews3Ouq++3X+cyVcYKP4u0px6Y1K927nbjck37JeuZT/D3mL5wZiuHIg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=issG/CnsMWnjoEfnrIxZ9pnEnbbkg41rbgZNslhU1DI=; b=GYdsXTOfSeZ5TxXfBgH9MEX09KKHrZunWhfSkQ0zGnWRjdxWDROJNNbnjpqya5DkhmoK5VLf2v/tYmCr1v1ow52ilgkZUEonKp5k98y+YjxdqVZvB2kqgrP6VlUGUoatclOmh8ZkxzagacATLolDF695NfAJbZ4KmmQ6u7pJNZJkqZbKTOa2XyRX9BX1WZITKUOHzAk+x2mhx9Y+WKT5hCLtkcEb5iWR7T0Y0jurL8u/WHB9m9MjP7T7LvjVM4bHt7DEkyIocbFAW65DnKavJuKc1d8S/rbJTWMoa+J+8yk3NZG9ktg/bsuU+2f93RvKnUAKKaYq9pEuChRACQsMiA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 198.47.23.194) smtp.rcpttodomain=vger.kernel.org smtp.mailfrom=ti.com; dmarc=pass (p=quarantine sp=none pct=100) action=none header.from=ti.com; dkim=none (message not signed); arc=none (0) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ti.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=issG/CnsMWnjoEfnrIxZ9pnEnbbkg41rbgZNslhU1DI=; b=Diwq2Hi8bbr87QPZDnIUKt9sGhWH3FSVA9VHr4WWLk6bm14p3AkQ1P5yYaQARM7YqKyvo/dO0/tswpKoi+00jfmi9jjTm/1JhJRk2+TP7RnNPJZGq+JvrD62gowHxQK5eFPqxiYL/fFbWNxJplVUeL/3Y1Z9daPHbHrQrALv8rc= Received: from BN0PR03CA0005.namprd03.prod.outlook.com (2603:10b6:408:e6::10) by BL3PR10MB6164.namprd10.prod.outlook.com (2603:10b6:208:3bf::8) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.21.428.8; Tue, 15 Sep 2026 09:56:47 +0000 Received: from BN2PEPF000044A4.namprd02.prod.outlook.com (2603:10b6:408:e6:cafe::1e) by BN0PR03CA0005.outlook.office365.com (2603:10b6:408:e6::10) with Microsoft SMTP Server (version=TLS1_3, cipher=TLS_AES_256_GCM_SHA384) id 15.21.406.12 via Frontend Transport; Tue, 15 Sep 2026 09:56:47 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 198.47.23.194) smtp.mailfrom=ti.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=ti.com; Received-SPF: Pass (protection.outlook.com: domain of ti.com designates 198.47.23.194 as permitted sender) receiver=protection.outlook.com; client-ip=198.47.23.194; helo=lewvzet200.ext.ti.com; pr=C Received: from lewvzet200.ext.ti.com (198.47.23.194) by BN2PEPF000044A4.mail.protection.outlook.com (10.167.243.155) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.21.428.7 via Frontend Transport; Tue, 15 Sep 2026 09:56:47 +0000 Received: from DLEE210.ent.ti.com (157.170.170.112) by lewvzet200.ext.ti.com (10.4.14.103) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.2562.45; Tue, 15 Sep 2026 04:56:30 -0500 Received: from DLEE203.ent.ti.com (157.170.170.78) by DLEE210.ent.ti.com (157.170.170.112) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.2562.45; Tue, 15 Sep 2026 04:56:30 -0500 Received: from lelvem-mr06.itg.ti.com (10.180.75.8) by DLEE203.ent.ti.com (157.170.170.78) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.2562.45 via Frontend Transport; Tue, 15 Sep 2026 04:56:30 -0500 Received: from uda0497581-ant.dhcp.ti.com (uda0497581-ant.dhcp.ti.com [10.24.51.159]) by lelvem-mr06.itg.ti.com (8.18.1/8.18.1) with ESMTP id 68F9tB8D3000901; Tue, 15 Sep 2026 04:56:27 -0500 From: Manorit Chawdhry Date: Tue, 15 Sep 2026 15:25:29 +0530 Subject: [PATCH 23/30] crypto: sa2ul - fix stack overflow in sa_prepare_iopads Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-ID: <20260915-b4-upstream-sa2ul-cleanup-v1-23-57ab34e97162@ti.com> References: <20260915-b4-upstream-sa2ul-cleanup-v1-0-57ab34e97162@ti.com> In-Reply-To: <20260915-b4-upstream-sa2ul-cleanup-v1-0-57ab34e97162@ti.com> To: Herbert Xu , "David S. Miller" , Keerthy , Colin Ian King CC: Andrew Davis , Pratham T , "Kamlesh Gurudasani" , Udit Kumar , , , "Manorit Chawdhry" X-Mailer: b4 0.15.2 X-Developer-Signature: v=1; a=ed25519-sha256; t=1789466112; l=6340; i=m-chawdhry@ti.com; s=20231127; h=from:subject:message-id; bh=ApNPlj/D2OLJpS6qqeB46sofqIuOmu6hWxom1CIotxQ=; b=1kw++g4eJzluIi61RDEdlRJ6/uzb6/lIdEaGk1wANinTsi8Qo0eJShrE5ECEfZiVG+NhuAiPf sMMLCA/ipg9Dstma2qQiuFpOXp+8RM686SgONH1Ag5bpy3R+75NNh0o X-Developer-Key: i=m-chawdhry@ti.com; a=ed25519; pk=fsr6Tm39TvsTgfyfFQLk+nnqIz2sBA1PthfqqfiiYSs= X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: BN2PEPF000044A4:EE_|BL3PR10MB6164:EE_ X-MS-Office365-Filtering-Correlation-Id: 85b343bc-0419-4d37-db32-08df130fa833 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|36860700016|82310400026|376014|23010399003|1800799024|56012099006|10067099003|18002099003|22082099003|6133799003|3023799007; X-Microsoft-Antispam-Message-Info: DVisMkuBLKnCtPW0RRPPsOX3jyXjWYSGe3k2C3XPtx0SUa2wcB0/fAIGEwpRRhi/vUUJRGXaBfBC+BJBwZil4k5zbIfd0cP/zjD5tAQ2Q0HpXsqFMUvw69dFdahVyOe1D40GNQyfQ6OrYGI3eZMkAlaf4ofCLoBVZJiaY1F43ia252ijys8F8x9qa4SQr6VhaEeC+uryjjAIleZ8ibfZo7WyELfibxOuZYx37kd79sf40wdIhibHWCYXavY+++zft1/P36AuVGehzRbowcV1oX04WcboyAo3Ryxdej5ZqleLfz8R5Sh5NySeOrWLVIHy2WICX2AbDeMcDl5sAijhtzIgwT5gkSeq742+6fObPC+SdBpJlFjGrLrKQfc34t0Qvc2/ahq5B3VMBGQZ8MHixk7SvLIU/Fse4XWD/LvAHk7PjjwKBmDYEK24+KTuFqu5iTalzZpN04/X2oKpwC++1ZB7J2cUTC1veGacrUzXC2ywfj/h9/IEpUt/OhT18sC3Z+56YmHYJBktk5i1X1mCCfxyRXn2asdpIIMRBSBptLgX3Wi0opc9drE19NDu2qhLq8SWNhvpUMJZFXUElMoDfAP+MXkP7A9ZDvBSfGpwMkV7FX7smpgoE9CzYblR8lbl3mh7hN68I+inJ3+Vfqv7ihoprHEA6qATLWnt3EWvwBdSSM4+IePYMd7R/jwr89i5zfAmimeRuGDCW8or8Fv0VQ== X-Forefront-Antispam-Report: CIP:198.47.23.194;CTRY:US;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:lewvzet200.ext.ti.com;PTR:InfoDomainNonexistent;CAT:NONE;SFS:(13230040)(36860700016)(82310400026)(376014)(23010399003)(1800799024)(56012099006)(10067099003)(18002099003)(22082099003)(6133799003)(3023799007);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: gbmYmEwop6fi9tbuFMy8effkTIME/68pghGreJ1Nco9MzoYibZLLOVhfzZKiWcyTFaPk/9qom1OIY3E0kjfdvkKZQNb8O54Qh4c3x/PKcdUMT0PLblLhV8+iISX7f/7v+LE4H12UeFLy20DUAhcIbMs6Edg+eg7qXjxfUTFyZiMREWQLVzuPRg9Lv6Vf630zstZ3K4ozJb7ntoQiMH3AuItB9MJGNtu1LN8mysbkKaIO+0tzTFRW86g4JhmA8PRajTt3pAE+wtzgeN2MQvbFEDILpL9Ttt6Chnf44w8Os/Vey+1BncDUrbrERBDGed1u+4wcAEChZuSi83HqfzS+UMAoSAip52/DdkhetXtlmnGPKuCAC8krqUnZ7Ed2IJCvqB8LdtHAB8rwtlemArrQI6B4lalK+ZboMVtu00UG/Ez6sOLt4fhv5i6YJB9dLE3r X-Exchange-RoutingPolicyChecked: a5lhKJLdGr75Qx5FfPEv0v828di4M1UT4o14E2h72k6BkaFb3wqON41U1x/zDuEaPshvGnUsn726/DeKSgHockJXotpqlOa9dZ1WNeujkTZVSP7eom0qoUqHsgfOAKDCzUlLQDhvCAHsxI2rhfupNTePDuPne9BGlA0FSEjvfsuK7UOdbdPWNQ2Ozd5gFNt80OH1HrAmQjDIO0uPSRtUC9kSQe2RXb38balqoGyLORD7OoiinO5yY29MvqN9tREP03uB+Ka8bshVujV3LcLiAJdWBSs+M0kbg0xnCvuryT7dfhXDnA8+ChDJTI9lWDKf0VwrBOetYYwpZI2kBkA+GQ== X-OriginatorOrg: ti.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 15 Sep 2026 09:56:47.6088 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 85b343bc-0419-4d37-db32-08df130fa833 X-MS-Exchange-CrossTenant-Id: e5b49634-450b-4709-8abb-1e2b19b982b7 X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=e5b49634-450b-4709-8abb-1e2b19b982b7;Ip=[198.47.23.194];Helo=[lewvzet200.ext.ti.com] X-MS-Exchange-CrossTenant-AuthSource: BN2PEPF000044A4.namprd02.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: BL3PR10MB6164 X-Proofpoint-Spam-Info: AW1haW4tMjYwOTE1MDE0MyBTYWx0ZWRfX9Q5ffvgCGv0A 36NfMbJ5MUZNyAV5XSroKFNrTsk8HOGDtY+VB6Wvnr00+2HTgKjaX9DI8xv/J+2dnS7rC6LkYjX McYlHyOCaYnSrXStJJSYA+Vm2ik71a8= X-Authority-Analysis: v=2.4 cv=KvnYSmWN c=1 sm=1 tr=0 ts=6aa91664 cx=c_pps a=wVrytDogCwW2gNy9sPioUw==:117 a=WotqVVQAdb04rnGuttW3Kw==:17 a=6eWqkTHjU83fiwn7nKZWdM+Sl24=:19 a=IkcTkHD0fZMA:10 a=VdqzKS8jKosA:10 a=s63m1ICgrNkA:10 a=V5UXEbMT0ywA:10 a=VkNPw1HP01LnGYTKEx00:22 a=Z8NIEmU8O1QQgoT56wFK:22 a=fPAWb5peG099m5CrUpKH:22 a=sozttTNsAAAA:8 a=AYz72fFD7cF7Bsoe0ywA:9 a=QEXdDO2ut3YA:10 X-Proofpoint-ORIG-GUID: tjIiyHi20taEoAlUQJVl6z_POV7YVOYk X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwOTE1MDE0MyBTYWx0ZWRfXyoZN27IYeMFa 3kkDvhPJeoJoZkcEowfkvC8tmShEv8T2twWuNGAE3GuG0WrGIv/17/Ltfp8RZybuLjbAvgoNZRl tCviu+Z1OEzawTGDJaX/BWdTsGNWt5WpLdRV+5aNwv9Mtk/IhGzqR2wXfwdS0++n9mGnpJLIf41 znRVMZGyOtiEMLC86s6YhpiP2cg/1AGZAKd8YvqqGokUcFm7jelPdsMRzsFGmjnTlAURRKXfvoq pWJq8q8VZPQYvL1b+hn71Sf28ufF5go07oDp4Bs9E8kTAeW+f5D+A9ZjMgMlekYd3kDcENOWRoR X07g23MweJCJl0gnVUD6Kjax1EEzBw+I17YSZADK1rzhUauxn1d4xUeS3yPIjM3EOj/+TdCuwOm URYgI6/w68Te5rkOYCr3SbxKxg9EyX9japy8gjhEgkpEB41jEySSyLOASfpf3QFy8YlxsvpEfKW TtyzH2vPqibs6ZYO5Fw== X-Proofpoint-GUID: tjIiyHi20taEoAlUQJVl6z_POV7YVOYk X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1176,Hydra:6.1.134,FMLib:17.12.100.49 definitions=2026-09-15_03,2026-09-14_02,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 lowpriorityscore=0 clxscore=1015 priorityscore=1501 impostorscore=0 suspectscore=0 spamscore=0 bulkscore=0 adultscore=0 phishscore=0 malwarescore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2609040000 definitions=main-2609150143 The sa_export_shash() function uses a fixed-size stack union to hold the hash state during export. This union was sized at 104 bytes, covering sha1_state and sha256_state but no longer including sha512_state as it did when the AEAD support was first added, leaving zero margin once crypto_shash_export() needs to write more than 104 bytes: BUG: KASAN: stack-out-of-bounds in __crypto_sha256_export.isra.0+0xf4/0x1= 38 Write of size 1 at addr ffff800084c46d78 by task cryptomgr_test/219 Hardware name: Texas Instruments J721S2 EVM (DT) Call trace: show_stack+0x18/0x24 (C) dump_stack_lvl+0x68/0x94 print_report+0x118/0x200 kasan_report+0xa8/0xe4 __asan_store1 __crypto_sha256_export.isra.0 crypto_sha256_export __crypto_shash_export crypto_shash_export sa_export_shash+0xa4/0x198 sa_prepare_iopads+0x234/0x460 sa_init_sc+0x268/0x730 sa_aead_setkey+0x20c/0x390 sa_aead_cbc_sha256_setkey+0xa4/0xe4 crypto_aead_setkey test_aead_vec_cfg test_aead_vec alg_test_aead The buggy address belongs to stack of task cryptomgr_test/219, offset 152 in frame: sa_export_shash+0x0/0x198 This frame has 1 object: [48, 152) 'sha' This reproduced on every board tested (311 occurrences on a single J721S2 EVM boot log alone), always via the authenc(hmac(sha256), cbc(aes))-sa2ul AEAD self-test. It surfaced after upstream sha256 changes (e.g. commit 3bf533787910 ("crypto: sha256 - Use the partial block API")) altered which sha256 shash implementation gets selected for hmac(sha256), but the underlying union has been undersized ever since it was shrunk to drop sha512_state. Fix this by replacing the fixed-size stack union with a dynamically allocated buffer sized via crypto_shash_statesize(). This ensures the buffer is always large enough for the current hash algorithm's state, regardless of future changes to the state structures. The buffer is allocated with kmalloc(GFP_KERNEL) and freed with kfree_sensitive() on all exit paths to prevent information leakage. Fixes: ad0bb4e4d226 ("crypto: sa2ul - Reduce stack usage") Assisted-by: Sisyphus:claude-sonnet-5 Signed-off-by: Manorit Chawdhry --- drivers/crypto/sa2ul.c | 52 +++++++++++++++++++++++++++++-----------------= ---- 1 file changed, 30 insertions(+), 22 deletions(-) diff --git a/drivers/crypto/sa2ul.c b/drivers/crypto/sa2ul.c index 36c8403b5713..265d1afaad81 100644 --- a/drivers/crypto/sa2ul.c +++ b/drivers/crypto/sa2ul.c @@ -18,6 +18,7 @@ #include #include #include +#include =20 #include #include @@ -392,39 +393,51 @@ static void prepare_kopad(u8 *k_opad, const u8 *key, = u16 key_sz) k_opad[i] =3D 0x5c; } =20 -static int sa_export_shash(void *state, struct shash_desc *hash, - int digest_size, __be32 *out) +static int sa_export_shash(struct shash_desc *hash, int digest_size, + __be32 *out) { - struct sha1_state *sha1; - struct sha256_state *sha256; u32 *result; int ret =3D 0; + int state_size; + u8 *sha; + + state_size =3D crypto_shash_statesize(hash->tfm); + if (state_size <=3D 0) { + dev_err(sa_k3_dev, "%s: invalid state_size=3D%d\n", __func__, + state_size); + return -EINVAL; + } + + sha =3D kmalloc(state_size, GFP_KERNEL); + if (!sha) + return -ENOMEM; =20 /* Export the intermediate digest to program into SA2UL */ - ret =3D crypto_shash_export(hash, state); + ret =3D crypto_shash_export(hash, sha); if (ret) { dev_err(sa_k3_dev, "%s: crypto_shash_export failed\n", __func__); + kfree_sensitive(sha); return ret; } =20 switch (digest_size) { case SHA1_DIGEST_SIZE: - sha1 =3D state; - result =3D sha1->state; + result =3D (u32 *)sha; break; case SHA256_DIGEST_SIZE: - sha256 =3D state; - result =3D sha256->state; + result =3D (u32 *)sha; break; default: dev_err(sa_k3_dev, "%s: bad digest_size=3D%d\n", __func__, digest_size); + kfree_sensitive(sha); return -EINVAL; } =20 cpu_to_be32_array(out, result, digest_size / 4); =20 + kfree_sensitive(sha); return ret; } =20 @@ -435,16 +448,11 @@ static int sa_prepare_iopads(struct algo_data *data, = const u8 *key, int block_size =3D crypto_shash_blocksize(data->ctx->shash); int digest_size =3D crypto_shash_digestsize(data->ctx->shash); int ret =3D 0; - - union { - struct sha1_state sha1; - struct sha256_state sha256; - u8 k_pad[SHA1_BLOCK_SIZE]; - } sha; + u8 k_pad[SHA1_BLOCK_SIZE]; =20 shash->tfm =3D data->ctx->shash; =20 - prepare_kipad(sha.k_pad, key, key_sz); + prepare_kipad(k_pad, key, key_sz); =20 ret =3D crypto_shash_init(shash); if (ret) { @@ -452,20 +460,20 @@ static int sa_prepare_iopads(struct algo_data *data, = const u8 *key, __func__, __LINE__, ret); return ret; } - ret =3D crypto_shash_update(shash, sha.k_pad, block_size); + ret =3D crypto_shash_update(shash, k_pad, block_size); if (ret) { dev_err(sa_k3_dev, "%s: %d: crypto_shash_update for ipad failed, ret=3D%= d\n", __func__, __LINE__, ret); return ret; } - ret =3D sa_export_shash(&sha, shash, digest_size, ipad); + ret =3D sa_export_shash(shash, digest_size, ipad); if (ret) { dev_err(sa_k3_dev, "%s: %d: sa_export_shash for ipad failed, ret=3D%d\n", __func__, __LINE__, ret); return ret; } =20 - prepare_kopad(sha.k_pad, key, key_sz); + prepare_kopad(k_pad, key, key_sz); =20 ret =3D crypto_shash_init(shash); if (ret) { @@ -473,20 +481,20 @@ static int sa_prepare_iopads(struct algo_data *data, = const u8 *key, __func__, __LINE__, ret); return ret; } - ret =3D crypto_shash_update(shash, sha.k_pad, block_size); + ret =3D crypto_shash_update(shash, k_pad, block_size); if (ret) { dev_err(sa_k3_dev, "%s: %d: crypto_shash_update for opad failed, ret=3D%= d\n", __func__, __LINE__, ret); return ret; } - ret =3D sa_export_shash(&sha, shash, digest_size, opad); + ret =3D sa_export_shash(shash, digest_size, opad); if (ret) { dev_err(sa_k3_dev, "%s: %d: sa_export_shash for opad failed, ret=3D%d\n", __func__, __LINE__, ret); return ret; } =20 - memzero_explicit(&sha, sizeof(sha)); + memzero_explicit(k_pad, SHA1_BLOCK_SIZE); =20 return ret; } --=20 2.43.0 From nobody Fri Sep 25 12:05:54 2026 Received: from mx0b-0002e601.pphosted.com (mx0b-0002e601.pphosted.com [148.163.154.28]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 7A40E47A86D; Tue, 15 Sep 2026 09:57:24 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=fail smtp.client-ip=148.163.154.28 ARC-Seal: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1789466246; cv=fail; b=J7KQR715nl3+75lF/nu8EZ+c/iQdROfQHQ9YPzG0GqvUF+KgqO4iP7ie/5/SQSksIJ89B/DNmAflQdaHRbaZu2eyrvTezkAtPqHjryoKaY8AcHClIV4iBzXZgb0hZU2jYESbUlAferTIJ0Mk/cWroN70g4AqmXjCN2RHa9dJOms= ARC-Message-Signature: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1789466246; c=relaxed/simple; bh=RcDE9iVplKFnDV4Zf6Fhqe54OYAdajcI1iK42ktIVgg=; h=From:Date:Subject:MIME-Version:Content-Type:Message-ID:References: In-Reply-To:To:CC; b=I0RNWVJ98DFOD4DWJIp/a8bEW7UMEADP+Ps0j2XrVafZ33FUiWGYGWOOqgJTDLc/sLBR/ySsSM8Zf3NaaWLLLsI+5xRHy/MfbEp60ht/rwVW5b4zyzd3VDQM2WuYQE0bW2fKxe485BWok5MYt0lof4+HE49QpP462eA04g8rtkc= ARC-Authentication-Results: i=2; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=ti.com; spf=pass smtp.mailfrom=ti.com; dkim=pass (2048-bit key) header.d=ti.com header.i=@ti.com header.b=eTRuEAhG; dkim=pass (1024-bit key) header.d=ti.com header.i=@ti.com header.b=F8/5vnk6; arc=fail smtp.client-ip=148.163.154.28 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=ti.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=ti.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=ti.com header.i=@ti.com header.b="eTRuEAhG"; dkim=pass (1024-bit key) header.d=ti.com header.i=@ti.com header.b="F8/5vnk6" Received: from pps.filterd (m0374955.ppops.net [127.0.0.1]) by mx0b-0002e601.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 68F9fQUu4098377; Tue, 15 Sep 2026 04:57:19 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ti.com; h=cc :content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s= proofpoint-05-2026; bh=e7vpzDaZ/hE37dxOKjcYG2utqQjsDtb4qlcQzB3Kq Ko=; b=eTRuEAhGPJdlykTLWc+5A7d4tg0shB1EJcYEG+sqt1h9lNXBemVBpFRlN snuxEgye/L3tDQGca4C0kLROoCBTt0UEyIjKhils6J6Dfgq8b32XvNlQ+VjVPBTB MHweuwtNaZFj5Vhade2HF/cxKKaZv2GPiqxr6kOEtjAdP3nqr8SGSvjP+PGGZmjQ I89vpNG8phe0+vEji60f40AWvwZjFHzxJb/eRatQEDhHT3PU8wdxTUtV2vK6RKn8 MpIFbGLoCVS3GwlUsgDKzB0N9F7yrwN2KC2EjCiX3BaCzfujHeQeaRpUsw9u51XW NfBTUCiCPJAG1z4yMovkJpiAOySAQ== Received: from mw6pr02cu001.outbound.protection.outlook.com (mail-westus2azon11012063.outbound.protection.outlook.com [52.101.48.63]) by mx0b-0002e601.pphosted.com (PPS) with ESMTPS id 4gpvpjaknd-1 (version=TLSv1.3 cipher=TLS_AES_256_GCM_SHA384 bits=256 verify=NOT); Tue, 15 Sep 2026 04:57:18 -0500 (CDT) ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=WPfKyCCs43ZHRJwUoHiRn4ZVcGckyXxE4BH5qEQyTTNlN1gEimqHiXSSH0xMAqnorKb+CAQ8P7c0l7dskKd4MlMaSrkW+rFlSHKsQ6pbmKGVgxLiidSBuX8hS2wpxu2Q0MmMa2YsDoYyL1qpaNWycxN4d9tPRyP/eBFRxp8EN4CY2NWEAe7OMDwLS6Gtgbt9fV1IjQkitFzDatXWeZNJznZ45N282tpJRtmMlRDmdJVo5ysxsxll6u9UZtVbA1ij79gEKL8XoQ9n1EWd9Bybzq8OXaqyaKPmoZaMzeEg7R+M2H8k9VrveOzpg34YSgA/PbnGnOhdQXbqdMMOtlZcOg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=e7vpzDaZ/hE37dxOKjcYG2utqQjsDtb4qlcQzB3KqKo=; b=XDkCPa8T+klxC0dEEBjSrDyVNi8SLecIYsoKTcxaKWmtpBGLeOGSIfD+RLSRhgNPXyRqoMneeDnzfEC6/R9CbCd+15QmPOWhIeDcFs94RNebGQOB0wzPSLBo2fY4GS+I6XDOFW6HywSM8XRfwIDEdCwf/ksE0GX1gX/A9chxp/jnplKRPnWdX8c05+k7S+PBXOMa7ABEoCxRvzt/44XDTLxDy2fgghcl0lp+DS1u10A11iSh/QdWrE+7O0XB1YmEt+pMTgdH4qFSWIEbPJ8ql0XoP3Yb725QDNjSWCdENUcwMaTvM2+IXnkLLXw7lXV53ogPm8fE5Jo6N6VwqudkFQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 198.47.21.195) smtp.rcpttodomain=vger.kernel.org smtp.mailfrom=ti.com; dmarc=pass (p=quarantine sp=none pct=100) action=none header.from=ti.com; dkim=none (message not signed); arc=none (0) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ti.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=e7vpzDaZ/hE37dxOKjcYG2utqQjsDtb4qlcQzB3KqKo=; b=F8/5vnk6dvX6Nl9X738DQZmAyWZBhP1MEjp9KFPmRsIqf7DqLJ4Ed3asDOzyF8YQ3y3DwnJBOi8dhUClNw9AVmf91oT3JZYZzUe7dQoGxpugqnBhqwHwIECcX4tmUw5i/OgzewHXDn9RPy88vZKjSLNsT/KbcOWXQOazrViY/N0= Received: from SJ2P221CA0004.NAMP221.PROD.OUTLOOK.COM (2603:10b6:a03:5db::14) by SA1PR10MB6544.namprd10.prod.outlook.com (2603:10b6:806:2bb::21) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.21.428.7; Tue, 15 Sep 2026 09:57:16 +0000 Received: from MWH0EPF000C6186.namprd02.prod.outlook.com (2603:10b6:a03:5db:cafe::2c) by SJ2P221CA0004.outlook.office365.com (2603:10b6:a03:5db::14) with Microsoft SMTP Server (version=TLS1_3, cipher=TLS_AES_256_GCM_SHA384) id 15.21.428.9 via Frontend Transport; Tue, 15 Sep 2026 09:57:16 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 198.47.21.195) smtp.mailfrom=ti.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=ti.com; Received-SPF: Pass (protection.outlook.com: domain of ti.com designates 198.47.21.195 as permitted sender) receiver=protection.outlook.com; client-ip=198.47.21.195; helo=flwvzet201.ext.ti.com; pr=C Received: from flwvzet201.ext.ti.com (198.47.21.195) by MWH0EPF000C6186.mail.protection.outlook.com (10.167.249.118) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.21.428.7 via Frontend Transport; Tue, 15 Sep 2026 09:57:14 +0000 Received: from DFLE203.ent.ti.com (10.64.6.61) by flwvzet201.ext.ti.com (10.248.192.32) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.2562.45; Tue, 15 Sep 2026 04:56:34 -0500 Received: from DFLE202.ent.ti.com (10.64.6.60) by DFLE203.ent.ti.com (10.64.6.61) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.2562.45; Tue, 15 Sep 2026 04:56:33 -0500 Received: from lelvem-mr06.itg.ti.com (10.180.75.8) by DFLE202.ent.ti.com (10.64.6.60) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.2562.45 via Frontend Transport; Tue, 15 Sep 2026 04:56:34 -0500 Received: from uda0497581-ant.dhcp.ti.com (uda0497581-ant.dhcp.ti.com [10.24.51.159]) by lelvem-mr06.itg.ti.com (8.18.1/8.18.1) with ESMTP id 68F9tB8E3000901; Tue, 15 Sep 2026 04:56:31 -0500 From: Manorit Chawdhry Date: Tue, 15 Sep 2026 15:25:30 +0530 Subject: [PATCH 24/30] crypto: sa2ul - add more checks before processing ipad/opad Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-ID: <20260915-b4-upstream-sa2ul-cleanup-v1-24-57ab34e97162@ti.com> References: <20260915-b4-upstream-sa2ul-cleanup-v1-0-57ab34e97162@ti.com> In-Reply-To: <20260915-b4-upstream-sa2ul-cleanup-v1-0-57ab34e97162@ti.com> To: Herbert Xu , "David S. Miller" , Keerthy , Colin Ian King CC: Andrew Davis , Pratham T , "Kamlesh Gurudasani" , Udit Kumar , , , "Manorit Chawdhry" X-Mailer: b4 0.15.2 X-Developer-Signature: v=1; a=ed25519-sha256; t=1789466112; l=4394; i=m-chawdhry@ti.com; s=20231127; h=from:subject:message-id; bh=RcDE9iVplKFnDV4Zf6Fhqe54OYAdajcI1iK42ktIVgg=; b=jl1VkAgxahZt8VCKtD+29iX40yedRAot0e0a2cZ6hhdd397XniE4W2wQW5SvDnLI8ZfazlOQN wjnHqtgy2u4CK/ehpEN1BX71kU1y2u+qahEWyXUp7sAvbpp5sZYssqD X-Developer-Key: i=m-chawdhry@ti.com; a=ed25519; pk=fsr6Tm39TvsTgfyfFQLk+nnqIz2sBA1PthfqqfiiYSs= X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: MWH0EPF000C6186:EE_|SA1PR10MB6544:EE_ X-MS-Office365-Filtering-Correlation-Id: e9f3bd62-fe01-4481-9943-08df130fb84f X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|376014|23010399003|36860700016|1800799024|82310400026|56012099006|18002099003|22082099003|10067099003; X-Microsoft-Antispam-Message-Info: ewUmLs2ikykyzWfq9XbxYbulBsfO3k/d55o3jeKU3ytlJ/H8uEdFNsdV9o/RGOOGh9KVmM0pajXRmiaN/0v4eJDJdYAbFA2wdV9ywf0eaxdTn973RC8EsLnonaI7Uv5ddEuhkepP30lSiHfJceC0jqjGRAKdukohEbF21MZDsrt4aTBgOS9VO7PU1gVVB7F/MBjn6As1NjmE7N7zlfb57EdA6fVT0lBRgik8luZRK8mCJgQoPLErJ32xqE1k05YdJ5eIVnTfukjRXEIkv3h1WRfP/b6j9xg++RD+H15aKB8pXFrzHWizuu7plWUq6kko8QsRCTrgfPo+ACNACwT7c5gu224Zgj1gmUwD+0ap5LK8GBPMax7idR6PaT2QXdb9XKhrcnmFIELXJwueKkqiGarX7OhOAG1DKGC7I0EH7s8NniO8jazttNf8x1vB2qURtn7dO1U6tJq8QIaAOZ1pofL2CFVX0w3nwt8R7hCmfxk3ULVbGMl2XeZ+qUkoZYNi3QqIzYJckN2R22Rc4639RozCVfTKnoWeCmp4Y7/rGWi4r9ddPC+36KaTnwmvgDltZjzOYiNiyCXLvIcNIttDTRTwIxj7KqOIzRf+iIP4K+qRiUzO515P2yV21l7mykOCG8uzYO97NHO3jA60d1HVGZRVXZqLE9B7bBIbWr2igp8bONjT/bkhT8QOoqaBExeYryetueKit8lHYrGtq5fOnQ== X-Forefront-Antispam-Report: CIP:198.47.21.195;CTRY:US;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:flwvzet201.ext.ti.com;PTR:ErrorRetry;CAT:NONE;SFS:(13230040)(376014)(23010399003)(36860700016)(1800799024)(82310400026)(56012099006)(18002099003)(22082099003)(10067099003);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: /0aaw6lpIlpQ4GRM8/dLKi2KLbeGKasSRGeB0VDZYB3GORvOtxhKRXym1Jg5M5SY7cj5sUTe8+moYJ92K0/LSz0lo2fhw0dNr5gKVNmwVwrB474l8Et3x5xt2uzMniiTw/lckfVNrputljFy+IRq/n3ra8nCUaWqf54+6/fwiXQfUujv5jGYeU94oQIXRlyAX4sH/vQa84iNLZJL7pTV5Ic++Vusq7X58BIfKjcc7K2TZr6/gcox7jUh8tC3c/yaiDVAa1DwudaE/1etaJr1KZ5p769SO8Rjx9hunDGKha1iTaHYXcIMS7WkOemTB7nQbp9gNuzqo+CRwzURZLfBtsQwneUatO38uK0JPOX1PcIwtCWYNzIYt/OdptldZETGmM69sZtUI0xZoAEy0QF3lWVLi1qPtGaRBjMlR4aq4C4c0JuoI6JQcw424cSQHaXi X-Exchange-RoutingPolicyChecked: cJK0syKDjjb5GIwdGsqvvFJEDCM+U9dDP91s3znsVrhk1J37zokeuqU1DhR61k8l4WwxVv5hdjVkLJgwwmzrV9Iw1j9BJVR8qrUIjg0d5FtrjsN4bLe+136ysQE7jGE3jTBzyOqaCe3y5VLFk/2ReXNQ91nKIlI5FRmALb+wIU3ZqcvTkDuJHaM0FotcSBsTsIsdu7TGnBQ0ck7MFVcbThqtwJFlV4ijSth+wt0UzZpeUq9YskS1+FttYi5Kvfs4fKr3PMcsXCQh2Bm5g6s1cpshXrn2I2vp9GlnG5J8gy06xPBPpBlpAt5Ra7R/vAr41YZITU55ujoIwmJeJIS8tA== X-OriginatorOrg: ti.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 15 Sep 2026 09:57:14.6154 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: e9f3bd62-fe01-4481-9943-08df130fb84f X-MS-Exchange-CrossTenant-Id: e5b49634-450b-4709-8abb-1e2b19b982b7 X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=e5b49634-450b-4709-8abb-1e2b19b982b7;Ip=[198.47.21.195];Helo=[flwvzet201.ext.ti.com] X-MS-Exchange-CrossTenant-AuthSource: MWH0EPF000C6186.namprd02.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: SA1PR10MB6544 X-Proofpoint-Spam-Info: AW1haW4tMjYwOTE1MDE0MyBTYWx0ZWRfX2LyIud6J7cd6 pL4Z39MjlqWVlzqIZNbgriKNZguGcTSSrMFsD5LFkTJH2vrVKzczom5tGnVTcj6Zr7UpPTHk2GN 4xvqiPG4e0H4jVMg6gwOCzyMnowCma4= X-Authority-Analysis: v=2.4 cv=KvnYSmWN c=1 sm=1 tr=0 ts=6aa9167f cx=c_pps a=m+Y8nsmXU8Fd5URmI4pqsQ==:117 a=tJyPKKxUohctrY4NYmUjkA==:17 a=6eWqkTHjU83fiwn7nKZWdM+Sl24=:19 a=IkcTkHD0fZMA:10 a=VdqzKS8jKosA:10 a=V5UXEbMT0ywA:10 a=VkNPw1HP01LnGYTKEx00:22 a=Z8NIEmU8O1QQgoT56wFK:22 a=fPAWb5peG099m5CrUpKH:22 a=sozttTNsAAAA:8 a=K37ofz1H7Ls3PSt_8rcA:9 a=QEXdDO2ut3YA:10 X-Proofpoint-ORIG-GUID: uYpd4BoKT0xd6ZkuxLAH9wBvp_Eg1MLr X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwOTE1MDE0MyBTYWx0ZWRfXwnVATfRgWr+R pro8C4uwAt/vARLsROj/TfiPbLBqNj1XRducqrHMHpZ9yqpvHxQg9D+vkh8tF9Q6PNhqFeA/7Bm VByEbidf2+H7b9X1erVjobhQWB3BX5HCe3YK2pfyJl7DdWykmvaA0kKiYhV94V5GxcbPcW+noEW tAQCxg/GyXiIzDDXYsT0AJ3LFxzNJzB0tEGFzYftvKJn0VsJ+mQ59V1u1ARVsAw+phd0eSKwHxF EA6DE+s5+FbQXzZAUx899hu++GRtbwvneOy8p0S0NK5Hx3T8fXtxk1IquZMu9IK3mytoXOR9hhv iToABUM7i66cfkZ57bsNCHN3i0reBmk/ZILw8l5Zw8DocoHLi0GvE+f+MdQk2qvdnT4WkvWZIyT Xj/UEUBwcnnKfHMXLActZLwzFzZO5ehRn9Ph90boS59T9Ug50Hij76Tc6LKsaD+Fy/FVNmIv8Ww TOmCskfHtlVSzV2lPOw== X-Proofpoint-GUID: uYpd4BoKT0xd6ZkuxLAH9wBvp_Eg1MLr X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1176,Hydra:6.1.134,FMLib:17.12.100.49 definitions=2026-09-15_03,2026-09-14_02,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 lowpriorityscore=0 clxscore=1015 priorityscore=1501 impostorscore=0 suspectscore=0 spamscore=0 bulkscore=0 adultscore=0 phishscore=0 malwarescore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2609040000 definitions=main-2609150143 When the key_sz is greater than the block_size then we need to hash it with the transform to process it further. To avoid repeated hashing for the key for individual ipad/opad, merge the prepare_kipad and prepare_kopad in sa_prepare_iopad itself. Also as per fips standard, there is a minimum key size requirement so check that based on fips enablement to return the appropriate error code. Since the framework doesn't provide the intermediate hash, replicate the checks of the framework and make sa2ul code similar to that. Fixes: d2c8ac187fc9 ("crypto: sa2ul - Add AEAD algorithm support") Assisted-by: Sisyphus:claude-sonnet-4-6 Signed-off-by: Manorit Chawdhry --- drivers/crypto/sa2ul.c | 63 +++++++++++++++++++++++++---------------------= ---- 1 file changed, 31 insertions(+), 32 deletions(-) diff --git a/drivers/crypto/sa2ul.c b/drivers/crypto/sa2ul.c index 265d1afaad81..cd5cd9182bdb 100644 --- a/drivers/crypto/sa2ul.c +++ b/drivers/crypto/sa2ul.c @@ -12,6 +12,7 @@ #include #include #include +#include #include #include #include @@ -24,6 +25,7 @@ #include #include #include +#include #include #include #include @@ -368,31 +370,6 @@ static void sa_swiz_128(u8 *in, u16 len) } } =20 -/* Prepare the ipad and opad from key as per SHA algorithm step 1*/ -static void prepare_kipad(u8 *k_ipad, const u8 *key, u16 key_sz) -{ - int i; - - for (i =3D 0; i < key_sz; i++) - k_ipad[i] =3D key[i] ^ 0x36; - - /* Instead of XOR with 0 */ - for (; i < SHA1_BLOCK_SIZE; i++) - k_ipad[i] =3D 0x36; -} - -static void prepare_kopad(u8 *k_opad, const u8 *key, u16 key_sz) -{ - int i; - - for (i =3D 0; i < key_sz; i++) - k_opad[i] =3D key[i] ^ 0x5c; - - /* Instead of XOR with 0 */ - for (; i < SHA1_BLOCK_SIZE; i++) - k_opad[i] =3D 0x5c; -} - static int sa_export_shash(struct shash_desc *hash, int digest_size, __be32 *out) { @@ -448,11 +425,34 @@ static int sa_prepare_iopads(struct algo_data *data, = const u8 *key, int block_size =3D crypto_shash_blocksize(data->ctx->shash); int digest_size =3D crypto_shash_digestsize(data->ctx->shash); int ret =3D 0; - u8 k_pad[SHA1_BLOCK_SIZE]; + int i =3D 0; + u8 k_ipad[SHA1_BLOCK_SIZE]; + u8 k_opad[SHA1_BLOCK_SIZE]; + + if (fips_enabled && (key_sz < 112 / 8)) + return -EINVAL; =20 shash->tfm =3D data->ctx->shash; =20 - prepare_kipad(k_pad, key, key_sz); + if (key_sz > block_size) { + int err; + + err =3D crypto_shash_digest(shash, key, key_sz, k_ipad); + if (err) + return err; + + key_sz =3D digest_size; + } else { + memcpy(k_ipad, key, key_sz); + } + + memset(k_ipad + key_sz, 0, block_size - key_sz); + memcpy(k_opad, k_ipad, block_size); + + for (i =3D 0; i < block_size; i++) { + k_ipad[i] ^=3D HMAC_IPAD_VALUE; + k_opad[i] ^=3D HMAC_OPAD_VALUE; + } =20 ret =3D crypto_shash_init(shash); if (ret) { @@ -460,7 +460,7 @@ static int sa_prepare_iopads(struct algo_data *data, co= nst u8 *key, __func__, __LINE__, ret); return ret; } - ret =3D crypto_shash_update(shash, k_pad, block_size); + ret =3D crypto_shash_update(shash, k_ipad, block_size); if (ret) { dev_err(sa_k3_dev, "%s: %d: crypto_shash_update for ipad failed, ret=3D%= d\n", __func__, __LINE__, ret); @@ -473,15 +473,13 @@ static int sa_prepare_iopads(struct algo_data *data, = const u8 *key, return ret; } =20 - prepare_kopad(k_pad, key, key_sz); - ret =3D crypto_shash_init(shash); if (ret) { dev_err(sa_k3_dev, "%s: %d: crypto_shash_init for opad failed, ret=3D%d\= n", __func__, __LINE__, ret); return ret; } - ret =3D crypto_shash_update(shash, k_pad, block_size); + ret =3D crypto_shash_update(shash, k_opad, block_size); if (ret) { dev_err(sa_k3_dev, "%s: %d: crypto_shash_update for opad failed, ret=3D%= d\n", __func__, __LINE__, ret); @@ -494,7 +492,8 @@ static int sa_prepare_iopads(struct algo_data *data, co= nst u8 *key, return ret; } =20 - memzero_explicit(k_pad, SHA1_BLOCK_SIZE); + memzero_explicit(k_ipad, SHA1_BLOCK_SIZE); + memzero_explicit(k_opad, SHA1_BLOCK_SIZE); =20 return ret; } --=20 2.43.0 From nobody Fri Sep 25 12:05:54 2026 Received: from mx0b-0002e601.pphosted.com (mx0b-0002e601.pphosted.com [148.163.154.28]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 3030E3A542B; Tue, 15 Sep 2026 09:56:52 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=fail smtp.client-ip=148.163.154.28 ARC-Seal: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1789466215; cv=fail; b=FN7Zfg3v8dnV4d4199NpizHKQpMyOpyb//vOy2by06TTkkkbK1quDDPer1rqcJMTjnBvlocbLK2cYJhlvAX6jMoQ2/cSEkTOZgSguCjqGiCtgtOtZyGg28XKC4qiRGS8jxIxdu9Y5qYDOZVT2tGsc8vZwXq0PFtkyiPHG73wX3c= ARC-Message-Signature: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1789466215; c=relaxed/simple; bh=v27iqbCBNd4mzZ1V2fiVYfiujSIiy9dJHAacoAUbHQ0=; h=From:Date:Subject:MIME-Version:Content-Type:Message-ID:References: In-Reply-To:To:CC; b=F7SoFc5mBQ03LrRR+l2n14dtiMYnHpz3aCDLfVXgPmIT5+ZMDsfMDzeMBkUA0DtbW5OVbeXAERCkauJ3FXJ6qxFNVspCwaiCeBqMx0knuIv8yeWP8fFktMi9+NhtVu7l2LcNc1o/a69ngDGv5GEVpaS6IJcxawpTTyc49crpbWk= ARC-Authentication-Results: i=2; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=ti.com; spf=pass smtp.mailfrom=ti.com; dkim=pass (2048-bit key) header.d=ti.com header.i=@ti.com header.b=Bp63/0pw; dkim=pass (1024-bit key) header.d=ti.com header.i=@ti.com header.b=hIQO1fWF; arc=fail smtp.client-ip=148.163.154.28 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=ti.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=ti.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=ti.com header.i=@ti.com header.b="Bp63/0pw"; dkim=pass (1024-bit key) header.d=ti.com header.i=@ti.com header.b="hIQO1fWF" Received: from pps.filterd (m0374955.ppops.net [127.0.0.1]) by mx0b-0002e601.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 68F9fKVK4098102; Tue, 15 Sep 2026 04:56:48 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ti.com; h=cc :content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s= proofpoint-05-2026; bh=o3nLt6vGS9cHT63eyxVlt2ezTTkVEMnRZ14Hr7dOa y8=; b=Bp63/0pwRRHnRVEsU2Gmoqd/8iExC+PuWjt0yW/jdSwun+KmHhu9G4HKS QAPz/pLczFCaY8JeWa3B3jKdLK8YuAgKMJ4ooLeVzkQalLzi7ZgkWfGu7AzIubTY FpGMmJhc7vffyeKR9ZBywmJCKKEAAq6fEsliimw7wMcypJxgtd+TyzbBZ2mFvgKT GA02el5QAgy9+X59GwLGb9hrmuDobdT/bLvRxXpXkOKUd5SUEyX6auutfls62gcP +JPE+unfIET+YTrs1HiWvXsL0Ty46TNsbot0YDRMEaJa4idKogcqfByBh/ScTYBo 8cj6y8hFpI8EJDt9epoGPsvOHbqIg== Received: from bn1pr04cu002.outbound.protection.outlook.com (mail-eastus2azon11010001.outbound.protection.outlook.com [52.101.56.1]) by mx0b-0002e601.pphosted.com (PPS) with ESMTPS id 4gpvpjakjw-1 (version=TLSv1.3 cipher=TLS_AES_256_GCM_SHA384 bits=256 verify=NOT); Tue, 15 Sep 2026 04:56:48 -0500 (CDT) ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=ow6HEnQpybOF015qxdAPMcHWkFUwYDymvSTQ6Z8ZKqIeuCxlrqVSUkh5n0BPPtYqZoBJ/nWNckLwoZHIOROjp53hTDWAJhrThhSQW5Ro6UlalG+pm+zrXNNar+Rh8KdmYfJ/kAGVia5Fnoy8eglply0P8JW8EZIwosrYV1rmLhhG6s4BmjoSeaTQcLmeql/ERy6rzJvdOxzPkGEbv4zEb5pLhzXmvEKorXYVY/hIDnAj+DWxDCplbZGHJTbEUlb3HAmrCxIh5CogM7qOg1LCn69wNQgsi/9vVAYtM+Vval7t85+rDGmyq4jOuEKKLE+1M4U7dShgehm5hJnVT5Wbew== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=o3nLt6vGS9cHT63eyxVlt2ezTTkVEMnRZ14Hr7dOay8=; b=HwDrGRBvXonVK4os2IP/jyXQW8RvAqhlueGZeVKIMip8KKUWhSs3lDFP+gzxbb5C4ZquCTGY0QuiZBGNlrmX5cOiHwGhFOrDvY1Beh59YVHjeCR9zKIeaegpkaco3P0+O4fb3pgz/UH5XHPDU64yb80/boiGkvI/4pTTXyInAqCdeSMa9G0SWxoiKRM+6snXCrQ7dHzjY4Bt/xGFj8Q9+2R2hnlUbue03EjtP59uBjZgiKi8X/kzhHP4NlFACbn8Vl83NAdam/p55NVq9a0+l42h6SsxbYq0ysZCReo16szCeO4E2LjCjOt78Od1xfsdXP0aRrpPmo5bD1+ZSVxVdA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 198.47.23.195) smtp.rcpttodomain=vger.kernel.org smtp.mailfrom=ti.com; dmarc=pass (p=quarantine sp=none pct=100) action=none header.from=ti.com; dkim=none (message not signed); arc=none (0) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ti.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=o3nLt6vGS9cHT63eyxVlt2ezTTkVEMnRZ14Hr7dOay8=; b=hIQO1fWFIXrHrzmo7JvaGvcqmiuuL/VHd19ZESMK3HG4UifEQ6a4Pv1vztSucysrAWQrVDyFGaf5BKi9e2YNIXYcwdpavhBFRxYJYB3dGLoNuai/fecCRMHLYzKFTzQBzOH0qDviitsv0kQBiOx5ohKht4WF8yZVxRD83ZbTNU0= Received: from BN9PR03CA0792.namprd03.prod.outlook.com (2603:10b6:408:13f::17) by DS7PR10MB5198.namprd10.prod.outlook.com (2603:10b6:5:3a5::24) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.21.406.5; Tue, 15 Sep 2026 09:56:45 +0000 Received: from LV8PEPF00000067.namprd03.prod.outlook.com (2603:10b6:408:13f:cafe::77) by BN9PR03CA0792.outlook.office365.com (2603:10b6:408:13f::17) with Microsoft SMTP Server (version=TLS1_3, cipher=TLS_AES_256_GCM_SHA384) id 15.21.406.12 via Frontend Transport; Tue, 15 Sep 2026 09:56:45 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 198.47.23.195) smtp.mailfrom=ti.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=ti.com; Received-SPF: Pass (protection.outlook.com: domain of ti.com designates 198.47.23.195 as permitted sender) receiver=protection.outlook.com; client-ip=198.47.23.195; helo=lewvzet201.ext.ti.com; pr=C Received: from lewvzet201.ext.ti.com (198.47.23.195) by LV8PEPF00000067.mail.protection.outlook.com (10.167.248.39) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.21.428.7 via Frontend Transport; Tue, 15 Sep 2026 09:56:45 +0000 Received: from DLEE204.ent.ti.com (157.170.170.84) by lewvzet201.ext.ti.com (10.4.14.104) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.2562.45; Tue, 15 Sep 2026 04:56:37 -0500 Received: from DLEE206.ent.ti.com (157.170.170.90) by DLEE204.ent.ti.com (157.170.170.84) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.2562.45; Tue, 15 Sep 2026 04:56:37 -0500 Received: from lelvem-mr06.itg.ti.com (10.180.75.8) by DLEE206.ent.ti.com (157.170.170.90) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.2562.45 via Frontend Transport; Tue, 15 Sep 2026 04:56:37 -0500 Received: from uda0497581-ant.dhcp.ti.com (uda0497581-ant.dhcp.ti.com [10.24.51.159]) by lelvem-mr06.itg.ti.com (8.18.1/8.18.1) with ESMTP id 68F9tB8F3000901; Tue, 15 Sep 2026 04:56:34 -0500 From: Manorit Chawdhry Date: Tue, 15 Sep 2026 15:25:31 +0530 Subject: [PATCH 25/30] crypto: sa2ul - fix data corruption by skipping device sync on unmap Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-ID: <20260915-b4-upstream-sa2ul-cleanup-v1-25-57ab34e97162@ti.com> References: <20260915-b4-upstream-sa2ul-cleanup-v1-0-57ab34e97162@ti.com> In-Reply-To: <20260915-b4-upstream-sa2ul-cleanup-v1-0-57ab34e97162@ti.com> To: Herbert Xu , "David S. Miller" , Keerthy , Colin Ian King CC: Andrew Davis , Pratham T , "Kamlesh Gurudasani" , Udit Kumar , , , "Manorit Chawdhry" X-Mailer: b4 0.15.2 X-Developer-Signature: v=1; a=ed25519-sha256; t=1789466112; l=1352; i=m-chawdhry@ti.com; s=20231127; h=from:subject:message-id; bh=v27iqbCBNd4mzZ1V2fiVYfiujSIiy9dJHAacoAUbHQ0=; b=sfmt85vUH7+2aXI9iVmmAIV1hcnJWsgGvvzldVymwYIzpwRtmk05g00n8UTbE8rOrmEu32CdM X24/T/+lrPsDaRqPU/SPH/6zKHcpIwIIiznorBmqdOfIbXp7MGRESA+ X-Developer-Key: i=m-chawdhry@ti.com; a=ed25519; pk=fsr6Tm39TvsTgfyfFQLk+nnqIz2sBA1PthfqqfiiYSs= X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: LV8PEPF00000067:EE_|DS7PR10MB5198:EE_ X-MS-Office365-Filtering-Correlation-Id: 53eb4fe0-064d-40df-8604-08df130fa6df X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|23010399003|1800799024|376014|36860700016|82310400026|10067099003|56012099006|22082099003|18002099003; X-Microsoft-Antispam-Message-Info: BXr58zcyaqelI5wtTpvgdR1crn9WCV+Xs5QW+lup1E9q/1jCHYWqS9DoF0kAOw+bZiZXRwQCAgsIGeYEPrbqklnTaWPAvNvWLg4ny0fytuMjJJAvsdCRtO1oxvjSBueeRe5H9hXqrIZBz4dKWhJm0d0GqjdDvnmTL7LS7Ck9gx8zoSY8KsTqe4MMM7fpTBB0/1OAEoZ8U9VJ1GNwRRkWyBX4LX8sUz4oF7Ei75Kcp8A8d432/y6rtr7Hk/qxRU1tKIwPasu9GNAK5WRIgqMEQByHXggnXOicrG9qIAE4MLXrSOlGD3B00EtKqXx/z8q2zp5OY7vhnfKRYG/wf63mUx4irt23ljZZiDRN3OlUNQfWmUrqy1USxzBt4xpK3RWn7367Bh4zMcZWehUv2SWvx427WSudIwiXNqJGtD1aq1zJR+/UEBhQiTlb6ZtcVvJvju2bOhHBFdvJvLVNZQAebpP09f3MSQWkEwJNCluec89TlYqWzGz0o450AyOj4mz01nHaL7crahSg81qse6UiMIkkpZ8XgmQJSD0u9lfBFl8El+E8CuRI5EpvGfSTa1jMr/7+2kMZwnEjutXHyf4jle04jgdscS2I4pr4HdkDSn/SY0P5vX3VYJpwgefMY170ib1Lh5/8lOoI3rEkfyvPakTWri93RCgSywntErE7yIjPrFbGnm9fl3+B+3/foeQZ2XVZtHU2woj0OwayvN2FSQ== X-Forefront-Antispam-Report: CIP:198.47.23.195;CTRY:US;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:lewvzet201.ext.ti.com;PTR:InfoDomainNonexistent;CAT:NONE;SFS:(13230040)(23010399003)(1800799024)(376014)(36860700016)(82310400026)(10067099003)(56012099006)(22082099003)(18002099003);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: K4ZrAIFS+CvR+7RwOSVAEZLimWhm+O0KebSb07cUJA/kNMLRC6aAUQKlTVwTvWD1yrp51XIcjoL891wBbB8SCiwU5QVqfQCziIRAkx6I1oBAztCT5OutgnS4zKhQxwZLHx1vB54Cknu9zl6ifdw09lEdrNetcY2w2oiE/u3Apg5hojaw7uadyICqVgf5BUhNoJOBXQDAJkUkZVoyQ4voUVy//M9C40hBbKzFktLfOY8aDinxYxhdW5WoAW3kL43ek+172wPEYAHJ0nx8ExViirOijt5g9LYqvc837j/3Klvd8TyN/qIRyHvfup314t9fLFT6OW5BfPFIA1Otz+cP6pGC7elimia1KerC2qZG+nJu890foC9zkVB4opS6P6RdAAAE+AeNC0veRXhs2rXv6n19P1H65WwB2TgB6CKPcbQIjpZhbEzC63JLaLmuIv/i X-Exchange-RoutingPolicyChecked: jU2Zx74+5E5nzgk0M0IQm4Criu+aPLx/N4NjH2lmssJPTcxoSJ9uyAIRXLx/rQ+Z7882TcoGLPzY2K0bV30lfjCRlncDT0rHObKuaejN4nmCXcPwIlYNW9EX/g45emy4ZOVEm79IaNXQ4nKy6fanvTQf/sQCoSaTtd4Ljvtux5oVFcLPgIlrInhXzjptw3NH0G+yNxdEIKUi+hya7PgYm1y9mJAti9b8uMXFojsaP+cDgic6OULLgX/HCcC3d87GxZMCj7H5IiyndhoTAe/QBo0r0ExMt5A/sAEC+IJbgc3+yVTl+O+jfGQpiEGwL/fHD4TJ8MxGRsEv9xgqMB4PYA== X-OriginatorOrg: ti.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 15 Sep 2026 09:56:45.3788 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 53eb4fe0-064d-40df-8604-08df130fa6df X-MS-Exchange-CrossTenant-Id: e5b49634-450b-4709-8abb-1e2b19b982b7 X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=e5b49634-450b-4709-8abb-1e2b19b982b7;Ip=[198.47.23.195];Helo=[lewvzet201.ext.ti.com] X-MS-Exchange-CrossTenant-AuthSource: LV8PEPF00000067.namprd03.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: DS7PR10MB5198 X-Proofpoint-Spam-Info: AW1haW4tMjYwOTE1MDE0MyBTYWx0ZWRfX+9iq3M2DrlTC 9D6rFb3xTDj2tYocPOLDeEP0zfr3l0FVb4qNsonCsMMhqgPlBv+2J9wHpcCSMoxDnPHAbB7UUi4 6Acj6gy8aCXX5lqUk8QJhKkIDYj6N/w= X-Authority-Analysis: v=2.4 cv=KvnYSmWN c=1 sm=1 tr=0 ts=6aa91660 cx=c_pps a=qHW1pi9L+1RZ0SKNcL3CYw==:117 a=f+v6EHfkeJbVwR46tk4DMg==:17 a=6eWqkTHjU83fiwn7nKZWdM+Sl24=:19 a=IkcTkHD0fZMA:10 a=VdqzKS8jKosA:10 a=s63m1ICgrNkA:10 a=V5UXEbMT0ywA:10 a=VkNPw1HP01LnGYTKEx00:22 a=Z8NIEmU8O1QQgoT56wFK:22 a=fPAWb5peG099m5CrUpKH:22 a=sozttTNsAAAA:8 a=6SFUuACjUt8MkCrBzXIA:9 a=QEXdDO2ut3YA:10 X-Proofpoint-ORIG-GUID: odVJQ6S7cjWj576q_jK6sSbwHVIivzKg X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwOTE1MDE0MyBTYWx0ZWRfXwXDmdx/mW64+ +uzE0dRjdqvK5ritZ+dxWhm2thEQLihupiNNcpyxb7kfVbyd4lA1Pc78uuxji0eMDycnXd9ZJ8Q FchSXLUrhd8KWLD/1Mn8RIWYRD67EYPJDTDX15s3N6T0MLmkJOg2jzRv2XrP8rbZfH7j3mk14w8 AIFbaQIqZWPca4uPUY90VfUdPKHmbHrsC/Nt/6+Res/hczMiWDiHXE1fI/Y5OivZZB69y3JiO4Y r5rkaXuaCtWa5Cw++dhPpS7GDs2570aKcezDoKNb70NM1Utsz1yCT95x/PsfnpKhEZQzmKXWfx3 ZJvb/Bzb1ZeO25xHImSoSlfcPCN8jPMZJRl6ufQPEWMRszWdY+IIwMTXr0t7xadSwf7C+15+TiP jnB8HzR0ekCiT5U8v2ILaQR0hV/kYaBePinW3/G9dSBuqMvrZ8DpzdlM3pr/8pXXehdzlQRN9ip hz9rG9sfvmaIfRGAFgA== X-Proofpoint-GUID: odVJQ6S7cjWj576q_jK6sSbwHVIivzKg X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1176,Hydra:6.1.134,FMLib:17.12.100.49 definitions=2026-09-15_03,2026-09-14_02,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 lowpriorityscore=0 clxscore=1015 priorityscore=1501 impostorscore=0 suspectscore=0 spamscore=0 bulkscore=0 adultscore=0 phishscore=0 malwarescore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2609040000 definitions=main-2609150143 The sa_free_sa_rx_data() function is called after explicitly syncing DMA buffers to CPU via sa_sync_from_device(). Between the sync and unmap, the DMA completion callbacks read and modify the buffer contents to extract results. Without DMA_ATTR_SKIP_CPU_SYNC, dma_unmap_sgtable() performs a device-to-CPU cache sync, which invalidates the CPU cache and overwrites the CPU's modifications with stale device data. This causes data corruption where processed results are lost. Add DMA_ATTR_SKIP_CPU_SYNC to keep the buffer in CPU domain after the explicit sync, preventing the unmap operation from corrupting the modified data. Fixes: 00c9211f60db ("crypto: sa2ul - Fix DMA mapping API usage") Assisted-by: Sisyphus:claude-sonnet-4-6 Signed-off-by: Manorit Chawdhry --- drivers/crypto/sa2ul.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/crypto/sa2ul.c b/drivers/crypto/sa2ul.c index cd5cd9182bdb..5e0ef12eb02b 100644 --- a/drivers/crypto/sa2ul.c +++ b/drivers/crypto/sa2ul.c @@ -1059,7 +1059,7 @@ static void sa_free_sa_rx_data(struct sa_rx_data *rxd) =20 if (mapped_sg->mapped) { dma_unmap_sgtable(rxd->ddev, &mapped_sg->sgt, - mapped_sg->dir, 0); + mapped_sg->dir, DMA_ATTR_SKIP_CPU_SYNC); kfree(mapped_sg->split_sg); } } --=20 2.43.0 From nobody Fri Sep 25 12:05:54 2026 Received: from mx0b-0002e601.pphosted.com (mx0b-0002e601.pphosted.com [148.163.154.28]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 148E947DF97; Tue, 15 Sep 2026 09:57:33 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=fail smtp.client-ip=148.163.154.28 ARC-Seal: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1789466255; cv=fail; b=AjUCsOofBRqMrXB2yZ6/l49Q2OmElQkQhK7APnsJ6HRPn2J/gzxZFE/6XKmT9NxihDPD6vBXz06h9VKUPXxFduKBNmP8V3NuOaOMqxrdrfE2uM1jt4RgpAi0r6ofpH8gvqymQxr6SbpJnEjVxUxDzCTHiLN6lAyYJP5jP7lwuSY= ARC-Message-Signature: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1789466255; c=relaxed/simple; bh=Co40b5y5PFO0m5hwueQ++uDe8w3o13WGlqq4nue966c=; h=From:Date:Subject:MIME-Version:Content-Type:Message-ID:References: In-Reply-To:To:CC; b=seFPjzStG1M1BS/14iMFYDq5pz8GmYW635LS4C356FsqJjLCC4ieZp8dvZulPHSylaT7lb+PSDV7xTYi4ezlGm+LmTPzr15Hqn3nGppquBHDksMj9EqP9IIp2HBn9esnxe9ib6VY4c3eiE0fPREwGFK5RAnoM7VTwBoyPV+wPYk= ARC-Authentication-Results: i=2; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=ti.com; spf=pass smtp.mailfrom=ti.com; dkim=pass (2048-bit key) header.d=ti.com header.i=@ti.com header.b=I7rT+b7a; dkim=pass (1024-bit key) header.d=ti.com header.i=@ti.com header.b=fxZTXg+T; arc=fail smtp.client-ip=148.163.154.28 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=ti.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=ti.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=ti.com header.i=@ti.com header.b="I7rT+b7a"; dkim=pass (1024-bit key) header.d=ti.com header.i=@ti.com header.b="fxZTXg+T" Received: from pps.filterd (m0374955.ppops.net [127.0.0.1]) by mx0b-0002e601.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 68F9fQTf4098406; Tue, 15 Sep 2026 04:57:29 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ti.com; h=cc :content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s= proofpoint-05-2026; bh=Vl5Pbjq0urGlWkTO4hAkMBUKaXvHbYKLLOVLaEKB9 8c=; b=I7rT+b7ax6Vee58TBP6ftK5J6yb5+DfdoOnHgPuBAbTdT6XHMSEI0288R axgV5HtVvMsWpQDf7nrlulOE8r7ZjsAzB/Z/7M8yfKo+4fT3x35LKI334Q8LHbsu OSnbRH2WCTK8SwkPaatsJioPjTpZX6j+fWuWa8CtnZyACEYDNZ+cffDZ5Sv4MpuF oQegrUWKggSS2sWq6amz4HB5lK6KwkL5S6qYDadcBDYFzCQkSv6DsLlNKLAwDTMH uXVyIADIwPLOy5Pj/71Yg8fquXOL4Z4A4J4Dlc5qmrlSrCDW2GIPnv5McR6Ez3kb Bgp3LuvBcO4GaojFUWj6gTfKnT+bA== Received: from sj2pr03cu001.outbound.protection.outlook.com (mail-westusazon11012008.outbound.protection.outlook.com [52.101.43.8]) by mx0b-0002e601.pphosted.com (PPS) with ESMTPS id 4gpvpjakpc-1 (version=TLSv1.3 cipher=TLS_AES_256_GCM_SHA384 bits=256 verify=NOT); Tue, 15 Sep 2026 04:57:29 -0500 (CDT) ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=m2IuwawDQbeqyFZuyOBMaKzllunamLiyIzOWdMg2Y1q/X47ZRvQ3rsNXzkDoa7Cqf2eMhF8jY5vhARcKDpN0wOhP9f98qvVLyiGKCJnMeTICaWQHpPOGbXl/HutrCRuMzMcDgkwRDVOK2gaVSY7PF0v2r+CYnar4R+c7xcusUUs2YtI0pb2q7xe5LTa5/RDVYx55fhQXqyHY6qMQNzUduBH9GqReh9qN3FSIgEW5SilBWJzs4JuSMter1Az4YqiEUfN6r/UVpsPxt9B/qzog6/VOcN3JJ7qjwgB0ANx0QHf70G88Gml+Lrn5nmFRqyB06xRyMmAvJiSOXKWM5U805g== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=Vl5Pbjq0urGlWkTO4hAkMBUKaXvHbYKLLOVLaEKB98c=; b=hXbZn2mN+GKx3id6LVVfnDRRo0jkU7YpAO8qbtvJS0XBkKOiWC1u1ZbFD5oAZsKoEV4iCu+xW13mBq5BfaiXv0ANQtcA+jQkJaGYXiqtPk3iWlowFYit3vuB5y07jvapQ0JkZ3lMofqsovOw6jRMwJVH2gQc85KnUSx71y4pzaoAyan3QJnFUqZT79pcEVfDm61AS6n4qqu7lwZF5gzIpAXAJRElwiXQzR4IlKbHHI6uXOYAdZOsQ8BhkiTqQ9S3h2igZlSstBJlFqTs1Asfy4lwIdwB0W5wj9nE8qc7B5TzipqxFrwkT8j9Odt0iMvQiLneu+zNyRhht3tesKFZPA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 198.47.21.195) smtp.rcpttodomain=vger.kernel.org smtp.mailfrom=ti.com; dmarc=pass (p=quarantine sp=none pct=100) action=none header.from=ti.com; dkim=none (message not signed); arc=none (0) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ti.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=Vl5Pbjq0urGlWkTO4hAkMBUKaXvHbYKLLOVLaEKB98c=; b=fxZTXg+T2L0aejwNUYng/wZpBVpNcbQZUJxwKKDvKxgckIg8GIHudEti98JQzFwTm+08MpjpSFRZE7OxuOIzC0eyzbB6z3iy5oUFsRlyhaZyqApYWGGW4Pmodf7832qFneA8/wLiB5H5azAastR5BREUp8juXCALsUS0w2hYVbA= Received: from SJ2P220CA0014.NAMP220.PROD.OUTLOOK.COM (2603:10b6:a03:5da::14) by DS4PPF509E676A9.namprd10.prod.outlook.com (2603:10b6:f:fc00::d1d) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.21.428.9; Tue, 15 Sep 2026 09:57:26 +0000 Received: from MWH0EPF000C6187.namprd02.prod.outlook.com (2603:10b6:a03:5da:cafe::2e) by SJ2P220CA0014.outlook.office365.com (2603:10b6:a03:5da::14) with Microsoft SMTP Server (version=TLS1_3, cipher=TLS_AES_256_GCM_SHA384) id 15.21.428.9 via Frontend Transport; Tue, 15 Sep 2026 09:57:26 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 198.47.21.195) smtp.mailfrom=ti.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=ti.com; Received-SPF: Pass (protection.outlook.com: domain of ti.com designates 198.47.21.195 as permitted sender) receiver=protection.outlook.com; client-ip=198.47.21.195; helo=flwvzet201.ext.ti.com; pr=C Received: from flwvzet201.ext.ti.com (198.47.21.195) by MWH0EPF000C6187.mail.protection.outlook.com (10.167.249.119) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.21.428.7 via Frontend Transport; Tue, 15 Sep 2026 09:57:24 +0000 Received: from DFLE207.ent.ti.com (10.64.6.65) by flwvzet201.ext.ti.com (10.248.192.32) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.2562.45; Tue, 15 Sep 2026 04:56:40 -0500 Received: from DFLE200.ent.ti.com (10.64.6.58) by DFLE207.ent.ti.com (10.64.6.65) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.2562.45; Tue, 15 Sep 2026 04:56:40 -0500 Received: from lelvem-mr06.itg.ti.com (10.180.75.8) by DFLE200.ent.ti.com (10.64.6.58) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.2562.45 via Frontend Transport; Tue, 15 Sep 2026 04:56:40 -0500 Received: from uda0497581-ant.dhcp.ti.com (uda0497581-ant.dhcp.ti.com [10.24.51.159]) by lelvem-mr06.itg.ti.com (8.18.1/8.18.1) with ESMTP id 68F9tB8G3000901; Tue, 15 Sep 2026 04:56:37 -0500 From: Manorit Chawdhry Date: Tue, 15 Sep 2026 15:25:32 +0530 Subject: [PATCH 26/30] crypto: sa2ul - use correct DMA direction in sa_sync_from_device Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-ID: <20260915-b4-upstream-sa2ul-cleanup-v1-26-57ab34e97162@ti.com> References: <20260915-b4-upstream-sa2ul-cleanup-v1-0-57ab34e97162@ti.com> In-Reply-To: <20260915-b4-upstream-sa2ul-cleanup-v1-0-57ab34e97162@ti.com> To: Herbert Xu , "David S. Miller" , Keerthy , Colin Ian King CC: Andrew Davis , Pratham T , "Kamlesh Gurudasani" , Udit Kumar , , , "Manorit Chawdhry" X-Mailer: b4 0.15.2 X-Developer-Signature: v=1; a=ed25519-sha256; t=1789466112; l=1174; i=m-chawdhry@ti.com; s=20231127; h=from:subject:message-id; bh=Co40b5y5PFO0m5hwueQ++uDe8w3o13WGlqq4nue966c=; b=A0JM6fY9ADbHEd81xuFCiSUygLBQDX6ZS71cKFnDPBbB+Y4HSdodHzBonhBh/booq9ku/Gy9M 0RAzMm1acdLC+rJYoxS62Js+RnwcAcUWC3bQBGoAUXTfz/0C6ZUnxST X-Developer-Key: i=m-chawdhry@ti.com; a=ed25519; pk=fsr6Tm39TvsTgfyfFQLk+nnqIz2sBA1PthfqqfiiYSs= X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: MWH0EPF000C6187:EE_|DS4PPF509E676A9:EE_ X-MS-Office365-Filtering-Correlation-Id: ebc75f79-03db-4dd3-4b1a-08df130fbe62 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|36860700016|23010399003|376014|82310400026|1800799024|56012099006|10067099003|18002099003|22082099003; X-Microsoft-Antispam-Message-Info: hWm4OcvPfF86UTd0ClO3LauVz/ZBHxYQKL2bAwOYoa0Orq2zCjxzrnuKvMgZPPj/FsecaWyI+isgxUE/DUWa2B+R5IG0U5XWgSgvzt8EEkzmhfG0YwXhKAzp1Gwh3tyN+vtA1QUIbmSLxl5y7VNTUVsAJJ3TlZVJq3OH1hRI6eV7EeJNU1YTa8viAQrMI5+2ekUWhXs8LcdDi42V71a/SnPPP9LAIyVK+EBciVf60+8rYVJGl+8ijAQdSaRGdJONZvpCbIlXoCoNqJH0NFhrmHX9wJVAAe2ZL/9KPG6DN7vFruND7rWBUAA0pxexuCwGrw51dnWKfL6x/cwZbQ/4vOv2bvv5lMhbFoFM0TDvmGT+yc9To9ObIREcz8R25rDRp5HLcS/kwb3oN7iDTUfU5FEhWUq/pOCSeQ6F/FjxcMXDqQFX3y9ZhMKG2sDBWG7YSdl8hjys75J/7EokiI3lVQTHDSpU4PHsU7aulmyWVhl9zS8sndYOtnKafKQkSslu0sudZjVYl1S7pWVXdZi6rPp2CZ2I+4+yQM3g6qFwxygs0JdmEd7WUKxWOb2Wfj9Pxh29M1+XLQbmTbwP347eX6qKnMQu5ulND1SFHNOMYku8jYl6cq3ADgNjwR2romRTk9qiQ8Xiwy8/0sY58e91vFJMOcfvsSwOhbLZvFUM9w1cJM4Yq7fw5mRbS2MfO3pWet24s3GbWMF65TtR8+d0Wg== X-Forefront-Antispam-Report: CIP:198.47.21.195;CTRY:US;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:flwvzet201.ext.ti.com;PTR:ErrorRetry;CAT:NONE;SFS:(13230040)(36860700016)(23010399003)(376014)(82310400026)(1800799024)(56012099006)(10067099003)(18002099003)(22082099003);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: Xukga2QbxYWlaeFZkVTqK6a3n4lgkqJFCWRPy2fS2ZpCa8tTMSX57TTzxcuWsZPxDZtIYdBu7GYOEW+w6aYn9lLDGZS/oQtkBLyw8b6QG6MDpaAJe7B9vX+WQEywc72A7lUdIY7hI0MV1SzywJKXc3uZph8fvEA11J2QJ+Vaxw/Fg4jbS2PLuFvxFlgwI9KQJi8k82hncSqjVdXsRLmwh1ndYY0+4PkkaDNOKtyoGWhrfanlEaRBkFSo6VsTZz9MWe4WOsSlxRVB8B12fYNCCkkN3yubMuLOa57C4jbM5ouEJi+zXDyhq5YalEVujq54CS4UKSpeek2x81TH52QIuceciE9pEJX1+q9pXocN6IeGkCbTl1+bH1mMvPNlJrB1tI8ZjRHGng89W/BErWABqNzd8aDH3k+MYdBSh0vHFMpKcm4AJB2fRvkovhd1YYii X-Exchange-RoutingPolicyChecked: DXqEVF8UUNvIiAip+pGMXvlXupzIOJrzXWkvKX5HrNxkk4bBYnTPR409/gouBhRTNR9qyYJyoKCx+aMblRwLYKfruhIMPtvD+VIZmRkRUNkHcwLgSyXTwr1ssd05XJY1utZ2S7CDXj04Kl/+7a858B9hBtQ6qO5SwplYTAQduUQ30pQLQurcbryFC9BqhEfBdlJGp5fKZIptq4eastewO5vPEAq36qgIQdHSRV6bwh0MWHMytv6Qx0suewWlVPrGkQRWmCvEnOUOZKycvs1pkda6C5yNTFgoQKd2Y0zAFLIAKMR68XvSUrLHqdqLU9NSQACYrq3//yaFhMBORmdv9A== X-OriginatorOrg: ti.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 15 Sep 2026 09:57:24.8147 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: ebc75f79-03db-4dd3-4b1a-08df130fbe62 X-MS-Exchange-CrossTenant-Id: e5b49634-450b-4709-8abb-1e2b19b982b7 X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=e5b49634-450b-4709-8abb-1e2b19b982b7;Ip=[198.47.21.195];Helo=[flwvzet201.ext.ti.com] X-MS-Exchange-CrossTenant-AuthSource: MWH0EPF000C6187.namprd02.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: DS4PPF509E676A9 X-Proofpoint-Spam-Info: AW1haW4tMjYwOTE1MDE0MyBTYWx0ZWRfX8Xbl8SIdZQNd yes27vQCP4/4jvEtHRHszgz1u/9KDg8Gy7nryGxYVCgcgvLZUbz3ergBJ/Wei/xFbgDGjXy3FpJ JSfc/y8B+r6pzgByl0j6zfdfsY1rK4Y= X-Authority-Analysis: v=2.4 cv=KvnYSmWN c=1 sm=1 tr=0 ts=6aa91689 cx=c_pps a=cGIxddJ9FFYnYBVvYRB3uQ==:117 a=tJyPKKxUohctrY4NYmUjkA==:17 a=6eWqkTHjU83fiwn7nKZWdM+Sl24=:19 a=IkcTkHD0fZMA:10 a=VdqzKS8jKosA:10 a=V5UXEbMT0ywA:10 a=VkNPw1HP01LnGYTKEx00:22 a=Z8NIEmU8O1QQgoT56wFK:22 a=fPAWb5peG099m5CrUpKH:22 a=sozttTNsAAAA:8 a=Vir26vXXUzd-kgAFZqQA:9 a=QEXdDO2ut3YA:10 X-Proofpoint-ORIG-GUID: ioOY0-MAfOfesB1shft2pUdGlio3ZXM9 X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwOTE1MDE0MyBTYWx0ZWRfX+oAPx6wYBrLa jtIZ8dVTi3BquCgmzyTThWyQtvS7DI9H4/+emkP7C3iyhwSMlO+DXR4f8IkECtmvXfVzRhsWjtU 0ylsZJXIaycEAqfzhQD+fNu8WPXLm6knteCKmdRTPKyiqg86/Zc03emwvq055uk50z0ZWyZi/M5 XiwRTLGjzxKvQMkkUgPNVAZW55UmE6J0eMmYTKI/aTQG9yDWmVd8SUFV8Uqk5bxnJ6BC1VSUn41 HCVXNWPoRmb4/hRgBfb8L/bhgIvyPRm71h6uE2LZNwL7D0Db4SjXwoMf5MBU3gDJcid0tQvBGyX dcDX1baVV40yOQk15FxZov1yYlPNI8lPikIiB+JBwzM5rxbbUvrlIhh6YBKFFpmxrTgSccO4WyX wBr0lH/zwKlGGOhfSVvtLwShS26/q583ocAa7ZyfAn/1ZpDRuHcnPyRXvFtQ55vx5lhL5RlGdru ZRmHLV0yNHM3oT+pLeQ== X-Proofpoint-GUID: ioOY0-MAfOfesB1shft2pUdGlio3ZXM9 X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1176,Hydra:6.1.134,FMLib:17.12.100.49 definitions=2026-09-15_03,2026-09-14_02,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 lowpriorityscore=0 clxscore=1015 priorityscore=1501 impostorscore=0 suspectscore=0 spamscore=0 bulkscore=0 adultscore=0 phishscore=0 malwarescore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2609040000 definitions=main-2609150143 Use correct DMA direction during sa_sync_from_device for proper cache coherency handling. Fixes: 00c9211f60db ("crypto: sa2ul - Fix DMA mapping API usage") Assisted-by: Sisyphus:claude-sonnet-4-6 Signed-off-by: Manorit Chawdhry --- drivers/crypto/sa2ul.c | 10 +++++++--- 1 file changed, 7 insertions(+), 3 deletions(-) diff --git a/drivers/crypto/sa2ul.c b/drivers/crypto/sa2ul.c index 5e0ef12eb02b..df905b391339 100644 --- a/drivers/crypto/sa2ul.c +++ b/drivers/crypto/sa2ul.c @@ -1041,13 +1041,17 @@ static int sa_3des_ecb_setkey(struct crypto_skciphe= r *tfm, const u8 *key, static void sa_sync_from_device(struct sa_rx_data *rxd) { struct sg_table *sgt; + u32 dir; =20 - if (rxd->mapped_sg[0].dir =3D=3D DMA_BIDIRECTIONAL) + if (rxd->mapped_sg[0].dir =3D=3D DMA_BIDIRECTIONAL) { sgt =3D &rxd->mapped_sg[0].sgt; - else + dir =3D rxd->mapped_sg[0].dir; + } else { sgt =3D &rxd->mapped_sg[1].sgt; + dir =3D rxd->mapped_sg[1].dir; + } =20 - dma_sync_sgtable_for_cpu(rxd->ddev, sgt, DMA_FROM_DEVICE); + dma_sync_sgtable_for_cpu(rxd->ddev, sgt, dir); } =20 static void sa_free_sa_rx_data(struct sa_rx_data *rxd) --=20 2.43.0 From nobody Fri Sep 25 12:05:54 2026 Received: from mx0a-0002e601.pphosted.com (mx0a-0002e601.pphosted.com [148.163.150.75]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 563AE48097D; Tue, 15 Sep 2026 09:56:59 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=fail smtp.client-ip=148.163.150.75 ARC-Seal: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1789466225; cv=fail; b=hYQ0+2eQNf8iZ1Du4darGB6WuRlY0esYuYZkZ+ZMgOreOlqhY74aIpt1q06i+wqa8FVWkW9UqHjijZ4NpmT8FVRGG/PtIQL2PLDIh0GstA29Bzj8bLeaucPMnc3PzzoCkKdpxhNAk5Yb5O5ezy8voCGhAjYZBmxlkVIV4Xt2uyo= ARC-Message-Signature: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1789466225; c=relaxed/simple; bh=gJRHm+l+PovcyNHXjfMAO7cE0Xy3l7kOdG6zKHpQwcU=; h=From:Date:Subject:MIME-Version:Content-Type:Message-ID:References: In-Reply-To:To:CC; b=H7wGCgCFpxRi0sX2lCHZ7P/80oNEDOCz3Ia9dwDBeFfmt50wK/2j2kLg6ib2KtouDE8alkXk2V8oESH8VmBt2qfHx6J3Hh45AleiqbT0JWtVvtj+qNXCPeQ9iyeM1GSug0zP/TIBd9cQpHT+eYyxo+BXL+vKdnoEhLnP4Gd36Fg= ARC-Authentication-Results: i=2; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=ti.com; spf=pass smtp.mailfrom=ti.com; dkim=pass (2048-bit key) header.d=ti.com header.i=@ti.com header.b=Y6b+3eDE; dkim=pass (1024-bit key) header.d=ti.com header.i=@ti.com header.b=KyWTHpTD; arc=fail smtp.client-ip=148.163.150.75 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=ti.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=ti.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=ti.com header.i=@ti.com header.b="Y6b+3eDE"; dkim=pass (1024-bit key) header.d=ti.com header.i=@ti.com header.b="KyWTHpTD" Received: from pps.filterd (m0384305.ppops.net [127.0.0.1]) by m0384305.ppops.net (8.18.1.11/8.18.1.11) with ESMTP id 68F9ejRb1480545; Tue, 15 Sep 2026 04:56:55 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ti.com; h=cc :content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s= proofpoint-05-2026; bh=ywuciZr0VaixwqTyLbk4oAHUaPLNNq0WqLMLxZVut Mc=; b=Y6b+3eDEVoBCcOVE00nfM7UdyDdsjJyy+HvfZYykn2EDpkUFwT03lJnX5 H0gWr5DwRLD1SkELZSNS24Y7OPWSIpmOzSO+jhoFcYW5fVil3U5u+Rj8QfNbfHNU 2roe/UBlBwIXzV5JfAeZ5MnzVyQoGwX1HF9IHp9ne6M3IfFudmb2nk35N3Awe3dQ l+eyc5wGmD6Ic3/g1zZ2t/1uAQCglVCqTHenNRVfFOOHfPSJ0ulM9BH7Jx06HE0C Qrzg5zsEZDfeE29302qpthBgb4Q5Euq3X9E90j120Qx5uDIyBwYCMZFYMWjE3T6Z boeXhn17l+sGsQs0xxs4ADGpr+GnA== Received: from bl0pr03cu003.outbound.protection.outlook.com (mail-eastusazon11012041.outbound.protection.outlook.com [52.101.53.41]) by m0384305.ppops.net (PPS) with ESMTPS id 4gpvpa2j3h-1 (version=TLSv1.3 cipher=TLS_AES_256_GCM_SHA384 bits=256 verify=NOT); Tue, 15 Sep 2026 04:56:54 -0500 (CDT) ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=jEjyGv+t9bfxbaoRqYoL3ZI+SnNbYH7TgwcUHE4OacRMpBKShX4aPc95AMls0j3uDUQ3yAdv1BFaCpzqFFUcq+1DCmo5qx5IU40RqnIzRIPmEDNquSUfgrQFKW8PiRUw3nMRV783WTwdO+MnA+DpnB2A3kwVkGjRhCZS+O31nS3TO1uW3+NEZJyLagRVPh4NuGkYP9HrJBQjlzzb4fa285uF8l+ZXVy4Mlxu4z5rGST5QrM4m6KAxdESCA2UOXzs48giYqU5wO6R3YTCqXNaPyzPiXpO6TzGfKf5PxrHO0xWsgmowiZJIIU+2V/edcv8/g9a1ryJ0jIFsI7zMKq5LA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=ywuciZr0VaixwqTyLbk4oAHUaPLNNq0WqLMLxZVutMc=; b=ZSidKoIE8RxTLXBRgrAUuLpgvdqJc/MM/zPOkbTNeJaZpsqqL/FlzIQLAk5bOED3CajFfPnzvRmla6Kdmg50MWZB6h/FsqCXdoHfEaaRZX2kW+5czUoTjA5hQhNEl6x88UKzvkEFj7AE1iklcFk1wclzR4+qYoHmf1Bf65N1UZj0jsLx700DGeV8TBiLL+KUlncii621TJxrKrMkwY4NgKjWakX5Ze+ceJvB4qnWeheXttPcFL1xPQzXFy85MR0jQn/zllhtY1qRhBIoFAKJJ+k+2WjdOzRF2YyUKHC1enLQxiFaBvF99gdj1DNwxTU3UvkHO835jXSBeF9cfDTN+A== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 198.47.23.195) smtp.rcpttodomain=vger.kernel.org smtp.mailfrom=ti.com; dmarc=pass (p=quarantine sp=none pct=100) action=none header.from=ti.com; dkim=none (message not signed); arc=none (0) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ti.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=ywuciZr0VaixwqTyLbk4oAHUaPLNNq0WqLMLxZVutMc=; b=KyWTHpTDQ1oV5gnDYOfJStWU8h5Y/H0M2Xb3cKJDhD8bOFlCwDWs5dDCUyjS4hT3M4/ld7z3J3D4KkdU7QAuHAwRrHnQogT20QhWNUkBXDUxlGbhkINbJkUpmKVu233XatY53eXh0a6YEGxoY+yUX5wD1TeGOZjgL5MOYYD/2MI= Received: from BN9PR03CA0786.namprd03.prod.outlook.com (2603:10b6:408:13f::11) by BN0PR10MB5014.namprd10.prod.outlook.com (2603:10b6:408:115::5) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.21.428.9; Tue, 15 Sep 2026 09:56:51 +0000 Received: from LV8PEPF00000067.namprd03.prod.outlook.com (2603:10b6:408:13f:cafe::af) by BN9PR03CA0786.outlook.office365.com (2603:10b6:408:13f::11) with Microsoft SMTP Server (version=TLS1_3, cipher=TLS_AES_256_GCM_SHA384) id 15.21.406.12 via Frontend Transport; Tue, 15 Sep 2026 09:56:51 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 198.47.23.195) smtp.mailfrom=ti.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=ti.com; Received-SPF: Pass (protection.outlook.com: domain of ti.com designates 198.47.23.195 as permitted sender) receiver=protection.outlook.com; client-ip=198.47.23.195; helo=lewvzet201.ext.ti.com; pr=C Received: from lewvzet201.ext.ti.com (198.47.23.195) by LV8PEPF00000067.mail.protection.outlook.com (10.167.248.39) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.21.428.7 via Frontend Transport; Tue, 15 Sep 2026 09:56:51 +0000 Received: from DLEE204.ent.ti.com (157.170.170.84) by lewvzet201.ext.ti.com (10.4.14.104) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.2562.45; Tue, 15 Sep 2026 04:56:43 -0500 Received: from DLEE205.ent.ti.com (157.170.170.85) by DLEE204.ent.ti.com (157.170.170.84) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.2562.45; Tue, 15 Sep 2026 04:56:43 -0500 Received: from lelvem-mr06.itg.ti.com (10.180.75.8) by DLEE205.ent.ti.com (157.170.170.85) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.2562.45 via Frontend Transport; Tue, 15 Sep 2026 04:56:43 -0500 Received: from uda0497581-ant.dhcp.ti.com (uda0497581-ant.dhcp.ti.com [10.24.51.159]) by lelvem-mr06.itg.ti.com (8.18.1/8.18.1) with ESMTP id 68F9tB8H3000901; Tue, 15 Sep 2026 04:56:40 -0500 From: Manorit Chawdhry Date: Tue, 15 Sep 2026 15:25:33 +0530 Subject: [PATCH 27/30] crypto: sa2ul - change dma_alloc_pool to mempool Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-ID: <20260915-b4-upstream-sa2ul-cleanup-v1-27-57ab34e97162@ti.com> References: <20260915-b4-upstream-sa2ul-cleanup-v1-0-57ab34e97162@ti.com> In-Reply-To: <20260915-b4-upstream-sa2ul-cleanup-v1-0-57ab34e97162@ti.com> To: Herbert Xu , "David S. Miller" , Keerthy , Colin Ian King CC: Andrew Davis , Pratham T , "Kamlesh Gurudasani" , Udit Kumar , , , "Manorit Chawdhry" X-Mailer: b4 0.15.2 X-Developer-Signature: v=1; a=ed25519-sha256; t=1789466112; l=4723; i=m-chawdhry@ti.com; s=20231127; h=from:subject:message-id; bh=gJRHm+l+PovcyNHXjfMAO7cE0Xy3l7kOdG6zKHpQwcU=; b=c8sU5p73w/vQO3ZhEJLroa3wW96sssyFMGR2P55Ru234Pc2i+fQT7gJypkarWcXcA8rZooJFC 8rn+BYJveDWBimM5gBBhBj4qdEZeXkpEWCmAzsyNb9KH8dTF/2B/l7m X-Developer-Key: i=m-chawdhry@ti.com; a=ed25519; pk=fsr6Tm39TvsTgfyfFQLk+nnqIz2sBA1PthfqqfiiYSs= X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: LV8PEPF00000067:EE_|BN0PR10MB5014:EE_ X-MS-Office365-Filtering-Correlation-Id: 20388b43-c16d-4909-cb01-08df130faa56 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|376014|1800799024|23010399003|82310400026|36860700016|56012099006|22082099003|18002099003|10067099003; X-Microsoft-Antispam-Message-Info: JyKjmc30MsW6V67j8Uf+nMreDjQ+WeAQ33jNlipSTpoKmJuNdKN5n5AO9aJuipIOHz+wfIwFW/CK6z8c76wAVx27V4LYOXaH2TSPgXVWmhQz5zvyb8XK4+bC7cQDoqKSfhb78wX9wFDqn/iUxjAGjYAhjFyhsYXam1/yyeHOB2q8bXKwzCQ8p7LWJwmW9Ql9HI6iwF41OXQ3GnAhBOy9lUPvzR1iz61e8GalBNrH+ov9UswQ4s7sJOcLlE2z+RPfBTmnhqYcXfAt+6Mdf3KcEhxbCyBOrv7FFRia78xKrGinipno07j4gUMJwTUT42gRGr/GFf/FWbG09pKj1UCG7eCJyMJp8e5FyEb54AVmgezC27jk1nlnVsrhkAcF/cjOobMyW9HG75qDRGTnrh5zCWkCYEN62k4/MjPaEavSxncMR/Da4aNKY2wE/T5bBRtCQVJPuNGG2Ry6k1Y0Jm9uZFw/lhwQ968IOpPX77Dqboe1ZSDMwit7a7gFMdBJbEsc9dt8R5kLUse0f+DX4MV9hEtnyduPhrHkM2S+ZicnvFeaF04vxdPvV3qsnSzBLx66Imlw2sm0lZOL0RA0b115ylWUTObt6iRg5q0S2YlSplVrUQfiDq1IxvyivB0s8sVM1XQ5YsZQb58NIbVigU5KNi52GAwR2FVo/eh0eGgqW85VXfLtH2LWMo89j5lG8Um32QrW0QEbdOyzP5k+oEZc8g== X-Forefront-Antispam-Report: CIP:198.47.23.195;CTRY:US;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:lewvzet201.ext.ti.com;PTR:InfoDomainNonexistent;CAT:NONE;SFS:(13230040)(376014)(1800799024)(23010399003)(82310400026)(36860700016)(56012099006)(22082099003)(18002099003)(10067099003);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: ZkrnfW5hA98K5mBWjf4aZeh9bc+X/KM1zrlVjgKduY/j79HkPlpfPvQ8kFOew0OgMb/wKmMAPPIVzrwLv2CsBM/wDyiAQbCXwOd0g3ZdnLicamzmLXdKW9kHAMlHxzpvcPRaE7sXfzXlWSvHDQ8taMaUSmu6tgqEVrbMahA0749oS65yz316qdlVQ2l/mOSgM95+eE3snMndxUEGX/TsW2kqPrfF/HHDXOVaSQvbqfBxuFDNZHpnnwMWXJvQcC/ya9jQXoA1FsSXr7Ew7dTCFpD+R8a8s7h9w2HNR1S7GBBHntXfsZfeYE3xLlwDZwSyNZZCt9HxDvVXZWf6oju/Tqxgqzj/i5lE85FBrA83yYnRzg5sVTC8lUPjFqfQlKrLAdntjtvOxqUX268DHyey01IwsTf4FB7fhWY1nFeVhUCC/96PSWk1fCkCEbloZv1A X-Exchange-RoutingPolicyChecked: AFJAvDHws4M+BZPdSZfdw4o7+iYKYAc4d+kuuLOF/7ZmBh2xNwPYoQN+fykxib1+VmyVBGqYMi2DCkj9z1S7adZ8nyRrGj5XPz1DvVCmTinUFq/Ch33fHrRjwHeXYC0VsNfou6zrT6iTNQWKwzr8QWULPBvkPY77qN1DJqoRXU2yZoU2hNpSCYsA6uCVkq9Ok44Ck6nHoen1LGC2ndoOlxj1C9zj6seYTdNJIeCNfLnhR67nMwFoizdVcbgmYxDLHERG7AGVa7HN5eAvWbzLQ3Jvu6Vr1aPhi9+emoZbAOzVGFfswd4buf0JSW+aaB1V3HDN75yvLf8ElYnvEALbaA== X-OriginatorOrg: ti.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 15 Sep 2026 09:56:51.1972 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 20388b43-c16d-4909-cb01-08df130faa56 X-MS-Exchange-CrossTenant-Id: e5b49634-450b-4709-8abb-1e2b19b982b7 X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=e5b49634-450b-4709-8abb-1e2b19b982b7;Ip=[198.47.23.195];Helo=[lewvzet201.ext.ti.com] X-MS-Exchange-CrossTenant-AuthSource: LV8PEPF00000067.namprd03.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: BN0PR10MB5014 X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwOTE1MDE0MyBTYWx0ZWRfX34JeSbSMXkwn vANt1eT6PXZfi+kdprJ3usGyOThpKMUhjTtODUSipRSXLwDK/riGQSV6v6caVOxGxvsJRyn/9pq pL7RT5I1zzadryBWw9b+yK4roUzkRhbQek92dYtaxUZDtzma3yZfoJ62eeSkE5fbsI1K18T2rRt SpefEQ49WFE2j6QX1+hRID98JJ8xJp/Mn/0FatF1Vq3YK5Qx4dS1SZkjfvq5A9X1sIXvJM/WNQd P4iz29yXJ89vuZexB4nMDZc2MBMEit8LvgQmhPfLJlucu6ff/OiRKZ45EZKQNS6i/CWgaGpaRzk sPvlnuq1H5svPQcR44qUQDHkQGPdCc/K0eAr3sGy8o4o5C5iIgF07zcDO3zcR8G/OKlSQHzC6Rx NLizc6hiPHLTBkNHVxR5xfhZEkqwibL5hFWr6OL3xghT+iu0wCuLz+TNW6cWwp5zbBZTz9PsQPT L9NxFdQ0ZnD3gKPjcag== X-Proofpoint-ORIG-GUID: _FnCsZZ21bLZCi2KSWtLQRETn3VqjEIa X-Authority-Analysis: v=2.4 cv=U7cHnuru c=1 sm=1 tr=0 ts=6aa91666 cx=c_pps a=yZuzC5SkKTYVmguxKPWuow==:117 a=f+v6EHfkeJbVwR46tk4DMg==:17 a=6eWqkTHjU83fiwn7nKZWdM+Sl24=:19 a=IkcTkHD0fZMA:10 a=VdqzKS8jKosA:10 a=s63m1ICgrNkA:10 a=V5UXEbMT0ywA:10 a=VkNPw1HP01LnGYTKEx00:22 a=Z8NIEmU8O1QQgoT56wFK:22 a=taLDd7a_hP9WKsMzeGRc:22 a=sozttTNsAAAA:8 a=cC7ItFaxPISbhmCCHF8A:9 a=QEXdDO2ut3YA:10 X-Proofpoint-GUID: _FnCsZZ21bLZCi2KSWtLQRETn3VqjEIa X-Proofpoint-Spam-Info: AW1haW4tMjYwOTE1MDE0MyBTYWx0ZWRfX3oot/aO089qf wXAJX5fzmDjl3Z1IFAtekCiiJUK9Dyid6HWbfomE1Bvx/bOd9lnG3MqokG5fV2gWDfDR9qYjp7X KXwB4DNDFMvzUtJ8n4MmNLrsy6Rgru8= X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1176,Hydra:6.1.134,FMLib:17.12.100.49 definitions=2026-09-15_03,2026-09-14_02,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 priorityscore=1501 phishscore=0 lowpriorityscore=0 suspectscore=0 impostorscore=0 malwarescore=0 bulkscore=0 clxscore=1015 spamscore=0 adultscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2609040000 definitions=main-2609150143 The SA2UL engine is a DMA master, so any memory it accesses must either be allocated coherent or be explicitly synced with the CPU cache around each access. The security context buffer is currently allocated from a DMA pool via dma_pool_alloc(), which assumes a coherent memory which is untrue at a bus level for many of our SoCs. This causes any fetch issues from SA2UL to end up getting some stale or unsynced data causing failures for any crypto operations. To remove this, allocate the security context from a kmalloc-backed mempool instead. Since this memory is now ordinary cacheable kernel memory, explicitly call dma_map_single()/dma_unmap_single() for DMA related operations. Fixes: 7694b6ca649f ("crypto: sa2ul - Add crypto driver") Assisted-by: Sisyphus:claude-sonnet-4-6 Signed-off-by: Manorit Chawdhry --- drivers/crypto/sa2ul.c | 23 +++++++++++++++++------ drivers/crypto/sa2ul.h | 2 +- 2 files changed, 18 insertions(+), 7 deletions(-) diff --git a/drivers/crypto/sa2ul.c b/drivers/crypto/sa2ul.c index df905b391339..cadc8db14bbb 100644 --- a/drivers/crypto/sa2ul.c +++ b/drivers/crypto/sa2ul.c @@ -14,6 +14,7 @@ #include #include #include +#include #include #include #include @@ -741,6 +742,9 @@ int sa_init_sc(struct sa_ctx_info *ctx, const struct sa= _match_data *match_data, const u8 *auth_key, u16 auth_key_sz, struct algo_data *ad, u8 enc, u32 *swinfo) { + struct sa_crypto_data *data =3D dev_get_drvdata(sa_k3_dev); + struct device *dev =3D &data->pdev->dev; + int enc_sc_offset =3D 0; int auth_sc_offset =3D 0; u8 *sc_buf =3D ctx->sc; @@ -802,6 +806,12 @@ int sa_init_sc(struct sa_ctx_info *ctx, const struct s= a_match_data *match_data, /* swizzle the security context */ sa_swiz_128(sc_buf, SA_CTX_MAX_SZ); =20 + ctx->sc_phys =3D dma_map_single(dev, ctx->sc, SA_CTX_MAX_SZ, DMA_BIDIRECT= IONAL); + if (dma_mapping_error(dev, ctx->sc_phys)) { + mempool_free(ctx->sc, data->sc_pool); + return -ENOMEM; + } + sa_set_swinfo(first_engine, ctx->sc_id, ctx->sc_phys, 1, 0, SA_SW_INFO_FLAG_EVICT, ad->hash_size, swinfo); =20 @@ -814,6 +824,7 @@ int sa_init_sc(struct sa_ctx_info *ctx, const struct sa= _match_data *match_data, static void sa_free_ctx_info(struct sa_ctx_info *ctx, struct sa_crypto_data *data) { + struct device *dev =3D &data->pdev->dev; unsigned long bn; =20 bn =3D ctx->sc_id; @@ -824,7 +835,8 @@ static void sa_free_ctx_info(struct sa_ctx_info *ctx, =20 if (ctx->sc) { memzero_explicit(ctx->sc, SA_CTX_MAX_SZ); - dma_pool_free(data->sc_pool, ctx->sc, ctx->sc_phys); + dma_unmap_single(dev, ctx->sc_phys, SA_CTX_MAX_SZ, DMA_BIDIRECTIONAL); + mempool_free(ctx->sc, data->sc_pool); ctx->sc =3D NULL; } } @@ -843,7 +855,7 @@ static int sa_init_ctx_info(struct sa_ctx_info *ctx, =20 ctx->sc_id =3D (u16)bn; =20 - ctx->sc =3D dma_pool_alloc(data->sc_pool, GFP_KERNEL, &ctx->sc_phys); + ctx->sc =3D mempool_alloc(data->sc_pool, GFP_KERNEL); if (!ctx->sc) { dev_err(&data->pdev->dev, "Failed to allocate SC memory\n"); err =3D -ENOMEM; @@ -2244,8 +2256,7 @@ static int sa_init_mem(struct sa_crypto_data *dev_dat= a) { struct device *dev =3D &dev_data->pdev->dev; /* Setup dma pool for security context buffers */ - dev_data->sc_pool =3D dma_pool_create("keystone-sc", dev, - SA_CTX_MAX_SZ, 64, 0); + dev_data->sc_pool =3D mempool_create_kmalloc_pool(64, SA_CTX_MAX_SZ); if (!dev_data->sc_pool) { dev_err(dev, "Failed to create dma pool"); return -ENOMEM; @@ -2439,7 +2450,7 @@ static int sa_ul_probe(struct platform_device *pdev) dma_release_channel(dev_data->dma_tx); =20 destroy_dma_pool: - dma_pool_destroy(dev_data->sc_pool); + mempool_destroy(dev_data->sc_pool); =20 disable_pm: pm_runtime_put_sync(dev); @@ -2460,7 +2471,7 @@ static void sa_ul_remove(struct platform_device *pdev) dma_release_channel(dev_data->dma_rx1); dma_release_channel(dev_data->dma_tx); =20 - dma_pool_destroy(dev_data->sc_pool); + mempool_destroy(dev_data->sc_pool); =20 platform_set_drvdata(pdev, NULL); =20 diff --git a/drivers/crypto/sa2ul.h b/drivers/crypto/sa2ul.h index fbea98981f10..7ca385e908cc 100644 --- a/drivers/crypto/sa2ul.h +++ b/drivers/crypto/sa2ul.h @@ -163,7 +163,7 @@ struct sa_match_data; struct sa_crypto_data { const struct sa_match_data *match_data; struct platform_device *pdev; - struct dma_pool *sc_pool; + mempool_t *sc_pool; struct device *dev; spinlock_t scid_lock; /* lock for SC-ID allocation */ /* Security context data */ --=20 2.43.0 From nobody Fri Sep 25 12:05:54 2026 Received: from mx0a-0002e601.pphosted.com (mx0a-0002e601.pphosted.com [148.163.150.75]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id D1B714A13A0; Tue, 15 Sep 2026 09:57:46 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=fail smtp.client-ip=148.163.150.75 ARC-Seal: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1789466269; cv=fail; b=gJjRsbEmXLGhk1BAOZODo2XRnHB5G3tN0KJMAW/iz2K2OICHda1u4EHe8HYOARzwqPPA9xWUpQ57lNzTpO1FcFLRyacI2ocWvzEQS1fIxw+UUuF02/q3M2p2oFonsLZBCUz1H+z7Yaqm5+q9WGp/DwTfaoNlnV1xBYId0+/fYfE= ARC-Message-Signature: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1789466269; c=relaxed/simple; bh=pqseqOuOMOhZwjIze1OBP//HbmrgcLJHJrVCOlX4Izs=; h=From:Date:Subject:MIME-Version:Content-Type:Message-ID:References: In-Reply-To:To:CC; b=atE3BIWrwWf70j9aMPigNYhUTXgGQDm2JLRKdveV30ydLiTpoIqQbqIDvZgOfQEHYxEZ3+39y9f9xFrr8+lF6mSqv06S9EOEGRr+6x+fIGwAd0uY81o7p4T42qV3vWq0gEElDdK8bkz7W5GsDDHm47q059sNieSBDHVpzzoIbHo= ARC-Authentication-Results: i=2; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=ti.com; spf=pass smtp.mailfrom=ti.com; dkim=pass (2048-bit key) header.d=ti.com header.i=@ti.com header.b=k2LjfrbI; dkim=pass (1024-bit key) header.d=ti.com header.i=@ti.com header.b=lxrbyxD0; arc=fail smtp.client-ip=148.163.150.75 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=ti.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=ti.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=ti.com header.i=@ti.com header.b="k2LjfrbI"; dkim=pass (1024-bit key) header.d=ti.com header.i=@ti.com header.b="lxrbyxD0" Received: from pps.filterd (m0384305.ppops.net [127.0.0.1]) by m0384305.ppops.net (8.18.1.11/8.18.1.11) with ESMTP id 68F9ejHU1480546; Tue, 15 Sep 2026 04:57:43 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ti.com; h=cc :content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s= proofpoint-05-2026; bh=s7/W3a1LIbgwkhfqSqj3Z21+8/+SpW8T1QEY+SFxu DE=; b=k2LjfrbIopi9st/JCrFQK4Sjd3ipnxyzheE9vgPKyv3exyjwBSKjWIybP DdJA34UjmSLVw1tJUqAndmUFA27dEImcs+/mmTDZjN0PG8TP+W+A8WB9EgLKWog7 /SijfWL1DYGJz+Ua/p4yl8WmHh6mpalTHwG3VN8v5Z3pQM1wjJvxZ174eOzjSOB1 axDazNr5aaRvJZZze5I+5QPQfRhUcGJ4T2xlfc5V9KCGzh8iGrFfg5bsIp+GKVn+ Q9wyrWyeZB24AC6fAdSFzPXvQ/7xuAbbtQOABpidMwUbrJNhJ9buul0WC2k9YKZv NhEXbchmy0tklyUJVHCXWr5wcb7gw== Received: from dm1pr04cu001.outbound.protection.outlook.com (mail-centralusazon11010002.outbound.protection.outlook.com [52.101.61.2]) by m0384305.ppops.net (PPS) with ESMTPS id 4gpvpa2j71-1 (version=TLSv1.3 cipher=TLS_AES_256_GCM_SHA384 bits=256 verify=NOT); Tue, 15 Sep 2026 04:57:42 -0500 (CDT) ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=pwB7tI+S0zonaNu4+IT7kqFxPSH2G2sGfwTAdd7yu6GRbqC+Sv23r679EZL6emjV2RoZ7972q3QCcizXe3yC6pKIbM+K5HomylMCJLHV+PXeK3sHjTNloQOgwxfRvHVAJbVYr2SIohzH1mgp3iZLsLBoMNjEsNDtADGjwJIyzzy69/riVdm3djh3Npupb/RRVGILRfVGDKCRYxeFoz+2ow/zfnZGXQUYPL1Eq7S7VOVM0ZFmmL8sbpssR0PM+kVI14FAZ3NQhbThlb/gIscQrNkJLc6cCLOCLTZZSrKQdihnjIyzuI+ZPOq2uR3CGeMcmeOvYomw4b/FaAk/E8TagQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=s7/W3a1LIbgwkhfqSqj3Z21+8/+SpW8T1QEY+SFxuDE=; b=gwL7TRWauDkKQPbKOjo3fw/hbWCqoDuXf4gF9EvFNt9b/RQZ5EH70z6hVZMf/uSGz5jAw1RqnGMqbl4u2Mub69p2j+kAyBeGpLOLSOvb+KKAm/80jYNN8dNSxBf1hddSmF7gAActI275ZgFl4iQ9jzvol/iMoO+8xSnxtAsjt0bllhIL4d+e4GAh9f891/kjXyCPesxDKuX/jGWnc5K82nqIs6BbtIOQvx5d+elbJ2afGOa8D98KAVAUiXk4LSSTd/0sjxwOfVgh46eaCoS0cInpUpIsWCUnsVWJgc9SLp/4e/U7mZ6cMq06wCQYwde1Dumk9hqDsKUVEpqoxImpkQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 198.47.21.195) smtp.rcpttodomain=vger.kernel.org smtp.mailfrom=ti.com; dmarc=pass (p=quarantine sp=none pct=100) action=none header.from=ti.com; dkim=none (message not signed); arc=none (0) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ti.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=s7/W3a1LIbgwkhfqSqj3Z21+8/+SpW8T1QEY+SFxuDE=; b=lxrbyxD0fwh5JBGq1nB0LXV+gPx2ePZIaQDD1bEjE1ZdT2GONJFMbpHDnosC17RNJeM92ZV3zm7byCr8YUHNQIKgQgHNC6317CHAD13exv/We+DL+jvO6FRdhHfbKsd4vBF5nvpP16t846++d41UHsAUJCvgqfZt2zzQj2/NfG8= Received: from SJ0PR05CA0175.namprd05.prod.outlook.com (2603:10b6:a03:339::30) by DM6PR10MB4137.namprd10.prod.outlook.com (2603:10b6:5:217::24) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.21.428.9; Tue, 15 Sep 2026 09:57:35 +0000 Received: from MWH0EPF000C6189.namprd02.prod.outlook.com (2603:10b6:a03:339:cafe::4b) by SJ0PR05CA0175.outlook.office365.com (2603:10b6:a03:339::30) with Microsoft SMTP Server (version=TLS1_3, cipher=TLS_AES_256_GCM_SHA384) id 15.21.382.11 via Frontend Transport; Tue, 15 Sep 2026 09:57:34 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 198.47.21.195) smtp.mailfrom=ti.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=ti.com; Received-SPF: Pass (protection.outlook.com: domain of ti.com designates 198.47.21.195 as permitted sender) receiver=protection.outlook.com; client-ip=198.47.21.195; helo=flwvzet201.ext.ti.com; pr=C Received: from flwvzet201.ext.ti.com (198.47.21.195) by MWH0EPF000C6189.mail.protection.outlook.com (10.167.249.121) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.21.428.7 via Frontend Transport; Tue, 15 Sep 2026 09:57:33 +0000 Received: from DFLE204.ent.ti.com (10.64.6.62) by flwvzet201.ext.ti.com (10.248.192.32) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.2562.45; Tue, 15 Sep 2026 04:56:47 -0500 Received: from DFLE209.ent.ti.com (10.64.6.67) by DFLE204.ent.ti.com (10.64.6.62) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.2562.45; Tue, 15 Sep 2026 04:56:47 -0500 Received: from lelvem-mr06.itg.ti.com (10.180.75.8) by DFLE209.ent.ti.com (10.64.6.67) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.2562.45 via Frontend Transport; Tue, 15 Sep 2026 04:56:46 -0500 Received: from uda0497581-ant.dhcp.ti.com (uda0497581-ant.dhcp.ti.com [10.24.51.159]) by lelvem-mr06.itg.ti.com (8.18.1/8.18.1) with ESMTP id 68F9tB8I3000901; Tue, 15 Sep 2026 04:56:43 -0500 From: Manorit Chawdhry Date: Tue, 15 Sep 2026 15:25:34 +0530 Subject: [PATCH 28/30] crypto: sa2ul - route requests through crypto_engine Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-ID: <20260915-b4-upstream-sa2ul-cleanup-v1-28-57ab34e97162@ti.com> References: <20260915-b4-upstream-sa2ul-cleanup-v1-0-57ab34e97162@ti.com> In-Reply-To: <20260915-b4-upstream-sa2ul-cleanup-v1-0-57ab34e97162@ti.com> To: Herbert Xu , "David S. Miller" , Keerthy , Colin Ian King CC: Andrew Davis , Pratham T , "Kamlesh Gurudasani" , Udit Kumar , , , "Manorit Chawdhry" X-Mailer: b4 0.15.2 X-Developer-Signature: v=1; a=ed25519-sha256; t=1789466112; l=30001; i=m-chawdhry@ti.com; s=20231127; h=from:subject:message-id; bh=pqseqOuOMOhZwjIze1OBP//HbmrgcLJHJrVCOlX4Izs=; b=o2tRV2uf3McMRHro3K7tiwhSuLdWykIaPawisDzUBTKFAaYDfn8PdkOSmIe/UCrwREgdaDdZv zWsRYUZpKFaDnEr7vZp1OaQMCxmIWakYtTm8YqG4v5CWOH7PPwWgtoj X-Developer-Key: i=m-chawdhry@ti.com; a=ed25519; pk=fsr6Tm39TvsTgfyfFQLk+nnqIz2sBA1PthfqqfiiYSs= X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: MWH0EPF000C6189:EE_|DM6PR10MB4137:EE_ X-MS-Office365-Filtering-Correlation-Id: ef02c08a-6173-49e9-ef65-08df130fc363 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|36860700016|23010399003|1800799024|376014|82310400026|56012099006|10067099003|22082099003|18002099003; X-Microsoft-Antispam-Message-Info: WHFwSFl13WDXne2lIQO530l5EoZVFwFLxJsP3CFAg3/pwMWSQb3iEqyp+HKm+8eYZmigAO4rRx6yRBsZId4jKtCBQ/I3t2FdSM60id1APkJA3S/Ubh19UloZYCjpLqFyyh3/iWuQwa+ItuYiDVom5QOH3UzKfHrXmzdpqX1w+KbrNbQSgsr2QLrTjanxXZZ5Q28Y4kIWhQYcQjgztiAjW4U1Jrvx0BhI8uSuSV6QneBNIAcuvL1njvNGaEi9NNVHgAgzAneFKIF2VlL2e9DbaFzCnvNaNzvKiHcwBuePSl6NcR+bTpRF6B+gqQD2lpF+8PwA2PF719kds3DbJW78/hp+s8j41qG2kebEYxWbRGjRI5hW4T7wNYin+4DlJGqzJegr2sgOYqg2bZU8Mfi+v8MMF+2X7D1pW7pXLsUpNvoztdP4tLkXmixalKA+IBQw1v+UKAOrgs2CMMhJ4QG8g5TIqkvfnrHMPoDnoEmdEpnc0Q42b0nD0FrylqFpzcN9x7uBMV0zoafKqNzYtZJfg+/OFiKuesAkATCpYrVwht+Tkh6TVP7SpX3C2W3miEDe2HlfoWEidygOZuDoTRTfNTKoJxK8kKNQk58QIkr3H0bPaNU4D7g688JvDWV3m58S7lw05SKJ6EfkR8+QpCJn007waayCkOqnmAtLeX5yBL/V17VcJ1a2GiVveZMAHo9s48AC46MCuCBf7e3roeIcHQ== X-Forefront-Antispam-Report: CIP:198.47.21.195;CTRY:US;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:flwvzet201.ext.ti.com;PTR:ErrorRetry;CAT:NONE;SFS:(13230040)(36860700016)(23010399003)(1800799024)(376014)(82310400026)(56012099006)(10067099003)(22082099003)(18002099003);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: GqjQVdzvkRWY6WOCb/5ESHHwMN1TRyuWWg1CZSQdjyXKSOqedO/yMl1RN0Wz9NW6/XiBI3QJcdHJlRxCbuRDQbN6xAjgmklaK/2Z8tG61Md7PeMFJHMPtWJpqtMzjuGHgAG1XiBOiJb8yn1fi80QXUDIYcr6n/assB1zAJsRoho3McuTzdatfNr4pxAxdci17DbraG8ZVoXa3p/HoTIPlZL8iB4kZH2ME/qztQjIu/+ytxSOcixzFQpxtgaSumEYfcMqxcI7LLkNSeSrSWwAlLQBMRarJ/aYLo0x0YttF4wiTE8e7RixHqE31PjWNgr2qnQWrUTu90XeicdoBPRThL+osEbcPA2CcCr/A8XrGgS3bPr6FP405BbLHn7TQe70uygfLw52HqixRzR+aG7KjKTZZw8Z2QMXTEnx3ue6kGFWlCIeGDhcbOkW3NaxAnvV X-Exchange-RoutingPolicyChecked: NcIxrlr4EfGwv9OliN0pg0GAXnA597+/d0zmOHD+nAy+tdGusOy+fkW3FYjYd1R+JH+d5ck2X9ctE8Xh3M92UslVRLGdDypOsn8QuFNeVt6NkMNqLu+TZeT5f3BLRL3rqG5MJwPJMpw00+6ccqcb7rr0HORZAIgkC5SxoWe9u3yStvsPj0ZNWaZxxzLhaR5/BQkOUwcJH4Dkp3ECbCB0ti5AfMy5CnwZp1vePEMb/hEtkEMw/SGFUmHKwxersvfBYD3woKiJo4rfA0ESh2EuW4P7O+HcMouQw8flDyP4u/YxrY7cg84E4mVejjC8Tl25K4oWrjdaflg7ynr9fmTkSQ== X-OriginatorOrg: ti.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 15 Sep 2026 09:57:33.2093 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: ef02c08a-6173-49e9-ef65-08df130fc363 X-MS-Exchange-CrossTenant-Id: e5b49634-450b-4709-8abb-1e2b19b982b7 X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=e5b49634-450b-4709-8abb-1e2b19b982b7;Ip=[198.47.21.195];Helo=[flwvzet201.ext.ti.com] X-MS-Exchange-CrossTenant-AuthSource: MWH0EPF000C6189.namprd02.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM6PR10MB4137 X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwOTE1MDE0MyBTYWx0ZWRfX98i3JH6iGujT BAJPb/WYD3ECIm734ae7XftiDW/LPvxlmyn2e6PVGRjt+9ozI25v7d9LUpRZrmWUpZqEsOOMbtl aS4+uQ+sBjfT/Xj7YXQ7Tv+Z1YTDFZmrCdvzrSiCfVbCjgAmAQK88b0Ky9wWbWQtrPhAQWzedpm Ji0njZ3mwK+gvoEtA24q7HtDjVpQsaV4yuqdlsDnEabxm8cE3o78xvWFEGgIynDoMFSS7FnBSho DESJZXMpcr5w9PaXyFN507rda2zn7hoMKdhhdRyDudzAvlxKY4X/fOGnCh9yX5GxZVpQIjN4fOE EocYPb9crEe3+fa50yS0nhcuEJOvCqJO5ONHTay/aSBVPQIM/wvzv5bf7rUm58Kq5B8k28Rm6nW tfH+mmRDW3dbWWQk/wPnYSEAk8GpZ4bJDPVPzjViK/5Zi6kfTxyM6xbfHK4iwKyKFn2hX/ClzBI UHHnlacpwxMX+OUspYA== X-Proofpoint-ORIG-GUID: B_BxtsuwM75YRmlPEr7rabJu8HvLrnBt X-Authority-Analysis: v=2.4 cv=U7cHnuru c=1 sm=1 tr=0 ts=6aa91696 cx=c_pps a=h3cS895ItAADrFIx/0pANw==:117 a=tJyPKKxUohctrY4NYmUjkA==:17 a=6eWqkTHjU83fiwn7nKZWdM+Sl24=:19 a=IkcTkHD0fZMA:10 a=VdqzKS8jKosA:10 a=V5UXEbMT0ywA:10 a=VkNPw1HP01LnGYTKEx00:22 a=Z8NIEmU8O1QQgoT56wFK:22 a=taLDd7a_hP9WKsMzeGRc:22 a=sozttTNsAAAA:8 a=7j_cNkhbxLCtgoFIOCQA:9 a=QEXdDO2ut3YA:10 a=ZT8lLOp2prkQlNvCk5ZN:22 X-Proofpoint-GUID: B_BxtsuwM75YRmlPEr7rabJu8HvLrnBt X-Proofpoint-Spam-Info: AW1haW4tMjYwOTE1MDE0MyBTYWx0ZWRfX9tjLvcio4JyV 5QcjE44xMACM4g+w9jaLSqCC/8ArEFS5FRg2Kyo3l/wzDGSjU4P3On1Obbm+Zj7rpZzIQHen8kx 2tbJrE8JGdWyflyiBw3WCCTQ+LxVwXU= X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1176,Hydra:6.1.134,FMLib:17.12.100.49 definitions=2026-09-15_03,2026-09-14_02,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 priorityscore=1501 phishscore=0 lowpriorityscore=0 suspectscore=0 impostorscore=0 malwarescore=0 bulkscore=0 clxscore=1015 spamscore=0 adultscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2609040000 definitions=main-2609150143 SA2UL previously submitted skcipher, ahash, and aead requests directly from crypto_alg callbacks. This mixes sleepable and atomic request contexts on the same hardware queue and gives concurrent callers no serialization against the single security accelerator. Register a struct crypto_engine per SA2UL instance and convert each skcipher/ahash/aead algorithm to submit through crypto_transfer_{skcipher,hash,aead}_request_to_engine() with a matching do_one_request() callback. The engine now serializes all HW submissions to SA2UL, so requests from different contexts no longer race on the same crypto accelerator queue. Select CRYPTO_ENGINE in Kconfig and add engine allocation/start in probe and engine_exit in the remove/error paths. Fixes: 7694b6ca649f ("crypto: sa2ul - Add crypto driver") Assisted-by: Sisyphus:claude-sonnet-4-6 Signed-off-by: Manorit Chawdhry --- drivers/crypto/Kconfig | 1 + drivers/crypto/sa2ul.c | 536 +++++++++++++++++++++++++++++----------------= ---- drivers/crypto/sa2ul.h | 22 ++ 3 files changed, 339 insertions(+), 220 deletions(-) diff --git a/drivers/crypto/Kconfig b/drivers/crypto/Kconfig index 0189dfdcbbe1..c9596f0c9087 100644 --- a/drivers/crypto/Kconfig +++ b/drivers/crypto/Kconfig @@ -816,6 +816,7 @@ config CRYPTO_DEV_SA2UL select CRYPTO_ALGAPI select CRYPTO_AUTHENC select CRYPTO_DES + select CRYPTO_ENGINE select CRYPTO_SHA1 select CRYPTO_SHA256 select CRYPTO_SHA512 diff --git a/drivers/crypto/sa2ul.c b/drivers/crypto/sa2ul.c index cadc8db14bbb..d92ba1f581c0 100644 --- a/drivers/crypto/sa2ul.c +++ b/drivers/crypto/sa2ul.c @@ -33,6 +33,7 @@ #include #include #include +#include =20 #include "sa2ul.h" =20 @@ -150,9 +151,9 @@ struct algo_data { struct sa_alg_tmpl { u32 type; /* CRYPTO_ALG_TYPE from */ union { - struct skcipher_alg skcipher; - struct ahash_alg ahash; - struct aead_alg aead; + struct skcipher_engine_alg skcipher; + struct ahash_engine_alg ahash; + struct aead_engine_alg aead; } alg; bool registered; }; @@ -914,8 +915,8 @@ static int sa_cipher_cra_init(struct crypto_skcipher *t= fm) } =20 ctx->fallback.skcipher =3D child; - crypto_skcipher_set_reqsize(tfm, crypto_skcipher_reqsize(child) + - sizeof(struct skcipher_request)); + crypto_skcipher_set_reqsize(tfm, sizeof(struct sa_cipher_req_ctx) + + crypto_skcipher_reqsize(child)); =20 dev_dbg(sa_k3_dev, "%s(0x%p) sc-ids(0x%x(0x%pad), 0x%x(0x%pad))\n", __func__, tfm, ctx->enc.sc_id, &ctx->enc.sc_phys, @@ -1086,6 +1087,7 @@ static void sa_free_sa_rx_data(struct sa_rx_data *rxd) static void sa_aes_dma_in_callback(void *data) { struct sa_rx_data *rxd =3D data; + struct sa_crypto_data *pdata =3D dev_get_drvdata(sa_k3_dev); struct skcipher_request *req; u32 *result; __be32 *mdptr; @@ -1106,7 +1108,7 @@ static void sa_aes_dma_in_callback(void *data) =20 sa_free_sa_rx_data(rxd); =20 - skcipher_request_complete(req, 0); + crypto_finalize_skcipher_request(pdata->engine, req, 0); } =20 static int @@ -1337,12 +1339,19 @@ static int sa_run(struct sa_req *req) return ret; } =20 -static int sa_cipher_run(struct skcipher_request *req, u8 *iv, int enc) +static int sa_run_one(struct sa_req *req) +{ + int ret =3D sa_run(req); + + return ret =3D=3D -EINPROGRESS ? 0 : ret; +} + +static int sa_cipher_run(struct skcipher_request *req, int enc) { struct sa_tfm_ctx *ctx =3D crypto_skcipher_ctx(crypto_skcipher_reqtfm(req)); struct crypto_alg *alg =3D req->base.tfm->__crt_alg; - struct sa_req sa_req =3D { 0 }; + struct sa_cipher_req_ctx *rctx =3D skcipher_request_ctx(req); =20 if (!req->cryptlen) return 0; @@ -1354,7 +1363,7 @@ static int sa_cipher_run(struct skcipher_request *req= , u8 *iv, int enc) if (req->cryptlen > SA_MAX_DATA_SZ || (req->cryptlen >=3D SA_UNSAFE_DATA_SZ_MIN && req->cryptlen <=3D SA_UNSAFE_DATA_SZ_MAX)) { - struct skcipher_request *subreq =3D skcipher_request_ctx(req); + struct skcipher_request *subreq =3D &rctx->fallback_req; =20 skcipher_request_set_tfm(subreq, ctx->fallback.skcipher); skcipher_request_set_callback(subreq, req->base.flags, @@ -1368,33 +1377,46 @@ static int sa_cipher_run(struct skcipher_request *r= eq, u8 *iv, int enc) return crypto_skcipher_decrypt(subreq); } =20 + rctx->enc =3D enc; + + return crypto_transfer_skcipher_request_to_engine(ctx->dev_data->engine, = req); +} + +static int sa_cipher_do_one_req(struct crypto_engine *engine, void *areq) +{ + struct skcipher_request *req =3D container_of(areq, struct skcipher_reque= st, base); + struct sa_tfm_ctx *ctx =3D crypto_skcipher_ctx(crypto_skcipher_reqtfm(req= )); + struct sa_cipher_req_ctx *rctx =3D skcipher_request_ctx(req); + struct sa_req sa_req =3D { 0 }; + sa_req.size =3D req->cryptlen; sa_req.enc_size =3D req->cryptlen; sa_req.src =3D req->src; sa_req.dst =3D req->dst; - sa_req.enc_iv =3D iv; + sa_req.enc_iv =3D req->iv; sa_req.type =3D CRYPTO_ALG_TYPE_SKCIPHER; - sa_req.enc =3D enc; + sa_req.enc =3D rctx->enc; sa_req.callback =3D sa_aes_dma_in_callback; sa_req.base =3D &req->base; sa_req.ctx =3D ctx; =20 - return sa_run(&sa_req); + return sa_run_one(&sa_req); } =20 static int sa_encrypt(struct skcipher_request *req) { - return sa_cipher_run(req, req->iv, 1); + return sa_cipher_run(req, 1); } =20 static int sa_decrypt(struct skcipher_request *req) { - return sa_cipher_run(req, req->iv, 0); + return sa_cipher_run(req, 0); } =20 static void sa_sha_dma_in_callback(void *data) { struct sa_rx_data *rxd =3D data; + struct sa_crypto_data *pdata =3D dev_get_drvdata(sa_k3_dev); struct ahash_request *req; struct crypto_ahash *tfm; unsigned int authsize; @@ -1416,7 +1438,7 @@ static void sa_sha_dma_in_callback(void *data) =20 sa_free_sa_rx_data(rxd); =20 - ahash_request_complete(req, 0); + crypto_finalize_hash_request(pdata->engine, req, 0); } =20 static int zero_message_process(struct ahash_request *req) @@ -1445,7 +1467,6 @@ static int sa_sha_run(struct ahash_request *req) { struct sa_tfm_ctx *ctx =3D crypto_ahash_ctx(crypto_ahash_reqtfm(req)); struct sa_sha_req_ctx *rctx =3D ahash_request_ctx(req); - struct sa_req sa_req =3D { 0 }; size_t auth_len; =20 auth_len =3D req->nbytes; @@ -1468,8 +1489,17 @@ static int sa_sha_run(struct ahash_request *req) return ret; } =20 - sa_req.size =3D auth_len; - sa_req.auth_size =3D auth_len; + return crypto_transfer_hash_request_to_engine(ctx->dev_data->engine, req); +} + +static int sa_sha_do_one_req(struct crypto_engine *engine, void *areq) +{ + struct ahash_request *req =3D container_of(areq, struct ahash_request, ba= se); + struct sa_tfm_ctx *ctx =3D crypto_ahash_ctx(crypto_ahash_reqtfm(req)); + struct sa_req sa_req =3D { 0 }; + + sa_req.size =3D req->nbytes; + sa_req.auth_size =3D req->nbytes; sa_req.src =3D req->src; sa_req.dst =3D req->src; sa_req.enc =3D true; @@ -1478,7 +1508,7 @@ static int sa_sha_run(struct ahash_request *req) sa_req.ctx =3D ctx; sa_req.base =3D &req->base; =20 - return sa_run(&sa_req); + return sa_run_one(&sa_req); } =20 static int sa_sha_setup(struct sa_tfm_ctx *ctx, struct algo_data *ad) @@ -1689,6 +1719,7 @@ static void sa_sha_cra_exit(struct crypto_tfm *tfm) static void sa_aead_dma_in_callback(void *data) { struct sa_rx_data *rxd =3D data; + struct sa_crypto_data *pdata =3D dev_get_drvdata(sa_k3_dev); struct aead_request *req; struct crypto_aead *tfm; unsigned int start; @@ -1722,7 +1753,7 @@ static void sa_aead_dma_in_callback(void *data) =20 sa_free_sa_rx_data(rxd); =20 - aead_request_complete(req, err); + crypto_finalize_aead_request(pdata->engine, req, err); } =20 static int sa_cra_init_aead(struct crypto_aead *tfm, const char *hash, @@ -1751,7 +1782,7 @@ static int sa_cra_init_aead(struct crypto_aead *tfm, = const char *hash, return PTR_ERR(ctx->fallback.aead); } =20 - crypto_aead_set_reqsize(tfm, sizeof(struct aead_request) + + crypto_aead_set_reqsize(tfm, sizeof(struct sa_aead_req_ctx) + crypto_aead_reqsize(ctx->fallback.aead)); =20 ret =3D sa_init_ctx_info(&ctx->enc, data); @@ -1897,11 +1928,11 @@ static int sa_aead_cbc_sha256_setkey(struct crypto_= aead *authenc, return sa_aead_setkey(authenc, key, keylen, &ad); } =20 -static int sa_aead_run(struct aead_request *req, u8 *iv, int enc) +static int sa_aead_run(struct aead_request *req, int enc) { struct crypto_aead *tfm =3D crypto_aead_reqtfm(req); struct sa_tfm_ctx *ctx =3D crypto_aead_ctx(tfm); - struct sa_req sa_req =3D { 0 }; + struct sa_aead_req_ctx *rctx =3D aead_request_ctx(req); size_t auth_size, enc_size; =20 enc_size =3D req->cryptlen; @@ -1915,7 +1946,7 @@ static int sa_aead_run(struct aead_request *req, u8 *= iv, int enc) if (auth_size > SA_MAX_DATA_SZ || (auth_size >=3D SA_UNSAFE_DATA_SZ_MIN && auth_size <=3D SA_UNSAFE_DATA_SZ_MAX)) { - struct aead_request *subreq =3D aead_request_ctx(req); + struct aead_request *subreq =3D &rctx->fallback_req; int ret; =20 aead_request_set_tfm(subreq, ctx->fallback.aead); @@ -1930,265 +1961,314 @@ static int sa_aead_run(struct aead_request *req, = u8 *iv, int enc) return ret; } =20 + rctx->enc =3D enc; + + return crypto_transfer_aead_request_to_engine(ctx->dev_data->engine, req); +} + +static int sa_aead_do_one_req(struct crypto_engine *engine, void *areq) +{ + struct aead_request *req =3D container_of(areq, struct aead_request, base= ); + struct crypto_aead *tfm =3D crypto_aead_reqtfm(req); + struct sa_tfm_ctx *ctx =3D crypto_aead_ctx(tfm); + struct sa_aead_req_ctx *rctx =3D aead_request_ctx(req); + struct sa_req sa_req =3D { 0 }; + size_t auth_size, enc_size; + + enc_size =3D req->cryptlen; + auth_size =3D req->assoclen + req->cryptlen; + + if (!rctx->enc) { + enc_size -=3D crypto_aead_authsize(tfm); + auth_size -=3D crypto_aead_authsize(tfm); + } + sa_req.enc_offset =3D req->assoclen; sa_req.enc_size =3D enc_size; sa_req.auth_size =3D auth_size; sa_req.size =3D auth_size; - sa_req.enc_iv =3D iv; + sa_req.enc_iv =3D req->iv; sa_req.type =3D CRYPTO_ALG_TYPE_AEAD; - sa_req.enc =3D enc; + sa_req.enc =3D rctx->enc; sa_req.callback =3D sa_aead_dma_in_callback; sa_req.base =3D &req->base; sa_req.ctx =3D ctx; sa_req.src =3D req->src; sa_req.dst =3D req->dst; =20 - return sa_run(&sa_req); + return sa_run_one(&sa_req); } =20 /* AEAD algorithm encrypt interface function */ static int sa_aead_encrypt(struct aead_request *req) { - return sa_aead_run(req, req->iv, 1); + return sa_aead_run(req, 1); } =20 /* AEAD algorithm decrypt interface function */ static int sa_aead_decrypt(struct aead_request *req) { - return sa_aead_run(req, req->iv, 0); + return sa_aead_run(req, 0); } =20 static struct sa_alg_tmpl sa_algs[] =3D { [SA_ALG_CBC_AES] =3D { .type =3D CRYPTO_ALG_TYPE_SKCIPHER, .alg.skcipher =3D { - .base.cra_name =3D "cbc(aes)", - .base.cra_driver_name =3D "cbc-aes-sa2ul", - .base.cra_priority =3D 30000, - .base.cra_flags =3D CRYPTO_ALG_TYPE_SKCIPHER | - CRYPTO_ALG_KERN_DRIVER_ONLY | - CRYPTO_ALG_ASYNC | - CRYPTO_ALG_NEED_FALLBACK, - .base.cra_blocksize =3D AES_BLOCK_SIZE, - .base.cra_ctxsize =3D sizeof(struct sa_tfm_ctx), - .base.cra_module =3D THIS_MODULE, - .init =3D sa_cipher_cra_init, - .exit =3D sa_cipher_cra_exit, - .min_keysize =3D AES_MIN_KEY_SIZE, - .max_keysize =3D AES_MAX_KEY_SIZE, - .ivsize =3D AES_BLOCK_SIZE, - .setkey =3D sa_aes_cbc_setkey, - .encrypt =3D sa_encrypt, - .decrypt =3D sa_decrypt, + .base =3D { + .base.cra_name =3D "cbc(aes)", + .base.cra_driver_name =3D "cbc-aes-sa2ul", + .base.cra_priority =3D 30000, + .base.cra_flags =3D CRYPTO_ALG_TYPE_SKCIPHER | + CRYPTO_ALG_KERN_DRIVER_ONLY | + CRYPTO_ALG_ASYNC | + CRYPTO_ALG_NEED_FALLBACK, + .base.cra_blocksize =3D AES_BLOCK_SIZE, + .base.cra_ctxsize =3D sizeof(struct sa_tfm_ctx), + .base.cra_module =3D THIS_MODULE, + .init =3D sa_cipher_cra_init, + .exit =3D sa_cipher_cra_exit, + .min_keysize =3D AES_MIN_KEY_SIZE, + .max_keysize =3D AES_MAX_KEY_SIZE, + .ivsize =3D AES_BLOCK_SIZE, + .setkey =3D sa_aes_cbc_setkey, + .encrypt =3D sa_encrypt, + .decrypt =3D sa_decrypt, + }, + .op.do_one_request =3D sa_cipher_do_one_req, } }, [SA_ALG_EBC_AES] =3D { .type =3D CRYPTO_ALG_TYPE_SKCIPHER, .alg.skcipher =3D { - .base.cra_name =3D "ecb(aes)", - .base.cra_driver_name =3D "ecb-aes-sa2ul", - .base.cra_priority =3D 30000, - .base.cra_flags =3D CRYPTO_ALG_TYPE_SKCIPHER | - CRYPTO_ALG_KERN_DRIVER_ONLY | - CRYPTO_ALG_ASYNC | - CRYPTO_ALG_NEED_FALLBACK, - .base.cra_blocksize =3D AES_BLOCK_SIZE, - .base.cra_ctxsize =3D sizeof(struct sa_tfm_ctx), - .base.cra_module =3D THIS_MODULE, - .init =3D sa_cipher_cra_init, - .exit =3D sa_cipher_cra_exit, - .min_keysize =3D AES_MIN_KEY_SIZE, - .max_keysize =3D AES_MAX_KEY_SIZE, - .setkey =3D sa_aes_ecb_setkey, - .encrypt =3D sa_encrypt, - .decrypt =3D sa_decrypt, + .base =3D { + .base.cra_name =3D "ecb(aes)", + .base.cra_driver_name =3D "ecb-aes-sa2ul", + .base.cra_priority =3D 30000, + .base.cra_flags =3D CRYPTO_ALG_TYPE_SKCIPHER | + CRYPTO_ALG_KERN_DRIVER_ONLY | + CRYPTO_ALG_ASYNC | + CRYPTO_ALG_NEED_FALLBACK, + .base.cra_blocksize =3D AES_BLOCK_SIZE, + .base.cra_ctxsize =3D sizeof(struct sa_tfm_ctx), + .base.cra_module =3D THIS_MODULE, + .init =3D sa_cipher_cra_init, + .exit =3D sa_cipher_cra_exit, + .min_keysize =3D AES_MIN_KEY_SIZE, + .max_keysize =3D AES_MAX_KEY_SIZE, + .setkey =3D sa_aes_ecb_setkey, + .encrypt =3D sa_encrypt, + .decrypt =3D sa_decrypt, + }, + .op.do_one_request =3D sa_cipher_do_one_req, } }, [SA_ALG_CBC_DES3] =3D { .type =3D CRYPTO_ALG_TYPE_SKCIPHER, .alg.skcipher =3D { - .base.cra_name =3D "cbc(des3_ede)", - .base.cra_driver_name =3D "cbc-des3-sa2ul", - .base.cra_priority =3D 30000, - .base.cra_flags =3D CRYPTO_ALG_TYPE_SKCIPHER | - CRYPTO_ALG_KERN_DRIVER_ONLY | - CRYPTO_ALG_ASYNC | - CRYPTO_ALG_NEED_FALLBACK, - .base.cra_blocksize =3D DES_BLOCK_SIZE, - .base.cra_ctxsize =3D sizeof(struct sa_tfm_ctx), - .base.cra_module =3D THIS_MODULE, - .init =3D sa_cipher_cra_init, - .exit =3D sa_cipher_cra_exit, - .min_keysize =3D 3 * DES_KEY_SIZE, - .max_keysize =3D 3 * DES_KEY_SIZE, - .ivsize =3D DES_BLOCK_SIZE, - .setkey =3D sa_3des_cbc_setkey, - .encrypt =3D sa_encrypt, - .decrypt =3D sa_decrypt, + .base =3D { + .base.cra_name =3D "cbc(des3_ede)", + .base.cra_driver_name =3D "cbc-des3-sa2ul", + .base.cra_priority =3D 30000, + .base.cra_flags =3D CRYPTO_ALG_TYPE_SKCIPHER | + CRYPTO_ALG_KERN_DRIVER_ONLY | + CRYPTO_ALG_ASYNC | + CRYPTO_ALG_NEED_FALLBACK, + .base.cra_blocksize =3D DES_BLOCK_SIZE, + .base.cra_ctxsize =3D sizeof(struct sa_tfm_ctx), + .base.cra_module =3D THIS_MODULE, + .init =3D sa_cipher_cra_init, + .exit =3D sa_cipher_cra_exit, + .min_keysize =3D 3 * DES_KEY_SIZE, + .max_keysize =3D 3 * DES_KEY_SIZE, + .ivsize =3D DES_BLOCK_SIZE, + .setkey =3D sa_3des_cbc_setkey, + .encrypt =3D sa_encrypt, + .decrypt =3D sa_decrypt, + }, + .op.do_one_request =3D sa_cipher_do_one_req, } }, [SA_ALG_ECB_DES3] =3D { .type =3D CRYPTO_ALG_TYPE_SKCIPHER, .alg.skcipher =3D { - .base.cra_name =3D "ecb(des3_ede)", - .base.cra_driver_name =3D "ecb-des3-sa2ul", - .base.cra_priority =3D 30000, - .base.cra_flags =3D CRYPTO_ALG_TYPE_SKCIPHER | - CRYPTO_ALG_KERN_DRIVER_ONLY | - CRYPTO_ALG_ASYNC | - CRYPTO_ALG_NEED_FALLBACK, - .base.cra_blocksize =3D DES_BLOCK_SIZE, - .base.cra_ctxsize =3D sizeof(struct sa_tfm_ctx), - .base.cra_module =3D THIS_MODULE, - .init =3D sa_cipher_cra_init, - .exit =3D sa_cipher_cra_exit, - .min_keysize =3D 3 * DES_KEY_SIZE, - .max_keysize =3D 3 * DES_KEY_SIZE, - .setkey =3D sa_3des_ecb_setkey, - .encrypt =3D sa_encrypt, - .decrypt =3D sa_decrypt, + .base =3D { + .base.cra_name =3D "ecb(des3_ede)", + .base.cra_driver_name =3D "ecb-des3-sa2ul", + .base.cra_priority =3D 30000, + .base.cra_flags =3D CRYPTO_ALG_TYPE_SKCIPHER | + CRYPTO_ALG_KERN_DRIVER_ONLY | + CRYPTO_ALG_ASYNC | + CRYPTO_ALG_NEED_FALLBACK, + .base.cra_blocksize =3D DES_BLOCK_SIZE, + .base.cra_ctxsize =3D sizeof(struct sa_tfm_ctx), + .base.cra_module =3D THIS_MODULE, + .init =3D sa_cipher_cra_init, + .exit =3D sa_cipher_cra_exit, + .min_keysize =3D 3 * DES_KEY_SIZE, + .max_keysize =3D 3 * DES_KEY_SIZE, + .setkey =3D sa_3des_ecb_setkey, + .encrypt =3D sa_encrypt, + .decrypt =3D sa_decrypt, + }, + .op.do_one_request =3D sa_cipher_do_one_req, } }, [SA_ALG_SHA1] =3D { .type =3D CRYPTO_ALG_TYPE_AHASH, .alg.ahash =3D { - .halg.base =3D { - .cra_name =3D "sha1", - .cra_driver_name =3D "sha1-sa2ul", - .cra_priority =3D 400, - .cra_flags =3D CRYPTO_ALG_TYPE_AHASH | - CRYPTO_ALG_ASYNC | - CRYPTO_ALG_KERN_DRIVER_ONLY | - CRYPTO_ALG_NEED_FALLBACK, - .cra_blocksize =3D SHA1_BLOCK_SIZE, - .cra_ctxsize =3D sizeof(struct sa_tfm_ctx), - .cra_module =3D THIS_MODULE, - .cra_init =3D sa_sha1_cra_init, - .cra_exit =3D sa_sha_cra_exit, + .base =3D { + .halg.base =3D { + .cra_name =3D "sha1", + .cra_driver_name =3D "sha1-sa2ul", + .cra_priority =3D 400, + .cra_flags =3D CRYPTO_ALG_TYPE_AHASH | + CRYPTO_ALG_ASYNC | + CRYPTO_ALG_KERN_DRIVER_ONLY | + CRYPTO_ALG_NEED_FALLBACK, + .cra_blocksize =3D SHA1_BLOCK_SIZE, + .cra_ctxsize =3D sizeof(struct sa_tfm_ctx), + .cra_module =3D THIS_MODULE, + .cra_init =3D sa_sha1_cra_init, + .cra_exit =3D sa_sha_cra_exit, + }, + .halg.digestsize =3D SHA1_DIGEST_SIZE, + .halg.statesize =3D sizeof(struct sa_sha_req_ctx) + + sizeof(struct sha1_state), + .init =3D sa_sha_init, + .update =3D sa_sha_update, + .final =3D sa_sha_final, + .finup =3D sa_sha_finup, + .digest =3D sa_sha_run, + .export =3D sa_sha_export, + .import =3D sa_sha_import, }, - .halg.digestsize =3D SHA1_DIGEST_SIZE, - .halg.statesize =3D sizeof(struct sa_sha_req_ctx) + - sizeof(struct sha1_state), - .init =3D sa_sha_init, - .update =3D sa_sha_update, - .final =3D sa_sha_final, - .finup =3D sa_sha_finup, - .digest =3D sa_sha_run, - .export =3D sa_sha_export, - .import =3D sa_sha_import, + .op.do_one_request =3D sa_sha_do_one_req, }, }, [SA_ALG_SHA256] =3D { .type =3D CRYPTO_ALG_TYPE_AHASH, .alg.ahash =3D { - .halg.base =3D { - .cra_name =3D "sha256", - .cra_driver_name =3D "sha256-sa2ul", - .cra_priority =3D 400, - .cra_flags =3D CRYPTO_ALG_TYPE_AHASH | - CRYPTO_ALG_ASYNC | - CRYPTO_ALG_KERN_DRIVER_ONLY | - CRYPTO_ALG_NEED_FALLBACK, - .cra_blocksize =3D SHA256_BLOCK_SIZE, - .cra_ctxsize =3D sizeof(struct sa_tfm_ctx), - .cra_module =3D THIS_MODULE, - .cra_init =3D sa_sha256_cra_init, - .cra_exit =3D sa_sha_cra_exit, + .base =3D { + .halg.base =3D { + .cra_name =3D "sha256", + .cra_driver_name =3D "sha256-sa2ul", + .cra_priority =3D 400, + .cra_flags =3D CRYPTO_ALG_TYPE_AHASH | + CRYPTO_ALG_ASYNC | + CRYPTO_ALG_KERN_DRIVER_ONLY | + CRYPTO_ALG_NEED_FALLBACK, + .cra_blocksize =3D SHA256_BLOCK_SIZE, + .cra_ctxsize =3D sizeof(struct sa_tfm_ctx), + .cra_module =3D THIS_MODULE, + .cra_init =3D sa_sha256_cra_init, + .cra_exit =3D sa_sha_cra_exit, + }, + .halg.digestsize =3D SHA256_DIGEST_SIZE, + .halg.statesize =3D sizeof(struct sa_sha_req_ctx) + + sizeof(struct sha256_state), + .init =3D sa_sha_init, + .update =3D sa_sha_update, + .final =3D sa_sha_final, + .finup =3D sa_sha_finup, + .digest =3D sa_sha_run, + .export =3D sa_sha_export, + .import =3D sa_sha_import, }, - .halg.digestsize =3D SHA256_DIGEST_SIZE, - .halg.statesize =3D sizeof(struct sa_sha_req_ctx) + - sizeof(struct sha256_state), - .init =3D sa_sha_init, - .update =3D sa_sha_update, - .final =3D sa_sha_final, - .finup =3D sa_sha_finup, - .digest =3D sa_sha_run, - .export =3D sa_sha_export, - .import =3D sa_sha_import, + .op.do_one_request =3D sa_sha_do_one_req, }, }, [SA_ALG_SHA512] =3D { .type =3D CRYPTO_ALG_TYPE_AHASH, .alg.ahash =3D { - .halg.base =3D { - .cra_name =3D "sha512", - .cra_driver_name =3D "sha512-sa2ul", - .cra_priority =3D 400, - .cra_flags =3D CRYPTO_ALG_TYPE_AHASH | - CRYPTO_ALG_ASYNC | - CRYPTO_ALG_KERN_DRIVER_ONLY | - CRYPTO_ALG_NEED_FALLBACK, - .cra_blocksize =3D SHA512_BLOCK_SIZE, - .cra_ctxsize =3D sizeof(struct sa_tfm_ctx), - .cra_module =3D THIS_MODULE, - .cra_init =3D sa_sha512_cra_init, - .cra_exit =3D sa_sha_cra_exit, + .base =3D { + .halg.base =3D { + .cra_name =3D "sha512", + .cra_driver_name =3D "sha512-sa2ul", + .cra_priority =3D 400, + .cra_flags =3D CRYPTO_ALG_TYPE_AHASH | + CRYPTO_ALG_ASYNC | + CRYPTO_ALG_KERN_DRIVER_ONLY | + CRYPTO_ALG_NEED_FALLBACK, + .cra_blocksize =3D SHA512_BLOCK_SIZE, + .cra_ctxsize =3D sizeof(struct sa_tfm_ctx), + .cra_module =3D THIS_MODULE, + .cra_init =3D sa_sha512_cra_init, + .cra_exit =3D sa_sha_cra_exit, + }, + .halg.digestsize =3D SHA512_DIGEST_SIZE, + .halg.statesize =3D sizeof(struct sa_sha_req_ctx) + + sizeof(struct sha512_state), + .init =3D sa_sha_init, + .update =3D sa_sha_update, + .final =3D sa_sha_final, + .finup =3D sa_sha_finup, + .digest =3D sa_sha_run, + .export =3D sa_sha_export, + .import =3D sa_sha_import, }, - .halg.digestsize =3D SHA512_DIGEST_SIZE, - .halg.statesize =3D sizeof(struct sa_sha_req_ctx) + - sizeof(struct sha512_state), - .init =3D sa_sha_init, - .update =3D sa_sha_update, - .final =3D sa_sha_final, - .finup =3D sa_sha_finup, - .digest =3D sa_sha_run, - .export =3D sa_sha_export, - .import =3D sa_sha_import, + .op.do_one_request =3D sa_sha_do_one_req, }, }, [SA_ALG_AUTHENC_SHA1_AES] =3D { .type =3D CRYPTO_ALG_TYPE_AEAD, .alg.aead =3D { .base =3D { - .cra_name =3D "authenc(hmac(sha1),cbc(aes))", - .cra_driver_name =3D - "authenc(hmac(sha1),cbc(aes))-sa2ul", - .cra_blocksize =3D AES_BLOCK_SIZE, - .cra_flags =3D CRYPTO_ALG_TYPE_AEAD | - CRYPTO_ALG_KERN_DRIVER_ONLY | - CRYPTO_ALG_ASYNC | - CRYPTO_ALG_NEED_FALLBACK, - .cra_ctxsize =3D sizeof(struct sa_tfm_ctx), - .cra_module =3D THIS_MODULE, - .cra_priority =3D 3000, + .base =3D { + .cra_name =3D "authenc(hmac(sha1),cbc(aes))", + .cra_driver_name =3D + "authenc(hmac(sha1),cbc(aes))-sa2ul", + .cra_blocksize =3D AES_BLOCK_SIZE, + .cra_flags =3D CRYPTO_ALG_TYPE_AEAD | + CRYPTO_ALG_KERN_DRIVER_ONLY | + CRYPTO_ALG_ASYNC | + CRYPTO_ALG_NEED_FALLBACK, + .cra_ctxsize =3D sizeof(struct sa_tfm_ctx), + .cra_module =3D THIS_MODULE, + .cra_priority =3D 3000, + }, + .ivsize =3D AES_BLOCK_SIZE, + .maxauthsize =3D SHA1_DIGEST_SIZE, + + .init =3D sa_cra_init_aead_sha1, + .exit =3D sa_exit_tfm_aead, + .setkey =3D sa_aead_cbc_sha1_setkey, + .setauthsize =3D sa_aead_setauthsize, + .encrypt =3D sa_aead_encrypt, + .decrypt =3D sa_aead_decrypt, }, - .ivsize =3D AES_BLOCK_SIZE, - .maxauthsize =3D SHA1_DIGEST_SIZE, - - .init =3D sa_cra_init_aead_sha1, - .exit =3D sa_exit_tfm_aead, - .setkey =3D sa_aead_cbc_sha1_setkey, - .setauthsize =3D sa_aead_setauthsize, - .encrypt =3D sa_aead_encrypt, - .decrypt =3D sa_aead_decrypt, + .op.do_one_request =3D sa_aead_do_one_req, }, }, [SA_ALG_AUTHENC_SHA256_AES] =3D { .type =3D CRYPTO_ALG_TYPE_AEAD, .alg.aead =3D { .base =3D { - .cra_name =3D "authenc(hmac(sha256),cbc(aes))", - .cra_driver_name =3D - "authenc(hmac(sha256),cbc(aes))-sa2ul", - .cra_blocksize =3D AES_BLOCK_SIZE, - .cra_flags =3D CRYPTO_ALG_TYPE_AEAD | - CRYPTO_ALG_KERN_DRIVER_ONLY | - CRYPTO_ALG_ASYNC | - CRYPTO_ALG_NEED_FALLBACK, - .cra_ctxsize =3D sizeof(struct sa_tfm_ctx), - .cra_module =3D THIS_MODULE, - .cra_alignmask =3D 0, - .cra_priority =3D 3000, + .base =3D { + .cra_name =3D "authenc(hmac(sha256),cbc(aes))", + .cra_driver_name =3D + "authenc(hmac(sha256),cbc(aes))-sa2ul", + .cra_blocksize =3D AES_BLOCK_SIZE, + .cra_flags =3D CRYPTO_ALG_TYPE_AEAD | + CRYPTO_ALG_KERN_DRIVER_ONLY | + CRYPTO_ALG_ASYNC | + CRYPTO_ALG_NEED_FALLBACK, + .cra_ctxsize =3D sizeof(struct sa_tfm_ctx), + .cra_module =3D THIS_MODULE, + .cra_alignmask =3D 0, + .cra_priority =3D 3000, + }, + .ivsize =3D AES_BLOCK_SIZE, + .maxauthsize =3D SHA256_DIGEST_SIZE, + + .init =3D sa_cra_init_aead_sha256, + .exit =3D sa_exit_tfm_aead, + .setkey =3D sa_aead_cbc_sha256_setkey, + .setauthsize =3D sa_aead_setauthsize, + .encrypt =3D sa_aead_encrypt, + .decrypt =3D sa_aead_decrypt, }, - .ivsize =3D AES_BLOCK_SIZE, - .maxauthsize =3D SHA256_DIGEST_SIZE, - - .init =3D sa_cra_init_aead_sha256, - .exit =3D sa_exit_tfm_aead, - .setkey =3D sa_aead_cbc_sha256_setkey, - .setauthsize =3D sa_aead_setauthsize, - .encrypt =3D sa_aead_encrypt, - .decrypt =3D sa_aead_decrypt, + .op.do_one_request =3D sa_aead_do_one_req, }, }, }; @@ -2209,14 +2289,14 @@ static void sa_register_algos(struct sa_crypto_data= *dev_data) =20 type =3D sa_algs[i].type; if (type =3D=3D CRYPTO_ALG_TYPE_SKCIPHER) { - alg_name =3D sa_algs[i].alg.skcipher.base.cra_name; - err =3D crypto_register_skcipher(&sa_algs[i].alg.skcipher); + alg_name =3D sa_algs[i].alg.skcipher.base.base.cra_name; + err =3D crypto_engine_register_skcipher(&sa_algs[i].alg.skcipher); } else if (type =3D=3D CRYPTO_ALG_TYPE_AHASH) { - alg_name =3D sa_algs[i].alg.ahash.halg.base.cra_name; - err =3D crypto_register_ahash(&sa_algs[i].alg.ahash); + alg_name =3D sa_algs[i].alg.ahash.base.halg.base.cra_name; + err =3D crypto_engine_register_ahash(&sa_algs[i].alg.ahash); } else if (type =3D=3D CRYPTO_ALG_TYPE_AEAD) { - alg_name =3D sa_algs[i].alg.aead.base.cra_name; - err =3D crypto_register_aead(&sa_algs[i].alg.aead); + alg_name =3D sa_algs[i].alg.aead.base.base.cra_name; + err =3D crypto_engine_register_aead(&sa_algs[i].alg.aead); } else { dev_err(dev, "un-supported crypto algorithm (%d)", @@ -2242,11 +2322,11 @@ static void sa_unregister_algos(const struct device= *dev) if (!sa_algs[i].registered) continue; if (type =3D=3D CRYPTO_ALG_TYPE_SKCIPHER) - crypto_unregister_skcipher(&sa_algs[i].alg.skcipher); + crypto_engine_unregister_skcipher(&sa_algs[i].alg.skcipher); else if (type =3D=3D CRYPTO_ALG_TYPE_AHASH) - crypto_unregister_ahash(&sa_algs[i].alg.ahash); + crypto_engine_unregister_ahash(&sa_algs[i].alg.ahash); else if (type =3D=3D CRYPTO_ALG_TYPE_AEAD) - crypto_unregister_aead(&sa_algs[i].alg.aead); + crypto_engine_unregister_aead(&sa_algs[i].alg.aead); =20 sa_algs[i].registered =3D false; } @@ -2422,6 +2502,16 @@ static int sa_ul_probe(struct platform_device *pdev) if (ret) goto destroy_dma_pool; =20 + dev_data->engine =3D crypto_engine_alloc_init(dev, 0); + if (!dev_data->engine) { + ret =3D -ENOMEM; + goto release_dma; + } + + ret =3D crypto_engine_start(dev_data->engine); + if (ret) + goto free_engine; + spin_lock_init(&dev_data->scid_lock); =20 val =3D SA_EEC_ENCSS_EN | SA_EEC_AUTHSS_EN | SA_EEC_CTXCACH_EN | @@ -2436,15 +2526,19 @@ static int sa_ul_probe(struct platform_device *pdev) =20 ret =3D of_platform_populate(node, NULL, NULL, dev); if (ret) - goto release_dma; + goto unregister_algos; =20 device_for_each_child(dev, dev, sa_link_child); =20 return 0; =20 -release_dma: +unregister_algos: sa_unregister_algos(dev); =20 +free_engine: + crypto_engine_exit(dev_data->engine); + +release_dma: dma_release_channel(dev_data->dma_rx2); dma_release_channel(dev_data->dma_rx1); dma_release_channel(dev_data->dma_tx); @@ -2467,6 +2561,8 @@ static void sa_ul_remove(struct platform_device *pdev) =20 sa_unregister_algos(&pdev->dev); =20 + crypto_engine_exit(dev_data->engine); + dma_release_channel(dev_data->dma_rx2); dma_release_channel(dev_data->dma_rx1); dma_release_channel(dev_data->dma_tx); diff --git a/drivers/crypto/sa2ul.h b/drivers/crypto/sa2ul.h index 7ca385e908cc..53d2bfd895cf 100644 --- a/drivers/crypto/sa2ul.h +++ b/drivers/crypto/sa2ul.h @@ -159,6 +159,7 @@ struct sa_match_data; * @dma_rx1: Pointer to DMA rx channel for sizes < 256 Bytes * @dma_rx2: Pointer to DMA rx channel for sizes > 256 Bytes * @dma_tx: Pointer to DMA TX channel + * @engine: crypto_engine instance for this device */ struct sa_crypto_data { const struct sa_match_data *match_data; @@ -173,6 +174,7 @@ struct sa_crypto_data { struct dma_chan *dma_rx1; struct dma_chan *dma_rx2; struct dma_chan *dma_tx; + struct crypto_engine *engine; }; =20 /** @@ -261,6 +263,26 @@ struct sa_sha_req_ctx { struct ahash_request fallback_req; }; =20 +/** + * struct sa_cipher_req_ctx: Structure used for skcipher request + * @enc: True if this request is an encrypt operation + * @fallback_req: SW fallback request container + */ +struct sa_cipher_req_ctx { + bool enc; + struct skcipher_request fallback_req; +}; + +/** + * struct sa_aead_req_ctx: Structure used for aead request + * @enc: True if this request is an encrypt operation + * @fallback_req: SW fallback request container + */ +struct sa_aead_req_ctx { + bool enc; + struct aead_request fallback_req; +}; + /** * struct sa_eng_info: Security accelerator engine info * @eng_id: Engine ID --=20 2.43.0 From nobody Fri Sep 25 12:05:54 2026 Received: from mx0a-0002e601.pphosted.com (mx0a-0002e601.pphosted.com [148.163.150.75]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 9B3AF4A1DEF; Tue, 15 Sep 2026 09:57:47 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=fail smtp.client-ip=148.163.150.75 ARC-Seal: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1789466269; cv=fail; b=pjzE01u9ilSMBZx1UeCAexv9JIvEoWwKldvdASS54rxbtPNAEhWYqhUuCAbwQD0m58vBTy9OXvFTmynnGGDMeeXRzNjH5/Pw3UHf/P8xIuufZmmowtmQf2zccS4376o9GzMdstbtXG88QWnjpp+X19SQmJLfx9qQA1lLQc+0aSI= ARC-Message-Signature: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1789466269; c=relaxed/simple; bh=87FoaMFEzPbnoTJqFF5CtXfl5HeHsDnSXNyOG8JHc70=; h=From:Date:Subject:MIME-Version:Content-Type:Message-ID:References: In-Reply-To:To:CC; b=IQhhodrQThIkQrUE9Iih2VoRukUrpuF1Lo0GCYyoTjzoEEsctIQMRUpwqcKZMiofNGOtcw5LQhssyxUEP/ekToav7/arFafjVvlJO+QfREqXR/zrp7RjI5ua++StZtdc1N99CkGOsZOsH0GTohzo5nppdByHGWiVgvUf5QUX+uw= ARC-Authentication-Results: i=2; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=ti.com; spf=pass smtp.mailfrom=ti.com; dkim=pass (2048-bit key) header.d=ti.com header.i=@ti.com header.b=INT+u97x; dkim=pass (1024-bit key) header.d=ti.com header.i=@ti.com header.b=tczQAzLK; arc=fail smtp.client-ip=148.163.150.75 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=ti.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=ti.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=ti.com header.i=@ti.com header.b="INT+u97x"; dkim=pass (1024-bit key) header.d=ti.com header.i=@ti.com header.b="tczQAzLK" Received: from pps.filterd (m0384305.ppops.net [127.0.0.1]) by m0384305.ppops.net (8.18.1.11/8.18.1.11) with ESMTP id 68F9eigU1480544; Tue, 15 Sep 2026 04:57:44 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ti.com; h=cc :content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s= proofpoint-05-2026; bh=cgs+xVdzOQlRGuPry19s5qAU6JrpcMNK/IdYlL5Z7 Aw=; b=INT+u97xFxWTPocxfBT4AZXhdTohSriry7ta4A0MDpPZ7/lABqBL2Y5Fv 9EKm9RJiFcEDMCCuhdMpWSModohq9tEl6k28CX664z2GOacVSLn4aKYsB5wtsprc DJGFOcPXtODd0DJWqdNtCT23/CbtWcotqaJpsPMwlz/oF+QigJWxbwyGNyBSBX3S LBrMaSUOKNOwvvYfARnUDRtsPNsW88xLXdSdSFiPLdTVqrb4oK60gZSi9/MFYAoa pW+j/GDc7kTSEI8FtVmzMooVKtd+pM9Q/Aa09CzHcQL+CIUjaWWa5LJ1rF2FcXbs yHYfFL+UDhqL4iW7UtAaKlfl5pEWg== Received: from ch1pr05cu001.outbound.protection.outlook.com (mail-northcentralusazon11010005.outbound.protection.outlook.com [52.101.193.5]) by m0384305.ppops.net (PPS) with ESMTPS id 4gpvpa2j74-1 (version=TLSv1.3 cipher=TLS_AES_256_GCM_SHA384 bits=256 verify=NOT); Tue, 15 Sep 2026 04:57:43 -0500 (CDT) ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=IkinJhbdaMt7X/688iNVSIz36QyikkPEAUq7MVe4Rnf4FWF7cCoh0RwsX97w1/VqKFcaxOP0vvF+vPkpr9PeNxNpLlYeCiFcZ+XZFJjad/j6NUViHd2Pf9Cdyk3M8RHlw4Ai++4fFstSRrbaaKsUG0UldTDa+zCYPsavorVE/Xn5OyR2iAiaddEuh6dXj1JCH2V+MAsjUTscwaua5AsFCrnVCKDa6QgPNi8rpFTe1lIBBBwNbSMIZNLNnGxAcFfpUHORwZZHcrLEMU98jvPM7L4e3TDhQNV7HvsN1QiFm2Mpth93ZFesKZ2DEFJbeGPKlpcM5el7uz19+09hdfnv0Q== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=cgs+xVdzOQlRGuPry19s5qAU6JrpcMNK/IdYlL5Z7Aw=; b=EnC5PmLiF3ZSlVuoe99w8kcD0+2BrVkCyu8xULkvW1ac7h+VJR5KXzMf2YHk4u2nfH6/7hvA3SSjVXvVFmCq7K/oyiZLePNLWlqJwc3GJVl/R9k3mexugBI1XDOkEPJ/LNzc8mEiGKNt/hOwZSPNwEvUQD4ED+D3Gx9khGiJgR7nN7m0TbnB5lpnLeebWkqdq+61XqQSlf6XaRS5TV6YluwTbzH5u5iMxdzxYNQalIIKXSY/CuQpdO8XUt3OivXeMZRXoeIv380+XKC1bJC+WySv155FtWZR2b9tDxuqyiDReE/RupbsDQf+hAKRz/p1diLZ1UJeT8sMc6qkBCBj+Q== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 198.47.21.195) smtp.rcpttodomain=vger.kernel.org smtp.mailfrom=ti.com; dmarc=pass (p=quarantine sp=none pct=100) action=none header.from=ti.com; dkim=none (message not signed); arc=none (0) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ti.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=cgs+xVdzOQlRGuPry19s5qAU6JrpcMNK/IdYlL5Z7Aw=; b=tczQAzLKiDYdNHYvB3Ycc336/vbxAMnSsO12XmGGgoKfZdhA2JqLwtq8IIxWktxs0RGtkod3qz1bVNSE68TE/7661LpsZtz74DASjMxiILKXxMNG/pVQ68zo+RMJSowTKRtzHQk3OxxrKo0eaLuN/OoPIL+AW/uleRHhIlfgOoM= Received: from SJ0PR05CA0160.namprd05.prod.outlook.com (2603:10b6:a03:339::15) by SJ5PPF25BED9404.namprd10.prod.outlook.com (2603:10b6:a0f:fc02::794) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.21.428.9; Tue, 15 Sep 2026 09:57:41 +0000 Received: from MWH0EPF000C6189.namprd02.prod.outlook.com (2603:10b6:a03:339:cafe::82) by SJ0PR05CA0160.outlook.office365.com (2603:10b6:a03:339::15) with Microsoft SMTP Server (version=TLS1_3, cipher=TLS_AES_256_GCM_SHA384) id 15.21.428.8 via Frontend Transport; Tue, 15 Sep 2026 09:57:40 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 198.47.21.195) smtp.mailfrom=ti.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=ti.com; Received-SPF: Pass (protection.outlook.com: domain of ti.com designates 198.47.21.195 as permitted sender) receiver=protection.outlook.com; client-ip=198.47.21.195; helo=flwvzet201.ext.ti.com; pr=C Received: from flwvzet201.ext.ti.com (198.47.21.195) by MWH0EPF000C6189.mail.protection.outlook.com (10.167.249.121) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.21.428.7 via Frontend Transport; Tue, 15 Sep 2026 09:57:39 +0000 Received: from DFLE200.ent.ti.com (10.64.6.58) by flwvzet201.ext.ti.com (10.248.192.32) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.2562.45; Tue, 15 Sep 2026 04:56:50 -0500 Received: from DFLE203.ent.ti.com (10.64.6.61) by DFLE200.ent.ti.com (10.64.6.58) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.2562.45; Tue, 15 Sep 2026 04:56:50 -0500 Received: from lelvem-mr06.itg.ti.com (10.180.75.8) by DFLE203.ent.ti.com (10.64.6.61) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.2562.45 via Frontend Transport; Tue, 15 Sep 2026 04:56:50 -0500 Received: from uda0497581-ant.dhcp.ti.com (uda0497581-ant.dhcp.ti.com [10.24.51.159]) by lelvem-mr06.itg.ti.com (8.18.1/8.18.1) with ESMTP id 68F9tB8J3000901; Tue, 15 Sep 2026 04:56:47 -0500 From: Manorit Chawdhry Date: Tue, 15 Sep 2026 15:25:35 +0530 Subject: [PATCH 29/30] crypto: sa2ul - report SA engine hardware revision Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-ID: <20260915-b4-upstream-sa2ul-cleanup-v1-29-57ab34e97162@ti.com> References: <20260915-b4-upstream-sa2ul-cleanup-v1-0-57ab34e97162@ti.com> In-Reply-To: <20260915-b4-upstream-sa2ul-cleanup-v1-0-57ab34e97162@ti.com> To: Herbert Xu , "David S. Miller" , Keerthy , Colin Ian King CC: Andrew Davis , Pratham T , "Kamlesh Gurudasani" , Udit Kumar , , , "Manorit Chawdhry" X-Mailer: b4 0.15.2 X-Developer-Signature: v=1; a=ed25519-sha256; t=1789466112; l=2394; i=m-chawdhry@ti.com; s=20231127; h=from:subject:message-id; bh=87FoaMFEzPbnoTJqFF5CtXfl5HeHsDnSXNyOG8JHc70=; b=IywzhRvKceqAo1nEMBb5yvoSH5jMEIzT+DSnSbMa7FQMD+HBM9m4dClU4sFzze3ZvLSY/a2bP xbDWyFJjljwDumZ5xKvdvjlniR78cOfe/6piPjR/iknDVZiFXPaoLB4 X-Developer-Key: i=m-chawdhry@ti.com; a=ed25519; pk=fsr6Tm39TvsTgfyfFQLk+nnqIz2sBA1PthfqqfiiYSs= X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: MWH0EPF000C6189:EE_|SJ5PPF25BED9404:EE_ X-MS-Office365-Filtering-Correlation-Id: 76e61ed7-6210-42ab-eab0-08df130fc72d X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|1800799024|82310400026|376014|36860700016|23010399003|6133799003|22082099003|18002099003|10067099003|56012099006; X-Microsoft-Antispam-Message-Info: vVqG6awREs5KMcU4HX5Pc69WRlxLBj2ogd3dL8pA6+SMJsazXSoO6kotGw0/riFeS9o8A8MsxjBQ7HdqUrhAwna/v+M7UyM2g02BskOgpjGdTmISSs3AGbY2co+88BVOwsM9rtRzlUm/VEzfAu5W2mg+GYN/Idpw3ymlJYHc79wFcAmBBW7Hf5sjQvB3NXIB13lfCeIiJYa7wbZpq+aXc1mQ7g9lqTWpJ84+mhD3duhDh8OpNCuXywBlfUY0QOpLMtJoTBV0G4Diu/IRT5e+PH5GbdAKwuKc2YcXPMC4NnZN6z926WitjcOgX5qwzzUwFtRchzgzFEDdKM8Z3DLTW/eUlu9yrMXpQuSpHa7w4U3DGX0DBC+4U65pwPS2BM+h+xN0VTZwFFSnF75oqqzJwgfzj5bDbN4dO1NjkOWPMKkqz0qEA15V2ZDF8GpJ00HgSLcmFpJwqdaeirKI8GYHqGlqLvkHxxNTxvI8se8gCn+0e7p4+MHJxWsszFexj+3nMySiXYVCU0ZhWPL7FdJauUtEBj5cSbAfQFayIMOULS+psJ/Py89sh6xRno44sJeHZQfyCxAijAQd6XMURRz9g3Ib2H3YCtvjsq6+WA6eoLxM1BazUvExw6qqRz0pO28Z+s7Se9/MEA4qzguBcCcU5iwUHtv+yyPrMQsX7HGHlD8KR249jJKGSySAP1JSpsVmrJzsdsoPBE7D8E57WcjMYg== X-Forefront-Antispam-Report: CIP:198.47.21.195;CTRY:US;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:flwvzet201.ext.ti.com;PTR:ErrorRetry;CAT:NONE;SFS:(13230040)(1800799024)(82310400026)(376014)(36860700016)(23010399003)(6133799003)(22082099003)(18002099003)(10067099003)(56012099006);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: 1SPLlzJ3UtrpnOM0RjarM2eUnkpZZLMsdrLcduJue6bTzG1u3+WDfyrQJLfcd7c89ESCUZ9VcxLT2oJSPg96rvmwsDd+OZLvfcOweMc31ZBnVNkUEqGFouEImxpdLe75BLSquvyzWen7mCo3p2i0I0gShckWRp+lO7xnFEp0ECLK0gV99S+946KWmAJgvNzA6z5pOAIb5F2OPMe5wjJ7n8pzoxEZFKsyxcCY9opCpGy2xk4HGrifKNGmlnjKOarQmcWxgJ7hf18GwIPnSikfm3d6xDN8qwPMpWJ6S1JP0KUQuyVVbdog5aV6DnZBlf6mdiJKPKeHskLeNhknAbAnOBtFLLkqIyrwy5VFSUt6n186w5A11YgUOHUxL6no/63EudpvCUM/acvmYzoroRRg6Fc+j8O1HY5algpkqkYPwsUv87c1U0Aju3IbLXoeN7qd X-Exchange-RoutingPolicyChecked: X2GPMAMcDJ29bMzTABmjCOISNTilwW79qmSPixiPeyP6nNopYQqKM2NnYhrXnha09+M2sTkQvc87Tdiz3yNOAI7+EopgwXNZr6hWVl4CXhGKanhdQbNR9cF9Pnyrfda0PodvxAhsmDldDzcu8V7O9pXG4xuU7UATJ5vHwRqJpq9kVbm4P/FxAUxzGRK0YWrIfgHg0db6R+b2FgyvayC01DLeOakGCO34yZw+jwhbeRW2D9yKpgYezQLnXP4eDM6BbtSxV6NfIVAzpV3NR3H4S81ZPmf58oKJJ5xRQ5/9djRRY9yKF+IHEA7m21PbeMDwclIFN4oc7MTMYE6FcPNsBQ== X-OriginatorOrg: ti.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 15 Sep 2026 09:57:39.5691 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 76e61ed7-6210-42ab-eab0-08df130fc72d X-MS-Exchange-CrossTenant-Id: e5b49634-450b-4709-8abb-1e2b19b982b7 X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=e5b49634-450b-4709-8abb-1e2b19b982b7;Ip=[198.47.21.195];Helo=[flwvzet201.ext.ti.com] X-MS-Exchange-CrossTenant-AuthSource: MWH0EPF000C6189.namprd02.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: SJ5PPF25BED9404 X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwOTE1MDE0MyBTYWx0ZWRfXzYvjxfxnMsrH +fEApZABMfNulhbLGezTROyjzEfpIkyBjuBRDaQwG0g9iSzo/AENbLpBbpo9y1wDe+W9v1/ZlEZ LFc2P+IZPe+wgw3F7PZ1XA11BUzQKYVvA0IePDpFXqyInlpsqCCGWJim1NxcP8p8pYy8owBetK6 TW1lYkU2A4hn9T59yCNSuK5yfgaTWeBJtp66TLGhHtFyJD4HfbH1VbesWtYc1wh7pwl7tNkZoRz zwyV3b0pP9D74gzA+CXhs3QM7tZcXqNYa/Jwmjyp23tD3jZpxUjK/NuriLXEtwK9K0n2mE5Z1kK UMfdvZ53kJNCK3fcXqX3EL+UwddVhK3GsB/kW1Yp+35ilX07efnyYlYd+i2SfUzBU7UDqntZ9j8 aYn4dOGblwg0DM++CCsja+dB9KdxcKJHxA1Rv5iJzhR3Mef+0z9GgaeBhrc2OqGBp55R1uMNt1d grcGCkTMSR3AsJDCoow== X-Proofpoint-ORIG-GUID: GW2_xo8qMw-wFe1GUM6tke3eBkhaEzZA X-Authority-Analysis: v=2.4 cv=U7cHnuru c=1 sm=1 tr=0 ts=6aa91698 cx=c_pps a=v0elvT+g34jhj2ItdigShQ==:117 a=tJyPKKxUohctrY4NYmUjkA==:17 a=6eWqkTHjU83fiwn7nKZWdM+Sl24=:19 a=IkcTkHD0fZMA:10 a=VdqzKS8jKosA:10 a=V5UXEbMT0ywA:10 a=VkNPw1HP01LnGYTKEx00:22 a=Z8NIEmU8O1QQgoT56wFK:22 a=taLDd7a_hP9WKsMzeGRc:22 a=sozttTNsAAAA:8 a=Oohk0lFMm99HtjJkPXAA:9 a=QEXdDO2ut3YA:10 X-Proofpoint-GUID: GW2_xo8qMw-wFe1GUM6tke3eBkhaEzZA X-Proofpoint-Spam-Info: AW1haW4tMjYwOTE1MDE0MyBTYWx0ZWRfX1PfaIOczXzU5 BbQ0bRO2b+JSOcODNxZmSnN7wy+9hyPmHmuF2Ijc9LM1YtyhvsHAk66i0OVakzD64G/AHNHdgwT mtDLGYMTw9lgUsaIMY9busQ50N+Gflk= X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1176,Hydra:6.1.134,FMLib:17.12.100.49 definitions=2026-09-15_03,2026-09-14_02,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 priorityscore=1501 phishscore=0 lowpriorityscore=0 suspectscore=0 impostorscore=0 malwarescore=0 bulkscore=0 clxscore=1015 spamscore=0 adultscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2609040000 definitions=main-2609150143 The SA2UL/SA3UL crypto engine exposes a REVISION register at offset 0x0 that encodes the major/minor hardware version (major =3D=3D 2 for SA2_UL, major =3D=3D 3 minor =3D=3D 0 for SA3_UL, major =3D=3D 3 minor =3D= =3D 1 for SA3_UL_CM). This version information is needed to detect the AES-CM (SA3UL_CM) variant so the driver can enable the extra TRNG-priming and AES key-expansion workarounds it requires. Add the SA_REVISION register offset and its major/minor field masks, read the register during probe, and log the decoded version via dev_info() for diagnostics. Signed-off-by: Manorit Chawdhry Assisted-by: Sisyphus:claude-sonnet-5 --- drivers/crypto/sa2ul.c | 8 +++++++- drivers/crypto/sa2ul.h | 9 +++++++++ 2 files changed, 16 insertions(+), 1 deletion(-) diff --git a/drivers/crypto/sa2ul.c b/drivers/crypto/sa2ul.c index d92ba1f581c0..9c4748110eef 100644 --- a/drivers/crypto/sa2ul.c +++ b/drivers/crypto/sa2ul.c @@ -2465,7 +2465,8 @@ static int sa_ul_probe(struct platform_device *pdev) struct device_node *node =3D dev->of_node; static void __iomem *saul_base; struct sa_crypto_data *dev_data; - u32 status, val; + u32 status, val, rev; + unsigned int major, minor; int ret; =20 dev_data =3D devm_kzalloc(dev, sizeof(*dev_data), GFP_KERNEL); @@ -2494,6 +2495,11 @@ static int sa_ul_probe(struct platform_device *pdev) return ret; } =20 + rev =3D readl_relaxed(saul_base + SA_REVISION); + major =3D FIELD_GET(SA_REVISION_MAJOR_MASK, rev); + minor =3D FIELD_GET(SA_REVISION_MINOR_MASK, rev); + dev_info(dev, "SAxUL_VERSION: %u.%u\n", major, minor); + ret =3D sa_init_mem(dev_data); if (ret) goto disable_pm; diff --git a/drivers/crypto/sa2ul.h b/drivers/crypto/sa2ul.h index 53d2bfd895cf..c5e73ed14f44 100644 --- a/drivers/crypto/sa2ul.h +++ b/drivers/crypto/sa2ul.h @@ -16,9 +16,18 @@ #include #include =20 +#define SA_REVISION 0x0000 #define SA_ENGINE_STATUS 0x0008 #define SA_ENGINE_ENABLE_CONTROL 0x1000 =20 +/* + * SA_REVISION register fields (see REVISION Register, offset 0x0) + * major =3D=3D 2: SA2_UL, major =3D=3D 3: SA3_UL (minor 0 =3D=3D SA3_UL, = minor 1 =3D=3D + * SA3_UL_CM aka SA3_UL v3.1) + */ +#define SA_REVISION_MAJOR_MASK GENMASK(10, 8) +#define SA_REVISION_MINOR_MASK GENMASK(5, 0) + struct sa_tfm_ctx; /* * SA_ENGINE_ENABLE_CONTROL register bits --=20 2.43.0 From nobody Fri Sep 25 12:05:54 2026 Received: from mx0b-0002e601.pphosted.com (mx0b-0002e601.pphosted.com [148.163.154.28]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 0FC6047F76C; Tue, 15 Sep 2026 09:57:42 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=fail smtp.client-ip=148.163.154.28 ARC-Seal: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1789466264; cv=fail; b=puTx2fizrypwd5UI+REaCLIJP+5C+vNqdi64+jxJrGVVKCMsDcJbzISVzLdUlS0wr5LmAm0dZdH+H5tpwnTZlMPo3WT6VzU/wtlK/Q5rxWUw7HeU/pBcEJ2sQNNiTp3oDTSkiGVAly5K7xN/XD55plFEIBjgpCPKp+HcepT9jgM= ARC-Message-Signature: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1789466264; c=relaxed/simple; bh=dMSxjxHR/7YuWvuj/LVD/Vh9LGwxrYaNLr2mJKjCNLY=; h=From:Date:Subject:MIME-Version:Content-Type:Message-ID:References: In-Reply-To:To:CC; b=tw4ZpArmElCkrsf/AJytQaoty2+o+IkOFQQq9h0UL70SstYH3hbUUjyZEIYuyh+AKncXOBzInchCxQq2C/ZUdYAOz8IQ+B5XV9Zv6YcEOlMeHzONx9vIyWf8t4hOLGxT+N3KsKp6yDZQ/9OFd0RH7LsLPIyB3+2cE/KelcjJpDY= ARC-Authentication-Results: i=2; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=ti.com; spf=pass smtp.mailfrom=ti.com; dkim=pass (2048-bit key) header.d=ti.com header.i=@ti.com header.b=aXG9KWmu; dkim=pass (1024-bit key) header.d=ti.com header.i=@ti.com header.b=pe1QH89H; arc=fail smtp.client-ip=148.163.154.28 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=ti.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=ti.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=ti.com header.i=@ti.com header.b="aXG9KWmu"; dkim=pass (1024-bit key) header.d=ti.com header.i=@ti.com header.b="pe1QH89H" Received: from pps.filterd (m0374955.ppops.net [127.0.0.1]) by mx0b-0002e601.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 68F9fL3V4098131; Tue, 15 Sep 2026 04:57:39 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ti.com; h=cc :content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s= proofpoint-05-2026; bh=1NPZv2ynQoSxCoBUM8nVsLcEB7z87UOn8mW1xRp3A bc=; b=aXG9KWmudKjMGCHJHKpjK5E8NT9iLKerP7nihbDA8la6yrVd4MSdgS0Vq CuAquNoAjTk7uwuHw9+0WZXEG13WtpsOFr8MjJ3PDm9DlRDCWk+HDJlA+EuhsOnK RQtnMQSEOkKb02UeD5jPFx2H4ibi/7hx2UECZL1qVC1qGxuOrAZZcEpDP3AlR8v+ KymWxjhuoCvqO9IeIIMCZSUoevV6VHWp9oq+CxfLIHCu9YAQIII2TU6zamBHSJ3l vmrSZIPHHjnT2nX+UizTcHzVZsG0nz0pPuFC+ra/EN1C24lN+EfUscLfUzZl9ihU jiO5lks2fN7UNw1Xe7g2WUE8EwfMw== Received: from sj2pr03cu001.outbound.protection.outlook.com (mail-westusazon11012058.outbound.protection.outlook.com [52.101.43.58]) by mx0b-0002e601.pphosted.com (PPS) with ESMTPS id 4gpvpjakq4-1 (version=TLSv1.3 cipher=TLS_AES_256_GCM_SHA384 bits=256 verify=NOT); Tue, 15 Sep 2026 04:57:38 -0500 (CDT) ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=hhY/TN/Gp5Ri3yO+4xpTOs5lbllNN3Bzg5tuFFZEj7CwhY9U2jyzKf++4BMdn1vI3ejCI2eEyqfU6bYyN1UlaPYU5SIyTLGGZodi82G2L7Zih9KH1/Ye5iDPxUYUtQTKkJpXhqsZpY3F8Y2YAImryu7jOvX8VAbtCco7YKHGhHwWlgPXhnwHMp3mca5bFhSMpOd4tbSEEYQS/gI3aP0L8KF4pALYDfVQvIWvYM4KurKt800wkgwgxTu8cOQ5n0lhoQnSs8Wb+6IHL2CXPxID6vfbceRPsF6V7HiXMvhmBPo/AAv1w1St7LIDJvSl/KXzq2FOguYhCwBI9pZYZ0+HAQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=1NPZv2ynQoSxCoBUM8nVsLcEB7z87UOn8mW1xRp3Abc=; b=UI0YJkHprvqvJf2jMt9iMtO40RLT+qBxYZk+v/J9f+B0h76pcv9glLSqfLaGbeG812fJSEUgQU+RCoy8p3XOSr09TfuW7Hi5CI1n/XCSjRPsZKVVimFtyMCKX1IifI5y/Slj8xo49Hmgs6lJlkI00mH2bmaiNqZXyxeQK0ZPGx2F91TSg2AVNW0cocbXgT3/GoWimi8KDXXkwvmQETMISxUfc/QiM6NCKVOMtHjIL4RBZxhgwDDg/cQ+A3TZxGJTcxThmSji+OjL8TLoXNJvCh2NL/qIgqZ82f+5caNGL6Ob3YzAWs3q/CTphrf+tLUbIptPmmdsJYVhh8aRD4sURw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 198.47.21.194) smtp.rcpttodomain=vger.kernel.org smtp.mailfrom=ti.com; dmarc=pass (p=quarantine sp=none pct=100) action=none header.from=ti.com; dkim=none (message not signed); arc=none (0) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ti.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=1NPZv2ynQoSxCoBUM8nVsLcEB7z87UOn8mW1xRp3Abc=; b=pe1QH89H+1iydLWrzhX4LXsHOO9qiGTgvf4KK1ybTMVY7Zn/ZSfmn21Fjwy0VjMHLL1znpY742rrPmXPzj8nGJxeXWdBybkZA3sYEtJrvdoHIV5YkK4noa3lwCJwfZFmI1KpAVjsWd6xn+A0yzzG8+zR/meZnbsYEogHqHwGHqk= Received: from CH0PR03CA0044.namprd03.prod.outlook.com (2603:10b6:610:b3::19) by AT6PR10MB987455.namprd10.prod.outlook.com (2603:10b6:170:113::7) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.21.428.9; Tue, 15 Sep 2026 09:57:36 +0000 Received: from CH2PEPF00000141.namprd02.prod.outlook.com (2603:10b6:610:b3:cafe::a7) by CH0PR03CA0044.outlook.office365.com (2603:10b6:610:b3::19) with Microsoft SMTP Server (version=TLS1_3, cipher=TLS_AES_256_GCM_SHA384) id 15.21.428.9 via Frontend Transport; Tue, 15 Sep 2026 09:57:36 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 198.47.21.194) smtp.mailfrom=ti.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=ti.com; Received-SPF: Pass (protection.outlook.com: domain of ti.com designates 198.47.21.194 as permitted sender) receiver=protection.outlook.com; client-ip=198.47.21.194; helo=flwvzet200.ext.ti.com; pr=C Received: from flwvzet200.ext.ti.com (198.47.21.194) by CH2PEPF00000141.mail.protection.outlook.com (10.167.244.74) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.21.428.7 via Frontend Transport; Tue, 15 Sep 2026 09:57:34 +0000 Received: from DFLE204.ent.ti.com (10.64.6.62) by flwvzet200.ext.ti.com (10.248.192.31) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.2562.45; Tue, 15 Sep 2026 04:56:53 -0500 Received: from DFLE206.ent.ti.com (10.64.6.64) by DFLE204.ent.ti.com (10.64.6.62) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.2562.45; Tue, 15 Sep 2026 04:56:53 -0500 Received: from lelvem-mr06.itg.ti.com (10.180.75.8) by DFLE206.ent.ti.com (10.64.6.64) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.2562.45 via Frontend Transport; Tue, 15 Sep 2026 04:56:53 -0500 Received: from uda0497581-ant.dhcp.ti.com (uda0497581-ant.dhcp.ti.com [10.24.51.159]) by lelvem-mr06.itg.ti.com (8.18.1/8.18.1) with ESMTP id 68F9tB8K3000901; Tue, 15 Sep 2026 04:56:50 -0500 From: Manorit Chawdhry Date: Tue, 15 Sep 2026 15:25:36 +0530 Subject: [PATCH 30/30] crypto: sa2ul - add AES-CM (SA3UL_CM) TRNG priming support Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-ID: <20260915-b4-upstream-sa2ul-cleanup-v1-30-57ab34e97162@ti.com> References: <20260915-b4-upstream-sa2ul-cleanup-v1-0-57ab34e97162@ti.com> In-Reply-To: <20260915-b4-upstream-sa2ul-cleanup-v1-0-57ab34e97162@ti.com> To: Herbert Xu , "David S. Miller" , Keerthy , Colin Ian King CC: Andrew Davis , Pratham T , "Kamlesh Gurudasani" , Udit Kumar , , , "Manorit Chawdhry" X-Mailer: b4 0.15.2 X-Developer-Signature: v=1; a=ed25519-sha256; t=1789466112; l=6421; i=m-chawdhry@ti.com; s=20231127; h=from:subject:message-id; bh=dMSxjxHR/7YuWvuj/LVD/Vh9LGwxrYaNLr2mJKjCNLY=; b=wORxmUukgnlIjzpM9sOk8NiKdMLvGb2uMeAartv0wa2EMtKLdcEdb+ABOpHCtxzRQc3LuLsdT Y2Ti9ua6T2wBmlWjURmYvo1HQbLP+ukPt9ZcQly8FkHfjnL+GQkwDTj X-Developer-Key: i=m-chawdhry@ti.com; a=ed25519; pk=fsr6Tm39TvsTgfyfFQLk+nnqIz2sBA1PthfqqfiiYSs= X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: CH2PEPF00000141:EE_|AT6PR10MB987455:EE_ X-MS-Office365-Filtering-Correlation-Id: 0aa73b7e-5e93-4289-002d-08df130fc418 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|376014|1800799024|82310400026|23010399003|36860700016|56012099006|22082099003|18002099003|10067099003; X-Microsoft-Antispam-Message-Info: uCMekEpAvhZo2ieXqbKr+IQTCqwazIAxYhMtU57hHn1gdHPszmWYIGwty7OaD/4phO7WvIp+0klA14Dyltho4RjYL5ap5e1UQAm+4Qa4U7W39oewXDhC7vNFTjxNsO7m1CGXYqBqq1taH/3UzjdBGb4h/K70SKio+gmpWxlCa9s/PsTscq7tT7Sgi/Bn7gVAjs1982Tpw7w2Ig5z4E9SU4XIxl0MBpRUuxXFhb4NXqGnAw4W5PgeowF2kPLm0DC5NZsHNh9naZbD+8OYUpC12BTts2JLjaw2zXL/BUY8rUJtGcWSw3ay+ufCbZQaIoyEEiQfTa5dy451CLIgFNHM5uiB/e1w3sdm6y8PZIpXuuE7jgVfaNq+ZVkywtL19/jKrokstpyNm44OaQ8GYzfzK7qP74xcjNQ+wXybxZgcQlBpnLu58yqU7ZRCn+shLPPYexQvi2nUWWaaa6i27TZE5OIorQbXwZonpPnOvK9MF3vsp0OaU6JeN98kbvzoUicZjmEHVomj78W+z+Tpxs263oKLxLeUgs17Dl+2TpkvkkbAMCorcRFHIC0a+JYmBsKVTeWGQDzO7ANa4wWXVR1uNkcrwe7mSjePCfJLIgGKB4BZybpi17tf2M1a9rM6QTh3jAQ9bbsJLqnuVmyyUpIrL+4nKCtSjwSmTFjsqQa9ol9OYg+BYWqe6D/Ufwm/r1N0eLmigqX3Q/zfGOs9rACWxg== X-Forefront-Antispam-Report: CIP:198.47.21.194;CTRY:US;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:flwvzet200.ext.ti.com;PTR:ErrorRetry;CAT:NONE;SFS:(13230040)(376014)(1800799024)(82310400026)(23010399003)(36860700016)(56012099006)(22082099003)(18002099003)(10067099003);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: v5lPDQXttDzDzweicHwlIF4VpxOwDZ3Go+beoxu3lCBlv7bfpA1lijn7V9JiKHcpCvBpd5Jshl5/8gXU3ctQYB62qfvAtGjqgn3rauzitxRBpYir7ZbAnYj+dZiGqLDYo5O9nvJZdztvg+reOMv8xoci//IBSopFheUS6MVwJwuXnOPC/qXfRQfOuoLJf0kwCD73xpb1IRr6C5l46KGSyhSdYABDijDyveH2cpDuxDb+nueKuGTGF9wc280IwpIHNmMoAquK3bC6+5kGkBYK5jJiXj9qRh9K7+k5Ij5uTSCIvTu9MtIu8ApCg/WZgWgkxZbY9I6llP5tEUu5FBs8rRnRr62qL3/HOXPMWfxKRZHxQN40YHE1lq3EyqdXmZMTieiewJxeRPyV1WDEvRCqKqWSl6aMkSyISx6YONnmZ8nInfRcDqFpY2c+bas2p9Sd X-Exchange-RoutingPolicyChecked: TCAZbzZ7ZOG8rdHWjvAIQ5dl42BJ/nPmKjkESwuuarPTm2KhkKXshj22lNnpvzc450Wj1t6V1FWnELbMoCnsePakjBPgDfvfihAGugnHGMNNqwLnAmtdlUMtlY15CrmcX9wj+zN++PUeJbVKOoLEhArj1KBve4rkBn0nEVzCsZlTm10dj8STWe7y5C+7uPV3+/wwn+U4T9T7Mzr0j11lq8c9ZtpTxO6dh92pZwttax8eTsLNCclqCk8egmaYMozgbFOsxwtUXsixN0CY55pUzdtahyK+KGCMEzQkm4uIQx6XdeGdTbzF443LP1fjcvcjaaOFS38b9Sc6AKbH7YNLDA== X-OriginatorOrg: ti.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 15 Sep 2026 09:57:34.4325 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 0aa73b7e-5e93-4289-002d-08df130fc418 X-MS-Exchange-CrossTenant-Id: e5b49634-450b-4709-8abb-1e2b19b982b7 X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=e5b49634-450b-4709-8abb-1e2b19b982b7;Ip=[198.47.21.194];Helo=[flwvzet200.ext.ti.com] X-MS-Exchange-CrossTenant-AuthSource: CH2PEPF00000141.namprd02.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: AT6PR10MB987455 X-Proofpoint-Spam-Info: AW1haW4tMjYwOTE1MDE0MyBTYWx0ZWRfX0ptMvj8pdi2h X20zDAkwewczSukfbb56xi+YWB9OgxoRrsOFMy5GKHV3PjnuieYL5d0wmAmwYTXGH1ca3CAL8vk BNB0gy6hWDWUhS+4Sa+ssZx2/W7M5z8= X-Authority-Analysis: v=2.4 cv=KvnYSmWN c=1 sm=1 tr=0 ts=6aa91692 cx=c_pps a=8P36fUQdMjs6HQlwNDQNwg==:117 a=iwqwCZQqcuTv3JOpYdM7/Q==:17 a=6eWqkTHjU83fiwn7nKZWdM+Sl24=:19 a=IkcTkHD0fZMA:10 a=VdqzKS8jKosA:10 a=V5UXEbMT0ywA:10 a=VkNPw1HP01LnGYTKEx00:22 a=Z8NIEmU8O1QQgoT56wFK:22 a=fPAWb5peG099m5CrUpKH:22 a=sozttTNsAAAA:8 a=BTFW9V_9Xv1Ih9i2t_oA:9 a=QEXdDO2ut3YA:10 X-Proofpoint-ORIG-GUID: ynOMSo9XE4OEmxyNGckrl2AbBvdISBod X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwOTE1MDE0MyBTYWx0ZWRfX9oy6uR/Ab72R 9LzCLKAjU5xjmyHj1IsXX5hfmePEfdybQkSYkH5JpavnrA7wrMEKYCHIqABJ53hWwfXlkVWoSmn WGz883/Rr18j3ZvUboCWWy35Qg38UfjVq5aZVNKtNdA5ZSspebIElDLIKG5OWG4NnTwiQWEI8pa sWptCyupF8N1EuAgwXmRF0FvHcJdUlu8u+OggX27a6vaJIhPDW3Yez/s4mwAHCsCco0Qgg4YfJ9 tLYfyBkvAtZXBBo2RyHypOswN8et7dONsI9yAQlqJo49Ltrvsdl2yhSf+nyyvlPZTsBCDyBitVA KduzbSnjAjT3y87jldProfYelp/C2CSQyrNvyXGV6lAfJSiOrQS8JqbB4wGeXSC0FuC1b6kbEtl tb28u7a34K6WMv094tV+zmuZ887FHxaeZ9UrkAIojLz3eiGpBQIx7ozO8YIt4vuyaBmA+iZTaIE yXF4JDbnK1Gb7L4ntbQ== X-Proofpoint-GUID: ynOMSo9XE4OEmxyNGckrl2AbBvdISBod X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1176,Hydra:6.1.134,FMLib:17.12.100.49 definitions=2026-09-15_03,2026-09-14_02,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 lowpriorityscore=0 clxscore=1015 priorityscore=1501 impostorscore=0 suspectscore=0 spamscore=0 bulkscore=0 adultscore=0 phishscore=0 malwarescore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2609040000 definitions=main-2609150143 The SA3UL_CM hardware variant (rev 3.1) requires an extra AES key schedule round (round 15) for AES-256 decryption, and needs a one-time TRNG-seeded AES-ECB priming operation after every power-up before its side-channel countermeasures are considered active. Add aes_cm detection in sa_ul_probe() based on the SA revision register, compute the extra round-15 key material into a local array (crypto_aes_ctx.key_enc[] only holds 60 words for rounds 0-14, so round 15 cannot be written into it directly), and add sa_aes_cm_trng_prime() which runs a throwaway ecb(aes) encrypt with a random key and random plaintext through the driver's own registered transform to satisfy the priming requirement. Assisted-by: Sisyphus:claude-sonnet-5 Signed-off-by: Manorit Chawdhry --- drivers/crypto/sa2ul.c | 100 +++++++++++++++++++++++++++++++++++++++++++++= +++- drivers/crypto/sa2ul.h | 2 + 2 files changed, 100 insertions(+), 2 deletions(-) diff --git a/drivers/crypto/sa2ul.c b/drivers/crypto/sa2ul.c index 9c4748110eef..ccc402bade2d 100644 --- a/drivers/crypto/sa2ul.c +++ b/drivers/crypto/sa2ul.c @@ -21,6 +21,7 @@ #include #include #include +#include =20 #include #include @@ -500,11 +501,22 @@ static int sa_prepare_iopads(struct algo_data *data, = const u8 *key, return ret; } =20 +/* SubWord using kernel AES S-box */ +static inline u32 sa_aes_subword(u32 w) +{ + return (u32)crypto_aes_sbox[w & 0xff] | + ((u32)crypto_aes_sbox[(w >> 8) & 0xff] << 8) | + ((u32)crypto_aes_sbox[(w >> 16) & 0xff] << 16) | + ((u32)crypto_aes_sbox[(w >> 24) & 0xff] << 24); +} + /* Derive the inverse key used in AES-CBC decryption operation */ -static inline int sa_aes_inv_key(u8 *inv_key, const u8 *key, u16 key_sz) +static inline int sa_aes_inv_key(u8 *inv_key, const u8 *key, u16 key_sz, + bool aes_cm) { struct crypto_aes_ctx ctx __cleanup(aes_zeroize_ctx); int key_pos; + u32 round15[4]; =20 if (aes_expandkey(&ctx, key, key_sz)) { dev_err(sa_k3_dev, "%s: bad key len(%d)\n", __func__, key_sz); @@ -517,6 +529,23 @@ static inline int sa_aes_inv_key(u8 *inv_key, const u8= *key, u16 key_sz) ctx.key_enc[53] =3D ctx.key_enc[52] ^ ctx.key_enc[47]; } =20 + /* + * SA3UL CM hardware variant needs an extra round 15 for AES-256. + * ctx.key_enc[] only holds 60 words (rounds 0-14), so round 15 is + * computed into a local array instead of writing past its end. + */ + if (key_sz =3D=3D AES_KEYSIZE_256 && aes_cm) { + round15[0] =3D sa_aes_subword(ctx.key_enc[59]) ^ ctx.key_enc[52]; + round15[1] =3D round15[0] ^ ctx.key_enc[53]; + round15[2] =3D round15[1] ^ ctx.key_enc[54]; + round15[3] =3D round15[2] ^ ctx.key_enc[55]; + + /* Decrypt key =3D round14 || round15 */ + memcpy(inv_key, &ctx.key_enc[56], 16); + memcpy(inv_key + 16, round15, 16); + return 0; + } + /* Based crypto_aes_expand_key logic */ switch (key_sz) { case AES_KEYSIZE_128: @@ -556,7 +585,10 @@ static int sa_set_sc_enc(struct algo_data *ad, const u= 8 *key, u16 key_sz, =20 /* For AES-CBC decryption get the inverse key */ if (ad->inv_key && !enc) { - if (sa_aes_inv_key(&sc_buf[SC_ENC_KEY_OFFSET], key, key_sz)) + struct sa_crypto_data *dev_data =3D dev_get_drvdata(sa_k3_dev); + bool aes_cm =3D dev_data ? dev_data->aes_cm : false; + + if (sa_aes_inv_key(&sc_buf[SC_ENC_KEY_OFFSET], key, key_sz, aes_cm)) return -EINVAL; /* For all other cases: key is used */ } else { @@ -2459,6 +2491,63 @@ static const struct of_device_id of_match[] =3D { }; MODULE_DEVICE_TABLE(of, of_match); =20 +/* + * SA3UL_CM (aes_cm) requires a one-time TRNG-seeded AES-ECB priming + * operation after every power-up/reset before its side-channel + * countermeasures are considered active. This reuses the driver's own + * registered ecb(aes) transform with a throwaway random key/plaintext. + */ +static int sa_aes_cm_trng_prime(struct sa_crypto_data *dev_data) +{ + struct crypto_skcipher *tfm; + struct skcipher_request *req; + struct crypto_wait wait; + u8 key[AES_KEYSIZE_128]; + u8 *pt; + struct scatterlist sg; + int ret; + + pt =3D kmalloc(AES_BLOCK_SIZE, GFP_KERNEL); + if (!pt) + return -ENOMEM; + + get_random_bytes(key, sizeof(key)); + get_random_bytes(pt, AES_BLOCK_SIZE); + + tfm =3D crypto_alloc_skcipher("ecb-aes-sa2ul", 0, 0); + if (IS_ERR(tfm)) { + ret =3D PTR_ERR(tfm); + goto out_zero; + } + + req =3D skcipher_request_alloc(tfm, GFP_KERNEL); + if (!req) { + ret =3D -ENOMEM; + goto free_tfm; + } + + ret =3D crypto_skcipher_setkey(tfm, key, sizeof(key)); + if (ret) + goto free_req; + + sg_init_one(&sg, pt, AES_BLOCK_SIZE); + crypto_init_wait(&wait); + skcipher_request_set_callback(req, CRYPTO_TFM_REQ_MAY_SLEEP, + crypto_req_done, &wait); + skcipher_request_set_crypt(req, &sg, &sg, AES_BLOCK_SIZE, NULL); + + ret =3D crypto_wait_req(crypto_skcipher_encrypt(req), &wait); + +free_req: + skcipher_request_free(req); +free_tfm: + crypto_free_skcipher(tfm); +out_zero: + memzero_explicit(key, sizeof(key)); + kfree(pt); + return ret; +} + static int sa_ul_probe(struct platform_device *pdev) { struct device *dev =3D &pdev->dev; @@ -2499,6 +2588,7 @@ static int sa_ul_probe(struct platform_device *pdev) major =3D FIELD_GET(SA_REVISION_MAJOR_MASK, rev); minor =3D FIELD_GET(SA_REVISION_MINOR_MASK, rev); dev_info(dev, "SAxUL_VERSION: %u.%u\n", major, minor); + dev_data->aes_cm =3D (major =3D=3D 3 && minor =3D=3D 1); =20 ret =3D sa_init_mem(dev_data); if (ret) @@ -2530,6 +2620,12 @@ static int sa_ul_probe(struct platform_device *pdev) =20 sa_register_algos(dev_data); =20 + if (dev_data->aes_cm) { + ret =3D sa_aes_cm_trng_prime(dev_data); + if (ret) + dev_warn(dev, "aes_cm TRNG priming failed: %d\n", ret); + } + ret =3D of_platform_populate(node, NULL, NULL, dev); if (ret) goto unregister_algos; diff --git a/drivers/crypto/sa2ul.h b/drivers/crypto/sa2ul.h index c5e73ed14f44..045fedda90c9 100644 --- a/drivers/crypto/sa2ul.h +++ b/drivers/crypto/sa2ul.h @@ -184,6 +184,8 @@ struct sa_crypto_data { struct dma_chan *dma_rx2; struct dma_chan *dma_tx; struct crypto_engine *engine; + /* true if HW is SA3UL_CM (SA_REVISION major=3D3 minor=3D1) */ + bool aes_cm; }; =20 /** --=20 2.43.0