From nobody Fri Sep 25 09:21:18 2026 Received: from OS0P286CU011.outbound.protection.outlook.com (mail-japanwestazon11010062.outbound.protection.outlook.com [52.101.228.62]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 2F04E49E5EC for ; Mon, 14 Sep 2026 20:16:00 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=fail smtp.client-ip=52.101.228.62 ARC-Seal: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1789416963; cv=fail; b=ZjfwQ86SIAGq+ClaUUl96zT9sDZIHT7mYpyEdusiSXRLxtUk7r401VDL/Ft6e2P4DXAszjP0Lw6tKvFozz9ETbctJZyxUryaSQmIgNO2E144jr82ghu9TMWqaf/TDGAN+b80IY2stWuDNBqysPHSrX8cFd0JWrH4shQqFyCGnag= ARC-Message-Signature: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1789416963; c=relaxed/simple; bh=t8bsygYQFB4cJt6KiM7uas2AH6+yP8A62DdUz9+XbTg=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=aKxM3ivFwSdGHLnTq16e3jr5L2v0a24lCaUzgzC0VU87xC+iXX0vgGluzeZG7OY6j/soWCqmo4CeDOA6zVzG3/NnY23xp4s2GJU3hQ6Kybbbwcd0RcRAShhWpQRcT1rxtwbMjqTsVmUkFWouAj8/aGGGJ9gZkDQPnVRsPzlfDt8= ARC-Authentication-Results: i=2; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=renesas.com; spf=pass smtp.mailfrom=renesas.com; dkim=pass (1024-bit key) header.d=renesas.com header.i=@renesas.com header.b=YtTXNJEk; arc=fail smtp.client-ip=52.101.228.62 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=renesas.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=renesas.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=renesas.com header.i=@renesas.com header.b="YtTXNJEk" ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=WFVObTWLZZeGw4MPdba8qx6ZXYLqajA7Obdd6V1lVaN4AsJS2tpsl5vpV6X75p1BvQ76FVsxLloujABK8mvB7JeAGfuXsf23rReC8pUotIgnCxvMYik4qmaXBrjv2wdP7r39Wxd8RZ+8yjrx3fbCPeQHkT8eMQLcghlrFoUmYjcYYgWznbY5enulvbI3a2hOcxrrgCmTx0OJ2b1T7a3oYfFVM+cNSRq1qsJDHIwHOsebvrGmlUrsQeHC+KrYFoq6LPtGX8H6L9jA/MrMp93/ZjrSzzSqfOsomBg+iK3vo9qvthXFLy+tYwOOgsLoWUWEh4rOBtphWFTta24iRzwKUw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=G5ovWw/djs60bamXLV3iewL0ukoTqaeEgj3TniqV9S0=; b=kURrD6Ud1x4idxVMhS1L7rzl5vVqVCpoQ72O0aF++cNNLjtF1ehRjhJcBCuAHxWRvnl8H0rNeI8lJTWcZYp5aIXfYhDIs3MVGHjNdxv5MA9l4uNva0Egq2A1hoCxnFvMf13cev9gLBcg4U1v959NfU60Zn607/LdrYrFDwbG6hlb6l5aqsktf9O2X92+5N/8S5WO36+UZTsZZdLMf+Pb/ipq5lIcoq6BZOoImXAwUHuvDO9Kvod8B2CqU86ANQyZ2ulXuT6ZfdnuVlLSW+BxqZDGPriwB7bajWEr/SgZvku7TEsXKnDV7JH9U+35/NQzJgv5mqaSkOj13r1d98Q4lw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 8.62.32.50) smtp.rcpttodomain=kernel.org smtp.mailfrom=renesas.com; dmarc=pass (p=none sp=none pct=100) action=none header.from=renesas.com; dkim=none (message not signed); arc=none (0) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=renesas.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=G5ovWw/djs60bamXLV3iewL0ukoTqaeEgj3TniqV9S0=; b=YtTXNJEkqtkILPDKIPg05Zz8ZwtNwitMyDtKAbnM3ZhHmabvWL3sOX/hg7hvV23ThriNu4NmSlQH8A+ds0atOp+jsVSL0WtIf8/tcd76KzdyWn8iVPpo93fHub527P+3d7WrCcIU1HopL1JRGkiAEd/eea8yor/WOysVEy8rScY= Received: from TY4P286CA0075.JPNP286.PROD.OUTLOOK.COM (2603:1096:405:36d::18) by TY3PR01MB10014.jpnprd01.prod.outlook.com (2603:1096:400:1ab::12) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.21.406.12; Mon, 14 Sep 2026 20:15:57 +0000 Received: from TYO1EPF00005022.JPNP286.PROD.OUTLOOK.COM (2603:1096:405:36d:cafe::75) by TY4P286CA0075.outlook.office365.com (2603:1096:405:36d::18) with Microsoft SMTP Server (version=TLS1_3, cipher=TLS_AES_256_GCM_SHA384) id 15.21.406.12 via Frontend Transport; Mon, 14 Sep 2026 20:15:57 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 8.62.32.50) smtp.mailfrom=renesas.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=renesas.com; Received-SPF: Pass (protection.outlook.com: domain of renesas.com designates 8.62.32.50 as permitted sender) receiver=protection.outlook.com; client-ip=8.62.32.50; helo=ejcrelay005p.adwin.renesas.com; pr=E Received: from ejcrelay005p.adwin.renesas.com (8.62.32.50) by TYO1EPF00005022.mail.protection.outlook.com (10.167.240.7) with Microsoft SMTP Server (version=TLS1_3, cipher=TLS_AES_256_GCM_SHA384) id 15.21.428.7 via Frontend Transport; Mon, 14 Sep 2026 20:15:57 +0000 Received: from demon-pc.localdomain (unknown [10.226.93.156]) by ejcrelay005p.adwin.renesas.com (Postfix) with ESMTP id E6D67300026E; Tue, 15 Sep 2026 05:15:55 +0900 (JST) From: Cosmin Tanislav To: Lee Jones Cc: mfd@lists.linux.dev, linux-kernel@vger.kernel.org, Cosmin Tanislav Subject: [PATCH 1/3] mfd: rz-mtu3: do not use struct rz_mtu3_channel::dev Date: Mon, 14 Sep 2026 23:14:54 +0300 Message-ID: <20260914201456.2018403-2-cosmin-gabriel.tanislav.xa@renesas.com> X-Mailer: git-send-email 2.55.0 In-Reply-To: <20260914201456.2018403-1-cosmin-gabriel.tanislav.xa@renesas.com> References: <20260914201456.2018403-1-cosmin-gabriel.tanislav.xa@renesas.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: TYO1EPF00005022:EE_|TY3PR01MB10014:EE_ X-MS-Office365-Filtering-Correlation-Id: a34a2fe4-c915-4dac-2302-08df129cfcc5 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|1800799024|82310400026|376014|36860700016|23010399003|10067099003|6133799003|18002099003|22082099003|56012099006|11063799006; X-Microsoft-Antispam-Message-Info: 4ZeFXRUIN75rK6xg9rq4ZOuEPa/xCevrMETNKsF0SmdX3/h0cu4vZhdSEvEI2e3Khn4PvJMLsWMhMzNKb23b2aZxVeOZZ9HE8nUwxzOYEU9BHJuMoeZC3W9RMFRkjZ7GAgexdNDJKokceWw+cS1D2Cx0mGXjthCgT44JZDNZVOWQ3y77pP53ZwQUh+fRLrPdJnxK8NVrj59oFOygtnDaMcCAO2fenMw5lGjyia9N3JSyZr0Ye8RfdamrqBOqAY0ICtGiyhJcRK5PIrSOZ1D8/IYBAD5/NFoI6ThwJMTjCUIQGmYL2S7QvLKpIK7EoAlrz0VGM8kqmrad40ahlTu6yVfpR0cJ2Th3fh8pL3rJlaaKcvNLmXJmEu/zsHi+Lc7K/o1HmubtPYBYeaSYEbJHvrKhFGvquTB4zJwzkghdAi7KynlG+kIwXHfH8BCuM9WwGB2pK1kHzwamjWtMBd6/usNz89SrQJO+c/0Rm2be8dZlGYh1hj2RW7/qzwLvg/gDrc2ZTwQSypM0ikrt+pjPC56ACnqpgzFJsyqAK7ZlhWZzSwE+Zs2FcK3nLWNqG3X5gtzYflcfqiWCaI4sgzA6yHLCZPnNzAhL9Hmu236LDwoJxORetTu6/4N+GGbFYDOnpAslgj3V0nGKiEFX0jiBaPdkGHhqVd2kutqpIb+oWC9/BuMUylDcayvx2uLI1VxBPiQtt6I6lZCP/90CFqBy+A== X-Forefront-Antispam-Report: CIP:8.62.32.50;CTRY:US;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:ejcrelay005p.adwin.renesas.com;PTR:InfoDomainNonexistent;CAT:NONE;SFS:(13230040)(1800799024)(82310400026)(376014)(36860700016)(23010399003)(10067099003)(6133799003)(18002099003)(22082099003)(56012099006)(11063799006);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: B3ZqHvl9rfe3SircV1FVbcqzt9s9G0AJvj8iglwwiMA8zVfkPjXZvjrVaGlB4o6g+3DN35GCLNVznR20T6/qoWsI7zN83WWpXwe9b33WFQHlAuGaIou77JJw4O7bV/QtaY75BpieMcY4pze4cL1W5KX6Vl/rvpGRkmI6m+Og0JhbWdchPpYG9fjbv6QlaLeAO+Mq7SyfJhtNQbeTjcCJrruQAOLLlqIhJn0VEjEsv0ahQvD57I6KJor6bBLHTGcFcbGLj9K9WNO/9jFgXAfvjjSCfdihP3ilKk+ONTh0Ch3BZwZU0iB7O9uh97r0DzIHng6B4m1X+2IA7n9ehO5ppH4pNMgPzFcfphioBGaAnVpzMT72u93CJXHxKiGOcGCF3nSz42Dghq2pdbae+EvGy6KT9ylouHsPKDlfTZaQKeJB+dESQq/c6peTI1OvN89w X-OriginatorOrg: renesas.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 14 Sep 2026 20:15:57.4378 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: a34a2fe4-c915-4dac-2302-08df129cfcc5 X-MS-Exchange-CrossTenant-Id: 53d82571-da19-47e4-9cb4-625a166a4a2a X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=53d82571-da19-47e4-9cb4-625a166a4a2a;Ip=[8.62.32.50];Helo=[ejcrelay005p.adwin.renesas.com] X-MS-Exchange-CrossTenant-AuthSource: TYO1EPF00005022.JPNP286.PROD.OUTLOOK.COM X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: TY3PR01MB10014 Content-Type: text/plain; charset="utf-8" Channels 1 and 2 are used by both the PWM and counter drivers. Both subdrivers assign struct rz_mtu3_channel::dev to their own device instance for those shared channels, so the value stored in it depends on which subdriver binds last. The MFD core helpers currently use ch->dev->parent to retrieve the parent driver data, which makes them depend on subdriver-populated state. This is fragile for shared channels and unnecessarily couples the core to child driver initialization. Introduce a rz_mtu3_ch_to_priv() helper that takes in a pointer to a struct rz_mtu3_channel and returns a pointer to the struct rz_mtu3_priv. This is possible because the struct rz_mtu3_channel contains its index (channel_number) in the struct rz_mtu3's channels array, allowing us to retrieve the pointer of the first channel, and then its container. By doing this, we remove the dependency on subdriver assigned data from the parent driver. Keep struct rz_mtu3_channel::dev for now, as it is still used by the PWM and counter drivers. Signed-off-by: Cosmin Tanislav --- drivers/mfd/rz-mtu3.c | 41 +++++++++++++++++++---------------------- 1 file changed, 19 insertions(+), 22 deletions(-) diff --git a/drivers/mfd/rz-mtu3.c b/drivers/mfd/rz-mtu3.c index 0a254e61ec0a..d809436e2124 100644 --- a/drivers/mfd/rz-mtu3.c +++ b/drivers/mfd/rz-mtu3.c @@ -60,10 +60,17 @@ static bool rz_mtu3_is_16bit_shared_reg(u16 offset) offset =3D=3D RZ_MTU3_TCNTSA || offset =3D=3D RZ_MTU3_TCNTSB); } =20 +static inline struct rz_mtu3_priv *rz_mtu3_ch_to_priv(struct rz_mtu3_chann= el *ch) +{ + struct rz_mtu3_channel *first_ch =3D ch - ch->channel_number; + struct rz_mtu3 *mtu =3D container_of(first_ch, struct rz_mtu3, channels[0= ]); + + return mtu->priv_data; +} + u16 rz_mtu3_shared_reg_read(struct rz_mtu3_channel *ch, u16 offset) { - struct rz_mtu3 *mtu =3D dev_get_drvdata(ch->dev->parent); - struct rz_mtu3_priv *priv =3D mtu->priv_data; + struct rz_mtu3_priv *priv =3D rz_mtu3_ch_to_priv(ch); =20 if (rz_mtu3_is_16bit_shared_reg(offset)) return readw(priv->mmio + offset); @@ -74,8 +81,7 @@ EXPORT_SYMBOL_GPL(rz_mtu3_shared_reg_read); =20 u8 rz_mtu3_8bit_ch_read(struct rz_mtu3_channel *ch, u16 offset) { - struct rz_mtu3 *mtu =3D dev_get_drvdata(ch->dev->parent); - struct rz_mtu3_priv *priv =3D mtu->priv_data; + struct rz_mtu3_priv *priv =3D rz_mtu3_ch_to_priv(ch); u16 ch_offs; =20 ch_offs =3D rz_mtu3_8bit_ch_reg_offs[ch->channel_number][offset]; @@ -86,8 +92,7 @@ EXPORT_SYMBOL_GPL(rz_mtu3_8bit_ch_read); =20 u16 rz_mtu3_16bit_ch_read(struct rz_mtu3_channel *ch, u16 offset) { - struct rz_mtu3 *mtu =3D dev_get_drvdata(ch->dev->parent); - struct rz_mtu3_priv *priv =3D mtu->priv_data; + struct rz_mtu3_priv *priv =3D rz_mtu3_ch_to_priv(ch); u16 ch_offs; =20 /* MTU8 doesn't have 16-bit registers */ @@ -102,8 +107,7 @@ EXPORT_SYMBOL_GPL(rz_mtu3_16bit_ch_read); =20 u32 rz_mtu3_32bit_ch_read(struct rz_mtu3_channel *ch, u16 offset) { - struct rz_mtu3 *mtu =3D dev_get_drvdata(ch->dev->parent); - struct rz_mtu3_priv *priv =3D mtu->priv_data; + struct rz_mtu3_priv *priv =3D rz_mtu3_ch_to_priv(ch); u16 ch_offs; =20 if (ch->channel_number !=3D RZ_MTU3_CHAN_1 && ch->channel_number !=3D RZ_= MTU3_CHAN_8) @@ -117,8 +121,7 @@ EXPORT_SYMBOL_GPL(rz_mtu3_32bit_ch_read); =20 void rz_mtu3_8bit_ch_write(struct rz_mtu3_channel *ch, u16 offset, u8 val) { - struct rz_mtu3 *mtu =3D dev_get_drvdata(ch->dev->parent); - struct rz_mtu3_priv *priv =3D mtu->priv_data; + struct rz_mtu3_priv *priv =3D rz_mtu3_ch_to_priv(ch); u16 ch_offs; =20 ch_offs =3D rz_mtu3_8bit_ch_reg_offs[ch->channel_number][offset]; @@ -128,8 +131,7 @@ EXPORT_SYMBOL_GPL(rz_mtu3_8bit_ch_write); =20 void rz_mtu3_16bit_ch_write(struct rz_mtu3_channel *ch, u16 offset, u16 va= l) { - struct rz_mtu3 *mtu =3D dev_get_drvdata(ch->dev->parent); - struct rz_mtu3_priv *priv =3D mtu->priv_data; + struct rz_mtu3_priv *priv =3D rz_mtu3_ch_to_priv(ch); u16 ch_offs; =20 /* MTU8 doesn't have 16-bit registers */ @@ -143,8 +145,7 @@ EXPORT_SYMBOL_GPL(rz_mtu3_16bit_ch_write); =20 void rz_mtu3_32bit_ch_write(struct rz_mtu3_channel *ch, u16 offset, u32 va= l) { - struct rz_mtu3 *mtu =3D dev_get_drvdata(ch->dev->parent); - struct rz_mtu3_priv *priv =3D mtu->priv_data; + struct rz_mtu3_priv *priv =3D rz_mtu3_ch_to_priv(ch); u16 ch_offs; =20 if (ch->channel_number !=3D RZ_MTU3_CHAN_1 && ch->channel_number !=3D RZ_= MTU3_CHAN_8) @@ -157,8 +158,7 @@ EXPORT_SYMBOL_GPL(rz_mtu3_32bit_ch_write); =20 void rz_mtu3_shared_reg_write(struct rz_mtu3_channel *ch, u16 offset, u16 = value) { - struct rz_mtu3 *mtu =3D dev_get_drvdata(ch->dev->parent); - struct rz_mtu3_priv *priv =3D mtu->priv_data; + struct rz_mtu3_priv *priv =3D rz_mtu3_ch_to_priv(ch); =20 if (rz_mtu3_is_16bit_shared_reg(offset)) writew(value, priv->mmio + offset); @@ -170,8 +170,7 @@ EXPORT_SYMBOL_GPL(rz_mtu3_shared_reg_write); void rz_mtu3_shared_reg_update_bit(struct rz_mtu3_channel *ch, u16 offset, u16 pos, u8 val) { - struct rz_mtu3 *mtu =3D dev_get_drvdata(ch->dev->parent); - struct rz_mtu3_priv *priv =3D mtu->priv_data; + struct rz_mtu3_priv *priv =3D rz_mtu3_ch_to_priv(ch); unsigned long tmdr, flags; =20 spin_lock_irqsave(&priv->lock, flags); @@ -244,8 +243,7 @@ static u8 rz_mtu3_get_tstr_bit_pos(struct rz_mtu3_chann= el *ch) =20 static void rz_mtu3_start_stop_ch(struct rz_mtu3_channel *ch, bool start) { - struct rz_mtu3 *mtu =3D dev_get_drvdata(ch->dev->parent); - struct rz_mtu3_priv *priv =3D mtu->priv_data; + struct rz_mtu3_priv *priv =3D rz_mtu3_ch_to_priv(ch); unsigned long flags, tstr; u16 offset; u8 bitpos; @@ -265,8 +263,7 @@ static void rz_mtu3_start_stop_ch(struct rz_mtu3_channe= l *ch, bool start) =20 bool rz_mtu3_is_enabled(struct rz_mtu3_channel *ch) { - struct rz_mtu3 *mtu =3D dev_get_drvdata(ch->dev->parent); - struct rz_mtu3_priv *priv =3D mtu->priv_data; + struct rz_mtu3_priv *priv =3D rz_mtu3_ch_to_priv(ch); unsigned long flags, tstr; u16 offset; u8 bitpos; --=20 2.55.0 From nobody Fri Sep 25 09:21:18 2026 Received: from OS0P286CU011.outbound.protection.outlook.com (mail-japanwestazon11010005.outbound.protection.outlook.com [52.101.228.5]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 93F2849EC4F for ; Mon, 14 Sep 2026 20:16:03 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=fail smtp.client-ip=52.101.228.5 ARC-Seal: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1789416965; cv=fail; b=jjLcOf8acoCoOhFIklANTernvx1oGh4OCaKWmVCffv2Z2L8HZbLlOI2eNpNsH8OdPDDG75VxxhDoMnsbBGzubAJkUbMqaQGZWyrRV43d4RLjEDZOcObyRx/AUZrD6OUZcSdkqB6dKJrbYaCsYlVTYDZh1HcIZ3D0df2R65x9ZnI= ARC-Message-Signature: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1789416965; c=relaxed/simple; bh=30vD1Tcr5FjlLgdhCqyE7V+NtD7fd9dZyO8HKs3xtlM=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=hRnecsERRzLx+BdI/zu1b0F3vnJY1bv2eB40bc9/eWFLXJYNdBkP1p9hkeiT0hbXTjKsK+9g0ZaoWXJRxbyD2Cb2RmrBcQfk2wzIImjPMJK00eudvAaU2KShhg9vYkPvWLG5LX7dXAlYU/vcLH+pMEX7k6mCUNEjN7FndKVphU8= ARC-Authentication-Results: i=2; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=renesas.com; spf=pass smtp.mailfrom=renesas.com; dkim=pass (1024-bit key) header.d=renesas.com header.i=@renesas.com header.b=oBWy1p4T; arc=fail smtp.client-ip=52.101.228.5 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=renesas.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=renesas.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=renesas.com header.i=@renesas.com header.b="oBWy1p4T" ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=fh4ZPMUS096hAOslvPPsuY3mtVjftkbFrqtLGV7MqqOFQa9Vxr/sHPtlm+/UbV8HtKpRaRbdvHTzR5zG4UrYSsLXirnrz8OPzgVPfnoUYOoSSBBoHUMTV9lm5TjoXZlWs2u7FuTf1Ryteeunb11mfyTMRuOWRbz4sKb1SeAHf23cUudqYtdTy0VDI+mcEoa/WdiVdYPwCVD7/1PTgIFEpZzfNx+f++llvCFJOuhSia6SG/Lmc4JhZFlHY1MY/IAHAyvloQsrOto1B3vc6uZUFAH86e+3fMY/B+p0VwDiC0zvVGZRypQo9UK9j5p4y9Nk20iNauJ3wZqOk8yxCYCpGw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=FnVbdkHgTdASCFUIvn1WWIe5QXLKBMmkFeIeCEsmLeU=; b=Zj4ZJ6hGPTlvS7eH72GyVkZG5L/2jGtQuLf2eT7kkbjC91zfuWdVHdSqXA5ev1ks2FnE4MJTkfRK3C9iMxfXOBWiUYxd1gjWAk/S6aFpv9O4FWbUnRZWmGbB6aegnwGAPI+fcO27ftNSZF3se/NxEQ79f41ZzzfmFlVFxmKHrvKYSv3f7vCD6hGeZMAYd/OKJUaRW4tTS+jWAM5WF8MiKbz8pSF8PvEjTFsIPkOi/v1FM8a8hP8N7/980NV2HE46xlVSxWp3MSlC7XU8D7A4tcDOdQfqx2BNXy91j5ZnOcPHeW+feLZOQA9KYuG99wfWV8WnKcmqL4LumSyKNJ01DA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 8.62.32.50) smtp.rcpttodomain=kernel.org smtp.mailfrom=renesas.com; dmarc=pass (p=none sp=none pct=100) action=none header.from=renesas.com; dkim=none (message not signed); arc=none (0) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=renesas.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=FnVbdkHgTdASCFUIvn1WWIe5QXLKBMmkFeIeCEsmLeU=; b=oBWy1p4TwUh4qIkFxv1VFPE100L+dSKJQ7hNxL4W0YNE2840q5aCqlLC4mZGmIWe3Foir99ProeEwCuEOV/r88atGzwBv1TjWiJINMkppD7FWg5ysazNF6UUQCw5ocMIOw+Uh6+8iZV7KHNpIvkpD2N3DIGQmBS5dqpV60mZn/U= Received: from TY4P286CA0054.JPNP286.PROD.OUTLOOK.COM (2603:1096:405:36e::11) by TYWPR01MB10393.jpnprd01.prod.outlook.com (2603:1096:400:24a::14) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.21.406.12; Mon, 14 Sep 2026 20:16:00 +0000 Received: from TYO1EPF00005020.JPNP286.PROD.OUTLOOK.COM (2603:1096:405:36e:cafe::89) by TY4P286CA0054.outlook.office365.com (2603:1096:405:36e::11) with Microsoft SMTP Server (version=TLS1_3, cipher=TLS_AES_256_GCM_SHA384) id 15.21.406.12 via Frontend Transport; Mon, 14 Sep 2026 20:16:00 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 8.62.32.50) smtp.mailfrom=renesas.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=renesas.com; Received-SPF: Pass (protection.outlook.com: domain of renesas.com designates 8.62.32.50 as permitted sender) receiver=protection.outlook.com; client-ip=8.62.32.50; helo=ejcrelay005p.adwin.renesas.com; pr=E Received: from ejcrelay005p.adwin.renesas.com (8.62.32.50) by TYO1EPF00005020.mail.protection.outlook.com (10.167.240.5) with Microsoft SMTP Server (version=TLS1_3, cipher=TLS_AES_256_GCM_SHA384) id 15.21.428.7 via Frontend Transport; Mon, 14 Sep 2026 20:16:00 +0000 Received: from demon-pc.localdomain (unknown [10.226.93.156]) by ejcrelay005p.adwin.renesas.com (Postfix) with ESMTP id 73138300026F; Tue, 15 Sep 2026 05:15:58 +0900 (JST) From: Cosmin Tanislav To: Lee Jones Cc: mfd@lists.linux.dev, linux-kernel@vger.kernel.org, Cosmin Tanislav Subject: [PATCH 2/3] mfd: rz-mtu3: reuse shared_reg_update_bit() in start_stop_ch() Date: Mon, 14 Sep 2026 23:14:55 +0300 Message-ID: <20260914201456.2018403-3-cosmin-gabriel.tanislav.xa@renesas.com> X-Mailer: git-send-email 2.55.0 In-Reply-To: <20260914201456.2018403-1-cosmin-gabriel.tanislav.xa@renesas.com> References: <20260914201456.2018403-1-cosmin-gabriel.tanislav.xa@renesas.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: TYO1EPF00005020:EE_|TYWPR01MB10393:EE_ X-MS-Office365-Filtering-Correlation-Id: ffd0e878-9517-4d3c-9700-08df129cfe4d X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|1800799024|82310400026|23010399003|376014|36860700016|10067099003|18002099003|22082099003|56012099006|11063799006; X-Microsoft-Antispam-Message-Info: hdmnpmqZJlbh6A9yR2gvDj4FyNXg/5WEehbx8SFCanCqHE9rDoxmNx07FEEWfdkzf7stxv/Y51cGLwyO4DrbHxftMPdBI3JTnJpb1w7Mztf7/f4eti1hri6a+ztju8O5Q5S5WgIW2QxgzgrhcLgGHwibHHFfBfpTkhoUrdxbyt/fDOCINBdCM9thPQlDBCtE1DfTt3j6O8BPPzmaM8wr0GxgWWN57KAEyi2jouFCWDD4cMDEYumOdBgP1B2OrZoCdhDn1ahY5m20Pogyr1MaLIuMOUfSBAAH2hA1bcU5rrzo4qHTbFnH0WViocFsXxXrq6K70b+ronWEP284q9Skria6RMEyyF5Y0QngVOGzWE2He5BPT9FnR/Lgq2a3KqiTnpYSIatvBne0gT32STaw4CuiBuuBBFLCEMSLcy5OKkcTKvg8sfiwzMBxqGJjNGQQfbuMF3GDMsoDb6kvsazzyfezd08yUa1xur5ID+4/D4XAoOCXyawQckSi6OljbBipdp0F2043mhT6zlnP3p6mNvYFShKoR3/+L6zGFk02v8+u9RBh7+u5lUhKcj01RQwQdBxCOIQPvjD7e06NbxuKMspWDnsQJD0tO1gJtQUez74lyGt/V1ohj/8L+DOUplVpEf4RKmYEKy7P7xYoKFBE6gT3xhzgezb7EwVTRU3BIjVaT4IOdDDRu2OlXAJSVLlSzKz25v339x8Y6HoL5suaOw== X-Forefront-Antispam-Report: CIP:8.62.32.50;CTRY:US;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:ejcrelay005p.adwin.renesas.com;PTR:InfoDomainNonexistent;CAT:NONE;SFS:(13230040)(1800799024)(82310400026)(23010399003)(376014)(36860700016)(10067099003)(18002099003)(22082099003)(56012099006)(11063799006);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: Zn4nGF5/QAUInkii/NpvGwBe/X16uAifq0OWlOKvn2rWQp4yd0dIJ3QROmaX0I4RgEwvf+nN8x8ZWdEw2H9Y78TjpqMZyos1luuTR4wq5jwk8KvtFHFq9qzDHyORtDI5fWchjvRI/9bLCy9CnUwbH4fQqMZ37nDSI8UVHxXEsBnb5bPwJlX+KxgOOJTdTwdvrpS9guBbUgAXnA1cZRVSja07hJ5emUkUbJdLdBQuCWRKgBOb7kYsy1VCSWqAoAGkOUY0CvWvkNKkRT4qlpcEuwdF3BBckm258K6oydQTxLLRafVnGQyTZeHn09H3ao7SqL++OOT4Ay7AXVNXiW233ngyfc0V35opI1dGsGTM7iO8mASddvy0wW2jgB5exNP+0miS2HH7bE+jYbSJL1ynUURVyDMvLHe1DKiRtRgghkqkAoPxJDajnZ3AUKMV0Ocz X-OriginatorOrg: renesas.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 14 Sep 2026 20:16:00.0057 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: ffd0e878-9517-4d3c-9700-08df129cfe4d X-MS-Exchange-CrossTenant-Id: 53d82571-da19-47e4-9cb4-625a166a4a2a X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=53d82571-da19-47e4-9cb4-625a166a4a2a;Ip=[8.62.32.50];Helo=[ejcrelay005p.adwin.renesas.com] X-MS-Exchange-CrossTenant-AuthSource: TYO1EPF00005020.JPNP286.PROD.OUTLOOK.COM X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: TYWPR01MB10393 Content-Type: text/plain; charset="utf-8" rz_mtu3_start_stop_ch() performs the same shared register update sequence already implemented by rz_mtu3_shared_reg_update_bit(). Reuse the helper instead of open-coding the read-modify-write sequence. Signed-off-by: Cosmin Tanislav --- drivers/mfd/rz-mtu3.c | 26 ++++++-------------------- 1 file changed, 6 insertions(+), 20 deletions(-) diff --git a/drivers/mfd/rz-mtu3.c b/drivers/mfd/rz-mtu3.c index d809436e2124..88aa1fedf1ef 100644 --- a/drivers/mfd/rz-mtu3.c +++ b/drivers/mfd/rz-mtu3.c @@ -171,12 +171,12 @@ void rz_mtu3_shared_reg_update_bit(struct rz_mtu3_cha= nnel *ch, u16 offset, u16 pos, u8 val) { struct rz_mtu3_priv *priv =3D rz_mtu3_ch_to_priv(ch); - unsigned long tmdr, flags; + unsigned long reg_val, flags; =20 spin_lock_irqsave(&priv->lock, flags); - tmdr =3D rz_mtu3_shared_reg_read(ch, offset); - __assign_bit(pos, &tmdr, !!val); - rz_mtu3_shared_reg_write(ch, offset, tmdr); + reg_val =3D rz_mtu3_shared_reg_read(ch, offset); + __assign_bit(pos, ®_val, !!val); + rz_mtu3_shared_reg_write(ch, offset, reg_val); spin_unlock_irqrestore(&priv->lock, flags); } EXPORT_SYMBOL_GPL(rz_mtu3_shared_reg_update_bit); @@ -243,22 +243,8 @@ static u8 rz_mtu3_get_tstr_bit_pos(struct rz_mtu3_chan= nel *ch) =20 static void rz_mtu3_start_stop_ch(struct rz_mtu3_channel *ch, bool start) { - struct rz_mtu3_priv *priv =3D rz_mtu3_ch_to_priv(ch); - unsigned long flags, tstr; - u16 offset; - u8 bitpos; - - offset =3D rz_mtu3_get_tstr_offset(ch); - bitpos =3D rz_mtu3_get_tstr_bit_pos(ch); - - /* start stop register shared by multiple timer channels */ - spin_lock_irqsave(&priv->lock, flags); - - tstr =3D rz_mtu3_shared_reg_read(ch, offset); - __assign_bit(bitpos, &tstr, start); - rz_mtu3_shared_reg_write(ch, offset, tstr); - - spin_unlock_irqrestore(&priv->lock, flags); + rz_mtu3_shared_reg_update_bit(ch, rz_mtu3_get_tstr_offset(ch), + rz_mtu3_get_tstr_bit_pos(ch), start); } =20 bool rz_mtu3_is_enabled(struct rz_mtu3_channel *ch) --=20 2.55.0 From nobody Fri Sep 25 09:21:18 2026 Received: from OS0P286CU011.outbound.protection.outlook.com (mail-japanwestazon11010007.outbound.protection.outlook.com [52.101.228.7]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 84BD73EE1FC for ; Mon, 14 Sep 2026 20:16:06 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=fail smtp.client-ip=52.101.228.7 ARC-Seal: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1789416968; cv=fail; b=cmhogpmtvp7mfSAYHGT51QPkWXfyvAgrCJWx8rfSeYIdbVn3hKRxV2tZ68GvRsvqhuKO//W360UA0DDNxgV751vWs8VhCxZQWdZk6q9TDbmFPL75+VClO2tamIbHOWYam/8dTvc63iOq2+YzjC+E3248QLGuRT3Lh5iZDYEUdJY= ARC-Message-Signature: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1789416968; c=relaxed/simple; bh=HIq3d2THEE+uceefQSDjo4gK9vlo/Kdo3bTukB9yn8Y=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=ICMIYZ0Fm5puizRn+nVcHOkns067lMxpItSN1mHalpsHQ3jpu9e/eGimk7nqrA//ctrRuagbDH7VqhOA2Q6bRMcUc+rzwq0mTerGzteoYmyaI+7abjE3SB1e+aRUWzh0kF3bn1+QHeAts7wCly3wIUaCLXOTUov75j7EC4fGhEY= ARC-Authentication-Results: i=2; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=renesas.com; spf=pass smtp.mailfrom=renesas.com; dkim=pass (1024-bit key) header.d=renesas.com header.i=@renesas.com header.b=CdtX4A/1; arc=fail smtp.client-ip=52.101.228.7 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=renesas.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=renesas.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=renesas.com header.i=@renesas.com header.b="CdtX4A/1" ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=RvJJCer7yud5qGnCoF+iUtc7uUyTaLa6KQwP4QwSF5SpljBJIxMZbPFbRd1uduYM7L+T48lEv2ui0JVmvO8TNo7fDwgZNpJ9J5oskyRNb5A+lpsNj/gnFF3VIxO35x6oEaIVHtUAp2mZUVxxSdGJ5y3V++akVPEwUVqIf0gnx2GpiGyRPaeziMc+CVoxyUQ7XvcFsxSbVXIkJULXR6JQW3aqjUkCl7aGiadMFzCKQJjasLWYu6Y6RLLx23Ry4xpMxpsAfoJTO/0Fn/5y7WsqrZQdroLhUgx3651wdy/rLODuGhbdWOr4h5J/dSBpwPx0sUw7F18HgwHP7/F5ILtzDw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=70ypXDo+cUSvzBsmcNDgWX4GSlEbxKHOqqHQ/jmsL2I=; b=qZLioXfm++DNLwRZOCf/vhQOuaJfpQ68LCSRoGSzieI4ZDNjYs/oTuGEVTXf8TFBUjND4P/pjtJYsNBNZsjnopwOtOuNxc6BD70LqJH/mBvWL+l0M2qPQRX9GfVI0CTOi8qVs/LoskXl5SeaKY8rsjqQw0r1/qhRV/pM40eH1t6c/C7TjSbKdQRgD9An7taPac6AM0TjZ98xCVCD443fgukdUnKamv5Tfc1QQWgUdjLeklYzgPXqXQ2nCmUCXFz7Dsyc42lJzdbgMqhCuNpi+A8cWRCe95ryE/0HUeQVObHhiJsTrnUMRwjay9+ZJUM6mz+4ZWUYyF0OKGtANJSAVg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 8.62.32.50) smtp.rcpttodomain=kernel.org smtp.mailfrom=renesas.com; dmarc=pass (p=none sp=none pct=100) action=none header.from=renesas.com; dkim=none (message not signed); arc=none (0) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=renesas.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=70ypXDo+cUSvzBsmcNDgWX4GSlEbxKHOqqHQ/jmsL2I=; b=CdtX4A/1UQ7lvvpUo7O+Ot7UvyRW3vQyfulTR1ivIPcZNMieMugiaDd/aHk6dj5JiwKNjyvgNmkgNY7D2dKKO6z8dZSvPM0EElH12cDTORnlWNgjfcUU1j0EowXGr1pPgqZTlBSDhCRu04yI5CVerzvx6AyNfrMNYgSwC9FwIvI= Received: from TY4P286CA0084.JPNP286.PROD.OUTLOOK.COM (2603:1096:405:36d::14) by TYCPR01MB9450.jpnprd01.prod.outlook.com (2603:1096:400:198::12) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.21.406.12; Mon, 14 Sep 2026 20:16:02 +0000 Received: from TYO1EPF00005022.JPNP286.PROD.OUTLOOK.COM (2603:1096:405:36d:cafe::50) by TY4P286CA0084.outlook.office365.com (2603:1096:405:36d::14) with Microsoft SMTP Server (version=TLS1_3, cipher=TLS_AES_256_GCM_SHA384) id 15.21.406.12 via Frontend Transport; Mon, 14 Sep 2026 20:16:02 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 8.62.32.50) smtp.mailfrom=renesas.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=renesas.com; Received-SPF: Pass (protection.outlook.com: domain of renesas.com designates 8.62.32.50 as permitted sender) receiver=protection.outlook.com; client-ip=8.62.32.50; helo=ejcrelay005p.adwin.renesas.com; pr=E Received: from ejcrelay005p.adwin.renesas.com (8.62.32.50) by TYO1EPF00005022.mail.protection.outlook.com (10.167.240.7) with Microsoft SMTP Server (version=TLS1_3, cipher=TLS_AES_256_GCM_SHA384) id 15.21.428.7 via Frontend Transport; Mon, 14 Sep 2026 20:16:02 +0000 Received: from demon-pc.localdomain (unknown [10.226.93.156]) by ejcrelay005p.adwin.renesas.com (Postfix) with ESMTP id 0CF9C300026F; Tue, 15 Sep 2026 05:16:00 +0900 (JST) From: Cosmin Tanislav To: Lee Jones Cc: mfd@lists.linux.dev, linux-kernel@vger.kernel.org, Cosmin Tanislav Subject: [PATCH 3/3] mfd: rz-mtu3: enable runtime PM Date: Mon, 14 Sep 2026 23:14:56 +0300 Message-ID: <20260914201456.2018403-4-cosmin-gabriel.tanislav.xa@renesas.com> X-Mailer: git-send-email 2.55.0 In-Reply-To: <20260914201456.2018403-1-cosmin-gabriel.tanislav.xa@renesas.com> References: <20260914201456.2018403-1-cosmin-gabriel.tanislav.xa@renesas.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: TYO1EPF00005022:EE_|TYCPR01MB9450:EE_ X-MS-Office365-Filtering-Correlation-Id: 76f00bbc-a10f-432b-15d3-08df129cffcf X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|1800799024|36860700016|82310400026|376014|23010399003|11063799006|56012099006|10067099003|22082099003|18002099003; X-Microsoft-Antispam-Message-Info: PwOTc4rKYAdRtubk/XbklSJfLT7UXZKz/oXvEwgji0t1wzZQBpb4VpIa++A4hPor9XPegNjQMJODgdB57L/7fMrI+ViJZpKsgUSFnn+inF4NGa4DPP9ObeGeT10dbfFTyjw1vzFD1YiSJSM1DvgTkjzf94AOHGzak1exZUlxj8WLrJ9BTSjY69CrCzl3zMV7mmAs75ZkzL2mbMwJQmxKEeFDIDFB90UA+3jv50eidn6wvo5vW/TQ7anbGTiAFPA58C/U1rNeInpPRtDfmf1Jdgqi2mxbfRphAYzuWMRMsvX9dgjRF9fBwPyxbnVcPj6xdo0PlkV1f02Y5a+1nu1wcXEBvtmSw3tdBROFSETGg5GPVMqnEw24A5tumu0XvIi6NPO3iIgHqmMdB9cv8z7JWgGNAFvamRkbwM5TzfzII4MP3Qtj77MrVO1joW6rkwnhPi+D8F9NRqryK2KIf2JSrF5SdOStE7BRp1nkXdrvbAav3PBosD/0Dqpa+E01inOrNliPqo4Kua9DDaE+HL+sb0M3crfs69uAmXuMOWx9ocOu55AvvIE+1bTt922cIwrTbMcPfmMdT02w2Gy+QFVhzuFHaLMJBTZ+N6H3vVWswJJI2/nKQKTgGVvrMWMdULV/347nHhm6Xo03VbwLgI5FvIJYlkx+TF2zoyXWB2N/BqaLdae95Pvayap8hGi1BIaZPwVKa5PgbuCqMa9ln9ndYA== X-Forefront-Antispam-Report: CIP:8.62.32.50;CTRY:US;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:ejcrelay005p.adwin.renesas.com;PTR:InfoDomainNonexistent;CAT:NONE;SFS:(13230040)(1800799024)(36860700016)(82310400026)(376014)(23010399003)(11063799006)(56012099006)(10067099003)(22082099003)(18002099003);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: 5HaJR0C4CQkXjGyjYdVjQzcbfVRj31MiNbMK1M6+DbBVXJfAJsU31MzCiisHQwmSsOnAEMktPi8ueVx6ILIcIykJHwOUJjlqxdnOB0hmPZw69Af3rZjFP1yI7E6F67vIQb42AJlAmhQwHJchvWzFZJ+7puiesPiNlutkNBgJ7+aHe1/XUlKwDrOo/3FDaYtM+1+phqSoXEXnECiei3vCtTnRI0cNcxgI0NeE7Z23ogTUouldJ3J+Ou3FRlhA37cLsvt6bpA0G0X5wrs6sJv+jpfyk8umh7iyCUQuCreVB5a7E0wkf2S/MDUBHqF13FGfAm4h5wHxp2jG8o/UxQCJV8OADIow62d3kAi9aPp2ReTGnM0P6hqPKy5Ll9TrqOoBQ+Y53uOQIjq1qn1gZ1GoSG0nl7Dkdf1qhhfFYb4w4xnXjR8PX2PmMGd0OVHc+Hkt X-OriginatorOrg: renesas.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 14 Sep 2026 20:16:02.5361 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 76f00bbc-a10f-432b-15d3-08df129cffcf X-MS-Exchange-CrossTenant-Id: 53d82571-da19-47e4-9cb4-625a166a4a2a X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=53d82571-da19-47e4-9cb4-625a166a4a2a;Ip=[8.62.32.50];Helo=[ejcrelay005p.adwin.renesas.com] X-MS-Exchange-CrossTenant-AuthSource: TYO1EPF00005022.JPNP286.PROD.OUTLOOK.COM X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: TYCPR01MB9450 Content-Type: text/plain; charset="utf-8" The MTU3 child devices use runtime PM, but the PM domain is attached to the parent MFD device rather than to the individual child devices, and the child devices open-code their own clock handling instead of using the PM domain logic. Enable runtime PM on the parent device so runtime PM usage by the child devices can propagate to the parent. Signed-off-by: Cosmin Tanislav --- drivers/mfd/rz-mtu3.c | 6 ++++++ 1 file changed, 6 insertions(+) diff --git a/drivers/mfd/rz-mtu3.c b/drivers/mfd/rz-mtu3.c index 88aa1fedf1ef..e24e67e7a66c 100644 --- a/drivers/mfd/rz-mtu3.c +++ b/drivers/mfd/rz-mtu3.c @@ -13,6 +13,7 @@ #include #include #include +#include #include #include =20 @@ -298,6 +299,7 @@ static int rz_mtu3_probe(struct platform_device *pdev) struct rz_mtu3 *ddata; struct reset_control *rstc; unsigned int i; + int ret; =20 ddata =3D devm_kzalloc(dev, sizeof(*ddata), GFP_KERNEL); if (!ddata) @@ -330,6 +332,10 @@ static int rz_mtu3_probe(struct platform_device *pdev) mutex_init(&ddata->channels[i].lock); } =20 + ret =3D devm_pm_runtime_enable(dev); + if (ret) + return ret; + return devm_mfd_add_devices(dev, 0, rz_mtu3_devs, ARRAY_SIZE(rz_mtu3_devs), NULL, 0, NULL); } --=20 2.55.0