From nobody Fri Sep 25 09:26:26 2026 Received: from mail-pz2-f12.google.com (mail-pz2-f12.google.com [74.125.228.12]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 2276A3D75C7 for ; Mon, 14 Sep 2026 14:14:47 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=74.125.228.12 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1789395289; cv=none; b=HX0d99GOq+UtsrxSSWkimcMH9NQBlDB10yghBw0N8xvAI4aTT8iy81AExcDv6DODeG03+uMnjx3mArrXW2K2wFaRnrqtykpiF//ojQCp6p1P+YtHiJr2fk5KsxALHFgktdAsha6ggMFvA7obXiP5JisBmN+UvZW//Az6M52C554= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1789395289; c=relaxed/simple; bh=EP3PPgE1+iPaVn/VB9tLZjMBu7ttoKeoWajGHIzWCWI=; h=From:To:Cc:Subject:Date:Message-ID:MIME-Version; b=itu6T9ODEDrHjDaq5NZ1iBC/azlM+fMBDMcvJXr44uVnwEJvknaGVYlntaZysgH3v8SbtW1OZs1OU9SGIuFL4BqvGgWhFWFywKAN3xv/Ms7T9nNRM4WCZ7u7WJ2aBvLCNNkf7QZYlM4qFR62MbxGQ1TcUypEkBD3Iahm+LVT8pw= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=qS0L+gm+; arc=none smtp.client-ip=74.125.228.12 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="qS0L+gm+" Received: by mail-pz2-f12.google.com with SMTP id 41be03b00d2f7-cc4c3304833so1536838a12.3 for ; Mon, 14 Sep 2026 07:14:47 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1789395287; x=1790000087; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to:content-type; bh=iowTzUN7eF2XmcFkQ3hjfDXclmIIX6foUfmhSB0uTUM=; b=qS0L+gm+B5k16XMJhWq/B9qpMgihVtGHokJs+iM53Dqnv1TQqlMVS2+3+VNvrC5F7a 9eEAlvxFBq8hdcg79t0Dm4A42FxWUAGAGXEsiFdfw4k9bXEGPdFspaaqrDRQ8I1DD1rz zyEuSSO6Q6ps7dR5DB5O1qXYV1a84ZIVgofq3/oqHIdlgVFAGtogiBI/filkfT7ncO9f QxQgGgCq14Wj0f1U+QDHk7Lp8Lj1pacn12JcbnIzKRk+dnUl77/yGak+rZpl1Un2u+co VKwoTkJQJXs+5UKbe2z9+VyxOt0aUSMvs5SMM06ocMs6ni5BniKh0ycRuIFmkJVo+U03 M7HA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1789395287; x=1790000087; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to:content-type; bh=iowTzUN7eF2XmcFkQ3hjfDXclmIIX6foUfmhSB0uTUM=; b=JmtApXV1jC/FYlXO04Ioreuo1vqcOLTTE6oGF8bLkPQXXs3wT10Z1lk7UrX0/GQJx7 cIzZF6Pyy88mWSQOBarsDQBkW5dM3YGPBmpZ8Ngj6IGhJwS0RD8V8mhrtJFoU2BrgJi5 /4RXDRz/aByxrGA/UWx4ahGPfWUxp3eJtrerTCSNPrF9w5/GKxcM7s8pt2J3VhFaETYR NcglnYwNow/HvNWAUazuYm1J3dVDVOBHt9oY8+I10RBNWfJFxHNEFjb9kNV/9vJF9+02 4xSg/+0TyXK0+1F/hE+fNIRhzMpuSjjDdtm3ANqQLxUKFENTTtZJRiPa9aZDy/buQSzh g02Q== X-Forwarded-Encrypted: i=1; AKwUvBzPL5a1H4eUsPAM3miCV3Qv0SBx14ryaBWmJpBsb7dQryqD97hD2DiCnYO7YLTe/ZnUHwfRvV2rQocc6k4=@vger.kernel.org X-Gm-Message-State: AFuF++n5FtAVHBi0fGJHRcsorMkJnxjg/M304MhGfZq5zaskbiGYvtxh +JBjj0Ha+oR1m/dMhjzKuZsct8htRkhu32OQrjxu3kPkxxRlzurrkhRY X-Gm-Gg: AYBFou2OkMEs/EvFA45oW9EMhG3QnTMJgdnjhAXQxOmALY/JakZ5NltCOarW/Y0E9Zv TZRi25XkWSFwNRSMHn5UjTv7qsw9ej49//TJH7CULaqq3g5k1q+GN2PL9FoUKv1mBmnuKlf4TeP yhu4ncFcPtmHNNJ0CNkjaupUGvuk7mofUmsryN3wnlBx7wv3V5jjKZn7uKa6V1lHHLFJ62MTAr0 XGihCsd9+NINFAkc2Hmh3PKlFNCd3JST1Ej5EbOcYSDUQoJy0FdF9MAoFiSpMUZq6dIk5oqtWRT eRYE5RpWF7OM/Nu5LeXMa2u5bxibAexAAO8tiA20r3uasi+SBa8KaN87XuoRiNiENLHB8/MRSOf wLi8XOYtpadTpkmDJrmu6tlxCJ83LAlzU16QwRkFQFyuSyOtgUsBIEWttjrk85an4VdS41/MCU3 TvQhRckakC8FkzVP2W3t93U9ccQo+A6CnnjU9Y07sE2OWwkDduLGstKA== X-Received: by 2002:a17:90b:2809:b0:39d:f2b0:5afd with SMTP id 98e67ed59e1d1-39df2b05b4emr3473390a91.2.1789395287409; Mon, 14 Sep 2026 07:14:47 -0700 (PDT) Received: from lgs.. ([2001:250:5800:1002::de93]) by smtp.gmail.com with ESMTPSA id 41be03b00d2f7-cc4c6549ec0sm5166288a12.15.2026.09.14.07.14.42 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 14 Sep 2026 07:14:46 -0700 (PDT) From: Guangshuo Li To: Shrikanth Hegde , Guangshuo Li , Thomas Gleixner , Frederic Weisbecker , Kees Cook , Benjamin Herrenschmidt , Paul Mackerras , linuxppc-dev@lists.ozlabs.org, linux-kernel@vger.kernel.org Cc: stable@vger.kernel.org Subject: [PATCH] macintosh: rack-meter: fix i2s device node reference leak Date: Mon, 14 Sep 2026 22:14:36 +0800 Message-ID: <20260914141436.1745138-1-lgs201920130244@gmail.com> X-Mailer: git-send-email 2.43.0 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" rackmeter_probe() obtains a reference to the i2s-a child node while iterating over the device tree children. Since the loop exits with break when the matching node is found, the reference to i2s remains held by the caller. The probe error paths correctly release both i2s and np, but the successful probe path only releases np. This leaks the i2s device node reference each time the driver is successfully bound. The i2s node is only needed during probe, including by rackmeter_setup_i2s(), and is not used after initialization has completed. Drop its reference before returning successfully from probe. This issue was found by manual code inspection. Fixes: 3e00a5aec3d6 ("[POWERPC] Xserve cpu-meter driver") Cc: stable@vger.kernel.org Signed-off-by: Guangshuo Li --- drivers/macintosh/rack-meter.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/macintosh/rack-meter.c b/drivers/macintosh/rack-meter.c index 26cb93191ede..c1c6d97d5013 100644 --- a/drivers/macintosh/rack-meter.c +++ b/drivers/macintosh/rack-meter.c @@ -496,6 +496,7 @@ static int rackmeter_probe(struct macio_dev* mdev, goto bail_stop_dma; } of_node_put(np); + of_node_put(i2s); return 0; =20 bail_stop_dma: --=20 2.43.0