From nobody Fri Sep 25 10:36:34 2026 Received: from mail-pg1-f171.google.com (mail-pg1-f171.google.com [209.85.215.171]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id AF1693D6CCF for ; Mon, 14 Sep 2026 07:29:02 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.215.171 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1789370944; cv=none; b=Jopam+6/afg7PWLonSHVcw+UjsBejNcWpbyNfR06aUk5/KkZLHcpA4wPPRV+RXvAyvCoMAlRxj/xsUevm68LFHAq8fs8rUTA2Hx66o/wmlDaxV8fJWn/XAVD/vz1VA4Vmp9tyBpF5E3v2SoxiZF01OxGJzKAem1nANFdjkzqkfA= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1789370944; c=relaxed/simple; bh=EVDRcKmTVQAmuHJWES9U2hQGWq/76vGUhS5zLMa3z4c=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=dnx3kzrtZcTjK5X6p0KRV69DEL8HqlgmEYvI/JfxuNr3FRdcSpC9+t2Wu8ANlj1n0tEdgJTmjZowtP1esxmNHKtv8yQIus9JL4VQwpXxffZFIPAPqpqGliGxNZvsan6Q5q2DENKUx6PKiXQWQduue0hmNRRPEMqLZKQjjl1Ulac= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=glkL16Fj; arc=none smtp.client-ip=209.85.215.171 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="glkL16Fj" Received: by mail-pg1-f171.google.com with SMTP id 41be03b00d2f7-cc4be0e5351so2020941a12.0 for ; Mon, 14 Sep 2026 00:29:02 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1789370942; x=1789975742; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to:content-type; bh=UiWyf1Dh9nthmX1SJ2zMjXD0YayBfWTFNKR/lg5M5tg=; b=glkL16Fjjl8jE8SF7ZjkTrR0qvvkyqAXJpJ3f/3UO5lBg+Bxlh0mW3Dqn3IFDMfBiA qdrR2AQjeltCxxeV85L7D5MK0bu8UNy3rohbr7puz/L9WkMrvheITj8LZafG2cIRn6Td wQWXcbsfszgVYAgoIKgFhwdl3snW9+dHk+hoS/ZCge0Qv9451DikfiKddZ/ueQQ+weJC CMSxKZzsWqw2oeflGbyLiVcIKpdQSPUHXPXp1VxxeVF/d3TsEzHiNywOrFQyQ3eeAxer DNppwrXcxfCTK5AgyDrTga99iWw+2WUU8bvFUHG6NwpAtmHnvab36TLVSnBYOM8p3dmV b0LQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1789370942; x=1789975742; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to:content-type; bh=UiWyf1Dh9nthmX1SJ2zMjXD0YayBfWTFNKR/lg5M5tg=; b=P+8bH+oVKCEYgCsvBJUmCln4rETP4sX6BVNwYcvC07zixxSpc7GFPL21a+kB82yTgt N4LTfzfR1dxKf/h766oTPDebJoStS6FngeBpq95vs7ag7fDSjNcrHWQ0FGkxbSA8+N09 f50xTXIhAou9E7t++M2xDzfubIWqXnMMBAv7651gtELv0OOGG+IOpP2cqk5/9DjPdpxJ fs2Zdkk9ntQK5HF8/HdpfYCH2EqAGZol8lc1W/1eP8ZTecNigAxAHNmjd4iPEyKSnTQA 71qCFP13ih9sGxQOBKI3QNyOrOLyxCwBgRyv1drAhbg/nQ3QJK+VobmubtdQA9dX0FMV ZjNA== X-Forwarded-Encrypted: i=1; AKwUvByeaoSr2JJ2B0/9hqdJkSXF8wSmbr0edW0Z6UK43TZKRjw1EYYIVkPrNSlR6fAehaQiyywbBbNoNdDFFms=@vger.kernel.org X-Gm-Message-State: AFuF++n7llg22i3eB+y3P7/npe4K09n6sCCv5ymxhduBGe11ITXlsj98 xAN0M6ItDqxTmIIwGxPC4KitfzQBVj8IIbtm7G2LX1q/8Q7qfUeaLsMR X-Gm-Gg: AYBFou3iKdFTiKr1UZB5kwaefOyTepQMWe49rroMNDMe4nKXLhvajF1PjwlE+qPnGWP HnMXugAHuSzi7eG7/DqqrxfaA2KLpt+NttpWyMf08kHm6n56i1m9o9DozasrVCWEKMcaTNbPk+K +86AdE+JWMHN6PKzZynXLHsJNrAJZkXs4la6COc9P/hwZ4KGNvNiDWeb8JnrABoF6JZkhP7RYos 6URIrOVD+OVhAZp85FH0yHoB/hHlBG9E3nMTsqPGDKye92dyj3yz4D+0IzswlMsgVPY0vsNCYK8 DiQaHsgQPh6GZi3oTCFpX9Z2RxjANnbqKkM0CIkM/UdiNz9OgQlo495m6OYkQdrN8ljjRBNg3rw yD+e0YYOVjYo/yGtgIkpTICHf4Ocm8rPh9QtNE7XUlemypv/lAIrZ35QL/EgYv7NcuQOui/hOQB ZaxYX2Je+/zsxBaIwngAt2xH9l0ChC47db/rcPmL8AIL7wJAyOk3Xft5zXNIxlYFnbfW+JJBlHm qDgzyRHKg12Q5uF0KaxC7LWjrnrApJK+/pCfUkZwltsr2tUToC6NsKVAuVKclxGQyvNCeBlsM9t plUH08aMV4Bmp+0EJr8FlbnAeA== X-Received: by 2002:a17:90b:582e:b0:38e:9ef9:eb97 with SMTP id 98e67ed59e1d1-39dec08daf1mr3030942a91.16.1789370941989; Mon, 14 Sep 2026 00:29:01 -0700 (PDT) Received: from phuc-desktop.. ([183.91.15.56]) by smtp.gmail.com with ESMTPSA id 98e67ed59e1d1-39d957131f9sm19598245a91.12.2026.09.14.00.28.58 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 14 Sep 2026 00:29:01 -0700 (PDT) From: phucduc.bui@gmail.com To: Mark Brown , AngeloGioacchino Del Regno Cc: Liam Girdwood , Matthias Brugger , Jaroslav Kysela , Takashi Iwai , Cezary Rojewski , Cyril Chao , Kuninori Morimoto , Dan Carpenter , cassiogabrielcontato@gmail.com, linux-sound@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-mediatek@lists.infradead.org, linux-kernel@vger.kernel.org, bui duc phuc Subject: [PATCH v2 01/13] ASoC: mediatek: mt8189: Return error for missing regmap Date: Mon, 14 Sep 2026 14:28:30 +0700 Message-ID: <20260914072842.24420-2-phucduc.bui@gmail.com> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20260914072842.24420-1-phucduc.bui@gmail.com> References: <20260914072842.24420-1-phucduc.bui@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" From: bui duc phuc mt8189_afe_enable_top_cg() currently returns success when the AFE regmap is unavailable. Return -EINVAL so callers can handle the error. Fixes: dc637ffeed6c ("ASoC: mediatek: mt8189: support audio clock control") Signed-off-by: bui duc phuc Reviewed-by: AngeloGioacchino Del Regno --- sound/soc/mediatek/mt8189/mt8189-afe-clk.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/sound/soc/mediatek/mt8189/mt8189-afe-clk.c b/sound/soc/mediate= k/mt8189/mt8189-afe-clk.c index fc7a7a73b0cf..63e03a40dbbe 100644 --- a/sound/soc/mediatek/mt8189/mt8189-afe-clk.c +++ b/sound/soc/mediatek/mt8189/mt8189-afe-clk.c @@ -236,7 +236,7 @@ static int mt8189_afe_enable_top_cg(struct mtk_base_afe= *afe, unsigned int cg_ty =20 if (!afe->regmap) { dev_err(afe->dev, "afe regmap is null !!!\n"); - return 0; + return -EINVAL; } =20 dev_dbg(afe->dev, "reg: 0x%x, mask: 0x%x, val: 0x%x\n", reg, mask, val); --=20 2.43.0 From nobody Fri Sep 25 10:36:34 2026 Received: from mail-pj2-f13.google.com (mail-pj2-f13.google.com [74.125.227.141]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 8AC153E3D80 for ; Mon, 14 Sep 2026 07:29:07 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=74.125.227.141 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1789370948; cv=none; b=jIbRD8fw9tCE2yXiY4e0XTTA3sG4V4s0KaLeK/gJ8XXqLSYIHEGO5vFFseq2U/Ou4PxuRpVavkpfhSsIx8RTrNvqbSqhcsz+XwuLzhq+yJprUKPX/woxumkuEvlFHruzYoTCf3tGw51FCHspUeF+5LYVOoFLzQnAQoH7qAT/OFA= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1789370948; c=relaxed/simple; bh=w3TSv8DyUDLvB/8NFHyYhUD593zzZ6iqidCdBEN1Ojc=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=HyZ8YrqYF5fWIHzJlxEBH/6ljVSfBEocQ86N0wFx9ImuzaKXFBtf+1K2gVAeTv4aNNJOdNCb6baj2wMM6pblqebH/WZO1YvkCRGyErPugJqoZEqyA8FnZVYsGs5dLfNNllImVWhRrIp5crBjALchHXyjWoAU6xTB+vpeKFC2wrI= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=mzqKtzEo; arc=none smtp.client-ip=74.125.227.141 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="mzqKtzEo" Received: by mail-pj2-f13.google.com with SMTP id 98e67ed59e1d1-396ccdaea76so686780a91.0 for ; Mon, 14 Sep 2026 00:29:07 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1789370947; x=1789975747; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to:content-type; bh=5ogPK4CkcC4kib57hvAPxClAgqXSK/aMlcwvCEMuXLo=; b=mzqKtzEoeZi8QdM+bQHEUA81EcbSuCyh+30tsMhywznsscfIojwqYRTmT9BN776MVk AnZiJKlYZrShU4VARRaZOcS2T7cK6FizsEvrPmOPNb595vM6IrzdD8qe1TzFN0bWe5xM KEcddX2gRFmpmKZbPkbSkO7booTds7vjyAya15GN5W3KxDTptDsnsRR6C86Ffe1p+7e6 JySWNZcqOl4864zGl651QhCkeNYf9ppzdf7INP1nIHiou+Os2RWltul8iE4LbNznNRDF Aqyd6gELZH0Ou5j25R23j6dz0k9rp4p7xSDT8Ata27Cf6zib9c8TYa84knnJactJETHv 0+8A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1789370947; x=1789975747; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to:content-type; bh=5ogPK4CkcC4kib57hvAPxClAgqXSK/aMlcwvCEMuXLo=; b=nR9JmgJIv46Lby6bHlCeqBEGkAsSof/HIDYZDwF3fHGygL0Wd//zpXk5cPttJVbsUH Bo71iEzXuZf3jwBudILXiKX6E7DKpi1smaq/yO42VotQHhHCrP5yNiDMhFwdUUYuGWTl rpf+oje/TYRtxvCBfEmEwrPocXpslft5YtafcqojPZvBsP/sePcViObL5sWeK2ibHRsR dPbK9NvMleuLpKzrkveBodwaEAjgb4IncbKM214J+1nrWKx+YM62FYxcP86NKQTjls6/ ic6mkvzi4eWwwWFdA85kJbUonMxTJ1UJ+XWaq0dn4fb4BV1kUHTV9liN8o4G5RpAICg4 teiA== X-Forwarded-Encrypted: i=1; AKwUvBzIUMoLW6nkg9nq427e4c4AxD+srlpGE5VSyCC3k8Sjfc2o0aPpvCQPLYygMwCVChz0qS4dmdkSpPJJL4g=@vger.kernel.org X-Gm-Message-State: AFuF++k2Ye7N+laH7jeEbg8FBePD83IbZ1Z0D7rsK53vTRWcJIyyIXRv qxusvk30QZWj+8II42XGFvhsFtfnQTjM1Ax4v2MGBKBiTq06sKERHW2J X-Gm-Gg: AYBFou2ki23AZIYhMsgx4VaK5O6Vfw7F0xKr8JIJskUNtr+G5OC44t6ayd898GLwAb2 VjXvXkmzreU/p2Z2TMj2G6QSDmFmMvX+7oqaIdMGuyfDrhxB8E/RihY0wgwGPHiIMxJutQHoH2l ewnucWsnjOoCJnuYIRNbdTJ24P8ssYqawU2a7B413kCxLfrWhg5M9AFBgffIVSIOeOE2vEuEkNJ FJJ8iFADi74Ir9zNoX8VUdzC8FRVz86fzZL/faNXrobAEorKsjIfLnvZvtyx0A5LBRAcaI2CVGc /2/u9PLGXRX10DAsPJbrtHtdp1m6sikEVIt/rEi4NPkSqufD+V0zlQZ1kjv3P7tXBXTJm+xBB3k EMkMtZG0NElxF9/eP8t4pjiEwPCDgfJ450VXEjw0TI+8Lfhyft+LNKcqJA3t2dcMAOH/oNwSOk3 pTWRPozAR++wDzBG63/axlvZJTLrEYO1SOi6ey5ldpi99D4kA2wlWNfKxq8iZLuRED7R/ro6MOR M5EjyiTTJkiBjNsMtQIqXxNgmp3ADZsDdBARxXFDhrmBok4HsU11ZAxXaGGACUPlmdXxijlyu4p 13z8FQNz8sCk9sOg X-Received: by 2002:a17:90b:1a8d:b0:390:84db:888e with SMTP id 98e67ed59e1d1-39dec3d0ddbmr1584578a91.7.1789370946743; Mon, 14 Sep 2026 00:29:06 -0700 (PDT) Received: from phuc-desktop.. ([183.91.15.56]) by smtp.gmail.com with ESMTPSA id 98e67ed59e1d1-39d957131f9sm19598245a91.12.2026.09.14.00.29.03 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 14 Sep 2026 00:29:06 -0700 (PDT) From: phucduc.bui@gmail.com To: Mark Brown , AngeloGioacchino Del Regno Cc: Liam Girdwood , Matthias Brugger , Jaroslav Kysela , Takashi Iwai , Cezary Rojewski , Cyril Chao , Kuninori Morimoto , Dan Carpenter , cassiogabrielcontato@gmail.com, linux-sound@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-mediatek@lists.infradead.org, linux-kernel@vger.kernel.org, bui duc phuc Subject: [PATCH v2 02/13] ASoC: mediatek: mt8189: Propagate APLL enable errors Date: Mon, 14 Sep 2026 14:28:31 +0700 Message-ID: <20260914072842.24420-3-phucduc.bui@gmail.com> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20260914072842.24420-1-phucduc.bui@gmail.com> References: <20260914072842.24420-1-phucduc.bui@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" From: bui duc phuc mt8189_apll1_enable() and mt8189_apll2_enable() currently ignore errors from regmap_update_bits() and do not clean up resources when clock enable operations fail. Propagate these errors and roll back the clocks and tuner state on errors. Fixes: dc637ffeed6c ("ASoC: mediatek: mt8189: support audio clock control") Signed-off-by: bui duc phuc --- Changes in v2: - Update the names of the goto labels. sound/soc/mediatek/mt8189/mt8189-afe-clk.c | 78 ++++++++++++++++------ 1 file changed, 56 insertions(+), 22 deletions(-) diff --git a/sound/soc/mediatek/mt8189/mt8189-afe-clk.c b/sound/soc/mediate= k/mt8189/mt8189-afe-clk.c index 63e03a40dbbe..aaf4f7921363 100644 --- a/sound/soc/mediatek/mt8189/mt8189-afe-clk.c +++ b/sound/soc/mediatek/mt8189/mt8189-afe-clk.c @@ -454,30 +454,47 @@ int mt8189_apll1_enable(struct mtk_base_afe *afe) =20 ret =3D mt8189_afe_enable_top_cg(afe, MT8189_CG_APLL1_CK); if (ret) - return ret; + goto err_clear_mux_setting; =20 ret =3D mt8189_afe_enable_top_cg(afe, MT8189_PDN_APLL_TUNER1); if (ret) - return ret; + goto err_disable_apll1_ck; =20 /* sel 44.1kHz:1, apll_div:7, upper bound:3 */ - regmap_update_bits(afe->regmap, AFE_APLL1_TUNER_CFG, - XTAL_EN_128FS_SEL_MASK_SFT | APLL_DIV_MASK_SFT | - UPPER_BOUND_MASK_SFT, - (0x1 << XTAL_EN_128FS_SEL_SFT) | (7 << APLL_DIV_SFT) | - (3 << UPPER_BOUND_SFT)); + ret =3D regmap_update_bits(afe->regmap, AFE_APLL1_TUNER_CFG, + XTAL_EN_128FS_SEL_MASK_SFT | APLL_DIV_MASK_SFT | + UPPER_BOUND_MASK_SFT, + (0x1 << XTAL_EN_128FS_SEL_SFT) | (7 << APLL_DIV_SFT) | + (3 << UPPER_BOUND_SFT)); + if (ret) + goto err_disable_apll_tuner1; =20 /* apll1 freq tuner enable */ - regmap_update_bits(afe->regmap, AFE_APLL1_TUNER_CFG, - FREQ_TUNER_EN_MASK_SFT, - 0x1 << FREQ_TUNER_EN_SFT); + ret =3D regmap_update_bits(afe->regmap, AFE_APLL1_TUNER_CFG, + FREQ_TUNER_EN_MASK_SFT, + 0x1 << FREQ_TUNER_EN_SFT); + if (ret) + goto err_disable_apll_tuner1; =20 /* audio apll1 on */ ret =3D mt8189_afe_enable_top_cg(afe, MT8189_AUDIO_APLL1_EN_ON); if (ret) - return ret; + goto err_clear_freq_tuner_en; =20 return 0; + +err_clear_freq_tuner_en: + regmap_update_bits(afe->regmap, AFE_APLL1_TUNER_CFG, + FREQ_TUNER_EN_MASK_SFT, + 0x0); +err_disable_apll_tuner1: + mt8189_afe_disable_top_cg(afe, MT8189_PDN_APLL_TUNER1); +err_disable_apll1_ck: + mt8189_afe_disable_top_cg(afe, MT8189_CG_APLL1_CK); +err_clear_mux_setting: + apll1_mux_setting(afe, false); + + return ret; } =20 void mt8189_apll1_disable(struct mtk_base_afe *afe) @@ -506,30 +523,47 @@ int mt8189_apll2_enable(struct mtk_base_afe *afe) =20 ret =3D mt8189_afe_enable_top_cg(afe, MT8189_CG_APLL2_CK); if (ret) - return ret; + goto err_clear_mux_setting; =20 ret =3D mt8189_afe_enable_top_cg(afe, MT8189_PDN_APLL_TUNER2); if (ret) - return ret; + goto err_disable_apll2_ck; =20 /* sel 48kHz: 2, apll_div: 7, upper bound: 3*/ - regmap_update_bits(afe->regmap, AFE_APLL2_TUNER_CFG, - XTAL_EN_128FS_SEL_MASK_SFT | APLL_DIV_MASK_SFT | - UPPER_BOUND_MASK_SFT, - (0x2 << XTAL_EN_128FS_SEL_SFT) | (7 << APLL_DIV_SFT) | - (3 << UPPER_BOUND_SFT)); + ret =3D regmap_update_bits(afe->regmap, AFE_APLL2_TUNER_CFG, + XTAL_EN_128FS_SEL_MASK_SFT | APLL_DIV_MASK_SFT | + UPPER_BOUND_MASK_SFT, + (0x2 << XTAL_EN_128FS_SEL_SFT) | (7 << APLL_DIV_SFT) | + (3 << UPPER_BOUND_SFT)); + if (ret) + goto err_disable_apll_tuner2; =20 /* apll2 freq tuner enable */ - regmap_update_bits(afe->regmap, AFE_APLL2_TUNER_CFG, - FREQ_TUNER_EN_MASK_SFT, - 0x1 << FREQ_TUNER_EN_SFT); + ret =3D regmap_update_bits(afe->regmap, AFE_APLL2_TUNER_CFG, + FREQ_TUNER_EN_MASK_SFT, + 0x1 << FREQ_TUNER_EN_SFT); + if (ret) + goto err_disable_apll_tuner2; =20 /* audio apll2 on */ ret =3D mt8189_afe_enable_top_cg(afe, MT8189_AUDIO_APLL2_EN_ON); if (ret) - return ret; + goto err_clear_freq_tuner_en; =20 return 0; + +err_clear_freq_tuner_en: + regmap_update_bits(afe->regmap, AFE_APLL2_TUNER_CFG, + FREQ_TUNER_EN_MASK_SFT, + 0x0); +err_disable_apll_tuner2: + mt8189_afe_disable_top_cg(afe, MT8189_PDN_APLL_TUNER2); +err_disable_apll2_ck: + mt8189_afe_disable_top_cg(afe, MT8189_CG_APLL2_CK); +err_clear_mux_setting: + apll2_mux_setting(afe, false); + + return ret; } =20 void mt8189_apll2_disable(struct mtk_base_afe *afe) --=20 2.43.0 From nobody Fri Sep 25 10:36:34 2026 Received: from mail-pj2-f12.google.com (mail-pj2-f12.google.com [74.125.227.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 3660D3AA500 for ; Mon, 14 Sep 2026 07:29:12 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=74.125.227.140 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1789370953; cv=none; b=qzrBAIbDUNE7LPiiPW/0fKYinAdQcf3n+bcdlJugerDikPh6O5Il45yOwz/1Hjw/Y3HeS8UwQxXygZXg5OZmLved20JM0oJ4x3OMHDUeY3W27X5VL7MerI51hHI2bV/VEs1qew0VyvgZFH0o0oTOlWfxARA8cr2xp66U2tC2E5E= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1789370953; c=relaxed/simple; bh=BAoT/932YSIrHskc09yxSfBLfT+jJ1FbZ080fdYmqB0=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=rH6GmlhshaTsaDTxWFT69l5Cb6I9ktd27ePdieQo2TA/riTZUaplWn6Wot3IteOxOq0hEiBA/4Fan4Dp5+YWkpmidVIH6Sra7A6tcoIrC5VfjYnZpACJIkNc9HwnxL89ewpMdXpSyLOeJhYoi5whh1lbE166iwd0tGXbPnWr0nM= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=llZ4h7dE; arc=none smtp.client-ip=74.125.227.140 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="llZ4h7dE" Received: by mail-pj2-f12.google.com with SMTP id 98e67ed59e1d1-39b2ad83dc6so1835196a91.0 for ; Mon, 14 Sep 2026 00:29:12 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1789370951; x=1789975751; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to:content-type; bh=DfKwZ+JcEx0QM0xlpom9cfu2SH2Yy+DujTq77/t9jZI=; b=llZ4h7dEYVZb0mjLVx1MV+rbxsryGMetvH6167nBqdYOrf1KdbiQapFNY8Z4IzpGsP BmC5rb5eElRXjdhRcLV6pbKce6wmUKzQ0SMb7fUKwLbMEnWnI9cQ7/rwXDoeZ5lor809 W1qeTQRFV6yt7n00dqDbMOfb/gt2FueEAO8yS9gTODNz6TfddGANxO0vWTb2jxKYSciD zS6u0Pu0ILn6AAju0/uXLY8MFkKrNgBxXhIIJO2zcA3Z8gBDKlVJbm2omVnZyj4sTZWk gmAGQ3UcouVuXnj779fNdeIc4o3zUGzmScTbVLzPjoUwa6+SKKZJs4lIREG8lpxGqili zWnQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1789370951; x=1789975751; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to:content-type; bh=DfKwZ+JcEx0QM0xlpom9cfu2SH2Yy+DujTq77/t9jZI=; b=H63PtnQL7VXwNYN7WRnY3o4bFW8+wuhL45Ny1drRQ/dqsmmuONibaz70nK3i4h07Lh S4g3jJfQE7ApGLy+yZU5IVBXHv8VqaIEN1hiLPHI+4cGnAZ5LrESy0oP1axDh/Wxk/Le 7KMvZbtFbdin+fN7PJlddV1Qi76x+tKVA976SY+fEKlCwACZKeR2aE0RQXpTKXxK7TRu CTtPNbJ4xn52dScNCp54QDZWnHwDV5lgkxtPUqU7NOIpe0xFsbA5lZY343YZU7dV+J9+ Spph4MgLBNBjAY/Oy6enJadot6uK6TRcWCy7lKMPHaQnKg3MifCkYfuSWNPrShLTybEe 0S2g== X-Forwarded-Encrypted: i=1; AKwUvBzLIEBCqDDxW8CM2F17YnzG3SwOKEykVmVMkDzrjwUlC3x+sgCJJOO/aA0kZKVCakBphYuBSymTHjg/6Kg=@vger.kernel.org X-Gm-Message-State: AFuF++kehrKFrdUYHRGIALLQdXuGptLpBqS+lt5imwXa72hNhfmJNdfd qrEvq65PlMfKLDa1wIlFZbjRZjJSIrsHFGWZxZnkSz1QaXf3xKwkVR4N X-Gm-Gg: AYBFou2WMkWYuYpHiaRpFFcy9NHs+tqVeY1T89y/eCrrmvdtRWb1kNaHpWZFl8sz/oI k9FJpnQp3n8Ivir7VT0wR3vdT8Fw7uqtozu92ptSuOXDMmap4C8NH0emri34ddJY2kIMVQsGrKy ksI4/nUuXPa/YGOcxzsKdHxGzYv+JfRsPUUKTPVmU4IlF0mqDoWserPxkQeMs3de1W23u9MRRJs XMfBvJPNxz/TGppcpHEDFd+12QNznodvXPv7uZLNX359c42pyeSX6/qwFeCzDjqjFr67G+wRy55 33W2yycbG8J8FxQ9GivUekFv27sNhmdApJ8TZs6vMScCvhUxq7OBUXZUSQHQyW7BydDWy+5jKJB KZNYBnWMHs2tDVlU5L4Or9IzeQxO4+ePiZNFoGAdSfgcIX4I0EaabuzKP9QssSUNZCfVTCHEiyy PjXG6bH46nYvGpskJP9XuOW+2zD/HOFUFzsMrD54um9HzwuD9N4Fo0WemMXAOCCZ04BPahtXRBO 4lRnBFLT0yBArR0HHFmFibYCCaLg3w8ZcFXogb2ynT4s71Q+f1WiPbUqlbQSbRMvagh8Y3yKV0J 4XWZPeqMHhuTWdo= X-Received: by 2002:a17:90a:e188:b0:398:b71e:60c1 with SMTP id 98e67ed59e1d1-39dec05885emr3025082a91.12.1789370951458; Mon, 14 Sep 2026 00:29:11 -0700 (PDT) Received: from phuc-desktop.. ([183.91.15.56]) by smtp.gmail.com with ESMTPSA id 98e67ed59e1d1-39d957131f9sm19598245a91.12.2026.09.14.00.29.07 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 14 Sep 2026 00:29:11 -0700 (PDT) From: phucduc.bui@gmail.com To: Mark Brown , AngeloGioacchino Del Regno Cc: Liam Girdwood , Matthias Brugger , Jaroslav Kysela , Takashi Iwai , Cezary Rojewski , Cyril Chao , Kuninori Morimoto , Dan Carpenter , cassiogabrielcontato@gmail.com, linux-sound@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-mediatek@lists.infradead.org, linux-kernel@vger.kernel.org, bui duc phuc Subject: [PATCH v2 03/13] ASoC: mediatek: mt8189: Propagate MCK enable errors Date: Mon, 14 Sep 2026 14:28:32 +0700 Message-ID: <20260914072842.24420-4-phucduc.bui@gmail.com> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20260914072842.24420-1-phucduc.bui@gmail.com> References: <20260914072842.24420-1-phucduc.bui@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" From: bui duc phuc mt8189_mck_enable() currently returns without restoring the clock state when setting the clock parent, enabling the divider, or setting the divider rate fails. Propagate the error and disable clocks enabled by the function. Fixes: dc637ffeed6c ("ASoC: mediatek: mt8189: support audio clock control") Signed-off-by: bui duc phuc --- Changes in v2: - Update the names of the goto labels. sound/soc/mediatek/mt8189/mt8189-afe-clk.c | 14 +++++++++++--- 1 file changed, 11 insertions(+), 3 deletions(-) diff --git a/sound/soc/mediatek/mt8189/mt8189-afe-clk.c b/sound/soc/mediate= k/mt8189/mt8189-afe-clk.c index aaf4f7921363..8f6241d47a65 100644 --- a/sound/soc/mediatek/mt8189/mt8189-afe-clk.c +++ b/sound/soc/mediatek/mt8189/mt8189-afe-clk.c @@ -639,7 +639,7 @@ int mt8189_mck_enable(struct mtk_base_afe *afe, int mck= _id, int rate) ret =3D mt8189_afe_set_clk_parent(afe, afe_priv->clk[m_sel_id], afe_priv->clk[apll_clk_id]); if (ret) - return ret; + goto err_disable_m_sel_clk; } =20 /* enable div, set rate */ @@ -650,13 +650,21 @@ int mt8189_mck_enable(struct mtk_base_afe *afe, int m= ck_id, int rate) =20 ret =3D mt8189_afe_enable_clk(afe, afe_priv->clk[div_clk_id]); if (ret) - return ret; + goto err_disable_m_sel_clk; =20 ret =3D mt8189_afe_set_clk_rate(afe, afe_priv->clk[div_clk_id], rate); if (ret) - return ret; + goto err_disable_div_clk; =20 return 0; + +err_disable_div_clk: + mt8189_afe_disable_clk(afe, afe_priv->clk[div_clk_id]); +err_disable_m_sel_clk: + if (m_sel_id >=3D 0) + mt8189_afe_disable_clk(afe, afe_priv->clk[m_sel_id]); + + return ret; } =20 int mt8189_mck_disable(struct mtk_base_afe *afe, int mck_id) --=20 2.43.0 From nobody Fri Sep 25 10:36:34 2026 Received: from mail-pj2-f13.google.com (mail-pj2-f13.google.com [74.125.227.141]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 8EEEE3E5A30 for ; Mon, 14 Sep 2026 07:29:16 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=74.125.227.141 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1789370958; cv=none; b=E9mWJRQCuc5u5SELzyFJimay9MlDPgE2KU3E/Un95THmLRb9p1J7rOmQS4RknH7Sv6I3MzBoVVDygASpDAAneoVqpUMdZbW+9w6rikubKh5GyuIrmudCYX9FHRWaynLObkErtugRm5fGXdWo2XSSlFX7MXLHSloPxT8IWkoLguc= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1789370958; c=relaxed/simple; bh=PMrTYt044OfF3pY6fLcQIplcKVJDKCIn9Rne/SIU1Eo=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=NRgQnKPmXqQY7ZcC40wL7P9ldDp5ZaEfJQKnaZPFMiXO0kOvTKYhZbv0eHxAVAId/EFgxv+f/qrWpWC/N/FU+6NXRn0HWy61YRw/FbueisTJgaJBY1eodTSvR6icxF8zGdkh/boiqAXR4Q0EFCVPmwnZ2kpMK1d97oowmRNkBAI= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=OhtvZ6cA; arc=none smtp.client-ip=74.125.227.141 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="OhtvZ6cA" Received: by mail-pj2-f13.google.com with SMTP id 98e67ed59e1d1-396ccda24afso1220250a91.3 for ; Mon, 14 Sep 2026 00:29:16 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1789370956; x=1789975756; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to:content-type; bh=GJYLAFpdT1QOF/hJAkr/62fvY6NkBt3I3B5rin4YsLo=; b=OhtvZ6cA8HlICKsueQfBz4aS1QtNwnuts55w3r3k58B62OpOGmeOPnflTogoVI5MDU YxdLBEay8qJtNStBhHRaYREZgY92TGnZDI2/lz6J81LHEFpqVYJCa5wcsaMEzL1sQX4R lYwisNCQxCmmAyoE1NqnGJk33lcDOSjkfzl3WlJNKrw/OX6skKEfImLAJeiEnuDAqvrd FKZk66LMBC+nKg8A2EFRvMm8GdrCrwdI7S03e7WzyK8fWjTt9T/D1VbNs5EY2Q3prHvX geAGy2bKxkLz0gK4A304fnrdhUawdUV6asgTfQTzc76jiBBAtX9Ih+HLyNa3a5Sq1pKB bohQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1789370956; x=1789975756; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to:content-type; bh=GJYLAFpdT1QOF/hJAkr/62fvY6NkBt3I3B5rin4YsLo=; b=rhgKRMuWtWkUygrRxa159Wc1QMmDGgHESTLB5sJbRvXYB5O0hcpAeF9CubfbjQGYCt cOGYhAJqqau2Dxjp0fTouseRxXl44qgwsZ6ARWD1FqE4hxT75VyxLD5aMALRfa7Rb/ky 350x4/ms6bvx308jDMbbHKeRbbQGIU2xj4IP+NVGIuVHW0PhIUhqqvjhSZRLiOP33eSd qIPt8OOeY4+OoRcRNh0ntEc3+vDo02T6c7p0THorJ2sCWih8mBEJScdpru0T7C7Zk29s ly0PtAQEVJTKdCV3gW89mHKXGZTTTH8m5blBqpWxAWGseW147KcyPvOzs7830HHJM6aD zw1Q== X-Forwarded-Encrypted: i=1; AKwUvBxIMw5HuCq36cmbfuiaGhHtsX0p8OCRrFAWqUiSlBr0uLfveWB3D2FrbyBmOGxiONto8KF1L2Lj2rwSrb8=@vger.kernel.org X-Gm-Message-State: AFuF++nCyvZuR+r1ZT6iORsEFnMest7maaasldITf2nx/G9dDiY7Sw/8 clVVPB3Wngtmw+R+cam+SXQ+F2oSfH0rEobmG+WmQud33MKvOE6rQFik X-Gm-Gg: AYBFou3M6+zBRKaOwOa6b1miRXaoREayDqqwbtkGik7WZ7/+YdmVESXh9e92tEXCu6q uj9Sy74XnREfPicN2MGRUolicJtya+MWfXrNgsUXmFE9wVP+FuGtEosqxceO6A7sx4nWNSUzpDm /t6aSF2xmO2K9Esa0OKlurjl7b1xopWGn3Mbj0yQY+r4I8RtqzMCiM/5xq193oCp3O9IyRln+/G W9kTGWSREKtT5mQLzOz7ZhmN5pPGP3PfHammCJcXISjb0/Zx3TyJ1iNou1po3UuJT83liMQn2yz OAO3mZVIyzoDhfYGzwNuAU/doleBTT3+j0oRqVekyu4gdbFY3B6cJyuBqwAf55ut8DvFBSbd8tt 5+aiVP7xo8IRe2zEgz2B/5ipU+NZkkPT8A85KyTYejVtGIJ6/Ppi54ipY2DcSUE/93M8txFbkoz ynY1N09lwoZ2R9WEDttdyOhXNXFtOMyidsmkNIdhAbpO8VAis+bXBmHHs9VhY7S8zk1GrPu2x6f J8pvbEVMjdIxBcqOYLxpVNBSeSdeOOGlM3oamPUVNBLNCRkktH1ul/3tDkqWfHQyLqp+INvbXJC fykpARKVuk7TJDA= X-Received: by 2002:a17:90b:2885:b0:398:b46d:48c0 with SMTP id 98e67ed59e1d1-39dec0849e5mr3489837a91.18.1789370955702; Mon, 14 Sep 2026 00:29:15 -0700 (PDT) Received: from phuc-desktop.. ([183.91.15.56]) by smtp.gmail.com with ESMTPSA id 98e67ed59e1d1-39d957131f9sm19598245a91.12.2026.09.14.00.29.12 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 14 Sep 2026 00:29:15 -0700 (PDT) From: phucduc.bui@gmail.com To: Mark Brown , AngeloGioacchino Del Regno Cc: Liam Girdwood , Matthias Brugger , Jaroslav Kysela , Takashi Iwai , Cezary Rojewski , Cyril Chao , Kuninori Morimoto , Dan Carpenter , cassiogabrielcontato@gmail.com, linux-sound@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-mediatek@lists.infradead.org, linux-kernel@vger.kernel.org, bui duc phuc Subject: [PATCH v2 04/13] ASoC: mediatek: mt8189: Validate MCK ID Date: Mon, 14 Sep 2026 14:28:33 +0700 Message-ID: <20260914072842.24420-5-phucduc.bui@gmail.com> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20260914072842.24420-1-phucduc.bui@gmail.com> References: <20260914072842.24420-1-phucduc.bui@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" From: bui duc phuc mt8189_mck_disable() only checks for negative MCK IDs. Reject IDs outside the valid MCK range as well. Fixes: dc637ffeed6c ("ASoC: mediatek: mt8189: support audio clock control") Signed-off-by: bui duc phuc Reviewed-by: AngeloGioacchino Del Regno --- sound/soc/mediatek/mt8189/mt8189-afe-clk.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/sound/soc/mediatek/mt8189/mt8189-afe-clk.c b/sound/soc/mediate= k/mt8189/mt8189-afe-clk.c index 8f6241d47a65..69aa3715c19e 100644 --- a/sound/soc/mediatek/mt8189/mt8189-afe-clk.c +++ b/sound/soc/mediatek/mt8189/mt8189-afe-clk.c @@ -675,8 +675,8 @@ int mt8189_mck_disable(struct mtk_base_afe *afe, int mc= k_id) =20 dev_dbg(afe->dev, "mck_id: %d.\n", mck_id); =20 - if (mck_id < 0) { - dev_err(afe->dev, "mck_id =3D %d < 0\n", mck_id); + if (mck_id >=3D MT8189_MCK_NUM || mck_id < 0) { + dev_err(afe->dev, "mck_id =3D %d\n", mck_id); return -EINVAL; } =20 --=20 2.43.0 From nobody Fri Sep 25 10:36:34 2026 Received: from mail-pj1-f51.google.com (mail-pj1-f51.google.com [209.85.216.51]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 6E2EF3DB335 for ; Mon, 14 Sep 2026 07:29:20 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.216.51 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1789370961; cv=none; b=N3nzf71mQHp979IZ4EpLkiacbsEGoh6gQXR+YuoXJPaU7QCGcZl0GtXtQAI9a79PER5XpmLfiSZ9AVnjBVHeja6X/Wll38rFLX5sQvpb+NQ+pKPQaCqr2fs7O/6/aTcBGSOafXUlRFmoKs3wIQrE5WOPUii0uEKINvVlWN3Aucw= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1789370961; c=relaxed/simple; bh=cIca475pFe2f5ZYvVKkisqa4yG3Dl/6iz7rvR/7MMYs=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=bh1FQ+Osk37YtcpOmSVlIedVDy6kfpvR4yBSMu76TOzjgIOVr2sRNsKLzcXxEEGjm4vXLY7nX8//4SAHqESBo2XaoVK2New3Dn65DL5NHbDyezjGjHg6XeUwrKe4gURgVUEUM3DsfT7nXbcl1Pp0XF6+/DYt2ndzqen1he8q4Rs= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=gWfWKVcv; arc=none smtp.client-ip=209.85.216.51 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="gWfWKVcv" Received: by mail-pj1-f51.google.com with SMTP id 98e67ed59e1d1-3964e480f76so4090667a91.1 for ; Mon, 14 Sep 2026 00:29:20 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1789370960; x=1789975760; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to:content-type; bh=B5j422sp7IgKzOpG0gt3MXA3l3kQYxqi7If+zAVtiI8=; b=gWfWKVcv1pRJFAtYkpiZiPR/A2g2knn9gzHPHFp1P1u1we10zuY9RnELEcXvAbH1aE 2eAue8QPtXACxmA5f2NV4vWWE+k6zAQPb0i1qv8Tp7cuIDG46/aYjQxbxu6Io1Ovu8mc 2IfvUc5UhK8YpKw0tmVpTV5kCNKGPUpfZtdy0HxChiuU0e66NkeM8JizfrP9SQPpB0Oh mBzVSXQ4+qIRR7a7ghfrHzcAFy+o57Ukd8jilWv9meJSKpRu8jeQ3eiOzVJOca8hnO1d dfYDmyD6NSeNrAljs/v6/p2bQv4ytD/StfW/NbPqRSzCUP9Uw4Us5XhbKWiCuzqMH9u7 qCxA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1789370960; x=1789975760; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to:content-type; bh=B5j422sp7IgKzOpG0gt3MXA3l3kQYxqi7If+zAVtiI8=; b=XB/WwvkTxImt1sEoeeHbdAKQaP31XaK/ZpC9Jgfi1qcywGez2LQislkhvTQ8NMu142 moZmwEAd/yqHj0DHt9AI/tiAo7K77Fzhr0DVHRRemROwyKnDZE7MlFkB3C4WylASLTm3 tlXWqhCk7dpsBRInWpGxSZfXF22LKRMnh8PbdzVbQTZT8RHCLwDo3N76hCaXgcJWb+8d aT/CIt5+YFThkpIfn83nxabDUvX/4qxg2d+7HTPDXigRgIPVpKlo7zAPeJIZKb9XRCzh 8+S5JPgyXJGXycbGuuMUoaX1HZJwjHZjYeT9halNAJWa7sx/shRMxxypjiZX1J9iFdH7 HWsg== X-Forwarded-Encrypted: i=1; AKwUvBznYZD91WWQrxsBLg2Cwr3sNgkV2Ns1JKPNz99dzs46QFT3EESejeaDgpGlG3P+ViVn16CZLjVsgCX5cUw=@vger.kernel.org X-Gm-Message-State: AFuF++nT12NIYwujxnH/ZQi92bmN46znarjnJlfhSnf5dXfUe+rbP0BP xD1zI3XBDerw1gT+A6K4HQ5DIkGkALJ60WWdRhIFivFqGP0Fl4xRdUD4 X-Gm-Gg: AYBFou37hojuUdz6YIDQYcJOZMyyCpS7FGwDHe4WrWnwhrC0S73aAWWiVSQO44Y6XMQ 0F8hmLSqhTwGrQurHmUtcmAForVoMyk1cqztJrrAMLtkmxksx9vWSsjojvCwMXoV8auSRZRfodh WSMjeVKcNI8YN2+xfhbeHAHAdzpVxurXJI/03h0BsCavAGwycvC8bTR4GWMuElP+pkyFSr2bqFn c99m4jbeDPuE4NUUlgdkVKeMrc4/yGLYco5hJgTHw+Pm8/cMFOImUpC3wI8TLf/ZN3vEwRUb3uB pxzqSvNRo4Lk9WDmEPX3hFihiMoH0kt5+q/yHecZ9n33iYjnXfwhtLYrxGfxYKZXEb4PiGs7aOc 07uyNQU4XsC9JJp6gVSzTPMRVZ5zCeRzRrTSc5NRQFJu3b5Sc23hfm0dyEx3yOnSjqrMiYxOdsH EW5EUXnGep1BYb9yWiTzRnY/vU/h+ifxdt3Uqdh6RauRuw2/6bXgRaWVCf+0NpxPHThKKMFF8SI w3ChSdp1y/8LoAEZjaz+K5wsEz/VSXUKqDKqmoBpr5w7UDKZKisEgnumg4D8w2okhDKDzG6hLOZ 3oWuIKk4ccGbgys= X-Received: by 2002:a17:90b:4984:b0:39d:f61d:7ca6 with SMTP id 98e67ed59e1d1-39df61d7d1bmr9021a91.15.1789370959820; Mon, 14 Sep 2026 00:29:19 -0700 (PDT) Received: from phuc-desktop.. ([183.91.15.56]) by smtp.gmail.com with ESMTPSA id 98e67ed59e1d1-39d957131f9sm19598245a91.12.2026.09.14.00.29.16 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 14 Sep 2026 00:29:19 -0700 (PDT) From: phucduc.bui@gmail.com To: Mark Brown , AngeloGioacchino Del Regno Cc: Liam Girdwood , Matthias Brugger , Jaroslav Kysela , Takashi Iwai , Cezary Rojewski , Cyril Chao , Kuninori Morimoto , Dan Carpenter , cassiogabrielcontato@gmail.com, linux-sound@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-mediatek@lists.infradead.org, linux-kernel@vger.kernel.org, bui duc phuc Subject: [PATCH v2 05/13] ASoC: mediatek: mt8189: Propagate reg_rw clock errors Date: Mon, 14 Sep 2026 14:28:34 +0700 Message-ID: <20260914072842.24420-6-phucduc.bui@gmail.com> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20260914072842.24420-1-phucduc.bui@gmail.com> References: <20260914072842.24420-1-phucduc.bui@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" From: bui duc phuc mt8189_afe_enable_reg_rw_clk() currently ignores errors from clock enable and parent operations. Propagate these errors and clean up the clocks before returning the error. Fixes: dc637ffeed6c ("ASoC: mediatek: mt8189: support audio clock control") Signed-off-by: bui duc phuc --- Changes in v2: - Update the names of the goto labels. sound/soc/mediatek/mt8189/mt8189-afe-clk.c | 31 +++++++++++++++++----- 1 file changed, 25 insertions(+), 6 deletions(-) diff --git a/sound/soc/mediatek/mt8189/mt8189-afe-clk.c b/sound/soc/mediate= k/mt8189/mt8189-afe-clk.c index 69aa3715c19e..173ee0709b16 100644 --- a/sound/soc/mediatek/mt8189/mt8189-afe-clk.c +++ b/sound/soc/mediatek/mt8189/mt8189-afe-clk.c @@ -700,17 +700,36 @@ int mt8189_mck_disable(struct mtk_base_afe *afe, int = mck_id) int mt8189_afe_enable_reg_rw_clk(struct mtk_base_afe *afe) { struct mt8189_afe_private *afe_priv =3D afe->platform_priv; + int ret; =20 /* bus clock for AFE internal access, like AFE SRAM */ - mt8189_afe_enable_clk(afe, afe_priv->clk[MT8189_CLK_TOP_MUX_AUDIOINTBUS]); - mt8189_afe_set_clk_parent(afe, afe_priv->clk[MT8189_CLK_TOP_MUX_AUDIOINTB= US], - afe_priv->clk[MT8189_CLK_TOP_CLK26M]); + ret =3D mt8189_afe_enable_clk(afe, afe_priv->clk[MT8189_CLK_TOP_MUX_AUDIO= INTBUS]); + if (ret) + return ret; + + ret =3D mt8189_afe_set_clk_parent(afe, afe_priv->clk[MT8189_CLK_TOP_MUX_A= UDIOINTBUS], + afe_priv->clk[MT8189_CLK_TOP_CLK26M]); + if (ret) + goto err_disable_audiointbus_clk; + /* enable audio clock source */ - mt8189_afe_enable_clk(afe, afe_priv->clk[MT8189_CLK_TOP_MUX_AUDIO_H]); - mt8189_afe_set_clk_parent(afe, afe_priv->clk[MT8189_CLK_TOP_MUX_AUDIO_H], - afe_priv->clk[MT8189_CLK_TOP_CLK26M]); + ret =3D mt8189_afe_enable_clk(afe, afe_priv->clk[MT8189_CLK_TOP_MUX_AUDIO= _H]); + if (ret) + goto err_disable_audiointbus_clk; + + ret =3D mt8189_afe_set_clk_parent(afe, afe_priv->clk[MT8189_CLK_TOP_MUX_A= UDIO_H], + afe_priv->clk[MT8189_CLK_TOP_CLK26M]); + if (ret) + goto err_disable_audio_h_clk; =20 return 0; + +err_disable_audio_h_clk: + mt8189_afe_disable_clk(afe, afe_priv->clk[MT8189_CLK_TOP_MUX_AUDIO_H]); +err_disable_audiointbus_clk: + mt8189_afe_disable_clk(afe, afe_priv->clk[MT8189_CLK_TOP_MUX_AUDIOINTBUS]= ); + + return ret; } =20 int mt8189_afe_disable_reg_rw_clk(struct mtk_base_afe *afe) --=20 2.43.0 From nobody Fri Sep 25 10:36:34 2026 Received: from mail-pj2-f13.google.com (mail-pj2-f13.google.com [74.125.227.141]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 85BFF3E6DF5 for ; Mon, 14 Sep 2026 07:29:24 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=74.125.227.141 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1789370966; cv=none; b=lisddAdLlh0DB/SEL+qsbJY3vpIrLVydMmTnSEuIcIXZzD3L7CFOi+3cBq4zTfIf20o6bQ5bOg/pWJwfyzmLn/Y8kexENXIpn/mr9bT4/ff6276tO8+RcLFoEkPXjWQ7Yrd30ohqguaI8YZrS+ZCnRGoYhqLJtRCDeY/A/ubdNA= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1789370966; c=relaxed/simple; bh=9pAmcknMocG7ZfJT4xEzcIhxbh9fPeGRfGyQnurOpFw=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=HpNJThCdI8lRkTA3x3yudTxDVsaE+EPMIWJLwkhG6WrJzQDMJIv46Gvf6+kDaNNrRiwcGNXp0scXyhPWjgN9tEeiT/i9UanGbA/qh54Nfs3NeT8s4ijgpw2JX0yg2GPwXJmeeMSLrLr2EVK6zwpyhaOxqEw1Q3WeThs/wA/qH3M= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=XVGVuakI; arc=none smtp.client-ip=74.125.227.141 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="XVGVuakI" Received: by mail-pj2-f13.google.com with SMTP id 98e67ed59e1d1-396ccda24afso1220339a91.3 for ; Mon, 14 Sep 2026 00:29:24 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1789370964; x=1789975764; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to:content-type; bh=uwh/9qTX2B9aSYEX0nJr57XNF2YmYT2AWRYwuXSA6iw=; b=XVGVuakIWIqbnkZ9zw4nZolswlM6LLELQIAVeBajv5o/PvN9kDQ2m61or3MtFDfsw/ n1KEVzwdD56ouX1Sc/j+91kJqoybAqeksMFddrNO8r/E67XmPnHMShNyNl1CxccLqWsl jdWHSnClbJ/qDEIs6ljAHUyi7HcvMJjv5k2tHkbXesgBGPQoTgVT9l98wlJHEwQXzx+t hv74u5VBM39DWXSOhDTWibPppjhYtwnvni3C/fOwk95GOL690kRCOQIDY+rGp+L/3623 C2qq79A1xFaxXMXPFqG6h6v8g23ztyScP0fBLHh337zqYx8TkJFDnbElG2Wak5dmIOod XV6A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1789370964; x=1789975764; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to:content-type; bh=uwh/9qTX2B9aSYEX0nJr57XNF2YmYT2AWRYwuXSA6iw=; b=jvQh7EkQ6zgECbxpi470CvcRA3rr4rWniZlCQZwj3UAn3gIj2BFVfJVDgRzjok+x+J pobkJ7w1sSAghr2EeN+py9VynyUs9RYuoEBeZbkfpfsyjEZWsbmJRr0TFJD9ulpy62j8 vv4n4EPlwFmk6vbfl4G/3+l3CHqSyPK43vOgjQz2f1C7IfwVZeUBtPG8wtb9+TkuybCD 1kuAglfIqzjiStmUr2xIBGxI4NvqLYKHc1Ie7XCFTv++XOWB3BfpSCVshPOy4HnxPxKo x9R2HvJki/PYET4mx/zANeck5ZsS1XBynu4rFnmuxhZDSBrN2qk4+npPq3kI7QVs9OIp GEKg== X-Forwarded-Encrypted: i=1; AKwUvBw8PcYQl6slrfxBp/d1iOVSBrRyrWrkV4Lpdj8Pe9fR8VLXGlZ/Lbm2smHGm8nGAO8CmPwPtgxXgp4nxw4=@vger.kernel.org X-Gm-Message-State: AFuF++lTVnfET3Z3B8/QhgrVAcxCojrQQEQk747ixKLb2LbMeHV2BJml UVIgTn6ZV7tBm7qlqocFJCmt+HdFyjOYGbqJ7VlQ3OiJ8HpvSrMom7yW X-Gm-Gg: AYBFou3ONP1PmOHr5R2LdYN7VxsmVoRpNpb0DSHpx/KmP5DYAiSCckivKjmJrZ5ot40 EjQBvj5+bufkLNGeo3mc0JziyXRdvMIi+OMwFfjBStUUrSPZnaRl/0NwRrahVg3CpYRhqCdz8di iM/NOsn4MdOgo5+H5EP7kzjfcbIoWY+omU3LYdOTjXS0XoQO/FkfUjA7kY/fOHDRqjkzEQ+iFSM Bz+I2d0IkUyILrYAR6VrwxRsWMXJ0BfK+IISi97auPyAD+DOurdMy8771/XzCuRMD+YokMD72d1 vHOnn5WfVFblc63jHAApmc0PZyYfvIWLdiecIkOlB2/uCPhCO5nAch+qhu98Lp3CwNei0LoQkqh yQtDlvEEI/mElWcsqa10eHaGxGIBEFkjNOejX7amAJFehEjerBiNXGwW1vA/87TE0D0OubQ3ywO IrkHf1+K3uRacahRGTUE7Wo7yWbkq8yVRRrjV0T8SPR7vtFOlcoDFu1l5RC9RMSiVO+PwXxtk1N 04zrp/IPrfXMZB1r3EgRe28n4mBdX/rcwq3YqFP5jlJFiaF5n4yI4SlTp6lIPPc4iqjuKEMqleu cv0bEpgPCxmWaM0= X-Received: by 2002:a17:90b:2789:b0:39d:f2a1:2a with SMTP id 98e67ed59e1d1-39df2a103d6mr728290a91.19.1789370963956; Mon, 14 Sep 2026 00:29:23 -0700 (PDT) Received: from phuc-desktop.. ([183.91.15.56]) by smtp.gmail.com with ESMTPSA id 98e67ed59e1d1-39d957131f9sm19598245a91.12.2026.09.14.00.29.20 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 14 Sep 2026 00:29:23 -0700 (PDT) From: phucduc.bui@gmail.com To: Mark Brown , AngeloGioacchino Del Regno Cc: Liam Girdwood , Matthias Brugger , Jaroslav Kysela , Takashi Iwai , Cezary Rojewski , Cyril Chao , Kuninori Morimoto , Dan Carpenter , cassiogabrielcontato@gmail.com, linux-sound@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-mediatek@lists.infradead.org, linux-kernel@vger.kernel.org, bui duc phuc Subject: [PATCH v2 06/13] ASoC: mediatek: mt8189: Use dev_err_probe() for clock errors Date: Mon, 14 Sep 2026 14:28:35 +0700 Message-ID: <20260914072842.24420-7-phucduc.bui@gmail.com> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20260914072842.24420-1-phucduc.bui@gmail.com> References: <20260914072842.24420-1-phucduc.bui@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" From: bui duc phuc Use dev_err_probe() when obtaining clocks to avoid redundant error messages, particularly for probe deferral. Signed-off-by: bui duc phuc Reviewed-by: AngeloGioacchino Del Regno --- sound/soc/mediatek/mt8189/mt8189-afe-clk.c | 7 +++---- 1 file changed, 3 insertions(+), 4 deletions(-) diff --git a/sound/soc/mediatek/mt8189/mt8189-afe-clk.c b/sound/soc/mediate= k/mt8189/mt8189-afe-clk.c index 173ee0709b16..3e7465c5b277 100644 --- a/sound/soc/mediatek/mt8189/mt8189-afe-clk.c +++ b/sound/soc/mediatek/mt8189/mt8189-afe-clk.c @@ -793,10 +793,9 @@ int mt8189_init_clock(struct mtk_base_afe *afe) =20 for (i =3D 0; i < MT8189_CLK_NUM; i++) { afe_priv->clk[i] =3D devm_clk_get(afe->dev, aud_clks[i]); - if (IS_ERR(afe_priv->clk[i])) { - dev_err(afe->dev, "devm_clk_get %s fail\n", aud_clks[i]); - return PTR_ERR(afe_priv->clk[i]); - } + if (IS_ERR(afe_priv->clk[i])) + return dev_err_probe(afe->dev, PTR_ERR(afe_priv->clk[i]), + "failed to get clock %s\n", aud_clks[i]); } =20 ret =3D mt8189_afe_disable_apll(afe); --=20 2.43.0 From nobody Fri Sep 25 10:36:34 2026 Received: from mail-pl1-f182.google.com (mail-pl1-f182.google.com [209.85.214.182]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id C6F9C3E7BB0 for ; Mon, 14 Sep 2026 07:29:28 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.214.182 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1789370970; cv=none; b=CQ817B+SxIcbpZ/kz6lKijCJijfMtzdE2oBLg3V5kEVw8+fUPMh4djGRn8q/10eea1D+rxsw4+TU3E/34qBLJfp4vyeuytNFDTj2GkVBJ8vtVYy+ZpwwtngPk2cOQMIM5tlxVbPkijnLRqkAx+iz0XKQ/79iHxDT9U6EPh6romg= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1789370970; c=relaxed/simple; bh=XdoVnpTfZ+t+DnQW8QFaf+eY9aunqbEVCAkCrXvXkyM=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=EElahu0lVi/M+dX1T6Y0i/K0aq1xW4lSE9Ml8dGFgxd4Drv1x9N6fVrVT3Y+FXU/AJ/d8XGvm+boY/m0Y7/y9HU5NcEVYvyI6cmXQruxL3pseWFjznGzt+yDc8MndrFRgPNoHSegFQmz9CVUI1+y0dg5zQi2xYJ9JKTnq0Lj7cQ= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=fam3d2qp; arc=none smtp.client-ip=209.85.214.182 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="fam3d2qp" Received: by mail-pl1-f182.google.com with SMTP id d9443c01a7336-2dd020a2e44so26861755ad.1 for ; Mon, 14 Sep 2026 00:29:28 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1789370968; x=1789975768; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to:content-type; bh=vZhy1gvzxv4nnqK22Id8tWzLP/pMb4kmGE3X33hanlU=; b=fam3d2qpLxSnjJqE5X47XnnY3H81BhxacDz6g0sR8wMsGVc4y3XH4hjnIqZ0VpqWFm UG/DwogMvVhoUvNtC79dhodkhhSEyvFKVEb/ipv3rLMSeW2KZXnq7vgcKMW9qaprc+ln NpM8hFqLS3xxtUVeVU2oTICZ7YTpgxuJVygGGrw2k/2KydqUnnM1p1TuNFFf2DW1sUQj XqbfxiI3+fFScgt1I3I8U7vZujB4+/GpGVsxRua8YU/Ic/A2nSQjrdMnIqHsqiR4GFBS wnfONIp7JW4NedvmAdVnHhkRTHD3uKmLd1kJN84NcRxC9p4pkpvTyfxdfcbean2rcVg3 Yxyg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1789370968; x=1789975768; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to:content-type; bh=vZhy1gvzxv4nnqK22Id8tWzLP/pMb4kmGE3X33hanlU=; b=YUWIeTsUS1cGGkcavpn1R8jMyuxprVU+vzgLibXZ56WtjFaZpwczplIr3v6G5ROYHM nCKG+FIQJQW9tzCnKj78xwJIHMN/tR2SR4zbM9dKEA8+xvekLiGJwFK54BjJG+mqoJ64 QUEPNPsjb6MsJuO22fyzNHUtyg0m1QKiwqCDxW0vEvJ1Al6EVj6gpePRC8OMzMkx50GB Qmuyf4TZGUyHsPy7clV3voEDpNU0r9lzvmd/gLS4xCmRRLAh6IKWmf17EGygXFshIRwK N7OPs6hAc9plyZbSGzx945gbS1/HrI2fS2Opj71vMVvufZgYfz2tL71tKWGzwy/t714w RhQQ== X-Forwarded-Encrypted: i=1; AKwUvByPzHj+znTGRjxahrAZatR5r5YEnOwThwVbDHaMqGZVZCjZxuxcyjpwPZzvQXGHHfvkjCAlBWAPwHgoA2E=@vger.kernel.org X-Gm-Message-State: AFuF++nWDcPvllHHYPFNCTH1fYILEPF9PbEKAeTfgreDCDVe9YaFeWs2 bEOZYFpEhrJBWO+1k+mLODJIyRAP2L+rTn086Uew+qgpTQ2ybb077ANW X-Gm-Gg: AYBFou07gUtPZsOEo2vc8jhTBXlMh/AH/V0lFeUHgRArnYgRtjNxyhIcMDDNhzIFkXp R9c1zhKznBdjGFHI12MQelKjHZusSQBOcSgcmHU7/hNMeaVv9+2lwkvp6T8pWdie3yNMcyapiU+ z47QEHiVV2Z8RuBq4LCXZecIZEvT/DMkdnjSdfQu1OF6cTJHsyvRiJYgwSqq/JoOa+O4OSVjw/C bhg+0qBJfCM9yfBHwmQD+Q72K4Wv++S5svJjLFPl2z2G7BeRiBnC13WxIZ70DnOYTZQiQS4Lllk 1xANi2MyzweHxl64ZDH9S+kDAq1MJLXs4NvzRjg5GuoeFEFbI/dubqpu6iBv1QtFxiMHp6gWZ/E KhJFpVa48b6AtKzVk7eOlDUP+J9A8gZJNEC5LhNdX8oY5xCjdpEhASIbbGhbtFL//9ta4DCpagR 27SfSxKbp37We107WpQvW7mclJF5zcXwN7ODjNn2Fs5IhwmVgVQGo+rL/HJbQOVqUryFawZfCSX NORcWH8Pa5Top5PnifJBOEiXWpjosbLgXiZgYyRdMv2snZGAIcwEGq+bsToGdqhMMszcFG0TeZu EFRlsPdf02JDm/c= X-Received: by 2002:a17:90a:d008:b0:39d:f5b1:e35f with SMTP id 98e67ed59e1d1-39df5b1e456mr82384a91.25.1789370968111; Mon, 14 Sep 2026 00:29:28 -0700 (PDT) Received: from phuc-desktop.. ([183.91.15.56]) by smtp.gmail.com with ESMTPSA id 98e67ed59e1d1-39d957131f9sm19598245a91.12.2026.09.14.00.29.24 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 14 Sep 2026 00:29:27 -0700 (PDT) From: phucduc.bui@gmail.com To: Mark Brown , AngeloGioacchino Del Regno Cc: Liam Girdwood , Matthias Brugger , Jaroslav Kysela , Takashi Iwai , Cezary Rojewski , Cyril Chao , Kuninori Morimoto , Dan Carpenter , cassiogabrielcontato@gmail.com, linux-sound@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-mediatek@lists.infradead.org, linux-kernel@vger.kernel.org, bui duc phuc Subject: [PATCH v2 07/13] ASoC: mediatek: mt8189: Propagate runtime resume errors Date: Mon, 14 Sep 2026 14:28:36 +0700 Message-ID: <20260914072842.24420-8-phucduc.bui@gmail.com> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20260914072842.24420-1-phucduc.bui@gmail.com> References: <20260914072842.24420-1-phucduc.bui@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" From: bui duc phuc mt8189_afe_runtime_resume() currently ignores errors from regmap operations and mt8189_afe_enable_main_clock(). Propagate these errors and clean up the state before returning the error. Fixes: 7eb153585598 ("ASoC: mediatek: mt8189: add platform driver") Signed-off-by: bui duc phuc Reviewed-by: AngeloGioacchino Del Regno --- Changes in v2: - Update the names of the goto labels. sound/soc/mediatek/mt8189/mt8189-afe-pcm.c | 36 +++++++++++++++++----- 1 file changed, 29 insertions(+), 7 deletions(-) diff --git a/sound/soc/mediatek/mt8189/mt8189-afe-pcm.c b/sound/soc/mediate= k/mt8189/mt8189-afe-pcm.c index 77cf2b604f6c..67fa40afdefa 100644 --- a/sound/soc/mediatek/mt8189/mt8189-afe-pcm.c +++ b/sound/soc/mediatek/mt8189/mt8189-afe-pcm.c @@ -2328,24 +2328,46 @@ static int mt8189_afe_runtime_resume(struct device = *dev) =20 if (!afe->regmap) { dev_warn(afe->dev, "skip regmap\n"); - return 0; + ret =3D -EINVAL; + goto err_disable_reg_rw_clk; } =20 regcache_cache_only(afe->regmap, false); - regcache_sync(afe->regmap); + ret =3D regcache_sync(afe->regmap); + if (ret) + goto err_set_cache_only; =20 /* set audio 26M request */ - regmap_update_bits(afe->regmap, AFE_SPM_CONTROL_REQ, 0x1, 0x1); - regmap_update_bits(afe->regmap, AFE_CBIP_CFG0, 0x1, 0x1); + ret =3D regmap_update_bits(afe->regmap, AFE_SPM_CONTROL_REQ, 0x1, 0x1); + if (ret) + goto err_set_cache_only; + + ret =3D regmap_update_bits(afe->regmap, AFE_CBIP_CFG0, 0x1, 0x1); + if (ret) + goto err_clear_26m_req; =20 /* force cpu use 8_24 format when writing 32bit data */ - regmap_update_bits(afe->regmap, AFE_MEMIF_CON0, - CPU_HD_ALIGN_MASK_SFT, 0 << CPU_HD_ALIGN_SFT); + ret =3D regmap_update_bits(afe->regmap, AFE_MEMIF_CON0, + CPU_HD_ALIGN_MASK_SFT, 0 << CPU_HD_ALIGN_SFT); + if (ret) + goto err_clear_26m_req; =20 /* enable AFE */ - mt8189_afe_enable_main_clock(afe); + ret =3D mt8189_afe_enable_main_clock(afe); + if (ret) + goto err_clear_26m_req; =20 return 0; + +err_clear_26m_req: + regmap_update_bits(afe->regmap, + AFE_SPM_CONTROL_REQ, 0x1, 0x0); +err_set_cache_only: + regcache_cache_only(afe->regmap, true); +err_disable_reg_rw_clk: + mt8189_afe_disable_reg_rw_clk(afe); + + return ret; } =20 static int mt8189_afe_component_probe(struct snd_soc_component *component) --=20 2.43.0 From nobody Fri Sep 25 10:36:34 2026 Received: from mail-pj2-f12.google.com (mail-pj2-f12.google.com [74.125.227.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 0D46B3E8328 for ; Mon, 14 Sep 2026 07:29:32 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=74.125.227.140 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1789370974; cv=none; b=ZCYAcekmmv1gNjSc+qycYDVzxDaaPUv3MDroolWOhV26UN5OgYx1VTSuN0NEpZNwhNmyun253d5njsxXqiU4ioZfGni10i25eUqilYXWmB+5QQX8iL0vDGdOf242A3IsSjgHxAYSSmeSaJ3ms4kaRejEIFtbGmVTq8FwGJfnLXQ= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1789370974; c=relaxed/simple; bh=yOM3Ftr+tZ+A5ui4+ZQHA4pRO70m1aCA1F6hMr5fOqY=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=KrlnNDx/PBTLyYviQL+BFKvKYRc0sjkeoZrmPZlLqd0ldWzrvEOffcFzVNvUauSu5nh4YV0Fd2ceSY2isFh1b9lxFPSJNwR2KN2By1BT1hDCXSjkbYhCvlbKxWIx0nate3ic3lNb9KUK0gt1HVv6soO4pQQ4F1pdcUs3toXtAN0= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=LNdjVXis; arc=none smtp.client-ip=74.125.227.140 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="LNdjVXis" Received: by mail-pj2-f12.google.com with SMTP id 98e67ed59e1d1-396ccd66bb5so1381929a91.0 for ; Mon, 14 Sep 2026 00:29:32 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1789370972; x=1789975772; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to:content-type; bh=kvhy8CjCHaEUNOyzqez3eokLT1azbHniSOhw40sTHWA=; b=LNdjVXisSUAw5dGg7GymYf40hNE6JRhnpXn5mA5waTNlGrXVHbgO6UVZHmm4gSpy/I oSoANvg/MbKLpepRdsq2lUqlPiPXSVThMvNHqdhbNArnJMG946liup4nDTLqBMCSR8HW sJ0o4uK9faIzoaf9935/nWNdFJKqZ/D5me3JCs7lSiTGGi/isIM65sE2v/rEoxKVeUZZ rlT1FCZI8SSYKXT3HD4X1CGQZhPUhGqYvO9dcxzme95YT6Z8qeec0hbL1n+qALgRra2h fWI1wyeyHe6AdTPld2vy+4oYzIe8ip7vwoCapDqsboaw7Yr+1ByRQRYU9hWov143LdRT gyHw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1789370972; x=1789975772; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to:content-type; bh=kvhy8CjCHaEUNOyzqez3eokLT1azbHniSOhw40sTHWA=; b=lUtz0oaM6Tz6vb0quSzj2UcVbgVsubuJiywQVNkemEPAGnA4HOwE80NVi6wG1wvHUq jv7OhFZUpn5JI+xBTV5G0DMbnCdJHxL51Q1ojAITPvwCyRRsqcDX3c64NNRCl69oBpWl WXIK4OOtThfJBW+lgdBJdeT7LP+FZo3FE63dhXgdhmdZDtuIPqtnVCk11JYVHp5rr6Jy CdT6gkFRh6WDDEQXaSzyXePAL7soXtpMHAgNQrj/z9cmnpeYHPZFlqSjzBHIa4DanzEg LKAS9T0Hx0To0c+QV6GLv7p+lQfNO8iFjhxlMGAKchZCtW/Pem0UzGS141rJqg5EO0Tt puKw== X-Forwarded-Encrypted: i=1; AKwUvByIb/b5YHCPvnr7/yUGTdgb0A+fEwEbQNmIOuwC9QEI3JBo7IDWvbE1hC5N8Ih8otVp+ZUqW2KDSjFDsmU=@vger.kernel.org X-Gm-Message-State: AFuF++lTPMjmBtEMMESXHOErEC+s2NpkobOcNIvaVH+Sa5uNnvGtwC0c 0e8uyMEiTRj9UyXjXIsK86pqmykcnmFixEeocNs2rE49xIQOmnwjsFmT X-Gm-Gg: AYBFou0lxB3P8Y3MPurXiqH/KWAhM7Qc++yCwJ8yPreKvCeyX9GSH+Cvq23D+yg68ky yGjwEEwijmAaTPEkLC2OiNbCnZMuolXHTIPBkWBbjC3uEHbHdvTLJ3XVvKT39xzXYtOWQ/P/D3D tMkHvDi7ix6YmzS4tKneEMqnmykdrLnDS1/IBzuL2HeajOy9Jzb1WWGwhDs6RMqqjBPAoKsBuxt Ctv4XWQE/n+c8XNhbNWQcu2KgDcOaHvEqygvyCeOG0wUrEMX6MDA8A+28xt6Q0XlmjX6OW8qrV4 P/mQxAbzDxTYCUps+s68mENtp3iSVs2WUxAspkydnkZphZNU9y6s24A3hGR7t4fHOZXLL2wwY1O qWxReAlTD4VRVjDBsQvGY9kb2U5B++zpsX+HMd0cAgbnsyM1ENkuddj1xztqcQgOBC6B27Yx1et QMNsaZMurHE+OEPiswhxgS+6w/vfChi9s4EWyY8en3GDP9uOY/rZ0b03xW5MwfQbV6LUHYJR8mF 2f1rEgx5QEs7OjjCIAC/x3AEqgZO0foasxEQIwp7bKPac6yyQxhwwJSTPB/hxVpXN0S9LpRQjzj ItIhnN2WFQzqOm5/z+BPn02fMg== X-Received: by 2002:a17:90a:1189:b0:39d:f064:3a76 with SMTP id 98e67ed59e1d1-39df06469efmr944725a91.15.1789370972413; Mon, 14 Sep 2026 00:29:32 -0700 (PDT) Received: from phuc-desktop.. ([183.91.15.56]) by smtp.gmail.com with ESMTPSA id 98e67ed59e1d1-39d957131f9sm19598245a91.12.2026.09.14.00.29.28 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 14 Sep 2026 00:29:32 -0700 (PDT) From: phucduc.bui@gmail.com To: Mark Brown , AngeloGioacchino Del Regno Cc: Liam Girdwood , Matthias Brugger , Jaroslav Kysela , Takashi Iwai , Cezary Rojewski , Cyril Chao , Kuninori Morimoto , Dan Carpenter , cassiogabrielcontato@gmail.com, linux-sound@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-mediatek@lists.infradead.org, linux-kernel@vger.kernel.org, bui duc phuc Subject: [PATCH v2 08/13] ASoC: mediatek: mt8189: Remove redundant error message Date: Mon, 14 Sep 2026 14:28:37 +0700 Message-ID: <20260914072842.24420-9-phucduc.bui@gmail.com> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20260914072842.24420-1-phucduc.bui@gmail.com> References: <20260914072842.24420-1-phucduc.bui@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" From: bui duc phuc The errors handled here are already reported by the called functions, either directly or deeper in the call chain. Therefore, the additional dev_err() and dev_err_probe() call is redundant and can be removed. Signed-off-by: bui duc phuc Reviewed-by: AngeloGioacchino Del Regno --- sound/soc/mediatek/mt8189/mt8189-afe-pcm.c | 13 +++++-------- 1 file changed, 5 insertions(+), 8 deletions(-) diff --git a/sound/soc/mediatek/mt8189/mt8189-afe-pcm.c b/sound/soc/mediate= k/mt8189/mt8189-afe-pcm.c index 67fa40afdefa..981e660981e3 100644 --- a/sound/soc/mediatek/mt8189/mt8189-afe-pcm.c +++ b/sound/soc/mediatek/mt8189/mt8189-afe-pcm.c @@ -2488,13 +2488,12 @@ static int mt8189_afe_pcm_dev_probe(struct platform= _device *pdev) =20 afe->base_addr =3D devm_platform_ioremap_resource(pdev, 0); if (IS_ERR(afe->base_addr)) - return dev_err_probe(dev, PTR_ERR(afe->base_addr), - "AFE base_addr not found\n"); + return PTR_ERR(afe->base_addr); =20 /* init audio related clock */ ret =3D mt8189_init_clock(afe); if (ret) - return dev_err_probe(dev, ret, "init clock error.\n"); + return ret; =20 /* init memif */ /* IPM2.0 no need banding */ @@ -2528,13 +2527,13 @@ static int mt8189_afe_pcm_dev_probe(struct platform= _device *pdev) /* request irq */ irq_id =3D platform_get_irq(pdev, 0); if (irq_id < 0) - return dev_err_probe(dev, irq_id, "no irq found"); + return irq_id; =20 ret =3D devm_request_irq(dev, irq_id, mt8189_afe_irq_handler, IRQF_TRIGGER_NONE, "Afe_ISR_Handle", afe); if (ret) - return dev_err_probe(dev, ret, "could not request_irq for Afe_ISR_Handle= \n"); + return ret; =20 /* init sub_dais */ INIT_LIST_HEAD(&afe->sub_dais); @@ -2603,10 +2602,8 @@ static int mt8189_afe_pcm_dev_probe(struct platform_= device *pdev) &mt8189_afe_component, afe->dai_drivers, afe->num_dai_drivers); - if (ret) { - dev_err(dev, "afe component err: %d\n", ret); + if (ret) return ret; - } =20 return 0; =20 --=20 2.43.0 From nobody Fri Sep 25 10:36:34 2026 Received: from mail-pj2-f12.google.com (mail-pj2-f12.google.com [74.125.227.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 57F373E3D86 for ; Mon, 14 Sep 2026 07:29:37 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=74.125.227.140 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1789370979; cv=none; b=eZOi1gYLXK2JRyhzZg6t5glq0CobnKixBUuSi8sWKLdsEWCs7AenEeqkSBHY4F1MEPuHagK6RSuTzcL7P3G1vBuMRdNnYC9QuEhN25m19mfJERtkDXui2lrlBGzTyDMDs1cHXPneFzPorUYowYyE+bOEDAVBEwNRbHym0xeJ32E= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1789370979; c=relaxed/simple; bh=Wfj7ayzlWfEu+I8dT6gg9Qx37En8fvuHsBJbQGPJEIc=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=BjUwf69AtyMvix+D7PhkDes/ReSkMwLJlir2XAVTEqGVN7K7XvQefnLcbhlBqRJ6R2tsXVgMYNT79sLQ79mcqsG6Z9A6begvsnKauPcl0J4tXKPLIHo8H8XCuI2Je5JV2PvJqZ6HJ+Ghw5a01TdNcK6Yy6+KysvBNyUAxkMuKo0= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=bJixNnUh; arc=none smtp.client-ip=74.125.227.140 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="bJixNnUh" Received: by mail-pj2-f12.google.com with SMTP id d9443c01a7336-2d747ed9866so19433535ad.2 for ; Mon, 14 Sep 2026 00:29:37 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1789370977; x=1789975777; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to:content-type; bh=qB6h8bEY4JQqTm9X+KYhPwqJjNuxDZMSiRPIGrpZWzc=; b=bJixNnUhQU9qsiIhlXMyzCCSczuXh/iQR+x6t6UZBagv7+bb00k6CCCVnk6mO7vuXL Da83jzK57wTJGycD1PYr07WeqY/LHSIPujGEDZK9meZYNNbYAeWjbK5IayCRoUiIs4c5 P6gA26Bpp8Y82cNoJ4hqf9Xybi1dpc0zE5baur3fs3mLEBoxoKqpMwkjWjDwSdEVhj12 Y5eu0NO6agQ4lBjgBJ3G3tFpItUQQkPvAAVODG500p2AgQxnZoA6hyqvhI2umOUj1p3s StiFWq2wvy3nGAI80xwh3rnaSfUx6e42H9/9nTDDRyLt/KTuRKuI1l9ER/a3doIqjU1Z 3TKw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1789370977; x=1789975777; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to:content-type; bh=qB6h8bEY4JQqTm9X+KYhPwqJjNuxDZMSiRPIGrpZWzc=; b=CjhsIZuawqDx11LRqpwyJBxAUWJD7q+ll8QeGoFhpOaEgAZLWXTDR+8MqLN14to7TQ NElPlrxWczB+orj9aud29LSuciD3JEvv76x0NExMHS3U78Jrz1JDpHNooHP/qbXKNo+B XLNo2CblFbF5kTWayen4049NGUvbLEvuZBMo2KsPWIPM6cfzrTEUcr074q3ihJTPCN2A wd1nLxNv633Bq0X1wekOFLhK+oAE9xyjhgk3YzJz4araARdpcfaGh4yYu0kHLYdcD79v k6oaeI1iaMyG709SKvCgV4g8HoHdd8dQl+PGiF94sKvskB46ffQOY9JQnmfuiL4khbbn 6MQg== X-Forwarded-Encrypted: i=1; AKwUvBz0672szWiLtYlAo9WJ9BiXptLHvvBKJ2wRWJ3KVRJQOU+CbIYmPRuWKTEjMNmSEuhqAYGMkyVgG1kdFEM=@vger.kernel.org X-Gm-Message-State: AFuF++m9Ik+qwoaKeD7E5tCBCPf+Ao4QXe2pgv2gQwAZrki26YcrBFC5 d4YAj0Emr7mFrFCf56COoX4I3qxZBoS++0np11uSnzaGq3J8tcK4NckR X-Gm-Gg: AYBFou2/Y7Xby437e/p5Cu0I/v1C8GpIWQ+bIA4ivjQLQWv8QG7qrdnCXTv2ej0jYj4 msp8p8vq/xNkoA1KRrxZxRSB1CQawWkqvoho3DNqNGDvzvdK1pUA898zkvX9rPQREwvYKyxfQ4L vAFpc9f8ET60rKsJ5pdJ8rn9oKSgd1bnoPFom9ioCDCMVsH1/j+30ZZ4sk4asu4l2Pi5HSB+igO dIgnByNg7xokjeg95E8teNgZM4Z3B0CcJfg1b7uOgW0vcKYRdcK1Gr8R+jXYxIBXnPiSedNnU5I LkHaKWmu4IhOn7yVLmeemYimHDxbQk110oyXxm6uIENwTaZOwdXGoIm/MZpw6hyTf39JdJYpcp4 k6O5VFzqhYSlI022+QkYh2FuLdttRBak2UVvHfvzaq8bFlFijsTapJEVfijbpj21J9imSV+TjIn GfuUTjXPmz6Z5rlXGjrNfKXhb09PIprY4nnZoz+2w6iSOfOlV0DXm1WZvQXJNpuw4dj3mKw+YaV qTNpYDv2tgdmOHzhcMp9BbfIKzofyocPeMa6chq4ALaO2TeGbFa7qBM/Cdp4yfeVpIMCm6sGzBE BE4TyaemFUxFc/8= X-Received: by 2002:a17:90a:e188:b0:398:b71e:60c1 with SMTP id 98e67ed59e1d1-39dec05885emr3027132a91.12.1789370976645; Mon, 14 Sep 2026 00:29:36 -0700 (PDT) Received: from phuc-desktop.. ([183.91.15.56]) by smtp.gmail.com with ESMTPSA id 98e67ed59e1d1-39d957131f9sm19598245a91.12.2026.09.14.00.29.33 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 14 Sep 2026 00:29:36 -0700 (PDT) From: phucduc.bui@gmail.com To: Mark Brown , AngeloGioacchino Del Regno Cc: Liam Girdwood , Matthias Brugger , Jaroslav Kysela , Takashi Iwai , Cezary Rojewski , Cyril Chao , Kuninori Morimoto , Dan Carpenter , cassiogabrielcontato@gmail.com, linux-sound@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-mediatek@lists.infradead.org, linux-kernel@vger.kernel.org, bui duc phuc Subject: [PATCH v2 09/13] ASoC: mediatek: mt8189: Propagate APLL errors Date: Mon, 14 Sep 2026 14:28:38 +0700 Message-ID: <20260914072842.24420-10-phucduc.bui@gmail.com> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20260914072842.24420-1-phucduc.bui@gmail.com> References: <20260914072842.24420-1-phucduc.bui@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" From: bui duc phuc mtk_apll_event() currently ignores errors returned by the APLL enable functions. Propagate these errors. Fixes: 7eb153585598 ("ASoC: mediatek: mt8189: add platform driver") Signed-off-by: bui duc phuc --- sound/soc/mediatek/mt8189/mt8189-dai-i2s.c | 7 +++++-- 1 file changed, 5 insertions(+), 2 deletions(-) diff --git a/sound/soc/mediatek/mt8189/mt8189-dai-i2s.c b/sound/soc/mediate= k/mt8189/mt8189-dai-i2s.c index 94c49a662e2d..4826ee250d70 100644 --- a/sound/soc/mediatek/mt8189/mt8189-dai-i2s.c +++ b/sound/soc/mediatek/mt8189/mt8189-dai-i2s.c @@ -485,6 +485,7 @@ static int mtk_apll_event(struct snd_soc_dapm_widget *w, { struct snd_soc_component *cmpnt =3D snd_soc_dapm_to_component(w->dapm); struct mtk_base_afe *afe =3D snd_soc_component_get_drvdata(cmpnt); + int ret; =20 dev_dbg(cmpnt->dev, "%s(), name %s, event 0x%x\n", __func__, w->name, event); @@ -492,9 +493,11 @@ static int mtk_apll_event(struct snd_soc_dapm_widget *= w, switch (event) { case SND_SOC_DAPM_PRE_PMU: if (strcmp(w->name, APLL1_W_NAME) =3D=3D 0) - mt8189_apll1_enable(afe); + ret =3D mt8189_apll1_enable(afe); else - mt8189_apll2_enable(afe); + ret =3D mt8189_apll2_enable(afe); + if (ret) + return ret; break; case SND_SOC_DAPM_POST_PMD: if (strcmp(w->name, APLL1_W_NAME) =3D=3D 0) --=20 2.43.0 From nobody Fri Sep 25 10:36:34 2026 Received: from mail-pj1-f48.google.com (mail-pj1-f48.google.com [209.85.216.48]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 635E03E5EF1 for ; Mon, 14 Sep 2026 07:29:41 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.216.48 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1789370982; cv=none; b=sO5Ttr/XA2DVs7aBp+ysqv4PybaQwYdmxwXfHjKuRyWtxmuLTIqFjlfNjtP9Lfn9A1+HZlgtu3czyASLb+w404ZdxiLO+imHjDr8m+Ar0qWj5RFumRKaZ5ZMAn5copwDVisKFoiJhu4TNc2c1HR2fkPC1yIPiA7RVqla7xmAhJ8= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1789370982; c=relaxed/simple; bh=L2LE+CaRB/r8u7ksh8vaBEGwU4XGfFxUrv1E4QN5LbI=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=ex0oE3MV6wSChk1McFvYFP43LhBaKJA70EpklzsLuSnTc/zy6vFeG7d+343N7q5i898ttclbARfK25WQOXd8phMLQfPgb9v2jXEU62Ss2hktQmT/xpfFBbros4ivqoGthzXgHESVUimN7z+IPtex0LDOMm4g7XpMsvdHZkgUQe0= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=SpmbS4WB; arc=none smtp.client-ip=209.85.216.48 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="SpmbS4WB" Received: by mail-pj1-f48.google.com with SMTP id 98e67ed59e1d1-38ea87caafeso2934161a91.3 for ; Mon, 14 Sep 2026 00:29:41 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1789370981; x=1789975781; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to:content-type; bh=PGiDmxTKSnaxUwBF7nwBu69cnzbPnmVOgMWHLivqaTs=; b=SpmbS4WBqZaX2y36mQU5uExJ2EOJgO5CfGdLkaecYaF9LE/B+chwbVaHD1fSGbDfku v3+68nQEWhuR20WcI3M4GJ9vTTFTts4jNT9IV2jOdCPOBm6hI4Acre4zOBg0aiSkd3Xr 9Ne+de4QXLqVkm+S7FuoEksgxhxLHBXAyk2eukIlybVCbU8g55nAI7Qz/CN/Fq4Glgsm XdF2ii0tQwTcVUa1xUdswHkSbYtF/JeVemQcE3YzbPAr+fmNRLNgS3TMc31uuMvhymDY v3fDRTB3emzXTemCauJyRKRyUXJEepjIJuv0rHyDu7nt72HS2N0bSFSLPCI2EnTsvL0q qYJg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1789370981; x=1789975781; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to:content-type; bh=PGiDmxTKSnaxUwBF7nwBu69cnzbPnmVOgMWHLivqaTs=; b=NFY9KBbL8XnnWTsrP6cVf0f+RfWqwci5Kvut5llE9HHRafTp2AbktsrBJtf53enbpM CQ2+6ly8QPnM03SmsVHgJQO7tadVlGgJQLlJKGa66PsBnE4f3uujeAk+TlZpAX5C9o9n kk4Xo9euz1u4oxfib2YsIckuk0xX3utLVH445MGw8nMzVF2ZhAD1LmNUYamRzLe4sEQc Lg98gRu8Vi0fgheL2JRZ72jhnpc2/uMNLBwgzD30xPFk3cHIQ4cjPFqTrJ0S43PySK/r CUqbuZJD1W9j/kbv6vBUQkaynHW1YzOnzYHpCIX26Uz+fpNhg/3rnT9CTcqO08PWZbn/ MQFg== X-Forwarded-Encrypted: i=1; AKwUvBxvEdcklDPTIPwONJ8zt3ejW1I88uZveW2dCav9wW5UKXeNLi+FrgtDXZ9TQCXHtqIwSeN2IqJjBbWM4vM=@vger.kernel.org X-Gm-Message-State: AFuF++l3Aq1RpVL8Ysh72iuXja08KLk3pq5REDKO/QhXDGWb/P6biXID o2QLji9ex9A5DPc2eZVvNP9ja5TxoM24SNQljkhdCkg6HY6srvoymbEf X-Gm-Gg: AYBFou3Sn3o4c7cLID4eExS2hZ9rUaYzGBcprlRv45vIVZgDBa3oIpDTapjJ2wq2xrn T6fcUxJFRMEbVWotz/yWhtdIX6dr5gPa5/YQI3let9zPDjFrBceR/72C/tZkBNAb0S9faPQoRa2 DDPflmZTLwFg0SVRDErfN8RO738AQ5xsKJv44h7epnUN+imydd+DVaMe05F8e3xRN4Y6SxNio41 ZGIGTK93ovvu2BNqIE7BSCdfsGMBKcZ4td8DkZ5RNmFQmATXmiWnYXZgXq8r/J2tb2aaA+Wwq4D eOd9t3R3mbTnWjKGPvqrRWNk7WINkbbU+w5WhOtzINcsmLYfGBECNxa7KilrqmUn8ReAudyqcjE 6pkdaY3Lek2lAlhFMFIQt8HPtaoClfGIN/ndbEaFoLmaHU1U8enS6Wbx4w2EW+FpTOejZxnFtCk 2wK5hRNaCsUBU6AqxT3opdvHz+ezWFJaP3mgzaxfICdmyIxlFIxJ7seRljM0ZQ0vAgPOAmEgwAv sR1Y7ReX1eCdw7O5hssq0JupxiqIg3j+m3L3jbPGYg/QTpGTyayYwEjeZxWKPWoM29EsH066EYx nu4jSCpxfeIn9OKJ X-Received: by 2002:a17:90b:164f:b0:39d:b1bd:b384 with SMTP id 98e67ed59e1d1-39dec0b6344mr3180432a91.17.1789370980816; Mon, 14 Sep 2026 00:29:40 -0700 (PDT) Received: from phuc-desktop.. ([183.91.15.56]) by smtp.gmail.com with ESMTPSA id 98e67ed59e1d1-39d957131f9sm19598245a91.12.2026.09.14.00.29.37 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 14 Sep 2026 00:29:40 -0700 (PDT) From: phucduc.bui@gmail.com To: Mark Brown , AngeloGioacchino Del Regno Cc: Liam Girdwood , Matthias Brugger , Jaroslav Kysela , Takashi Iwai , Cezary Rojewski , Cyril Chao , Kuninori Morimoto , Dan Carpenter , cassiogabrielcontato@gmail.com, linux-sound@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-mediatek@lists.infradead.org, linux-kernel@vger.kernel.org, bui duc phuc Subject: [PATCH v2 10/13] ASoC: mediatek: mt8189: Propagate MCLK errors Date: Mon, 14 Sep 2026 14:28:39 +0700 Message-ID: <20260914072842.24420-11-phucduc.bui@gmail.com> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20260914072842.24420-1-phucduc.bui@gmail.com> References: <20260914072842.24420-1-phucduc.bui@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" From: bui duc phuc mtk_mclk_en_event() currently ignores errors returned by the MCK enable and disable functions. Propagate these errors. Fixes: 7eb153585598 ("ASoC: mediatek: mt8189: add platform driver") Signed-off-by: bui duc phuc Reviewed-by: AngeloGioacchino Del Regno --- sound/soc/mediatek/mt8189/mt8189-dai-i2s.c | 7 ++++--- 1 file changed, 4 insertions(+), 3 deletions(-) diff --git a/sound/soc/mediatek/mt8189/mt8189-dai-i2s.c b/sound/soc/mediate= k/mt8189/mt8189-dai-i2s.c index 4826ee250d70..f20dbb410223 100644 --- a/sound/soc/mediatek/mt8189/mt8189-dai-i2s.c +++ b/sound/soc/mediatek/mt8189/mt8189-dai-i2s.c @@ -519,6 +519,7 @@ static int mtk_mclk_en_event(struct snd_soc_dapm_widget= *w, struct snd_soc_component *cmpnt =3D snd_soc_dapm_to_component(w->dapm); struct mtk_base_afe *afe =3D snd_soc_component_get_drvdata(cmpnt); struct mtk_afe_i2s_priv *i2s_priv; + int ret =3D 0; =20 dev_dbg(cmpnt->dev, "%s(), name %s, event 0x%x\n", __func__, w->name, event); @@ -529,17 +530,17 @@ static int mtk_mclk_en_event(struct snd_soc_dapm_widg= et *w, =20 switch (event) { case SND_SOC_DAPM_PRE_PMU: - mt8189_mck_enable(afe, i2s_priv->mclk_id, i2s_priv->mclk_rate); + ret =3D mt8189_mck_enable(afe, i2s_priv->mclk_id, i2s_priv->mclk_rate); break; case SND_SOC_DAPM_POST_PMD: i2s_priv->mclk_rate =3D 0; - mt8189_mck_disable(afe, i2s_priv->mclk_id); + ret =3D mt8189_mck_disable(afe, i2s_priv->mclk_id); break; default: break; } =20 - return 0; + return ret; } =20 static const struct snd_soc_dapm_widget mtk_dai_i2s_widgets[] =3D { --=20 2.43.0 From nobody Fri Sep 25 10:36:34 2026 Received: from mail-pj1-f41.google.com (mail-pj1-f41.google.com [209.85.216.41]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id C8BAF3E3C68 for ; Mon, 14 Sep 2026 07:29:45 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.216.41 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1789370987; cv=none; b=AoNiDeqFPUV2xnPjjdQiaKjPA3EZadXV91vMp9htgCd9iSjr+kXT/42AZ+rQd8NgP1EnUr5qXQOzNVPhPktymSlIkCxksKgsI81ocYyyw2UuxqyQ4Uydt104SRh0pYr0v5ZWLtFfv1hEgWt5koqtf01jPJjf1yOBj+/r9RUviQQ= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1789370987; c=relaxed/simple; bh=yVHr58+jpi0ogaZaNb/vAEA+UBaGvyzAgPcg7m3FJUI=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=QmntaViY1mrkiowZhH3VY9atL6cifExGQIlpgQc3zRWAS2PHTt58BENpAY4IxMlq/eSLGA4WMl90XU92FiEQxPM22vkzYaRdKqjlFr51e4pok5j0WyBEimSC/1QQwv6Amg4okgC5mcwXlzfZ+G/j2S8hbRPV/kmLiaF3rTh/D4s= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=aIONortY; arc=none smtp.client-ip=209.85.216.41 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="aIONortY" Received: by mail-pj1-f41.google.com with SMTP id 98e67ed59e1d1-381b831d535so5576492a91.0 for ; Mon, 14 Sep 2026 00:29:45 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1789370985; x=1789975785; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to:content-type; bh=iLuGPJOul88SFkcVl5PHBDFHBc0tVdx0/BNU/eqBS78=; b=aIONortYejgKrJlCywY3/Bg7Ua32BwTy3UUecesz3flUVbpA30rWIUWmb5Fjv0zqgp pNJB11SWkcdMtrOtxjoL9RXTe7OBf3PIXc7DxkqOdIawO18TqQmZhP4bG59x8dm2nSLE AmuSE29p0LjYmLhaN5iT1ag7QlMUmklZ1diAeFAMLeBNta7SKIWLmcXQpL8WW/0Y5WFZ IBIeUxEnw56wOEegj84o5jN0l7q8TvNsnqiWnkySyNzZz2TmuiJPKEFW6EmaBluwo/0V v61HwiakXDNgWNkooWZHfMa7MdIMvns9d9V5hMOFWBq3yLUdLu645y1PcRYQDv7vV+M0 Rryw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1789370985; x=1789975785; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to:content-type; bh=iLuGPJOul88SFkcVl5PHBDFHBc0tVdx0/BNU/eqBS78=; b=nEz/LOt3bfaR3ZxakybtRwSSLTlmayazqefYAGORO9PbKkf28UEL1MZH3hWNQSqHan 0zGPm9eYN5hrYGWo+86RHZt0WylyVqlZQgqtiNFItmOQNxaedDVAL9+iQuT4efBmFD24 RnKgeO+F+E/qFlE5PyNVgPZdaBALkeb3CP7y6mXOiPmlNqp3CgW22ns/IQaOl4Uz2gUH dFG9CfG0kBzgbh1eamK+wLYmbCqYbB332MlazrXCKwVFdM7zYpwfS5oK7cPpwNKd/NT2 HQ1cZe9ibZEzywiCoR+xhtWar6TRpuuld4JWgzb5hmcMkXnK7nzS3e6lo0zO+rR1+TAP 40Bw== X-Forwarded-Encrypted: i=1; AKwUvBxufomES7zRMORX7FGHKDOZ6c6aotpilEnUkZVUSmMYwkARMxkLeppE8te846DCQWy0VINxUA4GIL59qWw=@vger.kernel.org X-Gm-Message-State: AFuF++nG/L7yQbTD5gT+1UBlAPPL9AW4cx0Y5+T6p+iZ9UVnXHBUG714 a/UJW5iQgXWInmcwalYpC/BccwA2RR7u4LlnsMifCpjzlGttmoYc9m3X X-Gm-Gg: AYBFou2tsk8zaPtHFSCVU2wptw31BGAsZbPcyd/RQn9tXRO88AhigInG4ZqxZ4tbVD9 vqxY9b9eR7OaTdMT+YoAo6T2gDMSdOTpl77Y2gYVMziHYMT24y5oHSDVwJbvjV9ZeYeXw337+5M sJzIvg0ok/rZKN2iOD44i74XlB1QG6P4xrqmS4fohQV8rrWOIJyvIUdzNL98xO3Imk3Db6ZK0ok RbHQ56H8lL6Chet3Ypyz+Oin8YJJVm/IB8JVOd71U8RUjXJ41Z2OsiT00tri8aMi+EO51ChR1mR 3gBumFkXo4+KBIxVnDv+pcsnuuiWP/2DZBVfcrEKuYsCFUGeaRKkiF3HbH2xU9wGcGggwlKXx3n /u1rj5KLaWaeu1ztpmBMaVSYUxmBIKma51YNgMM+1e3KHkawwamThNrtUov0b9zwAzIu5K50jC4 85c+pwszECu6hvIyS+f9Eeiddad3T5lja1ANbViaeIJssVo67hvLspxXZZQc2366Pief5SFgY54 ozCne9i30FqMrGnSp5Oxtd0lIEbZr+mDO5io2qyAOMC23/8lhdnULs89191dg1rGKogdJc/6e5d lANVGDiMpdIqjWMqaJI1PnX66g== X-Received: by 2002:a17:90b:2809:b0:396:d27b:89b9 with SMTP id 98e67ed59e1d1-39debfa956bmr3527909a91.10.1789370985063; Mon, 14 Sep 2026 00:29:45 -0700 (PDT) Received: from phuc-desktop.. ([183.91.15.56]) by smtp.gmail.com with ESMTPSA id 98e67ed59e1d1-39d957131f9sm19598245a91.12.2026.09.14.00.29.41 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 14 Sep 2026 00:29:44 -0700 (PDT) From: phucduc.bui@gmail.com To: Mark Brown , AngeloGioacchino Del Regno Cc: Liam Girdwood , Matthias Brugger , Jaroslav Kysela , Takashi Iwai , Cezary Rojewski , Cyril Chao , Kuninori Morimoto , Dan Carpenter , cassiogabrielcontato@gmail.com, linux-sound@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-mediatek@lists.infradead.org, linux-kernel@vger.kernel.org, bui duc phuc Subject: [PATCH v2 11/13] ASoC: mediatek: mt8189: Validate sysclk frequency Date: Mon, 14 Sep 2026 14:28:40 +0700 Message-ID: <20260914072842.24420-12-phucduc.bui@gmail.com> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20260914072842.24420-1-phucduc.bui@gmail.com> References: <20260914072842.24420-1-phucduc.bui@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" From: bui duc phuc A zero frequency causes a modulo-by-zero error when validating the I2S clock frequency. Reject it before performing the validation. Fixes: 7eb153585598 ("ASoC: mediatek: mt8189: add platform driver") Signed-off-by: bui duc phuc Reviewed-by: AngeloGioacchino Del Regno --- Changes in v2: - Check for zero frequency since freq is unsigned.=20 sound/soc/mediatek/mt8189/mt8189-dai-i2s.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/sound/soc/mediatek/mt8189/mt8189-dai-i2s.c b/sound/soc/mediate= k/mt8189/mt8189-dai-i2s.c index f20dbb410223..2202fed63fc9 100644 --- a/sound/soc/mediatek/mt8189/mt8189-dai-i2s.c +++ b/sound/soc/mediatek/mt8189/mt8189-dai-i2s.c @@ -1286,6 +1286,9 @@ static int mtk_dai_i2s_set_sysclk(struct snd_soc_dai = *dai, dir !=3D SND_SOC_CLOCK_OUT) return -EINVAL; =20 + if (!freq) + return -EINVAL; + i2s_priv =3D afe_priv->dai_priv[dai->id]; if (!i2s_priv) return -EINVAL; --=20 2.43.0 From nobody Fri Sep 25 10:36:34 2026 Received: from mail-pj1-f42.google.com (mail-pj1-f42.google.com [209.85.216.42]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 293403B4EB2 for ; Mon, 14 Sep 2026 07:29:49 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.216.42 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1789370991; cv=none; b=PhRk7i/FkoR3QVL5BZFx2S4y6YNuczvyRiwA68DTqOeyy7F+vPbt7yedug0hgUog5fsR1HkZXNv6+CD2n8Hfb3W63pj6gDWlzYsfVcxkvuHZmAIy4G2cINFTjFo4BoHlXLWtcmujDUCVJ7wafHKZwHQWsCXB2SFm/mqduxB/4ao= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1789370991; c=relaxed/simple; bh=zVt/GLB/PctPHE9xjcaVCw+lY910OuGBOfYlSPretgM=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=CSvrBwljcFcj9kh2xZd2jljnXlBkvO39zBGn5SG67PMBZCc4zDfh3ZuWwotJ4mVs8Rtz5qghYO87FOB0tRkJwOzx0t0BD5TF/rmX0K3ncXYvBqbPcP4dZhP6ZtmDI6WzXSHsrJTPWM2qlgpWJ3nzPEWtvF3ptOJNvfrsncffrLM= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=KYAI7pFo; arc=none smtp.client-ip=209.85.216.42 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="KYAI7pFo" Received: by mail-pj1-f42.google.com with SMTP id 98e67ed59e1d1-3964e480f76so4091242a91.1 for ; Mon, 14 Sep 2026 00:29:49 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1789370989; x=1789975789; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to:content-type; bh=vlGnqVAUzYoXB3nTaQam08DX17fuCUu75lyq1+U5jAU=; b=KYAI7pFoKDv+72sI+qVre+WTK5th4jHZDZEbSzMkA76Tih8WoFXiferCPS9j5NkGKz 3qAQC6T8qIN1Yv8/X/Rm2TMuXinYnRS/DPNFGd1Nx0Q7q01JUn5dxMj9HfJ6lXNa2HHc e2aUfCnB6PsPSMFSU8thEMw+iO1KxCbaVox3OZ9VPaBOaEhG+kyX1tS1kXrWQbGiwnRv tFC92gK43lZIVBMwYoS89R3ujMVrMSasj7/rxn+7BJ6YCedeWSKIpk+dQGf7M5RNH9M5 7sUotqco5RJhjo5KzYerHw4FsNXKLoUk303VDPrm6VR9jjCkzmcTCaFls9oRnMvlksKp tQ+g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1789370989; x=1789975789; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to:content-type; bh=vlGnqVAUzYoXB3nTaQam08DX17fuCUu75lyq1+U5jAU=; b=CnjUO2o/7Hx+w7wgvtueRbK262uRdp/hgq+2uVfAbHgYprgW24wUCT+8uKguWAOi2s oy2IJ1FmY92Goz8WZ4Js7gGkz5GUUzPi9ZuaST1zzvK4NuQDNYPsfFwLG3STDG8Se8KA RglwpY1LMSdxqe/9uf72TlVRBl7MRcHo3ICT00mJxi2iUNhUw5OtF8OuahANi3yE/Mr/ LGb8YeRH3LqzQA1E3tX9RI9rr5EKrrjNFWohBx+j84yh6iI6dgRZV00vSpY/Hs6MWcAE n9FJwzGFGFJfLV6pOqlrmG+2ZcN5yS34t9zRSc2K4w65acMWfYWCrbRl7V9iQ9LgoNbs Ps8A== X-Forwarded-Encrypted: i=1; AKwUvBxPrI75hwQfnBrd5IgZBXt9J7Ta0RQVEFFKRHKhtdbJ24LZ3EkHb7z03H25jhwNDGyd7+Iwef40gd8AC4I=@vger.kernel.org X-Gm-Message-State: AFuF++mhv4ap47h6/TRs0G1Ih6T4dGdkjvlFeShXbSlEBu812qcgeVKU mBvrQcVhU9meKpjW4JbXBZ1cH/8c33LeQEFyVNlLtBSgTG4CRUYHswQA X-Gm-Gg: AYBFou2RXhQWwwSVlFOV4pxT7Bx0Uby9Bbb73bHv/7aOwBPLQHvqmX0D/74OtJ2Dfbg Ty4yzWq1Eixg9umRNZgs80OaroG7NdcYwDDdavGLZubnNx0fhjxD/yUgxkswL19V7idn6W1UsY4 y3fMuLQbfmNAMaSqt+MOAz4w+5So94nIvR9sEOtWYwdXZe6vLGFiQGYGehUm6h1U68qvTNCErYK CyVTt+K/KQapsTClv9U2SIsPpXtYtafUW9vRiJTMCmZt+Uj0bhTpMcNfikm+M9hk3GZLMhshDuH un0NZv0jUyEQ7b45z4ogSOVJ8RRnYLQsdt4hNyZozH20AxpUk8bgIQtmaDchBzrCWrSq4RRvltM JUSudVjAQGJSA/wNcyhgj8uW7+M+CVp0f74XC7HrstE4BGkxFa2/nyqAP5K9Kh+UXj8jU99OdYh kC81jjpUvSF1Uc3g13yZv/u9ntk4VzJL/1oyG+Znx6N+Jgninb05ICn+3C3yr77B/gNTHP0YJW4 hwCz5vUN1FaeS6i74iNM37cv0BvGWyrCdXmQiKwwoy2f+nNdGy5n2ymSAfpKT8b4ueWj+a2wTzZ l4psvC+gZv2CI1c= X-Received: by 2002:a17:90b:17c3:b0:398:deed:6e1d with SMTP id 98e67ed59e1d1-39debf6cf10mr3012416a91.5.1789370989442; Mon, 14 Sep 2026 00:29:49 -0700 (PDT) Received: from phuc-desktop.. ([183.91.15.56]) by smtp.gmail.com with ESMTPSA id 98e67ed59e1d1-39d957131f9sm19598245a91.12.2026.09.14.00.29.45 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 14 Sep 2026 00:29:49 -0700 (PDT) From: phucduc.bui@gmail.com To: Mark Brown , AngeloGioacchino Del Regno Cc: Liam Girdwood , Matthias Brugger , Jaroslav Kysela , Takashi Iwai , Cezary Rojewski , Cyril Chao , Kuninori Morimoto , Dan Carpenter , cassiogabrielcontato@gmail.com, linux-sound@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-mediatek@lists.infradead.org, linux-kernel@vger.kernel.org, bui duc phuc Subject: [PATCH v2 12/13] ASoC: mediatek: mt8189: Propagate TDM clock errors Date: Mon, 14 Sep 2026 14:28:41 +0700 Message-ID: <20260914072842.24420-13-phucduc.bui@gmail.com> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20260914072842.24420-1-phucduc.bui@gmail.com> References: <20260914072842.24420-1-phucduc.bui@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" From: bui duc phuc mtk_tdm_bck_en_event() and mtk_tdm_mck_en_event() currently ignore errors returned by the MCK enable and disable functions. Propagate these errors. Fixes: 9f202872ba04 ("ASoC: mediatek: mt8189: support TDM in platform drive= r") Signed-off-by: bui duc phuc --- sound/soc/mediatek/mt8189/mt8189-dai-tdm.c | 14 ++++++++------ 1 file changed, 8 insertions(+), 6 deletions(-) diff --git a/sound/soc/mediatek/mt8189/mt8189-dai-tdm.c b/sound/soc/mediate= k/mt8189/mt8189-dai-tdm.c index 5d68a55ccc45..1b51027c6cf4 100644 --- a/sound/soc/mediatek/mt8189/mt8189-dai-tdm.c +++ b/sound/soc/mediatek/mt8189/mt8189-dai-tdm.c @@ -261,22 +261,23 @@ static int mtk_tdm_bck_en_event(struct snd_soc_dapm_w= idget *w, struct mt8189_afe_private *afe_priv =3D afe->platform_priv; int dai_id =3D get_tdm_id_by_name(w->name); struct mtk_afe_tdm_priv *tdm_priv =3D afe_priv->dai_priv[dai_id]; + int ret =3D 0; =20 dev_dbg(cmpnt->dev, "name %s, event 0x%x, dai_id %d, bck: %d\n", w->name, event, dai_id, tdm_priv->bck_rate); =20 switch (event) { case SND_SOC_DAPM_PRE_PMU: - mt8189_mck_enable(afe, tdm_priv->bck_id, tdm_priv->bck_rate); + ret =3D mt8189_mck_enable(afe, tdm_priv->bck_id, tdm_priv->bck_rate); break; case SND_SOC_DAPM_POST_PMD: - mt8189_mck_disable(afe, tdm_priv->bck_id); + ret =3D mt8189_mck_disable(afe, tdm_priv->bck_id); break; default: break; } =20 - return 0; + return ret; } =20 static int mtk_tdm_mck_en_event(struct snd_soc_dapm_widget *w, @@ -288,23 +289,24 @@ static int mtk_tdm_mck_en_event(struct snd_soc_dapm_w= idget *w, struct mt8189_afe_private *afe_priv =3D afe->platform_priv; int dai_id =3D get_tdm_id_by_name(w->name); struct mtk_afe_tdm_priv *tdm_priv =3D afe_priv->dai_priv[dai_id]; + int ret =3D 0; =20 dev_dbg(cmpnt->dev, "name %s, event 0x%x, dai_id %d, mclk %d\n", w->name, event, dai_id, tdm_priv->mclk_rate); =20 switch (event) { case SND_SOC_DAPM_PRE_PMU: - mt8189_mck_enable(afe, tdm_priv->mclk_id, tdm_priv->mclk_rate); + ret =3D mt8189_mck_enable(afe, tdm_priv->mclk_id, tdm_priv->mclk_rate); break; case SND_SOC_DAPM_POST_PMD: tdm_priv->mclk_rate =3D 0; - mt8189_mck_disable(afe, tdm_priv->mclk_id); + ret =3D mt8189_mck_disable(afe, tdm_priv->mclk_id); break; default: break; } =20 - return 0; + return ret; } =20 static const struct snd_soc_dapm_widget mtk_dai_tdm_widgets[] =3D { --=20 2.43.0 From nobody Fri Sep 25 10:36:34 2026 Received: from mail-pj1-f52.google.com (mail-pj1-f52.google.com [209.85.216.52]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 82F163DDAE1 for ; Mon, 14 Sep 2026 07:29:55 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.216.52 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1789370996; cv=none; b=kuQexmoERlP6jLHCDLn33gxUvjP4RP/SyXjRUggDGqeMb/qIvagF27GH/PCrfdcPGvxkDlK/3tSzHp5BntrUtiKB63KgmHw8fZ5wyMB0YnwYJTI4/U6nU7xt399WeE79RfRzD5+6bgAef/9W16Tv6GGk5QvwLh3Ti97moeETrDE= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1789370996; c=relaxed/simple; bh=HNQ3yAaTj8Lox9L4v2OsrFX6RIoSfJ6hArRWObXN3VU=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=Ha/lojyw9amqnbjwsok/YfjZ14WcwHnwkIdF3YfosNeGNltYL/Tq+B5XRxYMphPZoTrVYavdKSx0GQw/xdtGGN7fIDYqHXrEZV/0YXtcrZfQXug7SbtIcTGJIC/jSfiOZ1ffXPKIDeIbzu+zsA689/n36D3cHfpMK/StNE0bAmU= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=lYfsZik/; arc=none smtp.client-ip=209.85.216.52 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="lYfsZik/" Received: by mail-pj1-f52.google.com with SMTP id 98e67ed59e1d1-3964e480f76so4091341a91.1 for ; Mon, 14 Sep 2026 00:29:55 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1789370995; x=1789975795; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to:content-type; bh=DlX7uEp+xJt+DRWD58MvDXb25/Cat7Ywclf9fNm7ioc=; b=lYfsZik/twvSM+UqaiMIjAwr1/XNFn0i3kN/SlgWyse7tgP7VHMBXaogaFrEDWLPFD R8Dy8jj0BbC3s5++wkvab2bE4DfdkMu/wn97ivBH/Ovxg8a0kWIYWebmG9mp2U/jm44N 1wussQPKOClO9yPEJlBUkv5/Rnk3WwSeKMotQ6FVNm0VBuna73i9ggJOx7C2JuMUF5V0 YGN2Zs1NBebCsz0jZ0JNBJsWdAWSvsIu6k7X4gkcqCmUpIypjrz5xW5rLN+IDZXQKFD0 eQJXuL5FwxizT7s93O0M7yZr5ZcXvGpLXQJpWRCIHRB/di/ZSqfsZXh+4Y48kX8Uy/ge 1S7w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1789370995; x=1789975795; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to:content-type; bh=DlX7uEp+xJt+DRWD58MvDXb25/Cat7Ywclf9fNm7ioc=; b=U+efKQEm2iIEot9Wt1ZqM2ovJviOp2sKdohhogzU0dDO2+ZsYGrKK97nMojUddwH52 ZudbO3mEG2oMSpOIWVwpWuHVpx5jcw1TnbeVUVZvOZ0qCQTQVb4TDEiF8E7OgSpLgSd0 GBmHfVtLwcP/pSQHs98gRw7rH5DChk1ehipaTed8j0cJl9y03KrliKxiHpCzt0DKhVQT eZliM36fwyjM0APBmosjiEh3sRaS6L1CHlDpNF+PoFvXJoX12U6p2hwM4T0zLO12IwYj BVS+EdZzxD7YgAe2j/wtcxvLcNAvBbQmHeBH9TAQB6+IGFWrYUuffEnzA9tAHgh0qpZS r9vA== X-Forwarded-Encrypted: i=1; AKwUvBxQxsh7fC3xQ36KRiBZAc55olcSEcOIbXl0PZx/8a0u7xhVtKJHthTCtie/M1NF6tXa2LLx/t0XDKEROcw=@vger.kernel.org X-Gm-Message-State: AFuF++nbPwd3N+IusREE87Z6Pi76EpETDUKMWa+vBNwqXpZkIoxCsK3G 0thcSAWK89bBPg9XsMtk8goBIkMfOPQIA4mHIgkjUdXlTd/idbrxCIREmIxtbQ== X-Gm-Gg: AYBFou1w1Ln4wwuAGNpFNnI/nBMX7rw7/BIjLZi3XfkYQxrAlG7IFZ9+lIZMXo8MJ83 np1hPPqiElzwMSpGFbpUA62xilT24zNe1PdV3G5ijBhxjJq9AMQatSIhLjT3QmYK6RpptJE5jPi r1qIZZnAeYV6LQtLcK19xbIczlgmkEGYZUU1oueElOGT56LKEsNX1PhUEDaaKNwfr10fmJ+8jbT hNV25XoI1ngsQ9Kv0b+5UgEf1cIwq2W7YiBLIGCnKNtLcECB+7G8QGDVxrEYh7lx0tX1Y3D2TGC BPEmYVq25Qxw03FTb8Om2FO8PG9kK7tmKH+mA6eiEF269TEozBlKTHj8FSgmDAiqHzWGTgWgokK VD/xr5E8m1tm8NowA3R8PQ4mfYlF3NQyh8snEHleDuzwh4rtnsmSn5uuh3W14DxR9qe8x0E6M9w 90D7kaMCwqx7Xco/YcYSqW6PWAsxy+x+f13pURHsiiivLZurutEAC2rXicxRc5g3XCtHqpMw/2n S6XLl8atkyDYS4tkPuOV3nPq9AHGPRSjO3/PRTJox7SciRgdRJ5LvYZdjMm6zdOQFacNcfpsxb3 CStiHOdyyO94N1jr3g/ivR26Ow== X-Received: by 2002:a17:90b:3884:b0:396:6344:3b63 with SMTP id 98e67ed59e1d1-39debf6ce65mr3151063a91.2.1789370994682; Mon, 14 Sep 2026 00:29:54 -0700 (PDT) Received: from phuc-desktop.. ([183.91.15.56]) by smtp.gmail.com with ESMTPSA id 98e67ed59e1d1-39d957131f9sm19598245a91.12.2026.09.14.00.29.51 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 14 Sep 2026 00:29:54 -0700 (PDT) From: phucduc.bui@gmail.com To: Mark Brown , AngeloGioacchino Del Regno Cc: Liam Girdwood , Matthias Brugger , Jaroslav Kysela , Takashi Iwai , Cezary Rojewski , Cyril Chao , Kuninori Morimoto , Dan Carpenter , cassiogabrielcontato@gmail.com, linux-sound@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-mediatek@lists.infradead.org, linux-kernel@vger.kernel.org, bui duc phuc Subject: [PATCH v2 13/13] ASoC: mediatek: mt8189: Validate TDM MCLK frequency Date: Mon, 14 Sep 2026 14:28:42 +0700 Message-ID: <20260914072842.24420-14-phucduc.bui@gmail.com> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20260914072842.24420-1-phucduc.bui@gmail.com> References: <20260914072842.24420-1-phucduc.bui@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" From: bui duc phuc mtk_dai_tdm_cal_mclk() accepts zero or negative frequencies. Reject invalid frequencies before configuring the TDM clock. Fixes: 9f202872ba04 ("ASoC: mediatek: mt8189: support TDM in platform drive= r") Signed-off-by: bui duc phuc Reviewed-by: AngeloGioacchino Del Regno --- sound/soc/mediatek/mt8189/mt8189-dai-tdm.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/sound/soc/mediatek/mt8189/mt8189-dai-tdm.c b/sound/soc/mediate= k/mt8189/mt8189-dai-tdm.c index 1b51027c6cf4..7748b4ff2c72 100644 --- a/sound/soc/mediatek/mt8189/mt8189-dai-tdm.c +++ b/sound/soc/mediatek/mt8189/mt8189-dai-tdm.c @@ -381,6 +381,9 @@ static int mtk_dai_tdm_cal_mclk(struct mtk_base_afe *af= e, int apll; int apll_rate; =20 + if (freq <=3D 0) + return -EINVAL; + apll =3D mt8189_get_apll_by_rate(afe, freq); apll_rate =3D mt8189_get_apll_rate(afe, apll); =20 --=20 2.43.0