From nobody Fri Sep 25 10:36:59 2026 Received: from mail-pl1-f169.google.com (mail-pl1-f169.google.com [209.85.214.169]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 91574340406 for ; Mon, 14 Sep 2026 05:34:53 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.214.169 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1789364094; cv=none; b=qo68zNRY1TVpXV3Avk1DXEw0UWQJ2p+CRP74K1kBKnC/exJLb/VJTnBsEuSn6bJhy76eggZxbPouPKu0u/hLrXFRXLzM9YMC1AmCRiWrjAzU/RD18mn0kXeUug/zU8twoR6eWKNmwXhTsxSoQK0iWNFDhQo5DkZSQK1WqMUitIg= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1789364094; c=relaxed/simple; bh=PyLYiRqolXNgZ1XljJ7WLyZ//aWMD1yUwpclJVxwOeg=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=mQ7EbY/qFcoJH2vcT6DkOV8F0+ITSF+fMA1rffrSMatAizr/d7W3RY9IhwZhJxAhh2J758MbhZG0JY0dS8O81p87gsvao3jvpLxMJk9uf1qaiRkbp8NXEAqbGgVPKppRH/paYitp04PIK1oSGkizfY2IESxJJceNzLQY/jGetLw= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=JljD1vy4; arc=none smtp.client-ip=209.85.214.169 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="JljD1vy4" Received: by mail-pl1-f169.google.com with SMTP id d9443c01a7336-2dd68a16955so3929495ad.0 for ; Sun, 13 Sep 2026 22:34:53 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1789364093; x=1789968893; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to:content-type; bh=IASBcTda1NMxT7D2tV4KSLuvYAReFfZa/VfnrrcpJ3s=; b=JljD1vy4GYiILbjCLDti8CecUEBnNZneIEPxtJWJ2lsmqUgZPN45wlaUd4aaumYn1X yV2WBiGCM5xv+O9uh77hIUS3lAn6yK4I00tCw/0vEXdNN/rWOpXjZ6kP/OeAv1blp0r3 UMoodZVZD6ILxYwUM6CHlqsubgnuhCjfjzbFb1a4vDacn+sXF/n8vbwJDMMh0tTlBYZm cljfrPq7HLZ2hSYSctGGjD8bixEPgGsK4NnNTgxNgSasEENx8gxEDqr19OpFZtnp7z9b m+xleQurKLzUQ+f9uMlyujAL5/OWOu6Dj5r27G8y3pX6rOVzTu4r+n4ydBzjKaNX3FRu vktw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1789364093; x=1789968893; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to:content-type; bh=IASBcTda1NMxT7D2tV4KSLuvYAReFfZa/VfnrrcpJ3s=; b=c0qal37rnANUw0nBMUzwwQWy8qdqbDd553/OdAZVE1FC3ARAsQL3stNKzz6Vn+UOZm fw4yjoPsztzW0SyahR8JoBmVH732Y8PZIW7KFsflduFbFizPKJ/YwK6+wAx697Apcf6A lsl96Ekg6uqY58po2BmOvrHVLm/HEeVa1nIgUpmvFzeUB1uOjj+1pqzHeecE6dBE6T8g 1/G9Ep0X+GO5rr4v81gSvmySGc6Wf5Xt3ZjTynC9sC4HkV3PbFj2tTHz+Y+iRPN2Zc1l RF4RDMkLWqGtamDUASDjs5laFwiWo0QGCkSgg3CDKOqetgCguv1e9Ieh0CvLbxxXc/55 arZg== X-Forwarded-Encrypted: i=1; AKwUvByi1eVPtinTFbrab2oOa0OI2yS2uwCGPVfYf6gk9eTR3lpq6i44b1M89eC8yATLjlgbRzeWhODFnAxshSc=@vger.kernel.org X-Gm-Message-State: AFuF++ndJfS+TbzjYlXQaR7Amc16hie+Xc93hhT6foVe26/PIrm1eAby gRZbcRKJOH2d2qOIGMCPk6v/5M6wkbsL4JmsiQtsbBso1/iA17Q+pU4= X-Gm-Gg: AYBFou0cb5XNAwymra60WnNrruAie1j3a3As7f5WHvbwiHmYSQn5QgGON/AC54QzAoq peIAKfr8oC/1Py2htfg8/gFSqtu+qGdx527YlQ021/qtHeUgH4oxxu75JEAUlTn58lGsUOFx2uJ 3CIp255D8+cMOpS2XtexUwANkpkcJiKBXO043SPPKZXv/wp07GOsa+cONi4RBqiodY/ZLANf9+k wdrZhF72jSx3+Ib9lwgITEOkb/H0nYKrrwBOXxmr/u6cyxPLHoRxC4hh85x/djQxXuFsdJ0mRcm UHT9cSySyn1rkJy1pUzwJl/J3tET00RKdtxDVJepKsxK4zH9eip+fcht5YbBqXNf7rNTU6XbkZp FysWXYjjWzdCJY9bye0gxnxIzwZswjRpfxO7Ox4ulHCO1VWN28RtH6XR7qF4j3aBhmBPcjOLOcH n/+AKSUYiT88rE+Yhiq+IFEuEbR4Og90WzJJi4iGqzHTbSMxkj9sMaYIu6SljJ1fMp4tmv8Mmlq YEhf8LxDYpM8eGelYQaV/Vpi3s= X-Received: by 2002:a17:90b:1f8a:b0:398:9beb:a2b6 with SMTP id 98e67ed59e1d1-39dd56bf8d7mr6649571a91.24.1789364092787; Sun, 13 Sep 2026 22:34:52 -0700 (PDT) Received: from ydg-Zenbook-14-UM3406GA ([2001:2d8:7f00:8c85:3b80:bc61:4619:5346]) by smtp.gmail.com with ESMTPSA id 98e67ed59e1d1-39d994872e0sm19009261a91.8.2026.09.13.22.34.49 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 13 Sep 2026 22:34:52 -0700 (PDT) From: Donggeun Yoo To: Steven Rostedt , Masami Hiramatsu Cc: Mathieu Desnoyers , Tom Zanussi , linux-trace-kernel@vger.kernel.org, linux-kernel@vger.kernel.org, Donggeun Yoo Subject: [PATCH v3 1/4] tracing: Print the bucket size as unsigned Date: Mon, 14 Sep 2026 14:34:40 +0900 Message-ID: <20260914053443.981201-2-donggeunyoo.kernel@gmail.com> X-Mailer: git-send-email 2.53.0 In-Reply-To: <20260914053443.981201-1-donggeunyoo.kernel@gmail.com> References: <20260914053443.981201-1-donggeunyoo.kernel@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" A key's bucket size reads back negative once it exceeds LONG_MAX: # echo 'hist:keys=3Dnext_pid.buckets=3D18446744073709551615' > trigger # cat trigger hist:keys=3Dnext_pid.buckets=3D-1:vals=3Dhitcount:... parse_field() takes the size with kstrtoul() and rejects only zero, so the whole unsigned long range is accepted and stored, but hist_field_print() renders it with %ld. Print it with %lu. Fixes: de9a48a360b7 ("tracing: Add linear buckets to histogram logic") Signed-off-by: Donggeun Yoo Assisted-by: Claude:claude-fable-5 Acked-by: Tom Zanussi --- kernel/trace/trace_events_hist.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/kernel/trace/trace_events_hist.c b/kernel/trace/trace_events_h= ist.c index 8af97fd4ee2d..a3eae5c1344a 100644 --- a/kernel/trace/trace_events_hist.c +++ b/kernel/trace/trace_events_hist.c @@ -6200,7 +6200,7 @@ static void hist_field_print(struct seq_file *m, stru= ct hist_field *hist_field) } } if (hist_field->buckets) - seq_printf(m, "=3D%ld", hist_field->buckets); + seq_printf(m, "=3D%lu", hist_field->buckets); } =20 static int event_hist_trigger_print(struct seq_file *m, --=20 2.53.0 From nobody Fri Sep 25 10:36:59 2026 Received: from mail-pj1-f53.google.com (mail-pj1-f53.google.com [209.85.216.53]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id DEB58360EFF for ; Mon, 14 Sep 2026 05:34:57 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.216.53 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1789364099; cv=none; b=Xywt52qYNeMEP79OGm5nC+RFiSP18OABQJrgO/h1CfaMRwNgO8ieCjwVSYbe75yv5IRGC6nnNXfper+55mAIzoJCgw3q2MUULGsDPuLhCTJ4gXexF0eWcUW4gUELoMX2A1W8H10PfOSS5KEjS8kqKGXc5YNdFkRFBBEopQCudyc= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1789364099; c=relaxed/simple; bh=pIQ9c55KC9C1IN19GUQ06sY5K4ji/wCShUGP3NMJw+4=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=Cd0W4mdizceyB7D6tRA7sXi2+s4/+dXcDX9kYifvhfPyQrS2yz5hI0O2yW8/qWPTlLEdwHVPbPJImZbYzJlww1WTIHSSMyibrmxzaorW/VG7s36+5zomM8kGM9QmWek7ic/Odtp2wisuGbQ+Exti+P2113o6++XtqO5+FnUbQw8= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=ie/uE1ve; arc=none smtp.client-ip=209.85.216.53 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="ie/uE1ve" Received: by mail-pj1-f53.google.com with SMTP id 98e67ed59e1d1-38dfe7eb825so2524500a91.0 for ; Sun, 13 Sep 2026 22:34:57 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1789364097; x=1789968897; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to:content-type; bh=tWnHbjEBAwTuvLezoZnDfrNJHbYbnfIfEVdIgnju5lQ=; b=ie/uE1veeYdis4FZ810xJI8UPBOZlbilTNxbFvR4OGJtdsQjvs/e4Ua6MHYObh2JtO 55ui48oSZXwzWmorkQZIFFu8RyUhZUAwQvKUDM4hmeBaLVaZHAMDMSiEMa89SAAPDQ4s +4dIgpegGmJVC/YadhW/X6M8YMaWscxCOui+up2Cs2hx6cHw007973LK8Es9L/XiEhNn 7ir+r3bflWZrr666QrVPpK0zrsmPeW0VGqzzdeTNxaErz9SVvikZmP3wUGFTh/nD5PiW uf9JYZDNkjuOxKbScASVwOI6M9SlSGeioDS54H4Yx+D36Mz9RZp2DwHkWPYY6kf/30AE iHww== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1789364097; x=1789968897; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to:content-type; bh=tWnHbjEBAwTuvLezoZnDfrNJHbYbnfIfEVdIgnju5lQ=; b=nja3xuE4le34L3o3Sp0G3bomPLSOdtDBaFlKJELyhILYqOUqia8U68J+7Sd9YVD4zH X6WG2gMqcN2A825js/zexSyXeMd8jq/x+O4q8t7FGNu5wPLIya6ispydlp3FSYbWkvr+ bMnnUtIcnpdoMFJkKyXUFqSPhVNA0drwOwZs1tzE6G+ymKeJEXHeZ+vVCE4iL1GR0Lrd Gh1zXZ7itbnN5HXmWfMevR/vL70Uy3iwCX4j5rat2ocIo2eTmq8pryLLD/K8OLdmXHGi X1WgxheGGBYhSQPiMGvwEM7IE5N3ym3moIRrPatKlah/iehrFmRH/dF4ubiQuIWXa52d /Ong== X-Forwarded-Encrypted: i=1; AKwUvBwP+uUALRP9xJnJlhg8J4tkTqPYK9gR87CO+HVXkf2S43OWp7Hob3UlmDE+iM6JkYceh/I1tWTytxjUHIg=@vger.kernel.org X-Gm-Message-State: AFuF++krYRyItmP+hoFTdSgYgDZ7hH7gpz5AXuJYfFZmRoZ3GrzDpGrq CrT/JIayjOGM5vgp89w8PiSwR7hizFqZOoz2LTtw1m3B/JRk3QTRwac= X-Gm-Gg: AYBFou0YF+at8MoVWet1voZuoP4xBLG8ZsmZT19bKX8VypUHqhzudXYv0zAClV9wNrp iGtHB1cR9tuXqyb9XUHbRayMkSbcOMmPs9QzcF4Ij9kM0INZTG1rz/DsF5ND6QwIs/XL29ULm8N qT7sbOoRdgZX3r6VEKLmIkIcQpKWW8r0dHMuXo5gp/TXd97zePjzkctDoP6ux9GObJO5X9srEqZ onW0vkkT16rved8pGjQ+ehqF/jZ7XXjyuET3X7a05NO3/RFSj54d3p/F+w2OtPps4xuwtB28GC6 J6WaTgAQrUyKmtyd6LKNdkOgT/H39fW3U0p4Yvi5u/4Y+iFeA9DrS8bJ3aAD2d1DKphmodlYoUh yLqcWbIwTA83SoT5/qVT5IdETt+nlbxMzwr7O6mUg4ktRSBtusLUXs1UEun52pzRXhsBVsVAlDK HHiGEKpjSBkDC+iwRQXyNPZ6zlYCRADQ3RK93RR8deEXG8YxyVnxeidFIYqR8cyfEIHjrlYuemR d+Gq10/E/iBKbYLQYCFPCcsnzZXz0YosG779g== X-Received: by 2002:a17:90b:2b83:b0:39d:ee20:1e38 with SMTP id 98e67ed59e1d1-39dee202423mr1419155a91.20.1789364097151; Sun, 13 Sep 2026 22:34:57 -0700 (PDT) Received: from ydg-Zenbook-14-UM3406GA ([2001:2d8:7f00:8c85:3b80:bc61:4619:5346]) by smtp.gmail.com with ESMTPSA id 98e67ed59e1d1-39d994872e0sm19009261a91.8.2026.09.13.22.34.53 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 13 Sep 2026 22:34:56 -0700 (PDT) From: Donggeun Yoo To: Steven Rostedt , Masami Hiramatsu Cc: Mathieu Desnoyers , Tom Zanussi , linux-trace-kernel@vger.kernel.org, linux-kernel@vger.kernel.org, Donggeun Yoo , stable@vger.kernel.org Subject: [PATCH v3 2/4] tracing: Add the bucket size to expr_field_str() Date: Mon, 14 Sep 2026 14:34:41 +0900 Message-ID: <20260914053443.981201-3-donggeunyoo.kernel@gmail.com> X-Mailer: git-send-email 2.53.0 In-Reply-To: <20260914053443.981201-1-donggeunyoo.kernel@gmail.com> References: <20260914053443.981201-1-donggeunyoo.kernel@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" expr_field_str() renders a HIST_FIELD_FL_BUCKET field as "pid.buckets", dropping the count, and parse_field() rejects that spelling. get_hist_field_flags() returns the bare string "buckets" and keeps the count in hist_field->buckets. hist_field_print() appends it, expr_field_str() never did. Nothing reaches it today, since .buckets is refused on a value and no expression can carry one, but the next patch renders histogram keys with expr_field_str(), where a .buckets key is legal. Append the count, as hist_field_print() does. Cc: stable@vger.kernel.org Fixes: de9a48a360b7 ("tracing: Add linear buckets to histogram logic") Signed-off-by: Donggeun Yoo Assisted-by: Claude:claude-fable-5 Acked-by: Tom Zanussi --- kernel/trace/trace_events_hist.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/kernel/trace/trace_events_hist.c b/kernel/trace/trace_events_h= ist.c index a3eae5c1344a..91a550411e8a 100644 --- a/kernel/trace/trace_events_hist.c +++ b/kernel/trace/trace_events_hist.c @@ -1754,6 +1754,9 @@ static bool expr_field_str(struct hist_field *field, = struct seq_buf *s) seq_buf_printf(s, ".%s", flags_str); } =20 + if (field->buckets) + seq_buf_printf(s, "=3D%lu", field->buckets); + return !seq_buf_has_overflowed(s); } =20 --=20 2.53.0 From nobody Fri Sep 25 10:36:59 2026 Received: from mail-pj2-f13.google.com (mail-pj2-f13.google.com [74.125.227.141]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 5B44937C927 for ; Mon, 14 Sep 2026 05:35:01 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=74.125.227.141 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1789364102; cv=none; b=fX3f+LfEzjDnmcBDmDGQ+koj9+c34wkFHOVOlDoHOvYNGgEQwwH5wneBx6PdxaeuHYqJVz3Ymp+MUk3O9Aa8Iaj2s3wrI8d42VomFl+2BmAHeIBwHNqGdHliSY6l5EgrDy5icV+TM6jq2N013weE0H+8UQjpoDl5mznSc5ELOP4= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1789364102; c=relaxed/simple; bh=fs+etxGPNJdOV8jLbNvbk7g0T1Q8B3rjAqWSv5XnrxM=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=s+Zve+XW2+LyYvonxkeMI4YhMHVmmgoRFb3uuWOznbB9B+rIcMQqpeDdODum7Z713JyHAlM+xMjOJNOUtpCpCZG9GPz5jb0lKStIZBaTZBmmXHYdKMOKPq1EAcF92QTaojyN6w0GkZOfvioudv/f0jBjC/PGIJdyG4aWLpiUlKc= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=Pm/abdGB; arc=none smtp.client-ip=74.125.227.141 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="Pm/abdGB" Received: by mail-pj2-f13.google.com with SMTP id 98e67ed59e1d1-39b9184fa80so1559511a91.2 for ; Sun, 13 Sep 2026 22:35:01 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1789364101; x=1789968901; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to:content-type; bh=MjygDWKH6F7NI1Gpi2HW71UEUzq+rkDAiIqSWm+VeuE=; b=Pm/abdGBGVmmCR4O4XNowaHqS9EGK2lzvwnTXrpGZP7MWQDRZm75fhxGGV9zoEqsqE /jsFo05oB1BoIRv7llXWmLWNbhpEQMwdS30ROC/nlV78kA6iZ9V8OD5d0gH5w/EEjOwy 7LJi0ijKZcCIQCccAMD8lpOW/PRVGzJX1ABjU1dFsYWKd0JEucWszShvw/sceg3ot1fe WJ3XuVjokxX21DuzVA41TAyqtunhqqOI2lJ/S8JVmUmPWuBbuXm1y6RYkMVswkzR3L7m 6SnaZr4I2xpzW7lTv5kcpE0nKlH5M0hyE0hzBhYLqU2g1eLLZRMIP8+TqLtMdw08tuO2 Ueug== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1789364101; x=1789968901; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to:content-type; bh=MjygDWKH6F7NI1Gpi2HW71UEUzq+rkDAiIqSWm+VeuE=; b=Qg18gVwCW/Lp/EVdSlWYUQNha1oH7bHCqe8xCfiOrhjTXYDxC97dx7m2fFGxY8C09c CqaaQa1DDL3ILcPTexlZ/KU5Ivkog9o4fjone2OFXHKTWqBJBvEqSmGLQwpsRhT0vTMR S2dx/04AnnOS/f9DFbi7nkHvepZ+1ZVeD0hYvIXwZpph/fTVYacx7wGt843OukNaEkaJ 2l0unpkXgGtHv0I8rLTUPe1mia7e9WdoF6nEazbMJzqG4WKKwqF9F/BPu6J5SIngcy4S AykrFktPy4upUIrZiR/joOhNjhJ+BWNml5utn9q8UAYyYpmewiyUn45CS4MrmLcC/Yhi wXUA== X-Forwarded-Encrypted: i=1; AKwUvBzpytu5H8tTqfJe399evbtL7n8ABW8q/UOn77pPuF4b+BrLjJXlr2zcPj6y2hmt4EJ/f0Y/mSKWPQMZmrg=@vger.kernel.org X-Gm-Message-State: AFuF++lOGN27Nxeo5NO85UNg6D/imacSQpWOQ5vLAR7Qww+kntz+DvaH sYkg0I7sjKZQAUlHkZnxJie4ZxXQLHSaCsfBa1IWaumY528feexys6c= X-Gm-Gg: AYBFou3AlZ9fNMPWOSRWMkgkJtp/1aXkRlt+CC/wMMWTXgYhxMqXsH7w0hVtrT4aRFu zOKcNLnH+YsOR6ISsB6q0brKvyyTfkagNVm1/kLDCsp+/XfCSrrHCvloye8chGkCENLfid42/Pl eldRJjb+5b/eArl0B4AzxYk8G3KgdXmhMPD4wCYVwFNelxqz36+BvWhYNM20RjF20BgcFQW5jAw mfWVI4Ji8owkGf5+sa+POOrjszI0eubGtOl7wsBDT0+Drr9KF9ceeQ/iIGbknAYqrWB+Kbisgeg uYFgmRY21Ad9j4Hoc+lc+6sYRLKI4GcThYmNhsslVmAM1+r6Vq5ROAObBLud8vxOn+L55HkTeLr KOZ2WpXOhXT5yEZ/9CUj8SQKD+uE7TiAf2fDBY89tbGifTdZ8iBO6LV3D3tJwFOkA8JvJdv8v/U tIjmRo5y4PBynBc+YT6VZN4iw3VDk2g1iBeBDb4gXKr+r8ToXYKSfujnFd3hs8NqIgMzPiGipxk RQir9aIG4WrzJxAJ3bIm3qJyIIHRCIcWvSmsQ== X-Received: by 2002:a17:90b:3e4f:b0:398:9be6:f997 with SMTP id 98e67ed59e1d1-39dec0f7abamr2852464a91.22.1789364100475; Sun, 13 Sep 2026 22:35:00 -0700 (PDT) Received: from ydg-Zenbook-14-UM3406GA ([2001:2d8:7f00:8c85:3b80:bc61:4619:5346]) by smtp.gmail.com with ESMTPSA id 98e67ed59e1d1-39d994872e0sm19009261a91.8.2026.09.13.22.34.57 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 13 Sep 2026 22:35:00 -0700 (PDT) From: Donggeun Yoo To: Steven Rostedt , Masami Hiramatsu Cc: Mathieu Desnoyers , Tom Zanussi , linux-trace-kernel@vger.kernel.org, linux-kernel@vger.kernel.org, Donggeun Yoo Subject: [PATCH v3 3/4] tracing: Only report the stacktrace modifier on a real field Date: Mon, 14 Sep 2026 14:34:42 +0900 Message-ID: <20260914053443.981201-4-donggeunyoo.kernel@gmail.com> X-Mailer: git-send-email 2.53.0 In-Reply-To: <20260914053443.981201-1-donggeunyoo.kernel@gmail.com> References: <20260914053443.981201-1-donggeunyoo.kernel@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" get_hist_field_flags() returns "stacktrace" for any field carrying HIST_FIELD_FL_STACKTRACE, including the common_stacktrace pseudo-field, which has no ftrace_event_field behind it. parse_field() no longer takes the modifier there: if (stack_modifier && (!field || field->filter_type !=3D FILTER_STACKTRACE)) { hist_err(tr, HIST_ERR_BAD_FIELD_MODIFIER, errpos(field_str)); so expr_field_str() renders "common_stacktrace.stacktrace", a spelling that cannot be parsed back. Report the modifier only when there is a field to report it for. hist_field_print(), the other caller of get_hist_field_flags(), excludes HIST_FIELD_FL_STACKTRACE before it calls, so this is confined to expr_field_str(), whose only key renderer arrives in the next patch. Fixes: a5e70ba87ca8 ("tracing: Fix memory corruption from the histogram sta= cktrace modifier") Signed-off-by: Donggeun Yoo Assisted-by: Claude:claude-fable-5 Acked-by: Tom Zanussi --- kernel/trace/trace_events_hist.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/kernel/trace/trace_events_hist.c b/kernel/trace/trace_events_h= ist.c index 91a550411e8a..fdd097abb0d6 100644 --- a/kernel/trace/trace_events_hist.c +++ b/kernel/trace/trace_events_hist.c @@ -1725,7 +1725,7 @@ static const char *get_hist_field_flags(struct hist_f= ield *hist_field) flags_str =3D "percent"; else if (hist_field->flags & HIST_FIELD_FL_GRAPH) flags_str =3D "graph"; - else if (hist_field->flags & HIST_FIELD_FL_STACKTRACE) + else if (hist_field->flags & HIST_FIELD_FL_STACKTRACE && hist_field->fiel= d) flags_str =3D "stacktrace"; =20 return flags_str; --=20 2.53.0 From nobody Fri Sep 25 10:36:59 2026 Received: from mail-pg1-f170.google.com (mail-pg1-f170.google.com [209.85.215.170]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 122E437EFE2 for ; Mon, 14 Sep 2026 05:35:04 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.215.170 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1789364106; cv=none; b=FUtjmGelywFY3LJE+yLzWZlJ7+DfiDfcVyNC5bBKLC1E5a/O1limHxwHUymAXEU9zKRVbAZE/ZvL/ZtEcyTBEWJhSfbbDYyhDSbUng5P4k5e/HwiQjt+uNho60VstA+hl+Wpm4fSSkiJWMhz8mnvp3sjL3YTJmBj4eWxdXMN9NI= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1789364106; c=relaxed/simple; bh=EAtL5GAvLO8guoNp4qcczPosAY9+l1BK3hnEZ/prkhY=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=mDit43nSSrjWzBbvPDhV86x59MaDyzNcG59Du1cUNDlD/TIzvwTMV/pM9S+gNqJYtW9osWCrWM4dB8uJ76lar5DPSgxp2I5rV9u8AET8JpBtRBPyVFisBKsrQhX+/BQI8ZksmGTWAnjirJnBpQOLV5R6vmjx7Wvt0j36+R1eW7g= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=epWv7lNc; arc=none smtp.client-ip=209.85.215.170 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="epWv7lNc" Received: by mail-pg1-f170.google.com with SMTP id 41be03b00d2f7-cc4dbcf2b85so1044497a12.3 for ; Sun, 13 Sep 2026 22:35:04 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1789364104; x=1789968904; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to:content-type; bh=tQV2Lz18105+vTwI6s9YIFFfIpvfqowDaG0Sxm6VeMM=; b=epWv7lNcRNhOybE1X9TtUWaxee+0/HdIVUJ0N87AZVqMN6D5eKHVKtMWcPEWTLB/6n Db2HRmDQ4zjCEIz1hxZFw4OjoDrWKQ5Rm64DMwGdkXISZzg01kk81lkzvY6fDMj5EdDr 61Zh0SOVPOaacNsP/Fj2HaNPYAcEKRxLrtLdqK2wbh+KrbEEvqV64sbZ/mX0PHwwrHgZ k1wzwWwX9YtuTHG500JK56NbrayCGpm/eXk7YV2z06eo1L5O2YyNMoOq2DfToZVCStrK FMa8rDyZ+imuJ75qUfGIkzvD6dQBVMaSD1CiK4NU6JfecxZ6uPR+4pWNKwKkPTlQWtNh RLpw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1789364104; x=1789968904; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to:content-type; bh=tQV2Lz18105+vTwI6s9YIFFfIpvfqowDaG0Sxm6VeMM=; b=VGztegdihGwQ+BRLZEQlHcTdSvaDFsBkUU2ePZQMlsiELsJ77gwlCvi3L8RcmrZvnG EZPJ3bUfOSJ9sAbnkoWmn6FyP8lseXSrj1h/QxwWIiWwTAigYWKnJouiHiDh8wyyF+KY 8B+NxL9WEN/YqpY3LUxXlBnquCMGlO9N1juRCLHvEbfiXzON88QBilZDVyOmitY91NW+ 0Y2Vg6v6wUaSrqM1731tFfDuzU7sxu2CUnREEUyqd01iyceTSbDD1oxURCRFfQgD9mR/ QtSu49dKfAVSagR3vy40mw4an/vp0mk+PpZ8ZMUK1uBWj9+c6QaoqXxYL/blnhOWcq5+ l5CQ== X-Forwarded-Encrypted: i=1; AKwUvBxfqD3+MtFMfiGgzUIzX+B9gM+tGTc7k54ESZPx4pOUjqgHrB9rSkUHf19kgAcTfwnTzv0wXaT6qQKgBW8=@vger.kernel.org X-Gm-Message-State: AFuF++nPdSM9tAx/+0WweMZoxrTQonxviykZKI67kTJtihF5YCZluDN6 ekp1UFqL9d7orDY36M4SyiITfi+FGtoewqE04FPqlu5LaH84WTKN1u8= X-Gm-Gg: AYBFou1EeH2bkaF79vzAU2sij7ICU0en7vDc8DvNMVkvnfTlJa++gK5q0OC85smCWJh c+Swcl5FJ5lE/4bOHBfjBuo+38tyuNWJRgG9/Xkp0p2LI5Ut2GNnMtinr0/oE+mYwrkFzQEUmyR oAvwNLGtdQQAJzAsxFOCS5m4j08M1+AwYwav/9uW0FqJVWGabCxMxMwRa0/zq20sLYKVGs2aGD9 1cZ9edacFH5tddB6+uwMD4k0Iz/GswXzT8aiY3mxsahHPLKasijfdP22AOEKWtDCLt9kxjF9DqQ Teo2CxOU5W9in1mq61gOSHl5vjyobSQ8qA78SomnyM/NsvzfpFbh5kZq8k4FsdQ1y/aoE9py7rG xfB/dI+O7j4XcxdHiM7nujzPtCSELlpWM6Du7x9/Vq2i0xgaXhRKCnCeTSCciIG/SdNbiTFikON fTeymp51BZ1eLCSiGZb5wxoLOMY1QLQnD/MZq14PJ/ZqUatZDZo1isIZKzMS8AIhHIe+usj3u2G 5/K5DQhTjf30gSGuZOkR/mtcu4= X-Received: by 2002:a17:90b:4c41:b0:398:9c39:520f with SMTP id 98e67ed59e1d1-39dec05d384mr2377298a91.15.1789364104244; Sun, 13 Sep 2026 22:35:04 -0700 (PDT) Received: from ydg-Zenbook-14-UM3406GA ([2001:2d8:7f00:8c85:3b80:bc61:4619:5346]) by smtp.gmail.com with ESMTPSA id 98e67ed59e1d1-39d994872e0sm19009261a91.8.2026.09.13.22.35.00 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 13 Sep 2026 22:35:03 -0700 (PDT) From: Donggeun Yoo To: Steven Rostedt , Masami Hiramatsu Cc: Mathieu Desnoyers , Tom Zanussi , linux-trace-kernel@vger.kernel.org, linux-kernel@vger.kernel.org, Donggeun Yoo , stable@vger.kernel.org Subject: [PATCH v3 4/4] tracing: Fix NULL dereference when copying keys for a field variable Date: Mon, 14 Sep 2026 14:34:43 +0900 Message-ID: <20260914053443.981201-5-donggeunyoo.kernel@gmail.com> X-Mailer: git-send-email 2.53.0 In-Reply-To: <20260914053443.981201-1-donggeunyoo.kernel@gmail.com> References: <20260914053443.981201-1-donggeunyoo.kernel@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" In event_hist_trigger_parse() where it needs to create actions like "onmatch", it calls: event_hist_trigger_parse() { create_actions() { action_create() { trace_action_create() { trace_action_create_field_var() { create_field_var_hist() Where create_field_var_hist() does a loop on the hist_data representing the keys. The issue is, if the keys uses one of the pseudo field types (like common_cpu), the hist_data field element will have NULL for its field member causing a NULL pointer dereference when accessing the key_field->field->name. # echo 'hist:keys=3Dcommon_cpu:ts0=3Dcommon_timestamp.usecs' > \ events/sched/sched_waking/trigger # echo 'my_synth u64 lat; int prio' > synthetic_events # echo 'hist:keys=3Dcommon_cpu:wakeup_lat=3Dcommon_timestamp.usecs-$ts0:\ onmatch(sched.sched_waking).my_synth($wakeup_lat,prio)' > \ events/sched/sched_switch/trigger KASAN: null-ptr-deref in range [0x0000000000000010-0x0000000000000017] RIP: 0010:create_field_var_hist+0x771/0x1380 Call Trace: trace_action_create_field_var+0x360/0x600 trace_action_create+0x393/0xe80 event_hist_trigger_parse+0x3e47/0x69e0 trigger_process_regex+0x1a6/0x250 event_trigger_write+0xce/0x160 Instead of accessing it directly, use the proper handler expr_field_str() to get the name. The three previous patches are prerequisites: without them a .buckets key and a common_stacktrace key each render into a command that cannot be parsed back. Cc: stable@vger.kernel.org Fixes: 02205a6752f2 ("tracing: Add support for 'field variables'") Signed-off-by: Donggeun Yoo Assisted-by: Claude:claude-fable-5 Acked-by: Tom Zanussi --- kernel/trace/trace_events_hist.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/kernel/trace/trace_events_hist.c b/kernel/trace/trace_events_h= ist.c index fdd097abb0d6..11d4cf2544ac 100644 --- a/kernel/trace/trace_events_hist.c +++ b/kernel/trace/trace_events_hist.c @@ -3093,7 +3093,7 @@ create_field_var_hist(struct hist_trigger_data *targe= t_hist_data, key_field =3D hist_data->fields[i]; if (!first) seq_buf_putc(&s, ','); - seq_buf_puts(&s, key_field->field->name); + expr_field_str(key_field, &s); first =3D false; } =20 --=20 2.53.0