From nobody Fri Sep 25 11:05:59 2026 Received: from mail-pj2-f12.google.com (mail-pj2-f12.google.com [74.125.227.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 323BC233923 for ; Mon, 14 Sep 2026 01:45:54 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=74.125.227.140 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1789350355; cv=none; b=H9Z7KVjBPZNkeNhx4DDmEflM//9czjvggxVjs/MtoJ1Kxiw+8jNrBi8x3PnfW5Un0Ws6Ngw4DQkuzU3UvVkv0DZ+iWJNZkvCWrMfQSOkjQuCgXBUtx9A6XLT+flv+Inse/DPREU+0HmyIU9CXegG0hEeV36xE23GohSjF1l2GHg= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1789350355; c=relaxed/simple; bh=J8Mf3HYZaTmZYQFkYELALEytTws8uvz/goY09yFk2pM=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=NVj5vX6b2zZsgkAbysV3ncj9kmZm39/TpOfOTaOE9phe25R6WqRqWn7gdMMMGKQAvh5vZSxeZbwaa+EqfuFBNwy71j1NeQPOcyUTyMqKSw04Nej2Dq+aVUp6PbNJjX/MzsSkkP9mM8rLd2X2j4BTSmMGMtRkh++ljIS8/wcYvC0= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=oPmbjGvj; arc=none smtp.client-ip=74.125.227.140 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="oPmbjGvj" Received: by mail-pj2-f12.google.com with SMTP id 98e67ed59e1d1-39b2ad83dc6so1647431a91.0 for ; Sun, 13 Sep 2026 18:45:54 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1789350353; x=1789955153; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:sender:from:to:cc:subject:date :message-id:reply-to:content-type; bh=pGK4SZ365cD9EYRGUuPJEEEIN0V6+rF/hbiJa0/JQok=; b=oPmbjGvjZIWSY1Y8ESOZjbNHZG3ihC8JLqbxdeKQSgUhFu1ip3egUqTHrpyK2tLMiZ q5tZgNqSCrep2s/AvAzPapmIkLFAE0YUgym89hpZDewRku7fjv8pOnre5rO9klkfD2dm cVsGvaDxT+RjNqAW+vyFf8L9+lDn+DRXVVB5JWnxUQM/gzFurz85WzGdPjm34p6cOSyt cNd+ywHMzoYLqalMyvrB3JLi12QRaC3EwKXSGkqe7KpIVu9zO6tF5Lzn88g2xHXTKH9S CfJ8K6tyOuk3j1x/yGdv6Ow4cVK5A3xof+0JV3qKTPkOKSAShsKLj01M2MY6yZ1nVzK0 U1/Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1789350353; x=1789955153; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:sender:x-gm-gg :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to :content-type; bh=pGK4SZ365cD9EYRGUuPJEEEIN0V6+rF/hbiJa0/JQok=; b=b9+UCRv7QXKNXQJkniaM0u3Rs6H/SKschwvKJhPq8dupfzbPoA01HzQgUtHeJF1TAu p0atoBHSbwc65Vi/meC/sugPMTFwq6PhCeajLzQoREH8r2KhsDJCirs00+udNh88BmLG l8OMUpvw9C3cqYKKFjGsf5ugSSvPjzr5ldIKTHU157ftwr/e/lvNUadboR9hQMI4oWhU HpRBbC4uDRW1D0nkeqDtyGhrcUH/KcyvXRD/VnDxeN422oG23eG28Z9n6ILvqiIaWcHz j8A0m0+CYcU4UY2Bpa2lNUUe3JKavt07rg/THApiAevb+ZF/uupFuXfOTBlYIAQNFGrK HREg== X-Forwarded-Encrypted: i=1; AKwUvBxbqhivxv3CSZ0hFGfugGUqfwTWgjFKnntF50Qu57fCGfY13td2TTujvwdWWy+RDdO4cvLFtsVspJXjP7k=@vger.kernel.org X-Gm-Message-State: AFuF++lCUJAKdBkNeJ/ypdp/C99usj4D2S5jDqCrbDL26y2QQvrvZQnH Fz+D+sxCwwGyKAxgaKyFRpbbD8UL9jABguTnLgznQ6DcAntbpvguAB+X X-Gm-Gg: AYBFou3KWOKL5Q8GbdOp1YHQ64CaS2c0SEXKudXsH1cGgLfcSyD2LeUvoZHLihoJCOR NvvjjkiVCjf99T4RKDamR3+mn6xZPSKOi5MNOBA/96UdU4FlKVDa+xaWh6ZzYFDqJE1WYgjOnaZ yZvU3C4hWmRPAXYVW8u2QHAE/uLCzB2iiTZkPAgdvuNNuBKAhNsYN77NF3l58danPXR491wB9mT puXtBlOAjfRfvxBuruqqb/cm+En0Fa50tVSDPgjNxiIIxbEuPeV8e3poKSbDzGRK4Vl66iSw3nJ 1se2+nOW2/UPFceb8B9wfB6Jv4P7Bfvwtx7Aj/avbpj6DzDM+urOFvFoIX7/sT8iZtLywVV0tOJ RBgukzuoIqJUGsOTLP2hoqTQZiL1MpqlIhZdvNeZ7dWLDa0K7E72ZE0EkhFBxaTOM0JpC1wGs3l 7XFWSqf8AMSW3A4JAU4OvJ3gxzEsgry67hpe/SjZlOzX595Thzn3vl07L8qiGOfiaR0Bn3V2wFo viHgUYMICJ5Fng7LPp1Yc3S3T0XxUaVh/KsQ1UQxyN5olM= X-Received: by 2002:a17:90b:5343:b0:381:a766:efcb with SMTP id 98e67ed59e1d1-39debf6b420mr1107499a91.4.1789350353561; Sun, 13 Sep 2026 18:45:53 -0700 (PDT) Received: from m-upc-A520M-HDV.lan ([2400:2410:3f60:500:fd07:4a24:951e:c85]) by smtp.gmail.com with ESMTPSA id 98e67ed59e1d1-39d951d1056sm17513403a91.7.2026.09.13.18.45.48 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 13 Sep 2026 18:45:52 -0700 (PDT) Sender: Yuyang Huang From: Yuyang Huang To: Yuyang Huang Cc: Andrew Lunn , "David S. Miller" , David Ahern , Donald Hunter , Eric Dumazet , Ido Schimmel , Jacob Keller , Jakub Kicinski , Kuniyuki Iwashima , Nicolas Dichtel , Nikolaos Gkarlis , Paolo Abeni , Sabrina Dubroca , Shuah Khan , Simon Horman , Stanislav Fomichev , linux-kernel@vger.kernel.org, linux-kselftest@vger.kernel.org, netdev@vger.kernel.org Subject: [PATCH net-next v5 1/4] netlink: specs: rt-addr: fix the type of target-netnsid Date: Mon, 14 Sep 2026 10:45:36 +0900 Message-ID: <20260914014539.5015-2-sigefriedhyy@gmail.com> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20260914014539.5015-1-sigefriedhyy@gmail.com> References: <20260914014539.5015-1-sigefriedhyy@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" The kernel parses IFA_TARGET_NETNSID as NLA_S32 and rt-link.yaml declares its target-netnsid as s32, but rt-addr.yaml has it as binary. Signed-off-by: Yuyang Huang Reviewed-by: Nicolas Dichtel --- Documentation/netlink/specs/rt-addr.yaml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/Documentation/netlink/specs/rt-addr.yaml b/Documentation/netli= nk/specs/rt-addr.yaml index 0ecbd24c890c..17ead2203451 100644 --- a/Documentation/netlink/specs/rt-addr.yaml +++ b/Documentation/netlink/specs/rt-addr.yaml @@ -119,7 +119,7 @@ attribute-sets: type: u32 - name: target-netnsid - type: binary + type: s32 - name: proto type: u8 --=20 2.43.0 From nobody Fri Sep 25 11:05:59 2026 Received: from mail-pj2-f12.google.com (mail-pj2-f12.google.com [74.125.227.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 21BB8233923 for ; Mon, 14 Sep 2026 01:45:59 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=74.125.227.140 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1789350361; cv=none; b=q3hCs5nGygpKUuwPqQkGBr7mcevVgjuzOde4ydatUkfvC2ZOjiRwQmpqJplu0QMp5TsUFTc1TTcZ8NGnjCc/7rLC367Wbf1i/Zj6CpKdGT1pXOi2YGRb86MORnR4t/XTHuquAfbFOs19+8yoK9fBm27z3ef3PVPxrzxyTFD72KI= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1789350361; c=relaxed/simple; bh=u0+LHqsRMvkeRcvlOQLQGY6bbii3GrUfYb0QO4VI/wU=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=iRq7KU4zqI5e4FS3wxQ6dif0AJ129BwWOB8dPwneK2udQ+W1uhQ5XrmXM2s1pDQvK11xTwX8yUTyHGxkEcyQGxTkuE8E3M8Kjvp2xdWN5u4FBPF7YFzny2SGeLPNepj6XOPeKlLH/8JZW7MRQyJHAOkYbQO/qgL8AP6/A76vtyI= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=ie5IfHVs; arc=none smtp.client-ip=74.125.227.140 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="ie5IfHVs" Received: by mail-pj2-f12.google.com with SMTP id 98e67ed59e1d1-396ccb1a98dso1000608a91.0 for ; Sun, 13 Sep 2026 18:45:59 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1789350359; x=1789955159; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:sender:from:to:cc:subject:date :message-id:reply-to:content-type; bh=Jps47vrBc3Zp/f3MRaXWhHENFCXI5ZlVx0gprVz2+XM=; b=ie5IfHVs+kycFJT1nxXT9cS1k5Do4HuCRB3j/8td+fBHmdJOntYqxLFsHERXq7lSoU uTrVd4rCQeCL0npgTTH82s1GKRpbFVR0pNnlvShA4frmpfiLBgiQozb4ltUtgaccTzsX Syf2DgjFKbyqSEU46mVQVvkv0Gu0KU3phnKSy8EdpYSBpkqd9VlVjkwqBahtUSTqVyXa 9laQs4TMjHVlBfN9NIQeq5eiRnc3Fq5WDpJaid4ehawdZtxU4JwHWZAnj+Dgnkp4/lXD qmAWtN091ARU7anvvjkZwcBUnWhFW3nb3WR4aaL/B9NqxKisxCUdpsrbXggmCr3v3SqQ qJoQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1789350359; x=1789955159; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:sender:x-gm-gg :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to :content-type; bh=Jps47vrBc3Zp/f3MRaXWhHENFCXI5ZlVx0gprVz2+XM=; b=ADTVlv8USsf58IfCuOgoUm4NqUFnGqerLLAqkEjP8I/7sXsmbIR4eX7nxqB14lwi9J o96AMHrt8WSGTn22WNIzwcYoYn2LEWQkKEyexAQWMsrMH/2Z0h/5pmTUyBtyeMCJNzj9 85JvXpoCfsAKyB+yoJWBTCRyQSMcT88xZlUaSL3Jh8NmcfsPHLfZ6arAXrTQe6X4mqMS bgs8BlY8OdS6X04YCLW0C10RG20OX2IJjDCKVTytjioUZtLY7cKxcuQvdjSk//n74fZd JwfpAUX594rczOFouBRW7fQSPvaWuHupunn+ZhACEpvT2cBK5NabqpDaPC7zopegwIdN hhFw== X-Forwarded-Encrypted: i=1; AKwUvByk3YISooerXSVcr48K6UazhRqVbunhU2gzqGoTqICh51jcXqr+BH/z3nkUAeCKT8ZglOKSuZFpHlw0lYA=@vger.kernel.org X-Gm-Message-State: AFuF++mNZoa8kvoxLxiX//OLqg9gaPjzgouCRq6WV8IqSFpF/1yDNx42 u2XOh9O5F3OwhJkCPfozMOTDU2fOof/gMFqbgrb7a6oW1rhr3IagjyFG X-Gm-Gg: AYBFou0qJSM0kyIn11RzXqKaa8yXIQ4plwmQmon+1fYSXMnm3ENnqZeSiAo/cAWVAee dYIgND6mKS1cF/zaXa2idDO1kAyWGMjvd8L5wvVkYTW3hFp1dl7ABpwT9lyxpIWXUdCVupyIGYm OanhGljASb9HBAXKYd1kMKJoCE9Lm05d7F+poZq2DedJppw/wHaaqrFPhyugtaVKf7oxeFtSPMG fYhpIbHGioa7LwAfmt0XbsHyzKiJc/HodwPiivb80Jd57K3uVnhEAt6NCjeKlXsLHbAM4S91HIe RUpxWE4rpGa+RKZsIlN2bWTbpPs4qlVVsePQeHgRA4W+vDOAVjKbNW4l08g/nVW0hMLAjIIoKwi rU7aKmd9OkfEp/SManjYlg09o2Tx/3DeKPDVSoWUvWx3hhLmcaokw1ABAmpEbdDSZDyH0hIfMxD kFJd7BxYBRVNDBBAOpCgvlnSoGiyjjwXHXoaiulKl8wHNfe/mU/qkJm8U7KwZbFIOqrlP0s8CBQ b0KLXFOoWXn9OuJNTKOwg4241AylwQ9T+oOWTbULsbakjR4 X-Received: by 2002:a17:90b:2e84:b0:39b:2b5a:8dc5 with SMTP id 98e67ed59e1d1-39debf8a0bbmr1077890a91.6.1789350359174; Sun, 13 Sep 2026 18:45:59 -0700 (PDT) Received: from m-upc-A520M-HDV.lan ([2400:2410:3f60:500:fd07:4a24:951e:c85]) by smtp.gmail.com with ESMTPSA id 98e67ed59e1d1-39d951d1056sm17513403a91.7.2026.09.13.18.45.53 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 13 Sep 2026 18:45:58 -0700 (PDT) Sender: Yuyang Huang From: Yuyang Huang To: Yuyang Huang Cc: Andrew Lunn , "David S. Miller" , David Ahern , Donald Hunter , Eric Dumazet , Ido Schimmel , Jacob Keller , Jakub Kicinski , Kuniyuki Iwashima , Nicolas Dichtel , Nikolaos Gkarlis , Paolo Abeni , Sabrina Dubroca , Shuah Khan , Simon Horman , Stanislav Fomichev , linux-kernel@vger.kernel.org, linux-kselftest@vger.kernel.org, netdev@vger.kernel.org Subject: [PATCH net-next v5 2/4] rtnetlink: add AF_PACKET multicast dumps Date: Mon, 14 Sep 2026 10:45:37 +0900 Message-ID: <20260914014539.5015-3-sigefriedhyy@gmail.com> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20260914014539.5015-1-sigefriedhyy@gmail.com> References: <20260914014539.5015-1-sigefriedhyy@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" RTM_GETMULTICAST dumps IPv4 and IPv6 multicast group memberships, but the device multicast list (dev->mc) is only available through /proc/net/dev_mcast, so "ip maddr show" still has to parse procfs for its link-layer entries. Handle RTM_GETMULTICAST dumps with ifa_family set to AF_PACKET and report every entry of dev->mc in the existing ifaddrmsg format: - IFA_MULTICAST carries the raw link-layer address - IFA_MC_USERS carries the entry reference count - IFA_F_GLOBAL in IFA_FLAGS reports netdev_hw_addr::global_use, set by dev_mc_add_global() (SIOCADDMULTI) and dev_mc_add_excl() ("bridge fdb add ... self"), i.e. entries added explicitly rather than by a protocol join. This is the static column of /proc/net/dev_mcast - ifa_scope is RT_SCOPE_LINK This covers every column of /proc/net/dev_mcast. AF_PACKET is the family iproute2 already uses for link-layer addresses ("ip -0"). The default FDB dump also walks dev->mc, but only for Ethernet devices without an ndo_fdb_dump of their own, so bridge, vxlan or macvlan devices never show their multicast filter there, and it has no users count or global_use bit. Extending it would change "bridge fdb show" output and add NDA_* attributes. There are no legacy users of AF_PACKET requests, so they are always validated: prefixlen, flags and scope must be zero and a non-zero ifa_index restricts the dump to that device. IFA_TARGET_NETNSID selects another netns like the IPv4 and IPv6 dumps and is the only attribute accepted. The dump runs under RCU and netif_addr_lock_bh() and does not need RTNL. Signed-off-by: Yuyang Huang Reviewed-by: Nicolas Dichtel --- include/uapi/linux/if_addr.h | 1 + net/core/rtnetlink.c | 174 +++++++++++++++++++++++++++++++++++ 2 files changed, 175 insertions(+) diff --git a/include/uapi/linux/if_addr.h b/include/uapi/linux/if_addr.h index 7fb630b7fe31..0a1ad9ebb47b 100644 --- a/include/uapi/linux/if_addr.h +++ b/include/uapi/linux/if_addr.h @@ -57,6 +57,7 @@ enum { #define IFA_F_NOPREFIXROUTE 0x200 #define IFA_F_MCAUTOJOIN 0x400 #define IFA_F_STABLE_PRIVACY 0x800 +#define IFA_F_GLOBAL 0x1000 =20 struct ifa_cacheinfo { __u32 ifa_prefered; diff --git a/net/core/rtnetlink.c b/net/core/rtnetlink.c index be9d1625bac3..5f3e692a828b 100644 --- a/net/core/rtnetlink.c +++ b/net/core/rtnetlink.c @@ -4571,6 +4571,178 @@ static int rtnl_dump_all(struct sk_buff *skb, struc= t netlink_callback *cb) return skb->len ? : ret; } =20 +static int rtnl_fill_mcaddr(struct sk_buff *skb, const struct net_device *= dev, + const struct netdev_hw_addr *ha, u32 portid, + u32 seq, unsigned int flags, int netnsid) +{ + u32 ifa_flags =3D ha->global_use ? IFA_F_GLOBAL : 0; + struct ifaddrmsg *ifm; + struct nlmsghdr *nlh; + + nlh =3D nlmsg_put(skb, portid, seq, RTM_GETMULTICAST, sizeof(*ifm), + flags); + if (!nlh) + return -EMSGSIZE; + + ifm =3D nlmsg_data(nlh); + ifm->ifa_family =3D AF_PACKET; + ifm->ifa_prefixlen =3D 0; + /* ifm->ifa_flags holds 8 bits, the full value is in IFA_FLAGS */ + ifm->ifa_flags =3D (__u8)ifa_flags; + ifm->ifa_scope =3D RT_SCOPE_LINK; + ifm->ifa_index =3D dev->ifindex; + + if ((netnsid >=3D 0 && + nla_put_s32(skb, IFA_TARGET_NETNSID, netnsid)) || + nla_put(skb, IFA_MULTICAST, dev->addr_len, ha->addr) || + nla_put_u32(skb, IFA_MC_USERS, ha->refcount) || + nla_put_u32(skb, IFA_FLAGS, ifa_flags)) { + nlmsg_cancel(skb, nlh); + return -EMSGSIZE; + } + + nlmsg_end(skb, nlh); + return 0; +} + +static int rtnl_dump_mcaddr_dev(struct net_device *dev, struct sk_buff *sk= b, + struct netlink_callback *cb, int *s_addr_idx, + unsigned int flags, int netnsid) +{ + struct netdev_hw_addr *ha; + int addr_idx =3D 0; + int err =3D 0; + + netif_addr_lock_bh(dev); + netdev_for_each_mc_addr(ha, dev) { + if (addr_idx < *s_addr_idx) { + addr_idx++; + continue; + } + err =3D rtnl_fill_mcaddr(skb, dev, ha, NETLINK_CB(cb->skb).portid, + cb->nlh->nlmsg_seq, flags, netnsid); + if (err < 0) + break; + addr_idx++; + } + netif_addr_unlock_bh(dev); + + *s_addr_idx =3D err < 0 ? addr_idx : 0; + + return err; +} + +struct rtnl_mcaddr_dump_filter { + struct net *tgt_net; + netns_tracker ns_tracker; + int netnsid; + int ifindex; +}; + +static const struct nla_policy rtnl_mcaddr_dump_policy[IFA_MAX + 1] =3D { + [IFA_TARGET_NETNSID] =3D { .type =3D NLA_S32 }, +}; + +static int rtnl_valid_dump_mcaddr_req(const struct nlmsghdr *nlh, + struct sock *sk, + struct rtnl_mcaddr_dump_filter *filter, + struct netlink_ext_ack *extack) +{ + struct nlattr *tb[IFA_MAX + 1]; + struct ifaddrmsg *ifm; + int err; + + ifm =3D nlmsg_payload(nlh, sizeof(*ifm)); + if (!ifm) { + NL_SET_ERR_MSG(extack, + "Invalid header for multicast dump request"); + return -EINVAL; + } + + if (ifm->ifa_prefixlen || ifm->ifa_flags || ifm->ifa_scope) { + NL_SET_ERR_MSG(extack, + "Invalid values in multicast dump header"); + return -EINVAL; + } + + err =3D nlmsg_parse(nlh, sizeof(*ifm), tb, IFA_MAX, + rtnl_mcaddr_dump_policy, extack); + if (err < 0) + return err; + + if (tb[IFA_TARGET_NETNSID]) { + struct net *net; + + filter->netnsid =3D nla_get_s32(tb[IFA_TARGET_NETNSID]); + net =3D rtnl_get_net_ns_capable(sk, filter->netnsid); + if (IS_ERR(net)) { + NL_SET_ERR_MSG(extack, + "Invalid target network namespace id"); + return PTR_ERR(net); + } + netns_tracker_alloc(net, &filter->ns_tracker, GFP_KERNEL); + filter->tgt_net =3D net; + } + + filter->ifindex =3D ifm->ifa_index; + + return 0; +} + +static int rtnl_dump_mcaddr(struct sk_buff *skb, struct netlink_callback *= cb) +{ + struct rtnl_mcaddr_dump_filter filter =3D { + .tgt_net =3D sock_net(skb->sk), + .netnsid =3D -1, + }; + unsigned int flags =3D NLM_F_MULTI; + struct { + unsigned long ifindex; + int addr_idx; + } *ctx =3D (void *)cb->ctx; + unsigned long s_ifindex; + struct net_device *dev; + int err; + + err =3D rtnl_valid_dump_mcaddr_req(cb->nlh, skb->sk, &filter, + cb->extack); + if (err < 0) + return err; + + rcu_read_lock(); + + if (filter.ifindex) { + cb->answer_flags |=3D NLM_F_DUMP_FILTERED; + flags |=3D NLM_F_DUMP_FILTERED; + dev =3D dev_get_by_index_rcu(filter.tgt_net, filter.ifindex); + if (!dev) { + err =3D -ENODEV; + goto out; + } + err =3D rtnl_dump_mcaddr_dev(dev, skb, cb, &ctx->addr_idx, flags, + filter.netnsid); + goto out; + } + + s_ifindex =3D ctx->ifindex; + for_each_netdev_dump(filter.tgt_net, dev, ctx->ifindex) { + /* The device the dump stopped at is gone, do not skip + * entries of the next one. + */ + if (dev->ifindex !=3D s_ifindex) + ctx->addr_idx =3D 0; + err =3D rtnl_dump_mcaddr_dev(dev, skb, cb, &ctx->addr_idx, flags, + filter.netnsid); + if (err < 0) + break; + } +out: + rcu_read_unlock(); + if (filter.netnsid >=3D 0) + put_net_track(filter.tgt_net, &filter.ns_tracker); + return err; +} + struct sk_buff *rtmsg_ifinfo_build_skb(int type, struct net_device *dev, unsigned int change, u32 event, gfp_t flags, int *new_nsid, @@ -7256,6 +7428,8 @@ static const struct rtnl_msg_handler rtnetlink_rtnl_m= sg_handlers[] __initconst =3D {.msgtype =3D RTM_SETSTATS, .doit =3D rtnl_stats_set}, {.msgtype =3D RTM_NEWLINKPROP, .doit =3D rtnl_newlinkprop}, {.msgtype =3D RTM_DELLINKPROP, .doit =3D rtnl_dellinkprop}, + {.protocol =3D PF_PACKET, .msgtype =3D RTM_GETMULTICAST, + .dumpit =3D rtnl_dump_mcaddr, .flags =3D RTNL_FLAG_DUMP_UNLOCKED}, {.protocol =3D PF_BRIDGE, .msgtype =3D RTM_GETLINK, .dumpit =3D rtnl_bridge_getlink}, {.protocol =3D PF_BRIDGE, .msgtype =3D RTM_DELLINK, --=20 2.43.0 From nobody Fri Sep 25 11:05:59 2026 Received: from mail-pz2-f12.google.com (mail-pz2-f12.google.com [74.125.228.12]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id C754B2FBE1F for ; Mon, 14 Sep 2026 01:46:05 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=74.125.228.12 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1789350367; cv=none; b=NLgUqCjaYhX5wp5BJHaOLWd2O8lo2IPE2tg3sv3Wycy5SYzOGvlIMWkDQIdT9h2pfZRMw7gkZ6sHUNb1gnjNtQdzfILWuZ+7Oq5eAeTzWwVtgCA3fm58NqoH692NmL2rWnkd4Zmwz7NiOE9faZUExcz2sSBu9xPjtyD4uTlJjWU= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1789350367; c=relaxed/simple; bh=XWZSGWd0VF3BDk2Yg1A/EXE1uFX53VnoBEuepPt1BZM=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=LN/Hpfy5TX+pxh94NB8Sx55CFZrVOZvZA1EMlocuR/kTBW9LIuQSdmSRubOTNN5hOroMjpc4WKxwX0gpy69Zps+yDrsZyk+0dQNXzuiz6SBWaZjdOuimKlA9xBZ9rQToTlrr9e4KVogNFABJZ62GfyNvcOE8o17rvwHk7ZFUY4c= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=DR/bgdsP; arc=none smtp.client-ip=74.125.228.12 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="DR/bgdsP" Received: by mail-pz2-f12.google.com with SMTP id 41be03b00d2f7-cc4ae61629fso1027543a12.2 for ; Sun, 13 Sep 2026 18:46:05 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1789350365; x=1789955165; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:sender:from:to:cc:subject:date :message-id:reply-to:content-type; bh=r6q020bOQ0jwuBWM3LeSY8k8HYujoeSZlWF2NlYzVlg=; b=DR/bgdsPljUgtaFRX/bjYdAttfefBZcB7asPvpvDxFZ3heijMUWoQ16Cw5OObbBWgB KoXZUiO2G4+kPw0afcqGPKzIjQpKnz0CTmxT27DkjGbIw4XfBQ2liyHcBCxGCJDEJoWj LBL5Qh99LJmFAXb3Gm7BVfrfbE4qaTCNLXljx9y50Po6Ic5aQM9tB+FQQ8D98BDLxouO BRD1rjSepQ3EyDbHbefwfmwwyFu2Y4DpWDzZyHCiZrojTGf0FdogkGN9+mlxpq1K0hAo C4KLV4gM4NcP5CdwpZwIhVHq4jXR0v2RnAxE8dyRaGOm4ozslvXHnERq7LwdBixAJIYi hyCA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1789350365; x=1789955165; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:sender:x-gm-gg :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to :content-type; bh=r6q020bOQ0jwuBWM3LeSY8k8HYujoeSZlWF2NlYzVlg=; b=UuWWxC0QzUYIlJ7qDDgUI3SyIm9VKTahGhcSPQ3TZktMjybflBPuXVrz7D+5ZDhtW/ LcbgaBX2ORKCGL0JaP+MbRyBzzAIbXqAlYT3/gJXP54rxvqKpz7QBgwZyrQrUxKssu2P /5HZxXakvTULL3s9Z+Z8WeLPPNA84Jz1Yhp7jFZMPRI0+6W3dNF0cobteoCDKmHFlk3U jbJgAwiL7SrVjWdDoxgBShO+TBTOUJ6wBbu7cGPhKGqkpltuiRYpuQwTPmHcK6Z1sjvh Hu8csC0k6aTRd7BHIaMxOl6VvGREOMEw1AugUGckOBJYWFTtv+cEFr+uVu1t64zCI8IZ O4uw== X-Forwarded-Encrypted: i=1; AKwUvBxgkq1nkt8iCRRKDTJ1TdxNx/cjmepaByPe2/YlAJJYI8Ip4Y8qI0OgHG+MjolOu6r75gC+HLAJwdvrTFg=@vger.kernel.org X-Gm-Message-State: AFuF++lXOV/yAs+vp4+4PoZFBOzjfQwUfwxxzKlpj5ASOFfq5oVVg9b+ B09Vq62Yctf1SnpjA+sr2zuNVOQQfq19f9fnep12ff7LaaFYF/F15HoW X-Gm-Gg: AYBFou0UT46ls1o8pbuXvsekzdt19L64Aa7WF64ru0L8641Jkyk2AV4upmmavUiCDRP RzLnTdr6yVBPqms43Cm2teVOgXA96E/34XnkpxNq63eQCEvXk9vBIQ/T3y3W6bNS6Pc07WtXra4 nibl482K0HW63FHs4Y8q1GAV1L76J4MHi3Z2/D5fHN+/OE8YjngaKXzCfhS7HNmMrfjg1TAyvHf mRGjy29aE/XksKcHL3IY5QA1dSdPm6HEaAgsgMEmUXqMdTQ1VqwG4cdwIARQb/lb7MnnV9o59Bx 6w9CICvFWPbl9GVfxfmbP0DcIkIlOolEgUA5BJ+/0L/EuNYJheMWk7J+eK7GS3EzLuqba38Bzm6 kPvjo4sWWykE9gbLSHWJHWdStBbaF+hSgGaBh/kfpZJDnF6fCKut/BRugV0FjctHsvdO+DWOR27 r3zLQ9Zp5kman600M5vI5lZX7PJvsTtS2CDIZdh5tjZPUsmTpQNAIhWOFDft5IEJ1/9QGKJXOtb eMVWtfWVGTjJUjP2O7zaCeu+0wQ3oqRIDnGTdmvzP0u+v8= X-Received: by 2002:a17:90b:4f4c:b0:39d:6f12:fd47 with SMTP id 98e67ed59e1d1-39dec099eddmr1038486a91.20.1789350365102; Sun, 13 Sep 2026 18:46:05 -0700 (PDT) Received: from m-upc-A520M-HDV.lan ([2400:2410:3f60:500:fd07:4a24:951e:c85]) by smtp.gmail.com with ESMTPSA id 98e67ed59e1d1-39d951d1056sm17513403a91.7.2026.09.13.18.45.59 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 13 Sep 2026 18:46:04 -0700 (PDT) Sender: Yuyang Huang From: Yuyang Huang To: Yuyang Huang Cc: Andrew Lunn , "David S. Miller" , David Ahern , Donald Hunter , Eric Dumazet , Ido Schimmel , Jacob Keller , Jakub Kicinski , Kuniyuki Iwashima , Nicolas Dichtel , Nikolaos Gkarlis , Paolo Abeni , Sabrina Dubroca , Shuah Khan , Simon Horman , Stanislav Fomichev , linux-kernel@vger.kernel.org, linux-kselftest@vger.kernel.org, netdev@vger.kernel.org Subject: [PATCH net-next v5 3/4] netlink: specs: rt-addr: document AF_PACKET multicast dumps Date: Mon, 14 Sep 2026 10:45:38 +0900 Message-ID: <20260914014539.5015-4-sigefriedhyy@gmail.com> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20260914014539.5015-1-sigefriedhyy@gmail.com> References: <20260914014539.5015-1-sigefriedhyy@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Add the global flag, list the attributes the AF_PACKET dump uses and describe how ifa-family selects IPv4, IPv6 or link-layer output for RTM_GETMULTICAST. Signed-off-by: Yuyang Huang Reviewed-by: Nicolas Dichtel --- Documentation/netlink/specs/rt-addr.yaml | 15 +++++++++++++-- 1 file changed, 13 insertions(+), 2 deletions(-) diff --git a/Documentation/netlink/specs/rt-addr.yaml b/Documentation/netli= nk/specs/rt-addr.yaml index 17ead2203451..1a17e55d1cca 100644 --- a/Documentation/netlink/specs/rt-addr.yaml +++ b/Documentation/netlink/specs/rt-addr.yaml @@ -77,6 +77,8 @@ definitions: name: mcautojoin - name: stable-privacy + - + name: global =20 attribute-sets: - @@ -168,7 +170,13 @@ operations: attributes: *ifaddr-all - name: getmulticast - doc: Get / dump IPv4/IPv6 multicast addresses. + doc: | + Get / dump multicast addresses. ifa-family must select the address + family: AF_INET or AF_INET6 for the IP multicast groups joined on + a device, AF_PACKET for the link-layer multicast addresses in the + device filter. Link-layer entries added explicitly, e.g. with + SIOCADDMULTI or "bridge fdb add ... self", rather than by a + protocol join are reported with the global flag set. attribute-set: addr-attrs fixed-header: ifaddrmsg do: @@ -181,10 +189,13 @@ operations: - multicast - mc-users - cacheinfo + - flags + - target-netnsid dump: request: value: 58 - attributes: [] + attributes: + - target-netnsid reply: value: 58 attributes: *mcaddr-attrs --=20 2.43.0 From nobody Fri Sep 25 11:05:59 2026 Received: from mail-pj2-f13.google.com (mail-pj2-f13.google.com [74.125.227.141]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id B577B2E7396 for ; Mon, 14 Sep 2026 01:46:11 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=74.125.227.141 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1789350373; cv=none; b=qOMN1LgmBaP0NvxRMIM743WNL9ubBDT1v8XPRdVL3wkn1hE4Dh8UUELq1+67NXV1TQfBbL2s3fSs67D6AezFWP7CX/vtRwW6VQL/vOBkBCqAtvUgMY4ruu9sN3pQvGckba0ZflFdTK1DNXloQvqmukd+/nZCyqIL1HVP0fAIVis= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1789350373; c=relaxed/simple; bh=EsT+PBPEd9+QfxQSnu5BDxW9hMrBz9PT5H0Z8BMmhSg=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=tvPcVu5FoZeVJZMR1jkAlqBDSbhmjrJx2jH0mAtNZC6YmNsdttQ2/Zp9GzzKJ/a4Dw3pQ38Or+WABn4VRGDOD9T/+7mPhEu9WUyjCGxzev/4MOnFGoc+M+I5lv15GAoAMdByhkAqIenzE7LBPXjPT6Ec+D+MQ/Uvx1+NQZ1uvms= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=MqUVBmRi; arc=none smtp.client-ip=74.125.227.141 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="MqUVBmRi" Received: by mail-pj2-f13.google.com with SMTP id 98e67ed59e1d1-396ccafb751so1480696a91.2 for ; Sun, 13 Sep 2026 18:46:11 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1789350371; x=1789955171; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:sender:from:to:cc:subject:date :message-id:reply-to:content-type; bh=Iog9u3kWQAxr12SZF5gI4RQKtYZ4RbwMVa3tg5U3XlE=; b=MqUVBmRiFM9k/unPPQzVguf558ycBf5ZPymyuKaJnnld2Utona4gE2v002YkkQmezF A5zfpJo1jlC6FNbZ9q81AQ8oqvIpU1WZXZmIjFUKyFIV8kt+92Sb/sZSWnO4Cy9c2XY+ +vutF2+CaZTrr3lQnX5vbWQ1q0+qnyYH9w/AQWDouNe+qVkvyqf7VGA7mnHzhn7Zuqvl rWslY0i3tICVFEoEaYHgj5KJxllUS7CkO8ZX9EOdy69PzHkT6EoAXCn8AxVru0hDGS5D lI+2FvI2NTXONZh0x871VPid6d2tIPB/oIgmjMw2H5LiC4Z2DpKUkK8bc8VRWilfpLSf q0iA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1789350371; x=1789955171; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:sender:x-gm-gg :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to :content-type; bh=Iog9u3kWQAxr12SZF5gI4RQKtYZ4RbwMVa3tg5U3XlE=; b=IpCmXENToA27Mf3moYU9+eceZZyOjiijQ2qWHBPdtwDPWzaU8Whyc9BkK2pAxclV9k 5QwwPejwV9KRJcnkixpOswQfvtGAy27vYmt4IbknAj6BVli1opiCrsS6ZYr4mi0nq1Q+ VuSbZPAccYb1eFKVm2E7lxy8WUtCjW7wKSKcse5IhcF/u+Rr5xBF9qNC0zN/8JeK6BNE DUpg5xNs/p3mXonJkukbEjqzyrwb+v37IkHrdFou1jSuYoNPgR4A0JuOQO5wzsw+lhUO sP70c3NDHVc/61p4dTdW3sQ/Ng7T2rVRqLrJttCvJraR6/BduMnOXEPCQZ82AuJOwgGt vwsA== X-Forwarded-Encrypted: i=1; AKwUvBwExQW/Nv2cHeY6/ImJnRxo36G73kjVcL8Em/Ebzrm1CgBOHNHY8mjGxc9sYyBI1BkKWHucOE1AxNTH75I=@vger.kernel.org X-Gm-Message-State: AFuF++nqp+ZI4V1qmkUis8wLbEpiBCW43lI3FviVMbRirKK3sY85K4TY esYP5FLa6JrP3Sif0ivgGc63UR+QWU+Ra7gGE6kmA2Stnuc1plYs5AmW X-Gm-Gg: AYBFou2m/PqjohnVecNosITpyUOlADwFPI6LqwZWbS7M8AAd5WUdaxmhIjiNxYZCC1u 9VZB+Qs5KzJqYbB5FGZsnz8fsfVAWnC4QvSVgxL18AWsyP5xJnwdy0mvnNaV+zNUsIY4lZ5pACu IJj1vYXh2ROVr/C5w0UVKyhEyP0Fth6BLH7vhjzq1EKnpFtFUUpygVs/izPRBA/YLQi/Qquu+Av VCmwSw8Sti6Z6nMbN/xlfFe9u2nEw2YKU0HdObBlrJ0hIA8XgyJeW4NzSz7PFH6TrHpOIutslld dGQjMHOEdurJJIMpvt9rdf40i4eNh0g6eqJcEWnMUdNDI7GZB9Wflm2R1h84FV5UQGJEYfgrVUS AJcX/1E4FIozwTk3CQUalopQDILVF17M5umigzqHD93niGWAdj5wHoimmgNXpfQB2WEJXLSSB3b 9xcV6BTsNA+/LOQDQh4HbW3T8mCVe51KfSc/xTjeSxTFKEa8S2Zko1Fb0OHXVWZ5I5ThcCtXTu1 Bd5fjCJ9MO5Zi54I0hdtM0iQEUCdqrjN4+OCtGy31BBI88= X-Received: by 2002:a17:90b:440b:b0:39d:e784:3e1c with SMTP id 98e67ed59e1d1-39dec0f7193mr1056503a91.19.1789350370733; Sun, 13 Sep 2026 18:46:10 -0700 (PDT) Received: from m-upc-A520M-HDV.lan ([2400:2410:3f60:500:fd07:4a24:951e:c85]) by smtp.gmail.com with ESMTPSA id 98e67ed59e1d1-39d951d1056sm17513403a91.7.2026.09.13.18.46.05 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 13 Sep 2026 18:46:10 -0700 (PDT) Sender: Yuyang Huang From: Yuyang Huang To: Yuyang Huang Cc: Andrew Lunn , "David S. Miller" , David Ahern , Donald Hunter , Eric Dumazet , Ido Schimmel , Jacob Keller , Jakub Kicinski , Kuniyuki Iwashima , Nicolas Dichtel , Nikolaos Gkarlis , Paolo Abeni , Sabrina Dubroca , Shuah Khan , Simon Horman , Stanislav Fomichev , linux-kernel@vger.kernel.org, linux-kselftest@vger.kernel.org, netdev@vger.kernel.org Subject: [PATCH net-next v5 4/4] selftests: net: test AF_PACKET multicast dumps Date: Mon, 14 Sep 2026 10:45:39 +0900 Message-ID: <20260914014539.5015-5-sigefriedhyy@gmail.com> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20260914014539.5015-1-sigefriedhyy@gmail.com> References: <20260914014539.5015-1-sigefriedhyy@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Dump the link-layer multicast addresses of a dummy device and verify that ifa_index restricts the dump to that device, that the all-hosts address joined on link up is listed without IFA_F_GLOBAL, that an address added with SIOCADDMULTI is listed with IFA_F_GLOBAL and IFA_MC_USERS, and that IFA_TARGET_NETNSID dumps another netns. Skip when the kernel does not support AF_PACKET dumps. Signed-off-by: Yuyang Huang Reviewed-by: Nicolas Dichtel --- tools/testing/selftests/net/rtnetlink.py | 75 +++++++++++++++++++++++- 1 file changed, 72 insertions(+), 3 deletions(-) diff --git a/tools/testing/selftests/net/rtnetlink.py b/tools/testing/selft= ests/net/rtnetlink.py index 5cc3ebdcf08d..d69d375a2def 100755 --- a/tools/testing/selftests/net/rtnetlink.py +++ b/tools/testing/selftests/net/rtnetlink.py @@ -1,17 +1,21 @@ #!/usr/bin/env python3 # SPDX-License-Identifier: GPL-2.0 =20 +import errno import socket import struct import time from lib.py import bkg, ip, ksft_exit, ksft_run, ksft_eq, ksft_ge, ksft_tr= ue, KsftSkipEx -from lib.py import ksft_not_in, ksft_not_none -from lib.py import CmdExitFailure, NetNS, NetNSEnter, RtnlAddrFamily, Rtnl= RouteFamily +from lib.py import ksft_in, ksft_not_in, ksft_not_none +from lib.py import CmdExitFailure, NetNS, NetNSEnter, NlError, RtnlAddrFam= ily, RtnlRouteFamily from lib.py import defer =20 IPV4_ALL_HOSTS_MULTICAST =3D b'\xe0\x00\x00\x01' IPV4_TEST_MULTICAST =3D b'\xef\x01\x01\x01' IPV6_TEST_MULTICAST =3D bytes.fromhex('ff020000000000000000000000000123') +ETH_ALL_HOSTS_MULTICAST =3D bytes.fromhex('01005e000001') +ETH_TEST_MULTICAST_STR =3D '01:00:5e:01:01:01' +ETH_TEST_MULTICAST =3D bytes.fromhex(ETH_TEST_MULTICAST_STR.replace(':', '= ')) =20 =20 def _users_for(rtnl: RtnlAddrFamily, family: int, grp: bytes, ifindex: int= ): @@ -105,6 +109,70 @@ def dump_mcaddr6_check() -> None: s2.close() =20 =20 +def dump_mcaddr_l2_check() -> None: + """ + Verify link-layer multicast addresses in an AF_PACKET RTM_GETMULTICAST + dump: the ifa-index filter, mc-users, the global flag and + target-netnsid. + """ + + with NetNS() as ns, NetNSEnter(str(ns)): + for ifname in ("dummy1", "dummy2"): + ip(f"link add name {ifname} type dummy") + ip(f"link set {ifname} up") + dev_idx =3D socket.if_nametoindex("dummy1") + ip(f"maddr add {ETH_TEST_MULTICAST_STR} dev dummy1") + + rtnl =3D RtnlAddrFamily() + defer(rtnl.close) + try: + addresses =3D rtnl.getmulticast( + {"ifa-family": socket.AF_PACKET, "ifa-index": dev_idx}, + dump=3DTrue) + except NlError as e: + if e.error =3D=3D errno.EOPNOTSUPP: + raise KsftSkipEx( + "kernel does not support AF_PACKET multicast dump") + raise + + # dummy2 has entries as well, only dummy1 may be listed + ksft_eq({addr['ifa-index'] for addr in addresses}, {dev_idx}, + "AF_PACKET multicast dump ignored ifa-index filter") + + entries =3D {addr['multicast']: addr for addr in addresses} + + # Bringing an Ethernet device up joins 224.0.0.1, which maps + # to 01:00:5e:00:00:01 in the device multicast list. + all_hosts =3D entries.get(ETH_ALL_HOSTS_MULTICAST) + ksft_not_none(all_hosts, + "dummy1 does not have the all-hosts link-layer addre= ss") + if all_hosts is not None: + ksft_not_in('global', all_hosts['flags'], + "protocol entry is global") + + static =3D entries.get(ETH_TEST_MULTICAST) + ksft_not_none(static, "dummy1 does not have the SIOCADDMULTI addre= ss") + if static is not None: + ksft_eq(static['mc-users'], 1, + "unexpected mc-users for the SIOCADDMULTI address") + ksft_in('global', static['flags'], + "SIOCADDMULTI entry is not global") + + # target-netnsid dumps another netns, ifa-index is relative to it + with NetNS() as peer: + ip(f"netns set {peer} 5") + ip("link add name dummy3 type dummy", ns=3Dpeer) + ip("link set dummy3 up", ns=3Dpeer) + peer_idx =3D ip("link show dummy3", json=3DTrue, ns=3Dpeer)[0]= ['ifindex'] + + addresses =3D rtnl.getmulticast( + {"ifa-family": socket.AF_PACKET, "target-netnsid": 5, + "ifa-index": peer_idx}, dump=3DTrue) + ksft_eq({(addr['ifa-index'], addr['target-netnsid']) + for addr in addresses}, {(peer_idx, 5)}, + "target-netnsid did not dump the peer netns") + + def ipv4_devconf_notify() -> None: """ Configure an interface and set ipv4-devconf values through netlink @@ -315,7 +383,8 @@ def ipv6_route_del_reason_absent() -> None: =20 =20 def main() -> None: - ksft_run([dump_mcaddr_check, dump_mcaddr6_check, ipv4_devconf_notify, + ksft_run([dump_mcaddr_check, dump_mcaddr6_check, dump_mcaddr_l2_check, + ipv4_devconf_notify, ipv6_route_del_reason_expired, ipv6_route_del_reason_ra_withdrawn, ipv6_route_del_reason_absent]) --=20 2.43.0