From nobody Fri Sep 25 08:47:13 2026 Received: from mx0b-0031df01.pphosted.com (mx0b-0031df01.pphosted.com [205.220.180.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id C04E143B3E5 for ; Tue, 15 Sep 2026 05:41:10 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.180.131 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1789450872; cv=none; b=bCtERp+N6hX91p3LgfqyBpHVpHsVvYZDn6Xcwg9eWEFx8b3GnnzBveqmZXlDW0WpQ7v/1DDTBR9OAkhLSIIv/VQXsYWcgelL7zrVsHEut2uWUVbW/yzwo4zH33cvbAPYgwxFP2fFMO37SvYaWy9iAP2Q0wreDwSzh3witFs/BBY= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1789450872; c=relaxed/simple; bh=PhAMGANz7MkUBW5ysjeXPGKUMHHQxXQzswMnWBzcuwQ=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=exhTVacPe8ed3sV5PPLv6xVsu94fGAx/VNxmYfdiMqSVYxQD96uh/UU66QLT3jYO3NuXeHzHYbYM37XF+74NvagasDVXON9I0Fd84VD7cf2nzL2E/5ufFQHzboTzHPLKxRTztjWHJceohJnI9yFD5HckvctVC4zDSG58Kqr5RZ0= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=O25HQT07; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=V5oYilCp; arc=none smtp.client-ip=205.220.180.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="O25HQT07"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="V5oYilCp" Received: from pps.filterd (m0279872.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 68F4u3nl2032076 for ; Tue, 15 Sep 2026 05:41:09 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= demnwsDRacp7YkAOkxM3KDcVI0hv/Hsw5qIhskdy3c8=; b=O25HQT07wIjDAb5a HETERkQbDPKgib2Tm9AYKFm1FvPDPE2SKNbebTUk/PMCszclmQu8cyYfWEYKI9Rp 9B1Jaw3WMpOwQ3CQBmuPyFFJR/THy63LlWfsyJ2vnfmcjuflaDQBflc3dt5UEstg nqQkjAjDSbpLfF7bJL3AZ2nZwxY2h+8tV79MQInFp4jcK/NjwVLVb+uRDqo6HzOQ gB9V2HpKnrXnUlWVogzTPzBhyxGrNsgrGdE/cvVjOWLDuxU8ooNc4IM/mOz0qSEq LbiadTeN+6bfgXcEgIiQhXeuIo0ZbYi/wJRUwDeYCftH5OCu2ylMGB8F30nK6Vo1 ZC7xIQ== Received: from mail-pj1-f70.google.com (mail-pj1-f70.google.com [209.85.216.70]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4gpye704n6-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Tue, 15 Sep 2026 05:41:09 +0000 (GMT) Received: by mail-pj1-f70.google.com with SMTP id 98e67ed59e1d1-399271df9d8so1015907a91.2 for ; Mon, 14 Sep 2026 22:41:09 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1789450868; x=1790055668; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :content-type:mime-version:subject:date:from:from:to:cc:subject:date :message-id:reply-to:content-type; bh=demnwsDRacp7YkAOkxM3KDcVI0hv/Hsw5qIhskdy3c8=; b=V5oYilCp3zOuz0NjWX9z7uP0XaQSmRXxjGPIaMH2NQJIupD7OnGXKZpxz+tj0mfPLo 4+6COVgr1Q8L8PgXxNVMb4/28cKF3WpPBXo0GwXPj3ktWqBgQPtIjuXTzqmUHVOzZsVx Hs4rLXR9b0dBQMuQdTCN47Ksg29YdeIncjQpHgnpJL2lko6Ro4WGnWM8KqAf5JoEx3k/ d+1R0nxU10rF6JzxpiAxfizbKhqypOLa3jD/dfTTSHUJtK40PKCPHlifcGYDF2vC3F20 GnS1l5LdUBuOOp1iDW3lq0xItVvHk2U6bhtWi7fEEveQHUH+wJgUwedoweI6/gzpfT9c DqGQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20260707; t=1789450868; x=1790055668; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :content-type:mime-version:subject:date:from:x-gm-gg :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to :content-type; bh=demnwsDRacp7YkAOkxM3KDcVI0hv/Hsw5qIhskdy3c8=; b=sbb6E+L8jcGUyrXj810yjtZIqb+IVQhWZncxmTK70nZDpW+1YwEGsEerxVRYS0HX7F 6CbaUAzVqgzpF+BOV/D9PQRwq3Wh3FViVCpzNTo6O2sUG0pC+NswrBMSmWFnStsdQjBs EajFox140un/2MY/sDkvBn2PnLt8X2Ex3zRMGZOBBt3coh1qPiYLHAPEjJPZjJZq6F5P Bf29eTNcKkn4XYwYmYudejOu4RVj/z0tYV5C2X3PyS8UVlgp1N+TpIogRsajNQ69NiWx ZyN5GBHokmeYe8G6Uw3aHT+gb753w8DTPCksNHFsSnZ0Kd7S6NVIy52yoKOMtrAyQDCE sNSg== X-Forwarded-Encrypted: i=1; AKwUvBwWQlpolJdY8qXKwzfyVLJDZ7h4L9Gr4E8wA5loSPfGuVMYq/Bwx9UVl9wXJu5Cy+CZiNkMVM6u/vIhX9U=@vger.kernel.org X-Gm-Message-State: AFuF++kyOgF2UyiZ0GdMxYmykvJXtWESEC8EsgTyXjdgcnTAiPH4bkov iAVTv4rpn2IW5qMobokPwzg5iNHt4PxHzLfXLe+5gdbEkCdPzNINi6VINaHkZvwCIHD6ITqe0ON PpMaaaSOX2ewt2UsiBgOJuYCeIc+6+5PSLeM6T6O7FIwN3IrXT5QSLZT9TCYkJgdhmOc= X-Gm-Gg: AYBFou2xfGw+SXhxd8HGLaa6ZPjpX1TgY3Md8D0FGHuvnLJlhl6LgOa98UdzvJpMEGV TMAcZONWEGjA8siqe9I4/DImbL3WZY8gwqKnqtB3CFxc9EhuDW4xEUeZwycjcOrWq1qFwc06s+t e1Jy+GGBxlr7s+3/1m0dl5R7wSGJQJJkKagiZTBp414u5fkT8z8fzzDHv5U+NJY462h4yZLelr6 r8oVYhsC8/VWddtmh5VFka/pUkXu3J1vIt0sRWHUbUPWuM+vu2hgF/3KOxjc+9HdsXn9g0f/NCz VBYGnc98AWBsOOF/+YTa+q+6c1plDy+oUaPBmI1nOqMmbSv0ue4d99mvR5wn3OZYSvzWmBwcsIL 4CPdQ9ATTGaPavMoujr+PfIPXRm2qSyrWLLwqvcAHm3CvT30= X-Received: by 2002:a17:90b:2709:b0:39d:fcef:e241 with SMTP id 98e67ed59e1d1-39dfcefe940mr4015315a91.2.1789450868534; Mon, 14 Sep 2026 22:41:08 -0700 (PDT) X-Received: by 2002:a17:90b:2709:b0:39d:fcef:e241 with SMTP id 98e67ed59e1d1-39dfcefe940mr4015282a91.2.1789450868135; Mon, 14 Sep 2026 22:41:08 -0700 (PDT) Received: from hu-zijuhu-lv.qualcomm.com (Global_NAT1.qualcomm.com. [129.46.96.20]) by smtp.gmail.com with ESMTPSA id a92af1059eb24-14390c0be29sm1589960c88.9.2026.09.14.22.41.07 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 14 Sep 2026 22:41:07 -0700 (PDT) From: Zijun Hu Date: Mon, 14 Sep 2026 22:40:51 -0700 Subject: [PATCH v2 1/2] Bluetooth: btnxpuart: Simplify nxp_recv_acl_pkt() by hci_acl_handle() Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20260914-misc_fix-v2-1-6178d838c946@oss.qualcomm.com> References: <20260914-misc_fix-v2-0-6178d838c946@oss.qualcomm.com> In-Reply-To: <20260914-misc_fix-v2-0-6178d838c946@oss.qualcomm.com> To: Amitkumar Karwar , Neeraj Kale , Marcel Holtmann , Luiz Augusto von Dentz Cc: Zijun Hu , linux-bluetooth@vger.kernel.org, linux-kernel@vger.kernel.org, Luiz Augusto von Dentz , Zijun Hu X-Mailer: b4 0.15.2 X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwOTE1MDA3OSBTYWx0ZWRfX4R/QZBQA1uKS IotlIf0c6Luydn3Cu086wPsi6N+/ctTldubGuNKEsds+3mYR+l8XS5fJBToZSmiGn5oYEbG675t qmqELz6cLJBc4vm3DdlUVbrrfGyzr8ubVbkJbmju2c6k7TjsDROh0pyP42721w/G7Dz4EL93Eif 6EZ8oJgeZIbL4hFfZRZBjgEyysJxuQyPdODUp6rUiFsJVuGQlXod0+QmYgrT4DC7ott7ICN2avB VwgU6VmDs+hOB9JLU16JZ00xdJ+WUwAH5JJwu37mekhA9VAfa9/sG/zri80+0Rec5DN54lgI4T6 yGGrSSdjrohNkcxhj/Vjao4XdYem0meitOHNRP26t//DwbFkifZ92zfYF+c1U+vSzIJziMHmnkk LjFXGrg2pMj1SoKPETaQ6Y5S9ZykRrbgT5YT88XHitIY2RqZxdKZ0ynnLRXDXsoNB9gyihbUYEd tHMekd1fGDnfMCKJvmQ== X-Proofpoint-GUID: SJ6LLrmNb6p-LE5CV_Tzaesrxhfl1uLe X-Proofpoint-Spam-Info: AW1haW4tMjYwOTE1MDA3OSBTYWx0ZWRfX4PGFtRKiD4Kk 9+wWdxBwMlyI/wDfZC/MsSr8uFdRwzPSzGExEwgmGRSc3xunkaE0XuscxdYgw8qXaycOkPLI/Zv OIZKgnwZmd59pPpr9dbF5nNaGT2J+0Y= X-Authority-Analysis: v=2.4 cv=fck4WEQF c=1 sm=1 tr=0 ts=6aa8da75 cx=c_pps a=0uOsjrqzRL749jD1oC5vDA==:117 a=ouPCqIW2jiPt+lZRy3xVPw==:17 a=IkcTkHD0fZMA:10 a=VdqzKS8jKosA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=yx91gb_oNiZeI1HMLzn7:22 a=EUspDBNiAAAA:8 a=k-9T60deko6e8epjNngA:9 a=QEXdDO2ut3YA:10 a=mQ_c8vxmzFEMiUWkPHU9:22 X-Proofpoint-ORIG-GUID: SJ6LLrmNb6p-LE5CV_Tzaesrxhfl1uLe X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1176,Hydra:6.1.134,FMLib:17.12.100.49 definitions=2026-09-15_01,2026-09-14_02,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 impostorscore=0 suspectscore=0 bulkscore=0 malwarescore=0 phishscore=0 spamscore=0 lowpriorityscore=0 adultscore=0 clxscore=1015 priorityscore=1501 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2609040000 definitions=main-2609150079 Simplify nxp_recv_acl_pkt() by using hci_acl_handle() instead of: __u16 handle =3D __le16_to_cpu(hci_acl_hdr(skb)->handle); ... (handle & 0x0FFF) ... Signed-off-by: Zijun Hu --- drivers/bluetooth/btnxpuart.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/drivers/bluetooth/btnxpuart.c b/drivers/bluetooth/btnxpuart.c index f2bbe6e462aa..69e897444112 100644 --- a/drivers/bluetooth/btnxpuart.c +++ b/drivers/bluetooth/btnxpuart.c @@ -1400,20 +1400,18 @@ static int nxp_process_fw_dump(struct hci_dev *hdev= , struct sk_buff *skb) =20 free_skb: kfree_skb(skb); return 0; } =20 static int nxp_recv_acl_pkt(struct hci_dev *hdev, struct sk_buff *skb) { - __u16 handle =3D __le16_to_cpu(hci_acl_hdr(skb)->handle); - /* FW dump chunks are ACL packets with conn handle 0xfff */ - if ((handle & 0x0FFF) =3D=3D 0xFFF) + if (hci_acl_handle(skb) =3D=3D 0xFFF) return nxp_process_fw_dump(hdev, skb); else return hci_recv_frame(hdev, skb); } =20 static int nxp_set_bdaddr(struct hci_dev *hdev, const bdaddr_t *bdaddr) { union nxp_set_bd_addr_payload pcmd; --=20 2.34.1 From nobody Fri Sep 25 08:47:13 2026 Received: from mx0a-0031df01.pphosted.com (mx0a-0031df01.pphosted.com [205.220.168.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 739C943DEC2 for ; Tue, 15 Sep 2026 05:41:11 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.168.131 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1789450872; cv=none; b=lX3Q3PXcKcFGvJwtQ8phNdHEhHnZmxD5WXtimy75Jd4fHU6JR5FUvRYiRdmOYv28uaMhITG1JflaIMTx8vYvOvP9D3Yr+jaM5Hks/tythNNdLKghBola7rBJQp24kMdecv4k8XyUygDJWn4mU9yD8JsE1P8vchaz6syOEPMypQo= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1789450872; c=relaxed/simple; bh=Hd3h8KPjaxfbpke901lpJ+9XzRU8B7Mv4K1p6Nk11uQ=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=mqJlZn4fy4/9XmL5VhFORgi66gQv0cMsNxm6aCuVSbbC1jGSJQD/gt4Eyu5vWo/2KYPMiu9dBIyaL2d9FQqoA0BziY7nGRPQ4M8ocZwLIO2qiiqU7LVRsFJJtEYLBdRtSYGoGPjqoXSzh2dU7dMJGCUdsehgHzj6ukezkDp1BME= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=OXcFcsVj; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=HK3c4lTw; arc=none smtp.client-ip=205.220.168.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="OXcFcsVj"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="HK3c4lTw" Received: from pps.filterd (m0279864.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 68F2nWHW1170366 for ; Tue, 15 Sep 2026 05:41:10 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= sHGp4VACy/9bz2acd/gwrvXj8b44/OpCnLoTqNtuD0U=; b=OXcFcsVjq9hpKEAg lm+Y5zg/MRW0XA2sI4RiAGQV2jrQtErfpBEVW563AD6P17g+xKaddbAkt6pqd5Dy /JMg/rLQhJMThAgbShtGJUDFiFcZyxBquLhXtcYd1a0AP095G7Ry5DKG/g9q4U/R BKK7TpWuMRb6BwWryBz6PMawSsqB43LjeUxykcm8j3PmP539SgkczD+sSxAqgEJa Cc+qAE+m0ij1lIR2ev5N6B/hnL0ojfA9OYiklUMn0xFs6O/b9S92ufFu4OIi4OYJ CKMYTqnaI7OiZZ5FEGaj7jvx3PJ+SsiTbqRBxAN96m7lOtC4e3AiIWSeWfD1HHeO h/WpAQ== Received: from mail-pj1-f69.google.com (mail-pj1-f69.google.com [209.85.216.69]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4gpergc3q2-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Tue, 15 Sep 2026 05:41:10 +0000 (GMT) Received: by mail-pj1-f69.google.com with SMTP id 98e67ed59e1d1-39af306c795so996264a91.3 for ; Mon, 14 Sep 2026 22:41:10 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1789450870; x=1790055670; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :content-type:mime-version:subject:date:from:from:to:cc:subject:date :message-id:reply-to:content-type; bh=sHGp4VACy/9bz2acd/gwrvXj8b44/OpCnLoTqNtuD0U=; b=HK3c4lTwHkqVDy37ucfOFLCqKqUSLEVuAnq0aJQM1fpiU+tFIfImhpQDqOYmFl/aNv +ozS51wAgxtma/shdcvw9ayAEkNHpWQMkkT4hM8WjhzHrlkD2PjWsTvgs47Z6kJDAnHU EMArRbc0UE3DRC2S1v6riufi3+BkmfKQ1THijtQNzyV9A+6qWzrkgJNcEpNnrkxD3d79 tQZwdOn2piy0oAyazSsND3r1geDYHBNP1OX5JHL41Zc7ktstOg1F+3GspSNQhrRU9RlK 0+KGuUIWST6+WkakfOtEZfsq7sgnTYDi8dDA7iiClenm1UEXzdoHx/GdIGO8KDcHtqvQ jhAg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20260707; t=1789450870; x=1790055670; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :content-type:mime-version:subject:date:from:x-gm-gg :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to :content-type; bh=sHGp4VACy/9bz2acd/gwrvXj8b44/OpCnLoTqNtuD0U=; b=dMMEyGxmuQPNfqcjrZt4ccOOkGbTxSJUA3x2/j5sXUPpUH8kxSuZDjzpPXcpQj2PaA u+Bx2EPlzDM3kguq8K4lYoh6eH3Nmm6x4/gutGOXgzMDoiu1XnBSDyDlZ+ZWRTtvjLd8 m9i/MygvK0s7ESC6sDL+JwTbu84n+oG9cG4/gQcQorKQZJeKcHgy7eAvbcqt1g8v0iyK vMxBBilTw2m9HV3OYSfIKfKOkMPyw1/Y93ihLuf1aZWnh4o37jZSQaV0wo8/dqwn1rzY jpQq5ohmMgE1cbvMPJfcT/vkr3ZwakvzSaRHx/mhliPu/ERNpGkGwqrC9T7F9oWp0ui3 4NaQ== X-Forwarded-Encrypted: i=1; AKwUvByKX8Ah4+4l0TRuqeHJPsj21rhRxYqg8Dge/I83QPtOMRxC9IwmtYS9Iyyvu/LcAPpIq1Kaa47aXfpe3nE=@vger.kernel.org X-Gm-Message-State: AFuF++kxhoMHSMVAMlVTkpi+QwjSs2XXxAv/D6S3pgvkD7Y09EVVolOV I4Jq7LfhFdlogpxQGoRzVuQ/nM8Dzd4WbKf45W0Qk16hqZ0y0eb0ivvyDKOkvAWzpn1ePiWfTla 6PpuO3sZ4uaNfPv2XXrLvezya5h5+tLnL0QOl2Ydfd0+cZMiCq6iRhiGrupyC+FAzzVncO/bNpX N6V0XS X-Gm-Gg: AYBFou3wgUZYH2k7BJ26+ZWasiITFpsrbfyrDnVO+JRnHHE5Lh5wjikEw/6SQnZdUnu ynxCeT8U2H9Bghc7jOTMh8DGFd4LJE9dHT9vyL/7vPFTeWutZHBSTpEClPb1e8kH3yv2kj1q0qA jjO2Zs0o3bDa0eZTDoy5tcrgJ55ACtixm9w0s9xcvHaqR6Rd/QgWVJI+HnoeJpiz86L1NC7gDZy 5laRkvuFgNERFqal3/HC+J3RODaSSIjtHmNHDhDgJSIAdqvRwNa14yB50+JGXW4qOXEgQ03C5mE CASguI6T5VZ9Ve1Ty0o+SfHBGC3HtUxhRBBol+3gA49OxtUGpP/4DjWv8N/Eq0bnFKTTNkDfNVy hcpVodQYYI0gAclpxGpfe1Xra4Vo8NDIEdyStJhufKx1dHFU= X-Received: by 2002:a17:90a:1690:b0:39d:f137:db60 with SMTP id 98e67ed59e1d1-39df137dd30mr4614818a91.0.1789450869793; Mon, 14 Sep 2026 22:41:09 -0700 (PDT) X-Received: by 2002:a17:90a:1690:b0:39d:f137:db60 with SMTP id 98e67ed59e1d1-39df137dd30mr4614784a91.0.1789450869337; Mon, 14 Sep 2026 22:41:09 -0700 (PDT) Received: from hu-zijuhu-lv.qualcomm.com (Global_NAT1.qualcomm.com. [129.46.96.20]) by smtp.gmail.com with ESMTPSA id a92af1059eb24-14390c0be29sm1589960c88.9.2026.09.14.22.41.08 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 14 Sep 2026 22:41:08 -0700 (PDT) From: Zijun Hu Date: Mon, 14 Sep 2026 22:40:52 -0700 Subject: [PATCH v2 2/2] Bluetooth: btnxpuart: Fix skb leak in nxp_process_fw_dump() Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20260914-misc_fix-v2-2-6178d838c946@oss.qualcomm.com> References: <20260914-misc_fix-v2-0-6178d838c946@oss.qualcomm.com> In-Reply-To: <20260914-misc_fix-v2-0-6178d838c946@oss.qualcomm.com> To: Amitkumar Karwar , Neeraj Kale , Marcel Holtmann , Luiz Augusto von Dentz Cc: Zijun Hu , linux-bluetooth@vger.kernel.org, linux-kernel@vger.kernel.org, Luiz Augusto von Dentz , Zijun Hu X-Mailer: b4 0.15.2 X-Authority-Analysis: v=2.4 cv=QK/91QLL c=1 sm=1 tr=0 ts=6aa8da76 cx=c_pps a=vVfyC5vLCtgYJKYeQD43oA==:117 a=ouPCqIW2jiPt+lZRy3xVPw==:17 a=IkcTkHD0fZMA:10 a=VdqzKS8jKosA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=DJpcGTmdVt4CTyJn9g5Z:22 a=EUspDBNiAAAA:8 a=ts5nViFRsRHbD-iAU4sA:9 a=QEXdDO2ut3YA:10 a=rl5im9kqc5Lf4LNbBjHf:22 X-Proofpoint-GUID: AdhDagsCkT0uH-pL1jYuxKM3sIizEHpw X-Proofpoint-ORIG-GUID: AdhDagsCkT0uH-pL1jYuxKM3sIizEHpw X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwOTE1MDA3OSBTYWx0ZWRfX88R8Ds+ruQZf GvDZmjvdYboYS0q5nGsHyZ9qoFDRvz/vVAdi2Y0oNpmWludDgRNUoIo0oJabPDop0kHiTbuWEeu HJh8vMllnSQuQbk8DeR0uPBEnv1X5grsoXUgbGJgtflvoirpXeIuyM0O4P5kgEfGbRVf20Qos2h cm7Vz5WauyyRDQYlPbRULdo1H/W7Orp473ICAq0gjf7QMlRoxv9gqMfl3fFNh4dIL9H8YuIVpsN pahnz7MYR9DM5e2foLB+eQiZ1HIgBtlBcP0CuP4QCatM3g1w8tBJ3y8xqFo68bVz3ASo/N9YWiQ 7oRNpAkC4NXnVOePzP2SEJX0uVnvcBe4HSGiQBm08EGqbbUU/tT7WD2gonDjQprPZXTTx716N6d l4QSBlsNcTYJmMoKZbjcxWxbMoeodhSR58CDWSA4r8aSGcb8RKoGtiB1BAsFgChcdr0HuG0Al7U d2JBOMbAs+GmX4CVJPg== X-Proofpoint-Spam-Info: AW1haW4tMjYwOTE1MDA3OSBTYWx0ZWRfX5yHyYCPBAgsw gz4qjGf6caNnX0vrohQEBEdXbDdtG61Pb3czV5oG8jsiDgnJMewghry4qFfE6vtt+jt9fNyEtZ+ Gu0hVx3FvBzP2i19O+vnLNBuDdurH7Q= X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1176,Hydra:6.1.134,FMLib:17.12.100.49 definitions=2026-09-15_01,2026-09-14_02,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 phishscore=0 malwarescore=0 suspectscore=0 lowpriorityscore=0 priorityscore=1501 spamscore=0 adultscore=0 bulkscore=0 clxscore=1015 impostorscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2609040000 definitions=main-2609150079 When CONFIG_DEV_COREDUMP=3Dn, hci_devcd_append() returns -EOPNOTSUPP without freeing its skb argument. This leaks the cloned skb and also prevents nxp_set_ind_reset() from being called to perform recovery. Fix by guarding hci_devcd_append(hdev, skb_clone(skb, GFP_ATOMIC)) with CONFIG_DEV_COREDUMP. Fixes: 998e447f443f ("Bluetooth: btnxpuart: Add support for HCI coredump fe= ature") Signed-off-by: Zijun Hu --- drivers/bluetooth/btnxpuart.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/drivers/bluetooth/btnxpuart.c b/drivers/bluetooth/btnxpuart.c index 69e897444112..a0b64fdcbcc1 100644 --- a/drivers/bluetooth/btnxpuart.c +++ b/drivers/bluetooth/btnxpuart.c @@ -1383,19 +1383,21 @@ static int nxp_process_fw_dump(struct hci_dev *hdev= , struct sk_buff *skb) err =3D hci_devcd_init(hdev, NXP_FW_DUMP_SIZE); if (err < 0) goto free_skb; =20 schedule_delayed_work(&hdev->dump.dump_timeout, msecs_to_jiffies(20000)); } =20 +#ifdef CONFIG_DEV_COREDUMP err =3D hci_devcd_append(hdev, skb_clone(skb, GFP_ATOMIC)); if (err < 0) goto free_skb; +#endif =20 if (buf_len =3D=3D 0) { bt_dev_warn(hdev, "=3D=3D=3D=3D FW dump complete =3D=3D=3D"); hci_devcd_complete(hdev); nxp_set_ind_reset(hdev, NULL); } =20 free_skb: --=20 2.34.1