From nobody Fri Sep 25 10:05:06 2026 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 094C5476041 for ; Mon, 14 Sep 2026 13:05:37 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=170.10.129.124 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1789391139; cv=none; b=UiSEXAEOEwaHwdYX/zdhxUI8GzlmFjf/JGcBQW4Ax19MOMSYF+VAFMRB2xPEd7b94c/QcefWg5YeqOioykKt/h7SEH/P/WNx0g/B16So7H/zNWu3ACfmzT40lJkTpIpeHkErjUes2wJIdhhr92lU5I/q/usJYkB8Nn93Yz/w6fg= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1789391139; c=relaxed/simple; bh=q5o+CKn0Co/R2u4gXcpA7aZ6Z7WqyCo44To0XEIGF3E=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:To:Cc; b=aRs3LUVTFIlZtyGiv8XivAwGz18PGfKu1liw3fqtWYM1p5HRNrBKWU9p0IirzQQFu5mxeHiuJZauXOK/ATz4d3F/wYDx+UW2M9NOZet/E6bWbk++eRuwnEwyJUpoVpjojxs+VRIi3X9qmMzCFT+MbDKXTKrBW7vBggTbmxLOFvg= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com; spf=pass smtp.mailfrom=redhat.com; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b=O/66uSa6; arc=none smtp.client-ip=170.10.129.124 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=redhat.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="O/66uSa6" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1789391136; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=IIrbGOfIQRouXedn+IFe+NVdpQt1cwK8/ve6LQAjMBQ=; b=O/66uSa6uvvM3oivI1M6pxBpCAbuTQPT/R9Xr/GPRjyCtQ+96ogwaVCdPwRru0GK8d6C83 LMDYBt15pueHdSGvX+ozSOXBkp5pJAZ4g8RGOVBm+nIUdUPVQ3xKb9BQnLLY5wM3QtHP09 Tu+1OmPJeEk04behp3sB6q/PCmC6efw= Received: from mx-prod-mc-01.mail-002.prod.us-west-2.aws.redhat.com (ec2-54-186-198-63.us-west-2.compute.amazonaws.com [54.186.198.63]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-349-v8tbygsCPh-78Yel-q_hfQ-1; Mon, 14 Sep 2026 09:05:32 -0400 X-MC-Unique: v8tbygsCPh-78Yel-q_hfQ-1 X-Mimecast-MFC-AGG-ID: v8tbygsCPh-78Yel-q_hfQ_1789391129 Received: from mx-prod-int-06.mail-002.prod.us-west-2.aws.redhat.com (mx-prod-int-06.mail-002.prod.us-west-2.aws.redhat.com [10.30.177.93]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mx-prod-mc-01.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id E27241955F21; Mon, 14 Sep 2026 13:05:28 +0000 (UTC) Received: from aesteve-thinkpadp1gen8.rmtes.csb (headnet05.pony-001.prod.iad2.dc.redhat.com [10.2.32.117]) by mx-prod-int-06.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id B1325180056E; Mon, 14 Sep 2026 13:05:26 +0000 (UTC) From: Albert Esteve Date: Mon, 14 Sep 2026 15:05:19 +0200 Subject: [PATCH] ath10k: clear QMI if failed during init Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20260914-fix-ath10k-dangling-v1-1-15c5089682b1@redhat.com> X-B4-Tracking: v=1; b=H4sIAAAAAAAC/x2MQQqAMAwEvyI5G2iLtuhXxIPaaINSpRURxL8bP A47Ow9kSkwZ2uKBRBdn3qOALguYwhAXQvbCYJSxqtEVznzjcAatVvSybxwX1LV11lfGTeMI8jw SifZXu/59P0FKLW1lAAAA X-Change-ID: 20260914-fix-ath10k-dangling-15676d427cbb To: Jeff Johnson , Kalle Valo , Bjorn Andersson , Govind Singh , Brian Norris , Niklas Cassel Cc: linux-wireless@vger.kernel.org, ath10k@lists.infradead.org, linux-kernel@vger.kernel.org, Albert Esteve X-Developer-Signature: v=1; a=ed25519-sha256; t=1789391126; l=928; i=aesteve@redhat.com; s=20260827; h=from:subject:message-id; bh=q5o+CKn0Co/R2u4gXcpA7aZ6Z7WqyCo44To0XEIGF3E=; b=FllOoEx11IsQvIExPmEjc7zvCB6JpPPqftbJxleq4hs7bjcJpONSe3ItkwpiRa8GzlfV6YUZP pudK/qMvdQqD9SIS5BBH9KG+C+0GFb2O/eUwRnriEebFaJVq7f7pazd X-Developer-Key: i=aesteve@redhat.com; a=ed25519; pk=zI2RBeZgocwYm3AkJW4CtjoJnKoDZrfBl1xe5Ed6h+U= X-Scanned-By: MIMEDefang 3.4.1 on 10.30.177.93 A failed ath10k_qmi_init() left a dangling pointer (ar_snoc->qmi) in the cleanup path. Clear the pointer on the way out for hygiene and consistency with deinit(). Fixes: ba94c753ccb4 ("ath10k: add QMI message handshake for wcn3990 client") Signed-off-by: Albert Esteve Reviewed-by: Brian Norris --- drivers/net/wireless/ath/ath10k/qmi.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/net/wireless/ath/ath10k/qmi.c b/drivers/net/wireless/a= th/ath10k/qmi.c index 0d74548a5f34..08a64f737fb4 100644 --- a/drivers/net/wireless/ath/ath10k/qmi.c +++ b/drivers/net/wireless/ath/ath10k/qmi.c @@ -1128,6 +1128,7 @@ int ath10k_qmi_init(struct ath10k *ar, u32 msa_size) =20 err: kfree(qmi); + ar_snoc->qmi =3D NULL; return ret; } =20 --- base-commit: bc35965f6940a9bf834d54187b6088b8eb09206d change-id: 20260914-fix-ath10k-dangling-15676d427cbb Best regards, --=20 Albert Esteve