From nobody Fri Sep 25 11:05:14 2026 Received: from mail-qv2-f12.google.com (mail-qv2-f12.google.com [74.125.230.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id B879C3D348C for ; Sun, 13 Sep 2026 22:37:55 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=74.125.230.140 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1789339077; cv=none; b=BvqQM8lJQ7Lxw2yBt8Ia5P63Z7/T2RUvaOmrS9lKc+foaHMOzwJ4YdLE2XBDYZL9D23/ydtqhzHYHDyH7Kn+DIR62l/UGvdz/mts4QC7FcTzfF281oqqZfH9POrQuWlD9FmhCX5Zzxbf+6uDHH5V43ti6NQ4QiNx30BZV733aN0= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1789339077; c=relaxed/simple; bh=J+u0KgMKJB3iK7Bi+salQZRzsKk6olKpGA7HZ0p8BHc=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=N9Plfg5S/JKg7gp1AaX/9mCeVyCz/1XlQ1mVPIs06V9Wt2snqo9AzMhKrIXJLNmaEWbcttMi5wrvdE9xYmtO/YMK2H9Z72u5wdUAjHZeJDstk2ROKEMX/+E4MhwAg2KU1Den2edV9HaOqdDB9NwD4D+mAEQJ0Z+2lV1LbOP/Cvs= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=SVxqtqN1; arc=none smtp.client-ip=74.125.230.140 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="SVxqtqN1" Received: by mail-qv2-f12.google.com with SMTP id 6a1803df08f44-90cdfcb5cb1so21412436d6.1 for ; Sun, 13 Sep 2026 15:37:55 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1789339074; x=1789943874; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to:content-type; bh=H08np1NCezknf+a6xR3bQgIb7oIFYvO24eBWSQtgT+s=; b=SVxqtqN16QiRtTx8N548gFdY2t+7ydubaECab3VCRYarHCtKKqyPDZnyq90OUEt3RM bt0XHF7qhmaxkN+VgJh50SzIqAlYJ51YYECaQT9wqiZy3LQWbE/YarJNIFD+9NVy9a+J E82hOvDGow9RlF6UFQibitHBSazCcY6T19HPH8TFq+l/o+0rVb+x74P9DIhTgI+7n/ss 7yEqBa84gZLGXcadWeuqZhRWEWf5LKgbWDLjiBQli/iqiaLVW7IZ3zeOEgQt7u9Kw8BT glkPokkC6BdwAxOqhedr25gMIhby/i0Nj9y7RhRjNivvMMl61it5ykXxIXqd5t6hK05h 6EYg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1789339074; x=1789943874; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to:content-type; bh=H08np1NCezknf+a6xR3bQgIb7oIFYvO24eBWSQtgT+s=; b=ojDZIxlk9mAbOycj3shaGjsZqcNRffXzC+a/5ai78tbRLkF/muQT/R9xSUWBc3S0W5 joqbE3WhmyBmqj08IFy5CgCCOCGohUNW7jjJM7dcKAzfJijmRX1tyq7n+eGJb13lFveW QPoEsLB2WqI4JkWfWTOT9HypeO/ywrhqisszT4edreXThkljuPfVG1aQjJIec9QD9JAn dFnZso4KCszXPgNwrzStnxTfIXk/1aaErlgdrNNJDK08svr0oxJ0EaPtYhMywXISTZYh pNHqv84BJpSyM6E9yRkxC9sJ5CCJOik0MaYNxSkqQb9WFS1/AEGXjXy1qLUhyecNNRJn cshg== X-Forwarded-Encrypted: i=1; AKwUvByJYF1IiDscKfcXYwrAvI2zB2ucuhUD9e07H6ErGRtWvN0DBrxaSvS/NKEuKLj3UkCCn3jcs30d0VA8b3w=@vger.kernel.org X-Gm-Message-State: AFuF++m8iqK94TbAwquwKOywytK07TKEpFGHN2wuAkUP1Al7eaJtvoy0 DzEdRLqlTpH9yFk/1/suuvnuvhjUkpC8hSEP/0nkAYIPN03b6MfrIzw= X-Gm-Gg: AYBFou08gMJ4Og/rmdtOY+Sfms9GBoHcJcurCTI8eDHNg/TXmZ+znGiPqfZW01cgKgF j/J9/jqAdpBOI6Wc6mRS0yn8ZHJYBu7nWG7laTT4Zh78UHf2uN96vkLnmeSu62Iy3s4I+M+JMh3 NiaMOlY8r9AnoQLAP8/DxqbVOIJYpvmM2gqcV+/7Z6k99fMtOPU5FdbO3BXRGHz1l/fv+yF8WtD pmGjCIij6wqHDTQt6An7I2zKfpZnFPY+bmffv+cRMXR9i5+Lyqn/Cat0kZ+lNXtHXnNDMqWhhoc /BRtFW/kDkBqLaUEjwh8YvtHqfVcVtiRXeT9/riCkNHbnYymj2FnhT9bg+j0Of5Td8JT9SQiXSu u4tHKwzaHzbKPkxP9rwALW/XyEjFc5mUKRILitk8I0yJJYYGRgSES/GuPwAWyGGodLubp04ZxHG vgdYAUKvGuxwWa+IKch1PhnK4w7IuV259LDHeRw13eDj3ortBIK+8ES7I/BDy7Pas9rtcz7eQ8a eUL+bWHYDBsE27hbgnwBkp7uhwOrQkyMXVK1t9G4P//IBeDTPhXIOSqeVkfsjbFGXEwvn11lq9u toY0rCbgAmsNdUG/VY8BKROZvZkS1nDhJysCw4Bp7VO4 X-Received: by 2002:a05:6214:1304:b0:90e:8a98:f218 with SMTP id 6a1803df08f44-9122e4e35b0mr2677096d6.9.1789339069896; Sun, 13 Sep 2026 15:37:49 -0700 (PDT) Received: from localhost.localdomain ([104.39.73.78]) by smtp.gmail.com with ESMTPSA id 6a1803df08f44-9120f45cbf2sm79361056d6.17.2026.09.13.15.37.47 (version=TLS1_3 cipher=TLS_CHACHA20_POLY1305_SHA256 bits=256/256); Sun, 13 Sep 2026 15:37:47 -0700 (PDT) From: Myeonghun Pak To: stern@rowland.harvard.edu Cc: gregkh@linuxfoundation.org, linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH 1/3] usb: ehci-platform: Disable controller wakeup on removal Date: Sun, 13 Sep 2026 18:37:30 -0400 Message-ID: <20260913223732.92882-2-mhun512@gmail.com> X-Mailer: git-send-email 2.50.1 In-Reply-To: <20260913223732.92882-1-mhun512@gmail.com> References: <20260913223732.92882-1-mhun512@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" On wakeup-capable ACPI controllers, a successful probe-time wakeup enable leaves a source attached after driver unbind: usb_remove_hcd() does not disable controller wakeup. Disable it after usb_remove_hcd() to balance the enable. This issue was identified during our ongoing static-analysis research while reviewing kernel code. Fixes: 776c15d0ad0c ("USB: ehci-platform: Add ACPI bindings for the EHCI pl= atform driver.") Assisted-by: OpenAI:GPT-5.6 Co-developed-by: Ijae Kim Signed-off-by: Ijae Kim Signed-off-by: Myeonghun Pak Acked-by: Alan Stern --- drivers/usb/host/ehci-platform.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/usb/host/ehci-platform.c b/drivers/usb/host/ehci-platf= orm.c index f61f095..b749de0 100644 --- a/drivers/usb/host/ehci-platform.c +++ b/drivers/usb/host/ehci-platform.c @@ -420,6 +420,7 @@ static void ehci_platform_remove(struct platform_device= *dev) quirk_poll_end(priv); =20 usb_remove_hcd(hcd); + device_wakeup_disable(hcd->self.controller); =20 if (pdata->power_off) pdata->power_off(dev); From nobody Fri Sep 25 11:05:14 2026 Received: from mail-qk1-f172.google.com (mail-qk1-f172.google.com [209.85.222.172]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 94C8440862C for ; Sun, 13 Sep 2026 22:37:53 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.222.172 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1789339075; cv=none; b=FBrHnvFCNg29NOK8QKaZCZY3Ze+45fYpZREMvILjgC+1AufWiYZsdeZaWPufpAeOP9ifCLUm/9uiZkRgUOfwinGsDchHCPdNCT+fhl3fUwx8hYQIBuiRIRAsuctYDr7dMQyLAQpIqd9EZ7izZtd8gtAyvhx95OFcYmd5AB/CxKE= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1789339075; c=relaxed/simple; bh=77rMhJ96Hr7kt35p05mN/FY3qSVNLhdnYmkNXT/rfv0=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=HVwup84i+z+UzJgVWsi3dKIQXP5efbbtIXVFMcikBIILzE66V+rACtpQYGco+R7gnwosgWGpjPI2hNo/ThqkesS3FvUD2xHVVygWSY50cbJjU8EyREAH+P1AFsxcQCh6U4zcZB2Lkg0KsPR2r5/OHJc0FhpCP2ENHbbXz6oOJHU= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=K7ObzS3B; arc=none smtp.client-ip=209.85.222.172 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="K7ObzS3B" Received: by mail-qk1-f172.google.com with SMTP id af79cd13be357-939fa4f2b81so139748485a.0 for ; Sun, 13 Sep 2026 15:37:53 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1789339072; x=1789943872; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to:content-type; bh=/eC2whU9fXcoJ6LICLe5n5h5thnnSk+FT//fcnt2+uc=; b=K7ObzS3BsTgssppi06tUopRu3nLYwoAyj0LjrjmjTyYZCD0K1sYB1wf5UicISAfcwt 2WC8Tb9n5Ho+kBA2ulPRAZ6Cz3P9sLwGKPO68kagYeJAHvrsWDtffdZK55UAxtHOal+A OiZyAJrWjx0KLwW8e4m64LOXcm+dF0uDUNv/041EoeUtDsqPe/thrsx2aBexG36jtj95 uZxswIl7rvc6vzn0FQ0WL4O9sMwINQIUr7fbGfZvaX7HPGJWso7KdQAISYR74hZkYG5B OeH1y+1JNqmDx4Uf4vDc9lzB1OUM/MMZvs6hN4zO0tCq9l7pbui41t8yIIgz1lRamJqm 1KYQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1789339072; x=1789943872; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to:content-type; bh=/eC2whU9fXcoJ6LICLe5n5h5thnnSk+FT//fcnt2+uc=; b=mglYTofYrI7fg9pjZKJKjJXiFS8TyqnuLzdDg/TGtXAl0N5a3v2R9Fax31FUnZlANz dNU3ZQD6tpDiGbroxbcf8EGgJ3NRUKcTdD4hX9cyB+dmwcs/W5eWa1liKJnTH/tDbnoK UVxiJ4s0ocvAB1fPJJscXZMMMQqTIOz8WHX1XVt5B4ELj0tg5aDi4Gd2ZyJBeBlvjfFO 30kx8meNh6YrbNNu4kYKuSn5rEQ6KWdocldYE27c4I8TZZruRqgCRJnA54beH2IJv98y I7T96R8JBiUGX2N0OMe4dwNxrxJUkVKq5uHsF1+ubSFjFM9ngwaHX+UFFACvGg3XoQn2 IvuQ== X-Forwarded-Encrypted: i=1; AKwUvBwbvQKtmGv2neVylHPyOlNPoU1NA3trK1a41fC/LBZHMaBjv91t7NLuqanlWNikzMNN/gjggdMQWIZCsys=@vger.kernel.org X-Gm-Message-State: AFuF++njm1EMiLP/r27fJBHEordFXWzKlNVnEeolha/rzd6yTo22sC2a i9D3wGVQjNkiTW0pr12B+Q/4aPlArTgrisgR7eywCD0YGfQUAg9jJYyswYBTDOxDoDxB X-Gm-Gg: AYBFou18glGWBx4A09O3u5sj0OofpcIf8Su+d2jasdXz3nhkeQHJ1YQpuG7KuJKKCF5 PU+cPx5nDzsCWsWYtI1NQ8RUgzcszJ3dLy9/faP7xCovVk1k1gPZ+i5pJK9f72kp5+KdFI1udbI cQNsFtyFurOBTk8WrlALFuIML3BapPff80SqjNpVnOWZI9ORm6bJVheIKAwCpljcJSlsO4xvwsi 22rFuYYURKQW36XGlaGttK8mn+i/wrZM3Qm9/wD79Kj/xluw0IVA9CmotM054XFStB7PHHITcDh 472BO/yjP+5xI5bMo4LLkhz8qH5+fKlTwu95jAY4RF8gr4bhYZlsDnwaA3c76TWi75CnoTQqgFW BHpZleoOHH6rruYzZ3GWbXVyul4nVyU632OVkj/BMdFDxoYWWLQ3e1/23+p5taAr36OBFN1Vdz0 2GHCnZubED15Yn+wN61ltPZ06UGQ3LWxyqHM8NG3xMCX17NLdZoI/N5/YvCECFtb+njxA+7un2a ZohXEe79n6SsvHsN+X4TozVV3SAw3sL/Jw78amsZp9+lvymiuJq+b3gVtDMA/4g+H8kVXgymJkX yKs3Pd+O8SAWBOWxRaZK4OZo1jmgjZFJUg== X-Received: by 2002:a05:620a:8081:b0:932:ddff:123d with SMTP id af79cd13be357-93a29945ca8mr25452485a.29.1789339072480; Sun, 13 Sep 2026 15:37:52 -0700 (PDT) Received: from localhost.localdomain ([104.39.73.78]) by smtp.gmail.com with ESMTPSA id 6a1803df08f44-9120f45cbf2sm79361056d6.17.2026.09.13.15.37.50 (version=TLS1_3 cipher=TLS_CHACHA20_POLY1305_SHA256 bits=256/256); Sun, 13 Sep 2026 15:37:51 -0700 (PDT) From: Myeonghun Pak To: stern@rowland.harvard.edu Cc: gregkh@linuxfoundation.org, linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH 2/3] usb: ohci-platform: Disable controller wakeup on removal Date: Sun, 13 Sep 2026 18:37:31 -0400 Message-ID: <20260913223732.92882-3-mhun512@gmail.com> X-Mailer: git-send-email 2.50.1 In-Reply-To: <20260913223732.92882-1-mhun512@gmail.com> References: <20260913223732.92882-1-mhun512@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" When OHCI reports remote-wakeup capability, a successful wakeup enable leaves a source attached after driver unbind: usb_remove_hcd() does not disable controller wakeup. Disable it after usb_remove_hcd() to balance the enable. This issue was identified during our ongoing static-analysis research while reviewing kernel code. Fixes: fa3364b5a2d7 ("USB: OHCI: Add a generic platform device driver") Assisted-by: OpenAI:GPT-5.6 Co-developed-by: Ijae Kim Signed-off-by: Ijae Kim Signed-off-by: Myeonghun Pak --- drivers/usb/host/ohci-platform.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/usb/host/ohci-platform.c b/drivers/usb/host/ohci-platf= orm.c index c801527..c2a90a4 100644 --- a/drivers/usb/host/ohci-platform.c +++ b/drivers/usb/host/ohci-platform.c @@ -246,6 +246,7 @@ static void ohci_platform_remove(struct platform_device= *dev) =20 pm_runtime_get_sync(&dev->dev); usb_remove_hcd(hcd); + device_wakeup_disable(&dev->dev); =20 if (pdata->power_off) pdata->power_off(dev); From nobody Fri Sep 25 11:05:14 2026 Received: from mail-qk1-f173.google.com (mail-qk1-f173.google.com [209.85.222.173]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 240E740BCD8 for ; Sun, 13 Sep 2026 22:37:56 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.222.173 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1789339077; cv=none; b=pFAF1kgECA6KZ8oE88zZ7DrhD4MgneXArxSgSJcQd8Dcpp48ggVjqKak5B9c50QNnWryJfC5QzHAmYpxCiw83PE1+T+g84aDopt2y3iufoHwtA1WRnYYidp85VMAYAuhldTP4NE4Xx5sVyLDktEUtG4gZYwvy+QqlPmeIY94Yes= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1789339077; c=relaxed/simple; bh=3yFoHeW1ePG+i4RCbEU2JofKauVW53+A/Z/TXfsz8qo=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=aRFR69FUsAW9yBm8l46IrhjQ/3Jzx0Mn3xr4gTgLQXXB0MCfjlt9ddyMMpJnrDGgWw64WYlUnI+GUuRJnoTa/vLblwVHQwBw1H/7IOvRSTblxsqSAhTNJGhwcjoHQeWH22HKZA6xPRl9RGdrz8sO11gcTf9memsXBntJFJoTrvg= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=bNghW4Jq; arc=none smtp.client-ip=209.85.222.173 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="bNghW4Jq" Received: by mail-qk1-f173.google.com with SMTP id af79cd13be357-93a0fb2f9efso61085185a.1 for ; Sun, 13 Sep 2026 15:37:56 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1789339075; x=1789943875; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to:content-type; bh=DHFmaO+kDb8wMPnqE7UfVX7wmIXcuui9FuHVD6Z8w4w=; b=bNghW4JqbzV+nmJqMj0JcEhLWNJC6XhUTI4gO2ieCIw45NBc6ZiL4eWtWx+298tzcs QMUl68yjAlapHf837bttbmeW4kCC8iwM5Zc2jLotnIK0GUAZV0jqIcx6bZq6INP3yTd4 LjoloRiXm8vQw63jLtnyTxNZv8dKj0NO4nGlZGe8AYpJkB8wf4WTsfbEcPDizLzodVzC TO2r0RbpIY7hSXvBXCFSYXJSXc7DWpHeKxHMo33jNUN/WqbBmRcKWDiG33OCkhsm/KRA d3wAcpFTU/JwdtEtoSB6Jp62CMz1KpZEMLkQvx+2ga2wjmuuB89j2JY5izfLqfTEQi+n RgjQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1789339075; x=1789943875; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to:content-type; bh=DHFmaO+kDb8wMPnqE7UfVX7wmIXcuui9FuHVD6Z8w4w=; b=FhhSlue96sK+ZUmpiEhPAycPveHtYMw75SI6e66qVTzg43L/aDDQYH+402wi1uuTre CYD4DS+sT3p7/1Mtd/Qho5SG1h0kXxP/suzouvFw4bLg6YtAZZMObIc7kph0qABvBDtQ SLiERZVP0WS3Cfxi7uc6LwShwyHNf5BhJd86qHiKd2bOGTY8zPl90hs4es+xfeCPRhP2 ts2yNZza5RIm0vzcVAGbHG6JiQNWWWo9QLawF5NjBeIeORwdGSzndSWz8fZCir5Kh2vO iQqKRRyaq5CzDKuYhXCNyNugAm8TEZFiVuaOZXA0CRI/niZItAk2Zv5abai1wdLjfHsW YuUQ== X-Forwarded-Encrypted: i=1; AKwUvBzv4iT41mBIjrI22NAK4q+QH3smkV/1eF3nFuDASKCVI4hCL5Gg/6AEG8x9gWGvCv+pr1oRMA6t2jw+/3E=@vger.kernel.org X-Gm-Message-State: AFuF++mAES9Y+3z0TSe0PXdvJzbDB/pVkKzWykSOot01D7XsjDyamf01 2/f1ezV9ZblkbBBgxhBRgivgVdEpVPzOpzSA+HdSnw5nQSRlsjzIjmY= X-Gm-Gg: AYBFou0OfPsD5+jj6zU+J6Ne26Ut/BvmpFG66VSXJugB/K9jvyNLeb1TIc7ptUGh52Y VkSTjOCPboRvH/GNMY7ytjsrhSOKXiFPOW6ZijwlL/LUBbneVsm7T+tW56YvWB9XVOb9Wq2uIX/ 0iGvfGLMkOy8PCzdgg4S/PB2GjevY7Nvzcvo08Ct5dtmoSlGzoB3lh9xcpkvNhfxqWk4aPYhw4f mZouH/wWVhNfTzeTDgO8xRTKtZza7l6VGvk+K4/1WGGk7Yz0T1NUo5XOCzCzpxyPAjCZABVXrPL Scqrutl/8+JyPA3bVtiJt7vyTlG8IRs8tEU89LjaPDguMggpWVBewoGaFQOVo0Ntrs4j2OBdSmJ pftQ3cxXM/sMSj3lBINXpBFHiI9d7f8CLoPocxP6lcB4AHrOnugOHQhYuQqWugHSo0OxRj34me/ zFu2E58rx1vtPgGNJLdhBaW16l1sho1hb55591j0b2ON3jpQpCmoAkWW+8gIsF22AOhTeIrmbk+ r7Hgo2MleRSMv8Tf5G2sErF5NPwO+/rKZ7aDna9wnC50YTYfNCxD/0Yaee/Itnm4PtfpupvDZJ7 iWBF/tcx0/Xg2wOzW57eJM+k/fl+x9ywqg== X-Received: by 2002:a05:620a:2708:b0:93a:133a:310b with SMTP id af79cd13be357-93a1870eb4amr396136385a.26.1789339075060; Sun, 13 Sep 2026 15:37:55 -0700 (PDT) Received: from localhost.localdomain ([104.39.73.78]) by smtp.gmail.com with ESMTPSA id 6a1803df08f44-9120f45cbf2sm79361056d6.17.2026.09.13.15.37.52 (version=TLS1_3 cipher=TLS_CHACHA20_POLY1305_SHA256 bits=256/256); Sun, 13 Sep 2026 15:37:53 -0700 (PDT) From: Myeonghun Pak To: stern@rowland.harvard.edu Cc: gregkh@linuxfoundation.org, linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org, krzk@kernel.org, peter.griffin@linaro.org, alim.akhtar@samsung.com, linux-arm-kernel@lists.infradead.org, linux-samsung-soc@vger.kernel.org Subject: [PATCH 3/3] usb: ohci-exynos: Disable controller wakeup on removal Date: Sun, 13 Sep 2026 18:37:32 -0400 Message-ID: <20260913223732.92882-4-mhun512@gmail.com> X-Mailer: git-send-email 2.50.1 In-Reply-To: <20260913223732.92882-1-mhun512@gmail.com> References: <20260913223732.92882-1-mhun512@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" When OHCI reports remote-wakeup capability, a successful wakeup enable leaves a source attached after driver unbind: usb_remove_hcd() does not disable controller wakeup. Disable it after usb_remove_hcd() to balance the enable. This issue was identified during our ongoing static-analysis research while reviewing kernel code. Fixes: 62194244cf87 ("USB: Add Samsung Exynos OHCI diver") Assisted-by: OpenAI:GPT-5.6 Co-developed-by: Ijae Kim Signed-off-by: Ijae Kim Signed-off-by: Myeonghun Pak --- drivers/usb/host/ohci-exynos.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/usb/host/ohci-exynos.c b/drivers/usb/host/ohci-exynos.c index cc5cb09..86ff7a0 100644 --- a/drivers/usb/host/ohci-exynos.c +++ b/drivers/usb/host/ohci-exynos.c @@ -194,6 +194,7 @@ static void exynos_ohci_remove(struct platform_device *= pdev) pdev->dev.of_node =3D exynos_ohci->of_node; =20 usb_remove_hcd(hcd); + device_wakeup_disable(hcd->self.controller); =20 exynos_ohci_phy_disable(&pdev->dev);