From nobody Fri Sep 25 12:05:43 2026 Received: from mail-m49198.qiye.163.com (mail-m49198.qiye.163.com [45.254.49.198]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 2A1593EA96A; Sun, 13 Sep 2026 12:52:09 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=45.254.49.198 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1789303932; cv=none; b=XhBQu+Gz+FWTusSnpxmOD0d3tJoH9onAcKTHFdsHbwKghSj8UmKxbohUiL25ikAvQvsVbeJn2ll0BrGwKD0oT90t7eDgb8hXOANJ3QeOoMhVsPlRR5PNldXqvB2/eVQUvYj1bE9V8nI0qLPFH7AlX0lBGr5iNAkaWylHRB4gw/s= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1789303932; c=relaxed/simple; bh=ErMdrmVoDeg8/bERXlPKMpXxwrX6QFUaszjeF3fGkK0=; h=From:To:Cc:Subject:Date:Message-Id:MIME-Version; b=n4Y0cs9vA3WsSRbONHnV9WIdebeqk0QdOCcDA9fjn4TvKqLXFY6fNKUNKwRD0M2GsODcuJ4JkJYwLsmGdKMcXTXHxeG+lz9FbC3quI7zVcSgLql5+2ZivOltlmCWiLOE6Z+BPm7moIUPgIR/6WGoDF4YejGp/SSwmH1E9W1htcA= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=seu.edu.cn; spf=pass smtp.mailfrom=seu.edu.cn; dkim=pass (1024-bit key) header.d=seu.edu.cn header.i=@seu.edu.cn header.b=PAC/7A5R; arc=none smtp.client-ip=45.254.49.198 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=seu.edu.cn Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=seu.edu.cn Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=seu.edu.cn header.i=@seu.edu.cn header.b="PAC/7A5R" Received: from seu.edu.cn (unknown [58.241.16.34]) by smtp.qiye.163.com (Hmail) with ESMTP id 4d907a3eb; Sun, 13 Sep 2026 20:52:03 +0800 (GMT+08:00) From: Slavin Liu To: jeff.hugo@oss.qualcomm.com, ogabbay@kernel.org Cc: carl.vanderlip@oss.qualcomm.com, linux-arm-msm@vger.kernel.org, dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org, bolin.liu@seu.edu.cn Subject: [PATCH] accel/qaic: tolerate absent crashdump state during cleanup Date: Sun, 13 Sep 2026 20:52:01 +0800 Message-Id: <20260913125201.109964-1-bolin.liu@seu.edu.cn> X-Mailer: git-send-email 2.34.1 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-HM-Tid: 0aa09ad3229603a1kunm4732dfae2511b8 X-HM-MType: 10 X-HM-Spam-Status: e1kfGhgUHx5ZQUpXWQgPGg8OCBgUHx5ZQUlOS1dZFg8aDwILHllBWSg2Ly tZV1koWUFITzdXWRgWCB1ZQUpXWS1ZQUlXWQ8JGhUIEh9ZQVlCHx5LVk5CSh5OQh5LHRoaSVYeHw 5VEwETFhoSFyQUDg9ZV1kYEgtZQVlOQ1VJT0pVSk1VSE9ZV1kWGg8SFR0UWUFZT0tIVUpLSUhOQ0 NVSktLVUtZBg++ DKIM-Signature: a=rsa-sha256; b=PAC/7A5RqifP9Fv2Cv7IoZhQprGO769BWgl/oyOqc+Y0BYNB4/fji2Ngs9QYVz9LmyhfS8pTGOeOVnZYeEEIW9UYrbRs4WVVs8cp90ncloorySyfYJ1y2XNNn2iqDDoIHloPCSEvWgD5hh7f/Lci3OuiKeQ5j5s/lMv1Kqv+Flc=; c=relaxed/relaxed; s=default; d=seu.edu.cn; v=1; bh=PO8y2509JB5N7S49pOyCwIPjvSnjKVxeZ9e5YXPBqIc=; h=date:mime-version:subject:message-id:from; Content-Type: text/plain; charset="utf-8" A negative response can be sent before crashdump state is assigned. If queuing that response fails, cleanup receives NULL. Treat that as no owned crashdump resources instead of dereferencing it. Detected by static analysis and reviewed with AI-assisted source auditing. Fixes: 6bc1fe6c748c ("accel/qaic: Collect crashdump from SSR channel") Assisted-by: LLM Signed-off-by: Slavin Liu --- drivers/accel/qaic/qaic_ssr.c | 6 +++++- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/drivers/accel/qaic/qaic_ssr.c b/drivers/accel/qaic/qaic_ssr.c index a98928654959..d9ba1d333cdb 100644 --- a/drivers/accel/qaic/qaic_ssr.c +++ b/drivers/accel/qaic/qaic_ssr.c @@ -194,7 +194,11 @@ struct dump_file_meta { =20 static void free_ssr_dump_info(struct ssr_crashdump *ssr_crash) { - struct ssr_dump_info *dump_info =3D ssr_crash->dump_info; + struct ssr_dump_info *dump_info; + + if (!ssr_crash) + return; + dump_info =3D ssr_crash->dump_info; =20 ssr_crash->dump_info =3D NULL; if (!dump_info)