From nobody Fri Sep 25 12:00:31 2026 Received: from mail-pj2-f12.google.com (mail-pj2-f12.google.com [74.125.227.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id DB09A383C99 for ; Sun, 13 Sep 2026 05:35:42 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=74.125.227.140 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1789277744; cv=none; b=f5fm9s+C87GeD2F4T4UmBZsfMSKqjo9cWVKdqkD7VBctHvl3PkRqRVelqemsvJESlZqHkqct9+H9Q6SBBLmDDflQyLE2UkAt1iWg9fL8cH+ga9GopTbmwuEdDMUadVlanpSsawmN5HMQPUBBhwg1OI88ON/3e8E/RmRn6jGENYg= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1789277744; c=relaxed/simple; bh=g3UkdkpCWLnZGOnt0s3r1JZYTobd2xUzpt7kHCypGs4=; h=From:To:Cc:Subject:Date:Message-ID:MIME-Version; b=PSCfty7GseBozCNJuQoFVK6+lNwyaFfVRkk+6hP7aWs829cbi1Pkow2hv+phGLdkF43lD3RyZtPwdxaeVKtX8GH/fEs6JIH766EjFiQqpVpsHVHQUJd3Q623tQ8nl8XxuG/5OIwE8fs5m0hypscDXt5NoKIw5eo/jD04T3Bfov0= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=FJiHx042; arc=none smtp.client-ip=74.125.227.140 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="FJiHx042" Received: by mail-pj2-f12.google.com with SMTP id 98e67ed59e1d1-396ccda24afso713132a91.3 for ; Sat, 12 Sep 2026 22:35:42 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1789277742; x=1789882542; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to:content-type; bh=dEi52B8rAYhWrqmn6XsExZbTrS6LSYARttaUbapzORo=; b=FJiHx042TR+0fsP6tvu2pVf2uzcBP/43QTPIynsOu4ZvzwIb9jX3YAMQAYd4hQfB/d QyWjO1fJIv6o6XucjkCWl7cv6ezvMKvcXc9s7L+83/vQIomrdQZA0c24kb9MBMCfxiix I4mh2kzFtIEIHWK+rGlUgeRHOTlSOYfcPizdfRjb2wjlfi3ZS/0JIPUk19S6SN+papBU cK4e9pB9mVa9c043FbO8yWeIGXlV8BrgZnSpKpCU8eq5xTteuCpk1P8+Fr90lGDvr/f0 ezTy59LnrmJNLYUUB0PXCDrLRHkQtFmFwvPOIwUbbHg4+oVBUk8oWuHSJlrK9DwRLJYT ibhQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1789277742; x=1789882542; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to:content-type; bh=dEi52B8rAYhWrqmn6XsExZbTrS6LSYARttaUbapzORo=; b=a/skrgAoNKA7xIO+JTE2wUjAJ20f1dq3CGW2ayTQeQLosTgbZ0+8ujytGBoYTluH98 W48py/TCs49PZ3gro/946yZdfnZI0FyNLeqiJ1pb766xRQ/27yUDn3Aks6OI3l1/6Icd j/slrMcNdmmStYh4KfIf1wKhFz5NScyxZwm7KWr++775w0Yr9fVCYMvcgqYoFQYiJULt HE1zhUNC3oTfjEM7Y7VIonhtC7J/M7gXKOna8PIJZigja8eQAjB94bsfHfvWTRFTk02q f7EdpSfYDb+icnxgloaHQyup218llpnbJf6NPtpsX0i9ZALa78ALOvKlRT/IEELyOg/p eNeQ== X-Forwarded-Encrypted: i=1; AKwUvBzI0gMrPSgqYCvqmJme9UIoNueh3TLUh5TPN2aNt0IQcnLzRKoH6vYdAYPh5TbFA9UCRJ3xqO7fQCWGoQc=@vger.kernel.org X-Gm-Message-State: AFuF++ljnOCGSCZfJfbxEELHvudJBwKuDS5oJOgz3noHSiIqXRzv5YfL BXNewzhFU2h1GF5HpUDPSSPJ04f4R/NTn7hjN+BiwRH9PmStWPboV+f1 X-Gm-Gg: AYBFou1aCH1+ZF90gfeMhX8EDsVC+Od+TdDvTAQdRgVPGXd/gyTQmTLlnSf0Gm/VAot fhhf4HwC0Qlal28DD27cxxo0ajBLP6z41jJYCf7tbMzpAtvrD0DCsx1FNngY0yJZyHUgwu9BrHf WmEYm+opGAQT4XTcgWrK1t+w8fBWL4DnY7EkEkvhJI0cvFjCDhUqZ5hqavla7jtRbhiPlmOFhJV STP5gNH2cKcrZlxuHDqFrmS3h35gwkLW4/sBMpsbQYg3bfc6O6y3ubBTFvdiAHArwz1GaQRINJa UHjMu3J4Vl7/48TWI3YvHu3V/2el5PWJ1Oz/w2+4tQFbZpL9ZMM+5acJZvA6vudifVpRfvK5MYf Mysc+IJHlJG/+9YH7aRC0HkuASaiHTe+POBbXq1X5aWIIK4IkKVrgjD6H8aTrMeqagZxQD0TqS6 Z7VIBjZxS3EttMMtVZaJ6j8rK3JVF+mKxLRmwLObPf++i0fXmCPGDfWrWeYzJ0xCOI X-Received: by 2002:a17:90b:4fc5:b0:399:149a:3f27 with SMTP id 98e67ed59e1d1-39d9bd71246mr21202876a91.9.1789277742198; Sat, 12 Sep 2026 22:35:42 -0700 (PDT) Received: from lgs.. ([2001:250:5800:1002::de93]) by smtp.gmail.com with ESMTPSA id 98e67ed59e1d1-39d951d1056sm13277134a91.7.2026.09.12.22.35.38 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 12 Sep 2026 22:35:41 -0700 (PDT) From: Guangshuo Li To: Shubhrajyoti Datta , Borislav Petkov , Tony Luck , linux-edac@vger.kernel.org, linux-kernel@vger.kernel.org Cc: Guangshuo Li , stable@vger.kernel.org Subject: [PATCH] EDAC/versalnet: fix remoteproc reference leak Date: Sun, 13 Sep 2026 13:35:32 +0800 Message-ID: <20260913053532.1324671-1-lgs201920130244@gmail.com> X-Mailer: git-send-email 2.43.0 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" mc_probe() acquires a reference to the remote processor with rproc_get_by_phandle(), but mc_remove() does not release the reference. rproc_shutdown() only balances the power reference acquired by rproc_boot(); it does not drop the device reference acquired by rproc_get_by_phandle(). As a result, successful driver removal leaves the remoteproc reference unbalanced. Call rproc_put() during removal to release the reference acquired in mc_probe(). This issue was found by manual code inspection. Fixes: d5fe2fec6c40d ("EDAC: Add a driver for the AMD Versal NET DDR contro= ller") Cc: stable@vger.kernel.org Signed-off-by: Guangshuo Li Reviewed-by: Radhey Shyam Pandey --- drivers/edac/versalnet_edac.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/edac/versalnet_edac.c b/drivers/edac/versalnet_edac.c index 97ec05d68bbb..3a06b41c1d84 100644 --- a/drivers/edac/versalnet_edac.c +++ b/drivers/edac/versalnet_edac.c @@ -953,6 +953,7 @@ static void mc_remove(struct platform_device *pdev) remove_versalnet(priv); rproc_shutdown(priv->mcdi->r5_rproc); cdx_mcdi_finish(priv->mcdi); + rproc_put(priv->mcdi->r5_rproc); kfree(priv->mcdi); } =20 --=20 2.43.0