From nobody Fri Sep 25 11:10:22 2026 Received: from mout01.posteo.de (mout01.posteo.de [185.67.36.65]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id A71D1369D74 for ; Sun, 13 Sep 2026 16:15:27 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=185.67.36.65 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1789316130; cv=none; b=ZsYAE6ejs7NFiflPnXw3cY5+Uk/f433oZ3yLNfFpZlnOK9q3oAPvIoi3gUrL+MlD3u8mb9B+Y6CsnOW1989afW0fOjIPqkF8B968fkmtzI1bshwNScA8obHKXftF1jiFUhew2NhlAaydvfwvkR6+U3x9tYSYL8cx6bxJ339QAHs= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1789316130; c=relaxed/simple; bh=Xn4GIYX+KSS0ezgE+U3dcStxf/TFdWFrcgYbKCNENcc=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=KW9Wm9ONIPPXCpR5hdl4ClKcxpD7SElcUY6xexXR57Lxzf0BdnQrs763O3Jz/3Y50X8IbWyANDdcE61uezQKiglmDbezAitike2IwbtULe7Z1CiAZJhgStf57brT1dhT0Gx2+KPvBiOcQDrGK6fV9mAuNHsB5ugJK8ek3E5yQxQ= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=posteo.de; spf=pass smtp.mailfrom=posteo.de; dkim=pass (2048-bit key) header.d=posteo.de header.i=@posteo.de header.b=mukMsm10; arc=none smtp.client-ip=185.67.36.65 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=posteo.de Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=posteo.de Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=posteo.de header.i=@posteo.de header.b="mukMsm10" Received: from submission (posteo.de [185.67.36.169]) by mout01.posteo.de (Postfix) with ESMTPS id EE343240031 for ; Sun, 13 Sep 2026 18:15:25 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=posteo.de; s=1984.8680eb; t=1789316125; bh=iMVmQuBrh2V9IQp0vpDiYlCSTCHfpYJ85NaS0L0yH9U=; h=From:Date:Subject:MIME-Version:Content-Type: Content-Transfer-Encoding:Message-Id:To:Cc:Autocrypt:OpenPGP:From; b=mukMsm10YQkgZEFD9WNlrIsPzQDjHMxss2jW1lMfrDlbzFhaH/Lyh1sQzksn8lpxY xB3E/Bv+fAoJtC06z/KMcXzLSTbFeHlCOAZ3wovvZNYxWylAcGNSJQ9FnGy9GvRa8t 4ikPj5gE3khKomnzRODescBR2ontzsosF7oYck131s+bA1/CEGwfVMYFrYsktCPUSN 3YzLGGnJg2qSP2v4v8FhOzkmqbIGF2WG28OywaF8QCAryGWUQD4A0geKWfmiWLkqsz ay26SIGJ1XKogo/KDzcTmitSSXVxxEIxzPhyLdeEKkrUQN8lkZhL8NC+Q+zabdcjf8 2i4CEsRP4AReQ== Received: from customer (localhost [127.0.0.1]) by submission (posteo.de) with ESMTPSA id 4hjYKP6PWMz9rxS; Sun, 13 Sep 2026 18:15:21 +0200 (CEST) From: Markus Probst Date: Sun, 13 Sep 2026 16:15:24 +0000 Subject: [PATCH v25 1/4] rust: leds: add basic led classdev abstractions Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20260913-rust_leds-v25-1-1a10371d78c3@posteo.de> References: <20260913-rust_leds-v25-0-1a10371d78c3@posteo.de> In-Reply-To: <20260913-rust_leds-v25-0-1a10371d78c3@posteo.de> To: Lee Jones , Pavel Machek , Greg Kroah-Hartman , Dave Ertman , Leon Romanovsky , Miguel Ojeda , Alex Gaynor , Gary Guo , =?utf-8?q?Bj=C3=B6rn_Roy_Baron?= , Benno Lossin , Andreas Hindborg , Alice Ryhl , Trevor Gross , Danilo Krummrich , "Rafael J. Wysocki" , Bjorn Helgaas , =?utf-8?q?Krzysztof_Wilczy=C5=84ski?= , Boqun Feng , Daniel Almeida , Tamir Duberstein , Alexandre Courbot , =?utf-8?q?Onur_=C3=96zkan?= , Ira Weiny , Boqun Feng Cc: rust-for-linux@vger.kernel.org, linux-leds@vger.kernel.org, linux-kernel@vger.kernel.org, linux-pci@vger.kernel.org, Markus Probst X-Developer-Signature: v=1; a=openpgp-sha256; l=18312; i=markus.probst@posteo.de; h=from:subject:message-id; bh=Xn4GIYX+KSS0ezgE+U3dcStxf/TFdWFrcgYbKCNENcc=; b=owEBiQJ2/ZANAwAIATR2H/jnrUPSAcsmYgBqpswUqX5Uhjc8T9mZ3cSW8oay8z5RyZISoYkjA OF+r+xJ8wyJAk8EAAEIADkWIQSCdBjE9KxY53IwxHM0dh/4561D0gUCaqbMFBsUgAAAAAAEAA5t YW51MiwyLjUrMS4xMiwyLDIACgkQNHYf+OetQ9IHMBAAkyew3Pdz+x9AdxkiDE95DLzsw/gmOv1 5JC/iZ9IfyDN95ee2NZQLiG/X1qLwzGl2+nFRiQ/YquKD2YpsrRZDCb8USQiclID728UNDZ5Ggb t7zhFbShkBT2ypJoxblGw10z+y2Fhc0mnb3AbfoWNpJpoQKymq7shzR6uuzjI2sFQ+UihBMm/sd 8uWabVaEXXwp0vaJtqGK+2kj8lbeh+hwK78PDd30gYjlP1YzeI2HXS99EBbyK0qQM9iw/HvEOKp pjzC2FXYPe7r4QsMIYBjbf9zlV0QZSLppFKE0h7XIaAUF/4YXbFGXNaS3snHfXHoymK6Scjooh3 ggR8lHnLCBCHuojMed+T4pVNWQZYiZxa04Q6ScDZHTa4AVPVXs/dpbDi5icxlf3PIPX63sPwcjE 0SPUOdclH4OJWumCz6KKjEL65eIqTKQgq/f4hDmIg+5h7Y+tHezTC1qf3XSMr0cx8LXaJL42iyY uJiwpCF8uVQ0njf0LMJ7i3KopcmkxGJE+/UzKRYd1zVKtHkIEpwTjlZr3YGUD2nzn/wGKXNF49j RVR+ZPxNBgcjoPFao5TVFxkSFhcgcABV7kxzz/zKVChZ33LQ3WvqfQefMwPxr1VbhBmi4Ikiev2 vQJrsEoqi2GT63eM7QBXFPlqFY0Q1Jzt3wAqc7Th2R8aXR9IYKAg= X-Developer-Key: i=markus.probst@posteo.de; a=openpgp; fpr=827418C4F4AC58E77230C47334761FF8E7AD43D2 Autocrypt: addr=markus.probst@posteo.de; prefer-encrypt=mutual; keydata=xsFNBGiDvXgBEADAXUceKafpl46S35UmDh2wRvvx+UfZbcTjeQOlSwKP7YVJ4JOZrVs93qReNLkO WguIqPBxR9blQ4nyYrqSCV+MMw/3ifyXIm6Pw2YRUDg+WTEOjTixRCoWDgUj1nOsvJ9tVAm76Ww+ /pAnepVRafMID0rqEfD9oGv1YrfpeFJhyE2zUw3SyyNLIKWD6QeLRhKQRbSnsXhGLFBXCqt9k5JA RhgQof9zvztcCVlT5KVvuyfC4H+HzeGmu9201BVyihJwKdcKPq+n/aY5FUVxNTgtI9f8wIbmfAja oT1pjXSp+dszakA98fhONM98pOq723o/1ZGMZukyXFfsDGtA3BB79HoopHKujLGWAGskzClwTjRQ xBqxh/U/lL1pc+0xPWikTNCmtziCOvv0KA0arDOMQlyFvImzX6oGVgE4ksKQYbMZ3Ikw6L1Rv1J+ FvN0aNwOKgL2ztBRYscUGcQvA0Zo1fGCAn/BLEJvQYShWKeKqjyncVGoXFsz2AcuFKe1pwETSsN6 OZncjy32e4ktgs07cWBfx0v62b8md36jau+B6RVnnodaA8++oXl3FRwiEW8XfXWIjy4umIv93tb8 8ekYsfOfWkTSewZYXGoqe4RtK80ulMHb/dh2FZQIFyRdN4HOmB4FYO5sEYFr9YjHLmDkrUgNodJC XCeMe4BO4iaxUQARAQABzRdtYXJrdXMucHJvYnN0QHBvc3Rlby5kZcLBkQQTAQgAOxYhBIJ0GMT0 rFjncjDEczR2H/jnrUPSBQJog714AhsDBQsJCAcCAiICBhUKCQgLAgQWAgMBAh4HAheAAAoJEDR2 H/jnrUPSgdkQAISaTk2D345ehXEkn5z2yUEjaVjHIE7ziqRaOgn/QanCgeTUinIv6L6QXUFvvIfH 1OLPwQ1hfvEg9NnNLyFezWSy6jvoVBTIPqicD/r3FkithnQ1IDkdSjrarPMxJkvuh3l7XZHo49GV HQ8i5zh5w4YISrcEtE99lJisvni2Jqx7we5tey9voQFDyM8jxlSWv3pmoUTCtBkX/eKHJXosgsuS B4TGDCVPOjla/emI5c9MhMG7O4WEEmoSdPbmraPw66YZD6uLyhV4DPHbiDWRzXWnClHSyjB9rky9 lausFxogvu4l9H+KDsXIadNDWdLdu1/enS/wDd9zh5S78rY2jeXaG4mnf4seEKamZ7KQ6FIHrcyP ezdDzssPQcTQcGRMQzCn6wP3tlGk7rsfmyHMlFqdRoNNv+ZER/OkmZFPW655zRfbMi0vtrqK2Awm 9ggobb1oktfd9PPNXMUY+DNVlgR2G7jLnenSoQausLUm0pHoNE8TWFv851Y6SOYnvn488sP1Tki5 F3rKwclawQFHUXTCQw+QSh9ay8xgnNZfH+u9NY7w3gPoeKBOAFcBc2BtzcgekeWS8qgEmm2/oNFV G0ivPQbRx8FjRKbuF7g3YhgNZZ0ac8FneuUtJ2PkSIFTZhaAiC0utvxk0ndmWFiW4acEkMZGrLaM L2zWNjrqwsD2zsFNBGiDvXgBEADCXQy1n7wjRxG12DOVADawjghKcG+5LtEf31WftHKLFbp/HArj BhkT6mj+CCI1ClqY+FYU5CK/s0ScMfLxRGLZ0Ktzawb78vOgBVFT3yB1yWBTewsAXdqNqRooaUNo 8cG/NNJLjhccH/7PO/FWX5qftOVUJ/AIsAhKQJ18Tc8Ik73v427EDxuKb9mTAnYQFA3Ev3hAiVbO 6Rv39amVOfJ8sqwiSUGidj2Fctg2aB5JbeMln0KCUbTD1LhEFepeKypfofAXQbGwaCjAhmkWy/q3 IT1mUrPxOngbxdRoOx1tGUC0HCMUW1sFaJgQPMmDcR0JGPOpgsKnitsSnN7ShcCr1buel7vLnUMD +TAZ5opdoF6HjAvAnBQaijtK6minkrM0seNXnCg0KkV8xhMNa6zCs1rq4GgjNLJue2EmuyHooHA4 7JMoLVHcxVeuNTp6K2+XRx0Pk4e2Lj8IVy9yEYyrywEOC5XRW37KJjsiOAsumi1rkvM7QREWgUDe Xs0+RpxI3QrrANh71fLMRo7LKRF3Gvw13NVCCC9ea20P4PwhgWKStkwO2NO+YJsAoS1QycMi/vKu 0EHhknYXamaSV50oZzHKmX56vEeJHTcngrM8R1SwJCYopCx9gkz90bTVYlitJa5hloWTYeMD7FNj Y6jfVSzgM/K4gMgUNDW/PPGeMwARAQABwsF2BBgBCAAgFiEEgnQYxPSsWOdyMMRzNHYf+OetQ9IF AmiDvXgCGwwACgkQNHYf+OetQ9LHDBAAhk+ab8+WrbS/b1/gYW3q1KDiXU719nCtfkUVXKidW5Ec Idlr5HGt8ilLoxSWT2Zi368iHCXS0WenGgPwlv8ifvB7TOZiiTDZROZkXjEBmU4nYjJ7GymawpWv oQwjMsPuq6ysbzWtOZ7eILx7cI0FjQeJ/Q2baRJub0uAZNwBOxCkAS6lpk5Fntd2u8CWmDQo4SYp xeuQ+pwkp0yEP30RhN2BO2DXiBEGSZSYh+ioGbCHQPIV3iVj0h6lcCPOqopZqyeCfigeacBI0nvN jHWz/spzF3+4OS+3RJvoHtAQmProxyGib8iVsTxgZO3UUi4TSODeEt0i0kHSPY4sCciOyXfAyYoD DFqhRjOEwBBxhr+scU4C1T2AflozvDwq3VSONjrKJUkhd8+WsdXxMdPFgBQuiKKwUy11mz6KQfcR wmDehF3UaUoxa+YIhWPbKmycxuX/D8SvnqavzAeAL1OcRbEI/HsoroVlEFbBRNBZLJUlnTPs8ZcU 4+8rq5YX1GUrJL3jf6SAfSgO7UdkEET3PdcKFYtS+ruV1Cp5V0q4kCfI5jk25iiz8grM2wOzVSsc l1mEkhiEPH87HP0whhb544iioSnumd3HJKL7dzhRegsMizatupp8D65A2JziW0WKopa1iw9fti3A aBeNN4ijKZchBXHPgVx+YtWRHfcm4l8= OpenPGP: url=https://posteo.de/keys/markus.probst@posteo.de.asc; preference=encrypt Implement the core abstractions needed for led class devices, including: * `led::LedOps` - the trait for handling leds, including `brightness_set`, `brightness_get` and `blink_set` * `led::DeviceBuilder` - the builder for the led class device * `led::Device` - a safe wrapper around `led_classdev` Signed-off-by: Markus Probst --- rust/kernel/led.rs | 265 ++++++++++++++++++++++++++++++++++++++++++= ++++ rust/kernel/led/normal.rs | 222 ++++++++++++++++++++++++++++++++++++++ rust/kernel/lib.rs | 1 + 3 files changed, 488 insertions(+) diff --git a/rust/kernel/led.rs b/rust/kernel/led.rs new file mode 100644 index 000000000000..deda8cc548a8 --- /dev/null +++ b/rust/kernel/led.rs @@ -0,0 +1,265 @@ +// SPDX-License-Identifier: GPL-2.0 + +//! Abstractions for the leds driver model. +//! +//! C header: [`include/linux/leds.h`](srctree/include/linux/leds.h) + +use core::{ + marker::PhantomData, + mem::transmute, + ptr::NonNull, // +}; + +use crate::{ + container_of, + device::{ + self, + property::FwNode, + Bound, // + }, + error::{ + from_result, + to_result, + VTABLE_DEFAULT_ERROR, // + }, + macros::vtable, + prelude::*, + str::CStrExt, + sync::aref::ARef, + types::Opaque, // +}; + +mod normal; + +pub use normal::Device; + +/// The name of the led is determined by the driver. +pub enum Named {} +/// The name of the led is determined by its fwnode. +pub enum Unnamed {} + +/// How the name of the led should be determined. +pub trait DeviceBuilderState: private::Sealed {} + +impl DeviceBuilderState for Named {} +impl private::Sealed for Named {} +impl DeviceBuilderState for Unnamed {} +impl private::Sealed for Unnamed {} + +/// The builder to register a led class device. +/// +/// See [`LedOps`]. +pub struct DeviceBuilder<'init, S> { + fwnode: Option>, + name: Option<&'init CStr>, + devicename: Option<&'init CStr>, + devname_mandatory: bool, + initial_brightness: u32, + color: Color, + _p: PhantomData, +} + +impl DeviceBuilder<'static, S> { + /// Creates a new [`DeviceBuilder`]. + #[inline] + #[expect( + clippy::new_without_default, + reason =3D "no need and derive is prevented by S" + )] + pub fn new() -> Self { + Self { + fwnode: None, + name: None, + devicename: None, + devname_mandatory: false, + initial_brightness: 0, + color: Color::default(), + _p: PhantomData, + } + } +} + +impl<'init> DeviceBuilder<'init, Unnamed> { + /// Sets the firmware node. + #[inline] + pub fn fwnode(self, fwnode: Option>) -> Self { + Self { fwnode, ..self } + } + + /// Sets the device name. + #[inline] + pub fn devicename(self, devicename: &'init CStr) -> Self { + Self { + devicename: Some(devicename), + ..self + } + } + + /// Sets if a device name is mandatory. + #[inline] + pub fn devicename_mandatory(self, mandatory: bool) -> Self { + Self { + devname_mandatory: mandatory, + ..self + } + } +} + +impl<'init, S: DeviceBuilderState> DeviceBuilder<'init, S> { + /// Sets the initial brightness value for the led. + /// + /// The default brightness is 0. + /// If [`LedOps::brightness_get`] is implemented, this value will be i= gnored. + #[inline] + pub fn initial_brightness(self, brightness: u32) -> Self { + Self { + initial_brightness: brightness, + ..self + } + } + + /// Sets the color of the led. + /// + /// This value can be overwritten by the "color" fwnode property. + #[inline] + pub fn color(self, color: Color) -> Self { + Self { color, ..self } + } +} + +impl<'init> DeviceBuilder<'init, Named> { + /// Sets the name of the led. + /// + /// Setting this will prevent the fwnode from being used and prevents = automatic name + /// composition. + #[inline] + pub fn name(self, name: &'init CStr) -> Self { + Self { + name: Some(name), + ..self + } + } +} + +/// Trait defining the operations for a LED driver. +/// +/// # Examples +/// ``` +/// use kernel::{ +/// led, +/// macros::vtable, +/// prelude::*, // +/// }; +/// +/// struct MyLedOps; +/// +/// +/// #[vtable] +/// impl led::LedOps for MyLedOps { +/// const BLOCKING: bool =3D false; +/// const MAX_BRIGHTNESS: u32 =3D 255; +/// +/// fn brightness_set<'bound>( +/// self: &led::Device<'bound, Self>, +/// _brightness: u32 +/// ) -> Result<()> { +/// // Set the brightness for the led here +/// Ok(()) +/// } +/// } +/// ``` +/// Led drivers must implement this trait in order to register and handle = a [`Device`]. +#[vtable] +pub trait LedOps: Send + Sync + Sized { + /// If set true, [`LedOps::brightness_set`] and [`LedOps::blink_set`] = must perform the + /// operation immediately. If set false, they must not sleep. + const BLOCKING: bool; + /// The max brightness level. + const MAX_BRIGHTNESS: u32; + + /// Sets the brightness level. + /// + /// See also [`LedOps::BLOCKING`]. + fn brightness_set<'bound>(self: &Device<'bound, Self>, brightness: u32= ) -> Result<()>; + + /// Gets the current brightness level. + fn brightness_get<'bound>(self: &Device<'bound, Self>) -> Result { + build_error!(VTABLE_DEFAULT_ERROR) + } + + /// Activates hardware accelerated blinking. + /// + /// delays are in milliseconds. If both are zero, a sensible default s= hould be chosen. + /// The caller should adjust the timings in that case and if it can't = match the values + /// specified exactly. Setting the brightness to 0 will disable the ha= rdware accelerated + /// blinking. + /// + /// See also [`LedOps::BLOCKING`]. + fn blink_set<'bound>( + self: &Device<'bound, Self>, + delay_on: &mut usize, + delay_off: &mut usize, + ) -> Result<()> { + let _ =3D (delay_on, delay_off); + build_error!(VTABLE_DEFAULT_ERROR) + } +} + +/// Led colors. +#[derive(Copy, Clone, Debug, Default, PartialEq, Eq)] +#[repr(u32)] +#[non_exhaustive] +#[expect( + missing_docs, + reason =3D "it shouldn't be necessary to document each color" +)] +pub enum Color { + #[default] + White =3D bindings::LED_COLOR_ID_WHITE, + Red =3D bindings::LED_COLOR_ID_RED, + Green =3D bindings::LED_COLOR_ID_GREEN, + Blue =3D bindings::LED_COLOR_ID_BLUE, + Amber =3D bindings::LED_COLOR_ID_AMBER, + Violet =3D bindings::LED_COLOR_ID_VIOLET, + Yellow =3D bindings::LED_COLOR_ID_YELLOW, + Ir =3D bindings::LED_COLOR_ID_IR, + Multi =3D bindings::LED_COLOR_ID_MULTI, + Rgb =3D bindings::LED_COLOR_ID_RGB, + Purple =3D bindings::LED_COLOR_ID_PURPLE, + Orange =3D bindings::LED_COLOR_ID_ORANGE, + Pink =3D bindings::LED_COLOR_ID_PINK, + Cyan =3D bindings::LED_COLOR_ID_CYAN, + Lime =3D bindings::LED_COLOR_ID_LIME, +} +static_assert!(bindings::LED_COLOR_ID_MAX =3D=3D 15); + +impl Color { + /// Name of the color + #[inline] + pub fn as_c_str(self) -> &'static CStr { + // SAFETY: + // - `self as u8` is a valid led color id. + // - `led_get_color_name` always returns a valid C string pointer. + unsafe { CStr::from_char_ptr(bindings::led_get_color_name(self as = u8)) } + } +} + +impl TryFrom for Color { + type Error =3D Error; + + fn try_from(value: u32) -> core::result::Result { + if value < bindings::LED_COLOR_ID_MAX { + // SAFETY: + // - `Color` is represented as `u32` + // - the static_assert above guarantees that no additional col= or has been added + // - `value` is guaranteed to be in the color id range + Ok(unsafe { transmute::(value) }) + } else { + Err(EINVAL) + } + } +} + +mod private { + pub trait Sealed {} +} diff --git a/rust/kernel/led/normal.rs b/rust/kernel/led/normal.rs new file mode 100644 index 000000000000..a22c29cfd262 --- /dev/null +++ b/rust/kernel/led/normal.rs @@ -0,0 +1,222 @@ +// SPDX-License-Identifier: GPL-2.0 + +//! Led mode for the `struct led_classdev`. +//! +//! C header: [`include/linux/leds.h`](srctree/include/linux/leds.h) + +use core::ops::Deref; + +use super::*; + +/// The led class device representation. +/// +/// This structure represents the Rust abstraction for a led class device. +#[pin_data(PinnedDrop)] +pub struct Device<'bound, T: 'bound =3D ()> { + #[pin] + ops: T, + #[pin] + classdev: Opaque, + _p: PhantomData<&'bound ()>, +} + +impl<'init, S: DeviceBuilderState> DeviceBuilder<'init, S> { + /// Registers a new [`Device`]. + pub fn build<'bound: 'init, T: LedOps + 'bound>( + self, + parent: &'bound device::Device, + ops: impl PinInit + 'init, + ) -> impl PinInit, Error> + 'init { + const_assert!(T::MAX_BRIGHTNESS <=3D i32::MAX.unsigned_abs() || !T= ::HAS_BRIGHTNESS_GET); + + try_pin_init!(Device { + ops <- ops, + classdev <- Opaque::try_ffi_init(|ptr: *mut bindings::led_clas= sdev| { + // SAFETY: `try_ffi_init` guarantees that `ptr` is valid f= or write. + // `led_classdev` gets fully initialized in-place by + // `led_classdev_register_ext` including `mutex` and `list= _head`. + unsafe { + ptr.write(bindings::led_classdev { + brightness_set: (!T::BLOCKING) + .then_some(Adapter::::brightness_set_callba= ck), + brightness_set_blocking: T::BLOCKING + .then_some(Adapter::::brightness_set_blocki= ng_callback), + brightness_get: T::HAS_BRIGHTNESS_GET + .then_some(Adapter::::brightness_get_callba= ck), + blink_set: T::HAS_BLINK_SET.then_some(Adapter::= ::blink_set_callback), + max_brightness: T::MAX_BRIGHTNESS, + brightness: self.initial_brightness, + color: self.color as u32, + name: self.name.map_or(core::ptr::null(), CStrExt:= :as_char_ptr), + ..bindings::led_classdev::default() + }) + }; + + let mut init_data =3D bindings::led_init_data { + fwnode: self + .fwnode + .as_ref() + .map_or(core::ptr::null_mut(), |fwnode| fwnode.as_= raw()), + default_label: core::ptr::null(), + devicename: self + .devicename + .map_or(core::ptr::null(), CStrExt::as_char_ptr), + devname_mandatory: self.devname_mandatory, + }; + + // SAFETY: + // - `parent.as_raw()` is guaranteed to be a pointer to a = valid `device`. + // - `ptr` is guaranteed to be a pointer to an initialized= `led_classdev`. + to_result(unsafe { + bindings::led_classdev_register_ext( + parent.as_raw(), + ptr, + if self.name.is_none() { + &raw mut init_data + } else { + core::ptr::null_mut() + }, + ) + })?; + + core::mem::forget(self.fwnode); // keep the reference coun= t incremented + + Ok::<_, Error>(()) + }), + _p: PhantomData, + }) + } +} + +impl<'bound, T: 'bound> Device<'bound, T> { + /// # Safety + /// `led_cdev` must be a valid pointer to a `led_classdev` embedded wi= thin a + /// `led::Device`. + #[inline] + unsafe fn from_raw<'a>(led_cdev: *mut bindings::led_classdev) -> &'a S= elf { + // SAFETY: The function's contract guarantees that `led_cdev` poin= ts to a `led_classdev` + // field embedded within a valid `led::Device`. `container_of!` ca= n therefore + // safely calculate the address of the containing struct. + unsafe { &*container_of!(Opaque::cast_from(led_cdev), Self, classd= ev) } + } +} + +impl<'bound, T: LedOps + 'bound> Deref for Device<'bound, T> { + type Target =3D T; + + fn deref(&self) -> &Self::Target { + &self.ops + } +} + +// SAFETY: A `led::Device` can be unregistered from any thread. +unsafe impl<'bound, T: 'bound + Send> Send for Device<'bound, T> {} + +// SAFETY: `led::Device` can be shared among threads because all methods o= f `led::Device` +// are thread safe. +unsafe impl<'bound, T: 'bound + Sync> Sync for Device<'bound, T> {} + +struct Adapter { + _p: PhantomData, +} + +impl Adapter { + /// # Safety + /// `led_cdev` must be a valid pointer to a `led_classdev` embedded wi= thin a + /// `led::Device`. + /// This function is called on setting the brightness of a led. + unsafe extern "C" fn brightness_set_callback( + led_cdev: *mut bindings::led_classdev, + brightness: u32, + ) { + // SAFETY: The function's contract guarantees that `led_cdev` is a= valid pointer to a + // `led_classdev` embedded within a `led::Device`. + let classdev =3D unsafe { Device::::from_raw(led_cdev) }; + + let _ =3D classdev.brightness_set(brightness); + } + + /// # Safety + /// `led_cdev` must be a valid pointer to a `led_classdev` embedded wi= thin a + /// `led::Device`. + /// This function is called on setting the brightness of a led immedia= tely. + unsafe extern "C" fn brightness_set_blocking_callback( + led_cdev: *mut bindings::led_classdev, + brightness: u32, + ) -> i32 { + from_result(|| { + // SAFETY: The function's contract guarantees that `led_cdev` = is a valid pointer to a + // `led_classdev` embedded within a `led::Device`. + let classdev =3D unsafe { Device::::from_raw(led_cdev) }; + + classdev.brightness_set(brightness)?; + Ok(0) + }) + } + + /// # Safety + /// `led_cdev` must be a valid pointer to a `led_classdev` embedded wi= thin a + /// `led::Device`. + /// This function is called on getting the brightness of a led. + unsafe extern "C" fn brightness_get_callback(led_cdev: *mut bindings::= led_classdev) -> u32 { + // SAFETY: The function's contract guarantees that `led_cdev` is a= valid pointer to a + // `led_classdev` embedded within a `led::Device`. + let classdev =3D unsafe { Device::::from_raw(led_cdev) }; + + // CAST: Resulting value will be casted back to i32 in the led sub= system. + from_result(|| { + classdev + .brightness_get() + .inspect(|val| debug_assert!(*val <=3D T::MAX_BRIGHTNESS)) + .and_then(|val| Ok(i32::try_from(val)?)) + }) as u32 + } + + /// # Safety + /// `led_cdev` must be a valid pointer to a `led_classdev` embedded wi= thin a + /// `led::Device`. + /// `delay_on` and `delay_off` must be valid pointers to `usize` and h= ave + /// exclusive access for the period of this function. + /// This function is called on enabling hardware accelerated blinking. + unsafe extern "C" fn blink_set_callback( + led_cdev: *mut bindings::led_classdev, + delay_on: *mut usize, + delay_off: *mut usize, + ) -> i32 { + from_result(|| { + // SAFETY: The function's contract guarantees that `led_cdev` = is a valid pointer to a + // `led_classdev` embedded within a `led::Device`. + let classdev =3D unsafe { Device::::from_raw(led_cdev) }; + + classdev.blink_set( + // SAFETY: The function's contract guarantees that `delay_= on` points to a `usize` + // and is exclusive for the period of this function. + unsafe { &mut *delay_on }, + // SAFETY: The function's contract guarantees that `delay_= off` points to a `usize` + // and is exclusive for the period of this function. + unsafe { &mut *delay_off }, + )?; + Ok(0) + }) + } +} + +#[pinned_drop] +impl<'bound, T: 'bound> PinnedDrop for Device<'bound, T> { + fn drop(self: Pin<&mut Self>) { + let raw =3D self.classdev.get(); + // SAFETY: The existence of `self` guarantees that `self.classdev.= get()` is a pointer to a + // valid `led_classdev`. + let dev: &device::Device =3D unsafe { device::Device::from_raw((*r= aw).dev) }; + + let _fwnode =3D dev + .fwnode() + // SAFETY: the reference count of `fwnode` has previously been + // incremented in `led::DeviceBuilder::build`. + .map(|fwnode| unsafe { ARef::from_raw(NonNull::from(fwnode)) }= ); + + // SAFETY: The existence of `self` guarantees that `self.classdev`= has previously been + // successfully registered with `led_classdev_register_ext`. + unsafe { bindings::led_classdev_unregister(raw) }; + } +} diff --git a/rust/kernel/lib.rs b/rust/kernel/lib.rs index 4d5c96ddc49c..748788ad131b 100644 --- a/rust/kernel/lib.rs +++ b/rust/kernel/lib.rs @@ -96,6 +96,7 @@ pub mod jump_label; #[cfg(CONFIG_KUNIT)] pub mod kunit; +pub mod led; pub mod list; pub mod maple_tree; pub mod miscdevice; --=20 2.55.0 From nobody Fri Sep 25 11:10:22 2026 Received: from mout01.posteo.de (mout01.posteo.de [185.67.36.65]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id B805C376A0A for ; Sun, 13 Sep 2026 16:15:30 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=185.67.36.65 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1789316133; cv=none; b=i6HMRIHQHgzRYsBN9v8JdtenacFUTHqONiNHirXIfG1do5wd0s1vx+5PIcsBfdRQfxSiY+ClIoUPip2ma+Ptrc8S2qN3ZA1VFQhY48AG/+3AZj48WivQ9ErH523CFP57zZupMzzD4RX1K9qNCdidreAiSTUdV6dPbTso8tvKXQ0= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1789316133; c=relaxed/simple; bh=nGlWCckWplXReJvD5In9Ul0BjlRCAccABtJ7zL4119w=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=TO1u+paeRiCar4NDbK8LUHnqs3bYlniIHW9CvPeKNOGV9sahS7CAOQlM/RnHBxhzxKhKrwXhuT3ZDTJJrKZVuZYJBwYiByj2ujLg3q8DomVgAYyVNEbig+wInNqLaSD/+Siw6nW7numC2eiTFjETXYwfs+ihiWGxvH4vUucx2KY= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=posteo.de; spf=pass smtp.mailfrom=posteo.de; dkim=pass (2048-bit key) header.d=posteo.de header.i=@posteo.de header.b=ejcfgALx; arc=none smtp.client-ip=185.67.36.65 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=posteo.de Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=posteo.de Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=posteo.de header.i=@posteo.de header.b="ejcfgALx" Received: from submission (posteo.de [185.67.36.169]) by mout01.posteo.de (Postfix) with ESMTPS id CB300240028 for ; Sun, 13 Sep 2026 18:15:28 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=posteo.de; s=1984.8680eb; t=1789316128; bh=zOXLDrWTt6vMg3DAwzxE1v5PRDK5diw3tSI+eXhQHm8=; h=From:Date:Subject:MIME-Version:Content-Type: Content-Transfer-Encoding:Message-Id:To:Cc:Autocrypt:OpenPGP:From; b=ejcfgALxAOxECmeefi51Ei2SOQz+XwNCOmVVUTSWOgu03kAFH51N1TlnwMSOMb93E y6qSNjp8hHWcxEUuqhc7xkO8EB6msAwhzzTMblGbFr9h2MyJRaqxgF6aHZ2afOotvK wbs9OEJ60LKasxawtBKhMhu5pGQJn0HMZcZjegBM2jeANvnRkYCa7Ab+88H+cFrG9s nDtHc/TK2g5duPQal7TJIrQZaJ8sCH/3Vcv/RFu4GjmuW2HYVb7H4Q5PIL22c4GVMG HzEZCg2vZsvv4ZhMWWVR1gz63a6biCnXxqw6z8kFiMUbtrHJCNMHQTowocH1lZn395 HPveNzljNMDvg== Received: from customer (localhost [127.0.0.1]) by submission (posteo.de) with ESMTPSA id 4hjYKS5CSTz9rxG; Sun, 13 Sep 2026 18:15:24 +0200 (CEST) From: Markus Probst Date: Sun, 13 Sep 2026 16:15:27 +0000 Subject: [PATCH v25 2/4] rust: leds: add Mode trait Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20260913-rust_leds-v25-2-1a10371d78c3@posteo.de> References: <20260913-rust_leds-v25-0-1a10371d78c3@posteo.de> In-Reply-To: <20260913-rust_leds-v25-0-1a10371d78c3@posteo.de> To: Lee Jones , Pavel Machek , Greg Kroah-Hartman , Dave Ertman , Leon Romanovsky , Miguel Ojeda , Alex Gaynor , Gary Guo , =?utf-8?q?Bj=C3=B6rn_Roy_Baron?= , Benno Lossin , Andreas Hindborg , Alice Ryhl , Trevor Gross , Danilo Krummrich , "Rafael J. Wysocki" , Bjorn Helgaas , =?utf-8?q?Krzysztof_Wilczy=C5=84ski?= , Boqun Feng , Daniel Almeida , Tamir Duberstein , Alexandre Courbot , =?utf-8?q?Onur_=C3=96zkan?= , Ira Weiny , Boqun Feng Cc: rust-for-linux@vger.kernel.org, linux-leds@vger.kernel.org, linux-kernel@vger.kernel.org, linux-pci@vger.kernel.org, Markus Probst X-Developer-Signature: v=1; a=openpgp-sha256; l=4284; i=markus.probst@posteo.de; h=from:subject:message-id; bh=nGlWCckWplXReJvD5In9Ul0BjlRCAccABtJ7zL4119w=; b=owEBiQJ2/ZANAwAIATR2H/jnrUPSAcsmYgBqpswVnPXmHQl09Kh3m0znWfjzvG1TCLN1WMJ2R lPIyggb8WOJAk8EAAEIADkWIQSCdBjE9KxY53IwxHM0dh/4561D0gUCaqbMFRsUgAAAAAAEAA5t YW51MiwyLjUrMS4xMiwyLDIACgkQNHYf+OetQ9Ih/BAAh++grf74LOmNBBlyMsez+69a2/xzY6B JTV818a1WUMB7XFZW7HsTxcukERzA4ximqh/b7dXRBTzPUmuA8aPMS0XPq3ryCAFsVdLSam3pzb PqnHtVyW3cVmnN4h8JER15YUXoJAwr9eFdX5GKmTFTIFvL1BacEDYWGWKXMx10FLdKVrrQVvBy/ XInTLJtKlnzWbax3Neh/SBIr9OaG3eGpw1VF0zSPSU0nKf6cAoZo4Vl4dJy5/Y1O+MPNNM8PGcg BTepYF0OzOKB44YF70yrkz8QV8e2bWf7mQaQHuUmPeoFR8QvZ9dPwoBdeaynN9SwKawU5FAYb4B XnzfBeD/4NBdFm6Lc0086zO/rCq8EAJlO7o7c0gRjhlsCRFOCxK0xDh9QEIZaFW2w96bt30FwIX Yp2u6J5kCbqH/3j0rsQJuExVR40bUORC0t4JhGGmI9RqN6aaMmLLqJ6fHN1l+CLcGVexee5bXMG Mc1v9LwlZ6O2g6Z7jaRu6PgT/Fs1wihxKYEMx5Ax3iGQ1MhCW/mqsutAoK1wMCkQEkIfX0+cJY3 144YZii33rrZYWFWFQwHs4rKFOhfvNQhDh+pTJDkO87jys3dmbHRfSRPzwvjkTL3VhXU2F7SfTN ZjxzecIX3myDjayNvwr1e2t6FTrb1Is8ObaX2FN8PI+1TxdrLM2E= X-Developer-Key: i=markus.probst@posteo.de; a=openpgp; fpr=827418C4F4AC58E77230C47334761FF8E7AD43D2 Autocrypt: addr=markus.probst@posteo.de; prefer-encrypt=mutual; keydata=xsFNBGiDvXgBEADAXUceKafpl46S35UmDh2wRvvx+UfZbcTjeQOlSwKP7YVJ4JOZrVs93qReNLkO WguIqPBxR9blQ4nyYrqSCV+MMw/3ifyXIm6Pw2YRUDg+WTEOjTixRCoWDgUj1nOsvJ9tVAm76Ww+ /pAnepVRafMID0rqEfD9oGv1YrfpeFJhyE2zUw3SyyNLIKWD6QeLRhKQRbSnsXhGLFBXCqt9k5JA RhgQof9zvztcCVlT5KVvuyfC4H+HzeGmu9201BVyihJwKdcKPq+n/aY5FUVxNTgtI9f8wIbmfAja oT1pjXSp+dszakA98fhONM98pOq723o/1ZGMZukyXFfsDGtA3BB79HoopHKujLGWAGskzClwTjRQ xBqxh/U/lL1pc+0xPWikTNCmtziCOvv0KA0arDOMQlyFvImzX6oGVgE4ksKQYbMZ3Ikw6L1Rv1J+ FvN0aNwOKgL2ztBRYscUGcQvA0Zo1fGCAn/BLEJvQYShWKeKqjyncVGoXFsz2AcuFKe1pwETSsN6 OZncjy32e4ktgs07cWBfx0v62b8md36jau+B6RVnnodaA8++oXl3FRwiEW8XfXWIjy4umIv93tb8 8ekYsfOfWkTSewZYXGoqe4RtK80ulMHb/dh2FZQIFyRdN4HOmB4FYO5sEYFr9YjHLmDkrUgNodJC XCeMe4BO4iaxUQARAQABzRdtYXJrdXMucHJvYnN0QHBvc3Rlby5kZcLBkQQTAQgAOxYhBIJ0GMT0 rFjncjDEczR2H/jnrUPSBQJog714AhsDBQsJCAcCAiICBhUKCQgLAgQWAgMBAh4HAheAAAoJEDR2 H/jnrUPSgdkQAISaTk2D345ehXEkn5z2yUEjaVjHIE7ziqRaOgn/QanCgeTUinIv6L6QXUFvvIfH 1OLPwQ1hfvEg9NnNLyFezWSy6jvoVBTIPqicD/r3FkithnQ1IDkdSjrarPMxJkvuh3l7XZHo49GV HQ8i5zh5w4YISrcEtE99lJisvni2Jqx7we5tey9voQFDyM8jxlSWv3pmoUTCtBkX/eKHJXosgsuS B4TGDCVPOjla/emI5c9MhMG7O4WEEmoSdPbmraPw66YZD6uLyhV4DPHbiDWRzXWnClHSyjB9rky9 lausFxogvu4l9H+KDsXIadNDWdLdu1/enS/wDd9zh5S78rY2jeXaG4mnf4seEKamZ7KQ6FIHrcyP ezdDzssPQcTQcGRMQzCn6wP3tlGk7rsfmyHMlFqdRoNNv+ZER/OkmZFPW655zRfbMi0vtrqK2Awm 9ggobb1oktfd9PPNXMUY+DNVlgR2G7jLnenSoQausLUm0pHoNE8TWFv851Y6SOYnvn488sP1Tki5 F3rKwclawQFHUXTCQw+QSh9ay8xgnNZfH+u9NY7w3gPoeKBOAFcBc2BtzcgekeWS8qgEmm2/oNFV G0ivPQbRx8FjRKbuF7g3YhgNZZ0ac8FneuUtJ2PkSIFTZhaAiC0utvxk0ndmWFiW4acEkMZGrLaM L2zWNjrqwsD2zsFNBGiDvXgBEADCXQy1n7wjRxG12DOVADawjghKcG+5LtEf31WftHKLFbp/HArj BhkT6mj+CCI1ClqY+FYU5CK/s0ScMfLxRGLZ0Ktzawb78vOgBVFT3yB1yWBTewsAXdqNqRooaUNo 8cG/NNJLjhccH/7PO/FWX5qftOVUJ/AIsAhKQJ18Tc8Ik73v427EDxuKb9mTAnYQFA3Ev3hAiVbO 6Rv39amVOfJ8sqwiSUGidj2Fctg2aB5JbeMln0KCUbTD1LhEFepeKypfofAXQbGwaCjAhmkWy/q3 IT1mUrPxOngbxdRoOx1tGUC0HCMUW1sFaJgQPMmDcR0JGPOpgsKnitsSnN7ShcCr1buel7vLnUMD +TAZ5opdoF6HjAvAnBQaijtK6minkrM0seNXnCg0KkV8xhMNa6zCs1rq4GgjNLJue2EmuyHooHA4 7JMoLVHcxVeuNTp6K2+XRx0Pk4e2Lj8IVy9yEYyrywEOC5XRW37KJjsiOAsumi1rkvM7QREWgUDe Xs0+RpxI3QrrANh71fLMRo7LKRF3Gvw13NVCCC9ea20P4PwhgWKStkwO2NO+YJsAoS1QycMi/vKu 0EHhknYXamaSV50oZzHKmX56vEeJHTcngrM8R1SwJCYopCx9gkz90bTVYlitJa5hloWTYeMD7FNj Y6jfVSzgM/K4gMgUNDW/PPGeMwARAQABwsF2BBgBCAAgFiEEgnQYxPSsWOdyMMRzNHYf+OetQ9IF AmiDvXgCGwwACgkQNHYf+OetQ9LHDBAAhk+ab8+WrbS/b1/gYW3q1KDiXU719nCtfkUVXKidW5Ec Idlr5HGt8ilLoxSWT2Zi368iHCXS0WenGgPwlv8ifvB7TOZiiTDZROZkXjEBmU4nYjJ7GymawpWv oQwjMsPuq6ysbzWtOZ7eILx7cI0FjQeJ/Q2baRJub0uAZNwBOxCkAS6lpk5Fntd2u8CWmDQo4SYp xeuQ+pwkp0yEP30RhN2BO2DXiBEGSZSYh+ioGbCHQPIV3iVj0h6lcCPOqopZqyeCfigeacBI0nvN jHWz/spzF3+4OS+3RJvoHtAQmProxyGib8iVsTxgZO3UUi4TSODeEt0i0kHSPY4sCciOyXfAyYoD DFqhRjOEwBBxhr+scU4C1T2AflozvDwq3VSONjrKJUkhd8+WsdXxMdPFgBQuiKKwUy11mz6KQfcR wmDehF3UaUoxa+YIhWPbKmycxuX/D8SvnqavzAeAL1OcRbEI/HsoroVlEFbBRNBZLJUlnTPs8ZcU 4+8rq5YX1GUrJL3jf6SAfSgO7UdkEET3PdcKFYtS+ruV1Cp5V0q4kCfI5jk25iiz8grM2wOzVSsc l1mEkhiEPH87HP0whhb544iioSnumd3HJKL7dzhRegsMizatupp8D65A2JziW0WKopa1iw9fti3A aBeNN4ijKZchBXHPgVx+YtWRHfcm4l8= OpenPGP: url=https://posteo.de/keys/markus.probst@posteo.de.asc; preference=encrypt Add the `led::Mode` trait to allow for other types of led class devices in `led::LedOps`. Signed-off-by: Markus Probst --- rust/kernel/led.rs | 37 ++++++++++++++++++++++++++----------- rust/kernel/led/normal.rs | 12 ++++++++++-- 2 files changed, 36 insertions(+), 13 deletions(-) diff --git a/rust/kernel/led.rs b/rust/kernel/led.rs index deda8cc548a8..7cd8f0504649 100644 --- a/rust/kernel/led.rs +++ b/rust/kernel/led.rs @@ -4,11 +4,7 @@ //! //! C header: [`include/linux/leds.h`](srctree/include/linux/leds.h) =20 -use core::{ - marker::PhantomData, - mem::transmute, - ptr::NonNull, // -}; +use core::{marker::PhantomData, mem::transmute, ops::Deref, ptr::NonNull}; =20 use crate::{ container_of, @@ -31,7 +27,10 @@ =20 mod normal; =20 -pub use normal::Device; +pub use normal::{ + Device, + Normal, // +}; =20 /// The name of the led is determined by the driver. pub enum Named {} @@ -156,6 +155,7 @@ pub fn name(self, name: &'init CStr) -> Self { /// /// #[vtable] /// impl led::LedOps for MyLedOps { +/// type Mode =3D led::Normal; /// const BLOCKING: bool =3D false; /// const MAX_BRIGHTNESS: u32 =3D 255; /// @@ -176,16 +176,21 @@ pub trait LedOps: Send + Sync + Sized { const BLOCKING: bool; /// The max brightness level. const MAX_BRIGHTNESS: u32; - /// Sets the brightness level. /// /// See also [`LedOps::BLOCKING`]. - fn brightness_set<'bound>(self: &Device<'bound, Self>, brightness: u32= ) -> Result<()>; - + fn brightness_set<'bound>( + self: &::Device<'bound, Self>, + brightness: u32, + ) -> Result<()>; /// Gets the current brightness level. - fn brightness_get<'bound>(self: &Device<'bound, Self>) -> Result { + fn brightness_get<'bound>(self: &::Device<'bound, = Self>) -> Result { build_error!(VTABLE_DEFAULT_ERROR) } + /// The led mode to use. + /// + /// See [`Mode`]. + type Mode: Mode; =20 /// Activates hardware accelerated blinking. /// @@ -196,7 +201,7 @@ fn brightness_get<'bound>(self: &Device<'bound, Self>) = -> Result { /// /// See also [`LedOps::BLOCKING`]. fn blink_set<'bound>( - self: &Device<'bound, Self>, + self: &::Device<'bound, Self>, delay_on: &mut usize, delay_off: &mut usize, ) -> Result<()> { @@ -260,6 +265,16 @@ fn try_from(value: u32) -> core::result::Result { } } =20 +/// The led mode. +/// +/// Each led mode has its own led class device type with different capabil= ities. +/// +/// See [`Normal`]. +pub trait Mode: private::Sealed { + /// The class device for the led mode. + type Device<'bound, T: LedOps + 'bound>: Deref; +} + mod private { pub trait Sealed {} } diff --git a/rust/kernel/led/normal.rs b/rust/kernel/led/normal.rs index a22c29cfd262..992353319522 100644 --- a/rust/kernel/led/normal.rs +++ b/rust/kernel/led/normal.rs @@ -8,6 +8,14 @@ =20 use super::*; =20 +/// The led mode for the `struct led_classdev`. Leds with this mode can on= ly have a fixed color. +pub enum Normal {} + +impl Mode for Normal { + type Device<'bound, T: LedOps + 'bound> =3D Device<'bou= nd, T>; +} +impl private::Sealed for Normal {} + /// The led class device representation. /// /// This structure represents the Rust abstraction for a led class device. @@ -22,7 +30,7 @@ pub struct Device<'bound, T: 'bound =3D ()> { =20 impl<'init, S: DeviceBuilderState> DeviceBuilder<'init, S> { /// Registers a new [`Device`]. - pub fn build<'bound: 'init, T: LedOps + 'bound>( + pub fn build<'bound: 'init, T: LedOps + 'bound>( self, parent: &'bound device::Device, ops: impl PinInit + 'init, @@ -120,7 +128,7 @@ struct Adapter { _p: PhantomData, } =20 -impl Adapter { +impl> Adapter { /// # Safety /// `led_cdev` must be a valid pointer to a `led_classdev` embedded wi= thin a /// `led::Device`. --=20 2.55.0 From nobody Fri Sep 25 11:10:22 2026 Received: from mout01.posteo.de (mout01.posteo.de [185.67.36.65]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 2AE26372B50 for ; Sun, 13 Sep 2026 16:15:33 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=185.67.36.65 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1789316140; cv=none; b=J40bPQ29d+eAglKAhWM9FzJP9/YgWZVQyb6IWO/Nlgn20Ua+cXsjDfUwdbhAwBeLTvNv9VKDizaOrJBYSiSYKOg3yHcpqtzu6bHLM0AXv6LZhSozvq7xGIhRBnA5PYeayJdiyTHBsWLhOtVWDcArPdkLlufe5EqgKxUIJI27LM0= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1789316140; c=relaxed/simple; bh=HxSkKW2bM+V+H68rbIkZH6yN3SqBMR4sqQTFWWuOvCQ=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=YQVXs4nkk8z6OLs2dT4hLDbBJUQG7roFiMQOSwJv+J0zZg44bbcYN3EbKmpwz3xy90sewQ7p7oFTPY6yjOUxfk6BKYxEnEUS2zaS59I3/qgjWAoq99yNQMupvlp1HMreqOeD2HP4RuGi2By7GL2rYKtUGmn8TOrEUv1NrzdgZDo= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=posteo.de; spf=pass smtp.mailfrom=posteo.de; dkim=pass (2048-bit key) header.d=posteo.de header.i=@posteo.de header.b=PVzPi8qN; arc=none smtp.client-ip=185.67.36.65 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=posteo.de Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=posteo.de Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=posteo.de header.i=@posteo.de header.b="PVzPi8qN" Received: from submission (posteo.de [185.67.36.169]) by mout01.posteo.de (Postfix) with ESMTPS id 85BD5240033 for ; Sun, 13 Sep 2026 18:15:31 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=posteo.de; s=1984.8680eb; t=1789316131; bh=yr1hPSR7JAgE9j+nBwDi229jABwzjGSoBuxusWr2eTs=; h=From:Date:Subject:MIME-Version:Content-Type: Content-Transfer-Encoding:Message-Id:To:Cc:Autocrypt:OpenPGP:From; b=PVzPi8qNyslXD+7M2ffg5BjM5DqM/7o0dFT6khJphYOrFoZHjOCpJTgzLHTg87UHY MHkIze4Z+Gj9/kRyU6Zx0Uh+Qe1DBAEID74O1jTqXtNrUZ/hf5bclxt4fD1X27wUQJ ri3CWMbfZwrXL1nuKPV1gGAbqairVFyH9p49mn/TQjt6kFRbZOG1S8FQ5NwE1j4z3o 25ZZnPsK6F4uwr863atbw1PvxlS7Y5/AiV/Hq9ZDUIB/wJLzOMI4XGcZTJ6ldBkQf+ 1lt5GzYbaz3i8MYP8+p1UOiKjicN3LkvXtauBaPbr1yb9rPUIuc74zEfhHOgvoL4jV mPnSodfikWKuw== Received: from customer (localhost [127.0.0.1]) by submission (posteo.de) with ESMTPSA id 4hjYKW3Y5fz9rxK; Sun, 13 Sep 2026 18:15:27 +0200 (CEST) From: Markus Probst Date: Sun, 13 Sep 2026 16:15:30 +0000 Subject: [PATCH v25 3/4] rust: leds: add multicolor classdev abstractions Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20260913-rust_leds-v25-3-1a10371d78c3@posteo.de> References: <20260913-rust_leds-v25-0-1a10371d78c3@posteo.de> In-Reply-To: <20260913-rust_leds-v25-0-1a10371d78c3@posteo.de> To: Lee Jones , Pavel Machek , Greg Kroah-Hartman , Dave Ertman , Leon Romanovsky , Miguel Ojeda , Alex Gaynor , Gary Guo , =?utf-8?q?Bj=C3=B6rn_Roy_Baron?= , Benno Lossin , Andreas Hindborg , Alice Ryhl , Trevor Gross , Danilo Krummrich , "Rafael J. Wysocki" , Bjorn Helgaas , =?utf-8?q?Krzysztof_Wilczy=C5=84ski?= , Boqun Feng , Daniel Almeida , Tamir Duberstein , Alexandre Courbot , =?utf-8?q?Onur_=C3=96zkan?= , Ira Weiny , Boqun Feng Cc: rust-for-linux@vger.kernel.org, linux-leds@vger.kernel.org, linux-kernel@vger.kernel.org, linux-pci@vger.kernel.org, Markus Probst X-Developer-Signature: v=1; a=openpgp-sha256; l=22223; i=markus.probst@posteo.de; h=from:subject:message-id; bh=HxSkKW2bM+V+H68rbIkZH6yN3SqBMR4sqQTFWWuOvCQ=; b=owEBiQJ2/ZANAwAIATR2H/jnrUPSAcsmYgBqpswVY47wE2wsy73vUjBGNYXpu0WXrS2Ev8P/x 2Sws7fF/jCJAk8EAAEIADkWIQSCdBjE9KxY53IwxHM0dh/4561D0gUCaqbMFRsUgAAAAAAEAA5t YW51MiwyLjUrMS4xMiwyLDIACgkQNHYf+OetQ9L+qw//aJz9wONjwwPGwiFm92FkEbwr7dBdkjw D9v7SYQTCb10jc3bvhWQHiSN9+1Yh5O2QJkSmSxFEWg8ZIxA7euHSUIvjx11EEaP4fmhjg+0foa oMo079q6vIcYNp3nnOfMI9kl34NF1OlZ0ALDfsdic/J390wboZb0f+b2pNKz8oA0SkoybYyN/nE yIUZy/1Uk5IgQyM57f6rj9ur6S5m+J04BW7tMuB3Tjh96R9Q0SR7YYBcMzKk+MQkv8JKHeIF1Hn 9UYUDHXUrnMSDCGeBt2vn3m9nEaONsasTTYjVr20/xYJwxFxvHpZCeDXCPD8ksBy5YqDYi9LtRu oUyybrbj3TA0CLP4O2qiUM3TrAunjVjJui8DF0RTUpqrSFQcOLEDqJP6DERFk0JQ4MFClS9CMw1 VJB/924x0mK5uLVb31M9WdN7aRag2XGwY7v9roHfN1qUlNAlccvj8fySVN69ZRcm31TCaC1kIgP 04KwnFedL6HuqGkX6rlTEvzd7THpb9hbOGjCgnUB/dAEyPR/K3Q1o0VHz7KzXku11R4rhplgnt2 7wDsT7QD8H6fhEIR36wdKw7zjaWGjvZswoB7Jrcl8MhuhuNVQE69/zFTAarCnv8G3Rqy2pIHsEP 68uekSQa8/Ogvjp0KMHVYXWoUs1Vwc9Bd4RZZfu0WrkHibCXpbQ0= X-Developer-Key: i=markus.probst@posteo.de; a=openpgp; fpr=827418C4F4AC58E77230C47334761FF8E7AD43D2 Autocrypt: addr=markus.probst@posteo.de; prefer-encrypt=mutual; keydata=xsFNBGiDvXgBEADAXUceKafpl46S35UmDh2wRvvx+UfZbcTjeQOlSwKP7YVJ4JOZrVs93qReNLkO WguIqPBxR9blQ4nyYrqSCV+MMw/3ifyXIm6Pw2YRUDg+WTEOjTixRCoWDgUj1nOsvJ9tVAm76Ww+ /pAnepVRafMID0rqEfD9oGv1YrfpeFJhyE2zUw3SyyNLIKWD6QeLRhKQRbSnsXhGLFBXCqt9k5JA RhgQof9zvztcCVlT5KVvuyfC4H+HzeGmu9201BVyihJwKdcKPq+n/aY5FUVxNTgtI9f8wIbmfAja oT1pjXSp+dszakA98fhONM98pOq723o/1ZGMZukyXFfsDGtA3BB79HoopHKujLGWAGskzClwTjRQ xBqxh/U/lL1pc+0xPWikTNCmtziCOvv0KA0arDOMQlyFvImzX6oGVgE4ksKQYbMZ3Ikw6L1Rv1J+ FvN0aNwOKgL2ztBRYscUGcQvA0Zo1fGCAn/BLEJvQYShWKeKqjyncVGoXFsz2AcuFKe1pwETSsN6 OZncjy32e4ktgs07cWBfx0v62b8md36jau+B6RVnnodaA8++oXl3FRwiEW8XfXWIjy4umIv93tb8 8ekYsfOfWkTSewZYXGoqe4RtK80ulMHb/dh2FZQIFyRdN4HOmB4FYO5sEYFr9YjHLmDkrUgNodJC XCeMe4BO4iaxUQARAQABzRdtYXJrdXMucHJvYnN0QHBvc3Rlby5kZcLBkQQTAQgAOxYhBIJ0GMT0 rFjncjDEczR2H/jnrUPSBQJog714AhsDBQsJCAcCAiICBhUKCQgLAgQWAgMBAh4HAheAAAoJEDR2 H/jnrUPSgdkQAISaTk2D345ehXEkn5z2yUEjaVjHIE7ziqRaOgn/QanCgeTUinIv6L6QXUFvvIfH 1OLPwQ1hfvEg9NnNLyFezWSy6jvoVBTIPqicD/r3FkithnQ1IDkdSjrarPMxJkvuh3l7XZHo49GV HQ8i5zh5w4YISrcEtE99lJisvni2Jqx7we5tey9voQFDyM8jxlSWv3pmoUTCtBkX/eKHJXosgsuS B4TGDCVPOjla/emI5c9MhMG7O4WEEmoSdPbmraPw66YZD6uLyhV4DPHbiDWRzXWnClHSyjB9rky9 lausFxogvu4l9H+KDsXIadNDWdLdu1/enS/wDd9zh5S78rY2jeXaG4mnf4seEKamZ7KQ6FIHrcyP ezdDzssPQcTQcGRMQzCn6wP3tlGk7rsfmyHMlFqdRoNNv+ZER/OkmZFPW655zRfbMi0vtrqK2Awm 9ggobb1oktfd9PPNXMUY+DNVlgR2G7jLnenSoQausLUm0pHoNE8TWFv851Y6SOYnvn488sP1Tki5 F3rKwclawQFHUXTCQw+QSh9ay8xgnNZfH+u9NY7w3gPoeKBOAFcBc2BtzcgekeWS8qgEmm2/oNFV G0ivPQbRx8FjRKbuF7g3YhgNZZ0ac8FneuUtJ2PkSIFTZhaAiC0utvxk0ndmWFiW4acEkMZGrLaM L2zWNjrqwsD2zsFNBGiDvXgBEADCXQy1n7wjRxG12DOVADawjghKcG+5LtEf31WftHKLFbp/HArj BhkT6mj+CCI1ClqY+FYU5CK/s0ScMfLxRGLZ0Ktzawb78vOgBVFT3yB1yWBTewsAXdqNqRooaUNo 8cG/NNJLjhccH/7PO/FWX5qftOVUJ/AIsAhKQJ18Tc8Ik73v427EDxuKb9mTAnYQFA3Ev3hAiVbO 6Rv39amVOfJ8sqwiSUGidj2Fctg2aB5JbeMln0KCUbTD1LhEFepeKypfofAXQbGwaCjAhmkWy/q3 IT1mUrPxOngbxdRoOx1tGUC0HCMUW1sFaJgQPMmDcR0JGPOpgsKnitsSnN7ShcCr1buel7vLnUMD +TAZ5opdoF6HjAvAnBQaijtK6minkrM0seNXnCg0KkV8xhMNa6zCs1rq4GgjNLJue2EmuyHooHA4 7JMoLVHcxVeuNTp6K2+XRx0Pk4e2Lj8IVy9yEYyrywEOC5XRW37KJjsiOAsumi1rkvM7QREWgUDe Xs0+RpxI3QrrANh71fLMRo7LKRF3Gvw13NVCCC9ea20P4PwhgWKStkwO2NO+YJsAoS1QycMi/vKu 0EHhknYXamaSV50oZzHKmX56vEeJHTcngrM8R1SwJCYopCx9gkz90bTVYlitJa5hloWTYeMD7FNj Y6jfVSzgM/K4gMgUNDW/PPGeMwARAQABwsF2BBgBCAAgFiEEgnQYxPSsWOdyMMRzNHYf+OetQ9IF AmiDvXgCGwwACgkQNHYf+OetQ9LHDBAAhk+ab8+WrbS/b1/gYW3q1KDiXU719nCtfkUVXKidW5Ec Idlr5HGt8ilLoxSWT2Zi368iHCXS0WenGgPwlv8ifvB7TOZiiTDZROZkXjEBmU4nYjJ7GymawpWv oQwjMsPuq6ysbzWtOZ7eILx7cI0FjQeJ/Q2baRJub0uAZNwBOxCkAS6lpk5Fntd2u8CWmDQo4SYp xeuQ+pwkp0yEP30RhN2BO2DXiBEGSZSYh+ioGbCHQPIV3iVj0h6lcCPOqopZqyeCfigeacBI0nvN jHWz/spzF3+4OS+3RJvoHtAQmProxyGib8iVsTxgZO3UUi4TSODeEt0i0kHSPY4sCciOyXfAyYoD DFqhRjOEwBBxhr+scU4C1T2AflozvDwq3VSONjrKJUkhd8+WsdXxMdPFgBQuiKKwUy11mz6KQfcR wmDehF3UaUoxa+YIhWPbKmycxuX/D8SvnqavzAeAL1OcRbEI/HsoroVlEFbBRNBZLJUlnTPs8ZcU 4+8rq5YX1GUrJL3jf6SAfSgO7UdkEET3PdcKFYtS+ruV1Cp5V0q4kCfI5jk25iiz8grM2wOzVSsc l1mEkhiEPH87HP0whhb544iioSnumd3HJKL7dzhRegsMizatupp8D65A2JziW0WKopa1iw9fti3A aBeNN4ijKZchBXHPgVx+YtWRHfcm4l8= OpenPGP: url=https://posteo.de/keys/markus.probst@posteo.de.asc; preference=encrypt Implement the abstractions needed for multicolor led class devices, including: * `led::MultiColor` - the led mode implementation * `MultiColorSubLed` - a safe wrapper arround `mc_subled` * `led::MultiColorDevice` - a safe wrapper around `led_classdev_mc` * `led::DeviceBuilder::build_multicolor` - a function to register a new multicolor led class device Signed-off-by: Markus Probst --- rust/bindings/bindings_helper.h | 1 + rust/kernel/led.rs | 34 ++- rust/kernel/led/multicolor.rs | 445 ++++++++++++++++++++++++++++++++++++= ++++ 3 files changed, 479 insertions(+), 1 deletion(-) diff --git a/rust/bindings/bindings_helper.h b/rust/bindings/bindings_helpe= r.h index 4b31aa7f432f..81a03985322a 100644 --- a/rust/bindings/bindings_helper.h +++ b/rust/bindings/bindings_helper.h @@ -69,6 +69,7 @@ #include #include #include +#include #include #include #include diff --git a/rust/kernel/led.rs b/rust/kernel/led.rs index 7cd8f0504649..b25a6f992a62 100644 --- a/rust/kernel/led.rs +++ b/rust/kernel/led.rs @@ -25,8 +25,16 @@ types::Opaque, // }; =20 +#[cfg(CONFIG_LEDS_CLASS_MULTICOLOR)] +mod multicolor; mod normal; =20 +#[cfg(CONFIG_LEDS_CLASS_MULTICOLOR)] +pub use multicolor::{ + MultiColor, + MultiColorDevice, + MultiColorSubLed, // +}; pub use normal::{ Device, Normal, // @@ -228,7 +236,24 @@ pub enum Color { Violet =3D bindings::LED_COLOR_ID_VIOLET, Yellow =3D bindings::LED_COLOR_ID_YELLOW, Ir =3D bindings::LED_COLOR_ID_IR, + #[cfg_attr( + CONFIG_LEDS_CLASS_MULTICOLOR, + doc =3D "Use this color for a [`MultiColor`] led." + )] + #[cfg_attr( + not(CONFIG_LEDS_CLASS_MULTICOLOR), + doc =3D "Use this color for a `MultiColor` led." + )] + /// If the led supports RGB, use [`Color::Rgb`] instead. Multi =3D bindings::LED_COLOR_ID_MULTI, + #[cfg_attr( + CONFIG_LEDS_CLASS_MULTICOLOR, + doc =3D "Use this color for a [`MultiColor`] led with rgb support." + )] + #[cfg_attr( + not(CONFIG_LEDS_CLASS_MULTICOLOR), + doc =3D "Use this color for a `MultiColor` led with rgb support." + )] Rgb =3D bindings::LED_COLOR_ID_RGB, Purple =3D bindings::LED_COLOR_ID_PURPLE, Orange =3D bindings::LED_COLOR_ID_ORANGE, @@ -269,7 +294,14 @@ fn try_from(value: u32) -> core::result::Result { /// /// Each led mode has its own led class device type with different capabil= ities. /// -/// See [`Normal`]. +#[cfg_attr( + CONFIG_LEDS_CLASS_MULTICOLOR, + doc =3D "See [`Normal`] and [`MultiColor`]." +)] +#[cfg_attr( + not(CONFIG_LEDS_CLASS_MULTICOLOR), + doc =3D "See [`Normal`] and `MultiColor`." +)] pub trait Mode: private::Sealed { /// The class device for the led mode. type Device<'bound, T: LedOps + 'bound>: Deref; diff --git a/rust/kernel/led/multicolor.rs b/rust/kernel/led/multicolor.rs new file mode 100644 index 000000000000..309487bdf38a --- /dev/null +++ b/rust/kernel/led/multicolor.rs @@ -0,0 +1,445 @@ +// SPDX-License-Identifier: GPL-2.0 + +//! Led mode for the `struct led_classdev_mc`. +//! +//! C header: [`include/linux/led-class-multicolor.h`](srctree/include/lin= ux/led-class-multicolor.h) + +use core::{ + cell::UnsafeCell, + num::NonZero, + ptr, // +}; + +use crate::types::ScopeGuard; + +use super::*; + +/// The led mode for the `struct led_classdev_mc`. Leds with this mode can= have multiple colors. +pub enum MultiColor {} +impl Mode for MultiColor { + type Device<'bound, T: LedOps + 'bound> =3D MultiColorD= evice<'bound, T>; +} +impl private::Sealed for MultiColor {} + +/// The multicolor sub led info representation. +/// +/// This structure represents the Rust abstraction for a C `struct mc_subl= ed`. +#[repr(C)] +#[derive(Debug)] +#[non_exhaustive] +pub struct MultiColorSubLed { + /// The color of the sub led + pub color: Color, + brightness: UnsafeCell, + intensity: UnsafeCell, + /// The maximum supported intensity value. + /// + /// If None the maximum intensity equals to [`LedOps::MAX_BRIGHTNESS`]. + pub max_intensity: Option>, + /// Arbitrary data for the driver to store. + pub channel: u32, +} + +// SAFETY: `MultiColorSubLed` can be shared among threads. +unsafe impl Sync for MultiColorSubLed {} + +impl Clone for MultiColorSubLed { + fn clone(&self) -> Self { + Self { + color: self.color, + brightness: self.brightness().into(), + intensity: self.intensity().into(), + max_intensity: self.max_intensity, + channel: self.channel, + } + } +} + +// We directly pass a reference to the `subled_info` field in `led_classde= v_mc` to the driver via +// `Device::subleds()`. +// We need safeguards to ensure `MultiColorSubLed` and `mc_subled` stay id= entical. +const _: () =3D { + use core::mem::offset_of; + + const fn assert_same_type(_: &T, _: &T) {} + + let rust_zeroed =3D MultiColorSubLed { + color: Color::White, + brightness: UnsafeCell::new(0), + intensity: UnsafeCell::new(0), + max_intensity: None, + channel: 0, + }; + let c_zeroed =3D bindings::mc_subled { + color_index: 0, + brightness: 0, + intensity: 0, + max_intensity: 0, + channel: 0, + }; + + assert!(offset_of!(MultiColorSubLed, color) =3D=3D offset_of!(bindings= ::mc_subled, color_index)); + assert!( + offset_of!(MultiColorSubLed, brightness) =3D=3D offset_of!(binding= s::mc_subled, brightness) + ); + assert!(offset_of!(MultiColorSubLed, intensity) =3D=3D offset_of!(bind= ings::mc_subled, intensity)); + assert!( + offset_of!(MultiColorSubLed, max_intensity) + =3D=3D offset_of!(bindings::mc_subled, max_intensity) + ); + assert!(offset_of!(MultiColorSubLed, channel) =3D=3D offset_of!(bindin= gs::mc_subled, channel)); + + assert_same_type(&0u32, &c_zeroed.color_index); + assert_same_type(&rust_zeroed.brightness.into_inner(), &c_zeroed.brigh= tness); + assert_same_type(&rust_zeroed.intensity.into_inner(), &c_zeroed.intens= ity); + assert!(size_of_val(&rust_zeroed.max_intensity) =3D=3D size_of_val(&c_= zeroed.max_intensity)); + assert_same_type(&rust_zeroed.channel, &c_zeroed.channel); + + assert!(size_of::() =3D=3D size_of::()); +}; + +impl MultiColorSubLed { + /// Create a new multicolor sub led info. + #[inline] + pub const fn new(color: Color) -> Self { + Self { + color, + brightness: UnsafeCell::new(0), + intensity: UnsafeCell::new(0), + max_intensity: None, + channel: 0, + } + } + + /// Set arbitrary data for the driver. + #[inline] + pub const fn channel(mut self, channel: u32) -> Self { + self.channel =3D channel; + self + } + + /// Set the initial intensity of the subled. + #[inline] + pub const fn initial_intensity(mut self, intensity: u32) -> Self { + self.intensity =3D UnsafeCell::new(intensity); + self + } + + /// Set the maximum supported intensity of the subled. + #[inline] + pub const fn max_intensity(mut self, max_intensity: NonZero) -> S= elf { + self.max_intensity =3D Some(max_intensity); + self + } + + /// The intensity of the sub led. + #[inline] + pub const fn intensity(&self) -> u32 { + // SAFETY: + // - `self.intensity.get()` is a valid pointer to `u32`. + // - We don't have exclusive or immutable access to `self.intensit= y`, + // but the alignment should prevent "load tearing". + unsafe { *self.intensity.get() } + } + + /// The brightness of the sub led. + #[inline] + pub const fn brightness(&self) -> u32 { + // SAFETY: + // - `self.brightness.get()` is a valid pointer to `u32`. + // - We don't have exclusive or immutable access to `self.brightne= ss`, + // but the alignment should prevent "load tearing". + unsafe { *self.brightness.get() } + } +} + +/// The multicolor led class device representation. +/// +/// This structure represents the Rust abstraction for a multicolor led cl= ass device. +#[pin_data(PinnedDrop)] +pub struct MultiColorDevice<'bound, T: 'bound =3D ()> { + #[pin] + ops: T, + #[pin] + classdev: Opaque, + _p: PhantomData<&'bound ()>, +} + +impl<'init, S: DeviceBuilderState> DeviceBuilder<'init, S> { + /// Registers a new [`MulticolorDevice`]. + pub fn build_multicolor<'bound: 'init, T: LedOps = + 'bound>( + self, + parent: &'bound device::Device, + ops: impl PinInit + 'init, + subleds: &'init [MultiColorSubLed], + ) -> impl PinInit, Error> + 'init { + const_assert!(T::MAX_BRIGHTNESS <=3D i32::MAX.unsigned_abs() || !T= ::HAS_BRIGHTNESS_GET); + + try_pin_init!(MultiColorDevice { + ops <- ops, + classdev <- Opaque::try_ffi_init(|ptr: *mut bindings::led_clas= sdev_mc| { + let mut colors =3D [false; bindings::LED_COLOR_ID_MAX as u= size]; + for subled in subleds { + if colors[subled.color as usize] { + dev_err!(parent.as_ref(), "duplicate color in mult= icolor led\n"); + return Err(EINVAL); + } + colors[subled.color as usize] =3D true; + } + let subleds_box =3D KBox::pin_slice( + |index| Ok::<_, Error>(subleds[index].clone()), + subleds.len(), + GFP_KERNEL, + )?; + let subleds_box_raw =3D KBox::into_raw(Pin::into_inner(sub= leds_box)); + + let subled_guard =3D ScopeGuard::new(|| { + // SAFETY: `subleds_box_raw` is guaranteed to be a val= id pointer to + // `[MultiColorSubLed]`. + drop(unsafe { >::from_raw(sub= leds_box_raw) }); + }); + + // SAFETY: `try_ffi_init` guarantees that `ptr` is valid f= or write. + // `led_classdev_mc` gets fully initialized in-place by + // `led_classdev_multicolor_register_ext` including `mutex= ` and `list_head`. + unsafe { + ptr.write(bindings::led_classdev_mc { + led_cdev: bindings::led_classdev { + brightness_set: (!T::BLOCKING) + .then_some(Adapter::::brightness_set_ca= llback), + brightness_set_blocking: T::BLOCKING + .then_some(Adapter::::brightness_set_bl= ocking_callback), + brightness_get: T::HAS_BRIGHTNESS_GET + .then_some(Adapter::::brightness_get_ca= llback), + blink_set: T::HAS_BLINK_SET.then_some(Adapter:= :::blink_set_callback), + max_brightness: T::MAX_BRIGHTNESS, + brightness: self.initial_brightness, + color: self.color as u32, + name: self.name.map_or(core::ptr::null(), CStr= Ext::as_char_ptr), + ..bindings::led_classdev::default() + }, + num_colors: u32::try_from(subleds_box_raw.len())?, + // CAST: The safeguards in the const block ensure = that + // `MultiColorSubLed` has an identical layout to `= mc_subled`. + subled_info: subleds_box_raw.cast::(), + }) + }; + + let mut init_data =3D bindings::led_init_data { + fwnode: self + .fwnode + .as_ref() + .map_or(core::ptr::null_mut(), |fwnode| fwnode.as_= raw()), + default_label: core::ptr::null(), + devicename: self + .devicename + .map_or(core::ptr::null(), CStrExt::as_char_ptr), + devname_mandatory: self.devname_mandatory, + }; + + // SAFETY: + // - `parent.as_ref().as_raw()` is guaranteed to be a poin= ter to a valid + // `device`. + // - `ptr` is guaranteed to be a pointer to an initialized= `led_classdev_mc`. + to_result(unsafe { + bindings::led_classdev_multicolor_register_ext( + parent.as_ref().as_raw(), + ptr, + if self.name.is_none() { + &raw mut init_data + } else { + core::ptr::null_mut() + }, + ) + })?; + + subled_guard.dismiss(); + + core::mem::forget(self.fwnode); // keep the reference coun= t incremented + + Ok::<_, Error>(()) + }), + _p: PhantomData, + }) + } +} + +impl<'bound, T: 'bound> MultiColorDevice<'bound, T> { + /// # Safety + /// `led_cdev` must be a valid pointer to a `led_classdev` embedded wi= thin a + /// `led::MultiColorDevice`. + #[inline] + unsafe fn from_raw<'a>(led_cdev: *mut bindings::led_classdev) -> &'a S= elf { + // SAFETY: The function's contract guarantees that `led_cdev` poin= ts to a `led_classdev` + // field embedded within a valid `led::MultiColorDevice`. `contain= er_of!` can therefore + // safely calculate the address of the containing struct. + let led_mc_cdev =3D unsafe { container_of!(led_cdev, bindings::led= _classdev_mc, led_cdev) }; + + // SAFETY: It is guaranteed that `led_mc_cdev` points to a `led_cl= assdev_mc` + // field embedded within a valid `led::MultiColorDevice`. `contain= er_of!` can therefore + // safely calculate the address of the containing struct. + unsafe { &*container_of!(Opaque::cast_from(led_mc_cdev), Self, cla= ssdev) } + } + + /// Returns the subleds passed to [`Device::new_multicolor`]. + #[inline] + pub fn subleds(&self) -> &[MultiColorSubLed] { + // SAFETY: The existence of `self` guarantees that `self.classdev.= get()` is a pointer to a + // valid `led_classdev_mc`. + let raw =3D unsafe { &*self.classdev.get() }; + // SAFETY: `raw.subled_info` is a valid pointer to `mc_subled[num_= colors]`. + // CAST: The safeguards in the const block ensure that `MultiColor= SubLed` has an identical + // layout to `mc_subled`. + unsafe { + core::slice::from_raw_parts( + raw.subled_info.cast::(), + // CAST: It is guaranteed that `num_colors` fits into an `= usize`. + raw.num_colors as usize, + ) + } + } +} + +impl<'bound, T: LedOps + 'bound> Deref for MultiColorDevice<'bound, T> { + type Target =3D T; + + fn deref(&self) -> &Self::Target { + &self.ops + } +} + +// SAFETY: A `led::MultiColorDevice` can be unregistered from any thread. +unsafe impl<'bound, T: 'bound + Send> Send for MultiColorDevice<'bound, T>= {} + +// SAFETY: `led::MultiColorDevice` can be shared among threads because all= methods of `led::Device` +// are thread safe. +unsafe impl<'bound, T: 'bound + Sync> Sync for MultiColorDevice<'bound, T>= {} + +struct Adapter> { + _p: PhantomData, +} + +impl> Adapter { + /// # Safety + /// `led_cdev` must be a valid pointer to a `led_classdev` embedded wi= thin a + /// `led::MultiColorDevice`. + /// This function is called on setting the brightness of a led. + unsafe extern "C" fn brightness_set_callback( + led_cdev: *mut bindings::led_classdev, + brightness: u32, + ) { + // SAFETY: The function's contract guarantees that `led_cdev` is a= valid pointer to a + // `led_classdev` embedded within a `led::MultiColorDevice`. + let classdev =3D unsafe { MultiColorDevice::::from_raw(led_cdev= ) }; + + // SAFETY: `classdev.classdev.get()` is guaranteed to be a pointer= to a valid + // `led_classdev_mc`. + unsafe { bindings::led_mc_calc_color_components(classdev.classdev.= get(), brightness) }; + + let _ =3D classdev.brightness_set(brightness); + } + + /// # Safety + /// `led_cdev` must be a valid pointer to a `led_classdev` embedded wi= thin a + /// `led::MultiColorDevice`. + /// This function is called on setting the brightness of a led immedia= tely. + unsafe extern "C" fn brightness_set_blocking_callback( + led_cdev: *mut bindings::led_classdev, + brightness: u32, + ) -> i32 { + from_result(|| { + // SAFETY: The function's contract guarantees that `led_cdev` = is a valid pointer to a + // `led_classdev` embedded within a `led::MultiColorDevice`. + let classdev =3D unsafe { MultiColorDevice::::from_raw(led_= cdev) }; + + // SAFETY: `classdev.classdev.get()` is guaranteed to be a poi= nter to a valid + // `led_classdev_mc`. + unsafe { bindings::led_mc_calc_color_components(classdev.class= dev.get(), brightness) }; + + classdev.brightness_set(brightness)?; + Ok(0) + }) + } + + /// # Safety + /// `led_cdev` must be a valid pointer to a `led_classdev` embedded wi= thin a + /// `led::MultiColorDevice`. + /// This function is called on getting the brightness of a led. + unsafe extern "C" fn brightness_get_callback(led_cdev: *mut bindings::= led_classdev) -> u32 { + // SAFETY: The function's contract guarantees that `led_cdev` is a= valid pointer to a + // `led_classdev` embedded within a `led::MultiColorDevice`. + let classdev =3D unsafe { MultiColorDevice::::from_raw(led_cdev= ) }; + + // CAST: Resulting value will be casted back to i32 in the led sub= system. + from_result(|| { + classdev + .brightness_get() + .inspect(|val| debug_assert!(*val <=3D T::MAX_BRIGHTNESS)) + .and_then(|val| Ok(i32::try_from(val)?)) + }) as u32 + } + + /// # Safety + /// `led_cdev` must be a valid pointer to a `led_classdev` embedded wi= thin a + /// `led::MultiColorDevice`. + /// `delay_on` and `delay_off` must be valid pointers to `usize` and h= ave + /// exclusive access for the period of this function. + /// This function is called on enabling hardware accelerated blinking. + unsafe extern "C" fn blink_set_callback( + led_cdev: *mut bindings::led_classdev, + delay_on: *mut usize, + delay_off: *mut usize, + ) -> i32 { + from_result(|| { + // SAFETY: The function's contract guarantees that `led_cdev` = is a valid pointer to a + // `led_classdev` embedded within a `led::MultiColorDevice`. + let classdev =3D unsafe { MultiColorDevice::::from_raw(led_= cdev) }; + + classdev.blink_set( + // SAFETY: The function's contract guarantees that `delay_= on` points to a `usize` + // and is exclusive for the period of this function. + unsafe { &mut *delay_on }, + // SAFETY: The function's contract guarantees that `delay_= off` points to a `usize` + // and is exclusive for the period of this function. + unsafe { &mut *delay_off }, + )?; + Ok(0) + }) + } +} + +#[pinned_drop] +impl<'bound, T: 'bound> PinnedDrop for MultiColorDevice<'bound, T> { + fn drop(self: Pin<&mut Self>) { + let raw =3D self.classdev.get(); + // SAFETY: The existence of `self` guarantees that `self.classdev.= get()` is a pointer to a + // valid `led_classdev_mc`. + let dev: &device::Device =3D unsafe { device::Device::from_raw((*r= aw).led_cdev.dev) }; + + let _fwnode =3D dev + .fwnode() + // SAFETY: the reference count of `fwnode` has previously been + // incremented in `led::DeviceBuilder::build_multicolor`. + .map(|fwnode| unsafe { ARef::from_raw(NonNull::from(fwnode)) }= ); + + // SAFETY: The existence of `self` guarantees that `self.classdev`= has previously been + // successfully registered with `led_classdev_multicolor_register_= ext`. + unsafe { bindings::led_classdev_multicolor_unregister(raw) }; + + // SAFETY: `raw` is guaranteed to be a valid pointer to `led_class= dev_mc`. + let led_cdev =3D unsafe { &*raw }; + + // SAFETY: `led_cdev.subled_info` is guaranteed to be a valid poin= ter to + // `[MultiColorSubLed]` with length of `led_cdev.num_colors`. + // See `led::DeviceBuilder::build_multicolor`. + drop(unsafe { + KBox::from_raw(ptr::slice_from_raw_parts_mut( + led_cdev.subled_info.cast::(), + // CAST: `num_colors` was originally converted from a `usi= ze` in + // `DeviceBuilder::build_multicolor`. Thus it is guarantee= d that + // `num_colors` fits into an usize. + led_cdev.num_colors as usize, + )) + }); + } +} --=20 2.55.0 From nobody Fri Sep 25 11:10:22 2026 Received: from mout02.posteo.de (mout02.posteo.de [185.67.36.66]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 1090E2F3632 for ; Sun, 13 Sep 2026 16:15:37 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=185.67.36.66 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1789316140; cv=none; b=LHesSZD10lKQDQFTIpvYsHpiDaWKtnkB8LxevIWm0Ac4YoDiJB9adX/Q/SUopTRetsJS5zdAqkTf7WqooH3F+8wMXwEFDSISdT+BhpcLqmILE3oUWobGUX2ZkaCvq07a5Hnxv1FvuMKNiODs7QbwYAsoOFhtAIyBNC8Q4dBvQbU= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1789316140; c=relaxed/simple; bh=nk2/+puSgSUGV8f7H3iOlqt9S+lnULltnh5QGWvWtOM=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=ItNL0E6tFqP67LcqlBkczPD3QomkQjGtSCrbYnW4yuAu0qATTd+blyV08Rr9WqT6y9cX98Srb5javowfNmm8iOclHJIV7HzmYF0ui46CSLeoKChu8ZoLR+qiyF2NsBrwY9Vd9hF7wazFfpZiEqrgoxWxL3rf6vTqBJ1DAzKer70= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=posteo.de; spf=pass smtp.mailfrom=posteo.de; dkim=pass (2048-bit key) header.d=posteo.de header.i=@posteo.de header.b=Yom/NGVw; arc=none smtp.client-ip=185.67.36.66 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=posteo.de Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=posteo.de Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=posteo.de header.i=@posteo.de header.b="Yom/NGVw" Received: from submission (posteo.de [185.67.36.169]) by mout02.posteo.de (Postfix) with ESMTPS id 52A23240108 for ; Sun, 13 Sep 2026 18:15:34 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=posteo.de; s=1984.8680eb; t=1789316134; bh=3fsceBp6cV1Cj/CzL9vzM2+bqceC8SgXDmD7BlTKzoA=; h=From:Date:Subject:MIME-Version:Content-Type: Content-Transfer-Encoding:Message-Id:To:Cc:Autocrypt:OpenPGP:From; b=Yom/NGVw+mv/Xh5Xengf87UhildUMO/JGHCo+aYx3GR4BVu9j1o9/ZuW3jEXqaX+n pTWafFeVqmBPDDHNPuDGT0W/ELs1UdreloHribRMok3fSiW5fP6EHm1ng+aNV7IyZ+ WN1tpi1lkra/VttYhDchHrQoWI7d4sTrhP7L62/SLvMxyqFJ3E8eped/YtV6QXRpRI +YWD3IOOOW6B0s7MY/zFyRr8Lq1sgD8DCg/YeNrCcN/x64EjI5bySOvWgBNssMZxe4 s+yyE5NU6MdBQz79kguRmaFHloUHfC1yXclGE26quKHC6I1aMkp5UCaSFF3mxCMaKC am3WVXFfY30Zg== Received: from customer (localhost [127.0.0.1]) by submission (posteo.de) with ESMTPSA id 4hjYKZ25nsz9rxB; Sun, 13 Sep 2026 18:15:30 +0200 (CEST) From: Markus Probst Date: Sun, 13 Sep 2026 16:15:33 +0000 Subject: [PATCH v25 4/4] MAINTAINERS: rust: leds: Add rust abstraction entry Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20260913-rust_leds-v25-4-1a10371d78c3@posteo.de> References: <20260913-rust_leds-v25-0-1a10371d78c3@posteo.de> In-Reply-To: <20260913-rust_leds-v25-0-1a10371d78c3@posteo.de> To: Lee Jones , Pavel Machek , Greg Kroah-Hartman , Dave Ertman , Leon Romanovsky , Miguel Ojeda , Alex Gaynor , Gary Guo , =?utf-8?q?Bj=C3=B6rn_Roy_Baron?= , Benno Lossin , Andreas Hindborg , Alice Ryhl , Trevor Gross , Danilo Krummrich , "Rafael J. Wysocki" , Bjorn Helgaas , =?utf-8?q?Krzysztof_Wilczy=C5=84ski?= , Boqun Feng , Daniel Almeida , Tamir Duberstein , Alexandre Courbot , =?utf-8?q?Onur_=C3=96zkan?= , Ira Weiny , Boqun Feng Cc: rust-for-linux@vger.kernel.org, linux-leds@vger.kernel.org, linux-kernel@vger.kernel.org, linux-pci@vger.kernel.org, Markus Probst X-Developer-Signature: v=1; a=openpgp-sha256; l=669; i=markus.probst@posteo.de; h=from:subject:message-id; bh=nk2/+puSgSUGV8f7H3iOlqt9S+lnULltnh5QGWvWtOM=; b=owEBiQJ2/ZANAwAIATR2H/jnrUPSAcsmYgBqpswV9My6uR4zhQNh6ZOFiXQjUAWUj4LUYg3eB 4HIlsft/pqJAk8EAAEIADkWIQSCdBjE9KxY53IwxHM0dh/4561D0gUCaqbMFRsUgAAAAAAEAA5t YW51MiwyLjUrMS4xMiwyLDIACgkQNHYf+OetQ9KfchAApMSU/q+pVB+ENC/NdVv2BGGmtiqYNS/ yAvKlRfQd6Wjlv4vqzKfDoqSDnFreLz/9QjzcssVOG3X5JQlgWYFnYzMFZXxP8ixXeNwdwdPmfK cn+Y7UkaJaecwakXhgZ4shHnz/hn/XZjvaYEgQVr0/dFnI1wmH8CLS2OSq57jCfXvFqFfWsa2HD /vCGeIAPq/cCj58KW5uszNNhnRol8vbPnVkdgPR2K1CGWZcydQse1QN4J4VV2sPYhe74b9SZbyz 2hWf+kXaxNJfN1Z5SEN1QVB3ru+ub7n9uiXq2tFcpGkaBNymfeetNRgjwK1f0zTzxS1M4avKlJr hyeJKH6PiInQQJcYUgWZrWI+/YmG3vkmnkZy0dfMaeLpb3grlH8dgA6rc9retq2j0fnIDVikh8D y4axCewh4VCOytpsF1yibMM+KNe0XE/d6lrntJS5BusS+P7X3L0b0lZ2BBbabLZLoTb69tpHADZ 3EROAHzt8rGBBXBpIiIie2qsueX4bdWRGQZbS8pFV5/Y5VtKJUdbiLQNGjc6rDqZuo+K5uDEiTk msXwHnP1LxDaySncZFM729mTOQ/hNgfqDlDdOFPUk7zVzsG1fR8tkE628Er1VL/D7PQWvu49k6i 25thRYxH5Mcjc+LNpGcO+jitm2bPrr9J4ei0KaqBtge7dJubWjlQ= X-Developer-Key: i=markus.probst@posteo.de; a=openpgp; fpr=827418C4F4AC58E77230C47334761FF8E7AD43D2 Autocrypt: addr=markus.probst@posteo.de; prefer-encrypt=mutual; keydata=xsFNBGiDvXgBEADAXUceKafpl46S35UmDh2wRvvx+UfZbcTjeQOlSwKP7YVJ4JOZrVs93qReNLkO WguIqPBxR9blQ4nyYrqSCV+MMw/3ifyXIm6Pw2YRUDg+WTEOjTixRCoWDgUj1nOsvJ9tVAm76Ww+ /pAnepVRafMID0rqEfD9oGv1YrfpeFJhyE2zUw3SyyNLIKWD6QeLRhKQRbSnsXhGLFBXCqt9k5JA RhgQof9zvztcCVlT5KVvuyfC4H+HzeGmu9201BVyihJwKdcKPq+n/aY5FUVxNTgtI9f8wIbmfAja oT1pjXSp+dszakA98fhONM98pOq723o/1ZGMZukyXFfsDGtA3BB79HoopHKujLGWAGskzClwTjRQ xBqxh/U/lL1pc+0xPWikTNCmtziCOvv0KA0arDOMQlyFvImzX6oGVgE4ksKQYbMZ3Ikw6L1Rv1J+ FvN0aNwOKgL2ztBRYscUGcQvA0Zo1fGCAn/BLEJvQYShWKeKqjyncVGoXFsz2AcuFKe1pwETSsN6 OZncjy32e4ktgs07cWBfx0v62b8md36jau+B6RVnnodaA8++oXl3FRwiEW8XfXWIjy4umIv93tb8 8ekYsfOfWkTSewZYXGoqe4RtK80ulMHb/dh2FZQIFyRdN4HOmB4FYO5sEYFr9YjHLmDkrUgNodJC XCeMe4BO4iaxUQARAQABzRdtYXJrdXMucHJvYnN0QHBvc3Rlby5kZcLBkQQTAQgAOxYhBIJ0GMT0 rFjncjDEczR2H/jnrUPSBQJog714AhsDBQsJCAcCAiICBhUKCQgLAgQWAgMBAh4HAheAAAoJEDR2 H/jnrUPSgdkQAISaTk2D345ehXEkn5z2yUEjaVjHIE7ziqRaOgn/QanCgeTUinIv6L6QXUFvvIfH 1OLPwQ1hfvEg9NnNLyFezWSy6jvoVBTIPqicD/r3FkithnQ1IDkdSjrarPMxJkvuh3l7XZHo49GV HQ8i5zh5w4YISrcEtE99lJisvni2Jqx7we5tey9voQFDyM8jxlSWv3pmoUTCtBkX/eKHJXosgsuS B4TGDCVPOjla/emI5c9MhMG7O4WEEmoSdPbmraPw66YZD6uLyhV4DPHbiDWRzXWnClHSyjB9rky9 lausFxogvu4l9H+KDsXIadNDWdLdu1/enS/wDd9zh5S78rY2jeXaG4mnf4seEKamZ7KQ6FIHrcyP ezdDzssPQcTQcGRMQzCn6wP3tlGk7rsfmyHMlFqdRoNNv+ZER/OkmZFPW655zRfbMi0vtrqK2Awm 9ggobb1oktfd9PPNXMUY+DNVlgR2G7jLnenSoQausLUm0pHoNE8TWFv851Y6SOYnvn488sP1Tki5 F3rKwclawQFHUXTCQw+QSh9ay8xgnNZfH+u9NY7w3gPoeKBOAFcBc2BtzcgekeWS8qgEmm2/oNFV G0ivPQbRx8FjRKbuF7g3YhgNZZ0ac8FneuUtJ2PkSIFTZhaAiC0utvxk0ndmWFiW4acEkMZGrLaM L2zWNjrqwsD2zsFNBGiDvXgBEADCXQy1n7wjRxG12DOVADawjghKcG+5LtEf31WftHKLFbp/HArj BhkT6mj+CCI1ClqY+FYU5CK/s0ScMfLxRGLZ0Ktzawb78vOgBVFT3yB1yWBTewsAXdqNqRooaUNo 8cG/NNJLjhccH/7PO/FWX5qftOVUJ/AIsAhKQJ18Tc8Ik73v427EDxuKb9mTAnYQFA3Ev3hAiVbO 6Rv39amVOfJ8sqwiSUGidj2Fctg2aB5JbeMln0KCUbTD1LhEFepeKypfofAXQbGwaCjAhmkWy/q3 IT1mUrPxOngbxdRoOx1tGUC0HCMUW1sFaJgQPMmDcR0JGPOpgsKnitsSnN7ShcCr1buel7vLnUMD +TAZ5opdoF6HjAvAnBQaijtK6minkrM0seNXnCg0KkV8xhMNa6zCs1rq4GgjNLJue2EmuyHooHA4 7JMoLVHcxVeuNTp6K2+XRx0Pk4e2Lj8IVy9yEYyrywEOC5XRW37KJjsiOAsumi1rkvM7QREWgUDe Xs0+RpxI3QrrANh71fLMRo7LKRF3Gvw13NVCCC9ea20P4PwhgWKStkwO2NO+YJsAoS1QycMi/vKu 0EHhknYXamaSV50oZzHKmX56vEeJHTcngrM8R1SwJCYopCx9gkz90bTVYlitJa5hloWTYeMD7FNj Y6jfVSzgM/K4gMgUNDW/PPGeMwARAQABwsF2BBgBCAAgFiEEgnQYxPSsWOdyMMRzNHYf+OetQ9IF AmiDvXgCGwwACgkQNHYf+OetQ9LHDBAAhk+ab8+WrbS/b1/gYW3q1KDiXU719nCtfkUVXKidW5Ec Idlr5HGt8ilLoxSWT2Zi368iHCXS0WenGgPwlv8ifvB7TOZiiTDZROZkXjEBmU4nYjJ7GymawpWv oQwjMsPuq6ysbzWtOZ7eILx7cI0FjQeJ/Q2baRJub0uAZNwBOxCkAS6lpk5Fntd2u8CWmDQo4SYp xeuQ+pwkp0yEP30RhN2BO2DXiBEGSZSYh+ioGbCHQPIV3iVj0h6lcCPOqopZqyeCfigeacBI0nvN jHWz/spzF3+4OS+3RJvoHtAQmProxyGib8iVsTxgZO3UUi4TSODeEt0i0kHSPY4sCciOyXfAyYoD DFqhRjOEwBBxhr+scU4C1T2AflozvDwq3VSONjrKJUkhd8+WsdXxMdPFgBQuiKKwUy11mz6KQfcR wmDehF3UaUoxa+YIhWPbKmycxuX/D8SvnqavzAeAL1OcRbEI/HsoroVlEFbBRNBZLJUlnTPs8ZcU 4+8rq5YX1GUrJL3jf6SAfSgO7UdkEET3PdcKFYtS+ruV1Cp5V0q4kCfI5jk25iiz8grM2wOzVSsc l1mEkhiEPH87HP0whhb544iioSnumd3HJKL7dzhRegsMizatupp8D65A2JziW0WKopa1iw9fti3A aBeNN4ijKZchBXHPgVx+YtWRHfcm4l8= OpenPGP: url=https://posteo.de/keys/markus.probst@posteo.de.asc; preference=encrypt Add self as maintainer. Signed-off-by: Markus Probst --- MAINTAINERS | 8 ++++++++ 1 file changed, 8 insertions(+) diff --git a/MAINTAINERS b/MAINTAINERS index 3a19da74d00c..54931e850570 100644 --- a/MAINTAINERS +++ b/MAINTAINERS @@ -14795,6 +14795,14 @@ F: drivers/leds/ F: include/dt-bindings/leds/ F: include/linux/leds.h =20 +LED SUBSYSTEM [RUST] +M: Markus Probst +L: linux-leds@vger.kernel.org +L: rust-for-linux@vger.kernel.org +S: Maintained +F: rust/kernel/led.rs +F: rust/kernel/led/ + LEGO MINDSTORMS EV3 R: David Lechner S: Maintained --=20 2.55.0