From nobody Fri Sep 25 10:38:01 2026 Received: from mx0a-0031df01.pphosted.com (mx0a-0031df01.pphosted.com [205.220.168.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 3D09236212E for ; Mon, 14 Sep 2026 03:43:19 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.168.131 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1789357400; cv=none; b=thYNPtiLyVgasMvDQBfK4q+EegHI3RgaBJoUj4s4LsvMKe657YaoDvfXKCc/bzUK7od/zOD0804qH0E/YWLf0DpyoTnQuE19FKtV4NEnxVX3Cu+ZDxvgPhhS+1k+IeCHEpbV4WHyEcmOELyW5mQ90K/t1vTfkvy4472qAiG7ILQ= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1789357400; c=relaxed/simple; bh=a5tHGTQShG2w+WKWXO+i1nzfM89k+Y3Nf27mhlT4GlA=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=m34Q/xj8+05zp4FADO0fLtd+hU+D5/uuhXmHAiLnLc0421p6mH2blcjQbjrhTvgaXSqfEbKq8ZtA3PfRP44mK6I+pt55C3y/qe3nUr8dXZRvFuwab8m0Oq3M3SqXs/YTr+MyZJSF0T2Na/Z9kd/YzEhdwrMJQT7J4hvBE3nW9Xs= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=V44TGmif; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=R9alZy+H; arc=none smtp.client-ip=205.220.168.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="V44TGmif"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="R9alZy+H" Received: from pps.filterd (m0279862.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 68E2eRhT2982729 for ; Mon, 14 Sep 2026 03:43:18 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= FLXqIO4EZyno+kGY0hlJ6AQH1Bxjk8Rbfc2b3Iql1sc=; b=V44TGmifzFV8XnT1 S2atvIZsWHVrnv6wPl9uakSAZ1Q94SUgFEZHVF7q6/pNqGZwDgoGxXiiFJVJ1C7E hOXxgas6JMgXatqszZpQeavHMAvhwNFHz5dwX1fLU45zSS/A4bVN3YA5pBzG3Fgi c5ZvJfiKVKWnuDcIeXS67iXwRDWcsCKWC/vJYqzxm/aJsYkdOFicnyVsn1C1zc7p 22ATEPaXGJkRmFi/PGiWe0/p3ru66U4PZVF5YtO1GoNXaWyorHjCcjmnYYXVzlVL OwzdX6Gl6zXby38WKpMSpzTb+te+nP3Sx5YfM32b/3OP3wjHMC6YQUZ0xVUS21CH u6Fdtw== Received: from mail-pj1-f71.google.com (mail-pj1-f71.google.com [209.85.216.71]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4gmygd4xbs-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Mon, 14 Sep 2026 03:43:18 +0000 (GMT) Received: by mail-pj1-f71.google.com with SMTP id 98e67ed59e1d1-398d3a12589so1015466a91.1 for ; Sun, 13 Sep 2026 20:43:18 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1789357398; x=1789962198; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :content-type:mime-version:subject:date:from:from:to:cc:subject:date :message-id:reply-to:content-type; bh=FLXqIO4EZyno+kGY0hlJ6AQH1Bxjk8Rbfc2b3Iql1sc=; b=R9alZy+HismUCRf1eIBmqkBq8RE0CT/EZIG4ReQNmSbivuVHTA4Vffl7iM0cbBGgR2 bQW//m5lmV1hdVqtkUfQ+opg/cgneSgL428oQjFhVh/mVLJDtnZ7Lb0scfKjhvvETBvT TlERuKgYL1Qyncco5O05TmXOYTUgPp7RQYfhuEeadKPrFVvHoLBl5xpSb4BEkLzl0X5q /Koe5BsKBhGf1KoRREDGHSMv6LYFgOZ31ZbMKG6THJmGcNSLwwJAVg6yb7nrkFnO/i6m hvcOwanJoPLlSnx9IyEqp7/DBJ6ya/xsEzzkNriY3OvR1Mt56v4x4nhX8nqbTlbC52gS NUWA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1789357398; x=1789962198; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :content-type:mime-version:subject:date:from:x-gm-gg :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to :content-type; bh=FLXqIO4EZyno+kGY0hlJ6AQH1Bxjk8Rbfc2b3Iql1sc=; b=c1rrdWfc92Sesyz+5pofCiBfMhGC2pf58fA1Gno1dqzFViNfB3hf/ycAHFmtISyubo taOAP0aO8GPoH1mxigFFV1bVuc6bx0a5PgLuGclHklaYSClCg5MnYURZxiGy/LWjcNJ0 1BD5uxIdbACWr6BfuiaXbY2vs521hNGote7UOcTmDlT79ggQ4NSu2v2VDmVUlABEZ0hQ JJ6NyqRyjr0ImRGJ9yIzLaDkOgIOlYatYjIw42GPOTJVSDJG0DkHD5dVz5cqjd/SMWW7 1SYbiXoR/Kx/quumR2A1gIvs6z9JrI2K/MIWQy2mL0pVU8DxOA3OSgLaPhEjDBMxKsf4 NJnw== X-Forwarded-Encrypted: i=1; AKwUvByv6PaP0CHoqxB8bpzBRp8E+ZfG4V1rD64YCr+Nom0YZdw5Y/JZedJrjsqlgpYmiMPjLVq/ulJIyH5vBlc=@vger.kernel.org X-Gm-Message-State: AFuF++lUY6uMAMWWByXBgNQUJW7vtRTtSG7Ve04HaNgN4k4VlfZVPuFB oNc/ww2rg+fMsGldmprk7Rn4HNCcwIeHQhvkuHwuqG7zkJQk0rujcRtzymy+GqqIAAPQevROK7Y s415xholrbxQ9R5R9yZqv0fSnzVHAbCKkTHMQmvOZzOxGn7n5d4gAx+O/kW1GaGSgEI8= X-Gm-Gg: AYBFou1NYj2IMPy/Xt8P5YT/Hk7fxcNzUyGtDVTqYVeqMGdm21gNOgq+BFTyHmNOVde NzZSx/1MTNZvdxSoz0o43yHLUnAtDUR6ycMv0LHuC6R4armCajq4eV1eaWgU6wATyU3Me1vH90p M/jahTv9TqZ5SHOwu0eT/c3NqzL3G8ZZarmf4jJxO9rTKUwQa4BOpBTVIy0XFbs7FqqOhsDNO7d NtgU7gvDoUfy6Vr3p7e8xBbRO9XSrEvMXDbYdm486VG/Td86JNOod8Sgyp0I5hJVvalJ/0348gP g2OYuGYztRGNvk+4yFa2UDW2Ic2pOgXSymwM9+nK6l4D7GWr6ZLcklveCBwRypPsatlfQa4Lza5 LdDXpjyZQJY9ZEje9rXUsae36se3mBL7PnpOVBnLBMT3uanI= X-Received: by 2002:a17:90b:390f:b0:38e:76f8:fcbb with SMTP id 98e67ed59e1d1-39dec1aa1cbmr1094568a91.4.1789357397904; Sun, 13 Sep 2026 20:43:17 -0700 (PDT) X-Received: by 2002:a17:90b:390f:b0:38e:76f8:fcbb with SMTP id 98e67ed59e1d1-39dec1aa1cbmr1094545a91.4.1789357397450; Sun, 13 Sep 2026 20:43:17 -0700 (PDT) Received: from hu-zijuhu-lv.qualcomm.com (Global_NAT1.qualcomm.com. [129.46.96.20]) by smtp.gmail.com with ESMTPSA id 5a478bee46e88-33ba4ee07f2sm21250894eec.18.2026.09.13.20.43.16 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 13 Sep 2026 20:43:16 -0700 (PDT) From: Zijun Hu Date: Sun, 13 Sep 2026 20:42:56 -0700 Subject: [PATCH 1/4] Bluetooth: coredump: Fix skb leak in hci_devcd_append() stub Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20260913-misc_fix-v1-1-558c1e4028b9@oss.qualcomm.com> References: <20260913-misc_fix-v1-0-558c1e4028b9@oss.qualcomm.com> In-Reply-To: <20260913-misc_fix-v1-0-558c1e4028b9@oss.qualcomm.com> To: Marcel Holtmann , Luiz Augusto von Dentz , Abhishek Pandit-Subedi , Manish Mandlik Cc: Zijun Hu , Luiz Augusto von Dentz , linux-bluetooth@vger.kernel.org, linux-kernel@vger.kernel.org, Zijun Hu X-Mailer: b4 0.15.2 X-Authority-Analysis: v=2.4 cv=RY0FmFtv c=1 sm=1 tr=0 ts=6aa76d56 cx=c_pps a=UNFcQwm+pnOIJct1K4W+Mw==:117 a=ouPCqIW2jiPt+lZRy3xVPw==:17 a=IkcTkHD0fZMA:10 a=VdqzKS8jKosA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=_K5XuSEh1TEqbUxoQ0s3:22 a=EUspDBNiAAAA:8 a=K11JH97qNKem9avEOwIA:9 a=QEXdDO2ut3YA:10 a=uKXjsCUrEbL0IQVhDsJ9:22 X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwOTE0MDA0OSBTYWx0ZWRfX1xDCiahkDepM yCupUKabOQlCnayAlfVf45ax//u4/IuxWfR6OYnvUzw5Knzw0kVUFJlJKcDyBc75KcdlYdJ9WIK AWYEdvgAto1Sn61DkzxxuldX3lk6IzyJ/BhgFcEOxxPTZ/4H66sX7gEDd51b81Pi1O8cUxM/+9H 1AS3bKF5btphCJcNbPjIxCM9Dy03GcuDfdpxHpCrCNhpKHYHnAny6nR1G+NS+rc9QwLIgT3w3tW //Jdd6Ffmy5fnD4mxOGTIPmzA2kFQfOmXbvQVBZu0E3EOt7aFdbEiznofUS8086JD+O4s7q8eID p6M429TG8fE5e1lRo6uqtI7opKIZezl4w95e9YDl92inYOCiq5DfRa7EoEEu8PcnjlR0g7n0jN2 FkUY8IMkGbxFVIIMaU755mrskBQVm4OHep0MoJli1heXv045PPuPgkFiQsxQV6aGqW4eDyyy0ZN bLMjiwqv0D5lYJ6LuEg== X-Proofpoint-ORIG-GUID: o7r1l7EBY7zf34YCwCGZ307186PiK61B X-Proofpoint-Spam-Info: AW1haW4tMjYwOTE0MDA0OSBTYWx0ZWRfX5VRcNism1yic XFFPRVz9Cg1FCkeu7Q+q8VDW+zqReMsTt04mvkfF4yvyQ33a1bYzy9J+pq87PPLDgflR+OUwYux im6vz6zbe3tsgCXE7RHBB9tqKpi9H1I= X-Proofpoint-GUID: o7r1l7EBY7zf34YCwCGZ307186PiK61B X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1176,Hydra:6.1.134,FMLib:17.12.100.49 definitions=2026-09-14_01,2026-09-13_01,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 clxscore=1015 priorityscore=1501 spamscore=0 suspectscore=0 lowpriorityscore=0 impostorscore=0 phishscore=0 malwarescore=0 bulkscore=0 adultscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2609040000 definitions=main-2609140049 For hci_devcd_append(hdev, skb): it consumes the skb when CONFIG_DEV_COREDUMP=3Dy, but its stub does not free the skb. this inconsistency causes skb leak when CONFIG_DEV_COREDUMP=3Dn. NXP btuart device driver encounters this leak: btnxpuart.c: nxp_process_fw_dump(hdev, skb) { ... // the skb_clone() is leaked. err =3D hci_devcd_append(hdev, skb_clone(skb, GFP_ATOMIC)); if (err < 0) goto free_skb; ... free_skb: kfree_skb(skb); /* frees the original, not the clone */ return 0; } Fix by freeing the skb in the stub to keep consistent behavior. Fixes: 9695ef876fd1 ("Bluetooth: Add support for hci devcoredump") Signed-off-by: Zijun Hu --- include/net/bluetooth/coredump.h | 1 + 1 file changed, 1 insertion(+) diff --git a/include/net/bluetooth/coredump.h b/include/net/bluetooth/cored= ump.h index acc1849f66c0..07940a1d5dd4 100644 --- a/include/net/bluetooth/coredump.h +++ b/include/net/bluetooth/coredump.h @@ -103,16 +103,17 @@ static inline int hci_devcd_register(struct hci_dev *= hdev, coredump_t coredump, =20 static inline int hci_devcd_init(struct hci_dev *hdev, u32 dump_size) { return -EOPNOTSUPP; } =20 static inline int hci_devcd_append(struct hci_dev *hdev, struct sk_buff *s= kb) { + kfree_skb(skb); return -EOPNOTSUPP; } =20 static inline int hci_devcd_append_pattern(struct hci_dev *hdev, u8 pattern, u32 len) { return -EOPNOTSUPP; } --=20 2.34.1 From nobody Fri Sep 25 10:38:01 2026 Received: from mx0a-0031df01.pphosted.com (mx0a-0031df01.pphosted.com [205.220.168.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id B25853655FA for ; Mon, 14 Sep 2026 03:43:20 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.168.131 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1789357402; cv=none; b=i1OfDFrcWNNdakQ9ClVwPlxll3WZZoPIxRNfty+UvnFDG/MEr0HsWDalUIfeuinUsL+2PNsXDIDd1No6ELsmDMOwbw3XaEruAQnuGvPKkgOzrtsuVUs/+EbxE5h9/MPsz8GT/uZq9uD2vufJHrVSduaMNKOL8m0Fl2UfcYc5dHg= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1789357402; c=relaxed/simple; bh=0DJphAlLU4Lqq36X7R5fjqAeZSPkUOxhBf+KhiipwAw=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=NtLaaxS/Q54UAeX2iItNSMMsaaGoTNdQzcfEh8BVW1hbvkMyUwCO/dRnWCBthq79Zi6IbHTSZD7qvxLM5IyjszRIh5hCG8+i1V3R9ClayPcoFlGY0LXhw0/rn8ylsO8WLKh5uNhfxnND9k+BfCPTF8PUGe/vaVn/pjmi9qrg52s= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=NWLBXXSp; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=cnRAiMsN; arc=none smtp.client-ip=205.220.168.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="NWLBXXSp"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="cnRAiMsN" Received: from pps.filterd (m0279864.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 68E2fUCj2243248 for ; Mon, 14 Sep 2026 03:43:20 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= GAsbxYca6VjWpMbSwguYm2YOe+ZCO4Pw6f1i4SctU5c=; b=NWLBXXSpLxZgDioU +NPIKIEO9L4JyP0OPnx0JOuCXzwT2qIA76HXXvko4tn8xnE6MBjaWapmh/fwA0Yn NsAQPnccB8b7LLPASjtOdWu3oaD4LJECVZLvhqq1x15Rt2xTWcdT1zQEj31mFHNw NlaBBCmvAscqDwwc1h//fPbXWwuHv+yBRTKsEDFLNaMpCXHJ0MhdFZWk1FaFLeNl FxDqf5wBpPW2RztQlSgSJKzXU/oVDvKI34kLAojzUFixaP6usZcN7+I/wEonEIpS s6w3QBd4Bw2CFp5HIXkMfJsdSateEu+O067N1Trtj5+sa35NoOwSniFPC8MYPFJ0 C4RMew== Received: from mail-pj1-f70.google.com (mail-pj1-f70.google.com [209.85.216.70]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4gmywh4rnv-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Mon, 14 Sep 2026 03:43:19 +0000 (GMT) Received: by mail-pj1-f70.google.com with SMTP id 98e67ed59e1d1-399271df9d8so753768a91.2 for ; Sun, 13 Sep 2026 20:43:19 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1789357399; x=1789962199; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :content-type:mime-version:subject:date:from:from:to:cc:subject:date :message-id:reply-to:content-type; bh=GAsbxYca6VjWpMbSwguYm2YOe+ZCO4Pw6f1i4SctU5c=; b=cnRAiMsNxQZWAN7w40OH8IUeVnM59j9xPCkawDxdbZobEfVhnIY+tuukc1PlB8Pkq9 awnHMRmwtHJrbHD22pcZRUeZVMw3eWjsgyvu+lya8HlL1oxGL/7WdXinK2htkZXZUY7z E/qBGtZun/nNyIGbTECnkiiqbQI5SkF61eZx5yu+LgvSF+Ko4yQlbKInxZ/bhvk66Qo6 qzv663WIkyb+4wKfMlOKqugGLXOPOQcdESOVil3Ft5yBmVOVnvf0jmlZuWINJP06urqA 84BPrUd4UrpsYGkgFGy3/yixe3mCW/UN3Tqr4MsYp4vmsXwURtDC7FIl5WXZt51E/gMm DtHA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1789357399; x=1789962199; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :content-type:mime-version:subject:date:from:x-gm-gg :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to :content-type; bh=GAsbxYca6VjWpMbSwguYm2YOe+ZCO4Pw6f1i4SctU5c=; b=dqcbxKFLswOPakD4GaY9jZXh7e2zZQawuDC3uZT5a7kAu/V7unFoz9FTrfy0/juhQt B6uUpJDCuuvJLRKo01tS4wf4QoxXw4oW5fpVbWSeWXZ5zzoZtaIcSVK5uVaHcJufxr5x iaMNY2Wz2PvTmcotpDBYqaoFX9uAyxXl2scEec5SBelPfMyKtovXWQGPN7LRHf+wkKMt ZsymvX9lz5/ieHXUE8xr6lrqLu/0w63x7srLcYrNJT5okDydIqjUnpvqeORWamuxSBYZ f5oYx3HfO+jDZ0O7ffLY6p/FsxUy8pIckZxz7K0kmwiHfIT+YO2AtoPaTBUi+OYDMWxS Y6pg== X-Forwarded-Encrypted: i=1; AKwUvByD3b678sx4iW9Gq2hMYyqFFN29cPnkl4m4BwGHkGMtlnkj9aB48KwPxQ1Bp9LdFc/WaGIymkj4aKZCiUw=@vger.kernel.org X-Gm-Message-State: AFuF++mUQaQiaPP83uVco/qLtHppS45jxSKgO7WE35AtQsV6sLeaji/W d5GVyVEP5lQTf2bVe+LxftyYtIUWVCQTUfuCwB/9fExAf4MognOvdbZzTaynAvhijHADMPe1+Nm WOur2+8StZkcwKWZqRapN7L/EG+5j2+tyLGvMZMpUFo9Iag3nlUbIr+zMowfTuabZWKk= X-Gm-Gg: AYBFou0sJXf43n4dCsgjTK+rft64cU0rYYXwuc5f6BtFBZ3+rw1sR0taG6cl2AB7pQn JlDOHQJmHUHW/a91m7EbrDpb0ArF3se2DjcbRRXwqOqoYdSgFUb84mtyJXS4/J4fFQaFs6I/N7y DjbnBeq/Gy7a83KMepoMSplXDb1O0PjC3hPU/DuNuhxX7Cl58VhS8SaNgzS1sDpgyHOpu0ifSn7 lPrewIeQAORCPZWvI1r9bOHxYu8gaC43L9zA2aJ/Lk/Iqf+OAGZJyeK7UdIg0IoA2QJTdOyea7p sy8r8MGAGp/Ak+LHaLgg9/yZFOnosI2vH2ei5REVk9ytMFWVm8UZ0NilL38FicBL31sJCzCWB29 X23GM3dIxlNqD5IH7Od+f8fm+dYV6uGIt7f+XjHtIt1p0nXs= X-Received: by 2002:a17:90b:440c:b0:381:bcfb:e710 with SMTP id 98e67ed59e1d1-39dec137c0emr1127695a91.3.1789357399158; Sun, 13 Sep 2026 20:43:19 -0700 (PDT) X-Received: by 2002:a17:90b:440c:b0:381:bcfb:e710 with SMTP id 98e67ed59e1d1-39dec137c0emr1127666a91.3.1789357398697; Sun, 13 Sep 2026 20:43:18 -0700 (PDT) Received: from hu-zijuhu-lv.qualcomm.com (Global_NAT1.qualcomm.com. [129.46.96.20]) by smtp.gmail.com with ESMTPSA id 5a478bee46e88-33ba4ee07f2sm21250894eec.18.2026.09.13.20.43.17 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 13 Sep 2026 20:43:17 -0700 (PDT) From: Zijun Hu Date: Sun, 13 Sep 2026 20:42:57 -0700 Subject: [PATCH 2/4] Bluetooth: coredump: Fix btmon heap-buffer-overflow Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20260913-misc_fix-v1-2-558c1e4028b9@oss.qualcomm.com> References: <20260913-misc_fix-v1-0-558c1e4028b9@oss.qualcomm.com> In-Reply-To: <20260913-misc_fix-v1-0-558c1e4028b9@oss.qualcomm.com> To: Marcel Holtmann , Luiz Augusto von Dentz , Abhishek Pandit-Subedi , Manish Mandlik Cc: Zijun Hu , Luiz Augusto von Dentz , linux-bluetooth@vger.kernel.org, linux-kernel@vger.kernel.org, Zijun Hu X-Mailer: b4 0.15.2 X-Proofpoint-GUID: bz14iHBX4FbYviiGhkZ2Mlp2X6oorhcf X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwOTE0MDA0OSBTYWx0ZWRfX7/dwWBDWBXmq kQi3vCdiL0PghE0fuiEB25BPt+arl7qSmGmiEU6WzQrxVnw45YdssJgfTHRQCWJkzn+Whw79ArO Gh+H9xT2yjin5JmwkWss0/tjVpZ7YBCV/ChTboGECib9TV5l0x6MRw/SYrvCfavckElY4RRlA3e 2QIkEDiCT4SB2GC+xJX4BTE8v0MuK0qiqW/ZZdX4Et2TpA1h1hsyyKFB2DBIpgb8VUtinG6mmm/ 9p34y0mDzFGgF9acNif9AyIIE9dnWcA2k3D4rpoT0m59AVeeKlCqu9Ph099WPhlXKAmvEYrDA7S qoEdESAqajwken/oWCq11djL3sZBr2j10sZSeZDXUv0EYKn/WrK0hgZATRTyapUYxZ/2LVhx4j7 2Fx0BAf3+tr5DxEeiXUt8ueiBEPgP0WkfQHkIJjHh1qT7WieHNH5vXf+6Y/FLOpfyAayTDXtat1 mOBkV78O+c8AdeMGGgQ== X-Proofpoint-Spam-Info: AW1haW4tMjYwOTE0MDA0OSBTYWx0ZWRfX+bY3tZf7PvjC yEMOXdAjH1f3h7f2w9bqD0YPZ0xYlX8irmgENnOwGFBifIsfijBOzHJyCKI3vdn9m98cCILtdnI E12N0OEdOcryPr3TwMbB6Sq6B5+3EEQ= X-Proofpoint-ORIG-GUID: bz14iHBX4FbYviiGhkZ2Mlp2X6oorhcf X-Authority-Analysis: v=2.4 cv=PsUG/AM3 c=1 sm=1 tr=0 ts=6aa76d57 cx=c_pps a=0uOsjrqzRL749jD1oC5vDA==:117 a=ouPCqIW2jiPt+lZRy3xVPw==:17 a=IkcTkHD0fZMA:10 a=VdqzKS8jKosA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=DJpcGTmdVt4CTyJn9g5Z:22 a=EUspDBNiAAAA:8 a=veR8huZC2ww56zqa0CUA:9 a=QEXdDO2ut3YA:10 a=mQ_c8vxmzFEMiUWkPHU9:22 X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1176,Hydra:6.1.134,FMLib:17.12.100.49 definitions=2026-09-14_01,2026-09-13_01,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 impostorscore=0 priorityscore=1501 suspectscore=0 bulkscore=0 spamscore=0 malwarescore=0 lowpriorityscore=0 phishscore=0 adultscore=0 clxscore=1015 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2609040000 definitions=main-2609140049 The collected coredump data can exceed btmon's maximum packet size of 1490 bytes, But hci_devcd_dump() forwards the entire coredump data as an HCI_DIAG_PKT without checking its size, causing below issue in btmon. Why ? For a monitor packet, its payload length @len in header may exceed BTSNOOP_MAX_PACKET_SIZE, btmon uses it to access payload in @buf. so cause heap-buffer-overflow. Kernel: include/net/bluetooth/hci_mon.h struct hci_mon_hdr { __le16 opcode; __le16 index; __le16 len; } __packed; BlueZ: src/shared/btsnoop.h monitor/control.c struct control_data { uint16_t channel; int fd; unsigned char buf[BTSNOOP_MAX_PACKET_SIZE]; uint16_t offset; }; Issue: ERROR: AddressSanitizer: heap-buffer-overflow on address 0x51b00000065c at = pc 0x7f50b987a029 bp 0x7ffde88dc8d0 sp 0x7ffde88dc088 READ of size 17916 at 0x51b00000065c thread T0 #0 0x7f50b987a028 in write ../../../../src/libsanitizer/sanitizer_commo= n/sanitizer_common_interceptors.inc:1096 #1 0x5b4f3443ae3a in btsnoop_write ../src/shared/btsnoop.c:289 #2 0x5b4f3429cbf0 in data_callback ../monitor/control.c:969 #3 0x5b4f3444fa9d in mainloop_run ../src/shared/mainloop.c:104 #4 0x5b4f34451da6 in mainloop_run_with_signal ../src/shared/mainloop-no= tify.c:196 #5 0x5b4f342953fc in main ../monitor/main.c:303 #6 0x7f50b8c2a1c9 in __libc_start_call_main ../sysdeps/nptl/libc_start_= call_main.h:58 #7 0x7f50b8c2a28a in __libc_start_main_impl ../csu/libc-start.c:360 #8 0x5b4f34295ed4 in _start (/usr/bin/btmon+0x29fed4) (BuildId: b41caaf= b24db693946c283eaea48112186863d2d) Fix by forwarding the collected dump data as an HCI_DIAG_PKT only when its size <=3D 1490. Fixes: b257e02ecc46 ("HCI: coredump: Log devcd dumps into the monitor") Signed-off-by: Zijun Hu --- net/bluetooth/coredump.c | 17 ++++++++++++----- 1 file changed, 12 insertions(+), 5 deletions(-) diff --git a/net/bluetooth/coredump.c b/net/bluetooth/coredump.c index 71fc8dab4004..61b45ba58a65 100644 --- a/net/bluetooth/coredump.c +++ b/net/bluetooth/coredump.c @@ -250,36 +250,43 @@ static void hci_devcd_handle_pkt_pattern(struct hci_d= ev *hdev, } =20 pattern =3D skb_pull_data(skb, sizeof(*pattern)); =20 if (!hci_devcd_memset(hdev, pattern->pattern, pattern->len)) bt_dev_dbg(hdev, "Failed to set pattern"); } =20 +/* Align with BlueZ's BTSNOOP_MAX_PACKET_SIZE. */ +#define HCI_DEVCD_DIAG_MAX_SIZE (1486 + 4) + static void hci_devcd_dump(struct hci_dev *hdev) { struct sk_buff *skb; u32 size; =20 bt_dev_dbg(hdev, "state %s", hci_devcd_state_name(hdev->dump.state)); =20 size =3D hdev->dump.tail - hdev->dump.head; =20 - /* Send a copy to monitor as a diagnostic packet */ - skb =3D bt_skb_alloc(size, GFP_ATOMIC); - if (skb) { - skb_put_data(skb, hdev->dump.head, size); - hci_recv_diag(hdev, skb); + if (size <=3D HCI_DEVCD_DIAG_MAX_SIZE) { + /* Send a copy to monitor as a diagnostic packet */ + skb =3D bt_skb_alloc(size, GFP_ATOMIC); + if (skb) { + skb_put_data(skb, hdev->dump.head, size); + hci_recv_diag(hdev, skb); + } } =20 /* Emit a devcoredump with the available data */ dev_coredumpv(&hdev->dev, hdev->dump.head, size, GFP_KERNEL); } =20 +#undef HCI_DEVCD_DIAG_MAX_SIZE + static void hci_devcd_handle_pkt_complete(struct hci_dev *hdev, struct sk_buff *skb) { u32 dump_size; =20 if (hdev->dump.state !=3D HCI_DEVCOREDUMP_ACTIVE) { DBG_UNEXPECTED_STATE(); return; --=20 2.34.1 From nobody Fri Sep 25 10:38:01 2026 Received: from mx0a-0031df01.pphosted.com (mx0a-0031df01.pphosted.com [205.220.168.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id D9BCF36826B for ; Mon, 14 Sep 2026 03:43:21 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.168.131 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1789357403; cv=none; b=gvHrKv6wx8ANhMK+PYD0rMHh06q0UyWWsPjVWSkW8izGUUF22CcAaHn6/2I3jLDxxQ3OySxOLmAfq/0p0c44WzugVY54Clrex6ngljH51jW2gziEzh2c789TGd13jGmbpmTYN9YM1JLXJXcu194m5tbVKwkIp21iWUfrvo4XT1g= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1789357403; c=relaxed/simple; bh=w579INk5HIY4CFkQ0m15JvuCIyvCxdEX8EntRbAN1lk=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=o5WsXK5/uFQ4CoiJP/IuaWoHduUD6z6hkojI7HY7VesvL6rS2hmqZJqFDketMeSk/jU1yy6eR8N/7q/xo8jLP8H6X4RHXWYZojPykrQhpvlwMT7Py1M6Vuc+iDl9aVu6rcwyA/MEK+btA16au+pSW+UQKMreBXIvvBnAV2/3STA= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=ROULYNen; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=ZnOfsUeW; arc=none smtp.client-ip=205.220.168.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="ROULYNen"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="ZnOfsUeW" Received: from pps.filterd (m0279864.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 68E2eemZ2241380 for ; Mon, 14 Sep 2026 03:43:21 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= UYkjE/aA061mfOcjRAR+umhJu7g5L7SSr1+2F6cUv+A=; b=ROULYNen02/KzOSj gKahloS2im7tNBizSnmtQ1yfHiEp11Zyt3xEyeT076w2NWr7nQILoba+Lj/d3uFp gEzC8kFH4ktgPL08LEeYEIzvmSY9MrtRTtTDDUPQnXqn9siqOcyUz3sOOSKM+Y60 KcXds6J1SywgMw1aFNK+UWBbXoF+TclBfcj8EWk2J/GrsZah1c3SZeAXrj+FN4TY fLL36IcjAEbtw2dT0XkXA8t4amzzJPf33CRizGxDEfAFN6R1Y4KNJ7BMi5HhB9QC zwMcJBCrBVnC+4ivJaKFZ8zaGWJJLE7duRwf2HH8jny7RpP2uUJQKkQxIMBQTKPr udlckw== Received: from mail-pj1-f69.google.com (mail-pj1-f69.google.com [209.85.216.69]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4gmywh4rnx-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Mon, 14 Sep 2026 03:43:21 +0000 (GMT) Received: by mail-pj1-f69.google.com with SMTP id 98e67ed59e1d1-38ddc70b9d5so872875a91.3 for ; Sun, 13 Sep 2026 20:43:21 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1789357401; x=1789962201; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :content-type:mime-version:subject:date:from:from:to:cc:subject:date :message-id:reply-to:content-type; bh=UYkjE/aA061mfOcjRAR+umhJu7g5L7SSr1+2F6cUv+A=; b=ZnOfsUeWGkPuQbQykMykCG1BGXmI3wboHPPLAvW5AkSlEHI5OaNdVDeEp9VaNmbgPd qIv3rrqF0BZhyZSMeg6G6SVgVDZOM5LUYx4/ZbVoVcE5CqLxc/O43nhfjcn74fLZBuDe hzVkyqrD/TaB9eXr16HDgwQEgp+U2dHZTe8MSusWzuFtM2su3cvLMOFBhCtxyqxFvPJI QkHmQ5h+4gaFDfzHvlLUv3ujwJ5rvI+WTcwvUnMkfpjzI0EPYsdhJO0qpQWkodCyjB9L S6nw2I0mhydw9fe6RqnwerfGzgTuNyKeeDqUCGKb6tbfxFmONK6fse0Yo3YizWEcIfsF uvJQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1789357401; x=1789962201; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :content-type:mime-version:subject:date:from:x-gm-gg :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to :content-type; bh=UYkjE/aA061mfOcjRAR+umhJu7g5L7SSr1+2F6cUv+A=; b=AViRo80Uf1AM8+mN2vbrTKNMbYNOQeZnQSkV72gh0ga4v3WA0rt2dvhWLOwmndTiVn Mr/IlYH9wcjKLNFG1KcisbAHTrCJNSn1PeVorfgbSel/ZsTPshs7QP/+INsPurwlHG+o DYOZ20uyiUAPQr4iwPHCDG5iu3xSTXLrjEbQ+xv9FTP7BVBL5lER8fcfuY8MM1TWOmdq cOr+edKkWqL0EV9gsVpPuJN76VJROCvz8VzBwYktpZkVhKINlHHhAcjE2sqMX4FDKO+K 6kqUORglPXYyimtnFnTVCUG+gkmW213tgYNxv62k5pmMQdN4db1r4YRQ+1Enexin9G4k ES+A== X-Forwarded-Encrypted: i=1; AKwUvBxU3D4m79WyF248XGZ3YdjOW9eVXWv66Ir7vP5P3aIx3dhSRDvgLYSPZG9CQ1vKxq4Z33buNsO94oe6iVw=@vger.kernel.org X-Gm-Message-State: AFuF++kFFPFge4oYYwbkq9WeVUdntVD7uPzxNxet+KEiXqdUD4G+3dtO 4F8V2zd78bB/mMXjUmMP5wQZGnL0DiE/eGk3cX+z+FzH/yAiauSsQbUY2A7pmwv65Dvo0/SnYFL ZYVvooGZZw/wzUOihFgnFdu65BRnj2pBP3X0EuRxjVkIctGZdaDRC3qasDWhA/qnS9N8= X-Gm-Gg: AYBFou29CbxFXKFelcKUyyf2PaxkjQs36eklSWgpR1h4fTS6YmUBRa/5bnSzCfD1IJW qPb7oPl08B4sdC6Jcl6YQ4JxUp7QR2y4QJaeai+hH3z5YBydnfoJazTHAx7BnFz5UOH0D4oDE0q SGZuFLNwWwdEAk52YtFOxOPwIDSADmKImtzSX9PDkV1hs+i2lcatB+flhws2zI9VgqdMoDXR6a/ SD8aUt86yKywUmndjKpf3hDpXEwLGWKjeO7+dfLlFXWyXUzDqbHo7xZdas17P3wtFg41TCh+YC5 7C6gdD1ozxUYSeM+3qLma4FsIPxnjP46b+Q87CmPOzOCF9jXQpszeziBr5pyiv/mGYJdr7wfRAX wcPp1646j8BD4OZ51kV3fHlGlT+CALN4uITviu7z6VF3Beqk= X-Received: by 2002:a17:90a:d88b:b0:398:bac0:238d with SMTP id 98e67ed59e1d1-39dec21ea0cmr1125539a91.5.1789357400596; Sun, 13 Sep 2026 20:43:20 -0700 (PDT) X-Received: by 2002:a17:90a:d88b:b0:398:bac0:238d with SMTP id 98e67ed59e1d1-39dec21ea0cmr1125502a91.5.1789357400138; Sun, 13 Sep 2026 20:43:20 -0700 (PDT) Received: from hu-zijuhu-lv.qualcomm.com (Global_NAT1.qualcomm.com. [129.46.96.20]) by smtp.gmail.com with ESMTPSA id 5a478bee46e88-33ba4ee07f2sm21250894eec.18.2026.09.13.20.43.18 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 13 Sep 2026 20:43:19 -0700 (PDT) From: Zijun Hu Date: Sun, 13 Sep 2026 20:42:58 -0700 Subject: [PATCH 3/4] Bluetooth: hci_event: Use 254 as max LE Meta subevent payload length in hci_le_ev_table[] Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20260913-misc_fix-v1-3-558c1e4028b9@oss.qualcomm.com> References: <20260913-misc_fix-v1-0-558c1e4028b9@oss.qualcomm.com> In-Reply-To: <20260913-misc_fix-v1-0-558c1e4028b9@oss.qualcomm.com> To: Marcel Holtmann , Luiz Augusto von Dentz , Abhishek Pandit-Subedi , Manish Mandlik Cc: Zijun Hu , Luiz Augusto von Dentz , linux-bluetooth@vger.kernel.org, linux-kernel@vger.kernel.org, Zijun Hu X-Mailer: b4 0.15.2 X-Proofpoint-GUID: AyasJ5cWbD09cXaeLc_UtRoa8bwJyNH3 X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwOTE0MDA0OSBTYWx0ZWRfXzJHopOgL6Twh rhwREIjn7XGHz6y/6B6I5uw7nBk/HXVGFJga4BnH6XBthMP1n6s+Fsgt6Q0kA8RdpNdLhAIbZdl 8oRJxdzCBKWqHH+HbVu/Lm2FO2bLl42nBuOehjewqwK1nDZQkRxlcPHwO24gbi0wF+p85HIxksv 5TAqU7e+JDFnaBNX4fpxV44vCUBXN+wDhBsL1pNbO7L5weP1HxEop1vevq1zw7jvlPBfTaPY/Vc uEmS08AhOsW4R+xMJK8j4lt4b1Ky1iYLa7Q7mPnO+yba08hrlzDhd7pwCGBgEKxOkuF0EKrKcwt Dh39dXsddMIDOvdeqisLUVd67UTTlE9PyJvD0zVr55snJ11CfEJrVeUYzxlzL8dgy7OSwlmlg5k IkRYUG1rMPACEDCVmz/xZ6Sh3VSOwxHyCgNzLfZnM5uaZotGKVJMRyBNMUUVXGwtlHp2r022M68 BGOIk8dBQRPMhnzQTTQ== X-Proofpoint-Spam-Info: AW1haW4tMjYwOTE0MDA0OSBTYWx0ZWRfX0eIOP49DPHDS WFgcIqR98ls5Jf30BYU54LjL3lVie7aD+KAjyEfBN6j+v8HhBMx8whDnDjP7ybcfXbQ95McTGy1 QY4M0C4rudXKpqUPyJkBifVJEJGp+cY= X-Proofpoint-ORIG-GUID: AyasJ5cWbD09cXaeLc_UtRoa8bwJyNH3 X-Authority-Analysis: v=2.4 cv=PsUG/AM3 c=1 sm=1 tr=0 ts=6aa76d59 cx=c_pps a=vVfyC5vLCtgYJKYeQD43oA==:117 a=ouPCqIW2jiPt+lZRy3xVPw==:17 a=IkcTkHD0fZMA:10 a=VdqzKS8jKosA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=DJpcGTmdVt4CTyJn9g5Z:22 a=EUspDBNiAAAA:8 a=A2jjY7DYbelx_RivTkEA:9 a=QEXdDO2ut3YA:10 a=rl5im9kqc5Lf4LNbBjHf:22 X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1176,Hydra:6.1.134,FMLib:17.12.100.49 definitions=2026-09-14_01,2026-09-13_01,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 impostorscore=0 priorityscore=1501 suspectscore=0 bulkscore=0 spamscore=0 malwarescore=0 lowpriorityscore=0 phishscore=0 adultscore=0 clxscore=1015 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2609040000 definitions=main-2609140049 hci_le_meta_evt() validates skb->len against subev->max_len from the entry in hci_le_ev_table[], By then, the HCI event header and LE Meta subevent header have already been stripped by skb_pull(), So the max LE Meta subevent payload is 254, but hci_le_ev_table[] still uses HCI_MAX_EVENT_SIZE (260) for it, which is imprecise. Fix by defining HCI_MAX_LE_SUBEVT_PLEN (254) and using it instead. Signed-off-by: Zijun Hu --- net/bluetooth/hci_event.c | 21 ++++++++++++--------- 1 file changed, 12 insertions(+), 9 deletions(-) diff --git a/net/bluetooth/hci_event.c b/net/bluetooth/hci_event.c index 03b805207ab0..1eacdd93c5b5 100644 --- a/net/bluetooth/hci_event.c +++ b/net/bluetooth/hci_event.c @@ -7469,33 +7469,36 @@ static void hci_le_conn_rate_change_evt(struct hci_= dev *hdev, void *data, } =20 #define HCI_LE_EV(_op, _func, _len) \ HCI_LE_EV_VL(_op, _func, _len, _len) =20 #define HCI_LE_EV_STATUS(_op, _func) \ HCI_LE_EV(_op, _func, sizeof(struct hci_ev_status)) =20 +#define HCI_MAX_LE_SUBEVT_PLEN \ + (HCI_MAX_EVENT_PLEN - sizeof(struct hci_ev_le_meta)) + /* Entries in this table shall have their position according to the subeve= nt * opcode they handle so the use of the macros above is recommend since it= does * attempt to initialize at its proper index using Designated Initializers= that * way events without a callback function can be omitted. */ static const struct hci_le_ev { void (*func)(struct hci_dev *hdev, void *data, struct sk_buff *skb); u16 min_len; u16 max_len; } hci_le_ev_table[U8_MAX + 1] =3D { /* [0x01 =3D HCI_EV_LE_CONN_COMPLETE] */ HCI_LE_EV(HCI_EV_LE_CONN_COMPLETE, hci_le_conn_complete_evt, sizeof(struct hci_ev_le_conn_complete)), /* [0x02 =3D HCI_EV_LE_ADVERTISING_REPORT] */ HCI_LE_EV_VL(HCI_EV_LE_ADVERTISING_REPORT, hci_le_adv_report_evt, sizeof(struct hci_ev_le_advertising_report), - HCI_MAX_EVENT_SIZE), + HCI_MAX_LE_SUBEVT_PLEN), /* [0x03 =3D HCI_EV_LE_CONN_UPDATE_COMPLETE] */ HCI_LE_EV(HCI_EV_LE_CONN_UPDATE_COMPLETE, hci_le_conn_update_complete_evt, sizeof(struct hci_ev_le_conn_update_complete)), /* [0x04 =3D HCI_EV_LE_REMOTE_FEAT_COMPLETE] */ HCI_LE_EV(HCI_EV_LE_REMOTE_FEAT_COMPLETE, hci_le_remote_feat_complete_evt, sizeof(struct hci_ev_le_remote_feat_complete)), @@ -7508,33 +7511,33 @@ static const struct hci_le_ev { sizeof(struct hci_ev_le_remote_conn_param_req)), /* [0x0a =3D HCI_EV_LE_ENHANCED_CONN_COMPLETE] */ HCI_LE_EV(HCI_EV_LE_ENHANCED_CONN_COMPLETE, hci_le_enh_conn_complete_evt, sizeof(struct hci_ev_le_enh_conn_complete)), /* [0x0b =3D HCI_EV_LE_DIRECT_ADV_REPORT] */ HCI_LE_EV_VL(HCI_EV_LE_DIRECT_ADV_REPORT, hci_le_direct_adv_report_evt, sizeof(struct hci_ev_le_direct_adv_report), - HCI_MAX_EVENT_SIZE), + HCI_MAX_LE_SUBEVT_PLEN), /* [0x0c =3D HCI_EV_LE_PHY_UPDATE_COMPLETE] */ HCI_LE_EV(HCI_EV_LE_PHY_UPDATE_COMPLETE, hci_le_phy_update_evt, sizeof(struct hci_ev_le_phy_update_complete)), /* [0x0d =3D HCI_EV_LE_EXT_ADV_REPORT] */ HCI_LE_EV_VL(HCI_EV_LE_EXT_ADV_REPORT, hci_le_ext_adv_report_evt, sizeof(struct hci_ev_le_ext_adv_report), - HCI_MAX_EVENT_SIZE), + HCI_MAX_LE_SUBEVT_PLEN), /* [0x0e =3D HCI_EV_LE_PA_SYNC_ESTABLISHED] */ HCI_LE_EV(HCI_EV_LE_PA_SYNC_ESTABLISHED, hci_le_pa_sync_established_evt, sizeof(struct hci_ev_le_pa_sync_established)), /* [0x0f =3D HCI_EV_LE_PER_ADV_REPORT] */ HCI_LE_EV_VL(HCI_EV_LE_PER_ADV_REPORT, hci_le_per_adv_report_evt, sizeof(struct hci_ev_le_per_adv_report), - HCI_MAX_EVENT_SIZE), + HCI_MAX_LE_SUBEVT_PLEN), /* [0x10 =3D HCI_EV_LE_PA_SYNC_LOST] */ HCI_LE_EV(HCI_EV_LE_PA_SYNC_LOST, hci_le_pa_sync_lost_evt, sizeof(struct hci_ev_le_pa_sync_lost)), /* [0x12 =3D HCI_EV_LE_EXT_ADV_SET_TERM] */ HCI_LE_EV(HCI_EV_LE_EXT_ADV_SET_TERM, hci_le_ext_adv_term_evt, sizeof(struct hci_evt_le_ext_adv_set_term)), /* [0x18 =3D HCI_EVT_LE_PAST_RECEIVED] */ HCI_LE_EV(HCI_EV_LE_PAST_RECEIVED, @@ -7545,38 +7548,38 @@ static const struct hci_le_ev { sizeof(struct hci_evt_le_cis_established)), /* [0x1a =3D HCI_EVT_LE_CIS_REQ] */ HCI_LE_EV(HCI_EVT_LE_CIS_REQ, hci_le_cis_req_evt, sizeof(struct hci_evt_le_cis_req)), /* [0x1b =3D HCI_EVT_LE_CREATE_BIG_COMPLETE] */ HCI_LE_EV_VL(HCI_EVT_LE_CREATE_BIG_COMPLETE, hci_le_create_big_complete_evt, sizeof(struct hci_evt_le_create_big_complete), - HCI_MAX_EVENT_SIZE), + HCI_MAX_LE_SUBEVT_PLEN), /* [0x1d =3D HCI_EV_LE_BIG_SYNC_ESTABLISHED] */ HCI_LE_EV_VL(HCI_EVT_LE_BIG_SYNC_ESTABLISHED, hci_le_big_sync_established_evt, sizeof(struct hci_evt_le_big_sync_established), - HCI_MAX_EVENT_SIZE), + HCI_MAX_LE_SUBEVT_PLEN), /* [0x1e =3D HCI_EVT_LE_BIG_SYNC_LOST] */ HCI_LE_EV_VL(HCI_EVT_LE_BIG_SYNC_LOST, hci_le_big_sync_lost_evt, sizeof(struct hci_evt_le_big_sync_lost), - HCI_MAX_EVENT_SIZE), + HCI_MAX_LE_SUBEVT_PLEN), /* [0x22 =3D HCI_EVT_LE_BIG_INFO_ADV_REPORT] */ HCI_LE_EV_VL(HCI_EVT_LE_BIG_INFO_ADV_REPORT, hci_le_big_info_adv_report_evt, sizeof(struct hci_evt_le_big_info_adv_report), - HCI_MAX_EVENT_SIZE), + HCI_MAX_LE_SUBEVT_PLEN), /* [0x2b =3D HCI_EVT_LE_ALL_REMOTE_FEATURES_COMPLETE] */ HCI_LE_EV_VL(HCI_EVT_LE_ALL_REMOTE_FEATURES_COMPLETE, hci_le_read_all_remote_features_evt, sizeof(struct hci_evt_le_read_all_remote_features_complete), - HCI_MAX_EVENT_SIZE), + HCI_MAX_LE_SUBEVT_PLEN), /* [0x37 =3D HCI_EVT_LE_CONN_RATE_CHANGE] */ HCI_LE_EV(HCI_EVT_LE_CONN_RATE_CHANGE, hci_le_conn_rate_change_evt, sizeof(struct hci_evt_le_conn_rate_change)), }; =20 static void hci_le_meta_evt(struct hci_dev *hdev, void *data, struct sk_buff *skb, u16 *opcode, u8 *status, hci_req_complete_t *req_complete, --=20 2.34.1 From nobody Fri Sep 25 10:38:01 2026 Received: from mx0a-0031df01.pphosted.com (mx0a-0031df01.pphosted.com [205.220.168.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 383A236AB77 for ; Mon, 14 Sep 2026 03:43:23 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.168.131 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1789357404; cv=none; b=GVocZNUvfvaDPiddM9EwSAvXWP/4ErWrV4X3nKdYP+rOCLjWmU4U4aC0Ajiht9VemPtuZmXPjVciho9ztBEGr7Vb7Piqi67WgL7QRtpwjr/OXlM4jo1BG1WDR5pekR2VQjVNACwH6vIEPT2rVyH3LlPUFhzlqxNLFkkvVn/Ml6M= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1789357404; c=relaxed/simple; bh=m3mEMCM2N86YPROdNx2HgOUYR7NEPesxcH769+cz/Ek=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=OiibnHaVsNUe+RHjp3jC8muNbvsKDlYnS/+OY4YvAid01mLu+MHel6EgHoJLMLxKmabE6vkEFNt2l+tYB0W9Vi/Ut8t6bCDLAn4YUm7x8Pnr31w4ECrIOw1zMjHOkiMhY85hLuhNNCrHPU69A/CaBxqwyopjAcEMuQ/2rA2Rjiw= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=HpctDhZK; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=Hz3DqObs; arc=none smtp.client-ip=205.220.168.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="HpctDhZK"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="Hz3DqObs" Received: from pps.filterd (m0279865.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 68E2ePHc151697 for ; Mon, 14 Sep 2026 03:43:22 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= F7GArmKpLP9AjtAbGUkxNxbZRVuwStWITOastx/GsUg=; b=HpctDhZKjovM4eS9 pk3lhnB5Z3HuG98U3Mv2+d4yVHyhcAGt8QvarE8+wVz9ER+JHukrXm2B2fq1mfm1 iD/y6cx/PJUbzShCWmM6fKinyOIjjmv2BShfsqYz1qctpkNxI7ots16NeJSg0Xru sRwFp0gMiHJ4HnPkDPRDKDubnh7HbrFp+XbbxLdDImkMAFdWnivqRZIiD+NNMALL CvXw3nRlEUXYxnxELrfYdXZt93ZreOHTR0B87XXt3SWUqGl9SuzaHrkdz/JpEocS ht6AhsiMABhkJmcff4zqVb54aAL7yCiO3Tq5t5o2CNaSIcMOoBPHmmkpJYyDl3CN keZURQ== Received: from mail-pj1-f70.google.com (mail-pj1-f70.google.com [209.85.216.70]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4gp3k08qxs-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Mon, 14 Sep 2026 03:43:22 +0000 (GMT) Received: by mail-pj1-f70.google.com with SMTP id 98e67ed59e1d1-399271df9d8so753775a91.2 for ; Sun, 13 Sep 2026 20:43:22 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1789357402; x=1789962202; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :content-type:mime-version:subject:date:from:from:to:cc:subject:date :message-id:reply-to:content-type; bh=F7GArmKpLP9AjtAbGUkxNxbZRVuwStWITOastx/GsUg=; b=Hz3DqObsTbnmizpvEDMWCoCqJNKdcDS7ZAvqATmGgnCocfYFAYgsuSmq4aG0D7Tv4K qmwyldKSRb+JDVjrb96GdCftI2FoIQoaSE7UfmlUlXHuB925g3rdpFUkf0HDsXD3/yj1 4N3sFkjboPfQe/YJvIjblDSAEIE1WWB3ANIfAkCRarknM/WidMk+xwlrMBLXbmxZuL+/ dMFX7lWyglghHeMSa3gmVYL5zj3UgM+DB0uu3A3GpqXsK24/Ed7XZAd0nOI35PQdRmMJ XbE8bJLGp5TIToi1PuKcuAvuJebSnz0xJX/dvzIkrcoWGKoVckeBWvVCTkxBgyYkh5Bd WC8w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1789357402; x=1789962202; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :content-type:mime-version:subject:date:from:x-gm-gg :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to :content-type; bh=F7GArmKpLP9AjtAbGUkxNxbZRVuwStWITOastx/GsUg=; b=Y7WYFcv8nFitP2Lr2PvsyhOayrCUkBkDX977IIl8E+cNbdCJebLwkcxN77NRDZbUPo L0saWOSc+xVZiezcf71XeoIWPQsD+BhN3RwYNqvH6d7K4vVS+B2uM0ims6cU6ewxkNf+ AaV8xGCSaihLXJ5x0wgUrJYTGYl0iKWu0tw1qunWKuQUAfdLCEcyEZJIECUio8JqhVvy zlXKpsypKBhlcvbrw7gR8fliE9ZX3Kh2BEY2uQ/V6KIvAOjRwBwTI8Gso/58OeH6VO8Q v6p2eVAXKttMMrQNKMyV5XHGhKYU+QzR4B3ktiy9OVgGyHFUSCYbivdN5HfAiQXEkwJq c87w== X-Forwarded-Encrypted: i=1; AKwUvBz4J8lGPPDMH16FmtBvnofjkB/4V/wviC4u/j9PCy3FEd0SjqMy2qCtyc2RnRChw+/ghAS1xhEQNPKKFE0=@vger.kernel.org X-Gm-Message-State: AFuF++mHv4qYF6joPyD+HHYm1VVcujHyarIjiKTZPicMH2nhZRMmnAWo 8y7x1IP5x5FI2lmnJNsE+c0qu6EWr5lv4aSGPuSCH+1dacSF/v7Z0dchuzybkcve59v7e6Amokq AxkP5TntCfPA1eINjocVQS4dqmf/jHbOFdBe3EFA4m0sh6X1j/fFCPJVNo3vKrupFpnQ= X-Gm-Gg: AYBFou09NR5zKII04MkGdxc1hKr27OLUaGtViH88b8RpECJi939Baglyv5Mdc8xQiZS amELDvYUqxKA6ghuKafkJ+iJzo2LNw6sJExMGgIWXVxaYPc+k/uMBIrtaOrd/WfbgQWmkE3NBn/ 6JJXT0HDsHIkL7yT95hW8bvf7mDnYK9ckJZCKNA8mLyQALUZm94EkN69vk2+EiI//te5r9w2qTU +hZ3Ve2ROJyklJjoNC5JTjdhDkfkJS2JhMu9x6Hpq8kgrfJmB6FB6Cvw7t56ljFX4qNcXPaxj8F sDAhsTp69e/bgDVtxQweFLuWnTK/QvJkaPjl5/ceKLVUMyOeVWaAoU1mv/rhizsr14ffRiv7MXw 39H4k8gA5EgAD8slo4tVs3gtK8rl6m4bpuCc4Seua10srPgA= X-Received: by 2002:a17:90b:4f:b0:398:bada:832b with SMTP id 98e67ed59e1d1-39dec251bf8mr1119711a91.6.1789357401741; Sun, 13 Sep 2026 20:43:21 -0700 (PDT) X-Received: by 2002:a17:90b:4f:b0:398:bada:832b with SMTP id 98e67ed59e1d1-39dec251bf8mr1119664a91.6.1789357401164; Sun, 13 Sep 2026 20:43:21 -0700 (PDT) Received: from hu-zijuhu-lv.qualcomm.com (Global_NAT1.qualcomm.com. [129.46.96.20]) by smtp.gmail.com with ESMTPSA id 5a478bee46e88-33ba4ee07f2sm21250894eec.18.2026.09.13.20.43.20 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 13 Sep 2026 20:43:20 -0700 (PDT) From: Zijun Hu Date: Sun, 13 Sep 2026 20:42:59 -0700 Subject: [PATCH 4/4] Bluetooth: hci_event: Use 252 as max CC event payload length in hci_cc_table[] Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20260913-misc_fix-v1-4-558c1e4028b9@oss.qualcomm.com> References: <20260913-misc_fix-v1-0-558c1e4028b9@oss.qualcomm.com> In-Reply-To: <20260913-misc_fix-v1-0-558c1e4028b9@oss.qualcomm.com> To: Marcel Holtmann , Luiz Augusto von Dentz , Abhishek Pandit-Subedi , Manish Mandlik Cc: Zijun Hu , Luiz Augusto von Dentz , linux-bluetooth@vger.kernel.org, linux-kernel@vger.kernel.org, Zijun Hu X-Mailer: b4 0.15.2 X-Proofpoint-Spam-Info: AW1haW4tMjYwOTE0MDA0OSBTYWx0ZWRfX0ZvMXV8n314s fn/+S4zjMRNZ6Td9RGDU2z3pnfjql3jFhQcsg912NODkMK7HpOV+35uDEuklobypO8VgQmbQVa2 fdFS5ynLkCbiCE7Uar6LCRUU8hyRFvg= X-Proofpoint-GUID: kD1rURCaMe_sMQz4CONoPaifVu64FelG X-Proofpoint-ORIG-GUID: kD1rURCaMe_sMQz4CONoPaifVu64FelG X-Authority-Analysis: v=2.4 cv=BtAIUoX5 c=1 sm=1 tr=0 ts=6aa76d5a cx=c_pps a=0uOsjrqzRL749jD1oC5vDA==:117 a=ouPCqIW2jiPt+lZRy3xVPw==:17 a=IkcTkHD0fZMA:10 a=VdqzKS8jKosA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=Um2Pa8k9VHT-vaBCBUpS:22 a=EUspDBNiAAAA:8 a=u9mAljIaFVsWc0BqypwA:9 a=QEXdDO2ut3YA:10 a=mQ_c8vxmzFEMiUWkPHU9:22 X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwOTE0MDA0OSBTYWx0ZWRfXzLTeUMhodlae 9WTcyF7kl/v1yBP8OCsYRxfpMnDND+tXSYM2j0CUAtZ73ofUBPeLRokHLsBJNu4O+5INNXvaqZp ctikQS13UYTS4P/41+yaeNTgR+vpIsqOK6WY50Xn39twzAjzUubRC1+4jpmCHUJAg3uUbOvnuwo jyElC5K5XggG6PPBs+890qF7MI3lCi8g1fz2cHjgICQk798BVjLQ6WoNyfbu2O8Jjsa2V5Z4b0a TIovnrmhUDa0AbsjxBp5U8OSRp6QtDhOF+XyuzEl8FPHeA191BvxVZCmYG5aVA/fLJjd+qOm2JW 7kzRsbUtN3ela+mV5Ud4KwPqXzUlbIW10MxdCXWmr5L7Gsjzu04eTQ4+9vdgDQgRO5TMKTDYlY+ IAvJFPskkMhfOGxQLvWyHxEzfoW8IZCQIsfyInc8Uglmlp1kn2fa/V4jC8pozvCjPzSY8uM9pXo cKoJ4QL4TpMKVGcsKDQ== X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1176,Hydra:6.1.134,FMLib:17.12.100.49 definitions=2026-09-14_01,2026-09-13_01,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 clxscore=1015 spamscore=0 phishscore=0 impostorscore=0 suspectscore=0 bulkscore=0 malwarescore=0 adultscore=0 lowpriorityscore=0 priorityscore=1501 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2609040000 definitions=main-2609140049 hci_cc_func() validates skb->len against cc->max_len from the entry in hci_cc_table[], But By then, the HCI event and CC headers have already been stripped by skb_pull(). So the max CC payload is 252, but hci_cc_table[] still uses HCI_MAX_EVENT_SIZE (260) for it, which is imprecise. Fix by defining HCI_MAX_CC_PLEN (252) and using it instead. Signed-off-by: Zijun Hu --- net/bluetooth/hci_event.c | 7 +++++-- 1 file changed, 5 insertions(+), 2 deletions(-) diff --git a/net/bluetooth/hci_event.c b/net/bluetooth/hci_event.c index 1eacdd93c5b5..25ddba2f603b 100644 --- a/net/bluetooth/hci_event.c +++ b/net/bluetooth/hci_event.c @@ -4094,16 +4094,19 @@ static u8 hci_cc_le_set_per_adv_enable(struct hci_d= ev *hdev, void *data, } =20 #define HCI_CC(_op, _func, _len) \ HCI_CC_VL(_op, _func, _len, _len) =20 #define HCI_CC_STATUS(_op, _func) \ HCI_CC(_op, _func, sizeof(struct hci_ev_status)) =20 +#define HCI_MAX_CC_PLEN \ + (HCI_MAX_EVENT_PLEN - sizeof(struct hci_ev_cmd_complete)) + static const struct hci_cc { u16 op; u8 (*func)(struct hci_dev *hdev, void *data, struct sk_buff *skb); u16 min_len; u16 max_len; } hci_cc_table[] =3D { HCI_CC_STATUS(HCI_OP_INQUIRY_CANCEL, hci_cc_inquiry_cancel), HCI_CC_STATUS(HCI_OP_PERIODIC_INQ, hci_cc_periodic_inq), @@ -4187,17 +4190,17 @@ static const struct hci_cc { HCI_CC(HCI_OP_READ_LOCAL_OOB_EXT_DATA, hci_cc_read_local_oob_ext_data, sizeof(struct hci_rp_read_local_oob_ext_data)), HCI_CC(HCI_OP_LE_READ_BUFFER_SIZE, hci_cc_le_read_buffer_size, sizeof(struct hci_rp_le_read_buffer_size)), HCI_CC(HCI_OP_LE_READ_LOCAL_FEATURES, hci_cc_le_read_local_features, sizeof(struct hci_rp_le_read_local_features)), HCI_CC_VL(HCI_OP_LE_READ_CONN_INTERVAL, hci_cc_le_read_conn_interval, sizeof(struct hci_rp_le_read_conn_interval), - HCI_MAX_EVENT_SIZE), + HCI_MAX_CC_PLEN), HCI_CC(HCI_OP_LE_READ_ADV_TX_POWER, hci_cc_le_read_adv_tx_power, sizeof(struct hci_rp_le_read_adv_tx_power)), HCI_CC(HCI_OP_USER_CONFIRM_REPLY, hci_cc_user_confirm_reply, sizeof(struct hci_rp_user_confirm_reply)), HCI_CC(HCI_OP_USER_CONFIRM_NEG_REPLY, hci_cc_user_confirm_neg_reply, sizeof(struct hci_rp_user_confirm_reply)), HCI_CC(HCI_OP_USER_PASSKEY_REPLY, hci_cc_user_passkey_reply, sizeof(struct hci_rp_user_confirm_reply)), @@ -4259,17 +4262,17 @@ static const struct hci_cc { HCI_CC_STATUS(HCI_OP_LE_SET_PER_ADV_ENABLE, hci_cc_le_set_per_adv_enable), HCI_CC(HCI_OP_LE_READ_TRANSMIT_POWER, hci_cc_le_read_transmit_power, sizeof(struct hci_rp_le_read_transmit_power)), HCI_CC_STATUS(HCI_OP_LE_SET_PRIVACY_MODE, hci_cc_le_set_privacy_mode), HCI_CC(HCI_OP_LE_READ_BUFFER_SIZE_V2, hci_cc_le_read_buffer_size_v2, sizeof(struct hci_rp_le_read_buffer_size_v2)), HCI_CC_VL(HCI_OP_LE_SET_CIG_PARAMS, hci_cc_le_set_cig_params, - sizeof(struct hci_rp_le_set_cig_params), HCI_MAX_EVENT_SIZE), + sizeof(struct hci_rp_le_set_cig_params), HCI_MAX_CC_PLEN), HCI_CC(HCI_OP_LE_SETUP_ISO_PATH, hci_cc_le_setup_iso_path, sizeof(struct hci_rp_le_setup_iso_path)), HCI_CC(HCI_OP_LE_READ_ALL_LOCAL_FEATURES, hci_cc_le_read_all_local_features, sizeof(struct hci_rp_le_read_all_local_features)), }; =20 static u8 hci_cc_func(struct hci_dev *hdev, const struct hci_cc *cc, --=20 2.34.1