From nobody Fri Sep 25 12:34:04 2026 Received: from PA4PR04CU001.outbound.protection.outlook.com (mail-francecentralazon11013012.outbound.protection.outlook.com [40.107.162.12]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id AB7EF471249; Sat, 12 Sep 2026 16:16:27 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=fail smtp.client-ip=40.107.162.12 ARC-Seal: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1789229791; cv=fail; b=eE//iUM/wC+kwuSoTYEIJC3aO39Z47K0GuKSRg71vuzX1KARpdLctn1r5/JiBX7dqkDnu/Hhtl5ftN6HXri6PmwoP7rud2VMb1IpA3IIDN5BjPOd8KojfNlhprXdQPkaLltOHl0EY6MXP7M1pvCdE+3QQx3YNCm+YJ2myyjFZ1o= ARC-Message-Signature: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1789229791; c=relaxed/simple; bh=U9BfqPNG+yV1ycRAJ2FEJYehc23Ycle3yElfVwt3G5s=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: Content-Type:MIME-Version; b=AXBmCCgqG4Tg/w2cUimt9EsFYhD6iyu/MPth3mPRyoNVPFunbZ17saNPNJSeefby2nHhuXu0RQXFGto+CoDU85icnbHtpYFICeW8+LgQKrsYunKnZsRKbOWSFjwjPXuFGRnZukHrwn4o+n2PUQiwuDEC2Zg8EWIDl6fboWMRZ40= ARC-Authentication-Results: i=2; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=nxp.com; spf=pass smtp.mailfrom=nxp.com; dkim=pass (2048-bit key) header.d=nxp.com header.i=@nxp.com header.b=jcE2+EYd; arc=fail smtp.client-ip=40.107.162.12 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=nxp.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=nxp.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=nxp.com header.i=@nxp.com header.b="jcE2+EYd" ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=AHLTxLU7rp/wH6mY/ErFLmEo9iyCLoySCmxalB3v+llQAtSVNiIMNF+NmkzZfVBVusZcfB31VVUcib73soILWNx1DM3i6byrm0mQUykqfLgrfFIyz/yEYGQN6eevz3b194QUdXOfAkoA3oVKvFxlmlM7gdNO7OVqE7ZGUWJ1z9zqg3CYjUctCvgTIIPsfvSSmN4DTVfo/2HjFw9U0SEhQymA1+YduTPg/xuioVBTh8p54cFI6yYWNADNamhoSz1Pb26VzDtvzGbcNwuAEA0i/BUPCnTg/kguTz2aGbZXj7fLN66hgq2v1RONUuyPOTstQ833GriizRVBW9e/6KrGRQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=uFax5kRpkURnjwJk76LP8zB5hmul2052vISE3QbVQF0=; b=nyUAON0gFNRNtKEJ+iLNtkI65nwl1PTsuremfeO1+9z5OYxECPwhN9pKcLUvF0RrTfasiHPQB+i/fIwc36Ok9XeMq6/oekKgbCcKDU7bI61cyWmcILjVhmtmOuOPkbrq+PWcRLPFJ+B+vjsraR1k45ApQhc/b1VzGL+KY0a7RWtjaZCzMuwm2wDqXeG8v9aHRHtv2fuo0UvRRfkRhymdDqyJfDuOjcVk9+Qv+GcYiOJG0SKwtLXCOdWJwjrTNNqjgRxAEqy76QdAa4F9bCjRWD6mMYioS7AM7kTGvv8+Vh00vj2uu2WBZ2UBffu8xlBK15prP9LYH74jojaZWaRR0w== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=nxp.com; dmarc=pass action=none header.from=nxp.com; dkim=pass header.d=nxp.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nxp.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=uFax5kRpkURnjwJk76LP8zB5hmul2052vISE3QbVQF0=; b=jcE2+EYdY8QDbsH805554/cBu9Z5P5RdqbfT90sJbgJe4y+53FI8h4YqlUlVaX2QPB6Of07ECZeaOkSal/gvFsYefC4us3N1OIfQKHE+Yy97OvzlBX7yrD8+/WbAZWW1gb6mmhdoMHJJPr71G6bNQ4oJ6QbbzP8DzU7uU+T/LmXrekHPVGeIX4DepSGfLwPWrQpmTyVa7lwjwvvD54s8TFAkW0/U+0Lep0XtmcxZXQBJyhW2sr5bzs5LZ+jQSXWvR3Bc/GJPAQW4/CvzVtds1P1vCGJBpdbS12I1gWyBhkCqiewnZjLbcX3QNl6sUkDAkLf+Uf9lHbUQQVQtYL7gZA== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=nxp.com; Received: from AM0PR04MB6900.eurprd04.prod.outlook.com (2603:10a6:208:17d::10) by DU2PR04MB8871.eurprd04.prod.outlook.com (2603:10a6:10:2e2::11) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.21.406.10; Sat, 12 Sep 2026 16:16:21 +0000 Received: from AM0PR04MB6900.eurprd04.prod.outlook.com ([fe80::7fda:8431:ca1b:b023]) by AM0PR04MB6900.eurprd04.prod.outlook.com ([fe80::7fda:8431:ca1b:b023%4]) with mapi id 15.21.0406.007; Sat, 12 Sep 2026 16:16:21 +0000 From: vladimir.oltean@nxp.com To: linux-pci@vger.kernel.org Cc: Aksh Garg , Lorenzo Pieralisi , =?UTF-8?q?Krzysztof=20Wilczy=C5=84ski?= , Manivannan Sadhasivam , Rob Herring , Bjorn Helgaas , Vignesh Raghavendra , Siddharth Vadapalli , Manikandan K Pillai , Felix Gu , linux-kernel@vger.kernel.org, linux-omap@vger.kernel.org, linux-arm-kernel@lists.infradead.org Subject: [PATCH 1/3] PCI: cadence: Remove device links to PHY Date: Sat, 12 Sep 2026 19:14:38 +0300 Message-ID: <20260912161440.1032188-2-vladimir.oltean@nxp.com> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20260912161440.1032188-1-vladimir.oltean@nxp.com> References: <20260912161440.1032188-1-vladimir.oltean@nxp.com> Content-Transfer-Encoding: quoted-printable X-ClientProxiedBy: BE1P281CA0237.DEUP281.PROD.OUTLOOK.COM (2603:10a6:b10:8c::8) To AM0PR04MB6900.eurprd04.prod.outlook.com (2603:10a6:208:17d::10) Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: AM0PR04MB6900:EE_|DU2PR04MB8871:EE_ X-MS-Office365-Filtering-Correlation-Id: dfcd2a60-9659-4f72-766a-08df10e92ee0 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|10070799003|19092799006|366016|23010399003|376014|1800799024|7416014|56012099006|11063799006|10067099003|22082099003|18002099003; X-Microsoft-Antispam-Message-Info: nldCP9lQsDedJ2IT3MV9aACoHWz3sxEvtXFer4l8VxprIf7bi9CE2z4McnIeBipM32aCYotcqzYiUCbz6Ber8s2BI9g/2DzpU1AqS+9yHWXjj3WUA9fkIOHlALOuxi1RPKUFp8GoaPVaWCnhX1VxwcroL5HXJhQv9hvVB8ojG2PzEK8HO9GQ4UKPOjiy8NoJCX/QhyxR9xGaDAltb0a/+1hAJ3Ztthl9kvzl+u4/ZX1c6oW1T16B4kDQ6XJJr9qUhCqvucnA+FLEmNYedO4hxo+9E4orRnfcoQhEyMCtJ1NqF5cTt3SHweyukTpfnx5bRfXK6qjcoWD7bZ4rTuRPxcPTpaFpR5DOInDGiSvg0OmxtCB1ZJpBAjrU4uMmTP5zQ3KicCDrhO7n/gFi6fODvUTnI+yC/axi0MM5IygDPWDRwMJd6q9CLb2wx9oczyFV1+cxRUbhjs46fvtoYcQc9tdaSCR9IjYpKladE5XKBu58f4kvdObD+GBU88AH9l15Gg8iH8AnMLiKbiopET27pS+amxDc7qyawd7GQYq+QgKDkESnptqaXT8wPxAJez7nnJCEXemGPZQY88iz1Ayg53MoQD6EsI/NLO69SypZ9fEj9109ZGWzWlyPrWVtGE0x/grVk6/0LsWPA9KNSwe40YS3onQBvx9rv5+VnTibJgE= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:AM0PR04MB6900.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230040)(10070799003)(19092799006)(366016)(23010399003)(376014)(1800799024)(7416014)(56012099006)(11063799006)(10067099003)(22082099003)(18002099003);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 2 X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?bq37jzzQVknzzrYRlgLkdxFU+SkDj7RMSwwiPaGBJFywr8GnPFh56bG2wAE/?= =?us-ascii?Q?DGpF7E1jEQx4d49kf1E72/MEbhYLQHRLbbyMdk/v1JNhEssGaevaMkObdkRa?= =?us-ascii?Q?DMqoZASSLPWa+wd/xSgNv1n3nF3d7p3maTlRHpwGMar47rdzBIByQiHUzR/+?= =?us-ascii?Q?EEonMMr96fCISHEEzZY8tkd/hGaoN/UZij3v4JpjUL1B1oaTsp1yTLPXdVUB?= =?us-ascii?Q?g6vJgSI6/P6VzDzfQRxGOJUciTGAjyybcZnEpIrWSBJ7DhLxln2cgH7LmDot?= =?us-ascii?Q?bMsgy3HJiJ4P4Ncx20WrXiBtcqKe2hCt5s588AX00isuZX3iTAsN7iON7axW?= =?us-ascii?Q?DDrFy7eMfj1eFrpmJTjINLsfZTUO62/iQdkIm+34PpXCSWPnf2XlTAc56Vv/?= =?us-ascii?Q?Q1uiCA7wOY814FRviPrAJIODpGq0rGLT/wZ3FK66y9gTAhUratt7Q9OKvgxY?= =?us-ascii?Q?yaKdThWUxo3UGC5VUDCyujREcRZYzX+7BGwuHL/IrcjgUVMUyOa8tSmuw1JN?= =?us-ascii?Q?Dq1iqiF4IhGBYVNVlstyz2hsXK8uBlw/cf4eoeLzEnhlvwo9ywCC1mNH2s6K?= =?us-ascii?Q?p0qdULwS10xkMm2VpYHA8gUD+HIucb+aSmhjwns4hoYl38rM+6SvjwsjinXC?= =?us-ascii?Q?va/Pf8hGMTndzb1HoJtzELK8/itu3P3PjOoJS2jEiIe708oOa99CPk2+UTUP?= =?us-ascii?Q?AU7WHaC/3jlM5GsgtH2RKH7kc3ZsfBGlpWxMDvUEuHd+aRR12UV3j6fFSmV9?= =?us-ascii?Q?LePfHqf1lGoSXI4N69uIEVQ0NAiIiD4wPkzbgwQLuWLathkASBRywCkjRWMx?= =?us-ascii?Q?9uM6/3qd5kQ0f+A5DlGs+zcRRa5Z1XiSLcyzr2EhLDHIsEZPH2MpEIErdRBf?= =?us-ascii?Q?aKzUYvqKvOY3n5UWWVVh/akurAUYVPMDPyeqddF0bG5qiiRo2GUSjvhQxHEF?= =?us-ascii?Q?kOD3k3PcMKddPpi8xei+ngZFknBgmeWU1Xr6VSZDKk1aSeFYFkgzoVQRGAGm?= =?us-ascii?Q?2DjmZBt5qnndbNkLZjIMV5yzDMpV+Xk2nJPkZt4GgatuFhK0YKI9tFdJqAyu?= =?us-ascii?Q?OKCplYkdTh2WxlxXhe7ENK89R0Su1TvXCve/BZzYh/DIemgOLQVZLpiHLENF?= =?us-ascii?Q?UTjDjcTphaxq0dI31I8y1OPp+dflG7VOI1xj2ezum/TcrBG5Vi0NfKZ1hhgP?= =?us-ascii?Q?mZCVyfZYmdb2Q7t7JbPheE15rCpIwcSNmgUygV1l9E1LOh8yvGP/F0hbM0NB?= =?us-ascii?Q?B0XH7J8Rp76QIUDZ0OH47Ci39owCmblPxUaaU5Ihhl7M0mQrzS7tUyeLXiqD?= =?us-ascii?Q?Fldv918bJDu+bY4+5ukKUnjIJ0AbKaBsGBeCHUT4Up8s55CIoC+cwAJgqmqp?= =?us-ascii?Q?N/ziS7+4HHak0LIQTPNse8BR8C8TSyjErVdyA5d3iXZnlKih4MB89rxIyLpa?= =?us-ascii?Q?DUmR0CKmRcC37mHAzaNhuUxvEZ3W0V9AGDSIvSSjCF/3vgd1RZVv0QN2Bgiu?= =?us-ascii?Q?V1DAJQ8RUnPD34PqteQIR12OGmnKgy3PjvNdb7LkJAGcyAeY/Dsflya63Qa0?= =?us-ascii?Q?VRdt+Qex8Cfw5R5yqAah5NttH3Ge9Iz5Fdu092LG5v+GkxPR/bddlpiXLnui?= =?us-ascii?Q?WtOsPAI2Q50dP6uzO1/fY3r42Y4iuCfaid0fo14ks1SaWwlnh/QFwwvoLE3B?= =?us-ascii?Q?2/f9x6/kMo2H4cqD0seKfdm562MAfrMOaIKQvCrgN7RaWGueD/SZkMOfncsy?= =?us-ascii?Q?ZP9q7Hr2XFTw1FtrLmRLNFoQzs6pH+ALYs7jV8zP3m1nB16e4aq3hNlD5ILj?= X-MS-Exchange-AntiSpam-MessageData-1: Lsa+P16ntnYq7dLPo8Fn/7guS6dXbQWDDzU= X-OriginatorOrg: nxp.com X-MS-Exchange-CrossTenant-Network-Message-Id: dfcd2a60-9659-4f72-766a-08df10e92ee0 X-MS-Exchange-CrossTenant-AuthSource: AM0PR04MB6900.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 12 Sep 2026 16:16:21.1516 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635 X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: paEUGdy0VPErY9Hxl8/w2xRSsaRpEWuCcYiDAVXddx+t+lyXJefYlNmSYnIJaaIYdzagCIX+rCSFHKiAh9EBzw== X-MS-Exchange-Transport-CrossTenantHeadersStamped: DU2PR04MB8871 Content-Type: text/plain; charset="utf-8" This is a partial revert of the device link pieces from commit dfb80534692d ("PCI: cadence: Add generic PHY support to host and EP drivers"). The trouble with this is that a PHY consumer driver dereferences fields from struct phy, which will become no longer possible. Since commit 987351e1ea77 ("phy: core: Add consumer device link support") from 2019, the PHY core also adds a device link to order PHY provider and consumer suspend/resume operations. The reverted functionality is from 2018, and is redundant with the PHY core now. Signed-off-by: Vladimir Oltean Reviewed-by: Aksh Garg --- .../pci/controller/cadence/pcie-cadence-plat.c | 4 ---- drivers/pci/controller/cadence/pcie-cadence.c | 16 +--------------- drivers/pci/controller/cadence/pcie-cadence.h | 2 -- 3 files changed, 1 insertion(+), 21 deletions(-) diff --git a/drivers/pci/controller/cadence/pcie-cadence-plat.c b/drivers/p= ci/controller/cadence/pcie-cadence-plat.c index a1ea24fc3b63..5900d68c6e83 100644 --- a/drivers/pci/controller/cadence/pcie-cadence-plat.c +++ b/drivers/pci/controller/cadence/pcie-cadence-plat.c @@ -41,7 +41,6 @@ static int cdns_plat_pcie_probe(struct platform_device *p= dev) struct pci_host_bridge *bridge; struct cdns_pcie_ep *ep; struct cdns_pcie_rc *rc; - int phy_count; bool is_rc; int ret; =20 @@ -122,9 +121,6 @@ static int cdns_plat_pcie_probe(struct platform_device = *pdev) pm_runtime_put_sync(dev); pm_runtime_disable(dev); cdns_pcie_disable_phy(cdns_plat_pcie->pcie); - phy_count =3D cdns_plat_pcie->pcie->phy_count; - while (phy_count--) - device_link_del(cdns_plat_pcie->pcie->link[phy_count]); =20 return 0; } diff --git a/drivers/pci/controller/cadence/pcie-cadence.c b/drivers/pci/co= ntroller/cadence/pcie-cadence.c index a1eada56edba..0ac980249941 100644 --- a/drivers/pci/controller/cadence/pcie-cadence.c +++ b/drivers/pci/controller/cadence/pcie-cadence.c @@ -222,7 +222,6 @@ int cdns_pcie_init_phy(struct device *dev, struct cdns_= pcie *pcie) struct device_node *np =3D dev->of_node; int phy_count; struct phy **phy; - struct device_link **link; int i; int ret; const char *name; @@ -238,10 +237,6 @@ int cdns_pcie_init_phy(struct device *dev, struct cdns= _pcie *pcie) if (!phy) return -ENOMEM; =20 - link =3D devm_kcalloc(dev, phy_count, sizeof(*link), GFP_KERNEL); - if (!link) - return -ENOMEM; - for (i =3D 0; i < phy_count; i++) { of_property_read_string_index(np, "phy-names", i, &name); phy[i] =3D devm_phy_get(dev, name); @@ -249,17 +244,10 @@ int cdns_pcie_init_phy(struct device *dev, struct cdn= s_pcie *pcie) ret =3D PTR_ERR(phy[i]); goto err_phy; } - link[i] =3D device_link_add(dev, &phy[i]->dev, DL_FLAG_STATELESS); - if (!link[i]) { - devm_phy_put(dev, phy[i]); - ret =3D -EINVAL; - goto err_phy; - } } =20 pcie->phy_count =3D phy_count; pcie->phy =3D phy; - pcie->link =3D link; =20 ret =3D cdns_pcie_enable_phy(pcie); if (ret) @@ -268,10 +256,8 @@ int cdns_pcie_init_phy(struct device *dev, struct cdns= _pcie *pcie) return 0; =20 err_phy: - while (--i >=3D 0) { - device_link_del(link[i]); + while (--i >=3D 0) devm_phy_put(dev, phy[i]); - } =20 return ret; } diff --git a/drivers/pci/controller/cadence/pcie-cadence.h b/drivers/pci/co= ntroller/cadence/pcie-cadence.h index b4d51adefea5..4a96e1869e53 100644 --- a/drivers/pci/controller/cadence/pcie-cadence.h +++ b/drivers/pci/controller/cadence/pcie-cadence.h @@ -260,7 +260,6 @@ struct cdns_plat_pcie_of_data { * @is_hpa: indicates if the architecture is HPA * @phy_count: number of supported PHY devices * @phy: list of pointers to specific PHY control blocks - * @link: list of pointers to corresponding device link representations * @ops: Platform-specific ops to control various inputs from Cadence PCIe * wrapper * @cdns_pcie_reg_offsets: Register bank offsets for different SoC @@ -276,7 +275,6 @@ struct cdns_pcie { bool is_hpa; int phy_count; struct phy **phy; - struct device_link **link; const struct cdns_pcie_ops *ops; const struct cdns_plat_pcie_of_data *cdns_pcie_reg_offsets; int max_link_speed; --=20 2.43.0 From nobody Fri Sep 25 12:34:04 2026 Received: from PA4PR04CU001.outbound.protection.outlook.com (mail-francecentralazon11013012.outbound.protection.outlook.com [40.107.162.12]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 93D06427F91; Sat, 12 Sep 2026 16:16:31 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=fail smtp.client-ip=40.107.162.12 ARC-Seal: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1789229795; cv=fail; b=Eujncc9DGBazlGercQXUIULUXvdzQjORRvqyxjvA5cAg5uj/XjiiiJhYeKv3KZNBKleIT+q9MNjXgMwDSCbKKQ5YSYil3rpfNQUw1JIkqQS+5P9E/2t72HVipGNZnEImCoSMPeWuNryPoFqACnfxa3l2uiqw24MXGJalTZ4CteY= ARC-Message-Signature: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1789229795; c=relaxed/simple; bh=iWfRCBeWF+rMftPu49fErmuRqrm6LVsJICKHCpTnLOQ=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: Content-Type:MIME-Version; b=VxSsid1XgUJOZJyypTEIUO14KwGjJKXRgmqAlsqGMemU6pZB97ud5g05L6SYGDuy+6zDXBEaOAwA0YwBoIfSaOftW1Jb6BqZWiP9dSV2XKOuSFdOYtzdnvEVNeLpHmlZ2E4OJAipwJhL91X32S2WMInTTGvcuMWh+Ly181mVbd4= ARC-Authentication-Results: i=2; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=nxp.com; spf=pass smtp.mailfrom=nxp.com; dkim=pass (2048-bit key) header.d=nxp.com header.i=@nxp.com header.b=NkoFbzey; arc=fail smtp.client-ip=40.107.162.12 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=nxp.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=nxp.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=nxp.com header.i=@nxp.com header.b="NkoFbzey" ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=xR6YlSKkSkzdbmn59fHcCCxo4g8QbLsm88fwmIwoLg8vE+BsFgt6crqc3xxLM4rS+abKZqUUwQsSFL/pcxzQS+/e+PTX9A/bDi8QRvSntY/E8OUeS+L0+6WwNdbZ5q3CEyp+8x3Ecx+1z9/YyfY9uRAqLxm28HLi3DA7iO4dxC2jXaeNbCOUEfNF7Uk9ug/WiwHlCTJRsSIEVOGQdS00VrL+3vefDrTJwHIJMkmbUHwatDiOSYj7cyNKXYkQ7qt4IaVXIG0J0o7z5T1H5EoiNIcmE7ry/gWMdcFyCxox2DWUfZe8hTFdrK7i1NB6Yyt7JoSh+yFck640U1F3KMeMkw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=Vo1iUfq8fAGc4cAtbqSOHX5idKCUY6sNEISnoEDPgRM=; b=MEjl+5ZpgSavLDd3UeuAuVQyRuAQcS6gejoXuFNoEtIKS4OCzVY2wn1LDNO79fbTfgScbo/n4SP9Qx0+42tICfd53syMyZlEjZYdJ1YtYUI3Ptfp46SF9dMNiIVbQx/UvfEaKmsgRuPVfUNEIluO7qzHP85NaV2cMYgT20YVADzC+J7+UzZWg4UWNaK4zc9r5QrBBNKNEqlGNosG7D17EK2sEB+9V+1IeOErf7hilIVZ0R8qCv5aFzUxKblRWtcXZbwv7F9ZH6MmF0h8ULyfHYNOlzmU6cFPl7Kzylv9U6Xt64RbyvZXRFEnSNhvvy9z9co37pBwOqjKMiLQItgI9w== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=nxp.com; dmarc=pass action=none header.from=nxp.com; dkim=pass header.d=nxp.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nxp.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=Vo1iUfq8fAGc4cAtbqSOHX5idKCUY6sNEISnoEDPgRM=; b=NkoFbzey7P4hKvIV2URTc2zCR2C5ormCK8p+xqIYbw3AbMYdp5i5J2EpLLnnwOORrvdA8+6/o6b/vFhkhvL/PdWotKGUuZUoZlK4nyMPVHQz8tlQIYtLUTAAkA5XgeiY7KR9/1MHHLhgNVyI71yOCKor+TD8HCC5kd2Eni7E7mqlA5BF6YZL94BQNRsgsXJV2gL2VOIlSssQG9dsScnjTZBYY++qs+d1T1Ue17R/ymXXsj0afe6+5w17ATVebLW77Bbt1V7wIygeeJmnqtdCSthuUpsFv511qcfEMHGgdgHxTmUW+U+4uEgwstU0p4g57U5CqCmi/WZ3N69wnZWomA== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=nxp.com; Received: from AM0PR04MB6900.eurprd04.prod.outlook.com (2603:10a6:208:17d::10) by DU2PR04MB8871.eurprd04.prod.outlook.com (2603:10a6:10:2e2::11) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.21.406.10; Sat, 12 Sep 2026 16:16:23 +0000 Received: from AM0PR04MB6900.eurprd04.prod.outlook.com ([fe80::7fda:8431:ca1b:b023]) by AM0PR04MB6900.eurprd04.prod.outlook.com ([fe80::7fda:8431:ca1b:b023%4]) with mapi id 15.21.0406.007; Sat, 12 Sep 2026 16:16:23 +0000 From: vladimir.oltean@nxp.com To: linux-pci@vger.kernel.org Cc: Aksh Garg , Lorenzo Pieralisi , =?UTF-8?q?Krzysztof=20Wilczy=C5=84ski?= , Manivannan Sadhasivam , Rob Herring , Bjorn Helgaas , Vignesh Raghavendra , Siddharth Vadapalli , Manikandan K Pillai , Felix Gu , linux-kernel@vger.kernel.org, linux-omap@vger.kernel.org, linux-arm-kernel@lists.infradead.org Subject: [PATCH 2/3] PCI: dra7xx: Remove device links to PHY Date: Sat, 12 Sep 2026 19:14:39 +0300 Message-ID: <20260912161440.1032188-3-vladimir.oltean@nxp.com> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20260912161440.1032188-1-vladimir.oltean@nxp.com> References: <20260912161440.1032188-1-vladimir.oltean@nxp.com> Content-Transfer-Encoding: quoted-printable X-ClientProxiedBy: BE1P281CA0459.DEUP281.PROD.OUTLOOK.COM (2603:10a6:b10:7f::9) To AM0PR04MB6900.eurprd04.prod.outlook.com (2603:10a6:208:17d::10) Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: AM0PR04MB6900:EE_|DU2PR04MB8871:EE_ X-MS-Office365-Filtering-Correlation-Id: fa20adb5-00c0-49f3-9179-08df10e92ff1 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|10070799003|19092799006|366016|23010399003|376014|1800799024|7416014|56012099006|11063799006|10067099003|22082099003|18002099003; X-Microsoft-Antispam-Message-Info: COjZNqBnyLpMt4aD6PAY5geU6O1QsUocitp/P8KIdtCj1DrJkTfLiCExhAX/2o3wv+EBEBbOiEpy3IddNLDIeMeWTAbptllHOrnS7bkcwY8JC94L4+OEr+hkkVwKo17TkTv0Ui/6oJgMAXZL3S4nWU4Sp/0MYokrG8NWV5jW4uHQLTm6vwhgSghiRM8719HkhO9wFT831dP4BYHXZGGJgK5fBlleM8ZdMbnbPJrNHKlRy/Lxxq507lGBJRRtgmwHVsfpJ1uPtu1cLiaMbKwypNFS47+Vg76NEZ6rDgl2ZbhvPnAzfqutGFVCsmzaR3r9mqhN/1JO4FfH8xbmSRmKqesGzrgTJ00m9yF9X2PLPOc3LTaQUhE1vAAgOsJhu9O4CVsCs9+7L2tqN4It/zeDAh6f0PMFrmrDOXl6TFHtGh4er5wLq8uKtw2tsDqhzeOqmuXy4bxRLxyN0GNPLfXYNlBlOGymVCRxpKD0E4SbgOFFubgWHEanKp+NFdt1htoJwaY2xzK/0xj/PoC5stnpDunaKj453n/OsUXjyV0kw/PkoCU5+LC7/IFa8XnYPfy5myvbqqKNADDe/ILNTuIDcuhSZcqJepFfSOqLjeC+swAl9kpNehinj2HSFRgcLF06NoLd/RO1B5uyN9Xo5Q70VNqbyHm2DK8ctWNhAC2jirg= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:AM0PR04MB6900.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230040)(10070799003)(19092799006)(366016)(23010399003)(376014)(1800799024)(7416014)(56012099006)(11063799006)(10067099003)(22082099003)(18002099003);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 2 X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?d5YYvqO8B5ldIElyk8Zz/vJBJvFnzFxERTh/Vz5BIkvUBk/ruj3853jukXLr?= =?us-ascii?Q?6+0RVNd3XpDCRG3Ir9lRuKEeZoKDg8H9HEgeTLh8CTW8HRk61mHJy7gwvmjq?= =?us-ascii?Q?INOoACqS9IGwueb08xsX5CcCULT1e2fr5swdz93nJa6yrGdD0Un19ZcthbCk?= =?us-ascii?Q?k6Xc0+ImwYqdwePkNReNdUHhKk3c13cZQb8e3flQl6PZdy2va/LjWc+eAHQH?= =?us-ascii?Q?bL05mPwNLHxJ5axuAMOwPLWVBCg6o/renHL3bB0KEC0J+XbcKTfsL6IY4lmg?= =?us-ascii?Q?XXEj5UjyqzdFAZEpc+SDOEPI0G+rFK7L8V5GdjQ/S7Jbsk7YkpeVmo5SVsbJ?= =?us-ascii?Q?Fy9Bh4Gdu9GKutFzTBiySj1l4iMD8Oug7hMXhMKjIRBQ0eyj50i6H7cwEWjW?= =?us-ascii?Q?sXTTHVsgQIFHgov6vOa/dimc4kX10ykGSrQY7vciQSgmDBg8ANXhp46sqv8h?= =?us-ascii?Q?CC5QC/1GLN+Hbb9nTLidBHDGKXeL8QgOnqqaoIKgAWa473TOcEEw58/gWKg6?= =?us-ascii?Q?fNP2D0se2NVXKVDyehvNZcOU+O6IIzS1Z41/hjMySaPt5z0MP+zXsCTa976D?= =?us-ascii?Q?3vGHya6rdIItB/f/1SdliAsJnDH62eKF7GqyXnGyBfGy8BSLLBQMzurrCMk2?= =?us-ascii?Q?F/czwZVIYyP2NRjaN0wc+z1W7IHHEK3KNKAtnCrDbA9ERp/SXHhPm4SAS1Qv?= =?us-ascii?Q?5LHlHl/l34Xr/3GK2YEl8/3V/e88uWqdf00OXgZC9/d0O28jlMNzcn08S/3+?= =?us-ascii?Q?7n5lQkRfRWDlQYAbXzc6P2lTNvRn12wwRvwhT9J7Vnd5mwyWNl29r/1pPy1U?= =?us-ascii?Q?/e9g3xMwihXQJQ3ReAtkneurnymYNAqvKbKen+OKe2mbXnkAVyS2L17iwebd?= =?us-ascii?Q?IqnL2ISVyCINBtpx+MX1fM63U0NIuxjYjLa+1XsFHTva4SEC7EGxI+DxnTFI?= =?us-ascii?Q?o2C03i/nw+YCeoarUWSL5ik6ypqXwbaODGmKszS5f9vGoi3pjS6BIfSLb2DG?= =?us-ascii?Q?JvLfc7b6Htrwue7Wvw3OtweH/1JQ12ILMPwBcPbeSniFlhMBvohg65pD4SQS?= =?us-ascii?Q?Cm7erzxStCA7Mo2nFl6hUdcQejrGqDPHEmn457ZXDliEmB1a9ftD+iVxrbls?= =?us-ascii?Q?+q4GgSB8efWc2jMpp9zfH/JWjIO3EktKUX4VSkdJqgnFymq0DUUTkG61k0cc?= =?us-ascii?Q?Ym0vZzb7YqwYgRP1dZwjKsnFcuduPs3NdCTl8fJ+xByqXf7zFvtnfgHivRNG?= =?us-ascii?Q?gKC619fl2mQJJVEiiRD9fG1tgi7NIPMKZR2ttnUuuX12nJ+YXrGzgpYhMV9E?= =?us-ascii?Q?iQClzvXIy+xFPBTue4Ru0s2pheXCuJzcHyCb9EFbtXy6z2XMhIjgNDHZv63w?= =?us-ascii?Q?uSrh0jhPO0YWR10Z0i2WWMJVE9P9xJ5rS0czBNdNhm0QmOZrkHXTTzRDMNYP?= =?us-ascii?Q?/0wD+sUdRqk4Z2mzBAZOTI9czOvGrR3JKb8eoVceCS1rkJR7UCMjgXp4R4e0?= =?us-ascii?Q?XTD2nDpVT/nmSe0PQlFPjMhTeLfwNaRj8zT5a2hDDTGdr+QcY4cohb9mD9qp?= =?us-ascii?Q?bFaZbFWKX6eD5Y2oktUYlTKN91QFFPxavnTxBckFsZaHCMAh1MSdDD6iBPO8?= =?us-ascii?Q?UzdzRIV6SQKec4FkSVnuFtcl4uzK9gqg3MnQkvFB/+885MegzzXEpAO9TG2u?= =?us-ascii?Q?v84YkvcK2fcQ/lABqhW76JmTrGMwhLbt/Rev4tRweEIlKdtcnEHNsUG8sSIo?= =?us-ascii?Q?J5aNAiwVn3rT/6+lXia3tBF4atkbqYJolHSlCLfawCH3QdEJoUWn6189dDJk?= X-MS-Exchange-AntiSpam-MessageData-1: GpLn3TAMyG7QIbMRdIa+yhTvPoH96bG25os= X-OriginatorOrg: nxp.com X-MS-Exchange-CrossTenant-Network-Message-Id: fa20adb5-00c0-49f3-9179-08df10e92ff1 X-MS-Exchange-CrossTenant-AuthSource: AM0PR04MB6900.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 12 Sep 2026 16:16:22.9866 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635 X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: 5qR/WPluZ9hMHoH0o/lBv03j/DUbtDUk8rAW+QSEKEQRk+9bAPKAOnJc3eGjWGYfZE55leDfnPGBObskLk6tLw== X-MS-Exchange-Transport-CrossTenantHeadersStamped: DU2PR04MB8871 Content-Type: text/plain; charset="utf-8" This is a full revert of commit 7a4db656a635 ("PCI: dra7xx: Create functional dependency between PCIe and PHY"). The trouble with this is that a PHY consumer driver dereferences fields from struct phy, which will become no longer possible. Since commit 987351e1ea77 ("phy: core: Add consumer device link support") from 2019, the PHY core also adds a device link to order PHY provider and consumer suspend/resume operations. The reverted functionality is from 2017, and is redundant with the PHY core now. Signed-off-by: Vladimir Oltean Reviewed-by: Aksh Garg --- drivers/pci/controller/dwc/pci-dra7xx.c | 16 ---------------- 1 file changed, 16 deletions(-) diff --git a/drivers/pci/controller/dwc/pci-dra7xx.c b/drivers/pci/controll= er/dwc/pci-dra7xx.c index 6ae5b27e27b3..6c9e88177600 100644 --- a/drivers/pci/controller/dwc/pci-dra7xx.c +++ b/drivers/pci/controller/dwc/pci-dra7xx.c @@ -9,7 +9,6 @@ =20 #include #include -#include #include #include #include @@ -680,7 +679,6 @@ static int dra7xx_pcie_probe(struct platform_device *pd= ev) int i; int phy_count; struct phy **phy; - struct device_link **link; void __iomem *base; struct dw_pcie *pci; struct dra7xx_pcie *dra7xx; @@ -728,10 +726,6 @@ static int dra7xx_pcie_probe(struct platform_device *p= dev) if (!phy) return -ENOMEM; =20 - link =3D devm_kcalloc(dev, phy_count, sizeof(*link), GFP_KERNEL); - if (!link) - return -ENOMEM; - dra7xx->clk =3D devm_clk_get_optional(dev, NULL); if (IS_ERR(dra7xx->clk)) return dev_err_probe(dev, PTR_ERR(dra7xx->clk), @@ -746,12 +740,6 @@ static int dra7xx_pcie_probe(struct platform_device *p= dev) phy[i] =3D devm_phy_get(dev, name); if (IS_ERR(phy[i])) return PTR_ERR(phy[i]); - - link[i] =3D device_link_add(dev, &phy[i]->dev, DL_FLAG_STATELESS); - if (!link[i]) { - ret =3D -EINVAL; - goto err_link; - } } =20 dra7xx->base =3D base; @@ -853,10 +841,6 @@ static int dra7xx_pcie_probe(struct platform_device *p= dev) pm_runtime_disable(dev); dra7xx_pcie_disable_phy(dra7xx); =20 -err_link: - while (--i >=3D 0) - device_link_del(link[i]); - return ret; } =20 --=20 2.43.0 From nobody Fri Sep 25 12:34:04 2026 Received: from PA4PR04CU001.outbound.protection.outlook.com (mail-francecentralazon11013012.outbound.protection.outlook.com [40.107.162.12]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id DD01727FB37; Sat, 12 Sep 2026 16:16:35 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=fail smtp.client-ip=40.107.162.12 ARC-Seal: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1789229797; cv=fail; b=f0nxEIbvzk21/9co/XUNbq2pqPUPbvHzrn8xSStv6ymnY39/nfotxSkXBIFHqxSyNrgo9KmW+W7FwyMoZSN8AnN1/e7+udSKLILhnbVWKpCwWhycF5aM0ZdXf250vdKHQLTlcpjVzr17KZHWykFeIrKOcl0jYyea4L7j4+zeD5g= ARC-Message-Signature: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1789229797; c=relaxed/simple; bh=/qrbLHadHC3vjBMOOck7EXhLBFi2SszF5M2IP4QOOX0=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: Content-Type:MIME-Version; b=nV22kFhpsrX8fBoArS6gs4fAxWZsXKRBaeVYMs8PnwuaxfUvRmRiIaZmr8AxNNOP0W6rqnZZJA46jkzs+pm7KjsqbPi+bfJpVrqu3naVvO/LsUMGNwqnuLJT71tPtYHZpQkGJRgiwmH3y5ut/jLOg+c27IgP2Sr8WwkWiFTmlME= ARC-Authentication-Results: i=2; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=nxp.com; spf=pass smtp.mailfrom=nxp.com; dkim=pass (2048-bit key) header.d=nxp.com header.i=@nxp.com header.b=eopY0BWO; arc=fail smtp.client-ip=40.107.162.12 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=nxp.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=nxp.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=nxp.com header.i=@nxp.com header.b="eopY0BWO" ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=v/Tp4CLqhTOjRSYSS5Qiw67eJe0aOD6jzcgfdVUdIO6kes5pwtLbeLSAlD6rpVzPjqsHT6bbeGagrlBADJk/0ls+7qCngLHX9PU450IO0XV8gBd7gAWssSV9XApBd+osvX408bXNBbMVlPHivzJ05CxPR9KVIF8I6ixiB9WDAZ1Gzpr0f1QJxdzA7+o5e30Gz+fLCn44pdnHaar2R7KC2j+bRi6jEvgqD7wygoTuGrIYb7uKYaStVdbdfGfR6ie8MEi7SQkv1l8WAbzRrijH/hPaST7V1zvDGbRvL4KjfXhlLQ0ygDPUG1qozwrs0tfGhPhR07iwn8SEtOK4ZtPseg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=LoZbRRqYtVHqcPM6hFdzgqle9b2xvCA1hlTCv7ez/50=; b=qCiQXUxWxBLoBuM54VNYSVHy28ukpZvIo6eMqk1kIIGYeOYyl3wCeYSITIn6aBKLSqEyZHQ/9bV9804vxil2zlfRJbFiNL9E6v4dRQa7E/aX03zWbLG+YBuiRqIrhbhjRijpaYxW77LKYrxzxZ9A8kuKjuk5+IIZLzzPVxIRUmpJenhvsxvVsFRn9p+R7I28iVzMLZ24oKsxVerRlJJvpeSEETFTX01M1nLpkZv4Ln7dK50dRFUQ0qbvgeoKa0uoF7JyN66wwirxg/F8bINAr3tFOg8tn+HMJQ3vqmqPmaF2jS2CettmcftnPy+2a4ZF4QMjIVQt4ocrFFUyKekHyg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=nxp.com; dmarc=pass action=none header.from=nxp.com; dkim=pass header.d=nxp.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nxp.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=LoZbRRqYtVHqcPM6hFdzgqle9b2xvCA1hlTCv7ez/50=; b=eopY0BWOAk15ljI6Lhaxu9PZm4OMawBQptoeM1dyz6TZxHiaINDdm0N1EX433lBaJsERkMGyew6K81Rc8u+2lye6lJTE8z3RxnkdDqOzSfqTIKDD6YapaJ3JIy0QnRpzveQt5Uqfq2MyIIVAfX096PjWicdGOCWFdQJCCHQF6BJ1n+Tl9g6NAW/sGWE1NhxmWHYr+cMyAbsXpC6VtkjaWqu2hvAAN2lGfhwhXw8/N2G3qOT5EDrsEufE5B65L5yz/OqF4LoYzLrew4HIOcmwUW2b7X5ix1quPBuFAWHq/jAJFW1RX7ic4AXpJ4ET6zvKYf41X3GMSXEbjPDWB8fBNA== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=nxp.com; Received: from AM0PR04MB6900.eurprd04.prod.outlook.com (2603:10a6:208:17d::10) by DU2PR04MB8871.eurprd04.prod.outlook.com (2603:10a6:10:2e2::11) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.21.406.10; Sat, 12 Sep 2026 16:16:25 +0000 Received: from AM0PR04MB6900.eurprd04.prod.outlook.com ([fe80::7fda:8431:ca1b:b023]) by AM0PR04MB6900.eurprd04.prod.outlook.com ([fe80::7fda:8431:ca1b:b023%4]) with mapi id 15.21.0406.007; Sat, 12 Sep 2026 16:16:24 +0000 From: vladimir.oltean@nxp.com To: linux-pci@vger.kernel.org Cc: Aksh Garg , Lorenzo Pieralisi , =?UTF-8?q?Krzysztof=20Wilczy=C5=84ski?= , Manivannan Sadhasivam , Rob Herring , Bjorn Helgaas , Vignesh Raghavendra , Siddharth Vadapalli , Manikandan K Pillai , Felix Gu , linux-kernel@vger.kernel.org, linux-omap@vger.kernel.org, linux-arm-kernel@lists.infradead.org Subject: [PATCH 3/3] PCI: keystone: Remove device links to PHY Date: Sat, 12 Sep 2026 19:14:40 +0300 Message-ID: <20260912161440.1032188-4-vladimir.oltean@nxp.com> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20260912161440.1032188-1-vladimir.oltean@nxp.com> References: <20260912161440.1032188-1-vladimir.oltean@nxp.com> Content-Transfer-Encoding: quoted-printable X-ClientProxiedBy: BE1P281CA0165.DEUP281.PROD.OUTLOOK.COM (2603:10a6:b10:67::14) To AM0PR04MB6900.eurprd04.prod.outlook.com (2603:10a6:208:17d::10) Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: AM0PR04MB6900:EE_|DU2PR04MB8871:EE_ X-MS-Office365-Filtering-Correlation-Id: 7746d58e-44ec-4dc1-8c92-08df10e9312c X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|10070799003|19092799006|366016|23010399003|376014|1800799024|7416014|56012099006|11063799006|10067099003|22082099003|18002099003; X-Microsoft-Antispam-Message-Info: z5x2Ic+mP0jnDdsmvmFQip5ZaHyn23IDA1Ky+TWaN2Nc2ovenmYOJ40XxOtP4E5+1DhESXzt7za5z8H1RFNfU08cmXyg2UUMA8OoalBFa3VoY62Qsyh6NCNG3cXsCn/1ko6TfWUzTQ9Dk30gV5znl9p7ljavmr1QSBxx8320MQg2CUevuVsPfaGuqIPl5zmphBXeTKBAmQrkMMh103kte+LJ+2GM9b1CH9HYJ+G0cGH52Px+9VRKvJbqp1Spd61M8YhnFtyuGKyxZ5BaZTk7qgYjqd1qwQmRxtCL58/5VPJ36umpfSPVKctvOG97cyaSBN5rrHGkNKD5oUCODtQhIsydlPIm4TJH0q4n88MY2lSajdcgWnXHOHMoyfnI1QBteAPaNniaUo/aEb7NtChJAO5yzXHOyHAK5L3kHwT2g0uEPH0jm8r/SKfpavOLwmyBlHj8DgVXD6DjP9pNakDw4EYThG9x0Nb0oXLJXAXOKJU1Ws5p7pz9g1Gj+FOPX8B38gEdoPKtvjfKt6yo2QcEaW5w9Nw5e9RAyK32ALhCRr/DOhVh/ws5EE+L4Au/HbvuDf7NGcp/LxEHhuX12QUd0fXKd1klpXkMpAZbY34b8W7nJzPndG3Q2GL6fVZ7hUcLGRjPip1e2K9cb7mrXToACogLuWLiXiS4mlNUqTKDAug= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:AM0PR04MB6900.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230040)(10070799003)(19092799006)(366016)(23010399003)(376014)(1800799024)(7416014)(56012099006)(11063799006)(10067099003)(22082099003)(18002099003);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 2 X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?qDrhgmbsYWHectne4eakpUVJarkFBFk+J3GMCVt3OYNtAUqva4vHwel9fnbU?= =?us-ascii?Q?VweVX/dJKwc3vzgluyTuttv/8sz8rS6iIPrYcTHyBmof6uastBIxcKpn/LMh?= =?us-ascii?Q?BKKcYrT4GxfKTkwswsgHsNvjvCPGu9to/798MotjsJB7fRkv72/ti3QpgN/b?= =?us-ascii?Q?Fiy+sv/AsnDklpS8FAX7ZZ+gu8EIwSF51aoLDgQAKniqBImn0AyrDMdhY45Y?= =?us-ascii?Q?ezr0cU7gdsCBy3x54yzY43FOzC/r3aM6bI2jh/gNU3df9tlv1Rv8mQW+QAGl?= =?us-ascii?Q?5l3BabxKWcMZmBTryKt8bHhPaaygZj5gr8ZxSVSy0zFJI3BYmypmyateJbGF?= =?us-ascii?Q?wxaPTZUiEp3sfaI25SI4T0AWmQh6JgzV7H8UaRxH+8nSjDXW6mvEqMZjBFqP?= =?us-ascii?Q?4RCoRmiYoNTCD36/0n92+4VIXpk3witJiriMZkJNS902DyZ+plolTN+ZEKG1?= =?us-ascii?Q?R12ZdhyBGs+4Z3Vb1mqdm0Fh00++lYK8dkhf/YSrOJOPgjWACTtRgim79ykR?= =?us-ascii?Q?JPBcTPA4Fx1wUSmYPTEe2mYDsx/QWVBzMtzwnsyc7PPgJlQaO6+yWfPKpYD2?= =?us-ascii?Q?cYuhCo9INT3mxCFYe0cXM6roxDEy31r6Ir8jcam9ABNBFYAwV/n1xZ0tt1b8?= =?us-ascii?Q?OWa10EuAYa3UpAp7MZyiaPPrC/9Sep1nO+dVzuUs1gvik/LSGbFIFvOOuI9h?= =?us-ascii?Q?X/upxrbHWlKpRB1xyu/K3Ctw8TbmU1Bj+JQnneZT2XhF60h4grYsqVhDZZIb?= =?us-ascii?Q?FFBSjFsb4UYcSpERIpZa7y5759JbRMMbGTzY7UmbMgIx+Q+WF8qPFlwhX6B7?= =?us-ascii?Q?G2zBksRPw7bzMs0mBvTG7SYo/6Ek0SWjqWjEC3HrJaka76R6Uc/ltS9xlil5?= =?us-ascii?Q?ewZjuBLtLHtQwr1jGcJtS3w3YG8iCGrgzn/M73c7W4y9GSL9KahiQqMd9Ywf?= =?us-ascii?Q?T77oPrYgvfZ/ErMbvxXvqbTr0p8x2/teQ1Ub+lEtnBJO3fnXLVO4iKEU0yKl?= =?us-ascii?Q?1UtCl4y3hiwJc8Pf1H3uiAGplEgWim4Pbo8yBrTd8FxgKmpB+66GZuyS0vau?= =?us-ascii?Q?ALJfR1SqtV6rb1CmNjBH0Z2FFt5Vbj8MWCRJY7vr9aD1hHtjAiLCE7C+CT1N?= =?us-ascii?Q?bbPVYeF4mz10bOCOd0DZGSVLKpGKtuUFWjoXdpAyBxK+Ro+9qwyFEh3xlyBa?= =?us-ascii?Q?WFVe+FQh6a9rgXot2wwyo5cOcY49BIFomqKF06RldzWqaFFEkS6DkfkKNHhG?= =?us-ascii?Q?SRJtQZiBOIkuVRDNfs82gJGLa+3sjyGVUUlWj1uOgy3bH3+caIx65M+3NoPo?= =?us-ascii?Q?YnK4Y+t+uZEOutO6l5ccKV81aNOoCyC3mxdG6Az2Pqk+tBFxxYh92bgZ9mEH?= =?us-ascii?Q?3wbaAHnNdP6CR5xeS3r5j1NTJ9V8OvOFfYJJOKFVVrJ+dx80GBPPCR+xWxv4?= =?us-ascii?Q?x672twxkhaGK7WVBhHM4oRgz7pvlf/z0pFDBbEznQn8iGeogFrnmXFkbwjSe?= =?us-ascii?Q?YkV+IwlmH6nEqbrawyil+n+sl0/KVli3GQAv/kpg8M8fJU3w89JN74geYgqO?= =?us-ascii?Q?PSORJIpyocllVhyua89xKczJEAn7kqHDgZ3Ufslva5av9meOZf7wxLP2/JbX?= =?us-ascii?Q?6TjJxrw6LzlwZZDGfh1CpMoUPDMRKgaiDZfccGQjzsDZXF3MZJuKVi8hJRlJ?= =?us-ascii?Q?J7ttTOplhXykz6h2q3tSTAitfIlJ3atwR7A1GYB4KYWLslFjUC3BOhcAFsCa?= =?us-ascii?Q?QXoIAmjSf5iZjotos8cp7K8Vc5P1grXTbdC9aF9sTSHzxahjXzp1FTX69PlG?= X-MS-Exchange-AntiSpam-MessageData-1: bPoWTVpbtHLBLyKxgGBKMtWxQY5vwjNHNCs= X-OriginatorOrg: nxp.com X-MS-Exchange-CrossTenant-Network-Message-Id: 7746d58e-44ec-4dc1-8c92-08df10e9312c X-MS-Exchange-CrossTenant-AuthSource: AM0PR04MB6900.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 12 Sep 2026 16:16:24.9251 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635 X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: cZaoLkjFToVkv+JZp7vO8D3gE1ug0AtMZu2b6Evaz8E42eal6tNwQ4y0/M5/ldN1ZbYLWAWO6khqHwurhUj1IA== X-MS-Exchange-Transport-CrossTenantHeadersStamped: DU2PR04MB8871 Content-Type: text/plain; charset="utf-8" This is a partial revert of the device link pieces from commit 49229238ab47 ("PCI: keystone: Cleanup PHY handling"). The trouble with this is that a PHY consumer driver dereferences fields from struct phy, which will become no longer possible. Since commit 987351e1ea77 ("phy: core: Add consumer device link support") from 2019, the PHY core also adds a device link to order PHY provider and consumer suspend/resume operations. The reverted functionality is from 2018, and is redundant with the PHY core now. Signed-off-by: Vladimir Oltean Reviewed-by: Aksh Garg --- drivers/pci/controller/dwc/pci-keystone.c | 31 +++-------------------- 1 file changed, 4 insertions(+), 27 deletions(-) diff --git a/drivers/pci/controller/dwc/pci-keystone.c b/drivers/pci/contro= ller/dwc/pci-keystone.c index 602516239a57..bd736a1624bc 100644 --- a/drivers/pci/controller/dwc/pci-keystone.c +++ b/drivers/pci/controller/dwc/pci-keystone.c @@ -129,7 +129,6 @@ struct keystone_pcie { int num_lanes; u32 num_viewport; struct phy **phy; - struct device_link **link; struct device_node *msi_intc_np; struct irq_domain *intx_irq_domain; struct device_node *np; @@ -1131,7 +1130,6 @@ static int ks_pcie_probe(struct platform_device *pdev) enum dw_pcie_device_mode mode; struct dw_pcie *pci; struct keystone_pcie *ks_pcie; - struct device_link **link; struct gpio_desc *gpiod; struct resource *res; void __iomem *base; @@ -1202,31 +1200,17 @@ static int ks_pcie_probe(struct platform_device *pd= ev) if (!phy) return -ENOMEM; =20 - link =3D devm_kcalloc(dev, num_lanes, sizeof(*link), GFP_KERNEL); - if (!link) - return -ENOMEM; - for (i =3D 0; i < num_lanes; i++) { snprintf(name, sizeof(name), "pcie-phy%d", i); phy[i] =3D devm_phy_optional_get(dev, name); if (IS_ERR(phy[i])) { ret =3D PTR_ERR(phy[i]); - goto err_link; - } - - if (!phy[i]) - continue; - - link[i] =3D device_link_add(dev, &phy[i]->dev, DL_FLAG_STATELESS); - if (!link[i]) { - ret =3D -EINVAL; - goto err_link; + goto err; } } =20 ks_pcie->np =3D np; ks_pcie->pci =3D pci; - ks_pcie->link =3D link; ks_pcie->num_lanes =3D num_lanes; ks_pcie->phy =3D phy; =20 @@ -1236,7 +1220,7 @@ static int ks_pcie_probe(struct platform_device *pdev) ret =3D PTR_ERR(gpiod); if (ret !=3D -EPROBE_DEFER) dev_err(dev, "Failed to get reset GPIO\n"); - goto err_link; + goto err; } =20 /* Obtain references to the PHYs */ @@ -1251,7 +1235,7 @@ static int ks_pcie_probe(struct platform_device *pdev) =20 if (ret) { dev_err(dev, "failed to enable phy\n"); - goto err_link; + goto err; } =20 platform_set_drvdata(pdev, ks_pcie); @@ -1338,25 +1322,18 @@ static int ks_pcie_probe(struct platform_device *pd= ev) pm_runtime_disable(dev); ks_pcie_disable_phy(ks_pcie); =20 -err_link: - while (--i >=3D 0 && link[i]) - device_link_del(link[i]); - +err: return ret; } =20 static void ks_pcie_remove(struct platform_device *pdev) { struct keystone_pcie *ks_pcie =3D platform_get_drvdata(pdev); - struct device_link **link =3D ks_pcie->link; - int num_lanes =3D ks_pcie->num_lanes; struct device *dev =3D &pdev->dev; =20 pm_runtime_put(dev); pm_runtime_disable(dev); ks_pcie_disable_phy(ks_pcie); - while (num_lanes--) - device_link_del(link[num_lanes]); } =20 static struct platform_driver ks_pcie_driver =3D { --=20 2.43.0