From nobody Fri Sep 25 13:16:56 2026 Received: from mail-wm2-f12.google.com (mail-wm2-f12.google.com [74.125.225.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 0013825228C for ; Sat, 12 Sep 2026 06:28:07 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=74.125.225.140 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1789194489; cv=none; b=FgkBHqPjijzKWNlEmgVaM6sFCR6IzlPBe5hC+AtQhcrEMdML25Zt1IHVU1xRvafQItkmoyFgeQEGMRfNXYhrDmkEp2EOPzRuz2epV5E61gA8WqnJ6ldD9z7sJONtndDu5PyAxLe9gMd34Ay2CthOhYqqldc8HrHTpcw/U98Cvpc= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1789194489; c=relaxed/simple; bh=Tgfw+bR1PxAXAQBy+XRLskdLb5gIhfOBvMohuAAe0u0=; h=From:To:Cc:Subject:Date:Message-Id:MIME-Version; b=ijqV8XdEgIQnwX1idAuIM9PD8ONyqwRDxBicc1L2W/BiKN8K4SpW+yhpuVDcwV6kQGCBFCR8dfQbZuNIhsOVUSI7tQxo/fbh6JBHF3kAjKFObZQhzTmZpL+KVadBEkIcRuZfoM9N+bYeBrh2phQ/CZilKKERe7CU2+oNT5wRlYI= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=MsTur5kT; arc=none smtp.client-ip=74.125.225.140 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="MsTur5kT" Received: by mail-wm2-f12.google.com with SMTP id 5b1f17b1804b1-49e620fa473so1285855e9.1 for ; Fri, 11 Sep 2026 23:28:07 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1789194486; x=1789799286; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to:content-type; bh=rsRnOmGwT1DNso6iLHvZBhAmNRKCLZB/9f/AeAbBVZg=; b=MsTur5kTZCftDCgm8CUjh8Nf+KCP78wrj9TvPTfHJlH/0+EW7TVtfa/rgEbOJw5kHb qkimqiIDXt1oPcpTKEkhw4AEUouFRNPhPNbKU4u5e7d4HuTtFn+wiXkF4CrKQW1jbT9t ZcqcbYJU2Dg0RL5u5iX/QAVuUakZHdSLlWHgJih3Txw3kGmOjGkymE3jWXR8NFofnBeO xWmoGbdGiLqP/t03jWSlkf5GHwji4wP77mjysG9vXkt8mySRd1BabRt9p6Ld/vhyD76d SUBiMx/g2XusUIFRewxKfc/Fsc5nqxAN0wJkqFMWb/lLR18H9hqYqaKxndEBGUWFSAYA 125Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1789194486; x=1789799286; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to:content-type; bh=rsRnOmGwT1DNso6iLHvZBhAmNRKCLZB/9f/AeAbBVZg=; b=AXNIZjSgF4ENTCBM2M+NrTLyLEYIBJ3zqh0SA/J7vUHbyIWHglSDLlinhxFVFocWDZ ZccxEZPnlWHl+/ZqEbMMWGBrs9gq5BHv4VyV5iAkAAygCxXwGKaAu7WyPqe27vQHl9Jl k+MtRAMSM0RoScnReDZJq46HNaaPgtdNU8u8fpHoub6aZ7GG6x0AqOf5YEoq20dVdIQO KQNZHUdhA5WqO33tOG6Av0ZYQL2eoFFUb2GlD6/wYhXAdot2G+iI1lpM1olhYGx0Tfc5 ye7BCEFSwY/zWhOoEC3/ocqyYEG4GMYxG+S0UKMKNHSeaBcDyTfwZLofSJfmCU94Q3BH WOsw== X-Forwarded-Encrypted: i=1; AKwUvBw4O0Ge/KrFJaSQptbts5CYl+nlSNqhHO/rSNYKKipjrJ+5hCWL1VugMfPJllaEHnZCoHuLRRaLQWP7j6o=@vger.kernel.org X-Gm-Message-State: AFuF++miB/oFjsPKQFsitxRONubQPIb+wvLMmDGbOVZZdugSlmjOqgLm mBrYsdwN5CuDeFyypUWZ11MiDggSB/7KkwApid1cW6KUeP+d7XVXA795 X-Gm-Gg: AYBFou2D+6CZYuaR453UZQdH0bE9ZBlpSKSnW6ZPMVv3XaQcLL0SdpbW/TPgzq5aV37 sBl9lPi+yoSwT8loYhgDFY3neXuLmqqF04j0TFzRYMKaC9XhNVmnahnrZj/8zXSO57zDTfMrRPB q3w9+2J5sjv8+6UUmnYUQYjPCoCYm8pYCPocoXrbe4NEGNeHGm57HFqIcOpDkioJpUkU06X7gMK B8l7u4xdAym00p3HxI5Vdq+Evr6FTkh/oecyu5ej5jGfo09mBCfDBJDJXvuG5AseFDcrhlI+DG9 djSSJN5nUUcciOnIpYPw9/BfNg8L2zTzHezhXPAun2afLMiSr6Ytb5wLKgrMyO0G+H2smoXLDj2 cbtng3iRa10+NsmfaK3HcHXLIzGxOzvNm08CgNhIYYsCa9zwOacoeYaBXMNRXHTUlCHr0wwj0/L 8gASr+IbznxweubiirCkYC+MuJeRWRqiJ7XLgEFI487m12EPy8otmaRKhxeCBRx/JbXLapfAJb5 PeaToIrScZoAbkfc4uRrZijWqH+5uApFcucHgaHrdNAPb7tZOG0W063sbW7nNk237kM1ShZAOwn e+URpuduyDd5dVa8irjCVuM/TZFWmEt0Htu3rLz1X6Ds5uLV+d8X+vs1myMXYOOYJqeV4bx9aaF aDQ== X-Received: by 2002:a05:600c:4713:b0:49e:6838:c813 with SMTP id 5b1f17b1804b1-49e6cc102ddmr12126115e9.33.1789194485973; Fri, 11 Sep 2026 23:28:05 -0700 (PDT) Received: from localhost.localdomain (dynamic-2a02-3100-b260-f201-9983-e8c4-aff5-7a36.310.pool.telefonica.de. [2a02:3100:b260:f201:9983:e8c4:aff5:7a36]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-49e6af095d7sm45068765e9.0.2026.09.11.23.28.05 (version=TLS1_3 cipher=TLS_CHACHA20_POLY1305_SHA256 bits=256/256); Fri, 11 Sep 2026 23:28:05 -0700 (PDT) From: Karl Mehltretter To: Hannes Reinecke , "James E.J. Bottomley" , "Martin K. Petersen" Cc: Karl Mehltretter , Chris Leech , Robert Love , linux-scsi@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH] scsi: fcoe: Fix the return value in fcoe_interface_create() kernel-doc Date: Sat, 12 Sep 2026 08:28:03 +0200 Message-Id: <20260912062803.42969-1-kmehltretter@gmail.com> X-Mailer: git-send-email 2.39.5 (Apple Git-154) Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" fcoe_interface_create() returns an ERR_PTR() on failure, but its kernel-doc still promises NULL on error. Its error paths switched to error pointers when FCoE module references were added for vports. Update the return documentation to match the implementation. Fixes: 7287fb911409 ("[SCSI] fcoe: Fix module reference count for vports") Assisted-by: LLM Signed-off-by: Karl Mehltretter --- drivers/scsi/fcoe/fcoe.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/scsi/fcoe/fcoe.c b/drivers/scsi/fcoe/fcoe.c index 438ac7c3a9e3fd548a42779c4d753320ec79a854..2c86d8a06e410c99e02f5c7f2ab= 96a908dda199a 100644 --- a/drivers/scsi/fcoe/fcoe.c +++ b/drivers/scsi/fcoe/fcoe.c @@ -375,7 +375,7 @@ static int fcoe_interface_setup(struct fcoe_interface *= fcoe, * @netdev: The net device to create the FCoE interface on * @fip_mode: The mode to use for FIP * - * Returns: pointer to a struct fcoe_interface or NULL on error + * Returns: pointer to a struct fcoe_interface or an ERR_PTR() on error */ static struct fcoe_interface *fcoe_interface_create(struct net_device *net= dev, enum fip_mode fip_mode) --=20 2.39.5 (Apple Git-154)