From nobody Fri Sep 25 13:17:01 2026 Received: from mail-wr2-f12.google.com (mail-wr2-f12.google.com [74.125.225.76]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 034621E8332 for ; Sat, 12 Sep 2026 00:23:02 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=74.125.225.76 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1789172584; cv=none; b=mUAL0ktr/Ol/bxrVhDz7jQ8P9MdY5Q8VtaLu8SdboHO6dnUca+HbQ5YuJD2MKyUJcI6s9eAqjTz8bubc57yzV2exQcuwsBMMD8iiiPeKiARC+FvRa1P0CR9JFSQSbugNvglO+0wZoMCuz8Sq8lpgAXQA4zYs4gEfdurvcNPyXfs= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1789172584; c=relaxed/simple; bh=C/ntNuH7/T4V0mo/sAmWBhHUovXH2mX+woiBShNBDfI=; h=From:To:Cc:Subject:Date:Message-Id:MIME-Version; b=HTVTkrsWKQHSPXr3RXLRYMAqnx7Y/aoMrqnaXFuWcjvFgq8kFD/RsV5kg75eyWUmxirWRBBGVW762tWHZkrNvyeZnsuT6PzR1ys4iNGZcI11MNOJl6ohJc7DCR3wgdocFsRA+sqi6Kv1w8UPKPfzOJd84lUYMZqMwzH1q8H3FJM= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=FWP47adl; arc=none smtp.client-ip=74.125.225.76 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="FWP47adl" Received: by mail-wr2-f12.google.com with SMTP id ffacd0b85a97d-485b1d2874fso96371f8f.0 for ; Fri, 11 Sep 2026 17:23:02 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1789172581; x=1789777381; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to:content-type; bh=a76hBPXYrcoSmtn4Q7RocQBlCM+IbZbkHYVvSI8P1K4=; b=FWP47adlnxicZz+lZg2e0nRmBhvXFIldq7jGMPwERkXLLfcrWZR7WK0LkTY+GjF2jd LTQgYV+RZ282s2sh+c+zv3BNGXnXtxiSH3/KPmDyndBeYB/qXJd/pPYcj98H94mq6tDe UZUySs9tz3Zwko5zqmndwQpmW2SsoxISk5rzx5bXvpk4y1z93uFN9k6xjtUfefiuyQHf 7vfTwcMuClUbJ7PoA80CbyZz6o2VF1Bb67xWlXnRij/TdJbAmAStYt6dwWVVHHc3f08z yDl2fdLR/N8jk9DXLryYDTYjAcQ1JZvQLiEqJAOaNVAdvY8Uhq8fUPECeQ2T3r+Mpopc 0+yQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1789172581; x=1789777381; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to:content-type; bh=a76hBPXYrcoSmtn4Q7RocQBlCM+IbZbkHYVvSI8P1K4=; b=sJRh2CX6IQP6fwltLbo6+JLGeaIokv+H3K7XvsFnmYqcG8xDiHY8ql7UE1QBR1NwGp GAF5w4bOMoNQptCf5+SONpQbCER42c8e7ckVchiPT6K6Hpt8zboQNi7yhCsPgk6Bp9kN RLBztF31/fAXhpd+rgUgtIPIrcbzBt7/i/oO61CRUSFR5+GpTXCKssINndDpaGg3K5vV 3lMOW+LsDBJgG5VURT2HW2uFt4qoIkxiboCEUYr1FpGQECwab28VvLdwlLMS+GjRNsaT NktmCwu8DyTCZrEj4902yxVdt7lU1EXFe1bhgi3g0aIF9qLT1gu3ov5EF7aGRip3ivj0 FdBQ== X-Forwarded-Encrypted: i=1; AKwUvBwv9UfUN7d1onKa9Ad+2AnxrbPeIufYKt5uFm4ZHbeSBZJhpe0pNPpGxZLVj3Phf0vioqRQGdt9hzpKI98=@vger.kernel.org X-Gm-Message-State: AFuF++mJiSkbEW29zY+KMZNBUABy9y/ZDM/YsyeqlIX2z2Nypp1o+/RX pwAkeLX9XW+4LCEQxpNxtCKs0K9K0p5PoVI+2rv4q8IkTJOgDYorOaJQ X-Gm-Gg: AYBFou29QNoslsynlxVZGWpU8PpR64SQ6qw7lSeMkWXR/pIMAMnrnTlxLfE9ukTYk// IhsWx94QFc5Es5/DjU4Nf9LbWWchlza0yfprp6BYSEKp2psP055GJ0tAPsAMmgg80RBP+hJix/Y M5w3M5RVtGVhXeu/3f2Cm197aWev22e9IdXZSUMrWlhqx7CXJDlLJY3x8ap2j8GlRDCilpbUThe QlmjEKGMQpL47af8Mgyjt5d7E3rW1J5M/C7eb+gCu+q+7lNwBCgw+ukiW/Xj+M5HN+C3OVGpwu3 5Kosi0XRN5GcRJ0ySrYrKRPf5QH/iK7HClbLVbTyTahhKogGfbhcsnuL38dEYE/P6dnE1hVNjhc Tuby5hmeFV2iQH+f15USOd2XXEaw7RaidKnTf99zINhmhNb6Lj+ct1U8hDgJnaGELiHmAOwqZ7D ariaHIOmKFR6L1LC7DLD8Mz6TmKVCVYEE8xcdTt4YCSUBJiJ93d0a7jRL9Sz1W0hDPck/MXtDNL N6kbN6KekWtG6tkzu5NtlJ1T/E6f/tLsgATflZBexiqp9J+/ijYsts4mvkinZHOdwPIwOkw7ur5 vl5uPlZOj14W4zHXrZ+Tu0JTMaXsn71KtApV X-Received: by 2002:a05:600c:698d:b0:49e:6865:904e with SMTP id 5b1f17b1804b1-49e6865921amr43495635e9.12.1789172581015; Fri, 11 Sep 2026 17:23:01 -0700 (PDT) Received: from localhost.localdomain (dynamic-095-114-033-154.95.114.pool.telefonica.de. [95.114.33.154]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-49e69f02e0bsm26924275e9.2.2026.09.11.17.22.59 (version=TLS1_3 cipher=TLS_CHACHA20_POLY1305_SHA256 bits=256/256); Fri, 11 Sep 2026 17:23:00 -0700 (PDT) From: Karl Mehltretter To: Even Xu , Xinpeng Sun , Jiri Kosina , Benjamin Tissoires Cc: Karl Mehltretter , Andy Shevchenko , linux-input@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH] HID: intel-thc-hid: intel-quicki2c: Fix the return value in quicki2c_dev_init() kernel-doc Date: Sat, 12 Sep 2026 02:21:43 +0200 Message-Id: <20260912002143.35091-1-kmehltretter@gmail.com> X-Mailer: git-send-email 2.39.5 (Apple Git-154) Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" quicki2c_dev_init() returns an ERR_PTR() on failure, but its kernel-doc says that failure returns NULL. This mismatch was present in the original driver skeleton. Document the error pointer returned by the initialization paths. Fixes: 61bb2714dc3a ("HID: intel-thc-hid: intel-quicki2c: Add THC QuickI2C = driver skeleton") Assisted-by: LLM Signed-off-by: Karl Mehltretter --- drivers/hid/intel-thc-hid/intel-quicki2c/pci-quicki2c.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/hid/intel-thc-hid/intel-quicki2c/pci-quicki2c.c b/driv= ers/hid/intel-thc-hid/intel-quicki2c/pci-quicki2c.c index 0d2ad7bc3648a2f227db2ed27ad9cbe18955bc0f..aa601ef613c91729f4fc90bdc16= 74cb838921421 100644 --- a/drivers/hid/intel-thc-hid/intel-quicki2c/pci-quicki2c.c +++ b/drivers/hid/intel-thc-hid/intel-quicki2c/pci-quicki2c.c @@ -380,7 +380,7 @@ exit: * If success, enable THC hardware interrupt. * * Return: Pointer to the quicki2c_device structure if success - * or NULL on failure. + * or an ERR_PTR() on failure. */ static struct quicki2c_device *quicki2c_dev_init(struct pci_dev *pdev, voi= d __iomem *mem_addr, const struct quicki2c_ddata *ddata) --=20 2.39.5 (Apple Git-154)