From nobody Fri Sep 25 11:56:40 2026 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 41E57357D0E; Sun, 13 Sep 2026 02:38:09 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1789267089; cv=none; b=oChGd2SzRmG1fTDZD3Gzgr45BpNB9ogoZv+JGYuZim67gzv/FcfE5osjxhaAck2gu6h4YYrkfYhciX5/HwB8IydBgiOBf5djwpzi3Kxxql1cwmouWf3CFYo86cj8xGo21HN0dZejprctBWTmsrOELTkC31EQAb8NodRVY4sn/Y4= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1789267089; c=relaxed/simple; bh=XjGowetihGiqAjoV226+UhXwTatGj1IDV2kE0b2OzQw=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=Gk6wZWytZTOHSAx1rsgX0vqLiGyOzHy1svbZCiJefyIdD6hOX5NP096R32LNApkl0sKuepgB9EPJpXNztShLri2Qlcq8Uw7KNDmpyt8/siO3dyHBVjzejidP/pvCS21Gd7u3qwkNWHo4nX+5O54rzT2Tc4fTVBKytfLlIk9CeRk= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=uX65YL0e; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="uX65YL0e" Received: by smtp.kernel.org (Postfix) with ESMTPS id 801FDC2BCFA; Sun, 13 Sep 2026 02:38:08 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1789267088; bh=XjGowetihGiqAjoV226+UhXwTatGj1IDV2kE0b2OzQw=; h=From:Date:Subject:References:In-Reply-To:To:Cc:Reply-To:From; b=uX65YL0ekyHEB42ogPVfoT0kV6G4XFruct3+FGK+IPtfw4K6MNfu2c6NPEWXaP2U/ K+KS64wsFulD7qbCmIitOOl/hViuy5VmNQ8zzHkUQuwYPU2hNjhgabKa7gktGT+dbz KZkHGLfAWgXh6nClwjhsJYOP3M6vKDK/hlYCIE98/7S/IZ2SuZRvFFgNjajmabxVmf UNPhpStDYe1/DEabRQ/OD+TF5yZhwj1DOxgT2HPrp8Su2jUldfElNaNZd5WSNhlzAz 7M1oWULTLOm/Iz6vlqXWYg/ZkDBBJmnpwbBd+wRSoMG6pzEqo1otmAfIeLDVJjbhe0 JBfPf+N+pXgGA== Received: from aws-us-west-2-korg-lkml-1.web.codeaurora.org (localhost.localdomain [127.0.0.1]) by smtp.lore.kernel.org (Postfix) with ESMTP id 6160CC88E53; Sun, 13 Sep 2026 02:38:08 +0000 (UTC) From: Rudraksha Gupta via B4 Relay Date: Sat, 12 Sep 2026 19:38:08 -0700 Subject: [PATCH v7 1/3] dt-bindings: leds: rt8515: Support single-GPIO flash ICs with vin supply Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20260912-expressatt_camera_flash-v7-1-e1fd2edc8d84@gmail.com> References: <20260912-expressatt_camera_flash-v7-0-e1fd2edc8d84@gmail.com> In-Reply-To: <20260912-expressatt_camera_flash-v7-0-e1fd2edc8d84@gmail.com> To: Lee Jones , Pavel Machek , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Linus Walleij , Bjorn Andersson , Konrad Dybcio , Liam Girdwood , Mark Brown Cc: linux-leds@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-msm@vger.kernel.org, phone-devel@vger.kernel.org, Rudraksha Gupta , Conor Dooley X-Mailer: b4 0.16.0 X-Developer-Signature: v=1; a=ed25519-sha256; t=1789267087; l=2722; i=guptarud@gmail.com; s=20240916; h=from:subject:message-id; bh=YAXE9xJLJFi0pOiJKXkn7F8HuxDAWR231QXLgxEZYyU=; b=dYyo6/J38Uy0zHy9FRHkac1Hsd1UY9oWKNAkCOmwTQ+DPtCmzlMYsF7yftKJBmvkculopxrUY bA/Jr3uBwszC3b8BuQPbMsY7QMWF+DlhG4yqrZs4WvJNi8xXSGMDeB/ X-Developer-Key: i=guptarud@gmail.com; a=ed25519; pk=ETrudRugWAtOpr0OhRiheQ1lXM4Kk4KGFnBySlKDi2I= X-Endpoint-Received: by B4 Relay for guptarud@gmail.com/20240916 with auth_id=211 X-Original-From: Rudraksha Gupta Reply-To: guptarud@gmail.com From: Rudraksha Gupta Some flash ICs use the same one-wire pulse-count protocol as the RT8515 but have only a single enable line for both flash and torch modes, plus an optional input voltage supply (e.g. a GPIO-controlled fixed regulator) that gates power to the chip. Make ent-gpios optional and add a vin-supply property to support these variants. Add a oneOf constraint requiring exactly one of ent-gpios or vin-supply. Add a binding example showing the single-GPIO configuration with an input supply. Assisted-by: Claude:claude-opus-4.6 Acked-by: Conor Dooley Reviewed-by: Linus Walleij Signed-off-by: Rudraksha Gupta --- .../devicetree/bindings/leds/richtek,rt8515.yaml | 34 ++++++++++++++++++= +++- 1 file changed, 33 insertions(+), 1 deletion(-) diff --git a/Documentation/devicetree/bindings/leds/richtek,rt8515.yaml b/D= ocumentation/devicetree/bindings/leds/richtek,rt8515.yaml index 0356371a6b01..ab3c5139132c 100644 --- a/Documentation/devicetree/bindings/leds/richtek,rt8515.yaml +++ b/Documentation/devicetree/bindings/leds/richtek,rt8515.yaml @@ -15,6 +15,10 @@ description: | current for each mode is defined in hardware using two resistors RFS and RTS. =20 + Some flash ICs use the same one-wire pulse-count protocol but have + only a single enable line for both flash and torch modes. For these + single-channel variants, only enf-gpios is needed. + properties: compatible: const: richtek,rt8515 @@ -26,6 +30,11 @@ properties: ent-gpios: maxItems: 1 description: A connection to the 'ENT' (enable torch) pin. + Not present on single-channel flash ICs that use only one enable + line for both flash and torch modes. + + vin-supply: + description: Optional input supply for the flash IC. =20 richtek,rfs-ohms: minimum: 7680 @@ -81,10 +90,15 @@ properties: =20 required: - compatible - - ent-gpios - enf-gpios - led =20 +oneOf: + - required: + - ent-gpios + - required: + - vin-supply + additionalProperties: false =20 examples: @@ -108,4 +122,22 @@ examples: }; }; =20 + - | + /* Single-channel flash IC with input supply */ + #include + #include + + led-controller { + compatible =3D "richtek,rt8515"; + enf-gpios =3D <&tlmm 3 GPIO_ACTIVE_HIGH>; + vin-supply =3D <&flash_reg>; + richtek,rfs-ohms =3D <16000>; + + led { + function =3D LED_FUNCTION_FLASH; + color =3D ; + flash-max-timeout-us =3D <250000>; + }; + }; + ... --=20 2.55.0 From nobody Fri Sep 25 11:56:40 2026 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 42E2E376BCC; Sun, 13 Sep 2026 02:38:09 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1789267089; cv=none; b=BBJTifS8Kt6K4JZkk3GjwMcoZlYTHe88meg/OiejM/qdX4du40KoPjLZBrDbeknILSv1oh/uFYB7opeeln94E9miaTDIeHXCQUHAkybB9fddr5HFEXu0mJvmFNTAe9k144saOFIqrDhJWMKL/RQffU50z+4AaOrVZC5/y/YSWws= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1789267089; c=relaxed/simple; bh=1p96QVsI041xiggk+9kJfF92XF3Bp24d0J5zfXI9ZeM=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=SDLRny7ZkuhVylPIO++3SHvXAGFf8M0JjkcWhZMGy/5Fwgi0xCC3yy8jXuThpD+7DdOinJOaPeNXqJoONCr0F9HXePPFLzMF4VyajwvB5eOpTtvmhKOOa3WMZzKvG5G0hV7G8wK4d+Aignqh11dTR96z9C7i+yh0OQ5YiksDtcs= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=MGkpKVjs; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="MGkpKVjs" Received: by smtp.kernel.org (Postfix) with ESMTPS id 953BFC2BCFB; Sun, 13 Sep 2026 02:38:08 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1789267088; bh=1p96QVsI041xiggk+9kJfF92XF3Bp24d0J5zfXI9ZeM=; h=From:Date:Subject:References:In-Reply-To:To:Cc:Reply-To:From; b=MGkpKVjsIBWwt11yYCFoTnpzjJ4i6BEXNwW5TnYfETVtC8xGW+2nWD9o35SB7+xhz K6G8aqSShAy6rYD3gKsYZCM4VeQ9FUEMxHvp4Yv5ED/WFQpSl6iUB/DzYnYOHL9Bq7 c1B9R8gs7XfLTxHnKL0xyWMpo4CRc68nXFx2fJNY1mPyTbqi1ToPLFrWr+CWUT+x/L JZsDM2XaofJahfdaHd9EhSuRTzCQ6OkPj4o1QGln3su/7rpyiyS8OK8obbbJenDSFj qYS83WXud9ZIw8WrbQcpsIoaCDl9RrJ7Stv9O605jcVOKT3ZG1tzwS8HYopmADo+Qu ZiDL2uWnaQuhg== Received: from aws-us-west-2-korg-lkml-1.web.codeaurora.org (localhost.localdomain [127.0.0.1]) by smtp.lore.kernel.org (Postfix) with ESMTP id 74043C88E56; Sun, 13 Sep 2026 02:38:08 +0000 (UTC) From: Rudraksha Gupta via B4 Relay Date: Sat, 12 Sep 2026 19:38:09 -0700 Subject: [PATCH v7 2/3] leds: flash: rt8515: Support single-GPIO flash ICs with vin supply Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20260912-expressatt_camera_flash-v7-2-e1fd2edc8d84@gmail.com> References: <20260912-expressatt_camera_flash-v7-0-e1fd2edc8d84@gmail.com> In-Reply-To: <20260912-expressatt_camera_flash-v7-0-e1fd2edc8d84@gmail.com> To: Lee Jones , Pavel Machek , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Linus Walleij , Bjorn Andersson , Konrad Dybcio , Liam Girdwood , Mark Brown Cc: linux-leds@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-msm@vger.kernel.org, phone-devel@vger.kernel.org, Rudraksha Gupta X-Mailer: b4 0.16.0 X-Developer-Signature: v=1; a=ed25519-sha256; t=1789267087; l=8605; i=guptarud@gmail.com; s=20240916; h=from:subject:message-id; bh=skylHszTLWKkxhvTfuJWw+lsWyDXTn0YaNbK6ScaP3M=; b=LJgoC1eV0Q2KJCIvx9SlazOf4UjuPfh5blxHB7+vcLE43bqgjU3hzRd4JhpX2omRYro4sUeTL +pyO8/D/fpBBcPMzcVwhtzBf6p+Jdj7ISbqefKynxzhhXw9Rt93yTA2 X-Developer-Key: i=guptarud@gmail.com; a=ed25519; pk=ETrudRugWAtOpr0OhRiheQ1lXM4Kk4KGFnBySlKDi2I= X-Endpoint-Received: by B4 Relay for guptarud@gmail.com/20240916 with auth_id=211 X-Original-From: Rudraksha Gupta Reply-To: guptarud@gmail.com From: Rudraksha Gupta Extend the RT8515 driver to support flash ICs that use only a single GPIO for both flash and torch modes (no separate ENT pin), with an optional vin regulator that gates power to the flash IC. Assisted-by: Claude:claude-opus-4.6 Reviewed-by: Linus Walleij Signed-off-by: Rudraksha Gupta --- drivers/leds/flash/leds-rt8515.c | 147 ++++++++++++++++++++++++++++-------= ---- 1 file changed, 107 insertions(+), 40 deletions(-) diff --git a/drivers/leds/flash/leds-rt8515.c b/drivers/leds/flash/leds-rt8= 515.c index 00904cc90ed6..541f61e13f01 100644 --- a/drivers/leds/flash/leds-rt8515.c +++ b/drivers/leds/flash/leds-rt8515.c @@ -30,6 +30,7 @@ #include #include #include +#include =20 #include =20 @@ -43,6 +44,9 @@ #define RT8515_TIMEOUT_US 250000U #define RT8515_MAX_TIMEOUT_US 300000U =20 +#define RT8515_OFF 0 +#define RT8515_ON 1 + struct rt8515 { struct led_classdev_flash fled; struct device *dev; @@ -51,7 +55,7 @@ struct rt8515 { struct regulator *reg; struct gpio_desc *enable_torch; struct gpio_desc *enable_flash; - struct timer_list powerdown_timer; + struct delayed_work powerdown_work; u32 max_timeout; /* Flash max timeout */ int flash_max_intensity; int torch_max_intensity; @@ -62,27 +66,50 @@ static struct rt8515 *to_rt8515(struct led_classdev_fla= sh *fled) return container_of(fled, struct rt8515, fled); } =20 -static void rt8515_gpio_led_off(struct rt8515 *rt) +static int rt8515_gpio_led_off(struct rt8515 *rt) { - gpiod_set_value(rt->enable_flash, 0); - gpiod_set_value(rt->enable_torch, 0); + gpiod_set_value(rt->enable_flash, RT8515_OFF); + gpiod_set_value(rt->enable_torch, RT8515_OFF); + + if (!rt->reg) + return 0; + + return regulator_is_enabled(rt->reg) > 0 ? regulator_disable(rt->reg) : 0; } =20 -static void rt8515_gpio_brightness_commit(struct gpio_desc *gpiod, - int brightness) +static int rt8515_gpio_brightness_commit(struct rt8515 *rt, struct gpio_de= sc *gpiod, int brightness) { - int i; + int ret; + + /* + * Reset the IC to start brightness from zero, + * then re-enable and pulse to the desired level. + */ + ret =3D rt8515_gpio_led_off(rt); + if (ret) + return ret; + + /* IC needs time to reset its brightness counter */ + usleep_range(100, 200); + + if (rt->reg) { + ret =3D regulator_enable(rt->reg); + if (ret) + return ret; + } =20 /* * Toggling a GPIO line with a small delay increases the * brightness one step at a time. */ - for (i =3D 0; i < brightness; i++) { - gpiod_set_value(gpiod, 0); + for (int i =3D 0; i < brightness; i++) { + gpiod_set_value(gpiod, RT8515_OFF); udelay(1); - gpiod_set_value(gpiod, 1); + gpiod_set_value(gpiod, RT8515_ON); udelay(1); } + + return 0; } =20 /* This is setting the torch light level */ @@ -91,23 +118,37 @@ static int rt8515_led_brightness_set(struct led_classd= ev *led, { struct led_classdev_flash *fled =3D lcdev_to_flcdev(led); struct rt8515 *rt =3D to_rt8515(fled); + int ret =3D 0; =20 mutex_lock(&rt->lock); =20 if (brightness =3D=3D LED_OFF) { - /* Off */ - rt8515_gpio_led_off(rt); + ret =3D rt8515_gpio_led_off(rt); + if (ret) + goto out; } else if (brightness < RT8515_TORCH_MAX) { - /* Step it up to movie mode brightness using the flash pin */ - rt8515_gpio_brightness_commit(rt->enable_torch, brightness); + /* + * Step it up to movie mode brightness. + * If there is no separate torch pin, use the flash pin + * for torch as well. + */ + ret =3D rt8515_gpio_brightness_commit(rt, + rt->enable_torch ?: rt->enable_flash, brightness); + if (ret) + goto out; } else { - /* Max torch brightness requested */ - gpiod_set_value(rt->enable_torch, 1); + /* + * Max torch brightness requested. + * If there is no separate torch pin, use the flash pin + * for torch as well. + */ + gpiod_set_value(rt->enable_torch ?: rt->enable_flash, RT8515_ON); } =20 +out: mutex_unlock(&rt->lock); =20 - return 0; + return ret; } =20 static int rt8515_led_flash_strobe_set(struct led_classdev_flash *fled, @@ -116,27 +157,35 @@ static int rt8515_led_flash_strobe_set(struct led_cla= ssdev_flash *fled, struct rt8515 *rt =3D to_rt8515(fled); struct led_flash_setting *timeout =3D &fled->timeout; int brightness =3D rt->flash_max_intensity; + int ret; + + if (!state) { + cancel_delayed_work_sync(&rt->powerdown_work); + mutex_lock(&rt->lock); + ret =3D rt8515_gpio_led_off(rt); + if (!ret) + fled->led_cdev.brightness =3D LED_OFF; + mutex_unlock(&rt->lock); + return ret; + } =20 mutex_lock(&rt->lock); =20 - if (state) { - /* Enable LED flash mode and set brightness */ - rt8515_gpio_brightness_commit(rt->enable_flash, brightness); - /* Set timeout */ - mod_timer(&rt->powerdown_timer, - jiffies + usecs_to_jiffies(timeout->val)); - } else { - timer_delete_sync(&rt->powerdown_timer); - /* Turn the LED off */ - rt8515_gpio_led_off(rt); - } + /* Enable LED flash mode and set brightness */ + ret =3D rt8515_gpio_brightness_commit(rt, rt->enable_flash, brightness); + if (ret) + goto out; + + /* Set timeout */ + schedule_delayed_work(&rt->powerdown_work, usecs_to_jiffies(timeout->val)= ); =20 fled->led_cdev.brightness =3D LED_OFF; /* After this the torch LED will be disabled */ =20 +out: mutex_unlock(&rt->lock); =20 - return 0; + return ret; } =20 static int rt8515_led_flash_strobe_get(struct led_classdev_flash *fled, @@ -144,7 +193,7 @@ static int rt8515_led_flash_strobe_get(struct led_class= dev_flash *fled, { struct rt8515 *rt =3D to_rt8515(fled); =20 - *state =3D timer_pending(&rt->powerdown_timer); + *state =3D delayed_work_pending(&rt->powerdown_work); =20 return 0; } @@ -162,12 +211,17 @@ static const struct led_flash_ops rt8515_flash_ops = =3D { .timeout_set =3D rt8515_led_flash_timeout_set, }; =20 -static void rt8515_powerdown_timer(struct timer_list *t) +static void rt8515_powerdown_work(struct work_struct *work) { - struct rt8515 *rt =3D timer_container_of(rt, t, powerdown_timer); + struct rt8515 *rt =3D container_of(work, struct rt8515, powerdown_work.wo= rk); + int ret; + + mutex_lock(&rt->lock); + ret =3D rt8515_gpio_led_off(rt); + mutex_unlock(&rt->lock); =20 - /* Turn the LED off */ - rt8515_gpio_led_off(rt); + if (ret) + dev_err(rt->dev, "failed to turn off LED (%d)\n", ret); } =20 static void rt8515_init_flash_timeout(struct rt8515 *rt) @@ -297,11 +351,19 @@ static int rt8515_probe(struct platform_device *pdev) return dev_err_probe(dev, PTR_ERR(rt->enable_flash), "cannot get ENF (enable flash) GPIO\n"); =20 - /* ENT - Enable Torch line */ - rt->enable_torch =3D devm_gpiod_get(dev, "ent", GPIOD_OUT_LOW); + /* ENT - Enable Torch line (optional for single-GPIO flash ICs) */ + rt->enable_torch =3D devm_gpiod_get_optional(dev, "ent", GPIOD_OUT_LOW); if (IS_ERR(rt->enable_torch)) return dev_err_probe(dev, PTR_ERR(rt->enable_torch), - "cannot get ENT (enable torch) GPIO\n"); + "Failed to obtain the Enable Torch GPIO\n"); + + rt->reg =3D devm_regulator_get_optional(dev, "vin"); + if (IS_ERR(rt->reg)) { + ret =3D PTR_ERR(rt->reg); + if (ret !=3D -ENODEV) + return dev_err_probe(dev, ret, "Failed to obtain the input supply\n"); + rt->reg =3D NULL; + } =20 child =3D device_get_next_child_node(dev, NULL); if (!child) { @@ -327,12 +389,17 @@ static int rt8515_probe(struct platform_device *pdev) dev_warn(dev, "flash-max-timeout-us property missing\n"); } - timer_setup(&rt->powerdown_timer, rt8515_powerdown_timer, 0); + INIT_DELAYED_WORK(&rt->powerdown_work, rt8515_powerdown_work); rt8515_init_flash_timeout(rt); =20 fled->ops =3D &rt8515_flash_ops; =20 - led->max_brightness =3D rt->torch_max_intensity; + /* + * If there is no separate torch pin, use flash max intensity + * as max brightness instead. + */ + led->max_brightness =3D rt->enable_torch ? + rt->torch_max_intensity : rt->flash_max_intensity; led->brightness_set_blocking =3D rt8515_led_brightness_set; led->flags |=3D LED_CORE_SUSPENDRESUME | LED_DEV_CAP_FLASH; =20 @@ -371,7 +438,7 @@ static void rt8515_remove(struct platform_device *pdev) struct rt8515 *rt =3D platform_get_drvdata(pdev); =20 rt8515_v4l2_flash_release(rt); - timer_delete_sync(&rt->powerdown_timer); + cancel_delayed_work_sync(&rt->powerdown_work); mutex_destroy(&rt->lock); } =20 --=20 2.55.0 From nobody Fri Sep 25 11:56:40 2026 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 43748376BE4; Sun, 13 Sep 2026 02:38:09 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1789267089; cv=none; b=FM2KGHab8biu3T/S1KNmpi+gc2Is/GqIDzcrK+wr1ASXzlxOudJznpWSDa7YrcJZVBXQEO5MKXpofFlbl5C0N52zIN9k7738fRSngS1fXy7lqg7kbG8WPn63QBCSpJShXU4r9/MIROfpaBSPhXUYkp19KKNxdiZ4YkuKxAlGRsU= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1789267089; c=relaxed/simple; bh=zmjDkalhHp+DZoMH9Wa+lSORBlcR37Dk9d3rt5R2DF8=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=DUyMRxMzjwxupAIMDkPtiR0fU4BrMY9h/t64IaLNCupgcZLgWg1OplbhaLjpdi+gMnJS5CK2G0Rbyp+OVpVYVmUvyavJibMIi1GTKOCdZlq0Njd7rW0HvG6LsTPPiMg/suwQhZXivVuy9l4y12brRiAgQFm1N9yaxnu0Q3r1Usg= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=s2d/nqPl; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="s2d/nqPl" Received: by smtp.kernel.org (Postfix) with ESMTPS id A4658C2BCF4; Sun, 13 Sep 2026 02:38:08 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1789267088; bh=zmjDkalhHp+DZoMH9Wa+lSORBlcR37Dk9d3rt5R2DF8=; h=From:Date:Subject:References:In-Reply-To:To:Cc:Reply-To:From; b=s2d/nqPlXk4vrfKpNgo70rae+uayyXcnBloNApk7n/YcmJe3G6F6FPN3Bq8R90dju ym8+AlI2JR0zN997O7vF5mh1DCG+iqn1sAa89wFLt7YwcVry3MECYPq0CLd6tPA1Nm yRklCZGkeHH6HABPJQZPTzgsZJuv3xivncNbHjKkx4KSFKp9fcYnhX+sPnWuJytw6g tmYa48JlQkmfxT7YMnc8mwU13cqiGZjPPjNlX2XDHgeXT1lO6YlG0LcAVGv9iJrdXG 3XL2pQzlmXvr0cInrW2muqtLzycjwZMtpMpQpAgXpMSlA5TtQZzFVLPE35hSf1a2w7 DF1UrxVeJrnmg== Received: from aws-us-west-2-korg-lkml-1.web.codeaurora.org (localhost.localdomain [127.0.0.1]) by smtp.lore.kernel.org (Postfix) with ESMTP id 87793C88E65; Sun, 13 Sep 2026 02:38:08 +0000 (UTC) From: Rudraksha Gupta via B4 Relay Date: Sat, 12 Sep 2026 19:38:10 -0700 Subject: [PATCH v7 3/3] ARM: dts: qcom: msm8960: expressatt: Add camera flash Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20260912-expressatt_camera_flash-v7-3-e1fd2edc8d84@gmail.com> References: <20260912-expressatt_camera_flash-v7-0-e1fd2edc8d84@gmail.com> In-Reply-To: <20260912-expressatt_camera_flash-v7-0-e1fd2edc8d84@gmail.com> To: Lee Jones , Pavel Machek , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Linus Walleij , Bjorn Andersson , Konrad Dybcio , Liam Girdwood , Mark Brown Cc: linux-leds@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-msm@vger.kernel.org, phone-devel@vger.kernel.org, Rudraksha Gupta , David Heidelberg , Konrad Dybcio X-Mailer: b4 0.16.0 X-Developer-Signature: v=1; a=ed25519-sha256; t=1789267087; l=2821; i=guptarud@gmail.com; s=20240916; h=from:subject:message-id; bh=+XXskm3P7Bxm9qp2AXPxEkCdFfEV4HAGzaJ1hbiZwr0=; b=106LwAaIjdtn/azCBcKQZ93VhbbPAjBtNjvMY43Ki+Pg4aYO6uveCYGx2cnojBLTQk8Ju5gC/ /4uWaSA1WDfCpCIntO0JIya2cuyFpw+ze6rEA/RRfFBnDQkhgZXpHXQ X-Developer-Key: i=guptarud@gmail.com; a=ed25519; pk=ETrudRugWAtOpr0OhRiheQ1lXM4Kk4KGFnBySlKDi2I= X-Endpoint-Received: by B4 Relay for guptarud@gmail.com/20240916 with auth_id=211 X-Original-From: Rudraksha Gupta Reply-To: guptarud@gmail.com From: Rudraksha Gupta Add camera flash support for the Samsung Galaxy Express (expressatt). Downstream references: Link: https://github.com/LineageOS/android_kernel_samsung_d2/blob/stable/cm= -12.0-YNG4N/drivers/leds/Makefile#L51 Link: https://github.com/LineageOS/android_kernel_samsung_d2/blob/stable/cm= -12.0-YNG4N/arch/arm/mach-msm/board-apexq-camera.c#L591 Assisted-by: Claude:claude-opus-4.6 Reviewed-by: David Heidelberg Reviewed-by: Konrad Dybcio Signed-off-by: Rudraksha Gupta --- .../dts/qcom/qcom-msm8960-samsung-expressatt.dts | 44 ++++++++++++++++++= ++++ 1 file changed, 44 insertions(+) diff --git a/arch/arm/boot/dts/qcom/qcom-msm8960-samsung-expressatt.dts b/a= rch/arm/boot/dts/qcom/qcom-msm8960-samsung-expressatt.dts index 5a3d88e31cf5..b7218ee1349f 100644 --- a/arch/arm/boot/dts/qcom/qcom-msm8960-samsung-expressatt.dts +++ b/arch/arm/boot/dts/qcom/qcom-msm8960-samsung-expressatt.dts @@ -1,11 +1,13 @@ // SPDX-License-Identifier: GPL-2.0 #include +#include #include =20 #include "qcom-msm8960.dtsi" #include "pm8921.dtsi" #include #include +#include #include =20 / { @@ -61,6 +63,32 @@ touchkey_enable: touchkey-enable { regulator-boot-on; }; =20 + vreg_flash: regulator-flash { + compatible =3D "regulator-fixed"; + regulator-name =3D "VREG_FLASH_3P3"; + regulator-min-microvolt =3D <3300000>; + regulator-max-microvolt =3D <3300000>; + gpio =3D <&pm8921_mpps 4 GPIO_ACTIVE_HIGH>; + enable-active-high; + pinctrl-0 =3D <&flash_led_unlock>; + pinctrl-names =3D "default"; + }; + + led-controller { + compatible =3D "richtek,rt8515"; + enf-gpios =3D <&tlmm 3 GPIO_ACTIVE_HIGH>; + vin-supply =3D <&vreg_flash>; + richtek,rfs-ohms =3D <16000>; + pinctrl-0 =3D <&cam_flash_en>; + pinctrl-names =3D "default"; + + led { + function =3D LED_FUNCTION_FLASH; + color =3D ; + flash-max-timeout-us =3D <250000>; + }; + }; + i2c-gpio-touchkey { compatible =3D "i2c-gpio"; #address-cells =3D <1>; @@ -171,6 +199,13 @@ touchscreen@4a { }; =20 &tlmm { + cam_flash_en: cam-flash-en-state { + pins =3D "gpio3"; + function =3D "gpio"; + drive-strength =3D <16>; + bias-pull-down; + }; + spi1_default: spi1-default-state { mosi-pins { pins =3D "gpio6"; @@ -571,3 +606,12 @@ magnetometer@2e { /* TODO: Figure out Mount Matrix */ }; }; + +&pm8921_mpps { + flash_led_unlock: flash-led-unlock-state { + pins =3D "mpp4"; + function =3D "digital"; + output-low; + power-source =3D ; + }; +}; --=20 2.55.0