From nobody Fri Sep 25 13:54:44 2026 Received: from DM1PR04CU001.outbound.protection.outlook.com (mail-centralusazon11010024.outbound.protection.outlook.com [52.101.61.24]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id DA272415F17; Fri, 11 Sep 2026 17:04:48 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=fail smtp.client-ip=52.101.61.24 ARC-Seal: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1789146291; cv=fail; b=tWmDmJTMHA26O6ULagR3DkK7SrpL7hHPoGZ03GZIv0vw5OZ0Ov6vAzEBuG4qMNhbPiL6xmGS/i4/fB1kYghjAJdN/183ObbzzZrVXC47MfC4djwN/UiVLN7dZPPx4EemOeilMlcBFKcP5MF/2BnsblOuyspVwB1znLbLbEG/ePs= ARC-Message-Signature: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1789146291; c=relaxed/simple; bh=KlTu/UqXHHro6lIeWxFzXf04Q/CalY775DOp58oxLtk=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: Content-Type:MIME-Version; b=oy2zs2a/SHOLCOld8JqNdy5TJlqEBp3TxBj1mwpE0rK1BR+FTiCDtvfLPApt9bL/V2gNzMjIAaIllQwyW2L/TUgPL7IbFfDZjEAymTG6TxvpdcfvgXzJnDWs8YGH6x6cwx7CvXASTsZSJ35N5jXzZfYCSNZdFBpnN2G7YyB49zw= ARC-Authentication-Results: i=2; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=nvidia.com; spf=fail smtp.mailfrom=nvidia.com; dkim=pass (2048-bit key) header.d=Nvidia.com header.i=@Nvidia.com header.b=sJ19yhcm; arc=fail smtp.client-ip=52.101.61.24 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=nvidia.com Authentication-Results: smtp.subspace.kernel.org; spf=fail smtp.mailfrom=nvidia.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=Nvidia.com header.i=@Nvidia.com header.b="sJ19yhcm" ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=DpabSjEwwjiTjKTpoS2ZhGdx38r4mLoLAGeBNhu7JEL/pBM4nmHxeh1B/eqxWV0D/WXB799hvsaTQ0Dmo/Xcjuo1jbwgMCNqhXzHRLmCB+2Sr6hlI1Dgzwqc3o7K4yf1V/Vx4isqjGWhKQJ/PlrpdSQbsZpDYN3Dq2l4TEp+PioWyE4HEAi0tLiDSlc5uRqrrAYI6rlgVrqy18wUMgT55vpEEn9Ow1MJ2vuBxhO1NIVF6zQi6s9Ywpbjd7RUdidVMboNbHNgAmptUJFb1gnshmztEO3pw/kAJ8Kk8VkNY2UeHUkBiZLunwytTFGkPDPVZUNHoZ4hsE64Spe6L3f8lQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=vqeG5HuMsAMpMKKRnHAelWMD6AvkY0hokZ0mTlcCgjY=; b=n7VJV1aWOVps/WnD7OSxEQD39TgsDB7EznOnU/yASwr0og3Ba6G6PN9xbag84/JuGMPFaPzhlQz2WsoM6+qh+2BXsrNK4BEXKtlozH4wSbinNu12XMvoOSD2lsyz+buKpJiCcQFvnFusbREaihYCTUSEt0Srana3t61F6nRd8kwphXD9uO5uK5wiHN54viNleb3B/jxhOIYdZEHuwE7LrL1Yy2Q5KYmpaP3aosXG2wJexcdWL2IOObbExe1n2kudEyFP+WoWOYsE/YXNqgawF66hoADcZCQ4EvDDnx2surhb+h32W9GChQphvWCVjj08PV9TWpSfIS97UZ8I+nKWBg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=nvidia.com; dmarc=pass action=none header.from=nvidia.com; dkim=pass header.d=nvidia.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Nvidia.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=vqeG5HuMsAMpMKKRnHAelWMD6AvkY0hokZ0mTlcCgjY=; b=sJ19yhcmSqk5mVjp+DAbFTWAkPATygqGFvWwzNMdTCpVdoc5TYYN8y97P8k47oUFTIUUQx8+Q2jW/khzYQdX/aHgEU5yJi+i583IBOPiAESpdv2lWDSy9rxSZG4HEMeqXW9izLdG5lTvETCRr97iT1PMBjXyzctbSwL0imx4HQi+H4APxPisOTkcSgWX975HYjmKTPXHOXnL69+KbSdptgfrC70KQ4YEuIY1ghEOe5FDzuydH4YoLC9U3oBnvjtHCK0R+fsmLaE48LpavDCvVm3pBS1KT/fRelWoE+3wCLzMNHy9ZKKYxyK5aN522FQySJtIdSVTiyOOt/4kHx2ZGg== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=nvidia.com; Received: from LV3PR12MB9411.namprd12.prod.outlook.com (2603:10b6:408:215::20) by SA1PR12MB8723.namprd12.prod.outlook.com (2603:10b6:806:385::12) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.21.406.9; Fri, 11 Sep 2026 17:04:41 +0000 Received: from LV3PR12MB9411.namprd12.prod.outlook.com ([fe80::98b7:86de:b69:2a15]) by LV3PR12MB9411.namprd12.prod.outlook.com ([fe80::98b7:86de:b69:2a15%6]) with mapi id 15.21.0406.007; Fri, 11 Sep 2026 17:04:41 +0000 From: Alex Williamson To: Alex Williamson , kvm Cc: Alex Williamson , linux-kernel , Jason Gunthorpe , Kevin Tian , Yi Liu , David Matlack , Jason Gunthorpe Subject: [PATCH v2 1/4] vfio: Reject a second cdev open before mutating shared device state Date: Fri, 11 Sep 2026 11:04:24 -0600 Message-ID: <20260911170429.1642480-2-alex.williamson@nvidia.com> X-Mailer: git-send-email 2.53.0 In-Reply-To: <20260911170429.1642480-1-alex.williamson@nvidia.com> References: <20260911170429.1642480-1-alex.williamson@nvidia.com> Content-Transfer-Encoding: quoted-printable X-ClientProxiedBy: CH2PR16CA0026.namprd16.prod.outlook.com (2603:10b6:610:50::36) To LV3PR12MB9411.namprd12.prod.outlook.com (2603:10b6:408:215::20) Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: LV3PR12MB9411:EE_|SA1PR12MB8723:EE_ X-MS-Office365-Filtering-Correlation-Id: d6e125f5-cf38-4169-a8b1-08df1026c534 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|23010399003|366016|376014|1800799024|22082099003|18002099003|11063799006|56012099006|10067099003; X-Microsoft-Antispam-Message-Info: 9+ixrzU6Pi2dApwQIklLqpsREY57dVoFpSk7nhKxv9DUTnirJPHCm/j2oaC57gvZeboEIlqnkwYRjZYp83AHlOFpew88e1kvwaWZ6nj6yQtXeJKpYS5bH/WOjBevpLLZDIH9Yj2PaH0J8Rp9EeC5KJOdIDEy1mceTbv+ISvpceBV8uyHUrPIZ6O6CAgKKFVN7VCAT89xLgRRgOmqjHGiuA8ke48J1hZvoIYUyNa1Kh087qwm2M60rJbsYavV7nKhCfhXqm/I7QDVFIWjjBLqFylNGtdUxXGhb83lBC92B1bNjruqSXXXMp1nmfTLseC4uWP5NvWnz1+mvP8tIrIGUDzEsQVLOktsXMkI4caC5ray292a57y5/K1Vbgkh/3kcatAeLFZLXDOTFLd05vj9lRfSgwrl59epCuB9ZGFoa4Qjyuk8G3u97ZKh93E35tNpEpSY+B/zYGTPam64gUKnPj5SWlKPYR/92belQd1V/vQmNkJ5RLvI1DSJsIb6fTOSaUp9nnnuHz6n58Znp3cJfJaB/X7vLpli1jD2didIPknCOHneCiTjRaBtdoxVuc5FKIoyXZ04dPj84aTstdsaWCEUb6OBenrQ+8juIMr+3Xwf+1bI7iYe90HQXm1aSNGwAOBwv/mEL9Q4p1TvJYGW9ONb8YiXXo0W7VSSe9xL4Qo= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:LV3PR12MB9411.namprd12.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230040)(23010399003)(366016)(376014)(1800799024)(22082099003)(18002099003)(11063799006)(56012099006)(10067099003);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?7k8qLkd4nOrcIMWydKBEqYcvKgjRrG56G0S8O47LPN0RvmZAD+OLRmdKfOJc?= =?us-ascii?Q?ByX/hr1CSvUZVl7imf+nyxXSLtyMzizyIQCkBg2cMLnm5Cl4qUepbi5doOih?= =?us-ascii?Q?vRqss8qVYDUnxXFWhrWEZkeBD8JWcE8O52Dc2MK4bYmvkPaSHlWkKCcpp+98?= =?us-ascii?Q?4QVDe8HovtOO9jZRc7RdaSWiNQp+X5mXF5miLF30IvXjOpODZQLwoifAcgpn?= =?us-ascii?Q?EYY/kSpprai82ETThq+IUp7OeTm4BbVu7zxt9v122QnLEuFIRGuWfww3soil?= =?us-ascii?Q?f067w+q97JgmXo5kta5CgRRKxgjuWYwvc4Iq9hHQaoi/qDsnhV6El8ae4ZwB?= =?us-ascii?Q?bLabL74t2iiDoHWRfEAf+WwJE8CllnzbYNsf1eRg6xbh4WEJg0kSyGDJ1CBG?= =?us-ascii?Q?W7UTlfH69YVUF0fvWTrr9H8lXlVgwlsG3iv6jL8YzJciSHWEKkohEz7th4Fd?= =?us-ascii?Q?FbJP9092HACTnZY2kqM1pRdA9DVe/6dfxyACAoNUxxOIZYLkrEoCU52NyCkW?= =?us-ascii?Q?OTtak6c35dnAn+ACalCcOGuBNvv4/bhd4AIKaZsCKq/YBvMSZl3bik/2vPOx?= =?us-ascii?Q?4ju/g8+5DXX/oRaGDNI8pwqi34MXMMG6UqraBUyTFg99VV399lT7Y257l5nY?= =?us-ascii?Q?8rAvMHLfOohhO1lkLHDUV+b69kHwvkcSwmjwb+ssg9BQbOhyqLxyk1Yt9iI1?= =?us-ascii?Q?KQTYX37VUh9TKU6of0ftP02YrYZvCmBsKgc8UGr+5tyBZajyBBAx3Jw+J5UR?= =?us-ascii?Q?jpFAonm2kbjsakYpZXqTSwITAxodItxwxrfnsKI9TgZqgPh9DkKoQFmcJvnm?= =?us-ascii?Q?hRfQLwC19Fo4nYmvK36POPzTm5bPzb3uZgdYO3r2O42bG11ewimc6wJl8EbL?= =?us-ascii?Q?0bO8PVFtReyolYuwyViX/Q3JSpGrJ2MpDnGSn55B0zm/EH2/LM4xQW0xgg6s?= =?us-ascii?Q?GeHDm4iYxU9/anzFQWuU4XuHVPLcfLHXDVQY0lETnmpgNEKeAODnujNSYuKq?= =?us-ascii?Q?dZx+7bJkUbn6WvqQTiJNe+lNFHyvQOaBIFxAYh7qbhEEd/Q4PVm5i0R7HiBL?= =?us-ascii?Q?Gn2rCbVRBkWHNmJ3lkmwjIyTZe/2QcvDbaKDIHbC/IIuCuth8Z2FbVMRkOKN?= =?us-ascii?Q?/8HToItWi3e4f1ZCSS/meiITWBCpbdsd0QffP6EmaUZpxUcVRzWsMwn8Yg8V?= =?us-ascii?Q?o+s2sgzDAU5xqStXYyiJfXG5L8QHPC7vly53/MWG+TogT2VX//7fcYUZMRYq?= =?us-ascii?Q?JkfkRizv60Xf3DTAsT1NFpCYHeTuYf9S2TuwvkNqc7skE6GUOezFavqSfy1n?= =?us-ascii?Q?YE9gGhhNBhfEHiqIrm+Muutd7JYBSLgafey6YgiHNxkEKB5WMGEUe2A97JXi?= =?us-ascii?Q?TX8YUKCxN0S72VgLsYGIHx4tCvJ04cNk0NjyGvAo9+w72uKW+x7I/0Wi2yUU?= =?us-ascii?Q?AG/fHPokR3e0kRlWxIrgR3HQU2aCxLkGvKyxH3/ej0L4ACcDEY+QoYFfum1O?= =?us-ascii?Q?JowYwty3oXN6b0dSooPQflbfov9J4cJjvA2+RUBXMBt/Saxj/Ucml7i2DwP0?= =?us-ascii?Q?cI6LopxIAW1qiD6Y1d04CAP5LUBVSDi3biBk+iGZHHneEglgREIj8ufqzyLO?= =?us-ascii?Q?Qgw0yfYf37tBhgb73q+UBzCJcmvNsvLqP8JB53ItqYqBK3Qt0IRtxPSapy6N?= =?us-ascii?Q?cBCZQhlfzbXdeMr+RwFeG8jhjIyxS80Q0x5zw3LeY+XT1T7yLQehRWWVzcls?= =?us-ascii?Q?eG6o2ciCRA=3D=3D?= X-OriginatorOrg: Nvidia.com X-MS-Exchange-CrossTenant-Network-Message-Id: d6e125f5-cf38-4169-a8b1-08df1026c534 X-MS-Exchange-CrossTenant-AuthSource: LV3PR12MB9411.namprd12.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 11 Sep 2026 17:04:41.5336 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 43083d15-7273-40c1-b7db-39efd9ccc17a X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: qSSH/30aMscy+CJjoZTUpeujNvRh4wIyHowG1Hh6vCRaJjK0XGC2muZnmFq8Gi7aepkF6oSlUqoqljkbeL02tw== X-MS-Exchange-Transport-CrossTenantHeadersStamped: SA1PR12MB8723 Content-Type: text/plain; charset="utf-8" The cdev single-open check lives in vfio_df_open(), which runs at the end of the bind ioctl, after vfio_df_ioctl_bind_iommufd() has already updated state shared across all opens: vfio_df_check_token() can set the PF vf_token and vfio_df_get_kvm_safe() records the caller's KVM pointer in device->kvm and takes a reference. A second cdev bind of an already-open device runs both, only to be rejected in vfio_df_open(). The error path clears device->kvm and drops the reference, tearing down the current opener's KVM association and potentially resulting in an unbalanced reference on close or premature release, while the vf_token remains clobbered. Move the single-open check into vfio_df_ioctl_bind_iommufd() ahead of both mutations, so a bind that cannot complete leaves the current opener's state untouched. df->group is NULL on this path, so a non-zero open_count is exactly what vfio_df_open() rejected. The test in vfio_df_open() becomes redundant and is removed. Return -EBUSY rather than -EINVAL here. The arguments are not invalid, the device is in use, which could be a transient condition due to a delayed fput if the prior user is terminated. This provides compatibility with the group path, where a group open returns -EBUSY, and users may choose bounded polling to detect such a transient condition. Fixes: 839e692fa4eb ("vfio: Make vfio_df_open() single open for device cdev= path") Fixes: 5fcc26969a16 ("vfio: Add VFIO_DEVICE_BIND_IOMMUFD") Fixes: 86624ba3b522 ("vfio/pci: Do vf_token checks for VFIO_DEVICE_BIND_IOM= MUFD") Assisted-by: LLM Reviewed-by: Jason Gunthorpe Signed-off-by: Alex Williamson Reviewed-by: Kevin Tian --- drivers/vfio/device_cdev.c | 12 ++++++++++++ drivers/vfio/vfio_main.c | 7 ------- 2 files changed, 12 insertions(+), 7 deletions(-) diff --git a/drivers/vfio/device_cdev.c b/drivers/vfio/device_cdev.c index 1d9515c967b0..30362936c7b5 100644 --- a/drivers/vfio/device_cdev.c +++ b/drivers/vfio/device_cdev.c @@ -130,6 +130,18 @@ long vfio_df_ioctl_bind_iommufd(struct vfio_device_fil= e *df, goto out_unlock; } =20 + /* + * The cdev path allows only a single open. Reject a second open here, + * before the VF token and device->kvm updates below would clobber the + * current opener's state on a bind that cannot complete. Return -EBUSY + * rather than -EINVAL since a delayed release of the prior opener can + * make this transient. + */ + if (device->open_count) { + ret =3D -EBUSY; + goto out_unlock; + } + ret =3D vfio_df_check_token(device, &bind); if (ret) goto out_unlock; diff --git a/drivers/vfio/vfio_main.c b/drivers/vfio/vfio_main.c index 423ead48aafe..cb3deb5a4857 100644 --- a/drivers/vfio/vfio_main.c +++ b/drivers/vfio/vfio_main.c @@ -603,13 +603,6 @@ int vfio_df_open(struct vfio_device_file *df) =20 lockdep_assert_held(&device->dev_set->lock); =20 - /* - * Only the group path allows the device to be opened multiple - * times. The device cdev path doesn't have a secure way for it. - */ - if (device->open_count !=3D 0 && !df->group) - return -EINVAL; - device->open_count++; if (device->open_count =3D=3D 1) { ret =3D vfio_df_device_first_open(df); --=20 2.53.0 From nobody Fri Sep 25 13:54:44 2026 Received: from CH4PR04CU002.outbound.protection.outlook.com (mail-northcentralusazon11013004.outbound.protection.outlook.com [40.107.201.4]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 0AA043A8384; Fri, 11 Sep 2026 17:04:52 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=fail smtp.client-ip=40.107.201.4 ARC-Seal: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1789146293; cv=fail; b=MW4mi49FMQBBxeMauNLC2gusR1pN1irfw49Tm2FYvsQcLL+Sb9o6YYkMlo3JxH+kTN4OThpo1zFV59pr8px/8CuD5q1QeuArycPxBp+9eLPy/xOZua0l1yvV41DO9MfG4GsfBtC+XnI2PNWCdypqlW1hyRbe3RZ6j6IvtyfZEb0= ARC-Message-Signature: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1789146293; c=relaxed/simple; bh=hQ5j4HxCSpOnb4hynrIOTlk4ifBtW0XBWCRK99T+zaw=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: Content-Type:MIME-Version; b=F91+8DE3bHB8ihy0EYxapf7Dy+oTWsMbyJgw3b6OQDrA3yLlaJmUNhHsvuBBFCIYri1dMxyv2OB1q0XX/pNBLnGnhsIWOKMevkVdb3vDmYh6NQV9uTJUgxf6JPzQxeFD62+9LTplkl8eFH2orPDL27ocwL3erIXYqFfc5xp/dTY= ARC-Authentication-Results: i=2; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=nvidia.com; spf=fail smtp.mailfrom=nvidia.com; dkim=pass (2048-bit key) header.d=Nvidia.com header.i=@Nvidia.com header.b=QrQ57Unc; arc=fail smtp.client-ip=40.107.201.4 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=nvidia.com Authentication-Results: smtp.subspace.kernel.org; spf=fail smtp.mailfrom=nvidia.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=Nvidia.com header.i=@Nvidia.com header.b="QrQ57Unc" ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=TboffqbYv4QQK2/KDWLry7v/fQuSOpQqbbdxmdE/C39nZilFWBuppj8bwLxEM6WOzgo5aN+3EQsKUwPiKCBkfnc6nlFQrtjZ0Ocy7mFoHyuiv5WwjYacz130OR3QaFmgv8yJBritMeuoYYGuvHD6GuZcJ8x7dsGy5IuqziSlG+RtUOl+gPVSREJlBWG/nyxSdkzy9mjxL4wKlKov9NfaMZptUoLwKx1K4iDnS0tnQSbey+Puvd3lNmYiHDLGvpPhFEntQlfnIPe/ZKBTsv24UGwfOIaK2wvjBey7+/8SqFJMmUF44a0KEg0gMjcxlCL9PeK2B9JzfTgsz17DzURTEw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=uKnloLd2iA0rVp3xdsFkHbbe8p6D9CXvh+k63Q6ysU0=; b=wRVwk6iSts6+gHcHPtNgY5VTBOz6nl9N2F4M5g2nhNtbumFF1FBAQQPkk3iYAwrDHod3hpEzPDuefH/HrBeX3kRaI6V8s3dfufmtnAk3pk0C37dlCis+Eh2aNsqjKlMFKdfEY5Sda6ur5yDAR0rcLm2NKUfK0Ts9f6RkSPHinjqcM+EJD1dyHhl/jMCsPbrQk/Xkf6dDQUFBsTAbdOwtIAjQIdCQUTl2fbizsvToSHvC9ASbdgxE7EbwQfX/e/m9BOKkzI6OGm9cOe7+k8gNbOnNYp/j2AkDmjGz+Pl2C0RdanYaZJ05LqyMSYNfBaLMd3OIWbFxTFSnh3Wh3KDwJQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=nvidia.com; dmarc=pass action=none header.from=nvidia.com; dkim=pass header.d=nvidia.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Nvidia.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=uKnloLd2iA0rVp3xdsFkHbbe8p6D9CXvh+k63Q6ysU0=; b=QrQ57UncGTaZR9+0w6kX5Pcx8qKxgvp3dCegJ2M/mzVotU1zASSr5qd9XQV8clB2+/FHO+TW7/rV6jtul00FV/6T+n6gyFniFztApoLWc8KjhRq+7VriPQaMdkP0Z3FOkRH7PSmtXKcjr1kdapOeTN6n40jNDGl/xXuNIwdwjarvz7QmPO/FGYTjpa05IMlynWPXYwzDgrKH2zRpkJWvI2DUEEk3j3iOiXBvSceStjuM6K2LgxlJec2IY+z+O3ElEtsPcRzAtvm26KDewHB6BzvSYh9GBCiLqRzDevNnAM+KZnyZxTVjpgeg5TJEoY6TZ+TeLMf4y8RjEgbreXIouQ== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=nvidia.com; Received: from LV3PR12MB9411.namprd12.prod.outlook.com (2603:10b6:408:215::20) by CH3PR12MB9343.namprd12.prod.outlook.com (2603:10b6:610:1c0::10) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.21.406.9; Fri, 11 Sep 2026 17:04:43 +0000 Received: from LV3PR12MB9411.namprd12.prod.outlook.com ([fe80::98b7:86de:b69:2a15]) by LV3PR12MB9411.namprd12.prod.outlook.com ([fe80::98b7:86de:b69:2a15%6]) with mapi id 15.21.0406.007; Fri, 11 Sep 2026 17:04:43 +0000 From: Alex Williamson To: Alex Williamson , kvm Cc: Alex Williamson , linux-kernel , Jason Gunthorpe , Kevin Tian , Yi Liu , David Matlack Subject: [PATCH v2 2/4] vfio: selftests: Verify a failed second open preserves the vf_token Date: Fri, 11 Sep 2026 11:04:25 -0600 Message-ID: <20260911170429.1642480-3-alex.williamson@nvidia.com> X-Mailer: git-send-email 2.53.0 In-Reply-To: <20260911170429.1642480-1-alex.williamson@nvidia.com> References: <20260911170429.1642480-1-alex.williamson@nvidia.com> Content-Transfer-Encoding: quoted-printable X-ClientProxiedBy: CH2PR16CA0026.namprd16.prod.outlook.com (2603:10b6:610:50::36) To LV3PR12MB9411.namprd12.prod.outlook.com (2603:10b6:408:215::20) Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: LV3PR12MB9411:EE_|CH3PR12MB9343:EE_ X-MS-Office365-Filtering-Correlation-Id: 748daf69-c9f8-46d9-ffe1-08df1026c60c X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|1800799024|366016|376014|23010399003|11063799006|56012099006|3023799007|10067099003|6133799003|22082099003|18002099003; X-Microsoft-Antispam-Message-Info: HsGvfE413w9IbJuT/fXF5A75st6FinO2sDMEAFHzWzsAVVrvIlpmixiMK3/Ww0L/qymNoKcLJPON8Hxpr9+7oa/UKBHeZLtM02Xq9LrViBeyRCFw0gZSt9RzaHaK5Lllsyu9setRW5sHdwM5dto3wLMD68r0kiFXMCVvtr/007Q++65yW+BuzfUtsp4xRlgFIBpQSVe7W4CInbDd0DP7YogQ0P4BDY8Cpe+phIuE+b8MUnDNfzcmSJP9YgJsQpjdIrAcIWV3BzVl1JrZcd1RT+/FcvKmXZVmwEn+2jgmW5ynBnRmyuv/tDWnFdNDNxwiJuUGX8duj4e7Te4BbnYxdnAIiTWoGdItRQtLMnlVTV9rWXNp7WbsATESiMruZU4h2E6zNs7fhf8OMGGv0F7w3RqvhQHoWHKahuh1zJJ8tCJvPNt7RRVOf4AoNAUiks1PuqTund6/4m5sOctOT9udJluqazufcixAUaAntw+XEtRoRh4I7NBkVoQINzWhZBMbLhp8Ag/nuBLvyJV6cBJ4JmHwZAnCe0LlVKCoBANKPLewZNitk6CoN4hheKaBkM1/p86t10II0YBb5VTnr5VeHx3TFaI3StZCgh2LMpfFk04+SCKc5+WnSJGmFeFjh/vYy3tgDN1MX9dikosXvfoFf4U/RAGzhZxQC90ElycbICc= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:LV3PR12MB9411.namprd12.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230040)(1800799024)(366016)(376014)(23010399003)(11063799006)(56012099006)(3023799007)(10067099003)(6133799003)(22082099003)(18002099003);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?Ot9dxieR0/gXts3TqVN6DX8ipUqOZ61OmSx9+A5r6VdEWYiPzcOftVdFHFFT?= =?us-ascii?Q?IiwbzY8Qs0RkeXAdd8lFbxkhU5u4jIsAvzK8iHu+2TZWEPCrh5MfcldpZt6z?= =?us-ascii?Q?j/2TAhSTf5aV5q1T7ZAg+0ru+AZm97hxvVxHebX2kad4SyCtiLHXFah2wdRP?= =?us-ascii?Q?5HX8VNK2PQo7gGFVIVRQWJ4fJlv8KHeaLZB2y7LYZGLCelPQKsvkklBB5djv?= =?us-ascii?Q?vcIZMaftQ+r4LhFqMtOaonO440SSsmNCJHqU5IuSBE3wk7OOI08gRVUN7Hx2?= =?us-ascii?Q?NRyluHH9cKiPVxO15xyd6c9uxqRRxega1xHOtPBI/283lkZ2KtOA6i0zAYOJ?= =?us-ascii?Q?AgQnO98wwtWB/1INu3YKYUIaIs8IYWo7Lk6ILPKCv6/tYjYAeTCub7YrZdS2?= =?us-ascii?Q?+RUlsqQdrcPE5xXr2FIn0Wtz2eR2RMGvPfUdxK4g+bK6Du9NRiKRzjx8QDq9?= =?us-ascii?Q?s2KeyuHUdtdN/wvJynGZXQ9yHX71dGq4ay0E8dx6gYcE5FX625nkWR876nQx?= =?us-ascii?Q?US1P95jhM0X1qBfWjKpQ77UUsPXcXcks8Z11zroWjnIGtDpABD/dT3Bqm03t?= =?us-ascii?Q?ozVeLl2HA7cQgZjTYJCvd5X8RDhbNfj71gzicPCfS2ZQoBVTYwUF3FBvkr2p?= =?us-ascii?Q?Shk8XiKDTGP2psUJtJj8lq9Deu8Od795IBLM+OQSPN8e/1J/m87SJ5+QrJph?= =?us-ascii?Q?MBh2XDHTdB9ZH9c4RD0u/x/DIEqp8INJQErugur1OqB7jsSlkADroz0t4atv?= =?us-ascii?Q?X9A+FZ0fRVhxWGfawd3cRDYgcwbZ+TvFo/hjva768AZgkb84H6ds4SCPRUEx?= =?us-ascii?Q?27f2CstjxIQRzLYiw1Fs0ybqOPOae2asjhqLxhx7fl06rm+/NpidhdJxsGwE?= =?us-ascii?Q?XrVOXQdN8ZzyN4/ApSyrVH5Hd9Mc4PNMPj7BIsSPPFOCDEHDZ73YJxso6OT7?= =?us-ascii?Q?0yLTA2wb2YuaDFlzblgNzOB8MwvE3eUQiC5ZHTQkgqTCyJQb5DVXJsSwFvB6?= =?us-ascii?Q?JNKZlVTTdYoz6xzzuz91S76k0HqGpDef8b4KgI1ZV1DUIRiwI4frQHrrhjhW?= =?us-ascii?Q?E4LP3mh2Wg83sofRBUGRv/wPZh2iM7QB5FyEXOi4PQ1QVL7ttXbC4rkEMe37?= =?us-ascii?Q?uKo3mkwhGHeOfV804+b4MGqiWUQw8SebwfQVm78/VonctWtJcPP8UefVlE5J?= =?us-ascii?Q?adWMTi22XexxW1KMseQ6U8umTTHDvZU9reGH79xQxum7ULe0SfQmr7XslZNL?= =?us-ascii?Q?plIw5Dqd6sjDJ730SRVR6tNvSTpf3FzImJ4xTH80rXbRmE51c29ybjGzCT8X?= =?us-ascii?Q?YWv+fzc/Jn/Ci+cn7IZgT/+ylUTKRQLD4dvhcVn8SRD0Rt7wWsiDFUCiZ6UV?= =?us-ascii?Q?g1qTTfiblzUAkPNU+Xm6ef3FKNk0ova5SF6hodtmlXTy1taObd2LWns7vgtL?= =?us-ascii?Q?MPD9zELfQeuCg3CeM9m5ahPkqLX1z3DcxN1nHxV+3Iyqf7ou9Q1z7GJ6eyeb?= =?us-ascii?Q?99S95Wv7cp+JYioqCuZu/JoogMWvVTjE0PLfLVIUgKAyYHtOfla/JTcmo4nP?= =?us-ascii?Q?Gpsdch/HWSEaqSWsBgT76bK41ed/QGzsti8BHDPOs6FZZKBmOsWRcu7TeCHw?= =?us-ascii?Q?QA/wkkKICJpB4XqXIOuqBxp/fULmr4k1LnwwNlAJNXBLChFjjOA+ifpX2DEk?= =?us-ascii?Q?XlOwo/7w7C0YpSJZ0jaahmunRi69dfo3TqqaZk0cc1Fc8usInk5r6YiLjVej?= =?us-ascii?Q?eg15hLMGoA=3D=3D?= X-OriginatorOrg: Nvidia.com X-MS-Exchange-CrossTenant-Network-Message-Id: 748daf69-c9f8-46d9-ffe1-08df1026c60c X-MS-Exchange-CrossTenant-AuthSource: LV3PR12MB9411.namprd12.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 11 Sep 2026 17:04:42.9056 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 43083d15-7273-40c1-b7db-39efd9ccc17a X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: i/Y2H1CEPiOMYXAPfU8ahTCEDBGWPevlNNI6evzdl0aD7WpMxiNrOcVrUvVjt78itYh9hGUGe5B4avQlQC6mIQ== X-MS-Exchange-Transport-CrossTenantHeadersStamped: CH3PR12MB9343 Content-Type: text/plain; charset="utf-8" The cdev path enforces a single open per device and rejects a second bind of an already open device. That rejection must happen before the bind can mutate state shared across opens, notably the PF vf_token, so that a bind which cannot complete leaves the current opener's state untouched. Add a regression test that binds a PF with one token, attempts a second bind of the same PF with a different token, then initializes a VF with the original token. The VF init succeeds only if the second bind left the PF vf_token intact; a regression that clobbered it to the second token would make the VF init fail. Additionally add a second separate test that enforces the -EBUSY errno on second open so that the vf_token clobber and errno testing are independent. These hazards are specific to the cdev/iommufd single-open path, so the tests run only in iommufd mode. Suggested-by: David Matlack Assisted-by: LLM Signed-off-by: Alex Williamson --- .../selftests/vfio/vfio_pci_sriov_uapi_test.c | 57 +++++++++++++++++++ 1 file changed, 57 insertions(+) diff --git a/tools/testing/selftests/vfio/vfio_pci_sriov_uapi_test.c b/tool= s/testing/selftests/vfio/vfio_pci_sriov_uapi_test.c index 19d657d00b75..b57e4498443f 100644 --- a/tools/testing/selftests/vfio/vfio_pci_sriov_uapi_test.c +++ b/tools/testing/selftests/vfio/vfio_pci_sriov_uapi_test.c @@ -157,6 +157,63 @@ TEST_F(vfio_pci_sriov_uapi_test, override_token) ASSERT_COND_VF_CREATION(ret); } =20 +TEST(failed_second_open_does_not_clobber_token) +{ + struct vfio_pci_device *pf =3D NULL, *pf_second_fd =3D NULL, *vf =3D NULL; + struct iommu *iommu; + int ret; + + iommu =3D iommu_init("iommufd"); + + /* Create and bind PF using UUID_1 */ + ret =3D device_init(pf_bdf, iommu, UUID_1, &pf); + ASSERT_EQ(ret, 0); + + /* + * Attempt to open the same PF again and bind it with a *different* + * token (UUID_2). Return value intentionally unenforced. + */ + device_init(pf_bdf, iommu, UUID_2, &pf_second_fd); + + /* + * Attempt to initialize a VF using the original PF token (UUID_1). + * If the failed open above clobbered the PF's token (i.e. updated it to + * UUID_2), this VF initialization will fail. + */ + ret =3D device_init(vf_bdf, iommu, UUID_1, &vf); + ASSERT_EQ(ret, 0); + + device_cleanup(vf); + device_cleanup(pf_second_fd); + device_cleanup(pf); + iommu_cleanup(iommu); +} + +TEST(failed_second_open_returns_ebusy) +{ + struct vfio_pci_device *pf =3D NULL, *pf_second_fd =3D NULL; + struct iommu *iommu; + int ret; + + iommu =3D iommu_init("iommufd"); + + /* Create and bind PF using UUID_1 */ + ret =3D device_init(pf_bdf, iommu, UUID_1, &pf); + ASSERT_EQ(ret, 0); + + /* + * Attempt to open the same PF again and bind it with a *different* + * token (UUID_2). This must fail with EBUSY because it's a second open. + * Previously failed with EINVAL. + */ + ret =3D device_init(pf_bdf, iommu, UUID_2, &pf_second_fd); + ASSERT_EQ(ret, -EBUSY); + + device_cleanup(pf_second_fd); + device_cleanup(pf); + iommu_cleanup(iommu); +} + static void vf_teardown(void) { /* --=20 2.53.0 From nobody Fri Sep 25 13:54:44 2026 Received: from CH4PR04CU002.outbound.protection.outlook.com (mail-northcentralusazon11013004.outbound.protection.outlook.com [40.107.201.4]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 5BAE0457E55; Fri, 11 Sep 2026 17:04:49 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=fail smtp.client-ip=40.107.201.4 ARC-Seal: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1789146291; cv=fail; b=lbpzqSnqX4cDcPYekAkJTymqxPreHwCQR0AwhAgXHMbBtnUeO57R/8puht4MH5XDsZwEs5GHLagOWQFvIHAgDA6eJKh6KbTuaRfhgG8v690EX8/ORjT2md8nj6Yio7m6+yLDZstbWvI65vk1pivcSkGGumFT7LJPLLSzMpuUvRM= ARC-Message-Signature: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1789146291; c=relaxed/simple; bh=H377nt6u0NYX7UVd9XucaRcJG0QmIoIOsWALm46xKF4=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: Content-Type:MIME-Version; b=bMD+cssZZAjw0TtxGD5hZxdV6w4hykXzLxIxTwmKm7sMSE1kOvi8SeGdt5YxVPZwVgyDVIJxyE7QT8YoWihO3w6VLARZs8EqQH78qoPEbDVmpcfphJNqAT1l7OvyvA7vwCODkb9E/xoZoVkDrJuxJqi/Guunuk1Zl5q/ASvVrJY= ARC-Authentication-Results: i=2; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=nvidia.com; spf=fail smtp.mailfrom=nvidia.com; dkim=pass (2048-bit key) header.d=Nvidia.com header.i=@Nvidia.com header.b=JSF+R1xO; arc=fail smtp.client-ip=40.107.201.4 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=nvidia.com Authentication-Results: smtp.subspace.kernel.org; spf=fail smtp.mailfrom=nvidia.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=Nvidia.com header.i=@Nvidia.com header.b="JSF+R1xO" ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=r5QgDm/Ue4ePFg4cOGjtcoOBiHHCsRPEklUa38U0E7xy9VemPKOJcBvJZaz40Ol3XUQQYYBpiZyfW8WnxjayMcUIlAqmUknButiNh2AUIPltTJJ8cXc+ZzZor5BHuhLwBl8/NaHdQU/K36BavGCsVZwTO4UxzM2mUqoSdXJpKg6fiAYD+WKkroKEevyspcElmswx9MRU7Y/whrptdbrhEz7z6MAxHVZJO2D6hFFTxlgcmusltxyn6SbXOP7c6WOA6ZL6CWrnN6c9OTw18X/WyF7m/c6Emw+pZ6Vl8PyZni2DqY7MKu1R+KZfyNiZQdNdgMbVmb8vHkNRsuJqACBiiA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=OaGMMJx/LWZGDPE96zRNDK2htNpyCjvqiJD3ujVj/II=; b=uFG6XVKDBXNhT/Wp3EkPWNUVn/qtIg1WVrKnHPfCU/WPhvGw3PAndu58LA7B5KSrrWv2M6QIJEz+vKfG/g8t413LWJHLmI7rOm0tTTZwWg0vHuI6U6sbhdBA5mZl7I+GpKJuIINGizufqgJJmD87tL7wdBVwUbaU3mIxb/pYjHJ20y7O+Z/hp2z2xUGyN/rja75xB0mgj42zKL2NbG+QOESAAPYcr4V/wPdILFFn0gOCien2THvWCEvQO+nOhOdwSt4U0lZFjIRkGePHYk6H5xGAyGhv0CAfCmN2N1ROGYNkkTUDTLE42N1Ufen5S7wyLPXVBfcewN56ciROIbOQuA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=nvidia.com; dmarc=pass action=none header.from=nvidia.com; dkim=pass header.d=nvidia.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Nvidia.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=OaGMMJx/LWZGDPE96zRNDK2htNpyCjvqiJD3ujVj/II=; b=JSF+R1xOJwrKcHjuhdqYeVg9MCQLtbeCFIqLkOEV8sN731H650esHgVcBHWhh1P/AN7xLGImGFOB4O9mJ8xKXP6cc6vkx4zNqHZFFrDNZSPmG+vRMzo2JMj785K3sz/yBOhuZsaKfjCflX80BkeP3WWMf64MTg84M6PdQC3Z3l7kWjhL7hwUkTx8EBA2ihIwzDqgWVcibG6arBuNyk5AF5SV5mZdG8G3WKovs0tZ2Shy1RNxbvhJQt6h5znu+/toTrD7w5PNWFbEN9iOUxIfvygSlj7NCFq3+Kc42OMwDWUwp26MQDFa7lL+dtIq6v91Ss+OjrsDdqNLyTtOaJkA4A== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=nvidia.com; Received: from LV3PR12MB9411.namprd12.prod.outlook.com (2603:10b6:408:215::20) by CH3PR12MB9343.namprd12.prod.outlook.com (2603:10b6:610:1c0::10) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.21.406.9; Fri, 11 Sep 2026 17:04:44 +0000 Received: from LV3PR12MB9411.namprd12.prod.outlook.com ([fe80::98b7:86de:b69:2a15]) by LV3PR12MB9411.namprd12.prod.outlook.com ([fe80::98b7:86de:b69:2a15%6]) with mapi id 15.21.0406.007; Fri, 11 Sep 2026 17:04:44 +0000 From: Alex Williamson To: Alex Williamson , kvm Cc: Alex Williamson , linux-kernel , Jason Gunthorpe , Kevin Tian , Yi Liu , David Matlack Subject: [PATCH v2 3/4] vfio: selftests: Extend mix_and_match timeout to 90s Date: Fri, 11 Sep 2026 11:04:26 -0600 Message-ID: <20260911170429.1642480-4-alex.williamson@nvidia.com> X-Mailer: git-send-email 2.53.0 In-Reply-To: <20260911170429.1642480-1-alex.williamson@nvidia.com> References: <20260911170429.1642480-1-alex.williamson@nvidia.com> Content-Transfer-Encoding: quoted-printable X-ClientProxiedBy: CH2PR16CA0026.namprd16.prod.outlook.com (2603:10b6:610:50::36) To LV3PR12MB9411.namprd12.prod.outlook.com (2603:10b6:408:215::20) Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: LV3PR12MB9411:EE_|CH3PR12MB9343:EE_ X-MS-Office365-Filtering-Correlation-Id: 980990ad-e2b2-4068-7134-08df1026c6d5 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|1800799024|366016|376014|23010399003|11063799006|56012099006|10067099003|6133799003|22082099003|18002099003; X-Microsoft-Antispam-Message-Info: BpYg2b9Zyn0+9yGoR/7WsRCvc+r0KfJWESbbvaWU3J9h+IAMuZ5LYejyrRoJe9oLSdVnYUX0fMB0YkLo+MmYSdoeuG8UmARxgMAPBUFa9+Li/7BC8WizhcAQ4I2ATnqqfBI/2x3U8SwqeguPHhAjIfFo3G0k2eqD7Y8ZuU8Luvuvk/oW8P4cd43MvJJD8eIlo1/NVk28IbCY7pSCFNO6x4i+doLcaeMIPp4xgWSi3IKSEf3nubom5vKDVfXwiboma+xd2rMptVUF9VSSP5OYPt42+SOvjMY0DD+kS3yHkIBaczjrNwMQgBwb15J2duCAAExDGgC9cS36+fXNzDlKGsRgFqFnO2Uy4Q5UBoAAnoMx8msqMWwbCJW0puwcdByp7BMQ0qEo6DQi339aYZ3yQ587H8o3HCjqL4losj6OKlgZIPlm5nNd1VwVNh/f95gHpWuqfKli6efs6pUqfnmmA10MMPuBGP3iU2uTtYeDKsDrL6DXeYE/GHcWAV/OFQWTc+aTUX9FmyW07Xlnrhu9P7TqTjaQww2qOYBffcgNWBpGKnz5AU4LbCSgkwgrXkCSDWwZyaIjczVtUDHinzpr3n8RNb0RNHN3Fc469AgCRWrtKs6DmZPzCIuAV6IeZlW6ndo5t3qG0CK223YbouKwd/eihgCj+LZCg1Af5diCA8Y= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:LV3PR12MB9411.namprd12.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230040)(1800799024)(366016)(376014)(23010399003)(11063799006)(56012099006)(10067099003)(6133799003)(22082099003)(18002099003);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?VV5sATtnvilzu9mu3v0wM2oQm8GKhNqV0NeNbPo0FPx0qWP3uSQpjEp0cxEE?= =?us-ascii?Q?DRyTw95b/PFuK+KN+zS9Uq4IUr2xFHiRkRQx0esQdKgtHyUb0XV2r0EKwoJQ?= =?us-ascii?Q?90wYf4K/cOIlen6nrpaQOVruyoFPyF4oI2VJ8oiHHHqm6Xb9xQFRCKHb3QCq?= =?us-ascii?Q?9SbVLdzrFBS8Je8u+rOX4vAhqtn7OLBH22MjCd5o+pA6E5OiRES7CtRv3Awi?= =?us-ascii?Q?qzVJ0YBvifs6+Igs9NBP5gm3fOxOqTF+QQGp0GOJZKKhZ7uCvXAnGnzEAwk8?= =?us-ascii?Q?j5AiRcBdEvKOe5Wv6aeXQsLH/twKnIH4j3eeo6xvl3fOdIPfv9DdPil1PIMn?= =?us-ascii?Q?Pkw/FZjzvI9K+sw9GoYHRCZzaPUtP0c/9ha86aFH8UD14j7IvcZ3G1TIx4qt?= =?us-ascii?Q?FjSPWnEW+FGnB9nX+QNwQPhKCz45Hx6H0eAPHHEJps7HuyMKS4lN6WrIJqKJ?= =?us-ascii?Q?JD9C2U2Zrp9kYfizpQQDOigLml7pPsIaZ+kNHOfLxbQH8A5FLrKN8oQ1O4+y?= =?us-ascii?Q?abykGZenKFeVgIFoucmwEavrErXTBEcXyRYx7XwffpYXXYmJG8VUCPHhTt6e?= =?us-ascii?Q?R8I8eCxGNpNzt6ZHCzL6KGoddL2asAHCjEguib5lZGWymRKRmzVpngDN30wK?= =?us-ascii?Q?ty4Yx+WxmqBeVxgTYYJWAAvs5XAB62COHxStmKFFxgKSg4orcg+dRFJCVa7Z?= =?us-ascii?Q?x93M5gKxGzCv+wkV3pFBhMkSNyXDWXLYlG6KmZuqNKOn4kWw6HQSERYRlE2+?= =?us-ascii?Q?od7oN8I7hHc8Xsj1de4solEgWY1RjEMZfDQ1quIjYNUNWpD9QAwe2lOfbk35?= =?us-ascii?Q?E4XT5Rb4tg5avfPSgZsxcCFi8WZg1IW6DZo0kmbJMY2e85l+hCyBYG7yrIgI?= =?us-ascii?Q?xllxVdbvLK/UvyEdrAWcv8zyan760tENJa7thXyQ7o0u7YfW/RqeKKxNrtTE?= =?us-ascii?Q?5n2yxssfsHbOjfJ0j2YsT2qWebgulyvxEMnDjly62kPwTp3c54HmEgybeN2I?= =?us-ascii?Q?4OdtwkAnZHELFSYubFLsfk4aj0nNKStUJTur3TgsSIUWFuP6CD1dkrxSemRk?= =?us-ascii?Q?asA7ldcN7b+X2iDhuN2hoNCrQmqA5O2/Z3x8AQ6+j9ijvLx+cv+TUMKR3LuH?= =?us-ascii?Q?vV4zs9jP48mM022mz46UwfHFk06W8DDALzE/pQqRlkJ7G1ijkm8kHpHlHfCE?= =?us-ascii?Q?G/RcDC5QRdto49vjfDIuX0GZphwlD9lLX752NEVBt9umbknRRKovED+VD7YO?= =?us-ascii?Q?bRUqRiE3AueIkHd5YjZFLbkmqINzY2lzsBTKHn0RSUrWrBOsbIBCOqlA3rNM?= =?us-ascii?Q?j3RFyHoECFY+8EDeE0pdWDNMICjGdPo13w4V5EwDdl+gFAe3GVQPIJGQn/gh?= =?us-ascii?Q?RBwy4nVsh+qc5ekMCNq733BHEg8jfOUIYJZOabkM3+9r767YSFA6nGW6rCFR?= =?us-ascii?Q?+oNz/zZnuymKx/QlJinVKOOmORRez9Bo+mTxyaC8k7vnDBpuW1MxVVSPWh5U?= =?us-ascii?Q?h/WudVLV900Rub02vtSMDRh51odF8fEOjPMP+WTLpCd8GASZ3j543xD/pIYQ?= =?us-ascii?Q?4mp7mh0jh/yFpvKumabLBbwfRiBcLI/T8rCB6KJTK33T3d5jvTiDZXEKDWbp?= =?us-ascii?Q?HAV+tsCQ5IL0ld81Wyd5PISEualUmEuH3pj4xTDAwHmmku/ba6k51hnpEi4F?= =?us-ascii?Q?XrpeYzThNluRHJ4qgKfU3Hqyjo4c9xDQD5FTs9PrDaa64xWRhnTFDylvsV8+?= =?us-ascii?Q?90ZxfBOVIg=3D=3D?= X-OriginatorOrg: Nvidia.com X-MS-Exchange-CrossTenant-Network-Message-Id: 980990ad-e2b2-4068-7134-08df1026c6d5 X-MS-Exchange-CrossTenant-AuthSource: LV3PR12MB9411.namprd12.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 11 Sep 2026 17:04:44.2715 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 43083d15-7273-40c1-b7db-39efd9ccc17a X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: XVSoBMI0+D7Gvj0mRLjG+jrcLdMTuSEX65fuIPRUzQfN0SdnRIDSkcanL3tM10VFv3IwyO80Ya9RPNchBQyK1A== X-MS-Exchange-Transport-CrossTenantHeadersStamped: CH3PR12MB9343 Content-Type: text/plain; charset="utf-8" Systems with firmware first error handling can see heavy SMM load as a result of the mix_and_match induced IOMMU errors. For devices like igb that get wedged on these errors, the resulting FLR is delayed waiting for the transaction pending register to clear, which never occurs. However, due to the background SMM, the backoff delays in PCI code wildly exceed their timeouts. As a result, the whole test can report failure. Extend the mix_and_match timeout to a value shown to complete reliably on such systems, with ~2x margin. Assisted-by: LLM Reviewed-by: David Matlack Signed-off-by: Alex Williamson --- tools/testing/selftests/vfio/vfio_pci_driver_test.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/tools/testing/selftests/vfio/vfio_pci_driver_test.c b/tools/te= sting/selftests/vfio/vfio_pci_driver_test.c index 761bf117d624..1d532f944cee 100644 --- a/tools/testing/selftests/vfio/vfio_pci_driver_test.c +++ b/tools/testing/selftests/vfio/vfio_pci_driver_test.c @@ -190,7 +190,7 @@ TEST_F(vfio_pci_driver_test, send_msi) ASSERT_EQ(1, value); } =20 -TEST_F(vfio_pci_driver_test, mix_and_match) +TEST_F_TIMEOUT(vfio_pci_driver_test, mix_and_match, 90) { u64 value; int i; --=20 2.53.0 From nobody Fri Sep 25 13:54:44 2026 Received: from CH4PR04CU002.outbound.protection.outlook.com (mail-northcentralusazon11013004.outbound.protection.outlook.com [40.107.201.4]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 1C4674A8402; Fri, 11 Sep 2026 17:04:54 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=fail smtp.client-ip=40.107.201.4 ARC-Seal: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1789146296; cv=fail; b=GzViFeT6a69XVKhvaYW1SZv7NpmpzLG6i06OR0auh22N7kwJKdgw5ZPWXJzlzLDgMjs16cIl8hYKY+AdZ3ueum0GC5D3wh46rZfWT9jXx+Ng3GtJj/nxr+coanpkJYoqO7qkdlyD7mcdRnvNAoU9c7i3Q0m5cLxoHJxZVRUoJfI= ARC-Message-Signature: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1789146296; c=relaxed/simple; bh=9MEMVtsMkuuyFza5mIvgIUrMdEJva6ea889Citf8cq4=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: Content-Type:MIME-Version; b=O/OebJ7qP6hQSJi2MAdNXnexKGcT+x/UxmCT71UF96PiD0LPD97zJN6iULKIh3zrmy0fL0gLjl6I+yUHcRw8MRxAgbxMhw4YmGck7ZCF7f8GrQ5h3ofYcs4UxjOZO17qEJT5FzUEDJQn3y9MX2rX4AhF1c+Jf2V/HJAnsJcTiqg= ARC-Authentication-Results: i=2; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=nvidia.com; spf=fail smtp.mailfrom=nvidia.com; dkim=pass (2048-bit key) header.d=Nvidia.com header.i=@Nvidia.com header.b=a87lt8A+; arc=fail smtp.client-ip=40.107.201.4 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=nvidia.com Authentication-Results: smtp.subspace.kernel.org; spf=fail smtp.mailfrom=nvidia.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=Nvidia.com header.i=@Nvidia.com header.b="a87lt8A+" ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=ucte8PeawXo52u0ZuuDOMLND7dwMralPIfNPUGU6kpFR/0rTh+312LdNnEWMrMUUssqRBXoQMWNEECELReLqUARHM+kdG0c/bl/how7FxHvum3I9tUnDfd+O+hXqZw7yVRyebBqlo6usCDiPclHK65wxIGB1UzoIdd5yY32sgsx5lAHaWPK4bCVyzqLpajGE6yxiX97wWOm+jEIlmByosGnW/eIHZzVVXfLT16yYtoFcELaUEdrUDs0st5WD+gm+lAjSomBR0+fHC/4T9MlBFNtOVquITJMkr2yGzKo1vkf5S3GAtSBnagZaAtE+Kiqtxe+FV0IB+4dlCoNo2HfwKQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=K9LTqCXbqoLxybTIqHfOnEFciL8zE+IzF+24+L5PLWQ=; b=x2BC1FGuUuuFPSSjCXZYImbmNPV5e/luqvY/aoWAxWMaOCrenAK88PpOg61OWi9Gf0HUXwoHfwLUcLTRlP6B5aGIs9looU8P7/+cY60XfHj24egyHW3RJG2VMho04ybu2Na0dSYlzGs5p5c9jK/Wsev5Oq2T/4v8n7o42yqmVZ+SwEo2CWugEKRlBFdG35gvjZUKieaILS6O12xed02MNcju1xrv1vym0ayCdtooob2qbZFSXSj/ct8xb77Tlz2Ezsp8y0C0Idsm771m8DbXekC9yOlGI34mlFNpiizJvNye2tCDi05dnCfZcH4rUEhxO/WiXZmm1jLjpI5pzH8EvA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=nvidia.com; dmarc=pass action=none header.from=nvidia.com; dkim=pass header.d=nvidia.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Nvidia.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=K9LTqCXbqoLxybTIqHfOnEFciL8zE+IzF+24+L5PLWQ=; b=a87lt8A+Q1PEaVYMjiUYWW1k0agjQEYotOn4soBEzEdwNHZt2p0CQTV5ARXC4JbtdFKXNXaw4YEHbDUuM39DijscXlNZ5HNJREaed6wxKaqPad17uu4QyT45BRr1FxGhEpreXk9LJHtzS4lKqz8zJsu/dpjdfYyeIuOS3KSVyY0D+UvEOpxQ64lOz+4o8MGCI/K579ovZ5jPH/FPpfVstYmf5aeGmbilB4o5HDnqI4IpTIOFwNzfp7skMQzw9g4pkUddWh3WD/u5CFXkeQMoQtniTyYgLaSwNjxhFw5LQfgFxIUtskNiUBENw3NX2R6Mv5/Eb+pKCUIZ+/wdDpzu9Q== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=nvidia.com; Received: from LV3PR12MB9411.namprd12.prod.outlook.com (2603:10b6:408:215::20) by CH3PR12MB9343.namprd12.prod.outlook.com (2603:10b6:610:1c0::10) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.21.406.9; Fri, 11 Sep 2026 17:04:45 +0000 Received: from LV3PR12MB9411.namprd12.prod.outlook.com ([fe80::98b7:86de:b69:2a15]) by LV3PR12MB9411.namprd12.prod.outlook.com ([fe80::98b7:86de:b69:2a15%6]) with mapi id 15.21.0406.007; Fri, 11 Sep 2026 17:04:45 +0000 From: Alex Williamson To: Alex Williamson , kvm Cc: Alex Williamson , linux-kernel , Jason Gunthorpe , Kevin Tian , Yi Liu , David Matlack Subject: [PATCH v2 4/4] vfio: selftests: Extend timeout for runner executions Date: Fri, 11 Sep 2026 11:04:27 -0600 Message-ID: <20260911170429.1642480-5-alex.williamson@nvidia.com> X-Mailer: git-send-email 2.53.0 In-Reply-To: <20260911170429.1642480-1-alex.williamson@nvidia.com> References: <20260911170429.1642480-1-alex.williamson@nvidia.com> Content-Transfer-Encoding: quoted-printable X-ClientProxiedBy: CH2PR16CA0026.namprd16.prod.outlook.com (2603:10b6:610:50::36) To LV3PR12MB9411.namprd12.prod.outlook.com (2603:10b6:408:215::20) Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: LV3PR12MB9411:EE_|CH3PR12MB9343:EE_ X-MS-Office365-Filtering-Correlation-Id: c65443bb-7de6-4554-b5b9-08df1026c791 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|1800799024|366016|376014|23010399003|5023799004|11063799006|56012099006|10067099003|6133799003|22082099003|18002099003; X-Microsoft-Antispam-Message-Info: uwSFlMN4F0zR1/lxoxh8lOZjmvht6kL4JHxYsmx5zYZ/y4XA/FnfG0DWEYgzBmog0Dux4D+OovQuJXX18oR9nrDGu7zuQryQG8NOOhKjQZHJMQMdFpT/HRErDAjPA1sjZ5kX/IHVAruaccFGc2Vju524mVPDQr4rKj4MSXWtJI3IOpcfZVToYpEwiWvscnsijrgDTbyGEFEQEMPK12CfF3QdFjdbRmpH1s0qAb80LyoyyLfkS+LVCDW9I/vzqflo3pWm+Ou4zEc3TNHZhZRZ0FUlNCHQfITSEZfXjsMSJPcibde/cdLp+U26LTRsXa3892cpgtJY5I584Wq4zEpZnJZBMW2/4scZ9YWOupBbaBzPV+JQS/fpama+KzcHe79Ovg58iw5wNEPa4p3e5XWmTt6pkTsGVEsqD5jThF/y+lHUMU/TuwSmrv5Eq1b1MOZ64son0FejVw6SgN38GoADJrePtwv2xFRSmgrG9f1B+2Ig+dHOSQH+tfM1O7FC3W9FTJv/mVwWwxaKd2UZpJmbQGGGHELjxOhSu58T3jkMPx/iotlltZb2Wj9frlTBjy9Yuvg+NTj1XoHTuElrR1wnXVo3p5pgVg7PBqhzLafbDdvoXVd1FfXZxmu6+B15I4vjcrxRijLl8FVNhdwrLu9RYajWpaDa27gBMYldNYaYvt4= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:LV3PR12MB9411.namprd12.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230040)(1800799024)(366016)(376014)(23010399003)(5023799004)(11063799006)(56012099006)(10067099003)(6133799003)(22082099003)(18002099003);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?4J4Odk+1xk3T2FBFEz/hFqh9tRimgyPeEzr9k6wqOwLElZpgR0YZdIRsnOIu?= =?us-ascii?Q?c6efRa7cHctlM5f0p5VPEs6jDzNOxhQ79x3CafeqGxGLc05q6GI44Hc8P6yp?= =?us-ascii?Q?3cnhDcnHl31UrCjiwdi/quZI0xR7wPkhodB/aeaEx/JdvNB/OTtoFHDNbukJ?= =?us-ascii?Q?y/1NOVupCuwu4WQeUAfZLvamfhrNmLwX+i4Ok7Csj+MiVKfGjlIwy1xbVEzy?= =?us-ascii?Q?3qHo7xJYmVn30TF7jZ44sMMm7i3iq90tlLxa5kN3dhGBUJyOTrpvygqtojQZ?= =?us-ascii?Q?nNpkdOfNk7hBAj2ubOxkNLytEtRtAE3MAVpYxC/bsu2rovMLgyigjDL3hZh5?= =?us-ascii?Q?z21h6/Q4uBxTqk6ZXlS/J0Xi992n5vYT2L3FKXbenyo75Y5TjA3dqYR3Lv2F?= =?us-ascii?Q?OmL+RH97niJ3aI6hdbeDZorJD2QWzD+TE8UAXTqbOPn6Zy0ZoL96XX+9jBgH?= =?us-ascii?Q?IKm0NxdGwEM1FcAffSFniHiOrd5mEaKhEOCkZHhpqofq6szRdxLORiMPnFim?= =?us-ascii?Q?97+FtyQTVHRdP7H1SRgzGlLC4cHHsVNetWaJTkL0RquH5R9UfSPDqbTjqpVY?= =?us-ascii?Q?l867nCLhLK1rYFnsajdZpsujUKMd8gbVA0/jbfpaWKeWMQ3Q3RdtR1M8lRUK?= =?us-ascii?Q?Vp4pKMosAvzpl9+gZl+ETWeSjNb8+K9k3MUm7/InsY9wNy34OyWWgsTollr9?= =?us-ascii?Q?oJ7nYkU1J8Xxd9EKULy9nOhCcizp75TGD5xrQP1iKknvrL1qcMC0F5MCXNkn?= =?us-ascii?Q?aGcMk8jdW0lgEmi8VP3juTgfAGKTDI8/LBjGzvFvqwXygWnu7xo/x7CPyBJw?= =?us-ascii?Q?NB7G5fR5eZLUcQ9eUHbU6APJhDGjgnJUEniB7scRk9uJujl8/Kc0RdLT/YdH?= =?us-ascii?Q?q7hrZSd/NXnFFLwhLPgQjgdI/ZmTWOHKfEwS/7yXeAxqe3ivtIOE2GifFpXX?= =?us-ascii?Q?AED3z/+AzBm95K9etQiAViME60jTmJy5Kf0DmN8k15isG3VQLshWRL7kKPor?= =?us-ascii?Q?ykcnj0gKy6iv+aAQaPpiVdG+cGmY6ZdyzDi1VK9fjlyp87Qz6Cciax0zVYa4?= =?us-ascii?Q?caSQIE9TIlA2F6pnELI/oYhvmp1fquFGQtdhi9Tl7lh1qtFWeBhpRg13C9k1?= =?us-ascii?Q?lU6RILoI0ed7esnvx+BYSaC5XN3O/P0lhVx0rCRDsygZ4TwJgDtk55/4lyWD?= =?us-ascii?Q?K4mkPYkEYlamCgVnUzmYTe1zyQsV6WBy/2WrgvTmrm5Ig26fxxMzjLBG/P71?= =?us-ascii?Q?xcE4rf7ZAy/46BimA/8rNGBbyPBKd47rZVoDdoxP7no+r8oeNWTfiPiNJmhH?= =?us-ascii?Q?Kynv8UcoDEXGUYUpVqYTmQgizNn+v51fumDkMFb8IFhYjBdh29BNrNX6TSDq?= =?us-ascii?Q?DYDpRp2k3CMeEBtwkHm6bFwTJaMcXxCpwkpK9TyBZzKKeqBYPh8o/nR8/0sR?= =?us-ascii?Q?w5dKyQIm1Lei5CAhbt6E5Upqgjx6YKJR00wi0O69hrS3w+BEhSvHo3ISkYlV?= =?us-ascii?Q?gFe1hEFEDkmzwq58NKMOrcmvss93oWj9uNFF009Q/+3XGtyEwoC8aUI+cPwU?= =?us-ascii?Q?yifrJrDGOWT30NhnatEQp8rLK+/OdThwStwbTG7YEPmCprLvNUp5EtbRiihs?= =?us-ascii?Q?Idxx+HFoyl9P/hwJ3DAEbLHiLF4DLIiz0KBK7yIpX2EC3YdbSEKXV87HkUVD?= =?us-ascii?Q?UQa91x5Vu2GWjRBB5ICw/hV1FbVpOjrdpKggCPClVfkta15X2sw2PU9EKQUy?= =?us-ascii?Q?K/5ajVGNgw=3D=3D?= X-OriginatorOrg: Nvidia.com X-MS-Exchange-CrossTenant-Network-Message-Id: c65443bb-7de6-4554-b5b9-08df1026c791 X-MS-Exchange-CrossTenant-AuthSource: LV3PR12MB9411.namprd12.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 11 Sep 2026 17:04:45.4691 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 43083d15-7273-40c1-b7db-39efd9ccc17a X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: QbJ191dCKOfOhsQkzvVr5/Lu6OkieX2e/4+xQp0dMB475sWyRpenlP/J426QtoqfyiRdf1t1eidYhvufMnOLWA== X-MS-Exchange-Transport-CrossTenantHeadersStamped: CH3PR12MB9343 Content-Type: text/plain; charset="utf-8" When executed via the runner, ie. run_kselftest.sh, tests are subject to a default 45s timeout. None of the igb, ioatdma, or nv_falcon drivers can run the vfio_pci_driver_test within this window. The igb driver is the worst due to the device getting wedged from bad DMAs in mix_and_match and requiring the full transaction pending delay prior to FLR. This is even further exacerbated when the system implements firmware-first error handling and the transaction pending scheduled delays are preempted beyond expectations by SMIs. Worst case observed runtime for the whole vfio_pci_driver_test on such a setup is 450s. Round up to 600s. Assisted-by: LLM Reviewed-by: David Matlack Signed-off-by: Alex Williamson --- tools/testing/selftests/vfio/.gitignore | 1 + tools/testing/selftests/vfio/settings | 5 +++++ 2 files changed, 6 insertions(+) create mode 100644 tools/testing/selftests/vfio/settings diff --git a/tools/testing/selftests/vfio/.gitignore b/tools/testing/selfte= sts/vfio/.gitignore index 7fadc19d3bca..fc14bc18bcd8 100644 --- a/tools/testing/selftests/vfio/.gitignore +++ b/tools/testing/selftests/vfio/.gitignore @@ -8,3 +8,4 @@ !*.mk !.gitignore !Makefile +!settings diff --git a/tools/testing/selftests/vfio/settings b/tools/testing/selftest= s/vfio/settings new file mode 100644 index 000000000000..c9abf1c19f19 --- /dev/null +++ b/tools/testing/selftests/vfio/settings @@ -0,0 +1,5 @@ +# Extend kselftest default 45s timeout based on worst case test runtime, +# currently vfio:vfio_pci_driver_test running on physical NIC, battling +# SMIs due to invoked firmware-first error handling from bad DMAs and +# device wedging. Observed worst case ~450s, extend to 600s. +timeout=3D600 --=20 2.53.0