From nobody Fri Sep 25 14:31:13 2026 Received: from mta0.migadu.com (out-225.mta0.migadu.com [91.218.175.225]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 7DC1F43DEDF for ; Fri, 11 Sep 2026 10:24:43 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=91.218.175.225 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1789122285; cv=none; b=u9COpUaLTcWutt6/PTEkH2I24XpTNNojelSGIqImlIBsWL84kCCSx0KBr725miz7vJ0gkIMg8a4Bdz6V0blt5Fi/lOiMiy86iGIwbC9f3oewW8Xg26XHlHwwI1UWjgAuCmNVy0UiFbTm6h1gdWBI/I6juQqDr6sdd6K3+zv+R0U= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1789122285; c=relaxed/simple; bh=l7+9c5zwjLVYxvhKf3ZRi1rGsctqjpbWc4slKLd1B+8=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=bkQSx4k/n7w1vjJd74amnYZFHllHfmjH7i3o19ReupCziA4p7hXT18UjbvY8c2vw2x5sICpXBw6kvLJfbn5bKl0rqj8RLEop57jmM7PrbjjkUG8J5dkwFrEU20+yIVlJHsDfLL96N9fwigkXV2LF+G24URNMnyfnD0rc2ILJ6T4= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.dev; spf=pass smtp.mailfrom=linux.dev; dkim=pass (1024-bit key) header.d=linux.dev header.i=@linux.dev header.b=sjn0Z6xw; arc=none smtp.client-ip=91.218.175.225 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.dev Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linux.dev Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linux.dev header.i=@linux.dev header.b="sjn0Z6xw" X-Envelope-To: linux-kernel@vger.kernel.org DKIM-Signature: a=rsa-sha256; bh=l7+9c5zwjLVYxvhKf3ZRi1rGsctqjpbWc4slKLd1B+8=; c=simple/simple; d=linux.dev; h=from:to:subject:date:message-id:mime-version:content-type; s=key1; t=1789122280; v=1; x=1789727080; b=sjn0Z6xwF0sGlctjKRr3HULe6VEpERNVoeNMqOVyWKuh0HQ0Ku2SOW0ucv7EK6qKu8FNKlfC ElpaJL+Cb05NxsI3v1Ydf6iB7hkQ7CY/W5ux0jEdTYeMTtZcQTLkS8Z7N6j5meAb0Lb9X/GyR+Q 3PyEXHHHK1K6M6IiN75PlXmA= X-Envelope-To: linux-kernel@vger.kernel.org Received: by smtp.migadu.com with ESMTPS id 121f891faccde060; Fri, 11 Sep 2026 10:24:40 +0000 X-Mizu-Trace-ID: 121f891faccde060 X-Migadu-Flow: FLOW_OUT From: Xuanqiang Luo To: netdev@vger.kernel.org Cc: dsahern@kernel.org, idosch@nvidia.com, davem@davemloft.net, edumazet@google.com, kuba@kernel.org, pabeni@redhat.com, horms@kernel.org, linux-kernel@vger.kernel.org, Xuanqiang Luo Subject: [PATCH net-next v1 1/2] ipv6: make IPV6_FREEBIND setsockopt lockless Date: Fri, 11 Sep 2026 18:24:17 +0800 Message-ID: <20260911102418.157071-2-xuanqiang.luo@linux.dev> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20260911102418.157071-1-xuanqiang.luo@linux.dev> References: <20260911102418.157071-1-xuanqiang.luo@linux.dev> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" From: Xuanqiang Luo IPV6_FREEBIND still takes the socket lock despite using inet_assign_bit() to update the flag shared with IP_FREEBIND. IPv6 TCP and UDP sockets can already update this flag without the lock through SOL_IP/IP_FREEBIND. Move IPV6_FREEBIND to the lockless setsockopt path. Signed-off-by: Xuanqiang Luo --- net/ipv6/ipv6_sockglue.c | 14 ++++++-------- 1 file changed, 6 insertions(+), 8 deletions(-) diff --git a/net/ipv6/ipv6_sockglue.c b/net/ipv6/ipv6_sockglue.c index 1f68fb64a43ef..4124084c3cd79 100644 --- a/net/ipv6/ipv6_sockglue.c +++ b/net/ipv6/ipv6_sockglue.c @@ -398,6 +398,12 @@ int do_ipv6_setsockopt(struct sock *sk, int level, int= optname, =20 /* Handle options that can be set without locking the socket. */ switch (optname) { + case IPV6_FREEBIND: + if (optlen < sizeof(int)) + return -EINVAL; + /* Shared with IP_FREEBIND. */ + inet_assign_bit(FREEBIND, sk, valbool); + return 0; case IPV6_UNICAST_HOPS: if (optlen < sizeof(int)) return -EINVAL; @@ -679,14 +685,6 @@ int do_ipv6_setsockopt(struct sock *sk, int level, int= optname, retv =3D 0; break; =20 - case IPV6_FREEBIND: - if (optlen < sizeof(int)) - goto e_inval; - /* we also don't have a separate freebind bit for IPV6 */ - inet_assign_bit(FREEBIND, sk, valbool); - retv =3D 0; - break; - case IPV6_RECVORIGDSTADDR: if (optlen < sizeof(int)) goto e_inval; --=20 2.43.0 From nobody Fri Sep 25 14:31:13 2026 Received: from mta0.migadu.com (out-234.mta0.migadu.com [91.218.175.234]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 28BB143F4B5 for ; Fri, 11 Sep 2026 10:24:47 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=91.218.175.234 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1789122291; cv=none; b=t+YlSb+HtJ4T+XSPz1R+JTg+Q57juh0Eayo9cX4GxQB7ESBWMstotwnn1npfG2RP3YIxpvGz4s+zDHkF2bWKSX/fslHEBBQxbxRDWC8juU6iDoDXLTmzern4LZJ52rqr0gUAvtvD+Ok1IYqe7K59uqLHGiB/M5g+8LdK5KhL3Rw= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1789122291; c=relaxed/simple; bh=CKO+PYwYpisBL043APtaARgWQuAzKYp65Rf3nLFJ8As=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=cl+9/ChBerK4nBOppIBMb1Bf8rbi1mekWgPSZb5hJjUMbuWCs8U6uxZ3qhDuOIjSWHwRqgGENF3TKTU0VysGWKh4R4IyTcuswfls0NLF3BOyCnZaImv2tVVtEdWjHIjOh9VfNNGhGWL71gdGpzur5u97585d7DezG9w6cDzUlKM= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.dev; spf=pass smtp.mailfrom=linux.dev; dkim=pass (1024-bit key) header.d=linux.dev header.i=@linux.dev header.b=fhWiINsw; arc=none smtp.client-ip=91.218.175.234 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.dev Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linux.dev Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linux.dev header.i=@linux.dev header.b="fhWiINsw" X-Envelope-To: linux-kernel@vger.kernel.org DKIM-Signature: a=rsa-sha256; bh=CKO+PYwYpisBL043APtaARgWQuAzKYp65Rf3nLFJ8As=; c=simple/simple; d=linux.dev; h=from:to:subject:date:message-id:mime-version:content-type; s=key1; t=1789122285; v=1; x=1789727085; b=fhWiINswVARgVgGzdeJhTksqRu3NF3LRGYw4XvfzBq7O/z5bMpuh/uyysG0wz+aFcLmy4IQl khiI2zyQB+RWg6uI4vmqAxtyoyKWi9fSVTqPf5mSnaLyY6XVn2IDgd7rB62UkdAkm8P+wsiXzm0 Rd6UJBa85ph0FpoEJ1XGH370= X-Envelope-To: linux-kernel@vger.kernel.org Received: by smtp.migadu.com with ESMTPS id 367291e8ef5c5200; Fri, 11 Sep 2026 10:24:45 +0000 X-Mizu-Trace-ID: 367291e8ef5c5200 X-Migadu-Flow: FLOW_OUT From: Xuanqiang Luo To: netdev@vger.kernel.org Cc: dsahern@kernel.org, idosch@nvidia.com, davem@davemloft.net, edumazet@google.com, kuba@kernel.org, pabeni@redhat.com, horms@kernel.org, linux-kernel@vger.kernel.org, Xuanqiang Luo Subject: [PATCH net-next v1 2/2] ipv6: make IPV6_TRANSPARENT setsockopt lockless Date: Fri, 11 Sep 2026 18:24:18 +0800 Message-ID: <20260911102418.157071-3-xuanqiang.luo@linux.dev> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20260911102418.157071-1-xuanqiang.luo@linux.dev> References: <20260911102418.157071-1-xuanqiang.luo@linux.dev> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" From: Xuanqiang Luo IPV6_TRANSPARENT still takes the socket lock despite using inet_assign_bit() to update the flag shared with IP_TRANSPARENT. IPv6 TCP and UDP sockets can already update this flag without the lock through SOL_IP/IP_TRANSPARENT. Move IPV6_TRANSPARENT to the lockless setsockopt path. Signed-off-by: Xuanqiang Luo --- net/ipv6/ipv6_sockglue.c | 22 +++++++++------------- 1 file changed, 9 insertions(+), 13 deletions(-) diff --git a/net/ipv6/ipv6_sockglue.c b/net/ipv6/ipv6_sockglue.c index 4124084c3cd79..4b3536571c980 100644 --- a/net/ipv6/ipv6_sockglue.c +++ b/net/ipv6/ipv6_sockglue.c @@ -404,6 +404,15 @@ int do_ipv6_setsockopt(struct sock *sk, int level, int= optname, /* Shared with IP_FREEBIND. */ inet_assign_bit(FREEBIND, sk, valbool); return 0; + case IPV6_TRANSPARENT: + if (valbool && !sockopt_ns_capable(net->user_ns, CAP_NET_RAW) && + !sockopt_ns_capable(net->user_ns, CAP_NET_ADMIN)) + return -EPERM; + if (optlen < sizeof(int)) + return -EINVAL; + /* Shared with IP_TRANSPARENT. */ + inet_assign_bit(TRANSPARENT, sk, valbool); + return 0; case IPV6_UNICAST_HOPS: if (optlen < sizeof(int)) return -EINVAL; @@ -672,19 +681,6 @@ int do_ipv6_setsockopt(struct sock *sk, int level, int= optname, retv =3D 0; break; =20 - case IPV6_TRANSPARENT: - if (valbool && !sockopt_ns_capable(net->user_ns, CAP_NET_RAW) && - !sockopt_ns_capable(net->user_ns, CAP_NET_ADMIN)) { - retv =3D -EPERM; - break; - } - if (optlen < sizeof(int)) - goto e_inval; - /* we don't have a separate transparent bit for IPV6 we use the one in t= he IPv4 socket */ - inet_assign_bit(TRANSPARENT, sk, valbool); - retv =3D 0; - break; - case IPV6_RECVORIGDSTADDR: if (optlen < sizeof(int)) goto e_inval; --=20 2.43.0