From nobody Fri Sep 25 14:32:27 2026 Received: from smtpout-03.galae.net (smtpout-03.galae.net [185.246.85.4]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id BEBD646AA65; Fri, 11 Sep 2026 09:18:40 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=185.246.85.4 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1789118322; cv=none; b=W0vV78AfZt/gTaJSfzi1ab5+dhvLVTog/7kDkJ9hGS2hvuYpP/jII1+TeP7gCmUs3iGDA2h/Sn8gyIhOrSTsTrh5Y2mFPHDdnzfgC37ZkQaS2+RVqyYTFZi+ePOaPH8ErIKBeLFzzBZ4r08tF5Jl0EC748rIxw76peufpaV0N6w= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1789118322; c=relaxed/simple; bh=FNdJQg1nU9szWM1z+WQDgA68h3ZDQ7o49HjueSGBOds=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=DlzaSU8biIX/vKOjrkqp2OF94b7NIDH1dFElcgiMYwMRCSCgxuuYcHundmpnPNeaxwViAWU+tALYpF7ycO5ftdioyWeMKEzU7GByywiEn6ojb05uEYNZ6UHF/E2zUNrm/d12WbJhWm8aBnpY6C710p4W51MiSdM/RjfOd6tSUjs= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=bootlin.com; spf=pass smtp.mailfrom=bootlin.com; dkim=pass (2048-bit key) header.d=bootlin.com header.i=@bootlin.com header.b=ESSRExb7; arc=none smtp.client-ip=185.246.85.4 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=bootlin.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=bootlin.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=bootlin.com header.i=@bootlin.com header.b="ESSRExb7" Received: from smtpout-01.galae.net (smtpout-01.galae.net [212.83.139.233]) by smtpout-03.galae.net (Postfix) with ESMTPS id D978D4E401AE; Fri, 11 Sep 2026 09:18:38 +0000 (UTC) Received: from mail.galae.net (mail.galae.net [212.83.136.155]) by smtpout-01.galae.net (Postfix) with ESMTPS id A75A8601DE; Fri, 11 Sep 2026 09:18:38 +0000 (UTC) Received: from [127.0.0.1] (localhost [127.0.0.1]) by localhost (Mailerdaemon) with ESMTPSA id 89F2011C7AFA0; Fri, 11 Sep 2026 11:18:35 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bootlin.com; s=dkim; t=1789118317; h=from:subject:date:message-id:to:cc:mime-version:content-type: content-transfer-encoding:in-reply-to:references; bh=d41CLK7NzVUywqJkormRGEPI2n24qzm1kyA+ft/gceU=; b=ESSRExb7lLsINACTLsll/7Z92NOsbCm569SBzGLpAbI19WD63QbinrrUcSEjmrERpqb4NE 1nniMmffq4N3NDcDzcmv2vx95Ciu8oCavP78t5NDmGDV4qGJ0AyHcDZm9NCDUV+BF/YLwp eTkKiPVZYpFrypemBrCIoW1pFjHJ9WDNTWaatKOy3UGHonhyd0TuUxQ6Ib0zT0I/Bd1ho4 ss0ryVrbvt2/zY0RLYvxCGBOQR2laaElzP3pdYXaIq6AkxnnR11UCm6MK4EaJAWoJpNSMN YfYEvAoWKZUnbxMhjGEmaPIOb2wf54Qwe9E9RFweaknBu3ZZvY22ui79QbVeyg== From: Diogo Ivo Date: Fri, 11 Sep 2026 11:17:34 +0200 Subject: [PATCH 1/3] watchdog: omap: Remove duplicate start() with early_init Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20260911-omap4-wdt_boot-v1-1-637d778a4a1e@bootlin.com> References: <20260911-omap4-wdt_boot-v1-0-637d778a4a1e@bootlin.com> In-Reply-To: <20260911-omap4-wdt_boot-v1-0-637d778a4a1e@bootlin.com> To: Wim Van Sebroeck , Guenter Roeck , Aaro Koskinen , Andreas Kemnade , Kevin Hilman , Roger Quadros , Tony Lindgren , Rob Herring , Krzysztof Kozlowski , Conor Dooley Cc: linux-watchdog@vger.kernel.org, linux-kernel@vger.kernel.org, linux-omap@vger.kernel.org, devicetree@vger.kernel.org, thomas.petazzoni@bootlin.com, Diogo Ivo X-Mailer: b4 0.15.2 X-Developer-Signature: v=1; a=openpgp-sha256; l=921; i=diogo.ivo@bootlin.com; h=from:subject:message-id; bh=FNdJQg1nU9szWM1z+WQDgA68h3ZDQ7o49HjueSGBOds=; b=owEBbQKS/ZANAwAKAQa+fFtWXslFAcsmYgBqo8dn3OqUkE0x8xLdxpcWjYTljiyg1JHdVJWWT mkF+6//T6qJAjMEAAEKAB0WIQTma35o1i1081e8B2UGvnxbVl7JRQUCaqPHZwAKCRAGvnxbVl7J RSSGD/9aA2bZUMvTaB1XFp4j5tZe/C4bDRaq6jXK0qUrImz4bGNcRSDbX3Z/scHOQBmp6b/vwwk v7v49VCnwbhagy2jdtmmlLwRdLDu8zLg/SI8uQiCGDcLr1o7+NnFsKS/z6qCrG9/+f5tRBZTdKI 1gnwi210Tv8tve3ZmaMggVZO0UNSuOLAOmp01jjqFjzsjAje+/dQKHQzIZW0h5lx+VjS/9fRSXx EsUfM/8YSgqMX/w5uyonaXvq1shxCbPkynJD+7bgpZP0smVGR/UY3qfvMwHpMfo1s07A1u7ebMw A0zee3/D9mn+OeTr0giAM4RRdyY6WBAnv9+J9AzcOj80DGo20os92DHNeJ+LszXNnpIkwtkaeai HLmvWyFTeTcQ77k63HKTTSg0k0Mc1NlXGF4Dd3TIJQUD6RmxH3quKrJYaNeMQO2s9d4kecdsOlV fFpUDonWiQmSXEHx56GOGiiofbaoyk0kcsWBELPEHDcIHCtzrAuWV7k7myRj/zzU1TUm+cQGVBL GvfLEBOyxPibYI2RJrZEbanqNEw9PSwh5rKCzDzCvGQ+ZXtBdloXyuNploAolEncYrfXXWy8AEk Z6ngeDrx4Oaf1VNl99iVRznWYTQl/xVh0v0Mq/FWgueWk26YVkY00Fv6Yif1UPIYO+SMauMxos7 NdnF94m10JICW1Q== X-Developer-Key: i=diogo.ivo@bootlin.com; a=openpgp; fpr=E66B7E68D62D74F357BC076506BE7C5B565EC945 X-Last-TLS-Session-Version: TLSv1.3 Commit cd004d8299f1 ("watchdog: Fix OMAP watchdog early handling") reworked the handling of the early_enable parameter and added an explicit call to omap_wdt_start() in case that parameter is true, but left the call that was previously there, which became duplicate. Fix this by removing the unnecessary duplicate call. Signed-off-by: Diogo Ivo --- drivers/watchdog/omap_wdt.c | 3 --- 1 file changed, 3 deletions(-) diff --git a/drivers/watchdog/omap_wdt.c b/drivers/watchdog/omap_wdt.c index 2482a1982c8b..e6d869e36c43 100644 --- a/drivers/watchdog/omap_wdt.c +++ b/drivers/watchdog/omap_wdt.c @@ -286,9 +286,6 @@ static int omap_wdt_probe(struct platform_device *pdev) readl_relaxed(wdev->base + OMAP_WATCHDOG_REV) & 0xFF, wdev->wdog.timeout); =20 - if (early_enable) - omap_wdt_start(&wdev->wdog); - pm_runtime_put(wdev->dev); =20 return 0; --=20 2.55.0 From nobody Fri Sep 25 14:32:27 2026 Received: from smtpout-04.galae.net (smtpout-04.galae.net [185.171.202.116]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 0022A46C851 for ; Fri, 11 Sep 2026 09:18:41 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=185.171.202.116 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1789118324; cv=none; b=rX+2FRazmaq/J7LZGw25ZCOxvvAI/Tl8BINU/quH3LA1Yu37T9kne+vlu7ZnN1svYr+6bihmkat4HzC5oxVoYRR8gkG7Ib6XvRmJTwn1uA8XmlOCLubyqDYMOw6JzkI+45GnZgWq+BzC2VH8NJx7TIYOW4p87JV2xYs9xCIMUF0= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1789118324; c=relaxed/simple; bh=JwXiDJvvKQIv9MV0uZmtmaGOF+sqPSMXOxUVlZBM3d0=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=eI1oQ4gBGWB2qdAipxF2Cx036bjdrrWt3BzSbBt2nBB6YxLmXqZqIb+B6a3vAyvZprZ6x0mEHnJRS3/84z5JYGzDEo4sNWMgEbnDnxDGR3l34DP3uwlDgXk25B4nFId6H1ABlS4lfmlTy713JJicWssY6OM6tANJaFpBWXS3krY= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=bootlin.com; spf=pass smtp.mailfrom=bootlin.com; dkim=pass (2048-bit key) header.d=bootlin.com header.i=@bootlin.com header.b=15IFO/PY; arc=none smtp.client-ip=185.171.202.116 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=bootlin.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=bootlin.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=bootlin.com header.i=@bootlin.com header.b="15IFO/PY" Received: from smtpout-01.galae.net (smtpout-01.galae.net [212.83.139.233]) by smtpout-04.galae.net (Postfix) with ESMTPS id 05ADEC653FD; Fri, 11 Sep 2026 09:19:22 +0000 (UTC) Received: from mail.galae.net (mail.galae.net [212.83.136.155]) by smtpout-01.galae.net (Postfix) with ESMTPS id 4E55A601DE; Fri, 11 Sep 2026 09:18:40 +0000 (UTC) Received: from [127.0.0.1] (localhost [127.0.0.1]) by localhost (Mailerdaemon) with ESMTPSA id C20AD11C7AFA3; Fri, 11 Sep 2026 11:18:37 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bootlin.com; s=dkim; t=1789118319; h=from:subject:date:message-id:to:cc:mime-version:content-type: content-transfer-encoding:in-reply-to:references; bh=kcsovVivfSkskH+qrQru/srukBjicvHQEB/3X3BkSK0=; b=15IFO/PY1s8WbVXRaw1MlwN/EHA6V87YyB5bJLaqTwILGJ13WuRdUxTCLQtJ0/rv0/gEed 7UhBDh6mT4evTKhJ2fh06x0ecWJa/L+fP4LavtD1opYyuWKWMtBGUER2VWgQxTuhuGeTUk bb13n3KoCylRD1oTxr3hac74z9qQw8xsAsarO6qHCl4baR33z2PCzT9zcI6BOI4ehoMdL6 Es3Rmdwt3QQD/AtAYRD/hxrUjhZIWhasY5cE1bXo6KSt6+BQCnEXfUTaRme89mSk+W7Vzs +cGdmmVzDrI3/iItkQQ9OcSljU7d2IzZahgkKZhfMyH89wacI5AiH+Vkx8WqlQ== From: Diogo Ivo Date: Fri, 11 Sep 2026 11:17:35 +0200 Subject: [PATCH 2/3] watchdog: omap: Add support for reading boot status Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20260911-omap4-wdt_boot-v1-2-637d778a4a1e@bootlin.com> References: <20260911-omap4-wdt_boot-v1-0-637d778a4a1e@bootlin.com> In-Reply-To: <20260911-omap4-wdt_boot-v1-0-637d778a4a1e@bootlin.com> To: Wim Van Sebroeck , Guenter Roeck , Aaro Koskinen , Andreas Kemnade , Kevin Hilman , Roger Quadros , Tony Lindgren , Rob Herring , Krzysztof Kozlowski , Conor Dooley Cc: linux-watchdog@vger.kernel.org, linux-kernel@vger.kernel.org, linux-omap@vger.kernel.org, devicetree@vger.kernel.org, thomas.petazzoni@bootlin.com, Diogo Ivo X-Mailer: b4 0.15.2 X-Developer-Signature: v=1; a=openpgp-sha256; l=2617; i=diogo.ivo@bootlin.com; h=from:subject:message-id; bh=JwXiDJvvKQIv9MV0uZmtmaGOF+sqPSMXOxUVlZBM3d0=; b=owEBbQKS/ZANAwAKAQa+fFtWXslFAcsmYgBqo8dnuO+8H5t1mjrBtVxWjuixihy/gr4WcRfsz FtarJ/GybOJAjMEAAEKAB0WIQTma35o1i1081e8B2UGvnxbVl7JRQUCaqPHZwAKCRAGvnxbVl7J RUomD/4+GJOqk5iHlZLw1gUn9Xj7kcA0QMEW65YtwheY1y+T0GMddDKhNmv+lL6qzT28MFs/BtQ sYsbAXdlLjYgsGjd7issx4cK/YrFei5UmXIgpSGoFF1vNCKmVTm3qIYba3pEQmF2ITZ7LNMOITg iYdYEFXBZTEJmYJY6xPHR/QCZG5+kbKeUrZUK9YPjbLteCY1XEJzAu0DYAcyQPVhNhXs62Rqz1t TJJWV5kpbwPp38l3Eh5Y7fdVx8sJr24urFvghjOreyTAPZp1a4cgL7HLQulioXDZUsSAHNmEJAK QNtN4Hl1tq1/Iyx8UFytH3RfCHkUM3fn9m8cfLsir0pZuRp3djNHl9YpfoifWScWty1bFyZda4z B4waI5f/mGNO3BrAVNvD9KBc56qnRrI/JWPmAIrmvVbpaMH0zCw9P+nbzjaX4LK5uRAfbJJJGJ8 Un/W2iIf4UDnJ2qEO3+fSk6j3vl5CxI41AE5uahahc1rqEV0g40T1wbJ+Yv7tsxjE0NcUaTqAsP BfmE2n9+TjpJqt3zYBEvznzenDIlwuP/URLwBKRiePMZW/2+kplFFijuFIaxZRLZFC51SeYIHtJ OS8PZ6kUuA1zH0Mr19nVQrl5h62oTc4g/ePdhj7rYUkydVMz97RQabyNddsGMNN+ZoeilAp4Hje 5rdlLrpjZEN1Igg== X-Developer-Key: i=diogo.ivo@bootlin.com; a=openpgp; fpr=E66B7E68D62D74F357BC076506BE7C5B565EC945 X-Last-TLS-Session-Version: TLSv1.3 Add support for determining the boot status of the watchdog. Signed-off-by: Diogo Ivo --- One case worth mentioning explicitly here in terms of regressions: Consider a machine where: - the bootloader turns on the wd - early_init =3D 0 - omap_wdt is compiled into the kernel - CONFIG_WATCHDOG_HANDLE_BOOT_ENABLED=3Dn - userspace does not service the watchdog The behaviour of such a machine up until this patch was that the the system would not reboot as the watchdog would be unconditionally stopped. However, after this patch such systems _will_ reboot since the watchdog will be kept on and nothing will service it. In practice, with just this patch this will not happen since the ti-sysc.c driver (that probes prior to the watchdog driver) will anyway stop the watchdog, but when adding the next patch in this series to stop that behaviour this regression becomes a real scenario. --- drivers/watchdog/omap_wdt.c | 19 ++++++++++++++++++- 1 file changed, 18 insertions(+), 1 deletion(-) diff --git a/drivers/watchdog/omap_wdt.c b/drivers/watchdog/omap_wdt.c index e6d869e36c43..7627d3c626c2 100644 --- a/drivers/watchdog/omap_wdt.c +++ b/drivers/watchdog/omap_wdt.c @@ -26,6 +26,7 @@ =20 #define pr_fmt(fmt) KBUILD_MODNAME ": " fmt =20 +#include #include #include #include @@ -42,6 +43,8 @@ =20 #include "omap_wdt.h" =20 +#define RATE_32K 32768 + static bool nowayout =3D WATCHDOG_NOWAYOUT; module_param(nowayout, bool, 0); MODULE_PARM_DESC(nowayout, "Watchdog cannot be stopped once started " @@ -225,6 +228,20 @@ static const struct watchdog_ops omap_wdt_ops =3D { .get_timeleft =3D omap_wdt_get_timeleft, }; =20 +static bool omap_wdt_is_running(struct omap_wdt_dev *wdev) +{ + unsigned long period_us =3D USEC_PER_SEC / RATE_32K; + void __iomem *base =3D wdev->base; + u32 value; + + value =3D readl_relaxed(base + OMAP_WATCHDOG_CRR); + + /* Give the watchdog some time to count if it's on */ + usleep_range(period_us * 10, period_us * 11); + + return readl_relaxed(base + OMAP_WATCHDOG_CRR) !=3D value; +} + static int omap_wdt_probe(struct platform_device *pdev) { struct omap_wd_timer_platform_data *pdata =3D dev_get_platdata(&pdev->dev= ); @@ -267,7 +284,7 @@ static int omap_wdt_probe(struct platform_device *pdev) wdev->wdog.bootstatus =3D WDIOF_CARDRESET; } =20 - if (early_enable) { + if (omap_wdt_is_running(wdev) || early_enable) { omap_wdt_start(&wdev->wdog); set_bit(WDOG_HW_RUNNING, &wdev->wdog.status); } else { --=20 2.55.0 From nobody Fri Sep 25 14:32:27 2026 Received: from smtpout-04.galae.net (smtpout-04.galae.net [185.171.202.116]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 2894A46A5EE; Fri, 11 Sep 2026 09:18:43 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=185.171.202.116 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1789118326; cv=none; b=m+aiYUk69icYlnv+bwklSzEYIIex4KoOBAn+Kc2Sn8G46Ct2nAY5w0G7PB4ur8i7wCZ4kYq/1ne6QG3RfH6YKTpwv2i9my022XmtHlAVww8G7LxGqC/6S66Vlqc0dmJvYFvbTIoHzqNiT8ajKE5d0TcUzMPCQ0f9b8QRX4JGuJA= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1789118326; c=relaxed/simple; bh=838xy0F9X/VK0YPmnRqJ+ttIkFXS4oj9OMQoLICoUYc=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=c4TCJjEq/BE0Axg+9aaVR/zXBlG2gSfAmvCW16uEyYVOvg46uj3r3nZh7TrcpNsKoHp0JZ+X7jAw356KXN2lDSzQEK/kRZS/0CJ6QRyYk6N8iRIch3la5nPcA/oKV/f1YFpaQx5cOnDs+dVzrJnjAYpZ5RVvSmjjyHvTQmGflM0= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=bootlin.com; spf=pass smtp.mailfrom=bootlin.com; dkim=pass (2048-bit key) header.d=bootlin.com header.i=@bootlin.com header.b=exXL670F; arc=none smtp.client-ip=185.171.202.116 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=bootlin.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=bootlin.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=bootlin.com header.i=@bootlin.com header.b="exXL670F" Received: from smtpout-01.galae.net (smtpout-01.galae.net [212.83.139.233]) by smtpout-04.galae.net (Postfix) with ESMTPS id 0AE29C653FC; Fri, 11 Sep 2026 09:19:24 +0000 (UTC) Received: from mail.galae.net (mail.galae.net [212.83.136.155]) by smtpout-01.galae.net (Postfix) with ESMTPS id 533E0601DE; Fri, 11 Sep 2026 09:18:42 +0000 (UTC) Received: from [127.0.0.1] (localhost [127.0.0.1]) by localhost (Mailerdaemon) with ESMTPSA id 96E6311C7AFA4; Fri, 11 Sep 2026 11:18:39 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bootlin.com; s=dkim; t=1789118321; h=from:subject:date:message-id:to:cc:mime-version:content-type: content-transfer-encoding:in-reply-to:references; bh=SYKJIY5q36jvMFs7Bja6orjyHSd3a65WX0v3LRrG3QQ=; b=exXL670FStLtHC7wvEfCGbEqHk8pdsjczKeUjV+37rX7w8dM/mPTTjURxXVdxxJicX3xtu BBNPbjhvcvH6HhVvROIQT0CnZLi9u8gTpCsbY4HW0tsCQzMIRKIYm0WsnjAsxS4/mSFrQG sffq6AVHuHt1of4l+oA33xFK8y3LimGukY4bz3R0vc1vyrKubyiOAY0uvWBBIr96G6n0RL RDzBh/h4FlJDY3KgWPiiJXAZlbQ7DE3hH9JJTEi6SOoJI3MXzRYvv6Cq8MT1bCh+Uo9tNT SNpTRbAWaHn2HEyB0b9ZH4QOqsyK4lyQ8OdZp/Hjuwic2/yRo/0akTnyXmslMw== From: Diogo Ivo Date: Fri, 11 Sep 2026 11:17:36 +0200 Subject: [PATCH 3/3] arm: dts: ti: omap: Prevent watchdog from being reset on kernel boot Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20260911-omap4-wdt_boot-v1-3-637d778a4a1e@bootlin.com> References: <20260911-omap4-wdt_boot-v1-0-637d778a4a1e@bootlin.com> In-Reply-To: <20260911-omap4-wdt_boot-v1-0-637d778a4a1e@bootlin.com> To: Wim Van Sebroeck , Guenter Roeck , Aaro Koskinen , Andreas Kemnade , Kevin Hilman , Roger Quadros , Tony Lindgren , Rob Herring , Krzysztof Kozlowski , Conor Dooley Cc: linux-watchdog@vger.kernel.org, linux-kernel@vger.kernel.org, linux-omap@vger.kernel.org, devicetree@vger.kernel.org, thomas.petazzoni@bootlin.com, Diogo Ivo X-Mailer: b4 0.15.2 X-Developer-Signature: v=1; a=openpgp-sha256; l=1960; i=diogo.ivo@bootlin.com; h=from:subject:message-id; bh=838xy0F9X/VK0YPmnRqJ+ttIkFXS4oj9OMQoLICoUYc=; b=owEBbQKS/ZANAwAKAQa+fFtWXslFAcsmYgBqo8dndI7vfthcnQipmbIstb83LclhanENvnfro prDo2aPB0mJAjMEAAEKAB0WIQTma35o1i1081e8B2UGvnxbVl7JRQUCaqPHZwAKCRAGvnxbVl7J RackEACEHwGC55Gljg8w26w3wryBYrIegzP+TCiAG2IyUr6biVl1gCJS7+kxKBc/bo8nvOKhOQ1 RvsrShDI1FDbvBBNLO7A2UsVfYmN4n62VYdQmazu7GP7BIsefV6IjjJK3cPj8Helhlk4u1hYclQ nrYwBXgpR/h0+3gcRXH2h4mVT6bzqpXB4DV8oQ6R7QRjylyPJ0O9Gg2yTT1dIgxBwa/tXRgFaPa nlvlNMswneWunZj1CuE7DO+j/7vWjex+WfTrM5XDfOfGxaxUcG2Xyt3Qp7BVqEyxpERfPrLtDnS qVtDa31id1f39cPgTqfdM90Ss0tSiz9nd/DMakW3ev/xE/1+RtQcEGxfj1a3Ywl3MZm2GFDrNxm KThXHCRebvFN2EzCDKqzwfRThMHxbAoZGkYj/ebUmYVom/bLUVbqtMBzlvRSj1GH/ATfVB7bEEz 3haeDtxhTFjIAStWbOg19rVIxeFVwFYISYm0h6L6oKzYcZz7NHFcwAAPWyDmIhnoyWQahsSCrpC QF/rJzQofofxr1kviF4GEQhdf1K5MGNn6teZiZYvXuxOFLpYorgucXObPXnOK5aTI0R5Rg7xaiH X2c6Fu3oJ+urfgKtqvHChuqz4TaCiOIwuPXFt6VOWngvekVtglejxuHWhae24HoZV1MP04wSiEP ZUs+sQqJ0CYNspA== X-Developer-Key: i=diogo.ivo@bootlin.com; a=openpgp; fpr=E66B7E68D62D74F357BC076506BE7C5B565EC945 X-Last-TLS-Session-Version: TLSv1.3 Currently the ti-sysc driver resets and idles the watchdog when it probes its target-module node. In a system where the watchdog is being used to detect a faulty boot this makes it impossible for the watchdog to do its function, in an unexpected and time-consuming manner to debug. Explicitly mark the watchdog node with ti,no-reset-on-init to prevent the reset portion from happening. This allows the watchdog driver proper to maintain the watchdog running. Signed-off-by: Diogo Ivo --- The ti,no-idle property is deliberately not added to minimize the possibility of a regression on systems that were relying on the ti-sysc driver disabling the watchdog and did not service it. With just ti,no-reset-on-init we get a 3 second window for the watchdog driver to probe and maintain the watchdog alive, otherwise the system will behave almost in the same way as before. The only difference comes from introducing the small 3 second window that could lead to a watchdog expiration on syste= ms where the watchdog was being stopped right next to its expiration, but that risk is much smaller regression-wise than always keeping its boot status. If this approach is deemed appropriate this patch should be mimicked in other TI SoC's with this watchdog. --- arch/arm/boot/dts/ti/omap/omap4-l4.dtsi | 1 + 1 file changed, 1 insertion(+) diff --git a/arch/arm/boot/dts/ti/omap/omap4-l4.dtsi b/arch/arm/boot/dts/ti= /omap/omap4-l4.dtsi index c1afc49f456c..eb0e10e51ba4 100644 --- a/arch/arm/boot/dts/ti/omap/omap4-l4.dtsi +++ b/arch/arm/boot/dts/ti/omap/omap4-l4.dtsi @@ -1126,6 +1126,7 @@ target-module@4000 { /* 0x4a314000, ap 7 18.0 */ , ; ti,syss-mask =3D <1>; + ti,no-reset-on-init; /* Domains (V, P, C): wakeup, wkup_pwrdm, l4_wkup_clkdm */ clocks =3D <&l4_wkup_clkctrl OMAP4_WD_TIMER2_CLKCTRL 0>; clock-names =3D "fck"; --=20 2.55.0