From nobody Fri Sep 25 14:32:37 2026 Received: from mx0b-0031df01.pphosted.com (mx0b-0031df01.pphosted.com [205.220.180.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id C0DFF435A9E for ; Fri, 11 Sep 2026 10:29:50 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.180.131 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1789122592; cv=none; b=NeALBmHL2xFFyfc8C+f2M+DurkxM8JaulrDjh91ElaXR9yPYr77dE5Kp9B2u1pCI95k1vXyQLfhSBH3rLoa3b4Mb1lq7VVwuL3Kej7VHgXDcY0IfGpwYFAC7icq8eFalAsi67VF97WCelqS13oP4Ay0GDLkWDHd8QJ8xgZRYOE0= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1789122592; c=relaxed/simple; bh=ZG093MO2ef10q/LWPvFaNq71LX74/rGkq31nYz5GUvY=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=tNYrgFf4uJFL5STZrXuQXCbYMvqdN8axdNlyOA6lTBeMEwIKmCl2K8nDAVfxQvVBX23X7jMcdInJJXmwLFT9k1rLaCi6rE4vajiqybOh1WeeERN0Ear7q8jpjdHdIYwH8S8IT5U+UoVi2DQ6zG5cLccaQwpuijTd/sYf8RwDG3I= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=I/DZKTDj; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=RurVLEC8; arc=none smtp.client-ip=205.220.180.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="I/DZKTDj"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="RurVLEC8" Received: from pps.filterd (m0279869.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 68B7kqcN3845456 for ; Fri, 11 Sep 2026 10:29:49 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= 89kOUuqbTMD7KBwxWQmwEktFk33uBWpQA+q0IsoXFqk=; b=I/DZKTDjmhSTvIGb QsmmmXilwWEUyUu6wBHwE/SOfshnkJ36+XtfmYcYVHn7UgJvhotzwLZD5ECiKj2l 58m+EmCH06BJoRrdoKkfxH3p5CkpPu+t1sunbS5YbsWbskh9tr/q53JXe60+jHDo YsObcHE8lhTniLTbYWm5493BlwYvXVvtwHgq2WLq+7s8rdIbvFPhI6Q+HAzDPADh UL1FvarMYGQLUdU8hAtZHZ7Y0AspUrRsr1ygS/zBArOaIJDFZ7mynW2x7fGwLd4P JlZXfMyPfJohbxq++WQ70Z9j6fzELh5TOCCbIen/N/0ZyFgeljEbrFM12o2PopGk X244Nw== Received: from mail-qk1-f197.google.com (mail-qk1-f197.google.com [209.85.222.197]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4gm5q42dsd-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Fri, 11 Sep 2026 10:29:49 +0000 (GMT) Received: by mail-qk1-f197.google.com with SMTP id af79cd13be357-9382f9430deso132879285a.1 for ; Fri, 11 Sep 2026 03:29:49 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1789122589; x=1789727389; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :content-type:mime-version:subject:date:from:from:to:cc:subject:date :message-id:reply-to:content-type; bh=89kOUuqbTMD7KBwxWQmwEktFk33uBWpQA+q0IsoXFqk=; b=RurVLEC8mDTiYLe41X7fC0AXWojGwrFjt7/GYSwKB4P7jcj8w3mNeROOHbes3u8NUJ yxVmlY6s+tCiZiJLLEqgIU+8iVhlwaI2UuLEpgyETE0hkKZJj6cqgZbWabAP5Ub4QJ2I wpymdWj0aP7rHS71yJhA6nVB16YFaL+Mpj8zWkpAg+qagkNDNKQ/wXwz7mSxuwamdcjX DyndvviL1hakeVsIZdrXXdMlx49ti38b5ZC2gVh3o1ZfAAWof2z/ZRcsYAQ1/SdCWN1G xaycXFvd4pgUF0nfXG5WPnX548t1k/q+lM2QfX9Rdbhjql+42Pw7vg+HUCTDL4xBYe0c yR7g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1789122589; x=1789727389; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :content-type:mime-version:subject:date:from:x-gm-gg :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to :content-type; bh=89kOUuqbTMD7KBwxWQmwEktFk33uBWpQA+q0IsoXFqk=; b=Rf+zPBcgvaMrDxRwlmM3U2um9dVvZXEP7zKJCArF7qxGa8cn3c9hYcpqEkBDRccZVh qicblr8p5Lxj3k1S0A/9Qa9DuF0uV2ys7HDIID0nFRtgfApl70BwlUbmTe1pMSkNt197 tnMZCztZU7LWNZXG3QhKl28ugJtb80T/EILOvOM/sdE2smr6qOc/kiHg4e5vwJHMEIPQ t3hHnHuoR7AMcZVrO4tAKbaNDXvWm7hK9MH9VoMRkGWtaM0/We9TE6Z5BuS5EPXOHYTs nq4tVMTeds5ped+TSynv12+KVwJWfX+oQSYesMlTujmtw8dWPo+o3i60G/tLeLWCGo2R LB9A== X-Forwarded-Encrypted: i=1; AKwUvBx9oeMZ4H6PUfUJWhRcLoQAAtf5UipaJWMnfu2UzS+yUU+rMbb4NOOy88EpF2UKAsu7c+x0JMK3FLYYskA=@vger.kernel.org X-Gm-Message-State: AFuF++kQJyJIl26nD2z9axc9mmG+gaaHlqsYjlI1NMfrLXG1YUM1jbDP 8xOdHlDQv3WkABDH5ru/2gRglMVO7HP4xiBw5osNoTJ9oqV2IZx2sHNcpqCOc8yfKq2A57ydCXP C3ESdg+4toJ198AT8ZVkUIFaD5SKtEARURLWxTDoDGMVKEy3B4Kxn4xTRMHZ9Vh9/Ixk= X-Gm-Gg: AYBFou0z+BrfR9giJHp89mc5IJEQslawWHfxvccbmq6Rt2ZQzDVcF8ajqS2hYGt4kTH bcUSw98yZeXMz0Tnyej+egljl53PkxxRjgPSdLEEc707XwXb4u4MIaCyCAJ8cikFgo+73IaeQt+ 5+HzqC4fd38W7cHAJ+bfu/WB49y18tYMoWXyUDXO4zzICkB4Dy1/U+3pB0BvrILUWqy06LqXaxB xewY7T915yRX8EGuL7CORn9MJeaHO4wCAcbmfPBaxi9WVRs0QCuzkjj4ghyu2HNfVEFBwi/4Yo5 yhXrU+pPdIVFyrbv4YFAEafyXrE0w8QhS6Dbv3dydapr+u16K15kh4JhTyYXZARgULqMIjcBosZ aexVENXl8BAgALxGwmoBQS4I= X-Received: by 2002:a05:620a:2a05:b0:939:72ae:e536 with SMTP id af79cd13be357-939ea08d7f4mr427003585a.13.1789122588916; Fri, 11 Sep 2026 03:29:48 -0700 (PDT) X-Received: by 2002:a05:620a:2a05:b0:939:72ae:e536 with SMTP id af79cd13be357-939ea08d7f4mr427000585a.13.1789122588563; Fri, 11 Sep 2026 03:29:48 -0700 (PDT) Received: from [127.0.1.1] ([178.197.219.214]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-49e61a81943sm38651965e9.1.2026.09.11.03.29.46 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 11 Sep 2026 03:29:47 -0700 (PDT) From: Krzysztof Kozlowski Date: Fri, 11 Sep 2026 12:29:34 +0200 Subject: [PATCH v4 1/7] drm/msm/hdmi_phy: Cleanup after msm_hdmi_phy_resource_enable() failure Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20260911-drm-msm-hdmi-fixes-before-eliza-v4-1-87bdb9f1987f@oss.qualcomm.com> References: <20260911-drm-msm-hdmi-fixes-before-eliza-v4-0-87bdb9f1987f@oss.qualcomm.com> In-Reply-To: <20260911-drm-msm-hdmi-fixes-before-eliza-v4-0-87bdb9f1987f@oss.qualcomm.com> To: Rob Clark , Dmitry Baryshkov , Abhinav Kumar , Jessica Zhang , Sean Paul , Marijn Suijten , David Airlie , Simona Vetter , Archit Taneja , Maarten Lankhorst , Maxime Ripard , Thomas Zimmermann , Rob Herring , Krzysztof Kozlowski , Conor Dooley Cc: linux-arm-msm@vger.kernel.org, dri-devel@lists.freedesktop.org, freedreno@lists.freedesktop.org, linux-kernel@vger.kernel.org, devicetree@vger.kernel.org, stable@vger.kernel.org, Krzysztof Kozlowski X-Mailer: b4 0.16.0 X-Developer-Signature: v=1; a=openpgp-sha256; l=1590; i=krzysztof.kozlowski@oss.qualcomm.com; h=from:subject:message-id; bh=ZG093MO2ef10q/LWPvFaNq71LX74/rGkq31nYz5GUvY=; b=owEBbQKS/ZANAwAKAcE3ZuaGi4PXAcsmYgBqo9gQpFoZjDhMzPsUy+LdmdzrFOl71cZhEMXi1 mgUxSmEFceJAjMEAAEKAB0WIQTd0mIoPREbIztuuKjBN2bmhouD1wUCaqPYEAAKCRDBN2bmhouD 15LsD/4/L0NDXHF/U4+guLhfAlcFLxQHsCCkbhDa9SOS7C/sitVrIcbNTbKbx2SaBDKTzOIw2Vt 7fBhdDez23YI8P6u/LyNQl5OOzReoKr4QHgoiJznFhA7kDD5g7uivqKOQk5gLtoUzdC2v4LhDvN bc0kf+BHkLPNrtZjXxnHrbai3byrm3eG0S2uSximL2J2iBxbw20Yq/Al/jaFyzp/RoTBBfqcpRp G2lRAzNdW6oTkplvqMfsArEIpSBhxhUefh9HTMwcQ6GXzuMpJTZt2xhF9lzWMIevTQ89wn/p/px lOGDeaCXHXkVVdyoGglrP1wZFoiPDRfXqtP84gsD97V1+InM8iel/9wAyhFzq+DoSxs4YoagUbE UVKdtRU8cyWu94bEJVIUq+PqsIm/j2xtl68qOyLls03WVMFf7fhz3yx9kxzytJJGymPrb6p3w+z qkgL4q007YVdg9DnaEjPnogP59GM6b8ftIaUTEDU2lb9rhv447d2EyqHriIqarFmqWJOPqbjikr Sc2Ich4Mekhl6pe0ih/foIR/m5gAB/D5s4W+gFOe2wRxaEso3MyWe+Nglgdgg4zcNX1g1v3JRsN PHpj53uzFB3laL/R+BBF8EtRVZANl365wFnxP31ti6FZhX8VMSzrLPLxhD6R7eMzuIbQJJYKx+T yaZAFMi7MQwvBZw== X-Developer-Key: i=krzysztof.kozlowski@oss.qualcomm.com; a=openpgp; fpr=9BD07E0E0C51F8D59677B7541B93437D3B41629B X-Proofpoint-GUID: z4ycgNt-r7whhlz3IY2rHU44QAePPR7S X-Proofpoint-Spam-Info: AW1haW4tMjYwOTExMDE0NiBTYWx0ZWRfX/ZJ82SajlW1D X/JmlkfWYyKKY+Jm8nAjKn4y2Izjdmgekk1CxQ4kMqRM/HjA9JR6ktpxsMv8dnAT/57iCulW1vn ODnPMUpJ6PfsKqLVf11Q3jffyQLZVNU= X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwOTExMDE0NiBTYWx0ZWRfX8/+rfBa1gyh7 HPE8HcvTvRxFhfsy+VOiliBD1AtxBz/zMTAKfkq/T9Q7tzjLSrP6HvAH9xNYuejF1v5A6wXy8wM iZ0HCjgficLIVBr+59mcMpBaPo24bPsbrj9D4MTcn7jkWTDv8w6TdCZpf/7pXO2hTgvzUnOCDaI fN8jilTv0sg0maH4BkwrIZqrRnZf79KkCinAxIbAYHrLvcjsgElKSUI0X8ExzVkxZV1xE5guSdx yS5A7hDCrV1Ac4MIFR/mM08TC2mT7Q3pyBz6pRvI9nbeBS5PhV9eNxVzBLmgoOlTaabeMcWA/jE e/yfrx4RjVjBPcdkA5a3r3hYx69p/8EkaL4ftadlNSURdSKhPMOnfHrHXUDEshakIxumEbGRazn TbeuASQiFEGDJl+c82EDZc/03LviT6bJ77CVxsNpk1tbA4UCFFKOAr/V9KkQz7/61KNNXKDYh9N Z87CAhWfeh8eQbkkXRw== X-Proofpoint-ORIG-GUID: z4ycgNt-r7whhlz3IY2rHU44QAePPR7S X-Authority-Analysis: v=2.4 cv=Wsa+otfv c=1 sm=1 tr=0 ts=6aa3d81d cx=c_pps a=50t2pK5VMbmlHzFWWp8p/g==:117 a=+bKQE0WJfmhK2875HamI0Q==:17 a=IkcTkHD0fZMA:10 a=VdqzKS8jKosA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=_glEPmIy2e8OvE2BGh3C:22 a=VwQbUJbxAAAA:8 a=EUspDBNiAAAA:8 a=bp1g5Iz1D7c7guLF1_8A:9 a=QEXdDO2ut3YA:10 a=IoWCM6iH3mJn3m4BftBB:22 X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1176,Hydra:6.1.134,FMLib:17.12.100.49 definitions=2026-09-11_03,2026-09-09_02,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 malwarescore=0 lowpriorityscore=0 priorityscore=1501 suspectscore=0 spamscore=0 bulkscore=0 impostorscore=0 clxscore=1015 adultscore=0 phishscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2609040000 definitions=main-2609110146 If msm_hdmi_phy_resource_enable() fails, e.g. when enabling regulators, it should reverse the state of things already changed. msm_hdmi_phy_resource_enable() is used also in probe path, thus such failure, which could be simple deferred probe, would leave these resources permanently enabled for the rest of the runtime. Cc: Fixes: 15b4a4523859 ("drm/msm/hdmi: Create a separate HDMI PHY driver") Signed-off-by: Krzysztof Kozlowski Reviewed-by: Konrad Dybcio --- drivers/gpu/drm/msm/hdmi/hdmi_phy.c | 16 ++++++++++++++-- 1 file changed, 14 insertions(+), 2 deletions(-) diff --git a/drivers/gpu/drm/msm/hdmi/hdmi_phy.c b/drivers/gpu/drm/msm/hdmi= /hdmi_phy.c index eb1088755cb3..15e37596bdb1 100644 --- a/drivers/gpu/drm/msm/hdmi/hdmi_phy.c +++ b/drivers/gpu/drm/msm/hdmi/hdmi_phy.c @@ -67,16 +67,28 @@ int msm_hdmi_phy_resource_enable(struct hdmi_phy *phy) ret =3D regulator_bulk_enable(cfg->num_regs, phy->regs); if (ret) { DRM_DEV_ERROR(dev, "failed to enable regulators: (%d)\n", ret); - return ret; + goto err_pm_put; } =20 for (i =3D 0; i < cfg->num_clks; i++) { ret =3D clk_prepare_enable(phy->clks[i]); - if (ret) + if (ret) { DRM_DEV_ERROR(dev, "failed to enable clock: %s (%d)\n", cfg->clk_names[i], ret); + goto err_clk_unprepare; + } } =20 + return 0; + +err_clk_unprepare: + for (; i > 0; i--) + clk_disable_unprepare(phy->clks[i - 1]); + regulator_bulk_disable(cfg->num_regs, phy->regs); + +err_pm_put: + pm_runtime_put_sync(dev); + return ret; } =20 --=20 2.53.0 From nobody Fri Sep 25 14:32:37 2026 Received: from mx0a-0031df01.pphosted.com (mx0a-0031df01.pphosted.com [205.220.168.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id E626B43E9D5 for ; Fri, 11 Sep 2026 10:29:53 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.168.131 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1789122595; cv=none; b=QLKaSDvghl7O9eMJnlO7ZIq68UKwnZEOCUg/9Y999bQT4VftoeEDbgEN1UEOODGpMcHIkhy0rZF7owhCwRr1yEAzpf7dMwVet/hh2hjyvmQPjdl+qQsCSW2q4VgT69QNzDcgmFUQVB9h11O6MQOvgS38kbaKuAaWSKr1oKAY99Y= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1789122595; c=relaxed/simple; bh=gCPjQLee8IZ6ZI1o3PKvV9FFsQQqDDwLDIvAlHVSnmc=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=W56uv28wR6NeGpgK1cgQLx3rkfZwlcgrOHvVNfWG+cn6Qi2wZc74jMBnQ0pnXWBdUnWZJRhNcB/HAiOFGcdQt4vXBfe2GJj/lRqAERBChlm4XuVhmcTUbZMfdUUTxK4Vw3+dQ+pDkobaxY50ZQ2Ve6vfchaJIBfALVcVMXho1Oc= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=DJ7JxI8d; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=GIRzgTLG; arc=none smtp.client-ip=205.220.168.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="DJ7JxI8d"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="GIRzgTLG" Received: from pps.filterd (m0279866.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 68B7kafV2801755 for ; Fri, 11 Sep 2026 10:29:53 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= HH0NlUkAHggOm55GmMCsiEP7bNk66V1yTa1Hyg0NTUI=; b=DJ7JxI8d/CYTDOCk h3XPeU/Vt9kTF0Ban3/fyGI8v+8G3Ee99q4z4RXS0tKm3WnjI0dzL8fUL/ywhviu ceS8k8+WpGiC3/TrOHnI6w6HAztiA1kBTFarjVYYW1HjGsMG6eAvg30r8TLwZDjv 8DC9KkWrsExoIaZsmM5bmhwmMO8nqr3JJwW6kjlvhV7P6cicnQvfAfONQlfTBaYG qV8FZAgSecDP/M2XUJy4CQg2Xu5cDHxxJ6yJKVQxBN5DOrrpDKmWb1I0iHrFS/jh Nv19OELvmyYg9z/hrtFHX3zyVu6MO5p0ouzwNOEe+b5Q2tXWuSh32KSxP9b5aDgs uQ+UlA== Received: from mail-qk1-f198.google.com (mail-qk1-f198.google.com [209.85.222.198]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4gm729j45j-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Fri, 11 Sep 2026 10:29:53 +0000 (GMT) Received: by mail-qk1-f198.google.com with SMTP id af79cd13be357-934956beec8so130141285a.0 for ; Fri, 11 Sep 2026 03:29:53 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1789122592; x=1789727392; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :content-type:mime-version:subject:date:from:from:to:cc:subject:date :message-id:reply-to:content-type; bh=HH0NlUkAHggOm55GmMCsiEP7bNk66V1yTa1Hyg0NTUI=; b=GIRzgTLG7AsA9tgUdicb6n0hiGtPu2uzBhyV4Tg7HJkJWO9KrtucEUmG4yS9M59Yhf 9uXQzCXVTZ0bObmTiSXygVgj1PO231RH/7BZdNYVj8mNrONzptRnkgQ/Mbe/fK52Hj75 qa/G+fsD+9zzirfPSAE2NtOfG2yyI3EOFxM3gVHuGyZKylfyM6/wfCXLIuu3TzZO0buS K4IgTM8UzOaPI1+P+fySaqqFIHBwuK/qcc5SiC1JvsgRS1w2OhTipvpH913HMiAGdS9r 2wG9KkCBhoglOSKTc+ZSfwji8PP+gTG7UruItpmlRgwa6WHvr4+jNwp2DGr0X1D5KCrQ vMgQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1789122592; x=1789727392; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :content-type:mime-version:subject:date:from:x-gm-gg :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to :content-type; bh=HH0NlUkAHggOm55GmMCsiEP7bNk66V1yTa1Hyg0NTUI=; b=jWz06ck0QJ4XX8KbvjM909qi5My9Hrr8hEK+fSib8yKVOVcage3Plrtx6zX1iT0KmF SQ+LEOWmGeD9Hw4zxO5+F3Pxkj6CgeLgQCcWTPFTDUiQ8NKALjXZxzVzdbBCDiPaFApr 9CN2l1JIBq8sbJjAvKmP+EINoH3zUNNA+wzq6K+DbTPHawt2kqyu9g3QiB3tvBVcUD9y CidEyGuW22KcOhxxb8VN+SQzBSZUy96829EZ1AzQWV6KWYlNqhRxELf6ids2u7tIjVI/ Q/fJUtcqKKIXeUDoFZKP8qpHrV/7+HmOCchVeocDHGFCmPKkXWt41fIW2BXLgFchKT93 VNxQ== X-Forwarded-Encrypted: i=1; AKwUvBzwF0lmmZSmvWaA7TkBqM2y++8VevQ1GyeDBX4NcJQu36s0yhV5kwI4mWMRaDvUBiZtR/f97msIc3dGbYs=@vger.kernel.org X-Gm-Message-State: AFuF++nJBUlCQ2Dcm4gbXr1uxfbMCufpuSaiDekU8KM+ScM8kOIRs6gV 33r/7unEWTJQ0trdKfdzppcExwJUWunjxi74TRak15lb2bbtvxiqKwX1tAGt3ERf6ZV6mMR+BpG 9aKu5I3UV9Y5v27SyC5Q4FJfqGgPsryCcaXqS/1RwZCwXwfCkPI72KwI2p+DwlgyeYMY= X-Gm-Gg: AYBFou2m4wr/w+Li0vAncQII50I/RYUYFwmRJYNUbS/eI0z0SfVjgehyv51hqNlB5Ar p543FUPxdQfwjChSzGgMhaYuTZJYfbtP1ytllNUJYnWVyWe0Sg0fBroo1Gj0YnynvAxvVwLSnFt KFUShqdBRAAmIv6AneUfs0cK3HQjVWoxqC/i0gFY7zzrqk6u+qLa7t9nhHIFHKJ91WcHTpGADdU tZstyKHvS2rrAVCGlVdl5p3px/Slml9OE2b4dizudln1+SHXIXo2PP3p97+SqlufLw1aBdplhx8 87NjmiMqiwiqTYCyn7z/4Nr0JtyRWr9h03eJY8dIlb0BwO/LetGRSM8ryXfJOAyzKwSFGLQPS3V OZQQch+JNArXoyUV8f10znE0= X-Received: by 2002:a05:620a:17a8:b0:939:9a09:6009 with SMTP id af79cd13be357-939ea22929amr417774485a.33.1789122592223; Fri, 11 Sep 2026 03:29:52 -0700 (PDT) X-Received: by 2002:a05:620a:17a8:b0:939:9a09:6009 with SMTP id af79cd13be357-939ea22929amr417771685a.33.1789122591779; Fri, 11 Sep 2026 03:29:51 -0700 (PDT) Received: from [127.0.1.1] ([178.197.219.214]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-49e61a81943sm38651965e9.1.2026.09.11.03.29.48 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 11 Sep 2026 03:29:50 -0700 (PDT) From: Krzysztof Kozlowski Date: Fri, 11 Sep 2026 12:29:35 +0200 Subject: [PATCH v4 2/7] drm/msm/hdmi: Handle msm_hdmi_power_on() errors during .atomic_pre_enable() Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20260911-drm-msm-hdmi-fixes-before-eliza-v4-2-87bdb9f1987f@oss.qualcomm.com> References: <20260911-drm-msm-hdmi-fixes-before-eliza-v4-0-87bdb9f1987f@oss.qualcomm.com> In-Reply-To: <20260911-drm-msm-hdmi-fixes-before-eliza-v4-0-87bdb9f1987f@oss.qualcomm.com> To: Rob Clark , Dmitry Baryshkov , Abhinav Kumar , Jessica Zhang , Sean Paul , Marijn Suijten , David Airlie , Simona Vetter , Archit Taneja , Maarten Lankhorst , Maxime Ripard , Thomas Zimmermann , Rob Herring , Krzysztof Kozlowski , Conor Dooley Cc: linux-arm-msm@vger.kernel.org, dri-devel@lists.freedesktop.org, freedreno@lists.freedesktop.org, linux-kernel@vger.kernel.org, devicetree@vger.kernel.org, stable@vger.kernel.org, Krzysztof Kozlowski X-Mailer: b4 0.16.0 X-Developer-Signature: v=1; a=openpgp-sha256; l=2516; i=krzysztof.kozlowski@oss.qualcomm.com; h=from:subject:message-id; bh=gCPjQLee8IZ6ZI1o3PKvV9FFsQQqDDwLDIvAlHVSnmc=; b=owEBbQKS/ZANAwAKAcE3ZuaGi4PXAcsmYgBqo9gRkXjI/OEtozReZDeGIxNSRVYnBNLuVDYf2 /ZVngtGyFeJAjMEAAEKAB0WIQTd0mIoPREbIztuuKjBN2bmhouD1wUCaqPYEQAKCRDBN2bmhouD 16cRD/sG7tWVhlh4K+dM3uTjagd7MjwoUd5+LK3+h748V4YfkAkWQ1KjKU0zdiH149YAjT5unRr d276FHxWWUtKrbYBnYO6VgdTVxNpLtJgIQ7z6XxkC0L63AgIwRcbybPe9JmZCxAe0iKa010yYUO R2HqvL3s93pOmGYGJpTS0Mprn7vXJW6MOMaeEG3hMjo9QIV7+2q+ghbzHFt8C0Xrf6UqpqX57ev e/GTTTWuSw5yxLDp6T1/CKjGdIByxbbli8F3yGkr13Cd7uEJGavLV78Tn8pLIU9jXpFxNZNyg5X any0DeWtC6WMNi+pUaHvAV1HDPMW35bwN7tNWEhVVw//mZrSjyo4aFRZ2ppTmt9eZQCG2yqf39G fttE5Mhlg/bTuQSMMFkJsJR09QhXkFYm9AAU9HItikZxropRdK9CG30pisSAIpJWJGAi/ZAoUl/ CyVEvpvjOIJUZySzFdGdptEpCQUYdeASISLYjgbG0iydLDAjMLc0x1uW5qhLVPg2TMQHE+0ccVX opoRAbJw2ykVwTOpf01GE8HJWA6WwAfyg1+mTfnZjWmYIOUgjxtzk/aLFnEozHTB2beRJIdEsAP L0W/XGgb9kYUpha1Lg6al1zfrJILjxyhvLOA4dG8LQVrS6EaSJgiXt4hLMlVu5HXVilf98cIWFS hDCRNBJPVxaMpZA== X-Developer-Key: i=krzysztof.kozlowski@oss.qualcomm.com; a=openpgp; fpr=9BD07E0E0C51F8D59677B7541B93437D3B41629B X-Proofpoint-Spam-Info: AW1haW4tMjYwOTExMDE0NiBTYWx0ZWRfX+volbFYrcthI Ynk1t+l6b0Qk6oIW2GxJ+IEaL46VUA2ofojMoT7jX6vuLO++udanr3CsTgyjTUQFYFf3hp4XRAk HTHtXnx/5cY/j3W4aHAZIPVTpNgnxSI= X-Proofpoint-GUID: 6jIO05-1p_Z-sORJWHlT9DVb8Dcm8Ze7 X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwOTExMDE0NiBTYWx0ZWRfX8FkzG+tlhNlL 11I5JbtqXhKJJE4jNUmsYRh42O4yrmvTUgutTtaFHRydWR03ycG8HU9Xcsnfbefcj9uYOwrkF4d ul67a28YKtxLSnupnHjDKT52MhzxP9xwo2qN2G3Om3cAZudbQrrKTYtZStGKB3UXqy8jgWzJvMZ S3slDL0hp5Ufc1hLLPasXi9Ux6vucyOaHpH88RisFVKYstrYA9XLSplhajMBJMJSBY2KOYbf74+ 1qkTkUobti++APAt6cLVh6PQhp2eSLXZ7JKX+REkTgc9OVzu3hU2ucOP3C3nH8S3HfkIN9pNwuw +Ln22b0nMHQBnMpN0cuiKXA3Z4moAXlz1W9OxAo5CA8KeNnVr4MC25lkB7Y8GgComSm7TIQlyAg wENVwsIeZznPM04sIBm2BkXzJ+CzDS4vLP9GGIGbFoPjP0HYWGxDSVKmvECpX5RSaSYRD0RPq5r YEVLSLnPVhX8A13QjBQ== X-Proofpoint-ORIG-GUID: 6jIO05-1p_Z-sORJWHlT9DVb8Dcm8Ze7 X-Authority-Analysis: v=2.4 cv=AfwkjHXG c=1 sm=1 tr=0 ts=6aa3d821 cx=c_pps a=qKBjSQ1v91RyAK45QCPf5w==:117 a=+bKQE0WJfmhK2875HamI0Q==:17 a=IkcTkHD0fZMA:10 a=VdqzKS8jKosA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=YMgV9FUhrdKAYTUUvYB2:22 a=VwQbUJbxAAAA:8 a=EUspDBNiAAAA:8 a=IzbfGf_HrtPdoiX6LZ8A:9 a=QEXdDO2ut3YA:10 a=NFOGd7dJGGMPyQGDc5-O:22 X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1176,Hydra:6.1.134,FMLib:17.12.100.49 definitions=2026-09-11_03,2026-09-09_02,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 malwarescore=0 adultscore=0 suspectscore=0 phishscore=0 lowpriorityscore=0 priorityscore=1501 impostorscore=0 bulkscore=0 spamscore=0 clxscore=1015 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2609040000 definitions=main-2609110146 Properly handle power up failures during .atomic_pre_enable() by aborting the .atomic_pre_enable() to avoid accessing registers why blocks did not bring up. Otherwise this could lead to imprecise aborts when accessing MMIO while entire power domain is off. Cc: Fixes: ba3d7bf3a7ab ("drm/msm/hdmi: Convert PHY files according to new desi= gn") Signed-off-by: Krzysztof Kozlowski Reviewed-by: Dmitry Baryshkov --- drivers/gpu/drm/msm/hdmi/hdmi_bridge.c | 30 +++++++++++++++++++++--------- 1 file changed, 21 insertions(+), 9 deletions(-) diff --git a/drivers/gpu/drm/msm/hdmi/hdmi_bridge.c b/drivers/gpu/drm/msm/h= dmi/hdmi_bridge.c index 157f19bd90b4..db85400e574e 100644 --- a/drivers/gpu/drm/msm/hdmi/hdmi_bridge.c +++ b/drivers/gpu/drm/msm/hdmi/hdmi_bridge.c @@ -13,14 +13,16 @@ #include "msm_kms.h" #include "hdmi.h" =20 -static void msm_hdmi_power_on(struct drm_bridge *bridge) +static int msm_hdmi_power_on(struct drm_bridge *bridge) { struct drm_device *dev =3D bridge->dev; struct hdmi_bridge *hdmi_bridge =3D to_hdmi_bridge(bridge); struct hdmi *hdmi =3D hdmi_bridge->hdmi; int ret; =20 - pm_runtime_resume_and_get(&hdmi->pdev->dev); + ret =3D pm_runtime_resume_and_get(&hdmi->pdev->dev); + if (ret) + return ret; =20 if (hdmi->extp_clk) { DBG("pixclock: %lu", hdmi->pixclock); @@ -29,9 +31,14 @@ static void msm_hdmi_power_on(struct drm_bridge *bridge) DRM_DEV_ERROR(dev->dev, "failed to set extp clk rate: %d\n", ret); =20 ret =3D clk_prepare_enable(hdmi->extp_clk); - if (ret) + if (ret) { DRM_DEV_ERROR(dev->dev, "failed to enable extp clk: %d\n", ret); + pm_runtime_put(&hdmi->pdev->dev); + return ret; + } } + + return 0; } =20 static void power_off(struct drm_bridge *bridge) @@ -287,13 +294,18 @@ static void msm_hdmi_bridge_atomic_pre_enable(struct = drm_bridge *bridge, =20 msm_hdmi_set_timings(hdmi, &crtc_state->adjusted_mode); =20 - mutex_lock(&hdmi->state_mutex); - if (!hdmi->power_on) { - msm_hdmi_phy_resource_enable(phy); - msm_hdmi_power_on(bridge); - hdmi->power_on =3D true; + scoped_guard(mutex, &hdmi->state_mutex) { + if (!hdmi->power_on) { + if (msm_hdmi_phy_resource_enable(phy)) + return; + + if (msm_hdmi_power_on(bridge)) { + msm_hdmi_phy_resource_disable(phy); + return; + } + hdmi->power_on =3D true; + } } - mutex_unlock(&hdmi->state_mutex); =20 if (connector->display_info.is_hdmi) msm_hdmi_audio_update(hdmi); --=20 2.53.0 From nobody Fri Sep 25 14:32:37 2026 Received: from mx0b-0031df01.pphosted.com (mx0b-0031df01.pphosted.com [205.220.180.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id EEF8843B3EF for ; Fri, 11 Sep 2026 10:30:06 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.180.131 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1789122609; cv=none; b=uqnsEKsD6Dd8Ap9Pq1kjC8J+O13aAsMKlRxnQmPIH1Watu7ieR2ihA/cu9mmyNY/a3uNKYcuHNdERouhOJrxjFMkdrj9R6iYSf4oHg71RTbg+j8CEbQdV9v5jrlXhPrh1ik1Zo2uICp+RekEDpWHniijF3LzNF0m/xiuTC2MCgE= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1789122609; c=relaxed/simple; bh=XH66GnTgugpnLWEqmx30iK26F7dqgoZ1zE1rBdQ5ZS8=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=fs/KlrqTW0iUBmdXzrClTZ8stXiOsAaB2KNP6fso7TrAqW9dZi7csHvts+OSPSz9rpSpyZWzxgpGpaVeHcE8TN7+D4USXrU7quKgmwF76XiANCul2s8enTU3Q26Q9pcd3Qo1LYoUqhV3y5r+QYT10VZyNT3WT6ghf+O/+tIcEuM= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=CSMZJ8lR; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=NrcuPs5n; arc=none smtp.client-ip=205.220.180.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="CSMZJ8lR"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="NrcuPs5n" Received: from pps.filterd (m0279868.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 68B7kjVP3366323 for ; Fri, 11 Sep 2026 10:30:05 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= FSrRHRs+USEOkCNabKEpUzOvaX+AzMaMbvbk8haZkZI=; b=CSMZJ8lRNYF1d4T7 b4DjaqBMCmjhAQ37Z4kw9QixzrdDa0KAJ55mssNCmxs7JVhCr9WRHeNvQWGfFQMP RXyip6GlhwYIMbE46SvRI7QQoH5VABVivDtq6zNnP4wBVmQKRfyYC9XhiwSGk+QB v1p+Q42/u9baFXLSz08tA7zW7ebs3UQaNCKY91HEQMcuqePCEighyX7Qg+zf/DHM vqVyImfaOcqbrSoQhuHQNEZwIJIf09Rdj68WdnRTicrbthUNrD7sbddEsvrJviId yOPKSIOS03GVGPOV0rIWl5ydPSf+I7wNVe0GidunuC2nn0O8i7h4cJMhRt27+9q4 cwDw7Q== Received: from mail-qk1-f197.google.com (mail-qk1-f197.google.com [209.85.222.197]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4gm1k2bcgn-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Fri, 11 Sep 2026 10:30:05 +0000 (GMT) Received: by mail-qk1-f197.google.com with SMTP id af79cd13be357-936e393061dso101149385a.2 for ; Fri, 11 Sep 2026 03:30:05 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1789122605; x=1789727405; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :content-type:mime-version:subject:date:from:from:to:cc:subject:date :message-id:reply-to:content-type; bh=FSrRHRs+USEOkCNabKEpUzOvaX+AzMaMbvbk8haZkZI=; b=NrcuPs5nGsurkdzON2tbd/N4x6uBjagTuoLltyp1KaNXV5VJ5CyHQoReJdOIKp0mRd uTTMIhC/dFA+39ztsgDetPHl1OzMT/Kp2N5YxHGyb23gT6vhpjUqDgSqR1PzTXRzT+NJ aicwsqYi6w1TBWSTsD/itbQpIVj6x+p8wyijIhRAYDbXCEoKEkLKpm/H6T1B970QAds7 QzzitYL9hm2zLpZ3n2tIeijTzsq+DCMN4RZxykCLZwpTdPw2/XpzQBkMUvoDbachFpCa s4SZsZz+GlvOqL8BtruAMUuaN0LkqKT3SykvJLztPvJKwZna4Nb18zPFq6uOrTfuRGam IZbw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1789122605; x=1789727405; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :content-type:mime-version:subject:date:from:x-gm-gg :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to :content-type; bh=FSrRHRs+USEOkCNabKEpUzOvaX+AzMaMbvbk8haZkZI=; b=qscmsFkm3f4iqo4Vs8sImY7RhFwcv4TLH3tuLvvIzaX3rrAI4ugq93cT0R9C/56kKM BYInFG4i+tC46zR7x/oNOyZykSGieTBxfgCOwB7ASzRkKmqMBI6PFMaBvVdmv48eoKnX Qw1D8E1E3Is8tY1MsF/ut5EaEPUoBZyqbmBENLVaHs6P7CTogEa7+ufIeycPAuYpzdVI MqX2xpmCN/UGUEo8SpVGYXMYFzYJNI3eVnKBma89QxWa9eI2kWCVKDJYDMj7ik6J39Oa KFKpRj+47K75NpOrOD+pYFz8I9EDfYYMQU4ekCaG322BtHcztNZoY+72Z8LTVvV9kKRS HLRw== X-Forwarded-Encrypted: i=1; AKwUvByICgKIHkghJCbhxK3YvTBbz7WK/cXleX5FZhvK8LbQaMnqdIbOH0A7kslQY0+tcstXCWAulpG863SSAmA=@vger.kernel.org X-Gm-Message-State: AFuF++mdo4Rl4EycD0mxNcbNGlJ2Y17tbrW6STLZRHvn84UXs3kjMR2z 7lJo5VmDGLO3OJfxQi1hpHHj23IWX2HHd6l5sUd3ZRSzq9FPnWqKIumDMI5ZWEevkYhY6K4VSKq 8KusGyWhf5lnfBFCoIeqRmlYSaQMKrd6jONrOJqJ5OUiOs5XL7tMUfwFHA//n7V/6qPo= X-Gm-Gg: AYBFou3/FB3bbhpPS8Xz8+D27Gq+pg8PfcM+zZ8kMPstHfSDHvy6R0tzzrEqOUcb/Ou IgFCvWl9m8GLLLu7Rp1QBoQ6Vj1r+Tl8u3Y0yN5c5ZmG0f0Ys1MZfRHvEMcqppPQoQbiHlMP7ou +fmgIPKmi17D1cxjzZ17F4NNcXr9esuoEJx/0GoBtxJnYOuK+CN0pIofbJwMBWomPGsycdSZLFw +38gK6v123pmfkJi2qdQ5nETG6j4BW9qz8uLqli23k/oVTO1B12ocEV1OSxlTm6qekiOEsTfAbj IDR5zJICEq8n0KNQIV8Ezc8hNY9ef8F6e2I7Q3ag/PC4SHnyLPATRUlL9gZ0EGgk4LZaXH/auKP PuwjuzewxpnA6JIclXWgcy0g= X-Received: by 2002:a05:620a:43a9:b0:936:623e:2603 with SMTP id af79cd13be357-939ea06ff04mr392364685a.17.1789122600108; Fri, 11 Sep 2026 03:30:00 -0700 (PDT) X-Received: by 2002:a05:620a:43a9:b0:936:623e:2603 with SMTP id af79cd13be357-939ea06ff04mr392331985a.17.1789122594922; Fri, 11 Sep 2026 03:29:54 -0700 (PDT) Received: from [127.0.1.1] ([178.197.219.214]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-49e61a81943sm38651965e9.1.2026.09.11.03.29.51 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 11 Sep 2026 03:29:53 -0700 (PDT) From: Krzysztof Kozlowski Date: Fri, 11 Sep 2026 12:29:36 +0200 Subject: [PATCH v4 3/7] drm/msm/hdmi_bridge: Correct poweroff/audio cleanup order in post_disable Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20260911-drm-msm-hdmi-fixes-before-eliza-v4-3-87bdb9f1987f@oss.qualcomm.com> References: <20260911-drm-msm-hdmi-fixes-before-eliza-v4-0-87bdb9f1987f@oss.qualcomm.com> In-Reply-To: <20260911-drm-msm-hdmi-fixes-before-eliza-v4-0-87bdb9f1987f@oss.qualcomm.com> To: Rob Clark , Dmitry Baryshkov , Abhinav Kumar , Jessica Zhang , Sean Paul , Marijn Suijten , David Airlie , Simona Vetter , Archit Taneja , Maarten Lankhorst , Maxime Ripard , Thomas Zimmermann , Rob Herring , Krzysztof Kozlowski , Conor Dooley Cc: linux-arm-msm@vger.kernel.org, dri-devel@lists.freedesktop.org, freedreno@lists.freedesktop.org, linux-kernel@vger.kernel.org, devicetree@vger.kernel.org, stable@vger.kernel.org, Konrad Dybcio , Krzysztof Kozlowski X-Mailer: b4 0.16.0 X-Developer-Signature: v=1; a=openpgp-sha256; l=1299; i=krzysztof.kozlowski@oss.qualcomm.com; h=from:subject:message-id; bh=XH66GnTgugpnLWEqmx30iK26F7dqgoZ1zE1rBdQ5ZS8=; b=owEBbQKS/ZANAwAKAcE3ZuaGi4PXAcsmYgBqo9gSmcfSFcKQbToEryQ/sbRBEp0E85MoJSCa4 eGEScNxwYqJAjMEAAEKAB0WIQTd0mIoPREbIztuuKjBN2bmhouD1wUCaqPYEgAKCRDBN2bmhouD 1+/fEACYbLTLMYCCYNYY614e8AJPNlr2hZiZ+bCfgxFKdd4RaDfhX3BZU4AyRXmWsUbgLyMc199 YEZu93YLjrjLP+s2RRQetCGPScFAsNe5liReqEQMD5wQB9Y/S7AkXJ5NSXskXwpwJWUoPV8eJ1t EXrvUmEoUr6GlfLVLyqxr7VuueWQX5p3wE2TXNbTzSCrPf6slIkNquInZlIa/Ei5xDKY6Ok8GiP uhsSUBD+7DkLwjU2uolYhzVnHg/0DCK+dQ+yhZAldBd49oSkk4e7GNl+OrOadDo6jTGZYlr0Drb gbBRxb6f8RxFYN3t4xxz6P+Hn4mIrzZy2xEoSaLiHtLAQRFbwCgdQzNd4uSsmyi8vFdstIgdYB4 WIvryUZPl7VyvvnzIhu2EOCyQpM5ZVZt7kF3D69V3emkTnZN31XcMOu7XAbUuAYTVxNQmdMTFcw +uvxffFBiZ+3d5hTfIPxB8RzNz3B0FQ7a7ZQLOr7Y6iPzRDVV8sAcJQH2q5tWPmU/p2lCwwitj9 UZQnZujaPPMiJe9XRh9l88XeD8GYqWa+HMAaIaFd88gaHJEGvaGJ4r5Cb8Y9oauHlHOoylYrhpA pavfPZH1l157iRjmQ3O25w7B3niQcMBrR4/Ras1j4zfmebz2jN1GmSTfQTuQ/oVwP5v9ZFTqbz7 agmupQwlLYWueAA== X-Developer-Key: i=krzysztof.kozlowski@oss.qualcomm.com; a=openpgp; fpr=9BD07E0E0C51F8D59677B7541B93437D3B41629B X-Authority-Analysis: v=2.4 cv=cM11IVeN c=1 sm=1 tr=0 ts=6aa3d82d cx=c_pps a=50t2pK5VMbmlHzFWWp8p/g==:117 a=+bKQE0WJfmhK2875HamI0Q==:17 a=IkcTkHD0fZMA:10 a=VdqzKS8jKosA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=ZpdpYltYx_vBUK5n70dp:22 a=VwQbUJbxAAAA:8 a=EUspDBNiAAAA:8 a=agfB2vzvzBSRJA4gfngA:9 a=QEXdDO2ut3YA:10 a=IoWCM6iH3mJn3m4BftBB:22 X-Proofpoint-GUID: ZV38paRH9LKH76yK9NmUTa2VfZ3O7Mfr X-Proofpoint-Spam-Info: AW1haW4tMjYwOTExMDE0NiBTYWx0ZWRfX827DgkVlbOUR xI6NXFkUaiW/B+UsKt88wpqG/VP5z1E1pFM0n38PHCsPYAX0IqCMcN9hsezV8scLOPx9TOPyUSD btYCjo4Sbl+TBWxant2fhpReB/pVdQk= X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwOTExMDE0NiBTYWx0ZWRfXxLLEturrX01o nFoQYrTJqS5T1PBGMctFFfT3UNwaROwaApJH+/XCvmFQJoVIeL3WYrqoDOEzD94IsJtofBE6uzv 6T7B4hZafBDFFPhT/MaeiKSL24sU/4qVTOniWj7WGDf90lSVOgYTSUopveUewv4Lpjr1NiC2TEp RCuDy5uuP0SGsRieIP7bqrvR8Jk9Wks8CH9fzFVinVLRNeXEDJCEV/yzC01YZOWfn9ULA91OyDh nqxG8oaxELsRIdtrbrcCCcNX2uV2DXtqEpO0FEEQ8vNu6EYTHalfPJc6FuQUi67bxODrlcauFcq DmDgRDzYOBfXVOeRlzZDm9tLKSFS7JCrWZI2X/VwcPhz5HCPYavyYT18ZVqq1Sh6Dqb0WmHZB3/ vyxvdYZl3P0hl7p0uQuzRQiJPnEkigxzWFs/pBjgYMlPjTUBOP//1p+WAlnth0IL4pTUER92rt7 0QGOjxGVQD6Wx3cPn6Q== X-Proofpoint-ORIG-GUID: ZV38paRH9LKH76yK9NmUTa2VfZ3O7Mfr X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1176,Hydra:6.1.134,FMLib:17.12.100.49 definitions=2026-09-11_03,2026-09-09_02,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 phishscore=0 lowpriorityscore=0 clxscore=1015 adultscore=0 bulkscore=0 priorityscore=1501 impostorscore=0 malwarescore=0 spamscore=0 suspectscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2609040000 definitions=main-2609110146 Turning off the power in msm_hdmi_bridge_atomic_post_disable() should follow reverse order of powering up, not only because it is logical, but also because msm_hdmi_audio_update() accesses registers thus block should still be powered on. Depending on specific timing, existing code could have accesses to MMIO of powered off block. Cc: stable@vger.kernel.org Fixes: c0c0d9eeeb8d ("drm/msm: hdmi audio support") Reviewed-by: Konrad Dybcio Signed-off-by: Krzysztof Kozlowski Reviewed-by: Dmitry Baryshkov --- drivers/gpu/drm/msm/hdmi/hdmi_bridge.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/gpu/drm/msm/hdmi/hdmi_bridge.c b/drivers/gpu/drm/msm/h= dmi/hdmi_bridge.c index db85400e574e..1860605850c9 100644 --- a/drivers/gpu/drm/msm/hdmi/hdmi_bridge.c +++ b/drivers/gpu/drm/msm/hdmi/hdmi_bridge.c @@ -339,10 +339,10 @@ static void msm_hdmi_bridge_atomic_post_disable(struc= t drm_bridge *bridge, msm_hdmi_phy_powerdown(phy); =20 if (hdmi->power_on) { - power_off(bridge); hdmi->power_on =3D false; if (hdmi->connector->display_info.is_hdmi) msm_hdmi_audio_update(hdmi); + power_off(bridge); msm_hdmi_phy_resource_disable(phy); } mutex_unlock(&hdmi->state_mutex); --=20 2.53.0 From nobody Fri Sep 25 14:32:37 2026 Received: from mx0a-0031df01.pphosted.com (mx0a-0031df01.pphosted.com [205.220.168.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 406A3436BC0 for ; Fri, 11 Sep 2026 10:30:00 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.168.131 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1789122601; cv=none; b=QofDK5EbiU2EXYjb/iwiWmXlWYAl9dsFkxp/X6ASkSJInUPM1yVbtRYIbo7t/g1LVF2cqJyQlFvvdrvliGYsEmeF8ufGjJtHULqHtmFEhkOc9nJnZx6wvcBaUZLmHlJrpXs4htk7pzkZQlZ2zHHiZekc+d1Z8m6WNPKokdBGbac= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1789122601; c=relaxed/simple; bh=DVXNSz/QqITCQAR3c9vgiIReGo6sp1REqUL1NIZWtK4=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=tXFTL94+lUXQhnVFBbcqUs5T5AUKVpZqROyHRo993cw6AgY91QWuIBW6imCQ5KzaFKTExfsDDxmDokRQhu/G1ml35XH3luSrT1KDWHKftFTG58NvlVZ4Pyz0LpDuZECd61Ju9TB7ncIDjTEDLDvLEIw4YmMN83Syz8sd6i1YvE4= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=pHksfQeY; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=G0yMTHjS; arc=none smtp.client-ip=205.220.168.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="pHksfQeY"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="G0yMTHjS" Received: from pps.filterd (m0279864.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 68B7kpjh2311499 for ; Fri, 11 Sep 2026 10:29:59 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= E0C2reVv1oSwnphcZX04pJknqbbG7msmctVikhe2z4c=; b=pHksfQeYf+c/aAK0 N6tQXPebPfDYihRs0gnVQe/eqzFFTjAB8xAzmnM1YHLbYxJw+DxXVzC/80mhbH4I BXRnlakj1LB8IQrGWdsCpYEbKmOZB9yTLuLn0YbRvPECzZzQLMiFrU3Yp3NkeOb1 pBMdk7NEnG1IALukD/ZEoPag1T3r8Rv+i8XojZORFUdEVwPEIKIadbwHIG94rZ23 SuD5VwUoZ4WfKYKdqq2LOZfZLYlri6UlTBoEuVBk99+oZQIKtT1HoG236X9xqJ47 a50oV1cqqUjLzIDsk58okArCct/ViYflsBt7jlCb4ffDZ7DNeOSnTG7jTzdUSyyP mtmCcg== Received: from mail-qk1-f198.google.com (mail-qk1-f198.google.com [209.85.222.198]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4gm7uchyj8-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Fri, 11 Sep 2026 10:29:59 +0000 (GMT) Received: by mail-qk1-f198.google.com with SMTP id af79cd13be357-93903622880so384651385a.0 for ; Fri, 11 Sep 2026 03:29:59 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1789122598; x=1789727398; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :content-type:mime-version:subject:date:from:from:to:cc:subject:date :message-id:reply-to:content-type; bh=E0C2reVv1oSwnphcZX04pJknqbbG7msmctVikhe2z4c=; b=G0yMTHjSJMVP764Y8/V80FXYuN+PlpIQ+3rhkO1oWMH1SfEo1hnPrv8lhaF82pdcTe 2xW66Yqo8yFXObMUwt7sDPEbQ8dZ4u2KHMnwz2gCiM78IFzosfJytKnFKLoQ38g2FB3x /rSw9VbJit+wOaeOHLyb2LdFM9u21dmiQ85TvjQVYhJ+tOP8HJ25NE4bItftk2qGejhg Oiqyg6JHtyoBoByMWQo4jvtsxnElOMpomRCcWYyqdoCbx7ZiSBXYETzJohoe76po9UCk JiYbzJ8jYRgKKYVmMq1hUPRhfaOkQrX99atESFmz+mYXoN45fmBPb2sREbLTrew9AoJV nosg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1789122598; x=1789727398; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :content-type:mime-version:subject:date:from:x-gm-gg :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to :content-type; bh=E0C2reVv1oSwnphcZX04pJknqbbG7msmctVikhe2z4c=; b=sMmjtiS9byjJGbiyDBzNX3Y8jJYiWAM8o/ii3jer61lTUMLQsGWopPlNnJ+F4Jbsmq 0SHkiEgs3oETJnJTuXXK4ZTxQPDxQ9kKn4bmgYrbBr0qiq7FGJ8Y26WJeIQcRqjoi4WK qYOVHFmM247n9ODiCEK04DFtykDulM30DTk5Y1bEMZYVayNUlo5+cEzTOJWniYGzfgsK p+kJdSjSpxfHra7yqPT+o1oeSH1aU9Pq6O1+CeAlHcYpBF3HpqFcTcA1pxKnfqCdXW8I Z0orBoeGxZSMCPYiJPLnERw0Fh3NVuvlahfyKCTC1DXwlS+OYYm0fgEgfvxGCLVJMO9+ XRLA== X-Forwarded-Encrypted: i=1; AKwUvBwxwfhCjCWQc13bC9MWyobW6lebtGZmj4OQ2Y3kN3QBtEJab9gXDsiPde5pre2+pM7m6RdpbY4Qmm53oOc=@vger.kernel.org X-Gm-Message-State: AFuF++nmhbEyKCCqqBlQx8kV9p5p2TH95w+SYj9oeIOKrye6G4w9MpFz erfb4KYQClGhTh7GzF8+SqBCX0MB2vFGQcZ1f8X2xcbaedS/8C8Gg6oevuo3S2T6qHoPIdvdHYH XegQ+wCq3QxsXday3C1lqCBWkmTyBl+XXFqVUVKM2p/26jfsnsryz5nsYOQ/xp56763g= X-Gm-Gg: AYBFou0n5FwZlYC1aMAU2k8YcfSu7ckLgEU7AfOAvUL6sgkGKhjiB3RALtrEA+rql/0 U8njfSL+SRcaW9lhxd0lpJB6E+tvkkwy+OR61vTF45Jc10ANWGYLX8N2fSlJmh3Wsj4bygFvpuZ aIjRVq4f9HgOodVMdgG//ff4D63d3lXBEPv61HNAdm7s31wV7i0PpWOmr7z2nD84/vRxxvtwdIe uWpEQTJpabMsEYi2ZmYtj4R2wSXVGqFJVwV+I4rqBOvx+a1n9CT/+seWT3LwMEEJj4g1O8a2D25 psGkXv0MXLJ5+CuUI8tQc7qCS1ff0epPX33nz+vIPHsoGCucKan7fUmVTX8f9Vs4dYh0P7vUi/R 7K1OH1ZDhTq0X0YTNNifMWHU= X-Received: by 2002:a05:620a:450c:b0:937:6f98:c68f with SMTP id af79cd13be357-939d7e3ff2dmr1128907285a.1.1789122598386; Fri, 11 Sep 2026 03:29:58 -0700 (PDT) X-Received: by 2002:a05:620a:450c:b0:937:6f98:c68f with SMTP id af79cd13be357-939d7e3ff2dmr1128904385a.1.1789122597996; Fri, 11 Sep 2026 03:29:57 -0700 (PDT) Received: from [127.0.1.1] ([178.197.219.214]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-49e61a81943sm38651965e9.1.2026.09.11.03.29.55 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 11 Sep 2026 03:29:57 -0700 (PDT) From: Krzysztof Kozlowski Date: Fri, 11 Sep 2026 12:29:37 +0200 Subject: [PATCH v4 4/7] drm/msm/hdmi_bridge: Drop redundant initialization in msm_hdmi_bridge_init() Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20260911-drm-msm-hdmi-fixes-before-eliza-v4-4-87bdb9f1987f@oss.qualcomm.com> References: <20260911-drm-msm-hdmi-fixes-before-eliza-v4-0-87bdb9f1987f@oss.qualcomm.com> In-Reply-To: <20260911-drm-msm-hdmi-fixes-before-eliza-v4-0-87bdb9f1987f@oss.qualcomm.com> To: Rob Clark , Dmitry Baryshkov , Abhinav Kumar , Jessica Zhang , Sean Paul , Marijn Suijten , David Airlie , Simona Vetter , Archit Taneja , Maarten Lankhorst , Maxime Ripard , Thomas Zimmermann , Rob Herring , Krzysztof Kozlowski , Conor Dooley Cc: linux-arm-msm@vger.kernel.org, dri-devel@lists.freedesktop.org, freedreno@lists.freedesktop.org, linux-kernel@vger.kernel.org, devicetree@vger.kernel.org, Konrad Dybcio , Krzysztof Kozlowski X-Mailer: b4 0.16.0 X-Developer-Signature: v=1; a=openpgp-sha256; l=909; i=krzysztof.kozlowski@oss.qualcomm.com; h=from:subject:message-id; bh=DVXNSz/QqITCQAR3c9vgiIReGo6sp1REqUL1NIZWtK4=; b=owEBbQKS/ZANAwAKAcE3ZuaGi4PXAcsmYgBqo9gTV0/YW3nDgV588FrAxTLe9cG52WMzAMMYr NKI84Lz0GmJAjMEAAEKAB0WIQTd0mIoPREbIztuuKjBN2bmhouD1wUCaqPYEwAKCRDBN2bmhouD 12GBD/9RqSUlV9uXlVhuHr2uUrrhS6rxshyiGQqKwcZ7ksHEN5NVwnshts1XzecGukzkys9Jjl9 GoTlteAOfZpaYwvtJ9iN+XLFs54jScHcP/7eqO4R6Z/cKzQjeB2HGzaf1UTUiHRqBBVDQMhUo+A RBtZcL+7XmiQVESJ9ZpMmyo+0xejSPquCYO45iV3Np48YlEA1Dl35EjkLhuPo5XU4O7/WrP8tH7 lts6l04ekv7YMO97ElLTS93qNnMuZ/MuR99FosbezHM59KO33o4XtwVqJGDQsxEiMY3ASamii9q 5Ljuho09Vs3yTJCvKgNDmFWKxcj3TyshRUfuy00mRPnF1AnpoTPNPjDxU1o0AoX/sCXovf1rc1+ pkrsI/9joUx0hs/2AX/9HEkoTJOZCxeOstg8vPkIBLY/OQl4HY+6coP9jkOwP5Hkiwy6U5ad/lT CFzm6wyEkaEixq/tq8YJGrkPA2oRPWqzD0vJUtxIyNmwXX+gvd5fbSSNhFaET6RdNjci4/8REGc zXAtOBPUBFKr2QR3L9hJ4QTKTRmjjBguyU53XS9CEOscIWKaqPXi23wilUDtmts2WJ7fSEnbSGr X4K4Ic9vaJpmQZom4HKVt4NSBE4JA++KrmJ3vmJ6nSWR6NG/Vybn8Kuaoo+0nVncsVlj6eKN8iL zd/lzs+F9i6/8aA== X-Developer-Key: i=krzysztof.kozlowski@oss.qualcomm.com; a=openpgp; fpr=9BD07E0E0C51F8D59677B7541B93437D3B41629B X-Authority-Analysis: v=2.4 cv=O4asLx9W c=1 sm=1 tr=0 ts=6aa3d827 cx=c_pps a=qKBjSQ1v91RyAK45QCPf5w==:117 a=+bKQE0WJfmhK2875HamI0Q==:17 a=IkcTkHD0fZMA:10 a=VdqzKS8jKosA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=DJpcGTmdVt4CTyJn9g5Z:22 a=EUspDBNiAAAA:8 a=RZP3y24nY_lDZDhlvS4A:9 a=QEXdDO2ut3YA:10 a=NFOGd7dJGGMPyQGDc5-O:22 X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwOTExMDE0NiBTYWx0ZWRfX2oBv3Rx0On0F tL/bTSlq2XFrLkqsMV1IWNoPmbMxRipWxLgBmvKj45rNw4VP4f9rCmbWwzjCXQaExiPEfQQMzph 93KTS8v0oR+FMdPc3feOlf5NhNPi+lgQFwTCjG/vOgraJx/jPYJL32BiKqchiVrIc7XZIjiD2SG txET9nHGO1b0LHzL+bR1IJsn/VSrayggD9TSEVj3LBCRoGM9wRav/7rK795TIp9p9+RawC43NAW ZGsnSCGhYCx/h7UrJrz1545lPxMP5WAXJ9XjKLesuQ5Lqc0pHkfKSfyhmCgNFm5vuTfC4lQiHH+ 1gk9GGGGLutnTw4ZvEcShLx4BiRwDs9KCbJ8dLvlcSyvErkdj2KJ+NUQYuamDnNW4wvHB8TVyvn ZUz3yx7jTGRU7Gg4ixDDRR17js2x0kxKDkVuSY3QwIwNkJpZax/LFN+GJAIFKIIsHKaC1AlkNhZ GVy3hFxck8xe/1mak3A== X-Proofpoint-GUID: aIjAhPqTigGSKucFl_hL8AO_6ZHo-HC3 X-Proofpoint-ORIG-GUID: aIjAhPqTigGSKucFl_hL8AO_6ZHo-HC3 X-Proofpoint-Spam-Info: AW1haW4tMjYwOTExMDE0NiBTYWx0ZWRfX75NTZzDzigaY 7RqLzxx7iKW7c0JKRtetUVeyJMgfQCQsrd3JcUbpVEjOh89ZCguvd1nFH04r0CBQIQZklWWMJV+ p7HK+e7MbmXMEU48eV8w6Q+PpXrtRlA= X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1176,Hydra:6.1.134,FMLib:17.12.100.49 definitions=2026-09-11_03,2026-09-09_02,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 phishscore=0 clxscore=1015 priorityscore=1501 suspectscore=0 impostorscore=0 lowpriorityscore=0 spamscore=0 adultscore=0 malwarescore=0 bulkscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2609040000 definitions=main-2609110146 Local 'struct drm_bridge *bridge' variable is assigned in ~13th line of the function, before any first use, thus explicit NULL initialization is not necessary. Reviewed-by: Konrad Dybcio Signed-off-by: Krzysztof Kozlowski Reviewed-by: Dmitry Baryshkov --- drivers/gpu/drm/msm/hdmi/hdmi_bridge.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/gpu/drm/msm/hdmi/hdmi_bridge.c b/drivers/gpu/drm/msm/h= dmi/hdmi_bridge.c index 1860605850c9..49587927e8a5 100644 --- a/drivers/gpu/drm/msm/hdmi/hdmi_bridge.c +++ b/drivers/gpu/drm/msm/hdmi/hdmi_bridge.c @@ -484,7 +484,7 @@ msm_hdmi_hotplug_work(struct work_struct *work) /* initialize bridge */ int msm_hdmi_bridge_init(struct hdmi *hdmi) { - struct drm_bridge *bridge =3D NULL; + struct drm_bridge *bridge; struct hdmi_bridge *hdmi_bridge; int ret; =20 --=20 2.53.0 From nobody Fri Sep 25 14:32:37 2026 Received: from mx0a-0031df01.pphosted.com (mx0a-0031df01.pphosted.com [205.220.168.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 7849B43A7E7 for ; Fri, 11 Sep 2026 10:30:06 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.168.131 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1789122607; cv=none; b=R0RUHVMUPblK2DsQnW0S0yTU0hKYVlvKM0QjS5WnVM/539SPFRZE9575Y0p0ngb/VCuIXjtx1iO/4FlV/XgdQsWKMRHFoSN4mh4e2auR9URgPItPT8Q1DyVIFEJGtWLN/4L7gSy9nlFJ9wTZPg+49yOF2TbjAn7TD+1M1pw2ZD4= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1789122607; c=relaxed/simple; bh=pt+Rkw+jgQanPwhA/NuvAa5qnlnZ01yZY+rh1utI0Qg=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=k9wuU5z6m4HZc66IU++Dmoom+PW2WMVZL2s+r4zs37xvxU5q8dWSDR4mFaaBSgf6BzdAgx+aYOBT58dWRB/KoNzC5aiXWuSfcjvsJ6yiv08qqPVMrmcwEemnZcivURxhJI6PIwWcTxtVw/Ic1yeUZXRSTajK+aC+xF0O9rewBqY= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=VqEc/AEu; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=aEF8pdPP; arc=none smtp.client-ip=205.220.168.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="VqEc/AEu"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="aEF8pdPP" Received: from pps.filterd (m0279867.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 68B7kmG5423699 for ; Fri, 11 Sep 2026 10:30:05 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= dfXCR8WLAG7aE7tsDiN6RRiR4IoTNhMtx0emBbiNuls=; b=VqEc/AEuTF7PpT3X olhkf2h9Bdq61NedwcggjM/bzc29Dqz8ssNS2ZdN1ZiCfLeSmWhxSzcXQdH4I3+o yzKEeScTa4eqLab3dXzV3JdHeElrraduNIQWSjE4Odv4OIFTL6Rcf9sVq7MQZwjQ GKAf5oooGSPR5hmf5/S7Jc/n5wLAICX+iB6rEnd1B3UonuOR6/UCMyMC/QhxPrtO x1I+5DxSKopjcWAvKpBbdir7T4WmIXWYl7f23ld7zJ8tBdeftMI1bMdL3VkNpe0B GiUZOF+//fEg2XroqxH30WeGrhan++NEkZTcIp9lGTyLO4orabT+NdHadu5cR2E8 AGI/Hg== Received: from mail-qk1-f197.google.com (mail-qk1-f197.google.com [209.85.222.197]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4gmbf8h78y-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Fri, 11 Sep 2026 10:30:05 +0000 (GMT) Received: by mail-qk1-f197.google.com with SMTP id af79cd13be357-939c30aa9a0so64631485a.0 for ; Fri, 11 Sep 2026 03:30:05 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1789122605; x=1789727405; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :content-type:mime-version:subject:date:from:from:to:cc:subject:date :message-id:reply-to:content-type; bh=dfXCR8WLAG7aE7tsDiN6RRiR4IoTNhMtx0emBbiNuls=; b=aEF8pdPPWC9Blthz5X+YC/3u9O0oLjUaPj/GmoTwiEnxcvbjjBF1p9K8lRA18B6yvO mX3V3zTtCT4Qc+nUUez2Qw7axdVmCA/IZYqouOEn68PY5brhBZy6vyKkyhEDbLB+ovWw QKQ3kE1j7lsWISLrbakcoD4qd6EMkpOw8NfVxCFRK5dUhZwHsaV9S4XQmarP7rs7jsXJ 8s/EW4S42O1vSdLqMbQKogbFY0OK33Edqq3YwU4yrg99n3bPPTLF6qyugcKeBD4QPRp9 cWHbNgGxVdzDci8/TjIJu4Al1RaanfqVoewHGRkMAPRUd3AhwmIYChOKvVlhbygCArtq SWNA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1789122605; x=1789727405; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :content-type:mime-version:subject:date:from:x-gm-gg :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to :content-type; bh=dfXCR8WLAG7aE7tsDiN6RRiR4IoTNhMtx0emBbiNuls=; b=jXMvZjmC1W3KPRuzWGNQItko1Y/9AN5LGrn9bDUqSayGX5JfQ5LQ/7LGXXPYmuL2mu z60BP62vmEf/Q7SV0IQ0ZuSPn6bYLuim6CDRPyeKk5G4A87Qkq9B3hFo0o7zocxWIBNH 9bOc+j/MP/8lLKfxuxfyIT7IKDW70OSQR0iUWWWtcRtfc1fjQgaEvd1CsYEFAjtY8Y3u oPZ2yf0Xm5xHWZQSnC/PqR9+IHffPCQlHv+lK/T4xAMaoFxbgEG7dK4q3oNli+UPWOoG bhGnMJaF0DY+3rKVPoyehDjAZH5RbyZ8hJK5FX/0KjFNhBIJwaGMOmtDDSe5rznywcI0 Lw1Q== X-Forwarded-Encrypted: i=1; AKwUvBxIY6DwD4pMjsTxLGfN+Lw0WCLBqvyH2te/Eu5PELOsS1mCuzw49KB9f2nGOwXwt6TUbnKbK6RzyA1WoCM=@vger.kernel.org X-Gm-Message-State: AFuF++lAdaqMgcf1tIIXnKjINU9EKk7AQAp8JCkqMh60gItPJ+/W0aTg FfmHNLhsWU2n9Dq5wUwUz/6q8l8Nhgs0t2dsM5NA9bu/BAed9l9BzmJJWL8Eqy5bbbDXJkz9JC1 j/vDf8lmu0wh+02eHqQbgbYLulEd2/K0GSdKq7ToNYyU9B9Uh5OUtOg2MkdBJeXarAkI= X-Gm-Gg: AYBFou0CyrAs35L4MCG3BRcMmN7AkYkpbJaTE5Px2xEMSHChjNcHYTCVpBpk3RKkt31 bAV0p/zcx8sTfFvpN2IW8s1ZFLq2lORNEtNR5K92RxpRwus0j4IX5vw24nMGWgjqIL8cfZpajI7 bKENCxtY0qc+dwcI2Fkx+MJzc2xxzDEAQ+nrsWbYSj8HVzWwiMFvOgY+BzMrZb1eQqZz5R+LHUq MDmCjzyEwa7KdMdHEA9CNiLib4jA57RrpH/BuCzynFkQ95OWKpUZOD8AhRdcTa1WU59Lb2eEyic RaWuLjVXO5U04/QRsZkGiz0xKjsbCQDwAnw2rEolJwCBjprSTyn9C0tpATPnJjmK+VWg9DOSFBK Ins9ar23fvwoGbkFJB1dt6QI= X-Received: by 2002:a05:620a:710d:b0:939:5c30:fcb8 with SMTP id af79cd13be357-939ea0e6e28mr448633685a.6.1789122604424; Fri, 11 Sep 2026 03:30:04 -0700 (PDT) X-Received: by 2002:a05:620a:710d:b0:939:5c30:fcb8 with SMTP id af79cd13be357-939ea0e6e28mr448595185a.6.1789122600092; Fri, 11 Sep 2026 03:30:00 -0700 (PDT) Received: from [127.0.1.1] ([178.197.219.214]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-49e61a81943sm38651965e9.1.2026.09.11.03.29.58 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 11 Sep 2026 03:29:59 -0700 (PDT) From: Krzysztof Kozlowski Date: Fri, 11 Sep 2026 12:29:38 +0200 Subject: [PATCH v4 5/7] drm/msm: Properly handle msm_ioremap() without name Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20260911-drm-msm-hdmi-fixes-before-eliza-v4-5-87bdb9f1987f@oss.qualcomm.com> References: <20260911-drm-msm-hdmi-fixes-before-eliza-v4-0-87bdb9f1987f@oss.qualcomm.com> In-Reply-To: <20260911-drm-msm-hdmi-fixes-before-eliza-v4-0-87bdb9f1987f@oss.qualcomm.com> To: Rob Clark , Dmitry Baryshkov , Abhinav Kumar , Jessica Zhang , Sean Paul , Marijn Suijten , David Airlie , Simona Vetter , Archit Taneja , Maarten Lankhorst , Maxime Ripard , Thomas Zimmermann , Rob Herring , Krzysztof Kozlowski , Conor Dooley Cc: linux-arm-msm@vger.kernel.org, dri-devel@lists.freedesktop.org, freedreno@lists.freedesktop.org, linux-kernel@vger.kernel.org, devicetree@vger.kernel.org, Abel Vesa , Krzysztof Kozlowski X-Mailer: b4 0.16.0 X-Developer-Signature: v=1; a=openpgp-sha256; l=1345; i=krzysztof.kozlowski@oss.qualcomm.com; h=from:subject:message-id; bh=pt+Rkw+jgQanPwhA/NuvAa5qnlnZ01yZY+rh1utI0Qg=; b=owEBbQKS/ZANAwAKAcE3ZuaGi4PXAcsmYgBqo9gU0RExYusnudZ0OMSrcweBZUWjDZMb+M8pu xhoxU79/VWJAjMEAAEKAB0WIQTd0mIoPREbIztuuKjBN2bmhouD1wUCaqPYFAAKCRDBN2bmhouD 13VaEACFaCKDETdpPto0n8tND9AnmPJrBouZ3DiV5VMplFHEEzVYq79foQF2rjqKv263AU9zq+3 JIWOx+5BF73BcsRrq5QIvQ7blWqANQTHgHriYqXprcy5baVa0he5oIynANoIZGXzLWLj54C08yK DpFvI7aOZpAchp0JCUbOtgLMdFHZI2j6EdqSJYa5xOKIvokL26l0WkT/lA8fQ4ZQPCcMUUhzxYT iMYAc8UDbse3YaQUCjHZS3SLsQcKQoYSgHE20MN7beFK5f55ru558QjCN/lWb9wluhSw6V7jgyk b5h+6TifujFZL3ipkLiEEBDx8Sncin3+oDzNqgKc+5t+WBWSAOIO7+/Y2pwulk3+PDd9y0MSjAW QR2gmN27rQ/a62pMIJEDJEH42LjUjGUESrCUWrhKWxhgvmrdZDpttf1Hdf+6PdXyA45f5jiMwJ2 IC5/13KIi+FWip/HxEMPIurxCj7mKgKAdyqpVmgcuBk1nnvxa3I16OcBy8nMqA2r+LBFet0gfUq XPB77l7QlFmKPKqFiAB7H6Ik3As0cPkYgkf0tiRrNG4L6z7zbELYeppwyVslAZTimh1eOGeYF/8 TbTVKCmSzSeT7WEHoe6FY3Qu+ITbN5AJCECIuR7C50IHN3ul+Sp2Bfg/rfOKUwUg9Kc3RMCiRk1 Jw/7z7tye3JvP2g== X-Developer-Key: i=krzysztof.kozlowski@oss.qualcomm.com; a=openpgp; fpr=9BD07E0E0C51F8D59677B7541B93437D3B41629B X-Proofpoint-GUID: Her33pLx5qNVOLQPfrqEc9FDW26vYWkt X-Proofpoint-ORIG-GUID: Her33pLx5qNVOLQPfrqEc9FDW26vYWkt X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwOTExMDE0NiBTYWx0ZWRfX8Pic2GvZvw5f TKTS2y7iCFQA4y/9n/aPHAHIktmmd7ydsYTjXkIO1qinyIfZvZ0lA8Lr3EcL2qIdcVKFe8FXa/j 7diaC/v72CAIqfb1fzCL+SkYikon6cnPHVhSqlMuf13tu8CgNezuVq1q/ZfM3tCZBqOBHxoRUKc ZIONOcGSXKyo3aqpACu+BkHz/6gCF7RFMzT8piaQ3nZ1TtbEylY47CovxscIqbvaYj/hhjORW6O O5pe5R1U/LdeRX0n5bOi6tdoxdockB3/k1dV9tc3sC+ygH2tEsI3XbpENvRAVMRtH/d8isf0u0m RLWOCItKJeRqxUVtkQaleBfmVm9ZOSaUv3KJ9zjDw3nRojXONfM/cBapJcqpFjaxNWeWexvJ3Gr 1k4WHy+885YY23q5+iAWcqvXHgUyGCBWae4eDJDbbeWrBLeHMrzGB7QKNnKLR/7i6p26d5sywwK +HwjQ0lUq7D2pAOzQ8w== X-Proofpoint-Spam-Info: AW1haW4tMjYwOTExMDE0NiBTYWx0ZWRfX+paEJK0yWTxs QrduV/I0Zt0xdghWTs7g3kULGQ+CPrNVyvTbJjZVh44AasZQxD2aUZuHJFnOY7ShxMCylfvVaJk HwXweRumhh+021WnAh9EI/NOsq45G94= X-Authority-Analysis: v=2.4 cv=UJFIjyfy c=1 sm=1 tr=0 ts=6aa3d82d cx=c_pps a=50t2pK5VMbmlHzFWWp8p/g==:117 a=+bKQE0WJfmhK2875HamI0Q==:17 a=IkcTkHD0fZMA:10 a=VdqzKS8jKosA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=eoimf2acIAo5FJnRuUoq:22 a=EUspDBNiAAAA:8 a=or9nyMeYumr6D7LEzWYA:9 a=QEXdDO2ut3YA:10 a=IoWCM6iH3mJn3m4BftBB:22 X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1176,Hydra:6.1.134,FMLib:17.12.100.49 definitions=2026-09-11_03,2026-09-09_02,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 lowpriorityscore=0 phishscore=0 bulkscore=0 spamscore=0 adultscore=0 malwarescore=0 suspectscore=0 impostorscore=0 clxscore=1015 priorityscore=1501 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2609040000 definitions=main-2609110146 msm_ioremap() accepts being called without name of the region to map and in such case maps by index 0. However error paths still use the name in error message. Reviewed-by: Abel Vesa Signed-off-by: Krzysztof Kozlowski Reviewed-by: Dmitry Baryshkov Reviewed-by: Konrad Dybcio --- drivers/gpu/drm/msm/msm_io_utils.c | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/drivers/gpu/drm/msm/msm_io_utils.c b/drivers/gpu/drm/msm/msm_i= o_utils.c index a6efe1eac271..99221b0d7e3f 100644 --- a/drivers/gpu/drm/msm/msm_io_utils.c +++ b/drivers/gpu/drm/msm/msm_io_utils.c @@ -77,7 +77,8 @@ static void __iomem *_msm_ioremap(struct platform_device = *pdev, const char *name =20 if (!res) { if (!quiet) - DRM_DEV_ERROR(&pdev->dev, "failed to get memory resource: %s\n", name); + DRM_DEV_ERROR(&pdev->dev, "failed to get memory resource: %s\n", + (name ?: "#0")); return ERR_PTR(-EINVAL); } =20 @@ -86,7 +87,8 @@ static void __iomem *_msm_ioremap(struct platform_device = *pdev, const char *name ptr =3D devm_ioremap(&pdev->dev, res->start, size); if (!ptr) { if (!quiet) - DRM_DEV_ERROR(&pdev->dev, "failed to ioremap: %s\n", name); + DRM_DEV_ERROR(&pdev->dev, "failed to ioremap: %s\n", + (name ?: "#0")); return ERR_PTR(-ENOMEM); } =20 --=20 2.53.0 From nobody Fri Sep 25 14:32:37 2026 Received: from mx0b-0031df01.pphosted.com (mx0b-0031df01.pphosted.com [205.220.180.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 5C08D44F56F for ; Fri, 11 Sep 2026 10:30:04 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.180.131 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1789122605; cv=none; b=KThMIKR9+OpKNsgUcCQDmeaxuJv1KTEUDmYlisga5p/Ynudh6x8GYko4ssCbZWmvJRPu2PH1WOac2oGMd3hpypP8xp07iPNkg5b1RzjHssH8hrDqjugaMQ1JHrw5gcReAqNLUr2AxkIbpPBfghtBWjAs3j1CPW9lENQQ1IIPlN0= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1789122605; c=relaxed/simple; bh=/YVh+L5neHC3SlylyZSkY52kedS/7Okrqq86t4o1xdw=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=cT8Nrvu1bTO5b38jKF6Wmn2jEIFprByV3PWXJ/hj5KG1E97vNp/ihzQnhT9JNdhNhosoV4Pctlv90RmsjAjkcWni4Q0gn8ZnYYxVl/J14R6AF0uCb7911Nyu+MLipM6ZkTktr+3Mvq5HrR2meUjGSBTr98qL2BxUMrjp2DpewHg= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=QpcMViXt; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=embtBQIm; arc=none smtp.client-ip=205.220.180.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="QpcMViXt"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="embtBQIm" Received: from pps.filterd (m0279872.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 68B7kvok2832840 for ; Fri, 11 Sep 2026 10:30:03 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= vizWdKJGFAB1HJu6hwMtO5oQyxT7j0M+cp6kkFJFsqU=; b=QpcMViXtCHLe9wrc kDrACOjs2+E0IpvU20o4U4GUtWh9ZQv4PMkD3P1LO0sG1MW/n+FZhat0dqNFNw+G gFlE2g2zyPvb1deu/k4a6MG6GKnDkopWlfedJrKOvO2AWNmsnFZ54+Uiv4wH5/bl 8fGXfMKhWxJKQEiItMfa8xZojy1/3Rb4AoFrRujmvW2Jmqow06K5ZYldVWJ4HLZo FfeBbD95EPVDlBQUw7vqX3wSaUes+A6bQvTcKXP6oWvairkRVEBMN/IyAduD/8++ GIgQi9kYcwDfpa0vvG4lA4AfwN7eAves4zyRaU22IzN0gdVVHmmDc0WtFIP01kpZ yJegSA== Received: from mail-qt1-f197.google.com (mail-qt1-f197.google.com [209.85.160.197]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4gmcgfgwt2-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Fri, 11 Sep 2026 10:30:03 +0000 (GMT) Received: by mail-qt1-f197.google.com with SMTP id d75a77b69052e-53088a3939aso18585691cf.0 for ; Fri, 11 Sep 2026 03:30:03 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1789122602; x=1789727402; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :content-type:mime-version:subject:date:from:from:to:cc:subject:date :message-id:reply-to:content-type; bh=vizWdKJGFAB1HJu6hwMtO5oQyxT7j0M+cp6kkFJFsqU=; b=embtBQIm43PC2Jlp7gTO7xN3biMjDAUC9FAdoWbUjRduqn6MqZsjWnSO4JOsRclF6n JTJuHdqWWeOU8kpSbAyosrKM8RfCntrdRg3dBKcen7k6CH2pVRjG7KHfKCVEK3VQ+/PF zqVb7VqVDsDX3KfjIRlWd7EGcpxGOhgxujLzR/JxoQxpqrqQhD6+SnJ2zXAEEIGcJ5w6 0NuDoJpx23OrI917GY2JU40iF9Ox2UjOCxXQYgE/DB455v9K6B9B7OKw6VpJWIWLaLAZ FiJ4cnVXXAJC4jETBTAjUoRIIxHjv19YstVg2FZhB6tlNKDNHzj3qj9ZMoX3vqTBhPsX xmzw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1789122602; x=1789727402; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :content-type:mime-version:subject:date:from:x-gm-gg :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to :content-type; bh=vizWdKJGFAB1HJu6hwMtO5oQyxT7j0M+cp6kkFJFsqU=; b=VZycO9YfCO9SUgKX6bjBh8ptiCMXwBdcUmIlDg40CgZm+6R0jA36eC0CfQyvhg5IxM omUp8OtewaMLp3Ldsm5ouX1G3pa8DzVUiR8sedJnrL4phU+2MhqB4/O6SKdiKpShJ0f7 E5Jx5+WOAlNKaEs4a98o3gVnRBKSmDhrB92ySxsr606QTsN1Hg4dh7rGdzjo93+ecpCG 5TThDRF45DRPOpL0JjyW3gscoAdl9bfboyEEF76w+k5nyWG6QBzXepXuGKz9djPbD2HC JT1hJh/90gGDwfr+vlC9PNhvyZBtb8GvTkkQY5ntCA7dbylmJmL/c4NaQV8sKs5iewpp Pt+Q== X-Forwarded-Encrypted: i=1; AKwUvByXpWcb0tbo6/0qwyEzeoHZgYAQGLE99sF9qNEv08S/Wq7KtzP7XubsKh3moIYwdzbNsIAAV0LAUIv4gwo=@vger.kernel.org X-Gm-Message-State: AFuF++lV/Ptky+nVvTAeVpyxfk59ZcUF40Mz/qyxbe91QQ/ozSVeOkqb 7OjymBZlmg8/uWdXNseVwgxhHh+T3mtcwxZJj5WtsO8tFNEnpIEzIzvLAsC51tBNlgskZrZXac6 OXP+7gXLYGBWIIwsbtX/roXpRJjCpsDL8amMecNSAXMq6EhtSHa28Wb2gMMt4fTrGh4U= X-Gm-Gg: AYBFou0XN+oxxKOXsVvuQg3kAz/6oWq2L93swZTOoJrWl7BV6H7s2PG8EzJ5paPrfD4 eW9W8yvZKJUJ7RP66dNHnwIq9jh04kvSmsytp4d1kwNSSgS8URRlN/yLe00SY7cB2O0Wj0DPjnU TtP6PIuxGrNNGbNkb5gmHzgi4FQ/pKLDenDsaGgveHU+88Pyvu3deg79E8uOGrGx+1cjh0kdXVo vS7CFrGJoexOMCVVMUjDcLcygPWgcozkZcmp8op9Zk6Nrfc/94iwzKiUaAnjC2Oc6TZgEnghJmh prp/33IG25HBG7sDwEH0vRM+pTmKdcl6xCqTvJ7FjCeN1bbdDCuCmtXfN6CTWl2tv7Ehgu6b9Ti 5hXfSqedZpRAHxsg26ylv970= X-Received: by 2002:a05:622a:4184:b0:530:b2e1:2f3f with SMTP id d75a77b69052e-530c8775a20mr54660941cf.54.1789122602578; Fri, 11 Sep 2026 03:30:02 -0700 (PDT) X-Received: by 2002:a05:622a:4184:b0:530:b2e1:2f3f with SMTP id d75a77b69052e-530c8775a20mr54660751cf.54.1789122602244; Fri, 11 Sep 2026 03:30:02 -0700 (PDT) Received: from [127.0.1.1] ([178.197.219.214]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-49e61a81943sm38651965e9.1.2026.09.11.03.30.00 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 11 Sep 2026 03:30:01 -0700 (PDT) From: Krzysztof Kozlowski Date: Fri, 11 Sep 2026 12:29:39 +0200 Subject: [PATCH v4 6/7] drm/msm/dsi: Fix indentation of if block in dsi_mgr_bridge_mode_valid() Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20260911-drm-msm-hdmi-fixes-before-eliza-v4-6-87bdb9f1987f@oss.qualcomm.com> References: <20260911-drm-msm-hdmi-fixes-before-eliza-v4-0-87bdb9f1987f@oss.qualcomm.com> In-Reply-To: <20260911-drm-msm-hdmi-fixes-before-eliza-v4-0-87bdb9f1987f@oss.qualcomm.com> To: Rob Clark , Dmitry Baryshkov , Abhinav Kumar , Jessica Zhang , Sean Paul , Marijn Suijten , David Airlie , Simona Vetter , Archit Taneja , Maarten Lankhorst , Maxime Ripard , Thomas Zimmermann , Rob Herring , Krzysztof Kozlowski , Conor Dooley Cc: linux-arm-msm@vger.kernel.org, dri-devel@lists.freedesktop.org, freedreno@lists.freedesktop.org, linux-kernel@vger.kernel.org, devicetree@vger.kernel.org, Konrad Dybcio , Krzysztof Kozlowski X-Mailer: b4 0.16.0 X-Developer-Signature: v=1; a=openpgp-sha256; l=859; i=krzysztof.kozlowski@oss.qualcomm.com; h=from:subject:message-id; bh=/YVh+L5neHC3SlylyZSkY52kedS/7Okrqq86t4o1xdw=; b=owEBbQKS/ZANAwAKAcE3ZuaGi4PXAcsmYgBqo9gUEvxbxfeqW8YDt9/GLaS5x5T5jcZJa3s+8 kkxvK6JiJWJAjMEAAEKAB0WIQTd0mIoPREbIztuuKjBN2bmhouD1wUCaqPYFAAKCRDBN2bmhouD 12WpEACOzE9Xk7yADRzq2MiKw2PpOehQm/+4vq79EC+vwMlvAPXnG1cHwOpJjW4JG/MW7wcka9U ZIWaWV/x2hlkOWfBoSfGck+VdKhdu9ZHotftqhFQhA4TbtXAF+FAF51H/EXSOrXGJqncVGozcqI a0d2yls1JYtHMLKtrHyjkm4wfWUBEHOfTd1umg9NknYdN4AJdce5Wh1ZXEt6QE8ZCr+FSgY/yJc G+1LwWO86s4vHH79ekMlHSHoPh73u/826IVeoL66rnYXSaWCmE1/Kid7HX7yYofPACoXzdWsxMB E44pnSCuE7u04vdOkLLWlB5lA/yu70vHKoIGgr7sQ4CleVkk5ShUmTLOBm66kSOKGJZbpd4JRED D2VswGZIbyGDtDG42Ucz6pj7E0+r6b+FTwSw8840tqy/dTcMqGN9BqQ0oTxL86XT/GlfXFmGgnw Q5n5AnVZ7ZLVaCT33OS5A6ttBx89BC0KL+NrZDzOIdzaS5lAet+ZMg1B0MeBggIBB7Vk5xTfi7h pjs99o+Uh4q95rm2e/NC0dJ0RiyJYqv1oTY4SjbfOAuTspTR8Bgmf6m75jvgrd+TEmEchHNMTew +spZLfv36eHkYxcJbMibKGE09WVIHoeA6NN3FYmj+akkkeoAYbSynF6fd31mkuQ9PAzpjxcPS26 E+Qt1a/qixu5ETA== X-Developer-Key: i=krzysztof.kozlowski@oss.qualcomm.com; a=openpgp; fpr=9BD07E0E0C51F8D59677B7541B93437D3B41629B X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwOTExMDE0NiBTYWx0ZWRfX2pO96V+ISGjB eJpbF9DEkoqyA763NAfvNrVpSouCNkC6Rin39V75IsKJ3RZ5Uld92GhogYom99iWXc68M2InpAZ 1h2LDk8aMM2BeoZdCvmen9RUSZ8dDKe9YqryGYZ0nf1sws/+vEzB3JzkymoM/aJm6paSo8yJN5A 0F1Jc00TO3XkVs8/sj7PAttaDdPKB5y6HfszV1+R/57xnUFrPLy8ef8tpDnAZwZWovLWf49Q8Gy vP3im0wpgJUF3f7qWL+8t+a5f9zqtvP+9rYhuDfyVH/nyA1P3XYAxWzBaIxhPFpuZHsdHQUvUyd N8dXXcw3fLoeg0ckByQn1x1pmvtHHfCA6GQUYAIeXA2oHdCLhq4GGoQm5P+P9Ip7IW9DHcwNKCn DXthOEiQ0Sg1HsPjUf/aip8JP3HolMCwONMpFgxSjZY2c3DOV1Z+X3IxAmfKZTdgjNk1TXFyqJI vIf9NaDoxcpVtO+Z7Mg== X-Proofpoint-GUID: MnYkOi6i-Gurt9YGT7kmPJdAG5VbpJL- X-Proofpoint-ORIG-GUID: MnYkOi6i-Gurt9YGT7kmPJdAG5VbpJL- X-Proofpoint-Spam-Info: AW1haW4tMjYwOTExMDE0NiBTYWx0ZWRfXwlO04CfZcmFi Xzp+I8aORpaqtnxNg6PWi+cAT0gysjrCrpPIYB3UtQyzVzsHQorLHGwZWKa8vGAh0ZRhHCN0R+p XrpZhZApimg0n5ZFbzmAWF78deWG8jE= X-Authority-Analysis: v=2.4 cv=ULtIjyfy c=1 sm=1 tr=0 ts=6aa3d82b cx=c_pps a=EVbN6Ke/fEF3bsl7X48z0g==:117 a=+bKQE0WJfmhK2875HamI0Q==:17 a=IkcTkHD0fZMA:10 a=VdqzKS8jKosA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=yx91gb_oNiZeI1HMLzn7:22 a=EUspDBNiAAAA:8 a=mamL7KDpJlut8y4y1IgA:9 a=QEXdDO2ut3YA:10 a=a_PwQJl-kcHnX1M80qC6:22 X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1176,Hydra:6.1.134,FMLib:17.12.100.49 definitions=2026-09-11_03,2026-09-09_02,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 priorityscore=1501 adultscore=0 phishscore=0 bulkscore=0 clxscore=1015 malwarescore=0 suspectscore=0 spamscore=0 lowpriorityscore=0 impostorscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2609040000 definitions=main-2609110146 Correct confusing indentation within else {} block in dsi_mgr_bridge_mode_valid(). Reviewed-by: Konrad Dybcio Signed-off-by: Krzysztof Kozlowski Reviewed-by: Dmitry Baryshkov --- drivers/gpu/drm/msm/dsi/dsi_manager.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/gpu/drm/msm/dsi/dsi_manager.c b/drivers/gpu/drm/msm/ds= i/dsi_manager.c index 959daa88b1d0..531d4ff78f56 100644 --- a/drivers/gpu/drm/msm/dsi/dsi_manager.c +++ b/drivers/gpu/drm/msm/dsi/dsi_manager.c @@ -429,7 +429,7 @@ static enum drm_mode_status dsi_mgr_bridge_mode_valid(s= truct drm_bridge *bridge, if (dev_pm_opp_get_opp_count(&pdev->dev) !=3D 0) return MODE_CLOCK_RANGE; } else { - return MODE_ERROR; + return MODE_ERROR; } =20 return msm_dsi_host_check_dsc(host, mode); --=20 2.53.0 From nobody Fri Sep 25 14:32:37 2026 Received: from mx0b-0031df01.pphosted.com (mx0b-0031df01.pphosted.com [205.220.180.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id BFF61456E1C for ; Fri, 11 Sep 2026 10:30:06 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.180.131 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1789122609; cv=none; b=bTkQLBJ30BjIaA/u4SQyAoT97e2stOXM/J+UxlATU2G87pN5RwZ21OO2EU9CIqc9f00R/u4ISMpIz251sruO5DLpl0M+k1xzzGELELsqlQpUHH5pE40HqvSCgeMWovhyYjZzTiFWaByOnkiIb4t6G+qg4PjnCNgbpV3fE2knQ+o= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1789122609; c=relaxed/simple; bh=OkF3pqNY5sBAsIguyZS7ydBERaknMe6JM23521127sE=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=p71N5JOEvdi6Org46H1BPKawdgRB2jMN1uTiooEAULOqyc2lbxxFBO2tOV3VxccFEjX2rBvF0vAhzecHAZuTgd95iPlRZv/x606gH0NQZSKSmkcHBEbxVBqxR/Ps8NATwRku7tYBAC3ZAJ445+Uk/Q2ZVBlg0CuCz2fYLM7wnkY= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=K3ZhNICD; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=HT7uK/zY; arc=none smtp.client-ip=205.220.180.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="K3ZhNICD"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="HT7uK/zY" Received: from pps.filterd (m0279870.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 68B7l16u3687109 for ; Fri, 11 Sep 2026 10:30:05 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= t5bFar5H27cJqwd2WNphcoVppq++/ChGc+WspNucP9M=; b=K3ZhNICDVGGt3Ja4 3PifMTjl3NR1UemPKIR1cwfgJ28JuWrRTLjE7qBPv2d/vZPTtvJI0zXX1MA7gfAR HaEXXKvOrNBp/XSKVEiiM0LkNubr2u2YwyZ2kaHDfX9hNvLIR4eij++P2f2e4t4A 0kWvZ2PAzmO3ipSVHWMZVUGP5zqg9RKNLasi4KIrHCqhdenLcrGX309HBczozJaO bROvySyf7VMj9wPFOnbgKgVDKd2Cxtq56PoJbUwdOONC4msWlZpKJct3H9iTBJ6b H5Z2wnzqRTnEyIW1BOYuHLRSuggbNjqQI0+yyx4lmpmVgYfmPpYUA008iIGnn/nS 2AD6uQ== Received: from mail-qk1-f197.google.com (mail-qk1-f197.google.com [209.85.222.197]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4gmapg1bqj-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Fri, 11 Sep 2026 10:30:05 +0000 (GMT) Received: by mail-qk1-f197.google.com with SMTP id af79cd13be357-93771aa0379so126072085a.1 for ; Fri, 11 Sep 2026 03:30:05 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1789122605; x=1789727405; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :content-type:mime-version:subject:date:from:from:to:cc:subject:date :message-id:reply-to:content-type; bh=t5bFar5H27cJqwd2WNphcoVppq++/ChGc+WspNucP9M=; b=HT7uK/zYsh+8N6Ikh4wSNx6TQR+v9znuOLezXPPmn1tsqLFyk8QgpbXMflAkrLcDgk oYscAW9yve30sazdQtSYOrtFJU+33OAw7H6io90O/sHQCKLuWuzwACi6sad6ud7JBKhG Zw1H9r8Zo25c+kJjeabkKC6j4mhRBB9VKC36PkazWJM48Nemy1afrzwnCOtco1yZIC5f 5ha2CT0xCbMzvgknkLQdIZWrIyaID1T5KkyawnfwvOi27T6FoRRwBa0JgTsGDusGzWpM TR2SMRES152zALf2N5gO/CxuXMjsD5kA/hP/HoLBHElbmc/PfNX8HPa9B7bz9WP0Yap9 9/nQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1789122605; x=1789727405; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :content-type:mime-version:subject:date:from:x-gm-gg :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to :content-type; bh=t5bFar5H27cJqwd2WNphcoVppq++/ChGc+WspNucP9M=; b=lWK5fo06t+CyWD3ug6O7wtvvyoJNI9ayTdXcKn5cEcjv0bPJcAezFjUluYuNu1UJuH 93xcrDK78W93P1dcYpMHg34Pa88a0yylHCmjeEsRKlZ02D/6LsjGz60iDlkmKClxOdpC doAfE3L9aPnxtiBiSjkSLRZlAFauXQhe87fSV/r/bf/66MaJH/3b5UNVNYAdRJ5tEKTG Z12l91iIWO5ub40yjImpm3EwF8g3GlXVeO/USqKfuMaMUONBObL5csL2tfL6EBHWFZYQ 4SJZQjPThQ6mBUzzUE8DpjxarLmMCTd93cAu8TGFGSZoTFThtZ3rAsO8FK/FWqBc8S7l g1UQ== X-Forwarded-Encrypted: i=1; AKwUvBxHB+3aYYZMIsYLlmW3dyZMwENMZTFMFiBfVxQDMgpdjl4wmccCVPID+1p6osgI3Ut9LAwiFe07kEpqVvk=@vger.kernel.org X-Gm-Message-State: AFuF++nXmK3V8pEfBzhmVEf3hwcN/zYltHZYRxW40k92S4QrK9mkYyDL mPjkV83JMPfMB4sA1zT+x2RjevoJAK1VvR0IUEISsV2h6N6P26KWXTDeaTsWkf7FY+CyPBZrhpD vXTtKB73DOIaM3xgR0SubLSrpu+AtBPEk9A9b4JJ24RobzukOdcOsN8ZIYVr3B+gGl3E= X-Gm-Gg: AYBFou3/7/puOWlwWchtTvOilPtpUuIVTI8Y0L5RGBGeidMgC9Og1NEnwJf0RZvQ+cL jrdw5N1xaLPHigjEbX2lRHyGayjKJwEpLUSyNXeaFjAgCuE8yfs4JTsrcRpG5iaIVePlWA6cwZl eSpf2II6z+6WGt5IJzFMKhsntSTCHoXwj9t78vLQXKUqInWcUmpUcdBcy2p73juQpEkxqDi1cKw wzg6jGFT/hVWJ64R0dO4lNEVvbuNQ/IuWlHBwJLJof1uTD4HJVm4T+CtaNDCEmf7Bo4moCGcc+x hSdWvZyWdQOxQ71xwdw9LJsvq35/KxJyY0jxYfaEQPzV4m3I0OkgPyj+kpiVgYb2InqN0j3fSUz EFDgih+PmhV29yXazo+JDbtk= X-Received: by 2002:a05:620a:288b:b0:939:6de6:9517 with SMTP id af79cd13be357-939ea2bf754mr384621785a.46.1789122604962; Fri, 11 Sep 2026 03:30:04 -0700 (PDT) X-Received: by 2002:a05:620a:288b:b0:939:6de6:9517 with SMTP id af79cd13be357-939ea2bf754mr384617385a.46.1789122604515; Fri, 11 Sep 2026 03:30:04 -0700 (PDT) Received: from [127.0.1.1] ([178.197.219.214]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-49e61a81943sm38651965e9.1.2026.09.11.03.30.02 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 11 Sep 2026 03:30:03 -0700 (PDT) From: Krzysztof Kozlowski Date: Fri, 11 Sep 2026 12:29:40 +0200 Subject: [PATCH v4 7/7] dt-bindings: display/msm: hdmi: Correct name of disallowed supplies Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20260911-drm-msm-hdmi-fixes-before-eliza-v4-7-87bdb9f1987f@oss.qualcomm.com> References: <20260911-drm-msm-hdmi-fixes-before-eliza-v4-0-87bdb9f1987f@oss.qualcomm.com> In-Reply-To: <20260911-drm-msm-hdmi-fixes-before-eliza-v4-0-87bdb9f1987f@oss.qualcomm.com> To: Rob Clark , Dmitry Baryshkov , Abhinav Kumar , Jessica Zhang , Sean Paul , Marijn Suijten , David Airlie , Simona Vetter , Archit Taneja , Maarten Lankhorst , Maxime Ripard , Thomas Zimmermann , Rob Herring , Krzysztof Kozlowski , Conor Dooley Cc: linux-arm-msm@vger.kernel.org, dri-devel@lists.freedesktop.org, freedreno@lists.freedesktop.org, linux-kernel@vger.kernel.org, devicetree@vger.kernel.org, Conor Dooley , Krzysztof Kozlowski X-Mailer: b4 0.16.0 X-Developer-Signature: v=1; a=openpgp-sha256; l=1237; i=krzysztof.kozlowski@oss.qualcomm.com; h=from:subject:message-id; bh=OkF3pqNY5sBAsIguyZS7ydBERaknMe6JM23521127sE=; b=owEBbQKS/ZANAwAKAcE3ZuaGi4PXAcsmYgBqo9gVrcZu/TMDuP1i7PORWJEkHVwIonipCvxhL qXzj3ig7OWJAjMEAAEKAB0WIQTd0mIoPREbIztuuKjBN2bmhouD1wUCaqPYFQAKCRDBN2bmhouD 15DsD/oC+uEKgZ7M5J4X4LpAk/JlszlMZ2civ+kPChZIYdG2ZJ9RYC5bHey27wDiMIrv7YSLK38 u4C9MfRPd9xqE6nuH5qayj/jAjOfUVqttQkyzZFqAVtU0vXFY8DatvN/oYC1OiIga0wRc3yzw8c KeypBp3vOhR7QiSQDpqCnEZJE8T/G01setUm1hmNMZoVahF++feF233o4tKWGPqppFdC7vufVEh a78a4ytiNRAh3h9FkC7Io3M1FM7gqZfIWykCIW0RrKHkAAZ/+OnsmCGgW+9701J99atgPBwuxPf dBEjN8cvEnVghDl5nLpoR+4s9GGS8jYF4BVPpJEBxYRN2F8xAtA4NmwxONUahJLMO2Qggb0d5Ah ZZxCRoQ4Oi3uH0FbcViqkHJ7nbLOMPmlvKhgQE5YclDTV4rCfPkpOh7ej3V6LhU0iWtUpGPU57z Wh/i3zYgt6HAFC13buF5fu2bK1IeUXsQeX0klMXEbCrYlOQBKmU/r0cQhVDFWmd7r+npJmKii9V wcgpfBjCtWr6x2GrRE66WTujzwBUBSnBfxv++aJqeWB81Amu955ZP3lWdkYwRnzLIrmRMGqZBlO ljhkeeX+ggqnEyAl7gcZMa+JRgjZJIaJOqb1y6yIZiHHegNp7pYYp9Rp1Pbsd/98Yb24Vo7Ckeh NVptqF+TywOqi3w== X-Developer-Key: i=krzysztof.kozlowski@oss.qualcomm.com; a=openpgp; fpr=9BD07E0E0C51F8D59677B7541B93437D3B41629B X-Proofpoint-ORIG-GUID: 5n6B1cLh0r5_i0LlsQxo9K4aeDo17VAY X-Proofpoint-Spam-Info: AW1haW4tMjYwOTExMDE0NiBTYWx0ZWRfX5YBMSoki/4Aj 7RpyQ7jyaGfhzi+zmjSS/VRqS7V+OsG7XEP7PYlBZyet/Nn9wB1L4VFvtcva9g0MTKmGP8OJ42W ughrar8LhViKKs9bvw/84rcWH2ik0iA= X-Proofpoint-GUID: 5n6B1cLh0r5_i0LlsQxo9K4aeDo17VAY X-Authority-Analysis: v=2.4 cv=DLoacCNb c=1 sm=1 tr=0 ts=6aa3d82d cx=c_pps a=50t2pK5VMbmlHzFWWp8p/g==:117 a=+bKQE0WJfmhK2875HamI0Q==:17 a=IkcTkHD0fZMA:10 a=VdqzKS8jKosA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=gowsoOTTUOVcmtlkKump:22 a=XYAwZIGsAAAA:8 a=EUspDBNiAAAA:8 a=LSMMCDwwRte7x3nqQVUA:9 a=QEXdDO2ut3YA:10 a=IoWCM6iH3mJn3m4BftBB:22 a=E8ToXWR_bxluHZ7gmE-Z:22 X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwOTExMDE0NiBTYWx0ZWRfX/K0Gr4amhdx8 1auEhfv7lqsQscuH+WcptRo4m3x+HmAM2QMhvUFbm5HzmfPpzTajoXxyZCVklGyzqY11dgoWE8T EcIzpZj+LD/2XZJPMg9Ct9bqP8QO9MShw0G59nzf/ngSnH3ZeukyNndym1VWyIIdX7rqxTcVBPG 59z1HvWkSZSk64h7/EPjFqwWYSvKkimeESY34wKdYjqAoT8X/s6i74rrCzlMm/YKKY1q5mwBa6n 99ZCPTg9/NK1eqoJxm++Wyui9f548y7tEniT/BwQNl4CofyeO/d/Huk4OxgRtHJCRnHUCMkVBr6 8q3/O5wCeG4OD2EI9VLoLTuEbE+FTgjXioI3Qnt5Cxqxm1KgnLddMPMSIFpuq++HSl1GWrPj6WX THAG6McYNwoK4sw+RCiiB83x1eF7zEUN3JR2WGa3g9E7Op7aMqUIksKMMuAL3Zx1RsR4m5MlOrZ Br2eG6+Zs+OIXZeN8Mg== X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1176,Hydra:6.1.134,FMLib:17.12.100.49 definitions=2026-09-11_03,2026-09-09_02,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 malwarescore=0 priorityscore=1501 phishscore=0 adultscore=0 suspectscore=0 spamscore=0 impostorscore=0 bulkscore=0 clxscore=1015 lowpriorityscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2609040000 definitions=main-2609110146 There are no properties in DTS or Linux drivers called "core-vcc-supplies" or "hdmi-mux-supplies", so the binding probably wanted "-supply" properties instead (which are defined in the top-level properties of the binding). Acked-by: Conor Dooley Signed-off-by: Krzysztof Kozlowski Reviewed-by: Dmitry Baryshkov --- Documentation/devicetree/bindings/display/msm/hdmi.yaml | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/Documentation/devicetree/bindings/display/msm/hdmi.yaml b/Docu= mentation/devicetree/bindings/display/msm/hdmi.yaml index dfec6c3480f3..02d27ccad024 100644 --- a/Documentation/devicetree/bindings/display/msm/hdmi.yaml +++ b/Documentation/devicetree/bindings/display/msm/hdmi.yaml @@ -113,7 +113,7 @@ allOf: - const: core - const: master_iface - const: slave_iface - core-vcc-supplies: false + core-vcc-supply: false =20 - if: properties: @@ -136,7 +136,7 @@ allOf: - const: core - const: alt_iface - const: extp - hdmi-mux-supplies: false + hdmi-mux-supply: false =20 - if: properties: --=20 2.53.0