From nobody Fri Sep 25 16:02:52 2026 Received: from mx0b-0002e601.pphosted.com (mx0b-0002e601.pphosted.com [148.163.154.28]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id C2428563FDB; Thu, 10 Sep 2026 17:57:10 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=fail smtp.client-ip=148.163.154.28 ARC-Seal: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1789063035; cv=fail; b=VFrDBI9qxcSDEFbQnkFBpdJQYl21Gm2YKfJkLbKDDO5pPQ1Wjjem0qeydtqM52lbwW6cWx0BXSwAwUJTePbnis5G/F14sLUgmBgHohIShq5juDF/1cfnr/qJxxrF7hAZ6p26Tm2thQm9tbR8Sw4YQcmfWguMoNzrfOCbiye/KBk= ARC-Message-Signature: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1789063035; c=relaxed/simple; bh=3l+N7VRjb7sCYwjUPdOx+NEFhmC5BVJCOEULINgQzmA=; h=From:To:CC:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=P7WpbQEEVsTKL2NAFuo/KMgQKV2h1RunDEFopqOqOlvqalkVY2U/CuM+zpUFN6ug43WjyZlCMMYvaLTeVRTsRZXBfMDFQiE3yjPI1fsKuN83kvra2VkPLmGifkpw16LIZNzRzfTs/P+1hyXMo90hydLHYT0HJ+dpFB1xG3DPoXw= ARC-Authentication-Results: i=2; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=ti.com; spf=pass smtp.mailfrom=ti.com; dkim=pass (2048-bit key) header.d=ti.com header.i=@ti.com header.b=mR6bCtAF; dkim=pass (1024-bit key) header.d=ti.com header.i=@ti.com header.b=uBWUaG6t; arc=fail smtp.client-ip=148.163.154.28 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=ti.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=ti.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=ti.com header.i=@ti.com header.b="mR6bCtAF"; dkim=pass (1024-bit key) header.d=ti.com header.i=@ti.com header.b="uBWUaG6t" Received: from pps.filterd (m0374955.ppops.net [127.0.0.1]) by mx0b-0002e601.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 68AGEWLK3808361; Thu, 10 Sep 2026 12:56:59 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ti.com; h=cc :content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s= proofpoint-05-2026; bh=r76QOfszn/d06cjyEn+KvN63bOkOlgpaVUcFIgF87 no=; b=mR6bCtAFoE5jlu+5J+aQ5pKUTbQ1nUZE1uIsSmMaV8i5Yy1VB5GxCCc8w 9vzc2O7OmgGuITFVVDrXzQd427/Pj5GNvIqphGn+5o77gQbkFf0gkP6Amyps8fnl WwXm67xZJ0xSu0vhPDFcVYHEP4FAS2HtgK7VMKo5E6MHsQ6cSbJgFZNaFENdXcFY YSQrb5Njx3TqgiwmjgtMOnDMQjKeUPpqKhPNAg1oXjbXuo5mR3qlQ6R8Fbiob1OL 76yXNnDoGxKzEi8Xgm9DinIRgCO2wEjdosksRxV4IWzAnSHOhnNIDCsWfgyESpYV K1u+sCtScg/N7NgK3rcPk6nxNF2Ow== Received: from cy3pr05cu001.outbound.protection.outlook.com (mail-westcentralusazon11013064.outbound.protection.outlook.com [40.93.201.64]) by mx0b-0002e601.pphosted.com (PPS) with ESMTPS id 4gkyw9gp0h-1 (version=TLSv1.3 cipher=TLS_AES_256_GCM_SHA384 bits=256 verify=NOT); Thu, 10 Sep 2026 12:56:59 -0500 (CDT) ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=m6SlmtVqHa2AvnHp1U/aXHDKdORu6LnJIiQ5pWD41202bXggxDcmcgZGRNtg/AuYoECOv2f8MahSK8DvocL06LuR9lz2uGJ8E9Pd0z5DI+iF+m0cSpog/H2aiz4Qtb4KHFX1MD279dJ0GqYqtdKH6CCszdCB/hDDJEdhBRxLQDbefcQBLQB5FHmR7XEU2k7LqS7kUtJlvnw+xDrqa/VCChsOZI4j2n6jORWE8kRpZB9C0anpne8wjo5ZBXYtTfEpT4pi7h2u+EsdhpjSewA5SNev5bkT1uIHWZGqkOltZVgckrywP6oKNxOppUcKo8WoA2CziBUTG8qk+VgbPrONZQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=r76QOfszn/d06cjyEn+KvN63bOkOlgpaVUcFIgF87no=; b=kxjC0bdo6baRZnE3tcQTmn1+V2jjW0+2BpKH6D9dwxJfnBkw/5I/Kkq0TIXRJi6SQpNXVM8W8O4AEGJvBq5hTFCjt3CnxyXl8L17mbdCxYlJty2uhCzVL/wdK7QwcbNqFBzTsi1b9cYOgiGI1NivuQ0a31hZLQJJKsiXvf5sT9+zG/qF6JjMYg+ZeNIk8D0Nk+uT1/gSodoN2kqcCR+ZFIJcEvjEgBcNRIOIEXhrTLkDp4aorSElmk+/0fWiAO6ROfQHv2pk6k41OMwMzVXV2N5TG1zmpZt0JCuQE08zFS3ZNApu514gMYtm2byoNDHWCYF53SKfdngRLd2tpe/IiQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 198.47.23.195) smtp.rcpttodomain=gondor.apana.org.au smtp.mailfrom=ti.com; dmarc=pass (p=quarantine sp=none pct=100) action=none header.from=ti.com; dkim=none (message not signed); arc=none (0) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ti.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=r76QOfszn/d06cjyEn+KvN63bOkOlgpaVUcFIgF87no=; b=uBWUaG6tIetZuA9NoPKmlNqDbiBlEm9pCsOGA9aY/R4z1wOq7Ax7XSDJej2hkE+2ODPUuzzYMzutGKMnpD6zyB3CbGvfqURFuRZrJ/In7luQ9mQYyA4NnJcz+Na4Xnn1H8ZlA49JAcXls38kltAnN4mEDlk74EZ359wxE7R7wKY= Received: from BN1PR12CA0027.namprd12.prod.outlook.com (2603:10b6:408:e1::32) by LV3PR10MB7795.namprd10.prod.outlook.com (2603:10b6:408:1b6::12) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.21.428.5; Thu, 10 Sep 2026 17:56:55 +0000 Received: from BL6PEPF00022573.namprd02.prod.outlook.com (2603:10b6:408:e1:cafe::63) by BN1PR12CA0027.outlook.office365.com (2603:10b6:408:e1::32) with Microsoft SMTP Server (version=TLS1_3, cipher=TLS_AES_256_GCM_SHA384) id 15.21.406.9 via Frontend Transport; Thu, 10 Sep 2026 17:56:54 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 198.47.23.195) smtp.mailfrom=ti.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=ti.com; Received-SPF: Pass (protection.outlook.com: domain of ti.com designates 198.47.23.195 as permitted sender) receiver=protection.outlook.com; client-ip=198.47.23.195; helo=lewvzet201.ext.ti.com; pr=C Received: from lewvzet201.ext.ti.com (198.47.23.195) by BL6PEPF00022573.mail.protection.outlook.com (10.167.249.41) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.21.406.5 via Frontend Transport; Thu, 10 Sep 2026 17:56:53 +0000 Received: from DLEE213.ent.ti.com (157.170.170.116) by lewvzet201.ext.ti.com (10.4.14.104) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.2562.45; Thu, 10 Sep 2026 12:56:37 -0500 Received: from DLEE204.ent.ti.com (157.170.170.84) by DLEE213.ent.ti.com (157.170.170.116) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.2562.45; Thu, 10 Sep 2026 12:56:37 -0500 Received: from lelvem-mr06.itg.ti.com (10.180.75.8) by DLEE204.ent.ti.com (157.170.170.84) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.2562.45 via Frontend Transport; Thu, 10 Sep 2026 12:56:37 -0500 Received: from pratham-Workstation-PC (pratham-workstation-pc.dhcp.ti.com [10.24.53.205]) by lelvem-mr06.itg.ti.com (8.18.1/8.18.1) with ESMTP id 68AHuZG62793554; Thu, 10 Sep 2026 12:56:36 -0500 From: T Pratham To: T Pratham , Herbert Xu , "David S. Miller" CC: Mert Seftali , Sebin Francis , Manorit Chawdhry , Vishal Mahaveer , Praneeth Bajjuri , kernel test robot , "Dan Carpenter" , , Subject: [PATCH v4 01/15] crypto: ti - Use list_first_entry_or_null() in dthe_get_dev() Date: Thu, 10 Sep 2026 23:26:05 +0530 Message-ID: <20260910175619.2122149-2-t-pratham@ti.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20260910175619.2122149-1-t-pratham@ti.com> References: <20260910175619.2122149-1-t-pratham@ti.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: BL6PEPF00022573:EE_|LV3PR10MB7795:EE_ X-MS-Office365-Filtering-Correlation-Id: 5029414b-e001-4bed-1abc-08df0f64e585 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|36860700016|376014|23010399003|82310400026|1800799024|10067099003|18002099003|22082099003|56012099006|13003099007; X-Microsoft-Antispam-Message-Info: ubiLvY4PD628L/cPokRgt+fWoUAg/Y97Ez/YD3kd3Yhdqpk3DBKSTUV1kflSOuxfYuaz8xwpvtB/SlIRQ7nGsS349YQrAuIiVOuf/0eRh28eaN9EJVY6mdq0eDV1ET18NLESlLXp99t0gQ8FYDHIYMFAGK8zfclXiER+3HrGhxBRHbfFdmO+hphzxTwMHTm5vxodTY1XoegVrZJxskUkuRLh/QUPpUBwG2gfny9JlbsOro0bIBHIn0bMHpHOYaO4y/sgbpIXlJe4IbXH9PjSUOnRoqOv4vbEIuwqa/zC18AV+NkunymAO/NK0Ir4TOG6WRNubmDfGd+/lyPU9+Yw+x54BkA3KzMjbsdncjcXtD/qNoBa1PYeYAGFCeNBJdEn4ikhWiSkJmJSGyuDoNBTo/NyqyRN3xySgkhEK5AI9KwcNRq6+bMnidpys8gKn2lEoQhkmvhooXXWTCxc9SKr0tdXvKN2dDYzYSkG2NMpASVgMPZIW7NoKT0P5qrVrMnT9KjXQstcHZQSu5fQUr+2OcozYQL4y4rngU4TbZWLc4Ja1ooWTzNDVOII1mTNBf1aAsv/dFcgDJw8gixaitdAqiUNTSJggbk0jnNTEpqLZfV4oEKBZZwHD+ugmHcXinxcmfxfieSeb34d+lYSMXAjvQ== X-Forefront-Antispam-Report: CIP:198.47.23.195;CTRY:US;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:lewvzet201.ext.ti.com;PTR:InfoDomainNonexistent;CAT:NONE;SFS:(13230040)(36860700016)(376014)(23010399003)(82310400026)(1800799024)(10067099003)(18002099003)(22082099003)(56012099006)(13003099007);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: KE5rOVQyTLarYlnDxpKnAdsuox7ZPOzl0rjraKHpNHFumq25AriymSwPjTjck5tkmArjA2p0svC39wuN6xiEUGCZi4EEa4sYhLJHlTkTmVmYFxT/0V7aVfol/yrpcMEDOBBCeIXsk1NfGW83uDw2H+9KEDPY5j2dTSBZnBG24e0g80BOsQ3+QCmqYe+X00Xe8dIduKG6w6xWPuHtEPDMfp5ICP5ZYx1n5MdGkNCGjKxrsScR3eT/qL01uKJH4bgSF0UaCT+5KvbqPO1urR9b1B/0OkjQSQux3fOwcJtC5k6ELpbqFn/PQS2A30nZOZh6K1oKvWJG7SvUAOEE0/AJhxR89kLCH0kJ8xkB0oUQhwvGWyiCi/5z954AwhxtmsXEQSvTYSzD2ASWxpAN7ILlywMEGILTuIAl1iUG5yBoEMmM4ta+npuggxaLQujdX4+V X-Exchange-RoutingPolicyChecked: VJ7gI4YlRWAOBiSvitGFPtx9ah/X7F4dB4QO7AqOnssZb92boYiT0QUvdTI1FKoVR9UucweixY6u2cLyRTmJQwuqWIoVNCTqW/s4PmHv/8kh80hwwkEulV5QVVj+MfGaEizcsS7yBUS8esHAmNbkWVvq38sVqaZf6eNxLHYeVXroHiF/ee58A6tMaA8Dz8Y/PfUD0hSycpodpkFCZV7NjsfDVjamUd7ZTqaGUe/fuUgzYIvazNYan6zI4/deT8a+kt/XLSRjBemk9q9Jo0GoaeBiMYOjBMDpREYvsjPPG2Ej8rMiNw3zOAzVgyYkPWNc8SsMGZSQ1EKeMgrwVcotFA== X-OriginatorOrg: ti.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 10 Sep 2026 17:56:53.0555 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 5029414b-e001-4bed-1abc-08df0f64e585 X-MS-Exchange-CrossTenant-Id: e5b49634-450b-4709-8abb-1e2b19b982b7 X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=e5b49634-450b-4709-8abb-1e2b19b982b7;Ip=[198.47.23.195];Helo=[lewvzet201.ext.ti.com] X-MS-Exchange-CrossTenant-AuthSource: BL6PEPF00022573.namprd02.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: LV3PR10MB7795 X-Proofpoint-Spam-Info: AW1haW4tMjYwOTEwMDIyMCBTYWx0ZWRfXyZmK2U1Q1fJP EWDl1FWTi3cmYH2ZDXOBbl5aTiIuOv8ql76z+4AwWDE0sAIh9h+F5phGvGXG28pj9nfxZSswTCL KQ5PJctnQl8qP0FtPl+umt8rhMXDGgE= X-Authority-Analysis: v=2.4 cv=ON6yTiaB c=1 sm=1 tr=0 ts=6aa2ef6b cx=c_pps a=ff0lUGClKvTotTGlvMT8aw==:117 a=f+v6EHfkeJbVwR46tk4DMg==:17 a=6eWqkTHjU83fiwn7nKZWdM+Sl24=:19 a=VdqzKS8jKosA:10 a=s63m1ICgrNkA:10 a=V5UXEbMT0ywA:10 a=VkNPw1HP01LnGYTKEx00:22 a=Z8NIEmU8O1QQgoT56wFK:22 a=fPAWb5peG099m5CrUpKH:22 a=VwQbUJbxAAAA:8 a=QyXUC8HyAAAA:8 a=pGLkceISAAAA:8 a=sozttTNsAAAA:8 a=HYHyqeARaHjSmq2Pe6sA:9 X-Proofpoint-GUID: k11WqPHmEpwnZhFGGPRLRO-JaogfU8Ar X-Proofpoint-ORIG-GUID: k11WqPHmEpwnZhFGGPRLRO-JaogfU8Ar X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwOTEwMDIyMCBTYWx0ZWRfX6RQQ1cLLehMj GY2gYA8Eh/kHkj7RZ5TBI35IZYH7eRALrb9KMy8M+8BrciJtZSYJiLIA77XwJPT07C/gOyf5ECQ DBvjrrFNMpTJ806c+F3bibGMyCThaVGoDoIiq8bLzj9iJ9oYWOpMnCbzjRrMgGjyHWl27+1eYoK v//Jd78hVfdGLVqpiqENL/7NttCxcKQMYsxqcdUAEmzR9FAh+UraoN3GrQ0SsKs1J6MHQy3gGhL qyeneduI0C1VaEPvBEh97tfw2HXkCinNPuMXqTYSzIgJ7fMO8KGCaTpvXtmsbQeAscC8s/j24qq XYGNDVIb7SDIzCSkTRLDKZgSztqPZu904n3uoL2xw/HROPmFMAQb1Kb5fnewd2J/hYTwNzvp9j3 PPgmtjVUneJFb43D1KlwkPdsudXqGlE2S8/SHfGN4+eD2h0J8Y0GEwqgV29+23Kb8gAiJ4UOksL ZcLmxecOW+nAMvY1qRA== X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1176,Hydra:6.1.134,FMLib:17.12.100.49 definitions=2026-09-10_05,2026-09-09_02,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 impostorscore=0 adultscore=0 clxscore=1015 phishscore=0 bulkscore=0 spamscore=0 suspectscore=0 malwarescore=0 priorityscore=1501 lowpriorityscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2609040000 definitions=main-2609100220 Content-Type: text/plain; charset="utf-8" From: Mert Seftali dthe_get_dev() fetches a device from the global device list with list_first_entry() and then checks the result for NULL. However, list_first_entry() never returns NULL: on an empty list it returns a bogus pointer computed from the list head. The NULL check is therefore dead code, and an empty list would be treated as a valid entry and moved around as if it were a real device. Use list_first_entry_or_null() so the existing NULL check works as intended and an empty list is handled gracefully. [pratham:] Add null checks on dev_data in callers of dthe_get_dev(). Fixes: 52f641bc63a4 ("crypto: ti - Add driver for DTHE V2 AES Engine (ECB, = CBC)") Reported-by: kernel test robot Reported-by: Dan Carpenter Closes: https://lore.kernel.org/r/202606111933.69GGTKxr-lkp@intel.com/ Signed-off-by: Mert Seftali Co-developed-by: T Pratham Signed-off-by: T Pratham --- drivers/crypto/ti/dthev2-aes.c | 12 ++++++++++-- drivers/crypto/ti/dthev2-common.c | 2 +- 2 files changed, 11 insertions(+), 3 deletions(-) diff --git a/drivers/crypto/ti/dthev2-aes.c b/drivers/crypto/ti/dthev2-aes.c index eb5cd902dfb59..4fdd24ee91637 100644 --- a/drivers/crypto/ti/dthev2-aes.c +++ b/drivers/crypto/ti/dthev2-aes.c @@ -112,6 +112,9 @@ static int dthe_cipher_init_tfm(struct crypto_skcipher = *tfm) struct dthe_tfm_ctx *ctx =3D crypto_skcipher_ctx(tfm); struct dthe_data *dev_data =3D dthe_get_dev(ctx); =20 + if (!dev_data) + return -ENODEV; + ctx->dev_data =3D dev_data; ctx->keylen =3D 0; =20 @@ -124,6 +127,9 @@ static int dthe_cipher_init_tfm_fallback(struct crypto_= skcipher *tfm) struct dthe_data *dev_data =3D dthe_get_dev(ctx); const char *alg_name =3D crypto_tfm_alg_name(crypto_skcipher_tfm(tfm)); =20 + if (!dev_data) + return -ENODEV; + ctx->dev_data =3D dev_data; ctx->keylen =3D 0; =20 @@ -571,10 +577,12 @@ static int dthe_aead_init_tfm(struct crypto_aead *tfm) { struct dthe_tfm_ctx *ctx =3D crypto_aead_ctx(tfm); struct dthe_data *dev_data =3D dthe_get_dev(ctx); + const char *alg_name =3D crypto_tfm_alg_name(crypto_aead_tfm(tfm)); =20 - ctx->dev_data =3D dev_data; + if (!dev_data) + return -ENODEV; =20 - const char *alg_name =3D crypto_tfm_alg_name(crypto_aead_tfm(tfm)); + ctx->dev_data =3D dev_data; =20 ctx->aead_fb =3D crypto_alloc_sync_aead(alg_name, 0, CRYPTO_ALG_NEED_FALLBACK); diff --git a/drivers/crypto/ti/dthev2-common.c b/drivers/crypto/ti/dthev2-c= ommon.c index a2ad79bec105a..cc02449382673 100644 --- a/drivers/crypto/ti/dthev2-common.c +++ b/drivers/crypto/ti/dthev2-common.c @@ -40,7 +40,7 @@ struct dthe_data *dthe_get_dev(struct dthe_tfm_ctx *ctx) return ctx->dev_data; =20 spin_lock_bh(&dthe_dev_list.lock); - dev_data =3D list_first_entry(&dthe_dev_list.dev_list, struct dthe_data, = list); + dev_data =3D list_first_entry_or_null(&dthe_dev_list.dev_list, struct dth= e_data, list); if (dev_data) list_move_tail(&dev_data->list, &dthe_dev_list.dev_list); spin_unlock_bh(&dthe_dev_list.lock); --=20 2.34.1 From nobody Fri Sep 25 16:02:52 2026 Received: from mx0a-0002e601.pphosted.com (mx0a-0002e601.pphosted.com [148.163.150.75]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 47B29577E48; Thu, 10 Sep 2026 17:57:43 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=fail smtp.client-ip=148.163.150.75 ARC-Seal: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1789063069; cv=fail; b=D0BiOzynnnzDVp9s7cSki09DNhr2nmXp2shtjqNmPFGcNR/lvikoNLAVXRCYD2r/PQ7JUwN2piFaBOmb9/oACE2lfo4EE9KFEMcQoCrSQE8SfOyGwW/CzJWAW/4p+YtO1k/FtgdunU/clXcWy3lb4/14I8mg/7g1ZjBhGGCXspU= ARC-Message-Signature: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1789063069; c=relaxed/simple; bh=JhIYat1tDDHjynnYJrzFdJBgSwjr7d6SfSSJ0/IQWLo=; h=From:To:CC:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=l5OVmT6XpRW1Nuy9qtAs5GUfzggNWL3gw3FwsXjuv0FX2fockELbyHXiCzjno5aQ7DHiqjTC2XjRVct1pJV7vvV0t4AZZcOP5CarLeGPjdK8TJQ7Kj3EaBD30RYrw460tXG+sH5y0wEzLw8wAYD1wQo+4hZrqWfc+YT849ybgHM= ARC-Authentication-Results: i=2; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=ti.com; spf=pass smtp.mailfrom=ti.com; dkim=pass (2048-bit key) header.d=ti.com header.i=@ti.com header.b=B0CZDQ8/; dkim=pass (1024-bit key) header.d=ti.com header.i=@ti.com header.b=F0DEw5Uo; arc=fail smtp.client-ip=148.163.150.75 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=ti.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=ti.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=ti.com header.i=@ti.com header.b="B0CZDQ8/"; dkim=pass (1024-bit key) header.d=ti.com header.i=@ti.com header.b="F0DEw5Uo" Received: from pps.filterd (m0380145.ppops.net [127.0.0.1]) by m0380145.ppops.net (8.18.1.11/8.18.1.11) with ESMTP id 68AF69GC3468075; Thu, 10 Sep 2026 12:57:39 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ti.com; h=cc :content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s= proofpoint-05-2026; bh=L3d/uqtROV07wByGxF+hfQgPvMnzChdKYg2ED7CQC yU=; b=B0CZDQ8/ifurHJGOhqiQAUthHZ7NLXstxX3JVS251x7BVOdoPlDsVSlTP T/y0ZBTPhnXY206JZA3erWyFQQuPzD5Od1k8VwjQS8e9S5sOfg5+Qcgr3rMBXedQ xokUj2lLvZbn40sdTUNtmBtmi038QyxKqRGoyRQDrzshJ72FE0Hci708XBzQusjC pLAmPgWWYIdgQQSmAVxok6hqbtnDVWlpiuNX1N4bgljN+T08Y7e7nUhUBhV4hpty 9jpPtEeIafTiR3k9JerHcgU8XPxSPb9IBGngXMsSVGi9F283g7/jzLZM9ZFsAUOb fN3wkFJCFTyzoe+X3huC8vgqtCkIA== Received: from bl2pr02cu003.outbound.protection.outlook.com (mail-eastusazon11011053.outbound.protection.outlook.com [52.101.52.53]) by m0380145.ppops.net (PPS) with ESMTPS id 4gkstvb432-1 (version=TLSv1.3 cipher=TLS_AES_256_GCM_SHA384 bits=256 verify=NOT); Thu, 10 Sep 2026 12:57:38 -0500 (CDT) ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=xSZ4wE5jXtRoL6KDAj2iHLJSwObqYYQOmZBIZVnDwyIICa5ac0DfRcF6kXSgtIqJXJ5Ry/CyfKGIBPyWcNhSnjXp0+F445rtXOQLgfxNn/bZdUoPVuDKoKio3odKFd/RqMi5eRlOB5syrhMi7pDzk5Fd8oDpymMqffP5tIu2EMZl2sOcWzO8wqhh8diD/+NMAebNyI5zWN+yTEEmYG7/HvqsoH6D3WfRfLMmIMduXimeYRxx4E/Q5isqfGSTKqHaUDIuXkghIb9rOe4mm4TbtrA0o+qoe/m5aqZ19clriHVO7qgPc4i/pVbKURnTHXwyVCaHnh4apRNEsdDxNN0oPw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=L3d/uqtROV07wByGxF+hfQgPvMnzChdKYg2ED7CQCyU=; b=hG5Xe080RpFg2ALQNoWfK2tBtfDK/pSrvBxhDmYpKGRyaW3gF/bfchs6ZxT0n1PpdHo1b8YDTiFr8OT4bjRMlhKcb1/GFzEtM5U8UVy3sKc18dPAEg5Vw36SQL20uQ0xjxYT/5NDQguVTBEKroiEdrlVCZXcF6pJ/b3l4qHDqdCbTcoKgIJbNLNs+V0srO6DZViQwQUAhsamSMSIhgLxOSOrNomrkjK+J9F3Oh+7JLBu1pwtaXl09uWOEI0zjpF6t5xGQbFGJWHpmJafEPyWBix1AB2H79R3mHx4B5KrghZCFcrDA884ZR2WrJWelWwjetevxidXQ2fFE94bdru/EA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 198.47.21.194) smtp.rcpttodomain=gondor.apana.org.au smtp.mailfrom=ti.com; dmarc=pass (p=quarantine sp=none pct=100) action=none header.from=ti.com; dkim=none (message not signed); arc=none (0) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ti.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=L3d/uqtROV07wByGxF+hfQgPvMnzChdKYg2ED7CQCyU=; b=F0DEw5UonukBMjQ/X9PhrXCxsY+NuyJOWyGUioSFYWOi2lOPmc1NzuMGgis1nrPKMJoC+ArhlXZKkiqwsx0a3KohowrgnxYQ0W8dPVZ/ZeO5DddcdjVZk1Q1pAvQM20AB6oneQQ35mr66fLAyZrY6Uy68llzPzg8ZDMQUX3Ime0= Received: from MW4PR03CA0017.namprd03.prod.outlook.com (2603:10b6:303:8f::22) by CHAPR10MB997720.namprd10.prod.outlook.com (2603:10b6:610:2f7::7) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.21.428.5; Thu, 10 Sep 2026 17:57:34 +0000 Received: from CO1PEPF00012E84.namprd03.prod.outlook.com (2603:10b6:303:8f:cafe::66) by MW4PR03CA0017.outlook.office365.com (2603:10b6:303:8f::22) with Microsoft SMTP Server (version=TLS1_3, cipher=TLS_AES_256_GCM_SHA384) id 15.21.382.12 via Frontend Transport; Thu, 10 Sep 2026 17:57:34 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 198.47.21.194) smtp.mailfrom=ti.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=ti.com; Received-SPF: Pass (protection.outlook.com: domain of ti.com designates 198.47.21.194 as permitted sender) receiver=protection.outlook.com; client-ip=198.47.21.194; helo=flwvzet200.ext.ti.com; pr=C Received: from flwvzet200.ext.ti.com (198.47.21.194) by CO1PEPF00012E84.mail.protection.outlook.com (10.167.249.59) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.21.406.5 via Frontend Transport; Thu, 10 Sep 2026 17:57:32 +0000 Received: from DFLE211.ent.ti.com (10.64.6.69) by flwvzet200.ext.ti.com (10.248.192.31) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.2562.45; Thu, 10 Sep 2026 12:56:39 -0500 Received: from DFLE211.ent.ti.com (10.64.6.69) by DFLE211.ent.ti.com (10.64.6.69) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.2562.45; Thu, 10 Sep 2026 12:56:39 -0500 Received: from lelvem-mr05.itg.ti.com (10.180.75.9) by DFLE211.ent.ti.com (10.64.6.69) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.2562.45 via Frontend Transport; Thu, 10 Sep 2026 12:56:39 -0500 Received: from pratham-Workstation-PC (pratham-workstation-pc.dhcp.ti.com [10.24.53.205]) by lelvem-mr05.itg.ti.com (8.18.1/8.18.1) with ESMTP id 68AHucWY3763605; Thu, 10 Sep 2026 12:56:39 -0500 From: T Pratham To: T Pratham , Herbert Xu , "David S. Miller" CC: Sebin Francis , Manorit Chawdhry , Vishal Mahaveer , Praneeth Bajjuri , , Subject: [PATCH v4 02/15] crypto: ti - Fix spinlock inconsistency in DTHEv2 Date: Thu, 10 Sep 2026 23:26:06 +0530 Message-ID: <20260910175619.2122149-3-t-pratham@ti.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20260910175619.2122149-1-t-pratham@ti.com> References: <20260910175619.2122149-1-t-pratham@ti.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: CO1PEPF00012E84:EE_|CHAPR10MB997720:EE_ X-MS-Office365-Filtering-Correlation-Id: dd8207b8-603b-4567-be18-08df0f64fcf0 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|23010399003|36860700016|82310400026|1800799024|376014|10067099003|6133799003|18002099003|22082099003|56012099006; X-Microsoft-Antispam-Message-Info: n1AgkO5ap/e4xBVsppuFoVL835SBx0boKxBzw8nuiKjX51dge1k09qJ1rH55UIdqylarhsuEG+AAWt0QE4HaogYP6uOxZFLhg/BHjNX0fc0skIL4jMDxDgnmXkU1PfQIDAtlpmowJ4xVFZ/JXTxGv8mT96DpG/b3HYPiZcTTRse/4bCczaBKs5R8t9DpESYBRULVnwF5JmM5Pz7XnNtqK8VHkiFFiUufFW0ML+6BcHHwr6BcZXFtJb+m3Qc5h8AvmBiH36QyF4+bge5wrpIvwV+qBmiFpqhosbgunUE618gWCZU3ELN0pNV5jmxPkGnAHRNGxE8NXSX6aWz8NjlxPXyVIIkwSKc2n/zLrJJox474szX0pyKTpe/zkPEvRnqG0j9bigEWjOwyApu12Ae0wkZS3gy7QG0idAhaa0ykdLB1FiiFrYs+KfbSQU2r+fS5+R9KN0j/RsCiIwhTa6cTBbKRWgnDlGCaaPCGEXlYd/XfiDU92+1baU9bWppt83b3oV7FGN5+1CnusoJME0oQidrX5y5xHJshqNSI503n0B1RMEkYr29CBN4J0y1bSiYfMWi2Gg1irrK7AXzpc/uhvhtl73iXMl9hgOhCI0/prTqmERh8zlvYFLAlMspRE3I8+rlxeUslw/wtFWQ3BpHylROleqFGaXTr/EDHblPkwHjmFYbrU8i0dWQtflPpv3zjK6gRnoah/7KlDR3PQeuFeA== X-Forefront-Antispam-Report: CIP:198.47.21.194;CTRY:US;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:flwvzet200.ext.ti.com;PTR:ErrorRetry;CAT:NONE;SFS:(13230040)(23010399003)(36860700016)(82310400026)(1800799024)(376014)(10067099003)(6133799003)(18002099003)(22082099003)(56012099006);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: +ZU7H2IBRgiTJhB6JdqdndVciuOHzwhmCX6q9sm+ve5M7YpuQTrMwvq04mtVmYnBPXkDRL4qj0V+KtNFR5fq2zuMqbntFw18wP3uOZaj0/xwKmVeWjOslU4yl5SOfyfOyfuiHR3eT8dJSqdfXwIeywMLelukHXSXq1Vtk6w22XBrJC9C54tOprmpHf04rqYOYQmoU1ylbNZa88cOKdEn9BItwuYOVZCODQU0MPctDdpK1o8TSPeW/p4vgELD6ayEuVBiWa3Fp7ATStTnP1zv9A+esxoimPiBYRe6WDv48JOuZ2MMxrRzjHB3aTItk4qzXWqSd69JHKZ0LUH2gGlgqon7Yk3OKNH6CqWsBevtnTTIzmrRoJo9mI7Dd9ke3ieVakm+Ziz9Rr4vpPT3oSlfzn5CdgiMARukt4pFOK61SxzE4rT/Mns0sqbIHsKe1ENp X-Exchange-RoutingPolicyChecked: pwXPU5L6YciTCjpc6gq5fncbiMy7OY9973SOOR/KIsChBZqfi0XfF2Xbm7uDcr9lifO+VrDvr1SLEyC/Tkv0deGqf4VVQlPymF2r/bzBUf9UmrXAZlGdN3HcaHeDSst8IG5DNZ3KBiIchQesolBgShfRiyrRjaXrQkH3wFZhBS9SUPH9noMKQTnzw1RQtJqMHjyya0tbkuVsn+lCJZK3k2i+aQh8TeA0NhuFzxkhE++FWYhDOH1N5Cve+D7+Ncn0J6v0orHCWIvWgzy3xWFSiM4eGEOsnWUsZMVzmEFsK4iddDUruvdkGkpaiqzi7ph4Jn6t59TWb6bO5Y49nOoKYQ== X-OriginatorOrg: ti.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 10 Sep 2026 17:57:32.3321 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: dd8207b8-603b-4567-be18-08df0f64fcf0 X-MS-Exchange-CrossTenant-Id: e5b49634-450b-4709-8abb-1e2b19b982b7 X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=e5b49634-450b-4709-8abb-1e2b19b982b7;Ip=[198.47.21.194];Helo=[flwvzet200.ext.ti.com] X-MS-Exchange-CrossTenant-AuthSource: CO1PEPF00012E84.namprd03.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: CHAPR10MB997720 X-Proofpoint-Spam-Info: AW1haW4tMjYwOTEwMDIyMCBTYWx0ZWRfX78K/ZooPGL5t ERLJe6a7aejtIuhyBaGY9zHvfR2o5Y7+maxtDtF0s2us2A1qTXdIyCcR2pFNjNwzZUCJfhskoRD Bm11qAiVuIHNR+DVYMPOuCLsMPiBUHQ= X-Proofpoint-GUID: AFunQlaYZ8Q3zlSuo6hoZzErjsF2d0QA X-Authority-Analysis: v=2.4 cv=VvG2kO2n c=1 sm=1 tr=0 ts=6aa2ef92 cx=c_pps a=H9d2Io+6O/etw3jU54J+0Q==:117 a=iwqwCZQqcuTv3JOpYdM7/Q==:17 a=6eWqkTHjU83fiwn7nKZWdM+Sl24=:19 a=VdqzKS8jKosA:10 a=V5UXEbMT0ywA:10 a=VkNPw1HP01LnGYTKEx00:22 a=Z8NIEmU8O1QQgoT56wFK:22 a=gO1vWkAQAl3rybz1DQOp:22 a=sozttTNsAAAA:8 a=ki2JzQWVm1jR-OH3vWAA:9 X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwOTEwMDIyMCBTYWx0ZWRfX1Gm4lpJF3czL jp/CamWzQ4PpwF7aY3mc2PsmmUMDj7Nza4oOFME4MM+TWQ4bCqt+g2Z4tv3myffh5VK0ZltfSgc nG3EhiCRWknfvR4Ax/+7pK71/ht8WlDhAMU7X0oe2Js69eV9JbCLWNhRo+Tth188X0Py5pOUIGl JRPE6/KoNOC0bWomRKSt0EiSv9XDSNJTzfRNuENZ3yPyR+1w+oibYogxGS86NjnXmrZfuFrvA63 oLg39S5bsP7s8sSfCXcETuFQasRC4b7t06QrLP0/Qnoeglbw0eoE8zYdznVVUrBY01V5OieR5GE YT+xIqPrYKCAvN0snu5rdTh1U1tNIoZT0ZINCIBTysa/EhpcgQbozftJw0Etx4aNy7advToaCtl XJtXNNL4wYkVXGlRtX5EHScbEXRa9NuGgvV8sFwVggFrWGJexDL8nx62R6pHmcW7vdDUONvl6qZ /pkcNvhUHuFekRTHG7w== X-Proofpoint-ORIG-GUID: AFunQlaYZ8Q3zlSuo6hoZzErjsF2d0QA X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1176,Hydra:6.1.134,FMLib:17.12.100.49 definitions=2026-09-10_05,2026-09-09_02,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 adultscore=0 bulkscore=0 lowpriorityscore=0 priorityscore=1501 suspectscore=0 malwarescore=0 spamscore=0 phishscore=0 impostorscore=0 clxscore=1015 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2609040000 definitions=main-2609100220 Content-Type: text/plain; charset="utf-8" Probe and remove functions use spin_(un)lock for acquiring the dthe_dev_list.lock. But dthe_get_dev uses the bh variant. Change spin_(un)lock_bh to spin_(un)lock to avoid potential deadlock when a softIRQ process tries to acquire the already held lock. Fixes: 52f641bc63a46 ("crypto: ti - Add driver for DTHE V2 AES Engine (ECB,= CBC)") Signed-off-by: T Pratham --- drivers/crypto/ti/dthev2-common.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/crypto/ti/dthev2-common.c b/drivers/crypto/ti/dthev2-c= ommon.c index cc02449382673..4c6b72ba104ec 100644 --- a/drivers/crypto/ti/dthev2-common.c +++ b/drivers/crypto/ti/dthev2-common.c @@ -39,11 +39,11 @@ struct dthe_data *dthe_get_dev(struct dthe_tfm_ctx *ctx) if (ctx->dev_data) return ctx->dev_data; =20 - spin_lock_bh(&dthe_dev_list.lock); + spin_lock(&dthe_dev_list.lock); dev_data =3D list_first_entry_or_null(&dthe_dev_list.dev_list, struct dth= e_data, list); if (dev_data) list_move_tail(&dev_data->list, &dthe_dev_list.dev_list); - spin_unlock_bh(&dthe_dev_list.lock); + spin_unlock(&dthe_dev_list.lock); =20 return dev_data; } --=20 2.34.1 From nobody Fri Sep 25 16:02:52 2026 Received: from mx0a-0002e601.pphosted.com (mx0a-0002e601.pphosted.com [148.163.150.75]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 44384568FDF; Thu, 10 Sep 2026 17:57:24 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=fail smtp.client-ip=148.163.150.75 ARC-Seal: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1789063053; cv=fail; b=q4vMwTqrQs9uQVtIrb2v7NqMzIE9JnzXuKxAI0IMbsk9f2gLaftmen6uNk6nJJaokhOKhRdDfIWMC5q1+3St+ZGgHKzmd2Cl7QksXkCrRRjuJTldgV8H6zkzox7CZZz7qqtIBFIbJsKIlfGAjNsh4n25UTFVBjH7d4LE8p0hdG8= ARC-Message-Signature: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1789063053; c=relaxed/simple; bh=SytUeFdB/MKaYKaubrhZRnRz1jmrcwLjp0R6X9UVqZU=; h=From:To:CC:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=S0IfuIaVZlKqXIiqO/MGH4qA/lIcwAN9xZWqQj6iTU/wFpPEoI4mpC3JAnTdgaaCD7gDe7UqPVxY6yXqID+52XpYfx2WT0z3LVlNEKLL6AqKpMy/9Jz+rWzIeNL+ucVSOZlSB1FI0zGOtc6wCN4p2BReK/2g750DMNxgwz+kA88= ARC-Authentication-Results: i=2; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=ti.com; spf=pass smtp.mailfrom=ti.com; dkim=pass (2048-bit key) header.d=ti.com header.i=@ti.com header.b=Ral8h80L; dkim=pass (1024-bit key) header.d=ti.com header.i=@ti.com header.b=BILNF5Yr; arc=fail smtp.client-ip=148.163.150.75 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=ti.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=ti.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=ti.com header.i=@ti.com header.b="Ral8h80L"; dkim=pass (1024-bit key) header.d=ti.com header.i=@ti.com header.b="BILNF5Yr" Received: from pps.filterd (m0384305.ppops.net [127.0.0.1]) by m0384305.ppops.net (8.18.1.11/8.18.1.11) with ESMTP id 68AF64aD1431174; Thu, 10 Sep 2026 12:57:17 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ti.com; h=cc :content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s= proofpoint-05-2026; bh=ys2sjHHwD+AiPU99+X4BPnXwi+/C0iIWiOc5Chq+H GE=; b=Ral8h80LnDuxGVLzQ1RyVxRCwbuiJkngBO2aUvTR4Gc6qDUGhkHj6W8Ow v33s96JGk7wOUbRtkcAG+dmBZTKjR/Y/Lgj8OYUiw5KYRF6e4WUBTWmID3YKTXxr pAJ/+TJtQk6sGv3ug9t7IgeYUSa4njXRSnI2DJNEz1lFMj0V7f9CZTUVl9R2PIoW soRSfdzT018vTa3jSgzLiRVeFk77z2HAG9vCl79ZsXTgfDnDAZOQSMqkOvclED+o 00ODulbSbqB5PerYrkgVbC5iEfiRdl0wLMCmJSG4Pu9xHn+QsdqkJYLU3sR9JPL5 QY3/JjdL3yY5HaQV4c31SeX+PDKzg== Received: from cy7pr03cu001.outbound.protection.outlook.com (mail-westcentralusazon11010037.outbound.protection.outlook.com [40.93.198.37]) by m0384305.ppops.net (PPS) with ESMTPS id 4gkcxgfbga-1 (version=TLSv1.3 cipher=TLS_AES_256_GCM_SHA384 bits=256 verify=NOT); Thu, 10 Sep 2026 12:57:17 -0500 (CDT) ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=pejuFqh/RGeC+RFd4qQtGe2d2gwT5usr17qF+E3HwOOUxKUP0H3HCDsZ7kHUu+PTAL0odSoXHuw5kxEemvhEMEP3BYObBrlm6tWVLZr5/Wtq3UJTX+XeumjJ6LIU+xf2ZyuNC3NMRcIdZqFaEZpiWRpMVPJr/u9Oks03xsMqnCtQIrHHbgHqcP0ANWDFjv/o9N08wKnrBq1llvCwwlBH8kmR6TT/v/v7vvwIFm8hGSGdW99ZLbOT9ubKbbeT6GVuMGLmEMRREcymZSZo143mHLJbaxU6o/lhfEqVoLLk4IHEz/tvZv5bJ0gIz1zYcOFirXGOCiXcoqbaS0MuZVl7Lg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=ys2sjHHwD+AiPU99+X4BPnXwi+/C0iIWiOc5Chq+HGE=; b=qlphUboJbDzFYmPSigDvvpOVpam/fCBj6a36zDfeHouWd7yc3rhI9OLwZytj5owpw2W5l8P76jw0SbkNEj25WnWBQ/FiABgpFoMEbyh0omk5KiFp6oT1upcM/AcdDLSscv09WI8WYOIU6tjmhZPKxKyHbkVND7D2bfyLt0cvMiQrBs58y/6ku1Q/JqKe7QbTqF+lQgPji54PfkvOiQity+DnC1oInUAbpsL9BeUfpx7eK+rbtWb7RBqsqO02T4H2KMwgMsGDB0jzJYfoUCzFsaXU39XPz+J2+QjKpf6+5GPSPe/myKY9fvwJTqXmdzSQi2/A2F2z7zKq4CidY9SeDA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 198.47.23.194) smtp.rcpttodomain=gondor.apana.org.au smtp.mailfrom=ti.com; dmarc=pass (p=quarantine sp=none pct=100) action=none header.from=ti.com; dkim=none (message not signed); arc=none (0) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ti.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=ys2sjHHwD+AiPU99+X4BPnXwi+/C0iIWiOc5Chq+HGE=; b=BILNF5YrA1homUmK7898OX9Tu42NTv16er1smT5C3EykqDSBc9p+FK7EZ/jrQdVEmtUgKn3FXueOShw99TrU4tV0uZ1ewiex9giTynuFPzWG1hJhvl31yydi+MMj4e8Go+RtKkzho/528RRfIakPrAwb9L4Slyi/tNnIBDiiWLM= Received: from MN2PR03CA0024.namprd03.prod.outlook.com (2603:10b6:208:23a::29) by IA0PR10MB7302.namprd10.prod.outlook.com (2603:10b6:208:407::16) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.21.406.7; Thu, 10 Sep 2026 17:57:12 +0000 Received: from BN3PEPF00022BCC.namprd03.prod.outlook.com (2603:10b6:208:23a:cafe::1f) by MN2PR03CA0024.outlook.office365.com (2603:10b6:208:23a::29) with Microsoft SMTP Server (version=TLS1_3, cipher=TLS_AES_256_GCM_SHA384) id 15.21.406.9 via Frontend Transport; Thu, 10 Sep 2026 17:57:12 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 198.47.23.194) smtp.mailfrom=ti.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=ti.com; Received-SPF: Pass (protection.outlook.com: domain of ti.com designates 198.47.23.194 as permitted sender) receiver=protection.outlook.com; client-ip=198.47.23.194; helo=lewvzet200.ext.ti.com; pr=C Received: from lewvzet200.ext.ti.com (198.47.23.194) by BN3PEPF00022BCC.mail.protection.outlook.com (10.167.248.164) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.21.406.5 via Frontend Transport; Thu, 10 Sep 2026 17:57:11 +0000 Received: from DLEE212.ent.ti.com (157.170.170.114) by lewvzet200.ext.ti.com (10.4.14.103) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.2562.45; Thu, 10 Sep 2026 12:56:41 -0500 Received: from DLEE201.ent.ti.com (157.170.170.76) by DLEE212.ent.ti.com (157.170.170.114) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.2562.45; Thu, 10 Sep 2026 12:56:41 -0500 Received: from lelvem-mr06.itg.ti.com (10.180.75.8) by DLEE201.ent.ti.com (157.170.170.76) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.2562.45 via Frontend Transport; Thu, 10 Sep 2026 12:56:41 -0500 Received: from pratham-Workstation-PC (pratham-workstation-pc.dhcp.ti.com [10.24.53.205]) by lelvem-mr06.itg.ti.com (8.18.1/8.18.1) with ESMTP id 68AHueMX2793621; Thu, 10 Sep 2026 12:56:41 -0500 From: T Pratham To: T Pratham , Herbert Xu , "David S. Miller" CC: Sebin Francis , Manorit Chawdhry , Vishal Mahaveer , Praneeth Bajjuri , , Subject: [PATCH v4 03/15] crypto: ti - Fix potential memory corruption on highmem pages Date: Thu, 10 Sep 2026 23:26:07 +0530 Message-ID: <20260910175619.2122149-4-t-pratham@ti.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20260910175619.2122149-1-t-pratham@ti.com> References: <20260910175619.2122149-1-t-pratham@ti.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: BN3PEPF00022BCC:EE_|IA0PR10MB7302:EE_ X-MS-Office365-Filtering-Correlation-Id: 119761a0-58c7-4470-eea6-08df0f64f086 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|376014|82310400026|23010399003|36860700016|1800799024|6133799003|56012099006|10067099003|18002099003|22082099003; X-Microsoft-Antispam-Message-Info: jtUrVntdM2I3sBr8wQM7qDoDOJMjBuzllIlWWqZJ8l36qASwTCSDesj6fk2QZQJcJJPwYh5DH3op4Gh0chIchrjm6M/+9yHbV2Pxypfyuz1CmMgDA9kYxKjp79YKVSewdoA61kawMakCgysWtNYbsZ/dbo1jSlBzqSDVRaW4msUTKM3kK1Cd94YUV/lpSB9CSRp6ev0fJ+iTDGd2VsoWirVsv7pfxz4uXFmz1vTSMlE2BJsM62D6oa5DciEX5PCl16yoI6CuQ93xaUcC/7+QVSkjCyuBV/6dblMIRb4JDmFW0f9VWJYxAKwemV67QWVOpXmKM2bm/Dcrck23TClFFkaH3fada783BgqGCJfPTEK4pCMKnSjYJ7MdI/cLJsPAhZ3faP+iq/fLTGG6Mf0bbXBOnWOGsT34SZcmeFA7H3sakntwQZywtMPi9eblFuWC75hJqX/7oPzs0AomQY/StI3mQORIBtp+NjYe3xdRoBqaJEmBe9IuI3p7ZK6Qben+D1o0siWXupqoA1WiBBrNpTjKREp2oT7mX0tByc2lBiTuYsJrCTP2daXYYetlBae1qyAo5zj6AZHy339eik76M2U+KSKGJ/6bB7EgccBjaRttPvC/CzSodPUQbLH6C3N9XnlWlCN5K1cWbmCDTw24JaD03IjNFys88h6qqX1hL1ZqdfqpKxbVhxCbIFNnJ/KeN0xxjR+n8646Atwiq7f2fQ== X-Forefront-Antispam-Report: CIP:198.47.23.194;CTRY:US;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:lewvzet200.ext.ti.com;PTR:InfoDomainNonexistent;CAT:NONE;SFS:(13230040)(376014)(82310400026)(23010399003)(36860700016)(1800799024)(6133799003)(56012099006)(10067099003)(18002099003)(22082099003);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: EA30u2w+XwD68EkS6IQ7664LoYkuWrQrpKnfUYREpBGUiUsMT0bfyvwySzhY38/yF29hMgv89w/C2Xq0UvrYqwrOpRbqA0cFY/opaKM3+ckJQoNEJHZmM/69uRiX0dF1UyKPL+BykQq4/sxNyVkh3UGnofBHfgIhtVu8u5pn9N0MazeoGt7lHsL74X7LN+cjtJjwxY38Fy6UboU8n5sO1xWiXgn7Q4id7+CYaW5A0OVq33Ct06cBTY/S2qn5sE8+byQP3Arl7tGbaNCY1ky0tRVZGc7C8tIohM7d6OFfq0F+yFR+sbR8vuz02khcNXizzAoEdQzWFVTX71sXwbOBohpJ1bmXWjb9bd1lApGR5SoHK+WgKKws10kJilioElkHaOGbk15mDHzIq9ZTRSJPzk0C2P+tJT9fJn8f7Bu2bgcISNRuCukQ0vxkkrm++lCU X-Exchange-RoutingPolicyChecked: VzZR3DVyj7MDLupR9FoR2pia+oiAaEpArsLIRMrSahQ5rCSqbOnEnpF9V1ILybGjhfVq8QSkMB5yFRfK2yG0n/bvRffs6EReg0ZpijtwiDrJf6NZdcDwmvu0aQgLamSpFYETwwYHmZ5/ck7ukxAngFpcl30J91Uz2R5P7owlsT4fD2JtTf5TsDvRj2G2DOg4nr0cvmqeTykgccG8nBqJJJehLIlTSKvPUSG3jN+BvPTxIyJZUQfS4T2a+4EcLBKU4XvDndv/rhJbVQCG8dKT6hY8Sa7jUq8XVKzuCCEqr095Lo1Zx9Zgai4wpxOb0uLmE//lLIvBfZ/bgcjGOkPB8Q== X-OriginatorOrg: ti.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 10 Sep 2026 17:57:11.5218 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 119761a0-58c7-4470-eea6-08df0f64f086 X-MS-Exchange-CrossTenant-Id: e5b49634-450b-4709-8abb-1e2b19b982b7 X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=e5b49634-450b-4709-8abb-1e2b19b982b7;Ip=[198.47.23.194];Helo=[lewvzet200.ext.ti.com] X-MS-Exchange-CrossTenant-AuthSource: BN3PEPF00022BCC.namprd03.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: IA0PR10MB7302 X-Proofpoint-ORIG-GUID: yi2L2PzK5MqF_1nzwU6uMgh667lDl2E3 X-Proofpoint-Spam-Info: AW1haW4tMjYwOTEwMDIyMCBTYWx0ZWRfXwnVvOBLrmV43 lSl0HZkw6LzRFXbPT7qolSH5fHuWfaHjgBdt/S2uL+ndpyQW1eMOFHqRZMJzajD+EsAKXpARn43 3eG2emHAZzkBoe7Gppl0hUapmDf84Bc= X-Proofpoint-GUID: yi2L2PzK5MqF_1nzwU6uMgh667lDl2E3 X-Authority-Analysis: v=2.4 cv=MqbHeGae c=1 sm=1 tr=0 ts=6aa2ef7d cx=c_pps a=HozCXiP24e1PxqS5ATOdRg==:117 a=WotqVVQAdb04rnGuttW3Kw==:17 a=6eWqkTHjU83fiwn7nKZWdM+Sl24=:19 a=VdqzKS8jKosA:10 a=s63m1ICgrNkA:10 a=V5UXEbMT0ywA:10 a=VkNPw1HP01LnGYTKEx00:22 a=Z8NIEmU8O1QQgoT56wFK:22 a=taLDd7a_hP9WKsMzeGRc:22 a=sozttTNsAAAA:8 a=IXP722aH8NCvtdUuCEcA:9 X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwOTEwMDIyMCBTYWx0ZWRfX7biW8eo3vEIy KVNnp5BNlQ9xa0LYSyzKz6UkU9iEY3Ee6l1Pq5isxVhs6saO1EkaZ7BcaPhVbBojeVZen9mtxYv ab5duaSLHefpGFHkUPWlqZH6lT30MtsYpPCumzEud5GGI9G6qxBb1KZH/GlaUnFOQe8Jh/6JQ/z eFa2h/6PafXC1xOBYjUhrQiei4DV5CNDVyZlsgBIqNegamJVm6kFhVFF0WGCPYePnKh0LZYvT46 CI6g57hpfoW652P5nTOvjgLxsE7KDtWf4BO5oq2ny9FD1P/uyC3BshPOajKHDwfYn1voK79DQrz u1J8Sxrb7SULN96M6pQF1JukOLKE4E+WpRM5SYCUsCvWO/0MWoWJY7ilzLHLkzVLFKW/E+mWiAX U/0rcfB5LoGjZo5fGqVJ9RDX+U7Y8y1AZxa73LoP0sBWZNrmCyXIpbT5olyVtuzTSOlgRPifEi7 jc01OMCbUesY2yOBuDA== X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1176,Hydra:6.1.134,FMLib:17.12.100.49 definitions=2026-09-10_05,2026-09-09_02,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 clxscore=1015 impostorscore=0 phishscore=0 lowpriorityscore=0 priorityscore=1501 spamscore=0 bulkscore=0 adultscore=0 suspectscore=0 malwarescore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2609040000 definitions=main-2609100220 Content-Type: text/plain; charset="utf-8" Change sg_set_buf to sg_set_page in DTHEv2 dthe_copy_sg function to avoid using sg_virt() on scatterlists. For scatterlists containing a highmem page, sg_virt() yields invalid or null adrdess, causing potential memory corruption. While we are here, also change function signature to change buflen from int to unsigned int. Fixes: 35645ca63caa1 ("crypto: ti - Add support for AES-CTR in DTHEv2 drive= r") Signed-off-by: T Pratham --- drivers/crypto/ti/dthev2-common.c | 4 ++-- drivers/crypto/ti/dthev2-common.h | 2 +- 2 files changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers/crypto/ti/dthev2-common.c b/drivers/crypto/ti/dthev2-c= ommon.c index 4c6b72ba104ec..8628187a32e18 100644 --- a/drivers/crypto/ti/dthev2-common.c +++ b/drivers/crypto/ti/dthev2-common.c @@ -50,7 +50,7 @@ struct dthe_data *dthe_get_dev(struct dthe_tfm_ctx *ctx) =20 struct scatterlist *dthe_copy_sg(struct scatterlist *dst, struct scatterlist *src, - int buflen) + unsigned int buflen) { struct scatterlist *from_sg, *to_sg; int sglen; @@ -59,7 +59,7 @@ struct scatterlist *dthe_copy_sg(struct scatterlist *dst, sglen =3D from_sg->length; if (sglen > buflen) sglen =3D buflen; - sg_set_buf(to_sg, sg_virt(from_sg), sglen); + sg_set_page(to_sg, sg_page(from_sg), sglen, from_sg->offset); from_sg =3D sg_next(from_sg); to_sg =3D sg_next(to_sg); } diff --git a/drivers/crypto/ti/dthev2-common.h b/drivers/crypto/ti/dthev2-c= ommon.h index d4a3b9c18bbc1..75d9a097650da 100644 --- a/drivers/crypto/ti/dthev2-common.h +++ b/drivers/crypto/ti/dthev2-common.h @@ -126,7 +126,7 @@ struct dthe_data *dthe_get_dev(struct dthe_tfm_ctx *ctx= ); **/ struct scatterlist *dthe_copy_sg(struct scatterlist *dst, struct scatterlist *src, - int buflen); + unsigned int buflen); =20 int dthe_register_aes_algs(void); void dthe_unregister_aes_algs(void); --=20 2.34.1 From nobody Fri Sep 25 16:02:52 2026 Received: from mx0a-0002e601.pphosted.com (mx0a-0002e601.pphosted.com [148.163.150.75]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id B3BF95616C3; Thu, 10 Sep 2026 17:57:36 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=fail smtp.client-ip=148.163.150.75 ARC-Seal: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1789063063; cv=fail; b=s43hT5AT+cWywCxAKL2sbXO+8htO+0edoldYvOq/Q2EO4xw5xIoZNZIYgKixkH0CRQpVeHJiu1foc16ebIBNePVap7IVNOB+EeoBFDj/mXxXaaUnTkhxTfLeIfmlwcxM3afZLF7vylNsrQMg3n1sQN6lD1Tp2YK74v/ojrrF/W4= ARC-Message-Signature: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1789063063; c=relaxed/simple; bh=9vSr8UD7YrxNSRU4FlCNr19P22a3uBbHyJQjbuf5cAY=; h=From:To:CC:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=NhqG7+n5x1bQ/qBO6qM3ov9Zh6H9wtGsGtbFeMX+R+csV7E7rGkTjqx/3qNFZ8Y20SYXgRIgeA9uIhaiYMuD2gnkJOH6DGkGwKI4yhTnTOm8SsI36HexH4bgLVpVudrLwlvn8GbnafOSon69PLioYpx1yjOCBBwAaAl4Ur6uTdQ= ARC-Authentication-Results: i=2; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=ti.com; spf=pass smtp.mailfrom=ti.com; dkim=pass (2048-bit key) header.d=ti.com header.i=@ti.com header.b=jEQabuz/; dkim=pass (1024-bit key) header.d=ti.com header.i=@ti.com header.b=M5t+j8m4; arc=fail smtp.client-ip=148.163.150.75 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=ti.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=ti.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=ti.com header.i=@ti.com header.b="jEQabuz/"; dkim=pass (1024-bit key) header.d=ti.com header.i=@ti.com header.b="M5t+j8m4" Received: from pps.filterd (m0384305.ppops.net [127.0.0.1]) by m0384305.ppops.net (8.18.1.11/8.18.1.11) with ESMTP id 68AF62MN1430972; Thu, 10 Sep 2026 12:57:31 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ti.com; h=cc :content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s= proofpoint-05-2026; bh=LiBbIhss8/2e7+bI7uNZyro3rgV9+Z9yQkT6AKlN+ ZU=; b=jEQabuz/LA/ZUhx4RNr1VnssVwQvjSrDerlCRDzoOIX8K71l0Yvf6Amxb xd8w5tPm+xdmki67HewEUHaf2yJ/wikge3f+ppr+ABYGMAidPbdKdmd5iRQyji4V DpDhuyWRnNH6fGpuvLHvrM3e2rjq3+JOSEsPvUajqmpQnM4A8wmKDMj2DoQkddkA 8H2jHIVWUq+ng/e7zJA755KJEJVdiscIN42wNwhNSLDdVgpm38xVlYZ07WCI4u43 buoSv5KW5+cjBIeEtHJQLBK0mFSHBUavIO0PPdMP4kcS3oFOQvk8RbmWnLDTYMJi Bs3TS/X4xD1mmr7TASA5jUSlNcmeA== Received: from bn8pr05cu002.outbound.protection.outlook.com (mail-eastus2azon11011063.outbound.protection.outlook.com [52.101.57.63]) by m0384305.ppops.net (PPS) with ESMTPS id 4gkcxgfbhd-1 (version=TLSv1.3 cipher=TLS_AES_256_GCM_SHA384 bits=256 verify=NOT); Thu, 10 Sep 2026 12:57:30 -0500 (CDT) ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=fwRVJYe07wK2CzLFsyUKWffwM2MUjUasA/KvAZWDa7Lw6dBXyeQlaC5oFILa6jVQi5hEMJ5O4xEkEP51vKOsgtFBiUFq7Ln3BHNNaErjoaqlJcrQa9BEa423ndLSrrCI7maTZvLlRR2/CLWzNDVjb6D0zN1g+Xb0mWiPktgmL9LlldQfLHNYW5aK6YBmV1bhC7Z3j5OpCkMRcrQRiQ5qMMtpehNZm7/7Cz89Ez1MIR4TXzsMvRcyJsaizdCLnQ+rkM3exu2aodlz5dMlpDfTlOZpQL1lxjo4FQYmw3GdIqMAEmd32bTBRR2RHZ4dSK5TJ5JmKPpIOmaqufG77UCDpQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=LiBbIhss8/2e7+bI7uNZyro3rgV9+Z9yQkT6AKlN+ZU=; b=FSqcvrYgKdSuHVGEBXWEbE9PblvD5tL2IQSFm63CNBsGJNicWh63dQ+cXWQFt8sinGs1dDvfzFMIFH9kuQQPqEP9KeNBlflceNp9D44IVpZu1MIwBxsyTmfQFZf8QB0UnqlYIsU2tcirDUS+5eb2ewDrn3N2+w/fBIZG00Y1NZheUrINV5XJGGvbDm4KRzhTU46aONdhMk45zVsg013iUwTgf4lvz0llJgteTjEsgHn7qaTG76qxi08/7sV4MG4VKp35fcn9fxZhELVcutGQBRAXFIwA/fqMbqXYBtoVolf85rDCDSsf/qDFeBr+rBQ3RxivhTgtG4zIOiKEl4Qpdg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 198.47.21.195) smtp.rcpttodomain=gondor.apana.org.au smtp.mailfrom=ti.com; dmarc=pass (p=quarantine sp=none pct=100) action=none header.from=ti.com; dkim=none (message not signed); arc=none (0) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ti.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=LiBbIhss8/2e7+bI7uNZyro3rgV9+Z9yQkT6AKlN+ZU=; b=M5t+j8m4ikGoEx9GW7+Nfe16M71QmqesixjTlWh3YD7aShjG34YsOgV9ebwxiONXVbfTC0CrXlt5SilxO84iqlvRJrzvItq3+PAfqxcD7y3nOmajcSy5RtAYGeqzrQP28TiB3xIFovDEGxctxivwEohzr79vKArOXogQKdfNaK8= Received: from CH0PR07CA0004.namprd07.prod.outlook.com (2603:10b6:610:32::9) by IA0PR10MB7370.namprd10.prod.outlook.com (2603:10b6:208:3dd::11) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.21.428.4; Thu, 10 Sep 2026 17:57:25 +0000 Received: from CH1PEPF0000AD81.namprd04.prod.outlook.com (2603:10b6:610:32:cafe::35) by CH0PR07CA0004.outlook.office365.com (2603:10b6:610:32::9) with Microsoft SMTP Server (version=TLS1_3, cipher=TLS_AES_256_GCM_SHA384) id 15.21.406.9 via Frontend Transport; Thu, 10 Sep 2026 17:57:25 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 198.47.21.195) smtp.mailfrom=ti.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=ti.com; Received-SPF: Pass (protection.outlook.com: domain of ti.com designates 198.47.21.195 as permitted sender) receiver=protection.outlook.com; client-ip=198.47.21.195; helo=flwvzet201.ext.ti.com; pr=C Received: from flwvzet201.ext.ti.com (198.47.21.195) by CH1PEPF0000AD81.mail.protection.outlook.com (10.167.244.89) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.21.406.5 via Frontend Transport; Thu, 10 Sep 2026 17:57:23 +0000 Received: from DFLE210.ent.ti.com (10.64.6.68) by flwvzet201.ext.ti.com (10.248.192.32) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.2562.45; Thu, 10 Sep 2026 12:56:44 -0500 Received: from DFLE201.ent.ti.com (10.64.6.59) by DFLE210.ent.ti.com (10.64.6.68) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.2562.45; Thu, 10 Sep 2026 12:56:44 -0500 Received: from lelvem-mr06.itg.ti.com (10.180.75.8) by DFLE201.ent.ti.com (10.64.6.59) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.2562.45 via Frontend Transport; Thu, 10 Sep 2026 12:56:44 -0500 Received: from pratham-Workstation-PC (pratham-workstation-pc.dhcp.ti.com [10.24.53.205]) by lelvem-mr06.itg.ti.com (8.18.1/8.18.1) with ESMTP id 68AHuhS02793654; Thu, 10 Sep 2026 12:56:44 -0500 From: T Pratham To: T Pratham , Herbert Xu , "David S. Miller" CC: Sebin Francis , Manorit Chawdhry , Vishal Mahaveer , Praneeth Bajjuri , , Subject: [PATCH v4 04/15] crypto: ti - Fix use-after-free of dev_data on DTHEv2 driver removal Date: Thu, 10 Sep 2026 23:26:08 +0530 Message-ID: <20260910175619.2122149-5-t-pratham@ti.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20260910175619.2122149-1-t-pratham@ti.com> References: <20260910175619.2122149-1-t-pratham@ti.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: CH1PEPF0000AD81:EE_|IA0PR10MB7370:EE_ X-MS-Office365-Filtering-Correlation-Id: 8b95d3ca-98ae-4aca-9a60-08df0f64f7bc X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|1800799024|376014|23010399003|36860700016|82310400026|56012099006|10067099003|22082099003|18002099003; X-Microsoft-Antispam-Message-Info: 1MPxOTL+hvV0RIy4Ut9SAzXINNc46FDvaTPW2Fdf22LqLPXRjrSTTSO94tkf2BltYVs5ob1DWeIIosGdhu4711/g20HCHXP0A1dlkGJ8ppvl4EvtvgiqPKNuoho7Kg2VjrRKcMEJay03TCZ2GGLC+qMGbxXrh0cxVXV+boqfHZqNuly5wVKzgZPd8BD/IHZAjDkW0MHZrMlGff9p4XTIaS11HZU4cA43rkfjBaDuISr6X65Y3F+dgl0C1NkwgKuXMmkBhCw/8hCq2NeaZpxFcpZdywonyAV4I1PUt/j4hsFcUIGpRaHjG2H130ITsCeg93VykvDG2RvGp/Vomu7z3r4l7yR5ZeCr2k6xdklaTDE/rCcfpbvKWQFbeScIyrhI+UyxR5zEJBAAjlp3HNSrZJC9WTDltDaxZqKJZYMt399/IWsFk4qlnyCFXiMhcaroBjEcDLtdAFPZ6T2PtI6tTdbXUhQuIAREXvIT6j4YvC4ReubnnHnUZv6ZSPcmkt7rmXp0Yo1ng4MxmpaC7tY4ck7T1rQ6/ajwu6yYLjZiFMrLA5XDUF1RDkU+qQDidPNUFXQOaTqlf7zH70OnfRka3iz27mnizxmhJt9enaaC0VHuVelKiKsocBrXhS/I1NG4oXNaVGfUrFf86bxJ79K3Q2JmI+y1R21mw+YmTwl8vouDS0UNf8pVfYvZrg40QTtvKoLKWPU78LK4z8YDvmsfLA== X-Forefront-Antispam-Report: CIP:198.47.21.195;CTRY:US;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:flwvzet201.ext.ti.com;PTR:ErrorRetry;CAT:NONE;SFS:(13230040)(1800799024)(376014)(23010399003)(36860700016)(82310400026)(56012099006)(10067099003)(22082099003)(18002099003);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: Vnb/3kG2eReQ7OJumvuoOSDZlUS7wzHo3Of8FJ5RXXEIzvLiX5ha/+gkMiy2jqC6JNcewBbg9yMovdcoMuio0FyKh8GRuOVs9ZWQfXAeO7BABeA12HPWhanTDmcTpWywBFBiYTKQg1kGnBM7co8Zu/0XNMxbjopF/SaOCrtY2mvE+YEd35atiEe51ZpsAe7A+q7G7tyvd09yOE/ov808MRrt9luWU7oCxHa2jjC0ljWtg8b1JWRjRxNFHKcqVRBovMEoMvbCyIrC5EOwnd9q+bAq/FErcLNQlossZ3PnFw/JJDRHVLeWZju1OH32uJoPypM2JjsMfbOdJinM6YbblJ9QNRoaSl/Q6FgVhpIlY74w/555Pe4qZ6zNigroVmdLins3OwUCj9ieSkGaLsqnpTjpggIG/v28NQZdVoSD1adf/Ay5m8ultjAeTcbCtbRa X-Exchange-RoutingPolicyChecked: MqasFVA8mJa24HWLpTO4koVm7ut31Q+cv3K9gUkz1/FLDODm/dg6jBX46Ft4kH4EaQaTnKxhexoJbMRydeD5S1uOjAONUjlfGsc1rJ4bf0XdcLQ0Hr0tAo8+gOu0c7cD0M6PLLD7t6YvB1kZC3sKtQQu34T9XMLmj2ZDbE2BqaW0tqG7Xd+HkgzZSE5bt5YEnQvdk1nY7kCwRqfg3o24ifH5RBQYCAfEwpWF5pVPwreU6jxGGjdIrdYlDpkiCHCdmyUkEHHmn9XeoTfT5j5Sy14jOQOANeca3dR4tv8fiQmuTdnnZdWpmg770FDeArE7110b67E9pCLlPlR8kKJkRg== X-OriginatorOrg: ti.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 10 Sep 2026 17:57:23.6363 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 8b95d3ca-98ae-4aca-9a60-08df0f64f7bc X-MS-Exchange-CrossTenant-Id: e5b49634-450b-4709-8abb-1e2b19b982b7 X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=e5b49634-450b-4709-8abb-1e2b19b982b7;Ip=[198.47.21.195];Helo=[flwvzet201.ext.ti.com] X-MS-Exchange-CrossTenant-AuthSource: CH1PEPF0000AD81.namprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: IA0PR10MB7370 X-Proofpoint-ORIG-GUID: dVrslkFTywkzSYfae6yLyaUkWnCW87Bq X-Proofpoint-Spam-Info: AW1haW4tMjYwOTEwMDIyMCBTYWx0ZWRfXyey3MGlxGzt9 PTtuY6QshwqHzVYufBlk70wN/v4W6MLXKSxnm+wzWrOX8WBVuM7RPUOxVgKiXwip/an+awQnM1U LVB607ve1+uRutLPeG7PChyMByD8bF4= X-Proofpoint-GUID: dVrslkFTywkzSYfae6yLyaUkWnCW87Bq X-Authority-Analysis: v=2.4 cv=MqbHeGae c=1 sm=1 tr=0 ts=6aa2ef8a cx=c_pps a=MlxngMRGYcnGG1Y86Hm5lQ==:117 a=tJyPKKxUohctrY4NYmUjkA==:17 a=6eWqkTHjU83fiwn7nKZWdM+Sl24=:19 a=VdqzKS8jKosA:10 a=V5UXEbMT0ywA:10 a=VkNPw1HP01LnGYTKEx00:22 a=Z8NIEmU8O1QQgoT56wFK:22 a=taLDd7a_hP9WKsMzeGRc:22 a=sozttTNsAAAA:8 a=i7zdQjoT4sji5VLZqVYA:9 X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwOTEwMDIyMCBTYWx0ZWRfXyAA1i9sXF7h2 VqgVdt0zatyE38krTQztrkNAjJKsRwVOmUch+dXXQrkB9wxPDbioLyABpzu/TGNqxxO2+99umVz Vbt2cY/X+SsRwq/JGrNPxc9Z9tflJiJ0FG6zFN7uN8bT0RP+X+vrB7dsJBqNPSQzw1JyHLSCKzI Hm0uBFjWmz1dgFRJcoqIP9yqlr2An2nLSq7d5vcxokIMehvY5jK3r9/8rP5UrD/TsdlyH8fp+ah 7DOC1ZMPYRUsO49LcUz1JI0/Rwh6J1yiDq3cMwDAl1XCTmNyy/UdRYKzAEjhyXy4yWGO5ixS9Fl 4+W4tm5G/MyBoZMUiuS6pHAtPEd1ykFwhs2uuwp/Z8EOmDBGq/lHS+fYH2wO9z5pkDjn8A/O2RM uDrOdOY7Y5LagH+0QLSqWTSaAn+QzaaTkUvvslTVDPx92oPt22SkFYqywp53hAFl6u/i9GuEDmL LcQztKLVHjVjYTlRAxw== X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1176,Hydra:6.1.134,FMLib:17.12.100.49 definitions=2026-09-10_05,2026-09-09_02,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 clxscore=1015 impostorscore=0 phishscore=0 lowpriorityscore=0 priorityscore=1501 spamscore=0 bulkscore=0 adultscore=0 suspectscore=0 malwarescore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2609040000 definitions=main-2609100220 Content-Type: text/plain; charset="utf-8" Each *_init_tfm() caches a pointer to the per-instance struct dthe_data in its transform context (ctx->dev_data), but never takes a reference on it. If there are tfms in progress when dthe_remove() is called, the devm allocated dev_data gets freed. Then ctx->dev_data will point to a memory that has been freed. Move dthe_data to req_ctx structs of algorithms, and store the device pointer in tfm_ctx. Add a refcnt to struct dthe_data, which atomically counts the number of requests enqueued in the crypto engine queue which reference the dthe_data object. A waitqueue waits on this atomic counter to get back to zero in dthe_remove() before doing the driver teardown. Fixes: 52f641bc63a46 ("crypto: ti - Add driver for DTHE V2 AES Engine (ECB,= CBC)") Signed-off-by: T Pratham --- drivers/crypto/ti/dthev2-aes.c | 74 +++++++++++++++++++++---------- drivers/crypto/ti/dthev2-common.c | 40 ++++++++++++++--- drivers/crypto/ti/dthev2-common.h | 52 ++++++++++++++++++++-- 3 files changed, 134 insertions(+), 32 deletions(-) diff --git a/drivers/crypto/ti/dthev2-aes.c b/drivers/crypto/ti/dthev2-aes.c index 4fdd24ee91637..6a8fbe67ef6cd 100644 --- a/drivers/crypto/ti/dthev2-aes.c +++ b/drivers/crypto/ti/dthev2-aes.c @@ -110,12 +110,11 @@ enum aes_ctrl_mode_masks { static int dthe_cipher_init_tfm(struct crypto_skcipher *tfm) { struct dthe_tfm_ctx *ctx =3D crypto_skcipher_ctx(tfm); - struct dthe_data *dev_data =3D dthe_get_dev(ctx); =20 - if (!dev_data) + ctx->dev =3D dthe_get_dev(); + if (!dev) return -ENODEV; =20 - ctx->dev_data =3D dev_data; ctx->keylen =3D 0; =20 return 0; @@ -124,20 +123,19 @@ static int dthe_cipher_init_tfm(struct crypto_skciphe= r *tfm) static int dthe_cipher_init_tfm_fallback(struct crypto_skcipher *tfm) { struct dthe_tfm_ctx *ctx =3D crypto_skcipher_ctx(tfm); - struct dthe_data *dev_data =3D dthe_get_dev(ctx); const char *alg_name =3D crypto_tfm_alg_name(crypto_skcipher_tfm(tfm)); =20 - if (!dev_data) + ctx->dev =3D dthe_get_dev(); + if (!ctx->dev) return -ENODEV; =20 - ctx->dev_data =3D dev_data; ctx->keylen =3D 0; - ctx->skcipher_fb =3D crypto_alloc_sync_skcipher(alg_name, 0, CRYPTO_ALG_NEED_FALLBACK); if (IS_ERR(ctx->skcipher_fb)) { - dev_err(dev_data->dev, "fallback driver %s couldn't be loaded\n", + dev_err(ctx->dev, "fallback driver %s couldn't be loaded\n", alg_name); + dthe_put_dev(ctx->dev); return PTR_ERR(ctx->skcipher_fb); } =20 @@ -149,6 +147,7 @@ static void dthe_cipher_exit_tfm(struct crypto_skcipher= *tfm) struct dthe_tfm_ctx *ctx =3D crypto_skcipher_ctx(tfm); =20 crypto_free_sync_skcipher(ctx->skcipher_fb); + dthe_put_dev(ctx->dev); } =20 static int dthe_aes_setkey(struct crypto_skcipher *tfm, const u8 *key, uns= igned int keylen) @@ -225,7 +224,7 @@ static void dthe_aes_set_ctrl_key(struct dthe_tfm_ctx *= ctx, struct dthe_aes_req_ctx *rctx, u32 *iv_in) { - struct dthe_data *dev_data =3D dthe_get_dev(ctx); + struct dthe_data *dev_data =3D rctx->dev_data; void __iomem *aes_base_reg =3D dev_data->regs + DTHE_P_AES_BASE; u32 ctrl_val =3D 0; =20 @@ -337,8 +336,8 @@ static int dthe_aes_run(struct crypto_engine *engine, v= oid *areq) { struct skcipher_request *req =3D container_of(areq, struct skcipher_reque= st, base); struct dthe_tfm_ctx *ctx =3D crypto_skcipher_ctx(crypto_skcipher_reqtfm(r= eq)); - struct dthe_data *dev_data =3D dthe_get_dev(ctx); struct dthe_aes_req_ctx *rctx =3D skcipher_request_ctx(req); + struct dthe_data *dev_data =3D rctx->dev_data; =20 unsigned int len =3D req->cryptlen; struct scatterlist *src =3D req->src; @@ -520,14 +519,17 @@ static int dthe_aes_run(struct crypto_engine *engine,= void *areq) local_bh_disable(); crypto_finalize_skcipher_request(dev_data->engine, req, ret); local_bh_enable(); + dthe_put_drvdata(dev_data); return 0; } =20 static int dthe_aes_crypt(struct skcipher_request *req) { struct dthe_tfm_ctx *ctx =3D crypto_skcipher_ctx(crypto_skcipher_reqtfm(r= eq)); - struct dthe_data *dev_data =3D dthe_get_dev(ctx); + struct dthe_aes_req_ctx *rctx =3D skcipher_request_ctx(req); + struct dthe_data *dev_data; struct crypto_engine *engine; + int ret; =20 /* * If data is not a multiple of AES_BLOCK_SIZE: @@ -553,8 +555,18 @@ static int dthe_aes_crypt(struct skcipher_request *req) return 0; } =20 + dev_data =3D dthe_get_drvdata(ctx->dev); + if (!dev_data) + return -ENODEV; + + rctx->dev_data =3D dev_data; + engine =3D dev_data->engine; - return crypto_transfer_skcipher_request_to_engine(engine, req); + ret =3D crypto_transfer_skcipher_request_to_engine(engine, req); + if (ret !=3D -EINPROGRESS && ret !=3D -EBUSY) + dthe_put_drvdata(dev_data); + + return ret; } =20 static int dthe_aes_encrypt(struct skcipher_request *req) @@ -576,19 +588,18 @@ static int dthe_aes_decrypt(struct skcipher_request *= req) static int dthe_aead_init_tfm(struct crypto_aead *tfm) { struct dthe_tfm_ctx *ctx =3D crypto_aead_ctx(tfm); - struct dthe_data *dev_data =3D dthe_get_dev(ctx); const char *alg_name =3D crypto_tfm_alg_name(crypto_aead_tfm(tfm)); =20 - if (!dev_data) + ctx->dev =3D dthe_get_dev(); + if (!ctx->dev) return -ENODEV; =20 - ctx->dev_data =3D dev_data; - ctx->aead_fb =3D crypto_alloc_sync_aead(alg_name, 0, CRYPTO_ALG_NEED_FALLBACK); if (IS_ERR(ctx->aead_fb)) { - dev_err(dev_data->dev, "fallback driver %s couldn't be loaded\n", + dev_err(ctx->dev, "fallback driver %s couldn't be loaded\n", alg_name); + dthe_put_dev(ctx->dev); return PTR_ERR(ctx->aead_fb); } =20 @@ -600,6 +611,7 @@ static void dthe_aead_exit_tfm(struct crypto_aead *tfm) struct dthe_tfm_ctx *ctx =3D crypto_aead_ctx(tfm); =20 crypto_free_sync_aead(ctx->aead_fb); + dthe_put_dev(ctx->dev); } =20 /** @@ -711,9 +723,9 @@ static struct scatterlist *dthe_aead_prep_crypt(struct = scatterlist *sg, return crypt_sg; } =20 -static int dthe_aead_read_tag(struct dthe_tfm_ctx *ctx, u32 *tag) +static int dthe_aead_read_tag(struct dthe_aes_req_ctx *rctx, u32 *tag) { - struct dthe_data *dev_data =3D dthe_get_dev(ctx); + struct dthe_data *dev_data =3D rctx->dev_data; void __iomem *aes_base_reg =3D dev_data->regs + DTHE_P_AES_BASE; u32 val; int ret; @@ -734,11 +746,12 @@ static int dthe_aead_read_tag(struct dthe_tfm_ctx *ct= x, u32 *tag) static int dthe_aead_enc_get_tag(struct aead_request *req) { struct dthe_tfm_ctx *ctx =3D crypto_aead_ctx(crypto_aead_reqtfm(req)); + struct dthe_aes_req_ctx *rctx =3D aead_request_ctx(req); u32 tag[AES_BLOCK_WORDS]; int nents; int ret; =20 - ret =3D dthe_aead_read_tag(ctx, tag); + ret =3D dthe_aead_read_tag(rctx, tag); if (ret) return ret; =20 @@ -753,12 +766,13 @@ static int dthe_aead_enc_get_tag(struct aead_request = *req) static int dthe_aead_dec_verify_tag(struct aead_request *req) { struct dthe_tfm_ctx *ctx =3D crypto_aead_ctx(crypto_aead_reqtfm(req)); + struct dthe_aes_req_ctx *rctx =3D aead_request_ctx(req); u32 tag_out[AES_BLOCK_WORDS]; u32 tag_in[AES_BLOCK_WORDS]; int nents; int ret; =20 - ret =3D dthe_aead_read_tag(ctx, tag_out); + ret =3D dthe_aead_read_tag(rctx, tag_out); if (ret) return ret; =20 @@ -859,7 +873,7 @@ static int dthe_aead_run(struct crypto_engine *engine, = void *areq) struct aead_request *req =3D container_of(areq, struct aead_request, base= ); struct dthe_tfm_ctx *ctx =3D crypto_aead_ctx(crypto_aead_reqtfm(req)); struct dthe_aes_req_ctx *rctx =3D aead_request_ctx(req); - struct dthe_data *dev_data =3D dthe_get_dev(ctx); + struct dthe_data *dev_data =3D rctx->dev_data; =20 unsigned int cryptlen =3D req->cryptlen; unsigned int assoclen =3D req->assoclen; @@ -1130,6 +1144,7 @@ static int dthe_aead_run(struct crypto_engine *engine= , void *areq) local_bh_disable(); crypto_finalize_aead_request(engine, req, ret); local_bh_enable(); + dthe_put_drvdata(dev_data); return 0; } =20 @@ -1137,10 +1152,11 @@ static int dthe_aead_crypt(struct aead_request *req) { struct dthe_tfm_ctx *ctx =3D crypto_aead_ctx(crypto_aead_reqtfm(req)); struct dthe_aes_req_ctx *rctx =3D aead_request_ctx(req); - struct dthe_data *dev_data =3D dthe_get_dev(ctx); + struct dthe_data *dev_data; struct crypto_engine *engine; unsigned int cryptlen =3D req->cryptlen; bool is_zero_ctr =3D true; + int ret; =20 /* In decryption, last authsize bytes are the TAG */ if (!rctx->enc) @@ -1191,8 +1207,18 @@ static int dthe_aead_crypt(struct aead_request *req) (ctx->aes_mode =3D=3D DTHE_AES_CCM && !is_zero_ctr)) return dthe_aead_do_fallback(req); =20 + dev_data =3D dthe_get_drvdata(ctx->dev); + if (!dev_data) + return -ENODEV; + + rctx->dev_data =3D dev_data; + engine =3D dev_data->engine; - return crypto_transfer_aead_request_to_engine(engine, req); + ret =3D crypto_transfer_aead_request_to_engine(engine, req); + if (ret !=3D -EINPROGRESS && ret !=3D -EBUSY) + dthe_put_drvdata(dev_data); + + return ret; } =20 static int dthe_aead_encrypt(struct aead_request *req) diff --git a/drivers/crypto/ti/dthev2-common.c b/drivers/crypto/ti/dthev2-c= ommon.c index 8628187a32e18..f5c834a9c011d 100644 --- a/drivers/crypto/ti/dthev2-common.c +++ b/drivers/crypto/ti/dthev2-common.c @@ -32,22 +32,46 @@ static struct dthe_list dthe_dev_list =3D { .lock =3D __SPIN_LOCK_UNLOCKED(dthe_dev_list.lock), }; =20 -struct dthe_data *dthe_get_dev(struct dthe_tfm_ctx *ctx) +struct device *dthe_get_dev(void) { struct dthe_data *dev_data; - - if (ctx->dev_data) - return ctx->dev_data; + struct device *dev =3D NULL; =20 spin_lock(&dthe_dev_list.lock); dev_data =3D list_first_entry_or_null(&dthe_dev_list.dev_list, struct dth= e_data, list); - if (dev_data) + if (dev_data) { list_move_tail(&dev_data->list, &dthe_dev_list.dev_list); + dev =3D get_device(dev_data->dev); + } + spin_unlock(&dthe_dev_list.lock); + + return dev; +} + +void dthe_put_dev(struct device *dev) +{ + put_device(dev); +} + +struct dthe_data *dthe_get_drvdata(struct device *dev) +{ + struct dthe_data *dev_data; + + spin_lock(&dthe_dev_list.lock); + dev_data =3D dev_get_drvdata(dev); + if (dev_data) + atomic_inc(&dev_data->req_refcnt); spin_unlock(&dthe_dev_list.lock); =20 return dev_data; } =20 +void dthe_put_drvdata(struct dthe_data *dev_data) +{ + if (atomic_dec_and_test(&dev_data->req_refcnt)) + wake_up(&dev_data->drain_wq); +} + struct scatterlist *dthe_copy_sg(struct scatterlist *dst, struct scatterlist *src, unsigned int buflen) @@ -153,6 +177,9 @@ static int dthe_probe(struct platform_device *pdev) if (IS_ERR(dev_data->regs)) return PTR_ERR(dev_data->regs); =20 + atomic_set(&dev_data->req_refcnt, 0); + init_waitqueue_head(&dev_data->drain_wq); + platform_set_drvdata(pdev, dev_data); =20 spin_lock(&dthe_dev_list.lock); @@ -203,10 +230,13 @@ static void dthe_remove(struct platform_device *pdev) =20 spin_lock(&dthe_dev_list.lock); list_del(&dev_data->list); + platform_set_drvdata(pdev, NULL); spin_unlock(&dthe_dev_list.lock); =20 dthe_unregister_algs(); =20 + wait_event(dev_data->drain_wq, !atomic_read(&dev_data->req_refcnt)); + crypto_engine_exit(dev_data->engine); =20 dma_release_channel(dev_data->dma_aes_rx); diff --git a/drivers/crypto/ti/dthev2-common.h b/drivers/crypto/ti/dthev2-c= ommon.h index 75d9a097650da..a827817e8119a 100644 --- a/drivers/crypto/ti/dthev2-common.h +++ b/drivers/crypto/ti/dthev2-common.h @@ -18,12 +18,14 @@ #include #include =20 +#include #include #include #include #include #include #include +#include =20 #define DTHE_REG_SIZE 4 #define DTHE_DMA_TIMEOUT_MS 2000 @@ -53,6 +55,8 @@ enum dthe_aes_mode { * @dma_aes_rx: AES Rx DMA Channel * @dma_aes_tx: AES Tx DMA Channel * @dma_sha_tx: SHA Tx DMA Channel + * @req_refcnt: Count of requests currently using this instance. + * @drain_wq: Waited on by dthe_remove() until @req_refcnt reaches zero. */ struct dthe_data { struct device *dev; @@ -64,6 +68,9 @@ struct dthe_data { struct dma_chan *dma_aes_tx; =20 struct dma_chan *dma_sha_tx; + + atomic_t req_refcnt; + wait_queue_head_t drain_wq; }; =20 /** @@ -78,7 +85,7 @@ struct dthe_list { =20 /** * struct dthe_tfm_ctx - Transform ctx struct containing ctx for all sub-c= omponents of DTHE V2 - * @dev_data: Device data struct pointer + * @dev: Device this transform is bound to. * @keylen: AES key length * @authsize: Authentication size for modes with authentication * @key: AES key @@ -87,7 +94,7 @@ struct dthe_list { * @skcipher_fb: Fallback crypto skcipher handle for AES-XTS mode */ struct dthe_tfm_ctx { - struct dthe_data *dev_data; + struct device *dev; unsigned int keylen; unsigned int authsize; u32 key[DTHE_MAX_KEYSIZE / sizeof(u32)]; @@ -103,16 +110,55 @@ struct dthe_tfm_ctx { * @enc: flag indicating encryption or decryption operation * @padding: padding buffer for handling unaligned data * @aes_compl: Completion variable for use in manual completion in case of= DMA callback failure + * @dev_data: Device data struct pointer */ struct dthe_aes_req_ctx { int enc; u8 padding[2 * AES_BLOCK_SIZE]; struct completion aes_compl; + struct dthe_data *dev_data; }; =20 /* Struct definitions end */ =20 -struct dthe_data *dthe_get_dev(struct dthe_tfm_ctx *ctx); +/** + * dthe_get_dev - Get the device pointer after increasing its reference co= unt + * + * Description: + * Picks a device instance and gets the associated device pointer throu= gh get_device() + * to maintain its reference count by the kernel itself. Callers must e= nsure to call + * dthe_put_dev() at exit to decrease the refcnt. + */ +struct device *dthe_get_dev(void); + +/** + * dthe_put_dev - Decrease the reference count of the device + * @dev: Device pointer to be released + * + * Description: + * Decreases the reference count of the device pointer obtained through= dthe_get_dev() + * by calling put_device(). + */ +void dthe_put_dev(struct device *dev); + +/** + * dthe_get_drvdata - Get a reference counted device driver data pointer + * @dev: Device pointer + * + * Description: + * Returns the instance's driver data if it is still bound, with @req_r= efcnt + * incremented, or NULL if it has been removed. Every req accepted for + * processing must call this and balance it with exactly one + * dthe_put_drvdata() when done. + */ +struct dthe_data *dthe_get_drvdata(struct device *dev); + +/** + * dthe_put_drvdata - Decrease the refcnt of the device driver data acquir= ed through + * dthe_get_drvdata() + * @dev_data: Driver data previously returned by dthe_get_drvdata() + */ +void dthe_put_drvdata(struct dthe_data *dev_data); =20 /** * dthe_copy_sg - Copy sg entries from src to dst --=20 2.34.1 From nobody Fri Sep 25 16:02:52 2026 Received: from mx0a-0002e601.pphosted.com (mx0a-0002e601.pphosted.com [148.163.150.75]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id AE93C563FCB; Thu, 10 Sep 2026 17:57:47 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=fail smtp.client-ip=148.163.150.75 ARC-Seal: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1789063071; cv=fail; b=jpED5hPBxlK3yklgmb/smU5koSsqaUIuk6UbTUgB+Spw3XTy3pie1EPplwwpy/GOwJWZEV45wVGGU9G3ubxONuKys21xeAN2c37G/ajJ6+ilQ4/2hdVqp737ijhiZNsE0c4rPHA+y7zZ6mcmjFo/sHB+4M3KjIjzVVrd33VQo/0= ARC-Message-Signature: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1789063071; c=relaxed/simple; bh=14+lpbbjuBYbleZZptnnErmVsbsXKn0WAKM8jdF9Cmo=; h=From:To:CC:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=isknBHDXe1V2Mb1sA57/yextXKa1u9CaGJ1HpY7VfBBzWA3LAVC+rzvzJmfdzSVZdqwaMB7X5+ItvP3LC5JcneGeSpshHPUQdHUuGYbJR/ivM8cTo32t0vryDm3Tqspdsyc9Ifqg5JUEhut+n7+mMDF3AtHDGHLdBP7towaEqKI= ARC-Authentication-Results: i=2; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=ti.com; spf=pass smtp.mailfrom=ti.com; dkim=pass (2048-bit key) header.d=ti.com header.i=@ti.com header.b=f/PI7YrV; dkim=pass (1024-bit key) header.d=ti.com header.i=@ti.com header.b=C+OoXgET; arc=fail smtp.client-ip=148.163.150.75 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=ti.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=ti.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=ti.com header.i=@ti.com header.b="f/PI7YrV"; dkim=pass (1024-bit key) header.d=ti.com header.i=@ti.com header.b="C+OoXgET" Received: from pps.filterd (m0380145.ppops.net [127.0.0.1]) by m0380145.ppops.net (8.18.1.11/8.18.1.11) with ESMTP id 68AF66BC3467971; Thu, 10 Sep 2026 12:57:44 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ti.com; h=cc :content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s= proofpoint-05-2026; bh=WCBqois36VGrEk3wC02QqgtiaiTky+9IMvxqB6ixU u4=; b=f/PI7YrVpAy6mp6qqt7yn99IbYsNyQgIQ4Nwwm7kVuPRyYLv9dd1hHZTQ 5VZEa5nRx0zGbXtIDecyUwOXGkPS0L45zP/L5xGbc8bRMMvBeiNkD6LAHd3K8pQZ i8q3cAuokiv3g9NTMV+S016Z6q+/MKSDLzTBHKeh780HB3QMQwKom5QS697FUCUs pOf02rBBrkobfK538FTYD0w2pfsQqfHn5CO5eKYY3Y5tyfRm29YjMc+cE4Apjtxc wztOJBYezmpOipRfliPwMMpqxlqoAjegWsmSFHgHyDpsnC6X2zoVVhyUWXN0/WEO VX303dH0HNSoyZm1CyTXlRwyfD30A== Received: from sj2pr03cu001.outbound.protection.outlook.com (mail-westusazon11012016.outbound.protection.outlook.com [52.101.43.16]) by m0380145.ppops.net (PPS) with ESMTPS id 4gkstvb43r-1 (version=TLSv1.3 cipher=TLS_AES_256_GCM_SHA384 bits=256 verify=NOT); Thu, 10 Sep 2026 12:57:43 -0500 (CDT) ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=W86vvwD4WS9V6ao0SX0hTfz4CVh3tkyeTP+6LO723Cqxm2EzamgJkWvXoBlb8jhtHGOkl1oyGVFEMRGxJl9q9EJRKgcMRWTFOgPHLR6tv6LatC/PfbMgC9Lk2pCD0W2rK3ZRRnvd47JFz742ZhPZbBMIsHjo1/0hLnuDMU2x6wwpxLt/ALsY6VCOPbunJiTV/+tCgWO8BOycWzha1kkqzUf2bT+GxNW5ZaAuZjGThSZHw1uy/hsNXGbaEkd49gVrYWhvkB7xdft5TPWxaQC5eeFKcgJIsWxTKlQ+VfkKJrNrUs7cXFXcvJ7eX/JjjUYbTMYudWl5CtP2Nn0BD2nvWQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=WCBqois36VGrEk3wC02QqgtiaiTky+9IMvxqB6ixUu4=; b=Qh3NkC6xoKVDV+wxricbbkYBU+i3p8m1CSMj3tiAOw1VtE8KXrouJBHC61wtqoyZoKqVIgB1bxTa0cUJkMwJdVQER5Ih5e0avDGD2Ibv/sLqyzMt9onFsx26SpwJI9hCBGIOF0I2zeB3aP8htvSN1wyNWbgwWfhItLYHbTAz+pyuS6iGsNN+Rlt0LTWyP0zCl6C4T357+wlLz2wKbm/WBQOaBeAekjvZovDcjO6uRWmX3sWRjCTa8j7t3xQfd2hPWVFS5QWQHN2r2nyhhkNqZ2GGRN+Azumilmdq+I20us/9wudAEif6MY2UqqSzqoNIGODTblLqguwmRiTuJTsk5w== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 198.47.21.194) smtp.rcpttodomain=gondor.apana.org.au smtp.mailfrom=ti.com; dmarc=pass (p=quarantine sp=none pct=100) action=none header.from=ti.com; dkim=none (message not signed); arc=none (0) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ti.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=WCBqois36VGrEk3wC02QqgtiaiTky+9IMvxqB6ixUu4=; b=C+OoXgETASwjcAay1f3hb2h/ao61XD5HINtGR/ZDFzYhL3LxCQZ+vlII8DQ6qJTfWGrxRLyGqTX/0K5FSf2zYVOobZF8s+o8e1H9rpsYlQPGvlf0uEhcYf+4hVwgH7QhrSX5CLO3HOoIxbVvGZ7ArWsG1WWS7ZloXHZPqhiymCM= Received: from SJ0PR05CA0049.namprd05.prod.outlook.com (2603:10b6:a03:33f::24) by DSVPR10MB997870.namprd10.prod.outlook.com (2603:10b6:8:45d::17) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.21.406.7; Thu, 10 Sep 2026 17:57:40 +0000 Received: from CO1PEPF00012E7E.namprd03.prod.outlook.com (2603:10b6:a03:33f:cafe::9c) by SJ0PR05CA0049.outlook.office365.com (2603:10b6:a03:33f::24) with Microsoft SMTP Server (version=TLS1_3, cipher=TLS_AES_256_GCM_SHA384) id 15.21.428.5 via Frontend Transport; Thu, 10 Sep 2026 17:57:40 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 198.47.21.194) smtp.mailfrom=ti.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=ti.com; Received-SPF: Pass (protection.outlook.com: domain of ti.com designates 198.47.21.194 as permitted sender) receiver=protection.outlook.com; client-ip=198.47.21.194; helo=flwvzet200.ext.ti.com; pr=C Received: from flwvzet200.ext.ti.com (198.47.21.194) by CO1PEPF00012E7E.mail.protection.outlook.com (10.167.249.53) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.21.406.5 via Frontend Transport; Thu, 10 Sep 2026 17:57:38 +0000 Received: from DFLE200.ent.ti.com (10.64.6.58) by flwvzet200.ext.ti.com (10.248.192.31) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.2562.45; Thu, 10 Sep 2026 12:56:47 -0500 Received: from DFLE215.ent.ti.com (10.64.6.73) by DFLE200.ent.ti.com (10.64.6.58) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.2562.45; Thu, 10 Sep 2026 12:56:47 -0500 Received: from lelvem-mr05.itg.ti.com (10.180.75.9) by DFLE215.ent.ti.com (10.64.6.73) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.2562.45 via Frontend Transport; Thu, 10 Sep 2026 12:56:47 -0500 Received: from pratham-Workstation-PC (pratham-workstation-pc.dhcp.ti.com [10.24.53.205]) by lelvem-mr05.itg.ti.com (8.18.1/8.18.1) with ESMTP id 68AHukgl3763714; Thu, 10 Sep 2026 12:56:47 -0500 From: T Pratham To: T Pratham , Herbert Xu , "David S. Miller" CC: Sebin Francis , Manorit Chawdhry , Vishal Mahaveer , Praneeth Bajjuri , Kamlesh Gurudasani , , Subject: [PATCH v4 05/15] crypto: ti - Trim scatterlists to correct length in AES Date: Thu, 10 Sep 2026 23:26:09 +0530 Message-ID: <20260910175619.2122149-6-t-pratham@ti.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20260910175619.2122149-1-t-pratham@ti.com> References: <20260910175619.2122149-1-t-pratham@ti.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: CO1PEPF00012E7E:EE_|DSVPR10MB997870:EE_ X-MS-Office365-Filtering-Correlation-Id: af480631-b1a0-46aa-3894-08df0f6500cb X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|82310400026|36860700016|376014|23010399003|1800799024|6133799003|18002099003|22082099003|56012099006|10067099003; X-Microsoft-Antispam-Message-Info: dO+Us9Pv0YvZ9rIAtu8BJ6qey9xGHoS75cdma/V+OxaeP2T8G/Af9CYModCgK+5EWLwEWAkvj3tzhX5EG1/f+lrCLjrU0HROks7j+YsH0OvjOzZrTpWfyAfAe/o60OOwEyN8lEagAXxDfZSGybwutZNEm1OdCfLFyAkj3ekXLMdxnDhx7pO11BsESEx4ZiysH2wOYuWIVGsW3iEUAYV2GwnCKYMUrU9SFdk6m55Pb5i83c6WkquF9/9FXju9UkKR2LUJZys/qbOGiSk7a2GEXc+yKzOstER+j9oac3eDmqYfy09dEKuHCFObkZejtoE31vw2euGemEdnrL3e1Yx7GfI7gcWZrOZ3kAKCCSV8RAdsbhXd/IFclLPhDYLjFpmSf8qr1dSBlo/ocBy7sqLnvX/2FIhWYHddUMho/y7R/mwXCUVacJYRPpiPe+9c0VhfVDQ1pEs9NCHmrqgylVa0a9OZOUKFlRjbqJk8o9OMZPWVhOWrfZiZLvR2gckThh2+ChaOL7av9J/c+KgzWPQ7wslDePT29Tl+q3UpX9GpKyJsMfY6TrtuiTqCcpgNd6x/hWnOwwfHeiDq/soP9eXdIVMUYm0DmUFiiuL453njZzL2uswU6SXrdBOs779kQCMbkkx3PbXI3t3Lwmp1uQjvImllpW1xyYo30ft6+yFASAoA5d4ddKLjGD1b52BmlN6nU1Yfne8LgcBsA5q2a6UCAw== X-Forefront-Antispam-Report: CIP:198.47.21.194;CTRY:US;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:flwvzet200.ext.ti.com;PTR:ErrorRetry;CAT:NONE;SFS:(13230040)(82310400026)(36860700016)(376014)(23010399003)(1800799024)(6133799003)(18002099003)(22082099003)(56012099006)(10067099003);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: hdeBNwtnHwcrDLEA287U4vQc+QzmoRT1/6mZ/4A7lW+DPhgo0gkK5xqJ5rH8dsrTjnA5YXI3h7b00HNnhzF01y2XKIvtdRTaIuBWkGWwzKjUFM2J+VUVD1JlKnCmJLqfjB0//Cp2hr6dc4Mditv7TsgV0+p8nIIjP7WFhnONKMsQxHkQMb3/h5ceJuK3zkN7wEzpeRBrGOCm+H6gWOtmhWUO6npZVL0R8/OOqMyZ1M20RrKmYjOlVNkni/B3/gVWvBlO0KUo2/BZwDiXkl2LiuRGHTFOqzjRSx5UtHXH/BODCm07PZSnBur0w+OyJS5TrUo3N00WMlFt32EB64q+TkYiaqlqyCZyAZpizGxrnP4DZWG5wLycAPoV8qADvSIrAWEWO7nGO6d0rdNNg39N9GRs0ouZjjIwWZ4vhAA+tOudA3+NwS4LZq0MWRHqeFEB X-Exchange-RoutingPolicyChecked: IMXHoH4ky/xB84A0DBdQDBSERZvVt/MRkglnReT2jvGxHG8lIOc/xepvVqecO6u33MsOeXAEy+8gCYjI6lBPFF8G6ixXZCKmjprtwke8lEce5aaYBM87t8WNEE58GpNhxQh0KH0fiEOdAB9cnGgxbWURPPJENBlKyRYIXoq7VCFcRBSRF5wgIHBxlU+9mojw/Mg1H/09r6BnMZQby6y/r3RGE7dFtfl31u3CRpW6rh0y8WloKmjJrASNk52S6dYBq7+olCxcrOo29UZHdQwBrFFM1z7pPOdPqVj7QOFtqL/bQZTWowEHQwg8i2j1FF9nPYN48jUTd+GjU1gmPcoBEw== X-OriginatorOrg: ti.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 10 Sep 2026 17:57:38.7991 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: af480631-b1a0-46aa-3894-08df0f6500cb X-MS-Exchange-CrossTenant-Id: e5b49634-450b-4709-8abb-1e2b19b982b7 X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=e5b49634-450b-4709-8abb-1e2b19b982b7;Ip=[198.47.21.194];Helo=[flwvzet200.ext.ti.com] X-MS-Exchange-CrossTenant-AuthSource: CO1PEPF00012E7E.namprd03.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: DSVPR10MB997870 X-Proofpoint-Spam-Info: AW1haW4tMjYwOTEwMDIyMCBTYWx0ZWRfX0ryCCpyjUCrB 3xKTLDF9oamX3cf77RfyslJ/oG+XTcgtw3vhyUOv3Zp9PQcNEvVoQ7Qb09fyfWAm4pb5kDJJQaw iz54dNyCFBhj2jJO3KObMPJnQBXCNFg= X-Proofpoint-GUID: 8Dz_EtTuXboa0traO00SfDTYtXiwFkTg X-Authority-Analysis: v=2.4 cv=VvG2kO2n c=1 sm=1 tr=0 ts=6aa2ef97 cx=c_pps a=wX+iSCk909IGAd/hxyKeOw==:117 a=iwqwCZQqcuTv3JOpYdM7/Q==:17 a=6eWqkTHjU83fiwn7nKZWdM+Sl24=:19 a=VdqzKS8jKosA:10 a=V5UXEbMT0ywA:10 a=VkNPw1HP01LnGYTKEx00:22 a=Z8NIEmU8O1QQgoT56wFK:22 a=gO1vWkAQAl3rybz1DQOp:22 a=sozttTNsAAAA:8 a=Tpn98H0sjD_mw3BxSIoA:9 X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwOTEwMDIyMCBTYWx0ZWRfX7YEtGUwxadMF /Xm92eg+GufHI2l8WCCThCmpegkz2RLBi3HG8NJi2zFyBDoN6dcb4rA9//lrD/H5L42xs8U7Xac DJ6O7GsmFBdc9UWNmIgg8RYf/V55pJbr5N9CT3uSKfhhn/kb4W8iMMpo9Y9rljVW/rg/t5rtNbR 2NwYNSo+5jI9ZRAqZW5AAmrC7lS64ug7DezXJCwwlYil04EexWHKkF/k2vwzf21VFdf8Szbjzlz KRjEFSOVG2WBy4RkvvYPeJ+a10F9Gqmr1aE+sQgvl8EiekFZ7aZFZovCqQjAYOsiTiPeYjwI0f9 47UQeNzg4oISSd6qzcXue9Px37w4MuKpt/kTUvI/X7almyLktYaZ5t3MQcs82FE7VreUEvwwcJN PFT50K0iCcRNN1M1dH4Rh9BUh88kRIdjHvopCqJRWHur+QjdOfNWmO6TkM9dFpntwbWQn/56g2l w9248C/aBwgo4IEFVxQ== X-Proofpoint-ORIG-GUID: 8Dz_EtTuXboa0traO00SfDTYtXiwFkTg X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1176,Hydra:6.1.134,FMLib:17.12.100.49 definitions=2026-09-10_05,2026-09-09_02,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 adultscore=0 bulkscore=0 lowpriorityscore=0 priorityscore=1501 suspectscore=0 malwarescore=0 spamscore=0 phishscore=0 impostorscore=0 clxscore=1015 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2609040000 definitions=main-2609100220 Content-Type: text/plain; charset="utf-8" AES functions were using src and dst scatterlists directly provided by the request. This is problematic as it is not guaranteed that the input scatterlist is exactly the length reqired. This problem was seen in IPSec use case when the kernel provides the scatterlist which contains space for plaintext/ciphertext and TAG. The problem comes when the scatterlist is mapped and sent via DMA. The K3 UDMA sends/waits for the amount of data equal to the length of scatterlist mapped. So when the last mapped nent contains some extra length, the DMA keeps waiting for the extra data and eventually times out and crashes. Mitigate this by copying the nents to a local scatterlist, copying only exactly cryptlen of data. Note that this does not copy the whole data, but rather only the scatterlist mapping. So it is not as penalising on performance. Fixes: 52f641bc63a4 ("crypto: ti - Add driver for DTHE V2 AES Engine (ECB, = CBC)") Signed-off-by: T Pratham Reviewed-by: Kamlesh Gurudasani --- drivers/crypto/ti/dthev2-aes.c | 145 ++++++++++++++++----------------- 1 file changed, 69 insertions(+), 76 deletions(-) diff --git a/drivers/crypto/ti/dthev2-aes.c b/drivers/crypto/ti/dthev2-aes.c index 6a8fbe67ef6cd..be7ec62ab2513 100644 --- a/drivers/crypto/ti/dthev2-aes.c +++ b/drivers/crypto/ti/dthev2-aes.c @@ -108,19 +108,6 @@ enum aes_ctrl_mode_masks { #define POLL_TIMEOUT_INTERVAL HZ =20 static int dthe_cipher_init_tfm(struct crypto_skcipher *tfm) -{ - struct dthe_tfm_ctx *ctx =3D crypto_skcipher_ctx(tfm); - - ctx->dev =3D dthe_get_dev(); - if (!dev) - return -ENODEV; - - ctx->keylen =3D 0; - - return 0; -} - -static int dthe_cipher_init_tfm_fallback(struct crypto_skcipher *tfm) { struct dthe_tfm_ctx *ctx =3D crypto_skcipher_ctx(tfm); const char *alg_name =3D crypto_tfm_alg_name(crypto_skcipher_tfm(tfm)); @@ -154,19 +141,24 @@ static int dthe_aes_setkey(struct crypto_skcipher *tf= m, const u8 *key, unsigned { struct dthe_tfm_ctx *ctx =3D crypto_skcipher_ctx(tfm); =20 - if (keylen !=3D AES_KEYSIZE_128 && keylen !=3D AES_KEYSIZE_192 && keylen = !=3D AES_KEYSIZE_256) - return -EINVAL; - ctx->keylen =3D keylen; memcpy(ctx->key, key, keylen); =20 - return 0; + crypto_sync_skcipher_clear_flags(ctx->skcipher_fb, CRYPTO_TFM_REQ_MASK); + crypto_sync_skcipher_set_flags(ctx->skcipher_fb, + crypto_skcipher_get_flags(tfm) & + CRYPTO_TFM_REQ_MASK); + + return crypto_sync_skcipher_setkey(ctx->skcipher_fb, key, keylen); } =20 static int dthe_aes_ecb_setkey(struct crypto_skcipher *tfm, const u8 *key,= unsigned int keylen) { struct dthe_tfm_ctx *ctx =3D crypto_skcipher_ctx(tfm); =20 + if (keylen !=3D AES_KEYSIZE_128 && keylen !=3D AES_KEYSIZE_192 && keylen = !=3D AES_KEYSIZE_256) + return -EINVAL; + ctx->aes_mode =3D DTHE_AES_ECB; =20 return dthe_aes_setkey(tfm, key, keylen); @@ -176,6 +168,9 @@ static int dthe_aes_cbc_setkey(struct crypto_skcipher *= tfm, const u8 *key, unsig { struct dthe_tfm_ctx *ctx =3D crypto_skcipher_ctx(tfm); =20 + if (keylen !=3D AES_KEYSIZE_128 && keylen !=3D AES_KEYSIZE_192 && keylen = !=3D AES_KEYSIZE_256) + return -EINVAL; + ctx->aes_mode =3D DTHE_AES_CBC; =20 return dthe_aes_setkey(tfm, key, keylen); @@ -184,24 +179,19 @@ static int dthe_aes_cbc_setkey(struct crypto_skcipher= *tfm, const u8 *key, unsig static int dthe_aes_ctr_setkey(struct crypto_skcipher *tfm, const u8 *key,= unsigned int keylen) { struct dthe_tfm_ctx *ctx =3D crypto_skcipher_ctx(tfm); - int ret =3D dthe_aes_setkey(tfm, key, keylen); =20 - if (ret) - return ret; + if (keylen !=3D AES_KEYSIZE_128 && keylen !=3D AES_KEYSIZE_192 && keylen = !=3D AES_KEYSIZE_256) + return -EINVAL; =20 ctx->aes_mode =3D DTHE_AES_CTR; =20 - crypto_sync_skcipher_clear_flags(ctx->skcipher_fb, CRYPTO_TFM_REQ_MASK); - crypto_sync_skcipher_set_flags(ctx->skcipher_fb, - crypto_skcipher_get_flags(tfm) & - CRYPTO_TFM_REQ_MASK); - - return crypto_sync_skcipher_setkey(ctx->skcipher_fb, key, keylen); + return dthe_aes_setkey(tfm, key, keylen); } =20 static int dthe_aes_xts_setkey(struct crypto_skcipher *tfm, const u8 *key,= unsigned int keylen) { struct dthe_tfm_ctx *ctx =3D crypto_skcipher_ctx(tfm); + int ret; =20 if (keylen !=3D 2 * AES_KEYSIZE_128 && keylen !=3D 2 * AES_KEYSIZE_192 && @@ -209,15 +199,12 @@ static int dthe_aes_xts_setkey(struct crypto_skcipher= *tfm, const u8 *key, unsig return -EINVAL; =20 ctx->aes_mode =3D DTHE_AES_XTS; - ctx->keylen =3D keylen / 2; - memcpy(ctx->key, key, keylen); - - crypto_sync_skcipher_clear_flags(ctx->skcipher_fb, CRYPTO_TFM_REQ_MASK); - crypto_sync_skcipher_set_flags(ctx->skcipher_fb, - crypto_skcipher_get_flags(tfm) & - CRYPTO_TFM_REQ_MASK); + ret =3D dthe_aes_setkey(tfm, key, keylen); + if (ret) + return ret; =20 - return crypto_sync_skcipher_setkey(ctx->skcipher_fb, key, keylen); + ctx->keylen =3D keylen / 2; + return 0; } =20 static void dthe_aes_set_ctrl_key(struct dthe_tfm_ctx *ctx, @@ -340,8 +327,10 @@ static int dthe_aes_run(struct crypto_engine *engine, = void *areq) struct dthe_data *dev_data =3D rctx->dev_data; =20 unsigned int len =3D req->cryptlen; + unsigned int pad_len =3D 0; struct scatterlist *src =3D req->src; struct scatterlist *dst =3D req->dst; + struct scatterlist *sg; =20 int src_nents =3D sg_nents_for_len(src, len); int dst_nents =3D sg_nents_for_len(dst, len); @@ -384,38 +373,38 @@ static int dthe_aes_run(struct crypto_engine *engine,= void *areq) * We need to handle the padding in the driver. */ if (ctx->aes_mode =3D=3D DTHE_AES_CTR && req->cryptlen % AES_BLOCK_SIZE) { - unsigned int pad_size =3D AES_BLOCK_SIZE - (req->cryptlen % AES_BLOCK_SI= ZE); - u8 *pad_buf =3D rctx->padding; - struct scatterlist *sg; - - len +=3D pad_size; + pad_len =3D AES_BLOCK_SIZE - (req->cryptlen % AES_BLOCK_SIZE); + len +=3D pad_len; src_nents++; dst_nents++; + } =20 - src =3D kmalloc_array(src_nents, sizeof(*src), GFP_ATOMIC); - if (!src) { - ret =3D -ENOMEM; - goto aes_ctr_src_alloc_err; - } - - sg_init_table(src, src_nents); - sg =3D dthe_copy_sg(src, req->src, req->cryptlen); - memzero_explicit(pad_buf, AES_BLOCK_SIZE); - sg_set_buf(sg, pad_buf, pad_size); + src =3D kmalloc_array(src_nents, sizeof(*src), GFP_ATOMIC); + if (!src) { + ret =3D -ENOMEM; + goto aes_src_alloc_err; + } =20 - if (diff_dst) { - dst =3D kmalloc_array(dst_nents, sizeof(*dst), GFP_ATOMIC); - if (!dst) { - ret =3D -ENOMEM; - goto aes_ctr_dst_alloc_err; - } + sg_init_table(src, src_nents); + sg =3D dthe_copy_sg(src, req->src, req->cryptlen); + if (pad_len > 0) { + memzero_explicit(rctx->padding, AES_BLOCK_SIZE); + sg_set_buf(sg, rctx->padding, pad_len); + } =20 - sg_init_table(dst, dst_nents); - sg =3D dthe_copy_sg(dst, req->dst, req->cryptlen); - sg_set_buf(sg, pad_buf, pad_size); - } else { - dst =3D src; + if (diff_dst) { + dst =3D kmalloc_array(dst_nents, sizeof(*dst), GFP_ATOMIC); + if (!dst) { + ret =3D -ENOMEM; + goto aes_dst_alloc_err; } + + sg_init_table(dst, dst_nents); + sg =3D dthe_copy_sg(dst, req->dst, req->cryptlen); + if (pad_len > 0) + sg_set_buf(sg, rctx->padding, pad_len); + } else { + dst =3D src; } =20 tx_dev =3D dmaengine_get_dma_device(dev_data->dma_aes_tx); @@ -502,19 +491,19 @@ static int dthe_aes_run(struct crypto_engine *engine,= void *areq) dma_unmap_sg(tx_dev, src, src_nents, src_dir); =20 aes_map_src_err: - if (ctx->aes_mode =3D=3D DTHE_AES_CTR && req->cryptlen % AES_BLOCK_SIZE) { + if (ctx->aes_mode =3D=3D DTHE_AES_CTR && req->cryptlen % AES_BLOCK_SIZE) memzero_explicit(rctx->padding, AES_BLOCK_SIZE); - if (diff_dst) - kfree(dst); -aes_ctr_dst_alloc_err: - kfree(src); -aes_ctr_src_alloc_err: - /* - * Fallback to software if ENOMEM - */ - if (ret =3D=3D -ENOMEM) - ret =3D dthe_aes_do_fallback(req); - } + if (diff_dst) + kfree(dst); + +aes_dst_alloc_err: + kfree(src); +aes_src_alloc_err: + /* + * Fallback to software if ENOMEM + */ + if (ret =3D=3D -ENOMEM) + ret =3D dthe_aes_do_fallback(req); =20 local_bh_disable(); crypto_finalize_skcipher_request(dev_data->engine, req, ret); @@ -1240,6 +1229,7 @@ static int dthe_aead_decrypt(struct aead_request *req) static struct skcipher_engine_alg cipher_algs[] =3D { { .base.init =3D dthe_cipher_init_tfm, + .base.exit =3D dthe_cipher_exit_tfm, .base.setkey =3D dthe_aes_ecb_setkey, .base.encrypt =3D dthe_aes_encrypt, .base.decrypt =3D dthe_aes_decrypt, @@ -1251,7 +1241,8 @@ static struct skcipher_engine_alg cipher_algs[] =3D { .cra_priority =3D 299, .cra_flags =3D CRYPTO_ALG_TYPE_SKCIPHER | CRYPTO_ALG_ASYNC | - CRYPTO_ALG_KERN_DRIVER_ONLY, + CRYPTO_ALG_KERN_DRIVER_ONLY | + CRYPTO_ALG_NEED_FALLBACK, .cra_alignmask =3D AES_BLOCK_SIZE - 1, .cra_blocksize =3D AES_BLOCK_SIZE, .cra_ctxsize =3D sizeof(struct dthe_tfm_ctx), @@ -1262,6 +1253,7 @@ static struct skcipher_engine_alg cipher_algs[] =3D { }, /* ECB AES */ { .base.init =3D dthe_cipher_init_tfm, + .base.exit =3D dthe_cipher_exit_tfm, .base.setkey =3D dthe_aes_cbc_setkey, .base.encrypt =3D dthe_aes_encrypt, .base.decrypt =3D dthe_aes_decrypt, @@ -1274,7 +1266,8 @@ static struct skcipher_engine_alg cipher_algs[] =3D { .cra_priority =3D 299, .cra_flags =3D CRYPTO_ALG_TYPE_SKCIPHER | CRYPTO_ALG_ASYNC | - CRYPTO_ALG_KERN_DRIVER_ONLY, + CRYPTO_ALG_KERN_DRIVER_ONLY | + CRYPTO_ALG_NEED_FALLBACK, .cra_alignmask =3D AES_BLOCK_SIZE - 1, .cra_blocksize =3D AES_BLOCK_SIZE, .cra_ctxsize =3D sizeof(struct dthe_tfm_ctx), @@ -1284,7 +1277,7 @@ static struct skcipher_engine_alg cipher_algs[] =3D { .op.do_one_request =3D dthe_aes_run, }, /* CBC AES */ { - .base.init =3D dthe_cipher_init_tfm_fallback, + .base.init =3D dthe_cipher_init_tfm, .base.exit =3D dthe_cipher_exit_tfm, .base.setkey =3D dthe_aes_ctr_setkey, .base.encrypt =3D dthe_aes_encrypt, @@ -1309,7 +1302,7 @@ static struct skcipher_engine_alg cipher_algs[] =3D { .op.do_one_request =3D dthe_aes_run, }, /* CTR AES */ { - .base.init =3D dthe_cipher_init_tfm_fallback, + .base.init =3D dthe_cipher_init_tfm, .base.exit =3D dthe_cipher_exit_tfm, .base.setkey =3D dthe_aes_xts_setkey, .base.encrypt =3D dthe_aes_encrypt, --=20 2.34.1 From nobody Fri Sep 25 16:02:52 2026 Received: from mx0a-0002e601.pphosted.com (mx0a-0002e601.pphosted.com [148.163.150.75]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id ABA8455D86A; Thu, 10 Sep 2026 17:57:05 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=fail smtp.client-ip=148.163.150.75 ARC-Seal: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1789063027; cv=fail; b=iu42CB4A5ydNkLSZnO8gDZo43IBBoe8+e35wZpzimjySW2ZO2Oag4Uj1/TdqMyRTGzRhv521ih/UKWeAAr0tfkwE8/ufr0JO0tLUd2b9Sp/tc2dAlsGQyBga/H5DNUdf6jMSw7lEGVySK3AtNZ02yPZbEjnem6XhPxyau68+aLE= ARC-Message-Signature: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1789063027; c=relaxed/simple; bh=xb+vL0JDbiPKN7Wt2F5InRrdoz1YYUcDoCoOu4uU4Hg=; h=From:To:CC:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=IXgJKBaXATS76hycx+X5eqtyF/FQEYujevRqLQv8WKbnJe7+cceDNQcREmlEZFONRSgOsFgttRKETE9cQAnulDJXOdmePyVEUVF2/pe46Xh7snRtVgbCTFmArLM1GTOSLNw5F4VMuaoKY+fYiK3LOqXG5OKArI1dXSHeLxJ9QAk= ARC-Authentication-Results: i=2; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=ti.com; spf=pass smtp.mailfrom=ti.com; dkim=pass (2048-bit key) header.d=ti.com header.i=@ti.com header.b=V3vgUCh6; dkim=pass (1024-bit key) header.d=ti.com header.i=@ti.com header.b=irmscqJN; arc=fail smtp.client-ip=148.163.150.75 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=ti.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=ti.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=ti.com header.i=@ti.com header.b="V3vgUCh6"; dkim=pass (1024-bit key) header.d=ti.com header.i=@ti.com header.b="irmscqJN" Received: from pps.filterd (m0380145.ppops.net [127.0.0.1]) by m0380145.ppops.net (8.18.1.11/8.18.1.11) with ESMTP id 68AF66BA3467971; Thu, 10 Sep 2026 12:57:02 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ti.com; h=cc :content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s= proofpoint-05-2026; bh=9AAog4xG5I3fqrRUyrRYVntKwYPVthg9NlLstka6J 8o=; b=V3vgUCh6NdZEQyHTmn7BHsw7Vz8c09uE3ipwdvRfY1R+A0/dagBy1FVfJ MsaHbuu0I4eDQeiDbYgZMmtlm95uEc3kAyMAEHO7iPqOzhJUfg5TYfNhu2cy64bB Gqi7LWIiUzpotw3E2fcBhPK4E9VWb9zFHMTjMH1Cn73vp9e3ICHPEguA76tnQPOq fomkVR2yiHV635+hZvzXDSkWxw9r0MudrKXAlkFKbXuQbBwQEpVVPDYTnhbZrNdF nof1EpuSPVW63aHX/Vyel3W3S4Dd5O5Mjv9dt/wHjcMCYjGhg3Akp6tP/V4Ap67r eLxL/Yow7pWDX3EPj9L3s0TPlmWQA== Received: from ch1pr05cu001.outbound.protection.outlook.com (mail-northcentralusazon11010017.outbound.protection.outlook.com [52.101.193.17]) by m0380145.ppops.net (PPS) with ESMTPS id 4gkstvb3yr-1 (version=TLSv1.3 cipher=TLS_AES_256_GCM_SHA384 bits=256 verify=NOT); Thu, 10 Sep 2026 12:57:02 -0500 (CDT) ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=lEK1aihcjuJsS07MP0CsigEr6JZpEYc7UiVj8oPf6xAL8FWdOsSLwqRK8LkDJkkdbPzFuBYCMfaLip6G5j711u8roWmM0CRE94kEVYq4w+ssQB6nldnSr1NzmU+DcL3wrHnt20nGiK+NozlYjpYqT3SHZNghcRWNUGC1YOHraV4gw3nWK/gAKyp4sqo+UfHa9mb1LgJJIU3ThCBRKYyJm973x1H9RvznyWWVnR8k7gOmuOot34umP/I9HQUtw48eIjnmDoGRXbidL/QT17w7M4PUOLBUrbdjkgV8W/6ezHPlS39wD4HfHMs+4gw4XIXa1DECL7hUKdlhDEULRSf2Jg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=9AAog4xG5I3fqrRUyrRYVntKwYPVthg9NlLstka6J8o=; b=LLNrp00qBNgIeeoUyCqSdp/bg3Ub5rohXvG4eNU/oiNAapC+0sXvkuID6UfHVzANvjilVYGLqzQhB1GTgKtVBroHset/scpB7kU9cUiW16IKA4/4lDxw44G/iDV9Qd94Z24Rlc3RmRo3+CA23SGPMpZnMkMAMBCoAoDH7sbgGy6t54SIigXX94p1WK3SjNopwBQkjProxSm+7Nln81RBn8wzD1ViPjflAiPOC85Rt0oNNGvfEZHsNYStbDxXA+/Kryuc4iDoZwFiqDdmCEtlNNE1xISt+JUlNt1rfCcEpLgvm5QHl5du3dRUWxOL6l6vtM4w9t0ODw+evVWYI77u5A== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 198.47.23.195) smtp.rcpttodomain=gondor.apana.org.au smtp.mailfrom=ti.com; dmarc=pass (p=quarantine sp=none pct=100) action=none header.from=ti.com; dkim=none (message not signed); arc=none (0) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ti.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=9AAog4xG5I3fqrRUyrRYVntKwYPVthg9NlLstka6J8o=; b=irmscqJN0ZF0wSU8X+aIDtAln7WArYxNtVXUyfqWNlqpy7q0EA15RUkID2/5rdOk/5NxOIDY0uDUlMCE5TQG1P2Dl2Ki2HKz9uvt623uIHXHJ5TnHpySxX0mPkUqHkI3iy8eCRanwxtxzvAxCxH5+Dt2kgle35hLaBGqtVHoqGc= Received: from BN1PR12CA0007.namprd12.prod.outlook.com (2603:10b6:408:e1::12) by DS0PR10MB997603.namprd10.prod.outlook.com (2603:10b6:8:314::14) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.21.428.5; Thu, 10 Sep 2026 17:57:00 +0000 Received: from BL6PEPF00022573.namprd02.prod.outlook.com (2603:10b6:408:e1:cafe::3a) by BN1PR12CA0007.outlook.office365.com (2603:10b6:408:e1::12) with Microsoft SMTP Server (version=TLS1_3, cipher=TLS_AES_256_GCM_SHA384) id 15.21.406.9 via Frontend Transport; Thu, 10 Sep 2026 17:57:00 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 198.47.23.195) smtp.mailfrom=ti.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=ti.com; Received-SPF: Pass (protection.outlook.com: domain of ti.com designates 198.47.23.195 as permitted sender) receiver=protection.outlook.com; client-ip=198.47.23.195; helo=lewvzet201.ext.ti.com; pr=C Received: from lewvzet201.ext.ti.com (198.47.23.195) by BL6PEPF00022573.mail.protection.outlook.com (10.167.249.41) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.21.406.5 via Frontend Transport; Thu, 10 Sep 2026 17:57:00 +0000 Received: from DLEE207.ent.ti.com (157.170.170.95) by lewvzet201.ext.ti.com (10.4.14.104) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.2562.45; Thu, 10 Sep 2026 12:56:49 -0500 Received: from DLEE202.ent.ti.com (157.170.170.77) by DLEE207.ent.ti.com (157.170.170.95) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.2562.45; Thu, 10 Sep 2026 12:56:49 -0500 Received: from lelvem-mr05.itg.ti.com (10.180.75.9) by DLEE202.ent.ti.com (157.170.170.77) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.2562.45 via Frontend Transport; Thu, 10 Sep 2026 12:56:49 -0500 Received: from pratham-Workstation-PC (pratham-workstation-pc.dhcp.ti.com [10.24.53.205]) by lelvem-mr05.itg.ti.com (8.18.1/8.18.1) with ESMTP id 68AHumWx3763736; Thu, 10 Sep 2026 12:56:49 -0500 From: T Pratham To: T Pratham , Herbert Xu , "David S. Miller" CC: Sebin Francis , Manorit Chawdhry , Vishal Mahaveer , Praneeth Bajjuri , , Subject: [PATCH v4 06/15] crypto: ti - Align buffers to cacheline for DMA Date: Thu, 10 Sep 2026 23:26:10 +0530 Message-ID: <20260910175619.2122149-7-t-pratham@ti.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20260910175619.2122149-1-t-pratham@ti.com> References: <20260910175619.2122149-1-t-pratham@ti.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: BL6PEPF00022573:EE_|DS0PR10MB997603:EE_ X-MS-Office365-Filtering-Correlation-Id: 3abb372e-fe0d-412b-0243-08df0f64e9d5 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|36860700016|376014|23010399003|82310400026|1800799024|10067099003|18002099003|22082099003|56012099006; X-Microsoft-Antispam-Message-Info: BSc3XdVOpQyWsFquucCmtpIhMAvpTKPLJ6NlXoLlSMB82vihcsa1rM6oSgXNgxxWAzU8wyAbLpuQBDSo1HG9+aRSZGFW1Hbg1YRmB77m8RU2X3syNnJv+nSm5kdCv6S0J2wzQajArxxzD2SYPwUunDw8ld+8NrS/0tko96iZJN6qK5K+PKhLHlo5pjSi9N73E/Wez/Z/7/Zg735tM/wCK1QLawNIwozZB5eZCs3O/dGbNvaFcY+XGab8Le87RwqVgjYmWJhsfN6o2BuWwttgEh7L5iRJ3fDVdMVmPbphj/k3AyHVJY3vgetap0f7L+XR5zFrNAYUvlfln4N82bfHe1BhrRWdjvKK54CxgJ9gZ15VXHBv1nV7EkO/QyHUbYosZWD8ycxTC6RgO8FuiczFBQSZBqqdQiMDz4LCR0tbJgwEZDsplc9HgNU7x9eft36NqWYE6sspI1Q53TvrZEOulaV27JSI/qQUJwNaVX/sQ256txNT7D+rCW97fWeOoYl5qX9VURtlk6ITEHfqYPYyjpQwYD5hUiClHJVV7tYXFA//Xf5J45Hxa4Cm6dTUBxK/eLvSVwpDudtde1H1nUanJdcKWENMF9QNKCqM0LrbYBcnGZ3KQ6CUHjG1Vw6fJlKIM0mEJvIRc1EMiAU58/nye7XTALAz+BOpfwzNxx6evAb4JCxLTabOawIwKUV0IjoI X-Forefront-Antispam-Report: CIP:198.47.23.195;CTRY:US;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:lewvzet201.ext.ti.com;PTR:InfoDomainNonexistent;CAT:NONE;SFS:(13230040)(36860700016)(376014)(23010399003)(82310400026)(1800799024)(10067099003)(18002099003)(22082099003)(56012099006);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: DxVJ/0sjKUmVgDFYSEC6ldpZ0t1ViXYbnCHXVr8xIQX1SnE+kcXs9eKFqpsg8oqcmLPXTHvENpMUcchlCmiQuWk1IJ9KmOLpkf+4tAg/mbWQYQ/3MB98/0Gu172oeTbiSk8v7VLno15z1UocNCzrxzs3WTtFTtJvw6SssPxJhJtZZT9ZOXE6DKoGUUomXeILP5HJ58LC0Hkm1MNG00gf8Dr201Z/itIQbFQd4LCqMGJ7nKcmKQFOaK1MSXKJI7Us7vyJ79eRFAIP/aQc4mnNzHR2vT8fDINdMqrmS7SosfAcWCjyzGHV9JN6EN6kR6+TIIXv2vKSMjDW3x0Wdx8kJA1l0QQW+uAHhoCASZO/U94MtBzm52+1U4n2+OkoMak6IBqYw/jAgojSoaPCRxJ3bCu51H5x5zZo2zd9gXp+TX2g7rqeHx21bTWnrktXEhXB X-Exchange-RoutingPolicyChecked: SSOoBrdE07GHoGGuNv0m2X7LtwhCaQdpDVDFAnPHhfJss4CAVhnI25Az8YJ264udb+5hJjvrEGv8SZS+0fZlakB81GLwjri95ie4hfmM50KW/ljYeAPkItJpMjHl3knGAyNBYfq14fFOcp4Ll/S1mkdRsOFeudSX7exIeqYLEeZq0CGKYerht251K+Bm/COKuEvYiWus5jEWb31+M0ChkXFC1avPOpDbF7sUteIRrZz/GEEP1w4X2nItCMXlAVa3mfmLuyk685FPBbDWroGrjiOEdYSw2c4QY4OWxYbSznp6E8wEg+tn+iddmBD4gGXcqr/9x66fz31iodgqffSPAA== X-OriginatorOrg: ti.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 10 Sep 2026 17:57:00.2791 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 3abb372e-fe0d-412b-0243-08df0f64e9d5 X-MS-Exchange-CrossTenant-Id: e5b49634-450b-4709-8abb-1e2b19b982b7 X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=e5b49634-450b-4709-8abb-1e2b19b982b7;Ip=[198.47.23.195];Helo=[lewvzet201.ext.ti.com] X-MS-Exchange-CrossTenant-AuthSource: BL6PEPF00022573.namprd02.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: DS0PR10MB997603 X-Proofpoint-Spam-Info: AW1haW4tMjYwOTEwMDIyMCBTYWx0ZWRfXxDF+LQgZA8g4 5H+glRU4G7vN6zWx2qPc/8HffbBV3HtI2bdE1R3zEVd8ox56uNtcOm95JUzEGA5oyTQR+Hd8exw v2vCkurk3D5UNZq8MwDFalueCPVTWfM= X-Proofpoint-GUID: AOq3eX4Ee9oNTxtzWAmNFBcEq0Kuwqxo X-Authority-Analysis: v=2.4 cv=VvG2kO2n c=1 sm=1 tr=0 ts=6aa2ef6e cx=c_pps a=ZlG836pX3zBvGR9gn4UHEQ==:117 a=f+v6EHfkeJbVwR46tk4DMg==:17 a=6eWqkTHjU83fiwn7nKZWdM+Sl24=:19 a=VdqzKS8jKosA:10 a=s63m1ICgrNkA:10 a=V5UXEbMT0ywA:10 a=VkNPw1HP01LnGYTKEx00:22 a=Z8NIEmU8O1QQgoT56wFK:22 a=gO1vWkAQAl3rybz1DQOp:22 a=sozttTNsAAAA:8 a=8TpikKgA1nL99BGwQjsA:9 a=zZCYzV9kfG8A:10 X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwOTEwMDIyMCBTYWx0ZWRfX95ytYJ+yqHvv 1Krjgf3bzEod2sekPQN/TMhrlOHUCu7Fr0kR+8xG++9dkt950N+ugZDIBHVXOunnqozHT0TaNCr mqV2idN8sGMZt7lYT355xSNRYVSW2R66g5LtWMbnn58R/NOt5iUF1j/SLN4i9f/httVGujI/UV/ 6aqLEfZjfLf3/4yGcCsbF/X+s5jgOK8bn7A7gNTJ6wo4eWvMTpPX1Up1g4AkTfJJsLnRFDwlTct 4Hz4kwcoCkUdrbpzJYwX4t53MsZCWacWMk/z9x8URQEjeAt4I9zzRehtsvFaLz1WwkHt06vC7mg Nj5mfymwI2ZaIRan/sEGvZfKcULFFh29HdGJ0mJuWU8pLdoez18WVJnEHT/MB7SxSnO+g4dTVy7 IB4SzFGGOn6K6SNJnoOq1dV+9k/yLzjhjdDqVDZyc1Mn2eaX4yWQoO6vufLHQAg/teVAVor+qfS HwS0+egUpqWraTzjYwQ== X-Proofpoint-ORIG-GUID: AOq3eX4Ee9oNTxtzWAmNFBcEq0Kuwqxo X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1176,Hydra:6.1.134,FMLib:17.12.100.49 definitions=2026-09-10_05,2026-09-09_02,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 adultscore=0 bulkscore=0 lowpriorityscore=0 priorityscore=1501 suspectscore=0 malwarescore=0 spamscore=0 phishscore=0 impostorscore=0 clxscore=1015 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2609040000 definitions=main-2609100220 Content-Type: text/plain; charset="utf-8" Align padding buffer which are DMA mapped to cache line to avoid any potential cache coherence problem. Fixes: 35645ca63caa1 ("crypto: ti - Add support for AES-CTR in DTHEv2 drive= r") Signed-off-by: T Pratham --- drivers/crypto/ti/dthev2-common.h | 2 ++ 1 file changed, 2 insertions(+) diff --git a/drivers/crypto/ti/dthev2-common.h b/drivers/crypto/ti/dthev2-c= ommon.h index a827817e8119a..cfb50255a5dce 100644 --- a/drivers/crypto/ti/dthev2-common.h +++ b/drivers/crypto/ti/dthev2-common.h @@ -114,7 +114,9 @@ struct dthe_tfm_ctx { */ struct dthe_aes_req_ctx { int enc; + __dma_from_device_group_begin(); u8 padding[2 * AES_BLOCK_SIZE]; + __dma_from_device_group_end(); struct completion aes_compl; struct dthe_data *dev_data; }; --=20 2.34.1 From nobody Fri Sep 25 16:02:52 2026 Received: from mx0b-0002e601.pphosted.com (mx0b-0002e601.pphosted.com [148.163.154.28]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 57254583ACB; Thu, 10 Sep 2026 17:57:54 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=fail smtp.client-ip=148.163.154.28 ARC-Seal: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1789063077; cv=fail; b=p5zAShqBgpvPD5l6QXpdjx40XPLEJJgF10mpurQ1Qg0gV/ZUfBr8J56ucHoNjNScZ0oHAr1tEvzUsbtpnOBB5y9udwigBgK3zSjnJVWcXqBAHc461fRtvLak77qXj9ipaa7AL3rHM9i2Kf99BG4Bgque2QMYjLjm8tNZenqxCUs= ARC-Message-Signature: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1789063077; c=relaxed/simple; bh=L6sJTGbxYKzCcew0gputMowl1JIkjqKkuQGwSODlbjs=; h=From:To:CC:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=mNzQBAf6wIdQPHgTS2qAnZKXY+s3ThEdWuc/VbQ4PDgXbvf4AV9bDxNBSQG4+Lls5Lp0p2PalN9AVKK9nM/PebvaeG/4H5Ri3HTZ8au/OqO/009i9PgAyNSp/hDDjwNyXeb0MCW3TI7AquZJE4S2BfdHkuHMVbqwgBzsOmccjFc= ARC-Authentication-Results: i=2; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=ti.com; spf=pass smtp.mailfrom=ti.com; dkim=pass (2048-bit key) header.d=ti.com header.i=@ti.com header.b=PA4tQsJ0; dkim=pass (1024-bit key) header.d=ti.com header.i=@ti.com header.b=LwSgGz51; arc=fail smtp.client-ip=148.163.154.28 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=ti.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=ti.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=ti.com header.i=@ti.com header.b="PA4tQsJ0"; dkim=pass (1024-bit key) header.d=ti.com header.i=@ti.com header.b="LwSgGz51" Received: from pps.filterd (m0374956.ppops.net [127.0.0.1]) by mx0b-0002e601.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 68AGGFgA3546631; Thu, 10 Sep 2026 12:57:50 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ti.com; h=cc :content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s= proofpoint-05-2026; bh=1XOuYy4Cz02k59FK1p12uZ+MgDqx6sx09AI8IDLaQ 7A=; b=PA4tQsJ0HJx+k0pRbQ5TYAlWh9cwZj3TWcg23pEywF4RQvVG+fgd6Eauq AycaiWZBlYJcpo3CKImEZxP5KRMonRVvgJAFg+BRq9Ltg5bXBVIPqTIGfnlUFFRO HFuZUuqCw51IVygPAmFcHiSu5I6G3h9e2V4ssTCwavtcgeW6sDLb7d5JOsmwZqGJ LORaI+npOf9ovX1crKShNSGFwo6kCJ8typxBUoHgopy+zMcVJRO2zw9JuPFV7Yqf ko9390FLCIkWjNnRlHUPM7Q9A8sHEm/mVaQyhF/fQKO01LSIcRnXWfqeIz4tUvmt bKq2wHpw5XYCMAuftPRpotCvHGM5w== Received: from ph8pr06cu001.outbound.protection.outlook.com (mail-westus3azon11012052.outbound.protection.outlook.com [40.107.209.52]) by mx0b-0002e601.pphosted.com (PPS) with ESMTPS id 4gkyx20n92-1 (version=TLSv1.3 cipher=TLS_AES_256_GCM_SHA384 bits=256 verify=NOT); Thu, 10 Sep 2026 12:57:50 -0500 (CDT) ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=kle9zCByb4sGJKKFyx6pDqwYjpDQA9OMcDjVwuFV6+0OnBhPVuaZWTxZzpf1c1MW2cE8qE3gWiKS0mU/R7uwgyASJGi5iQbldR7plEGfC2nhFF2yZbssJfYPLZGWbXGulGRq1VmtC7S7VnGmcebX90f+e7xFZZC8hK2qg3j+pVNXTbNsG+BCOICKeFcu/rTPPDt8Lu/wdHMC9Xf/P6fLYyVUULM3TqsSl6CRntmPR4D34nbwqESb/3N5YuzZruXlUj1qgQ76szEFv3ct6nDUsEpbbO4Cu56Bhxr/z3OJAFyvBcsaJilNz8vrVCGMFBCbehR04iWKuRIgel+nu2ilBA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=1XOuYy4Cz02k59FK1p12uZ+MgDqx6sx09AI8IDLaQ7A=; b=CFV/uLJESNlaIh7wCpBN9ULjUGsf34JwjJ0N5YvKbmLB4mgsGf37uiXeNGIc91fHm25w6/Brer4n6Lc4bopwbHnvNojjhc4AGzr4H86TJEm8g/QydR3HhD6y+V1VcqzhDQE56vYZjVXQicpRMF23njUgLMkIoAfK2xofw0txpufRNxkb3A7IonLlzqOB3hPohmYnmW6VkwFl8PrQrPJ8s89psG4pD2pl4xA+6SaFHl2pdksmtUdiHjzmdvXc2RZwyU59U+aByY6AuA1xhCGdB59s2neJiz9q4RGmZHnMreKjes0oRt+Jb8/mnlQHA9kPQWx0PiANrUwPWmGN8Y0V9w== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 198.47.23.194) smtp.rcpttodomain=gondor.apana.org.au smtp.mailfrom=ti.com; dmarc=pass (p=quarantine sp=none pct=100) action=none header.from=ti.com; dkim=none (message not signed); arc=none (0) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ti.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=1XOuYy4Cz02k59FK1p12uZ+MgDqx6sx09AI8IDLaQ7A=; b=LwSgGz51Yy889i13z9+587rT91Z41m5MJGAJ+D1tleTljrJN1Jgho/yTCLbNTkEK5PsY4xkd+JLhTS1KvgfeKmZvHHaZtEdxo6nH6oiD2ITb/6Hv8hW1tpTahKrH3X9b2dAZxwYcy7BuZWI/al0JinUOh+ccCDeuxPHRIa9Ali8= Received: from MW4P222CA0029.NAMP222.PROD.OUTLOOK.COM (2603:10b6:303:114::34) by DS4PPF6ABE13187.namprd10.prod.outlook.com (2603:10b6:f:fc00::d24) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.21.406.7; Thu, 10 Sep 2026 17:57:30 +0000 Received: from SJ1PEPF000037B4.namprd05.prod.outlook.com (2603:10b6:303:114:cafe::6e) by MW4P222CA0029.outlook.office365.com (2603:10b6:303:114::34) with Microsoft SMTP Server (version=TLS1_3, cipher=TLS_AES_256_GCM_SHA384) id 15.21.406.9 via Frontend Transport; Thu, 10 Sep 2026 17:57:26 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 198.47.23.194) smtp.mailfrom=ti.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=ti.com; Received-SPF: Pass (protection.outlook.com: domain of ti.com designates 198.47.23.194 as permitted sender) receiver=protection.outlook.com; client-ip=198.47.23.194; helo=lewvzet200.ext.ti.com; pr=C Received: from lewvzet200.ext.ti.com (198.47.23.194) by SJ1PEPF000037B4.mail.protection.outlook.com (10.167.244.196) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.21.406.5 via Frontend Transport; Thu, 10 Sep 2026 17:57:25 +0000 Received: from DLEE212.ent.ti.com (157.170.170.114) by lewvzet200.ext.ti.com (10.4.14.103) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.2562.45; Thu, 10 Sep 2026 12:56:52 -0500 Received: from DLEE200.ent.ti.com (157.170.170.75) by DLEE212.ent.ti.com (157.170.170.114) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.2562.45; Thu, 10 Sep 2026 12:56:52 -0500 Received: from lelvem-mr05.itg.ti.com (10.180.75.9) by DLEE200.ent.ti.com (157.170.170.75) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.2562.45 via Frontend Transport; Thu, 10 Sep 2026 12:56:52 -0500 Received: from pratham-Workstation-PC (pratham-workstation-pc.dhcp.ti.com [10.24.53.205]) by lelvem-mr05.itg.ti.com (8.18.1/8.18.1) with ESMTP id 68AHup5O3763752; Thu, 10 Sep 2026 12:56:51 -0500 From: T Pratham To: T Pratham , Herbert Xu , "David S. Miller" CC: Sebin Francis , Manorit Chawdhry , Vishal Mahaveer , Praneeth Bajjuri , , Subject: [PATCH v4 07/15] crypto: ti - Separate padding buffer for src and dst Date: Thu, 10 Sep 2026 23:26:11 +0530 Message-ID: <20260910175619.2122149-8-t-pratham@ti.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20260910175619.2122149-1-t-pratham@ti.com> References: <20260910175619.2122149-1-t-pratham@ti.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: SJ1PEPF000037B4:EE_|DS4PPF6ABE13187:EE_ X-MS-Office365-Filtering-Correlation-Id: acd156a0-6005-4983-dd04-08df0f64f907 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|1800799024|36860700016|82310400026|23010399003|376014|22082099003|18002099003|56012099006|10067099003; X-Microsoft-Antispam-Message-Info: htwnRXFk83czxo/7VLYt7BTVzUC8ibyPkK/02iE6xI2Yysox9SXqssQdf6bd+nI3vZwW92ynVlZXtKXcXS8PDKLcIzAP+peVN4Mzk2IYtdsq+S90axHezFz2YI6wnGKFxwy0KX1bqnmLp4X26A78ZBdrXxts08CvN5BPego6cCrNeG1fdPo6fjRODwlKwdQ7GZX92EJMD7PbZoCZHEC6OTdTMLDCzx1jmrcyfXZXwgJs7B7/UnVYLq3L7XHDGnRjdupjVQLgxS0Q6NQMqe4BLXhVkuGO9TVUC1/Ba/QWtmc0zOq9EnQNfJ62D19BsID5QLP0T7csT49Kutd7bTdNfksw2w5fdwEBU1Ezg+JdNoOAlaACRXWC1hwLLCWOnrNW3NMyoi40NuEaxb45XGh+bnTFFVHym0PSx70wY/ptJejQqY06nzyTMCJwptKZN+t4SLA1BKSXxoXvqPHFWtIZ1cIqakc+afr6p0GBxMT8hl6IuuO3GhksiQCTwndlMP17GddOwpP8HW52VRfocqxyrlehXe0jzbnn9xkNeCIoTxZ5/WnWngnrrz98ykuC4xsNkhk0ptS1g0O24D9iBxv2FacHdtYOsyosn9Gv6O9F7hgcqOdyMvQwokYOgFr5EQbgnp41dfI37aZWJhjKA0WIknboSGfK5Dx/Nkf79qEBugdJuy3hZ1qvBbIt0Ep/bLc6Y3DrUIqHn3h9LtqMhDIwbQ== X-Forefront-Antispam-Report: CIP:198.47.23.194;CTRY:US;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:lewvzet200.ext.ti.com;PTR:InfoDomainNonexistent;CAT:NONE;SFS:(13230040)(1800799024)(36860700016)(82310400026)(23010399003)(376014)(22082099003)(18002099003)(56012099006)(10067099003);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: D7HjEJWDBTPaG8K7Y3hvav500SG7immj8gy5AtgqW6czsljWhxv5hpYPcQcPOyEiVB1QvQTH+xq3wKp3W5ZQ6NRm2x4OXndFNvlAIGvg+Mi9o80/L0p6+T1iobLoZjXooGymk0hWoAViQPqljn5KBEGL2xOnIcWCGksZPbgXBt/ImzEw9YoZFY3B/U8wwxR/pB1yygZRzsm6oD6QYZ7naOYLoqebPSsZcx/uFn0V3s5OVgO8lMLf8KPBBKryWTtBv9l81L0IV2/G/h8dRg0N9ySUo6MVdvnGndVGFLKhr9h8cvmhuIdTJzvlb0DAUJdNQV7RSvQwfOUEVHxoHOcfAaPft9X5LSElBOjclzMWBF3KOJkFK9jIeuEr045wj0TVNFAhilWDLlD+yrj/YCj9tiguCxHfXuUx8joL+R1+3kcJM9YpRgrAM5WkrdcrxRAK X-Exchange-RoutingPolicyChecked: 3B44FzNVMIFO87Lmw7h1N5aZXhZR+b9qNP7z3LuJKc2ur+LF2DxUxg1BbLOqyVP6hLC7B/76ZNN2VrtBrUGXjVf1CJ0zorLKFOXN4WSuqyecnd70AZUzQeOFsffaJiS4//xD+4RZWIVfWD/obbpOHpFKcTGteA1B2wcFLE15R84h23okI9+60whu5pnMxt+ZNzg2bxZFI0oiZ0NKZlZ6oiyhwS3oicadHjmh1AKw33aycs2XzXTrCU7w1rLp1mHU03XimCVcxfYq/dW3IsmdEEZ6Lfik6x4od+QAIHeI7GXCc5v1AFHLQrQGZMrRXUfWOOiURf0aT5baF/MSExalqg== X-OriginatorOrg: ti.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 10 Sep 2026 17:57:25.7710 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: acd156a0-6005-4983-dd04-08df0f64f907 X-MS-Exchange-CrossTenant-Id: e5b49634-450b-4709-8abb-1e2b19b982b7 X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=e5b49634-450b-4709-8abb-1e2b19b982b7;Ip=[198.47.23.194];Helo=[lewvzet200.ext.ti.com] X-MS-Exchange-CrossTenant-AuthSource: SJ1PEPF000037B4.namprd05.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: DS4PPF6ABE13187 X-Proofpoint-Spam-Info: AW1haW4tMjYwOTEwMDIyMCBTYWx0ZWRfX3eVdbA3r/rId uK/Hd4SOAwIYoPTnm/Srz3DWdzjXbAMXnmtnZ/TCeWNKrfn/vACmwtoTGB4AZ3LqGhmIvvaoaqm 4wPKYfrMEMPNaaK+v97rwEYVnsq+buc= X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwOTEwMDIyMCBTYWx0ZWRfX9KdSbF50awA1 BoEJ3vegw2jFUGDqLVyHpwxZ7J6IBXgoveOyfBVdTU5NFI3y4ibi7t4dK5bbNNQhi4y/ByvGohu /xh+eEfj5Dcy4dm4nEdLIcWWg+fs1fDW8moZ6UBlRqeWB8coQE5SBVd2m+5/vJPOQqkBv0WQgR/ PB9Tr1V4so/OmeZBgxMSgYfe3gFZJLcWTV2QqJ7gGwtLY/EMhCwF0o5vAheKKsVUz1F7YSCzHXK nT8DklKBlVaNa5QqIkaAZWFmA79gIY3340GVgVQLclAVpWDPZDNu3YQCzAkdhHfwNp+6zS9UDWJ UvNV55pFNwybv1qOYlANb4XD8bVQiHJGaPCY2trt3dnCFtvzb/9IZrirHCJHjan0sroAFRHRzuI UY1qcm/M9jrwA6vLBZapSWxBbkqBtvmSUkAqZFHqpKyEbi5pHwvbSiEUpWKyfsCBw7BjYfwsnUV vyhJQVo7A57rfACMVuw== X-Proofpoint-ORIG-GUID: iJMDC7Sx7s3PaipZ--K7t3kjgjJkhkMJ X-Proofpoint-GUID: iJMDC7Sx7s3PaipZ--K7t3kjgjJkhkMJ X-Authority-Analysis: v=2.4 cv=UJ5Ijyfy c=1 sm=1 tr=0 ts=6aa2ef9e cx=c_pps a=GeWWyO5P+zJVL7v3m8oIig==:117 a=WotqVVQAdb04rnGuttW3Kw==:17 a=6eWqkTHjU83fiwn7nKZWdM+Sl24=:19 a=VdqzKS8jKosA:10 a=s63m1ICgrNkA:10 a=V5UXEbMT0ywA:10 a=VkNPw1HP01LnGYTKEx00:22 a=Z8NIEmU8O1QQgoT56wFK:22 a=jwouBfj2j3NM8CExmVVE:22 a=sozttTNsAAAA:8 a=pcghVQDwmu1mgjzKNFMA:9 X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1176,Hydra:6.1.134,FMLib:17.12.100.49 definitions=2026-09-10_05,2026-09-09_02,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 bulkscore=0 malwarescore=0 lowpriorityscore=0 spamscore=0 clxscore=1015 priorityscore=1501 adultscore=0 suspectscore=0 phishscore=0 impostorscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2609040000 definitions=main-2609100220 Content-Type: text/plain; charset="utf-8" Separate the padding buffer, which is allocated in the req ctx, for src and dst scatterlist to avoid any DMA mapping issues when not doing inline operations. In such cases, the current code was mapping the same padding buffer twice which might cause issues. Fixes: 35645ca63caa1 ("crypto: ti - Add support for AES-CTR in DTHEv2 drive= r") Signed-off-by: T Pratham --- drivers/crypto/ti/dthev2-aes.c | 19 ++++++++++++------- drivers/crypto/ti/dthev2-common.h | 2 +- 2 files changed, 13 insertions(+), 8 deletions(-) diff --git a/drivers/crypto/ti/dthev2-aes.c b/drivers/crypto/ti/dthev2-aes.c index be7ec62ab2513..aeccc235cb667 100644 --- a/drivers/crypto/ti/dthev2-aes.c +++ b/drivers/crypto/ti/dthev2-aes.c @@ -338,6 +338,9 @@ static int dthe_aes_run(struct crypto_engine *engine, v= oid *areq) int src_mapped_nents; int dst_mapped_nents; =20 + u8 *src_padding =3D rctx->padding; + u8 *dst_padding =3D rctx->padding + AES_BLOCK_SIZE; + bool diff_dst; enum dma_data_direction src_dir, dst_dir; =20 @@ -388,8 +391,8 @@ static int dthe_aes_run(struct crypto_engine *engine, v= oid *areq) sg_init_table(src, src_nents); sg =3D dthe_copy_sg(src, req->src, req->cryptlen); if (pad_len > 0) { - memzero_explicit(rctx->padding, AES_BLOCK_SIZE); - sg_set_buf(sg, rctx->padding, pad_len); + memzero_explicit(src_padding, AES_BLOCK_SIZE); + sg_set_buf(sg, src_padding, pad_len); } =20 if (diff_dst) { @@ -401,8 +404,10 @@ static int dthe_aes_run(struct crypto_engine *engine, = void *areq) =20 sg_init_table(dst, dst_nents); sg =3D dthe_copy_sg(dst, req->dst, req->cryptlen); - if (pad_len > 0) - sg_set_buf(sg, rctx->padding, pad_len); + if (pad_len > 0) { + memzero_explicit(dst_padding, AES_BLOCK_SIZE); + sg_set_buf(sg, dst_padding, pad_len); + } } else { dst =3D src; } @@ -492,7 +497,7 @@ static int dthe_aes_run(struct crypto_engine *engine, v= oid *areq) =20 aes_map_src_err: if (ctx->aes_mode =3D=3D DTHE_AES_CTR && req->cryptlen % AES_BLOCK_SIZE) - memzero_explicit(rctx->padding, AES_BLOCK_SIZE); + memzero_explicit(rctx->padding, 2 * AES_BLOCK_SIZE); if (diff_dst) kfree(dst); =20 @@ -882,7 +887,7 @@ static int dthe_aead_run(struct crypto_engine *engine, = void *areq) =20 u8 *src_assoc_padbuf =3D rctx->padding; u8 *src_crypt_padbuf =3D rctx->padding + AES_BLOCK_SIZE; - u8 *dst_crypt_padbuf =3D rctx->padding + AES_BLOCK_SIZE; + u8 *dst_crypt_padbuf =3D rctx->padding + 2 * AES_BLOCK_SIZE; =20 bool diff_dst; enum dma_data_direction aad_dir, src_dir, dst_dir; @@ -1125,7 +1130,7 @@ static int dthe_aead_run(struct crypto_engine *engine= , void *areq) kfree(aad_sg); =20 aead_prep_aad_err: - memzero_explicit(rctx->padding, 2 * AES_BLOCK_SIZE); + memzero_explicit(rctx->padding, 3 * AES_BLOCK_SIZE); =20 if (ret) ret =3D dthe_aead_do_fallback(req); diff --git a/drivers/crypto/ti/dthev2-common.h b/drivers/crypto/ti/dthev2-c= ommon.h index cfb50255a5dce..f78420ba871e2 100644 --- a/drivers/crypto/ti/dthev2-common.h +++ b/drivers/crypto/ti/dthev2-common.h @@ -115,7 +115,7 @@ struct dthe_tfm_ctx { struct dthe_aes_req_ctx { int enc; __dma_from_device_group_begin(); - u8 padding[2 * AES_BLOCK_SIZE]; + u8 padding[3 * AES_BLOCK_SIZE]; __dma_from_device_group_end(); struct completion aes_compl; struct dthe_data *dev_data; --=20 2.34.1 From nobody Fri Sep 25 16:02:52 2026 Received: from mx0b-0002e601.pphosted.com (mx0b-0002e601.pphosted.com [148.163.154.28]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 7173D568FBA; Thu, 10 Sep 2026 17:57:49 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=fail smtp.client-ip=148.163.154.28 ARC-Seal: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1789063072; cv=fail; b=b4kBGoGe/HgyTsooC8Ki82bRcHAxNov01PIpAJC0iw6UaeidLM21A9EpP03YL51f4P1XYg5FKWfMSjJw8+fzQp5Y2qDv+ArzQiWYEp6dweGxTnBKk2qNRIG9oDLncJxVLetX2+soj2B5gVQbaAnRDxvhdILji0IqO1cbWkddPx0= ARC-Message-Signature: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1789063072; c=relaxed/simple; bh=Ge9j09OItfl39sMD0+R3OKL8fXxzjj6qvomlEshNfas=; h=From:To:CC:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=hghoFhUm1bjJ/JoDjAlw+FJ/J8htPqlPFW38XSaAoSpn4BOkE9QhFYZcimrk+wp/oyEha6gUg+fVXRLQpw+kHS3Je6vNMviA9R+hbEL6RcR/YnKZSUTu5Ni4eGtjYU/p6vYAZHVjxVqavmAlA+IRSJMbentZ7szSYGLu2H0W5NA= ARC-Authentication-Results: i=2; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=ti.com; spf=pass smtp.mailfrom=ti.com; dkim=pass (2048-bit key) header.d=ti.com header.i=@ti.com header.b=MHaIpFdd; dkim=pass (1024-bit key) header.d=ti.com header.i=@ti.com header.b=d2yWebh6; arc=fail smtp.client-ip=148.163.154.28 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=ti.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=ti.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=ti.com header.i=@ti.com header.b="MHaIpFdd"; dkim=pass (1024-bit key) header.d=ti.com header.i=@ti.com header.b="d2yWebh6" Received: from pps.filterd (m0374956.ppops.net [127.0.0.1]) by mx0b-0002e601.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 68AGGGwG3546639; Thu, 10 Sep 2026 12:57:45 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ti.com; h=cc :content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s= proofpoint-05-2026; bh=30Ztst7SGgSl2Rl1/eIFquFLmUY0KxcuyVzjHqWNX uQ=; b=MHaIpFddwETvqHutPMmGlHlSByXGU8+jnHlv2k+6fIyI519b+XJbtmjEM zFVaRYf0siMYrrfnf9eeJ0DZ6kIAr90kMtZTArvf/KBD9ydZNKmqCQF2lq74LAAR QM9LseVmUuDq5TQynYeF4AztdREb6IeC+f5DaEDLCSEsCr/FTbBoXaQg/WMizMy7 nymGnwZGt0vvAXune48KHjqhbIWaDJWZRp8QBT/Z+tlTBJ411u5hmcA3U1c3YI8D Upo+jHYn39VvfWAJWFp0D3hhJFtykYRMJhmfzDFAHhqbGI7m17hyYL43IcdtVTBE h7ikYIDsIPD00JUzHab6Ff3gbdKxQ== Received: from bl0pr03cu003.outbound.protection.outlook.com (mail-eastusazon11012006.outbound.protection.outlook.com [52.101.53.6]) by mx0b-0002e601.pphosted.com (PPS) with ESMTPS id 4gkyx20n8m-1 (version=TLSv1.3 cipher=TLS_AES_256_GCM_SHA384 bits=256 verify=NOT); Thu, 10 Sep 2026 12:57:45 -0500 (CDT) ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=DbNqq4JyGIjz2qccKyuXAgadJiQBM1QzfqALKeAhBSr9kMzpNLjWqdfmkZnmk9+9X23YSU+IZ/y2QYFhQANtrrn1G2fpLL2LfIg1GabgZ9Qxhi3IujocjxCmyZJVhnqbtVP0YcE2QdUfI29Ozuo5PwqyIYXtmtjh/L0aPUUGX7Uj4Rh5Tkd8E0AaLHPHE9OwMgX9MA9uccxcZiCq+YhgzbTWAun0hYUXiFHsrhfFfD2ljq++NCDWWCiJ4bD59hgeYsaUHdyJZNDeYS7kKiTi7cZQIvYK75u+14/kvadk+G1xbUSNnsCWJKYKwFhuK2MZNmlzDAPXJADJxyMIzpij7w== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=30Ztst7SGgSl2Rl1/eIFquFLmUY0KxcuyVzjHqWNXuQ=; b=i7GtkcwH9dhFcukglFUgtEu0iqR7/V0Rk81bP0F4XlvsQqU1QVrWwZCHInknQhbjdieD09O1CbNMqeCONJQFUcwBQqdGbsr62LtazIDe1aXRMuZG9oOmjk5kAOqL7y4iCGgr8Tlc4avUB+8ZjQYH1h+tnnvgSJLY6rX5RzY4A0UJex+AgPUw9FUz5LUm3d/LZcKOer02yN02jMzL1/0ogquFjlIkY1nJIeOMu1nkwet801SguM2dKOK6jMgYoVgc1fs8VRKTIXofBCb/G5ALc/ZVJlhYHYNcXHQJTKX29WlhK/ayW8FX8B2qZoIbHC79pXEMUK+atzDUQlnmTQCh1g== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 198.47.21.194) smtp.rcpttodomain=gondor.apana.org.au smtp.mailfrom=ti.com; dmarc=pass (p=quarantine sp=none pct=100) action=none header.from=ti.com; dkim=none (message not signed); arc=none (0) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ti.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=30Ztst7SGgSl2Rl1/eIFquFLmUY0KxcuyVzjHqWNXuQ=; b=d2yWebh6rk+nuC2LNNss+fF3c97RKUz9fC3JzpfkbpKTHO9qyqa1btcA6SOimk713+4StxgU7b4wL9a2t4v/jfEolV+BRmFjJyNoj4ZaEeb3Pp9MN3m8jj2K+vYEbxWK/Yveq70FxQ8+nwoSDWnKEoLupwrObHiTuNwnOi79oM4= Received: from MW4PR03CA0062.namprd03.prod.outlook.com (2603:10b6:303:b6::7) by DM4PR10MB7505.namprd10.prod.outlook.com (2603:10b6:8:18a::7) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.21.406.7; Thu, 10 Sep 2026 17:57:42 +0000 Received: from CO1PEPF00012E82.namprd03.prod.outlook.com (2603:10b6:303:b6:cafe::4a) by MW4PR03CA0062.outlook.office365.com (2603:10b6:303:b6::7) with Microsoft SMTP Server (version=TLS1_3, cipher=TLS_AES_256_GCM_SHA384) id 15.21.406.9 via Frontend Transport; Thu, 10 Sep 2026 17:57:42 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 198.47.21.194) smtp.mailfrom=ti.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=ti.com; Received-SPF: Pass (protection.outlook.com: domain of ti.com designates 198.47.21.194 as permitted sender) receiver=protection.outlook.com; client-ip=198.47.21.194; helo=flwvzet200.ext.ti.com; pr=C Received: from flwvzet200.ext.ti.com (198.47.21.194) by CO1PEPF00012E82.mail.protection.outlook.com (10.167.249.57) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.21.406.5 via Frontend Transport; Thu, 10 Sep 2026 17:57:41 +0000 Received: from DFLE213.ent.ti.com (10.64.6.71) by flwvzet200.ext.ti.com (10.248.192.31) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.2562.45; Thu, 10 Sep 2026 12:56:54 -0500 Received: from DFLE204.ent.ti.com (10.64.6.62) by DFLE213.ent.ti.com (10.64.6.71) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.2562.45; Thu, 10 Sep 2026 12:56:54 -0500 Received: from lelvem-mr05.itg.ti.com (10.180.75.9) by DFLE204.ent.ti.com (10.64.6.62) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.2562.45 via Frontend Transport; Thu, 10 Sep 2026 12:56:54 -0500 Received: from pratham-Workstation-PC (pratham-workstation-pc.dhcp.ti.com [10.24.53.205]) by lelvem-mr05.itg.ti.com (8.18.1/8.18.1) with ESMTP id 68AHurjB3763781; Thu, 10 Sep 2026 12:56:54 -0500 From: T Pratham To: T Pratham , Herbert Xu , "David S. Miller" CC: Sebin Francis , Manorit Chawdhry , Vishal Mahaveer , Praneeth Bajjuri , , Subject: [PATCH v4 08/15] crypto: ti - Validate sg_nents_for_len() return value in DTHEv2 AES Date: Thu, 10 Sep 2026 23:26:12 +0530 Message-ID: <20260910175619.2122149-9-t-pratham@ti.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20260910175619.2122149-1-t-pratham@ti.com> References: <20260910175619.2122149-1-t-pratham@ti.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: CO1PEPF00012E82:EE_|DM4PR10MB7505:EE_ X-MS-Office365-Filtering-Correlation-Id: f6e492e2-f4db-4b50-1059-08df0f650247 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|376014|36860700016|23010399003|1800799024|82310400026|56012099006|10067099003|22082099003|18002099003; X-Microsoft-Antispam-Message-Info: 1AAczsJxEpkhc4aDgddjCfp6D7WxAxKJWOhSBYRHYwavwmlyN7Tl+XBAWH6LeHEgUW072CRVwIJik+OOHrMW05Tq+80OzEpjNgqSk6/Z4cRSE4SGFH48N6/hYxTffok56JevHryV1xwXkNtb3n3tHOHiaoJOlo+Sk6pIbqzVsBNh/xVGH7X9lJgiBxUhQ/rItnYSbeCG01vWREE00Clst44PuiRZxCxt1CpofIdNKbUw/Yb3ybNTbZ5/nriPl6vkXv+DqaCrN5RdXrfenIA+IrFnl7IwZaBEV2ovJtYqQH+EUvqcpzEswabtY8J1mgbqwVkgGRuD+6fAgmOrxpho6XNKsbosFzOr9LSpCDQo16IE97yglpij85cOd6R4tOogJ9UGjUvyKuNyPBJ2KTLYufq1p+XYfiTdxWGTcUobycPySwXHmUxBlYrolveg+uc36wfY3YK/hN+njYtG7U8qnp5dXV7REDRoHDQJD/FPna1SRRW6Gz6WQjzcK5sPMVawxk4zkMfOMTUgD/6sBTpV4WC1js3P2sBjp2amBodo7iLqwztkZ58Lz48VscNiD33qv2hCiFunx9DL2wGyTRNS/pI8CTj/U/fQjuA7E8u6F1YlW6HVUjRdJdAnoZmsbBwf1ZnwiSvwabBrlLtQ4vU9f9+jAHOm0bYnks3DyrTw87oyHGK4Fl6FoMFMdIOBpWOL1RhVdjAfA4kgbYMcmerl8Q== X-Forefront-Antispam-Report: CIP:198.47.21.194;CTRY:US;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:flwvzet200.ext.ti.com;PTR:ErrorRetry;CAT:NONE;SFS:(13230040)(376014)(36860700016)(23010399003)(1800799024)(82310400026)(56012099006)(10067099003)(22082099003)(18002099003);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: X3oedpm+nlJUWXm4qML5lps05bBJjn2AC+2ajXFHFto06R1q35HsHojdMibC8qysABYJDys+JQ9Vn4NommOwJSOGnT7ahewaogg+5Eiktrhf1usXM6NQXT0ExGjVuYqeKbmq6ttyBV3d1Dmp8uCRhX84KEuXzot/IVRxt8v6xjP4axcSztUTdpN4D6lxWVzFIa5MV/8NhDJQ076G5FGucM+yGn6bGGzByrtEpNHUM0x8bZBcZDzokiYOBVq4cINrJIqfE0NxpMgjuDPOSw1lS7gMvaNqsH2k5UgKwVrajRlvBcwVBRvWLV2WLCd2OkN6JGiLycLf8NbNANZs02FqgvMzliODdVD+QR4+Fy2oJtD+/Aw+ZKRdM1ip4KxZ3ZXwCqVY316bxw05IzRDboSzo6STdJgh4Z1YWqNr/GIE6+YmFlm3bLj0e1Y5yuMeP77I X-Exchange-RoutingPolicyChecked: Dz+ofApcIy+I914ISu1UelbeiC1ny9lWcJicdi8Jf9ChZkakYFswb9tZIVk/4LrlAqzSV3442fqHyUAYOZJu52BPT5qrT+Hpx+R6jK6b07B92hhbu9k60Wh/ZK1Vh7k84IN5wPNfWdoICiM1UTbSgcI9fUE+pE7KfeugThYgLEbDVQysGZlHn6joWIBXIq4mEQUCVyH/BiuhbAwRqGnzSecX2V1XZu99b/7fv5/hP9OIIyk8fG49BURBBPHIrO7Z35hOV8BPH5+N+ysgUPmVTr0NS0WJ1yxbkNhdYjU5NCKvbhNpbnuzauqgQ94CDHLtkeMLvBlQylyJnkgiiY0zHA== X-OriginatorOrg: ti.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 10 Sep 2026 17:57:41.2859 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: f6e492e2-f4db-4b50-1059-08df0f650247 X-MS-Exchange-CrossTenant-Id: e5b49634-450b-4709-8abb-1e2b19b982b7 X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=e5b49634-450b-4709-8abb-1e2b19b982b7;Ip=[198.47.21.194];Helo=[flwvzet200.ext.ti.com] X-MS-Exchange-CrossTenant-AuthSource: CO1PEPF00012E82.namprd03.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM4PR10MB7505 X-Proofpoint-Spam-Info: AW1haW4tMjYwOTEwMDIyMCBTYWx0ZWRfX3DZIu8RoQfJB lKjRZhStBaAgHQ9YV/5sdzKPv7CZSOg6/7goWdsM+z2MzQ3FD1jCEOim+XE06Gz6PRN9ki1LyR2 3F9PoYMerjNSwWPLwJKFKxX2/bGZ504= X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwOTEwMDIyMCBTYWx0ZWRfX9H4ZYdsizDkw i5NfFX68EIEpIbVQqqZf56WHlXTDGUqRUvmyAm2p5uQiztzDU6C3fq4tTR3lBH08JqFG5/fyX8W P7ejFkvhqCVlOP5P5G634mUkEFtiF88nIETCngGLRXRFahXrhFmqeLWBOO9ga9rcqb6TmQpW5kX fGNxeuumLIz3PCmWSWL+7fiFJqDRU4tgT+qXCX8NdB8Oi86xYwrf0M1sL+RNY6vGwmrhAGd7MkZ s3q1qR0LuQYldNXM+uWDoJu3jBSIuOPPJ3d6hnarbqq//s7zDV8LcRwfg9ttCuvqZIXP/QY+CEv dwdCZe2jeGAkGLuHqkN9aDz/3THy7p+5cFczM1mhJDMwIbCqTg6/S5581lulYqCrevJAPW7z86Q Xd8wgR6oxfbzbDLNgHjBdfJo4cUlzWrOhfdtEDN2h0xhBJy4nvvTjKbcNaC9sQfMH0HSFJJxvsW WcIWRUeJAzLEqXfzyhA== X-Proofpoint-ORIG-GUID: TdRodD5KzURB6FR8Sj3DtWB6endV8b0V X-Proofpoint-GUID: TdRodD5KzURB6FR8Sj3DtWB6endV8b0V X-Authority-Analysis: v=2.4 cv=UJ5Ijyfy c=1 sm=1 tr=0 ts=6aa2ef99 cx=c_pps a=gX39by8dV5dKUPXqjYrUqQ==:117 a=iwqwCZQqcuTv3JOpYdM7/Q==:17 a=6eWqkTHjU83fiwn7nKZWdM+Sl24=:19 a=VdqzKS8jKosA:10 a=V5UXEbMT0ywA:10 a=VkNPw1HP01LnGYTKEx00:22 a=Z8NIEmU8O1QQgoT56wFK:22 a=jwouBfj2j3NM8CExmVVE:22 a=sozttTNsAAAA:8 a=wrH6CD59uMa574BPOq8A:9 X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1176,Hydra:6.1.134,FMLib:17.12.100.49 definitions=2026-09-10_05,2026-09-09_02,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 bulkscore=0 malwarescore=0 lowpriorityscore=0 spamscore=0 clxscore=1015 priorityscore=1501 adultscore=0 suspectscore=0 phishscore=0 impostorscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2609040000 definitions=main-2609100220 Content-Type: text/plain; charset="utf-8" sg_nents_for_len() returns -EINVAL if the supplied scatterlist is shorter than the requested length. Add explicit checks after each sg_nents_for_len() call in DTHEv2 AES driver. Fixes: 52f641bc63a46 ("crypto: ti - Add driver for DTHE V2 AES Engine (ECB,= CBC)") Signed-off-by: T Pratham --- drivers/crypto/ti/dthev2-aes.c | 6 ++++++ 1 file changed, 6 insertions(+) diff --git a/drivers/crypto/ti/dthev2-aes.c b/drivers/crypto/ti/dthev2-aes.c index aeccc235cb667..bc3591ec58a1c 100644 --- a/drivers/crypto/ti/dthev2-aes.c +++ b/drivers/crypto/ti/dthev2-aes.c @@ -354,6 +354,11 @@ static int dthe_aes_run(struct crypto_engine *engine, = void *areq) u32 aes_irqenable_val =3D readl_relaxed(aes_base_reg + DTHE_P_AES_IRQENAB= LE); u32 aes_sysconfig_val =3D readl_relaxed(aes_base_reg + DTHE_P_AES_SYSCONF= IG); =20 + if (src_nents < 0 || dst_nents < 0) { + ret =3D -EINVAL; + goto aes_inval_nent_err; + } + aes_sysconfig_val |=3D DTHE_AES_SYSCONFIG_DMA_DATA_IN_OUT_EN; writel_relaxed(aes_sysconfig_val, aes_base_reg + DTHE_P_AES_SYSCONFIG); =20 @@ -510,6 +515,7 @@ static int dthe_aes_run(struct crypto_engine *engine, v= oid *areq) if (ret =3D=3D -ENOMEM) ret =3D dthe_aes_do_fallback(req); =20 +aes_inval_nent_err: local_bh_disable(); crypto_finalize_skcipher_request(dev_data->engine, req, ret); local_bh_enable(); --=20 2.34.1 From nobody Fri Sep 25 16:02:52 2026 Received: from mx0b-0002e601.pphosted.com (mx0b-0002e601.pphosted.com [148.163.154.28]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id F1042394792; Thu, 10 Sep 2026 17:57:40 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=fail smtp.client-ip=148.163.154.28 ARC-Seal: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1789063070; cv=fail; b=AHnJKIZ+aNNh5pBcoOxoQvw5c22Bl8XjAVk29BuKq9OT/gMJYO8jj5xFtRatnUP7vmvHjhDN//MleNGDyOgDOvIGG4X3bo5Fj/mmxH+uSyL5DcBcE1mT6RnYBACuaPlGZbl8yOK/mAv7qtgIFd4wfnbJupBTEbnGx3HnUhrpQ3Y= ARC-Message-Signature: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1789063070; c=relaxed/simple; bh=8AiEGfb8lJzH+XTUake6thyKV3Zd4kzDjnDYuThYIjo=; h=From:To:CC:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=H8p9ZACC7ZbmJQe2hJvOYKq2+HTzHNfHYuxGZJ9do6QxgO0ewyBuDZKZtU78HGmqvu6L6HS7eHOfZN6M6QF1kYI4amUdT+4BPQH7EVEVXtASxHiDCIhjJk7yEPW+HiYz7xmwbeZcttYt35Cx4YD6QknJ4f4+LHeuzg/6Sa1YQBI= ARC-Authentication-Results: i=2; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=ti.com; spf=pass smtp.mailfrom=ti.com; dkim=pass (2048-bit key) header.d=ti.com header.i=@ti.com header.b=QX0v0y3A; dkim=pass (1024-bit key) header.d=ti.com header.i=@ti.com header.b=AUhC3S/B; arc=fail smtp.client-ip=148.163.154.28 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=ti.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=ti.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=ti.com header.i=@ti.com header.b="QX0v0y3A"; dkim=pass (1024-bit key) header.d=ti.com header.i=@ti.com header.b="AUhC3S/B" Received: from pps.filterd (m0374956.ppops.net [127.0.0.1]) by mx0b-0002e601.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 68AGGC3P3546611; Thu, 10 Sep 2026 12:57:33 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ti.com; h=cc :content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s= proofpoint-05-2026; bh=w5beXwKfniW4zqbzhimEbX0XKyemxYErkY0Kg3dQT 7Q=; b=QX0v0y3A5Bk4DT7teTVE/KZgY8IhbAw9wPQOf7u56zuIktOcy6dlyaSRv YTAWjyKA3ZBFPNptzn+awqZzGVfnpKns4vW7mllxs7MtTKS9uBZoXk6EVJ4kTmbG 9rRtBlaYALPR7T+snCxUH7IS2cJmvGcYRkkmOo/jCrWn2bm41oxSYPn3Q52vdLnW 2MFfKH+PrG6kpJ0YHRLptQvvYFQySz7McIhk1HmiplJo2dkBaFAJq5mPMoQOkeM2 gLsyP7OUKWByynR86b5hxjja5OLQUtliHYhqky+DMJKEyzCsI8g5uvhWrMg2aIVe hWkP8yNC+IpvnYp+bgFMxhzQR910g== Received: from byapr05cu005.outbound.protection.outlook.com (mail-westusazon11010055.outbound.protection.outlook.com [52.101.85.55]) by mx0b-0002e601.pphosted.com (PPS) with ESMTPS id 4gkyx20n7a-1 (version=TLSv1.3 cipher=TLS_AES_256_GCM_SHA384 bits=256 verify=NOT); Thu, 10 Sep 2026 12:57:33 -0500 (CDT) ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=eLIHEeK4Z87V8sZaxyWNn9czZx941iDDXaq+VESdpc9LsRoQpSwej4wu5OyrF4OlNGXHslmHJlxOpXseHdBLEXTVsbl2UkYa8BRktVDV/xMYDfL5uegdOF7frXmt/oZPzqLVZ5AYASIfYN9OnaXs055sxfP1HJA/MxuApCDaI1kd0LoC+HVSeXYWMHzRpRDs2SvTPoQ7rN1rCEgIAZ0JyeJylBKO39mXsjBv5rrjGR3A3ZbJ2PSIjaq04WsrUEOzP5vVtHdULIq+jJZ97GXM5yu0KGM++tFNtpFQ06Ont4l2TzyDpaYjMxntv7UuwzeVkLho4kt4dqyWgmAmKB2gGA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=w5beXwKfniW4zqbzhimEbX0XKyemxYErkY0Kg3dQT7Q=; b=gRwJQz7V0mBUbJdbzPDaXgV6Ej4XrXt/+J//8sTzL0nzK4TOk0pe3ZWm7h5jITwP3XK5Sfx357AwevwFCj6o2WB2s3jakwwXe5n81ndKQiqT8yB0RMc9k+tmsIXQL/Y59cyAgpwRUjNwn3XU2mqroXIvKxV76KJxI0bj52uvwvqMULZpfIGPlvCK+B7olM1VvwJZmbGNrKV++V9Fdgl8N9uLQAewnq6NbmqHveL61tB3oosB4nYlWxWWh0lZfx0Ofns0V07pUrbE5G3vDGlFb41ZY1bKpHIKS4j2+fjY0Lz6l3kVWKJrkEwtyPgM2YGsnuVkwAKjSBJA+4SSdcF59w== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 198.47.21.195) smtp.rcpttodomain=gondor.apana.org.au smtp.mailfrom=ti.com; dmarc=pass (p=quarantine sp=none pct=100) action=none header.from=ti.com; dkim=none (message not signed); arc=none (0) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ti.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=w5beXwKfniW4zqbzhimEbX0XKyemxYErkY0Kg3dQT7Q=; b=AUhC3S/BGybExczZiPXBGpgrlEX6bESla4Jhz6mh90J6SIiuRN6XbpjgZGiWx83Y+mfZcjPDwAolW8Km3DgCZ6uoe7aOsqdR6Yd8XK0S3bLKYBfy1IrUaE7HPQvA9MjgKgl/IW9l19hQPZVwBp9jv4CSTcNm9OlKWsDRV5K9PsU= Received: from CH0PR07CA0011.namprd07.prod.outlook.com (2603:10b6:610:32::16) by PH0PR10MB7099.namprd10.prod.outlook.com (2603:10b6:510:26d::6) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.21.406.7; Thu, 10 Sep 2026 17:57:29 +0000 Received: from CH1PEPF0000AD81.namprd04.prod.outlook.com (2603:10b6:610:32:cafe::5b) by CH0PR07CA0011.outlook.office365.com (2603:10b6:610:32::16) with Microsoft SMTP Server (version=TLS1_3, cipher=TLS_AES_256_GCM_SHA384) id 15.21.406.9 via Frontend Transport; Thu, 10 Sep 2026 17:57:29 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 198.47.21.195) smtp.mailfrom=ti.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=ti.com; Received-SPF: Pass (protection.outlook.com: domain of ti.com designates 198.47.21.195 as permitted sender) receiver=protection.outlook.com; client-ip=198.47.21.195; helo=flwvzet201.ext.ti.com; pr=C Received: from flwvzet201.ext.ti.com (198.47.21.195) by CH1PEPF0000AD81.mail.protection.outlook.com (10.167.244.89) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.21.406.5 via Frontend Transport; Thu, 10 Sep 2026 17:57:27 +0000 Received: from DFLE213.ent.ti.com (10.64.6.71) by flwvzet201.ext.ti.com (10.248.192.32) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.2562.45; Thu, 10 Sep 2026 12:56:57 -0500 Received: from DFLE215.ent.ti.com (10.64.6.73) by DFLE213.ent.ti.com (10.64.6.71) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.2562.45; Thu, 10 Sep 2026 12:56:57 -0500 Received: from lelvem-mr06.itg.ti.com (10.180.75.8) by DFLE215.ent.ti.com (10.64.6.73) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.2562.45 via Frontend Transport; Thu, 10 Sep 2026 12:56:57 -0500 Received: from pratham-Workstation-PC (pratham-workstation-pc.dhcp.ti.com [10.24.53.205]) by lelvem-mr06.itg.ti.com (8.18.1/8.18.1) with ESMTP id 68AHuu772793780; Thu, 10 Sep 2026 12:56:56 -0500 From: T Pratham To: T Pratham , Herbert Xu , "David S. Miller" CC: Sebin Francis , Manorit Chawdhry , Vishal Mahaveer , Praneeth Bajjuri , , Subject: [PATCH v4 09/15] crypto: ti - Validate sg_nents_for_len() return value in DTHEv2 AEAD Date: Thu, 10 Sep 2026 23:26:13 +0530 Message-ID: <20260910175619.2122149-10-t-pratham@ti.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20260910175619.2122149-1-t-pratham@ti.com> References: <20260910175619.2122149-1-t-pratham@ti.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: CH1PEPF0000AD81:EE_|PH0PR10MB7099:EE_ X-MS-Office365-Filtering-Correlation-Id: 900a9bfd-8b67-41a8-2862-08df0f64fa21 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|82310400026|23010399003|1800799024|36860700016|376014|10067099003|56012099006|22082099003|18002099003; X-Microsoft-Antispam-Message-Info: O8vqYosgBwGNQCLX8nql0StA5XbhijvgR4a7fblrjIFNFg88MA0ddhsxxdmAaMNLr/TlvIBuXPUB/jNjlEiQAhQTZOcXE+A2fEGTUfXf/6ElqIAkbQqE8YBwAImHSqYtCncBerT5FB+Du9r2AHEWHuDezlkuV16qOsFYz7P/0NfLF76N/+hgJ/C0QQ5UGY1ONs82m8HCMGvM6p2SwX9kVgPWZMMitw4s1rNqyhf9WUXNEyFbp3OYYVqomsSXwx+VtfT2YCU0HVw2Twoh9qpZyN7TW6Uv/5yI6W8+bIx39e8tz+SfybsfzvKup1a9vmXk2y02yRHOA4R7B1pIbilDCjnQz9tj2oqzOjmEjlwXzkCJiP9y7gvPs1/QarPzOiqkb+ZEdk/rhS/C9VvS6CtpDXIIEg51oE3Go0qa8W4biiJ0x4NBH4pRuXtCkEBC4ZXOboh41Q6mtaJuO8TPptY/dJsvjsDuAQvx0VTfsK7QuPkoGo1dM1cBt9V+MFKYCELIPzGiW6khBWGaI/YE6/Y5SxWLYKjJgD+dSgj4XrJCFLU90CDpOM03V92zXMo+V9bYq6OEWskfwXODAKS8nTNYoYUF2tX6qEa8rDsFh9386s5tNQ1i+ZmlIzNvXyS0HiE+QDZNtQpL279yPBOJkyxz8etGlo9byjRnKMYbIqeF9EkoOU4c89n7nCFzegguoVoMJMret0X0N/SGQVymIleaOg== X-Forefront-Antispam-Report: CIP:198.47.21.195;CTRY:US;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:flwvzet201.ext.ti.com;PTR:ErrorRetry;CAT:NONE;SFS:(13230040)(82310400026)(23010399003)(1800799024)(36860700016)(376014)(10067099003)(56012099006)(22082099003)(18002099003);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: A3wQC6x4MgltuyB7CTtF1rJRTMIK1ftgHo8NyACz66PkJfqviogbufLWKgHN+KBUrbgzB+xp70jQbaOQXtiIUfBWgjaufA6x2zRGxTItbni2/8PeNa9Z3/yMvxnrRchXlJDLwG0+NmVdvupgZPBXTIQ/l5h/TqjOvYkCYBSR9rBz9qUxIOPM3vhNblblC16JhGabhBQQVGMqdV0rX6oEY9sPdWJeC6YyhkGDSZiNpWLFQM6wjZAF5DesD2oiburzFgL9JKmRbIPQ3tkVrnKlOAOALMgNAIJbjS43Cu0NV7eKTtNcFEo6mJdcSUmyd2zuuVo1QzI7ifkPAE/+MxKLIk4FoqpAFStqToyrUijB05clyy0tWaaZKjGkX8P1z+Sd36t+AqO9kt50oMElgZl89zJu7pUyoMXNqinZJN8ooWkEPpe3XJUiMwlB61PBiuuv X-Exchange-RoutingPolicyChecked: 5qPPYaMlmNsnhhkCHorayz6rE09R6g2BQCzGkuR4yEX7eUS3h3ufVWVJPN82x5TT49lBlvFIycuINAKUbwxOMkF5lplrYJafkJRHj6C8T+toTsCYTzy3Brb0/x+FeNVudAkW+O81QIejmnU7Vp34+1CrneqEZvFlB/kt+MTNXI32zmBqpjJlSCwjLaHLGADhoBu+MXaUcLjenBz7F+XOe3vnXHHvSZ1tLW/1H72wQ0J3X5eEFdMOfLlS9LAyi35P47FaEruJdkeXDnIbEYvzR7cRoOYwtTgF23BIwBXzflen3iEUXaMAD/1CrzBhGNCl0KM8uoBWJQxG6ct/dxUYYg== X-OriginatorOrg: ti.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 10 Sep 2026 17:57:27.6482 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 900a9bfd-8b67-41a8-2862-08df0f64fa21 X-MS-Exchange-CrossTenant-Id: e5b49634-450b-4709-8abb-1e2b19b982b7 X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=e5b49634-450b-4709-8abb-1e2b19b982b7;Ip=[198.47.21.195];Helo=[flwvzet201.ext.ti.com] X-MS-Exchange-CrossTenant-AuthSource: CH1PEPF0000AD81.namprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH0PR10MB7099 X-Proofpoint-Spam-Info: AW1haW4tMjYwOTEwMDIyMCBTYWx0ZWRfXxgaXptNakaY+ Kzv7fyDX5UM/xKylwZcVBtNZzKDedCpzxYYBwyNk1FenCrZ5jFfPWjDtEpx2DgfA6VtYS9xXwF1 O6mFgv3HgoOmeMjQ3OsWE0ZDwfeKLy0= X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwOTEwMDIyMCBTYWx0ZWRfX3Vw5bIX6WWEC o7rMgHc2ywUTMUwDLcrUL1oACtL8WrpYiITd4aTJCut7HBxZ5cphhD0seNOee222/ajbcrwj6nY TNTqjc3ekuNB0gzjXeenCt9twR6JRxTCiHoLn+ngeRP4ZPlzILJjX1aEwJowjA/MZLv7hrHsej8 TxIFVohajINEhg8njgNkCFrc0Qcf3kXBeLxQ+ch2fNIfWmka7EI6GBgnchNBj6/UtardpniQV+A lBISK3nGhSReB9PL5Y0H3MjO+2z4AETHvVxL1xuBb2+j31ZbOMXMOalZvNG//8XZCwqxZ6ykZBM T/g+ZjuCD8LeOaH2XYiXazD/Zd+OaxdUEafeEO6EXyicNb9gAwPXIr0Sq9e/pelEcGwa/oKFoQ0 8ritQAAJ668lk9JusSkGL1yN1H6+Gznx9LzMSvghVHgtH1MenJ+c9ZvvAy5nn4j09AK5OEHTav6 V+p0Wma9RJxxntZgwdw== X-Proofpoint-ORIG-GUID: 86JtwtqgSEV_07C0JBhTJZrWOt4FuCk9 X-Proofpoint-GUID: 86JtwtqgSEV_07C0JBhTJZrWOt4FuCk9 X-Authority-Analysis: v=2.4 cv=UJ5Ijyfy c=1 sm=1 tr=0 ts=6aa2ef8d cx=c_pps a=25083kmBgh9d5ln0vqlIEw==:117 a=tJyPKKxUohctrY4NYmUjkA==:17 a=6eWqkTHjU83fiwn7nKZWdM+Sl24=:19 a=VdqzKS8jKosA:10 a=V5UXEbMT0ywA:10 a=VkNPw1HP01LnGYTKEx00:22 a=Z8NIEmU8O1QQgoT56wFK:22 a=jwouBfj2j3NM8CExmVVE:22 a=sozttTNsAAAA:8 a=iMD6g9N4YQ2QoEUmFGwA:9 X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1176,Hydra:6.1.134,FMLib:17.12.100.49 definitions=2026-09-10_05,2026-09-09_02,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 bulkscore=0 malwarescore=0 lowpriorityscore=0 spamscore=0 clxscore=1015 priorityscore=1501 adultscore=0 suspectscore=0 phishscore=0 impostorscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2609040000 definitions=main-2609100220 Content-Type: text/plain; charset="utf-8" sg_nents_for_len() returns -EINVAL if the supplied scatterlist is shorter than the requested length. Add explicit checks after each sg_nents_for_len() call in DTHEv2 AEAD driver. Fixes: 37b902c603042 ("crypto: ti - Add support for AES-GCM in DTHEv2 drive= r") Signed-off-by: T Pratham --- drivers/crypto/ti/dthev2-aes.c | 22 ++++++++++++++++++++++ 1 file changed, 22 insertions(+) diff --git a/drivers/crypto/ti/dthev2-aes.c b/drivers/crypto/ti/dthev2-aes.c index bc3591ec58a1c..65a53fcf80467 100644 --- a/drivers/crypto/ti/dthev2-aes.c +++ b/drivers/crypto/ti/dthev2-aes.c @@ -641,6 +641,8 @@ static struct scatterlist *dthe_aead_prep_aad(struct sc= atterlist *sg, return NULL; =20 aad_nents =3D sg_nents_for_len(sg, assoclen); + if (aad_nents < 0) + return ERR_PTR(aad_nents); if (assoclen % AES_BLOCK_SIZE) aad_nents++; =20 @@ -697,6 +699,10 @@ static struct scatterlist *dthe_aead_prep_crypt(struct= scatterlist *sg, goto dthe_aead_prep_crypt_split_err; =20 crypt_nents =3D sg_nents_for_len(out_sg[0], cryptlen); + if (crypt_nents < 0) { + err =3D crypt_nents; + goto dthe_aead_prep_crypt_mem_err; + } if (cryptlen % AES_BLOCK_SIZE) crypt_nents++; =20 @@ -756,6 +762,8 @@ static int dthe_aead_enc_get_tag(struct aead_request *r= eq) return ret; =20 nents =3D sg_nents_for_len(req->dst, req->cryptlen + req->assoclen + ctx-= >authsize); + if (nents < 0) + return nents; =20 sg_pcopy_from_buffer(req->dst, nents, tag, ctx->authsize, req->assoclen + req->cryptlen); @@ -777,6 +785,8 @@ static int dthe_aead_dec_verify_tag(struct aead_request= *req) return ret; =20 nents =3D sg_nents_for_len(req->src, req->assoclen + req->cryptlen); + if (nents < 0) + return nents; =20 sg_pcopy_to_buffer(req->src, nents, tag_in, ctx->authsize, req->assoclen + req->cryptlen - ctx->authsize); @@ -973,6 +983,10 @@ static int dthe_aead_run(struct crypto_engine *engine,= void *areq) if (assoclen !=3D 0) { /* Map AAD for TX only */ aad_nents =3D sg_nents_for_len(aad_sg, assoclen); + if (aad_nents < 0) { + ret =3D aad_nents; + goto aead_dma_map_aad_err; + } aad_mapped_nents =3D dma_map_sg(tx_dev, aad_sg, aad_nents, aad_dir); if (aad_mapped_nents =3D=3D 0) { dev_err(dev_data->dev, "Failed to map AAD for TX\n"); @@ -994,6 +1008,10 @@ static int dthe_aead_run(struct crypto_engine *engine= , void *areq) if (cryptlen !=3D 0) { /* Map ciphertext src for TX (BIDIRECTIONAL if in-place) */ src_nents =3D sg_nents_for_len(src, cryptlen); + if (src_nents < 0) { + ret =3D src_nents; + goto aead_dma_prep_aad_err; + } src_mapped_nents =3D dma_map_sg(tx_dev, src, src_nents, src_dir); if (src_mapped_nents =3D=3D 0) { dev_err(dev_data->dev, "Failed to map ciphertext src for TX\n"); @@ -1014,6 +1032,10 @@ static int dthe_aead_run(struct crypto_engine *engin= e, void *areq) /* Map ciphertext dst for RX (only if separate dst) */ if (diff_dst) { dst_nents =3D sg_nents_for_len(dst, cryptlen); + if (dst_nents < 0) { + ret =3D dst_nents; + goto aead_dma_prep_src_err; + } dst_mapped_nents =3D dma_map_sg(rx_dev, dst, dst_nents, dst_dir); if (dst_mapped_nents =3D=3D 0) { dev_err(dev_data->dev, "Failed to map ciphertext dst for RX\n"); --=20 2.34.1 From nobody Fri Sep 25 16:02:52 2026 Received: from mx0b-0002e601.pphosted.com (mx0b-0002e601.pphosted.com [148.163.154.28]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 5775E4FB9C9; Thu, 10 Sep 2026 17:57:26 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=fail smtp.client-ip=148.163.154.28 ARC-Seal: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1789063051; cv=fail; b=eg8mUPoYOtQhp+0tAw7ihVnG1IInjJ6poVKJSymvpVShmfM85dA4lfkklslria+52UT9nvalEA1aYYbIa4w1qFjJ0afS53011WSDdqdPvoRbVKMT4OoEwLxhYCng+o3uEONRPIUoVQ/2OJs8f13HXGBTPU9mx7sK+uGmbswWwb0= ARC-Message-Signature: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1789063051; c=relaxed/simple; bh=6RV17K+dOkVeshFmshHqF6sMCwCc25grQ5kOysr9CGI=; h=From:To:CC:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=twGmz7VV2MxDdKzjMSKXvIT0pzKKn5RvYodhAI+kdGp1LgTmoRm7c5ulPkC4EIELp+C4aU9K+VlFk1X3FOJUKvvA12TzTFikOVyAP6akU3K58voCli1qajDOy2aKglfdqYP/NmO5UoOHtUVPfApMx3rPxj5dbmOopP28hUrrGkI= ARC-Authentication-Results: i=2; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=ti.com; spf=pass smtp.mailfrom=ti.com; dkim=pass (2048-bit key) header.d=ti.com header.i=@ti.com header.b=hMvPBnPQ; dkim=pass (1024-bit key) header.d=ti.com header.i=@ti.com header.b=AngVP2Xt; arc=fail smtp.client-ip=148.163.154.28 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=ti.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=ti.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=ti.com header.i=@ti.com header.b="hMvPBnPQ"; dkim=pass (1024-bit key) header.d=ti.com header.i=@ti.com header.b="AngVP2Xt" Received: from pps.filterd (m0374955.ppops.net [127.0.0.1]) by mx0b-0002e601.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 68AGEdts3808502; Thu, 10 Sep 2026 12:57:22 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ti.com; h=cc :content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s= proofpoint-05-2026; bh=3Hbdg4pI7uZrAjMnu5fvtSkbjxE49GEKGFuOUs0rp ss=; b=hMvPBnPQTwdgSqcKrmYez3zm4xciBgj3o32+dyoxf7k09oZhAaeF0XcfN 5WxbCdI2FM4+rQ0GsPP+oEuNjBTPJc0e0Hh+TMymyQgSV4stj83PM+tAzyWn2VKD UBN0A50nKJWYvv+0X9gwDVbRB4zvj+Yl7K5fZXYbOfV21RtD1pyRA1Bfr2/fPXk1 W9qVlS7Zx+ER3YeWItmoQ5PEiclPwsvTJ1d+r/ypijMVPQGundQdg7t5XK9bE4hY DeL5NSzVorFdyZkGo57xmAzTuZfZE25rz/HrhggItPpdEotDithIquWyBHGO2E06 1QQUnG/xP6d35sOvnd0RZd1SOfUVw== Received: from sn4pr0501cu005.outbound.protection.outlook.com (mail-southcentralusazon11011004.outbound.protection.outlook.com [40.93.194.4]) by mx0b-0002e601.pphosted.com (PPS) with ESMTPS id 4gkyw9gp2r-1 (version=TLSv1.3 cipher=TLS_AES_256_GCM_SHA384 bits=256 verify=NOT); Thu, 10 Sep 2026 12:57:21 -0500 (CDT) ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=IG/zyOa+t1llQ/R4+ip7EH7RESsNxPqbbKFRVqAn47bfAeKIUO8zURMuplqB1BnAsBAnV8zVF5s3WO0XIsdaJQPDiYOsAjVReFHwmX5y2Qe9qhtVvT2hIJtMMXOobNSo9VHwfH4xIZ7SU4ElaIbTovdg2nQbdc0aG8qFsfTfiReCFw90WtUDLUFp4VUBZiu/2CqfaJSIdJ1onMZOTKBuXi6K15X0sIDWtdrHwVfHKiuzKywu1FIJeGtFUWSQqvkkmnPtHIc2YFXQSyFhO8ZtYHccJX+viDml16E31JmN6x6rz07oqbP6rsxBlxOQi9rG5uyrwuozal7FL733XXKSHQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=3Hbdg4pI7uZrAjMnu5fvtSkbjxE49GEKGFuOUs0rpss=; b=HQfLjuP3cSILITVfirdSXs4FyxMMarP4BmoFzV5do+xksDiOzVVgisNBSMGkURdvafjHROxREat4Kr2Nm+FubBhNdjsMavGbevRCQjFyY48GtD1nExvFOfDnhyv4NZbcUPsyfVJFACoVhIZr75ydETX0nmGQmpWN8TX1GSYvN20SuXLY1cTErotV5q0ya/ZTHrbpHxqZDqsyTbk2n8sT86N5qCUPc8STqV0ne46DlXC/mePK1l6Fn8hRqnXRULS59VyZT6drqe768KNROfIFZepQDOA6B75FNlHIZV/0Neebcm8DXH2NecmLG7e6qJpn7QU1t+2ry5S2NXzY7HcaVQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 198.47.23.195) smtp.rcpttodomain=gondor.apana.org.au smtp.mailfrom=ti.com; dmarc=pass (p=quarantine sp=none pct=100) action=none header.from=ti.com; dkim=none (message not signed); arc=none (0) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ti.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=3Hbdg4pI7uZrAjMnu5fvtSkbjxE49GEKGFuOUs0rpss=; b=AngVP2XtX8JCMlzVItGRcrbjjHU5SScl9brKqdUp9IkP7skPfhx85tKQK5Gk5oW05ETAYaJuwEln/NxWiEnvKv28sA4yzLs+Knp0vI35/J4pPMsL49f6qdScFeIlzRVwzMl6iKHxBWFadGJt4wgv+W3yQdpkwD2zataZ9uRVQSA= Received: from BN9PR03CA0378.namprd03.prod.outlook.com (2603:10b6:408:f7::23) by DM3PPFE51A5CB22.namprd10.prod.outlook.com (2603:10b6:f:fc00::c51) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.21.428.4; Thu, 10 Sep 2026 17:57:17 +0000 Received: from BL6PEPF0002256F.namprd02.prod.outlook.com (2603:10b6:408:f7:cafe::5) by BN9PR03CA0378.outlook.office365.com (2603:10b6:408:f7::23) with Microsoft SMTP Server (version=TLS1_3, cipher=TLS_AES_256_GCM_SHA384) id 15.21.406.8 via Frontend Transport; Thu, 10 Sep 2026 17:57:16 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 198.47.23.195) smtp.mailfrom=ti.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=ti.com; Received-SPF: Pass (protection.outlook.com: domain of ti.com designates 198.47.23.195 as permitted sender) receiver=protection.outlook.com; client-ip=198.47.23.195; helo=lewvzet201.ext.ti.com; pr=C Received: from lewvzet201.ext.ti.com (198.47.23.195) by BL6PEPF0002256F.mail.protection.outlook.com (10.167.249.37) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.21.406.5 via Frontend Transport; Thu, 10 Sep 2026 17:57:15 +0000 Received: from DLEE210.ent.ti.com (157.170.170.112) by lewvzet201.ext.ti.com (10.4.14.104) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.2562.45; Thu, 10 Sep 2026 12:56:59 -0500 Received: from DLEE209.ent.ti.com (157.170.170.98) by DLEE210.ent.ti.com (157.170.170.112) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.2562.45; Thu, 10 Sep 2026 12:56:59 -0500 Received: from lelvem-mr06.itg.ti.com (10.180.75.8) by DLEE209.ent.ti.com (157.170.170.98) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.2562.45 via Frontend Transport; Thu, 10 Sep 2026 12:56:59 -0500 Received: from pratham-Workstation-PC (pratham-workstation-pc.dhcp.ti.com [10.24.53.205]) by lelvem-mr06.itg.ti.com (8.18.1/8.18.1) with ESMTP id 68AHuwnb2793839; Thu, 10 Sep 2026 12:56:59 -0500 From: T Pratham To: T Pratham , Herbert Xu , "David S. Miller" CC: Sebin Francis , Manorit Chawdhry , Vishal Mahaveer , Praneeth Bajjuri , , Subject: [PATCH v4 10/15] crypto: ti - Terminate DMA on all error paths in AES to clear descriptors Date: Thu, 10 Sep 2026 23:26:14 +0530 Message-ID: <20260910175619.2122149-11-t-pratham@ti.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20260910175619.2122149-1-t-pratham@ti.com> References: <20260910175619.2122149-1-t-pratham@ti.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: BL6PEPF0002256F:EE_|DM3PPFE51A5CB22:EE_ X-MS-Office365-Filtering-Correlation-Id: a72205f3-de05-43ef-7f2a-08df0f64f2df X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|23010399003|82310400026|36860700016|376014|1800799024|10067099003|18002099003|22082099003|56012099006; X-Microsoft-Antispam-Message-Info: UVuhsGJjEBenpUbw1lj/cfk0HEOrzKmyl1swWWzYT6k2pjNzz2v8bVEFTEC7oFXa2aeVUvDK3fbTYBatSFZM5oB0FwQw9+fTT7is0bCtwgVvUKvyPb+47B7eqrbzVyNkQChuIZ8JRad9UNYog+TaFZQOWSlup8dlQVg3W+SKpQju3csP45Lix9xFvhnIdR+bYASm8odqiJnh2yZEq8sKKDzwrNboefGtRiOm8kTt9th9Ly2mSafvejQFr0K7Tilr7VpdoS+h5LpBHy8McrwSBfP+dO0GrZg8a5OX21uJVxrZknbR7Td0V9oNkIDOw344Tch8PfawvwPcvORRO/FpRKxD8i3jVxfe9pSbr+jrmkaVyrhX50ifKutVhS7M7FsFC/jqvycJLNNa/0RcrR4RAJuKiul6AVIJQut2JhMVgWCpO4IMa4AN9effuZBmnL2muQuq7iJyxC9yALG7kbHzJ+LS6VUXme3tLTDWwMbQyB7i8B32UUm1QBybnQ6aq+I43kJO2PT418zYGSZYBQAXCXHNnu7oN4dGAie0g8hPCTY6baVscSltuBuy5zDCRVskzXd/ojFmiMGHTyMtOWsaailxi6imvLVKyJa4NE70rFaFTyXGP61Dap2LI9AAXDpInoLp4D6QO4DT8qb+5UBgFJHlr4LM3ak9h9HVG43ptyMRwsgoREbF2TDdYDlwzMHSxmB0u6oH2BiN0BP0pDUPFg== X-Forefront-Antispam-Report: CIP:198.47.23.195;CTRY:US;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:lewvzet201.ext.ti.com;PTR:InfoDomainNonexistent;CAT:NONE;SFS:(13230040)(23010399003)(82310400026)(36860700016)(376014)(1800799024)(10067099003)(18002099003)(22082099003)(56012099006);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: 60lPRVnxSp61W2jexiG8O1VJnmLNCAU3MUmhnjGaMv6OByXWi6b7LeLQE8gASxMUmFTid7zDAbS9835qNNDRvtrdPsMfIppwFqscSgMlQ9bCEl8Auk9EWidHb/uOczYmykp3xKUgfBIlZuoVP6CIQUoGU4E2dpZQyFWxrN0TYsgZVNPjtfuxn16wokOMVbc8aqnd4VzZLQw7bOVZzN/DfRXZB4mPejxt5muQd4ExEBmOVMqcnnGrT1bTdZmpwygbTunegsEwg5PAQt5jQ0Q3xthgLlpEa2XnCSsQkxIwU6UPULqSXDVmldr8RPra2WWsZxXsTef1LTrIeIE0xj0nnA0HbccW2Zy+WyXsyw0IjrWijzC9a0pN4ZUe4CM1+POfWz3/deeGFOXDE6itQxf4uD3ldNIIoYOQG6nHBc1uUlystT0xsujTsXjdbJT4yh6P X-Exchange-RoutingPolicyChecked: BHz2A1XbIVbiGTFu0gfTdz2hkDSfjhmdzlwfA4RN6FVFft/m0cshR8xLaCrErHSFV9ucfZ7enfKM8ppL13ElBB44AJTC6d6kTBEoWQHY+OU2yiHfzCOunkEBRXv5iw3AiG/LG7g4Kd871mhRE/fxMKCU4co/qCo4sT/QYka+K8seXLTc72jKwfHmoIKbUAGQDwoMw/ejs3E3Oc4VTKBPncRfFL+jrNbIdS/1VNwO+bPnxeTYhHWGsJvLjWfEb8yuGfaj3vss7zmznMANCuQAAS+xjRpf9ZeMVbRy9Hwr+bxw6iUC8SZtG43J8unb7N3OBj6DdVLoodQKdh91AMguzA== X-OriginatorOrg: ti.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 10 Sep 2026 17:57:15.4543 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: a72205f3-de05-43ef-7f2a-08df0f64f2df X-MS-Exchange-CrossTenant-Id: e5b49634-450b-4709-8abb-1e2b19b982b7 X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=e5b49634-450b-4709-8abb-1e2b19b982b7;Ip=[198.47.23.195];Helo=[lewvzet201.ext.ti.com] X-MS-Exchange-CrossTenant-AuthSource: BL6PEPF0002256F.namprd02.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM3PPFE51A5CB22 X-Proofpoint-Spam-Info: AW1haW4tMjYwOTEwMDIyMCBTYWx0ZWRfX0Yad8a1XoQLj qi3f5F1KoVIR0k5v3qcAgQYWBgiqpEF89rinv6nY9TBcPSgKb3EkMz6viYCn6rXgwAiCHEEtq9d VxvGLigxVCIAqpRKQjcOnGHl2S2324o= X-Authority-Analysis: v=2.4 cv=ON6yTiaB c=1 sm=1 tr=0 ts=6aa2ef81 cx=c_pps a=FYRcjPsbj8Vbl0y3HSZiwA==:117 a=f+v6EHfkeJbVwR46tk4DMg==:17 a=6eWqkTHjU83fiwn7nKZWdM+Sl24=:19 a=VdqzKS8jKosA:10 a=s63m1ICgrNkA:10 a=V5UXEbMT0ywA:10 a=VkNPw1HP01LnGYTKEx00:22 a=Z8NIEmU8O1QQgoT56wFK:22 a=fPAWb5peG099m5CrUpKH:22 a=sozttTNsAAAA:8 a=T1XiGUNGXxSxoSVzcpQA:9 X-Proofpoint-GUID: PO_xsGJ8KpVBmPMvvk-PlrWfeSe_iCNQ X-Proofpoint-ORIG-GUID: PO_xsGJ8KpVBmPMvvk-PlrWfeSe_iCNQ X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwOTEwMDIyMCBTYWx0ZWRfX7Z/vxtQHMQkj +pfkXIyz6ZSMWLZrSFfdNXY2YAzG94vvRjY8b6UFqpW66Oe4sR6lE5BGPoZ/Kzq0llT10Nw5RC5 FbrS6gYo6ledMTxuCnf+jHFPWbx7V847SQBNBAt2KGlMQdyVbzetGflZvVT7cZUFp+H5/NydXNm AGLfdjMguE6v/1P/nmVbQy7KlguwT+pXG6T5xDr20vU1lzcFmNIHG8qeqGWb2WYIC7MeSM2rBGB ujPgxXXklf+0fqBhXkQPYfvFDTyYEAKpYQY6fzrNvkSRHFSNHPPhfDgirSRyRucx25QhyTbq24V 5mOJQR4hpvm0R3qgF1CPGTmp2JpBsLd+ZzuoRLX3/2RbaP0Wf38h6xyeTbRX6u40BXCzd1MrcRs qA2i63zQSCq/jQGyU+vUymq5/NDHC5+st4h6CCWM4Kj945R+BmF6jFC85oVF20M9IkAbuZ7MJ8N 6RXYOE6IX+Yzy0wk4Kw== X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1176,Hydra:6.1.134,FMLib:17.12.100.49 definitions=2026-09-10_05,2026-09-09_02,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 impostorscore=0 adultscore=0 clxscore=1015 phishscore=0 bulkscore=0 spamscore=0 suspectscore=0 malwarescore=0 priorityscore=1501 lowpriorityscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2609040000 definitions=main-2609100220 Content-Type: text/plain; charset="utf-8" dmaengine_prep_slave_sg() allocates a DMA descriptor which is freed on either successful dmaengine_submit() or on dmaengine_terminate_sync(). The error paths after descriptor allocation was not clearing them, leaving the descriptors orphaned and leaking memory in case of failure. Add terminate calls in dthe_aes_run() to appropriately clean the DMA descriptors. Fixes: 52f641bc63a46 ("crypto: ti - Add driver for DTHE V2 AES Engine (ECB,= CBC)") Signed-off-by: T Pratham --- drivers/crypto/ti/dthev2-aes.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/drivers/crypto/ti/dthev2-aes.c b/drivers/crypto/ti/dthev2-aes.c index 65a53fcf80467..10073bbeca113 100644 --- a/drivers/crypto/ti/dthev2-aes.c +++ b/drivers/crypto/ti/dthev2-aes.c @@ -449,6 +449,8 @@ static int dthe_aes_run(struct crypto_engine *engine, v= oid *areq) if (!desc_out) { dev_err(dev_data->dev, "OUT prep_slave_sg() failed\n"); ret =3D -EINVAL; + /* terminate to free the orphaned desc_in descriptor */ + dmaengine_terminate_sync(dev_data->dma_aes_rx); goto aes_prep_err; } =20 --=20 2.34.1 From nobody Fri Sep 25 16:02:52 2026 Received: from mx0b-0002e601.pphosted.com (mx0b-0002e601.pphosted.com [148.163.154.28]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 2FFD5569F04; Thu, 10 Sep 2026 17:57:48 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=fail smtp.client-ip=148.163.154.28 ARC-Seal: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1789063072; cv=fail; b=gd0dr6xnJbQ6i1+6kgmP/stUK+1aLFZ1jD6Q06woRqs1tI2qlSh13b6kvl+iOtsaIQoar0w1BEM5aOxctP+OMRawvQjEJzndqsSslqbWCcESeeK7i1omkGliHbiRW4/NO5lLVC9t84QMVbSxi/Nu5ZAuoXk2TiHmnMhuNuD/h58= ARC-Message-Signature: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1789063072; c=relaxed/simple; bh=OuWkyrSAYLpUMGWtwqp0QtAQW2fMadEqcmQ2cP2XYgA=; h=From:To:CC:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=tuCPmOe25fQ5hK1LwYGuKfOUIwdZxeoIO/Or37xh2izFYppsmW0PLYoDEuT47RHeonkpbzSQq9Z0sXGuugHpf3VpTUCyri6oUBwhinT+uQTh1q0tATVO6sZjzvtZ1+oDgerZvcRjuwQPpe3OH8GctiE4kcALsBuQ3L+yOLkkcnI= ARC-Authentication-Results: i=2; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=ti.com; spf=pass smtp.mailfrom=ti.com; dkim=pass (2048-bit key) header.d=ti.com header.i=@ti.com header.b=e7L4TRXA; dkim=pass (1024-bit key) header.d=ti.com header.i=@ti.com header.b=F97mU0tj; arc=fail smtp.client-ip=148.163.154.28 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=ti.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=ti.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=ti.com header.i=@ti.com header.b="e7L4TRXA"; dkim=pass (1024-bit key) header.d=ti.com header.i=@ti.com header.b="F97mU0tj" Received: from pps.filterd (m0374955.ppops.net [127.0.0.1]) by mx0b-0002e601.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 68AGEbaa3808450; Thu, 10 Sep 2026 12:57:44 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ti.com; h=cc :content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s= proofpoint-05-2026; bh=kZD+OiTUMOfEPNZVRM9b0rd42p1/v7GDAJbNfg0tE ug=; b=e7L4TRXArqAgR+uoMG1YLZg5Bsk/T0Z6sKCHciokHo0trnTWPe5cC09KC K1xR5iD08o0SYPwBrdEPKEX/Egy9x0WsgKiJMFQPnyL1amDkj5eGdsbgsvH01XK+ 3cKDu/UPlrcq0baox2lEgYgn2Czx2z0Y2qsD18K5qd5OaJbmNk/AzqF6b5evytxa SltS5DSD2nqccB+OkGMsnJTNOcX5rfg/xOmhaODurQoOQkcpf3gfZXxqN0eMXyQf kyXbh3cw2iaTtaj+ezNAX7N2g9qIVlz/ZWFZBPFlzBTcRgNFG+1QVbfu8H4NA4xI 8QK0Mf7hXL5cdBU2y318M61GHvDwQ== Received: from ch4pr04cu002.outbound.protection.outlook.com (mail-northcentralusazon11013044.outbound.protection.outlook.com [40.107.201.44]) by mx0b-0002e601.pphosted.com (PPS) with ESMTPS id 4gkyw9gp4t-1 (version=TLSv1.3 cipher=TLS_AES_256_GCM_SHA384 bits=256 verify=NOT); Thu, 10 Sep 2026 12:57:44 -0500 (CDT) ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=WqnjL0RH30Mhm1DN2yqwR6HXDFMxAkQ2lt+EMRTqKUP9/Th/jTxNDaREHl6vGLphPChcMrFm+l34PIlsukWJMVd3RFkSAAXgOYBFCLZzFQGMfGCgWvtp68NGe14hf4+/uPqit2mUkNXGyPoWmQy0nMiq8jDoGk7n5NFtHPo6aZk6M97BLkBM3kZ/BtSYNTVuOYtodVPJl5HpQ4TaNiBQkGtXw7atlUTy1gx8QPjY2pG1+b/tTPmAm+pkqQXnbMqB+kUWvO3T+gKXWn2GoR4WZfoUWtyAVp88qQCwNJiUfxjQUWNrh55GjANrjHy+RUGkm2gEV+XnngDPQeFSyRQgDw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=kZD+OiTUMOfEPNZVRM9b0rd42p1/v7GDAJbNfg0tEug=; b=E8ZMCFQiCaBC6N+qpfVFL+Qhp3YtatxMW4mUq1DyyL5ikV5SyQ+1WddRo1eG1LP4UySfHM4e5YihwhHw5esy+/5D8cZl0vN0vZzOWsmfUZgnMWIHHRUUloNyCMTjkzBT58u/dDw9q0ZNS8ELQVoHSkbnGUUH3SIRwDhulxYBafbzziHSdyVm7CejHMxxWuL7rd34MGReT6rztcSj+dD5YFV+SiaR1+zIyhbQT7h/rX064jhEiAPDjof+TD0dKhPLeayc1Yh4cOp4lARWxADxva51A+UscHvvqUggfffoLzn20N1e9kWqgJGHHrvKpTyovAePQSfJdZ4vJhs4DhaWPA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 198.47.21.195) smtp.rcpttodomain=gondor.apana.org.au smtp.mailfrom=ti.com; dmarc=pass (p=quarantine sp=none pct=100) action=none header.from=ti.com; dkim=none (message not signed); arc=none (0) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ti.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=kZD+OiTUMOfEPNZVRM9b0rd42p1/v7GDAJbNfg0tEug=; b=F97mU0tjiESsOKcAmSvprg1P+NMlfEQCqLfGwj89/zTLx350VK8vNW5hbp8X+pODFpntkb3NYSNBo1Xgev2QgEBgunKbDg+qCaPciUuQ8RlaONOiGK2lvg8X+WXP2zn1Q1kFgQ0OGzBsYhWik1Db/GI6Qd5MWqOkUgcmslPv1Bg= Received: from CH0PR07CA0018.namprd07.prod.outlook.com (2603:10b6:610:32::23) by IA0PR10MB6793.namprd10.prod.outlook.com (2603:10b6:208:43b::10) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.21.428.5; Thu, 10 Sep 2026 17:57:38 +0000 Received: from CH1PEPF0000AD81.namprd04.prod.outlook.com (2603:10b6:610:32:cafe::97) by CH0PR07CA0018.outlook.office365.com (2603:10b6:610:32::23) with Microsoft SMTP Server (version=TLS1_3, cipher=TLS_AES_256_GCM_SHA384) id 15.21.406.9 via Frontend Transport; Thu, 10 Sep 2026 17:57:38 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 198.47.21.195) smtp.mailfrom=ti.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=ti.com; Received-SPF: Pass (protection.outlook.com: domain of ti.com designates 198.47.21.195 as permitted sender) receiver=protection.outlook.com; client-ip=198.47.21.195; helo=flwvzet201.ext.ti.com; pr=C Received: from flwvzet201.ext.ti.com (198.47.21.195) by CH1PEPF0000AD81.mail.protection.outlook.com (10.167.244.89) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.21.406.5 via Frontend Transport; Thu, 10 Sep 2026 17:57:36 +0000 Received: from DFLE211.ent.ti.com (10.64.6.69) by flwvzet201.ext.ti.com (10.248.192.32) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.2562.45; Thu, 10 Sep 2026 12:57:01 -0500 Received: from DFLE211.ent.ti.com (10.64.6.69) by DFLE211.ent.ti.com (10.64.6.69) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.2562.45; Thu, 10 Sep 2026 12:57:01 -0500 Received: from lelvem-mr06.itg.ti.com (10.180.75.8) by DFLE211.ent.ti.com (10.64.6.69) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.2562.45 via Frontend Transport; Thu, 10 Sep 2026 12:57:01 -0500 Received: from pratham-Workstation-PC (pratham-workstation-pc.dhcp.ti.com [10.24.53.205]) by lelvem-mr06.itg.ti.com (8.18.1/8.18.1) with ESMTP id 68AHv0Ti2793863; Thu, 10 Sep 2026 12:57:01 -0500 From: T Pratham To: T Pratham , Herbert Xu , "David S. Miller" CC: Sebin Francis , Manorit Chawdhry , Vishal Mahaveer , Praneeth Bajjuri , , Subject: [PATCH v4 11/15] crypto: ti - Terminate DMA on all error paths in AEAD to clear descriptors Date: Thu, 10 Sep 2026 23:26:15 +0530 Message-ID: <20260910175619.2122149-12-t-pratham@ti.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20260910175619.2122149-1-t-pratham@ti.com> References: <20260910175619.2122149-1-t-pratham@ti.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: CH1PEPF0000AD81:EE_|IA0PR10MB6793:EE_ X-MS-Office365-Filtering-Correlation-Id: adf34b42-9121-4f45-7f70-08df0f64ff86 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|36860700016|376014|23010399003|82310400026|1800799024|10067099003|18002099003|22082099003|56012099006; X-Microsoft-Antispam-Message-Info: +slTOL1zeoKpZn22cQcf6rHAdS0SMSrVKdisLnQkRqS4hWcoYfVx3TF07kqiSqVqcU6Ux1FckKlNMD2Emo5vp/rp+f8IDheOnx64iCGxbctlUCIPe6IHADgN3498cRZ1BQIkJEzzHn5BKbu3jhCLWCKqlXZypheI0yBDIqLB07IeZoxkv7JFuNOivwvKvR8nYV02DsjVUp63Mrs63fucJ1QLfATCeu5KvDN+zixPaXuUYW93Q2Yl8B+0wjW+IFLzfDxGa7GO5LR/JUePPJ1/noAsE5d+PfXJ+5MZ2nsi+DCmp8geIJ9gyNv4ZMdlrkIu3tnvaZt/wpfjNI6yvmKVRTumsP1B3GJ5dC1of90zPeuneBglRYr5sipVU793TQw/e8g6Wl12DiJ+U6zgLW+nvwRYzYK2jL93YOL7jbEie6UegbHkw9puR9ZZEncXzVslzHLCmU7R7cMQ6eNcaTXR2tQAO8x0OdM8jcwfmDHPeMTD4gNxiTbOfwbGERoE6hCTM5yD+FLA0ucLA/QdReZruXWmK1BTZDCzJnguij2wY6Mvn8ZcZ6JKF6H1khz/OaZ0WGg2q9dKlHz++t3QMI0VbC9AP4j7fqXvGBPCb+AWgVbUPCE7Te9mv/NJfM719S/O2sYiqgWcvdFRoGamXqyZ6sY/BQFTGNbxVN1v4TPnXdwoNyAa+C5+ApD2vdkDOH+rxmGWmcVK2ieSCXxt1/zzbQ== X-Forefront-Antispam-Report: CIP:198.47.21.195;CTRY:US;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:flwvzet201.ext.ti.com;PTR:ErrorRetry;CAT:NONE;SFS:(13230040)(36860700016)(376014)(23010399003)(82310400026)(1800799024)(10067099003)(18002099003)(22082099003)(56012099006);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: MYLF9crGAFTZcABEsTGhVOcFH42L38QzJe46KVNzS3W9aqXL4EdkgXg/Xxy+4FYsEz1oTkOjIhSoftxJyiueqmHL1gjKtJalqaLy+5hhrFnGw13XyB8bRffRjcKPZ8dYpyFUwGaKRW9vVRgDe0YUFSV1q/uyGJCnML1qlw8qLzZHoS9lp97IacGAPYFPzWWaauom6UxEb/hKIFJKgEGNOeN2RHKpcVEVfGJe9tdcBaFIaPXmCNavwqkTI08Uhmu7wcNs8yiF4CiinQ/rlCrWE0n1iLHRQQGNJhB5gCb3G8qxMO9S29Ta26fGi57bP8OATzkSMfrJMZDjpznXUkLLvwN9GGbIVUX3+7kM/GeAtAb2otdhVd4Y1hWTTPzPeVo7JpADrv8zVjFcuD4KyT+CyzoQRHJ7R885uemRZesdUBVjpaZgY6XZFYWhMDuLqmqW X-Exchange-RoutingPolicyChecked: unOCzR/pFQFJ4VfrgEgGZf6pKzueAvlU9jVb7IF0+WXt2Twt+/Ia5z27LKxArJE378mbV0CSwHirNUPv1lv6RcEsXZG/fVlXxZD4GZHjiXDjAY7CQAACtloytFokf60tzfeZ6J/1DWhXsE6UpUauHNHJTcEDxIetzhjt6lV3nW/w3s0NO9cELOlYUAWAbH3vYG7NBpefZV569IyOu+g/wB7l+nGqa6bVGlGFIwc9FmdAUyBz6qkYpqh3hYI+Ms7EHiec9y5qaImUx4SPyDXBjzJRtLw7HWRtNbhxEw8fL5b36Xo8az8E5uT4OrPwaquP5vV6jGhRNbr26/+4WfpTjA== X-OriginatorOrg: ti.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 10 Sep 2026 17:57:36.7044 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: adf34b42-9121-4f45-7f70-08df0f64ff86 X-MS-Exchange-CrossTenant-Id: e5b49634-450b-4709-8abb-1e2b19b982b7 X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=e5b49634-450b-4709-8abb-1e2b19b982b7;Ip=[198.47.21.195];Helo=[flwvzet201.ext.ti.com] X-MS-Exchange-CrossTenant-AuthSource: CH1PEPF0000AD81.namprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: IA0PR10MB6793 X-Proofpoint-Spam-Info: AW1haW4tMjYwOTEwMDIyMCBTYWx0ZWRfX1RXe8Qb6nwzx n0dx4m2++bWcSXz1wC6qyW/kF1FuuWQ4cOjK6o9eqIVCaPoZ8aMuZKxFp9qXWWkKgZ5dV/PBKxm U5mzsFYWC33E6dJZnWj/F1mouWNTYuc= X-Authority-Analysis: v=2.4 cv=ON6yTiaB c=1 sm=1 tr=0 ts=6aa2ef98 cx=c_pps a=skQXzUdJ1yZbsxdDph07EQ==:117 a=tJyPKKxUohctrY4NYmUjkA==:17 a=6eWqkTHjU83fiwn7nKZWdM+Sl24=:19 a=VdqzKS8jKosA:10 a=V5UXEbMT0ywA:10 a=VkNPw1HP01LnGYTKEx00:22 a=Z8NIEmU8O1QQgoT56wFK:22 a=fPAWb5peG099m5CrUpKH:22 a=sozttTNsAAAA:8 a=noPYQ3j_lezN9luSq70A:9 X-Proofpoint-GUID: 9U_fWK6DFubD91lBWCtFOWnGRsyDogcK X-Proofpoint-ORIG-GUID: 9U_fWK6DFubD91lBWCtFOWnGRsyDogcK X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwOTEwMDIyMCBTYWx0ZWRfX2D8Kb7lE1TKz u/MZzuerrG77/2mnY9jBKqlHJMJmOmAHWB8O656CTRHHc/IYuqFNW7GnTjOSTKiUCIjUW4rdIox CKc9zEfHHAqNpq2exbbaYuJ+SoCahABvxJuCSkaUW2+YWmYrm9AzZ925kZakyjlfHHZjSVP8+6C 7zUMwfItwI4LmvlqIVhWPnttBzZI4LszBeuX4j30DnbPyD1FjlaUP9dPOimGNFKD43arlLLSmka yTEy+MJ9AxEpZCe+FoqbXtwy8RIhzpDMXfiAdBOm75h6q3mmw/n+F0i5+TsHshCo7vBEV2cfRQR WDqAtnV+M0XKovdURm22HDGzEFLIMbHLvRPHQmyWqPRAhQfKRfBzof+zkCaTlcm0iPLi5G1NMIg p0ddSXpLiV8j1vf+O+Jj89RIn3IS3PnTvJ/85EfGrY4uZI4TF4pS2UyT0ByfrLp1fJxlZ2Kol0b tDFR9hpXE0PeyB22geg== X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1176,Hydra:6.1.134,FMLib:17.12.100.49 definitions=2026-09-10_05,2026-09-09_02,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 impostorscore=0 adultscore=0 clxscore=1015 phishscore=0 bulkscore=0 spamscore=0 suspectscore=0 malwarescore=0 priorityscore=1501 lowpriorityscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2609040000 definitions=main-2609100220 Content-Type: text/plain; charset="utf-8" dmaengine_prep_slave_sg() allocates a DMA descriptor which is freed on either successful dmaengine_submit() or on dmaengine_terminate_sync(). The error paths after descriptor allocation was not clearing them, leaving the descriptors orphaned and leaking memory in case of failure. Add terminate calls in dthe_aead_run() to appropriately clean the DMA descriptors. Fixes: 37b902c603042 ("crypto: ti - Add support for AES-GCM in DTHEv2 drive= r") Signed-off-by: T Pratham --- drivers/crypto/ti/dthev2-aes.c | 15 +++++++++++++-- 1 file changed, 13 insertions(+), 2 deletions(-) diff --git a/drivers/crypto/ti/dthev2-aes.c b/drivers/crypto/ti/dthev2-aes.c index 10073bbeca113..a034c1c8f20ed 100644 --- a/drivers/crypto/ti/dthev2-aes.c +++ b/drivers/crypto/ti/dthev2-aes.c @@ -912,6 +912,7 @@ static int dthe_aead_run(struct crypto_engine *engine, = void *areq) =20 struct device *tx_dev, *rx_dev; struct dma_async_tx_descriptor *desc_in, *desc_out, *desc_aad_out; + bool cleanup_tx_chan =3D false; =20 int ret; int err; @@ -1012,13 +1013,15 @@ static int dthe_aead_run(struct crypto_engine *engi= ne, void *areq) src_nents =3D sg_nents_for_len(src, cryptlen); if (src_nents < 0) { ret =3D src_nents; - goto aead_dma_prep_aad_err; + cleanup_tx_chan =3D (assoclen !=3D 0); + goto aead_dma_map_src_err; } src_mapped_nents =3D dma_map_sg(tx_dev, src, src_nents, src_dir); if (src_mapped_nents =3D=3D 0) { dev_err(dev_data->dev, "Failed to map ciphertext src for TX\n"); ret =3D -EINVAL; - goto aead_dma_prep_aad_err; + cleanup_tx_chan =3D (assoclen !=3D 0); + goto aead_dma_map_src_err; } =20 /* Prepare DMA descriptors for ciphertext TX */ @@ -1028,6 +1031,7 @@ static int dthe_aead_run(struct crypto_engine *engine= , void *areq) if (!desc_out) { dev_err(dev_data->dev, "Ciphertext TX prep_slave_sg() failed\n"); ret =3D -EINVAL; + cleanup_tx_chan =3D (assoclen !=3D 0); goto aead_dma_prep_src_err; } =20 @@ -1036,12 +1040,14 @@ static int dthe_aead_run(struct crypto_engine *engi= ne, void *areq) dst_nents =3D sg_nents_for_len(dst, cryptlen); if (dst_nents < 0) { ret =3D dst_nents; + cleanup_tx_chan =3D true; goto aead_dma_prep_src_err; } dst_mapped_nents =3D dma_map_sg(rx_dev, dst, dst_nents, dst_dir); if (dst_mapped_nents =3D=3D 0) { dev_err(dev_data->dev, "Failed to map ciphertext dst for RX\n"); ret =3D -EINVAL; + cleanup_tx_chan =3D true; goto aead_dma_prep_src_err; } } else { @@ -1056,6 +1062,7 @@ static int dthe_aead_run(struct crypto_engine *engine= , void *areq) if (!desc_in) { dev_err(dev_data->dev, "Ciphertext RX prep_slave_sg() failed\n"); ret =3D -EINVAL; + cleanup_tx_chan =3D true; goto aead_dma_prep_dst_err; } =20 @@ -1145,6 +1152,10 @@ static int dthe_aead_run(struct crypto_engine *engin= e, void *areq) aead_dma_prep_src_err: if (cryptlen !=3D 0) dma_unmap_sg(tx_dev, src, src_nents, src_dir); +aead_dma_map_src_err: + /* Free any descriptor prepared on dma_aes_tx but never submitted */ + if (cleanup_tx_chan) + dmaengine_terminate_sync(dev_data->dma_aes_tx); aead_dma_prep_aad_err: if (assoclen !=3D 0) dma_unmap_sg(tx_dev, aad_sg, aad_nents, aad_dir); --=20 2.34.1 From nobody Fri Sep 25 16:02:52 2026 Received: from mx0a-0002e601.pphosted.com (mx0a-0002e601.pphosted.com [148.163.150.75]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id E1758566C7B; Thu, 10 Sep 2026 17:57:45 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=fail smtp.client-ip=148.163.150.75 ARC-Seal: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1789063069; cv=fail; b=HH6Uh7FytXFBmYofOQv8JSWRS6Ji4bW8kGZiJiyHpNwAnAzqCDMg12/hZOyzuiJ5xghes3uf40KOHsVrWPERb9N4wX8+NaKpOYhTmxjHghZpEitMLj0chrRzFaEvm+NfQ1HhXv8eh7mKhCVzqPpC6dO4duQfaavjngLwXflqDeA= ARC-Message-Signature: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1789063069; c=relaxed/simple; bh=rMIHH7q1HiGvJljbcET80ADog5KoEWbz8PeiVhRv+ks=; h=From:To:CC:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=vBqOWQwaPSiA8CGPb0zzxPb48+9Cfie7VXGUSUZ2xrHa1vLeaWSwKfWsy/7pUJFF8DtCTFDtsqfGwO5CNt7YqnC9L2BWhElIBnnlxYxqoHbHFbEwSHnooxLarBfRD9J/FCLUgCNZYFXbLSkurkDGC/5RakIxyIBCMn2YDFm65Ns= ARC-Authentication-Results: i=2; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=ti.com; spf=pass smtp.mailfrom=ti.com; dkim=pass (2048-bit key) header.d=ti.com header.i=@ti.com header.b=SA++p9kJ; dkim=pass (1024-bit key) header.d=ti.com header.i=@ti.com header.b=aVBuLdxc; arc=fail smtp.client-ip=148.163.150.75 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=ti.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=ti.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=ti.com header.i=@ti.com header.b="SA++p9kJ"; dkim=pass (1024-bit key) header.d=ti.com header.i=@ti.com header.b="aVBuLdxc" Received: from pps.filterd (m0384305.ppops.net [127.0.0.1]) by m0384305.ppops.net (8.18.1.11/8.18.1.11) with ESMTP id 68AF62ka1430994; Thu, 10 Sep 2026 12:57:41 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ti.com; h=cc :content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s= proofpoint-05-2026; bh=6E/G/PUZN0NxwZbEDin4ADqQv2DLFI8Xgpfze4sUr Gk=; b=SA++p9kJ1vmoVLTtrHVayKV03fqhU20sTckfm5QbMVeOXsmccIcyrekw+ FYxWbht9jCwbjijoSfMknjH38GRMZLwHmxvM2Y9v7W2ASSCcZ2LQkn9aE+2K/M/m DzrDY1otV3tyrQMwRFBjbcPorpOzS8DtmxD8UTQ84FJUrAsBA9kFmrYzM/Z7aWmT /0ZWVfD/iSXOX7A1wLuYjXbFM2Yv+/Di6UBVpolr3vr/4T+skuI307JIMK1B/luc MfYSh0iDks7GUAsyDvQsEg4aWYnJXyY17pLmlBexw4W4Q0dfd82jqHmgGuaciJtq B22Bbp0/8vIdmJPU0wy0r6AjLqjOA== Received: from dm1pr04cu001.outbound.protection.outlook.com (mail-centralusazon11010025.outbound.protection.outlook.com [52.101.61.25]) by m0384305.ppops.net (PPS) with ESMTPS id 4gkcxgfbj6-1 (version=TLSv1.3 cipher=TLS_AES_256_GCM_SHA384 bits=256 verify=NOT); Thu, 10 Sep 2026 12:57:41 -0500 (CDT) ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=oUd7AzVzeb3dmJjOgxeRayYuea1fGg2SXQv10kuFwZIKfma/9ygngRD6dmibQ7ehvcWWJLiXMRMo3wTtILmRJDG36TfFumg0YdIep4HcTRarlcGC0025rcwSpfR3o4EQDk+XiOIwVyHF38vCjR/TGeFBGi5PJKhwuly4ZrUoo5we7oa81aQIGIJtICkWKnxxBCrxRGZuFUh4VPIAXxxVStLjQwt5sbEmdgXcYGtZSbG4IAk8rJdXP5vEPI57yQfByF7eUC6Dqo0UwnUvDhnqOkhKpvBCM0U1xqUFNcMIsNbGktMHdjI3b1SXmd84BuzvT2c5kklsjLr+rSTw/HNNPA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=6E/G/PUZN0NxwZbEDin4ADqQv2DLFI8Xgpfze4sUrGk=; b=xtqEj3xqwMjF4nEDM2BecyQbvPUTyzHXLvS1YvCXvIUHxKe2UYHcSKfWtxM05iB0t5+V0xwfnljZIfwwNBYvm0E60Q+/9AUU2bplMlV3cXogW4CTlAmPZM5G1yqpaxaFLMeNXMcT+AAeuyiB84q+R03Lpue9CrpD67C2TyQyZKY8hEMNMMnJgBcmhg3XrknIBAGwqOByGC/MK1PeDd4K6fPBTx48jXuLzUBnfAX9ngnIE+zojCCbY6CxOXMxUqk1+3C35J3hoeR/EgFNTRAOw0eaBjnTPSP4oNuR8pA4vNQqhT6pEnE5Qq+bkIf4gqXH6/cnaCqHL1mL5gMpyrLMyg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 198.47.23.194) smtp.rcpttodomain=gondor.apana.org.au smtp.mailfrom=ti.com; dmarc=pass (p=quarantine sp=none pct=100) action=none header.from=ti.com; dkim=none (message not signed); arc=none (0) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ti.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=6E/G/PUZN0NxwZbEDin4ADqQv2DLFI8Xgpfze4sUrGk=; b=aVBuLdxcwj+esPIta9LPdsvhrVmRUsDBjXDyM6Vwp07ROmOGiKZTnSrXu0guytHRefZdCnDb5NPbSVc3MZxu/dQ2y3pLsXYIJ/iWY6STzrMd7KSbBso3/6x2rGYp1E7uXanqKSzaoAhS2e7wELiOUKwJCey+8Mo3h0qLJ52KxFk= Received: from MW4P222CA0011.NAMP222.PROD.OUTLOOK.COM (2603:10b6:303:114::16) by IA1PR10MB6052.namprd10.prod.outlook.com (2603:10b6:208:3af::13) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.21.428.5; Thu, 10 Sep 2026 17:57:38 +0000 Received: from SJ1PEPF000037B4.namprd05.prod.outlook.com (2603:10b6:303:114:cafe::50) by MW4P222CA0011.outlook.office365.com (2603:10b6:303:114::16) with Microsoft SMTP Server (version=TLS1_3, cipher=TLS_AES_256_GCM_SHA384) id 15.21.406.9 via Frontend Transport; Thu, 10 Sep 2026 17:57:35 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 198.47.23.194) smtp.mailfrom=ti.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=ti.com; Received-SPF: Pass (protection.outlook.com: domain of ti.com designates 198.47.23.194 as permitted sender) receiver=protection.outlook.com; client-ip=198.47.23.194; helo=lewvzet200.ext.ti.com; pr=C Received: from lewvzet200.ext.ti.com (198.47.23.194) by SJ1PEPF000037B4.mail.protection.outlook.com (10.167.244.196) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.21.406.5 via Frontend Transport; Thu, 10 Sep 2026 17:57:35 +0000 Received: from DLEE205.ent.ti.com (157.170.170.85) by lewvzet200.ext.ti.com (10.4.14.103) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.2562.45; Thu, 10 Sep 2026 12:57:04 -0500 Received: from DLEE207.ent.ti.com (157.170.170.95) by DLEE205.ent.ti.com (157.170.170.85) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.2562.45; Thu, 10 Sep 2026 12:57:04 -0500 Received: from lelvem-mr05.itg.ti.com (10.180.75.9) by DLEE207.ent.ti.com (157.170.170.95) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.2562.45 via Frontend Transport; Thu, 10 Sep 2026 12:57:04 -0500 Received: from pratham-Workstation-PC (pratham-workstation-pc.dhcp.ti.com [10.24.53.205]) by lelvem-mr05.itg.ti.com (8.18.1/8.18.1) with ESMTP id 68AHv3UI3763975; Thu, 10 Sep 2026 12:57:03 -0500 From: T Pratham To: T Pratham , Herbert Xu , "David S. Miller" CC: Sebin Francis , Manorit Chawdhry , Vishal Mahaveer , Praneeth Bajjuri , , Subject: [PATCH v4 12/15] crypto: ti - Do AEAD software fallback on only ENOMEM Date: Thu, 10 Sep 2026 23:26:16 +0530 Message-ID: <20260910175619.2122149-13-t-pratham@ti.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20260910175619.2122149-1-t-pratham@ti.com> References: <20260910175619.2122149-1-t-pratham@ti.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: SJ1PEPF000037B4:EE_|IA1PR10MB6052:EE_ X-MS-Office365-Filtering-Correlation-Id: f9103171-4380-434c-8267-08df0f64fe8c X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|23010399003|36860700016|1800799024|82310400026|376014|56012099006|10067099003|22082099003|18002099003; X-Microsoft-Antispam-Message-Info: TZEs01aH5SI891U/t7mN5+gNaOdlUfk40EsJsF0l/gKMUx6h79sO8mMqhfD6oE5uJY3WGVSeFYsDGzkSK1Ser5Hs0j2kb90NFscSPRwS49XaP/PGCjFZHAcImNRzIPkK9q78Rzw3kWE86whT12XUqE4hnmFBRL5qCyp7NHLkb3HbZfYboYZa7rII+56n8FJZ2a1fZJBdKfMSZdQXcojhAsTNyuSTN81K/D7P7w+kt9efLCTMtIX+lmJW+OvSmpUnVKQqOzPb6jQHrQlzuOoh/pd//0woxsc0ClEOGEq7qPdavMF1a66f0NzDpSRNgolQ7ajKSKXILh/jtPpNbH5I4Ox1lC5RmZrIYGFZ7/HEVXdJPmlxcWucKWcLMvTF4px/69BJnmjUdY68ZzI5YU1z49O9D3h7DpsYrIMHaljp6RuiHw5R/zwZZRS9eYh9gfHmgjWXcQlYBF2a4N9LH/LGrqkCV/9OoHTWYmqoMJP/TRwFkt8bn+keNU8txLBLPPBXTtYNcE3ORaRmaZB6pmIp5HHLZ5ULb3oj/xWyCTuWwnv27Yuq4LkHwRXtjvqubw9yYP+owfHTef7x3bzutSHdtqh6t1gzy1Ri7ogNqtiw2Kzo7MnQp70YwEETyb52Hkvza4knmEOTlhl53t6R365hUkfaH/H+xcGgENTPSzAoe4WSDyM3sAWh2nDNM5niaqJq8azrXs/qfJOyW59jMPtJLg== X-Forefront-Antispam-Report: CIP:198.47.23.194;CTRY:US;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:lewvzet200.ext.ti.com;PTR:InfoDomainNonexistent;CAT:NONE;SFS:(13230040)(23010399003)(36860700016)(1800799024)(82310400026)(376014)(56012099006)(10067099003)(22082099003)(18002099003);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: 2aUol5hSRJ8R/hSGfu1X2SPFcPaveIkgrug7UndPvYGnpFV4sGklHy3IRvwNDs+Gsmug2+N829oCcUZATZ4MvOdKpuFvpELZ64T5EO5Vr+xNSJP9fbsWXc4bXj2JdllbThahLnd2awk/pWRjACksixPEDSdTm/O/75i7XO4fFnp9xXCYxsF7BFwWgF9D73U0KDe1x6ZqhC7SXgdopTNCKVwEn4TtmXFMPo4zp+ST1JcELDrI5Yay29ekxvQvVRsKfTXWkWFzyA6xYTEx+iRoDwyy+YfitNI5/JYb8In81dK2uUq3QvSjFb671QyyP0kBCFJ3h4RUcb8+sUHP4NlOazGZyEbsmqgHKZtz+j3QZadIlVE+Db+n6NDPN3ekJPTrCKK+VwjcqDrg2KYXvIN8jraPjYk9ICowEwnZwZAspfDLIvw99cHhvwUz+L/n/xWb X-Exchange-RoutingPolicyChecked: 2FV2sBAVi8iSOYXWXrRhNHHWduXS1zEb6RU9g4DgDTb2Xsl7IH/D9lSWxSAO4OqtG6icZfuXUgM59dOIQFznyWY7nk8QTxchSCoFbmE/xeOSlBCbGHyQ56mOaOtUPJjeJohsHtyslJswVeCUGeLbFywoT3XEnqFFLLSpRorCzTbaNAdIAQFlbPzOJh8ukSYLC66Z7pc61vSs6xiaizPzXpT+tt8Ddr+VADlXPUdguiEnxR2OQ5eRqF84FTmHtIdlQfFXYT2wWf9+3C3xWBmmJYQOImxd4EKBAlppjLZ+OvDbL4e1bSceKdhmoQUB2AXYUcOgCibL53Sw8gV5sXMu1w== X-OriginatorOrg: ti.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 10 Sep 2026 17:57:35.0313 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: f9103171-4380-434c-8267-08df0f64fe8c X-MS-Exchange-CrossTenant-Id: e5b49634-450b-4709-8abb-1e2b19b982b7 X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=e5b49634-450b-4709-8abb-1e2b19b982b7;Ip=[198.47.23.194];Helo=[lewvzet200.ext.ti.com] X-MS-Exchange-CrossTenant-AuthSource: SJ1PEPF000037B4.namprd05.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: IA1PR10MB6052 X-Proofpoint-ORIG-GUID: ZbaQYmSTJKNUpaY9feLqFHN1JbY8mqR9 X-Proofpoint-Spam-Info: AW1haW4tMjYwOTEwMDIyMCBTYWx0ZWRfX4jdyj50aRfGa Sc7lwz0HoVCH3rWAGw7DTnlvq1oc8BnA0P0t3wyzW8Q5QhbefNuE2fGlwlHMND76xHH3cGxYUZt xeVXSZMCd+9qVInHh35eALZk0CfvH/g= X-Proofpoint-GUID: ZbaQYmSTJKNUpaY9feLqFHN1JbY8mqR9 X-Authority-Analysis: v=2.4 cv=MqbHeGae c=1 sm=1 tr=0 ts=6aa2ef95 cx=c_pps a=vcXwJhCbSog8BousImPcCw==:117 a=WotqVVQAdb04rnGuttW3Kw==:17 a=6eWqkTHjU83fiwn7nKZWdM+Sl24=:19 a=VdqzKS8jKosA:10 a=s63m1ICgrNkA:10 a=V5UXEbMT0ywA:10 a=VkNPw1HP01LnGYTKEx00:22 a=Z8NIEmU8O1QQgoT56wFK:22 a=taLDd7a_hP9WKsMzeGRc:22 a=sozttTNsAAAA:8 a=4oUWx8CZaJwu3DmIChQA:9 X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwOTEwMDIyMCBTYWx0ZWRfX5SN/9AUCAdHE 2yY7dCI2d6cFmAeui/pvrOxP6RRunR3AQ8vFbtvCVeoAKe1MQZnUGL4F7e18vmSfLlzylSUP3NX 2pQIVxsZ48Aw6SfnfIX3kFlGVhVUMNJCW0MPNhua6+JSUFMj8fB2UGiMx3mGHlH5xnmxQDrwMJS heHseyk0xEP86AvXa/XbP218q2cnzS87u57iVV0aOBNFaHRHD8iriQSZUtMkZAH21xWqKXG9cyD tPaPDFrmtfGAbXSvD9kdVf3vyxsNjawMa7lxaa0xDWSV/VrBRMpNs72kirtgDAkBfMVNyE1Vmba aBmBHVvr2jJBBAWsErKaMBvw05bfNleMHz++5mHR7ybIujnfBI62VpOjtE0WSC9BEwxAUdR/JAE 2LM67Ql/2LN8OheJRbhvdbATEzy9CWd3lm04LzyrBcrzxVhLoju4ybbW6YXyp8DkbM1NEE5i+8n gkNb3k5/6yO6b7FE7Ww== X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1176,Hydra:6.1.134,FMLib:17.12.100.49 definitions=2026-09-10_05,2026-09-09_02,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 clxscore=1015 impostorscore=0 phishscore=0 lowpriorityscore=0 priorityscore=1501 spamscore=0 bulkscore=0 adultscore=0 suspectscore=0 malwarescore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2609040000 definitions=main-2609100220 Content-Type: text/plain; charset="utf-8" Similarly in how AES part of this driver, we are falling back to software when memory allocation fails (we get -ENOMEM), fix the AEAD part also to only do fallback when we fail only due to -ENOMEM. This is because we are doing memory allocations with GFP_ATOMIC in the beginning which might fail. Any other failure paths might have modified the data or buffers already. Doing a software fallback on them might give incorrect or corrupt results. Fixes: 37b902c603042 ("crypto: ti - Add support for AES-GCM in DTHEv2 drive= r") Signed-off-by: T Pratham --- drivers/crypto/ti/dthev2-aes.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/crypto/ti/dthev2-aes.c b/drivers/crypto/ti/dthev2-aes.c index a034c1c8f20ed..150ce65f613fa 100644 --- a/drivers/crypto/ti/dthev2-aes.c +++ b/drivers/crypto/ti/dthev2-aes.c @@ -1173,7 +1173,7 @@ static int dthe_aead_run(struct crypto_engine *engine= , void *areq) aead_prep_aad_err: memzero_explicit(rctx->padding, 3 * AES_BLOCK_SIZE); =20 - if (ret) + if (ret =3D=3D -ENOMEM) ret =3D dthe_aead_do_fallback(req); =20 local_bh_disable(); --=20 2.34.1 From nobody Fri Sep 25 16:02:52 2026 Received: from mx0b-0002e601.pphosted.com (mx0b-0002e601.pphosted.com [148.163.154.28]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 14CE54A68B7; Thu, 10 Sep 2026 17:58:12 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=fail smtp.client-ip=148.163.154.28 ARC-Seal: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1789063094; cv=fail; b=C/BaL/WTu2pG3LfJ/F1HtZKhGeqcJ58nB1Hk5y4Pnfz0f0LTIeRkKp64xc2I1SqzxcLa4sqc7yJiOqJNFWCO1grIPfKIX/4HG0n101blp5yWrMbRh5QVXVKAaTLFhUgq8ZWOwKBhOyZUL2huQkSzOPkq7AZanN995qYmRqnLJvk= ARC-Message-Signature: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1789063094; c=relaxed/simple; bh=ysoPploXnsuJRmYnZ19/V+M8zWYzeuUXCUMX2vd/iFI=; h=From:To:CC:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=P/4w+kou4V4TjfIjftUUMeNgyKmFnKgRRkw22MtcYdhM5MynaeIdss+VXdTA4Hafg4gIL78w1YKLd8zwYSX4TUcdB9LetVu3EBh8zXkTw3uMDGXjuv1wESYOVxcOWjr+6zkwbE7Wd0Xi/q2xaOpnmPMHl/OMlrakBjVbMYpuaMc= ARC-Authentication-Results: i=2; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=ti.com; spf=pass smtp.mailfrom=ti.com; dkim=pass (2048-bit key) header.d=ti.com header.i=@ti.com header.b=X7Th8BQq; dkim=pass (1024-bit key) header.d=ti.com header.i=@ti.com header.b=YRDOs2iP; arc=fail smtp.client-ip=148.163.154.28 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=ti.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=ti.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=ti.com header.i=@ti.com header.b="X7Th8BQq"; dkim=pass (1024-bit key) header.d=ti.com header.i=@ti.com header.b="YRDOs2iP" Received: from pps.filterd (m0374955.ppops.net [127.0.0.1]) by mx0b-0002e601.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 68AGEWqT3808363; Thu, 10 Sep 2026 12:58:09 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ti.com; h=cc :content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s= proofpoint-05-2026; bh=IioPKfS4scmDQFvt8IjnJCzYXdhpHsv53wGTOOthe AI=; b=X7Th8BQqfDJYic3CPL4Mtuyt32XC1VtqqOo13a3GVb/Jn4ArOPoSS/6KE vjU/Rc2Izx9i+lrk6PDdq9kaIvQ8IPaTofIPGcy27MbNqKR+XC3GfTaLdEVae6jX HqkFsrO9UHZfgcNTDfkEFK6u6ztkSHCMEO60xP9uip11L3WkuutdzjqLeknm6Eyn yKkWiMs6Fy5dsBusYn/FIKrJkFe4I1eBo4YC4kFzj4aRTeFP8KqfCb6aCEsK6sHY Remb8+FciOwazzmGEbaGVczJ67B4EZqKLr01ky1FNbdqJoXjYzS/R2wPd28C26YY gel12bRNxGi8DB5mVNB2QhEsOhVWA== Received: from dm5pr21cu001.outbound.protection.outlook.com (mail-centralusazon11011046.outbound.protection.outlook.com [52.101.62.46]) by mx0b-0002e601.pphosted.com (PPS) with ESMTPS id 4gkyw9gp74-1 (version=TLSv1.3 cipher=TLS_AES_256_GCM_SHA384 bits=256 verify=NOT); Thu, 10 Sep 2026 12:58:09 -0500 (CDT) ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=gupbi5zl9g3U+WylQYPRlmahq8a2Z5SqhLVCyeGnqFyO20zbRmySXYHyjHgRZespKtXqc9edIjmrAXxrOOVqK2Cxlr9zh2tBrLUc37Rt1duDbIxhnLOTv1hLDMdB5lln56nIEzC8qz/outQc8Yt2VCunUIf2OeSDksq9QpOHdXU+mZ3murCv4CcTjGTDd9wjIaNR0mKI6Z5C8RUQ6V8wDYXtQ12HwqfHbWaQGygd0M7J69AtyHlrc7NZTnpWYgH+X6rIVVSPY08/7MgKfnpcC4d+58gMr+FpvnxbNXupWhPfCqMRbzW/+zg14TLgAAtstobzeZw4WWrzr/3erIAyKg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=IioPKfS4scmDQFvt8IjnJCzYXdhpHsv53wGTOOtheAI=; b=dl0+Hti/duixUra9kZ90Iylo93NRqqgzLGR2nKyJzq4N7xRPpfXfP6dEVzekyP/SvjI8IrjZiA1hx4PILVqZ3KZamN7z55iqk93TSt4ZdnnmJp2XB2xmuLYdJ/qTzHN8DrQ5C70ZUmRGsrrqgJYX0EMBBN3+w3q4VLqb42hWmfSJhghqO7tbURsfMw1GuzzBqRaSBtgiKqzn0DqLn9G04ZEUjs1BO23zsq+vl17FyjEaUDPb9IgFjwi1jkNslFqcfeqXU8o2qevBXoiwputn0+WYOSpDBp1AkjPxVy4lgaQ3wNj+s2lG/gQM+w4C0ZqxOmybf63izS1KyaeJ4SuB6A== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 198.47.21.194) smtp.rcpttodomain=gondor.apana.org.au smtp.mailfrom=ti.com; dmarc=pass (p=quarantine sp=none pct=100) action=none header.from=ti.com; dkim=none (message not signed); arc=none (0) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ti.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=IioPKfS4scmDQFvt8IjnJCzYXdhpHsv53wGTOOtheAI=; b=YRDOs2iPGrZVhSZNSvLG8E8tCE8LaJzpho7YfePQhfo9X7VBL+EMOqY2et9Uh+D9rd2YChja1Xmro/P2CO4euGNtxS4pYG8whg0QRRH7144kdpuYIRpu507nR1jN5jUEfGE753uzPwFOVjL4TB+CLcQQeWmZDVaYS0kaBOEdeKw= Received: from MW4PR03CA0011.namprd03.prod.outlook.com (2603:10b6:303:8f::16) by CO1PR10MB4657.namprd10.prod.outlook.com (2603:10b6:303:96::14) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.21.406.7; Thu, 10 Sep 2026 17:58:02 +0000 Received: from CO1PEPF00012E84.namprd03.prod.outlook.com (2603:10b6:303:8f:cafe::7f) by MW4PR03CA0011.outlook.office365.com (2603:10b6:303:8f::16) with Microsoft SMTP Server (version=TLS1_3, cipher=TLS_AES_256_GCM_SHA384) id 15.21.382.12 via Frontend Transport; Thu, 10 Sep 2026 17:58:02 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 198.47.21.194) smtp.mailfrom=ti.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=ti.com; Received-SPF: Pass (protection.outlook.com: domain of ti.com designates 198.47.21.194 as permitted sender) receiver=protection.outlook.com; client-ip=198.47.21.194; helo=flwvzet200.ext.ti.com; pr=C Received: from flwvzet200.ext.ti.com (198.47.21.194) by CO1PEPF00012E84.mail.protection.outlook.com (10.167.249.59) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.21.406.5 via Frontend Transport; Thu, 10 Sep 2026 17:58:01 +0000 Received: from DFLE211.ent.ti.com (10.64.6.69) by flwvzet200.ext.ti.com (10.248.192.31) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.2562.45; Thu, 10 Sep 2026 12:57:06 -0500 Received: from DFLE211.ent.ti.com (10.64.6.69) by DFLE211.ent.ti.com (10.64.6.69) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.2562.45; Thu, 10 Sep 2026 12:57:06 -0500 Received: from lelvem-mr05.itg.ti.com (10.180.75.9) by DFLE211.ent.ti.com (10.64.6.69) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.2562.45 via Frontend Transport; Thu, 10 Sep 2026 12:57:06 -0500 Received: from pratham-Workstation-PC (pratham-workstation-pc.dhcp.ti.com [10.24.53.205]) by lelvem-mr05.itg.ti.com (8.18.1/8.18.1) with ESMTP id 68AHv52M3764019; Thu, 10 Sep 2026 12:57:06 -0500 From: T Pratham To: T Pratham , Herbert Xu , "David S. Miller" CC: Sebin Francis , Manorit Chawdhry , Vishal Mahaveer , Praneeth Bajjuri , , Subject: [PATCH v4 13/15] crypto: ti - Correct AEAD tag operations against dma cache invalidation Date: Thu, 10 Sep 2026 23:26:17 +0530 Message-ID: <20260910175619.2122149-14-t-pratham@ti.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20260910175619.2122149-1-t-pratham@ti.com> References: <20260910175619.2122149-1-t-pratham@ti.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: CO1PEPF00012E84:EE_|CO1PR10MB4657:EE_ X-MS-Office365-Filtering-Correlation-Id: 74346524-a579-4236-5861-08df0f650e41 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|82310400026|23010399003|1800799024|36860700016|376014|10067099003|56012099006|22082099003|18002099003; X-Microsoft-Antispam-Message-Info: qCzpTiBLx/SClSAL3yqrv9bkhDSa8Ue/IND6tuJVu6fndZijVRmKNsjQlvaYamYu3W3FGc0hRzKADST1rOwyxBENyQSEdl5Uzb9wH4gtooHef3UAY4RrCR3clNADZG/xYc5IbDCwomHH5iC+SsbHp1drJH+Q4VW10BRgVky05KO7qhuGyOZeKT0vfxzu0vFN0gKVF776UZlO5CGWvwGQyfXhJfoe/PipogPFv5sN7W92E9tbmZgB8wOrMwBqEEWwMRo4a7h4aEMqA5yDmYbika28ey0Uslgw8ThmlHWF9eVvlQCDm0HYfIfyPPN7XEYdD2musasCXGiC72JplsaXUh4D/vEvVFQS2kQTJaX/uzKZH1kDPSEDp5a5jX80wfvIkZc82aFCw+/oU2j3Xoo9uATqZMKHueCRYlxyfcLrMd7CiDbQUEliqm5effGO43EyMFjesSzX94093oNkWElACJHDU43P0VAsPt3yN0yz9ES9iNoThQQNalRF1RXQ2CPJsx5g1g/zP2zrOOuhMk3cDUrcR5YSBN9xpHK7HatdC6sAm+zgsB/gq5KOkf2ifD5ehX1o3iga/ZrHYce1a8LcbjmM87Vn74dWGPZ+b82G0cubG26u6C9sPBhW6EimSYn/r9Dh7OlVYOMC/VvqGKjTQUlZa9es7qY7ta5abrdjBAeKL5Qj6YZMWaLyIJe8xqS0/aYgJvVQ1wpw5vmhpu69Zw== X-Forefront-Antispam-Report: CIP:198.47.21.194;CTRY:US;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:flwvzet200.ext.ti.com;PTR:ErrorRetry;CAT:NONE;SFS:(13230040)(82310400026)(23010399003)(1800799024)(36860700016)(376014)(10067099003)(56012099006)(22082099003)(18002099003);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: HA1UhxDpni0Vfdxb3GCi8tnXIPuMQYVRFkeCHyCmPBAsyJuNu9cqcPadg890TOgue9vKJi03ztPIb1N14o0IclDvtHv/ccKvYy2pmQNq1vAvb9uBBVEWnBW0FaFDw+FeS7W9iO80u9hzx4sXai4z78ceT/2SwTAXO7S5rgcNbG7UaTYEz8P4swhclPNCDobpfATFbHTuW01s024/013fy54eCR9KREEPDRAWsUTtI+WdAD9Z+MqJJ9MpGxw6SRpvsI6lUEpLcrIf29jg2GFSWaS2OEmH70QqDP7qT083ulnRh8yI9o/9GJgh34EvOhNK0LO9HmcZ4X15RxnK0sFw1oI0/P9L36wjFpSUolqgkETp2IeRqMXmnDZs2ai4eNEkW1yHLVlisJnW7lFTj3NoeWKbzdYFoptu9vpLU7T6iKGf4oZSmA4JsElf6Jx8HSDg X-Exchange-RoutingPolicyChecked: DRhh69TF5NyFJf4C3mYbVAakZIMUoTdMiYw8JgFO6EIc35dnAcuRkw9liCm47QiBJYtIwaqte+9Z8LZ18Q0RCOSQOHjXPa/XS8HsE38SXr2JrBtmiCy/rIF/Vs5wgdSz6ZT2Hpad0TfNr0/Fgz1uHZKbW3G9XUyFLRD6L5t70CwQQ6ibbAMoG8BjpdmZzTHLFEoL3swJiClG0EmxqahdBTa6GiZoWYaPWA5HWuE3okVHUwurYpXdh9HJjxzX36qYsYymmVD3q+Hu2cVtSoFw2aVcYEt5lcc9Es1Dd3C0rt8WgynbK0P0O/ZzQLHPNMxLtJzccpUXLtA/mczHlxtSsg== X-OriginatorOrg: ti.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 10 Sep 2026 17:58:01.3757 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 74346524-a579-4236-5861-08df0f650e41 X-MS-Exchange-CrossTenant-Id: e5b49634-450b-4709-8abb-1e2b19b982b7 X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=e5b49634-450b-4709-8abb-1e2b19b982b7;Ip=[198.47.21.194];Helo=[flwvzet200.ext.ti.com] X-MS-Exchange-CrossTenant-AuthSource: CO1PEPF00012E84.namprd03.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: CO1PR10MB4657 X-Proofpoint-Spam-Info: AW1haW4tMjYwOTEwMDIyMCBTYWx0ZWRfXxuHU0OrLe6wF 4E2QBqmC6zhq3NiH5mbQTS9m3AOIGqm49rykQhSYILcFGdEch2IdkM8C7KhX86pgVgukMqdMpOa DNI0bXyz9v+FH892OWvMc+L0VBrkKRg= X-Authority-Analysis: v=2.4 cv=ON6yTiaB c=1 sm=1 tr=0 ts=6aa2efb1 cx=c_pps a=m/LAOfpIcXRJv0ug5Ru3ZQ==:117 a=iwqwCZQqcuTv3JOpYdM7/Q==:17 a=6eWqkTHjU83fiwn7nKZWdM+Sl24=:19 a=VdqzKS8jKosA:10 a=V5UXEbMT0ywA:10 a=VkNPw1HP01LnGYTKEx00:22 a=Z8NIEmU8O1QQgoT56wFK:22 a=fPAWb5peG099m5CrUpKH:22 a=sozttTNsAAAA:8 a=BSBB0G2mMgAadyb2BJkA:9 X-Proofpoint-GUID: BhDAHAzh4LzEU1UQzar05I4brt5kiYgW X-Proofpoint-ORIG-GUID: BhDAHAzh4LzEU1UQzar05I4brt5kiYgW X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwOTEwMDIyMCBTYWx0ZWRfX9pyULTpyvKy/ SEtwILABpvDHIIm89Q7W51bpj2/+WzNDdphX125pb3G0CS5LL/u9mOVeMG3btQn6I9x9l0Ts2gw Qx9nksiWlZh2IwsksWmeGBikRaBwmLbe5ksUy1BS7OK8DsDN9S+lnRllVzNjECSsUL0efKq2Hvs DlAcX/Aeb5tIrYa2Nw9Apro7JIOASdXy1YRCexz4OHg/oC5CnAD49WmuW8FXWaF/yp2B48GzlWj T2swoW9vJkua7Tgzi/vQibfpqqu5RWmSyYxrcQ8RfTLp+bgeRU0G2RAXcCmnZvtnf1X8Q1PiS1k 4zQXh+D335UwG1vbiGByyopDWX+Fgpq9z19cdp6qsDqDxr4Fht2zrpNzBwYE/omVaL4mAcrC0Ys QhtjyMO5g1EHK4h2QN13MnY0WFSjFxYhjhRBcGhuRbGgUZEi8OCJ/AzihAgH1MN9sQxqiDeiwgw 8B22cl4RTnzF3sHm1vQ== X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1176,Hydra:6.1.134,FMLib:17.12.100.49 definitions=2026-09-10_05,2026-09-09_02,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 impostorscore=0 adultscore=0 clxscore=1015 phishscore=0 bulkscore=0 spamscore=0 suspectscore=0 malwarescore=0 priorityscore=1501 lowpriorityscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2609040000 definitions=main-2609100220 Content-Type: text/plain; charset="utf-8" There are two issues wrt tag operations (tag read/write in AEAD algorithms) pointed out by Sashiko: 1. dma_sync_sg_for_cpu() before tag operations always uses rx_dev. But dst is mapped with tx_dev in case of inline operations. This is "technically" a no-issue right now as both devices use different channels from the same dma device. But it is nice to be correct. 2. dma_unmap_sg() is being called after tag operations. But between them, there is no synchronisation step. So tag operations writing TAG into the dst scatterlist could in theory be lost in the cache invalidation done as part of unmapping scatterlists. Now, in the current code, we can correct both of these with some conditional logic and repeating the sync (this time with sync_for_device). However, it felt more elegant to move the TAG operations to occur after all the scatterlists are unmapped. This ensures all buffers are properly synced as well as avoids unnecessary repeated syncing of caches. Fixes: 37b902c603042 ("crypto: ti - Add support for AES-GCM in DTHEv2 drive= r") Signed-off-by: T Pratham --- drivers/crypto/ti/dthev2-aes.c | 25 ++++++++++++++++--------- 1 file changed, 16 insertions(+), 9 deletions(-) diff --git a/drivers/crypto/ti/dthev2-aes.c b/drivers/crypto/ti/dthev2-aes.c index 150ce65f613fa..150ba73776aa9 100644 --- a/drivers/crypto/ti/dthev2-aes.c +++ b/drivers/crypto/ti/dthev2-aes.c @@ -913,6 +913,7 @@ static int dthe_aead_run(struct crypto_engine *engine, = void *areq) struct device *tx_dev, *rx_dev; struct dma_async_tx_descriptor *desc_in, *desc_out, *desc_aad_out; bool cleanup_tx_chan =3D false; + bool do_tag_ops =3D false; =20 int ret; int err; @@ -1136,15 +1137,11 @@ static int dthe_aead_run(struct crypto_engine *engi= ne, void *areq) ret =3D 0; } =20 - if (cryptlen !=3D 0) - dma_sync_sg_for_cpu(rx_dev, dst, dst_nents, dst_dir); - - if (rctx->enc) - err =3D dthe_aead_enc_get_tag(req); - else - err =3D dthe_aead_dec_verify_tag(req); - - ret =3D (ret) ? ret : err; + /* + * Need to read TAG registers if data is submitted, even in case + * of DMA timeout, to clear the hardware states + */ + do_tag_ops =3D true; =20 aead_dma_prep_dst_err: if (diff_dst && cryptlen !=3D 0) @@ -1160,6 +1157,16 @@ static int dthe_aead_run(struct crypto_engine *engin= e, void *areq) if (assoclen !=3D 0) dma_unmap_sg(tx_dev, aad_sg, aad_nents, aad_dir); =20 + /* Do tag ops after scatterlist unmapping syncs caches */ + if (do_tag_ops) { + if (rctx->enc) + err =3D dthe_aead_enc_get_tag(req); + else + err =3D dthe_aead_dec_verify_tag(req); + + ret =3D (ret) ? ret : err; + } + aead_dma_map_aad_err: if (diff_dst && cryptlen !=3D 0) kfree(dst); --=20 2.34.1 From nobody Fri Sep 25 16:02:52 2026 Received: from mx0b-0002e601.pphosted.com (mx0b-0002e601.pphosted.com [148.163.154.28]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 14D9D525A6C; Thu, 10 Sep 2026 17:58:12 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=fail smtp.client-ip=148.163.154.28 ARC-Seal: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1789063094; cv=fail; b=Eca0Vm+JNZsRyjQL930q48P8CgiFr2pvjNjtyE80TfYnSxMtCmKyaeeJevJ7AkvVuNxeDJ3bjSv6F6vwF/1LYO9wP/iAevFtDYvc333c2EoVuOU5DZ4m0LO8dhrFJ3Wl/i3uV8fp2+BLEalzsG45RfKFedoFfecwYn2GhpWBhUg= ARC-Message-Signature: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1789063094; c=relaxed/simple; bh=Xj5n2GVqsJvcefGEwXsaxhsOWs63LUfndOX4wp+k6c4=; h=From:To:CC:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=RaJRQmNCdQ7gKkKaaBGakOLiLB2HMdYJQGeWewoGcsN4csNSHKaGX9CVLL4Mmtp4UslPm/m9d3rCaAZ8yHFQYEek9ZpUEpxeFC0DsoX9EknQ94VIcZ64Wt0LRDjaUSNx4n7ly5UHy+yz3n9bijgw5QCUjEq5MFuwjDWmEntyevY= ARC-Authentication-Results: i=2; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=ti.com; spf=pass smtp.mailfrom=ti.com; dkim=pass (2048-bit key) header.d=ti.com header.i=@ti.com header.b=G+Jlsce3; dkim=pass (1024-bit key) header.d=ti.com header.i=@ti.com header.b=Pls2wD5C; arc=fail smtp.client-ip=148.163.154.28 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=ti.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=ti.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=ti.com header.i=@ti.com header.b="G+Jlsce3"; dkim=pass (1024-bit key) header.d=ti.com header.i=@ti.com header.b="Pls2wD5C" Received: from pps.filterd (m0374956.ppops.net [127.0.0.1]) by mx0b-0002e601.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 68AGGFgD3546631; Thu, 10 Sep 2026 12:58:09 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ti.com; h=cc :content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s= proofpoint-05-2026; bh=FYCkMb8oUWMLmdB4yXRpk+rbOGGjOkqEpnuQX29Sv MM=; b=G+Jlsce3aqdGPhXDhDjDC1Y9kTS7MnNm+4Mf9VNWqX89fPt5YOGi0hM7b m+ba57zn6BvXVkhFxWFJZM9jAzTCp1WFW64V+l9KjQsRUj5287+F5pueBF0BNlw+ 5uOkBTfwpt7OBY+qgIWSUNE5Kn613bQ31SDV2ataqZRACh60Vv1Zp57eVsju5Yu9 VZWaD8d16zUpOMej+ZgAfcy91V78A+O+CsKcdgLRzQxUadzEwrrKOvJKmQyAcUqU i1y4aztKoOvZy1ofN2j0OXYAyKQya4wj5wPjBg4JuP+G63ziSwcxiKbCUSfszLKD rKhEH92Zow2MzoSNFznKyrIZJlWjQ== Received: from cy3pr05cu001.outbound.protection.outlook.com (mail-westcentralusazon11013002.outbound.protection.outlook.com [40.93.201.2]) by mx0b-0002e601.pphosted.com (PPS) with ESMTPS id 4gkyx20nbc-1 (version=TLSv1.3 cipher=TLS_AES_256_GCM_SHA384 bits=256 verify=NOT); Thu, 10 Sep 2026 12:58:09 -0500 (CDT) ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=AoC17BtsmYQe2mwJELmipoVAzVwN1QJtTXXj7G55Q4PSmybKaKKIVU5qZm0woa+VuLElCTGyLGSxaz+yBn7P+9lCpyNKRVAAz32eEwCK+Geahq5SW1gcj5vnqSpJHKRfd8C0X5QZVv5HvlpLSYsq8tunZQheBrfySuk1aZ4QuLxvBe7MQOZIzZDxcsO8GvgIRkjZFT9/uClIq5+fTymq+w0JFNilKu/Pzs6ljCRS/mvBUq0oQRjC2vffPMGmtB6nD1NFdVKlulUnYuoDpe8PQMv0xR2Q7qqAbkTDsh3UJo+oiaJV8Q3BfSkmsc7sTVRbgC7gi9fyXq0qtBF3MOfquQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=FYCkMb8oUWMLmdB4yXRpk+rbOGGjOkqEpnuQX29SvMM=; b=wRmUQmcchb92PfAYn4FKw7Alu2ialQxoriN2BqnSgfq2mRVb4ER4nZhnfF+UyDdwGsAr9yOJUMA9N4dQ1FHj2EojIOpXbqVhZfToZd2wDesZT9zdkQFsZFOyMiWFlkBxSFob6ryWrDqYq/J0ZksvXISbxYisZ+fblCEu7WFws0y1CAsgHCq8XYJU0IYsn0i+tw/MWMKcJprU4yxadyrjsp1WrjddQ2VHf0uikz4bY7wYBEpS76W2bAZl9TOT0MKTt7/KwknxkYiYzATDoNyqd0xb5Yh+xBtWLcjJ8sHFCWJSH1nsgPGMYwiD1QKhNrm+jWLv2zZanXvTZ794D8Yh4w== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 198.47.21.194) smtp.rcpttodomain=gondor.apana.org.au smtp.mailfrom=ti.com; dmarc=pass (p=quarantine sp=none pct=100) action=none header.from=ti.com; dkim=none (message not signed); arc=none (0) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ti.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=FYCkMb8oUWMLmdB4yXRpk+rbOGGjOkqEpnuQX29SvMM=; b=Pls2wD5C3iaHpURjakoAR4B7UmaTlIqulyQnt0b/qUbz5j+koccGUIQ2l5GPmh7XY9sC7XMcMKhjzNJgIPZkLb22LLhd/AfbIRZCx7dcxLhuQnwG3Zru1ptCS3idbjbLEm+lUGxeSa1ppfM2QMgGQ9/C4qk9y6yQ3V6u9kks/VQ= Received: from MW4PR03CA0065.namprd03.prod.outlook.com (2603:10b6:303:b6::10) by CY5PR10MB6093.namprd10.prod.outlook.com (2603:10b6:930:3a::15) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.21.428.5; Thu, 10 Sep 2026 17:58:04 +0000 Received: from CO1PEPF00012E82.namprd03.prod.outlook.com (2603:10b6:303:b6:cafe::37) by MW4PR03CA0065.outlook.office365.com (2603:10b6:303:b6::10) with Microsoft SMTP Server (version=TLS1_3, cipher=TLS_AES_256_GCM_SHA384) id 15.21.406.9 via Frontend Transport; Thu, 10 Sep 2026 17:58:04 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 198.47.21.194) smtp.mailfrom=ti.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=ti.com; Received-SPF: Pass (protection.outlook.com: domain of ti.com designates 198.47.21.194 as permitted sender) receiver=protection.outlook.com; client-ip=198.47.21.194; helo=flwvzet200.ext.ti.com; pr=C Received: from flwvzet200.ext.ti.com (198.47.21.194) by CO1PEPF00012E82.mail.protection.outlook.com (10.167.249.57) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.21.406.5 via Frontend Transport; Thu, 10 Sep 2026 17:58:03 +0000 Received: from DFLE209.ent.ti.com (10.64.6.67) by flwvzet200.ext.ti.com (10.248.192.31) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.2562.45; Thu, 10 Sep 2026 12:57:08 -0500 Received: from DFLE209.ent.ti.com (10.64.6.67) by DFLE209.ent.ti.com (10.64.6.67) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.2562.45; Thu, 10 Sep 2026 12:57:08 -0500 Received: from lelvem-mr06.itg.ti.com (10.180.75.8) by DFLE209.ent.ti.com (10.64.6.67) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.2562.45 via Frontend Transport; Thu, 10 Sep 2026 12:57:08 -0500 Received: from pratham-Workstation-PC (pratham-workstation-pc.dhcp.ti.com [10.24.53.205]) by lelvem-mr06.itg.ti.com (8.18.1/8.18.1) with ESMTP id 68AHv7WS2794038; Thu, 10 Sep 2026 12:57:08 -0500 From: T Pratham To: T Pratham , Herbert Xu , "David S. Miller" CC: Sebin Francis , Manorit Chawdhry , Vishal Mahaveer , Praneeth Bajjuri , , Subject: [PATCH v4 14/15] crypto: ti - Change lengths in AES to u64 to avoid potential overflows Date: Thu, 10 Sep 2026 23:26:18 +0530 Message-ID: <20260910175619.2122149-15-t-pratham@ti.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20260910175619.2122149-1-t-pratham@ti.com> References: <20260910175619.2122149-1-t-pratham@ti.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: CO1PEPF00012E82:EE_|CY5PR10MB6093:EE_ X-MS-Office365-Filtering-Correlation-Id: 578c19c1-fc53-42fd-7fec-08df0f650f80 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|82310400026|23010399003|36860700016|1800799024|376014|56012099006|10067099003|22082099003|18002099003; X-Microsoft-Antispam-Message-Info: SWPWVFcLsdUHJJePMpjKWTFApviAaRcJoRBtErp0mks3YOy5kEscNqgVhR7AGuHymuAgwpH+5KDqFan0DoMXHcUAdsKca/sfzN/2uD19qeaPnb+f8+Xl1a0Mwrgw9WI1RKDfVbM8w012fkWMjk1cVepFGWZ9eJmfAKW8YqaKUAC5RMxrhTzrjm9UeABPyl31logoa6aNP1bCw96RUa1xX9VJJrBzzGO5k8/sZSZ9twkqNmWBr8t5ROY4zGgg5QiDO9GOrwx3iKGdphOnVzqnKwiIkEq8t9G+XfkluO1hHOoJrZbmco4l4g7jc5yRi0AudnzXeQ5XGE4bDDvKKhbL6ddDCEP89WoNO6QMOlBG/8vWluQUeHkpN01iqNs9NG7PHEBvpZfRrjnQ0r9NwAq74NEeLr9G/iCSHjXBA7e4znGwYfiY74TgwKdQczFyumMEbtJ8liNB9KggsvAT4x+pvPfVvazPht7zm9NYroHByxwGF99N5fv8fx3S8Q1FOqzephIJvL3mHQcOYe4QoEwArvSLRqgWKA8pl4crpUbcAprlupYN+OtiXJ4g+K9Kuum3ZFaq/fOzTRCsXvGul/keYsZ88pviecZLX7VLI4uUrbOJ1s0xbVjjLOn30EuQfQxdIEMlWhnw5rbrreZZi4EFFaHPGACSp9Y9cP/iOWCEM7HIfkTtg4G7LdcFCeDXwKhsuqPCodS7XebCWzRjFvJJCw== X-Forefront-Antispam-Report: CIP:198.47.21.194;CTRY:US;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:flwvzet200.ext.ti.com;PTR:ErrorRetry;CAT:NONE;SFS:(13230040)(82310400026)(23010399003)(36860700016)(1800799024)(376014)(56012099006)(10067099003)(22082099003)(18002099003);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: duq335/WxjVcrI76RLkbSm2UAJcIA2KZFDDe0BbUX6r0Q8VPOZlR1iVcXmWUKgtoKN0oLe1HCuMOrT80e5Kyd9ofJCR7VrliIl8Zs9O1eVTR8m/+m+IxL3XaNopdSIXfiZ0GHbQ9Zt23sHEBc2qX7kt5yDFvlnfN/yLiL+QYwKRticlB9yeD35PUut7PjQxfj5MCUqNMHV0jG4jhkve0ros0MpUCaS4gtmuGmg1aFrqXxvwJqlN6ueYuJ5WKaSLy/FQUH7bFbYmP5mX4YTUv3UU0ZylFSYAR8g+dogspm8xBCwTVXBKyeJ7DSvgGplArch2Z9OQEOtHpjuYg+pN8nbDu+tHLv4DyQJl1he10lIlAmSyEHIHyJYJRpruWnbXPRwGcuDthOT9EwdcFid/zWl8aUI9nZ93xFwHNfKlf/fG9cefNuDVv0wTZR4W9wIFp X-Exchange-RoutingPolicyChecked: MQ6F/AJKzsMx4xfGaXR/3KR9V22FjjK81GNs2hfgy1BmVMzC3ZlqZuSWa9qElcci59pTVFARuCi/AUAsYwFnT8o7eJzUfNYdiG4JFd01RxQ9NYIaWVhgmg/KnItVXI1XFrxLUm7+3qoHcz+3tR+t23eUAm93VQNZq3mOuhJb5L1tq23XjSIK+vR0YyMzpIzQ5g101jd9YpsXBq3M4gizzT7+7LEfWsbh0mqFgpxzGfKnolD3QCibB/U3/moZnHTOENBg+DrqozIlFEhBdsplMzusuecePh1pgmTYVUbZzfJvBZPKQxzf54IUpdto7Yn/2C5OksfnYAYcxuMKGUiL7Q== X-OriginatorOrg: ti.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 10 Sep 2026 17:58:03.4671 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 578c19c1-fc53-42fd-7fec-08df0f650f80 X-MS-Exchange-CrossTenant-Id: e5b49634-450b-4709-8abb-1e2b19b982b7 X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=e5b49634-450b-4709-8abb-1e2b19b982b7;Ip=[198.47.21.194];Helo=[flwvzet200.ext.ti.com] X-MS-Exchange-CrossTenant-AuthSource: CO1PEPF00012E82.namprd03.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: CY5PR10MB6093 X-Proofpoint-Spam-Info: AW1haW4tMjYwOTEwMDIyMCBTYWx0ZWRfX+LxjczI1DH6q SRpqjCCBGrn6R4nhv0ohvTy4v1s9HRRk7YnZrlGCoXkELUVTG24m7YPkMoV50NbKl/WqbmcuqEb u9E9yiAMo+4G08J94gL6wk1CuwuyrvY= X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwOTEwMDIyMCBTYWx0ZWRfX8geTzU3fWtJO sL2IHWFkmASFEaS0jCWOcxoOTyvS9QG3K1oLYf/9b+d15mY7tmcF5ndMjnKksl6uk7XZR/9bz2S Fayh8LIaE55vzEJKnGB4h1MBNM0nITaqjYIfPBSgzbzYo0XHD4ej8vfLwv8wAQto3ShqK15tU1W UB9JzhkmmdBUbOJjxkx/7f4Tcav6otS4+NevLMIny9tv2VfN3DWxVjbT1al4zg5gchEKhIl36VO O3pvN/202IEhuIB4rQevWeoOjK4JxDibvuOgnhn0tS8HkPgiHsWuLnvipm7upEBqVRaMHyKYCFk 8z0M72hZ64Rp5AL58ew1rtVUJKz6s2fjacijdgoAbAHyhbwvqiDmt57RidXL/oBgUIJPD5A20va jrKDYqvt1naiYbb3LFYYcAyZoAGASAxZ9Jl2mHUymjls6U33XuS07eJIZye3WuG1e1+QM3xzJgv MlFykcmv+DXro7PHgDQ== X-Proofpoint-ORIG-GUID: 63D2gxNp5e_txOo1mMGfXOsiv8SEXems X-Proofpoint-GUID: 63D2gxNp5e_txOo1mMGfXOsiv8SEXems X-Authority-Analysis: v=2.4 cv=UJ5Ijyfy c=1 sm=1 tr=0 ts=6aa2efb1 cx=c_pps a=IyT5loBvHZYA5YPQi3EYsQ==:117 a=iwqwCZQqcuTv3JOpYdM7/Q==:17 a=6eWqkTHjU83fiwn7nKZWdM+Sl24=:19 a=VdqzKS8jKosA:10 a=V5UXEbMT0ywA:10 a=VkNPw1HP01LnGYTKEx00:22 a=Z8NIEmU8O1QQgoT56wFK:22 a=jwouBfj2j3NM8CExmVVE:22 a=sozttTNsAAAA:8 a=sQKIhDeqCqRtbGPzpkwA:9 a=zZCYzV9kfG8A:10 X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1176,Hydra:6.1.134,FMLib:17.12.100.49 definitions=2026-09-10_05,2026-09-09_02,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 bulkscore=0 malwarescore=0 lowpriorityscore=0 spamscore=0 clxscore=1015 priorityscore=1501 adultscore=0 suspectscore=0 phishscore=0 impostorscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2609040000 definitions=main-2609100220 Content-Type: text/plain; charset="utf-8" Change cryptlen from unsigned int to u64 to avoid overflow when added in padding length calculation. Fixes: 35645ca63caa1 ("crypto: ti - Add support for AES-CTR in DTHEv2 drive= r") Signed-off-by: T Pratham --- drivers/crypto/ti/dthev2-aes.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/crypto/ti/dthev2-aes.c b/drivers/crypto/ti/dthev2-aes.c index 150ba73776aa9..9b982ca4a7730 100644 --- a/drivers/crypto/ti/dthev2-aes.c +++ b/drivers/crypto/ti/dthev2-aes.c @@ -326,8 +326,8 @@ static int dthe_aes_run(struct crypto_engine *engine, v= oid *areq) struct dthe_aes_req_ctx *rctx =3D skcipher_request_ctx(req); struct dthe_data *dev_data =3D rctx->dev_data; =20 - unsigned int len =3D req->cryptlen; - unsigned int pad_len =3D 0; + u64 len =3D req->cryptlen; + u64 pad_len =3D 0; struct scatterlist *src =3D req->src; struct scatterlist *dst =3D req->dst; struct scatterlist *sg; --=20 2.34.1 From nobody Fri Sep 25 16:02:52 2026 Received: from mx0b-0002e601.pphosted.com (mx0b-0002e601.pphosted.com [148.163.154.28]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id BA5E04BA9F8; Thu, 10 Sep 2026 17:57:49 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=fail smtp.client-ip=148.163.154.28 ARC-Seal: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1789063073; cv=fail; b=cHTn1869ysYOl3QBkv2hB9JEjLVNwsOKbs7OQwa61qmAYWE1NlwYb9qg4fNYsuRO7TnR5NkmIwBHp+HGUtmzpNlE2Uw/R//PZ6MYyM5fM7j7TjdQcwc+/UadTwDDo+tOP7f6bVhGq9nxjkNrTBY1rtGR4K4i0vP37ZJNlkVqJiw= ARC-Message-Signature: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1789063073; c=relaxed/simple; bh=MmcuVvXYaMjero/AwfUHOm7TRDKEXBVAlucY5yNCKhc=; h=From:To:CC:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=YPtJV3d8o7NfHvkM3oaX0n9Gg+n/ogdCkWYMiCZmYuX4awQn7RyZXLG2zDgIR2EzyCoC3TBmlftQ1iGBW1Ne3Akc5wQZzNbad/0DvhPwJml8ya+OqmlHGPHTMtEyRsVxMQFeK+w6xRQLKyxf3E7z8pJr7nq1Y43ODGhyCZVd4nU= ARC-Authentication-Results: i=2; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=ti.com; spf=pass smtp.mailfrom=ti.com; dkim=pass (2048-bit key) header.d=ti.com header.i=@ti.com header.b=XHEM3YNZ; dkim=pass (1024-bit key) header.d=ti.com header.i=@ti.com header.b=PK6/14Bk; arc=fail smtp.client-ip=148.163.154.28 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=ti.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=ti.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=ti.com header.i=@ti.com header.b="XHEM3YNZ"; dkim=pass (1024-bit key) header.d=ti.com header.i=@ti.com header.b="PK6/14Bk" Received: from pps.filterd (m0374956.ppops.net [127.0.0.1]) by mx0b-0002e601.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 68AGGAtK3546582; Thu, 10 Sep 2026 12:57:45 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ti.com; h=cc :content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s= proofpoint-05-2026; bh=PqnJREAsaDSaK59bXYGlEMRqdohLFwctOvTZ9KWYh A0=; b=XHEM3YNZyIZ2r6QtdFWUMq0oYPgNffv1+bdDFaxdxvQjm0Vw5YwzyAB9b hsY6CcMLTKqIF2Viw+pckCT4Ys8BxB9rpTqVSeeS/qtagXJfwqwcK4gdfVq82Hap ZYNI13F0fVsJu/I5wOosGpFBBtDqJMhvvvORuRrCOb+EYbO4G0A4DZqz3y4PrL0O +M3hKIQdkJhzQSrrmjVCnlbbr9m+dPODaf3BZEWZc17kLpwD3rK9LzvRuBX2Bnjg wkvB/KeS+154T6GN3brVzl31jU877bLQABxak5vsgY/TCy3KgXK4FBvpjBf60xqS m0hA/UCYzcUOFecHGj3GzxHzr43kw== Received: from ph8pr06cu001.outbound.protection.outlook.com (mail-westus3azon11012058.outbound.protection.outlook.com [40.107.209.58]) by mx0b-0002e601.pphosted.com (PPS) with ESMTPS id 4gkyx20n8k-1 (version=TLSv1.3 cipher=TLS_AES_256_GCM_SHA384 bits=256 verify=NOT); Thu, 10 Sep 2026 12:57:45 -0500 (CDT) ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=gxdVVr5b6298ENv3q0/X+GQnlvyUyq5Ku0H1FeCpnDBcNy2tLpKxrqnai95CMeu8Rz3eaNrqqFp9vW6qDLxesp0rnUOTnedlLEyclHH9czx4D3e7fPOg+UNLfW3nNu7cBsiaSGB0VuMBxErXR6BXx73oJk0EjDCv6WcUxTKv4MX5Cbo8WL5eunRdxP+IyWU3GCuURepmJOgJodFqgsWHsIPuEdn5ek3jUvw/hQFhvqRPKLf3gmfgkTHkfSgpPBx7KBAIVnv8GJYjPsxtVKfDF7G17j3DoPkvXiUWnXJ4+fjtEvvVVFMImAWHL1niArgO1+H/stg1CTb81XYCNxIcZg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=PqnJREAsaDSaK59bXYGlEMRqdohLFwctOvTZ9KWYhA0=; b=t26boSjvdJ5c4KzhRPccdDrGaPdYINn8SoMmjfGozqMilCN3IUzfK3Dl6VhLuvM+9VCktHDF7++801rmZCDhRsO810ko1/AJfGv1mABOLZaqShRmtsQih1x96fzIL4rcZZtaMpplNtM4Nr8MbwN81oWtxOTRsM6qfTz6V8OEig668WguJV0vpbkw40J0wZFbZ0oo9ojvRhpHXkSzyyObtQcUIx0kyqysTB0a+c/Yj3ptlhQDZ2EOjqtfp7T4cm1L8dNwGIT61DqpD6YwkY/4m0F9VB7VjIhUf2zz1Qj1RISz3/G/5ODmaSjhOjSiWMCDWF+jqUoP+LlObaZwDZ2LLQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 198.47.23.195) smtp.rcpttodomain=gondor.apana.org.au smtp.mailfrom=ti.com; dmarc=pass (p=quarantine sp=none pct=100) action=none header.from=ti.com; dkim=none (message not signed); arc=none (0) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ti.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=PqnJREAsaDSaK59bXYGlEMRqdohLFwctOvTZ9KWYhA0=; b=PK6/14Bkbh7oH/hYO+tDIlJ34Ag+11e+8GGIVEDiwtgJ9e0dqHdpx4q84UNqH+CxlzP/vXfuq/TOYwijOuVol00ZSyNoJSk+Au5X2bUQjCQsUaQgdb9yu0Gd+yrpg5+7VLFxByj14uwvPqLJflWPc/GChwh8au78ybXbLzp5IPM= Received: from BN9PR03CA0385.namprd03.prod.outlook.com (2603:10b6:408:f7::30) by DS6PR10MB997848.namprd10.prod.outlook.com (2603:10b6:8:464::12) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.21.406.4; Thu, 10 Sep 2026 17:57:42 +0000 Received: from BL6PEPF0002256F.namprd02.prod.outlook.com (2603:10b6:408:f7:cafe::74) by BN9PR03CA0385.outlook.office365.com (2603:10b6:408:f7::30) with Microsoft SMTP Server (version=TLS1_3, cipher=TLS_AES_256_GCM_SHA384) id 15.21.406.7 via Frontend Transport; Thu, 10 Sep 2026 17:57:42 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 198.47.23.195) smtp.mailfrom=ti.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=ti.com; Received-SPF: Pass (protection.outlook.com: domain of ti.com designates 198.47.23.195 as permitted sender) receiver=protection.outlook.com; client-ip=198.47.23.195; helo=lewvzet201.ext.ti.com; pr=C Received: from lewvzet201.ext.ti.com (198.47.23.195) by BL6PEPF0002256F.mail.protection.outlook.com (10.167.249.37) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.21.406.5 via Frontend Transport; Thu, 10 Sep 2026 17:57:41 +0000 Received: from DLEE212.ent.ti.com (157.170.170.114) by lewvzet201.ext.ti.com (10.4.14.104) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.2562.45; Thu, 10 Sep 2026 12:57:11 -0500 Received: from DLEE205.ent.ti.com (157.170.170.85) by DLEE212.ent.ti.com (157.170.170.114) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.2562.45; Thu, 10 Sep 2026 12:57:11 -0500 Received: from lelvem-mr06.itg.ti.com (10.180.75.8) by DLEE205.ent.ti.com (157.170.170.85) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.2562.45 via Frontend Transport; Thu, 10 Sep 2026 12:57:11 -0500 Received: from pratham-Workstation-PC (pratham-workstation-pc.dhcp.ti.com [10.24.53.205]) by lelvem-mr06.itg.ti.com (8.18.1/8.18.1) with ESMTP id 68AHvAgA2794066; Thu, 10 Sep 2026 12:57:10 -0500 From: T Pratham To: T Pratham , Herbert Xu , "David S. Miller" CC: Sebin Francis , Manorit Chawdhry , Vishal Mahaveer , Praneeth Bajjuri , , Subject: [PATCH v4 15/15] crypto: ti - Change lengths in AEAD to u64 to avoid potential overflows Date: Thu, 10 Sep 2026 23:26:19 +0530 Message-ID: <20260910175619.2122149-16-t-pratham@ti.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20260910175619.2122149-1-t-pratham@ti.com> References: <20260910175619.2122149-1-t-pratham@ti.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: BL6PEPF0002256F:EE_|DS6PR10MB997848:EE_ X-MS-Office365-Filtering-Correlation-Id: f9841fd7-a1bb-407d-c06d-08df0f6502b1 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|36860700016|376014|1800799024|23010399003|82310400026|10067099003|56012099006|18002099003|22082099003; X-Microsoft-Antispam-Message-Info: 7QPHN1XG16i60Q/whxn1Eo1CbFI0xQ9ZeWPWmm7IZ/QWMEUFxGHWUAuwNF3lv51kd0gyqA37CPqDHBImN70sgTDM2+uxmLyH/CQ/uEJ7eT34wB3xqxiGuMqbcBl1X/RWxR1okwzqzB3nobIVs380cVb/JId/zDHX6ui86QopYwMg62/aDUfdi78a/poid6j72oE8IppkpK38li63i+cfK8cbvWC7MEdt2Rg1zSyNfgX1c4JdWhP7AzGBDEginuxyaEtOJisbBi+AMHF6oVofA58iLT6zaFqhR8FSsczI38vvMtWgIHIqXpyyAmKnCecUq53gMjBwEpsetxrQDFowZRhKvSoRZDLheYvNpzyVv+9ZwlwtUW0rvWnDJtDlUyChRQVRpp8gVbngvDXWw+IUnb13BEGBe6D6ht3QpPTrnIb8Ifw3IUhknI2l9nI8QKjQrK32CsXgv8+YfLM9e8cIVPMxLb4jK+usmYK7v7KQUBbXRzGknYkf9MblUMESPy+07+xWY9AhR9oHLhgcKtr3+KxtKNOti1083xgd8k7saYgEThNo25yYTQfXXZ3PVhp4k3LcbaBRcjlCcO3mHUDOp1z0hyhxgKaoSJ0O2w+Ro69CjM0mydsv4g99mY3JTXAn7R8mUYHh1ZMiivGsVA8uWjLA9NuAfsKwIq5u3XQYNdpiyDhmo+TDRA8nAkW/CrWdKMtRRDmXWpQ+Mf7rEm8gNg== X-Forefront-Antispam-Report: CIP:198.47.23.195;CTRY:US;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:lewvzet201.ext.ti.com;PTR:InfoDomainNonexistent;CAT:NONE;SFS:(13230040)(36860700016)(376014)(1800799024)(23010399003)(82310400026)(10067099003)(56012099006)(18002099003)(22082099003);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: ngJiMqnx3svndHgSU42oXljhsADieOPJfUsfG3pNPmR9kqjAYj0alj5rc1D1+2iYtaMRcVcT7ctPyJPu1MeuPxBny0W5buV64XOKZLPa7+jE34lEbzpL30VD33YsagNSNG2UsBjemoD41VaWspYtjg3NguagQbWsbXKlG13/kT+BfD3vOmIBhsSRsDBemdQ74waXw3Pc3ofzGD1qbL6h9aG5HkOBhWbxI8pIbmGHJcOfY+FeP1L3ZY8m0fChsQgiET0t3WKJ+lFNRKk7toKVkMa67+Lsih5WSqe6Ap1GB2RSJXAEeTwGEevVZviAWjVDHwXOx4XDfj+AHcuLPouvZjjQ3LHF98TZYJifdTtjhSrsDg7W8cJsOdjXO+uCPjymPeRDW5DZGpE+u9ye1sxoLuBz8vYuCDO2Acr7DJE5lb4sxwzoYAUGZrSGtlbvjkTN X-Exchange-RoutingPolicyChecked: RlLXQ32wYsjbmckMlkRSYiVO3085PsO3uxXwFTBNQ4iOIUaw4RUnmsBo4NbVS/MphUfhb5jfTxQDVWxWaxksHvl/e++s0APzPGnYkbRmx3fMrBmEK2pHogdbpASeTm/PXDwGbhF1/P9xQW/q+3s2m5zBJ4kWXanErzhHjYRQnEmX4F+Gz1OCLWnqMpdvQlpydD+4V7fUSqfoiG3Ls5lgWt8JYGxuYrzQQHLFTPQjrRSwWqHs5O+dNrAFEzjhUUOgEzqd1Fk1dfaetIx0Dkw0xOXgu/iRx5bpeS/H5ivhQckfUDvf5F20PnWUggidogy26AwAojzjvCp/5m05oxaQrg== X-OriginatorOrg: ti.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 10 Sep 2026 17:57:41.9970 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: f9841fd7-a1bb-407d-c06d-08df0f6502b1 X-MS-Exchange-CrossTenant-Id: e5b49634-450b-4709-8abb-1e2b19b982b7 X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=e5b49634-450b-4709-8abb-1e2b19b982b7;Ip=[198.47.23.195];Helo=[lewvzet201.ext.ti.com] X-MS-Exchange-CrossTenant-AuthSource: BL6PEPF0002256F.namprd02.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: DS6PR10MB997848 X-Proofpoint-Spam-Info: AW1haW4tMjYwOTEwMDIyMCBTYWx0ZWRfX7wMzl0S7bS7z Ro1QoPm8zWWw1snGN4+i85+vbL3qTZ+T4CzHlx1kzY5HvesSOw3yc+Vpj1d/cWEFwmdg80fO+p8 cOXdCg1QjiU2cGn30+YfE15iPps51n4= X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwOTEwMDIyMCBTYWx0ZWRfXzjlX6OhHhklp GhJHq6JC7hf85qr+p2a3ccObfRaxJzlOP6fnlh7Q6nNf1gpDqVqIMpKeQ+17uH8zX25r9Hn1yIO d9h5wT6foyQ+AsmexZOv5OdRUvARC+2Ezlid8C40ke4Z36Njk9aQT70VMV8v5abpUahYJpfnHYM cyYuAyFDDj+eZkmcHqiUgqF2oLIhksCwXCj/E5SCRtliTDTtatEF8Cv3+0mPGx6HmrC+HFI1oRa aMeKGv9cxY2KP2ywnzGiQof0hQcj5B6+P1giDkrAn63uRBpq326MW+iIdKybMcLb8gRha0WaKU5 +8MJuMQtTcz/vTLIB+9/Gfb7PMTCINqc21VQqSKg0WUtk6ynacRd/Z18FYg/LVHkqycnwRP/jG0 rk89qpzq80yZcnkbLZNjti/jpLjWWpbYT2T6khUMrMvHAZzXz1ERcr2nQIgHpj+yXmRJSFMCWO2 hQ21A3EGaNwjtiS0ANQ== X-Proofpoint-ORIG-GUID: 7BfQNJZarHTH7Y5uLDGDh14yhYIK4G9A X-Proofpoint-GUID: 7BfQNJZarHTH7Y5uLDGDh14yhYIK4G9A X-Authority-Analysis: v=2.4 cv=UJ5Ijyfy c=1 sm=1 tr=0 ts=6aa2ef99 cx=c_pps a=dnat/ZFdcaejr8kp+uhwWQ==:117 a=f+v6EHfkeJbVwR46tk4DMg==:17 a=6eWqkTHjU83fiwn7nKZWdM+Sl24=:19 a=VdqzKS8jKosA:10 a=s63m1ICgrNkA:10 a=V5UXEbMT0ywA:10 a=VkNPw1HP01LnGYTKEx00:22 a=Z8NIEmU8O1QQgoT56wFK:22 a=jwouBfj2j3NM8CExmVVE:22 a=sozttTNsAAAA:8 a=W2mYDkbPwZfAYNH1kz8A:9 X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1176,Hydra:6.1.134,FMLib:17.12.100.49 definitions=2026-09-10_05,2026-09-09_02,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 bulkscore=0 malwarescore=0 lowpriorityscore=0 spamscore=0 clxscore=1015 priorityscore=1501 adultscore=0 suspectscore=0 phishscore=0 impostorscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2609040000 definitions=main-2609100220 Content-Type: text/plain; charset="utf-8" Change assoclen, cryptlen, authsize from unsigned int to u64 to avoid overflow when they are added (in TAG offset and padding length calculation) Fixes: 37b902c603042 ("crypto: ti - Add support for AES-GCM in DTHEv2 drive= r") Signed-off-by: T Pratham --- drivers/crypto/ti/dthev2-aes.c | 28 +++++++++++++++++----------- 1 file changed, 17 insertions(+), 11 deletions(-) diff --git a/drivers/crypto/ti/dthev2-aes.c b/drivers/crypto/ti/dthev2-aes.c index 9b982ca4a7730..ca87aacc39c5d 100644 --- a/drivers/crypto/ti/dthev2-aes.c +++ b/drivers/crypto/ti/dthev2-aes.c @@ -756,6 +756,9 @@ static int dthe_aead_enc_get_tag(struct aead_request *r= eq) struct dthe_tfm_ctx *ctx =3D crypto_aead_ctx(crypto_aead_reqtfm(req)); struct dthe_aes_req_ctx *rctx =3D aead_request_ctx(req); u32 tag[AES_BLOCK_WORDS]; + u64 assoclen =3D req->assoclen; + u64 cryptlen =3D req->cryptlen; + u64 authsize =3D ctx->authsize; int nents; int ret; =20 @@ -763,12 +766,12 @@ static int dthe_aead_enc_get_tag(struct aead_request = *req) if (ret) return ret; =20 - nents =3D sg_nents_for_len(req->dst, req->cryptlen + req->assoclen + ctx-= >authsize); + nents =3D sg_nents_for_len(req->dst, cryptlen + assoclen + authsize); if (nents < 0) return nents; =20 - sg_pcopy_from_buffer(req->dst, nents, tag, ctx->authsize, - req->assoclen + req->cryptlen); + sg_pcopy_from_buffer(req->dst, nents, tag, authsize, + assoclen + cryptlen); =20 return 0; } @@ -779,6 +782,9 @@ static int dthe_aead_dec_verify_tag(struct aead_request= *req) struct dthe_aes_req_ctx *rctx =3D aead_request_ctx(req); u32 tag_out[AES_BLOCK_WORDS]; u32 tag_in[AES_BLOCK_WORDS]; + u64 assoclen =3D req->assoclen; + u64 cryptlen =3D req->cryptlen; + u64 authsize =3D ctx->authsize; int nents; int ret; =20 @@ -786,14 +792,14 @@ static int dthe_aead_dec_verify_tag(struct aead_reque= st *req) if (ret) return ret; =20 - nents =3D sg_nents_for_len(req->src, req->assoclen + req->cryptlen); + nents =3D sg_nents_for_len(req->src, assoclen + cryptlen); if (nents < 0) return nents; =20 - sg_pcopy_to_buffer(req->src, nents, tag_in, ctx->authsize, - req->assoclen + req->cryptlen - ctx->authsize); + sg_pcopy_to_buffer(req->src, nents, tag_in, authsize, + assoclen + cryptlen - authsize); =20 - if (crypto_memneq(tag_in, tag_out, ctx->authsize)) + if (crypto_memneq(tag_in, tag_out, authsize)) return -EBADMSG; else return 0; @@ -887,10 +893,10 @@ static int dthe_aead_run(struct crypto_engine *engine= , void *areq) struct dthe_aes_req_ctx *rctx =3D aead_request_ctx(req); struct dthe_data *dev_data =3D rctx->dev_data; =20 - unsigned int cryptlen =3D req->cryptlen; - unsigned int assoclen =3D req->assoclen; - unsigned int authsize =3D ctx->authsize; - unsigned int unpadded_cryptlen; + u64 cryptlen =3D req->cryptlen; + u64 assoclen =3D req->assoclen; + u64 authsize =3D ctx->authsize; + u64 unpadded_cryptlen; struct scatterlist *src =3D NULL; struct scatterlist *dst =3D NULL; struct scatterlist *aad_sg =3D NULL; --=20 2.34.1