From nobody Fri Sep 25 16:50:46 2026 Received: from mail-pz2-f12.google.com (mail-pz2-f12.google.com [74.125.228.12]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id E453F489FDC for ; Thu, 10 Sep 2026 12:58:05 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=74.125.228.12 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1789045087; cv=none; b=d4AhvjBoQZajXXvs8MovakSja22Z5jUBcWegiq9LIfGAsR6UbIQbiqaG9KXmXBngYGNRbhAju7oldCAkHS7quIkuCWi4L4niDwxh/WEsaWtzzXMTBfdDIaR6ztCohnsdLTlXqrYoL13FKlKnFUPKNAM/0iGwLTMyWfbd+kjaY5o= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1789045087; c=relaxed/simple; bh=EVDRcKmTVQAmuHJWES9U2hQGWq/76vGUhS5zLMa3z4c=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=jMuXzN929sg8MBaAdc2AOGrR4ywOXjx43HLcuDM79swnGVDly56nOZ7nv+QylFf0eEfmLDTkfBDsiajJbgbIH+u46FuMJCvtm6ZJQm7xSapZO2BSd25l698/pxndu1v/NaUJPeka649D0f/Z5KVhhdmu70zV108kRPwJp5s6KQo= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=NnXXgkkJ; arc=none smtp.client-ip=74.125.228.12 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="NnXXgkkJ" Received: by mail-pz2-f12.google.com with SMTP id 41be03b00d2f7-cc1cebcb8d7so817361a12.0 for ; Thu, 10 Sep 2026 05:58:05 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1789045085; x=1789649885; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to:content-type; bh=UiWyf1Dh9nthmX1SJ2zMjXD0YayBfWTFNKR/lg5M5tg=; b=NnXXgkkJqpobyICWryKKYqtxScJ9nTHeIqtGe5QkiqQCA4IKbCz2fRJvB9IHWN1BQ7 H0McH/ZAfuAhStKtr9okXryVP/Z3YeCrPCfLVpffq7PVIUcEI700KYkcPVJ0NsYDZxwN NgES9Q/QjQ79RLG2LX7Q4dDqTVak37YqqLFM/2MY2ShdFkUem9Olh5ceUJUz8y4gixrV 5M38APvgEWgkb0wk1IBZJJIy975ppI4e+iU4YS4aqkNawE3FAHr/hA4fXfH53Pfd2oh/ i6mWgVPaM47+erWVBLEAFPtl/FT8DkusEKOPEk69f6l+3J6fjpElC+xDL4NGkGmPoaqN 8mtg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1789045085; x=1789649885; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to:content-type; bh=UiWyf1Dh9nthmX1SJ2zMjXD0YayBfWTFNKR/lg5M5tg=; b=FSdZKShDp3mP+atwRLv3LbRXxIT0aTxzX0t5E3PH090jh6bee02y3uUbA11WoA/6Iw KxbDLvxpEBcwbKG/lbRb6itdHOf5iLDy1lzxCDiMRrPoCFSjeoIdMbfZSj5Maqf4uDYc jWvVyTtwJYdCAEyRPvbwVG407v2KGkt/nHMs851osw2MaAgk/kgrafk0thsnSkAR1ssi XWEVxy9tusprJOICHcacKm7tFr9B7rSUFaCxi/kOxaMwKRloLmTZZU80Ww0dPKprhlZa IXXiv63hem9D3mtbSDY326BhNBKguvlrgo460HtJga+5JjKTAYteUo5yn3YPJqHKAQEO sINg== X-Forwarded-Encrypted: i=1; AKwUvBwOTpG1U4rsxxt9AWeCDcmLBBiSFlzIrZLJ0ePU34ZSk85wODBDRLefI7dPjH8K0K+JgSydpSJjGCosfBc=@vger.kernel.org X-Gm-Message-State: AFuF++lNVn+dhReIcAqpczwsHdcYxRNXQ+qeTQ2S9iiL70sgbERk8Kmh eiGVmBLlPCF8nCasdKczKIt2qmcRaGrLnKjSx/gB25yjImJ/0sfPwDaK X-Gm-Gg: AYBFou2mXoq0Eood/rGcnQt7WOR1kJ2QUfLDOQP3LlShM5LofcypZNym2HCxZaNXO1m AJvIICvzxjGJTiMVmBYK599JaM1wf/TpTzPq+Nyl2XmaWkdfqzbv2u+jQfDyYAGAu/wagw9fQO2 VKFUQoyOImkPI7tIXxfpQe7iigGa4jKZfkHdHa2C9FwrhRtTBqklkP4AR/6OffZeZD54ILgCuSv lq4Vp90eqL+nAIzYay8fGi2OosbRxMkaTlIDml8hs2t/Ftrt+lk2Z4lP92nDOZ0xByGDDqCeygJ TA+8npvYhsEAc/t8jX8hbThCKttKdl6E1oEC1wTSf2f1HIzxn8sRZ2pMEpChWJ6fmman5ca6tVk os2SSUD48B3Yb+K5P4ZUu7bYLmQ1iW3X0eRMqIDOLuG3AmQP+rCjetqeTDTgj0BzKKMf7US7hFf gHKDHhOvrFlHl7cFkC2If0vbjg4mu2AQB661pA5I671hDUjEEXjd8wigtbLKG9VmrI8R/xx62sb gCOg99EAKXHz1DKDrM8u1Y1KcK1Q+8VisnDM8kb6KSLS/k1SUtLJgK4H43E1jDC9FxF4rGq8uRm qaSucJO4MeYsJ/K9xDKchg8kBg== X-Received: by 2002:a17:90a:d406:b0:38f:de94:bf34 with SMTP id 98e67ed59e1d1-39d77b1c378mr4389281a91.10.1789045084933; Thu, 10 Sep 2026 05:58:04 -0700 (PDT) Received: from phuc-desktop.. ([183.91.15.56]) by smtp.gmail.com with ESMTPSA id 98e67ed59e1d1-39d7e77b1afsm4891592a91.5.2026.09.10.05.58.01 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 10 Sep 2026 05:58:04 -0700 (PDT) From: phucduc.bui@gmail.com To: Mark Brown , AngeloGioacchino Del Regno Cc: Liam Girdwood , Matthias Brugger , Jaroslav Kysela , Takashi Iwai , Cezary Rojewski , Cyril Chao , Kuninori Morimoto , Dan Carpenter , cassiogabrielcontato@gmail.com, linux-sound@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-mediatek@lists.infradead.org, linux-kernel@vger.kernel.org, bui duc phuc Subject: [PATCH 01/13] ASoC: mediatek: mt8189: Return error for missing regmap Date: Thu, 10 Sep 2026 19:57:30 +0700 Message-ID: <20260910125742.150902-2-phucduc.bui@gmail.com> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20260910125742.150902-1-phucduc.bui@gmail.com> References: <20260910125742.150902-1-phucduc.bui@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" From: bui duc phuc mt8189_afe_enable_top_cg() currently returns success when the AFE regmap is unavailable. Return -EINVAL so callers can handle the error. Fixes: dc637ffeed6c ("ASoC: mediatek: mt8189: support audio clock control") Signed-off-by: bui duc phuc --- sound/soc/mediatek/mt8189/mt8189-afe-clk.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/sound/soc/mediatek/mt8189/mt8189-afe-clk.c b/sound/soc/mediate= k/mt8189/mt8189-afe-clk.c index fc7a7a73b0cf..63e03a40dbbe 100644 --- a/sound/soc/mediatek/mt8189/mt8189-afe-clk.c +++ b/sound/soc/mediatek/mt8189/mt8189-afe-clk.c @@ -236,7 +236,7 @@ static int mt8189_afe_enable_top_cg(struct mtk_base_afe= *afe, unsigned int cg_ty =20 if (!afe->regmap) { dev_err(afe->dev, "afe regmap is null !!!\n"); - return 0; + return -EINVAL; } =20 dev_dbg(afe->dev, "reg: 0x%x, mask: 0x%x, val: 0x%x\n", reg, mask, val); --=20 2.43.0 From nobody Fri Sep 25 16:50:46 2026 Received: from mail-pg1-f176.google.com (mail-pg1-f176.google.com [209.85.215.176]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 1220541D652 for ; Thu, 10 Sep 2026 12:58:10 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.215.176 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1789045092; cv=none; b=f/aVB+edu4x3xQEm974JN/nNIsaxL+v7JZVIMuQDytx0pRD51KUVXwuER4B1VsSABz6sw2ROqYBdehcSZx1d+C77X0qh5txsvokCPoccdfSY2ilPG4rm/LICmcSqrQD+iYkPzGZ4pBRjnrdk0Qj1kgZNFuumWirubE/azA2Tp74= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1789045092; c=relaxed/simple; bh=8R+M9WKTmBHOoibWGxqqRpuDlDmGb5sK/DQtxVHwCLs=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=HP6NsM++E26R7MSqRSImxqz/kZ4ub3tsP1nLsjs7zA5Vh6UPAJYLyTCYM4u8wb+hZN5KOcfFEZyBqxx+gFm1pqt3EzvnHP0dUWWzPFlRpKxar12GjGcqsOt2lVFwdJxKaPIQjU2psix0/sOLA1z3xQ3P/XtCMsxvtobjadtIWSg= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=A5HltfKi; arc=none smtp.client-ip=209.85.215.176 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="A5HltfKi" Received: by mail-pg1-f176.google.com with SMTP id 41be03b00d2f7-cc4b62d118aso416173a12.2 for ; Thu, 10 Sep 2026 05:58:10 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1789045090; x=1789649890; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to:content-type; bh=g3KOEHZTQKUIeB5kbh5OXuF9axs2TgY2RpwsVG2WXZc=; b=A5HltfKi8t5g56eeHdEmVbb2Ir6y8NFvDUzVTYN/JjIr1txmUsNBt2ISpxsZm7Iynx 0M0FIce4+q/fxX6Yfd3T89R7jVafVfJu80aWi4P4aHeNAh7VpAGavHPkyhEP4tkv9Viu 5fJF1yjNWvtMMIa507pYO66DN8YrlgvU3B2pOiat8QnVtDpyY/4NQsbBgR8C0TNVTtjk dR8ivJTINogvgV2jDUGkUlZsZprrsRsXjgFPeQkrol85FO+HkNBCGn21K4LQwcZ0Tcs1 v+XnrywjpW/GMPiH8o5GkMYRhu3GULhxb88qgQLjQNWjqTM6+Lgln4oV19cuH+Sbtxck l3ng== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1789045090; x=1789649890; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to:content-type; bh=g3KOEHZTQKUIeB5kbh5OXuF9axs2TgY2RpwsVG2WXZc=; b=rnMeGXqsqU+jgvTfHn2ZW1oOETw+i1LYUCdtqUtgyQmRF0WTNYYG+L3M9TM0xRXTvZ n+dw9NYAufIeOoRrBA/GvBWE+iJ/rkKPNIg+PHHHIjABbkGc3nfgWPWypf6w4lkl7/2H xyQzzM7kCIeNlnYKWi9TvXN3rBp9ZREN8WuZvOYnPAJDNnD8USPHW9Yo1GPjWeCpUiIN i8odar/+XgaqXF5x6NV/SAT01jk+S2dz48hIz6gPRYms0NnozrPqdgtn4OGPk9Ayzwyp QX4baG7kIGIdfSfvz7WY/nsfhMdZfxnT3oN4fPHPWlxahh1nxfF4jOYNnFek9bHpcMEe 7uPg== X-Forwarded-Encrypted: i=1; AKwUvByPDHS9dU+WwC7prpO+bkyaQwVcQqrdYoVKTMosxsZ9VYdMYGD45n4/GjtGlN7ZBTK7EmgilO5raioJkQo=@vger.kernel.org X-Gm-Message-State: AFuF++mUVB3eEANbO7mLYOlH5PlN4g0HoiDFsrEjfAcKnV387CO3fg0Y uZ5BgUartyCvSF9chNnSPXG7Qg2Q+DT1vs3niLxyt/WjGOGVnYwY0nEi X-Gm-Gg: AYBFou0cXlFRX20cPyb1Kr0V2E4p1/shPMt2+aCk0DFrGII7hkhefm6FXN0omGIGeuF QyBL5McBmd3rnWqw0Y/3jUr/GwiJQhT/0/b0VGv4g6/wAN0D0+GfTGOA8i3b1rjnHGlh62+4lRZ kabiKU7Cuc8fTQFCnxOWVR7DVxRn+rIOOItwQZeuzkxUea1+h86KRp3PraZE64bqhwXUvZgpPa1 84wHsnsOgXyshyeJR5GBX896v/g8xmStEcxSGjmncZ6ig9YStRMIybKofv/OojtLXsVNLAP8UqN tgcPzKgn0Hx3Dy6b1sRAx5vX48Iy6BjFf1d3WNfUqaugJJjUOtyo8eagLjKA31qN/Dz9dglCnlX rg/UeBv5+MiCz/8XhqEAukjuSMVTK2LI650kQrqyN56CJOLCVHx2n+UK7FYDCg9vbC/RfrtLT0J aqwAZKipFMUPuhN5in1FN+SmvWkZr+A5MzvGIvCiSvhWcogReL1Vdc0r3Iz50eQm6Y3hTmPGTgf LmhJmwoxc8McnYXzw5x5mFy1aZRF/ebBhgMEANcA5Zn3FXkCV6bC5f/IdmizXpBIoNgDb9av5+k B9pCjKu0p+xplrA= X-Received: by 2002:a17:90b:268f:b0:398:c3a3:dbd0 with SMTP id 98e67ed59e1d1-39b2612eb96mr63642021a91.8.1789045090094; Thu, 10 Sep 2026 05:58:10 -0700 (PDT) Received: from phuc-desktop.. ([183.91.15.56]) by smtp.gmail.com with ESMTPSA id 98e67ed59e1d1-39d7e77b1afsm4891592a91.5.2026.09.10.05.58.05 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 10 Sep 2026 05:58:09 -0700 (PDT) From: phucduc.bui@gmail.com To: Mark Brown , AngeloGioacchino Del Regno Cc: Liam Girdwood , Matthias Brugger , Jaroslav Kysela , Takashi Iwai , Cezary Rojewski , Cyril Chao , Kuninori Morimoto , Dan Carpenter , cassiogabrielcontato@gmail.com, linux-sound@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-mediatek@lists.infradead.org, linux-kernel@vger.kernel.org, bui duc phuc Subject: [PATCH 02/13] ASoC: mediatek: mt8189: Propagate APLL enable errors Date: Thu, 10 Sep 2026 19:57:31 +0700 Message-ID: <20260910125742.150902-3-phucduc.bui@gmail.com> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20260910125742.150902-1-phucduc.bui@gmail.com> References: <20260910125742.150902-1-phucduc.bui@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" From: bui duc phuc mt8189_apll1_enable() and mt8189_apll2_enable() currently ignore errors from regmap_update_bits() and do not clean up resources when clock enable operations fail. Propagate these errors and roll back the clocks and tuner state on errors. Fixes: dc637ffeed6c ("ASoC: mediatek: mt8189: support audio clock control") Signed-off-by: bui duc phuc --- sound/soc/mediatek/mt8189/mt8189-afe-clk.c | 78 ++++++++++++++++------ 1 file changed, 56 insertions(+), 22 deletions(-) diff --git a/sound/soc/mediatek/mt8189/mt8189-afe-clk.c b/sound/soc/mediate= k/mt8189/mt8189-afe-clk.c index 63e03a40dbbe..a901be97e75f 100644 --- a/sound/soc/mediatek/mt8189/mt8189-afe-clk.c +++ b/sound/soc/mediatek/mt8189/mt8189-afe-clk.c @@ -454,30 +454,47 @@ int mt8189_apll1_enable(struct mtk_base_afe *afe) =20 ret =3D mt8189_afe_enable_top_cg(afe, MT8189_CG_APLL1_CK); if (ret) - return ret; + goto err_apll1_ck; =20 ret =3D mt8189_afe_enable_top_cg(afe, MT8189_PDN_APLL_TUNER1); if (ret) - return ret; + goto err_apll_tuner1; =20 /* sel 44.1kHz:1, apll_div:7, upper bound:3 */ - regmap_update_bits(afe->regmap, AFE_APLL1_TUNER_CFG, - XTAL_EN_128FS_SEL_MASK_SFT | APLL_DIV_MASK_SFT | - UPPER_BOUND_MASK_SFT, - (0x1 << XTAL_EN_128FS_SEL_SFT) | (7 << APLL_DIV_SFT) | - (3 << UPPER_BOUND_SFT)); + ret =3D regmap_update_bits(afe->regmap, AFE_APLL1_TUNER_CFG, + XTAL_EN_128FS_SEL_MASK_SFT | APLL_DIV_MASK_SFT | + UPPER_BOUND_MASK_SFT, + (0x1 << XTAL_EN_128FS_SEL_SFT) | (7 << APLL_DIV_SFT) | + (3 << UPPER_BOUND_SFT)); + if (ret) + goto err_tuner; =20 /* apll1 freq tuner enable */ - regmap_update_bits(afe->regmap, AFE_APLL1_TUNER_CFG, - FREQ_TUNER_EN_MASK_SFT, - 0x1 << FREQ_TUNER_EN_SFT); + ret =3D regmap_update_bits(afe->regmap, AFE_APLL1_TUNER_CFG, + FREQ_TUNER_EN_MASK_SFT, + 0x1 << FREQ_TUNER_EN_SFT); + if (ret) + goto err_tuner; =20 /* audio apll1 on */ ret =3D mt8189_afe_enable_top_cg(afe, MT8189_AUDIO_APLL1_EN_ON); if (ret) - return ret; + goto err_apll1_en_on; =20 return 0; + +err_apll1_en_on: + regmap_update_bits(afe->regmap, AFE_APLL1_TUNER_CFG, + FREQ_TUNER_EN_MASK_SFT, + 0x0); +err_tuner: + mt8189_afe_disable_top_cg(afe, MT8189_PDN_APLL_TUNER1); +err_apll_tuner1: + mt8189_afe_disable_top_cg(afe, MT8189_CG_APLL1_CK); +err_apll1_ck: + apll1_mux_setting(afe, false); + + return ret; } =20 void mt8189_apll1_disable(struct mtk_base_afe *afe) @@ -506,30 +523,47 @@ int mt8189_apll2_enable(struct mtk_base_afe *afe) =20 ret =3D mt8189_afe_enable_top_cg(afe, MT8189_CG_APLL2_CK); if (ret) - return ret; + goto err_apll2_ck; =20 ret =3D mt8189_afe_enable_top_cg(afe, MT8189_PDN_APLL_TUNER2); if (ret) - return ret; + goto err_apll_tuner2; =20 /* sel 48kHz: 2, apll_div: 7, upper bound: 3*/ - regmap_update_bits(afe->regmap, AFE_APLL2_TUNER_CFG, - XTAL_EN_128FS_SEL_MASK_SFT | APLL_DIV_MASK_SFT | - UPPER_BOUND_MASK_SFT, - (0x2 << XTAL_EN_128FS_SEL_SFT) | (7 << APLL_DIV_SFT) | - (3 << UPPER_BOUND_SFT)); + ret =3D regmap_update_bits(afe->regmap, AFE_APLL2_TUNER_CFG, + XTAL_EN_128FS_SEL_MASK_SFT | APLL_DIV_MASK_SFT | + UPPER_BOUND_MASK_SFT, + (0x2 << XTAL_EN_128FS_SEL_SFT) | (7 << APLL_DIV_SFT) | + (3 << UPPER_BOUND_SFT)); + if (ret) + goto err_tuner; =20 /* apll2 freq tuner enable */ - regmap_update_bits(afe->regmap, AFE_APLL2_TUNER_CFG, - FREQ_TUNER_EN_MASK_SFT, - 0x1 << FREQ_TUNER_EN_SFT); + ret =3D regmap_update_bits(afe->regmap, AFE_APLL2_TUNER_CFG, + FREQ_TUNER_EN_MASK_SFT, + 0x1 << FREQ_TUNER_EN_SFT); + if (ret) + goto err_tuner; =20 /* audio apll2 on */ ret =3D mt8189_afe_enable_top_cg(afe, MT8189_AUDIO_APLL2_EN_ON); if (ret) - return ret; + goto err_apll2_en_on; =20 return 0; + +err_apll2_en_on: + regmap_update_bits(afe->regmap, AFE_APLL2_TUNER_CFG, + FREQ_TUNER_EN_MASK_SFT, + 0x0); +err_tuner: + mt8189_afe_disable_top_cg(afe, MT8189_PDN_APLL_TUNER2); +err_apll_tuner2: + mt8189_afe_disable_top_cg(afe, MT8189_CG_APLL2_CK); +err_apll2_ck: + apll2_mux_setting(afe, false); + + return ret; } =20 void mt8189_apll2_disable(struct mtk_base_afe *afe) --=20 2.43.0 From nobody Fri Sep 25 16:50:46 2026 Received: from mail-pj2-f12.google.com (mail-pj2-f12.google.com [74.125.227.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 8B4C0463B6E for ; Thu, 10 Sep 2026 12:58:15 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=74.125.227.140 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1789045098; cv=none; b=gTwEojVtQC+H3xGJnrmNpZsFF7rkmLLTFdZan5t5pPbeqynCBF08TpK/SthKDKnW1aRFwboaKnpgjezDtkWHM8EpwcZIkFPvMq4tLnRSgFSnXSkN84o96HS2Z/CPCGCIzMEzhPkAnRMAxOjjaUiqWaA103lrnZ5AqA8VYrGTMvY= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1789045098; c=relaxed/simple; bh=gxw3C5/yz8ul7f7LJNdtEH1VOBy0BfPp0Uf/l7ubhrE=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=gUSq3fZ2M8bLAo4bWWq7ZGZtfJtlolsq38VQPpXHq8ovc8ZcwhG/qknARLv1UrtQO+/6wNo7OF+326k7f4ro1/T4muHnh5Cx87TGqgfnrwW8KSKSaAFTH7neNZm2kaRIP+Ma2ppnCRb3CMqPzKWXGLYCTJh8KQCZ/D9kVTlUB3M= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=hufIA9G/; arc=none smtp.client-ip=74.125.227.140 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="hufIA9G/" Received: by mail-pj2-f12.google.com with SMTP id 98e67ed59e1d1-39b31b4281eso1367867a91.2 for ; Thu, 10 Sep 2026 05:58:15 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1789045095; x=1789649895; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to:content-type; bh=Ap1gX+PkBizjl0Oij+OVCGBkei2bcoaYLfDjuKETX2w=; b=hufIA9G/ggefXX0rfNyF2raSWNK3tZ5ieqR7Zjmv7m/2QIpe3gt/QDl+86TL3fnzw5 QXJk9Y4u4ttmxXtuZn8wM31meINvmzu6vMp2NdG26pmJ57cbCVrAh4Lhx3vEIpAjklOT 0pGXuaexVUmu5KNR9WFtu4JIdk5B03cmVnCmMVPrg4rYTfr2mh+z5Rn1So+WSVeHjFyb GbK0KQ6b4P+QCJpoApjEtSJpKi4UscLz/y7uTpl5zJeRgZkFi6svn2akAHLwMxL1yH8y hBUHMxPIaLkUmfpT+zoOEgLbJgcpBP4HSuHI1Zgf4O15e01f8q13rvHb89bHjBmFb9G5 4Fxg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1789045095; x=1789649895; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to:content-type; bh=Ap1gX+PkBizjl0Oij+OVCGBkei2bcoaYLfDjuKETX2w=; b=qWOPMQf87U28NOwXL5A8RY6KKz42dy5Lfh5wmg0k8JfrAXeJRXhUQScoTjzWS9v3/N D8SMHqF2ZfKXHbxybkNlE7vLnI9tp2f8yWVMYDhra2+HHb7ATdneLmqRqxffwCbBpVlh e9iBsidhIa42pkmDr4JxXNndO/ZtKBgVaNjUc8gmZJeeQonJD+zKvLLwnYnbtdPrpBVy PrsOUg/4H6bOIjlCx9WYRAenaILKkJ1x5fM4WxaGzy8R1TMlLmjYAWesdO8ibgF17ZdG 6C4W6NlRKHOMAmgyZ8T6eazZrD1y/T5LJPzC5QxiIMTc7ByeuOz1UI2Mz3z1C5Vy6HrY A8Iw== X-Forwarded-Encrypted: i=1; AKwUvBwRaQQU8TdiGXvPEILCrkmRdezowKk3nVxUCSa0TemWDyt8Y/DAIOIh0lZJf66Zyyg85iAiKlhs5D4PLsQ=@vger.kernel.org X-Gm-Message-State: AFuF++mVjYWic4YbpnkSxbTbZUXZSgA4CYF39QXuaIyIiXBiiNmivwGL qOWDUlOFPdKZAK7ALk+LCs3YNgsL8P2BWLFEKYPchvXiFNK/mYgIvd2v X-Gm-Gg: AYBFou2krAU3Ns14YRrpRb0NbM2CAL8K+GAf0X3RuG51RPVu/pCmG2TOzht4Qv40+G4 2XONpctHc09Eg8f1sUSBtu+G5yKhF6s7LgF/aFhobcLl4yCtnY0VqhqO6taJnNWcbVIHGYGfWnL +xiYl8gHV+x92Ys8Fwxy3qZwA/BYfTyYw6k1tBl49utFrcyD+uC70LWtu7dA0pKJHJkDyP2z2JN ySrkllYC2akdl6p/1q8JZI+z2n7kpIOu/A+tRoBZV+E6YLaqambbhd+wXn6dz+VN9oPC3UH2sNK NYIn9aOwcsnhqKnojUKYDbKbPhWqkS3KDZOftrYbrnmYpxp4r3jxNPwncuQXkm/nB9atc8ZPFin A4XhFTGCnfWKQCbYh08rKGRdl3NwJqmr5m6oJZllW4LRqMPJUMwGB3gIwE4YcM1qhlp9se8LRHg zAwSTkxz090cfbE7BWIpa5+C6nmjP7l091B4HP2lvQEF9M3dwsI3GEIJuJoo82wZLrwRjAWJzcR 9VYztBXz7ZfpPwbSY2+Ykwrmz3C8x9+QZZCR5NCV3Z04LpjC5Pq70xWVIOZR5xha1nYezoevFOj Scoecy3DhmSG2eA= X-Received: by 2002:a17:90b:2b43:b0:398:ab03:95b2 with SMTP id 98e67ed59e1d1-39d709e5464mr10985783a91.10.1789045094591; Thu, 10 Sep 2026 05:58:14 -0700 (PDT) Received: from phuc-desktop.. ([183.91.15.56]) by smtp.gmail.com with ESMTPSA id 98e67ed59e1d1-39d7e77b1afsm4891592a91.5.2026.09.10.05.58.10 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 10 Sep 2026 05:58:14 -0700 (PDT) From: phucduc.bui@gmail.com To: Mark Brown , AngeloGioacchino Del Regno Cc: Liam Girdwood , Matthias Brugger , Jaroslav Kysela , Takashi Iwai , Cezary Rojewski , Cyril Chao , Kuninori Morimoto , Dan Carpenter , cassiogabrielcontato@gmail.com, linux-sound@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-mediatek@lists.infradead.org, linux-kernel@vger.kernel.org, bui duc phuc Subject: [PATCH 03/13] ASoC: mediatek: mt8189: Propagate MCK enable errors Date: Thu, 10 Sep 2026 19:57:32 +0700 Message-ID: <20260910125742.150902-4-phucduc.bui@gmail.com> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20260910125742.150902-1-phucduc.bui@gmail.com> References: <20260910125742.150902-1-phucduc.bui@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" From: bui duc phuc mt8189_mck_enable() currently returns without restoring the clock state when setting the clock parent, enabling the divider, or setting the divider rate fails. Propagate the error and disable clocks enabled by the function. Fixes: dc637ffeed6c ("ASoC: mediatek: mt8189: support audio clock control") Signed-off-by: bui duc phuc --- sound/soc/mediatek/mt8189/mt8189-afe-clk.c | 14 +++++++++++--- 1 file changed, 11 insertions(+), 3 deletions(-) diff --git a/sound/soc/mediatek/mt8189/mt8189-afe-clk.c b/sound/soc/mediate= k/mt8189/mt8189-afe-clk.c index a901be97e75f..933179f2a5ba 100644 --- a/sound/soc/mediatek/mt8189/mt8189-afe-clk.c +++ b/sound/soc/mediatek/mt8189/mt8189-afe-clk.c @@ -639,7 +639,7 @@ int mt8189_mck_enable(struct mtk_base_afe *afe, int mck= _id, int rate) ret =3D mt8189_afe_set_clk_parent(afe, afe_priv->clk[m_sel_id], afe_priv->clk[apll_clk_id]); if (ret) - return ret; + goto err_m_sel; } =20 /* enable div, set rate */ @@ -650,13 +650,21 @@ int mt8189_mck_enable(struct mtk_base_afe *afe, int m= ck_id, int rate) =20 ret =3D mt8189_afe_enable_clk(afe, afe_priv->clk[div_clk_id]); if (ret) - return ret; + goto err_m_sel; =20 ret =3D mt8189_afe_set_clk_rate(afe, afe_priv->clk[div_clk_id], rate); if (ret) - return ret; + goto err_div; =20 return 0; + +err_div: + mt8189_afe_disable_clk(afe, afe_priv->clk[div_clk_id]); +err_m_sel: + if (m_sel_id >=3D 0) + mt8189_afe_disable_clk(afe, afe_priv->clk[m_sel_id]); + + return ret; } =20 int mt8189_mck_disable(struct mtk_base_afe *afe, int mck_id) --=20 2.43.0 From nobody Fri Sep 25 16:50:46 2026 Received: from mail-pj1-f54.google.com (mail-pj1-f54.google.com [209.85.216.54]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 1D13D48A8A4 for ; Thu, 10 Sep 2026 12:58:19 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.216.54 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1789045101; cv=none; b=QGjyKWxWUEl0fYNTKy1WSIWnA/AGrOYsMvSvfd6dNOkyyc7ADk0w/8JnoIVt29y9WZYI7ctPLtI/OBnznI5vvJhbLr9KHGDnGMkPKkT90u+7LUa0C3JqG7x9rfvawqyJx+iWUOtdhfH1H1/8nVLqoty2QbdYX7vEm/9Qbu3JGAw= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1789045101; c=relaxed/simple; bh=eDB4A6Lwo/gDz5Acpsb0IJtqQRbTmROpMeCy9cYBs8g=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=hCZCodIMepz40t7mj9SZ4iWJ4N6/1krevTcAEao/Ue2mlSjqePbwqvybjYlrd7dpfaeHT7XqZHWhfV//RcZPJg2oZ7q57xQAEUjLPUsGi9xYKTM85n38+XdbyPXT9Kssx9YEV79x7KpM0KYXBtCkN2IAm35jQ9HaWJTQ6WayPNo= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=b42YW58x; arc=none smtp.client-ip=209.85.216.54 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="b42YW58x" Received: by mail-pj1-f54.google.com with SMTP id 98e67ed59e1d1-39b9a99469fso2927706a91.3 for ; Thu, 10 Sep 2026 05:58:19 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1789045099; x=1789649899; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to:content-type; bh=bKdmUJYxYgq8tpbG7VT9pIxvv5zd6VcFqq2QVmbg6wI=; b=b42YW58x+HwpXj9HrjuINZrpfkM7gk+mWkUTLKKyibsb/LfTGZyvZBYilVGWBhzwuf CeBxxlAjyx53aVTQlfXHPMcRUzrQdu+KZTIkNh98Lb3dMFgIrmlht+apgpRpu9I6dwtB U3xTJaHblh4iJGZSgVkIAMRvNHF7JEMdSYz2g1GFYwu1SDuMIl9B5x5zIslNePNk7x14 cfbj6w0MM7DOV3K0GY47oHmHJrPT0NmFj3aF7zxprKMPhGRK7RuqYZSqyYkNHI9i7Bm6 +EKZQsNumdOhwNhu+1PpOinO0Phs9YeD4AREmkPLE55Ufg7jeeCRUor5qlGH2rafRk/8 IY+w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1789045099; x=1789649899; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to:content-type; bh=bKdmUJYxYgq8tpbG7VT9pIxvv5zd6VcFqq2QVmbg6wI=; b=qXw+fBhaXQyj/PpMgPf+/ru2MThyQUoKEXpkNr69TO++w1U/kLOMAOIQnVRboq+kzT 9BhcVhxB1gOROYdFPh71kCocHsCwSoHp9psRSFqdtgwcGnD8VLSxQkFI0HuC+EAzoPjQ Yl8h+cwT3jAvUCg1sZ7ZlE4fHbS8QKO2fxj0wUmx9PIov35BFDu4PcrnOnaDKL2afeUW xhzWyOjj/OgcjDx7sqahTt4Fd/MvcENnNp15hervpOv+ANouHJwo8/yyCfzew1Kqe3XR TwJHhMndLjw5QA4zBDs9+p/UJr+8RBVXITItWGQBTqtDYtWZUmQ03HiOHivPkw6DfqN+ XJRA== X-Forwarded-Encrypted: i=1; AKwUvBxZ4MNT4N7sl97m7g2tWMl0bCdSX8wi10vQVppgv0DTJASc7MJwHsST1CA/tQrCeLEMy1f49Rr6+meU2f4=@vger.kernel.org X-Gm-Message-State: AFuF++m+euKwT/9tsruO7AM0w2hmQxE/YYZ+wBbFXTWjYwieazSLzPPK DFcjrs9mLyfhdYh2K/Myvu6+ETyiSw4sCYkPjIWIPhhFT/v13q25NEhu X-Gm-Gg: AYBFou3Feu9Lw/yMgNaTLRcdoBZKl0vnnYjDalme1YfrMAgol7F5bkAX2sPseONsfVG iksEeQdxI20/MGr3ZpGlhLBRbNxVWT+izEoI8btXJpMDDbsjHE+vJ7gLSPdEZEGtoeI72wspiqR N/kQpXphDFAJTfH4raGLMVPFm0JyNQlk0cT/phqjBOL+INrmJOljHCuqN5jESgDD9fbuoBKlSQj 10WyORUUXJDYi9L/XazUeUMBQc93MMcDj/W0TSSWdVurAj0IqvSNCglrfYB+4ZOJXNw29RuFf8+ JPBsqS9YpGjXIewps2lIhtMOihmYjyOAnVbAh9onoK8K7uAe3zPLlEzSNPT93UKOMVDX13OYgr4 5PWMexKXYPVGXbi8IULG2bxvcv1NgMSg70iRAEsU6iYcw9jUnDTuVfAu2G0y58b3hWeBL0PrrKC bWiL+rr+ZGqugaliNU3p9JcwU9SPx3VjlSalo2OKaCjHUuMuej8RHrOT/hOyBfIWGyX04v1ZjKG 7IDfoZc838R+5/N4X7H9gzsY1hnkryVLWMRZB41PPDXqHYl/ekBydAq7tUTTqmqtfswA+oTvQ0M Fz3iJ3iRmgAX8vA= X-Received: by 2002:a17:90a:fc47:b0:398:9c0c:7c72 with SMTP id 98e67ed59e1d1-39b2627fe24mr58655781a91.25.1789045099266; Thu, 10 Sep 2026 05:58:19 -0700 (PDT) Received: from phuc-desktop.. ([183.91.15.56]) by smtp.gmail.com with ESMTPSA id 98e67ed59e1d1-39d7e77b1afsm4891592a91.5.2026.09.10.05.58.15 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 10 Sep 2026 05:58:18 -0700 (PDT) From: phucduc.bui@gmail.com To: Mark Brown , AngeloGioacchino Del Regno Cc: Liam Girdwood , Matthias Brugger , Jaroslav Kysela , Takashi Iwai , Cezary Rojewski , Cyril Chao , Kuninori Morimoto , Dan Carpenter , cassiogabrielcontato@gmail.com, linux-sound@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-mediatek@lists.infradead.org, linux-kernel@vger.kernel.org, bui duc phuc Subject: [PATCH 04/13] ASoC: mediatek: mt8189: Validate MCK ID Date: Thu, 10 Sep 2026 19:57:33 +0700 Message-ID: <20260910125742.150902-5-phucduc.bui@gmail.com> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20260910125742.150902-1-phucduc.bui@gmail.com> References: <20260910125742.150902-1-phucduc.bui@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" From: bui duc phuc mt8189_mck_disable() only checks for negative MCK IDs. Reject IDs outside the valid MCK range as well. Fixes: dc637ffeed6c ("ASoC: mediatek: mt8189: support audio clock control") Signed-off-by: bui duc phuc --- sound/soc/mediatek/mt8189/mt8189-afe-clk.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/sound/soc/mediatek/mt8189/mt8189-afe-clk.c b/sound/soc/mediate= k/mt8189/mt8189-afe-clk.c index 933179f2a5ba..88f15a9c2513 100644 --- a/sound/soc/mediatek/mt8189/mt8189-afe-clk.c +++ b/sound/soc/mediatek/mt8189/mt8189-afe-clk.c @@ -675,8 +675,8 @@ int mt8189_mck_disable(struct mtk_base_afe *afe, int mc= k_id) =20 dev_dbg(afe->dev, "mck_id: %d.\n", mck_id); =20 - if (mck_id < 0) { - dev_err(afe->dev, "mck_id =3D %d < 0\n", mck_id); + if (mck_id >=3D MT8189_MCK_NUM || mck_id < 0) { + dev_err(afe->dev, "mck_id =3D %d\n", mck_id); return -EINVAL; } =20 --=20 2.43.0 From nobody Fri Sep 25 16:50:46 2026 Received: from mail-pg1-f176.google.com (mail-pg1-f176.google.com [209.85.215.176]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 9C35F488221 for ; Thu, 10 Sep 2026 12:58:24 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.215.176 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1789045107; cv=none; b=iM7CpU6vFZbRCO0A+BSJv61JU8WjAFi3+ghdfqNO89gtNPQKpaXXsMOBMmJDNWcHXlFie2k9Ja4vjGJU0fuhviHCc5kVMmNOkl9c5bVXVBCFNm5UgN5H31ZQ5kFs7m9iqQ0BkEzt+XhhTfRlGZgJeAXvZx2XLAGhB/hkKSDvLzM= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1789045107; c=relaxed/simple; bh=sIdjIJnQzzDHHd3jtn8HXsF9ZViycOy80c1qBL2u6LY=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=GRpUcLI0e3wxvL6pnUk3ivbwLsX58XVOPsd1o/G3QRPt3mUqIp1cqsjzdGCLCFdDpr8wu/yJ7Bz+4B1Upn5cE+kDOnr0GjJO89QwTBowk8G5gacVUDtfAl6TXzJh2thxNwy/hhi146IJ3WVY9bos1KSli9SNTbCmCRATYFw6mxg= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=G640F5VX; arc=none smtp.client-ip=209.85.215.176 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="G640F5VX" Received: by mail-pg1-f176.google.com with SMTP id 41be03b00d2f7-cbee846deecso988558a12.1 for ; Thu, 10 Sep 2026 05:58:24 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1789045104; x=1789649904; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to:content-type; bh=DhFmxksn93jaqEPBP5cg3W4kPZXQ3iAg4tUPjfm3otE=; b=G640F5VXxl5Z4GsUfiAe0sX6murh8Fmg/yQPi8pLB+bXb+JjrJF/E+r5xGV4q+gSls yDAKzDTIqChG10Mr7CWu7VEF8up6HX+fHY1lnD8BzXoInwZtodul6yW7pyAS5av2/N7U p/h/wW8rweSTY+hjhsPNnmWUCnPDnb+gUVpx1p90nFoQDgYiCFbEIWHeoT08WMYnfW2J 29ydoitEeI5VUSetPblsFRClYlh6FcBtorR5WcBIk2GsqqQkKBh6pPK6qYRony1apwDg 1V43+6CqEd165A4RdYT6Ps0FS/S7juH4Ejp57KfTZXKX0GUBt27igXspMNqRQj9KwHHM YGhQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1789045104; x=1789649904; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to:content-type; bh=DhFmxksn93jaqEPBP5cg3W4kPZXQ3iAg4tUPjfm3otE=; b=AE3H78PW2hriRp4w9Cgy/020Dd2qgmVNTmy6yjT7ZgDtR1XLk0KjT9VhPbja7gh0hj g8rxkr6pf0hFLSY8izQvQt6DQSyaiL0hc5drLO/EKwE9rlBWQT3oUnW0Ft+7Wv3ueC/Z rZNOK3nOAeoR/8yYuzcyzdrIIMij8qI9O4UWdtDTfrlfl9oZFL7sE4Zv9+K8Upz+dRCg Ry0ivejceGhjDGNCgfUJDtNxeRDzE6fBe5mXCGfoWHfRcg5dOkE45EwMOLWIFOAxc7y8 sbnuxRKWZ7ZmMEoWLCAXCWm77eIgBE6PkKoWdaByHNkjHAFKcVEb2ZaRKwiujOGcNqCj b/Bg== X-Forwarded-Encrypted: i=1; AKwUvBxO+VLIs2bSR9ML5N3mGeiw8MuIU9ky3+1TZ1dz3Dn7vugG47avr0n6Cxl8hRE+G1V5UoKZMHFSO8tPrJc=@vger.kernel.org X-Gm-Message-State: AFuF++mrPb1nzjY4q4SrQVGNQAt9Fi6JwDC573QZwY+YrVlHU4b3nltl JGIx3DFEsl4JLW81Tg7tn4E2OPylw1ilVt/QJYByqamxLRQ1G4ytrPLj X-Gm-Gg: AYBFou3ke/8hCyaJRu9sPPVyorY1YlAczF1jo8tZgX2M+CYnopY4wENlhG7P+8sdH52 TH4ydUBDOKcmAH3SXOCNZ93psyI6VyBf6eFECXjEWRlo6jA3T0qVPMgWpy8yg2a/Jz00OxZfq6P n8L+JZKPFIyknmRZpGgXQ7uD4x34fI/d3qhdC6UyEB5d78Y4mKxQ8VAHkXqyDKDB/TJIksPOrce B7aIOF9i6RTMkbsbfGan/1S52+YsTsuETAIsyey1lB6vZQU0KEjAlbEoCLLwoxQKqCQ3PgBqeDm XzbaDpaAb1ty63UXeSlYDzD1xXQAG9C9hCMnQZ0BdKcf6MHWmOjyoCBVxtpmKZpnbJn+VROdown 9vxedKJXDZ/I4BK8/AjQXV3p9rZZpFcGNMCsnpz7LpcFupkyhTvP3Z6631PMi5swyKNEYmR86/v 4qyE8hDufqywNx/Oa3FjtKe2SILlhcx7UhC152P4Bw3It7kP5pvhcfPkKGuNf88JRv+v+8ovjCY lF6hF7k75/S74TO2r97PzzJoLhiGZ1JmG7k15WzpczgvPY0CkGHPn483/JCoZDRE+iKMwlO92eK +/GALC28IIim9kc= X-Received: by 2002:a17:90b:2e0e:b0:398:9be5:b419 with SMTP id 98e67ed59e1d1-39b2622bfecmr60688528a91.20.1789045103695; Thu, 10 Sep 2026 05:58:23 -0700 (PDT) Received: from phuc-desktop.. ([183.91.15.56]) by smtp.gmail.com with ESMTPSA id 98e67ed59e1d1-39d7e77b1afsm4891592a91.5.2026.09.10.05.58.20 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 10 Sep 2026 05:58:23 -0700 (PDT) From: phucduc.bui@gmail.com To: Mark Brown , AngeloGioacchino Del Regno Cc: Liam Girdwood , Matthias Brugger , Jaroslav Kysela , Takashi Iwai , Cezary Rojewski , Cyril Chao , Kuninori Morimoto , Dan Carpenter , cassiogabrielcontato@gmail.com, linux-sound@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-mediatek@lists.infradead.org, linux-kernel@vger.kernel.org, bui duc phuc Subject: [PATCH 05/13] ASoC: mediatek: mt8189: Propagate reg_rw clock errors Date: Thu, 10 Sep 2026 19:57:34 +0700 Message-ID: <20260910125742.150902-6-phucduc.bui@gmail.com> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20260910125742.150902-1-phucduc.bui@gmail.com> References: <20260910125742.150902-1-phucduc.bui@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" From: bui duc phuc mt8189_afe_enable_reg_rw_clk() currently ignores errors from clock enable and parent operations. Propagate these errors and clean up the clocks before returning the error. Fixes: dc637ffeed6c ("ASoC: mediatek: mt8189: support audio clock control") Signed-off-by: bui duc phuc --- sound/soc/mediatek/mt8189/mt8189-afe-clk.c | 31 +++++++++++++++++----- 1 file changed, 25 insertions(+), 6 deletions(-) diff --git a/sound/soc/mediatek/mt8189/mt8189-afe-clk.c b/sound/soc/mediate= k/mt8189/mt8189-afe-clk.c index 88f15a9c2513..435914aafb44 100644 --- a/sound/soc/mediatek/mt8189/mt8189-afe-clk.c +++ b/sound/soc/mediatek/mt8189/mt8189-afe-clk.c @@ -700,17 +700,36 @@ int mt8189_mck_disable(struct mtk_base_afe *afe, int = mck_id) int mt8189_afe_enable_reg_rw_clk(struct mtk_base_afe *afe) { struct mt8189_afe_private *afe_priv =3D afe->platform_priv; + int ret; =20 /* bus clock for AFE internal access, like AFE SRAM */ - mt8189_afe_enable_clk(afe, afe_priv->clk[MT8189_CLK_TOP_MUX_AUDIOINTBUS]); - mt8189_afe_set_clk_parent(afe, afe_priv->clk[MT8189_CLK_TOP_MUX_AUDIOINTB= US], - afe_priv->clk[MT8189_CLK_TOP_CLK26M]); + ret =3D mt8189_afe_enable_clk(afe, afe_priv->clk[MT8189_CLK_TOP_MUX_AUDIO= INTBUS]); + if (ret) + return ret; + + ret =3D mt8189_afe_set_clk_parent(afe, afe_priv->clk[MT8189_CLK_TOP_MUX_A= UDIOINTBUS], + afe_priv->clk[MT8189_CLK_TOP_CLK26M]); + if (ret) + goto err_audiointbus; + /* enable audio clock source */ - mt8189_afe_enable_clk(afe, afe_priv->clk[MT8189_CLK_TOP_MUX_AUDIO_H]); - mt8189_afe_set_clk_parent(afe, afe_priv->clk[MT8189_CLK_TOP_MUX_AUDIO_H], - afe_priv->clk[MT8189_CLK_TOP_CLK26M]); + ret =3D mt8189_afe_enable_clk(afe, afe_priv->clk[MT8189_CLK_TOP_MUX_AUDIO= _H]); + if (ret) + goto err_audiointbus; + + ret =3D mt8189_afe_set_clk_parent(afe, afe_priv->clk[MT8189_CLK_TOP_MUX_A= UDIO_H], + afe_priv->clk[MT8189_CLK_TOP_CLK26M]); + if (ret) + goto err_audio_h; =20 return 0; + +err_audio_h: + mt8189_afe_disable_clk(afe, afe_priv->clk[MT8189_CLK_TOP_MUX_AUDIO_H]); +err_audiointbus: + mt8189_afe_disable_clk(afe, afe_priv->clk[MT8189_CLK_TOP_MUX_AUDIOINTBUS]= ); + + return ret; } =20 int mt8189_afe_disable_reg_rw_clk(struct mtk_base_afe *afe) --=20 2.43.0 From nobody Fri Sep 25 16:50:46 2026 Received: from mail-pj2-f12.google.com (mail-pj2-f12.google.com [74.125.227.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 346EE489FDE for ; Thu, 10 Sep 2026 12:58:28 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=74.125.227.140 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1789045110; cv=none; b=rMxbxz9Bmj6a2sGnAP4rUvH678ykA9IAHOpkkhUUq18jfRA5WCisRXrkKpNSyPyVeXEvlZYeiO18jQJIf0/FOxEkEnhsqOb1R7yypDRcScZZoBlzQO7fLEULXnmejTJ+CQeX54ndKSecabaUc238PL2lh+GShgBNJk06/mNVrks= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1789045110; c=relaxed/simple; bh=7mTmQqvMAJspHqMWjJADF5TkGnCYRTyK2h8zGqfXvsQ=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=DQHXbu9WW/ZAAvAwtXusNftEy/MoxrIKVY8ynyRPkC26kKxQ9ldwNfrIQM6N6wyU50Bb/QPhmr+SbDy1Ly30a4tWBev4cnCV+MgBjFfki/AV+tpOb4tVNyecAPgd5KOVX/bQd1J1rOpgTO7ATRnjMQXDOJa7lOe6E99nt69r7NU= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=lBEwYEHl; arc=none smtp.client-ip=74.125.227.140 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="lBEwYEHl" Received: by mail-pj2-f12.google.com with SMTP id 98e67ed59e1d1-39b31b4281eso1368050a91.2 for ; Thu, 10 Sep 2026 05:58:28 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1789045108; x=1789649908; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to:content-type; bh=MsPHanuPYhLkAJkeLkxT04CaUhRH1BSXCePDlxHKnc4=; b=lBEwYEHlRt6twxxo35hJCWSo8eh/hQrmPGa1Ibm2BtCCJONxqJI3TwijaWTwi3tTRc KdZEsJ0MmcgnF4+OfykSqr+xtJ8dLUmAFSVJf9UlBYKXyS6ty48SNwYeDcHfy63iM9ER nXR/oQW/PCfd2oA0A3hcqjNryeQyb7lWnKpq9zAFE/pu8qKNXp0njv67CB0X8QrKnzHE OmdDR/EBC0CPCNE+UH1ZPFkIHjCseIDr4K6LXTihV6eTeAPzUc0P3R/hbt9eK8XDMTxp eb2j382vx4yJVQmjzLg1ZdkHrQMt16ACDAwbKIOdTu6UcRJS6o10o8FsBKyOjg+RlUky eEPg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1789045108; x=1789649908; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to:content-type; bh=MsPHanuPYhLkAJkeLkxT04CaUhRH1BSXCePDlxHKnc4=; b=gscKPb8s1v7RbFwoMMiJZZS46/Fb47gIKPCXfZH2/fHApVVQVYPyTzf0lYDVq1HVTM 8ynBycdjni+yvIy3U/QrTVYwr+VZaG78A/7+F6mba2GT/ML2Z3Uch4n7Bq3DWFXLDkiA 9ciUHYmnb/jNgiQfziFNlYuFYKLGUVSRV9HRjA3E6lPdsTLy3nA/DWgKqtiFV3wx174z QVeYwIm1MPzGeEu8+R6RJEc561g3X7kcW0P14CAPJgRFQORlPC6F/Y83uatV50f96/wJ hNQGpp3f56kIlPuo6NpDnR6Qvi7puD5lhIccVeETyY+aPu+3W7+IOG1JvBfbZt1BCKdd S9ZQ== X-Forwarded-Encrypted: i=1; AKwUvBxak8xW1jMblkSPWAeg/suHm3hYBgeG/L0PT58+2CnKwR56KoBHa1Qz5gaWov9oJF2TOmoaHtFH7ysNfwk=@vger.kernel.org X-Gm-Message-State: AFuF++lrnXOdk5ofXgIXm6+xmT868nm3EjcdJRPpY/Vr0iAxX1TFkjj0 MEbXRURvrGId21go8fJ2aYHJFHbYOhOBjjvF32On/4Xk1SPnGHSg46xd X-Gm-Gg: AYBFou1ZVujzvcQXh87rGf8rVsTdka0dr1YWGGIGYYWxyH97tqP8zKIW3ChYh1qFMrl LHb94tqFexm4xsbucMyjsapYjP5WxC5w5Gj+wfT89+dQFwFWKsxdIPi7D/s4SlXgguAdpTwEXij JklnxJ5djMo0WS5v7f0KWtJ6T14HxsXtTJiQNJLSnyVb9saDjpFaRnVcfMW2Kd2CT7wHWS81aHS YDXGtQm7UzUOIIMUMFPCxnU/0FyicgLjZGJYxub3c9vEUqNrr/pgFcweyK9VkfT1sIzpua5TP6U XnUUpkQ0vy/W8IqMGHxaDOFLOEVms9VBsoFqnYAmHvwxCjZEMZeV0DBrDU77qt/71KY/ddMZWGw fl5hZl71ZzDH2RCwxgjeOW2tWeGG6r1DDMYTxVOiqRfOxAkXz2hfCfJvkdACjjFZeGJQA7t3fSa nycTUw4A4z/mf/rLrVkMFR78JunyEz9P23C6V4soCN4yd/Iuk4h50b63fOrKsxRXDT/z9EXLPC1 hbVDuR7NXS4HL7nPAzbT0vXaP+xAlWAE6QQJt2fR0f+fq5u8wIJJJWMstHKpYq+KS+byNnkunuU GYscGQEYyhXWGQ4= X-Received: by 2002:a17:90b:5292:b0:398:e969:87ef with SMTP id 98e67ed59e1d1-39d70b7d864mr10327996a91.24.1789045108156; Thu, 10 Sep 2026 05:58:28 -0700 (PDT) Received: from phuc-desktop.. ([183.91.15.56]) by smtp.gmail.com with ESMTPSA id 98e67ed59e1d1-39d7e77b1afsm4891592a91.5.2026.09.10.05.58.24 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 10 Sep 2026 05:58:27 -0700 (PDT) From: phucduc.bui@gmail.com To: Mark Brown , AngeloGioacchino Del Regno Cc: Liam Girdwood , Matthias Brugger , Jaroslav Kysela , Takashi Iwai , Cezary Rojewski , Cyril Chao , Kuninori Morimoto , Dan Carpenter , cassiogabrielcontato@gmail.com, linux-sound@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-mediatek@lists.infradead.org, linux-kernel@vger.kernel.org, bui duc phuc Subject: [PATCH 06/13] ASoC: mediatek: mt8189: Use dev_err_probe() for clock errors Date: Thu, 10 Sep 2026 19:57:35 +0700 Message-ID: <20260910125742.150902-7-phucduc.bui@gmail.com> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20260910125742.150902-1-phucduc.bui@gmail.com> References: <20260910125742.150902-1-phucduc.bui@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" From: bui duc phuc Use dev_err_probe() when obtaining clocks to avoid redundant error messages, particularly for probe deferral. Signed-off-by: bui duc phuc --- sound/soc/mediatek/mt8189/mt8189-afe-clk.c | 7 +++---- 1 file changed, 3 insertions(+), 4 deletions(-) diff --git a/sound/soc/mediatek/mt8189/mt8189-afe-clk.c b/sound/soc/mediate= k/mt8189/mt8189-afe-clk.c index 435914aafb44..4997031cbcab 100644 --- a/sound/soc/mediatek/mt8189/mt8189-afe-clk.c +++ b/sound/soc/mediatek/mt8189/mt8189-afe-clk.c @@ -793,10 +793,9 @@ int mt8189_init_clock(struct mtk_base_afe *afe) =20 for (i =3D 0; i < MT8189_CLK_NUM; i++) { afe_priv->clk[i] =3D devm_clk_get(afe->dev, aud_clks[i]); - if (IS_ERR(afe_priv->clk[i])) { - dev_err(afe->dev, "devm_clk_get %s fail\n", aud_clks[i]); - return PTR_ERR(afe_priv->clk[i]); - } + if (IS_ERR(afe_priv->clk[i])) + return dev_err_probe(afe->dev, PTR_ERR(afe_priv->clk[i]), + "failed to get clock %s\n", aud_clks[i]); } =20 ret =3D mt8189_afe_disable_apll(afe); --=20 2.43.0 From nobody Fri Sep 25 16:50:46 2026 Received: from mail-pz2-f12.google.com (mail-pz2-f12.google.com [74.125.228.12]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id A1E1648CD4F for ; Thu, 10 Sep 2026 12:58:33 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=74.125.228.12 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1789045115; cv=none; b=cAoP+zR1Ijkpjw5t7E++lanw/YwdRlwZcpoe0UbNMZVTbJOC7pCx2Ec29by6GBxtKFB1qeQP1zlUBHiC2P/Bs+BEpcQSkwH4IeIaQJEWr4DLV2uDpRCg03ZbmIfqYsqmbA9cc7zT1DkWqtBQEjDAW60NW3tRi3B085/CsGgHaOU= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1789045115; c=relaxed/simple; bh=yM4L3d5xAxA3ZdEO3lRnqdCQHhz1gw6fuQgVMe41j5I=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=EEYx5DGFxh22dpBcgf0tivYM0jODtCgnSdT+ImI21XEdT1CRtSZQyfkkFdeR7HnYixlKxaJ0Uv1nuZKTUeR2iP7WIT4qz/JfyxlyH89c1wQGahzYXRgLiJg6332bFELu5tuIpUZxT4Q2Dr/05FfX0lzqsbYKAyQhI/ExtbiAbUA= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=skQAj1+4; arc=none smtp.client-ip=74.125.228.12 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="skQAj1+4" Received: by mail-pz2-f12.google.com with SMTP id 41be03b00d2f7-cc4bdf8acd6so342002a12.1 for ; Thu, 10 Sep 2026 05:58:33 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1789045113; x=1789649913; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to:content-type; bh=X0f+3hmpde177tradfD9iqffBrSGUNX0UYvHhWMmKXM=; b=skQAj1+4eJCaWdBS4pZ/idL7FrFydoXhJKy8mgLTV1REAiLYGCN821dfRHngaWgAiz yF9GVXEv/yTMsMG5EBCC7zb4h/yURwTvrq4CeBPV9doYYSdY6FULvUgHEzZoIsNBylwL dub7fSmlYlgyNqE07mxsxujxAR4rvku6xCykfkdfKyOBqCKPIF2mGTOQxLMh03L6J3EL E6X3zH3F1b8aZHw/zfms/tsQ4SECk2fGREBZdidZT/ZH0TMMC7dXoqw+L07f6EI/1sLN U29zBeB2wzkjwz8+tHeFBzNXcL/GzCoinWWfNPezSrZN00oTCRVBzetJ/yUJO34qvP8I 3SWw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1789045113; x=1789649913; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to:content-type; bh=X0f+3hmpde177tradfD9iqffBrSGUNX0UYvHhWMmKXM=; b=ZNtBmlRB+FMv6fX8uC7tw7lCD9qsmM78GR42dVqjLNhOOQVeHMCIy9M4KBs9vqTrzN VoAfslTCSr0xZEBw2/2LPN6vPWYG5n0klMk1NMpcpTTSVXmonzD2Q/7fWKlV4i3kIils YXhObDqapZlxN3tZH+eFeVgKu2k/uhclxIGtZcE1MWMcDjYLGEKQavHH8onV7HHJ+5hv cv1YvaqVu4f1cdJ+SU05Njxp5VJrJ2UPgvQjZq4j3MOqv24cpVXHL0/2MiYqDbnep+wk LltYqh+q89R9HqXW3YIHAB9qQKM3l0uKCYTFjI42Ro82F/rTcrUNhrRk2OekHbmif+6H lRdA== X-Forwarded-Encrypted: i=1; AKwUvBx1T1NPSzeXLLTLDlW5leLlpZpNrSMcT9MUviFTq2H4mlzHBoVkgIDAw7e2607Eo+WFM+CjTSQrpLOWRqM=@vger.kernel.org X-Gm-Message-State: AFuF++lKiNVp9D8SA79mBZppDvacBaIlL9/vIk9PnBbp0aZt+1y8owJC e6PrjmcyzdpZ5iS5h8R4LHYhJjVunUCZNT16CLpx6GR3OiOaECdzg7R4 X-Gm-Gg: AYBFou3I2OJuvbTa2DTUx9wpdEgLGgJMmtHYQ7iQ92JTJWE9pTH7gpeTYCFkY3ur65Z P9SFawHIiHnXu14BOcjiTwnNANdO/e9LMyAIlm4Vcv3lGq3A37g3OKSQ9EcHbgsibb7Wil7fpaF ZJFJhvPHdWORcJx4+OqrLBk+WZSmqSGGVu7O0f0K1QqD8KdgKLE7TvAHOCXj3snGrN9xz3uIS9P 09wOQrwV08A0Y6SVWQxcIPgg15Ybk3pzCGmHXXy1g0GQRMcpi3DZE9xwY7NdYasuzZJPZzqxmd2 ZZXkyoMBKSdNsXE/9k/zPDmWOMNYpuF5MEkg0oxDwqAngH7Mjd/Z84RXu4ckBfDfn9L6emB+trK vf/RWYa1qt815TA0GDLeT0IkDbGf75iBZqCtt7I1iQfH5AiOvJv1NGxH4Ft7ZLZZI6RInFpQYaV oLlVhyDY/891fXYMpJAROfN7PI1k1iCPJ2thfjsnevup9XnOspouAng+Bg+y/ypddYJJ1ob7YFD Bn6WpWVuXBN16L/2/vedG4y1Z+D53lwSlaGJQ1k256G8OGevKJ0udKU+zbkbf34qDiblQ0BmLM4 oCmvwqitGJ0+fwI= X-Received: by 2002:a17:90b:3c4a:b0:39d:6f12:fd47 with SMTP id 98e67ed59e1d1-39d70bb2226mr11925208a91.20.1789045112679; Thu, 10 Sep 2026 05:58:32 -0700 (PDT) Received: from phuc-desktop.. ([183.91.15.56]) by smtp.gmail.com with ESMTPSA id 98e67ed59e1d1-39d7e77b1afsm4891592a91.5.2026.09.10.05.58.28 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 10 Sep 2026 05:58:32 -0700 (PDT) From: phucduc.bui@gmail.com To: Mark Brown , AngeloGioacchino Del Regno Cc: Liam Girdwood , Matthias Brugger , Jaroslav Kysela , Takashi Iwai , Cezary Rojewski , Cyril Chao , Kuninori Morimoto , Dan Carpenter , cassiogabrielcontato@gmail.com, linux-sound@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-mediatek@lists.infradead.org, linux-kernel@vger.kernel.org, bui duc phuc Subject: [PATCH 07/13] ASoC: mediatek: mt8189: Propagate runtime resume errors Date: Thu, 10 Sep 2026 19:57:36 +0700 Message-ID: <20260910125742.150902-8-phucduc.bui@gmail.com> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20260910125742.150902-1-phucduc.bui@gmail.com> References: <20260910125742.150902-1-phucduc.bui@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" From: bui duc phuc mt8189_afe_runtime_resume() currently ignores errors from regmap operations and mt8189_afe_enable_main_clock(). Propagate these errors and clean up the state before returning the error. Fixes: 7eb153585598 ("ASoC: mediatek: mt8189: add platform driver") Signed-off-by: bui duc phuc --- sound/soc/mediatek/mt8189/mt8189-afe-pcm.c | 36 +++++++++++++++++----- 1 file changed, 29 insertions(+), 7 deletions(-) diff --git a/sound/soc/mediatek/mt8189/mt8189-afe-pcm.c b/sound/soc/mediate= k/mt8189/mt8189-afe-pcm.c index 77cf2b604f6c..431320719b63 100644 --- a/sound/soc/mediatek/mt8189/mt8189-afe-pcm.c +++ b/sound/soc/mediatek/mt8189/mt8189-afe-pcm.c @@ -2328,24 +2328,46 @@ static int mt8189_afe_runtime_resume(struct device = *dev) =20 if (!afe->regmap) { dev_warn(afe->dev, "skip regmap\n"); - return 0; + ret =3D -EINVAL; + goto err_reg_rw_clk; } =20 regcache_cache_only(afe->regmap, false); - regcache_sync(afe->regmap); + ret =3D regcache_sync(afe->regmap); + if (ret) + goto err_regcache_sync; =20 /* set audio 26M request */ - regmap_update_bits(afe->regmap, AFE_SPM_CONTROL_REQ, 0x1, 0x1); - regmap_update_bits(afe->regmap, AFE_CBIP_CFG0, 0x1, 0x1); + ret =3D regmap_update_bits(afe->regmap, AFE_SPM_CONTROL_REQ, 0x1, 0x1); + if (ret) + goto err_regcache_sync; + + ret =3D regmap_update_bits(afe->regmap, AFE_CBIP_CFG0, 0x1, 0x1); + if (ret) + goto err_26m_req; =20 /* force cpu use 8_24 format when writing 32bit data */ - regmap_update_bits(afe->regmap, AFE_MEMIF_CON0, - CPU_HD_ALIGN_MASK_SFT, 0 << CPU_HD_ALIGN_SFT); + ret =3D regmap_update_bits(afe->regmap, AFE_MEMIF_CON0, + CPU_HD_ALIGN_MASK_SFT, 0 << CPU_HD_ALIGN_SFT); + if (ret) + goto err_26m_req; =20 /* enable AFE */ - mt8189_afe_enable_main_clock(afe); + ret =3D mt8189_afe_enable_main_clock(afe); + if (ret) + goto err_26m_req; =20 return 0; + +err_26m_req: + regmap_update_bits(afe->regmap, + AFE_SPM_CONTROL_REQ, 0x1, 0x0); +err_regcache_sync: + regcache_cache_only(afe->regmap, true); +err_reg_rw_clk: + mt8189_afe_disable_reg_rw_clk(afe); + + return ret; } =20 static int mt8189_afe_component_probe(struct snd_soc_component *component) --=20 2.43.0 From nobody Fri Sep 25 16:50:46 2026 Received: from mail-pj2-f12.google.com (mail-pj2-f12.google.com [74.125.227.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 14C7B48C402 for ; Thu, 10 Sep 2026 12:58:38 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=74.125.227.140 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1789045120; cv=none; b=sr5o8dn3lgQlDO5jWzBAv+jedJ+hx6XGelZcd4yLJil4pzjCOudEZVi8Kua3IN3/QMXHUPeJWSs2YDhMdRJ+lVcvpBoaDrzyqpjTPCiTnANf3smAQQgZabTHW2gOZIAVpnxptuCEceZ+lHDNzG9zBp6fNZNOit6Utv205cVeRnM= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1789045120; c=relaxed/simple; bh=EMTf/inp7tRn7qQQ56C9Ys6vtY7gDfXQI6g14oe4GtU=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=gtlvNsW2mOl03QXxQJnacWf3XZ08khp5dTvzLDGEhooP7ogXgwNtxNlQ4huhAGbz5z5uEtmKgnCTQLxMLroR25LzRyUJKnMaEDuQyx41kY22ICn+HPlyrhyGYQf5oGq4FfkMw4ZEiuf1AAq6aofaMI6hcsPwjgsG+q4obHtGD3k= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=jP8bPZWp; arc=none smtp.client-ip=74.125.227.140 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="jP8bPZWp" Received: by mail-pj2-f12.google.com with SMTP id 98e67ed59e1d1-398c066106cso1155933a91.1 for ; Thu, 10 Sep 2026 05:58:38 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1789045117; x=1789649917; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to:content-type; bh=ueFbq8+vEvSr27HopAfMc9ldfFuJNT5gbHVBZLkrJAw=; b=jP8bPZWpn1xRFYPQmHfJnInTgdORqiu+BJdHR3mPuORZn1PzAMlS7hmPzM0uzce9x6 Vcq6dlA5MoAbbXhZQ2E8mznOZhkzEp6ciMK+jvdjguCT23WTLSuzSwjQLYJ8xns8mLkr AuOipdjV907yfNaVuSySlkZU4oLI5e4/R2EUWi78dLAAMuzR0yjfR/DcW/PNjYItlCJt uIN1WyHFGgqAQgswyP2LBAoDVivwIvcdkYznmh5Q/5wXFUGXjsDUlpboH2SnHhPWjn26 dLmdj4/m21+awFVqag5di4UpKVHH89CmQQ2R/1UbdkrE+PZmBH2vyMfO0s2J/oAT+Uql w0PQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1789045117; x=1789649917; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to:content-type; bh=ueFbq8+vEvSr27HopAfMc9ldfFuJNT5gbHVBZLkrJAw=; b=R1lbbwMDdyeZGytonzRwelbI1sVfS/v6+R+K+/UVGTpgOxUKtpyPPj4D+ggpzn/5uj gBw4xucLtJLLjc63XZzh1JClVdQJkrSihklEtphAKlyA8jJTxJftMfO1UL3BVpmJbCBZ Tsxf26sGl8O9xxIJZj9y0l7Fju+3hvLo7D9V1+uHvru+rRaNnYWYD5gAu/QWneCawiJQ Y6SvOTI979CwMQhx2wBdXYiu/9tBOOGe7m/+IfUqspEVjDqhZjP0The+eixEgMFoXLKg s+T/VbDUIJe/eHzov7yIe3H2mODx3y16Rv5ygxlC43u7XVAsV5rsFk7hBo80p/8ObfNl 75wA== X-Forwarded-Encrypted: i=1; AKwUvBxobFM5dP39/6eIO17G7xVo0Mn5jUJ7UXCur9hFzsTX9Ff9eR+Iu8pT4rATuc2sWwtErs1X76rezDSznbk=@vger.kernel.org X-Gm-Message-State: AFuF++mGWi6fxsOAnOTzkfXVKuc4EVTDQqKvcXkpDA4xUFOA8f0J0oTD gr6Ru7Et5J6l8hPbRUa6ShWpR7+s5iiJW20V8owN+yI2W59GUAS2Yfvo X-Gm-Gg: AYBFou3CGA8JiBgkXOTJFcpXpnmLPqKk2YnK7R5Ig+24INnjSGM85nExxfvS2DFdcb3 iCo5aNRt2XagP2VkgnArPM8vHXWVQT/GxXVwKj3C5fuaafSbsUleiDEcSm0/w3IiGpNmRmjKWJw AOtzDR2fpTXPPkv1WGnmYIRTJj0ZapVKi8gT0WbKOWEU2/7Gn+FZlzpS2zz4tuWJIUfHLfpniqY Pp/e2K2fuBEH/m2dBXmL1EuYKraBIaIoWDE6axcAmTymAc1rQ8lYvI1R8hwAnZRgtb5EfzqJjBU Sp71kUftfNibBi/lHwIgVNZZ89Co+s1U7oGhnumDOj+Uxwsh6+G9IC3ZaaMpywSMfx5c2Q9hxqN Wsls2yhshBkUq4ZbXst2/ao/FzxL0/WM9wamc6KWrFqh6RGrz93UCgF6EPXLyUM41Mhgl2KLkgx VchoxfECJckCpu03KkKgHC7R0BANnxgnK/Uzk9SnD5uKuIrXc5hA72dhNi2XaAfjEAtMS0o0aLi tMtOuGiiRjKhiqSqJP5G6Kmv9K5u9LuU/VNDkXbI4fJN9KldYN588asm/KoqpSXXyKs6DQsXX4x GCu1YGSclhd/AUo= X-Received: by 2002:a17:90b:57e6:b0:37d:f206:a2ac with SMTP id 98e67ed59e1d1-39d70a34abcmr11658680a91.7.1789045117218; Thu, 10 Sep 2026 05:58:37 -0700 (PDT) Received: from phuc-desktop.. ([183.91.15.56]) by smtp.gmail.com with ESMTPSA id 98e67ed59e1d1-39d7e77b1afsm4891592a91.5.2026.09.10.05.58.33 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 10 Sep 2026 05:58:36 -0700 (PDT) From: phucduc.bui@gmail.com To: Mark Brown , AngeloGioacchino Del Regno Cc: Liam Girdwood , Matthias Brugger , Jaroslav Kysela , Takashi Iwai , Cezary Rojewski , Cyril Chao , Kuninori Morimoto , Dan Carpenter , cassiogabrielcontato@gmail.com, linux-sound@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-mediatek@lists.infradead.org, linux-kernel@vger.kernel.org, bui duc phuc Subject: [PATCH 08/13] ASoC: mediatek: mt8189: Remove redundant error message Date: Thu, 10 Sep 2026 19:57:37 +0700 Message-ID: <20260910125742.150902-9-phucduc.bui@gmail.com> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20260910125742.150902-1-phucduc.bui@gmail.com> References: <20260910125742.150902-1-phucduc.bui@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" From: bui duc phuc The errors handled here are already reported by the called functions, either directly or deeper in the call chain. Therefore, the additional dev_err() and dev_err_probe() call is redundant and can be removed. Signed-off-by: bui duc phuc --- sound/soc/mediatek/mt8189/mt8189-afe-pcm.c | 13 +++++-------- 1 file changed, 5 insertions(+), 8 deletions(-) diff --git a/sound/soc/mediatek/mt8189/mt8189-afe-pcm.c b/sound/soc/mediate= k/mt8189/mt8189-afe-pcm.c index 431320719b63..9335a9e44665 100644 --- a/sound/soc/mediatek/mt8189/mt8189-afe-pcm.c +++ b/sound/soc/mediatek/mt8189/mt8189-afe-pcm.c @@ -2488,13 +2488,12 @@ static int mt8189_afe_pcm_dev_probe(struct platform= _device *pdev) =20 afe->base_addr =3D devm_platform_ioremap_resource(pdev, 0); if (IS_ERR(afe->base_addr)) - return dev_err_probe(dev, PTR_ERR(afe->base_addr), - "AFE base_addr not found\n"); + return PTR_ERR(afe->base_addr); =20 /* init audio related clock */ ret =3D mt8189_init_clock(afe); if (ret) - return dev_err_probe(dev, ret, "init clock error.\n"); + return ret; =20 /* init memif */ /* IPM2.0 no need banding */ @@ -2528,13 +2527,13 @@ static int mt8189_afe_pcm_dev_probe(struct platform= _device *pdev) /* request irq */ irq_id =3D platform_get_irq(pdev, 0); if (irq_id < 0) - return dev_err_probe(dev, irq_id, "no irq found"); + return irq_id; =20 ret =3D devm_request_irq(dev, irq_id, mt8189_afe_irq_handler, IRQF_TRIGGER_NONE, "Afe_ISR_Handle", afe); if (ret) - return dev_err_probe(dev, ret, "could not request_irq for Afe_ISR_Handle= \n"); + return ret; =20 /* init sub_dais */ INIT_LIST_HEAD(&afe->sub_dais); @@ -2603,10 +2602,8 @@ static int mt8189_afe_pcm_dev_probe(struct platform_= device *pdev) &mt8189_afe_component, afe->dai_drivers, afe->num_dai_drivers); - if (ret) { - dev_err(dev, "afe component err: %d\n", ret); + if (ret) return ret; - } =20 return 0; =20 --=20 2.43.0 From nobody Fri Sep 25 16:50:46 2026 Received: from mail-pj1-f47.google.com (mail-pj1-f47.google.com [209.85.216.47]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 258D1489FB6 for ; Thu, 10 Sep 2026 12:58:43 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.216.47 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1789045127; cv=none; b=HYdn0aaJOfbGIOK4XGVyrF7n5AtNdueS5ONPgGBpj2xo30OekGJBDojjo8AjVMBQZSG1AsHAcs1pgAoTw7p4J1TIVyVo2Mz9Y9e4FZ6B5Sk1UF0BTCV+YvF2h92IT8WVGch5NHlHfRfk/CnMnny7EDdn6MhxEhE1cNm/kYuR794= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1789045127; c=relaxed/simple; bh=Wfj7ayzlWfEu+I8dT6gg9Qx37En8fvuHsBJbQGPJEIc=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=uOSBh6XZU3bpWDwsFH56aGpPYwlyAufpA4ojaUOoEGc457jpHcV5p0S01JiRmuISd1XcCcqxjPSm6PENuFoTVHh4Xb+56IJIv17r28r1dgxlbS1bxHj2nAat3nzM/mJ9JDOzSslTw6mmSceIngtEwMOs/o4/ZH39T+tzeg4WcSw= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=Ct57quuM; arc=none smtp.client-ip=209.85.216.47 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="Ct57quuM" Received: by mail-pj1-f47.google.com with SMTP id 98e67ed59e1d1-398b3c37877so6573844a91.0 for ; Thu, 10 Sep 2026 05:58:43 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1789045122; x=1789649922; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to:content-type; bh=qB6h8bEY4JQqTm9X+KYhPwqJjNuxDZMSiRPIGrpZWzc=; b=Ct57quuMxyD2hHz3lF4kxqr7Gj+MBJ3uJIZGzCkp5B4WESkKv93MK+UoB2j8xWb1sa uXyu48K85yY61cO6T6pJVm8UVKXhdCF6IDiTq1aECDVm/ATJHOy/qLUWlB0lEGP7uK2k 8BD3QeVvaUt5e32t5ylR7P8V2AYGNS3HMjPTcjb8HV8k5qJwGIZ+eL8cJ4nHBQvKpGUE UoZzVD1S1HlFHDEJkPdENIMqYubElaD+RUjGe0A7K8vaLhkYMNRpglUDEVmduY9qQX+G JJBhXCFE4kq2nV+m8LWChMF8nD8ImhUOCPoWxO6/oNMg+8Ojts8pZ4dXpaNAlbbw3msg mfzQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1789045122; x=1789649922; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to:content-type; bh=qB6h8bEY4JQqTm9X+KYhPwqJjNuxDZMSiRPIGrpZWzc=; b=GNdci0O/9mPdeIuR9w/T18C6RW8fkoYLK+Ls3jaIpxyqw3E/UWogoo9vT+AptlYC9+ ewKNBPVSYMmNyY9AHlXoA0074KzQEyO0OqoLGsf2Ct3sVKCmP+InSN+s1H0+i/V/jwmX yn4Sbmu8cePnwYk8ci3rtXuGdYrhnVzx6G+zkdSObGlSGrIf5pZNQZpvf+KPiXHlCg4o bzuLuhUlZqEe2onMWes57nwY3u9o6Rf2YWaaSyEvoLYvbtyOCNUE9ojEjfVTTEEBlz4W IPV2SEzDsFMvs5KhVmdwkLLtwM2h8SQc1SY0jPDwYYS83/BAX2UEFWwLc4aUOokgeVX8 i4jQ== X-Forwarded-Encrypted: i=1; AKwUvBzurkS/pG4FyykU4RGLtJX5xhi/m9eMB99ElcwbG1L4SYfjEsAHNxkJ8zTTrbRdB0f+PqdYWd/5sJ0RUgg=@vger.kernel.org X-Gm-Message-State: AFuF++lvnYxpeEIJhjuR78wnVst3c2S5bZlR0G+QXRONoxe+/qnS6Gzf ZH01ePFBx/lLG5vqfxkijVL/8iQjj/wEY48PaHu53v/nbyIdvJghYeeC X-Gm-Gg: AYBFou1nIuBUAx95VEETT6NWqtK1wmlKcY3fTBLGeqkMNphWqH1hEZwTEYYydOF70NN iUZPJFpbt2008oZFzRootUXtIj/lF9Ch0wEzw85ZtTGwdv6s7FOnBVVkbtM1QIxWKHZX/6ralWW e9uU/wJYe0n3IRD4Mkb7odX7M/TjlZ8qApoQVFCLxfAy52uqOWJEqb9G0S0a+F9bmNNR/CIE93Q /7dsJKiShd27UpP4qii0llYgW7HtMUsEs7QFfFLwx8RQkTjnc67S5mKQhSF6uMz5sXJ577x90Nf d0bZidiBHy5i52HSmq7Z0nfI/BpaBIBj4nl3Kq7875NPJQZGHwWmtDjmADK6XNripluwyHdDLSX Bvg+lOEhjBJsDxv//Wv75gPIQHYW3W4xLFY1VIHPYWBOvE/EaLufPArhLB5W9IR6jdaR1Leqocf g/bdGM/WgzjZEKCwAk+fwam9HEYdmY8dH2SXleLyxGLLpMOWzLZ+vcSvkusBAqOX+JQF+xDIIas jHxhYMuRactFvXBWvmv7kfi+CDy4C/m3UkITmOP2R7RI7hSRjVgb/W8SYN484GWLDCtycsgbV/O ESKB3jnHx1jAvXNctPzv7Pxikg== X-Received: by 2002:a17:90b:3b52:b0:38f:18f9:785 with SMTP id 98e67ed59e1d1-39b26101d25mr61915384a91.8.1789045121712; Thu, 10 Sep 2026 05:58:41 -0700 (PDT) Received: from phuc-desktop.. ([183.91.15.56]) by smtp.gmail.com with ESMTPSA id 98e67ed59e1d1-39d7e77b1afsm4891592a91.5.2026.09.10.05.58.37 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 10 Sep 2026 05:58:41 -0700 (PDT) From: phucduc.bui@gmail.com To: Mark Brown , AngeloGioacchino Del Regno Cc: Liam Girdwood , Matthias Brugger , Jaroslav Kysela , Takashi Iwai , Cezary Rojewski , Cyril Chao , Kuninori Morimoto , Dan Carpenter , cassiogabrielcontato@gmail.com, linux-sound@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-mediatek@lists.infradead.org, linux-kernel@vger.kernel.org, bui duc phuc Subject: [PATCH 09/13] ASoC: mediatek: mt8189: Propagate APLL errors Date: Thu, 10 Sep 2026 19:57:38 +0700 Message-ID: <20260910125742.150902-10-phucduc.bui@gmail.com> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20260910125742.150902-1-phucduc.bui@gmail.com> References: <20260910125742.150902-1-phucduc.bui@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" From: bui duc phuc mtk_apll_event() currently ignores errors returned by the APLL enable functions. Propagate these errors. Fixes: 7eb153585598 ("ASoC: mediatek: mt8189: add platform driver") Signed-off-by: bui duc phuc --- sound/soc/mediatek/mt8189/mt8189-dai-i2s.c | 7 +++++-- 1 file changed, 5 insertions(+), 2 deletions(-) diff --git a/sound/soc/mediatek/mt8189/mt8189-dai-i2s.c b/sound/soc/mediate= k/mt8189/mt8189-dai-i2s.c index 94c49a662e2d..4826ee250d70 100644 --- a/sound/soc/mediatek/mt8189/mt8189-dai-i2s.c +++ b/sound/soc/mediatek/mt8189/mt8189-dai-i2s.c @@ -485,6 +485,7 @@ static int mtk_apll_event(struct snd_soc_dapm_widget *w, { struct snd_soc_component *cmpnt =3D snd_soc_dapm_to_component(w->dapm); struct mtk_base_afe *afe =3D snd_soc_component_get_drvdata(cmpnt); + int ret; =20 dev_dbg(cmpnt->dev, "%s(), name %s, event 0x%x\n", __func__, w->name, event); @@ -492,9 +493,11 @@ static int mtk_apll_event(struct snd_soc_dapm_widget *= w, switch (event) { case SND_SOC_DAPM_PRE_PMU: if (strcmp(w->name, APLL1_W_NAME) =3D=3D 0) - mt8189_apll1_enable(afe); + ret =3D mt8189_apll1_enable(afe); else - mt8189_apll2_enable(afe); + ret =3D mt8189_apll2_enable(afe); + if (ret) + return ret; break; case SND_SOC_DAPM_POST_PMD: if (strcmp(w->name, APLL1_W_NAME) =3D=3D 0) --=20 2.43.0 From nobody Fri Sep 25 16:50:46 2026 Received: from mail-pj2-f12.google.com (mail-pj2-f12.google.com [74.125.227.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 0C0934908B2 for ; Thu, 10 Sep 2026 12:58:47 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=74.125.227.140 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1789045130; cv=none; b=DyjTe7rKmrzrVaCmqMfpV+jGOfq1KeFU6ebrXeUwqUKup/UOT7aTflXz8zmXMk9dAQnlI7Gt7pYYYO2jJvOKctYHFbcCykQGW14vv8RT7q/fRfZaGWT0aiNxVaPys63Nnb6FD4x7MowtC7wC1i/BVm6KMg08RpWHucKD8uuMnL0= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1789045130; c=relaxed/simple; bh=L2LE+CaRB/r8u7ksh8vaBEGwU4XGfFxUrv1E4QN5LbI=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=l40bD3msSLIhEXsgjPtriFHQQR/NOAujbJON9E52BK00STDq+XRxUq8BcFNAJK/sN/79jARvpQ0QLKx1rPqzB7o/yEGLWahI0/aycHjR74lj1s5D0Jh2Oln9m2aYeMo688l9hYT9DyJj6bgf85QeowzawLvKXDFDWQ1NjWykeVg= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=ZijXHL49; arc=none smtp.client-ip=74.125.227.140 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="ZijXHL49" Received: by mail-pj2-f12.google.com with SMTP id 98e67ed59e1d1-396ccd78e6eso1126813a91.0 for ; Thu, 10 Sep 2026 05:58:47 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1789045126; x=1789649926; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to:content-type; bh=PGiDmxTKSnaxUwBF7nwBu69cnzbPnmVOgMWHLivqaTs=; b=ZijXHL493SAwG8pbxmPvAaTdsYslEMrAGHVASctHIx4v0Ma2NUaWDGTjDRW1oYgJQ8 Gz5zVZn6bNBfZhBM1raKicpEDOOIq6z95lMcqivaoUXjhwlquC0WGBz7fIOgVm/PF1Ms 6BjxRmqJ9U/x9IT9rt6DKG3pieinWVgCCUXeQDD/G824s8eYg+bzGe6M2ODNW59InNNU OuH979xmwWk6EqI9weG0HjHuHH7e79NjB9E9Dn6RXLTWiDIpaNCKjaozCmElUhS1nbYc 6R2U4AlaBzlMp6GxKvsd0LE2Ns0BQYpxIMnuxmLtkYC9DwxMy1/gnEy1rEyO4gyYDMW3 ALsA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1789045126; x=1789649926; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to:content-type; bh=PGiDmxTKSnaxUwBF7nwBu69cnzbPnmVOgMWHLivqaTs=; b=PRERFTlDCo4pjYss8CnCfX3pQdWPWUnVb30q9999tPdpjTta3RybdR8BIYK90oMm6R N8CuARA5kskinklG3EKmgyiHHb/neWaaSwCTdIVE8PpN5ii569v/A/IeFZseAfVyBC0W Txpfsp3B4FLIdI4Aq4vWKh7a6/IqAIh/OzGNjHgoGZeGNWN81YVmsBW83MCXLCyM9kX/ li0jOIks0NxfLcCJcvbnS3dUsz8RBw4VjhhKI+MOZ31Wyym62Fd7L7wXJXRF3jmRW/my flwdScm/OqfdFz5UaSBnPDwxy28yYGTT0E+0QGVkuOwYy+PH6ho1XcWybvbw/D7tRXSL kvTw== X-Forwarded-Encrypted: i=1; AKwUvBw7TeJlIfO1ecB5BrLlviZqldZY4kUf41LkESvVlPBs/K/r6hEz6TfwxRxHS32FzZgUlO+Kmao/pvSGSgI=@vger.kernel.org X-Gm-Message-State: AFuF++klQ93GsOOMQEFzG713hBaJS3PvNzRMMBRoSSNBefNOh3MOprqR GYqTH2MoTSp32ysE8qY1AMJ7QNrBwMFi1oAS+uvHVujK+WJtA82AtKlL X-Gm-Gg: AYBFou1Z3vibJP3pLAbVATR7+zUztXXsI+9L62kwiRjrA5WnM2E38/6D5GH0WuIzaF3 C4WzId/sWw+OqzMRGymZrWG8GTKYDJKDB0Vh3Kvkh0gHWwRMa73OH6OFCxTbo95ABM/z5GyxQ8Y EbLrDZvkdVULwr2nU9WBqyAUMtAr1RtFAko9cRPTkiAMUV0mcJnwJcABdHj7kFAWQxaDEerqvch x56ilLpagcg+WY30J+wkazMYXM85ldGadtpVD4n+e15K1mYnm57/GyBgnpJhro5RE9FW6SGiThO Tomgzfpe4wvhj0IGE5vtU/PsM1Ts0ecarKtfZ782WVey+N5HSZBwb/YBSFKmUHQmsLm9kFf5SD+ /EDsnzxhMWLrhjmNvOe/emv4Cz8kyYyNWB1cxBA37nOrHPw5aT6STfBrKbkrISOJ/GlAFlZmtsn MEIxvaQ4+ma/0yFIJh8HTtUMPpeFHJkIi7YCOC8REvbegYLEcc3AQcbPGxfP7YHSeyg+sT91nTt ERg/e0QEzQjzx1fXJV+6TRk/4DpUL2lWkm2vJZuq3aycCyFp2eLKWXqpOX1iRRnLlFCCBfIsGfO 1AFdL5pJLLSutJ3koOJVUTWPFQ== X-Received: by 2002:a17:90b:5485:b0:395:8124:ac53 with SMTP id 98e67ed59e1d1-39d77a1d83bmr3896223a91.6.1789045126242; Thu, 10 Sep 2026 05:58:46 -0700 (PDT) Received: from phuc-desktop.. ([183.91.15.56]) by smtp.gmail.com with ESMTPSA id 98e67ed59e1d1-39d7e77b1afsm4891592a91.5.2026.09.10.05.58.42 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 10 Sep 2026 05:58:45 -0700 (PDT) From: phucduc.bui@gmail.com To: Mark Brown , AngeloGioacchino Del Regno Cc: Liam Girdwood , Matthias Brugger , Jaroslav Kysela , Takashi Iwai , Cezary Rojewski , Cyril Chao , Kuninori Morimoto , Dan Carpenter , cassiogabrielcontato@gmail.com, linux-sound@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-mediatek@lists.infradead.org, linux-kernel@vger.kernel.org, bui duc phuc Subject: [PATCH 10/13] ASoC: mediatek: mt8189: Propagate MCLK errors Date: Thu, 10 Sep 2026 19:57:39 +0700 Message-ID: <20260910125742.150902-11-phucduc.bui@gmail.com> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20260910125742.150902-1-phucduc.bui@gmail.com> References: <20260910125742.150902-1-phucduc.bui@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" From: bui duc phuc mtk_mclk_en_event() currently ignores errors returned by the MCK enable and disable functions. Propagate these errors. Fixes: 7eb153585598 ("ASoC: mediatek: mt8189: add platform driver") Signed-off-by: bui duc phuc --- sound/soc/mediatek/mt8189/mt8189-dai-i2s.c | 7 ++++--- 1 file changed, 4 insertions(+), 3 deletions(-) diff --git a/sound/soc/mediatek/mt8189/mt8189-dai-i2s.c b/sound/soc/mediate= k/mt8189/mt8189-dai-i2s.c index 4826ee250d70..f20dbb410223 100644 --- a/sound/soc/mediatek/mt8189/mt8189-dai-i2s.c +++ b/sound/soc/mediatek/mt8189/mt8189-dai-i2s.c @@ -519,6 +519,7 @@ static int mtk_mclk_en_event(struct snd_soc_dapm_widget= *w, struct snd_soc_component *cmpnt =3D snd_soc_dapm_to_component(w->dapm); struct mtk_base_afe *afe =3D snd_soc_component_get_drvdata(cmpnt); struct mtk_afe_i2s_priv *i2s_priv; + int ret =3D 0; =20 dev_dbg(cmpnt->dev, "%s(), name %s, event 0x%x\n", __func__, w->name, event); @@ -529,17 +530,17 @@ static int mtk_mclk_en_event(struct snd_soc_dapm_widg= et *w, =20 switch (event) { case SND_SOC_DAPM_PRE_PMU: - mt8189_mck_enable(afe, i2s_priv->mclk_id, i2s_priv->mclk_rate); + ret =3D mt8189_mck_enable(afe, i2s_priv->mclk_id, i2s_priv->mclk_rate); break; case SND_SOC_DAPM_POST_PMD: i2s_priv->mclk_rate =3D 0; - mt8189_mck_disable(afe, i2s_priv->mclk_id); + ret =3D mt8189_mck_disable(afe, i2s_priv->mclk_id); break; default: break; } =20 - return 0; + return ret; } =20 static const struct snd_soc_dapm_widget mtk_dai_i2s_widgets[] =3D { --=20 2.43.0 From nobody Fri Sep 25 16:50:46 2026 Received: from mail-pj1-f47.google.com (mail-pj1-f47.google.com [209.85.216.47]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 76DE9492E4A for ; Thu, 10 Sep 2026 12:58:52 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.216.47 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1789045135; cv=none; b=nvboGOqyR+aGu/cSncBUVSbzmuF6mZNIxK0dh5alht0CYkFVZe8YkFGDNSa3DT2amYh24H36pd84ygeOVXczPXXaICIWdWSMGQ5a0bYKaYpnBDO8a27MLmTACscY4dsmPlfzfSUWi5D1OACpt7O7AozYnPKU6ArcnMo60nN1BmQ= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1789045135; c=relaxed/simple; bh=1dO6s+nzXLmizG7uTVM++KB2+NBkZYoja2P36FVZ+3U=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=ReMa9IsyfTBMsakaAT8gORsLoa2+sbeBTS3Qe6xbzGNzOkcro0byaE4DHaFrUNCX00z+o5S1sfSvuFtF8SbSo5e5LB4aks38SQ2jbPE+qf9MhKiHIgf+vFZmZN/wUxa1c5zA9j2gM/Qlq0Sj0QHApRCCf0ZHvhFPBNvRZNHXfSk= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=OmTQlJl7; arc=none smtp.client-ip=209.85.216.47 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="OmTQlJl7" Received: by mail-pj1-f47.google.com with SMTP id 98e67ed59e1d1-38e42560ebcso5488945a91.1 for ; Thu, 10 Sep 2026 05:58:52 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1789045131; x=1789649931; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to:content-type; bh=9Iq4XFZgztZ/SSg/JPxbN63E3iQJmYKZr/24Kl0mWDQ=; b=OmTQlJl71DndygFybkTVyLn72bpPxKFhrocG7ObEYqCG+6OSiBYAqgZnRyYLCULVdC tKbkp1TPz2oEVZV/RguuLSOcbeY/4sqE8k3NkP9aAE8256P6Pidyq8f63v8Hl2EqP2in u3ea4YJFSlvsa5QwzPtt4yU284iBcnrLoNQtWqkc51U8ar2GIHsV3mCvqJnP+e8Dv1Mg 8Tsm5TNsbp8BdlITCBOmw6vvDQ0Wijc7L3HhN704vVvMeNVxCYZxLjuWSGA0yNuPmHzS Ca29JScanFjqmHuYv6Ck2MXp58sPv+LcKk86td5Lhi/W/11Weh3psMrbjSEek6uTfeH4 LtBA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1789045131; x=1789649931; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to:content-type; bh=9Iq4XFZgztZ/SSg/JPxbN63E3iQJmYKZr/24Kl0mWDQ=; b=nBMU0Ps2EgkpWAPW4mTNSGoixxs4dnpFJ+/Pb8Wnf0bCxRv4MlH6bzcZXuKCvBWnJl HkJ5BRjf/S2n0ZmAlidW9rCoSeGeHXaBbCM4XwiOJlf4Sbuk2SToXA8h6ssELNUt1psv lLYPMckLSqJRy/67YUiUM928HQrYGfDRC8C6ReeLtIOwn/JLLGPNb7oKBu1WYcPXMcM3 tPlwSO/YjvM84RM5CqlK1eR8/4f060FVFnsqkfNlYqd0NowyOIGDnN4HcWfs7eYUnCWv CQiNWPkIv9jzdMqVctux/rdDBlo0GowDfqOBujiDV3AYRPQFu1/t1XZsrx8KFws+62wz hmBg== X-Forwarded-Encrypted: i=1; AKwUvBw3L6jzPza3E/LYV9LQufh17AZa3zggYREF9rHKydQVIvowJ7nr9PxcT0MWVTJrLJddBAdn4U8V0Eg4qNk=@vger.kernel.org X-Gm-Message-State: AFuF++lydZdXFp55EdwzVpWBV9RDJflafyHEOo8AqKNhR/Vw9k2/zElh gxUGJYfo3wiuHchCS+pJbDDkIoH7wI3LsmINHJqayLMwCNER+5UqMuVC X-Gm-Gg: AYBFou2K+gRsbHU/jOSqLdBllZnoOEKIGmlnjDNEQ3xXPJPIbqK9d/al3Ni421vdng5 I6alB9WKzwPWmUO4zn1mb2t76TN02MZIevFYD6BT7Zt3UN9yzWpmbI8gCFoBi09vAjgDiqhBKoA cUKEn/CiYd7FPpjALSWCdDSpQLKB3vcff9fQCSeZkgjFsYG2KWabSqij6zlbCSB6Qqsq7g9pxBR fEf2aESUU/+dEWJhe9ZDBC2qibSgnBAYgtgGOPEJKejX1/Oy22kuIZx7Dd4QX4SCcU1maSM/ksw O5GmxsHVsZDHyvIerKJuRYR/oJJY7/6PFKK+IyOZiG+s/oi0e3oHp7L/nInF+MLTbBzwPXKtOvd VOPRci67F57jIBFrZ3+/AxZYbXXZXzGsFDIGopZsvqT2PcGL5gGClKWPK3kudEAkDpyS+pNDpbV q/gZDr2UQFR2nlo0wvOOntIEudSI2H5iXK1vSxNbFmgwI/69DuHEjp1J3NS/r/xkeJuszfU1Zoe 5SRfGjA38oHyNeTkzi/X6jQ8u40T1Y52z1DrkmvkZOGfAtAUVYTOU4mIjaYCTuKS/ASenqB/DCG BKxAEfMMjaC7zsA= X-Received: by 2002:a17:90b:2d0b:b0:398:c794:ca26 with SMTP id 98e67ed59e1d1-39b263167f7mr60419743a91.25.1789045130914; Thu, 10 Sep 2026 05:58:50 -0700 (PDT) Received: from phuc-desktop.. ([183.91.15.56]) by smtp.gmail.com with ESMTPSA id 98e67ed59e1d1-39d7e77b1afsm4891592a91.5.2026.09.10.05.58.47 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 10 Sep 2026 05:58:50 -0700 (PDT) From: phucduc.bui@gmail.com To: Mark Brown , AngeloGioacchino Del Regno Cc: Liam Girdwood , Matthias Brugger , Jaroslav Kysela , Takashi Iwai , Cezary Rojewski , Cyril Chao , Kuninori Morimoto , Dan Carpenter , cassiogabrielcontato@gmail.com, linux-sound@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-mediatek@lists.infradead.org, linux-kernel@vger.kernel.org, bui duc phuc Subject: [PATCH 11/13] ASoC: mediatek: mt8189: Validate sysclk frequency Date: Thu, 10 Sep 2026 19:57:40 +0700 Message-ID: <20260910125742.150902-12-phucduc.bui@gmail.com> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20260910125742.150902-1-phucduc.bui@gmail.com> References: <20260910125742.150902-1-phucduc.bui@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" From: bui duc phuc mtk_dai_i2s_set_sysclk() accepts zero or negative frequencies. Reject invalid frequencies before configuring the I2S clock. Fixes: 7eb153585598 ("ASoC: mediatek: mt8189: add platform driver") Signed-off-by: bui duc phuc --- sound/soc/mediatek/mt8189/mt8189-dai-i2s.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/sound/soc/mediatek/mt8189/mt8189-dai-i2s.c b/sound/soc/mediate= k/mt8189/mt8189-dai-i2s.c index f20dbb410223..ca7d786cdeff 100644 --- a/sound/soc/mediatek/mt8189/mt8189-dai-i2s.c +++ b/sound/soc/mediatek/mt8189/mt8189-dai-i2s.c @@ -1286,6 +1286,9 @@ static int mtk_dai_i2s_set_sysclk(struct snd_soc_dai = *dai, dir !=3D SND_SOC_CLOCK_OUT) return -EINVAL; =20 + if (freq <=3D 0) + return -EINVAL; + i2s_priv =3D afe_priv->dai_priv[dai->id]; if (!i2s_priv) return -EINVAL; --=20 2.43.0 From nobody Fri Sep 25 16:50:46 2026 Received: from mail-pj2-f12.google.com (mail-pj2-f12.google.com [74.125.227.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id E33A1492E37 for ; Thu, 10 Sep 2026 12:58:56 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=74.125.227.140 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1789045138; cv=none; b=l/y01vnzds/xJOjGPOaNVDnQOoceupOGgtsU0lpdMsyFldQUcJYRDAx3lAT9ubKUyAIE0NYXLtP0gvSBMoODBoIQK0QQ6bniLtw7CyIXnUgGgN77iYcmTtkkzNgx31IvXxKV5NtuPiGRNEZf1ezJlk54SJ8MoM3K7TS05xF2uOQ= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1789045138; c=relaxed/simple; bh=zVt/GLB/PctPHE9xjcaVCw+lY910OuGBOfYlSPretgM=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=a546oU8Ey/GgFOS4LO3Hmzt2b/9/p6o1kupgdZ6fES9k+dkHSPcJO3H4UScTSc2Svrk6DwUCrxvcubbvl1Rm92BDb8hlEfIbK0GE/NI7+twc9YbzxuTRWvpsyM0FUPRLxNQIDTPY/JgQ5vIaGOdAHnJKXB8v3GfERk5OaTSguH4= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=GV+HiOYW; arc=none smtp.client-ip=74.125.227.140 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="GV+HiOYW" Received: by mail-pj2-f12.google.com with SMTP id 98e67ed59e1d1-396ccafb751so2128170a91.2 for ; Thu, 10 Sep 2026 05:58:56 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1789045135; x=1789649935; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to:content-type; bh=vlGnqVAUzYoXB3nTaQam08DX17fuCUu75lyq1+U5jAU=; b=GV+HiOYW4ibcXRW0xjhbCO9YDZNtuLs+6jRlWYwSWfuWpU5e8wdNu8ARubW8ePu/dM Q4Q/EidX4rLFAhHy3L3QnQnnT9q8vnQkvN4ZqMn2PMVws9Om2dK1oKEZWc0hoSHePY7h A0zH0xrcw16Jc108Sc9CKoGW8IXoFwDiWC3qJjkyQJp8pkeiA4Ry3GXjsBkIfvIRBw1i Rl+RSJkacGn9ovAMDE3b21aLS//sNnDVF3j4AWkYyLaH4RNRBuXIA9lx/zqAGGQjjK3I 1w2gSPq448J8SN91AmkMlQ087m7ZkH869WDUGugtRLz0emRb1UkOQGIhJeXLzahjvAAi 0Tsw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1789045135; x=1789649935; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to:content-type; bh=vlGnqVAUzYoXB3nTaQam08DX17fuCUu75lyq1+U5jAU=; b=Lv2g+X0oFo69lfrE8Qubdwu5iLTisetQ23ZnjeQ8V+mHd1QXLFhrJnLuECM19h7qfM Uy5qEWr4U4hpqewvc2b8c79aC8cQbqJGCMPJZjRrSHT77f54PXSiPQJPTAiQgZnd8V/2 Bwhx/s3ezNQ+8qd16F1rGz1JysTgJtV6iS5uuBE6erU9DpLDcq6wAZHe0akWPeizsAHv /6bfb8VrZYEbiGoz7EYczcel3S9qtbsd0VnvyBH+8o03L8FwMuYyaCFJZlcHSV9kEXK/ XW4K9jmems2vuW7Nyrz2mIRvPdBhusvsgDxfQ2tiHxrXCALrS2Vnwhz06utBOCrjPDVz IfUw== X-Forwarded-Encrypted: i=1; AKwUvBzzXNYtYMYGwlFfrFSsS/4GNxc0qiXoKXx3XvwrwKbAwFE+UiEBtjwsX5s0iuoixbWo1EEurDn8+HcKnRQ=@vger.kernel.org X-Gm-Message-State: AFuF++n3SEnoVzTzPLe0/o8qXbouoq/Vhz0PuuVYq+sv71tdOXN/WxTO mw1n/YwYSMTcSRHI31oazyf2OJKFJ8C56Yk5cREatHpmD3R09FDiXwCg X-Gm-Gg: AYBFou3nQeRktRavIjLOHjtYFC37Tha9oLRbIw2/kkw+R9k4t2xuMYDtheTWrMdsxnm ++SAtI6W3cF4cmRUVDNKJMSbWkNi3UfY8anY1nk9bFTVHkrkmCA+asfV8QpnX/PU8YrU7RJ0B4e NybaPySbrDRKjHablq3+tsE1oyX8KZ4IQdZP/rmn0ghqkPwW525uc/tEZgWLw1Sw5NuWCDhwKSg S/dB9HtuxTnhh1zb5/kOUxpJO9nMeoMhgWlFV9pHaXBq7xBHAssRCmFg1u4XciXagZyciNtcWkz r4POshLwASrwbKmpWVpwx+5bHPQvgLroJCcnEfosmNGg57ntDvWHO1uiOEgGTaZYACFtX23XMoN uwA+5Sz2PsOD9LgGmONnc7iA+NUpQUPRtNuyNgLPIDZ2ZuuCgcf9X+Gacx2y9nFPMluWpESTT4c kPFRC9tDGvYn82vAK29faMLXXjRAdUdzB3NeBYO+OxFhUNXJqcjVKGN1k+8rNeF+zjpn09lBJZ4 vKrChwGG5eCa8HUhkl/P3VdTMU7T3UaHltjDIeGLejFGRmtgBup8IcFY2yulkKu8LKzRGmrH1hI Aan0B/xFKmtccI8= X-Received: by 2002:a17:90b:520e:b0:398:9be8:ea65 with SMTP id 98e67ed59e1d1-39bac3c452dmr19487586a91.18.1789045135450; Thu, 10 Sep 2026 05:58:55 -0700 (PDT) Received: from phuc-desktop.. ([183.91.15.56]) by smtp.gmail.com with ESMTPSA id 98e67ed59e1d1-39d7e77b1afsm4891592a91.5.2026.09.10.05.58.51 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 10 Sep 2026 05:58:55 -0700 (PDT) From: phucduc.bui@gmail.com To: Mark Brown , AngeloGioacchino Del Regno Cc: Liam Girdwood , Matthias Brugger , Jaroslav Kysela , Takashi Iwai , Cezary Rojewski , Cyril Chao , Kuninori Morimoto , Dan Carpenter , cassiogabrielcontato@gmail.com, linux-sound@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-mediatek@lists.infradead.org, linux-kernel@vger.kernel.org, bui duc phuc Subject: [PATCH 12/13] ASoC: mediatek: mt8189: Propagate TDM clock errors Date: Thu, 10 Sep 2026 19:57:41 +0700 Message-ID: <20260910125742.150902-13-phucduc.bui@gmail.com> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20260910125742.150902-1-phucduc.bui@gmail.com> References: <20260910125742.150902-1-phucduc.bui@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" From: bui duc phuc mtk_tdm_bck_en_event() and mtk_tdm_mck_en_event() currently ignore errors returned by the MCK enable and disable functions. Propagate these errors. Fixes: 9f202872ba04 ("ASoC: mediatek: mt8189: support TDM in platform drive= r") Signed-off-by: bui duc phuc --- sound/soc/mediatek/mt8189/mt8189-dai-tdm.c | 14 ++++++++------ 1 file changed, 8 insertions(+), 6 deletions(-) diff --git a/sound/soc/mediatek/mt8189/mt8189-dai-tdm.c b/sound/soc/mediate= k/mt8189/mt8189-dai-tdm.c index 5d68a55ccc45..1b51027c6cf4 100644 --- a/sound/soc/mediatek/mt8189/mt8189-dai-tdm.c +++ b/sound/soc/mediatek/mt8189/mt8189-dai-tdm.c @@ -261,22 +261,23 @@ static int mtk_tdm_bck_en_event(struct snd_soc_dapm_w= idget *w, struct mt8189_afe_private *afe_priv =3D afe->platform_priv; int dai_id =3D get_tdm_id_by_name(w->name); struct mtk_afe_tdm_priv *tdm_priv =3D afe_priv->dai_priv[dai_id]; + int ret =3D 0; =20 dev_dbg(cmpnt->dev, "name %s, event 0x%x, dai_id %d, bck: %d\n", w->name, event, dai_id, tdm_priv->bck_rate); =20 switch (event) { case SND_SOC_DAPM_PRE_PMU: - mt8189_mck_enable(afe, tdm_priv->bck_id, tdm_priv->bck_rate); + ret =3D mt8189_mck_enable(afe, tdm_priv->bck_id, tdm_priv->bck_rate); break; case SND_SOC_DAPM_POST_PMD: - mt8189_mck_disable(afe, tdm_priv->bck_id); + ret =3D mt8189_mck_disable(afe, tdm_priv->bck_id); break; default: break; } =20 - return 0; + return ret; } =20 static int mtk_tdm_mck_en_event(struct snd_soc_dapm_widget *w, @@ -288,23 +289,24 @@ static int mtk_tdm_mck_en_event(struct snd_soc_dapm_w= idget *w, struct mt8189_afe_private *afe_priv =3D afe->platform_priv; int dai_id =3D get_tdm_id_by_name(w->name); struct mtk_afe_tdm_priv *tdm_priv =3D afe_priv->dai_priv[dai_id]; + int ret =3D 0; =20 dev_dbg(cmpnt->dev, "name %s, event 0x%x, dai_id %d, mclk %d\n", w->name, event, dai_id, tdm_priv->mclk_rate); =20 switch (event) { case SND_SOC_DAPM_PRE_PMU: - mt8189_mck_enable(afe, tdm_priv->mclk_id, tdm_priv->mclk_rate); + ret =3D mt8189_mck_enable(afe, tdm_priv->mclk_id, tdm_priv->mclk_rate); break; case SND_SOC_DAPM_POST_PMD: tdm_priv->mclk_rate =3D 0; - mt8189_mck_disable(afe, tdm_priv->mclk_id); + ret =3D mt8189_mck_disable(afe, tdm_priv->mclk_id); break; default: break; } =20 - return 0; + return ret; } =20 static const struct snd_soc_dapm_widget mtk_dai_tdm_widgets[] =3D { --=20 2.43.0 From nobody Fri Sep 25 16:50:46 2026 Received: from mail-pj1-f48.google.com (mail-pj1-f48.google.com [209.85.216.48]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 0A92249552C for ; Thu, 10 Sep 2026 12:59:01 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.216.48 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1789045143; cv=none; b=Duiv60fZ3RsFr4ixNUQGoPUWjFDA+xi3utc3ARDmaglZLz8M+u1dkuDEz1klP3Sdc+aTa4WF1/WuwyxXU4rAN0C8Ul5u18uczZxKkqANnfK9050dJo8VOJyoALQxR6OirL8ZF6rOhH+aqur8kMV718y0xx7ZSg8u4gnkTXI4+KI= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1789045143; c=relaxed/simple; bh=HNQ3yAaTj8Lox9L4v2OsrFX6RIoSfJ6hArRWObXN3VU=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=cuGOc+4bEXF/B8eLuSqm77n8DznidhMh4jh717iPcXVCq/C9y6KiOA1+l/cOUyUtBzKisMLFB3kCtYvT3exz/IZvDOLVhnouXtyiRiBMkya/hxzD/dCfNf4OdSZsBiTZem/xmQyNSth4HmaOr5J8sbRlU/ivvXbI2tBY+xuHccs= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=XXmG+AmY; arc=none smtp.client-ip=209.85.216.48 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="XXmG+AmY" Received: by mail-pj1-f48.google.com with SMTP id 98e67ed59e1d1-38ea87caafeso6197383a91.3 for ; Thu, 10 Sep 2026 05:59:01 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1789045141; x=1789649941; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to:content-type; bh=DlX7uEp+xJt+DRWD58MvDXb25/Cat7Ywclf9fNm7ioc=; b=XXmG+AmYeQA5wFVZe4dPHhJnRvIQuS2SddhNcQiHH8MWPBka942XMgjYgqNim3IeLx d5kwADZa1r2xjLVXZS/IRgIuIXmk1EBm+iq4gz1jq2nxgAcm9FcUFxqT3Y+N+k5LRbW5 NyWO2uFYIZyvnY6xpaqDDykqGA9ItPmv7/iPBTORP3fZYi9Ce44x3j2otet0gOwLw7U9 Ui4lgmQtiJ2tVBiB76vksrXK+3oLxxHYq9frS98i8BA4tfS17PvA99vzc+rp75NK3WMs /Q7Wp6vskMvUGcw4zyXMe7Cn1bPbiv/O3sYTBj4y7bFF3vBznrtc455dH/wuAz2euoRe DKfw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1789045141; x=1789649941; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to:content-type; bh=DlX7uEp+xJt+DRWD58MvDXb25/Cat7Ywclf9fNm7ioc=; b=szb+vHxjKG2w1/RIWF5qwlmsiIJ3NwySYkBN6yIR4GgDjkfiAriDpf/QpIv04+qZmW QdG5Vr18qquGWv25VkKm9z58wk0k4YcfWMyVMK8xH27aBcEBQbfkDQHCDflsbGWkO8rP b+aWfX3uLdzM282/sAc9ILNqz+OpAk3ObUxM5r42qc9zPw+Z/wruMyw/HAdiSjyQoawl qXVcTUSwQWEl414/7MYL0U4HMx3XoifSHXXklt4aDExqeg1pkLHdOYDZrHK/hgNb+Xpv wmiLGPP3L7zHaEwUf0zIn8TeglqHzLSCv4Ix00aRr8z0yC1dqESS3CB9conEoVEFz5Hv 9Agw== X-Forwarded-Encrypted: i=1; AKwUvByRNPjJ8znXDjZdasHPP2vlFI4BnQEZhpCcoMFRmYZG0zrveFC8DUIyt8DJB5Fg+NaIKcCKiabaQNkkzr4=@vger.kernel.org X-Gm-Message-State: AFuF++ntdJtudKIwgiem2oaaUxV6XDd+3kXwjgDkQ7h4YxDkHoeVvTtN J8bru3dyy1O631lmikErdtyYOv882GmmBEGWrHlifiCegp0YtA9SzwY1 X-Gm-Gg: AYBFou3Gpo0RskMRIdHz+2AUaILJkBgLoaZI9FRKsZ2Gx67DESICyJWlqC0XJKYRfP8 Q1EQow8TPAF3jInTorIngvheFw0YhyYylFfOAuvWeuqo2mVgvryagqXjKlfjh2g3p8kFud7b9du 8WkiGdYUDfvbG6ZQ6sXUieZd/OE+QS6s4k/5zGv8J+TA83rw8mtoQALHaCjgaHCNIOlJcn4yM+M d3rciW6WFntYIRxnv3kICN6dawze4sf+p5Y0/odi7ss5uzX39hjl1JhMrMVUDzbqQJ3CqwmhGrT YNxQGUgltn+zVerH88FOAxGgSnniJocqvcuJzmlUAWVdB98oW4wfyV6vwcU29VeKmWzuT0BZeGW JvEnK/wB64zjYWGqAtkDd0fHdb1tnSB0GXsAVHGmgZOfpQ4IlX3pNVYfwa64vJmI+LGgS277P8j 55f0Od3deQKDLLruY5qr9JjbiQszWewFs5CKCVqBRmHLpd4N038bzooZANFbffWIs/jQo94xOcH TGqTWKQgoVlUZ6hSxBIBz4B8HSKNAN0i2S1IfQIvBj9VtnWA2TJ4z5o36g7Yt3cWqCC0sWSdiI5 ct95cIfFnoYwI/w= X-Received: by 2002:a17:90b:3a81:b0:398:c292:ac80 with SMTP id 98e67ed59e1d1-39b2612eaa4mr58543997a91.10.1789045140953; Thu, 10 Sep 2026 05:59:00 -0700 (PDT) Received: from phuc-desktop.. ([183.91.15.56]) by smtp.gmail.com with ESMTPSA id 98e67ed59e1d1-39d7e77b1afsm4891592a91.5.2026.09.10.05.58.56 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 10 Sep 2026 05:59:00 -0700 (PDT) From: phucduc.bui@gmail.com To: Mark Brown , AngeloGioacchino Del Regno Cc: Liam Girdwood , Matthias Brugger , Jaroslav Kysela , Takashi Iwai , Cezary Rojewski , Cyril Chao , Kuninori Morimoto , Dan Carpenter , cassiogabrielcontato@gmail.com, linux-sound@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-mediatek@lists.infradead.org, linux-kernel@vger.kernel.org, bui duc phuc Subject: [PATCH 13/13] ASoC: mediatek: mt8189: Validate TDM MCLK frequency Date: Thu, 10 Sep 2026 19:57:42 +0700 Message-ID: <20260910125742.150902-14-phucduc.bui@gmail.com> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20260910125742.150902-1-phucduc.bui@gmail.com> References: <20260910125742.150902-1-phucduc.bui@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" From: bui duc phuc mtk_dai_tdm_cal_mclk() accepts zero or negative frequencies. Reject invalid frequencies before configuring the TDM clock. Fixes: 9f202872ba04 ("ASoC: mediatek: mt8189: support TDM in platform drive= r") Signed-off-by: bui duc phuc --- sound/soc/mediatek/mt8189/mt8189-dai-tdm.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/sound/soc/mediatek/mt8189/mt8189-dai-tdm.c b/sound/soc/mediate= k/mt8189/mt8189-dai-tdm.c index 1b51027c6cf4..7748b4ff2c72 100644 --- a/sound/soc/mediatek/mt8189/mt8189-dai-tdm.c +++ b/sound/soc/mediatek/mt8189/mt8189-dai-tdm.c @@ -381,6 +381,9 @@ static int mtk_dai_tdm_cal_mclk(struct mtk_base_afe *af= e, int apll; int apll_rate; =20 + if (freq <=3D 0) + return -EINVAL; + apll =3D mt8189_get_apll_by_rate(afe, freq); apll_rate =3D mt8189_get_apll_rate(afe, apll); =20 --=20 2.43.0