From nobody Fri Sep 25 16:51:46 2026 Received: from mx0b-0002e601.pphosted.com (mx0b-0002e601.pphosted.com [148.163.154.28]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 5B83845A297; Thu, 10 Sep 2026 10:42:52 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=fail smtp.client-ip=148.163.154.28 ARC-Seal: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1789036975; cv=fail; b=kRDGb84knIVXhhXNWEUW7TcSoQiubogn6Go1cWJtXnBC8l8dhKPUqGaMT/Z9xOWEXoOCIJkUSFDtxv4qdAq1CSTQKlTSdR3q6ECVTZX+9F2M8RFAVy1F/wyGIvJBI3bBTDGc1Ix1qRSJ/fmJPQ1NVr2O5gYn/3pkPhu2iQTGyTk= ARC-Message-Signature: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1789036975; c=relaxed/simple; bh=3l+N7VRjb7sCYwjUPdOx+NEFhmC5BVJCOEULINgQzmA=; h=From:To:CC:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=iYnbLr+oy114hTjksEPrinnHR69kJxgshnZFD410I4262PA1vRtTKukDF3mL2KbtDspdF+LGv9hkGq02NG8OAnhqhg9NeKVsu35RcAYHFVSBAULqQXSXsbSPh5IrFlw/iybLYsWrIwfLcYl+0b9MOj2dhErd8EIxZ6QziUq1sx4= ARC-Authentication-Results: i=2; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=ti.com; spf=pass smtp.mailfrom=ti.com; dkim=pass (2048-bit key) header.d=ti.com header.i=@ti.com header.b=HYKBsgk1; dkim=pass (1024-bit key) header.d=ti.com header.i=@ti.com header.b=AyPYk5Gm; arc=fail smtp.client-ip=148.163.154.28 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=ti.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=ti.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=ti.com header.i=@ti.com header.b="HYKBsgk1"; dkim=pass (1024-bit key) header.d=ti.com header.i=@ti.com header.b="AyPYk5Gm" Received: from pps.filterd (m0374955.ppops.net [127.0.0.1]) by mx0b-0002e601.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 68A8oV9E2934064; Thu, 10 Sep 2026 05:42:44 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ti.com; h=cc :content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s= proofpoint-05-2026; bh=r76QOfszn/d06cjyEn+KvN63bOkOlgpaVUcFIgF87 no=; b=HYKBsgk1nHAzWC2P+OL1q6m93tl6QZR6XFJbeeXx1WDCxeo18VtTqfg80 qY2l0KwY9TKeJxmES5sNKOPyas22UcaTa3Z86KoJOppBbsbPfJPuHPYCQEgTHCY+ fa3PlV7eB0L6qxT4tUpJd78qI10TrsOPYtP/jhUmUJnRDbOyX9W7C4dDbI+HlQ9v YUSCHishsPgDEPWeYfJmNAICq7sORbuDTo9RgghtIH644j+JFHmjvGqZFs4OeNV0 jG7FAKBmf8uuTntrbxcH/NZzWBD07QQf7Mw/DKqSxrTtgiAj0gmZ/IKKnRVpjqcn lQfQVu+0kswZVZlhOFTgYXeg2Rd2A== Received: from ph7pr06cu001.outbound.protection.outlook.com (mail-westus3azon11010065.outbound.protection.outlook.com [52.101.201.65]) by mx0b-0002e601.pphosted.com (PPS) with ESMTPS id 4gkcxg4xgu-1 (version=TLSv1.3 cipher=TLS_AES_256_GCM_SHA384 bits=256 verify=NOT); Thu, 10 Sep 2026 05:42:44 -0500 (CDT) ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=YvXNU3PAXbyIOXaLsqJ68PRcz7+/QI+oqFBQxozqc4ViufFAfrDfUT0r7kJ6Qha0c7Suhqb9cYaNHVokn8d6Hvti1UHfeLrRl9fP2Hbu1ugFL/Jmp0PM3dxLqmff58LmLrcf0IQpvlE7vY+fTorVv9YUmUZsuKARBnGXTnXyJLcqYVkcvWa9pv3EArPISWlcSy5cPXulntvd0AwtNdDfwsNxFukdwX6751hHyJ6rAipnKZUTDm6U+schAxunQO3+OG12lhg33wjAUDl5z8o8B3Xt7tQIKk1s5fX6LjL66B0EXTtHhsyrzXB243tUrw+VBZjqx1LLUX9u0Zx8h6dYQA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=r76QOfszn/d06cjyEn+KvN63bOkOlgpaVUcFIgF87no=; b=pmWnyFTy9fvGuVKARPCJUvt+fJX5U49g/AHa8X8RCUClG3F7hKQQKpRJ/dmTqR8ng87d1j85PrgprzsGyyCXX6vn4/0HDLQUzFYBxnfDT9YTT0wLa1aozRa1ntmEbMuAcLCRlxS8guiezZOMv1giVcyzEv2m2+tiQy5RH7FnfyCzJ6iUXKblUuCxF2782VO3lJOxDB8cSiPzRCV587DaeQ0D9MT8mTOBfm4vHCM8bqbhj1/bEpP+zHEz8n+K0Og+UrVhiMqVIypw6UP7K0IUGHleU5a2EfFgj9O7LbOyLN5hlQD8SP/xUKmdl7EnR/wrYRrT/AVcrTvdWCX60VC5KQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 198.47.23.195) smtp.rcpttodomain=gondor.apana.org.au smtp.mailfrom=ti.com; dmarc=pass (p=quarantine sp=none pct=100) action=none header.from=ti.com; dkim=none (message not signed); arc=none (0) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ti.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=r76QOfszn/d06cjyEn+KvN63bOkOlgpaVUcFIgF87no=; b=AyPYk5Gm1CbVyZL2wLby74ZLq67Mi7/rLTrzzWOR+QjglSrrkfSKumyLknSIHLle3fjkBHLpl0VJn4GfnN45gIvTDQF8UU+iB3k3ycXWfcQHCwQ7nDwEdntw8UZv1aLLpYmd2igXLvaD6SZTIe8/xFRlFkgplsRa+7yFBre81Pk= Received: from SJ0PR03CA0102.namprd03.prod.outlook.com (2603:10b6:a03:333::17) by CH3PR10MB6902.namprd10.prod.outlook.com (2603:10b6:610:14e::6) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.21.428.4; Thu, 10 Sep 2026 10:42:41 +0000 Received: from BY1PEPF000264B5.namprd02.prod.outlook.com (2603:10b6:a03:333:cafe::86) by SJ0PR03CA0102.outlook.office365.com (2603:10b6:a03:333::17) with Microsoft SMTP Server (version=TLS1_3, cipher=TLS_AES_256_GCM_SHA384) id 15.21.406.8 via Frontend Transport; Thu, 10 Sep 2026 10:42:41 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 198.47.23.195) smtp.mailfrom=ti.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=ti.com; Received-SPF: Pass (protection.outlook.com: domain of ti.com designates 198.47.23.195 as permitted sender) receiver=protection.outlook.com; client-ip=198.47.23.195; helo=lewvzet201.ext.ti.com; pr=C Received: from lewvzet201.ext.ti.com (198.47.23.195) by BY1PEPF000264B5.mail.protection.outlook.com (10.167.242.122) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.21.406.5 via Frontend Transport; Thu, 10 Sep 2026 10:42:40 +0000 Received: from DLEE210.ent.ti.com (157.170.170.112) by lewvzet201.ext.ti.com (10.4.14.104) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.2562.45; Thu, 10 Sep 2026 05:42:29 -0500 Received: from DLEE205.ent.ti.com (157.170.170.85) by DLEE210.ent.ti.com (157.170.170.112) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.2562.45; Thu, 10 Sep 2026 05:42:29 -0500 Received: from lelvem-mr06.itg.ti.com (10.180.75.8) by DLEE205.ent.ti.com (157.170.170.85) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.2562.45 via Frontend Transport; Thu, 10 Sep 2026 05:42:29 -0500 Received: from pratham-Workstation-PC (pratham-workstation-pc.dhcp.ti.com [10.24.53.205]) by lelvem-mr06.itg.ti.com (8.18.1/8.18.1) with ESMTP id 68AAgSrK2177497; Thu, 10 Sep 2026 05:42:29 -0500 From: T Pratham To: T Pratham , Herbert Xu , "David S. Miller" CC: Mert Seftali , Sebin Francis , Manorit Chawdhry , Vishal Mahaveer , Praneeth Bajjuri , kernel test robot , "Dan Carpenter" , , Subject: [PATCH v3 01/12] crypto: ti - Use list_first_entry_or_null() in dthe_get_dev() Date: Thu, 10 Sep 2026 16:11:51 +0530 Message-ID: <20260910104202.1537226-2-t-pratham@ti.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20260910104202.1537226-1-t-pratham@ti.com> References: <20260910104202.1537226-1-t-pratham@ti.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: BY1PEPF000264B5:EE_|CH3PR10MB6902:EE_ X-MS-Office365-Filtering-Correlation-Id: 450d6d28-ac9e-4835-faba-08df0f283d09 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|36860700016|23010399003|376014|82310400026|1800799024|10067099003|18002099003|22082099003|56012099006|13003099007; X-Microsoft-Antispam-Message-Info: nTYSy4gXnOzVvgOQ5dxDIknQ7jcPGiaUEhLiej6VhqAK1RPJHLTJv/kqTic2cf1m5hq1jiX2noh5viJdMaRLozKoPGgnBn1HmrCHI8qbj/3X4HlcevjFt2ePTy87B3Wbq+SkR+plDYLPs0IL+SJIzL6XS9wUUlzUwSO9UIB/GWNVI6UeQvwn2sxVwzu0FjlE4XHiTmFLCK2ktAze2ANlSieQGGVtCFjFY5jo72NmbAvoYbAGYnEPnDruhUnhRfHi1wHb7DMmj7IqUoks/s6VqXJ4Sg8jfXbeREyS0hb1j2BLKR8Qg2bNJ6jZ0VdMwYzhYVUUtkV0Rkhiy2um8eozy+Jmcl+vCt5dWHViGbZswPS/HHPbpBaKh6yu27mMa0Fhn0i1tTcHXa5bbETLVp9QwMlPXX8+Fmy9640s34X3jaTtDNizCSut6VcRVnj5QQxYASsMH5lq7CkBj3prWFI2XKsF3BNLyqyxshBB7eo7Ei8t2CBBlmIfsFFUglirP0uyU1vOUoqIzb21zxA9dA9IwZ4eftTmWY/5HSHY9cYYytubHAkXaJoyxNx+JUZUTT+XnidebkW5JInYCRevC8uFAehxCPLy1h7A8NYo/2z8xLHqowdJ/0Tu6TC8OgNPP4XwTsfRiN8PphxyEeSfoEEI3w== X-Forefront-Antispam-Report: CIP:198.47.23.195;CTRY:US;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:lewvzet201.ext.ti.com;PTR:InfoDomainNonexistent;CAT:NONE;SFS:(13230040)(36860700016)(23010399003)(376014)(82310400026)(1800799024)(10067099003)(18002099003)(22082099003)(56012099006)(13003099007);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: e49AzYLyvC9WkKBmKPlEXmjGkTciZsJ6CiEJnH7pk5F+mIYNVuJvzWa9383bD0a//VmdvQ9yR25UTvkbe+FTyRCskJyKi8wJyTupUoEHjnmce4P6kK41alThyLYQQe0Yd3Op83ztcOWRobyxdTO9UL+ohrh1P3BjW/21Qehi0WYGFgMn4VzrkKh0zmdO2GiaxfcJBYOZz2U3kUuvPF2eOHGI1c4l8dirFePG3FhXJFNbjpa9ZDVlnuZ46POjq8Rqxdt//vhwjKMFNXqSzaeZkRqfro8edQUtY1a3hWP5/VGcAHlkt8pHHS0MwRUoXfysPLzahOACjHjA8GU8NBsWbwdnh/Pn1GryfQwOImc9OFm8WvU6PWqURRDbh5r6xewOO1xpaDqekpcdVAjpl3lXfVBp4+I5y2Ep0HmXC/x5SADIxNmKW5xBS7S51ZNCY/5k X-Exchange-RoutingPolicyChecked: madZF5l989HRgffBWACqXG44m2LDPaNlVWxasmtKqxeMzwXksYc7cB0kNTlAIAmdwkuNe928fDZL1WmtqJ3C/8F8qZ0MmSdl4l33H6YNXDN//QxaQuQQ8NrJGAMAj+H+bubzqMDjgV2wabsESZNFYftIk0/+6POERoVcYQgB0i+3tXxu8nF76Cmg0WSSTkhFMdDepXflWnwuFZUYcw87M2EWHGpkqNX6KmdMF3bc6/ttaKCG0dRldv2vsO8RMNmXM3WWOq/Hh8BtcTDRblEOJp6UEKKqtdjCGgDRFho1NmricII6C/+cnrXlQsJhxvwD1ezp7JQZ0il+ei6K/Dvq1A== X-OriginatorOrg: ti.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 10 Sep 2026 10:42:40.5679 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 450d6d28-ac9e-4835-faba-08df0f283d09 X-MS-Exchange-CrossTenant-Id: e5b49634-450b-4709-8abb-1e2b19b982b7 X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=e5b49634-450b-4709-8abb-1e2b19b982b7;Ip=[198.47.23.195];Helo=[lewvzet201.ext.ti.com] X-MS-Exchange-CrossTenant-AuthSource: BY1PEPF000264B5.namprd02.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: CH3PR10MB6902 X-Authority-Analysis: v=2.4 cv=MpPHeGae c=1 sm=1 tr=0 ts=6aa289a4 cx=c_pps a=Lj9o+5Kg1g76LDS8oSCIAA==:117 a=f+v6EHfkeJbVwR46tk4DMg==:17 a=6eWqkTHjU83fiwn7nKZWdM+Sl24=:19 a=VdqzKS8jKosA:10 a=s63m1ICgrNkA:10 a=V5UXEbMT0ywA:10 a=VkNPw1HP01LnGYTKEx00:22 a=Z8NIEmU8O1QQgoT56wFK:22 a=fPAWb5peG099m5CrUpKH:22 a=VwQbUJbxAAAA:8 a=QyXUC8HyAAAA:8 a=pGLkceISAAAA:8 a=sozttTNsAAAA:8 a=HYHyqeARaHjSmq2Pe6sA:9 X-Proofpoint-ORIG-GUID: cUXxvipXNwbTs1Y3XMzATNNGewjuvMG3 X-Proofpoint-Spam-Info: AW1haW4tMjYwOTEwMDEyNCBTYWx0ZWRfX28iGQJnkAZqY 4YddLxNJHXdurFxCo4PK65ZskEJngKlgELrP8qGpVNqVxWLCOecCpOmuDzxhNrA1CXwtMGTDjtB aTK0tNdHyURoAubzXrxjhEBW5ip61+E= X-Proofpoint-GUID: cUXxvipXNwbTs1Y3XMzATNNGewjuvMG3 X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwOTEwMDEyNCBTYWx0ZWRfX7kO/mlXK/+Dh 7P5dMPl77AW7dijtqrOsw+l+WwmHDdLlE2fkSbxfl/5eU6yEoC5RahspKIBBPTPw5ifFE9EhIKT pjxAFtsN6in0G/ifA1nVpn9RRmLTjDF+pR/7OWOWcY8/WtRlA1UFneDPwIjhBRcA4x1TO2pP8BQ +pGR4VvMdrDz3P/+bxIQu+gD1EL+mdo+F8azIclRg8ZJuhXCN8q4cxqxlGNTDjCoFqhO570NVL2 pntm3C3XyD5hLN5Dim6cjvDKpUMGQ3VKjS0AAY/Bxfv0CYzWh6RyDjDDBW3P0zHi6UYcCfXaJ/r 3pfr0sCIduo9UytDYTfRFZAZUEK8+Ra+cd3VMWq4tlm6d9djnDFq89amlxF+YFUSM4aVrBbPgrl 0wYDUXEpQDyJoOMxh905juyVHC8KwMu0jF1kviqLVdMNhOzHm+gz7jXsC7I6GnhE4iF3FzMrm0y 0PnM2fwdzLkcTW1mU6g== X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1176,Hydra:6.1.134,FMLib:17.12.100.49 definitions=2026-09-10_03,2026-09-09_02,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 priorityscore=1501 lowpriorityscore=0 adultscore=0 suspectscore=0 malwarescore=0 impostorscore=0 phishscore=0 clxscore=1015 spamscore=0 bulkscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2609040000 definitions=main-2609100124 Content-Type: text/plain; charset="utf-8" From: Mert Seftali dthe_get_dev() fetches a device from the global device list with list_first_entry() and then checks the result for NULL. However, list_first_entry() never returns NULL: on an empty list it returns a bogus pointer computed from the list head. The NULL check is therefore dead code, and an empty list would be treated as a valid entry and moved around as if it were a real device. Use list_first_entry_or_null() so the existing NULL check works as intended and an empty list is handled gracefully. [pratham:] Add null checks on dev_data in callers of dthe_get_dev(). Fixes: 52f641bc63a4 ("crypto: ti - Add driver for DTHE V2 AES Engine (ECB, = CBC)") Reported-by: kernel test robot Reported-by: Dan Carpenter Closes: https://lore.kernel.org/r/202606111933.69GGTKxr-lkp@intel.com/ Signed-off-by: Mert Seftali Co-developed-by: T Pratham Signed-off-by: T Pratham --- drivers/crypto/ti/dthev2-aes.c | 12 ++++++++++-- drivers/crypto/ti/dthev2-common.c | 2 +- 2 files changed, 11 insertions(+), 3 deletions(-) diff --git a/drivers/crypto/ti/dthev2-aes.c b/drivers/crypto/ti/dthev2-aes.c index eb5cd902dfb59..4fdd24ee91637 100644 --- a/drivers/crypto/ti/dthev2-aes.c +++ b/drivers/crypto/ti/dthev2-aes.c @@ -112,6 +112,9 @@ static int dthe_cipher_init_tfm(struct crypto_skcipher = *tfm) struct dthe_tfm_ctx *ctx =3D crypto_skcipher_ctx(tfm); struct dthe_data *dev_data =3D dthe_get_dev(ctx); =20 + if (!dev_data) + return -ENODEV; + ctx->dev_data =3D dev_data; ctx->keylen =3D 0; =20 @@ -124,6 +127,9 @@ static int dthe_cipher_init_tfm_fallback(struct crypto_= skcipher *tfm) struct dthe_data *dev_data =3D dthe_get_dev(ctx); const char *alg_name =3D crypto_tfm_alg_name(crypto_skcipher_tfm(tfm)); =20 + if (!dev_data) + return -ENODEV; + ctx->dev_data =3D dev_data; ctx->keylen =3D 0; =20 @@ -571,10 +577,12 @@ static int dthe_aead_init_tfm(struct crypto_aead *tfm) { struct dthe_tfm_ctx *ctx =3D crypto_aead_ctx(tfm); struct dthe_data *dev_data =3D dthe_get_dev(ctx); + const char *alg_name =3D crypto_tfm_alg_name(crypto_aead_tfm(tfm)); =20 - ctx->dev_data =3D dev_data; + if (!dev_data) + return -ENODEV; =20 - const char *alg_name =3D crypto_tfm_alg_name(crypto_aead_tfm(tfm)); + ctx->dev_data =3D dev_data; =20 ctx->aead_fb =3D crypto_alloc_sync_aead(alg_name, 0, CRYPTO_ALG_NEED_FALLBACK); diff --git a/drivers/crypto/ti/dthev2-common.c b/drivers/crypto/ti/dthev2-c= ommon.c index a2ad79bec105a..cc02449382673 100644 --- a/drivers/crypto/ti/dthev2-common.c +++ b/drivers/crypto/ti/dthev2-common.c @@ -40,7 +40,7 @@ struct dthe_data *dthe_get_dev(struct dthe_tfm_ctx *ctx) return ctx->dev_data; =20 spin_lock_bh(&dthe_dev_list.lock); - dev_data =3D list_first_entry(&dthe_dev_list.dev_list, struct dthe_data, = list); + dev_data =3D list_first_entry_or_null(&dthe_dev_list.dev_list, struct dth= e_data, list); if (dev_data) list_move_tail(&dev_data->list, &dthe_dev_list.dev_list); spin_unlock_bh(&dthe_dev_list.lock); --=20 2.34.1 From nobody Fri Sep 25 16:51:46 2026 Received: from mx0a-0002e601.pphosted.com (mx0a-0002e601.pphosted.com [148.163.150.75]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 6E61A3DAAD5; Thu, 10 Sep 2026 10:42:55 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=fail smtp.client-ip=148.163.150.75 ARC-Seal: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1789036977; cv=fail; b=YTKgoc5Y8yNiUAzku/r75ZfGxrnYptn0jQnVW1RQSchtixYexRsLRQ1PeK0eLV7Xvj3g5DwPvpRO/sThF2QwWIdo2FrwosjmvpoqOkHWCKx67LJBtbYTOHFLoTMg1lz818BzOVJtxmDoc5vQmhYmnWUrRGhE3tfYaBicQ3XaDsw= ARC-Message-Signature: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1789036977; c=relaxed/simple; bh=JhIYat1tDDHjynnYJrzFdJBgSwjr7d6SfSSJ0/IQWLo=; h=From:To:CC:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=LK5UW/lmhQfRUBj2yRcoyO/yflJE66Z/jNqAuNWMtFVqzEhY0THjaHTX5QZRgPiU65Nyc3nJaVRkaz4kZcsNg5rHK0wwV7Swg3KkSxpxhmj/BXp2rxIseHPy9WehgxlM+qb4/6kqzcljSxwcMrQFTJayDvm4+Mkpu3EYt9CR5Y0= ARC-Authentication-Results: i=2; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=ti.com; spf=pass smtp.mailfrom=ti.com; dkim=pass (2048-bit key) header.d=ti.com header.i=@ti.com header.b=cItckjoe; dkim=pass (1024-bit key) header.d=ti.com header.i=@ti.com header.b=a+2qtPZL; arc=fail smtp.client-ip=148.163.150.75 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=ti.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=ti.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=ti.com header.i=@ti.com header.b="cItckjoe"; dkim=pass (1024-bit key) header.d=ti.com header.i=@ti.com header.b="a+2qtPZL" Received: from pps.filterd (m0384305.ppops.net [127.0.0.1]) by m0384305.ppops.net (8.18.1.11/8.18.1.11) with ESMTP id 68A8oH6O712619; Thu, 10 Sep 2026 05:42:52 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ti.com; h=cc :content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s= proofpoint-05-2026; bh=L3d/uqtROV07wByGxF+hfQgPvMnzChdKYg2ED7CQC yU=; b=cItckjoeFr7wsQjE5xsUvGK8SdzVh8rPYWcweA0HVJroxuZn9YugjEn0w c4Krh9/kNOO+euI3tBDXS8dIG16CYW8MDjzCMH6v+ikY70OaJHrLzivxpEJVHDO5 UtqmZiP4e8L5m7G8lIIAJ1nt4rPiZVe4tSU82yNhkcRTpq5nVddMbqEOK2x7i/Aj uYVIEb85S0ZJ4pDJQWDcgm83sNSZQ73+Hc7mf/iTUyoFCfmrdh0oCFAjYXO4iy9K EpXGStCJpD/RwJParkSkHYHYA8Ea+hiONbXOjk4XnrP3zUkgcWfJmZUD2QXsgnRF sYYxP76UPGNrNMPF/w7r5NX4f8ufg== Received: from bl2pr02cu003.outbound.protection.outlook.com (mail-eastusazon11011059.outbound.protection.outlook.com [52.101.52.59]) by m0384305.ppops.net (PPS) with ESMTPS id 4gkcxgcnwe-1 (version=TLSv1.3 cipher=TLS_AES_256_GCM_SHA384 bits=256 verify=NOT); Thu, 10 Sep 2026 05:42:52 -0500 (CDT) ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=tJqpMPCV8752kMky92KoQ9Fg45JaixUa6OcR304HuTYbsWCUFKPzB5dbq3muVx8AMNCEUnZu3KYEBlFjEZZuaIC46cl3dBaHksyJWiD56gYhDcQ4d404fHTtenkCa+uU/HKf2x5X411rL32CSt7ON7tpL+9Wd+fZdugyB+BTdpt3bja/NvwVXQCziOE67yoo8XJulzeLnzPzpcPjuoNlSoIBM10trwfWMW2xye5S2c/MXcBO4UdBlfxAgstmw/gzhAUvX35cD5GVkFHgFquRWRwSBPsJUk8Zo68aKg/zKTIjwoDTkBkUuliN4jMAWLPgtiYrEKAWag1ZzN5ekkgSpQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=L3d/uqtROV07wByGxF+hfQgPvMnzChdKYg2ED7CQCyU=; b=Aga8bfKwGp+9e3nN+8JhHhXHacjatOKGEt+qhAqlOzK1zAdd2OIQMUErj6YNRCKGFGTaYoiwGPgrGFXZV7VO9QaD3UzecKTkqCzBDwvaTcpO0DKHRNhmBPbrdGnBxw95nQGStMlK8IsMKDNMn9M+xo7Pr16n/70ZwnA9X6Wz6mz0VsuNmAATNbS3dmNeQYIA6TCH8XMivQFaNMOJ42a3a9Huuzxvdr39G5I16bSdpyiZdkLnq+kqrA8UTaVKtHKR2LSun1tklipHpdwiIOjquMK/a9++9QMpzlzy5XKCZXqmwKijsqijsNDO+fMtv3k+vfCxbkIEZBhBxqLoyTz2vg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 198.47.23.195) smtp.rcpttodomain=gondor.apana.org.au smtp.mailfrom=ti.com; dmarc=pass (p=quarantine sp=none pct=100) action=none header.from=ti.com; dkim=none (message not signed); arc=none (0) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ti.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=L3d/uqtROV07wByGxF+hfQgPvMnzChdKYg2ED7CQCyU=; b=a+2qtPZLz2Ywx7VAOK7D0n2dm9kffeiAduSn2c/Zn2JflrpkvUxHXS150mIIR6/LbZowg5nDdzntzobAq1BuHygNEVlO6U34ude1UrQ1iO1dzwRD4qhdChacw1NQl2ihvQWuc9/J1vHTHG3sbpTNfMV7tAFyJ3FvLNHwNn/0ksI= Received: from SJ0PR03CA0104.namprd03.prod.outlook.com (2603:10b6:a03:333::19) by SABPR10MB997918.namprd10.prod.outlook.com (2603:10b6:806:50c::8) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.21.406.4; Thu, 10 Sep 2026 10:42:48 +0000 Received: from BY1PEPF000264B5.namprd02.prod.outlook.com (2603:10b6:a03:333:cafe::71) by SJ0PR03CA0104.outlook.office365.com (2603:10b6:a03:333::19) with Microsoft SMTP Server (version=TLS1_3, cipher=TLS_AES_256_GCM_SHA384) id 15.21.406.7 via Frontend Transport; Thu, 10 Sep 2026 10:42:48 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 198.47.23.195) smtp.mailfrom=ti.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=ti.com; Received-SPF: Pass (protection.outlook.com: domain of ti.com designates 198.47.23.195 as permitted sender) receiver=protection.outlook.com; client-ip=198.47.23.195; helo=lewvzet201.ext.ti.com; pr=C Received: from lewvzet201.ext.ti.com (198.47.23.195) by BY1PEPF000264B5.mail.protection.outlook.com (10.167.242.122) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.21.406.5 via Frontend Transport; Thu, 10 Sep 2026 10:42:48 +0000 Received: from DLEE214.ent.ti.com (157.170.170.117) by lewvzet201.ext.ti.com (10.4.14.104) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.2562.45; Thu, 10 Sep 2026 05:42:32 -0500 Received: from DLEE208.ent.ti.com (157.170.170.97) by DLEE214.ent.ti.com (157.170.170.117) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.2562.45; Thu, 10 Sep 2026 05:42:32 -0500 Received: from lelvem-mr05.itg.ti.com (10.180.75.9) by DLEE208.ent.ti.com (157.170.170.97) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.2562.45 via Frontend Transport; Thu, 10 Sep 2026 05:42:32 -0500 Received: from pratham-Workstation-PC (pratham-workstation-pc.dhcp.ti.com [10.24.53.205]) by lelvem-mr05.itg.ti.com (8.18.1/8.18.1) with ESMTP id 68AAgVoZ3150113; Thu, 10 Sep 2026 05:42:31 -0500 From: T Pratham To: T Pratham , Herbert Xu , "David S. Miller" CC: Sebin Francis , Manorit Chawdhry , Vishal Mahaveer , Praneeth Bajjuri , , Subject: [PATCH v3 02/12] crypto: ti - Fix spinlock inconsistency in DTHEv2 Date: Thu, 10 Sep 2026 16:11:52 +0530 Message-ID: <20260910104202.1537226-3-t-pratham@ti.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20260910104202.1537226-1-t-pratham@ti.com> References: <20260910104202.1537226-1-t-pratham@ti.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: BY1PEPF000264B5:EE_|SABPR10MB997918:EE_ X-MS-Office365-Filtering-Correlation-Id: 9308dc7a-087e-4741-b799-08df0f28417b X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|23010399003|1800799024|82310400026|36860700016|376014|10067099003|6133799003|22082099003|18002099003|56012099006; X-Microsoft-Antispam-Message-Info: L8mo6lDtslEngmJi8UzbK/EMOIqREC3rQm1YZeERA65RGhmp1oCUs7mwH894i00atEvIsJp46MU2+jWf7v6aLXOMybCUsowZIV4sZoV7J5CNhKb6dBnrHkJIKErDe0Zux8IlKAyrXzDbFyLOzNLgPTWlpTVbr6c5lD5R3AdaSE87QraAhyccV+63M1o6U3GsORvGZy4mH3AQr8RKdb98pK901S5qIfwcVYAVpbYr3DWA3BVy8Ch9XCuFMHJygqr4Fji7EjmErCpiP6tcfPemNPCwDwIW2Qv1pAbDOp4I8bxLCNatNk7LLfrnDDLYaXRJF80PtQnhmeJKMpJ9y3LWOuSURGjFpIP5ZW9WoPrjVCEnfzgrjQJpqmd69BuhcxPVXxGnP9UNxSYV/UWB0z17HoNgYI9psnbLHt6ekVlco75Z9NmvDE7RBA2RaFFI4yRMuS+XSb4W8TR1cgc/LGS8uRh+6wmZD/ETWgIkNewG3gTiEyjOCPbys+WCOYAPPfAYdm6xGRiqF3oO4i9w/Tz5lhJIcq45qy2mLA2FKI+8i7Ob5syIAaviRuQ/IAeu2zl7WK3J8jKhBUfJB3zK+pd4Ex5qekfxn7r4ZWK1ocCLESaW2cL0J2VTTc9VVSi5XQrFeSV+DKtSLCpl6wVK+rSZ1cKUYu0+uqknqH8sVGkjLvbJ47UsGhvbT2y142IzDSHc3/vEz93oi8p5/7Dj4dXZ2g== X-Forefront-Antispam-Report: CIP:198.47.23.195;CTRY:US;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:lewvzet201.ext.ti.com;PTR:InfoDomainNonexistent;CAT:NONE;SFS:(13230040)(23010399003)(1800799024)(82310400026)(36860700016)(376014)(10067099003)(6133799003)(22082099003)(18002099003)(56012099006);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: fX4eY9IC4hLU7u7daLqXJNd7jG/2zfmCTq3zw2WDcwEY3E3dTIXt7eRoRA4L1YI3RftBpcYkWiZgrfa5kVVw6T6PnkfhGyC/Mgoseus56cvwbHLblS9aS27wxbNgkMh5l1v/k0d9k4ks9Z+Fq/wfU6Oio0M3cUJGr21QWemzWk085oHW+zpoe2oFdfcyEUcM1PcDXVgngbnSgb5IErcMlIC5c8M2rBe1iwdH5+oPAuHFaS2gZNsb9x/7JY+uMsXrfk0LarVnB780wif7hjPHhvg69by7DFfkkq4EfWr2wmdkTy0fFwK7n4pjxO/bh2NBU8H1IIPTtDXXbxW03nznjDeP3d5BiA5RxrPfMzquAmn/WDz4679ZOAZ/rkrqon4pXxbv14HUOTQkf+laqtsypeWdBHtYxWn8m1MvkluSYPKDFwLMx0jIQtkRl+WxCPpt X-Exchange-RoutingPolicyChecked: V+rRTdsucNmxSXvFNkScq/gaxYma6xBBPOymfXxD5q7jQ/o1U8260LASbKoWwZK72Ck34Rzaw4Lg2/3aLcdM/4SXNnsfkUVYvWL2Rgi1uYzT/vB1e+2HO6Mg5sCBGqMPJIR7NLQdKSIX+D+wxkx/5bDAxikQkiucWTXBCucI/S0ubJnneYcMHOleLaRF63PiEmEBGR9acrCg2cH6QRzZQwq1FXLI0ZuLBIALj5kN3a1Oyd76YsZBov6/E4LCOZdHjKobQyzGuvIeXGyWNdf1/5pC4jn9RL76ikUYFvJ0I1swe+thojiOhgzWhhZTvSnwPNLUok6YBVpIzimwD7u3GQ== X-OriginatorOrg: ti.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 10 Sep 2026 10:42:48.0283 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 9308dc7a-087e-4741-b799-08df0f28417b X-MS-Exchange-CrossTenant-Id: e5b49634-450b-4709-8abb-1e2b19b982b7 X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=e5b49634-450b-4709-8abb-1e2b19b982b7;Ip=[198.47.23.195];Helo=[lewvzet201.ext.ti.com] X-MS-Exchange-CrossTenant-AuthSource: BY1PEPF000264B5.namprd02.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: SABPR10MB997918 X-Proofpoint-ORIG-GUID: ho6VyGAnPAS1sjb2iWZwrJDPN94sngxb X-Proofpoint-Spam-Info: AW1haW4tMjYwOTEwMDEyNCBTYWx0ZWRfX4hMkbx0+gZd1 K4+QFNT8oQVYJS/sg8Bg1wifz8kxI6o4h0W0SHIvlvpaQquHv1QF7Wx8qeVPTM6noXu13wq5Z+q egI6UkDVxP5GOFcDkIfXHNJzhqZUJX4= X-Proofpoint-GUID: ho6VyGAnPAS1sjb2iWZwrJDPN94sngxb X-Authority-Analysis: v=2.4 cv=MqbHeGae c=1 sm=1 tr=0 ts=6aa289ac cx=c_pps a=MNM/txilNqeExyaWs+jKwg==:117 a=f+v6EHfkeJbVwR46tk4DMg==:17 a=6eWqkTHjU83fiwn7nKZWdM+Sl24=:19 a=VdqzKS8jKosA:10 a=s63m1ICgrNkA:10 a=V5UXEbMT0ywA:10 a=VkNPw1HP01LnGYTKEx00:22 a=Z8NIEmU8O1QQgoT56wFK:22 a=taLDd7a_hP9WKsMzeGRc:22 a=sozttTNsAAAA:8 a=ki2JzQWVm1jR-OH3vWAA:9 X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwOTEwMDEyNCBTYWx0ZWRfX5gugI5iI8wWB gUJ3zo45cemZUzCelKk4s702iASlFv6UnbacOyX58v8Uiyv2tucbI+4lVTIpVe97Jsbh4XXm+rm 8CbsBUjsvht1NeFKaxqVMnQRSRS8rIW6+9sMlL9082gKEiojLfeXjBvMv0J8K5Or2uyvsOOeDFd hI/lL/B1mCrLm3IAM6tcNRGx5F6qj94/Px+I9Jph1hT/WH8Ptnxzp7hNDgBEa6NTqNCvt6/sc61 fpWjeaomGSUHmh6ttrPS97O9oGU4Tlv6C1+XYIH2UgEa/XQYXOr4H1+c+eWxY4E2B2Mz0sRh34y z2U4B4szJbvjpIkVUF8JfSKhhfL3pJfLLfR9Ievk4zsC+yyy9hNbXthrLJu4AjyRO/TKYoPVWi6 PDDebpDJo4114nuI4mS8C8yUklwPYycczjhm8J4AHVPVlKe/d8ncKQeTcWLWdcUo2pjqcdq89L1 6FIViArWEayZvfOftRA== X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1176,Hydra:6.1.134,FMLib:17.12.100.49 definitions=2026-09-10_03,2026-09-09_02,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 clxscore=1015 impostorscore=0 phishscore=0 lowpriorityscore=0 priorityscore=1501 spamscore=0 bulkscore=0 adultscore=0 suspectscore=0 malwarescore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2609040000 definitions=main-2609100124 Content-Type: text/plain; charset="utf-8" Probe and remove functions use spin_(un)lock for acquiring the dthe_dev_list.lock. But dthe_get_dev uses the bh variant. Change spin_(un)lock_bh to spin_(un)lock to avoid potential deadlock when a softIRQ process tries to acquire the already held lock. Fixes: 52f641bc63a46 ("crypto: ti - Add driver for DTHE V2 AES Engine (ECB,= CBC)") Signed-off-by: T Pratham --- drivers/crypto/ti/dthev2-common.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/crypto/ti/dthev2-common.c b/drivers/crypto/ti/dthev2-c= ommon.c index cc02449382673..4c6b72ba104ec 100644 --- a/drivers/crypto/ti/dthev2-common.c +++ b/drivers/crypto/ti/dthev2-common.c @@ -39,11 +39,11 @@ struct dthe_data *dthe_get_dev(struct dthe_tfm_ctx *ctx) if (ctx->dev_data) return ctx->dev_data; =20 - spin_lock_bh(&dthe_dev_list.lock); + spin_lock(&dthe_dev_list.lock); dev_data =3D list_first_entry_or_null(&dthe_dev_list.dev_list, struct dth= e_data, list); if (dev_data) list_move_tail(&dev_data->list, &dthe_dev_list.dev_list); - spin_unlock_bh(&dthe_dev_list.lock); + spin_unlock(&dthe_dev_list.lock); =20 return dev_data; } --=20 2.34.1 From nobody Fri Sep 25 16:51:46 2026 Received: from mx0a-0002e601.pphosted.com (mx0a-0002e601.pphosted.com [148.163.150.75]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id C9C6C45A297; Thu, 10 Sep 2026 10:43:07 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=fail smtp.client-ip=148.163.150.75 ARC-Seal: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1789036990; cv=fail; b=bF8BOfMJbK43KgOuST8TyS4PfwCdc9hdpSBjKXoixreiosNL49MCGeuGRdl35APaH5lWwSVSIncOoG8Vv2MA6PvbiMlnabl/Zju479cRvHbibO1uvY4TIfT+jVsVkQh8khFmhyBKe3QBLep55fTixQqRc9e9oESIEXVoZzz3Mbg= ARC-Message-Signature: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1789036990; c=relaxed/simple; bh=SytUeFdB/MKaYKaubrhZRnRz1jmrcwLjp0R6X9UVqZU=; h=From:To:CC:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=G7iEUHVVHXnR1hKm/8scN3TIg+rXaiz7A5n8jxAlufX5YzRl5A3wB8/s5LJwfR2ZEkzNcYJFa8DNF8ksHmqtCfjzS3subtdinfPk7JCUYhuYFIXyQ9Vty89CXVENGmCsMCZDR8fb/PIXBIZmGH5ufndbBlr1bIq1ec3nmwkpWFU= ARC-Authentication-Results: i=2; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=ti.com; spf=pass smtp.mailfrom=ti.com; dkim=pass (2048-bit key) header.d=ti.com header.i=@ti.com header.b=M1g/DWbp; dkim=pass (1024-bit key) header.d=ti.com header.i=@ti.com header.b=AFFy41ZJ; arc=fail smtp.client-ip=148.163.150.75 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=ti.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=ti.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=ti.com header.i=@ti.com header.b="M1g/DWbp"; dkim=pass (1024-bit key) header.d=ti.com header.i=@ti.com header.b="AFFy41ZJ" Received: from pps.filterd (m0384305.ppops.net [127.0.0.1]) by m0384305.ppops.net (8.18.1.11/8.18.1.11) with ESMTP id 68A8oH6T712619; Thu, 10 Sep 2026 05:43:05 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ti.com; h=cc :content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s= proofpoint-05-2026; bh=ys2sjHHwD+AiPU99+X4BPnXwi+/C0iIWiOc5Chq+H GE=; b=M1g/DWbpJ+7bVBleuag8rhJLsfHLPIN0EnbvXYPGT9wwQA6fNM38uOdAZ TDcr/E++BswinrCBVpm+Q13J0f/9CpUcXv2C2E9z/FIPiYXWjfgU4xDBNSBVslFJ uosa9vCQKZ9+jtv535l19vWks4igNBdRU2wX7V3mjJS+Pp/2jTBjeXdRMkzHAKQM U9lT88ofNY8KnAoPldg6G0Rxa4q/C/hbPYo5VNhdzWtmAyZJDUVz9Xj+AswcYarD lVTKVGnB1FYDZ0dARWZIAZMZCcXnnr2GYScZr/KyQgN+taTN6KHlDjuRVTy2TXmC tIvcJ6cGkdg0kMu21FLsw6DxL7TSg== Received: from cy7pr03cu001.outbound.protection.outlook.com (mail-westcentralusazon11010014.outbound.protection.outlook.com [40.93.198.14]) by m0384305.ppops.net (PPS) with ESMTPS id 4gkcxgcnxd-1 (version=TLSv1.3 cipher=TLS_AES_256_GCM_SHA384 bits=256 verify=NOT); Thu, 10 Sep 2026 05:43:05 -0500 (CDT) ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=I/LLolDbd6KOXPO0GEF07tLcGwtYoLsfTzAp8DA2afmZ1j8Yqj4cjrvAlSHTf8vsXAZ+3d4VnP9OY74lVGdrh7scQaWRdUbfa7FiUSnKVgeZqxurdA+erOjM+SycZaLblt8Kom1TLEFOVJ9cckjZ40a6sij9t4Vm3JqARm//ju2d80p/MZwl06ra3b77dVHn7KuWb1vIu808YcUC332O09eV7PyjyhkjrjUQuS7ZoNCkRSNhynA3veW8VyabEtIma+0Nyt0AaVNJNHvSLpHjHZ5MEC+14l1PjqayNM/MPn+l9MhjuSoN7dqcRhS1BzeDJuZgxhGHxkAafzvqp8uueQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=ys2sjHHwD+AiPU99+X4BPnXwi+/C0iIWiOc5Chq+HGE=; b=QbYDRbPuJ8LVRhQ+ewMWqnkszwvSmdpkhFtBa28co6WxVVsukLCYPfFFLWw/VVS8vsZgXktkPW+9RG9MAVSHRuAOIMgDG8l6H2zvs0oKon7OemujNQzWn6nw13F0FpDuZOD/84plUGBhgALVXxqWxrw9j6rwaZuaW8N9qqZFPjpLTtob3fcodlyWDIzBfOIAs4YNCh9TGiIpC9lXe9bXW1C5qdV4PekqRz7wVXorlmHZxOFc/FiGFuhrAkEJntEzZ/lK7B1E91924PfTEERbzmIINsAB1A4V52y9nLWgD9oOAj2xsk+8A1rUPascGi91aABc0NhJUld3JMvDLfv8Ng== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 198.47.23.194) smtp.rcpttodomain=gondor.apana.org.au smtp.mailfrom=ti.com; dmarc=pass (p=quarantine sp=none pct=100) action=none header.from=ti.com; dkim=none (message not signed); arc=none (0) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ti.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=ys2sjHHwD+AiPU99+X4BPnXwi+/C0iIWiOc5Chq+HGE=; b=AFFy41ZJzgcVbeI9EkCI9NnQWnh/OkhU7He0jULrK8qiOMKUINrjHBRkEsXzSx7mOYGa5sfuNyNRJ01Gkuywb6Ytfr8at8J6coPMQtrOEjj1jL+5AMD5JrKH+WCy2YweEACzqtwe4E4jEQgqQSwba58beEQd0UGAYJc/ju0XFFM= Received: from BY1P220CA0021.NAMP220.PROD.OUTLOOK.COM (2603:10b6:a03:5c3::16) by IA1PR10MB7358.namprd10.prod.outlook.com (2603:10b6:208:3fa::8) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.21.406.7; Thu, 10 Sep 2026 10:43:02 +0000 Received: from SJ5PEPF000001EF.namprd05.prod.outlook.com (2603:10b6:a03:5c3:cafe::2) by BY1P220CA0021.outlook.office365.com (2603:10b6:a03:5c3::16) with Microsoft SMTP Server (version=TLS1_3, cipher=TLS_AES_256_GCM_SHA384) id 15.21.406.7 via Frontend Transport; Thu, 10 Sep 2026 10:43:01 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 198.47.23.194) smtp.mailfrom=ti.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=ti.com; Received-SPF: Pass (protection.outlook.com: domain of ti.com designates 198.47.23.194 as permitted sender) receiver=protection.outlook.com; client-ip=198.47.23.194; helo=lewvzet200.ext.ti.com; pr=C Received: from lewvzet200.ext.ti.com (198.47.23.194) by SJ5PEPF000001EF.mail.protection.outlook.com (10.167.242.203) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.21.406.5 via Frontend Transport; Thu, 10 Sep 2026 10:43:00 +0000 Received: from DLEE213.ent.ti.com (157.170.170.116) by lewvzet200.ext.ti.com (10.4.14.103) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.2562.45; Thu, 10 Sep 2026 05:42:35 -0500 Received: from DLEE211.ent.ti.com (157.170.170.113) by DLEE213.ent.ti.com (157.170.170.116) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.2562.45; Thu, 10 Sep 2026 05:42:35 -0500 Received: from lelvem-mr06.itg.ti.com (10.180.75.8) by DLEE211.ent.ti.com (157.170.170.113) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.2562.45 via Frontend Transport; Thu, 10 Sep 2026 05:42:35 -0500 Received: from pratham-Workstation-PC (pratham-workstation-pc.dhcp.ti.com [10.24.53.205]) by lelvem-mr06.itg.ti.com (8.18.1/8.18.1) with ESMTP id 68AAgY902177590; Thu, 10 Sep 2026 05:42:34 -0500 From: T Pratham To: T Pratham , Herbert Xu , "David S. Miller" CC: Sebin Francis , Manorit Chawdhry , Vishal Mahaveer , Praneeth Bajjuri , , Subject: [PATCH v3 03/12] crypto: ti - Fix potential memory corruption on highmem pages Date: Thu, 10 Sep 2026 16:11:53 +0530 Message-ID: <20260910104202.1537226-4-t-pratham@ti.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20260910104202.1537226-1-t-pratham@ti.com> References: <20260910104202.1537226-1-t-pratham@ti.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: SJ5PEPF000001EF:EE_|IA1PR10MB7358:EE_ X-MS-Office365-Filtering-Correlation-Id: a0cf1929-16e3-4f72-a578-08df0f2848c0 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|36860700016|376014|23010399003|1800799024|82310400026|10067099003|56012099006|6133799003|22082099003|18002099003; X-Microsoft-Antispam-Message-Info: dRFdBcI9bp3GVr9/FXVI8GwtYzsU9uMygghWSQTKKAlW7vPcZZE65zh+mY6+3fAWAkV9KtSq7HC1aRkw1MZF3drETnxhOzN9vqFViwPBV5RDR61lY7lH70pUkRd9nDHpnNDoyT3LiSsjnN4koh+XVwy/NukDEidAt/KokrbKjekks9WjVFCK1lXtWOBMttRmX8dzTH11y4Nbtyi8EXYBcpS+qFlRTawRFr53CRDRpqrqIZjuZhSaRGqyxgmi8xE85YWDz1YI0LfLeoQoyiv7VkEb9Om9a2gay/Dk46zuRdL69dAwYz9NMUuLRY0KYv1OchvuugWliNPQN4atms1x8WfZX0vbcPg0fyRCc9w1aI2W6OlPDR8sfIFVaDPfQKcnzuk52V8go35wGWWtvHOkaj/y0bFwGiBOebjCVOILwJHWJ48/Wzq8Y/cArzqW9Xe/zfMEaYA8ohJXDyELkxTs8hv1IdhFXqZ2FTosIZ5/xQOiijq9bxClwMUernhkQPMMOB9u0Hr6KyeICxqw6HThc6GTdTKXoP4fhN0l21YFHDQWGnamz/oIWIRcF4u2HYZ9UJx1JvETvfW/FSrLzAiyb4RQh07rBzPfanzJ2OGWUhYEroJp4tst/CHnEGRzcSq27X2kGGPmmkITWqX0nseaqwtcn8ho/NqV0KKFSKxbw5QkdqI5Iubmy4dlPGE7GtAIOvR5F/XgkwbNz4pqNftqCA== X-Forefront-Antispam-Report: CIP:198.47.23.194;CTRY:US;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:lewvzet200.ext.ti.com;PTR:InfoDomainNonexistent;CAT:NONE;SFS:(13230040)(36860700016)(376014)(23010399003)(1800799024)(82310400026)(10067099003)(56012099006)(6133799003)(22082099003)(18002099003);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: 5QzD4NkXr7sgh0sP6MXpx59wD2pm6gqdO4J5kqtxiHdKH0/3X1bc6eRwLdkSvdbHdhlrkmN4tTqwN1ha1Sh6tVmCQij03XxxJa3GHbuudJ/HKInvxiuR+0uq/+3ogcsA/cgpGbhA9WJYEpFeznN7ctziQWsjBPiwKg36JOUGOQhIjcEdtYW9XEjmtLgSDiTtSuCXNitChXPNymxhInSROx9nTwc5HY+0o07bAZhhHwB7uLo6uIKQjVHlflsT3cuExBhgqepERZhQLLtgxry7Aq2THFRse7HK/qyqVpbylR+np3xVFx2G76P7gXY1Fn9j3C8dyUfvMd+FHD4CBe9cV/FHf+LTjz8IBd6KdJtiNb4FxqNYKDDSSB6ilvflUORKe4xOt2VCEoJOhpY1l1DL9qbsoWSWZOZ0MwbgV2AsSZEX5x3O8ZbWhF2d/Q5TUdjb X-Exchange-RoutingPolicyChecked: v19fE/bwUaZYPD1e/UmuKorJbBruJkc9rE0KEE6LjHCFaOFS7/NCEp6Ps7fqNH354eHfl+RWamPmGq5sLRfrthbuawVd12i6NiIXZQCJD1IuYawm0ZLch2qY5cqd6QwyEEB40pA1FfeMh9Lx5fo6wPQ3jX07loo8JSKIlpakSCBo/nuhTOotmx0qeMD/gFZRyQ7gVL/gzIAmL5Ox22cPRJT37Ei7XgnQh1c3lSweo/UXVbVcZezRKxj/bRy/H8Hl3K4t0cL6DIqd7nzyO+4dSYSaBsnQkhRR4it4qiGJqC9WH82IhJ+gF+J3C1BNOUCK3CkFR8sIwRZmQx/U4KDY6A== X-OriginatorOrg: ti.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 10 Sep 2026 10:43:00.2219 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: a0cf1929-16e3-4f72-a578-08df0f2848c0 X-MS-Exchange-CrossTenant-Id: e5b49634-450b-4709-8abb-1e2b19b982b7 X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=e5b49634-450b-4709-8abb-1e2b19b982b7;Ip=[198.47.23.194];Helo=[lewvzet200.ext.ti.com] X-MS-Exchange-CrossTenant-AuthSource: SJ5PEPF000001EF.namprd05.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: IA1PR10MB7358 X-Proofpoint-ORIG-GUID: YiUHgrHkLisqWOITHozOnBSbirpC3xY7 X-Proofpoint-Spam-Info: AW1haW4tMjYwOTEwMDEyNCBTYWx0ZWRfXzEoz48UdjfIQ Jdx3cniwJ1JjW9Q4FCRDpPqHDfDlkeWDvhK4kvbI2JdijH9g4nLKJQlrzPfzy+joYZoUKifPBNg Jp+2aRQs4JaZ55zJCV8EZXrr+j8U7Z0= X-Proofpoint-GUID: YiUHgrHkLisqWOITHozOnBSbirpC3xY7 X-Authority-Analysis: v=2.4 cv=MqbHeGae c=1 sm=1 tr=0 ts=6aa289b9 cx=c_pps a=CzkwbHv2eVnX1aWe+0O+5A==:117 a=WotqVVQAdb04rnGuttW3Kw==:17 a=6eWqkTHjU83fiwn7nKZWdM+Sl24=:19 a=VdqzKS8jKosA:10 a=s63m1ICgrNkA:10 a=V5UXEbMT0ywA:10 a=VkNPw1HP01LnGYTKEx00:22 a=Z8NIEmU8O1QQgoT56wFK:22 a=taLDd7a_hP9WKsMzeGRc:22 a=sozttTNsAAAA:8 a=IXP722aH8NCvtdUuCEcA:9 X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwOTEwMDEyNCBTYWx0ZWRfX4l/7myDXCnfU SWFv9UKRt63l9KZOwZG/MKWOCZ/SFxlb/uOqKTBnMWp8bAFBoAvYjX3YLYnbvFHW8NrNskZpyLb 9QAa7agLYIrK59LVWYAFQm4hJZhd9yAz+2kw9zNr1iOKK9mEE6EM4MaE+tG7cJ8iAKqIHuta868 OBNSIc0uEGfpGFeEgBc9v6RVmic54e1KetSExazX6dWmNLxBtFTsTa21RuD57t2lnwmqohhqYFE vDY3yLl5XQWxrQ7e/4JjxlS+bcRB3xXhKFYd5sFB+Cc6niYODkUcdIRc85n/dGGz5Ban5LxB5lo nVJ2keDaGyRs71c+QkCXz4+MuRVaDCPSG9Usza0CuFkKOKRfsMklDMXyZicXEOLsU5p2X87mxRZ ehabYPaBaRHRAadoXPa3rzNq2fA1f68nP7XD91fOcu1C+S55ijDerhqKY5VRw1fWMVRASBBjqe+ WfuXIc1ny29MkG82z8w== X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1176,Hydra:6.1.134,FMLib:17.12.100.49 definitions=2026-09-10_03,2026-09-09_02,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 clxscore=1015 impostorscore=0 phishscore=0 lowpriorityscore=0 priorityscore=1501 spamscore=0 bulkscore=0 adultscore=0 suspectscore=0 malwarescore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2609040000 definitions=main-2609100124 Content-Type: text/plain; charset="utf-8" Change sg_set_buf to sg_set_page in DTHEv2 dthe_copy_sg function to avoid using sg_virt() on scatterlists. For scatterlists containing a highmem page, sg_virt() yields invalid or null adrdess, causing potential memory corruption. While we are here, also change function signature to change buflen from int to unsigned int. Fixes: 35645ca63caa1 ("crypto: ti - Add support for AES-CTR in DTHEv2 drive= r") Signed-off-by: T Pratham --- drivers/crypto/ti/dthev2-common.c | 4 ++-- drivers/crypto/ti/dthev2-common.h | 2 +- 2 files changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers/crypto/ti/dthev2-common.c b/drivers/crypto/ti/dthev2-c= ommon.c index 4c6b72ba104ec..8628187a32e18 100644 --- a/drivers/crypto/ti/dthev2-common.c +++ b/drivers/crypto/ti/dthev2-common.c @@ -50,7 +50,7 @@ struct dthe_data *dthe_get_dev(struct dthe_tfm_ctx *ctx) =20 struct scatterlist *dthe_copy_sg(struct scatterlist *dst, struct scatterlist *src, - int buflen) + unsigned int buflen) { struct scatterlist *from_sg, *to_sg; int sglen; @@ -59,7 +59,7 @@ struct scatterlist *dthe_copy_sg(struct scatterlist *dst, sglen =3D from_sg->length; if (sglen > buflen) sglen =3D buflen; - sg_set_buf(to_sg, sg_virt(from_sg), sglen); + sg_set_page(to_sg, sg_page(from_sg), sglen, from_sg->offset); from_sg =3D sg_next(from_sg); to_sg =3D sg_next(to_sg); } diff --git a/drivers/crypto/ti/dthev2-common.h b/drivers/crypto/ti/dthev2-c= ommon.h index d4a3b9c18bbc1..75d9a097650da 100644 --- a/drivers/crypto/ti/dthev2-common.h +++ b/drivers/crypto/ti/dthev2-common.h @@ -126,7 +126,7 @@ struct dthe_data *dthe_get_dev(struct dthe_tfm_ctx *ctx= ); **/ struct scatterlist *dthe_copy_sg(struct scatterlist *dst, struct scatterlist *src, - int buflen); + unsigned int buflen); =20 int dthe_register_aes_algs(void); void dthe_unregister_aes_algs(void); --=20 2.34.1 From nobody Fri Sep 25 16:51:46 2026 Received: from mx0a-0002e601.pphosted.com (mx0a-0002e601.pphosted.com [148.163.150.75]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 7D98845D927; Thu, 10 Sep 2026 10:43:21 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=fail smtp.client-ip=148.163.150.75 ARC-Seal: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1789037005; cv=fail; b=EqkvwhwKJ/kw2YEKeoxU/vRPzNAJfKxQYRHnDtM/8M+pkM7QY3KWLTH823SF6YphZYnPYFQlfOmmw340m9houY4H2w1P4Pl0sAk7A2py5ohjbwOvpS5+QlWFBhaielohZhsN5m0WMc494dfY9aH0whhVquN2QUrqiMxPuiRegYM= ARC-Message-Signature: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1789037005; c=relaxed/simple; bh=qDm9YMpatm3c2GeOSqBVtYYx+wjpO01nOH9SWgJq3SQ=; h=From:To:CC:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=K0auOSiWxwJbmLGTG1AWSi5/car+PXZYBcTVNGYCavTGStSWGDL03OYF0GWMyio0Q1RSgwduUO8IiyMZ7l5swKYZlLAlYjfajXpSYKASF7OtH5AxKuk2z8uQ3Ep+G7S/TMnCCSBOwaQcOfghkqEE+4mEqfBEpnSPfs8Znkyx4eQ= ARC-Authentication-Results: i=2; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=ti.com; spf=pass smtp.mailfrom=ti.com; dkim=pass (2048-bit key) header.d=ti.com header.i=@ti.com header.b=JkGXZjoE; dkim=pass (1024-bit key) header.d=ti.com header.i=@ti.com header.b=VRChaBoJ; arc=fail smtp.client-ip=148.163.150.75 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=ti.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=ti.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=ti.com header.i=@ti.com header.b="JkGXZjoE"; dkim=pass (1024-bit key) header.d=ti.com header.i=@ti.com header.b="VRChaBoJ" Received: from pps.filterd (m0384305.ppops.net [127.0.0.1]) by m0384305.ppops.net (8.18.1.11/8.18.1.11) with ESMTP id 68A8oJLu712686; Thu, 10 Sep 2026 05:43:18 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ti.com; h=cc :content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s= proofpoint-05-2026; bh=Juwpi7NMHqBhbVSei/QV3uz+jT/nxHXTax9Iy/G0i o4=; b=JkGXZjoExI4AhbVKv0t/hVq7qgB9EmW32c0WSCjN3a9Ml3nCjEqzuB0Xl PqdXirUYlIhP+6r7ZdEA0Jp6CaLjcMRTm+67pj/ZqxwvX+4gQ6r9klwc2BV7Lun1 78U1x9hBDvY3vRJMPMiPYlOhZRFHQTvQoI78poZNhRXM3LuWXWiRg2Zdwb53IGnG j2E8TqXcAxb9ZKgvtQhfl5s67zTzWXe3stUBSHJFifzLtFh+KlL6CDCCgq+l7ISg naHpFh+1huup6v2dwysZ0K3EBStJ/OkcFBhRwNs6l7timCs6oQcx7SGcJ+NL7+4F OXWOtaz4xWhRhWa48y+P9RcOW/Jxg== Received: from ph0pr06cu001.outbound.protection.outlook.com (mail-westus3azon11011009.outbound.protection.outlook.com [40.107.208.9]) by m0384305.ppops.net (PPS) with ESMTPS id 4gkcxgcny8-1 (version=TLSv1.3 cipher=TLS_AES_256_GCM_SHA384 bits=256 verify=NOT); Thu, 10 Sep 2026 05:43:18 -0500 (CDT) ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=G3RjMZlgyvsOZRu9EuMuN988BVZI/0lavmNlz35PJRQ9KwHpd2lfzZv1yHDZxvqwAQh/UfQvcmo/TEVibXT/q/X2d2Vvdd3oCCL7WKXeOzkS4owj9kPnpuzolrRD2YXOarubbNyyxkJcLaUjAZa4ERgD4hAtXlL/+6NET3vo/hJxu34qp9OQ0mrbJgt+ddPyDOh/zf7VAMnZS5ToPqBuKcT/5V+zzE6tPXGLuR3bdcwuUbs51t4OA1tNSQ8so2FagEZLW1kJKfmr4JctTTvvYuNeNwj5cinvxQO5WKUaft+WdTXeBITjhLTFbEL1aZvpv4aEoFxJ68PCDSHXYq+gcQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=Juwpi7NMHqBhbVSei/QV3uz+jT/nxHXTax9Iy/G0io4=; b=SLYtv4Ennnf8EIQVE+/It9EgBdngOflqXf77NfCumSZ94I9jLXnACKZfi+qMCr7vea1NVpz/NPSXpiWEuQ7SCPibk3LobQOZK+HeaziCC76uwug/WloXdwmxn427NGcZczlCcp2Umk2l+mnlSfu5jVEwOxZP61kAcg+rq+bD7Nn/1cp8g5t168m/pcXGe7Dn+Ib6IN0aWbcbMxqd3WA788C0X5M0srocgihx7Z9qUstBrJFWdrkjN6N06vqzJt2/rV+dlc6FA3XqlQTYGrlVWGiViUf8sNQ9AeBaJdVIiDfJrJjy6ZTGV279OxVSxjETjf939uQYYO80+9XP8/gGtQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 198.47.21.195) smtp.rcpttodomain=gondor.apana.org.au smtp.mailfrom=ti.com; dmarc=pass (p=quarantine sp=none pct=100) action=none header.from=ti.com; dkim=none (message not signed); arc=none (0) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ti.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=Juwpi7NMHqBhbVSei/QV3uz+jT/nxHXTax9Iy/G0io4=; b=VRChaBoJcbb+J2l04KUQSWp8RqTPS981ol4D8nCfy0qquIaW4aun/KBiQt8poNekXAO9Z2/mRT/VWmmy1tUMxCoVeEigAe1ExhyTkzuQG5ApiNcclZhBnnlvE8uSzn+g6+byAa00Esp1DY21uI4L+XAz/65ONbcpttSGyXfkgOM= Received: from DM6PR07CA0086.namprd07.prod.outlook.com (2603:10b6:5:337::19) by SJ5PPFCBE2A5DAD.namprd10.prod.outlook.com (2603:10b6:a0f:fc02::7cd) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.21.406.7; Thu, 10 Sep 2026 10:43:14 +0000 Received: from SA2PEPF000015CA.namprd03.prod.outlook.com (2603:10b6:5:337:cafe::1e) by DM6PR07CA0086.outlook.office365.com (2603:10b6:5:337::19) with Microsoft SMTP Server (version=TLS1_3, cipher=TLS_AES_256_GCM_SHA384) id 15.21.406.9 via Frontend Transport; Thu, 10 Sep 2026 10:43:13 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 198.47.21.195) smtp.mailfrom=ti.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=ti.com; Received-SPF: Pass (protection.outlook.com: domain of ti.com designates 198.47.21.195 as permitted sender) receiver=protection.outlook.com; client-ip=198.47.21.195; helo=flwvzet201.ext.ti.com; pr=C Received: from flwvzet201.ext.ti.com (198.47.21.195) by SA2PEPF000015CA.mail.protection.outlook.com (10.167.241.200) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.21.406.5 via Frontend Transport; Thu, 10 Sep 2026 10:43:12 +0000 Received: from DFLE205.ent.ti.com (10.64.6.63) by flwvzet201.ext.ti.com (10.248.192.32) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.2562.45; Thu, 10 Sep 2026 05:42:39 -0500 Received: from DFLE214.ent.ti.com (10.64.6.72) by DFLE205.ent.ti.com (10.64.6.63) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.2562.45; Thu, 10 Sep 2026 05:42:38 -0500 Received: from lelvem-mr05.itg.ti.com (10.180.75.9) by DFLE214.ent.ti.com (10.64.6.72) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.2562.45 via Frontend Transport; Thu, 10 Sep 2026 05:42:38 -0500 Received: from pratham-Workstation-PC (pratham-workstation-pc.dhcp.ti.com [10.24.53.205]) by lelvem-mr05.itg.ti.com (8.18.1/8.18.1) with ESMTP id 68AAgbEW3150195; Thu, 10 Sep 2026 05:42:38 -0500 From: T Pratham To: T Pratham , Herbert Xu , "David S. Miller" CC: Sebin Francis , Manorit Chawdhry , Vishal Mahaveer , Praneeth Bajjuri , , Subject: [PATCH v3 04/12] crypto: ti - Fix use-after-free of dev_data on DTHEv2 driver removal Date: Thu, 10 Sep 2026 16:11:54 +0530 Message-ID: <20260910104202.1537226-5-t-pratham@ti.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20260910104202.1537226-1-t-pratham@ti.com> References: <20260910104202.1537226-1-t-pratham@ti.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: SA2PEPF000015CA:EE_|SJ5PPFCBE2A5DAD:EE_ X-MS-Office365-Filtering-Correlation-Id: 9651f42d-062d-4d51-750d-08df0f284fec X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|82310400026|36860700016|23010399003|376014|1800799024|56012099006|10067099003|18002099003|22082099003; X-Microsoft-Antispam-Message-Info: GlKu0/ykC4/hOr2KrLW6VFg5df13xiaGL9ZtyPT7oMJMH4hfV+ymyPP7Zbul0p/JZPpDE8eH9FZ2ecIF+Ok/xTlA4PdKdV+AnNBUoiTeteICsVFQZh1sbVtN6zuE6hFi52xVIbkIaOllBVZb+T9v98WJHBt291cSBDwXyChwPsLdrQAQ+aSWISx9eQ0AcWJuLpmc5bUfwQcSmNULOznVNOeqCo2Hqq11om00+z9ttpqpLtYV9Z/brra3t1kOMiRm54mj/ROPiYKml0sdfz9VATncfmR/1rGO6uSIONZKDAdL0I5Uh3jtiag/XCjreckmgg2cMpOuwkZ3ie8fWu4H731w5vINGGIIsC2Ew7i5YaN870OzwZquCk7gXW9bcZ0Dp9jc/bHVmYA+pQlK7nHJ9NXF1g24xbMQXoUiDGFtd/PM69ZZ/MEy+CxvbM6YBz2iYBjDxpYVbf9N6gEH8gDHhw9rxTc6MwhyRsCag+4xXOv0/i2pYxvyBqL5ytrnfxZzxPm//fNSu/7tD13LL/BXf/NTVycMioZgyxmBUQV+v56kHTOkGA/aNm0atcoan1UW7vHqY1IWUhvZIoQ6gcYRZs1N2Ku2n6i27vaQvgGf6Gk7hj+dV6etA719k1nNpXNuwBYP6a2VwUUW6e5nfxQfubUta0V+C25EkPXpEUUkRw6DYjzJy/m/NIO+Q/BU9D+97zcSXH6O2hg8vhCy6JM1uw== X-Forefront-Antispam-Report: CIP:198.47.21.195;CTRY:US;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:flwvzet201.ext.ti.com;PTR:ErrorRetry;CAT:NONE;SFS:(13230040)(82310400026)(36860700016)(23010399003)(376014)(1800799024)(56012099006)(10067099003)(18002099003)(22082099003);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: SkJwbcsQWup0VHClnsCUEenLI8a/Y68wu52/XrD+C8Fzwg7sKc9GIDzgjO28eQdMO1fKLoHfXxAFfCiAYztM4BPkJm/USNGqsn3CHyW/qOMIrcLxDQAz8QkUp4Q9ZeJdAFCA8Sk13oz0Y0axnPn5qXCVl0D7uOgxlG6SQlJHlbzRu5FujEnHgXAXuuGl3IrBrgXuW5F5mSAmSAKehIPiD5fQu3tBXU5n5Dc21o3NJ5ZQ7L5suyQ4M1y4M2jrw57/Oo0v81Muwb1sBKgGMP5d3FuPKVLWs3/GPO7eqEKQ8aBmjQpfxKvpkpWca5z7/96IKos287mrnIQ1IcBKxCHONWPda2HdBDVRqQmqHh8bM7f+mwMp+VTM2/OP+wf9e/3WWAOoGsddwTWLNl4m6PpgMahnr0MAP7KlkXIt94SmNBjQI3GR99hrKdpJS9YW/GFf X-Exchange-RoutingPolicyChecked: t2g69eGkxYFax6de3Mlh1wFec6aF6itPST4ZjHCn8j5JYiHa3DKd2SFResnB2urppTLieCVSNVLvkcPeA1l6XOct7Y/7VO4i+FY6ucTR5DgHulaK7LtwtQNqsuiYmxDHqhK1QIW4v9CTMukfJuRZT/m3pBEfTUZqr3uNbwS7oSAFEmnA6f/rKHUMs2nnenC8J6c4U/mxm2cCHzuci5JeTj5iN0yUc0PccEF+k6Ori62dYy7TPLvpc4/K/NR1hwWfbLZYpVnVSLFiEZDDH54bjdkcqSIVOgLt5ktBWN51NRqdBjfflukxY1suUD7lUqMs+qp61hLbgJdiWcW2GQ3R+Q== X-OriginatorOrg: ti.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 10 Sep 2026 10:43:12.3108 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 9651f42d-062d-4d51-750d-08df0f284fec X-MS-Exchange-CrossTenant-Id: e5b49634-450b-4709-8abb-1e2b19b982b7 X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=e5b49634-450b-4709-8abb-1e2b19b982b7;Ip=[198.47.21.195];Helo=[flwvzet201.ext.ti.com] X-MS-Exchange-CrossTenant-AuthSource: SA2PEPF000015CA.namprd03.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: SJ5PPFCBE2A5DAD X-Proofpoint-ORIG-GUID: s-U5H07RS9FGdO76TG7UO_qWa-RbGESe X-Proofpoint-Spam-Info: AW1haW4tMjYwOTEwMDEyNCBTYWx0ZWRfXwWeYBvGdSr2g r1KmqNhBNRs4JDPwW9KrcJzKBjpv7tOewR0xXz64to8+OY4yLDxSFTkXQeYA1w37J0teWK8drsH BtZZQ0O4lkCcOIyYW8MWd6B2czXvgOE= X-Proofpoint-GUID: s-U5H07RS9FGdO76TG7UO_qWa-RbGESe X-Authority-Analysis: v=2.4 cv=MqbHeGae c=1 sm=1 tr=0 ts=6aa289c6 cx=c_pps a=8LlSNZ/L86USH+wcAhsXzg==:117 a=tJyPKKxUohctrY4NYmUjkA==:17 a=6eWqkTHjU83fiwn7nKZWdM+Sl24=:19 a=VdqzKS8jKosA:10 a=V5UXEbMT0ywA:10 a=VkNPw1HP01LnGYTKEx00:22 a=Z8NIEmU8O1QQgoT56wFK:22 a=taLDd7a_hP9WKsMzeGRc:22 a=sozttTNsAAAA:8 a=b_Sv9-5cbYMGkstBTwQA:9 X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwOTEwMDEyNCBTYWx0ZWRfXzxhuTTn+sVtW /WJUmD7lhLKnTSWYabwwrUWNpipK3Fkn/Gkl8LKcYutdkA6+VBHgGgWniXb8VKAof1V1hH1yTG9 3t/GvG07mjrV3MO3xElaAiy+gy9DkFTwn9SEhlODgmIxsA+2+hj4B19jx9wl2Q2lmEWC1Js1bRP GcKLgBcDtSVPCpAzyksnlanrp1hpPgDIjlOHE4EL1ibhNsiueCnDtgtJ7Sy/UfT/nQPEOWrGI48 dvZGNoDhcjibB5wtG2cbhs/fFfPxj+7uNYH8O6Hj65AyJRp4oEE+DSkeoP5NgOG9YDmEa4Hx0Ej QAaWXbm6xljL6Lfq8C5rjLm2rKgXyE0cxMCMa0x9e7IfbXbii9g8Qbgkmdu9MIijfGBi4OTZndr S+B9bxw/ewVHWHWQGfIOhOEzuafwlm0ptIve2/v+HVx3ukaTaWJ3Xq0Ha0Oa0i42PxOEHrPsTBA wDh5Sbjl07QFv2X+kWw== X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1176,Hydra:6.1.134,FMLib:17.12.100.49 definitions=2026-09-10_03,2026-09-09_02,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 clxscore=1015 impostorscore=0 phishscore=0 lowpriorityscore=0 priorityscore=1501 spamscore=0 bulkscore=0 adultscore=0 suspectscore=0 malwarescore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2609040000 definitions=main-2609100124 Content-Type: text/plain; charset="utf-8" Each *_init_tfm() caches a pointer to the per-instance struct dthe_data in its transform context (ctx->dev_data), but never takes a reference on it. If there are tfms in progress when dthe_remove() is called, the devm allocated dev_data gets freed. Then ctx->dev_data will point to a memory that has been freed. Move dthe_data to req_ctx structs of algorithms, and store the device pointer in tfm_ctx. Add a refcnt to struct dthe_data, which atomically counts the number of requests enqueued in the crypto engine queue which reference the dthe_data object. A waitqueue waits on this atomic counter to get back to zero in dthe_remove() before doing the driver teardown. Fixes: 52f641bc63a46 ("crypto: ti - Add driver for DTHE V2 AES Engine (ECB,= CBC)") Signed-off-by: T Pratham --- drivers/crypto/ti/dthev2-aes.c | 74 +++++++++++++++++++++---------- drivers/crypto/ti/dthev2-common.c | 39 +++++++++++++--- drivers/crypto/ti/dthev2-common.h | 52 ++++++++++++++++++++-- 3 files changed, 133 insertions(+), 32 deletions(-) diff --git a/drivers/crypto/ti/dthev2-aes.c b/drivers/crypto/ti/dthev2-aes.c index 4fdd24ee91637..6a8fbe67ef6cd 100644 --- a/drivers/crypto/ti/dthev2-aes.c +++ b/drivers/crypto/ti/dthev2-aes.c @@ -110,12 +110,11 @@ enum aes_ctrl_mode_masks { static int dthe_cipher_init_tfm(struct crypto_skcipher *tfm) { struct dthe_tfm_ctx *ctx =3D crypto_skcipher_ctx(tfm); - struct dthe_data *dev_data =3D dthe_get_dev(ctx); =20 - if (!dev_data) + ctx->dev =3D dthe_get_dev(); + if (!dev) return -ENODEV; =20 - ctx->dev_data =3D dev_data; ctx->keylen =3D 0; =20 return 0; @@ -124,20 +123,19 @@ static int dthe_cipher_init_tfm(struct crypto_skciphe= r *tfm) static int dthe_cipher_init_tfm_fallback(struct crypto_skcipher *tfm) { struct dthe_tfm_ctx *ctx =3D crypto_skcipher_ctx(tfm); - struct dthe_data *dev_data =3D dthe_get_dev(ctx); const char *alg_name =3D crypto_tfm_alg_name(crypto_skcipher_tfm(tfm)); =20 - if (!dev_data) + ctx->dev =3D dthe_get_dev(); + if (!ctx->dev) return -ENODEV; =20 - ctx->dev_data =3D dev_data; ctx->keylen =3D 0; - ctx->skcipher_fb =3D crypto_alloc_sync_skcipher(alg_name, 0, CRYPTO_ALG_NEED_FALLBACK); if (IS_ERR(ctx->skcipher_fb)) { - dev_err(dev_data->dev, "fallback driver %s couldn't be loaded\n", + dev_err(ctx->dev, "fallback driver %s couldn't be loaded\n", alg_name); + dthe_put_dev(ctx->dev); return PTR_ERR(ctx->skcipher_fb); } =20 @@ -149,6 +147,7 @@ static void dthe_cipher_exit_tfm(struct crypto_skcipher= *tfm) struct dthe_tfm_ctx *ctx =3D crypto_skcipher_ctx(tfm); =20 crypto_free_sync_skcipher(ctx->skcipher_fb); + dthe_put_dev(ctx->dev); } =20 static int dthe_aes_setkey(struct crypto_skcipher *tfm, const u8 *key, uns= igned int keylen) @@ -225,7 +224,7 @@ static void dthe_aes_set_ctrl_key(struct dthe_tfm_ctx *= ctx, struct dthe_aes_req_ctx *rctx, u32 *iv_in) { - struct dthe_data *dev_data =3D dthe_get_dev(ctx); + struct dthe_data *dev_data =3D rctx->dev_data; void __iomem *aes_base_reg =3D dev_data->regs + DTHE_P_AES_BASE; u32 ctrl_val =3D 0; =20 @@ -337,8 +336,8 @@ static int dthe_aes_run(struct crypto_engine *engine, v= oid *areq) { struct skcipher_request *req =3D container_of(areq, struct skcipher_reque= st, base); struct dthe_tfm_ctx *ctx =3D crypto_skcipher_ctx(crypto_skcipher_reqtfm(r= eq)); - struct dthe_data *dev_data =3D dthe_get_dev(ctx); struct dthe_aes_req_ctx *rctx =3D skcipher_request_ctx(req); + struct dthe_data *dev_data =3D rctx->dev_data; =20 unsigned int len =3D req->cryptlen; struct scatterlist *src =3D req->src; @@ -520,14 +519,17 @@ static int dthe_aes_run(struct crypto_engine *engine,= void *areq) local_bh_disable(); crypto_finalize_skcipher_request(dev_data->engine, req, ret); local_bh_enable(); + dthe_put_drvdata(dev_data); return 0; } =20 static int dthe_aes_crypt(struct skcipher_request *req) { struct dthe_tfm_ctx *ctx =3D crypto_skcipher_ctx(crypto_skcipher_reqtfm(r= eq)); - struct dthe_data *dev_data =3D dthe_get_dev(ctx); + struct dthe_aes_req_ctx *rctx =3D skcipher_request_ctx(req); + struct dthe_data *dev_data; struct crypto_engine *engine; + int ret; =20 /* * If data is not a multiple of AES_BLOCK_SIZE: @@ -553,8 +555,18 @@ static int dthe_aes_crypt(struct skcipher_request *req) return 0; } =20 + dev_data =3D dthe_get_drvdata(ctx->dev); + if (!dev_data) + return -ENODEV; + + rctx->dev_data =3D dev_data; + engine =3D dev_data->engine; - return crypto_transfer_skcipher_request_to_engine(engine, req); + ret =3D crypto_transfer_skcipher_request_to_engine(engine, req); + if (ret !=3D -EINPROGRESS && ret !=3D -EBUSY) + dthe_put_drvdata(dev_data); + + return ret; } =20 static int dthe_aes_encrypt(struct skcipher_request *req) @@ -576,19 +588,18 @@ static int dthe_aes_decrypt(struct skcipher_request *= req) static int dthe_aead_init_tfm(struct crypto_aead *tfm) { struct dthe_tfm_ctx *ctx =3D crypto_aead_ctx(tfm); - struct dthe_data *dev_data =3D dthe_get_dev(ctx); const char *alg_name =3D crypto_tfm_alg_name(crypto_aead_tfm(tfm)); =20 - if (!dev_data) + ctx->dev =3D dthe_get_dev(); + if (!ctx->dev) return -ENODEV; =20 - ctx->dev_data =3D dev_data; - ctx->aead_fb =3D crypto_alloc_sync_aead(alg_name, 0, CRYPTO_ALG_NEED_FALLBACK); if (IS_ERR(ctx->aead_fb)) { - dev_err(dev_data->dev, "fallback driver %s couldn't be loaded\n", + dev_err(ctx->dev, "fallback driver %s couldn't be loaded\n", alg_name); + dthe_put_dev(ctx->dev); return PTR_ERR(ctx->aead_fb); } =20 @@ -600,6 +611,7 @@ static void dthe_aead_exit_tfm(struct crypto_aead *tfm) struct dthe_tfm_ctx *ctx =3D crypto_aead_ctx(tfm); =20 crypto_free_sync_aead(ctx->aead_fb); + dthe_put_dev(ctx->dev); } =20 /** @@ -711,9 +723,9 @@ static struct scatterlist *dthe_aead_prep_crypt(struct = scatterlist *sg, return crypt_sg; } =20 -static int dthe_aead_read_tag(struct dthe_tfm_ctx *ctx, u32 *tag) +static int dthe_aead_read_tag(struct dthe_aes_req_ctx *rctx, u32 *tag) { - struct dthe_data *dev_data =3D dthe_get_dev(ctx); + struct dthe_data *dev_data =3D rctx->dev_data; void __iomem *aes_base_reg =3D dev_data->regs + DTHE_P_AES_BASE; u32 val; int ret; @@ -734,11 +746,12 @@ static int dthe_aead_read_tag(struct dthe_tfm_ctx *ct= x, u32 *tag) static int dthe_aead_enc_get_tag(struct aead_request *req) { struct dthe_tfm_ctx *ctx =3D crypto_aead_ctx(crypto_aead_reqtfm(req)); + struct dthe_aes_req_ctx *rctx =3D aead_request_ctx(req); u32 tag[AES_BLOCK_WORDS]; int nents; int ret; =20 - ret =3D dthe_aead_read_tag(ctx, tag); + ret =3D dthe_aead_read_tag(rctx, tag); if (ret) return ret; =20 @@ -753,12 +766,13 @@ static int dthe_aead_enc_get_tag(struct aead_request = *req) static int dthe_aead_dec_verify_tag(struct aead_request *req) { struct dthe_tfm_ctx *ctx =3D crypto_aead_ctx(crypto_aead_reqtfm(req)); + struct dthe_aes_req_ctx *rctx =3D aead_request_ctx(req); u32 tag_out[AES_BLOCK_WORDS]; u32 tag_in[AES_BLOCK_WORDS]; int nents; int ret; =20 - ret =3D dthe_aead_read_tag(ctx, tag_out); + ret =3D dthe_aead_read_tag(rctx, tag_out); if (ret) return ret; =20 @@ -859,7 +873,7 @@ static int dthe_aead_run(struct crypto_engine *engine, = void *areq) struct aead_request *req =3D container_of(areq, struct aead_request, base= ); struct dthe_tfm_ctx *ctx =3D crypto_aead_ctx(crypto_aead_reqtfm(req)); struct dthe_aes_req_ctx *rctx =3D aead_request_ctx(req); - struct dthe_data *dev_data =3D dthe_get_dev(ctx); + struct dthe_data *dev_data =3D rctx->dev_data; =20 unsigned int cryptlen =3D req->cryptlen; unsigned int assoclen =3D req->assoclen; @@ -1130,6 +1144,7 @@ static int dthe_aead_run(struct crypto_engine *engine= , void *areq) local_bh_disable(); crypto_finalize_aead_request(engine, req, ret); local_bh_enable(); + dthe_put_drvdata(dev_data); return 0; } =20 @@ -1137,10 +1152,11 @@ static int dthe_aead_crypt(struct aead_request *req) { struct dthe_tfm_ctx *ctx =3D crypto_aead_ctx(crypto_aead_reqtfm(req)); struct dthe_aes_req_ctx *rctx =3D aead_request_ctx(req); - struct dthe_data *dev_data =3D dthe_get_dev(ctx); + struct dthe_data *dev_data; struct crypto_engine *engine; unsigned int cryptlen =3D req->cryptlen; bool is_zero_ctr =3D true; + int ret; =20 /* In decryption, last authsize bytes are the TAG */ if (!rctx->enc) @@ -1191,8 +1207,18 @@ static int dthe_aead_crypt(struct aead_request *req) (ctx->aes_mode =3D=3D DTHE_AES_CCM && !is_zero_ctr)) return dthe_aead_do_fallback(req); =20 + dev_data =3D dthe_get_drvdata(ctx->dev); + if (!dev_data) + return -ENODEV; + + rctx->dev_data =3D dev_data; + engine =3D dev_data->engine; - return crypto_transfer_aead_request_to_engine(engine, req); + ret =3D crypto_transfer_aead_request_to_engine(engine, req); + if (ret !=3D -EINPROGRESS && ret !=3D -EBUSY) + dthe_put_drvdata(dev_data); + + return ret; } =20 static int dthe_aead_encrypt(struct aead_request *req) diff --git a/drivers/crypto/ti/dthev2-common.c b/drivers/crypto/ti/dthev2-c= ommon.c index 8628187a32e18..6b88ad72c48d9 100644 --- a/drivers/crypto/ti/dthev2-common.c +++ b/drivers/crypto/ti/dthev2-common.c @@ -32,22 +32,44 @@ static struct dthe_list dthe_dev_list =3D { .lock =3D __SPIN_LOCK_UNLOCKED(dthe_dev_list.lock), }; =20 -struct dthe_data *dthe_get_dev(struct dthe_tfm_ctx *ctx) +struct device *dthe_get_dev(void) { struct dthe_data *dev_data; - - if (ctx->dev_data) - return ctx->dev_data; + struct device *dev =3D NULL; =20 spin_lock(&dthe_dev_list.lock); dev_data =3D list_first_entry_or_null(&dthe_dev_list.dev_list, struct dth= e_data, list); - if (dev_data) + if (dev_data) { list_move_tail(&dev_data->list, &dthe_dev_list.dev_list); + dev =3D get_device(dev_data->dev); + } spin_unlock(&dthe_dev_list.lock); =20 + return dev; +} + +void dthe_put_dev(struct device *dev) +{ + put_device(dev); +} + +struct dthe_data *dthe_get_drvdata(struct device *dev) +{ + struct dthe_data *dev_data; + + dev_data =3D dev_get_drvdata(dev); + if (dev_data) + atomic_inc(&dev_data->req_refcnt); + return dev_data; } =20 +void dthe_put_drvdata(struct dthe_data *dev_data) +{ + if (atomic_dec_and_test(&dev_data->req_refcnt)) + wake_up(&dev_data->drain_wq); +} + struct scatterlist *dthe_copy_sg(struct scatterlist *dst, struct scatterlist *src, unsigned int buflen) @@ -153,6 +175,9 @@ static int dthe_probe(struct platform_device *pdev) if (IS_ERR(dev_data->regs)) return PTR_ERR(dev_data->regs); =20 + atomic_set(&dev_data->req_refcnt, 0); + init_waitqueue_head(&dev_data->drain_wq); + platform_set_drvdata(pdev, dev_data); =20 spin_lock(&dthe_dev_list.lock); @@ -207,6 +232,10 @@ static void dthe_remove(struct platform_device *pdev) =20 dthe_unregister_algs(); =20 + wait_event(dev_data->drain_wq, !atomic_read(&dev_data->req_refcnt)); + + platform_set_drvdata(pdev, NULL); + crypto_engine_exit(dev_data->engine); =20 dma_release_channel(dev_data->dma_aes_rx); diff --git a/drivers/crypto/ti/dthev2-common.h b/drivers/crypto/ti/dthev2-c= ommon.h index 75d9a097650da..a827817e8119a 100644 --- a/drivers/crypto/ti/dthev2-common.h +++ b/drivers/crypto/ti/dthev2-common.h @@ -18,12 +18,14 @@ #include #include =20 +#include #include #include #include #include #include #include +#include =20 #define DTHE_REG_SIZE 4 #define DTHE_DMA_TIMEOUT_MS 2000 @@ -53,6 +55,8 @@ enum dthe_aes_mode { * @dma_aes_rx: AES Rx DMA Channel * @dma_aes_tx: AES Tx DMA Channel * @dma_sha_tx: SHA Tx DMA Channel + * @req_refcnt: Count of requests currently using this instance. + * @drain_wq: Waited on by dthe_remove() until @req_refcnt reaches zero. */ struct dthe_data { struct device *dev; @@ -64,6 +68,9 @@ struct dthe_data { struct dma_chan *dma_aes_tx; =20 struct dma_chan *dma_sha_tx; + + atomic_t req_refcnt; + wait_queue_head_t drain_wq; }; =20 /** @@ -78,7 +85,7 @@ struct dthe_list { =20 /** * struct dthe_tfm_ctx - Transform ctx struct containing ctx for all sub-c= omponents of DTHE V2 - * @dev_data: Device data struct pointer + * @dev: Device this transform is bound to. * @keylen: AES key length * @authsize: Authentication size for modes with authentication * @key: AES key @@ -87,7 +94,7 @@ struct dthe_list { * @skcipher_fb: Fallback crypto skcipher handle for AES-XTS mode */ struct dthe_tfm_ctx { - struct dthe_data *dev_data; + struct device *dev; unsigned int keylen; unsigned int authsize; u32 key[DTHE_MAX_KEYSIZE / sizeof(u32)]; @@ -103,16 +110,55 @@ struct dthe_tfm_ctx { * @enc: flag indicating encryption or decryption operation * @padding: padding buffer for handling unaligned data * @aes_compl: Completion variable for use in manual completion in case of= DMA callback failure + * @dev_data: Device data struct pointer */ struct dthe_aes_req_ctx { int enc; u8 padding[2 * AES_BLOCK_SIZE]; struct completion aes_compl; + struct dthe_data *dev_data; }; =20 /* Struct definitions end */ =20 -struct dthe_data *dthe_get_dev(struct dthe_tfm_ctx *ctx); +/** + * dthe_get_dev - Get the device pointer after increasing its reference co= unt + * + * Description: + * Picks a device instance and gets the associated device pointer throu= gh get_device() + * to maintain its reference count by the kernel itself. Callers must e= nsure to call + * dthe_put_dev() at exit to decrease the refcnt. + */ +struct device *dthe_get_dev(void); + +/** + * dthe_put_dev - Decrease the reference count of the device + * @dev: Device pointer to be released + * + * Description: + * Decreases the reference count of the device pointer obtained through= dthe_get_dev() + * by calling put_device(). + */ +void dthe_put_dev(struct device *dev); + +/** + * dthe_get_drvdata - Get a reference counted device driver data pointer + * @dev: Device pointer + * + * Description: + * Returns the instance's driver data if it is still bound, with @req_r= efcnt + * incremented, or NULL if it has been removed. Every req accepted for + * processing must call this and balance it with exactly one + * dthe_put_drvdata() when done. + */ +struct dthe_data *dthe_get_drvdata(struct device *dev); + +/** + * dthe_put_drvdata - Decrease the refcnt of the device driver data acquir= ed through + * dthe_get_drvdata() + * @dev_data: Driver data previously returned by dthe_get_drvdata() + */ +void dthe_put_drvdata(struct dthe_data *dev_data); =20 /** * dthe_copy_sg - Copy sg entries from src to dst --=20 2.34.1 From nobody Fri Sep 25 16:51:46 2026 Received: from mx0a-0002e601.pphosted.com (mx0a-0002e601.pphosted.com [148.163.150.75]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 02EF445A294; Thu, 10 Sep 2026 10:43:14 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=fail smtp.client-ip=148.163.150.75 ARC-Seal: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1789036998; cv=fail; b=Ytsi74wJDrfpJSBQD7J4/nK+cKqHGzbtvyFvH7X2jRCnuZO9se4GTjKjpGLqktd86b5gFBKIJ86K8z/4HcxfQX5JFfldLtcjZcLWQ1PmK7uFh+wgxloWu7TkqnnTFsEKXGOY/jijDKbNK0YtlUm4bGy+YpQ+tasWLhLItCd0cj8= ARC-Message-Signature: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1789036998; c=relaxed/simple; bh=14+lpbbjuBYbleZZptnnErmVsbsXKn0WAKM8jdF9Cmo=; h=From:To:CC:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=CHMm0wf2Ubpw7fVznu/frTiUDXghoUJGMo9Nk863Ah9JB4JlkSGUBTbH+tWkClmJt9w6wyMpe27FadDEspFvHz8CXY9ZCHw1wKnb+aXo455HJYLBr4gKAqCKN9nON5+7YrrJwhmUPwdwbE4fgc+JzVSEngfx5loUOXTZVyoijUE= ARC-Authentication-Results: i=2; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=ti.com; spf=pass smtp.mailfrom=ti.com; dkim=pass (2048-bit key) header.d=ti.com header.i=@ti.com header.b=a2fTomyW; dkim=pass (1024-bit key) header.d=ti.com header.i=@ti.com header.b=RSsU3BD5; arc=fail smtp.client-ip=148.163.150.75 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=ti.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=ti.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=ti.com header.i=@ti.com header.b="a2fTomyW"; dkim=pass (1024-bit key) header.d=ti.com header.i=@ti.com header.b="RSsU3BD5" Received: from pps.filterd (m0384305.ppops.net [127.0.0.1]) by m0384305.ppops.net (8.18.1.11/8.18.1.11) with ESMTP id 68A8oHSb712625; Thu, 10 Sep 2026 05:43:12 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ti.com; h=cc :content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s= proofpoint-05-2026; bh=WCBqois36VGrEk3wC02QqgtiaiTky+9IMvxqB6ixU u4=; b=a2fTomyW7GIisOCByiw+W389SUVjXMtxOG6ayWKy3ZueWkqZw9Cx9rgmF wV6urY8INellgxWwYVZOMj6ERknTGJo0/r8rfWBxC6kJjy4y6TM2vGs9m4C5DtuD 3DOTK4Uuh0BvVoeE31ZQ+FcODz17ww/pj2ZcAYqrD/eN3d6G4AFzVIO1GNsFv+gD ECKNs9/ZzaimmtaBG4cEbq1XWAygudxcUNsM5ECx5u6r42NCk1azIaGVx7xeBYBj bsxZLDX0J4ammMnPODTf4OYogJGC2gKYbFGvjUQgeR5hN+3F3w3jU8gFFDszRuqv Me4mNeMCQfvC1SjJSJpCWKmP/y6Iw== Received: from ph0pr06cu001.outbound.protection.outlook.com (mail-westus3azon11011034.outbound.protection.outlook.com [40.107.208.34]) by m0384305.ppops.net (PPS) with ESMTPS id 4gkcxgcnxt-1 (version=TLSv1.3 cipher=TLS_AES_256_GCM_SHA384 bits=256 verify=NOT); Thu, 10 Sep 2026 05:43:11 -0500 (CDT) ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=ABeEarYwn4r9mS2p/KSI5OATWGFrE+SY4Rs3hdeZ81GwqDsZISaLRuGCkpTTbErs3wDyMxk8ErnDO49wfSzCi8YyUQ4Yl6EthjxAH+XRxcDEe296aAKR+0YRQaD5T5jW5BvDx5fYLdywAOx2s+jsxuiLYZdZNUfv/j9c+UG3z/xh/9EzLqnlJgznLFxoi7SXNfYr33mQihjy0WRO++Ro+xjIlsOiyqqq4hkJ+qYp+zwRa5IaSQlB6r8YWSW3qymNwd5VBcImzTg9lh6ZkKBHjArJrxYRlnyNiew5DpkeAq+bGbTdQEWsdZF3c7DcSNlQAhNLIPEbdYJ12aJUCRhokg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=WCBqois36VGrEk3wC02QqgtiaiTky+9IMvxqB6ixUu4=; b=r0/DFe7WCuF/jH/YO/8XEW4J/OstVsVqqLWOFgCy2d1k4wfXKosa606xqqGqQzTAeQHh1L7mxDgrpT2OBm6qbI4m/i1+Z7Mdyt2XBm3BiyxPXByz43fX17HZGX92BijxHI9J0pm6NulmRC0innCtnW+ALIic34dVcMqJ4opxiBRTMKZ/reExY0uMLiKkmNqc0d3GqvsMb5uHKeFj4pwB3Q2OqJ1g3ksZLnYhvbfhRIVTpNbM1XrVCYkUYIC+2MnLY7fAAZxeFenXnKi40armfVKAXuzb/zLqe65mI5jAs2MhweEShWxl7AyNoS3ziAy4Y1LQzgFMcjjzVYHZv2/KRQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 198.47.23.194) smtp.rcpttodomain=gondor.apana.org.au smtp.mailfrom=ti.com; dmarc=pass (p=quarantine sp=none pct=100) action=none header.from=ti.com; dkim=none (message not signed); arc=none (0) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ti.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=WCBqois36VGrEk3wC02QqgtiaiTky+9IMvxqB6ixUu4=; b=RSsU3BD580enQL1HFCNA9EROwFIbbFT/adO3H5qZtJzLOa8u/stdt+osS/Ck/dSakuaKQ2ftUXk4kKrU47hI4IkxxwLezIB2NR3lU9UxSCv9sE39+gZxHnxs7VKNnaoSlxDczJNQi1TLeOvh+PTXordjT5CgEPUDs+mGsPILxSs= Received: from SJ0PR03CA0158.namprd03.prod.outlook.com (2603:10b6:a03:338::13) by MN7PR10MB700146.namprd10.prod.outlook.com (2603:10b6:208:638::11) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.21.406.7; Thu, 10 Sep 2026 10:43:08 +0000 Received: from SJ5PEPF000001E8.namprd05.prod.outlook.com (2603:10b6:a03:338:cafe::55) by SJ0PR03CA0158.outlook.office365.com (2603:10b6:a03:338::13) with Microsoft SMTP Server (version=TLS1_3, cipher=TLS_AES_256_GCM_SHA384) id 15.21.382.15 via Frontend Transport; Thu, 10 Sep 2026 10:43:08 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 198.47.23.194) smtp.mailfrom=ti.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=ti.com; Received-SPF: Pass (protection.outlook.com: domain of ti.com designates 198.47.23.194 as permitted sender) receiver=protection.outlook.com; client-ip=198.47.23.194; helo=lewvzet200.ext.ti.com; pr=C Received: from lewvzet200.ext.ti.com (198.47.23.194) by SJ5PEPF000001E8.mail.protection.outlook.com (10.167.242.196) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.21.406.5 via Frontend Transport; Thu, 10 Sep 2026 10:43:07 +0000 Received: from DLEE201.ent.ti.com (157.170.170.76) by lewvzet200.ext.ti.com (10.4.14.103) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.2562.45; Thu, 10 Sep 2026 05:42:42 -0500 Received: from DLEE202.ent.ti.com (157.170.170.77) by DLEE201.ent.ti.com (157.170.170.76) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.2562.45; Thu, 10 Sep 2026 05:42:42 -0500 Received: from lelvem-mr05.itg.ti.com (10.180.75.9) by DLEE202.ent.ti.com (157.170.170.77) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.2562.45 via Frontend Transport; Thu, 10 Sep 2026 05:42:42 -0500 Received: from pratham-Workstation-PC (pratham-workstation-pc.dhcp.ti.com [10.24.53.205]) by lelvem-mr05.itg.ti.com (8.18.1/8.18.1) with ESMTP id 68AAge1O3150255; Thu, 10 Sep 2026 05:42:41 -0500 From: T Pratham To: T Pratham , Herbert Xu , "David S. Miller" CC: Sebin Francis , Manorit Chawdhry , Vishal Mahaveer , Praneeth Bajjuri , Kamlesh Gurudasani , , Subject: [PATCH v3 05/12] crypto: ti - Trim scatterlists to correct length in AES Date: Thu, 10 Sep 2026 16:11:55 +0530 Message-ID: <20260910104202.1537226-6-t-pratham@ti.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20260910104202.1537226-1-t-pratham@ti.com> References: <20260910104202.1537226-1-t-pratham@ti.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: SJ5PEPF000001E8:EE_|MN7PR10MB700146:EE_ X-MS-Office365-Filtering-Correlation-Id: 20f9e006-2a7e-492c-7e94-08df0f284d1d X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|23010399003|82310400026|1800799024|36860700016|376014|10067099003|6133799003|18002099003|22082099003|56012099006; X-Microsoft-Antispam-Message-Info: jW+8HFtgCQMYMlkVwVJYcsKOpLQcQhQ2L44WJoz6bWWj37jlWrB5TMZWHtai2WMmpvRV3wLU4sj9dlK7Cax1YIncf6cGNO4p8OrBVQUakgflZ0OPfqi38OoBwbfm3YiDIqle+jn6gxY2QeHSJVDwfgV9S00AoLF/LybpVQibLXBAW/IPXUPdJ/LethSjt5Nb2oDMaPWREtIHoY7tOemf+1OFE5eDIz79+1rZIgCBXDxSgU6DmVecrJxUlUNbjRwB59EjSmEHDPqb1Uwx4ASIPOg6PbDtw08eP8sRjDjFwc5frXlS1x9215JabcZnMWsWObzSqVUD51OWgiOy7VIz25Kj8xIgDg+nuliG78yFdGJ8p+4SHxgw7MA8uwzHFq9imLLbE1uaXx56RW8Ta2oD+R9LfoQxCqiRZsBRHtNzEvm4TR+Ooum0r60nmDdniQBMeiaEdj0aCkQ40FP+g/gQiGtbP462cKA70i68XohxQubnQzru0wiaym9aqYfiayA/qVM6nzvZ7y7JSHlrAGP9GfCqgFfRUGCNbYm/nFl3BOBDmhD/mjdgaJH3t/hl3i9ZIRNQyWEm3IaDTRIvA9W80tsHoAa6oZLT/5I9IIqtEkVH7RZ306Isy5yR2xkt8Aqje7GT1sLwz1STsaBYu+W9p6urvuNQmh1BwLahO/NA2RzYBP4dJYoYp4Dp3O1NOSp/j0Ax6Mq3G0CTPuNfvkWeTA== X-Forefront-Antispam-Report: CIP:198.47.23.194;CTRY:US;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:lewvzet200.ext.ti.com;PTR:InfoDomainNonexistent;CAT:NONE;SFS:(13230040)(23010399003)(82310400026)(1800799024)(36860700016)(376014)(10067099003)(6133799003)(18002099003)(22082099003)(56012099006);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: H3FMXX4OaNhR9InLlEG0aDNDw3KP0wPIkkFW2Y7fZULbJGDmdOXgg+bREHtV/WQ71ZsANG92uFHkgdATML+I7gypDNNB+mQ2L4lNlQHTudCtx749kUktP5dp3iXpQcQ1ekQtqoTBkqcNBaSf96d07sOEL/cAlNgo5Td8VJBG/JVYECOfOWNgp2zmRoW0V5IyldqSmKuozbWVpJ3nbkRtZRGIPWMzFUS2gf16rKmOZhUk4LFWmYXpXjk6m1g0PYfYZ7rYVKoGIH9VofPQ7wPIOwzSibd5A4JNSL1khpoHW0pYjSlfuYmme83ga2En3ShCOLB+EGSuJ6qzWXx/f1orodp08W5Kk887U7HO/GVw6eUnetpwknzpcpFHPtQ1WdnRoad91vzoHWGoxrdKonBQkGk5CevJOUo+XgRXEPC2yPtfIQqzldLFmroYj4ZAW0Ra X-Exchange-RoutingPolicyChecked: JAvIaC1G1RM/NZg6ZU9jdAYZVR/Dx0vO10Kgr6jFRJHhA4d4/fqDVkFThMR70DMbXdu2vrWYa8m+/AXMpFqJp6MsYtYNUrGlC0YaE4EoVcc/4pYautf23Ut4+tikWA1tGRvj/1y4V05Gnp9/Ob5b73LGtZvRcx7rLi5dWLNn5H6XbCVaVKoI8FMu0le6ReOUCHrBp6+NUT+EEqXLqsknBNihV/T49HgQySHjA83h6zphYJh6Aru9Y24Egxjl5sXoBfggRGyKJr8n+6uRfOXuEx7ngghR0/jOuWvRY7/tNfbX3AeDNch6UC4XDtpJzPFZCFCAhRkPGnVr8XKRKIP4/Q== X-OriginatorOrg: ti.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 10 Sep 2026 10:43:07.5362 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 20f9e006-2a7e-492c-7e94-08df0f284d1d X-MS-Exchange-CrossTenant-Id: e5b49634-450b-4709-8abb-1e2b19b982b7 X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=e5b49634-450b-4709-8abb-1e2b19b982b7;Ip=[198.47.23.194];Helo=[lewvzet200.ext.ti.com] X-MS-Exchange-CrossTenant-AuthSource: SJ5PEPF000001E8.namprd05.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: MN7PR10MB700146 X-Proofpoint-ORIG-GUID: SKYTd8Xy80s8Fejh4S5pVOETWzTKczem X-Proofpoint-Spam-Info: AW1haW4tMjYwOTEwMDEyNCBTYWx0ZWRfX8dbPntVR5/bO bgYv6+QiU9ZacG30nxw3HcBF3XULl+b4qA02XYcWUcUY0jusfbGoMXGEhwJ4gCR98FcNybBlymd YLTXccAGM4+qoJplFwntVzN9EsYZPRA= X-Proofpoint-GUID: SKYTd8Xy80s8Fejh4S5pVOETWzTKczem X-Authority-Analysis: v=2.4 cv=MqbHeGae c=1 sm=1 tr=0 ts=6aa289bf cx=c_pps a=zZIwMYV7Wou7+0JapvgM9A==:117 a=WotqVVQAdb04rnGuttW3Kw==:17 a=6eWqkTHjU83fiwn7nKZWdM+Sl24=:19 a=VdqzKS8jKosA:10 a=s63m1ICgrNkA:10 a=V5UXEbMT0ywA:10 a=VkNPw1HP01LnGYTKEx00:22 a=Z8NIEmU8O1QQgoT56wFK:22 a=taLDd7a_hP9WKsMzeGRc:22 a=sozttTNsAAAA:8 a=Tpn98H0sjD_mw3BxSIoA:9 X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwOTEwMDEyNCBTYWx0ZWRfXwk9jqIyJCqZS JfTh9wnZan9dKPHgYV9Me/pX+o9LtLRFOtPq2PD3gb/98tbmLYkYGCBvQqZ/9o9ogyussmUobiM D50/kFt/0ELNGSHOWowPO2iDqapxUvMoyBRhTaLOMc0+/4HsthZEzMLHvAJyHVBLVO/eqRW416j akFI+JPAtu8zs1UkM5ecDtS/P46vxMDKQNgUDFyqwR+XBEk6zwT1+IXKSFsfLPVur4X57QmECSd 5wos26eajvKq4lrrXNQ/aNWicgGOCshis7XDKfhnSiWNgYYFjhfDMfGnXDJAOyRf/Vpng+/JfUD tRQAthQTn1Fpprhbzk065l6JJYZFELSPytNiXuZxrPoFIHLzs/CQf6YUsJcWKXmei0iG4a68ikL fivOmG33UgAkJ2ukRq2v8HP6zIBFpX3EcD8U4FrkmvR3xwb9j37sUclK9F6N57+KyUMik8/g9Ed M8aQ1w/rk+ReXDOUHoA== X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1176,Hydra:6.1.134,FMLib:17.12.100.49 definitions=2026-09-10_03,2026-09-09_02,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 clxscore=1015 impostorscore=0 phishscore=0 lowpriorityscore=0 priorityscore=1501 spamscore=0 bulkscore=0 adultscore=0 suspectscore=0 malwarescore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2609040000 definitions=main-2609100124 Content-Type: text/plain; charset="utf-8" AES functions were using src and dst scatterlists directly provided by the request. This is problematic as it is not guaranteed that the input scatterlist is exactly the length reqired. This problem was seen in IPSec use case when the kernel provides the scatterlist which contains space for plaintext/ciphertext and TAG. The problem comes when the scatterlist is mapped and sent via DMA. The K3 UDMA sends/waits for the amount of data equal to the length of scatterlist mapped. So when the last mapped nent contains some extra length, the DMA keeps waiting for the extra data and eventually times out and crashes. Mitigate this by copying the nents to a local scatterlist, copying only exactly cryptlen of data. Note that this does not copy the whole data, but rather only the scatterlist mapping. So it is not as penalising on performance. Fixes: 52f641bc63a4 ("crypto: ti - Add driver for DTHE V2 AES Engine (ECB, = CBC)") Signed-off-by: T Pratham Reviewed-by: Kamlesh Gurudasani --- drivers/crypto/ti/dthev2-aes.c | 145 ++++++++++++++++----------------- 1 file changed, 69 insertions(+), 76 deletions(-) diff --git a/drivers/crypto/ti/dthev2-aes.c b/drivers/crypto/ti/dthev2-aes.c index 6a8fbe67ef6cd..be7ec62ab2513 100644 --- a/drivers/crypto/ti/dthev2-aes.c +++ b/drivers/crypto/ti/dthev2-aes.c @@ -108,19 +108,6 @@ enum aes_ctrl_mode_masks { #define POLL_TIMEOUT_INTERVAL HZ =20 static int dthe_cipher_init_tfm(struct crypto_skcipher *tfm) -{ - struct dthe_tfm_ctx *ctx =3D crypto_skcipher_ctx(tfm); - - ctx->dev =3D dthe_get_dev(); - if (!dev) - return -ENODEV; - - ctx->keylen =3D 0; - - return 0; -} - -static int dthe_cipher_init_tfm_fallback(struct crypto_skcipher *tfm) { struct dthe_tfm_ctx *ctx =3D crypto_skcipher_ctx(tfm); const char *alg_name =3D crypto_tfm_alg_name(crypto_skcipher_tfm(tfm)); @@ -154,19 +141,24 @@ static int dthe_aes_setkey(struct crypto_skcipher *tf= m, const u8 *key, unsigned { struct dthe_tfm_ctx *ctx =3D crypto_skcipher_ctx(tfm); =20 - if (keylen !=3D AES_KEYSIZE_128 && keylen !=3D AES_KEYSIZE_192 && keylen = !=3D AES_KEYSIZE_256) - return -EINVAL; - ctx->keylen =3D keylen; memcpy(ctx->key, key, keylen); =20 - return 0; + crypto_sync_skcipher_clear_flags(ctx->skcipher_fb, CRYPTO_TFM_REQ_MASK); + crypto_sync_skcipher_set_flags(ctx->skcipher_fb, + crypto_skcipher_get_flags(tfm) & + CRYPTO_TFM_REQ_MASK); + + return crypto_sync_skcipher_setkey(ctx->skcipher_fb, key, keylen); } =20 static int dthe_aes_ecb_setkey(struct crypto_skcipher *tfm, const u8 *key,= unsigned int keylen) { struct dthe_tfm_ctx *ctx =3D crypto_skcipher_ctx(tfm); =20 + if (keylen !=3D AES_KEYSIZE_128 && keylen !=3D AES_KEYSIZE_192 && keylen = !=3D AES_KEYSIZE_256) + return -EINVAL; + ctx->aes_mode =3D DTHE_AES_ECB; =20 return dthe_aes_setkey(tfm, key, keylen); @@ -176,6 +168,9 @@ static int dthe_aes_cbc_setkey(struct crypto_skcipher *= tfm, const u8 *key, unsig { struct dthe_tfm_ctx *ctx =3D crypto_skcipher_ctx(tfm); =20 + if (keylen !=3D AES_KEYSIZE_128 && keylen !=3D AES_KEYSIZE_192 && keylen = !=3D AES_KEYSIZE_256) + return -EINVAL; + ctx->aes_mode =3D DTHE_AES_CBC; =20 return dthe_aes_setkey(tfm, key, keylen); @@ -184,24 +179,19 @@ static int dthe_aes_cbc_setkey(struct crypto_skcipher= *tfm, const u8 *key, unsig static int dthe_aes_ctr_setkey(struct crypto_skcipher *tfm, const u8 *key,= unsigned int keylen) { struct dthe_tfm_ctx *ctx =3D crypto_skcipher_ctx(tfm); - int ret =3D dthe_aes_setkey(tfm, key, keylen); =20 - if (ret) - return ret; + if (keylen !=3D AES_KEYSIZE_128 && keylen !=3D AES_KEYSIZE_192 && keylen = !=3D AES_KEYSIZE_256) + return -EINVAL; =20 ctx->aes_mode =3D DTHE_AES_CTR; =20 - crypto_sync_skcipher_clear_flags(ctx->skcipher_fb, CRYPTO_TFM_REQ_MASK); - crypto_sync_skcipher_set_flags(ctx->skcipher_fb, - crypto_skcipher_get_flags(tfm) & - CRYPTO_TFM_REQ_MASK); - - return crypto_sync_skcipher_setkey(ctx->skcipher_fb, key, keylen); + return dthe_aes_setkey(tfm, key, keylen); } =20 static int dthe_aes_xts_setkey(struct crypto_skcipher *tfm, const u8 *key,= unsigned int keylen) { struct dthe_tfm_ctx *ctx =3D crypto_skcipher_ctx(tfm); + int ret; =20 if (keylen !=3D 2 * AES_KEYSIZE_128 && keylen !=3D 2 * AES_KEYSIZE_192 && @@ -209,15 +199,12 @@ static int dthe_aes_xts_setkey(struct crypto_skcipher= *tfm, const u8 *key, unsig return -EINVAL; =20 ctx->aes_mode =3D DTHE_AES_XTS; - ctx->keylen =3D keylen / 2; - memcpy(ctx->key, key, keylen); - - crypto_sync_skcipher_clear_flags(ctx->skcipher_fb, CRYPTO_TFM_REQ_MASK); - crypto_sync_skcipher_set_flags(ctx->skcipher_fb, - crypto_skcipher_get_flags(tfm) & - CRYPTO_TFM_REQ_MASK); + ret =3D dthe_aes_setkey(tfm, key, keylen); + if (ret) + return ret; =20 - return crypto_sync_skcipher_setkey(ctx->skcipher_fb, key, keylen); + ctx->keylen =3D keylen / 2; + return 0; } =20 static void dthe_aes_set_ctrl_key(struct dthe_tfm_ctx *ctx, @@ -340,8 +327,10 @@ static int dthe_aes_run(struct crypto_engine *engine, = void *areq) struct dthe_data *dev_data =3D rctx->dev_data; =20 unsigned int len =3D req->cryptlen; + unsigned int pad_len =3D 0; struct scatterlist *src =3D req->src; struct scatterlist *dst =3D req->dst; + struct scatterlist *sg; =20 int src_nents =3D sg_nents_for_len(src, len); int dst_nents =3D sg_nents_for_len(dst, len); @@ -384,38 +373,38 @@ static int dthe_aes_run(struct crypto_engine *engine,= void *areq) * We need to handle the padding in the driver. */ if (ctx->aes_mode =3D=3D DTHE_AES_CTR && req->cryptlen % AES_BLOCK_SIZE) { - unsigned int pad_size =3D AES_BLOCK_SIZE - (req->cryptlen % AES_BLOCK_SI= ZE); - u8 *pad_buf =3D rctx->padding; - struct scatterlist *sg; - - len +=3D pad_size; + pad_len =3D AES_BLOCK_SIZE - (req->cryptlen % AES_BLOCK_SIZE); + len +=3D pad_len; src_nents++; dst_nents++; + } =20 - src =3D kmalloc_array(src_nents, sizeof(*src), GFP_ATOMIC); - if (!src) { - ret =3D -ENOMEM; - goto aes_ctr_src_alloc_err; - } - - sg_init_table(src, src_nents); - sg =3D dthe_copy_sg(src, req->src, req->cryptlen); - memzero_explicit(pad_buf, AES_BLOCK_SIZE); - sg_set_buf(sg, pad_buf, pad_size); + src =3D kmalloc_array(src_nents, sizeof(*src), GFP_ATOMIC); + if (!src) { + ret =3D -ENOMEM; + goto aes_src_alloc_err; + } =20 - if (diff_dst) { - dst =3D kmalloc_array(dst_nents, sizeof(*dst), GFP_ATOMIC); - if (!dst) { - ret =3D -ENOMEM; - goto aes_ctr_dst_alloc_err; - } + sg_init_table(src, src_nents); + sg =3D dthe_copy_sg(src, req->src, req->cryptlen); + if (pad_len > 0) { + memzero_explicit(rctx->padding, AES_BLOCK_SIZE); + sg_set_buf(sg, rctx->padding, pad_len); + } =20 - sg_init_table(dst, dst_nents); - sg =3D dthe_copy_sg(dst, req->dst, req->cryptlen); - sg_set_buf(sg, pad_buf, pad_size); - } else { - dst =3D src; + if (diff_dst) { + dst =3D kmalloc_array(dst_nents, sizeof(*dst), GFP_ATOMIC); + if (!dst) { + ret =3D -ENOMEM; + goto aes_dst_alloc_err; } + + sg_init_table(dst, dst_nents); + sg =3D dthe_copy_sg(dst, req->dst, req->cryptlen); + if (pad_len > 0) + sg_set_buf(sg, rctx->padding, pad_len); + } else { + dst =3D src; } =20 tx_dev =3D dmaengine_get_dma_device(dev_data->dma_aes_tx); @@ -502,19 +491,19 @@ static int dthe_aes_run(struct crypto_engine *engine,= void *areq) dma_unmap_sg(tx_dev, src, src_nents, src_dir); =20 aes_map_src_err: - if (ctx->aes_mode =3D=3D DTHE_AES_CTR && req->cryptlen % AES_BLOCK_SIZE) { + if (ctx->aes_mode =3D=3D DTHE_AES_CTR && req->cryptlen % AES_BLOCK_SIZE) memzero_explicit(rctx->padding, AES_BLOCK_SIZE); - if (diff_dst) - kfree(dst); -aes_ctr_dst_alloc_err: - kfree(src); -aes_ctr_src_alloc_err: - /* - * Fallback to software if ENOMEM - */ - if (ret =3D=3D -ENOMEM) - ret =3D dthe_aes_do_fallback(req); - } + if (diff_dst) + kfree(dst); + +aes_dst_alloc_err: + kfree(src); +aes_src_alloc_err: + /* + * Fallback to software if ENOMEM + */ + if (ret =3D=3D -ENOMEM) + ret =3D dthe_aes_do_fallback(req); =20 local_bh_disable(); crypto_finalize_skcipher_request(dev_data->engine, req, ret); @@ -1240,6 +1229,7 @@ static int dthe_aead_decrypt(struct aead_request *req) static struct skcipher_engine_alg cipher_algs[] =3D { { .base.init =3D dthe_cipher_init_tfm, + .base.exit =3D dthe_cipher_exit_tfm, .base.setkey =3D dthe_aes_ecb_setkey, .base.encrypt =3D dthe_aes_encrypt, .base.decrypt =3D dthe_aes_decrypt, @@ -1251,7 +1241,8 @@ static struct skcipher_engine_alg cipher_algs[] =3D { .cra_priority =3D 299, .cra_flags =3D CRYPTO_ALG_TYPE_SKCIPHER | CRYPTO_ALG_ASYNC | - CRYPTO_ALG_KERN_DRIVER_ONLY, + CRYPTO_ALG_KERN_DRIVER_ONLY | + CRYPTO_ALG_NEED_FALLBACK, .cra_alignmask =3D AES_BLOCK_SIZE - 1, .cra_blocksize =3D AES_BLOCK_SIZE, .cra_ctxsize =3D sizeof(struct dthe_tfm_ctx), @@ -1262,6 +1253,7 @@ static struct skcipher_engine_alg cipher_algs[] =3D { }, /* ECB AES */ { .base.init =3D dthe_cipher_init_tfm, + .base.exit =3D dthe_cipher_exit_tfm, .base.setkey =3D dthe_aes_cbc_setkey, .base.encrypt =3D dthe_aes_encrypt, .base.decrypt =3D dthe_aes_decrypt, @@ -1274,7 +1266,8 @@ static struct skcipher_engine_alg cipher_algs[] =3D { .cra_priority =3D 299, .cra_flags =3D CRYPTO_ALG_TYPE_SKCIPHER | CRYPTO_ALG_ASYNC | - CRYPTO_ALG_KERN_DRIVER_ONLY, + CRYPTO_ALG_KERN_DRIVER_ONLY | + CRYPTO_ALG_NEED_FALLBACK, .cra_alignmask =3D AES_BLOCK_SIZE - 1, .cra_blocksize =3D AES_BLOCK_SIZE, .cra_ctxsize =3D sizeof(struct dthe_tfm_ctx), @@ -1284,7 +1277,7 @@ static struct skcipher_engine_alg cipher_algs[] =3D { .op.do_one_request =3D dthe_aes_run, }, /* CBC AES */ { - .base.init =3D dthe_cipher_init_tfm_fallback, + .base.init =3D dthe_cipher_init_tfm, .base.exit =3D dthe_cipher_exit_tfm, .base.setkey =3D dthe_aes_ctr_setkey, .base.encrypt =3D dthe_aes_encrypt, @@ -1309,7 +1302,7 @@ static struct skcipher_engine_alg cipher_algs[] =3D { .op.do_one_request =3D dthe_aes_run, }, /* CTR AES */ { - .base.init =3D dthe_cipher_init_tfm_fallback, + .base.init =3D dthe_cipher_init_tfm, .base.exit =3D dthe_cipher_exit_tfm, .base.setkey =3D dthe_aes_xts_setkey, .base.encrypt =3D dthe_aes_encrypt, --=20 2.34.1 From nobody Fri Sep 25 16:51:46 2026 Received: from mx0a-0002e601.pphosted.com (mx0a-0002e601.pphosted.com [148.163.150.75]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 04D6B3DAAD5; Thu, 10 Sep 2026 10:43:23 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=fail smtp.client-ip=148.163.150.75 ARC-Seal: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1789037007; cv=fail; b=ZPDkcQSINWX0xpKtITWOJ9YCJWslj5eGMTrW5U1IdE3YFtbi5w6Ku+NC9r6WGjfEqaMexfOT/JQZKKUD0qKWFan6FIHffzNgNkBpdx1EHPMvrocig1XrBBsHCQFSt1k95eKa79rNJEL/H62NokeSQQZLPqbEdoutrthI9eU10oA= ARC-Message-Signature: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1789037007; c=relaxed/simple; bh=xb+vL0JDbiPKN7Wt2F5InRrdoz1YYUcDoCoOu4uU4Hg=; h=From:To:CC:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=AeJcQT1ZqsZ5E0OB4uw4taa1NaHEOHrRPMhnVjHYf9nIq7DVy4q0MQMhuJoHJygyBPtrabAZ2w7xpFAjuKGGKvhbC7IS3L3tX/2fcuHmzumihLiKVoN2sZw0sb48jslRdZ+HP993iPXfZQ7Kg0H/r6S/QVU9SrO7qqZQfCXZmFg= ARC-Authentication-Results: i=2; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=ti.com; spf=pass smtp.mailfrom=ti.com; dkim=pass (2048-bit key) header.d=ti.com header.i=@ti.com header.b=TKYyykG6; dkim=pass (1024-bit key) header.d=ti.com header.i=@ti.com header.b=LbHMWyVm; arc=fail smtp.client-ip=148.163.150.75 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=ti.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=ti.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=ti.com header.i=@ti.com header.b="TKYyykG6"; dkim=pass (1024-bit key) header.d=ti.com header.i=@ti.com header.b="LbHMWyVm" Received: from pps.filterd (m0384305.ppops.net [127.0.0.1]) by m0384305.ppops.net (8.18.1.11/8.18.1.11) with ESMTP id 68A8oHTO712620; Thu, 10 Sep 2026 05:43:18 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ti.com; h=cc :content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s= proofpoint-05-2026; bh=9AAog4xG5I3fqrRUyrRYVntKwYPVthg9NlLstka6J 8o=; b=TKYyykG6a1PoHFTM9AlcaEWXUmG32llKndz+uJLFjeraZrst7oonghicq 74eTmbVcBr+gYwNn6hWcgWYXDpIWRKa7ucrFKKV2cRffbWk6W6bbESP1QsScGDJZ 2k80k5unwsZk1cSYQ6ijSCDzY8ff52wGubTf9ndnJPhOjaxouHet9n1vjbCB9Lsl NQf+qmFzWuSYLtFLNGzBMZjro+tZRz82Sac7fJcy22dR1ZrpopS6Fq8r8uGCDgxH fvzFwM9Ap2osWzxQ0HFmhgSgUaq2KxX9xfB3hqwF08/mwtPj0o7FYR0QbdQ94pl6 uz0mYc/boOe5lTC/MP2tUi8iNKfNQ== Received: from sa9pr02cu001.outbound.protection.outlook.com (mail-southcentralusazon11013037.outbound.protection.outlook.com [40.93.196.37]) by m0384305.ppops.net (PPS) with ESMTPS id 4gkcxgcny7-1 (version=TLSv1.3 cipher=TLS_AES_256_GCM_SHA384 bits=256 verify=NOT); Thu, 10 Sep 2026 05:43:18 -0500 (CDT) ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=i7E9g5WeHgp4ifH4+Sp4uWpqpmw8QUTgIzcTdnBGT83RDPafP1F9si1CzmewSFMlfoOJ8AexvpyBIsUX4w8Q0D/yLaLTYugkB0rJAmivrjSrnnQqpq26F7blQXZ+Yu4KbgBQYwMK7enGc8jJsOpPGwX5xFjOCDRu/LGwiNgZa2fvATSYjS0Cb9fRfqR5X09vHA8t69HYPDIrRc5IC+De3DblGYbyePlX25GYLCSjwuSP33cimhrL5he6Z3tdLlLL8bYbt13VzPusspXK/04+mwxV5CmeLUruYXQiSQkdXV4vcqIBSOuaE0O1ou/SE7u+5DkgRjjjrU/Bp465ennFCA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=9AAog4xG5I3fqrRUyrRYVntKwYPVthg9NlLstka6J8o=; b=bRoCtc17tRG4lK0PZt24HOC6o3BG/pkAcfNaoI80WuhDwFjoI7nGCQNWxmWM7a3Nm4fNjsD2bzgscaMfW0oYL+y2/bjXU48ddPZ8ZbatnxLTQ3YyHhsQHTpVFAK15XeaJsw6RCJLHujRu3Trl8L+1iWpT9kfktLhfU/vLtpoq9he1AcFfPBXZyneDCF/UitZUJM0bdM4MrpL1tg28j48DxS4xHv61L1dWmXl889fe8scW+mU8c2b7cwVDXVb9OViFVU0LZtSI/DUrRLexLkl0la/NA5MbS0Ir0fqXKOGGZGAQmxCRgJQsGBtKyQcYtjnbegrWh4Ok87+4fpT5CXuwA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 198.47.21.195) smtp.rcpttodomain=gondor.apana.org.au smtp.mailfrom=ti.com; dmarc=pass (p=quarantine sp=none pct=100) action=none header.from=ti.com; dkim=none (message not signed); arc=none (0) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ti.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=9AAog4xG5I3fqrRUyrRYVntKwYPVthg9NlLstka6J8o=; b=LbHMWyVmjeN4ED17zzB+IkNyqAPKhih7l+rWWMxOboyPOrghZwegO3mOQVFUgKOTeOcZsWl1gUdcHK6620bU5BnXF/EUGDEKh9dDqlk9/h4U8LEZvvFN1loFyH38luCBFHVgH9vBZikvEQLn1abeCaWS0CSxL+xvNhpBgYFLD2c= Received: from DM6PR07CA0088.namprd07.prod.outlook.com (2603:10b6:5:337::21) by DM3PPFE23691A9C.namprd10.prod.outlook.com (2603:10b6:f:fc00::c50) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.21.428.5; Thu, 10 Sep 2026 10:43:15 +0000 Received: from SA2PEPF000015CA.namprd03.prod.outlook.com (2603:10b6:5:337:cafe::a7) by DM6PR07CA0088.outlook.office365.com (2603:10b6:5:337::21) with Microsoft SMTP Server (version=TLS1_3, cipher=TLS_AES_256_GCM_SHA384) id 15.21.406.9 via Frontend Transport; Thu, 10 Sep 2026 10:43:15 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 198.47.21.195) smtp.mailfrom=ti.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=ti.com; Received-SPF: Pass (protection.outlook.com: domain of ti.com designates 198.47.21.195 as permitted sender) receiver=protection.outlook.com; client-ip=198.47.21.195; helo=flwvzet201.ext.ti.com; pr=C Received: from flwvzet201.ext.ti.com (198.47.21.195) by SA2PEPF000015CA.mail.protection.outlook.com (10.167.241.200) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.21.406.5 via Frontend Transport; Thu, 10 Sep 2026 10:43:14 +0000 Received: from DFLE208.ent.ti.com (10.64.6.66) by flwvzet201.ext.ti.com (10.248.192.32) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.2562.45; Thu, 10 Sep 2026 05:42:45 -0500 Received: from DFLE211.ent.ti.com (10.64.6.69) by DFLE208.ent.ti.com (10.64.6.66) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.2562.45; Thu, 10 Sep 2026 05:42:45 -0500 Received: from lelvem-mr05.itg.ti.com (10.180.75.9) by DFLE211.ent.ti.com (10.64.6.69) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.2562.45 via Frontend Transport; Thu, 10 Sep 2026 05:42:45 -0500 Received: from pratham-Workstation-PC (pratham-workstation-pc.dhcp.ti.com [10.24.53.205]) by lelvem-mr05.itg.ti.com (8.18.1/8.18.1) with ESMTP id 68AAghjw3150321; Thu, 10 Sep 2026 05:42:44 -0500 From: T Pratham To: T Pratham , Herbert Xu , "David S. Miller" CC: Sebin Francis , Manorit Chawdhry , Vishal Mahaveer , Praneeth Bajjuri , , Subject: [PATCH v3 06/12] crypto: ti - Align buffers to cacheline for DMA Date: Thu, 10 Sep 2026 16:11:56 +0530 Message-ID: <20260910104202.1537226-7-t-pratham@ti.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20260910104202.1537226-1-t-pratham@ti.com> References: <20260910104202.1537226-1-t-pratham@ti.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: SA2PEPF000015CA:EE_|DM3PPFE23691A9C:EE_ X-MS-Office365-Filtering-Correlation-Id: 488a8695-c4fa-4957-47fa-08df0f285136 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|82310400026|23010399003|36860700016|1800799024|376014|10067099003|18002099003|22082099003|56012099006; X-Microsoft-Antispam-Message-Info: KjzDA/3RTseycG5GeFJSeprYyRn0h4aGXE+ECvZnQVZXdHu/FKj1N3ojwWuf6PJVe8vdemf1YwBtD4UIOXuSTM+mZO54+RnueWA/xqpae4OVj8Z6UBNWrilPL+aFzPjR2tVPORnZ596HV6hpjRfbIIfnLUqSUTWYUgPFg1/2hExi+vbIvY5vhp1IVRNAgSA7KcT88LOs1KVm62LbXbyADhlwE+k1GuNd/HkaD2rZpfUum/ngUzhbdV+astJks/aIg3sHCOrxIuVnCjkR+8VmWLynPqqdPLZZqG6okjAD5RlME8nURaT0PuuoghP+B73/IQ+ItkXhlns/TKtd+8lIN4Bkj6mXKgbW0CWVQoGBaB/k2BZws+iCXvnuo6hiWEIT/c3aT1lGGB5XSUWQQDZePczf+UKspwjpM9BiJMawqvkiImnrOzRNtm7r3vacrbFhYrC3RbrlJig2vA6alUwqIVhDwrKbknjTqcNGFmXWY5arQVLYjdh8q1khE2Wp2k8Hn//SXo3b6CfxRxBP0AdPkoAkn2gCQHqkxJs3PxhX+AUA75gZvc1RhHXh76i/mYmW/f0Ko8zuEqDW1xJ6IemQSu+UgDV7tbJmTOfX3+hWHYYE0MYVRgOoy4ZbPF/u8SpdmbQdbs6ksQRHv5dlmsNzVpz7/Qxs2VPETUzl6n7PycWzfxRJM6caoDqxXG5Ilrna X-Forefront-Antispam-Report: CIP:198.47.21.195;CTRY:US;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:flwvzet201.ext.ti.com;PTR:ErrorRetry;CAT:NONE;SFS:(13230040)(82310400026)(23010399003)(36860700016)(1800799024)(376014)(10067099003)(18002099003)(22082099003)(56012099006);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: H63xekvsfEguPBzexael771Qze8fUMzhdfj5ZZt0dKT3VQyQrNoJU0HK8A5+mGog/AK7zlN7KfyyrSlOCPOmWypeJDCub2b8FdpaFB/+qGIwsDolU1txXoKmP8fiq40iq5KKY5yNd+bjePhTkUlR8b0bOQc/D43RIE0bNB8io1Cyks5jHQgal59bIHKiTYpp/N9C9QKlTtKcrMaLXmdffeEy8yZI/XZxXI/k3251fSnfJLk7xFdII4i0EOsxVniJj/Uoit3A2MArFb1sWLQ8S4RWFbBNrxsIAwTGDrSLijCqezGFMTYUrVmQH0avF0F984Gq0V7YExWa1iP4S3TrF8FsQp1U3DKh7QsBpvUhQEaAgY9F5OPXVTiHvEMUyPM5DVu4NwYax603J6vgxztfhaKbnTLKhOS0xUEi+AK4mQqsFZ1fghy0MrhlwNZ964me X-Exchange-RoutingPolicyChecked: QXkHc3f3y4hoU4CohGCdm2jj336FqRbyxlrSopYP4OOrk11G75ChziAZgAqkW7xhMGgTigjNhU1HVrS+ubMh4EmEA+/n29drQVoYaS6ov4AWoZbsFu/XpZ+He8bbssPJOwMoj2Kmt43MoZ3J/5ndacB0YiP9S5T8IUHJFoXduvk7MWgj/8NWit5tqG3cI7epJRBiCtg/othnYm/ZQ/L3DUpDZES6G4Rpd2BqBSQiZTK1yACT0pqhO/OWCtzlCCAu4V3LsJaT7bNuUnyuDfzzFy5hqVaGKC7C5U/CPX4jctTvIBTmECrpwINxLTrQxm0c9jGMW3TLsN4vR4A7U50Vdw== X-OriginatorOrg: ti.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 10 Sep 2026 10:43:14.4761 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 488a8695-c4fa-4957-47fa-08df0f285136 X-MS-Exchange-CrossTenant-Id: e5b49634-450b-4709-8abb-1e2b19b982b7 X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=e5b49634-450b-4709-8abb-1e2b19b982b7;Ip=[198.47.21.195];Helo=[flwvzet201.ext.ti.com] X-MS-Exchange-CrossTenant-AuthSource: SA2PEPF000015CA.namprd03.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM3PPFE23691A9C X-Proofpoint-ORIG-GUID: ZYZfh_RZ4xE76MTfl2k1D3gvKQIOfv_r X-Proofpoint-Spam-Info: AW1haW4tMjYwOTEwMDEyNCBTYWx0ZWRfX+lsmQpl28JQ7 C47gEou5do9OG0w0jgCpv2hFT9LGs/dnSVCNcYSrG5pEaeS5vK85cnsVJk1QKyBWBeDp2l7O3h4 MTg/PIIRS+f9EG346o8C0Ftm5yta/bs= X-Proofpoint-GUID: ZYZfh_RZ4xE76MTfl2k1D3gvKQIOfv_r X-Authority-Analysis: v=2.4 cv=MqbHeGae c=1 sm=1 tr=0 ts=6aa289c6 cx=c_pps a=S19i2aQNi83ZBCZ28RB3Sw==:117 a=tJyPKKxUohctrY4NYmUjkA==:17 a=6eWqkTHjU83fiwn7nKZWdM+Sl24=:19 a=VdqzKS8jKosA:10 a=V5UXEbMT0ywA:10 a=VkNPw1HP01LnGYTKEx00:22 a=Z8NIEmU8O1QQgoT56wFK:22 a=taLDd7a_hP9WKsMzeGRc:22 a=sozttTNsAAAA:8 a=8TpikKgA1nL99BGwQjsA:9 a=zZCYzV9kfG8A:10 X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwOTEwMDEyNCBTYWx0ZWRfX81BY7VX4Kumm AD8iLm9gn8kEBQFSu3I/iwgc27fOy+diKUP7vmTbhSNYx5x7cnfaL7UIRfzMj0aKJNbGAXdk3/r Ye+f4aFU/rRV5TXWjbcElk0UnabHImXHnCkBEeM1dQqQMTZfPmrOpxGY0jlTglrM7RfmUC2/anB DupFnTM0E83uK8fI4BaD/KKqse2JiUYk36XkbdQ7wfhzCsAWI/E3P7qr/gZliN1trKvVKLKHeRV jsUaiozGha818+cnqxp78cx8aN6C2cJ21/h+blNwjW+ysj8YI3ZWUSmdObYRIIELEbrp9ESwMBG jxmxNKBq5RaQ2KhX/TXUSGZSy35A1TIaIL6pLpV7S+KTwXc/CpeolEbuhehnda/LpYvHdu4tee5 qi6pyzoS/IoBHyyWzgDzi/EVjw0nySyjbl1bCVDJxJc1BOvU/LAjxfBD6/4uPuxr1xsAcFVrCmA 17h3LZ5V2NRZcJCVNgA== X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1176,Hydra:6.1.134,FMLib:17.12.100.49 definitions=2026-09-10_03,2026-09-09_02,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 clxscore=1015 impostorscore=0 phishscore=0 lowpriorityscore=0 priorityscore=1501 spamscore=0 bulkscore=0 adultscore=0 suspectscore=0 malwarescore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2609040000 definitions=main-2609100124 Content-Type: text/plain; charset="utf-8" Align padding buffer which are DMA mapped to cache line to avoid any potential cache coherence problem. Fixes: 35645ca63caa1 ("crypto: ti - Add support for AES-CTR in DTHEv2 drive= r") Signed-off-by: T Pratham --- drivers/crypto/ti/dthev2-common.h | 2 ++ 1 file changed, 2 insertions(+) diff --git a/drivers/crypto/ti/dthev2-common.h b/drivers/crypto/ti/dthev2-c= ommon.h index a827817e8119a..cfb50255a5dce 100644 --- a/drivers/crypto/ti/dthev2-common.h +++ b/drivers/crypto/ti/dthev2-common.h @@ -114,7 +114,9 @@ struct dthe_tfm_ctx { */ struct dthe_aes_req_ctx { int enc; + __dma_from_device_group_begin(); u8 padding[2 * AES_BLOCK_SIZE]; + __dma_from_device_group_end(); struct completion aes_compl; struct dthe_data *dev_data; }; --=20 2.34.1 From nobody Fri Sep 25 16:51:46 2026 Received: from mx0a-0002e601.pphosted.com (mx0a-0002e601.pphosted.com [148.163.150.75]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 7DCCC3E4106; Thu, 10 Sep 2026 10:43:18 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=fail smtp.client-ip=148.163.150.75 ARC-Seal: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1789037001; cv=fail; b=tC3c+/vESQNHXk+/pWN4FhYCiERBACqVNXqwlPATjtLbPEfncfTQnTmjwbG6goF4/Lh7lZzJTwko3Pd5tBOWDWr//w5m4ZQnlvBQdE2znI76O6j4MajiXk2I9OAqDKDBOoBdMbo5Ali3HlECfr8mBFkveDMr9gzICIWFS3np0QU= ARC-Message-Signature: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1789037001; c=relaxed/simple; bh=L6sJTGbxYKzCcew0gputMowl1JIkjqKkuQGwSODlbjs=; h=From:To:CC:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=PXJXEbIODZpXV8qw7sHhZy/aR1mneDwh5zhE3Euu2Jo12HlDXJqpxk1RgFBhRhkyR4tdB7fIls0SiwnvzJRx6frQNXMZAnh0vfKyGBaQszegyNHr4NWqys1CUM3bN6w0s+wOjf1W7jptKrKpIJSpq3LKWypVJq5rrGmkp+6GVbw= ARC-Authentication-Results: i=2; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=ti.com; spf=pass smtp.mailfrom=ti.com; dkim=pass (2048-bit key) header.d=ti.com header.i=@ti.com header.b=e97Enfsr; dkim=pass (1024-bit key) header.d=ti.com header.i=@ti.com header.b=AaUJTKfh; arc=fail smtp.client-ip=148.163.150.75 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=ti.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=ti.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=ti.com header.i=@ti.com header.b="e97Enfsr"; dkim=pass (1024-bit key) header.d=ti.com header.i=@ti.com header.b="AaUJTKfh" Received: from pps.filterd (m0380145.ppops.net [127.0.0.1]) by m0380145.ppops.net (8.18.1.11/8.18.1.11) with ESMTP id 68A9KRdk2786667; Thu, 10 Sep 2026 05:43:16 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ti.com; h=cc :content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s= proofpoint-05-2026; bh=1XOuYy4Cz02k59FK1p12uZ+MgDqx6sx09AI8IDLaQ 7A=; b=e97Enfsr8AhQMAUsQFcFUCPcSBLqOYyFcGdn/w8FhuJMTp5sGKWET9RHT 84Gp3luaisRdJOCeUXfaBEQ3xyLzgkaExxzGnj1HewWOp/kO/jLvHe+HKmGTlytG fJyXi9k5vC6MWgCoZ+uQLaLhuz5ne0BUY803rIZj0kpTBHmZw/f9CJg4/YITRMeW Qno4oR3gGa31Lxa45rdtGlIH1VAPylOadHnZYWYK/z9RcqDDLji8a/376v+Es9/O t3g4icCoXl21EHdp1UevPNDxpakvU0sVO/BkjrLf/jFYCmz557enrEKDdJWId3NS 84xa6fYAiKbBXFrXO0CRXUCgJo0xQ== Received: from dm5pr21cu001.outbound.protection.outlook.com (mail-centralusazon11011035.outbound.protection.outlook.com [52.101.62.35]) by m0380145.ppops.net (PPS) with ESMTPS id 4gkstv8b9c-1 (version=TLSv1.3 cipher=TLS_AES_256_GCM_SHA384 bits=256 verify=NOT); Thu, 10 Sep 2026 05:43:15 -0500 (CDT) ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=bTq1guQMX876JZp3GDe4yXKofqz0btlPKkikuV2Uvomwl50RYtpC7wp1CxVtmIDSp5LZtSD+PVJyHPntcQItQ21+roKeS6QHsVyZuHeSoFRhtfTGLhtlFS8TPyYQrdFyeZvSZ36wyQy8crr9CUHk26Vm38pHru97qPozif8S/EHgp/dAXSfHhyGfhN4K5Eb55yQAhfVhQDyahC8AtvJvg0dUvBiq5MAoh+XA+UWsiF3LVG7LFCngr9++riCWI130IYJKZ0Vj9gHq0VxJBsUb6C0mSc1Dl9xDSqg8jJTsCTD6zJKzmqHxw/uaLsH92LlXUDvDiu9eytRSr7AUbZpMsQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=1XOuYy4Cz02k59FK1p12uZ+MgDqx6sx09AI8IDLaQ7A=; b=XZocU0rq+YxKu+yvJhrVyXtf7s25+MdZGePaqq4/CWaMcUpF+BWf9WG6W0Ih5bYe81J/mcFpAVggZ0g2zy5/DldM3xhjkH9iNcAJpMhKhwBw1Z5TlmONZH7SDDtujVLyBerTyWv1zuUSNEzcafFkmG4rIQirPnYEmrP3vK4KvsyCOT5l264ks0zhvWB80Z1WJ2Fxhp3plBgdROg2od0cWSSxY04Fm9ccU83tIh+HT7xGQYvMdFWXAw/Z2TkqW4ejskNkHnXY0RoognNrSgowFyWrV/woZrax9QpsZRnwDKcIuvxs10lql9s2Hv/1NhnIYwav0MJJfx90UhN/hTNNYg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 198.47.21.194) smtp.rcpttodomain=gondor.apana.org.au smtp.mailfrom=ti.com; dmarc=pass (p=quarantine sp=none pct=100) action=none header.from=ti.com; dkim=none (message not signed); arc=none (0) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ti.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=1XOuYy4Cz02k59FK1p12uZ+MgDqx6sx09AI8IDLaQ7A=; b=AaUJTKfhobJIvGjrafQKgqeVL0SoJqxnSHO51zsp7ECwTKP21C3Zv2FKrZWlwwxNKTHOP21Wx/h8IpUH/rQbMz6nB7EyXNq7UyQ/HvY+ogYIeFkhgKCx47uYjbpnjHXzRmbjFaMJMvzaTJpIQi5pTT/g1WnPB97207EyzlPI2lk= Received: from BN9PR03CA0768.namprd03.prod.outlook.com (2603:10b6:408:13a::23) by DS4PR10MB693589.namprd10.prod.outlook.com (2603:10b6:8:3ed::9) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.21.406.7; Thu, 10 Sep 2026 10:43:13 +0000 Received: from BN7PEPF00000092.namprd03.prod.outlook.com (2603:10b6:408:13a:cafe::ab) by BN9PR03CA0768.outlook.office365.com (2603:10b6:408:13a::23) with Microsoft SMTP Server (version=TLS1_3, cipher=TLS_AES_256_GCM_SHA384) id 15.21.406.9 via Frontend Transport; Thu, 10 Sep 2026 10:43:13 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 198.47.21.194) smtp.mailfrom=ti.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=ti.com; Received-SPF: Pass (protection.outlook.com: domain of ti.com designates 198.47.21.194 as permitted sender) receiver=protection.outlook.com; client-ip=198.47.21.194; helo=flwvzet200.ext.ti.com; pr=C Received: from flwvzet200.ext.ti.com (198.47.21.194) by BN7PEPF00000092.mail.protection.outlook.com (10.167.245.70) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.21.406.5 via Frontend Transport; Thu, 10 Sep 2026 10:43:12 +0000 Received: from DFLE211.ent.ti.com (10.64.6.69) by flwvzet200.ext.ti.com (10.248.192.31) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.2562.45; Thu, 10 Sep 2026 05:42:50 -0500 Received: from DFLE210.ent.ti.com (10.64.6.68) by DFLE211.ent.ti.com (10.64.6.69) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.2562.45; Thu, 10 Sep 2026 05:42:50 -0500 Received: from lelvem-mr06.itg.ti.com (10.180.75.8) by DFLE210.ent.ti.com (10.64.6.68) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.2562.45 via Frontend Transport; Thu, 10 Sep 2026 05:42:50 -0500 Received: from pratham-Workstation-PC (pratham-workstation-pc.dhcp.ti.com [10.24.53.205]) by lelvem-mr06.itg.ti.com (8.18.1/8.18.1) with ESMTP id 68AAgnCd2177942; Thu, 10 Sep 2026 05:42:49 -0500 From: T Pratham To: T Pratham , Herbert Xu , "David S. Miller" CC: Sebin Francis , Manorit Chawdhry , Vishal Mahaveer , Praneeth Bajjuri , , Subject: [PATCH v3 07/12] crypto: ti - Separate padding buffer for src and dst Date: Thu, 10 Sep 2026 16:11:57 +0530 Message-ID: <20260910104202.1537226-8-t-pratham@ti.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20260910104202.1537226-1-t-pratham@ti.com> References: <20260910104202.1537226-1-t-pratham@ti.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: BN7PEPF00000092:EE_|DS4PR10MB693589:EE_ X-MS-Office365-Filtering-Correlation-Id: 7742eb01-2325-4512-2d59-08df0f284fe2 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|82310400026|36860700016|23010399003|376014|1800799024|22082099003|18002099003|56012099006|10067099003; X-Microsoft-Antispam-Message-Info: APkBdnCFFefP7uxNpepAx0qhzJahgiR9qNc/ZTItHHi+4UziBfUql3tWMo8uofv7Xcz/FbLHaaJ4jZ76w3lNKcCayoH63o7WFypaFs0H5qkod5yoBnQG2ei+hKnyuWRSF2k0zijAmsZlF3aY4YCi55pp1hyLgerphNWgRQhs/qxTrz8wcZcT4qqw7a5ADKwS2Sz+6kLt3372rYjlc/dcIwOXxyVNm1uN+eI07t3Sderj0xOz3IQcL+tdz3FDdHwQFED7jEPiTQYsFIgpQgy+f0+oI9flAuOz02tTGYub/J4cHjq0D6X96y7SSPPUslt0p0yvP4y2E1DEmh/ek23uXJFXduJ3Pj8zKW6ALG7xia9fUpcuasClZc2FUcj9KPp43gzv8fRBBRea+qExhBPucwMrZxTanJ4jIpBlviBM52pQl3qB0+OiGvI8RkCCYK7iXz2d6ulckuxZ/RdaSVqkxKqzeyq3ERjcVo+I13/b5mq2aH4Vm1k2L3Brs9lA/ews3sODfiABzt2K0jlXDnX12gU/4uCw699gQQeu43pevuf7A1FhnkGgssTV556CZhGdOxFhVttGrvRyFu8x4TMjXvT27kqTSL5RO3tH057Lf+9DDePA+NQjkUO2E8n+TMgMYlY+enNJBjtrekAtpTEypM265B0CSZKvX3cRId6Y8Nw/SeagXmxdjzmsN0qOQhv0n3rGKqm+WR4+A/rq1cVYTg== X-Forefront-Antispam-Report: CIP:198.47.21.194;CTRY:US;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:flwvzet200.ext.ti.com;PTR:ErrorRetry;CAT:NONE;SFS:(13230040)(82310400026)(36860700016)(23010399003)(376014)(1800799024)(22082099003)(18002099003)(56012099006)(10067099003);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: X0eVPHV+8PHBmXR2Ay0oYgSoRuhuINz/EFmNU2GkHYcNCRghGQPWKGkFJ9M1HFJshIvX8qknSi0vciJ/KMD02aUpnumoov+h2rFjRxbst53WDGWJo9ngj5FCiIyNDUedl+0wjikq/3qU8HfFuBs8EScEQ590NhIxAuKKqIa8LTl0oT645g/IDqzR95vLrJq33JeT8QBMKSHgp/cUcb0V32lW/j+e0K0xrLPU/tXLn4Fz8NR6P/JESj22HYV6nhAsPhMfRrissptiyLMsY8TSGegx7tDoK8bFASpb3mZrjmkuBj6SJXWvEfRTe3uOyfba2PHWGB1pLEpOWKGMcCsORcvwAR5eLOoJbhCfYBUeMlCTpF4FB4OO4ArJp9eZZKUnLWITe0DWYfdzh/WBfRNs8hyfpmWA3y8yzlGaJpJdUEICuP5+H6clXAHP+u1hfDG5 X-Exchange-RoutingPolicyChecked: Bz1GezlgbBqP9KxZPOPO5KZG6Ee5wkNPHtCiGe7IPYFLEenJ+zl6JUCFZehYa/9KmRyVaGL6or7u4EoIbGnDuDN7BwEuWpyYJTyLFqLsYesy/TiPoFK9vW+8XYzm+jATSGulERhIl2OEE9vNBsW/7QgKduGTwAqTB2k9g0mUze5HIN8STu5oSyV21E+gS+JcBV/kwosIfEIQ5S18/dn9Z577FdWysqjjZ8j3P4/UzUiorAKNzq+dnEieoBQU2hfXR22cEYHwOkqX0J5mQGzy/ew2N1X4ctf5Oqm8F2FfELav7y8EOdVMkz+Q0PV7kVew47k636qhyN4TnabyEi+Xbg== X-OriginatorOrg: ti.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 10 Sep 2026 10:43:12.1997 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 7742eb01-2325-4512-2d59-08df0f284fe2 X-MS-Exchange-CrossTenant-Id: e5b49634-450b-4709-8abb-1e2b19b982b7 X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=e5b49634-450b-4709-8abb-1e2b19b982b7;Ip=[198.47.21.194];Helo=[flwvzet200.ext.ti.com] X-MS-Exchange-CrossTenant-AuthSource: BN7PEPF00000092.namprd03.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: DS4PR10MB693589 X-Proofpoint-Spam-Info: AW1haW4tMjYwOTEwMDEyNCBTYWx0ZWRfXyD6hc/oUJiOb fDXYj2Umdnt9dYXXs4nSj56uLM+5eM4FJp1WYJB6/e+J7RcPoHLgezIlYBKGIF00V7d+zfzuora MM0GTY0bNNY0h39RAMKFK5pHV1l2LKY= X-Proofpoint-GUID: n5imDquV77g8KmZ3mljIDX_JoInOVs3O X-Authority-Analysis: v=2.4 cv=VvG2kO2n c=1 sm=1 tr=0 ts=6aa289c3 cx=c_pps a=YQq2SbcpNRFTj3qt8lmqwA==:117 a=iwqwCZQqcuTv3JOpYdM7/Q==:17 a=6eWqkTHjU83fiwn7nKZWdM+Sl24=:19 a=VdqzKS8jKosA:10 a=V5UXEbMT0ywA:10 a=VkNPw1HP01LnGYTKEx00:22 a=Z8NIEmU8O1QQgoT56wFK:22 a=gO1vWkAQAl3rybz1DQOp:22 a=sozttTNsAAAA:8 a=pcghVQDwmu1mgjzKNFMA:9 X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwOTEwMDEyNCBTYWx0ZWRfXwe15EcL4msNL 4QGsygd0MlOko/ywbEuKE9wkBYZbzS0lBc8GB9kOmA2dEUhCyswhegtWWOSgWritieiVgcrizfm vi59n6QRFc7roOpBBiHG7x9YM7xkImop2XiCkueS8fHw1mVmN7fRJVoB3ooqxsgdhZM1ptAAxZD RpNJFciBZ8f/5K1xvWSYZIOq44xAXFFqWLBpSi/ifEUnZ3b6G15dprQfAG+ykEHXfs9/5VdUiXo /kApMXOUgkfdv9d+I2pwltnGlMkeTROKcDp3eCs8BevzGuczkYzTqaSiEcPmhxkVf+efzOyhNC/ r7s+JGTiKcoz7Fq9MEer/QL8j3tmRzIjtobJbv/gO3n25VJryu89W/y1VuYcw4V/PlEmW23e6BK b30A8IQk/owZnTHuj3emHfRJ8oSC5bc8FANjByzrxD49KTf9ujido7nStWHrTzdtYH1G/iyKmh+ lmgGNP6QPPPrfrUX23A== X-Proofpoint-ORIG-GUID: n5imDquV77g8KmZ3mljIDX_JoInOVs3O X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1176,Hydra:6.1.134,FMLib:17.12.100.49 definitions=2026-09-10_03,2026-09-09_02,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 adultscore=0 bulkscore=0 lowpriorityscore=0 priorityscore=1501 suspectscore=0 malwarescore=0 spamscore=0 phishscore=0 impostorscore=0 clxscore=1015 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2609040000 definitions=main-2609100124 Content-Type: text/plain; charset="utf-8" Separate the padding buffer, which is allocated in the req ctx, for src and dst scatterlist to avoid any DMA mapping issues when not doing inline operations. In such cases, the current code was mapping the same padding buffer twice which might cause issues. Fixes: 35645ca63caa1 ("crypto: ti - Add support for AES-CTR in DTHEv2 drive= r") Signed-off-by: T Pratham --- drivers/crypto/ti/dthev2-aes.c | 19 ++++++++++++------- drivers/crypto/ti/dthev2-common.h | 2 +- 2 files changed, 13 insertions(+), 8 deletions(-) diff --git a/drivers/crypto/ti/dthev2-aes.c b/drivers/crypto/ti/dthev2-aes.c index be7ec62ab2513..aeccc235cb667 100644 --- a/drivers/crypto/ti/dthev2-aes.c +++ b/drivers/crypto/ti/dthev2-aes.c @@ -338,6 +338,9 @@ static int dthe_aes_run(struct crypto_engine *engine, v= oid *areq) int src_mapped_nents; int dst_mapped_nents; =20 + u8 *src_padding =3D rctx->padding; + u8 *dst_padding =3D rctx->padding + AES_BLOCK_SIZE; + bool diff_dst; enum dma_data_direction src_dir, dst_dir; =20 @@ -388,8 +391,8 @@ static int dthe_aes_run(struct crypto_engine *engine, v= oid *areq) sg_init_table(src, src_nents); sg =3D dthe_copy_sg(src, req->src, req->cryptlen); if (pad_len > 0) { - memzero_explicit(rctx->padding, AES_BLOCK_SIZE); - sg_set_buf(sg, rctx->padding, pad_len); + memzero_explicit(src_padding, AES_BLOCK_SIZE); + sg_set_buf(sg, src_padding, pad_len); } =20 if (diff_dst) { @@ -401,8 +404,10 @@ static int dthe_aes_run(struct crypto_engine *engine, = void *areq) =20 sg_init_table(dst, dst_nents); sg =3D dthe_copy_sg(dst, req->dst, req->cryptlen); - if (pad_len > 0) - sg_set_buf(sg, rctx->padding, pad_len); + if (pad_len > 0) { + memzero_explicit(dst_padding, AES_BLOCK_SIZE); + sg_set_buf(sg, dst_padding, pad_len); + } } else { dst =3D src; } @@ -492,7 +497,7 @@ static int dthe_aes_run(struct crypto_engine *engine, v= oid *areq) =20 aes_map_src_err: if (ctx->aes_mode =3D=3D DTHE_AES_CTR && req->cryptlen % AES_BLOCK_SIZE) - memzero_explicit(rctx->padding, AES_BLOCK_SIZE); + memzero_explicit(rctx->padding, 2 * AES_BLOCK_SIZE); if (diff_dst) kfree(dst); =20 @@ -882,7 +887,7 @@ static int dthe_aead_run(struct crypto_engine *engine, = void *areq) =20 u8 *src_assoc_padbuf =3D rctx->padding; u8 *src_crypt_padbuf =3D rctx->padding + AES_BLOCK_SIZE; - u8 *dst_crypt_padbuf =3D rctx->padding + AES_BLOCK_SIZE; + u8 *dst_crypt_padbuf =3D rctx->padding + 2 * AES_BLOCK_SIZE; =20 bool diff_dst; enum dma_data_direction aad_dir, src_dir, dst_dir; @@ -1125,7 +1130,7 @@ static int dthe_aead_run(struct crypto_engine *engine= , void *areq) kfree(aad_sg); =20 aead_prep_aad_err: - memzero_explicit(rctx->padding, 2 * AES_BLOCK_SIZE); + memzero_explicit(rctx->padding, 3 * AES_BLOCK_SIZE); =20 if (ret) ret =3D dthe_aead_do_fallback(req); diff --git a/drivers/crypto/ti/dthev2-common.h b/drivers/crypto/ti/dthev2-c= ommon.h index cfb50255a5dce..f78420ba871e2 100644 --- a/drivers/crypto/ti/dthev2-common.h +++ b/drivers/crypto/ti/dthev2-common.h @@ -115,7 +115,7 @@ struct dthe_tfm_ctx { struct dthe_aes_req_ctx { int enc; __dma_from_device_group_begin(); - u8 padding[2 * AES_BLOCK_SIZE]; + u8 padding[3 * AES_BLOCK_SIZE]; __dma_from_device_group_end(); struct completion aes_compl; struct dthe_data *dev_data; --=20 2.34.1 From nobody Fri Sep 25 16:51:46 2026 Received: from mx0b-0002e601.pphosted.com (mx0b-0002e601.pphosted.com [148.163.154.28]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 6483F45D1BA; Thu, 10 Sep 2026 10:43:11 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=fail smtp.client-ip=148.163.154.28 ARC-Seal: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1789036994; cv=fail; b=SsWt8UqLdA9cm3ZadweXLBHiRdpDsyKJGKgltvziLVVbS258AfDdFDyoGuBoKXncwd1jMHWfGpvJvgDofSm6+qZcIVHP5h6xiX4uq1bNQQZB5lQZKcGyNdF5J1zTzODiBao1GgPBykQg7YfGmHq/cAbb9D04mAiPxC/7kj35FSA= ARC-Message-Signature: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1789036994; c=relaxed/simple; bh=Ge9j09OItfl39sMD0+R3OKL8fXxzjj6qvomlEshNfas=; h=From:To:CC:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=Bn5jR4H4DV0HCehTErFhuVP7ikO1I0164Jfn3vz7Nrjh+XFHEth6wGpYZUM5p5k7T4m+WALHFnaqyQF/RXIHxhk4HPPMMOp47W1/RqipDGW9LC3W9sI2TqfGF1pUtbEKZzYmhfh6iR0yVkrxzAUjpEyzepBVgSPXKDT1Zo0az5Y= ARC-Authentication-Results: i=2; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=ti.com; spf=pass smtp.mailfrom=ti.com; dkim=pass (2048-bit key) header.d=ti.com header.i=@ti.com header.b=Rz4u3QpC; dkim=pass (1024-bit key) header.d=ti.com header.i=@ti.com header.b=SF90WBAJ; arc=fail smtp.client-ip=148.163.154.28 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=ti.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=ti.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=ti.com header.i=@ti.com header.b="Rz4u3QpC"; dkim=pass (1024-bit key) header.d=ti.com header.i=@ti.com header.b="SF90WBAJ" Received: from pps.filterd (m0374955.ppops.net [127.0.0.1]) by mx0b-0002e601.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 68A8oYLn2934232; Thu, 10 Sep 2026 05:43:08 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ti.com; h=cc :content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s= proofpoint-05-2026; bh=30Ztst7SGgSl2Rl1/eIFquFLmUY0KxcuyVzjHqWNX uQ=; b=Rz4u3QpCuJiPHym0s/FdgkBM/ufq/gS4ZBTStrPy1TZvcD1A5XjtfG74U zKxvNhYI7NveC85RWmvNKx2flIH03GqzbtNW1N4RjLRdHq94FfxlMcgNjdsLsxzC G3K1uHK0FO+k2IfqGocSfSjH+b9MhNRpmTtqBDo8X8lLY/sbYCN0shm9zf2V1flj j7+Lzj+2rlrsu+7xX5mskRSM1DvxB8Z73KLoAuUQkb8gtdyH1PNTp8YzSP5EGNBg LpQNGk606enYOv3mqcDI9yeBlt7eOg3Fbps7abd2GTBRtRBx+UMhM3p9dLzw/whM 4jbHBHHEzxWCU8wnagl2sL+fzTfNQ== Received: from bl2pr02cu003.outbound.protection.outlook.com (mail-eastusazon11011063.outbound.protection.outlook.com [52.101.52.63]) by mx0b-0002e601.pphosted.com (PPS) with ESMTPS id 4gkcxg4xjk-1 (version=TLSv1.3 cipher=TLS_AES_256_GCM_SHA384 bits=256 verify=NOT); Thu, 10 Sep 2026 05:43:08 -0500 (CDT) ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=HWBWLb49i1osEKjS9RFmxdGuR1GKb8r1/io1idnYFOygtiqt/qAIaTrslju1bFS7CfX7ZOmDFRE4lbb8geqmEycYfNrCQ5EAyQDw6XV9x9Y4Flq7Te26cnF3ArVSOlOSZkgTOOicgD05UMYzV6zjyNSMs3jO9TlofJXruJdzpWsDgLnMMf2H3ZjKF1E/uWEjAVrk91zU5NCmKP5X/VymSvwhgOh4Qxwy3sclWrTnb3Tl1HeHgOVIz8CKsx1iRttQcuwYtJf/+UJoCddl1zXh+xrohrH2TNqR60VasyrnIMiccX6o2dOoZLLWRo1MPHIQd+Ea7zj0lDkUf/0S89mjiw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=30Ztst7SGgSl2Rl1/eIFquFLmUY0KxcuyVzjHqWNXuQ=; b=gohGpAHUJAoDSyrmQ8NVBMnXxmkJNS9gP/sTsMMXKIZCBRoBqkPlIFBWl6y3XdGfxoHsM6YihCsNTEraplBP/sbjNEVMecOmsFSScvQT7CJ16OTZcZs1b+E6J0Vis0brLbKVBVRP6s2gun11lwCoYmqT2/LwH5mxAIXEUJrLGVngt/YdevqQwnRVjh+mVih6fu2x6f+NAsCjmbvZ+lGrtQyvtEk1O5reT0RT5CJY8FxOS7ZLp3sZNTaX38s0YBh9PYzfCrmfAwsdc1A/lJWnFJPV3H83ss2QrDOak8tCiDup8tQbSBaazo0VRgzdUrbBoKlkpRXQLWCdu1t8UNSXbw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 198.47.23.195) smtp.rcpttodomain=gondor.apana.org.au smtp.mailfrom=ti.com; dmarc=pass (p=quarantine sp=none pct=100) action=none header.from=ti.com; dkim=none (message not signed); arc=none (0) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ti.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=30Ztst7SGgSl2Rl1/eIFquFLmUY0KxcuyVzjHqWNXuQ=; b=SF90WBAJckoRYjhQxXB7LSvA57FsPHNeHCAadBtZOkQRfKlw47ryiU/yWFK8qnSzLs25ayPfku1cWyGV1CghG0cpQ9pLjqWQ8odgeb8iV8n2fC9sg6QvXlIvdyDAudVQfQbX07Y3EI1fhVnRin5TBtp3MbTvlYFChP/2UMAoKq8= Received: from BY3PR05CA0022.namprd05.prod.outlook.com (2603:10b6:a03:254::27) by PH0PR10MB4631.namprd10.prod.outlook.com (2603:10b6:510:41::10) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.21.406.7; Thu, 10 Sep 2026 10:43:06 +0000 Received: from BY1PEPF000264B0.namprd02.prod.outlook.com (2603:10b6:a03:254:cafe::1a) by BY3PR05CA0022.outlook.office365.com (2603:10b6:a03:254::27) with Microsoft SMTP Server (version=TLS1_3, cipher=TLS_AES_256_GCM_SHA384) id 15.21.428.6 via Frontend Transport; Thu, 10 Sep 2026 10:43:06 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 198.47.23.195) smtp.mailfrom=ti.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=ti.com; Received-SPF: Pass (protection.outlook.com: domain of ti.com designates 198.47.23.195 as permitted sender) receiver=protection.outlook.com; client-ip=198.47.23.195; helo=lewvzet201.ext.ti.com; pr=C Received: from lewvzet201.ext.ti.com (198.47.23.195) by BY1PEPF000264B0.mail.protection.outlook.com (10.167.242.119) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.21.406.5 via Frontend Transport; Thu, 10 Sep 2026 10:43:05 +0000 Received: from DLEE209.ent.ti.com (157.170.170.98) by lewvzet201.ext.ti.com (10.4.14.104) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.2562.45; Thu, 10 Sep 2026 05:42:53 -0500 Received: from DLEE215.ent.ti.com (157.170.170.118) by DLEE209.ent.ti.com (157.170.170.98) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.2562.45; Thu, 10 Sep 2026 05:42:53 -0500 Received: from lelvem-mr05.itg.ti.com (10.180.75.9) by DLEE215.ent.ti.com (157.170.170.118) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.2562.45 via Frontend Transport; Thu, 10 Sep 2026 05:42:53 -0500 Received: from pratham-Workstation-PC (pratham-workstation-pc.dhcp.ti.com [10.24.53.205]) by lelvem-mr05.itg.ti.com (8.18.1/8.18.1) with ESMTP id 68AAgqVM3150465; Thu, 10 Sep 2026 05:42:52 -0500 From: T Pratham To: T Pratham , Herbert Xu , "David S. Miller" CC: Sebin Francis , Manorit Chawdhry , Vishal Mahaveer , Praneeth Bajjuri , , Subject: [PATCH v3 08/12] crypto: ti - Validate sg_nents_for_len() return value in DTHEv2 AES Date: Thu, 10 Sep 2026 16:11:58 +0530 Message-ID: <20260910104202.1537226-9-t-pratham@ti.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20260910104202.1537226-1-t-pratham@ti.com> References: <20260910104202.1537226-1-t-pratham@ti.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: BY1PEPF000264B0:EE_|PH0PR10MB4631:EE_ X-MS-Office365-Filtering-Correlation-Id: 1ed940e3-ce05-4ea4-6c6b-08df0f284bc0 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|82310400026|23010399003|36860700016|376014|1800799024|10067099003|56012099006|22082099003|18002099003; X-Microsoft-Antispam-Message-Info: jElhkQgh61001YFh1AoM/Waxmouzkmpc+9kkxtmwwYWVs5nSFQBBT65rfT6gxZ7rE+aYc3YntzZdXTHT7Mr3HX1rX4sqm9DNFRGlLwUetumboBCfeoYOCKyyWKvN59dfneuwVc2ConqbBrAQmwC18KZy23Yj22I0PvvhBcCjthhcUB14pRQvd8CdowbE/QbPQ8umnI7YVwVpCAU723YZpYJxcE7CtphbNz0WKTDT4HP+HMXuS4efHrvc+3wdk7HwadJaexWMlDu9/Y6r+YcXjK2VOM1hx79T54ia4SorGHtREPIKCvfdF0Ecn/g3Q/2katJt87ZSI/ec3Y0uM0a+X3edSsX47RpeICscvSoLiqe/sKIWE4LSG7F34R5VEv3/pG2OY5I7CoyVpiGPjg3zvlk/T7gkcbecnd/4q16XpAgGMCeBf3z+YtsouduztWG4HL7PApGlbpOP9Q1cw6nFzpvVCDQNX2oXsdDr6S+5skdYca1zi4NZvOd9v5/qBqiabr8pA/4BnXXAgQo3MpoKD69Cno7UQf+LJr3wnLeU0RTrhGS4aLiqSQVi8dGVKWkIpNMW9lFRDTmHbyVof7gw5xoQ7S8P1cnFKr63Bwahch9k7V7x/r/qgRfYZipAFjPDrc0ahQ21Cyva4rkNSuY34hGitz7u6gj+ymUt3vgKVlfi5XUiphgfKQlcz+QYkLWKpgL8sSmXIXXNeaT07ODprA== X-Forefront-Antispam-Report: CIP:198.47.23.195;CTRY:US;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:lewvzet201.ext.ti.com;PTR:InfoDomainNonexistent;CAT:NONE;SFS:(13230040)(82310400026)(23010399003)(36860700016)(376014)(1800799024)(10067099003)(56012099006)(22082099003)(18002099003);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: kv3QrH3oXPLvX5JWj6Yr9VdOLUjEqgsNdGANcqeMfZ1Nw2z3f3OS964dHsUp1rZAQalR3lBfll2Tz59m4fskmiXw8a8ud1atf6b89k/DJdX2vLDF0xgXxwh/WmY9Q06hvoGtkp9xztUGXivIHkikQogmpAxVXxb6pa40m8RFwgOKoDNNqrPdnhKPhEp/jPRmkwLpU/jUfttgxUnO06hub1H5aD2vw3YiPe2QyzyrmnCcuxaUh3jz4aohEOejhdrX313XdtDR4lJl5/zqyFLJ0CDqAUIWnLMu1WtjyLs8ttKGe1l1W8z5c8Z3RhR9CzeujvW8qzPCm8gYn9Y5eTQD/wvoK3Dd7HYcXxv4blCesvQc0gHNKWJwDoW939KRxovzH4gUvhSpXHZgylKXHVudJoWMJcI+jHf4dVG8FkH8dx3FDmu3oeec1dh6RkXflyIU X-Exchange-RoutingPolicyChecked: NVZ/bfVfFveRr3cG3Rfe6+oCIGNL24YA7umwhZL8TD4qyODOVVd2w+oZeooKmQjl2hpJsDxMBH6I0fLvR1I6BXoJai844Ipf4jnHjLtETTpFuMnny2KZ5qew5fOVq/vRUt8j9fLhMvp1o00foifFy3bMIt6aV0VoPE/B4/y3TZkCo/Wcsr9hXSqMwC2tA5AHqxvpdOFaYmJMhQqstsV4Z2a+NR3Z30hEIVxtd8CJZRE4klC2K87+K/jW4SjaavbZSQ5mM543VS41njxnY38c4AfMyKszY092uejTlsYdc1O3awFspHvopFjsoHe9Why1DiRKpmFN957a/uoWLkXWXQ== X-OriginatorOrg: ti.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 10 Sep 2026 10:43:05.2616 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 1ed940e3-ce05-4ea4-6c6b-08df0f284bc0 X-MS-Exchange-CrossTenant-Id: e5b49634-450b-4709-8abb-1e2b19b982b7 X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=e5b49634-450b-4709-8abb-1e2b19b982b7;Ip=[198.47.23.195];Helo=[lewvzet201.ext.ti.com] X-MS-Exchange-CrossTenant-AuthSource: BY1PEPF000264B0.namprd02.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH0PR10MB4631 X-Authority-Analysis: v=2.4 cv=MpPHeGae c=1 sm=1 tr=0 ts=6aa289bc cx=c_pps a=/mfax+0MUk3zis5Hx41TAA==:117 a=f+v6EHfkeJbVwR46tk4DMg==:17 a=6eWqkTHjU83fiwn7nKZWdM+Sl24=:19 a=VdqzKS8jKosA:10 a=s63m1ICgrNkA:10 a=V5UXEbMT0ywA:10 a=VkNPw1HP01LnGYTKEx00:22 a=Z8NIEmU8O1QQgoT56wFK:22 a=fPAWb5peG099m5CrUpKH:22 a=sozttTNsAAAA:8 a=wrH6CD59uMa574BPOq8A:9 X-Proofpoint-ORIG-GUID: fpYfyP6CrbfbMGXLwQ2B2j_PywxFbBM2 X-Proofpoint-Spam-Info: AW1haW4tMjYwOTEwMDEyNCBTYWx0ZWRfXybT2xAfN0/Ir JC2NkmvWQU/IuHAK8Up9D/zsf5mGTaLVMJLcnkLX+b13hwnajT188cNUZx1XWEbOW2HrLfl6NnD FKiCBZleiMTt5W+NRuvyMC8L/sOPkX8= X-Proofpoint-GUID: fpYfyP6CrbfbMGXLwQ2B2j_PywxFbBM2 X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwOTEwMDEyNCBTYWx0ZWRfX54lV84jSYbYG ZYXjihWuZI242PhLdW3v4afrI+TpKtMPEcv5rXLsRdp51WnhNNxfE/BG7za8JAsp40jaBJLzZzu 9i5eVsUXNfguL2W0IFXaap6hWRiz2peQppA6Wjq0/CL2FYQHsR0HaRWFDQUcQx08VC3laz2EBEk moy//dIQpaVa4cfVXWJGaKxq22RIzmJFZWw3ewIjBpl4lkwZTLUZ86FVz/JMQV+lVKFskhZFG4a /SMEsvqXhFgl7o1J+P5sHSht+FXilzMHthi/GhMp9qlpt+900/rPZBxxLDrFB2BkuZN6QYMEY0P tkrfw5C7DUggTBwnXqotNEEPmvTjoXGTZcUuJcM/usK4FqHv6se5p9GTrr0Qr89Hl6v13Ef0IO/ aP9qnpHC7Lj7sq4ArjUwWc2FmGLesAUgzp9aYyiIHqSFTkEvOI2/BnPrfwDk1JOp5Vgixbx8dtZ 20aNnrvDFZSG1dczADQ== X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1176,Hydra:6.1.134,FMLib:17.12.100.49 definitions=2026-09-10_03,2026-09-09_02,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 priorityscore=1501 lowpriorityscore=0 adultscore=0 suspectscore=0 malwarescore=0 impostorscore=0 phishscore=0 clxscore=1015 spamscore=0 bulkscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2609040000 definitions=main-2609100124 Content-Type: text/plain; charset="utf-8" sg_nents_for_len() returns -EINVAL if the supplied scatterlist is shorter than the requested length. Add explicit checks after each sg_nents_for_len() call in DTHEv2 AES driver. Fixes: 52f641bc63a46 ("crypto: ti - Add driver for DTHE V2 AES Engine (ECB,= CBC)") Signed-off-by: T Pratham --- drivers/crypto/ti/dthev2-aes.c | 6 ++++++ 1 file changed, 6 insertions(+) diff --git a/drivers/crypto/ti/dthev2-aes.c b/drivers/crypto/ti/dthev2-aes.c index aeccc235cb667..bc3591ec58a1c 100644 --- a/drivers/crypto/ti/dthev2-aes.c +++ b/drivers/crypto/ti/dthev2-aes.c @@ -354,6 +354,11 @@ static int dthe_aes_run(struct crypto_engine *engine, = void *areq) u32 aes_irqenable_val =3D readl_relaxed(aes_base_reg + DTHE_P_AES_IRQENAB= LE); u32 aes_sysconfig_val =3D readl_relaxed(aes_base_reg + DTHE_P_AES_SYSCONF= IG); =20 + if (src_nents < 0 || dst_nents < 0) { + ret =3D -EINVAL; + goto aes_inval_nent_err; + } + aes_sysconfig_val |=3D DTHE_AES_SYSCONFIG_DMA_DATA_IN_OUT_EN; writel_relaxed(aes_sysconfig_val, aes_base_reg + DTHE_P_AES_SYSCONFIG); =20 @@ -510,6 +515,7 @@ static int dthe_aes_run(struct crypto_engine *engine, v= oid *areq) if (ret =3D=3D -ENOMEM) ret =3D dthe_aes_do_fallback(req); =20 +aes_inval_nent_err: local_bh_disable(); crypto_finalize_skcipher_request(dev_data->engine, req, ret); local_bh_enable(); --=20 2.34.1 From nobody Fri Sep 25 16:51:46 2026 Received: from mx0a-0002e601.pphosted.com (mx0a-0002e601.pphosted.com [148.163.150.75]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 04C52439F99; Thu, 10 Sep 2026 10:43:18 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=fail smtp.client-ip=148.163.150.75 ARC-Seal: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1789037002; cv=fail; b=kVgXnpIV2i/nld2mq9uQvaUPyThbe9flDxJyl+cYZgNqHXHoxAZ6iCyKGGn1FzJPDjiZHt+15ah+io2ao/OH+p1IbWbGKk+7Ep2AZ1FGNBnG1vJbof4tmDYcqB7yl/RY6axebDSoUAs9Ph8ajOoG3MnYNZauDwMH05jbsicPii8= ARC-Message-Signature: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1789037002; c=relaxed/simple; bh=8AiEGfb8lJzH+XTUake6thyKV3Zd4kzDjnDYuThYIjo=; h=From:To:CC:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=aXmOaDjKfmD+ICaPHI2PPN7USChHTgsL69efShXmRVH2yzUNE24zt4K0pIMChRRK8omsKEj3qQhEv9+DdkeszmRCXykdknxECQUalwTQrBqB6FZqdsCMba+Sr5RuQD0sPNtlfkGr1a4B18p7AGgWTnQTgdMdTHIow+33smmNlxs= ARC-Authentication-Results: i=2; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=ti.com; spf=pass smtp.mailfrom=ti.com; dkim=pass (2048-bit key) header.d=ti.com header.i=@ti.com header.b=K41BpiAW; dkim=pass (1024-bit key) header.d=ti.com header.i=@ti.com header.b=DwCeAyNE; arc=fail smtp.client-ip=148.163.150.75 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=ti.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=ti.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=ti.com header.i=@ti.com header.b="K41BpiAW"; dkim=pass (1024-bit key) header.d=ti.com header.i=@ti.com header.b="DwCeAyNE" Received: from pps.filterd (m0384305.ppops.net [127.0.0.1]) by m0384305.ppops.net (8.18.1.11/8.18.1.11) with ESMTP id 68A8oGeH712608; Thu, 10 Sep 2026 05:43:16 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ti.com; h=cc :content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s= proofpoint-05-2026; bh=w5beXwKfniW4zqbzhimEbX0XKyemxYErkY0Kg3dQT 7Q=; b=K41BpiAWxUsR/IvQkFewhm8XzkBLh07yO4tm9aqyPhZLi5CR0vUsS/5Ir 0G15EqCJF1oaZYIUOEJn4tglR/qbx619sjiqSXlBZYSftHwlZ1VHL3GKvFmZpFWG VcUIX4/+1aLwxxXDWWIkupRWVYJp/H/5Gf/wj4e8Bx8axnCJavTymMq24LS8MBgg fThmScMw1l8G/5PvC0dpU+E01XEKRm8iJK0qWlxvgUXZGH+nhhuaPgbNxSfD70sM H3hA3l7dgBV3tfRg0fGQtS8v+Scjig22u8gEEBqnTCnZ7zIM30KLQVKNSLYqox8M Cl6Zrvm+kB91sc+c93gCf0ndSH9aA== Received: from dm5pr21cu001.outbound.protection.outlook.com (mail-centralusazon11011044.outbound.protection.outlook.com [52.101.62.44]) by m0384305.ppops.net (PPS) with ESMTPS id 4gkcxgcny4-1 (version=TLSv1.3 cipher=TLS_AES_256_GCM_SHA384 bits=256 verify=NOT); Thu, 10 Sep 2026 05:43:16 -0500 (CDT) ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=wySa/2ah0ukzN4U/7RtZlusKs6DzCtUboVNj0Vy5nmh01PxTqJQNc/TzmR2vDAKUb+gjKtK9+PG1H1ZgMqzfQfPZLyc4ID/PtsO+eI0ER/WYYhXmn441BmQJXRXbn7feq9PuUuxdA9Y87tjMNP0jnA/U/YJvDXdMuEHlkjIVpBeQhnBf5nk4j5q4DD/uJljlwwZ5PtJ7I6Q6jLl4gTAJqwmgnqmCGqAu8/j0W/y/3NlLfvpRuGvi9lXM0UzzxKiLzM27sE5J/ol5fyfUs4CHrxsM96s0h6fu/J5OMLrJhdLSRO+j8n+lZ8FQsBCqKScCEgH5wDoE8tuVMl2DHfq7Gw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=w5beXwKfniW4zqbzhimEbX0XKyemxYErkY0Kg3dQT7Q=; b=Qelfp5ZmrZYGfO+RFDm068TnBbyGqhhwLwEhDo4+KrYH0y4wuIwVQghUzT38lqOXWk7Q9ZtWjejcUYSvyArblDm2g2HV1We0rUo2VNRgAaQYDiQVrlwc2QNISWjvfKWNqrTgdSOMmv8ww3XifBz3y7IHJTEWOtZZv87gA7y3UhzIMxh4OAc3HcqkH2Sxc0BWyFYfsGyvi59vj9nWN+MS85F0oVYalskIFBplcPVSeus7qL5YuFsJaLFfQZFode81jrk0ZsisQrJ2SXne5FRRRl6Lmf280cRj1y8jApwDmDerlR02VNSGXfmwUJqZsFVbYqJUaen4i9JEJLg18UDSTA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 198.47.23.194) smtp.rcpttodomain=gondor.apana.org.au smtp.mailfrom=ti.com; dmarc=pass (p=quarantine sp=none pct=100) action=none header.from=ti.com; dkim=none (message not signed); arc=none (0) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ti.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=w5beXwKfniW4zqbzhimEbX0XKyemxYErkY0Kg3dQT7Q=; b=DwCeAyNE3ssHdD5R3QNGb4DY2uN6PoZ7MseTx1jF9/ihvJv0h2j+fgzRseeOy4/kVdatXloBvEkKm4dCDbrGCHystegqgS/wpDxBAwnf0DyQDP5g8Ll4hi6FhOfZAaVgpuGrdw1SJc3A3Yo9wc0AHUq9NgFGSA/ExOnCmqaudTM= Received: from SJ0PR03CA0168.namprd03.prod.outlook.com (2603:10b6:a03:338::23) by CH0PR10MB5034.namprd10.prod.outlook.com (2603:10b6:610:c9::21) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.21.382.10; Thu, 10 Sep 2026 10:43:14 +0000 Received: from SJ5PEPF000001E8.namprd05.prod.outlook.com (2603:10b6:a03:338:cafe::ad) by SJ0PR03CA0168.outlook.office365.com (2603:10b6:a03:338::23) with Microsoft SMTP Server (version=TLS1_3, cipher=TLS_AES_256_GCM_SHA384) id 15.21.406.7 via Frontend Transport; Thu, 10 Sep 2026 10:43:14 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 198.47.23.194) smtp.mailfrom=ti.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=ti.com; Received-SPF: Pass (protection.outlook.com: domain of ti.com designates 198.47.23.194 as permitted sender) receiver=protection.outlook.com; client-ip=198.47.23.194; helo=lewvzet200.ext.ti.com; pr=C Received: from lewvzet200.ext.ti.com (198.47.23.194) by SJ5PEPF000001E8.mail.protection.outlook.com (10.167.242.196) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.21.406.5 via Frontend Transport; Thu, 10 Sep 2026 10:43:14 +0000 Received: from DLEE213.ent.ti.com (157.170.170.116) by lewvzet200.ext.ti.com (10.4.14.103) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.2562.45; Thu, 10 Sep 2026 05:42:56 -0500 Received: from DLEE213.ent.ti.com (157.170.170.116) by DLEE213.ent.ti.com (157.170.170.116) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.2562.45; Thu, 10 Sep 2026 05:42:56 -0500 Received: from lelvem-mr05.itg.ti.com (10.180.75.9) by DLEE213.ent.ti.com (157.170.170.116) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.2562.45 via Frontend Transport; Thu, 10 Sep 2026 05:42:56 -0500 Received: from pratham-Workstation-PC (pratham-workstation-pc.dhcp.ti.com [10.24.53.205]) by lelvem-mr05.itg.ti.com (8.18.1/8.18.1) with ESMTP id 68AAgtH63150518; Thu, 10 Sep 2026 05:42:55 -0500 From: T Pratham To: T Pratham , Herbert Xu , "David S. Miller" CC: Sebin Francis , Manorit Chawdhry , Vishal Mahaveer , Praneeth Bajjuri , , Subject: [PATCH v3 09/12] crypto: ti - Validate sg_nents_for_len() return value in DTHEv2 AEAD Date: Thu, 10 Sep 2026 16:11:59 +0530 Message-ID: <20260910104202.1537226-10-t-pratham@ti.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20260910104202.1537226-1-t-pratham@ti.com> References: <20260910104202.1537226-1-t-pratham@ti.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: SJ5PEPF000001E8:EE_|CH0PR10MB5034:EE_ X-MS-Office365-Filtering-Correlation-Id: 7eba3ee3-c394-4100-90bb-08df0f285101 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|82310400026|23010399003|1800799024|36860700016|376014|56012099006|10067099003|18002099003|22082099003; X-Microsoft-Antispam-Message-Info: jrt289kBdkp010SxejUXZKP627r+SPlq4tmvJLH6pdYCbR9xvz+xSo+/FKzr04ws9Vi0p5aOquXsSZ4pXZ0BvZ8QMqePihDOGd+sejcYIeDOitu0aKbVP8EbaC2ZAF8XaCGICiQZqD6o26HtKg9KQAhUq2Qp1ZTN+My2ZyIuIf7maCGMHVl05kq9JCe4suqqDLJLSyTGZwVcvVQtIoabXN05BH+N+MhBA4RTLwyD6dx63VA+wIh2HGY36inaHi9JZGi0/gOAdqiAjj09S6HWiRhLPm79b9YjhldWctUPbyqAf1KqIf5HzrOfBVkCWurA9X0gioErpuiTySeHjI/Zv4UPQZ8ofcajuW1rtUBaoqTJs555EWJP30jkUjVjKgDV9DQf+5+5JyjTlNeECGw9TL1ZE0cbHMCWrZnOPCqopUhnCjMLnG3JRtQumizPjG6TXNj4WkRbBoa5+yrHM3T37mACB5Uld8cNCiuLNF7SSkDXj4j2hw4jVwpyLpHxsLvSB108RQEJ/5gcj7mbeTiGVZV1DpcPa29YKC0CUz0QON+TNtq/IP3Ls/IHUyl6dvwigRsN0TXjHeCmvgXzsih3iGQ7oNUy1Gc1U8U5X1gs5QiuVmYQmm+KhxtdRQ27s39P+NhEwvH7XJh/lNLYxXprijghXgsOJFAyYnhNsp27DuHGav+q+A3EpRIpBFpJHIg0E52GzfKrBpu+oDaRFQui8A== X-Forefront-Antispam-Report: CIP:198.47.23.194;CTRY:US;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:lewvzet200.ext.ti.com;PTR:InfoDomainNonexistent;CAT:NONE;SFS:(13230040)(82310400026)(23010399003)(1800799024)(36860700016)(376014)(56012099006)(10067099003)(18002099003)(22082099003);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: RqK/7zBxxnfOD1gAYphErnbvFUbAD/Lf5o99IRkoNClLhDff3qj24qb9Gt75YQYSQBGxeXO62qv8ESobS1dXGbfvuL8H7KgupeDyhI1ZwZWo8HvbKhoCNKq4uOOTyIt6h2dDyS1S3RQW2UB/vV9paahrqrFWABPn8Dsc3djN7XMemHT+nAWAMWC9ylqPZs/iM/2tvFkq4mgHn/8mUuh9wToZVqSNxL65UCMab300Lp+vvbw6EYn0oSpnSLFizYyxekIzCgRW8HebW4Kg5mFgQnflYpwfFY2N3NM8ELbDoWwwDdsIpH1gboNCyiQOoKKRhlPT6We+WqkFyoq1XEF0Q+HTxbN4V47OOEehiz0uly4WlubOOm0BLSi6eGiORpqLURzksAZrfuJDi0m+1W6lRHVBgoBvgfYAjRya3DC7voXnWziWhkeVsE8//fUp0ia4 X-Exchange-RoutingPolicyChecked: WAMPNP4L5Om3AAaei+wo2SB0Vl/DBJVgrKAl+WrHvU8G2uGLsBEYMQV2Oz361xSFHGcsyA3uSzZnLdnBNtnfmmPC8hzR3//9Ijb2CTbb4HAuy1rLAOSReINQAOol8XLJaW48Q+Ztiroa1ylhHld9Ul+GtLpMYVEqljAPNUry2yBSHnbr0eG8ZtgVNNZP/R//9XI0SK1/APdzzVuD35RpnP6Q9oMsLzk/3G+TJJKRLruXb477KNri3w3C5M80RqVNpVGQNjdDoXJ7rF0T7MAjZh/iEYeE742s9f5pmhu79k5hW7CuwHeBQBKHhQbmG0nDMhXeCwtLrpdzG+Pz9MoiiQ== X-OriginatorOrg: ti.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 10 Sep 2026 10:43:14.0655 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 7eba3ee3-c394-4100-90bb-08df0f285101 X-MS-Exchange-CrossTenant-Id: e5b49634-450b-4709-8abb-1e2b19b982b7 X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=e5b49634-450b-4709-8abb-1e2b19b982b7;Ip=[198.47.23.194];Helo=[lewvzet200.ext.ti.com] X-MS-Exchange-CrossTenant-AuthSource: SJ5PEPF000001E8.namprd05.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: CH0PR10MB5034 X-Proofpoint-ORIG-GUID: YBtjy7S0r45S8gLkHjrEXNdaFl-6DLSl X-Proofpoint-Spam-Info: AW1haW4tMjYwOTEwMDEyNCBTYWx0ZWRfXyx9TGpyz1Pie /1ZBLgUd5BXoOmzaJhR5rpB2MJwl1r9QYqjdGMdhng+ZQw7HvQbWFwfxPdYKE9PHJV+js4onoRg 7iovCy0eqdIqA+R5e6HJd1B0ZBlGyvo= X-Proofpoint-GUID: YBtjy7S0r45S8gLkHjrEXNdaFl-6DLSl X-Authority-Analysis: v=2.4 cv=MqbHeGae c=1 sm=1 tr=0 ts=6aa289c4 cx=c_pps a=Z1Yvi+W4mc/VVWckEa0YUw==:117 a=WotqVVQAdb04rnGuttW3Kw==:17 a=6eWqkTHjU83fiwn7nKZWdM+Sl24=:19 a=VdqzKS8jKosA:10 a=s63m1ICgrNkA:10 a=V5UXEbMT0ywA:10 a=VkNPw1HP01LnGYTKEx00:22 a=Z8NIEmU8O1QQgoT56wFK:22 a=taLDd7a_hP9WKsMzeGRc:22 a=sozttTNsAAAA:8 a=iMD6g9N4YQ2QoEUmFGwA:9 X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwOTEwMDEyNCBTYWx0ZWRfXyyf+x+9bIAh2 7VjTtRDeW8Pip5RkOiB4/k4aRxQa2KaV1CXIIxJTy2pjqU1CrQ0iNsFydvZwHweqXpCd1aZ+KPi 3Ggkq8qLgfoQrfdv38yLZZi5ka4/4iHTK6XbV5MJQU5KXv9siob6rfLGpktDWZPoUsWVVziBDne gFVXrLHAOxtZ8nFfHriWeCwVkyFdAVM52bIpFxDgZBX834ejdc05uZ7540+Lw/iL3dR7VP1eBOW JAxw9DL702KfO0N1u6r4PeB118uteMDobIiblU+uhUqPX8FlXDb496e+TeU+EVAKPBEvMvpUrwQ l5FylmXOvzvexC40uGXL1zHVEtVpy/+Pdck1d9Uo0JhSdxIOAYqr37VKIQoALInYpIHXbjdnkRw wtuprIb/g2dimcH34Cmfp2lEtbtXCc7e6/ssHlbZFMh/fM+zhS5IirTxvCuNTw6wb//em3jsFWN mlfYCzD/a7IeBFLcQHA== X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1176,Hydra:6.1.134,FMLib:17.12.100.49 definitions=2026-09-10_03,2026-09-09_02,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 clxscore=1015 impostorscore=0 phishscore=0 lowpriorityscore=0 priorityscore=1501 spamscore=0 bulkscore=0 adultscore=0 suspectscore=0 malwarescore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2609040000 definitions=main-2609100124 Content-Type: text/plain; charset="utf-8" sg_nents_for_len() returns -EINVAL if the supplied scatterlist is shorter than the requested length. Add explicit checks after each sg_nents_for_len() call in DTHEv2 AEAD driver. Fixes: 37b902c603042 ("crypto: ti - Add support for AES-GCM in DTHEv2 drive= r") Signed-off-by: T Pratham --- drivers/crypto/ti/dthev2-aes.c | 22 ++++++++++++++++++++++ 1 file changed, 22 insertions(+) diff --git a/drivers/crypto/ti/dthev2-aes.c b/drivers/crypto/ti/dthev2-aes.c index bc3591ec58a1c..65a53fcf80467 100644 --- a/drivers/crypto/ti/dthev2-aes.c +++ b/drivers/crypto/ti/dthev2-aes.c @@ -641,6 +641,8 @@ static struct scatterlist *dthe_aead_prep_aad(struct sc= atterlist *sg, return NULL; =20 aad_nents =3D sg_nents_for_len(sg, assoclen); + if (aad_nents < 0) + return ERR_PTR(aad_nents); if (assoclen % AES_BLOCK_SIZE) aad_nents++; =20 @@ -697,6 +699,10 @@ static struct scatterlist *dthe_aead_prep_crypt(struct= scatterlist *sg, goto dthe_aead_prep_crypt_split_err; =20 crypt_nents =3D sg_nents_for_len(out_sg[0], cryptlen); + if (crypt_nents < 0) { + err =3D crypt_nents; + goto dthe_aead_prep_crypt_mem_err; + } if (cryptlen % AES_BLOCK_SIZE) crypt_nents++; =20 @@ -756,6 +762,8 @@ static int dthe_aead_enc_get_tag(struct aead_request *r= eq) return ret; =20 nents =3D sg_nents_for_len(req->dst, req->cryptlen + req->assoclen + ctx-= >authsize); + if (nents < 0) + return nents; =20 sg_pcopy_from_buffer(req->dst, nents, tag, ctx->authsize, req->assoclen + req->cryptlen); @@ -777,6 +785,8 @@ static int dthe_aead_dec_verify_tag(struct aead_request= *req) return ret; =20 nents =3D sg_nents_for_len(req->src, req->assoclen + req->cryptlen); + if (nents < 0) + return nents; =20 sg_pcopy_to_buffer(req->src, nents, tag_in, ctx->authsize, req->assoclen + req->cryptlen - ctx->authsize); @@ -973,6 +983,10 @@ static int dthe_aead_run(struct crypto_engine *engine,= void *areq) if (assoclen !=3D 0) { /* Map AAD for TX only */ aad_nents =3D sg_nents_for_len(aad_sg, assoclen); + if (aad_nents < 0) { + ret =3D aad_nents; + goto aead_dma_map_aad_err; + } aad_mapped_nents =3D dma_map_sg(tx_dev, aad_sg, aad_nents, aad_dir); if (aad_mapped_nents =3D=3D 0) { dev_err(dev_data->dev, "Failed to map AAD for TX\n"); @@ -994,6 +1008,10 @@ static int dthe_aead_run(struct crypto_engine *engine= , void *areq) if (cryptlen !=3D 0) { /* Map ciphertext src for TX (BIDIRECTIONAL if in-place) */ src_nents =3D sg_nents_for_len(src, cryptlen); + if (src_nents < 0) { + ret =3D src_nents; + goto aead_dma_prep_aad_err; + } src_mapped_nents =3D dma_map_sg(tx_dev, src, src_nents, src_dir); if (src_mapped_nents =3D=3D 0) { dev_err(dev_data->dev, "Failed to map ciphertext src for TX\n"); @@ -1014,6 +1032,10 @@ static int dthe_aead_run(struct crypto_engine *engin= e, void *areq) /* Map ciphertext dst for RX (only if separate dst) */ if (diff_dst) { dst_nents =3D sg_nents_for_len(dst, cryptlen); + if (dst_nents < 0) { + ret =3D dst_nents; + goto aead_dma_prep_src_err; + } dst_mapped_nents =3D dma_map_sg(rx_dev, dst, dst_nents, dst_dir); if (dst_mapped_nents =3D=3D 0) { dev_err(dev_data->dev, "Failed to map ciphertext dst for RX\n"); --=20 2.34.1 From nobody Fri Sep 25 16:51:46 2026 Received: from mx0b-0002e601.pphosted.com (mx0b-0002e601.pphosted.com [148.163.154.28]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id AEF4B45C6E5; Thu, 10 Sep 2026 10:43:22 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=fail smtp.client-ip=148.163.154.28 ARC-Seal: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1789037007; cv=fail; b=oUPOhwmipy5UB1bBYYkjEPah950QVgoL/dvoDVcOqFsP/j+BtyTku2cFFVNdtSCqQa4NpSjl3+x6HE/HL5V5uSpSVQ4Ie0mupvrsM+jLYuNehekN7GaeEBv0iDhxBVw67G7kCvOAEE4Vw3RcBIGhzkg9hZ2pILy1Gr2UeGG4cxs= ARC-Message-Signature: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1789037007; c=relaxed/simple; bh=6RV17K+dOkVeshFmshHqF6sMCwCc25grQ5kOysr9CGI=; h=From:To:CC:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=YzdWX/ocmShztTRErw7S+NMHH6YXd+b3IHiRUFq00WpyHDNpLQNfTBUKxBUIHlVKz4TjG6o/dL5o79xbwC5rP6XSsLFK+Izq0t2YJhZ5X/5K70zuXI3BZvXxFqxPDnGzABCXh/0Fd21d6bP7fmsVkju9T93219C/zyQgilAhKd0= ARC-Authentication-Results: i=2; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=ti.com; spf=pass smtp.mailfrom=ti.com; dkim=pass (2048-bit key) header.d=ti.com header.i=@ti.com header.b=qv6u5+ep; dkim=pass (1024-bit key) header.d=ti.com header.i=@ti.com header.b=eqR7DMHq; arc=fail smtp.client-ip=148.163.154.28 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=ti.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=ti.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=ti.com header.i=@ti.com header.b="qv6u5+ep"; dkim=pass (1024-bit key) header.d=ti.com header.i=@ti.com header.b="eqR7DMHq" Received: from pps.filterd (m0374955.ppops.net [127.0.0.1]) by mx0b-0002e601.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 68A8oUKR2934041; Thu, 10 Sep 2026 05:43:17 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ti.com; h=cc :content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s= proofpoint-05-2026; bh=3Hbdg4pI7uZrAjMnu5fvtSkbjxE49GEKGFuOUs0rp ss=; b=qv6u5+ephxOKtr5p/H7JZ5opSzEfGDfbFjaeXCYNlXQv0q+pmkwfoctu1 w7X0TjmkTKD1zweANQmy+etts6qBKPl3xbkWkzTcu0e8Pue+wwJJkzKwFXa22dFf nAPav9rV1kW+Zw+hxSAFHcs4KWVORXyClXzPHaigLiqPE3Ul5ZHxvPaX2raLWrht wigvBnYGtbM/p6Jpm/sbukOhDmdiztIXh9PbHoJwOPdstIWFjfied1UL85kJZP8z pxffZehCXXmtXqk58SPiJShf1FjE6JZCMllOJEWQGfPuYj4h9GVSG9OaeCmcdIdO IuCliWm3rlziBF7ZPECzwrV5arFJQ== Received: from sa9pr02cu001.outbound.protection.outlook.com (mail-southcentralusazon11013003.outbound.protection.outlook.com [40.93.196.3]) by mx0b-0002e601.pphosted.com (PPS) with ESMTPS id 4gkcxg4xk3-1 (version=TLSv1.3 cipher=TLS_AES_256_GCM_SHA384 bits=256 verify=NOT); Thu, 10 Sep 2026 05:43:17 -0500 (CDT) ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=nV7kgUd/iPe/FIqeOeE8zhcMuXhMsJ3DJ4BEOtcejizCDhR9DRdYtOYfCyL05TyrJGNrZveL4co8pO4y1SccRguv/Hs7wrbDherbzaN+12S97SsQFr8a0Y5LfNk7uhLa44izauEhHiKPUjQcdBZpGB45DEBcCefY4UNzgO1dE1+RGUReuw2zteWPDyT/m/zCjAbyO+G9ExZ4GlrXkyP1J+pMYWgZ7A81MtE0lacv8P/vG0euhSaeU+qWtuHfsD4TkOhr7d+xG3ni0OZFihswKltfeBD+Flzh5WCIDxh6+OG9qrRk8dUQZaJLIBHnyaLGyj7SzqaWjKL0AOeBu+Kd8w== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=3Hbdg4pI7uZrAjMnu5fvtSkbjxE49GEKGFuOUs0rpss=; b=LsR31ruXYNPFabbs/7Nr165H7UDMDqzO21nEUlGUuSmuth0zDy+BesJUP169HJNo0uAV6c+qFKX//vaeDtBiYDlZonpo9fkSGfKentlYHJeubBez4myCFff88zFGZ68vOu/cUAvecnkGgd4jUfaeVxC2Chg0En8kZC+TP8FMpLceaF0l9ml5VuxYi5+tKBSb5FCaON413d6xb7kwEHju3/DNEu7S2hJy0WhkSxxqjnMcMTb+QhLRYqUl87sqsbYKcoKyolyMNSe9sboYtJ5VFnRYKgyhuSdk/LHduCWmLy/IEyWR8xuAAP8001u7gO64rW1NkPESR0DTIZwJdxuOGg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 198.47.23.194) smtp.rcpttodomain=gondor.apana.org.au smtp.mailfrom=ti.com; dmarc=pass (p=quarantine sp=none pct=100) action=none header.from=ti.com; dkim=none (message not signed); arc=none (0) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ti.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=3Hbdg4pI7uZrAjMnu5fvtSkbjxE49GEKGFuOUs0rpss=; b=eqR7DMHqNyvINN+dByxK8V3pRwt9qaiHev7T16Gve+kU6UY9vIC/7MlmmtuJDMK0FdB/vTWIBRV5cyFhKfnEp7IHXKhEabwG1dJNXQv9IGi7ZXxHoiw8WNazcyiXXB2UokNgHmapaXVlq3agM0dQ7SL5CEbiV9aefW8JiXr+/rw= Received: from BY1P220CA0022.NAMP220.PROD.OUTLOOK.COM (2603:10b6:a03:5c3::14) by BL3PR10MB6212.namprd10.prod.outlook.com (2603:10b6:208:38c::13) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.21.406.7; Thu, 10 Sep 2026 10:43:15 +0000 Received: from SJ5PEPF000001EF.namprd05.prod.outlook.com (2603:10b6:a03:5c3:cafe::61) by BY1P220CA0022.outlook.office365.com (2603:10b6:a03:5c3::14) with Microsoft SMTP Server (version=TLS1_3, cipher=TLS_AES_256_GCM_SHA384) id 15.21.406.7 via Frontend Transport; Thu, 10 Sep 2026 10:43:15 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 198.47.23.194) smtp.mailfrom=ti.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=ti.com; Received-SPF: Pass (protection.outlook.com: domain of ti.com designates 198.47.23.194 as permitted sender) receiver=protection.outlook.com; client-ip=198.47.23.194; helo=lewvzet200.ext.ti.com; pr=C Received: from lewvzet200.ext.ti.com (198.47.23.194) by SJ5PEPF000001EF.mail.protection.outlook.com (10.167.242.203) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.21.406.5 via Frontend Transport; Thu, 10 Sep 2026 10:43:14 +0000 Received: from DLEE210.ent.ti.com (157.170.170.112) by lewvzet200.ext.ti.com (10.4.14.103) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.2562.45; Thu, 10 Sep 2026 05:42:59 -0500 Received: from DLEE205.ent.ti.com (157.170.170.85) by DLEE210.ent.ti.com (157.170.170.112) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.2562.45; Thu, 10 Sep 2026 05:42:59 -0500 Received: from lelvem-mr06.itg.ti.com (10.180.75.8) by DLEE205.ent.ti.com (157.170.170.85) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.2562.45 via Frontend Transport; Thu, 10 Sep 2026 05:42:59 -0500 Received: from pratham-Workstation-PC (pratham-workstation-pc.dhcp.ti.com [10.24.53.205]) by lelvem-mr06.itg.ti.com (8.18.1/8.18.1) with ESMTP id 68AAgwTK2178195; Thu, 10 Sep 2026 05:42:59 -0500 From: T Pratham To: T Pratham , Herbert Xu , "David S. Miller" CC: Sebin Francis , Manorit Chawdhry , Vishal Mahaveer , Praneeth Bajjuri , , Subject: [PATCH v3 10/12] crypto: ti - Terminate DMA on all error paths in AES to clear descriptors Date: Thu, 10 Sep 2026 16:12:00 +0530 Message-ID: <20260910104202.1537226-11-t-pratham@ti.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20260910104202.1537226-1-t-pratham@ti.com> References: <20260910104202.1537226-1-t-pratham@ti.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: SJ5PEPF000001EF:EE_|BL3PR10MB6212:EE_ X-MS-Office365-Filtering-Correlation-Id: 18d785f8-6895-49b7-7616-08df0f285179 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|82310400026|23010399003|1800799024|36860700016|376014|10067099003|56012099006|22082099003|18002099003; X-Microsoft-Antispam-Message-Info: VSSdZp1mm+jPlVbTQuNd9xRGhZ5m2YjLH30aXoWEsf7Zzn+jLEVBYopRWbHUpDy5PXPrIRg77fruW77MAN6/ZVcePV+JBgJv/IQ8IPo2cqinAcMPeTDotO4wPnxl4HKT0Cmg5NJ6GFg1evagSxkvc4dMkoVVdZqC9WNkI6jpP7qxb5dOu18Cm702o6QzOFDrum2YiGldgZswuFxf80yyUKuHcuer0jF8OJUOLJ7wOCj7ZBZpNk7SoqhTNfHW+esE1a5Jf1U2ay4gAY4L7203CuJa6FHei7YZGB3k5VrygZvbWRKFqp4LC5mVmXKNBroEoUhGKpMzpqKYbYhIH9DuGmKpvY9DXgd886TAhijslwkBSpCbGlGtBzuEiDSef406D06XNaUGis1ovq2HBdFseKlXpKLdK6/AYYiW1Z0uclZB5YEYljPy7de31CpmsNtRm9/UiQEvptvHOEN5W3NpJASf0wSjUVpwJ/NlNwNPPG8jtgtIc6TK5s9CSiyKsIWaRw2czqCE0EJdnbCq7DlLuW6O0YsUTmHqJCdCArVBXy/hWtKQc/euxSEsaTKaMgOU4Y3uc8RZkk+yd69DZjzfJjLyY2GYM3ErIq+rbXe8e7grsLBR/iuXDNPFY37he14r7+Pm7ayXXqb+SC31fDzAULmGTF3TfKBjy/C+7IZQPz3wy/7upNh7c0eaNcK92j+aWFmRPER3qjON2FqO8Y3R6w== X-Forefront-Antispam-Report: CIP:198.47.23.194;CTRY:US;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:lewvzet200.ext.ti.com;PTR:InfoDomainNonexistent;CAT:NONE;SFS:(13230040)(82310400026)(23010399003)(1800799024)(36860700016)(376014)(10067099003)(56012099006)(22082099003)(18002099003);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: ja4DpMowgpwUzrL4CzcKR8alPhC4b3TTrsePgr7IR440C5Y6LyltMBVMjozVzxcxDDHlwme4sC41kGwvGESFyT+Jnvx2fMfchOd77eZazk2NMVkruwROIfmSRERM1OU6pKuG+tzJw804gXcYscJDz80H8+qHPuccQCkHtv9fo4xZYnZMa3FKPaQ9XIfVCr1JAb9RBEdbdVS8cynJbpcB0n/G0B2JjxLSEqNShxclTFruLlAUv4EmKc1XAuTOJaJMcj4+d24oEFgLVfMmXDqVVfyrzZ0b/pl3nK1bINCYXa42AkqGituigP5NFRy6NvuHrfiMr99dxCJfw+06SzZwXI/yCW7t/orn75C12vsCLKjwcf+4m2MCYP28HaxQ3Bjvz37+QunNfv6U6pNGH3ja3EOCB4xDkAMd72FQAnl7DzY8uNkFj63YP6A834SMZfzD X-Exchange-RoutingPolicyChecked: OMRMzlBx9eqnGl/i/isglZsBlaprLFawRoA2sOngGf9oAFGYMSk5Q3niH+5oItBjY4IZk0GXhE7yCo/ccN/6gwVo/xvXfb4gX6MTuEywsrVHaSkO89jGBbUMlF84vrmTFzvjBMutDA/Ogl7fD6q96ewzL+cINHzFz4sRNgEc7qg4eTKPxNEiy34keVxlLbFkBiJ0c3eh1JLR0yR6MbzHeY9eGXIPK+X4aTdytEI10rk2YUAmCkyp8Dj+JpHk0gqaGdncONFe/9SvQuHsVM2+Bgt+o+QtznE3XBj+j8zFpkQQxFSIWYvWA3QTS4OcnFm8TaOSAHuTJUdukQeyubymug== X-OriginatorOrg: ti.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 10 Sep 2026 10:43:14.8531 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 18d785f8-6895-49b7-7616-08df0f285179 X-MS-Exchange-CrossTenant-Id: e5b49634-450b-4709-8abb-1e2b19b982b7 X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=e5b49634-450b-4709-8abb-1e2b19b982b7;Ip=[198.47.23.194];Helo=[lewvzet200.ext.ti.com] X-MS-Exchange-CrossTenant-AuthSource: SJ5PEPF000001EF.namprd05.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: BL3PR10MB6212 X-Authority-Analysis: v=2.4 cv=MpPHeGae c=1 sm=1 tr=0 ts=6aa289c5 cx=c_pps a=rjhVvYU/dOM9ArBm263f9w==:117 a=WotqVVQAdb04rnGuttW3Kw==:17 a=6eWqkTHjU83fiwn7nKZWdM+Sl24=:19 a=VdqzKS8jKosA:10 a=s63m1ICgrNkA:10 a=V5UXEbMT0ywA:10 a=VkNPw1HP01LnGYTKEx00:22 a=Z8NIEmU8O1QQgoT56wFK:22 a=fPAWb5peG099m5CrUpKH:22 a=sozttTNsAAAA:8 a=T1XiGUNGXxSxoSVzcpQA:9 X-Proofpoint-ORIG-GUID: qArhscTXmZLvO5Z9icu40gjFOLzqi2Wd X-Proofpoint-Spam-Info: AW1haW4tMjYwOTEwMDEyNCBTYWx0ZWRfX6zxSVKi+CkCH z/CtaZFj1ZWPFqzPYDtG4btRPmN9BprGiLMerSAXdjobH13VroE1v5XLbO2QPGzMCFplSgxcZ3w e/18KGpZFAtzjcknhWt1bSpG0lqVIiY= X-Proofpoint-GUID: qArhscTXmZLvO5Z9icu40gjFOLzqi2Wd X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwOTEwMDEyNCBTYWx0ZWRfXy1AhFu4+6a1M SMlgQDkiERrKdTy3in9LKC9VVIDyIvYDq1cy/FCBPU5kiF1fS4aAVbkEpJo2QR6SOm31ZpySe60 1dqft5cHZcinSPR1y0JM6Y8IcjASNb9lHPWjfKjtZ5B1h5KCi3fi655Yn3w8iCMBr+/fMPk3piW 7nVJymtrHhmn3CGxsqiTXtyp1ClL7Yx9VdprLIuqgNiDCHPI25Yp/TpXEfHys5LKzYEbFvsL/FW Ni+E5dLQu+P95zMRzUPnFBRz/y9JbYPsD+FH2hk/7jViUd3EBbBQh6RSI7i0Sz6QDqAevNzOkth AGHLsrZS4Y/rDiDmWxmqXX5HA3Rjh3xyBKJ6vXO9fWiX4zBYB1XBQRU5YgxB/W7rQvfvoHh4AqC cXSmrAklMdIUzxEpHnB+Ot0Pz1CbeH+YHep26q2AAWDnTQNi0bMVFdMgIqB6yfP7sFHYiJANii7 IEbrVhIeE74pV+UFS7g== X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1176,Hydra:6.1.134,FMLib:17.12.100.49 definitions=2026-09-10_03,2026-09-09_02,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 priorityscore=1501 lowpriorityscore=0 adultscore=0 suspectscore=0 malwarescore=0 impostorscore=0 phishscore=0 clxscore=1015 spamscore=0 bulkscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2609040000 definitions=main-2609100124 Content-Type: text/plain; charset="utf-8" dmaengine_prep_slave_sg() allocates a DMA descriptor which is freed on either successful dmaengine_submit() or on dmaengine_terminate_sync(). The error paths after descriptor allocation was not clearing them, leaving the descriptors orphaned and leaking memory in case of failure. Add terminate calls in dthe_aes_run() to appropriately clean the DMA descriptors. Fixes: 52f641bc63a46 ("crypto: ti - Add driver for DTHE V2 AES Engine (ECB,= CBC)") Signed-off-by: T Pratham --- drivers/crypto/ti/dthev2-aes.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/drivers/crypto/ti/dthev2-aes.c b/drivers/crypto/ti/dthev2-aes.c index 65a53fcf80467..10073bbeca113 100644 --- a/drivers/crypto/ti/dthev2-aes.c +++ b/drivers/crypto/ti/dthev2-aes.c @@ -449,6 +449,8 @@ static int dthe_aes_run(struct crypto_engine *engine, v= oid *areq) if (!desc_out) { dev_err(dev_data->dev, "OUT prep_slave_sg() failed\n"); ret =3D -EINVAL; + /* terminate to free the orphaned desc_in descriptor */ + dmaengine_terminate_sync(dev_data->dma_aes_rx); goto aes_prep_err; } =20 --=20 2.34.1 From nobody Fri Sep 25 16:51:46 2026 Received: from mx0a-0002e601.pphosted.com (mx0a-0002e601.pphosted.com [148.163.150.75]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id D9A9A463B85; Thu, 10 Sep 2026 10:43:35 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=fail smtp.client-ip=148.163.150.75 ARC-Seal: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1789037022; cv=fail; b=R263L3kWg0sLjkZHEkMKes++sgYh4lYMQ+Ej9IYzI1qAtwD62PsXZwLLs9qRSQDdACj62CWErI9XBcLuYTWcTm3QS0zSUp9sqO2uSLSVTSQDfNKWUNkh12ST81UmqA4haqIUqasLfhuqZxc0qnBrKfVdctnbGGxve6txmOgF/nc= ARC-Message-Signature: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1789037022; c=relaxed/simple; bh=OuWkyrSAYLpUMGWtwqp0QtAQW2fMadEqcmQ2cP2XYgA=; h=From:To:CC:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=OLdQaIIPABcRyFI9u5F0a19RZGoejFa+UN8k8VHaqzS9x4G0m90rxXIg9A20JlLP/hEAE+WZVqqliyE0a6CohZd/16FfvRU2SUsybJd6rr/hPjIi4ya9MFGl189GUF35HGfs90ey75baobMmH4m2PCwI6RriyQMRuUUjylsvLg8= ARC-Authentication-Results: i=2; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=ti.com; spf=pass smtp.mailfrom=ti.com; dkim=pass (2048-bit key) header.d=ti.com header.i=@ti.com header.b=lOZ4wSrB; dkim=pass (1024-bit key) header.d=ti.com header.i=@ti.com header.b=i++KzF9Q; arc=fail smtp.client-ip=148.163.150.75 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=ti.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=ti.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=ti.com header.i=@ti.com header.b="lOZ4wSrB"; dkim=pass (1024-bit key) header.d=ti.com header.i=@ti.com header.b="i++KzF9Q" Received: from pps.filterd (m0380145.ppops.net [127.0.0.1]) by m0380145.ppops.net (8.18.1.11/8.18.1.11) with ESMTP id 68A9KLXu2786572; Thu, 10 Sep 2026 05:43:31 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ti.com; h=cc :content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s= proofpoint-05-2026; bh=kZD+OiTUMOfEPNZVRM9b0rd42p1/v7GDAJbNfg0tE ug=; b=lOZ4wSrBc+jAEHA6RbhOgiJzB36DdbvayZZuySbGrpUI6SQQuzKekDZqt JvWy+WuriNC7o4M+6+xeUhJBmq97kXiGViqiEpyadl/0UD6zptPrChnQXLWQU4cQ b50RotEJtvRA30dYInsCIqJVdSfpZJzzVBmw+G5vdPvcTbC3XGx7eTQI0gYxsUTc h1g8kD7Nsf3SPHmqP1jpLyIflob7sZYYLHkzuXDCbSPDeAtdJT3sfgVhYFn3vrJF v7Gvq2rgjf6ue54A2rw39mr4w+/npGdaFqgayHJXzldmtdIdhKxNTwh9gcOV+t+p 1unMZYm7/3jF+R3H4nXnCNRrIPU9Q== Received: from bl0pr03cu003.outbound.protection.outlook.com (mail-eastusazon11012058.outbound.protection.outlook.com [52.101.53.58]) by m0380145.ppops.net (PPS) with ESMTPS id 4gkstv8ba8-1 (version=TLSv1.3 cipher=TLS_AES_256_GCM_SHA384 bits=256 verify=NOT); Thu, 10 Sep 2026 05:43:31 -0500 (CDT) ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=goYMwk/pbML48Hv09fUGcCndUG3l8+yqhBpYzWW60b35Bp94iL2MZCn5R1jb0FyKuGuY7ROnFAipo6ZK/Sqm6k2FxGW3JLTtYJwVDECTgSSEs1C+1+Jc/qFnwB5xz//cLviUaNC4PWjyv3yW2gKAyl+EF6HrvejX9HaalXSjCNWskpJlDVO5ZFcdVf5FvNv71jOZ5J2ESd9sp4dEPwpsN85iEM3/VIjksUjIYrnJIaG34yuM0kHvZef8aC0EBxQe5lY/vzcCd6ipcgEhe1AA7o6+LZVoNkiUPSlga5KZGo+WgQmgVl5y39BsUBvCBWRCgcOxV1gSCfyZ2vXp08je9Q== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=kZD+OiTUMOfEPNZVRM9b0rd42p1/v7GDAJbNfg0tEug=; b=LFo/9kWKtVr2FVg9dPmFh6WXDwp5OyfR17AuGH/gZ9tv/zx99DpAmhYJ/KpfWZeEJzHTtAaWM4NMDNvfu8YzLGR6gwXPjTeba/6HHSa+KTL6Of2EKVuiauI6rFwaivZBkP66s+AZvZ/qak6DVgGgLax0Ellch7NyyQeT46nwLUtIAjETE7JqR99Q67ADePIR1eUUKw343dLPSqW3Z94PDPhoSscuKydJVI5TrqBStqAmzBaHYEc1u03S93paE+9ChmHGAYbzJdgoGM1HMI/QaCTfwAtbWmMvDFJspSxaztZGi8otdAyhTSFR4ZMW3mnxs7GCchstISHbAbfPZMCEuQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 198.47.23.195) smtp.rcpttodomain=gondor.apana.org.au smtp.mailfrom=ti.com; dmarc=pass (p=quarantine sp=none pct=100) action=none header.from=ti.com; dkim=none (message not signed); arc=none (0) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ti.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=kZD+OiTUMOfEPNZVRM9b0rd42p1/v7GDAJbNfg0tEug=; b=i++KzF9Q3rxmy8QU68RBw12bMlHKuCEpSdVrBsdgMl5fL8dCt1svooU4TvU2tI4h0ASSJ3SIh8C3VG+C1rWY8gyiQA+LECZ0MrSWCy9/P78MqoqROWp5lupvvu4ntUvQyBT424jpEkSILIiG9Uo15C86Ha0sKdBKp1nPFYWcGLk= Received: from BY3PR10CA0016.namprd10.prod.outlook.com (2603:10b6:a03:255::21) by DS4PPFC31902354.namprd10.prod.outlook.com (2603:10b6:f:fc00::d47) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.21.406.9; Thu, 10 Sep 2026 10:43:27 +0000 Received: from BY1PEPF000264B2.namprd02.prod.outlook.com (2603:10b6:a03:255:cafe::39) by BY3PR10CA0016.outlook.office365.com (2603:10b6:a03:255::21) with Microsoft SMTP Server (version=TLS1_3, cipher=TLS_AES_256_GCM_SHA384) id 15.21.406.7 via Frontend Transport; Thu, 10 Sep 2026 10:43:27 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 198.47.23.195) smtp.mailfrom=ti.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=ti.com; Received-SPF: Pass (protection.outlook.com: domain of ti.com designates 198.47.23.195 as permitted sender) receiver=protection.outlook.com; client-ip=198.47.23.195; helo=lewvzet201.ext.ti.com; pr=C Received: from lewvzet201.ext.ti.com (198.47.23.195) by BY1PEPF000264B2.mail.protection.outlook.com (10.167.242.118) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.21.406.5 via Frontend Transport; Thu, 10 Sep 2026 10:43:26 +0000 Received: from DLEE206.ent.ti.com (157.170.170.90) by lewvzet201.ext.ti.com (10.4.14.104) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.2562.45; Thu, 10 Sep 2026 05:43:02 -0500 Received: from DLEE205.ent.ti.com (157.170.170.85) by DLEE206.ent.ti.com (157.170.170.90) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.2562.45; Thu, 10 Sep 2026 05:43:02 -0500 Received: from lelvem-mr06.itg.ti.com (10.180.75.8) by DLEE205.ent.ti.com (157.170.170.85) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.2562.45 via Frontend Transport; Thu, 10 Sep 2026 05:43:02 -0500 Received: from pratham-Workstation-PC (pratham-workstation-pc.dhcp.ti.com [10.24.53.205]) by lelvem-mr06.itg.ti.com (8.18.1/8.18.1) with ESMTP id 68AAh15A2178264; Thu, 10 Sep 2026 05:43:01 -0500 From: T Pratham To: T Pratham , Herbert Xu , "David S. Miller" CC: Sebin Francis , Manorit Chawdhry , Vishal Mahaveer , Praneeth Bajjuri , , Subject: [PATCH v3 11/12] crypto: ti - Terminate DMA on all error paths in AEAD to clear descriptors Date: Thu, 10 Sep 2026 16:12:01 +0530 Message-ID: <20260910104202.1537226-12-t-pratham@ti.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20260910104202.1537226-1-t-pratham@ti.com> References: <20260910104202.1537226-1-t-pratham@ti.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: BY1PEPF000264B2:EE_|DS4PPFC31902354:EE_ X-MS-Office365-Filtering-Correlation-Id: 14d52b36-2d0f-408d-cdb6-08df0f28588c X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|36860700016|23010399003|82310400026|376014|1800799024|56012099006|10067099003|18002099003|22082099003; X-Microsoft-Antispam-Message-Info: POPizgIvSve7bt8WdOq6TOYNXMjS+YQtSuqGr5luVv15tQviMTsI7s884CShmtG88+6XQKYDj9Wqtx6/yw7XTdTpgkPkN6Ukrjl2vb0XkHI0ocviiVpUOZuB9Q2HY+9b8T0ttQveC+8Ce1EBKg8q+gzKPbxwpX9s4j2uhwXjS6SVnutwfFMJypDNPOnvtaDzAsh7P+grAVy5SNwszgBebsmfnvki1vjcM1NzwU4V1VMn+b+6TYuHwEdCOTnnZrKkNlelIntFcHSJv43OR6sQNYJUbpVl5+qMweBlsIJNFWESoiqxRzAgP7r+S2oOYNPWSL+mk0PyQI0cL9kzIMT8P8pk7qopofPKTPKYrZ4gtd1VzbFfAqM6QxAVjzKn3ulNnKXgfvKxBEyQ+CGwMq4w0KCYRZGFdQ8wqZDujO8KhgJWiHnsVRUN2HEdy8P76esiexxEonnu04DsR0d46h+1dKZhHOwLnR1FRIzC0AaHgTG+BeckHVre54sp5jsTRlp680MELwXfpwnBczoEdFFKr8Cv2+QCQOcIGzaMq6lLGeiqKj2bX9JiOOrwWs08zkVSgKyvDu90I+x6cimtbF6c6aywlMd4YCDBw/Hif5Ma3CdhE9ZvBqLrEmRFSy02PRhD58fViP9/pYhNvx0HsQCjcNFK4DkXOYJyCJkyeL0D8QeWVMra9wFsmlgeWhpzSfC8AaoT9xv/9fZyuScSFx1lBQ== X-Forefront-Antispam-Report: CIP:198.47.23.195;CTRY:US;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:lewvzet201.ext.ti.com;PTR:InfoDomainNonexistent;CAT:NONE;SFS:(13230040)(36860700016)(23010399003)(82310400026)(376014)(1800799024)(56012099006)(10067099003)(18002099003)(22082099003);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: tuy/R1Dds9WQw8B3SDvxRocHjOkhnFuc+NXtxboxJla+3eSR1h3dFk2Lg/OdX9uYM5d3LECXp3pF1hbQeFhQB3AyXlcWhjw8gWUvI9q7G+lOirdTT+ttirRasGxWOji7lRFPJhszCrhS7+zht6dXtVpR48/Hf6DQuj4agnYOdrQbLrkc8oyPxZ+/jw2FfmVhkv0G7YU8EicKD9A2XHWGR7xD1quB5Ue3bVJHYSOZuKaMYgTlpM4vwOznGHKuks3TJzDNUZLOw6HCJ1y8oScfIk6dVJbK/JA5Q09hmVp5zrfBZaME8XIH0YcIKXmzA6S9trUZaqa9zu6jMKi4BV7J9cALWi+fbVf9Kd9kGzBHmkAsIVR4pmw0wPJTVFQXtIWu2SmOCnRBI0B2uAWqWPV0oHPWH7sDdIj9W9dq/pw7GV7hvmRnmwH8WKUms+J0FSwg X-Exchange-RoutingPolicyChecked: NaYvyFPvFfDvu8l5qFt6aiz7JJCZe3NNd8PtN9MMWiOQWFfBms79R124i6lBdLdbAu0wIWYd9Shn9KRqHcGRDur3YDF9ajmKSxYj7qUzwvdrNM1uPgRWVpCGyJV1TZcCn0y8cGjMK/VtitdzPxKzLvohi6QxRosJhHGb10glPLrtnJ6N5JKmAL2DvgKaBj/I1UIrMhhqMHagFLFD+bnoHpJq54VQkOJHfxR/21fuQAaaRBpP63AqSpWaGRsGa0oPe34EwWaUMOgrpoxnhX89cbB2rJ6iXhpiGMwwtvkefGdA7HZWPdmSjV+hsAnwLLmMjuHoGAC64s2/8kxQL4LkyQ== X-OriginatorOrg: ti.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 10 Sep 2026 10:43:26.7317 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 14d52b36-2d0f-408d-cdb6-08df0f28588c X-MS-Exchange-CrossTenant-Id: e5b49634-450b-4709-8abb-1e2b19b982b7 X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=e5b49634-450b-4709-8abb-1e2b19b982b7;Ip=[198.47.23.195];Helo=[lewvzet201.ext.ti.com] X-MS-Exchange-CrossTenant-AuthSource: BY1PEPF000264B2.namprd02.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: DS4PPFC31902354 X-Proofpoint-Spam-Info: AW1haW4tMjYwOTEwMDEyNCBTYWx0ZWRfX9Ufronlfocc4 0ncaaQAQaQtBdJEHWKq0V+gWeRv8HEwekug3uIajgY0DaSKI3odyAGNQY48AXHJzZ/hHhYh/1S7 Zm6zQ3T08xmQwTmzu10JmWnIwU6MX9s= X-Proofpoint-GUID: uvcbVPbigFN6wlx83RsitA2llsAXphrX X-Authority-Analysis: v=2.4 cv=VvG2kO2n c=1 sm=1 tr=0 ts=6aa289d3 cx=c_pps a=eaWElexNrpfURq8UtOOyIA==:117 a=f+v6EHfkeJbVwR46tk4DMg==:17 a=6eWqkTHjU83fiwn7nKZWdM+Sl24=:19 a=VdqzKS8jKosA:10 a=s63m1ICgrNkA:10 a=V5UXEbMT0ywA:10 a=VkNPw1HP01LnGYTKEx00:22 a=Z8NIEmU8O1QQgoT56wFK:22 a=gO1vWkAQAl3rybz1DQOp:22 a=sozttTNsAAAA:8 a=noPYQ3j_lezN9luSq70A:9 X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwOTEwMDEyNCBTYWx0ZWRfX3hyGviuLTS8Z SOYtrMovFfyv5Qm43PK3bL4bQmZRNPnHs/ihs2SOGqa/d5BQcXi6+Ww91TWAdy5C6mmQzSpl4Ry fZUvgkEi9wfRqWBG+er4Ej0sLJVetme1bTclSD8miBbha0zYDqDmJLoY0cc1s8AFLbt0MEwFy1z s6sg/Vy6cNQ77o+sg5uExypPdN6ooB/D7KRhE7jGYaIV99U3Ut+hP7Xq0eAT2Ap8d94xLC4AsUL Am1jWFgGepE6GXHRqw9jkp2/BPx59KNn7f6HDsRcjK4dYkAH36zXTmNkPuTHV4Gg2DArBsV9vtY WY2pDwwfmhkskgQqHFWTqAGGoi6WRXjUprPPhSPH7VMCavj+r1zkJRxvxos50yKQw+cxIcaY93k OqZLwnjSdNy41+OFPibCm+yDz9MjMKL5CuMDpup0cv8ZPMR9Y9Uno11EqkuxivznxsUdhj8jwCR ISZ4K+ASlk189MT1sTA== X-Proofpoint-ORIG-GUID: uvcbVPbigFN6wlx83RsitA2llsAXphrX X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1176,Hydra:6.1.134,FMLib:17.12.100.49 definitions=2026-09-10_03,2026-09-09_02,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 adultscore=0 bulkscore=0 lowpriorityscore=0 priorityscore=1501 suspectscore=0 malwarescore=0 spamscore=0 phishscore=0 impostorscore=0 clxscore=1015 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2609040000 definitions=main-2609100124 Content-Type: text/plain; charset="utf-8" dmaengine_prep_slave_sg() allocates a DMA descriptor which is freed on either successful dmaengine_submit() or on dmaengine_terminate_sync(). The error paths after descriptor allocation was not clearing them, leaving the descriptors orphaned and leaking memory in case of failure. Add terminate calls in dthe_aead_run() to appropriately clean the DMA descriptors. Fixes: 37b902c603042 ("crypto: ti - Add support for AES-GCM in DTHEv2 drive= r") Signed-off-by: T Pratham --- drivers/crypto/ti/dthev2-aes.c | 15 +++++++++++++-- 1 file changed, 13 insertions(+), 2 deletions(-) diff --git a/drivers/crypto/ti/dthev2-aes.c b/drivers/crypto/ti/dthev2-aes.c index 10073bbeca113..a034c1c8f20ed 100644 --- a/drivers/crypto/ti/dthev2-aes.c +++ b/drivers/crypto/ti/dthev2-aes.c @@ -912,6 +912,7 @@ static int dthe_aead_run(struct crypto_engine *engine, = void *areq) =20 struct device *tx_dev, *rx_dev; struct dma_async_tx_descriptor *desc_in, *desc_out, *desc_aad_out; + bool cleanup_tx_chan =3D false; =20 int ret; int err; @@ -1012,13 +1013,15 @@ static int dthe_aead_run(struct crypto_engine *engi= ne, void *areq) src_nents =3D sg_nents_for_len(src, cryptlen); if (src_nents < 0) { ret =3D src_nents; - goto aead_dma_prep_aad_err; + cleanup_tx_chan =3D (assoclen !=3D 0); + goto aead_dma_map_src_err; } src_mapped_nents =3D dma_map_sg(tx_dev, src, src_nents, src_dir); if (src_mapped_nents =3D=3D 0) { dev_err(dev_data->dev, "Failed to map ciphertext src for TX\n"); ret =3D -EINVAL; - goto aead_dma_prep_aad_err; + cleanup_tx_chan =3D (assoclen !=3D 0); + goto aead_dma_map_src_err; } =20 /* Prepare DMA descriptors for ciphertext TX */ @@ -1028,6 +1031,7 @@ static int dthe_aead_run(struct crypto_engine *engine= , void *areq) if (!desc_out) { dev_err(dev_data->dev, "Ciphertext TX prep_slave_sg() failed\n"); ret =3D -EINVAL; + cleanup_tx_chan =3D (assoclen !=3D 0); goto aead_dma_prep_src_err; } =20 @@ -1036,12 +1040,14 @@ static int dthe_aead_run(struct crypto_engine *engi= ne, void *areq) dst_nents =3D sg_nents_for_len(dst, cryptlen); if (dst_nents < 0) { ret =3D dst_nents; + cleanup_tx_chan =3D true; goto aead_dma_prep_src_err; } dst_mapped_nents =3D dma_map_sg(rx_dev, dst, dst_nents, dst_dir); if (dst_mapped_nents =3D=3D 0) { dev_err(dev_data->dev, "Failed to map ciphertext dst for RX\n"); ret =3D -EINVAL; + cleanup_tx_chan =3D true; goto aead_dma_prep_src_err; } } else { @@ -1056,6 +1062,7 @@ static int dthe_aead_run(struct crypto_engine *engine= , void *areq) if (!desc_in) { dev_err(dev_data->dev, "Ciphertext RX prep_slave_sg() failed\n"); ret =3D -EINVAL; + cleanup_tx_chan =3D true; goto aead_dma_prep_dst_err; } =20 @@ -1145,6 +1152,10 @@ static int dthe_aead_run(struct crypto_engine *engin= e, void *areq) aead_dma_prep_src_err: if (cryptlen !=3D 0) dma_unmap_sg(tx_dev, src, src_nents, src_dir); +aead_dma_map_src_err: + /* Free any descriptor prepared on dma_aes_tx but never submitted */ + if (cleanup_tx_chan) + dmaengine_terminate_sync(dev_data->dma_aes_tx); aead_dma_prep_aad_err: if (assoclen !=3D 0) dma_unmap_sg(tx_dev, aad_sg, aad_nents, aad_dir); --=20 2.34.1 From nobody Fri Sep 25 16:51:46 2026 Received: from mx0a-0002e601.pphosted.com (mx0a-0002e601.pphosted.com [148.163.150.75]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 21683468C12; Thu, 10 Sep 2026 10:43:38 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=fail smtp.client-ip=148.163.150.75 ARC-Seal: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1789037025; cv=fail; b=KyWC6GNv1rZybWJNBHP9aTfxaLuQWOBjVDJOgjOMYrZq8G394CeaaZ57+dVBIK1+i2M2Twkhc8jsiLsoSHn0uqm0ekOoGbq3Ny0xSaq+p+qxfSgfHucd6gBhCditOrjrdvdtGs/aEKR+RaDIu/AKtzFztJEZeIz4HUYAjIZ2fEM= ARC-Message-Signature: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1789037025; c=relaxed/simple; bh=rMIHH7q1HiGvJljbcET80ADog5KoEWbz8PeiVhRv+ks=; h=From:To:CC:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=ZBUBkLcIWQW6FmhCbpsfVGOALZ51oV7PQVPIoYZbvNbl8WVodqz8vHhat/BdsNHqADJlLFJKGTAw8g5lRzcZkN9DqnBrpaKVdjIdAs8Q4Oh3VxL3RUW50vsKezz4iZM307G5CoKQEdh4uGmROGnJcUdwmofX89uU1Pu9iW3yXGg= ARC-Authentication-Results: i=2; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=ti.com; spf=pass smtp.mailfrom=ti.com; dkim=pass (2048-bit key) header.d=ti.com header.i=@ti.com header.b=aShbBFVz; dkim=pass (1024-bit key) header.d=ti.com header.i=@ti.com header.b=omgudF/x; arc=fail smtp.client-ip=148.163.150.75 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=ti.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=ti.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=ti.com header.i=@ti.com header.b="aShbBFVz"; dkim=pass (1024-bit key) header.d=ti.com header.i=@ti.com header.b="omgudF/x" Received: from pps.filterd (m0384305.ppops.net [127.0.0.1]) by m0384305.ppops.net (8.18.1.11/8.18.1.11) with ESMTP id 68A8oIbU712662; Thu, 10 Sep 2026 05:43:34 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ti.com; h=cc :content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s= proofpoint-05-2026; bh=6E/G/PUZN0NxwZbEDin4ADqQv2DLFI8Xgpfze4sUr Gk=; b=aShbBFVzFmcyp8nWfShYy1XNjLp1W0gHtDWoJ1ZrO7vzuwZj/m0se4nI4 lgAGiT16oKGgbGTdgGPio7reSFDP6k3Mu4vyPiPQnPdaENfEk4xuYcwYzuLoJRLw zGgiqL9JIDgDA3Sbx7DAX/kQYQ26OgI0zy82DuBbXXTW1vzAIiV3AFrL/IGaztVc bfJiJXouI1rm98H/VEJ+cCR4VFTJjRCMUkATDSkrBP3L5W4eChBXcCZohh8ckcFf YocMlO/CwPXkx+f/kvoy36CpoDwvuPoDoQKygf6TpGUuF7IUMAl4kax/mocZgfko ulxDa8cOiunjUmN0In1YlYT6WAipw== Received: from sa9pr02cu001.outbound.protection.outlook.com (mail-southcentralusazon11013066.outbound.protection.outlook.com [40.93.196.66]) by m0384305.ppops.net (PPS) with ESMTPS id 4gkcxgcp0r-1 (version=TLSv1.3 cipher=TLS_AES_256_GCM_SHA384 bits=256 verify=NOT); Thu, 10 Sep 2026 05:43:34 -0500 (CDT) ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=fCioPxFAeHON3ATeq1IabP+Hp6SlAGTIuJ5DSkB3tZXCos4kkaGOgDS+Mo7IdZlBfR3F9LJchZSLCiZUGpjuSzyiv1lKm+9yEoOR70TrRERkSeOOYVurge7a7P9mny92YLbRdNnZftPvZsesiN5xktNS3tEO+7FTHynuHZt7Os0YBLET2NzcXrqasFrxNJ89/YV7GK6nsfaeK31SdPJmjLovFZByqaA2KkFjDnzEpSsFPESmXLospWBe5SihaviK2j8z5N7tK5a2Y6etqjFogpP1dtjOf3E8qBpAUxfRyi6MAIF2dnUSfGsP/q56QWf6ARLqpRB3q5GwzIWCkRB23g== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=6E/G/PUZN0NxwZbEDin4ADqQv2DLFI8Xgpfze4sUrGk=; b=fznWOHuF7A/QR6Krp12mLMNbe7POWY8Ygee32hC0/W222mnwFhYdBejGaAiEqU9vqsvLJGMKW3Vpqr7SwZzh5TBJ9JmPlkUX8jgQkpF2A6lSUdTMRmgPR9SJ+ttbyW1RPk8RprIaXJ8c8ucCyfOz8upZensX4Kj5NkuomMB+Wgs2KP29ncgmgxVTORjo8ggCCZg0/nfDOjx0xVAPDgcKib/TopgCZJF6PQ57JNOKr4mX6ODYQuw4dH3dTwSJCaiml9alLIWo+BswXJpHX9+H+e8vU4s/rxRhwZWs0cK0RT9a9fGb+ezz2XLRsX0tUUdRPcgYSdYRt9AcATzaAh0Zww== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 198.47.23.195) smtp.rcpttodomain=gondor.apana.org.au smtp.mailfrom=ti.com; dmarc=pass (p=quarantine sp=none pct=100) action=none header.from=ti.com; dkim=none (message not signed); arc=none (0) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ti.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=6E/G/PUZN0NxwZbEDin4ADqQv2DLFI8Xgpfze4sUrGk=; b=omgudF/xE2QIg/ifzE1NAZJRk6DEHGGlKa642Lb76EpYSlHJMXeJL2RHsuPrwUpSpUXAq8EJF5EVmtS+QXQO37PbM+ZEaij6mZwMHUxLMQWiezoWdnMRojehrkSkdIHMPn3Cc8X9Xj3f5qwhoDdNZBJSegLVRaYPLVVnItefB3Y= Received: from BY3PR10CA0011.namprd10.prod.outlook.com (2603:10b6:a03:255::16) by CH9PR10MB997856.namprd10.prod.outlook.com (2603:10b6:610:345::24) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.21.406.4; Thu, 10 Sep 2026 10:43:31 +0000 Received: from BY1PEPF000264B2.namprd02.prod.outlook.com (2603:10b6:a03:255:cafe::4f) by BY3PR10CA0011.outlook.office365.com (2603:10b6:a03:255::16) with Microsoft SMTP Server (version=TLS1_3, cipher=TLS_AES_256_GCM_SHA384) id 15.21.406.9 via Frontend Transport; Thu, 10 Sep 2026 10:43:30 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 198.47.23.195) smtp.mailfrom=ti.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=ti.com; Received-SPF: Pass (protection.outlook.com: domain of ti.com designates 198.47.23.195 as permitted sender) receiver=protection.outlook.com; client-ip=198.47.23.195; helo=lewvzet201.ext.ti.com; pr=C Received: from lewvzet201.ext.ti.com (198.47.23.195) by BY1PEPF000264B2.mail.protection.outlook.com (10.167.242.118) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.21.406.5 via Frontend Transport; Thu, 10 Sep 2026 10:43:30 +0000 Received: from DLEE215.ent.ti.com (157.170.170.118) by lewvzet201.ext.ti.com (10.4.14.104) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.2562.45; Thu, 10 Sep 2026 05:43:05 -0500 Received: from DLEE212.ent.ti.com (157.170.170.114) by DLEE215.ent.ti.com (157.170.170.118) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.2562.45; Thu, 10 Sep 2026 05:43:05 -0500 Received: from lelvem-mr06.itg.ti.com (10.180.75.8) by DLEE212.ent.ti.com (157.170.170.114) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.2562.45 via Frontend Transport; Thu, 10 Sep 2026 05:43:05 -0500 Received: from pratham-Workstation-PC (pratham-workstation-pc.dhcp.ti.com [10.24.53.205]) by lelvem-mr06.itg.ti.com (8.18.1/8.18.1) with ESMTP id 68AAh4tH2178405; Thu, 10 Sep 2026 05:43:04 -0500 From: T Pratham To: T Pratham , Herbert Xu , "David S. Miller" CC: Sebin Francis , Manorit Chawdhry , Vishal Mahaveer , Praneeth Bajjuri , , Subject: [PATCH v3 12/12] crypto: ti - Do AEAD software fallback on only ENOMEM Date: Thu, 10 Sep 2026 16:12:02 +0530 Message-ID: <20260910104202.1537226-13-t-pratham@ti.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20260910104202.1537226-1-t-pratham@ti.com> References: <20260910104202.1537226-1-t-pratham@ti.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: BY1PEPF000264B2:EE_|CH9PR10MB997856:EE_ X-MS-Office365-Filtering-Correlation-Id: f5031b99-1c2a-44cd-9b86-08df0f285ab3 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|82310400026|36860700016|1800799024|376014|23010399003|10067099003|56012099006|22082099003|18002099003; X-Microsoft-Antispam-Message-Info: eJhZjaOK+UI1os9VZK1woaJmke/NgWDrvybSzeXp8P4PZmVvUfNKqs1TspYWe70e3vCL+rAQRFROFA88hAupda5gC+HFa5VFmsFbVN61LjLEL/sNNLyijb5lSMRyTurzAuGK9ZQB41/uXZob3WJ3dTtHGeIRTAPIXYYU5an/LSCuaK/Yj4Rjtww3tOgyNjfu1d4kCvGgkEM1ElfFtUocJXYARwVS8nZMz9rJbp4AeoftyGZyrjLcB5vtY94n5zuPntkod2nDEeqkjNbOvgfBeT1yzT/oV4IPEBcEODenB+AdWQoeptHwW1hoPfzg4EUYCvPhpvMXNgBVYnNyQtohG51+QRMg37oWA7amI3DTtcFk21MMoCZP5b9f8+zJxWgHVpM2A9gAiwaCLJX71pVV6w4W1WVqQDUeVTdl+n9nyXj6UcfMLSM9xysycPRjhciyxAf8gS2pIX2k+XO8AgERIXlF9pT6VVDeALGJdO8TuK37NJ2DAA/fGY1Abb0DKlRSMD/hMp++0Q8hZB0sdtO5amJg8Ce+lcshjo1JBSpwbin4phPRuaVX9ePG5Vq0jabECqw+Z2nNnJI9oiQOntkXQCdVWfUgUbVEAn9H0KeYji8XqPjP1DtDtbBhnGBQptA4EOvy5p1Zw+9gxAc/YiAGRuXlVnTAQkxJL7+fAUSqyWjnGPDNGOmeIn5pw00xL9GFdWNHCbsGn7TMHUsYfCWPwQ== X-Forefront-Antispam-Report: CIP:198.47.23.195;CTRY:US;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:lewvzet201.ext.ti.com;PTR:InfoDomainNonexistent;CAT:NONE;SFS:(13230040)(82310400026)(36860700016)(1800799024)(376014)(23010399003)(10067099003)(56012099006)(22082099003)(18002099003);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: OuAFGj/fAENJb20ksCzCc6FWlv9+WCEmmne1vPduneuo1Ql1LY373R6AlMj9gKbvr1QojmpA/6qJZV9+POVU5injUr6wUp3i5O+iJ3dN3nqVDq+f7Ax6YIlfolqbdsABbsa/WTJZNhOtJuYKks2aFDaHxdsIfMC5hnLhWnJJmyV+xHiV55MPa+iP9LYhUEbjwPW2/MumV+g3gGtoGL4fTMUMx54YZqncU1LN1us1sRzC9DJd+6GDMhIy8MLGWwtR3T4QT8jbWMmLHTfkdUl0Q5RQuYjkKlJoXiimtbGs9m/RPU7Rm583XE0e9AlRzfIZNUPmy5EOcpw8qnnn+1fOzeUjViU/VwyxIERtATYZ4xxmIX1OGFIuATRLwELxAghBsg1quBL/Z9UB9pvcoLAbCZJL7v0pwwa74Pf9dufH3Au43y3312Q7neLok7yvqIiR X-Exchange-RoutingPolicyChecked: dcqngKIzE6lKEKTAwFMzOTd7FMQCPam2gpIcKIKIAYc/X9UIw1wNP99yfDAx1ayi9aZ0pC5MZJzqUqE/NcvgPdfCNKRiMXen6kbwiIF+Mvd6S1IK9KFGGB7cWWJUPH9fQ/R7QTtZucUKq9rju9nSJgk0CRcJEkGznMhJ521cR9eZpSeS+IQ2UtlsYwbrayLWM3q25l3VkYFCHXXdhB57MAgIx2uXo2vm/nr6DFLq255ojf0ZqXQUdrYq7u/SYa7CUXNgFQmNyggZ8zVI0WTzVQGqfFvBol48C4nvckV36RJYTSRKYxpnbRUZoBaeZJ70d/ccVhuDPvCegpgEeacftw== X-OriginatorOrg: ti.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 10 Sep 2026 10:43:30.3438 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: f5031b99-1c2a-44cd-9b86-08df0f285ab3 X-MS-Exchange-CrossTenant-Id: e5b49634-450b-4709-8abb-1e2b19b982b7 X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=e5b49634-450b-4709-8abb-1e2b19b982b7;Ip=[198.47.23.195];Helo=[lewvzet201.ext.ti.com] X-MS-Exchange-CrossTenant-AuthSource: BY1PEPF000264B2.namprd02.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: CH9PR10MB997856 X-Proofpoint-ORIG-GUID: W06FCjCssl-GgLzPgrlewWI_Mdp0BZZC X-Proofpoint-Spam-Info: AW1haW4tMjYwOTEwMDEyNCBTYWx0ZWRfXxWajQRHdPZAM HvBLdC6HG3fWCvpnMrwskQq4iUaz6LXzZdxYD4sJUQR1IqcgLAJFGjDMncJDgB1+iVC50MTfPlx lBW5JqEbX5ncchXbMue9GRDXIHq7l6o= X-Proofpoint-GUID: W06FCjCssl-GgLzPgrlewWI_Mdp0BZZC X-Authority-Analysis: v=2.4 cv=MqbHeGae c=1 sm=1 tr=0 ts=6aa289d6 cx=c_pps a=yvofFnGdSAaTKL5iNkS0vw==:117 a=f+v6EHfkeJbVwR46tk4DMg==:17 a=6eWqkTHjU83fiwn7nKZWdM+Sl24=:19 a=VdqzKS8jKosA:10 a=s63m1ICgrNkA:10 a=V5UXEbMT0ywA:10 a=VkNPw1HP01LnGYTKEx00:22 a=Z8NIEmU8O1QQgoT56wFK:22 a=taLDd7a_hP9WKsMzeGRc:22 a=sozttTNsAAAA:8 a=4oUWx8CZaJwu3DmIChQA:9 X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwOTEwMDEyNCBTYWx0ZWRfX7N2tA4dqsgHz awWk3AV9UBTLAC5gKcXrX+FjyFksrd27gs0w4r4Prnd7wH/iumgTEW0FBUKz9irKyomGfnVYPfl i/QUWRYYDSBmlIwjp/mFQQn7AaqKzfsV4XB2X3Ds2a1TWn33GB9nYkgYvNadKqNwlNELZ1mScCs uqA9joPzu/CGboWk2Od/7+cncgxNHqQdzy7UBJ3BdR3LUVlRWIrxvsUw6l4toj0puwMb8boaIMU ByibR9F/KWyiB1MFGMP1KaRdoqcY7rBOjHO6gkgRYvSvGDVhO6myz6p8wdSISZf592kzxukoz0s 9mzE6gcK/LSGx+eYGQgrolHR8Cg96lc6rUsDoDsex/2VjUopuqZ/dUX0lzYjQnrLHobkBhNDE39 Eq5EgE2QJmiTR5Gsbw6bI5Nld+m5zDSl4E5YU8bCxmIZNRadliIDi9+Ypy6VDCt8TRq/mjAxXlB nFAOs5D17TowUKhyXQw== X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1176,Hydra:6.1.134,FMLib:17.12.100.49 definitions=2026-09-10_03,2026-09-09_02,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 clxscore=1015 impostorscore=0 phishscore=0 lowpriorityscore=0 priorityscore=1501 spamscore=0 bulkscore=0 adultscore=0 suspectscore=0 malwarescore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2609040000 definitions=main-2609100124 Content-Type: text/plain; charset="utf-8" Similarly in how AES part of this driver, we are falling back to software when memory allocation fails (we get -ENOMEM), fix the AEAD part also to only do fallback when we fail only due to -ENOMEM. This is because we are doing memory allocations with GFP_ATOMIC in the beginning which might fail. Any other failure paths might have modified the data or buffers already. Doing a software fallback on them might give incorrect or corrupt results. Fixes: 37b902c603042 ("crypto: ti - Add support for AES-GCM in DTHEv2 drive= r") Signed-off-by: T Pratham --- drivers/crypto/ti/dthev2-aes.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/crypto/ti/dthev2-aes.c b/drivers/crypto/ti/dthev2-aes.c index a034c1c8f20ed..150ce65f613fa 100644 --- a/drivers/crypto/ti/dthev2-aes.c +++ b/drivers/crypto/ti/dthev2-aes.c @@ -1173,7 +1173,7 @@ static int dthe_aead_run(struct crypto_engine *engine= , void *areq) aead_prep_aad_err: memzero_explicit(rctx->padding, 3 * AES_BLOCK_SIZE); =20 - if (ret) + if (ret =3D=3D -ENOMEM) ret =3D dthe_aead_do_fallback(req); =20 local_bh_disable(); --=20 2.34.1