From nobody Fri Sep 25 16:54:11 2026 Received: from mail-m155101.qiye.163.com (mail-m155101.qiye.163.com [101.71.155.101]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 4893E3CB8F5; Thu, 10 Sep 2026 09:24:23 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=101.71.155.101 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1789032272; cv=none; b=FWIlnNQvgF9hosxS/89MiYa+gkWG3HaVu70NHd3qdJoSif+xfOhrfbCsRwOpdHlwxUdvpDShLoDR+peXSvx4FtvcxxMAK5VghfVqLXRf0nuG26Ul7BQjaIyLcgyV6/5L3Yq4XBMVtJPwSAAvo2AR2QghjPMw3VUkhiXZljZkmLU= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1789032272; c=relaxed/simple; bh=RJydT2Dk8RQ1sONS+iE0RGlzWiAtuS02wqiSMmED05k=; h=From:To:Cc:Subject:Date:Message-Id:MIME-Version; b=PCgXcdGpIZ0U9xz2zPdGvAkBuPcgQOD/jT7o/uePcluZmCeQ6aXMjT1u6avDd6F5zDt1hoHMWAnAyIBvgc81ttxNZ8f0v029rxOlLbAnFCRMD8uICFVJyuGZeNE/dfZPrXd/PKflAfA4oQG1GHJ8g2d8ghj1yGjt1cQQtGnENTw= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=seu.edu.cn; spf=pass smtp.mailfrom=seu.edu.cn; dkim=pass (1024-bit key) header.d=seu.edu.cn header.i=@seu.edu.cn header.b=YyUyP2Sj; arc=none smtp.client-ip=101.71.155.101 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=seu.edu.cn Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=seu.edu.cn Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=seu.edu.cn header.i=@seu.edu.cn header.b="YyUyP2Sj" Received: from PC-202605011814.localdomain (unknown [222.191.246.242]) by smtp.qiye.163.com (Hmail) with ESMTP id 4d445a41d; Thu, 10 Sep 2026 17:24:13 +0800 (GMT+08:00) From: Runyu Xiao To: Nilesh Javali , Manish Rangankar , GR-QLogic-Storage-Upstream@marvell.com, "James E . J . Bottomley" , "Martin K . Petersen" Cc: linux-scsi@vger.kernel.org, linux-kernel@vger.kernel.org, Jianhao Xu , Runyu Xiao , stable@vger.kernel.org Subject: [PATCH] scsi: qedi: Initialize callback state before registration Date: Thu, 10 Sep 2026 17:24:05 +0800 Message-Id: <20260910092405.1300129-1-runyu.xiao@seu.edu.cn> X-Mailer: git-send-email 2.34.1 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-HM-Tid: 0aa08aa1c9ac03a1kunm63a873ca18fb04 X-HM-MType: 10 X-HM-Spam-Status: e1kfGhgUHx5ZQUpXWQgPGg8OCBgUHx5ZQUlOS1dZFg8aDwILHllBWSg2Ly tZV1koWUFITzdXWRgWCB1ZQUpXWS1ZQUlXWQ8JGhUIEh9ZQVlCQ0NMVkJPSUwaTx1DGB9OTFYeHw 5VEwETFhoSFyQUDg9ZV1kYEgtZQVlJSUlVSkJKVUlPTVVJT0lZV1kWGg8SFR0UWUFZT0tIVUpLSE pPSExVSktLVUpCS0tZBg++ DKIM-Signature: a=rsa-sha256; b=YyUyP2Sjuj55u+kZWrbQOQNVoVEk/1XVBn2fLlOH0xia178XJLGclmQpIc52Rb5RQ+9CW1RduRWYUHF6fjsxBQ77Rit7XwDSrvHVV160gRIGN/14TpEL9uj5UQI4JJPzGTv3d6Ctx3v49OO7wZhxLXyu7p77mTKQm31lfQGHar4=; c=relaxed/relaxed; s=default; d=seu.edu.cn; v=1; bh=2QLnkcGLYs1KfcKJLaEcqelOoy7bY8ls7NzfuQq15P8=; h=date:mime-version:subject:message-id:from; Content-Type: text/plain; charset="utf-8" qedi_get_protocol_tlv_data() can be called asynchronously by QED after qedi_ops->register_ops(). It takes stats_lock and reads ll2_mtu, but __qedi_probe() currently registers the callback before initializing the mutex and assigning the default MTU on the normal probe path. Initialize the callback-visible state before registering qedi_cb_ops. Keep the recovery path from reinitializing state because it reuses the existing qedi context. Fixes: 3cc5746e5ad7 ("scsi: qedi: Initialize the stats mutex lock") Cc: stable@vger.kernel.org Assisted-by: LLM Codex Signed-off-by: Runyu Xiao --- drivers/scsi/qedi/qedi_main.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/drivers/scsi/qedi/qedi_main.c b/drivers/scsi/qedi/qedi_main.c index 227ff7bd1..f394fcbb9 100644 --- a/drivers/scsi/qedi/qedi_main.c +++ b/drivers/scsi/qedi/qedi_main.c @@ -2652,8 +2652,6 @@ static int __qedi_probe(struct pci_dev *pdev, int mod= e) snprintf(host_buf, sizeof(host_buf), "host_%d", qedi->shost->host_no); qedi_ops->common->set_name(qedi->cdev, host_buf); =20 - qedi_ops->register_ops(qedi->cdev, &qedi_cb_ops, qedi); - memset(¶ms, 0, sizeof(params)); params.mtu =3D DEF_PATH_MTU + IPV6_HDR_LEN + TCP_HDR_LEN; qedi->ll2_mtu =3D DEF_PATH_MTU; @@ -2670,6 +2668,7 @@ static int __qedi_probe(struct pci_dev *pdev, int mod= e) spin_lock_init(&qedi->task_idx_lock); mutex_init(&qedi->stats_lock); } + qedi_ops->register_ops(qedi->cdev, &qedi_cb_ops, qedi); qedi_ops->ll2->register_cb_ops(qedi->cdev, &qedi_ll2_cb_ops, qedi); qedi_ops->ll2->start(qedi->cdev, ¶ms); =20 --=20 2.34.1