From nobody Fri Sep 25 16:51:05 2026 Received: from mail-qk2-f12.google.com (mail-qk2-f12.google.com [74.125.230.204]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id E7DDC3955C0 for ; Thu, 10 Sep 2026 08:17:21 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=74.125.230.204 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1789028244; cv=none; b=trWHSKNWwCU22K6chKlTR6pZtzpW4CUvVuOel0bpqSmY498OjA9fzekzVA3FGJvjv4NXdNBGUldFlnEjQj2z+ZjxlFQXOLTQ5sf1A/LMTP6keJsgAJYN00C7+aCH4p7Qw2geaGY6OrPgzYDMNvpwVT2Qj+zGqt0Peg+VC/E1TWI= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1789028244; c=relaxed/simple; bh=gDFyzNvBDNjI/mr8CUb+d2A4IpdA26e6ynTV9GMGTDo=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=Mz3Ps3hbgtzMovtXl4+CRfxp0k6Gc+vcvJwvfmVt9VoxTRIA0TIWKs6ZwSFBBg5LSfCMu0TBKzPWgwd5aa6IdJSIX/Vn0jP8oZJoqLAVAoGgdrhLXXGlqqtDaPL1nu7AxkyU3VlGLjn41oCjRuBMyK9vALzD8O2qAF54J+zktkU= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=oXGZvURK; arc=none smtp.client-ip=74.125.230.204 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="oXGZvURK" Received: by mail-qk2-f12.google.com with SMTP id af79cd13be357-93910c3d02aso121014585a.1 for ; Thu, 10 Sep 2026 01:17:21 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1789028241; x=1789633041; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to:content-type; bh=hWzmAdRLUf0g2QMy6rAYQTOxI2sFMD4mgsTYky0eQmc=; b=oXGZvURKvetqQT1Cz/+PQ+Ud3Nb4vNCXQROX9s/lNN55CJzBHT48dV9WWjcI2Kayrn zr0oJG7jnkSdVIK/bcnf6VtnBzFGd0IYjzo6GHPF7BGYxGJ5ar4c2hnRWIBCQzjVIXhl Xs0OZxc0m55EJe6MFrdZ2SBTAntQjZoPX2nugdIc6iZdGE7JlobeafdzLcZ5kGA4TvZl jt+0+a+BzwIQoUqF4j+1TA0o15fHwgXEu7lR05clERxtlJuCAT6L9LzLs8PLM8xo8G2b RXRsZXnxpfl/6Tp7VvrTYrIgAzqDrrbkPpH6vkbNKwz/DWYu6D9p4WvNShIm7mASMaYW Ls0w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1789028241; x=1789633041; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to:content-type; bh=hWzmAdRLUf0g2QMy6rAYQTOxI2sFMD4mgsTYky0eQmc=; b=VwuZmRjX44CRgwFeXN5TSKH8bhroW2V7fQtvCViR7Ye5mufP5I3K5WK/1dIAZyKnjh AjWP9twN9/DlkHZwQF2q5z+ftsFDnU0MM4h+1NoLTzIKoPvHJAqOk28NLa5mAyI2a38S jdsuRHfonyasupeh5kpJzZn2VK8Bq8UIGVsCjypWEFy20EFE4K/26UNvH+TVk8DZcA6D tMOXozg+hzWFR4lnmIkruc++3D7rZgCds/eCm7A8O17mkqxBo0c2rsS/XCQWiyrDDCTk c51tkODjzRS5oRQEOPF+N5mqLcZzbCpDWLjXNgQNuINkpS6BBMwS1NywdYdrifAWryYP r9lQ== X-Forwarded-Encrypted: i=1; AKwUvBwsymMECkbpdEZ2YtK50SFyETAPbsMpWPf4MELT6epeE80NdCeSKF+hwJH1f6khAcq5XVol1kONFTkNWuQ=@vger.kernel.org X-Gm-Message-State: AFuF++l8g44um9SXW3wIXLu1IUpz/VdDY5oli7lO8l3FiMNV0sOZmvKe Nfh9jw6rIJUmBqQ4TCe9C1GTMTn1Aih0qHcTJPiq8NO6o/T576B7DhNl X-Gm-Gg: AYBFou0ssvoZFJqfcUGhcBwMkTGOqLXVXFZjaLUsO3v43DGTT9EiAzj+X63dpeFwJ35 3ZEkU6gWjVLFW2x5E8RtextbzImMXZxR5JXZ8wNFJMNpjFM4/Evwoxgej5dquNKaMPA/owcKnJc 03na+7t2j8+LM0nvZS45YivRDVCkPj8sRnc+sbg8ndZClqqe9k2j5XiGL765lXAUw0jH8PQiOgO susnNVqI3LNy8kIVI1Cm6r1eX5JqMybMhOLOtFZvlZ8qnkcdHmWf0hDNKOGXL4WMxb/GYi0Zz+T Kb69fUDKxZ50XQxNPskEenhooPHA1lHtfi53Edh4cADekkmCFf5KJslJMqltR3MoFQLbWFPI54x kOJ8J1LBxGjs81gxyX0p4Wb7haRDHG4jhxeGg2S04Xki0TcfBcstHhqpGJzCI2WAzNScd7R48hz hMRgPtKr+VWs/5FFfFc3XwK1Z9hp08alsbLnP4Ga8ZPKOCBjBw80CMsNZN6hSOssXmQQDOpZspq MqS X-Received: by 2002:a05:620a:4620:b0:939:6de7:238d with SMTP id af79cd13be357-939d7fb6f5cmr412443285a.23.1789028240873; Thu, 10 Sep 2026 01:17:20 -0700 (PDT) Received: from deb05.proceq.com ([213.160.61.66]) by smtp.gmail.com with ESMTPSA id af79cd13be357-939a57535a1sm1087723885a.0.2026.09.10.01.17.19 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 10 Sep 2026 01:17:20 -0700 (PDT) From: Mehmet Fide To: Ping-Ke Shih Cc: Bitterblue Smith , linux-wireless@vger.kernel.org, linux-kernel@vger.kernel.org, mehmet.fide@screeningeagle.com Subject: [PATCH rtw-next v3 1/3] wifi: rtw88: usb: bound what the driver feeds the after-DTIM queue Date: Thu, 10 Sep 2026 10:17:14 +0200 Message-ID: <20260910081716.769081-2-mehmet.fide@gmail.com> X-Mailer: git-send-email 2.55.0 In-Reply-To: <20260910081716.769081-1-mehmet.fide@gmail.com> References: <20260910081716.769081-1-mehmet.fide@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" From: Mehmet Fide Frames routed to the high queue are transmitted right after DTIM beacons only, inside the ATIM window, while they wait in the shared TX page pool. The driver puts no limit on how many it hands over, so as long as one station dozes, any sustained broadcast or multicast traffic outruns the drain and empties the pool: measured on an RTL8822BU AP with a single client in power save and ~40 frames/s of mDNS chatter, the free page count at 0x240 goes from 1803 to 16 in about 100 seconds and stays there for as long as the traffic lasts. From that point every other transmit queues behind the backlog, authentication responses arrive too late for anyone to join, and the reserved page download fails ("error beacon valid"). The AP keeps beaconing and only a reboot recovers. Feed the high queue through a small budget that refills below the measured drain rate (about 3 frames per DTIM, ~15/s at dtim_period 2 on the default 2 TU ATIM window); whatever exceeds the budget leaves on its access category queue right away. The high queue backlog is now bounded by the burst size under any load, so the page pool cannot run dry, at the price that a dozing station may miss part of a broadcast storm. Signed-off-by: Mehmet Fide Acked-by: Ping-Ke Shih --- v3: - the refill macro comment says what one interval buys (Ping-Ke) - the bookkeeping comment is a single line, blank lines around the refill block (Ping-Ke) drivers/net/wireless/realtek/rtw88/usb.c | 41 ++++++++++++++++++++++-- drivers/net/wireless/realtek/rtw88/usb.h | 5 +++ 2 files changed, 43 insertions(+), 3 deletions(-) diff --git a/drivers/net/wireless/realtek/rtw88/usb.c b/drivers/net/wireles= s/realtek/rtw88/usb.c index c90802919473..a03896260f1a 100644 --- a/drivers/net/wireless/realtek/rtw88/usb.c +++ b/drivers/net/wireless/realtek/rtw88/usb.c @@ -562,7 +562,37 @@ static int rtw_usb_write_data_h2c(struct rtw_dev *rtwd= ev, u8 *buf, u32 size) return rtw_usb_write_data(rtwdev, &pkt_info, buf); } =20 -static u8 rtw_usb_tx_queue_mapping_to_qsel(struct sk_buff *skb) +#define RTW_USB_HIQ_REFILL_INTERVAL (HZ / 10) /* one unit of budget per 10= 0 ms */ +#define RTW_USB_HIQ_BUDGET_MAX 16 + +static bool rtw_usb_hiq_take_budget(struct rtw_usb *rtwusb) +{ + unsigned long flags, elapsed, add; + bool ok; + + spin_lock_irqsave(&rtwusb->hiq_lock, flags); + + elapsed =3D jiffies - rtwusb->hiq_refill; + add =3D elapsed / RTW_USB_HIQ_REFILL_INTERVAL; + if (add) { + rtwusb->hiq_budget =3D min_t(unsigned long, rtwusb->hiq_budget + add, + RTW_USB_HIQ_BUDGET_MAX); + + /* keep the unfinished part of the interval for the next unit */ + rtwusb->hiq_refill =3D jiffies - elapsed % RTW_USB_HIQ_REFILL_INTERVAL; + } + + ok =3D rtwusb->hiq_budget > 0; + if (ok) + rtwusb->hiq_budget--; + + spin_unlock_irqrestore(&rtwusb->hiq_lock, flags); + + return ok; +} + +static u8 rtw_usb_tx_queue_mapping_to_qsel(struct rtw_usb *rtwusb, + struct sk_buff *skb) { struct ieee80211_hdr *hdr =3D (struct ieee80211_hdr *)skb->data; struct ieee80211_tx_info *info =3D IEEE80211_SKB_CB(skb); @@ -573,7 +603,8 @@ static u8 rtw_usb_tx_queue_mapping_to_qsel(struct sk_bu= ff *skb) qsel =3D TX_DESC_QSEL_MGMT; else if (is_broadcast_ether_addr(hdr->addr1) || is_multicast_ether_addr(hdr->addr1)) - qsel =3D (info->flags & IEEE80211_TX_CTL_SEND_AFTER_DTIM) ? + qsel =3D (info->flags & IEEE80211_TX_CTL_SEND_AFTER_DTIM) && + rtw_usb_hiq_take_budget(rtwusb) ? TX_DESC_QSEL_HIGH : skb->priority; else if (skb_get_queue_mapping(skb) <=3D IEEE80211_AC_BK) qsel =3D skb->priority; @@ -593,7 +624,7 @@ static int rtw_usb_tx_write(struct rtw_dev *rtwdev, u8 *pkt_desc; int ep; =20 - pkt_info->qsel =3D rtw_usb_tx_queue_mapping_to_qsel(skb); + pkt_info->qsel =3D rtw_usb_tx_queue_mapping_to_qsel(rtwusb, skb); pkt_desc =3D skb_push(skb, chip->tx_pkt_desc_sz); memset(pkt_desc, 0, chip->tx_pkt_desc_sz); ep =3D qsel_to_ep(rtwusb, pkt_info->qsel); @@ -1034,6 +1065,10 @@ static int rtw_usb_init_tx(struct rtw_dev *rtwdev) struct rtw_usb *rtwusb =3D rtw_get_usb_priv(rtwdev); int i; =20 + spin_lock_init(&rtwusb->hiq_lock); + rtwusb->hiq_budget =3D RTW_USB_HIQ_BUDGET_MAX; + rtwusb->hiq_refill =3D jiffies; + rtwusb->txwq =3D create_singlethread_workqueue("rtw88_usb: tx wq"); if (!rtwusb->txwq) { rtw_err(rtwdev, "failed to create TX work queue\n"); diff --git a/drivers/net/wireless/realtek/rtw88/usb.h b/drivers/net/wireles= s/realtek/rtw88/usb.h index 9b695b688b24..94ff21dd0846 100644 --- a/drivers/net/wireless/realtek/rtw88/usb.h +++ b/drivers/net/wireless/realtek/rtw88/usb.h @@ -75,6 +75,11 @@ struct rtw_usb { u8 out_ep[RTW_USB_EP_MAX]; int qsel_to_ep[TX_DESC_QSEL_MAX]; =20 + /* protects hiq_budget and hiq_refill */ + spinlock_t hiq_lock; + u32 hiq_budget; + unsigned long hiq_refill; + struct workqueue_struct *txwq, *rxwq; =20 struct sk_buff_head tx_queue[RTW_USB_EP_MAX]; --=20 2.55.0 From nobody Fri Sep 25 16:51:05 2026 Received: from mail-qk2-f12.google.com (mail-qk2-f12.google.com [74.125.230.204]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 7CA283C061D for ; Thu, 10 Sep 2026 08:17:23 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=74.125.230.204 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1789028245; cv=none; b=fhh48AzeG5RZIBVnyDqCT/tCk1t6qGGcSSKD/c5a7HrwNcQHh48R6zA4RpVPQnWv0x3nq/2oxOmBwRn0WmnyBlMr6DTD83b/XbFyMNTXNgMX5aNZLRHpeJayxw4abfysvCi6nfnUkXBxRvS87YXZABqIhNOqKcSnMnokatkrhkg= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1789028245; c=relaxed/simple; bh=Pf9FGUuu4T99qrISQwcUth/SFnfHhXZMk0vraXLaX2M=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=sBGbFqKRggqLmgg/eD5vhVj+0jnrExGi/23w6XEaIv9ZywG4ZaU9c5MrNtEECgnKwPYY0FDYJZcasZpQeCV51VGFtLDa5q03rjEP+l6QcZIi6eDImzxG7pIosmbwr8UUdn7LAPfROSmXr5rT3AGbXFzz5EFxtCsxtCJNULMAQ2A= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=q5nlhSDN; arc=none smtp.client-ip=74.125.230.204 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="q5nlhSDN" Received: by mail-qk2-f12.google.com with SMTP id af79cd13be357-93910ca5aa7so125836385a.1 for ; Thu, 10 Sep 2026 01:17:23 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1789028242; x=1789633042; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to:content-type; bh=/Qa2OeELdjZHS87D2WN6hbNeXUfzKq/fcfCAU9P6xlU=; b=q5nlhSDNNmF6ra3GhNynpWwwriXDFG4/MuCqh3di7r2o5Q7qx5Xs3X9YPNz7Wvsk6o 4dTYZSwIAS4wwzjc7U2hQV6oqUN0NEu2/+kXEkoTVGx+X4QFGFdoFjiulNcvS1Sf1Tv8 sesZOB1HqWTsSCcRHE9kq84oiepUAv7ryduZOWSrZAguzggvr46OLATcF2h4QXOjcDs3 VXGAfnAe1pBpDyL8tN/8/Ej4TQ1k88pwwZw4YLchcFvxCNMPC8+t6XbA731AoxCTIIZD 4GwsrWum6LPkViwSMVm++Y/UziuM8XP7zhvzEtWMKB16y8BWLwIyGbiGdQatzXXCMlOR onmw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1789028242; x=1789633042; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to:content-type; bh=/Qa2OeELdjZHS87D2WN6hbNeXUfzKq/fcfCAU9P6xlU=; b=IWSyS1p/coB9+OsXHmyMEt/tiqvtqAjfkiycrhLJpC6/88qxklfG1MbG2IeROwxPLt 1ArfjDX3DfwEKYXGGUWQ0YMTwu145+fQcTPtWQbzb0KF0RxfZAY7uzZDqeoABFlSKrVT 77Y9sj1bdpqFyVVxsyg8VQAk9YfxXWPRfA3SnRYxeyRVtqR/5vwhIuPz6Q+3CKFV+n5u VZywvVJ0tYGWFsCd7VJNKZ22Kv5lvme2th/B6i6so1U1SR638/DUAa66WpIt0pTQUeFP D5kK3kKtyaUnACDOQUGhpiKQctKddwFDIFJL3giMUEzluhIlBo4BksNnT2q9Q8t7Xlv2 wDWg== X-Forwarded-Encrypted: i=1; AKwUvBwCtAg7uC3uCotoXp/gs0gAXqtSRfcFrqzDyMl7qxv8Qgyn7cnoK+vkxd5Hr0SWqT1Mq5DrTVG8BhwYA8M=@vger.kernel.org X-Gm-Message-State: AFuF++muc8D/ZaLj75f+V9uTM1rFFHbvm/p/H3oxGw0oEzO0jSCD8iuv +xzTkoJhMk390tGG+WhUcQB5xO1kZ0XWO4ibWTAIX8Xh/oz9YASGYC/P X-Gm-Gg: AYBFou3dqAugallBQyTXsM30c2FhwmjCvpXeFaUmShHZrPykG4tMz0kHzrhjzB+uWc5 Z0moo2VYcz2NmQesladzMmR0ohKrfFR+oaBXFMtj1KuHzeC+AiY7HTuNhpigsHIEQI/tI0bZ+2B bknBAKORzSSTLynhVq0BuHT1OgpmouE+IQ4DKVlAyObG78SGSJW5/y51vrdvN80F+7UG6cptYOy HBBTKc5AqgFNsBr0NIkFZjxbfaXVox9BV2fvF+iycw/WVmnbI2RgyNSIr8qq8KIl/MWHlyjdY7b 3njG/mJBW6QV5ZmPZQyYNiJRqTFnBSZk9BtfesCNP5NcUEUismlGvoH4n03As+7UH9r13eFHVtN DObtwYBWeIw9UYGbTub4Vb1jhKenD10CCnd+Er0t6BHIcsBJKVpBg/6Yu/YTD13GdtPEBUq1LIa JW7SkUL+mB6bAMksSDeWx8pfl+4+jC/jd709V+J6a4pX7zSKwkkt9yOCUufBsPCu895YLzjN/c0 9gs X-Received: by 2002:a05:620a:4552:b0:939:9eb4:888a with SMTP id af79cd13be357-939d4924ccfmr797682585a.1.1789028242237; Thu, 10 Sep 2026 01:17:22 -0700 (PDT) Received: from deb05.proceq.com ([213.160.61.66]) by smtp.gmail.com with ESMTPSA id af79cd13be357-939a57535a1sm1087723885a.0.2026.09.10.01.17.21 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 10 Sep 2026 01:17:21 -0700 (PDT) From: Mehmet Fide To: Ping-Ke Shih Cc: Bitterblue Smith , linux-wireless@vger.kernel.org, linux-kernel@vger.kernel.org, mehmet.fide@screeningeagle.com Subject: [PATCH rtw-next v3 2/3] wifi: rtw88: usb: only let the frames a dozing station needs use the after-DTIM queue Date: Thu, 10 Sep 2026 10:17:15 +0200 Message-ID: <20260910081716.769081-3-mehmet.fide@gmail.com> X-Mailer: git-send-email 2.55.0 In-Reply-To: <20260910081716.769081-1-mehmet.fide@gmail.com> References: <20260910081716.769081-1-mehmet.fide@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" From: Mehmet Fide With the budget in place the high queue can no longer take the chip down, but ordinary chatter still competes with the frames a sleeping station actually needs. mac80211 marks every broadcast and multicast frame with IEEE80211_TX_CTL_SEND_AFTER_DTIM while a station dozes, mDNS and SSDP included, so under normal traffic the budget is spent on frames nobody waits for. Do what the vendor driver does with its default "allow special" high queue filter: admit only ARP, EAPOL and DHCP to the after-DTIM path, the frames a station coming out of power save has to see; everything else goes out on its access category queue at line rate. The frames are classified the way rtw89_core_tx_btc_spec_pkt_notify() does it, from skb->protocol and the network and transport header offsets that mac80211 keeps from the netdev path; EAPOL is the control port flag. Frames the AP relays between its own stations arrive as ETH_P_802_3 and are not inspected, they leave on the access category queue. With the filter in place the page pool stays at 1803 through the same 180 second storm, a DHCP flood still takes the after-DTIM path (and is then held by the budget), and join/ping cycling without power save is unchanged (10/10). Signed-off-by: Mehmet Fide Acked-by: Ping-Ke Shih --- v3: - the IP/UDP test written in positive form (Ping-Ke) drivers/net/wireless/realtek/rtw88/usb.c | 27 ++++++++++++++++++++++-- 1 file changed, 25 insertions(+), 2 deletions(-) diff --git a/drivers/net/wireless/realtek/rtw88/usb.c b/drivers/net/wireles= s/realtek/rtw88/usb.c index a03896260f1a..715a2ce342d9 100644 --- a/drivers/net/wireless/realtek/rtw88/usb.c +++ b/drivers/net/wireless/realtek/rtw88/usb.c @@ -2,9 +2,11 @@ /* Copyright(c) 2018-2019 Realtek Corporation */ =20 +#include #include -#include #include +#include +#include #include "main.h" #include "debug.h" #include "mac.h" @@ -562,6 +564,27 @@ static int rtw_usb_write_data_h2c(struct rtw_dev *rtwd= ev, u8 *buf, u32 size) return rtw_usb_write_data(rtwdev, &pkt_info, buf); } =20 +static bool rtw_usb_bmc_needs_dtim(struct sk_buff *skb) +{ + struct ieee80211_tx_info *info =3D IEEE80211_SKB_CB(skb); + struct udphdr *udphdr; + + if (info->control.flags & IEEE80211_TX_CTRL_PORT_CTRL_PROTO) + return true; + + if (skb->protocol =3D=3D htons(ETH_P_ARP)) + return true; + + if (skb->protocol =3D=3D htons(ETH_P_IP) && + ip_hdr(skb)->protocol =3D=3D IPPROTO_UDP) { + udphdr =3D udp_hdr(skb); + + return udphdr->dest =3D=3D htons(67) || udphdr->dest =3D=3D htons(68); + } + + return false; +} + #define RTW_USB_HIQ_REFILL_INTERVAL (HZ / 10) /* one unit of budget per 10= 0 ms */ #define RTW_USB_HIQ_BUDGET_MAX 16 =20 @@ -604,7 +627,7 @@ static u8 rtw_usb_tx_queue_mapping_to_qsel(struct rtw_u= sb *rtwusb, else if (is_broadcast_ether_addr(hdr->addr1) || is_multicast_ether_addr(hdr->addr1)) qsel =3D (info->flags & IEEE80211_TX_CTL_SEND_AFTER_DTIM) && - rtw_usb_hiq_take_budget(rtwusb) ? + rtw_usb_bmc_needs_dtim(skb) && rtw_usb_hiq_take_budget(rtwusb) ? TX_DESC_QSEL_HIGH : skb->priority; else if (skb_get_queue_mapping(skb) <=3D IEEE80211_AC_BK) qsel =3D skb->priority; --=20 2.55.0 From nobody Fri Sep 25 16:51:05 2026 Received: from mail-qt1-f179.google.com (mail-qt1-f179.google.com [209.85.160.179]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 7181B397E64 for ; Thu, 10 Sep 2026 08:17:25 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.160.179 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1789028248; cv=none; b=TmEPb3ONx3JIPAJlAHlI+BxRX5ha5caGdFG9x0Isg6B46dBZPtdPe677CeKS7e59N3nycuNtOxcIDnkh5qCvNJADptKP5p0HuhQQ50b8MkXCIKAQ3978hExse6wwfx6GE9+GK4ZXjOoivE8yKQWPd1lj9V+UJuJGitVfYnADnxo= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1789028248; c=relaxed/simple; bh=A9QmHRxhcnlFEMXPsheklMbj5r20vpaPgP2nE5PMD2s=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=R/S5HA5UrXuV3585vA3n8ggwJEDTATdpakgV6PlsTGhPDJjyI/B5Jxr8TtAD6HwwoS6VauiXVAHAmAPe0m2IX7gacchct1J+RaSBq4iQok9GXTC4EP1c1oYcJirqZOT9/AfULTWR663Vc2XEW08GJkzMzlIiExEHnrdHrKPfmkk= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=mX2vNhOI; arc=none smtp.client-ip=209.85.160.179 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="mX2vNhOI" Received: by mail-qt1-f179.google.com with SMTP id d75a77b69052e-5301db51586so21880991cf.1 for ; Thu, 10 Sep 2026 01:17:25 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1789028244; x=1789633044; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to:content-type; bh=8w29+FNmbA7LWNO6WgdUJylIFrA2rKKIMGzm7xHnRZg=; b=mX2vNhOIAOwa76+OqBd9FCSTAiBmq06wRjyx55dI4Y2rEtiIx2hooyuQwbkadi41YR k5ldR5XWyOYsh3JrVS329wcN1sD7qzQgh14grLWkPU0LzBtoWDr7tYR7FycOjA9rjxmM XU1Nr3H6p6bpaIlNNiKhGjtnJlqGTe2Qr0T1YurtF/UVD9+v1N1im/ypTrnFbrlovsJY Q7XepRHTsKv2KeBlWJX2P0WgBPY4N5zovxd7JQwkBds6nF0pfeSDeuEzUa9Z9QZud6UQ Ho2b6CS56m29id4lKVlHEfphl4HOOYrkD/EQPEFvIu4IbHmCo/qnpiKjYu5XRsAkZ7Hc 7PAg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1789028244; x=1789633044; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to:content-type; bh=8w29+FNmbA7LWNO6WgdUJylIFrA2rKKIMGzm7xHnRZg=; b=Fj1C1hMPTF5AYB/2DVQS16+ZtAXAUOPFkXIV3paIOaiqT+VjXrg6WYZhVERvZznHDI Yt7b88UwvBpWhKirbpo2miEOuflLWZm1pJGwxZOLuUgU5ivuYop3vq+f13x1GfoRHinC UUHFuJL5/QfWDDREml00FyD44lV/LoTjUHX7hxYOGn9SpQKjvl4JAbmz8nQJq7Vnj1Qm ThMWJX342/jX/V9RiinrtYexfIKPSFjnLy98kdnihnWsN5fhw/w1Ip5zs8T7ojHJLqin pdoEQwTPo/0dR0fi4Lhsca64sF9rKn+gzwxO04xYBzqAkpxBNknjmRfCOcUzTuZzI8kO 1+FA== X-Forwarded-Encrypted: i=1; AKwUvBwv4m/MWQkmiRpVd+vebZyEAah8Th4pGoh3tDHsw9Y3MaJDaixbmU+a920jilr3aFN7BkBwW2Dmnt9Pmp0=@vger.kernel.org X-Gm-Message-State: AFuF++mvpuuapNtXaOds15eR5yZxSZbeZzz7+JWhwNbYjKTC9rTyHOje dMjgDQ3F84rTjKJ8mfYddb8gudaXzVbE1uyFuBkKTPFObSO2PfL0bCdpA8cl8/b5 X-Gm-Gg: AYBFou1nchTQZCg97duyl1s9FlfHA0+5US0QrzBPIFJCiZs04jsxjR76Tz4o1n+fgqo uS9D5DgsZUdBiNlw2zVRmNB2qmmqXDV3iKdh77UliEllU321bIIeEvAYMc5zpLjUtsCt0DDa8fL dcStMaVsJ6JE7BjrUOspBE3E6sn9mXozhELb6Of1vFA6jejY0jvNZg45wTneMspN8PmRj+5Ma4g 9h0Iwf9IVejysOMRixvSZgElKBsUdfX1Epz2WW6q4iGJKSBswQsclhdhKMD38vFOw7wH7ZpNblu lHSQo/u1HJy87oMARcDUvPBPxb+CcGK8bpaAuhpQyA3RlGiLQmy0oPSq0v8qJ5uaKOL3s3DGjrb ERyK6gtxdAczWJ9ww4Fukkqy/2sLgMgg44I3EExzyH8VmTCh7XeKNW3VA5LmZ6fRTnuX/mH8FcJ N7em6K6/AsvT88vINGQV9+q65VbsM1skT4AXviOkQvddPdQEHkRdGR0fcHLVhkSFUVqfszCX8VW h1R X-Received: by 2002:a05:620a:8388:b0:939:9c21:8ece with SMTP id af79cd13be357-9399c21b43fmr3256938285a.42.1789028243645; Thu, 10 Sep 2026 01:17:23 -0700 (PDT) Received: from deb05.proceq.com ([213.160.61.66]) by smtp.gmail.com with ESMTPSA id af79cd13be357-939a57535a1sm1087723885a.0.2026.09.10.01.17.22 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 10 Sep 2026 01:17:23 -0700 (PDT) From: Mehmet Fide To: Ping-Ke Shih Cc: Bitterblue Smith , linux-wireless@vger.kernel.org, linux-kernel@vger.kernel.org, mehmet.fide@screeningeagle.com Subject: [PATCH rtw-next v3 3/3] wifi: rtw88: widen the ATIM window while an AP interface is up Date: Thu, 10 Sep 2026 10:17:16 +0200 Message-ID: <20260910081716.769081-4-mehmet.fide@gmail.com> X-Mailer: git-send-email 2.55.0 In-Reply-To: <20260910081716.769081-1-mehmet.fide@gmail.com> References: <20260910081716.769081-1-mehmet.fide@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" From: Mehmet Fide The frames held for dozing stations go out right after the DTIM beacon and only for the duration of the ATIM window. The chips come up with a 2 TU window (the two that program it set 0x2 at init), which drains about three frames per DTIM; the vendor driver sets 0xa or 0xc in AP mode instead. With the 2 TU window the measured page pool exhaustion takes ~100 s of ordinary multicast chatter; at 0x4 the same storm already drains, so 0xa leaves comfortable headroom. Program 0xa when an AP interface starts and put the default back when it stops, since most chips never initialize the register themselves. The bound and the filter of the previous patches still apply: the window adds drain capacity, the budget protects the pool when that is not enough, the filter keeps chatter off the beacon-paced path. Suggested-by: Ping-Ke Shih Signed-off-by: Mehmet Fide Acked-by: Ping-Ke Shih --- drivers/net/wireless/realtek/rtw88/mac80211.c | 2 ++ drivers/net/wireless/realtek/rtw88/reg.h | 2 ++ 2 files changed, 4 insertions(+) diff --git a/drivers/net/wireless/realtek/rtw88/mac80211.c b/drivers/net/wi= reless/realtek/rtw88/mac80211.c index 0b622d7663b6..2a9b09fa76e7 100644 --- a/drivers/net/wireless/realtek/rtw88/mac80211.c +++ b/drivers/net/wireless/realtek/rtw88/mac80211.c @@ -474,6 +474,7 @@ static int rtw_ops_start_ap(struct ieee80211_hw *hw, =20 mutex_lock(&rtwdev->mutex); rtw_write32_set(rtwdev, REG_TCR, BIT_TCR_UPDATE_HGQMD); + rtw_write16(rtwdev, REG_ATIMWND, ATIMWND_AP); rtwdev->ap_active =3D true; rtw_store_op_chan(rtwdev, true); chip->ops->phy_calibration(rtwdev); @@ -490,6 +491,7 @@ static void rtw_ops_stop_ap(struct ieee80211_hw *hw, =20 mutex_lock(&rtwdev->mutex); rtw_write32_clr(rtwdev, REG_TCR, BIT_TCR_UPDATE_HGQMD); + rtw_write16(rtwdev, REG_ATIMWND, ATIMWND_DEFAULT); rtwdev->ap_active =3D false; if (!rtw_core_check_sta_active(rtwdev)) rtw_clear_op_chan(rtwdev); diff --git a/drivers/net/wireless/realtek/rtw88/reg.h b/drivers/net/wireles= s/realtek/rtw88/reg.h index 08e9494977e0..0b9ba6f37680 100644 --- a/drivers/net/wireless/realtek/rtw88/reg.h +++ b/drivers/net/wireless/realtek/rtw88/reg.h @@ -483,6 +483,8 @@ #define REG_DRVERLYINT 0x0558 #define REG_BCNDMATIM 0x0559 #define REG_ATIMWND 0x055A +#define ATIMWND_DEFAULT 0x2 +#define ATIMWND_AP 0xa #define REG_USTIME_TSF 0x055C #define REG_BCN_MAX_ERR 0x055D #define REG_RXTSF_OFFSET_CCK 0x055E --=20 2.55.0