From nobody Fri Sep 25 18:21:33 2026 Received: from DM1PR04CU001.outbound.protection.outlook.com (mail-centralusazon11010010.outbound.protection.outlook.com [52.101.61.10]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 4F3C856855D; Wed, 9 Sep 2026 14:21:34 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=fail smtp.client-ip=52.101.61.10 ARC-Seal: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1788963695; cv=fail; b=GFp6PnWsnvN2gSUGCy0dy8c7IgBloG3GSXVySKVFw4jvjnehGmRFpKj33SxyhcxeaVcGj80bMiRDXG62azTkBjZKJuykgSD7maZsFJmfBR7olX4h7iudx1+ZNbl6EqsTZRSO73/W5rzx4pCOwkQeU2zKNUZrD3RC2dFnTnj6+RY= ARC-Message-Signature: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1788963695; c=relaxed/simple; bh=AGXlSBdQ7yc/+sQDAbQXrAc8mKtbz0L8CIU/E7SPIgY=; h=From:To:CC:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=MV7OgHZd3+ZyM4HSUjUyJyd11p9abKoB5h53jAzYdvm/msWDtqbCmJTPidzSbiHksBMBqo5kltlJrnIwD+t0kiJn+m2STt1Z850N1WKw3/SkBeeon4sR5oV6HTtl71wn+h6t+G0GBj4xDA/iOmE233czdog/66etzL57R4vZc3g= ARC-Authentication-Results: i=2; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=amd.com; spf=fail smtp.mailfrom=amd.com; dkim=pass (1024-bit key) header.d=amd.com header.i=@amd.com header.b=qq04ST0m; arc=fail smtp.client-ip=52.101.61.10 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=amd.com Authentication-Results: smtp.subspace.kernel.org; spf=fail smtp.mailfrom=amd.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=amd.com header.i=@amd.com header.b="qq04ST0m" ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=f+RISE3mWOqiTUu4ZRaFqpj4kcoyzQ00G8PgAqpm9tzGe/7usIuPam+gmLSk5Q9wW61P2Bk8p1JziL+HpKRTIg4sbfEJHGIDRvScDFaJFfp2A9H2Qv6mDbpuUB9AE+LnJeAOSgFmBjXupbZKaFc1hE4+gOw3zqmmGpBJ7PcichIc46SyR9kik83EN/W9CSHqgzcrOGxuxqd3Y0wI9mOZ8j32qKNBOa2xtCwh+FTX5f1abV9TC53g2pA2cmqYLX3dnHYQmXmCet0gvTBOP3AbT4KTZYD/yBH7xl5ox70X5ONeuiyjpITgvadei/VAF2f+6dxkv/Xcy7MkF7S6I2lMyQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=HEMM4i2YvMOqxg00tn0W8VjYzkEBhEyZ8Hkr5mIvyoM=; b=misQj8C0pDjjgk86yHEhjrmaLO8qyj15hGCsHhybttuOZnLxT96oZb1W/i0+W0inOB9weT2WqDult0vZgWC6BWWvpzVZ5fm5t890t5RU4yzSUogYQzDgiRytaamlSoJr5DxKT0Q8PIunNcAs0BIN8/L8NwEkFktmPVkuxWpULnGnZ2j3chQYT5/PGbaa0Pan3cTP/Ibhk87AU/6G0pvgQPUSjr4RHXClOeWL6R/qWfBZ8OiOmE+ZtHvAH40SJHhKH2qw2tLhGN753aYmnb50ycQIP2bou7FMZfb7EQRYu+oc1yxzGjDpNJiFgJOCdRDtsq8sggk2OAhpCb7a0ZWQfQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 165.204.84.17) smtp.rcpttodomain=bootlin.com smtp.mailfrom=amd.com; dmarc=pass (p=quarantine sp=quarantine pct=100) action=none header.from=amd.com; dkim=none (message not signed); arc=none (0) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=HEMM4i2YvMOqxg00tn0W8VjYzkEBhEyZ8Hkr5mIvyoM=; b=qq04ST0ma+kXcOwzYvIHF47beWpo7+/UFyHMl1wIFu2uQmsl1WyYxqWbRed0KMd8eJaj/Vu70MqZLcfeXZgC5ILuKxRkEUIyFVF1dSe2XHElkazIuySVtHBF5/z4GeyLZTIJFo09P6DNoshBx2JzNh6skY2WDFGyhPHZsfSRQtM= Received: from SJ0PR03CA0048.namprd03.prod.outlook.com (2603:10b6:a03:33e::23) by IA1PR12MB8080.namprd12.prod.outlook.com (2603:10b6:208:3fd::6) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.21.406.8; Wed, 9 Sep 2026 14:21:24 +0000 Received: from SJ1PEPF000037BB.namprd05.prod.outlook.com (2603:10b6:a03:33e:cafe::7d) by SJ0PR03CA0048.outlook.office365.com (2603:10b6:a03:33e::23) with Microsoft SMTP Server (version=TLS1_3, cipher=TLS_AES_256_GCM_SHA384) id 15.21.406.8 via Frontend Transport; Wed, 9 Sep 2026 14:21:23 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 165.204.84.17) smtp.mailfrom=amd.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=amd.com; Received-SPF: Pass (protection.outlook.com: domain of amd.com designates 165.204.84.17 as permitted sender) receiver=protection.outlook.com; client-ip=165.204.84.17; helo=satlexmb07.amd.com; pr=C Received: from satlexmb07.amd.com (165.204.84.17) by SJ1PEPF000037BB.mail.protection.outlook.com (10.167.244.202) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.21.406.5 via Frontend Transport; Wed, 9 Sep 2026 14:21:22 +0000 Received: from satlexmb07.amd.com (10.181.42.216) by satlexmb07.amd.com (10.181.42.216) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.2562.46; Wed, 9 Sep 2026 09:21:03 -0500 Received: from xhdvineethc40.xilinx.com (10.180.168.240) by satlexmb07.amd.com (10.181.42.216) with Microsoft SMTP Server id 15.2.2562.46 via Frontend Transport; Wed, 9 Sep 2026 09:21:00 -0500 From: Vineeth Karumanchi To: , , , , , , CC: , , , Subject: [PATCH net-next v2 1/4] net: macb: Rename MACB_CAPS_QBV to MACB_CAPS_TC Date: Wed, 9 Sep 2026 19:50:53 +0530 Message-ID: <20260909142056.1433875-2-vineeth.karumanchi@amd.com> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20260909142056.1433875-1-vineeth.karumanchi@amd.com> References: <20260909142056.1433875-1-vineeth.karumanchi@amd.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: SJ1PEPF000037BB:EE_|IA1PR12MB8080:EE_ X-MS-Office365-Filtering-Correlation-Id: ce9791ff-3bb8-4c7b-88eb-08df0e7d9fe7 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|376014|82310400026|23010399003|1800799024|36860700016|10067099003|11063799006|5023799004|56012099006|22082099003|18002099003; X-Microsoft-Antispam-Message-Info: NRLRjfb4Wfche6bu5c7wui0h6WkyypaHiYRFQXVgevMwCcuAhKbjo5fmBTs92euDrYMBiEaeiUvit+OEAcTn5Er4ih31G4pEfx0G8O3OFkbtuxJt0LmLvAATmvIPnhzmyS6JkeZEiuIXJ6riNAnaatyKbDlpMAdmbVuCQAQcST1b9g8OnyjvcG/J3BjP3UoBFMe4QIBBGzKfc/waZo5JQ8fEQFPH1U13Uyz//H+/0hO7uxy2eWwjBz+FvPZuGPVP9ch1Fjq25pqn/uT1gjiK96JV+jqAtY+X2ppRznu51Z+rM8h0kX6tOZqpfDebEAR++S5ehn2sdiE18414oEPM0WAij0CfO9EiFCc3TsGaFoIeMkbiq+NYrLw5mUXAp5ZgZ6Jw7QojXGe6yxKn7HVNeJIZjUuJdNRDA+bbM5cm81voBj7QLoP3R6K//+Z2F2C0WBBswOdbxnsblVO8dWjFUSudXzG86itUvrGfLqHuF7UVq0BX+y7hw/R4YObxJeee8HmeWAX42DO0mETzqsrkE+3DQZhuupupMmdkadGqBdjpEvUj53zU8EBwShXE91atc8dEOch85wuLDvvEJaG1NVctkiydycxK4DUQk6h1zM2tfYUTc7TBk/BbpKRFYeULsT0oqiqHSCUEIPw/hnUlnNwcyryAe2JFi9TcXRC+y7zitE2edKQ7PojYsizezA0MdTqGHElOgUve5fm0K48I1w== X-Forefront-Antispam-Report: CIP:165.204.84.17;CTRY:US;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:satlexmb07.amd.com;PTR:InfoDomainNonexistent;CAT:NONE;SFS:(13230040)(376014)(82310400026)(23010399003)(1800799024)(36860700016)(10067099003)(11063799006)(5023799004)(56012099006)(22082099003)(18002099003);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: nsf00pEWAQFwGCYwda2evhki6gwEzguyFvOKNX/vftnWFZdf9Dsh+m8la5UPUZzwYOJpygmWtWv75NaSynAZJbRLXDNH7XkJ2CStQQKf19W3I37BWk21p10OjrviBGtnmwYDbtvCSiA8AS6yr0vK1Qo0MVkee4Wq/11g7pCOny6QVmCBsGdZyefMhj64iJD/IiXbHycKrJQpiCxCGsZgbP2dg6WrPEIulg8NzwpKa98DSzV0VICd0ghJ84CEJp76lAlCSuS86MRy/djYp+wTDJ9TD7k+FdyQbtBusXIKQ0XsZQPJ6n9N8h2DhEsvO0OfCGKG4/lZHtmK6RdLZ/073raQ8phc1PBWUpWHtI69fnHqGZQQ+O7rCLBkbToUcD8AAVWtBjG3xlfIa9erOrQn0PXS8qLBvNbzrDVPddUljlijWT3iWq2nchBTG1clHuP+ X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 09 Sep 2026 14:21:22.5079 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: ce9791ff-3bb8-4c7b-88eb-08df0e7d9fe7 X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=3dd8961f-e488-4e60-8e11-a82d994e183d;Ip=[165.204.84.17];Helo=[satlexmb07.amd.com] X-MS-Exchange-CrossTenant-AuthSource: SJ1PEPF000037BB.namprd05.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: IA1PR12MB8080 Content-Type: text/plain; charset="utf-8" The MACB_CAPS_QBV capability flag was originally introduced to gate TAPRIO/QBV support. However, GEM IP versions that support QBV also implement multiple TSN clauses. Replace this with a generic capability flag that can be reused by other TSN features. Rename MACB_CAPS_QBV to MACB_CAPS_TC to better reflect its role as a general traffic-class offload capability. The supported TSN clauses are handled through macb_setup_tc(). Signed-off-by: Vineeth Karumanchi Reviewed-by: Th=C3=A9o Lebrun --- Changes in v2: - No functional change; rebased on net-next. drivers/net/ethernet/cadence/macb.h | 2 +- drivers/net/ethernet/cadence/macb_main.c | 6 +++--- 2 files changed, 4 insertions(+), 4 deletions(-) diff --git a/drivers/net/ethernet/cadence/macb.h b/drivers/net/ethernet/cad= ence/macb.h index d6931c41f39d..f5359549f3d4 100644 --- a/drivers/net/ethernet/cadence/macb.h +++ b/drivers/net/ethernet/cadence/macb.h @@ -768,7 +768,7 @@ #define MACB_CAPS_MIIONRGMII BIT(9) #define MACB_CAPS_NEED_TSUCLK BIT(10) #define MACB_CAPS_QUEUE_DISABLE BIT(11) -#define MACB_CAPS_QBV BIT(12) +#define MACB_CAPS_TC BIT(12) #define MACB_CAPS_PCS BIT(13) #define MACB_CAPS_HIGH_SPEED BIT(14) #define MACB_CAPS_CLK_HW_CHG BIT(15) diff --git a/drivers/net/ethernet/cadence/macb_main.c b/drivers/net/etherne= t/cadence/macb_main.c index a427a5b9d894..8223ad81215b 100644 --- a/drivers/net/ethernet/cadence/macb_main.c +++ b/drivers/net/ethernet/cadence/macb_main.c @@ -4823,8 +4823,8 @@ static int macb_init_dflt(struct platform_device *pde= v) netdev->hw_features |=3D NETIF_F_HW_CSUM | NETIF_F_RXCSUM; if (bp->caps & MACB_CAPS_SG_DISABLED) netdev->hw_features &=3D ~NETIF_F_SG; - /* Enable HW_TC if hardware supports QBV */ - if (bp->caps & MACB_CAPS_QBV) + /* Enable TC offload for TSN-capable hardware */ + if (bp->caps & MACB_CAPS_TC) netdev->hw_features |=3D NETIF_F_HW_TC; =20 netdev->features =3D netdev->hw_features; @@ -5693,7 +5693,7 @@ static const struct macb_config versal_config =3D { .caps =3D MACB_CAPS_GIGABIT_MODE_AVAILABLE | MACB_CAPS_JUMBO | MACB_CAPS_GEM_HAS_PTP | MACB_CAPS_BD_RD_PREFETCH | MACB_CAPS_NEED_TSUCLK | MACB_CAPS_QUEUE_DISABLE | - MACB_CAPS_QBV | + MACB_CAPS_TC | MACB_CAPS_USRIO_HAS_MII, .dma_burst_length =3D 16, .init =3D init_reset_optional, --=20 2.43.0 From nobody Fri Sep 25 18:21:33 2026 Received: from CY7PR03CU001.outbound.protection.outlook.com (mail-westcentralusazon11010034.outbound.protection.outlook.com [40.93.198.34]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 0DC7E583AAC; Wed, 9 Sep 2026 14:21:37 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=fail smtp.client-ip=40.93.198.34 ARC-Seal: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1788963699; cv=fail; b=f7q8lRhXyxl8MGdsWsfrmIaJ2ydGjmNf5QOit6n5HzulR7PFVnM7qVN5/xH0lNdjhTn5Y52HYyEtoQNpNBpkeZwCFbR52Rbntp+IMqV+a7Fjlt5FWF1PyTDEt4STU6xQGdGPUM+XCheZVxjOkE7Z67edOsROgwqIMKQ/FmhGcWA= ARC-Message-Signature: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1788963699; c=relaxed/simple; bh=rsqzPeqvQxomQx2X+fY8O361BifKnNMZJI98REfK+TU=; h=From:To:CC:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=QRMkEBbFUFHMJyLnj8SNiXJ/7zWXWUDjNoDAcnSoGlmgCPKMvIOOYOZ92eMEfpWfP7dWZEtfBiH2+Fp6Jq1h7zW+m1wiCn2rrr8irxOWi0IIqr3W4GeNvgYYid1lIsGnXurKreY+NoC2iOvvuBxQvo7jtLlWlKL6Wj2s2xf/GWA= ARC-Authentication-Results: i=2; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=amd.com; spf=fail smtp.mailfrom=amd.com; dkim=pass (1024-bit key) header.d=amd.com header.i=@amd.com header.b=q6FrWG1Y; arc=fail smtp.client-ip=40.93.198.34 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=amd.com Authentication-Results: smtp.subspace.kernel.org; spf=fail smtp.mailfrom=amd.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=amd.com header.i=@amd.com header.b="q6FrWG1Y" ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=HjouS6skrHmBsl8RqpnOnicrmedxM+X6DyWiwtUJBqxY0uQ+9DPg9Re7HiMOIv57TJhIr/Dz8SALLceHxljPLJrwUbYDc0Ga3uXcc9ZEGXfGGfpRkv1ilG+sPlvC3sXjDhEeB4HIhIJGEbc6xnF0RE7KpmEnvQLHJKUNvbFq0AoCsJYwuFFmzD8k6vYKFe18AFwiIUHYsXNUxfMhPjMpcL3yrB5yqpmFtvl5rA+NUCH7YhLqr3qbwQj6SVMA7ncqW36JKuKRejGDbtK7cPueJJ1/A/IQ+drquTeDQaoMd26KjI/JC98uiLsWuw7Ga99gRRzojSTml7is2+qloFzcFQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=YEwmXTD73KeYoMHw7cygkFHM2inYbhhAk+o81Q3+97U=; b=ARejUCgx+HhnB5xyDHuIHbmhdq+UqciQGu0zVqLxiRt6oGpfb4qQI0R+3LfdzO4zdyOWkjk5U8vCj0IpouvVOOX9j29Q3okqqJirtIMl7ZUFcgFSbpSE2dbAb05adrYWwsqXiMttQ/MZunLbsPRIfHKNl1oKREylWeGTeQacdRY9HV/UXMFiC9R19oMlBz8DzTDXhC1wZXBWpuyHa7p11tobQmKh3TaO7vEFkOHdzqbCOHy47x2Qb7MGdSDEjhfLz5Y//p4ZwAOuZrAVx4mVQ6JuQYAiS3ZAd5rKEMXyT+e6dteINjyO+6b1q5nqh9QISleYVvs9UshMpxY9W4hPtA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 165.204.84.17) smtp.rcpttodomain=bootlin.com smtp.mailfrom=amd.com; dmarc=pass (p=quarantine sp=quarantine pct=100) action=none header.from=amd.com; dkim=none (message not signed); arc=none (0) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=YEwmXTD73KeYoMHw7cygkFHM2inYbhhAk+o81Q3+97U=; b=q6FrWG1YiXTzw2NXsDessNYrdUQ7MxMYhF/vok31i335FvOoOC2AzDF36dOLYHOW5KT7M50AaZLs4LVRdeCrbCgvUDRtDXSALxZ/JtW5evowvtZ8TMwE9d0tFtl2VYvkpdswPItinyER+HuPVD5cJzlWBc4YzEXjjunodMf9s9o= Received: from SJ0PR03CA0153.namprd03.prod.outlook.com (2603:10b6:a03:338::8) by SN7PR12MB6744.namprd12.prod.outlook.com (2603:10b6:806:26c::13) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.21.406.8; Wed, 9 Sep 2026 14:21:32 +0000 Received: from SJ1PEPF000037B8.namprd05.prod.outlook.com (2603:10b6:a03:338:cafe::98) by SJ0PR03CA0153.outlook.office365.com (2603:10b6:a03:338::8) with Microsoft SMTP Server (version=TLS1_3, cipher=TLS_AES_256_GCM_SHA384) id 15.21.406.7 via Frontend Transport; Wed, 9 Sep 2026 14:21:30 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 165.204.84.17) smtp.mailfrom=amd.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=amd.com; Received-SPF: Pass (protection.outlook.com: domain of amd.com designates 165.204.84.17 as permitted sender) receiver=protection.outlook.com; client-ip=165.204.84.17; helo=satlexmb07.amd.com; pr=C Received: from satlexmb07.amd.com (165.204.84.17) by SJ1PEPF000037B8.mail.protection.outlook.com (10.167.244.197) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.21.406.5 via Frontend Transport; Wed, 9 Sep 2026 14:21:28 +0000 Received: from satlexmb10.amd.com (10.181.42.219) by satlexmb07.amd.com (10.181.42.216) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.2562.46; Wed, 9 Sep 2026 09:21:07 -0500 Received: from satlexmb07.amd.com (10.181.42.216) by satlexmb10.amd.com (10.181.42.219) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.2562.46; Wed, 9 Sep 2026 09:21:06 -0500 Received: from xhdvineethc40.xilinx.com (10.180.168.240) by satlexmb07.amd.com (10.181.42.216) with Microsoft SMTP Server id 15.2.2562.46 via Frontend Transport; Wed, 9 Sep 2026 09:21:03 -0500 From: Vineeth Karumanchi To: , , , , , , CC: , , , Subject: [PATCH net-next v2 2/4] net: macb: Move TC capability and PM checks to macb_setup_tc() Date: Wed, 9 Sep 2026 19:50:54 +0530 Message-ID: <20260909142056.1433875-3-vineeth.karumanchi@amd.com> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20260909142056.1433875-1-vineeth.karumanchi@amd.com> References: <20260909142056.1433875-1-vineeth.karumanchi@amd.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: SJ1PEPF000037B8:EE_|SN7PR12MB6744:EE_ X-MS-Office365-Filtering-Correlation-Id: 1559fa65-a7b4-4b67-902a-08df0e7da3a8 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|376014|82310400026|1800799024|23010399003|36860700016|10067099003|56012099006|11063799006|18002099003|22082099003; X-Microsoft-Antispam-Message-Info: yo1mxy+8ypwv2E6zMgFNx/Y+xd+vE4GS0ymqA8SylsMHrsRVLcusGQe1QuT493OpWwfbPGYUNm4wt4cz7vVq7viM4Vvu32kz4VnEh8xdriOTxUbg9BxsDSBtrdNeIcyJZFxcXza4EXKwlFf0HSmVrgVIv8yOip74mDZW4Tmt+VGOfY0+fOod+He/Eg07Ot46spOz1JuFjDltelKQPWJnZQeQ+A4nb+I2/CvKqjzhHSEFT4L494g4c9hJq8jZkOYtiF3DGZ/24MPoAyO2hor0HJsxKQ1HlfnIYLtgaSSCFoWWThylD+lSMHy3AdiXoZoJ2fnVNdgc15DJtIM+gIyKlFFzHmO88t44Ej97Rkrx0ibRmB/wDHOG5bNpLL95j/ArEZHIxv27UI8hsYAiiuwcJ2HHC1ynf4Gk+9La2rFIVzvCe7cBfmh4Zl35xXOER+y7LVoVyJ39DL5aQyhUy0h80uZ6mZTq848dHAIjMrN7Fx6EMnvej11SBjwFNwp7dcxKvrQEZHSKdUiDO8E6qiByZslk8P1rothncz0oRIRL3yzGIZIXeKfw5ngb37gGPYKFy+NJ43/5ZFg1BpAl4it57Bx2Sn7BmGR8iR3QKqw1UIMGP6/0hUYl0b8EDmAEQ6GUEOLyMo8zuyHszk3ZvZ2WnYl4RXZqOjbNV3xwCcFz/lbKSB/gsyC1xp91FRKX33ScCpn3GVTOthEuesgJsUYLiQ== X-Forefront-Antispam-Report: CIP:165.204.84.17;CTRY:US;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:satlexmb07.amd.com;PTR:InfoDomainNonexistent;CAT:NONE;SFS:(13230040)(376014)(82310400026)(1800799024)(23010399003)(36860700016)(10067099003)(56012099006)(11063799006)(18002099003)(22082099003);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: Z/i1xst8/Sn3rZsL19Tz1XY5OaWTFX3ichvJoK3HzbIBXx0UCdEnxkAxfzZR6EYqkvsADAe2ZbZKPZ0M5k9LB5Zi40pNG8dyneyrwYN6EA3JV6Hxz0CHpMHnj1Kivzj+Wkob8dMIPK4vkqItKG5XsahT/6iL7uBvYBjOoRoigylUDFWlZHSlozzVK3aIj5RfXj018MaMb5Ph+2z4bF/+d5vZJoxuKR1YGo0Cnf64yQwXzTV/87PB8kdiMrQQY1U9s0TCJb7WSt1g+LU6zy+DAm/BvjHmgrsz9S4UpHslF280x7D8A7pyPsaWPdyDhNUExR1ALp4jNdXalR3iGlNk8cZB206ToFte4Yky7Igvt1ha1e6xuxuTwTGh/R/okpn9M9+S7LFLpeMKZ+hhEBa4/tj+exL6GdTiBLRRojYcFrsZSqNPBjMfbtg7JyhwgOIj X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 09 Sep 2026 14:21:28.8044 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 1559fa65-a7b4-4b67-902a-08df0e7da3a8 X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=3dd8961f-e488-4e60-8e11-a82d994e183d;Ip=[165.204.84.17];Helo=[satlexmb07.amd.com] X-MS-Exchange-CrossTenant-AuthSource: SJ1PEPF000037B8.namprd05.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: SN7PR12MB6744 Move the NETIF_F_HW_TC capability check and the runtime PM suspend guard from macb_setup_taprio() into the common macb_setup_tc() entry point. These preconditions apply to all hardware TC offload paths routed through ndo_setup_tc(), not just TAPRIO. Centralizing them avoids duplicating the same checks as new TC qdisc types are added. Signed-off-by: Vineeth Karumanchi Reviewed-by: Th=C3=A9o Lebrun --- Changes in v2: - No functional change; rebased on net-next, which renamed the struct net_device pointer to "netdev" (was "dev"). drivers/net/ethernet/cadence/macb_main.c | 23 +++++++++++++---------- 1 file changed, 13 insertions(+), 10 deletions(-) diff --git a/drivers/net/ethernet/cadence/macb_main.c b/drivers/net/etherne= t/cadence/macb_main.c index 8223ad81215b..ff7e02d3fab8 100644 --- a/drivers/net/ethernet/cadence/macb_main.c +++ b/drivers/net/ethernet/cadence/macb_main.c @@ -4476,18 +4476,8 @@ static void macb_taprio_destroy(struct net_device *n= etdev) static int macb_setup_taprio(struct net_device *netdev, struct tc_taprio_qopt_offload *taprio) { - struct macb *bp =3D netdev_priv(netdev); int err =3D 0; =20 - if (unlikely(!(netdev->hw_features & NETIF_F_HW_TC))) - return -EOPNOTSUPP; - - /* Check if Device is in runtime suspend */ - if (unlikely(pm_runtime_suspended(&bp->pdev->dev))) { - netdev_err(netdev, "Device is in runtime suspend\n"); - return -EOPNOTSUPP; - } - switch (taprio->cmd) { case TAPRIO_CMD_REPLACE: err =3D macb_taprio_setup_replace(netdev, taprio); @@ -4505,9 +4495,22 @@ static int macb_setup_taprio(struct net_device *netd= ev, static int macb_setup_tc(struct net_device *netdev, enum tc_setup_type typ= e, void *type_data) { + struct macb *bp; + if (!netdev || !type_data) return -EINVAL; =20 + bp =3D netdev_priv(netdev); + + if (unlikely(!(netdev->hw_features & NETIF_F_HW_TC))) + return -EOPNOTSUPP; + + /* Check if Device is in runtime suspend */ + if (unlikely(pm_runtime_suspended(&bp->pdev->dev))) { + netdev_err(netdev, "Device is in runtime suspend\n"); + return -EOPNOTSUPP; + } + switch (type) { case TC_SETUP_QDISC_TAPRIO: return macb_setup_taprio(netdev, type_data); --=20 2.43.0 From nobody Fri Sep 25 18:21:33 2026 Received: from SN4PR0501CU005.outbound.protection.outlook.com (mail-southcentralusazon11011055.outbound.protection.outlook.com [40.93.194.55]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 228565964E0; Wed, 9 Sep 2026 14:21:44 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=fail smtp.client-ip=40.93.194.55 ARC-Seal: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1788963706; cv=fail; b=s7AIIWDZboEa3iLNopYzr/zB+72uP+2dWP+VAqWVnvQvoU2QJ/j50c8XKMVA1OfVnBVzjicuZD+Ey74QZLmaWRF8zzHNJqM7npQN8IAZ9xvxR16T4NWHkIcjvY6wb5pdl61zqjx//EwSb4GpWZ+rnfd0h0X8m35H9xS0bEeWBsk= ARC-Message-Signature: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1788963706; c=relaxed/simple; bh=n/Emb784ujvTbfD5TJTYVWkQz17F79Dg01+7Csb97+o=; h=From:To:CC:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=haBTgA7UrFvFu1XAWX6vy0x+0Wrad0OIIBSbRuVNLjJt8SnMvOdi6dvS7C+j8bheAZTb+MGNTRknXiXv3fwk0Uj8AErwVlIzf+mHb+H8KNYVbXf3eMFAg4x+x1uZg+07lPc2JQApZJrLNCAn6LbSFPz24Wo8sXHU6ibenDEXwpo= ARC-Authentication-Results: i=2; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=amd.com; spf=fail smtp.mailfrom=amd.com; dkim=pass (1024-bit key) header.d=amd.com header.i=@amd.com header.b=3tH6VCoL; arc=fail smtp.client-ip=40.93.194.55 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=amd.com Authentication-Results: smtp.subspace.kernel.org; spf=fail smtp.mailfrom=amd.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=amd.com header.i=@amd.com header.b="3tH6VCoL" ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=NM/8y4VaxHA3NFJNcfB0HkFrDN8V29zUFxIEvtLSiQh6FJ7sDAQ7ED1qRoXFG7JsgMEfy8Gsl07lLb7b9Yvo5SSK0wfzudn60+W8fNYy0m8iA4aoGui2pVHEqqLQ4MPN1/hdskCACv3R92cOOpOurM0rq9E0j+ND7GRAtSPxRN20uxyut5JcV3Ck4WffGnnpVgEcM65XS6j+AsMFZs5UJCJmMLRDF4jAthsH+Oh4bMO1oNvum+s+v3fAevAILR85L22W6V2/S5uZIBEl2sKw+S16RKedbklX/4n7FddM8idqCmXUUJoaxfxPwjvCGHExqBk1bBT9Zu29Hfm3KoE9Bw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=7E/kv/H5ufDQ85jNTsAkh48mf3JkECJWRHkbqHnSx7k=; b=BxmrBMt7+l9QP/3bpvYR26raLC/ArQc8EiTKySLRx/gP1wP4FavjXpbt1wm0QQ4pw7g8w3mI0JLzwpDs0M/59mu9R1ReGDOnSWsrljkO7UujpfNq3Qm7kFGH8PWUKv6sNJnr/LA6qhELzL1daERWvWSRCF9LlYy0VanfRTFQCCHbY7zWnvUFs07E3+KhqYwvic2EEF0jEGFm6vGlfGQBYIVF08bcdUyH3McT6fjZLLQFAqiBnnOXvKa/9G1f3flgMHCZ8eRYxC6qWQj3ZpHKmt07I/v5X3QMlFDHzER2eSwjEpPo8NVtTL49n737EK/JI8c0z4yGhsOvD8W9d9aNTA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 165.204.84.17) smtp.rcpttodomain=bootlin.com smtp.mailfrom=amd.com; dmarc=pass (p=quarantine sp=quarantine pct=100) action=none header.from=amd.com; dkim=none (message not signed); arc=none (0) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=7E/kv/H5ufDQ85jNTsAkh48mf3JkECJWRHkbqHnSx7k=; b=3tH6VCoL+TIRG597GiItf6rQFKaMRpKSlKmUcOIpxM2BTiSGNijm4kIqFyVENQVUOHdmolIJJ9Q58DAhKS1dAK+uNnU9do8i8i/t/5Uq2eq+ogkg20Br+ToJHVjeABy8ZXj4vSmt7fWP9zOPQbWsADt/FxM7sFXvtlyrp/pCL8o= Received: from SJ0PR03CA0036.namprd03.prod.outlook.com (2603:10b6:a03:33e::11) by SN7PR12MB7977.namprd12.prod.outlook.com (2603:10b6:806:340::9) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.21.406.7; Wed, 9 Sep 2026 14:21:37 +0000 Received: from SJ1PEPF000037BB.namprd05.prod.outlook.com (2603:10b6:a03:33e:cafe::7b) by SJ0PR03CA0036.outlook.office365.com (2603:10b6:a03:33e::11) with Microsoft SMTP Server (version=TLS1_3, cipher=TLS_AES_256_GCM_SHA384) id 15.21.406.8 via Frontend Transport; Wed, 9 Sep 2026 14:21:37 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 165.204.84.17) smtp.mailfrom=amd.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=amd.com; Received-SPF: Pass (protection.outlook.com: domain of amd.com designates 165.204.84.17 as permitted sender) receiver=protection.outlook.com; client-ip=165.204.84.17; helo=satlexmb07.amd.com; pr=C Received: from satlexmb07.amd.com (165.204.84.17) by SJ1PEPF000037BB.mail.protection.outlook.com (10.167.244.202) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.21.406.5 via Frontend Transport; Wed, 9 Sep 2026 14:21:36 +0000 Received: from satlexmb07.amd.com (10.181.42.216) by satlexmb07.amd.com (10.181.42.216) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.2562.46; Wed, 9 Sep 2026 09:21:09 -0500 Received: from xhdvineethc40.xilinx.com (10.180.168.240) by satlexmb07.amd.com (10.181.42.216) with Microsoft SMTP Server id 15.2.2562.46 via Frontend Transport; Wed, 9 Sep 2026 09:21:07 -0500 From: Vineeth Karumanchi To: , , , , , , CC: , , , Subject: [PATCH net-next v2 3/4] net: macb: Add MQPRIO qdisc hardware offload support Date: Wed, 9 Sep 2026 19:50:55 +0530 Message-ID: <20260909142056.1433875-4-vineeth.karumanchi@amd.com> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20260909142056.1433875-1-vineeth.karumanchi@amd.com> References: <20260909142056.1433875-1-vineeth.karumanchi@amd.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: SJ1PEPF000037BB:EE_|SN7PR12MB7977:EE_ X-MS-Office365-Filtering-Correlation-Id: 8022ee94-0084-4807-2ba4-08df0e7da824 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|376014|23010399003|36860700016|82310400026|1800799024|11063799006|10067099003|22082099003|18002099003|6133799003|56012099006; X-Microsoft-Antispam-Message-Info: fF6VSyTVdEQg1BLXVJRvsCxJN43c57RiE3CacYuVU+a9ss/D7owTnBJuYmyAOmHyKzUXGmGH/Ip5Ct1jSfls+bNd3Ia4CKUaPe991GXCkMduwcdJ17uBuRAMAo9tdVrZFj+/yIZSL7n4l0zPZYpKj2JwTUVSPMOUBgWIh6zXv2E3vXnWnx98FaVcLoEA9s896oAikZz67FaewUu5gGPeb30MAfQx8wfEoW0tfz0p4aTXu2R1D9hhRS+2NiMkUD9ihgOUyTFEXS0lPt3jVUgBXWSTpW2Wrgv5LrUUMMJ0+tz5PJjyXaTD5JhExC+COAP2VV/qbFGTR35AgOQP1lZcfwzAE/epacEeYNKTzXh2HBiGTFEEpereB7nnXm4JdrUTOQNGCoXpSO75XJpTXJtI+mlTkoLCpeFwaRneIDs6PQkYDaaudIdyd5QRy75HhI2vCIhBTjoJDb8kXN3JF6xBg+LNd7lyC+bnEq2ganYcjdHjA/BjV33e3p96ea7bnkDFeXs6ODItpS3OTZ4x9Lf3LRHfGSZSjFzhs8R4Wz2Cgd1K63otvgvyBEpsyI0RYbfPS7m5UARL990ILZHwFKekEmWqBonRtcAcxXv3hSoXLl79FWlXtDvC7LSH+lc8wlr3nlOwKa8F/I3hbiXPQOOuMSvix9PJnEk5wsewGH9AiOUj2tes5og0CZUjVlsiqZ6XULBAkdvKZzWGj6kqv6JKqg== X-Forefront-Antispam-Report: CIP:165.204.84.17;CTRY:US;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:satlexmb07.amd.com;PTR:InfoDomainNonexistent;CAT:NONE;SFS:(13230040)(376014)(23010399003)(36860700016)(82310400026)(1800799024)(11063799006)(10067099003)(22082099003)(18002099003)(6133799003)(56012099006);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: ulmo0QQzeSAdbHweQgUaNmWZr6oYcTSusDAp6IVulAbQfDH0aRvwXe0yv/1m9E5kj3T2Fa4yI1eB9qD6NuguvCz1V0ribUUrtaHleg5zSzkR9zUc1sfBxyKQyxphSMwJhU7DGnipmOZrAT0txgcxxBPhvMUwgGvdyvyNIwFdym5gENEk4bRSk/UlbP5WFSejDAzbNhjN6Vo8vP9RvTJRzTGOcBNHdVeIku1jFxhrS49VgOuTGaRSt/jL5WtEYFB1F/Zk0SEszVhT3+vMeWM9cr8Dkai4+cjqozYgczKSgY9w+0hhha2ITnYymo5ADqa1PFni/xyvJDo3PouDTLKTbmvcnEknTWgJauuFt0ELrWQQ5CW/yUUnMZZiJNuuthC4FV25Xw3WRqolDiCtZlEWOt5P8wah0EPk42a8ZIyj+QOtv0uf57K32+9eSzvq52Id X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 09 Sep 2026 14:21:36.3276 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 8022ee94-0084-4807-2ba4-08df0e7da824 X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=3dd8961f-e488-4e60-8e11-a82d994e183d;Ip=[165.204.84.17];Helo=[satlexmb07.amd.com] X-MS-Exchange-CrossTenant-AuthSource: SJ1PEPF000037BB.namprd05.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: SN7PR12MB7977 Content-Type: text/plain; charset="utf-8" Add support for TC_SETUP_QDISC_MQPRIO hardware offload, allowing traffic class to queue mapping via the mqprio qdisc. Implement macb_setup_mqprio() which configures TC-to-queue mappings through netdev_set_num_tc() and netdev_set_tc_queue(), and resets them when num_tc is zero. The driver advertises TC_MQPRIO_HW_OFFLOAD_TCS offload level. Add macb_tc_query_caps() to report mqprio capabilities. Setting validate_queue_counts to true delegates queue count and overlap validation to the mqprio core via mqprio_validate_queue_counts(), avoiding redundant checks in the driver. Signed-off-by: Vineeth Karumanchi --- Changes in v2: - No functional change; rebased on net-next, which renamed the struct net_device pointer to "netdev" (was "dev"/"ndev"). drivers/net/ethernet/cadence/macb_main.c | 59 ++++++++++++++++++++++++ 1 file changed, 59 insertions(+) diff --git a/drivers/net/ethernet/cadence/macb_main.c b/drivers/net/etherne= t/cadence/macb_main.c index ff7e02d3fab8..67150ff03066 100644 --- a/drivers/net/ethernet/cadence/macb_main.c +++ b/drivers/net/ethernet/cadence/macb_main.c @@ -4492,6 +4492,60 @@ static int macb_setup_taprio(struct net_device *netd= ev, return err; } =20 +static int macb_setup_mqprio(struct net_device *netdev, + struct tc_mqprio_qopt_offload *mqprio) +{ + struct tc_mqprio_qopt *qopt =3D &mqprio->qopt; + u8 num_tc =3D qopt->num_tc; + int err; + u8 i; + + /* Handle reset case early */ + if (!num_tc) { + netdev_reset_tc(netdev); + return 0; + } + + /* Configure traffic classes */ + qopt->hw =3D TC_MQPRIO_HW_OFFLOAD_TCS; + + err =3D netdev_set_num_tc(netdev, num_tc); + if (err) + return err; + + for (i =3D 0; i < num_tc; i++) { + err =3D netdev_set_tc_queue(netdev, i, qopt->count[i], + qopt->offset[i]); + if (err) + goto err_reset_tc; + + netdev_dbg(netdev, "MQPRIO: TC%d -> queue %u (count=3D%u)\n", + i, qopt->offset[i], qopt->count[i]); + } + + return 0; + +err_reset_tc: + netdev_reset_tc(netdev); + return err; +} + +static int macb_tc_query_caps(struct net_device *netdev, + struct tc_query_caps_base *base) +{ + switch (base->type) { + case TC_SETUP_QDISC_MQPRIO: { + struct tc_mqprio_caps *caps =3D base->caps; + + caps->validate_queue_counts =3D true; + + return 0; + } + default: + return -EOPNOTSUPP; + } +} + static int macb_setup_tc(struct net_device *netdev, enum tc_setup_type typ= e, void *type_data) { @@ -4500,6 +4554,9 @@ static int macb_setup_tc(struct net_device *netdev, e= num tc_setup_type type, if (!netdev || !type_data) return -EINVAL; =20 + if (type =3D=3D TC_QUERY_CAPS) + return macb_tc_query_caps(netdev, type_data); + bp =3D netdev_priv(netdev); =20 if (unlikely(!(netdev->hw_features & NETIF_F_HW_TC))) @@ -4512,6 +4569,8 @@ static int macb_setup_tc(struct net_device *netdev, e= num tc_setup_type type, } =20 switch (type) { + case TC_SETUP_QDISC_MQPRIO: + return macb_setup_mqprio(netdev, type_data); case TC_SETUP_QDISC_TAPRIO: return macb_setup_taprio(netdev, type_data); default: --=20 2.43.0 From nobody Fri Sep 25 18:21:33 2026 Received: from PH0PR06CU001.outbound.protection.outlook.com (mail-westus3azon11011029.outbound.protection.outlook.com [40.107.208.29]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 0ADAA4FDE6C; Wed, 9 Sep 2026 14:21:39 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=fail smtp.client-ip=40.107.208.29 ARC-Seal: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1788963701; cv=fail; b=pjfdUldbf/C6kgY2RMkU4LD2S5lXuztgw5k2yxNEoXovX6Y81rJjqubCBXHzAQggeDQUiSgLKhKQnbORmsHtjIrMSq4vnV3QSdcB/81pG8/Y9OHZ1GV+AkbwWVYPgXLijZ65S9BIBmml0NTJ53kfFZB4ZLOa5TBnCwab0zVK/Lw= ARC-Message-Signature: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1788963701; c=relaxed/simple; bh=0WmLsdwcaxue37QYZyE+IXGr0RVVK4X0Sf1TF0nbCzs=; h=From:To:CC:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=Lp299lV+JU50c6Bg5OtIz4hm3rTkapT821aBmjgJ9HEzG1HxAkztuzlXfEPopDnOoAmuXzJhHtCppO0W70CeH7TWDQxYv9Y9R83YZZou13Nkw5Q9S5SukQsz/fN74J/86WbMzElvZldG6q0t3JPLRiXADdW6hNO4WuhCkuKUgbc= ARC-Authentication-Results: i=2; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=amd.com; spf=fail smtp.mailfrom=amd.com; dkim=pass (1024-bit key) header.d=amd.com header.i=@amd.com header.b=h2EUX5tD; arc=fail smtp.client-ip=40.107.208.29 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=amd.com Authentication-Results: smtp.subspace.kernel.org; spf=fail smtp.mailfrom=amd.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=amd.com header.i=@amd.com header.b="h2EUX5tD" ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=ivw7R/MKala4J+B2SsXx6s9tRHOChoGX9MwUHVylIb9eowohsAosKbwXjLV5ko5cD4ZP5xKlQXp4QQkKT3aeuZDwGYa1+WILVEUlc8ca936Ysi7tMvf4RUunkL/810XZpCSlGXasKHzWg6nHgJsUMMqoz/18aY/2lwVfysgQqnrDGtHlAPOttyAmdrzcMZ5tW2qWlQpHFkMcDF9xZ6lu8MGJ7Xh8VvLIJRs8j9cCP4dydO9pwB+xb5PTbNO5YytWKizq2Q5Q1T2qolOg0ReKB3lmNwTh8PG9isF2u2PiN5A0kUA9SNr4aPii2u/xKpFqTgMtGeZHesqRg2QJXDGc7Q== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=5NigIkL758h7pcAEQtuknZ30I0V3RSsgMxXUGB3nzik=; b=CzQbcIUCazNYh/Du6tFH8TTnwNxcRvbcR2C35fD6F5mW8chEYT1IFuIY+LOEagktVym40eyAWP40HsXn9gTsWCuKqVI/ckpiC3CNlqdx9IV+vuWJDdc6kj5cJNkW5AK+z8ZKY7g3xylttvU994NWUlEH6PE8T56RHOvo4bu+CYju8hU3xi7z9SJ5I6qHvEO02/bJamrfNfpzJoXVJ2lbNOPJ04vQEY9UnpU1mn/Wcu0aAmCoQ9VGIdNeeMvDKe9WzcX8j5I353RdFm7bLP6klZxv7tkndezfW5hOMN2Ji3Sg6DFkCNRY5+S/TGIB0zjt81i7N3fhyebEpQ+qq0J49w== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 165.204.84.17) smtp.rcpttodomain=bootlin.com smtp.mailfrom=amd.com; dmarc=pass (p=quarantine sp=quarantine pct=100) action=none header.from=amd.com; dkim=none (message not signed); arc=none (0) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=5NigIkL758h7pcAEQtuknZ30I0V3RSsgMxXUGB3nzik=; b=h2EUX5tDjOutm4Q9H9s1PfA21To4ZHzIT6apcWeGMiYFgszgHZrXyfidJh7pTHB6sAi/Chkf0/gAUUNd9cVXz1rYzEkU0Xiu9/1ii5Lo5qsiFpAb5oXxNxAuE5RFrFPH+b7ctTT2ii6Ek9JDLbTPBmTMox4+7fAkOeaKrkeIkY0= Received: from SJ0PR03CA0176.namprd03.prod.outlook.com (2603:10b6:a03:338::31) by SJ0PR12MB5609.namprd12.prod.outlook.com (2603:10b6:a03:42c::12) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.21.406.8; Wed, 9 Sep 2026 14:21:37 +0000 Received: from SJ1PEPF000037B8.namprd05.prod.outlook.com (2603:10b6:a03:338:cafe::61) by SJ0PR03CA0176.outlook.office365.com (2603:10b6:a03:338::31) with Microsoft SMTP Server (version=TLS1_3, cipher=TLS_AES_256_GCM_SHA384) id 15.21.406.6 via Frontend Transport; Wed, 9 Sep 2026 14:21:37 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 165.204.84.17) smtp.mailfrom=amd.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=amd.com; Received-SPF: Pass (protection.outlook.com: domain of amd.com designates 165.204.84.17 as permitted sender) receiver=protection.outlook.com; client-ip=165.204.84.17; helo=satlexmb07.amd.com; pr=C Received: from satlexmb07.amd.com (165.204.84.17) by SJ1PEPF000037B8.mail.protection.outlook.com (10.167.244.197) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.21.406.5 via Frontend Transport; Wed, 9 Sep 2026 14:21:37 +0000 Received: from satlexmb07.amd.com (10.181.42.216) by satlexmb07.amd.com (10.181.42.216) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.2562.46; Wed, 9 Sep 2026 09:21:13 -0500 Received: from xhdvineethc40.xilinx.com (10.180.168.240) by satlexmb07.amd.com (10.181.42.216) with Microsoft SMTP Server id 15.2.2562.46 via Frontend Transport; Wed, 9 Sep 2026 09:21:10 -0500 From: Vineeth Karumanchi To: , , , , , , CC: , , , Subject: [PATCH net-next v2 4/4] net: macb: Add TSN CBS TC offload support Date: Wed, 9 Sep 2026 19:50:56 +0530 Message-ID: <20260909142056.1433875-5-vineeth.karumanchi@amd.com> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20260909142056.1433875-1-vineeth.karumanchi@amd.com> References: <20260909142056.1433875-1-vineeth.karumanchi@amd.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: SJ1PEPF000037B8:EE_|SJ0PR12MB5609:EE_ X-MS-Office365-Filtering-Correlation-Id: 8768f9df-2848-4e80-acff-08df0e7da8ad X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|376014|82310400026|36860700016|23010399003|1800799024|6133799003|10067099003|56012099006|11063799006|22082099003|18002099003; X-Microsoft-Antispam-Message-Info: SLrQ/EVPmzyMW61BeAncZwI+5ffWm0AnpAV09uicewcb0YZ4q03xjQkQfB1UCov6I4jxkfX5zeCuuD37ylJhjeAPHOgRlAzRHlIMG9wONjwJgI2pVgUgNNVLquxhLLtRJ/cl5kLnblAfsDPqMdsupcw/qC3RiiKNjewcv7kxipOtOcvkZ2K2Vo7VLGZEffcds463tnnDxPytm4wrAGlWG8CprbRADaIedQhmHVpAaNoI3SCLSyscmdd7vl22QCtf9YzCa2DxTAt26xQg9cS1srln/eFgXlAb9qYX6ZD2xoWUf5G9SbawYoxb+TDCyfU1y072a6eiPNUvtf+4HamXXqnEbOV9J7qK0hGsqSDh8FcnYHAu4IqcZEzEmZf+ML1yFdIVxivDpX4/jR97PYxu+w/yeeL2lsLV+vtSWyOE8kNu+JT5r8TNEY5FrR40RiNwIyffuNqIY6IlNujDeakmn7I8FtwOGdelpVLXOpVvk1pyR3fomdWE8gG2HKA9rlihdy/lOP655ZG3HVdp3Sv/PaY0yqILOfApypIEDmnq6Fifn5szvAn6dCkiImQP3DwKuI9473mE/e9qX1lcEf1RvA4GMssN2j+ZvvVjO99m4d8GJQ2cN0nR2eJkM1XSNIyvqtXlUxM2vEtBfC86aS+AXjzuDFouynlhfJHr9QAwNxRvdEh86mevf2rvB87EoCe6ZhOZlf14NU5nBkVnD2VcTA== X-Forefront-Antispam-Report: CIP:165.204.84.17;CTRY:US;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:satlexmb07.amd.com;PTR:InfoDomainNonexistent;CAT:NONE;SFS:(13230040)(376014)(82310400026)(36860700016)(23010399003)(1800799024)(6133799003)(10067099003)(56012099006)(11063799006)(22082099003)(18002099003);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: jao0KbNRI5t7Zs6ZGKTscWyV99yKecJlnmgb5k1IzAEAaWM992MwN/v7TTIvlbZe9soNEsGfbm2vUwh1HAFeMgw0f43cnUEU1iq/9pBwbaqWpdPNz+W6TltNR+Sz5506BGz71TBqZkGNpP7cvXbsWBODb9mqG75az3bLbxiMaJ3hkjvROnm4loYHvZgQKpKHFFpgAWyb78QzdX+BvdRDTO4ZhCNYDpYf29zGIBmbxUoHZLdmXdtCWH4Zc8P6fgSYyhWk1EJAJKfBLwmDQRK2wPk20pSfrOhWLLC3SVDpfQIzw3BvWTfBlrQvujtdTneLw+J8wPMwz/Z5gBIE8IrfAaCH6Bem3b0E4Nk3/rOe54SKk86+w8Nm67d+fWZmIBnwuz0Ku2CLV+jmViHCxjb/dKN/nb1cowKjx0BnH0ayvMALkh5u7O5Rv5j/Rr2Vb8/H X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 09 Sep 2026 14:21:37.2299 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 8768f9df-2848-4e80-acff-08df0e7da8ad X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=3dd8961f-e488-4e60-8e11-a82d994e183d;Ip=[165.204.84.17];Helo=[satlexmb07.amd.com] X-MS-Exchange-CrossTenant-AuthSource: SJ1PEPF000037B8.namprd05.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: SJ0PR12MB5609 Content-Type: text/plain; charset="utf-8" Add Credit-Based Shaper (CBS/IEEE 802.1Qav) TC offload support for time-sensitive networking on GEM hardware. CBS is restricted to the two highest-priority queues: Queue A (num_queues - 1) and Queue B (num_queues - 2), matching hardware capability. Validate that idleslope is positive and does not exceed the link speed, preventing negative values from bypassing the bounds check due to signed-to-unsigned promotion. The idle slope register value is computed differently based on hardware variant: High-speed GEM: scale idleslope linearly to the full 32-bit register range relative to link speed. Standard MACB: convert the kbps idleslope into the register's native unit, which depends on the interface width: - 1G (8-bit GMII): bytes/sec, scale kbps by 1000/8 (125) - 10/100M (4-bit MII): nibbles/sec, scale kbps by 1000/4 (250) Signed-off-by: Vineeth Karumanchi --- Changes in v2: - macb_cbs_get_queue_params() now returns the idleslope register offset (u32 *idleslope_reg) instead of a bool flag, and the idleslope is programmed via bp->macb_reg_writel(), dropping the per-queue if/else that open-coded gem_writel(CBS_IDLESLOPE_Q_A/Q_B). - Expanded the idleslope kbps-to-hardware-unit conversion comment. - Zero-initialize kset in macb_cbs_add() so an unpopulated link speed reads as 0 and is rejected; reorder locals to keep the declarations in reverse-christmas-tree order. - Rebased on net-next, which renamed the struct net_device pointer to "netdev" (was "dev"/"ndev"). drivers/net/ethernet/cadence/macb.h | 9 ++ drivers/net/ethernet/cadence/macb_main.c | 116 +++++++++++++++++++++++ 2 files changed, 125 insertions(+) diff --git a/drivers/net/ethernet/cadence/macb.h b/drivers/net/ethernet/cad= ence/macb.h index f5359549f3d4..20faeba77d6d 100644 --- a/drivers/net/ethernet/cadence/macb.h +++ b/drivers/net/ethernet/cadence/macb.h @@ -184,6 +184,9 @@ #define GEM_DCFG8 0x029C /* Design Config 8 */ #define GEM_DCFG10 0x02A4 /* Design Config 10 */ #define GEM_DCFG12 0x02AC /* Design Config 12 */ +#define GEM_CBS_CONTROL 0x04BC /* CBS Control Register */ +#define GEM_CBS_IDLESLOPE_Q_A 0x04C0 /* CBS IdleSlope Queue A */ +#define GEM_CBS_IDLESLOPE_Q_B 0x04C4 /* CBS IdleSlope Queue B */ #define GEM_ENST_CONTROL 0x0880 /* ENST control register */ #define GEM_USX_CONTROL 0x0A80 /* High speed PCS control register */ #define GEM_USX_STATUS 0x0A88 /* High speed PCS status register */ @@ -224,6 +227,12 @@ #define GEM_ENST_ON_TIME(hw_q) (0x0820 + ((hw_q) << 2)) #define GEM_ENST_OFF_TIME(hw_q) (0x0840 + ((hw_q) << 2)) =20 +/* Bitfields in CBS_CONTROL */ +#define GEM_CBS_ENABLE_QUEUE_A_OFFSET 0 +#define GEM_CBS_ENABLE_QUEUE_A_SIZE 1 +#define GEM_CBS_ENABLE_QUEUE_B_OFFSET 1 +#define GEM_CBS_ENABLE_QUEUE_B_SIZE 1 + /* Bitfields in ENST_CONTROL */ #define GEM_ENST_DISABLE_QUEUE_OFFSET 16 =20 diff --git a/drivers/net/ethernet/cadence/macb_main.c b/drivers/net/etherne= t/cadence/macb_main.c index 67150ff03066..00c1c619dea8 100644 --- a/drivers/net/ethernet/cadence/macb_main.c +++ b/drivers/net/ethernet/cadence/macb_main.c @@ -99,6 +99,10 @@ struct sifive_fu540_macb_mgmt { =20 #define MACB_MDIO_TIMEOUT 1000000 /* in usecs */ =20 +/* CBS port transmit rate factors: 1000/interface_width */ +#define MACB_CBS_PORT_RATE_1G 125 /* 1000/8 for GMII (8-bit) */ +#define MACB_CBS_PORT_RATE_10_100M 250 /* 1000/4 for MII (4-bit) */ + /* DMA buffer descriptor might be different size * depends on hardware configuration: * @@ -4492,6 +4496,116 @@ static int macb_setup_taprio(struct net_device *net= dev, return err; } =20 +static int macb_cbs_get_queue_params(struct macb *bp, u8 queue_num, + u32 *enable_bit, u32 *idleslope_reg) +{ + /* Queue A is highest priority (num_queues - 1) */ + if (queue_num =3D=3D bp->num_queues - 1) { + *enable_bit =3D GEM_BIT(CBS_ENABLE_QUEUE_A); + *idleslope_reg =3D GEM_CBS_IDLESLOPE_Q_A; + return 0; + } + + /* Queue B is second highest priority (num_queues - 2) */ + if (queue_num =3D=3D bp->num_queues - 2) { + *enable_bit =3D GEM_BIT(CBS_ENABLE_QUEUE_B); + *idleslope_reg =3D GEM_CBS_IDLESLOPE_Q_B; + return 0; + } + + return -EINVAL; +} + +static int macb_cbs_add(struct net_device *netdev, + struct tc_cbs_qopt_offload *qopt) +{ + u32 enable_bit, idleslope, speed_kbps, ctrl, idleslope_reg; + struct ethtool_link_ksettings kset =3D {}; + struct macb *bp =3D netdev_priv(netdev); + int err; + + err =3D macb_cbs_get_queue_params(bp, qopt->queue, &enable_bit, &idleslop= e_reg); + if (err) { + netdev_err(netdev, "CBS: Queue %d not eligible (only top 2 queues suppor= t CBS)\n", + qopt->queue); + return -EINVAL; + } + + /* idleslope is calibrated for the current link speed; CBS is not + * reprogrammed on link-speed changes, so it must be reconfigured + * if the link speed changes. + */ + phylink_ethtool_ksettings_get(bp->phylink, &kset); + + if (!kset.base.speed || kset.base.speed =3D=3D SPEED_UNKNOWN) { + netdev_err(netdev, "CBS: Invalid link speed\n"); + return -EINVAL; + } + + speed_kbps =3D kset.base.speed * 1000; + + if (qopt->idleslope <=3D 0 || (u32)qopt->idleslope > speed_kbps) { + netdev_err(netdev, "CBS: invalid idleslope %d (must be 1..%u kbps)\n", + qopt->idleslope, speed_kbps); + return -EINVAL; + } + + /* qopt->idleslope is in kbps; convert to the units the hardware + * register expects: + * - High-speed GEM: fraction of port bandwidth, scaled to the full + * 32-bit register range + * - Standard MACB: the register counts bytes/sec in 1G (8-bit GMII) + * mode and nibbles/sec in 10/100 (4-bit MII) mode, so scale kbps + * by 1000/8 (125) or 1000/4 (250) respectively + */ + if (bp->caps & MACB_CAPS_HIGH_SPEED) + idleslope =3D DIV_ROUND_UP_ULL((u64)qopt->idleslope * U32_MAX, speed_kbp= s); + else + idleslope =3D (u32)qopt->idleslope * (kset.base.speed >=3D 1000 ? + MACB_CBS_PORT_RATE_1G : MACB_CBS_PORT_RATE_10_100M); + + scoped_guard(spinlock_irqsave, &bp->lock) { + /* Disable CBS for the queue before updating idleslope */ + ctrl =3D gem_readl(bp, CBS_CONTROL) & ~enable_bit; + gem_writel(bp, CBS_CONTROL, ctrl); + /* Update idleslope for the queue */ + bp->macb_reg_writel(bp, idleslope_reg, idleslope); + /* Re-enable CBS for the queue with new idleslope */ + gem_writel(bp, CBS_CONTROL, ctrl | enable_bit); + } + + netdev_dbg(netdev, "CBS: Configured queue %d with idleslope 0x%x\n", + qopt->queue, idleslope); + + return 0; +} + +static void macb_cbs_destroy(struct net_device *netdev, u8 queue_num) +{ + struct macb *bp =3D netdev_priv(netdev); + u32 enable_bit, idleslope_reg; + + if (macb_cbs_get_queue_params(bp, queue_num, &enable_bit, &idleslope_reg)) + return; + + scoped_guard(spinlock_irqsave, &bp->lock) { + gem_writel(bp, CBS_CONTROL, gem_readl(bp, CBS_CONTROL) & ~enable_bit); + bp->macb_reg_writel(bp, idleslope_reg, 0); + } + + netdev_dbg(netdev, "CBS: Disabled queue %d\n", queue_num); +} + +static int macb_setup_cbs(struct net_device *netdev, + struct tc_cbs_qopt_offload *qopt) +{ + if (qopt->enable) + return macb_cbs_add(netdev, qopt); + + macb_cbs_destroy(netdev, qopt->queue); + return 0; +} + static int macb_setup_mqprio(struct net_device *netdev, struct tc_mqprio_qopt_offload *mqprio) { @@ -4571,6 +4685,8 @@ static int macb_setup_tc(struct net_device *netdev, e= num tc_setup_type type, switch (type) { case TC_SETUP_QDISC_MQPRIO: return macb_setup_mqprio(netdev, type_data); + case TC_SETUP_QDISC_CBS: + return macb_setup_cbs(netdev, type_data); case TC_SETUP_QDISC_TAPRIO: return macb_setup_taprio(netdev, type_data); default: --=20 2.43.0