From nobody Fri Sep 25 19:19:22 2026 Received: from mx0a-0031df01.pphosted.com (mx0a-0031df01.pphosted.com [205.220.168.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id A80E6530DF2 for ; Wed, 9 Sep 2026 10:51:12 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.168.131 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1788951074; cv=none; b=A6BrXY37KFmbTDeQYuWgTaTd+9v1/QanUDLZ9nz6z1YXifZqyWd1hIOrKTTDD5bAJzEYzVrbMrG5h6g2oqsfCjv6p3fPBzXvtCCZlAO10BI0aXuLcO/p8aLuEYiUVFcIH3vN3vAG4Ue7LH2qbeKv0luLMVlaJjaRrLypBAl+oKs= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1788951074; c=relaxed/simple; bh=2uL+BEbJFI0aZgxBFxpVYgInsl6ywz9PoGcVsUCsRUA=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=pOii7O8rfeDK8d/MHJCqCY8Qjv1VOacWtYadII6IgTh5OZVV/Mo0C3KSWmltIUsVnIgEUZqRBcfDUhci/XGcm0ZySEDpIPN310gWogNh/F9Vbm4AU/pLXhTsBiV+P1WNTAe8RxDq8fj1fi/TUjuc6dV/AfSU/5fFaAytKX6fXjM= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=B3YIB9F2; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=cJqFJ9W6; arc=none smtp.client-ip=205.220.168.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="B3YIB9F2"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="cJqFJ9W6" Received: from pps.filterd (m0279866.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 689AS4cA1008109 for ; Wed, 9 Sep 2026 10:51:12 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:date:from:in-reply-to:message-id :mime-version:references:subject:to; s=qcppdkim1; bh=fkauJ7thgLh tosPxn69++tv1mpgFbiKGw88ZWJVXATk=; b=B3YIB9F2cwfqdb0DywFGJt3kkqm BSUMZAlr53vtV2g9tG8FcGSVW9SdMPbpMcwcvB0tun6fKvHDOzsSCkpxM7Mfsw/s Q1cqEmrM0lxfIaFilfIFRiQj2rNaK5XnozToCf+S5SAI1VuEjCk+bCidVPNUa4gZ tCUsUmojBiOGjtLv16wZeBS+I6CkZreJavg7WSAF1qJdRL2FQYOF6wYDv2KTcV77 kFo2nW86cdYZ8pUW1+75lIY83RWg05s14CWEXvV7IpCUZKTMCEJx6Dk8toEz7K7m Vf4wDFI2IODKN1MtD47cA1aOZaKoE/D8DIy2Vqv/a2Ti4nLbqD4S4SVtIcw== Received: from mail-pg1-f197.google.com (mail-pg1-f197.google.com [209.85.215.197]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4gjppp3uf4-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Wed, 09 Sep 2026 10:51:11 +0000 (GMT) Received: by mail-pg1-f197.google.com with SMTP id 41be03b00d2f7-cc132709c76so7848296a12.3 for ; Wed, 09 Sep 2026 03:51:11 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1788951071; x=1789555871; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to:content-type; bh=fkauJ7thgLhtosPxn69++tv1mpgFbiKGw88ZWJVXATk=; b=cJqFJ9W6wCuCDvnKD+PhwwHvLjgjV5Gjk/qCkBK+rA995tobUkovs2hEdZYCdmBYWJ BwV7euwQJ4L7LPCp8JsAzdQ66A4Lsnrm9uNi4K8eneMZxN4XtBMQ3fMqi2LuXBObD6h6 SI9utvlGdLTzSqX84gCO3976Bw0sYup0Yjzg+vtg8hMA+IRRB7kfIB6e4bXoF8q8CSsG xWkRKbrTYXqL6eaUjKBiDdlJjzB+UEY77afyjzmwanNak4EyrlUuGD30SziKVLpUJw0y KG5GquAlXPq13UYphFhtzBFNqV0erN09JLkyqpKmv+6b9rS1Sbo18jXfrqtBYpuOZmNz r6TA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1788951071; x=1789555871; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to:content-type; bh=fkauJ7thgLhtosPxn69++tv1mpgFbiKGw88ZWJVXATk=; b=RCnW4Nmpvfc3j6NNFGN0EzcEZHs4aG8d5bWT7nT+Lb2qPtFg+8vOEuBTN5XITa2K6f D3/x9Z4KlTBl15H+I0LQxvB0eXlO7T+1fhxc1DtzTjQcgn7iTHPBhjOkIVuuu7A/aZ1p EVC3a8aqNU+gDmHmfoW1OtuYBNAmf+T3MSItO2QMNyIPCAXD8XgafXyXJQdreEVUgIqG BmYjQJAEZzUPyTpN+XscPrwNIzyiuVCp6blObzxjz1SyeCX2L/clqzsy8sscBMI+OZLi 14AX7lt5PfGaEPcW7//fIczk5ESqJunHgJbf5i+HvbdJ/KVVUPqjRZ8rKH4chF16pj+5 NtFw== X-Forwarded-Encrypted: i=1; AKwUvBz75N2yRzsmP+B/t9i6QLxdYkkBLox6exAqC2mHOjrWZJe15nA4kffz5KnLpCuDjPz4MkTDCcM2/md3p3I=@vger.kernel.org X-Gm-Message-State: AFuF++kysOguBMi6+YnSAr1qXsX1+hv7KuXcs8AUUMQzLhgDWLbFRALy okNM1VGjgD7qL9/pnf45CCyDvALF8Qz3nbsv2aH4VyV9jiHZpC7ecPojgtShdH4hLOQ8hE8hymf UMrWby6d+6OCo+eznIO3CXyYHFVXHqNsofefTTsMa2MHRE/sQrvj0Cz3ScHXmDa9MDeg= X-Gm-Gg: AYBFou0QoYb4OKNaHJhAmfqnL82XCVyg8ZW9gODO9fuN/sRKsdq7Tzj1zjNeajbM10T lT0iZrnZsNcZa7Au3DzlkOwuZms3Nx/sbNZXf3EwNIRdTyFaNZRFQNzcLZIopL7rJes9AWxoA09 EA0Yg9Zus9hQE/W/AqmekvMFkJkqeidlQZ3u4ytu6NgS1PrjkPtjPxiBbpl/D5VeWfEjCTjBgEi f3rnrpBjLYq3EoUB+0TUapBJshGaDi+aCdzpVC9PBBboiT2qCc0aC6Y9EA51jvvwpb7GfhpTxgj xwy4xHUz5kNUSYwLIf8bXPqyq5Q1sHdgQqC38kG/ppF5G1921Ays2A7Ka0FoEwp507j5o1nsPCg PkrKRge010eRAXUXuckd0ZV+2FAc= X-Received: by 2002:a05:6a21:329a:b0:3cc:8f53:26c0 with SMTP id adf61e73a8af0-3dacbef08d3mr484696637.17.1788951070785; Wed, 09 Sep 2026 03:51:10 -0700 (PDT) X-Received: by 2002:a05:6a21:329a:b0:3cc:8f53:26c0 with SMTP id adf61e73a8af0-3dacbef08d3mr484629637.17.1788951070277; Wed, 09 Sep 2026 03:51:10 -0700 (PDT) Received: from hu-mojha-hyd.qualcomm.com ([202.46.23.25]) by smtp.gmail.com with ESMTPSA id a92af1059eb24-1434bb7d71fsm12084678c88.15.2026.09.09.03.51.05 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 09 Sep 2026 03:51:09 -0700 (PDT) From: Mukesh Ojha To: Bjorn Andersson , Mathieu Poirier , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Manivannan Sadhasivam Cc: linux-arm-msm@vger.kernel.org, linux-remoteproc@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, Mukesh Ojha , Abel Vesa Subject: [PATCH v3 1/3] remoteproc: qcom_q6v5_pas: propagate dev_pm_genpd_set_performance_state() errors Date: Wed, 9 Sep 2026 16:20:47 +0530 Message-ID: <20260909105049.1317985-2-mukesh.ojha@oss.qualcomm.com> X-Mailer: git-send-email 2.55.0 In-Reply-To: <20260909105049.1317985-1-mukesh.ojha@oss.qualcomm.com> References: <20260909105049.1317985-1-mukesh.ojha@oss.qualcomm.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-Proofpoint-GUID: aQjnE16f8uwklttBgUKbuy13sdktxJPU X-Proofpoint-ORIG-GUID: aQjnE16f8uwklttBgUKbuy13sdktxJPU X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwOTA5MDEyMCBTYWx0ZWRfX3U9g4OkuErbQ 6ccs1lnu9kBBjjWj9eravRgIvUGFzVC2MDbG0/3EtaCY3TawPXn3D22Aav40qIrtDhug0fEtf4W j2Vn0DsAMzSSIHa7uHQ7xxIdjB9ViYH5A+WpO+Igk2ewfkXa1YfA1lUC9eE0+dgXy/IjD/0Ix96 pVbLZBPeLEza+ArZQsdnGg3xFPRa4mRaCVr027KA8VTiKyJK3KWgcaH1/kOrCHn1scJtfAuAOaO AaKfxNBckYMDSICIB5O1k1i53M1a0KTYzzmLVz7zCeEYkSK6W8mHH42+80Ph5bQHIGogE8WlIXe 5IQJE798JrFPV+a+cSNGuOiTVt8+zmmiIBOasAcbRqU2xsUvD/Pz+vOzMpmtZKHmDSDG+vUHKU2 agp4VC2KTu96/8nitVCUjHk896AeapIdT+Azl+M+fiuxmcrMHtLLnglAgmBDoJdqLq+Vqq2C4dg D2XLQcSCZV7dcyrACPQ== X-Proofpoint-Spam-Info: AW1haW4tMjYwOTA5MDEyMCBTYWx0ZWRfX3rqgA+IQgqIA tMPmhXddA130xwOQUmKAy+jw/AmEDEZZMfD4h/a7NJ6wqwAF3YtUYSGMa/jzxaAlBoMdAcIJwDu GKLfhDrS9eH24wPJoHvao/lHQPyCrKU= X-Authority-Analysis: v=2.4 cv=DcInbPtW c=1 sm=1 tr=0 ts=6aa13a1f cx=c_pps a=rz3CxIlbcmazkYymdCej/Q==:117 a=ZePRamnt/+rB5gQjfz0u9A==:17 a=VdqzKS8jKosA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=YMgV9FUhrdKAYTUUvYB2:22 a=EUspDBNiAAAA:8 a=l42t8P_hCmqpnny7Gc0A:9 a=bFCP_H2QrGi7Okbo017w:22 X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1176,Hydra:6.1.134,FMLib:17.12.100.49 definitions=2026-09-08_03,2026-09-08_03,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 impostorscore=0 bulkscore=0 suspectscore=0 phishscore=0 clxscore=1015 lowpriorityscore=0 adultscore=0 spamscore=0 malwarescore=0 priorityscore=1501 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2606150000 definitions=main-2609090120 Content-Type: text/plain; charset="utf-8" The proxy power domain enable path discards the return value of dev_pm_genpd_set_performance_state(), masking failures silently. When the call fails the performance state is not applied, yet firmware load proceeds without any indication of the problem. Capture the return value and bail out on failure, unwinding any previously voted proxy PDs via the existing unroll path. A proxy performance state failure indicates that the requested OPP is not supported by the underlying power domain; continuing would leave the remoteproc running with an unconfigured voltage/frequency vote, so treat it as fatal. Reviewed-by: Abel Vesa Signed-off-by: Mukesh Ojha Reviewed-by: Konrad Dybcio --- drivers/remoteproc/qcom_q6v5_pas.c | 8 +++++++- 1 file changed, 7 insertions(+), 1 deletion(-) diff --git a/drivers/remoteproc/qcom_q6v5_pas.c b/drivers/remoteproc/qcom_q= 6v5_pas.c index a005546c265d..c163e66347f8 100644 --- a/drivers/remoteproc/qcom_q6v5_pas.c +++ b/drivers/remoteproc/qcom_q6v5_pas.c @@ -167,7 +167,13 @@ static int qcom_pas_pds_enable(struct qcom_pas *pas, s= truct device **pds, int i; =20 for (i =3D 0; i < pd_count; i++) { - dev_pm_genpd_set_performance_state(pds[i], INT_MAX); + ret =3D dev_pm_genpd_set_performance_state(pds[i], INT_MAX); + if (ret) { + dev_err(pas->dev, + "failed to set proxy PD %d state %u: %d\n", + i, INT_MAX, ret); + goto unroll_pd_votes; + } ret =3D pm_runtime_get_sync(pds[i]); if (ret < 0) { pm_runtime_put_noidle(pds[i]); --=20 2.55.0 From nobody Fri Sep 25 19:19:22 2026 Received: from mx0a-0031df01.pphosted.com (mx0a-0031df01.pphosted.com [205.220.168.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 96DFF534451 for ; Wed, 9 Sep 2026 10:51:17 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.168.131 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1788951079; cv=none; b=kYjMXjPGkDgNOlwpZhMKVLNSiP1LGAOIujoBJO7/FItCXQPqSY4O954P/5csnCe3ycBUSaH6MgcwyLmdSIy/y9AzfFZFYoUo8EfgKZQbs0t+H54QXwNwIj6b4TdI4pHj0HV3X4YWDctUx72Ech6o0SOPZTcbTNDLNgsqnaOMcV0= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1788951079; c=relaxed/simple; bh=O9f6hfp0eJOnXdSOlQWDVVs/akRlJJL7XlXjA7mu5GY=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=qhV9/4OhQAq/mzlPu0ZDq5OALWw3O0xGGJ/DMxfI40/x8PlR49aYcWbvmJnZjrDTnGZGXbTdLcPQX6ceqoF0l5dRFNKbg1O8n1o6rpsF3z63YwvTBvWYgIZ788MKnosz3Dej1C0mO/tDUX0zSJHwgKcXKz7emPcvIfz1tLU1iNc= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=MpPzIskl; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=DoRNpxJ8; arc=none smtp.client-ip=205.220.168.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="MpPzIskl"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="DoRNpxJ8" Received: from pps.filterd (m0279864.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 689AS4Zk462929 for ; Wed, 9 Sep 2026 10:51:17 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:date:from:in-reply-to:message-id :mime-version:references:subject:to; s=qcppdkim1; bh=s3bU5CVGxsB pdkgDP4LaGaH4/EM25sITQmXcPZ7cZmg=; b=MpPzIskld4wNR1Cdu5P8xe6rK7W J+A8vcKQ2RUhqgdW0YzhYuPcpeKsy8VsesdWiUeeetwTZwfEfltTPdj0GTvDqnif 8NlqUH4nGQOvltoxyu6UUb5/tHDzudTN+IIYJGSHm60mdfH+RWXctLK+mJ/sYOwl mdOkjDgIIqE+rJP3CPI1DXX+evHekV3V41hoToLF73HJebHNiXhAUMZOwv+dBtrH 5FLDJBhsMoq6OYIQhRa1OPCNatBeuEzQHmKTOYDLmDD7MHLc/yyalO5IOTMZalnj im2OHKSnR1Vo8GuGv6KKHuBJk2BPEZDpPnVX0E7gsq5Ent0I7LFJXSg66hQ== Received: from mail-pl1-f197.google.com (mail-pl1-f197.google.com [209.85.214.197]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4gjywr1k0x-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Wed, 09 Sep 2026 10:51:16 +0000 (GMT) Received: by mail-pl1-f197.google.com with SMTP id d9443c01a7336-2d932ef41c4so1088075ad.0 for ; Wed, 09 Sep 2026 03:51:16 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1788951076; x=1789555876; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to:content-type; bh=s3bU5CVGxsBpdkgDP4LaGaH4/EM25sITQmXcPZ7cZmg=; b=DoRNpxJ8UYBfrTbAJdKIT6pcJVaXt4PE548Je3QT4itHQm8yOx/vUea2+NcRb7iHqI IffipotUAGAnIioIdXsMIBkRCmP8pwuoV/tmtsfGnlTUf7SOCoLfYsR/OBcxR9QjyONC l/vuEGZ7jJbtB8JX3YLSeIA3jqBt8u1E1t3G0X7qprVa97pM85090R1+QiP+9DwUs3+N 4tOG01PKaVt0JNiha0eDpM+gF7z4LrCl/bYn5zm7Dgl9LFX4q6EmhKoDs2D/OzyVfLhh soucEeMRYkMKQQ6NgwxgGWML+4sbBLP8WP6aDm7NTm61CUFLw2p1EUKb4JpqXk+BspHX F6cg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1788951076; x=1789555876; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to:content-type; bh=s3bU5CVGxsBpdkgDP4LaGaH4/EM25sITQmXcPZ7cZmg=; b=ohN6Id6463ORH/GYqeXcwpGx38DOPEb5NpWz6anAE1bCdrRsOUOPXZx8NS6NksJStd ZWj38GWWGlQqbLVk4LylLmYe2BNgSYrRxVAhHb4E88Kwl0Yf521E2N6Fe/Eo10DOqupq MyoFxtTpdIah7sTsnNTHPY7hfh8JFHolRDrHPGXNfMiRs87YjGRUHwbY8tn3UszGNCUM e+PbcQTTr+/JbOXYi5vSBAQ8fAGKCm8FkLBrp9/ea3QbBPvijoTXlTO/zWXMifZeWJ9F u+JQRYKoPwFGsTECYewZ1nY1OM3FcJ9forf+CGOvGuvD9Pw57JyrQwHbCbMElBh9r9II O9Qw== X-Forwarded-Encrypted: i=1; AKwUvBxI+XX/bmrmcDHJbUVA9IFcdfGV9PsGN7hFe5CfjvLneqnzxVmqzlKYxdGrGvVKLaceCNZJmmdtJ3UVglA=@vger.kernel.org X-Gm-Message-State: AFuF++mJTFfA+09TAUXAeksBkVi44FuULFjulDmYHAj3AfNyOM1x2+r/ StVRWmyX2sX8nxX8KlbYiL11bKhAopmLRuhM6BaUmZP4FckVOT9YS33BbDnK5BXX2hwmC5gq7Bv HcuouY9s2yGvtGpnLIzHRkfDj0OJX/09Jsf1LIOGSXRQ2JQIipZRlomKwdq7J/+szSnc= X-Gm-Gg: AYBFou3iL2lxU73LL3CSwbB9wqCnfA2TWSXDEQEqXMDTIdfnNnQItiPrtyfbj8SpQo1 w812UNHiq6y1HdUCBkhQlDX2spyTvxVUYyLX0yO8ZGWDAFT3P+uYRYZi/sAybBnc4I7kPSrUzk9 suMPL7yr2d2OWUEyCH0ClqIXlN4rUhdAHHFGLbTzoxk/yZIK1fKq2eAXBltxay4tSP4lCjZaygL 8yVgjB9YJclDy4NTUym1SibXTPkrlzDZbDLj1i8v86/mg8TLgNS1MUKA8HX0Urr6j0guozwSrke Wz393g7xZKkwfYqId4nSQB0WAtZqm2kNY6jkBWm/UXThLfFpTfgmJ6m0VyQQjgnl14QPnrW4zkp O8h+rVeZiEnEmVSv+SfE5asTwyYc= X-Received: by 2002:a17:90b:538c:b0:398:9beb:a2b4 with SMTP id 98e67ed59e1d1-39b087992ddmr41223155a91.22.1788951075734; Wed, 09 Sep 2026 03:51:15 -0700 (PDT) X-Received: by 2002:a17:90b:538c:b0:398:9beb:a2b4 with SMTP id 98e67ed59e1d1-39b087992ddmr41223096a91.22.1788951075144; Wed, 09 Sep 2026 03:51:15 -0700 (PDT) Received: from hu-mojha-hyd.qualcomm.com ([202.46.23.25]) by smtp.gmail.com with ESMTPSA id a92af1059eb24-1434bb7d71fsm12084678c88.15.2026.09.09.03.51.10 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 09 Sep 2026 03:51:14 -0700 (PDT) From: Mukesh Ojha To: Bjorn Andersson , Mathieu Poirier , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Manivannan Sadhasivam Cc: linux-arm-msm@vger.kernel.org, linux-remoteproc@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, Mukesh Ojha , Krzysztof Kozlowski Subject: [PATCH v3 2/3] dt-bindings: remoteproc: qcom,sm8550-pas: make qcom,hawi-cdsp-pas standalone Date: Wed, 9 Sep 2026 16:20:48 +0530 Message-ID: <20260909105049.1317985-3-mukesh.ojha@oss.qualcomm.com> X-Mailer: git-send-email 2.55.0 In-Reply-To: <20260909105049.1317985-1-mukesh.ojha@oss.qualcomm.com> References: <20260909105049.1317985-1-mukesh.ojha@oss.qualcomm.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-Authority-Analysis: v=2.4 cv=a4YAM0SF c=1 sm=1 tr=0 ts=6aa13a24 cx=c_pps a=cmESyDAEBpBGqyK7t0alAg==:117 a=ZePRamnt/+rB5gQjfz0u9A==:17 a=VdqzKS8jKosA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=DJpcGTmdVt4CTyJn9g5Z:22 a=EUspDBNiAAAA:8 a=kGc2aUUJYeWwMdlnZD0A:9 a=1OuFwYUASf3TG4hYMiVC:22 X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwOTA5MDEyMCBTYWx0ZWRfXxMU9q9XHzXxx 2nGbrmbJ7e4XKH9qkI2opDIkqHxjH2PYVcdo7T7xqmbdZIMFOpPr4bwa9Yu8+dTA4rBvSxGztd6 jmcHWwKiwpIvOGhhEPg2If9n5AJSqNU+XMRCbKkQ2ZXdXphuvNkl8fSonX3HoXmlqMWopkOHfNv UjOqcXm/beRvCOczPRfNMUrJtQ4BPMs1FMC//SqWwgSIUDsEZ2mOwNkjikz2MAy08ZlnkLXbp5Z OQZOUn3wO1BM24onpg0f/I5O0bXiLKlGa/8FuuLAtEKSStLy1hLkeKpdx3goPbzX5vN7ITUDhdG 0QqVt8wrRs4CQ1kxL/DSBR57dbZ+PaTi0GdmMt2h6pQXdbcAfpbntq+1h/O9ydeSkOi5ynaa1Vp rb+VuPQN4na+T0+8RVMB6ot8amTwKHr8WHBptOqM8YtNwAJB+DdU69hPxZODNGAyr7fOtmkBfvU qp3DEwaTDd4Cs9IIvtg== X-Proofpoint-Spam-Info: AW1haW4tMjYwOTA5MDEyMCBTYWx0ZWRfX3BqeOpJA1fLY 8T4vKTAyPxkX2dzcJXZL9dXvEuYSbhCMy6M2lsUljUJh8PLOx4kLsgXYJzyduCGQ+iRKU6HS/Vo rUSBw4uQM1O051RfWSvnSulA/sdiuJQ= X-Proofpoint-ORIG-GUID: MmWNdb6VYZBCxk7c0DuhX6-G-E_Pp7Wm X-Proofpoint-GUID: MmWNdb6VYZBCxk7c0DuhX6-G-E_Pp7Wm X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1176,Hydra:6.1.134,FMLib:17.12.100.49 definitions=2026-09-08_03,2026-09-08_03,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 priorityscore=1501 malwarescore=0 phishscore=0 lowpriorityscore=0 bulkscore=0 clxscore=1015 spamscore=0 adultscore=0 impostorscore=0 suspectscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2606150000 definitions=main-2609090120 Content-Type: text/plain; charset="utf-8" qcom,hawi-cdsp-pas was initially grouped as a fallback to qcom,sm8550-cdsp-pas on the assumption of hardware-level compatibility. Bringup revealed that the NSP proxy power domain on Hawi requires a specific RPMH performance level that the sm8550 driver data does not provide, breaking the compatibility contract the fallback string implies. Remove qcom,hawi-cdsp-pas from the sm8550-cdsp-pas fallback items block, add it to the standalone compatible enum, and extend the existing cx/mxc/nsp power-domain constraint to cover it explicitly. Reviewed-by: Krzysztof Kozlowski Signed-off-by: Mukesh Ojha --- .../devicetree/bindings/remoteproc/qcom,sm8550-pas.yaml | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/Documentation/devicetree/bindings/remoteproc/qcom,sm8550-pas.y= aml b/Documentation/devicetree/bindings/remoteproc/qcom,sm8550-pas.yaml index c58e8a6c7fe1..cf57095cd49d 100644 --- a/Documentation/devicetree/bindings/remoteproc/qcom,sm8550-pas.yaml +++ b/Documentation/devicetree/bindings/remoteproc/qcom,sm8550-pas.yaml @@ -18,6 +18,7 @@ properties: oneOf: - enum: - qcom,eliza-cdsp-pas + - qcom,hawi-cdsp-pas - qcom,sdx75-mpss-pas - qcom,sm8550-adsp-pas - qcom,sm8550-cdsp-pas @@ -40,7 +41,6 @@ properties: - items: - enum: - qcom,glymur-cdsp-pas - - qcom,hawi-cdsp-pas - qcom,kaanapali-cdsp-pas - qcom,maili-cdsp-pas - const: qcom,sm8550-cdsp-pas @@ -273,6 +273,7 @@ allOf: compatible: contains: enum: + - qcom,hawi-cdsp-pas - qcom,sm8550-cdsp-pas - qcom,sm8650-cdsp-pas - qcom,x1e80100-cdsp-pas --=20 2.55.0 From nobody Fri Sep 25 19:19:22 2026 Received: from mx0b-0031df01.pphosted.com (mx0b-0031df01.pphosted.com [205.220.180.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id B96DD53444D for ; Wed, 9 Sep 2026 10:51:23 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.180.131 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1788951085; cv=none; b=U3wx10lWypm3TxQXIgHcO3B7nwCQ0eZhctFN9LzMIXCE58g1pJole1HRbFZlgDdxT8mLKFcqneii6m7lfGcq6ocm/SA2WcNR7IWepfYEzIKzEUniqSwCYIZIAeZDybW7LTrlfOk+YAATtSL9pfuLnih6o3kmJFxsHmZomEJ48fc= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1788951085; c=relaxed/simple; bh=vDJVRWCy05G/W1impMgDXPlScQt9SGaQUbrN9edkIZ4=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=pZlofDdbCJVV0qXQ9UMJ9jkb36PZ8SByToV96dDfw0yWzusx2taBTGWr29ul0NRH0+dX3wz3p23PfG85vcM74ac6Xp6yfQv5zS4oghYXTw5qkD3BmxD26T/67t4h6ENisFnGEWi/HpVd2QPHLizG5TPm7CP6jUMd7i9puMLTebQ= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=EqKi7SKn; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=LnD/TNZc; arc=none smtp.client-ip=205.220.180.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="EqKi7SKn"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="LnD/TNZc" Received: from pps.filterd (m0279869.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 689ATQUn2035286 for ; Wed, 9 Sep 2026 10:51:22 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:date:from:in-reply-to:message-id :mime-version:references:subject:to; s=qcppdkim1; bh=StIud/YqJ+3 TGGk5d/xvQ+diZ2UDnagtRnqO6Sj9D8o=; b=EqKi7SKnx6ERjTucs1ABOSnMWHj YsRg1TqzO9guk0Q5YltHXqNKw7Bn9++iUAYKuLVx5HdWjVEG1lDHPTOdnZEg4C4Z lzPZCtz9HEa/MLN8LeVxHcv2uqYKsLJJPXTzgYQjGqMjohLq2zuMUNW3tBro5Cw2 mZO3ZQWe9dWngx/mAC5PTm9gDuAaT5QIHyeNU4vbQpYDGfsVSd20wXelUo+8wFXC wXtb1lcRajMac/Gdl9XIpNcAqVAY64oarS7CI+6fuHCEQHOT0X7Yt2sftesoc+jy k2RaEEi64muml72QIvuHOZiHofV24aMCPi9wj2oPPwdwvGAlEjsjGo6uKnw== Received: from mail-pj1-f72.google.com (mail-pj1-f72.google.com [209.85.216.72]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4gk5rgg2ra-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Wed, 09 Sep 2026 10:51:22 +0000 (GMT) Received: by mail-pj1-f72.google.com with SMTP id 98e67ed59e1d1-39b77130a7fso4797798a91.2 for ; Wed, 09 Sep 2026 03:51:22 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1788951081; x=1789555881; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to:content-type; bh=StIud/YqJ+3TGGk5d/xvQ+diZ2UDnagtRnqO6Sj9D8o=; b=LnD/TNZcjc3T0UPgVjUg513Nb+yRg1mjXYBP2/IlceLVNs+wevnfXX6WaQPqmKTP+w +2ctUsiA4buTt2sDLbvYudqYOPgAniU8O4XcqAXAZeNTWDluQNicc0i2qrcSf39lg78h OxvRsnOkCxIqGaQ2hKDgxz0QSjx3xp/6qIFKULd4Ip/BNMFgtS6rBXhw/UasqWGAYZi3 rTrqZJaQQLUCL0FYU2mBhaxJ4C4Dq6XYi1qg7w0++ZHblyIdNpjpWZggkAV5GTdeOHXK DLHRpYJ1TqB5TqXyB/W/PMF6n0pT7Iq4/Dpa8wdjhwFhu7bfkI2qhe1MBrUiAHJmKFey oodQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1788951081; x=1789555881; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to:content-type; bh=StIud/YqJ+3TGGk5d/xvQ+diZ2UDnagtRnqO6Sj9D8o=; b=kfYQVvMGFM4qVWKYorXeVkaJWGztypbf7VC8fPSrNFv4c0nIkAdhZ5mBgnaaqUXprw Tu10WY66vOZef8Tv8panTPdHpV+tOgzng1cM5iXCca0ZjsoSg/9dOpVFLFBfi7u47ogD FhFJJ4kn2rfIZhk9kV5H84cOyj2SBh0LdaJqZtdW5WfAPaj/+OxL0xHAR7DS9sdoGtqM 1XjeWVykS0nDvsyviRpkhYwgf81+/THnWIFfAmMzGVBU7aGZVYb4Q2/YSYLD8pnRsqYp Quh4eIiCar7JilH3z6i2KWcMCyPZl/HBPvoMy9qJ9PatJkI0vs5ngJGkXzn5I6Ucfsqj WOwA== X-Forwarded-Encrypted: i=1; AKwUvBxdvq4gvE9BJRuFdtjXN7SbH8VAZvUEzfE5G8q8kMuRxiYNBa322udHsftmEUVARO2c8LN/pqTicg+Kz0I=@vger.kernel.org X-Gm-Message-State: AFuF++mHO/Wwf/3+85HtpLqCEAlNcjyJFUC5pWJoHwMQfJwOwgj2MrFL DPqL6REQjTciyO85L3UKyrfBZsKXke1jqEinQsemh8IPRT1B8BzG+zBA7OSc91GOQVPB9pbmB7J M/qB8ESkMbbWoOtS5u9DLXZ1muhiUFlg3k9pBHzGNpca06PnI6fGk/L9kQitXP6Srylg= X-Gm-Gg: AYBFou2+5N/AnHlOBkurGD5/dpHHUyCshKPDDejhNJ1XqwPdcsvPwWQY3Zeq64CQ+Wr oNdZrTeLo5bvx1vsfs/P76vWGk59GTcnY9F5s0V15UFNZrEyzYKKayMwgIRVkAE+P9Ba6iW80HO Xh5SwjYCr+TbjBA/pHB7sEGu58JZrbs3wGSBnfQ7vdF9iaJjDM2I1thzzs/nmT6IkGi53AFVzP2 LccL7wjN4jChUboWsmotYIFbP/Hcc+Cvvk7vOxqSau7rBMGjz2NM09YcB88s1rqWRJh6+v82Es0 yJL3mAE4F6JvYIY9jAzIUgHWi0OFlxM0bKmq5VXrjn1z5LHJ79yJyhq7QSCg+VMFbMu7qjzrXd+ rsu6W4Fbf4j9Oj5E1oLP9MPE+ZEA= X-Received: by 2002:a17:90b:2681:b0:38f:5801:dc0e with SMTP id 98e67ed59e1d1-39b261d52a4mr51208614a91.15.1788951081135; Wed, 09 Sep 2026 03:51:21 -0700 (PDT) X-Received: by 2002:a17:90b:2681:b0:38f:5801:dc0e with SMTP id 98e67ed59e1d1-39b261d52a4mr51208549a91.15.1788951080503; Wed, 09 Sep 2026 03:51:20 -0700 (PDT) Received: from hu-mojha-hyd.qualcomm.com ([202.46.23.25]) by smtp.gmail.com with ESMTPSA id a92af1059eb24-1434bb7d71fsm12084678c88.15.2026.09.09.03.51.15 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 09 Sep 2026 03:51:19 -0700 (PDT) From: Mukesh Ojha To: Bjorn Andersson , Mathieu Poirier , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Manivannan Sadhasivam Cc: linux-arm-msm@vger.kernel.org, linux-remoteproc@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, Mukesh Ojha , Abel Vesa Subject: [PATCH v3 3/3] remoteproc: qcom_q6v5_pas: add per-PD proxy performance states for Hawi CDSP Date: Wed, 9 Sep 2026 16:20:49 +0530 Message-ID: <20260909105049.1317985-4-mukesh.ojha@oss.qualcomm.com> X-Mailer: git-send-email 2.55.0 In-Reply-To: <20260909105049.1317985-1-mukesh.ojha@oss.qualcomm.com> References: <20260909105049.1317985-1-mukesh.ojha@oss.qualcomm.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-Proofpoint-Spam-Info: AW1haW4tMjYwOTA5MDEyMSBTYWx0ZWRfX4ZQaIWW/6k3t cMmlWs/JZ/+We0ckfEG4j5IBjnlBnNAPQvorsohQLst4R8MNjAOvEG6ZAUS7RkHzJFYYkeP7V8w /AnfIZx5LvTibsJ1rAqzDtCQFiwrrTE= X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwOTA5MDEyMSBTYWx0ZWRfXwBvDuz9JvhYB 6SWgYUbaQ3Bwi/YAZzWjrh8qH8NrdFX44IMi+Rc5lKll0Esb74JWSi0zRKVpNjs+vG/CrxoLLT7 1vYYZzokvTuDZ0L3jam9bU1rW4aV9Lh36yCoorgeFPQg0eActS+P6CroiW7Ji3WQplGkRsGfc+8 L6eBae3hf2CesYqycta183vKdhucs20dulS0Ln54IVdtsm7N72E7XBg+mmxV5imKDgzypXJN8mm 3GJPZuPBnXEDrG7cSiM8nWJFJSBoce/eglOrK0sKNRwCariA5J6lI7fha4KWyYRvkqDCcyC6pIH Nvujluykn5XssJgQLVogm3vvLkVd6I4bvCjfu61A2k8ZKFC3i8X6B5cqPPG3vSxyBb9HgKdpOL4 NCSeuXbtItIbzIiC00LXU6OgVcyEYpQMpVbQxOraqm+gnvb+S2ffPB3U2WjwmBvALOdSvJWsVaw RTK2vo3ZMAcuEmgAekg== X-Authority-Analysis: v=2.4 cv=B6qJFutM c=1 sm=1 tr=0 ts=6aa13a2a cx=c_pps a=RP+M6JBNLl+fLTcSJhASfg==:117 a=ZePRamnt/+rB5gQjfz0u9A==:17 a=VdqzKS8jKosA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=_glEPmIy2e8OvE2BGh3C:22 a=EUspDBNiAAAA:8 a=EzEDkhfgfUAEW4_RwPsA:9 a=iS9zxrgQBfv6-_F4QbHw:22 X-Proofpoint-GUID: RYnvAn_lSz6h-x_GB4cekrJwN4-vakRl X-Proofpoint-ORIG-GUID: RYnvAn_lSz6h-x_GB4cekrJwN4-vakRl X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1176,Hydra:6.1.134,FMLib:17.12.100.49 definitions=2026-09-08_03,2026-09-08_03,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 priorityscore=1501 phishscore=0 spamscore=0 adultscore=0 malwarescore=0 bulkscore=0 clxscore=1015 impostorscore=0 lowpriorityscore=0 suspectscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2606150000 definitions=main-2609090121 Content-Type: text/plain; charset="utf-8" The proxy power domain enable path requests INT_MAX performance state for every proxy PD. On Hawi, the NSP proxy power domain's RPMH power domain has no OPP at INT_MAX, while CX and MXC accept INT_MAX, mapping to their maximum supported level. Introduce a proxy_pd_performance_states array in qcom_pas_data to allow per-PD RPMH levels to be declared explicitly. Platforms that omit this field retain the existing INT_MAX behaviour. Add Hawi CDSP remoteproc support with the following proxy PD performance states: CX: RPMH_REGULATOR_LEVEL_TURBO MXC: RPMH_REGULATOR_LEVEL_TURBO NSP: RPMH_REGULATOR_LEVEL_NOM Reviewed-by: Abel Vesa Signed-off-by: Mukesh Ojha Tested-by: Yijie Yang --- drivers/remoteproc/qcom_q6v5_pas.c | 50 ++++++++++++++++++++++++++++-- 1 file changed, 48 insertions(+), 2 deletions(-) diff --git a/drivers/remoteproc/qcom_q6v5_pas.c b/drivers/remoteproc/qcom_q= 6v5_pas.c index c163e66347f8..8ac66db80193 100644 --- a/drivers/remoteproc/qcom_q6v5_pas.c +++ b/drivers/remoteproc/qcom_q6v5_pas.c @@ -28,6 +28,7 @@ #include #include #include +#include =20 #include "qcom_common.h" #include "qcom_pil_info.h" @@ -51,6 +52,8 @@ struct qcom_pas_data { bool decrypt_shutdown; =20 char **proxy_pd_names; + const unsigned int *proxy_pd_performance_states; + unsigned int num_proxy_pd_performance_states; =20 const char *load_state; const char *ssr_name; @@ -79,6 +82,7 @@ struct qcom_pas { struct regulator *px_supply; =20 struct device *proxy_pds[3]; + const unsigned int *proxy_pd_performance_states; =20 int proxy_pd_count; =20 @@ -167,11 +171,16 @@ static int qcom_pas_pds_enable(struct qcom_pas *pas, = struct device **pds, int i; =20 for (i =3D 0; i < pd_count; i++) { - ret =3D dev_pm_genpd_set_performance_state(pds[i], INT_MAX); + unsigned int state =3D INT_MAX; + + if (pas->proxy_pd_performance_states) + state =3D pas->proxy_pd_performance_states[i]; + + ret =3D dev_pm_genpd_set_performance_state(pds[i], state); if (ret) { dev_err(pas->dev, "failed to set proxy PD %d state %u: %d\n", - i, INT_MAX, ret); + i, state, ret); goto unroll_pd_votes; } ret =3D pm_runtime_get_sync(pds[i]); @@ -879,6 +888,7 @@ static int qcom_pas_probe(struct platform_device *pdev) pas->info_name =3D desc->sysmon_name; pas->smem_host_id =3D desc->smem_host_id; pas->decrypt_shutdown =3D desc->decrypt_shutdown; + pas->proxy_pd_performance_states =3D desc->proxy_pd_performance_states; pas->region_assign_idx =3D desc->region_assign_idx; pas->region_assign_count =3D min_t(int, MAX_ASSIGN_COUNT, desc->region_as= sign_count); pas->region_assign_vmid =3D desc->region_assign_vmid; @@ -914,6 +924,14 @@ static int qcom_pas_probe(struct platform_device *pdev) goto unassign_mem; pas->proxy_pd_count =3D ret; =20 + if (WARN(desc->proxy_pd_performance_states && + desc->num_proxy_pd_performance_states !=3D pas->proxy_pd_count, + "proxy_pd_performance_states count %u !=3D pd count %d\n", + desc->num_proxy_pd_performance_states, pas->proxy_pd_count)) { + ret =3D -EINVAL; + goto detach_proxy_pds; + } + ret =3D qcom_q6v5_init(&pas->q6v5, pdev, rproc, desc->crash_reason_smem, desc->load_state, qcom_pas_handover); if (ret) @@ -1804,6 +1822,33 @@ static const struct qcom_pas_data glymur_soccp_resou= rce =3D { .needs_tzmem =3D true, }; =20 +static const struct qcom_pas_data hawi_cdsp_resource =3D { + .crash_reason_smem =3D 601, + .firmware_name =3D "cdsp.mdt", + .dtb_firmware_name =3D "cdsp_dtb.mdt", + .pas_id =3D 18, + .dtb_pas_id =3D 0x25, + .minidump_id =3D 7, + .auto_boot =3D true, + .proxy_pd_names =3D (char*[]){ + "cx", + "mxc", + "nsp", + NULL + }, + .proxy_pd_performance_states =3D (const unsigned int[]){ + RPMH_REGULATOR_LEVEL_TURBO, + RPMH_REGULATOR_LEVEL_TURBO, + RPMH_REGULATOR_LEVEL_NOM, + }, + .num_proxy_pd_performance_states =3D 3, + .load_state =3D "cdsp", + .ssr_name =3D "cdsp", + .sysmon_name =3D "cdsp", + .ssctl_id =3D 0x17, + .smem_host_id =3D 5, +}; + static const struct qcom_pas_data eliza_cdsp_resource =3D { .crash_reason_smem =3D 601, .firmware_name =3D "cdsp.mbn", @@ -1833,6 +1878,7 @@ static const struct of_device_id qcom_pas_of_match[] = =3D { { .compatible =3D "qcom,eliza-adsp-pas", .data =3D &sm8550_adsp_resource = }, { .compatible =3D "qcom,eliza-cdsp-pas", .data =3D &eliza_cdsp_resource }, { .compatible =3D "qcom,glymur-soccp-pas", .data =3D &glymur_soccp_resour= ce }, + { .compatible =3D "qcom,hawi-cdsp-pas", .data =3D &hawi_cdsp_resource }, { .compatible =3D "qcom,kaanapali-soccp-pas", .data =3D &kaanapali_soccp_= resource }, { .compatible =3D "qcom,milos-adsp-pas", .data =3D &sm8550_adsp_resource = }, { .compatible =3D "qcom,milos-cdsp-pas", .data =3D &milos_cdsp_resource }, --=20 2.55.0