From nobody Fri Sep 25 20:02:05 2026 Received: from mail-pl1-f176.google.com (mail-pl1-f176.google.com [209.85.214.176]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 09539343D63 for ; Wed, 9 Sep 2026 04:55:12 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.214.176 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1788929714; cv=none; b=FuSGda/jWWL2FTPoK21Hlc4EOhUMLc+mlg1sZZAaL2r6t62SxIi35lXA9iuT+H1oMVvdPY3nYUrn8cs7GPqnYC48YK3BL5/5u6gxnTNCCDjRjdWzxe3FQSKB2FrLMf59HDnf4FPUV+8iItwqp6dnmNTq8ctHaY9VP85vJH6DFA0= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1788929714; c=relaxed/simple; bh=/jNbC5DebhzK+Aiemy35oWPeEdVyuqm+UDXrJimJ528=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=skr97r3GS9Uvhm/vDWa4N2tCcbvqy5smYUDLZ5guP7NeQghp2EpJVjJuZGzCSpd5mjXXXgNg43ZKo3ajeMeNvjg5fxookHuQmxh2elF+YeIwC993sKnNxAHGI3lTEEhBveNhi2j0hgfucZtywZDgfuop/GaS4i3KipUO2KICpX4= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=QiY83OCH; arc=none smtp.client-ip=209.85.214.176 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="QiY83OCH" Received: by mail-pl1-f176.google.com with SMTP id d9443c01a7336-2d9db539a54so47981905ad.0 for ; Tue, 08 Sep 2026 21:55:12 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1788929712; x=1789534512; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to:content-type; bh=Wu0O0pJmWewYzRf0DSsVxXq14cBDmhqpv1Ta+hWpqN4=; b=QiY83OCHg8V3QU3R6GHw2HdmuCNbyXXCNxeZ43y2I8Z0e+bsv18NUQdYRhwfEXaH58 BZ/4i7vAwbw38rG8B4r36v/2Iq77+71UbQDPclJkeZNowtEQuHYX/uM5Qnwx8ar3pkMt wSafHYswYazLg8oAGza0vDmJjEgof91d4vV8LoBKE+icKYzmWEFhYMUsYDslQ0HxxN4J zOJhpEHQBVHA8K7gUtIbNP1INDldk728dRCVJigBbMNfE7dndhyF+APxviAyb0wRUDUs 2Z0GXDK61z178+gFqwS1IUIBWpbLklqOFd1m4Xc30+VwQxnkFeWyzb2VGd3o/XTiDbQU O9rQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1788929712; x=1789534512; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to:content-type; bh=Wu0O0pJmWewYzRf0DSsVxXq14cBDmhqpv1Ta+hWpqN4=; b=MG44U9dxBLNStqoiBRUJhZJfnbQ8/q+MLj8egDpYMLMyGU4WOdmGUpc/VUP93dO9x3 QT6pREmBEe5T1x4esWlpo2+VEGTL4anZP/SgHzkkMh/8tY19MNCdwaXlVxNM5u9UVo93 pfCFJuoTi5Hu2WKaz5GpY4sRG1RdYYElL9/CMr9I7tTe885tWGDnf4Kce2YXSPL3K4xY XnlHivP+swKvwWYByrsPbIlRWlLRxAK4REpZnc2AnUXIYyZ5YqTsyVop4N4R1fsv5/yS kLB24zes/N5D2b8KW7tT45RPhF2L1Tr30ltpEWnATCWV1laUsa+mxpgq/j/DY2qAhEPb xchQ== X-Forwarded-Encrypted: i=1; AKwUvByfTsLzkWW8DxR42cZb0wnQKqBXRUmV5pFCoLTXqKJwOLa+TqpSbSb4BhsaSrY7NSeBd3XcmgznoWRe8uk=@vger.kernel.org X-Gm-Message-State: AFuF++n7hV2vF/3Oxf+qXDih8+kX4kKCKYOaMGa/Vr9J1SAaRca3dye9 wnoo1ztUF8IPgfu23u0W/7DcaylLx5d3nEYDSeJ5/6cn5Bb/C2OjiW6L X-Gm-Gg: AYBFou0I6iYD7c5ycOagEXnMNyBVEe4OHZo1l2bGRuf1hS01yF016iFW2IBHARcNQVh PHJ4u0icxIc4BnxwulqEocmu0w1Oc5WPqWO0FPj9K3KqeNruY/dFUvChWqGnA+LF3wRar0FhtAN fzuqGpsFNYgg3V1dYC0ojmr3+qJWqD2A63SO108E+QT9rP6M0vYbXPBI8G1RzS9tnhiNjZSANeg DNimFLf54998K7gT6cJdIHqYGqZFioAQibHhzEgHWReQ5DYtpgr9Uat4YiFlIsoSLnk8qBXYkJa 0L/Q3NT52rNatlKpHGXEoWVJBhTBa5EADfamos1E8f5wA++AnYPU29nfm5NGs6pxPebV2zITilN txbPQyyNY0kN4WFup9MxPVwL/R9FP0AT8jTM9aWZFYAd1lG3Ray6d+g/3M0LjKn3RxFDC0xu3aR ScT4x4i7UMfZpPx7XagppWjVBKA6y7mdfwqcw91De9bfdMcVcYZpKUiqi9Zes1Dv9x/boByQrRk rOJKHtzJacifI01ToexYvFZt+TjJYLnOk3eKNXtSXk93TTH0DLMqZdnautYsV9GHLMCJpyornUE lTSXrKhkhsru7KI= X-Received: by 2002:a17:902:ebc5:b0:2ca:9d5a:8b6c with SMTP id d9443c01a7336-2db1231f623mr518417745ad.5.1788929711582; Tue, 08 Sep 2026 21:55:11 -0700 (PDT) Received: from phuc-desktop.. ([183.91.15.56]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-2db1499e876sm66688505ad.56.2026.09.08.21.55.08 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 08 Sep 2026 21:55:11 -0700 (PDT) From: phucduc.bui@gmail.com To: Radhey Shyam Pandey , Andrew Lunn , davem@davemloft.net, Eric Dumazet , Jakub Kicinski , Paolo Abeni , Michal Simek , Simon Horman Cc: netdev@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, bui duc phuc Subject: [PATCH net-next v6 1/3] net: xilinx: axienet: Propagate errors from optional IRQ lookup Date: Wed, 9 Sep 2026 11:54:48 +0700 Message-ID: <20260909045450.16176-2-phucduc.bui@gmail.com> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20260909045450.16176-1-phucduc.bui@gmail.com> References: <20260909045450.16176-1-phucduc.bui@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" From: bui duc phuc platform_get_irq_optional() returns a positive IRQ number on success or a negative error code on failure. For an optional IRQ, -ENXIO indicates that no optional IRQ is available, while other errors should be propagated. Propagate all error codes returned by platform_get_irq_optional() other than -ENXIO. Another call to platform_get_irq_optional() in the same function already handles the return value this way. Apply the same error handling to this call site for consistency. Reviewed-by: Simon Horman Reviewed-by: Radhey Shyam Pandey Signed-off-by: bui duc phuc --- Changes in v6 :=20 - Add Simon's Reviewed-by: tag. - Drop the Fixes: tag as this patch is intended for net-next. drivers/net/ethernet/xilinx/xilinx_axienet_main.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/drivers/net/ethernet/xilinx/xilinx_axienet_main.c b/drivers/ne= t/ethernet/xilinx/xilinx_axienet_main.c index 1722b7038f34..207aecb5f8b9 100644 --- a/drivers/net/ethernet/xilinx/xilinx_axienet_main.c +++ b/drivers/net/ethernet/xilinx/xilinx_axienet_main.c @@ -2975,6 +2975,8 @@ static int axienet_probe(struct platform_device *pdev) dev_err(&pdev->dev, "could not determine irqs\n"); return -ENOMEM; } + if (lp->eth_irq < 0 && lp->eth_irq !=3D -ENXIO) + return lp->eth_irq; =20 /* Reset core now that clocks are enabled, prior to accessing MDIO */ ret =3D __axienet_device_reset(lp); --=20 2.43.0 From nobody Fri Sep 25 20:02:05 2026 Received: from mail-pl1-f171.google.com (mail-pl1-f171.google.com [209.85.214.171]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id D39E335FF6C for ; Wed, 9 Sep 2026 04:55:17 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.214.171 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1788929719; cv=none; b=X7zxOSXW8e+6YGtVtUnG2LignqsVQZi8OHHsVEOIH1zPShjj8dYRgCIlCceY4n+0W27F+vxTmC2+ZxFs1MDoYNLmrR7dEiWAaguBn2ZwMZmL040SlO3sTiNO/xOTD8vIsDn73bMO3Az9Rm3ibHnEK2PKXWJOBqFVz9KCYJ+xpJU= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1788929719; c=relaxed/simple; bh=9XQNM3dHn9B6ebcmsmXP5Kg8HA2I6Ns/3HUBA3vfo5Q=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=Mru7fPS94TRxaXEcX7en4AodcDNiEbL1VfCK3kucYKToyTaeKvwGRZC/CjlDA1+nBX2wuSs3iYeTueEE29jrdkb1Y6NKcBT7eIoh6qP6+p3bU+j03KUsXr+dMpOUbjABN4Mz4eQLFOotqk+fqmhGqpZdkMwPtuQTBu7+FK5RN7Y= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=M6kcDLnt; arc=none smtp.client-ip=209.85.214.171 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="M6kcDLnt" Received: by mail-pl1-f171.google.com with SMTP id d9443c01a7336-2d032846c95so63355995ad.1 for ; Tue, 08 Sep 2026 21:55:17 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1788929717; x=1789534517; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to:content-type; bh=qiAYhnnhs61WtKZMJIh7R7XvaVkzgplipEpTD594EKI=; b=M6kcDLnt6lHDVasxDqZm9/IxYakPr0pHZB/5UNRYvE5YT9ka0+URz235GSBlTAqFZL 23PSr8U2ppXLVVRnBt3Aps+eZzn3Qfq5tsFGFM5xFw85PbaFWc178y4xhv0n3KWIc223 T3CZfXfw66QttQmBYie4sHG/Xjr1GWmZfsO5iUf8Hgi1INMoN94pLmm38RIGk+WUaBoM Xk0d442oI+Q2PPKWEv1hcXj+clh4OYXVAFaXR9D0n+yqHcdmmO+F8bD0qqiDD9f/5eO9 Zi1dPK8AhhLiWJ0Uvg9l1eBMiuW+1NjVujBrHprUgQVzge4pRUaiDV/fjB3663HYEsyb upYQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1788929717; x=1789534517; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to:content-type; bh=qiAYhnnhs61WtKZMJIh7R7XvaVkzgplipEpTD594EKI=; b=o1wBy+GXWXnPPdznn9dzN3k+DHC8kz+D8nz1HIeffL1GCR2q16dIzvvb77BADw7CA+ XRAuR4LsQM5UBT5IqLCAT5eRTsnb8DKNRNq3YWRstXgNTnNfA9m92aUUUKQ4LLebYin4 zSB1bjnpZmW2LEYyDtYkezgQavn/g3SDlHkQuyxp68vBj095QYokkSS93XppEFvy3oKd DcAx7d7xRgTaaN1BWWDaZarRB5efwZxcB6XK2h7bMAx0UszK4mtOAu/FSlqLuWDkdo8I 6wxWXys0Wsa+7uS8dfycoY7/OAIw7X8FldqL2magAjPiQJ/ONKOtn2Wa4BjA+WzvKmkJ xrEw== X-Forwarded-Encrypted: i=1; AKwUvBxox+yQEehQfgh3w2HL+mKpRUIQ1iNBSjaTAg0xuJNPgsivupPC1dpxcpOREIi7dvdY8f5z8cOLLupkd4I=@vger.kernel.org X-Gm-Message-State: AFuF++lbY8lUSDY22DYTEvg3VECTgLeY7T20tvvxypGL5AHrRamaeMIL 6Qu93TjCDncI1Bfz2JbgnxlXOAWbE8GC+BUqH9euaBnBzTS8sQPvnNAc X-Gm-Gg: AYBFou0Sl+1iBJIh1lxfAX/vDpElH1BGR836XAlphv0m/zW9MERSH7gP5yPCyT1OKyl SQTAJJj4pYQQObi5Hk7Vx7LPkbr6Kcx+Yj4zMiZdmfXA4tmSth0Ex6yLFuceQCypzDFP8caD+OY 6yvJu/ZnVFETFdJV961ZXyJp6tKzZF7zkbJg9aOTtLIYap/SsDY1FiXNnwRGSHzlT3wFfVI8vAZ aOzYnMpT18/IiiRAm8LyZht8vZhqz3eiNdqrfMEkoTdpkE8Z9xX9zHsfcPbESZndlWAz+Zu1FA6 R38exSCBzLzm1JcAJj2AiCE0H7moGdW748jf8niz+d12Klq/RLv0eNXHMM4qaJuxWKvnn6U9h3C 4r4IiZoTEkxaIpXWmhIZOTejyW7K8ZHWuJcKpbO5uik6oUPqewbHLPD+GS/IzLLltOk4tX7td2B cUiN1dlFORsnqfhJb4yTH37iRcnt2dNWHGBL8PraDrDAvHOlQ83pQIn+2WugnY86WdvkahgBfSF 4oKb8zxod36ZE7sqZ2UVthptgnzgFpviwMZwsKfjxLwd5klVvT32mfbk7rR04LJyn7UqlOdah5z Y/MdN08uaD3QdBvE X-Received: by 2002:a17:903:32cb:b0:2c9:bf82:dd11 with SMTP id d9443c01a7336-2db1248c3f4mr422794085ad.7.1788929716983; Tue, 08 Sep 2026 21:55:16 -0700 (PDT) Received: from phuc-desktop.. ([183.91.15.56]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-2db1499e876sm66688505ad.56.2026.09.08.21.55.13 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 08 Sep 2026 21:55:16 -0700 (PDT) From: phucduc.bui@gmail.com To: Radhey Shyam Pandey , Andrew Lunn , davem@davemloft.net, Eric Dumazet , Jakub Kicinski , Paolo Abeni , Michal Simek , Simon Horman Cc: netdev@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, bui duc phuc Subject: [PATCH net-next v6 2/3] net: xilinx: axienet: Handle optional IRQ return value correctly Date: Wed, 9 Sep 2026 11:54:49 +0700 Message-ID: <20260909045450.16176-3-phucduc.bui@gmail.com> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20260909045450.16176-1-phucduc.bui@gmail.com> References: <20260909045450.16176-1-phucduc.bui@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" From: bui duc phuc lp->eth_irq is assigned from platform_get_irq_optional(), which returns a non-zero interrupt number on success or a negative error number on failure. Errors other than -ENXIO are handled before this check, so -ENXIO is the only error value that can reach this point. Check for a negative value instead of treating 0 as an undefined IRQ. Reviewed-by: Simon Horman Reviewed-by: Radhey Shyam Pandey Signed-off-by: bui duc phuc --- Changes in v6 :=20 - Add Simon's Reviewed-by: tag. - Drop the Fixes: tag as this patch is intended for net-next. drivers/net/ethernet/xilinx/xilinx_axienet_main.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/ethernet/xilinx/xilinx_axienet_main.c b/drivers/ne= t/ethernet/xilinx/xilinx_axienet_main.c index 207aecb5f8b9..3927ababf833 100644 --- a/drivers/net/ethernet/xilinx/xilinx_axienet_main.c +++ b/drivers/net/ethernet/xilinx/xilinx_axienet_main.c @@ -3052,7 +3052,7 @@ static int axienet_probe(struct platform_device *pdev) ndev->ethtool_ops =3D &axienet_ethtool_ops; } /* Check for Ethernet core IRQ (optional) */ - if (lp->eth_irq <=3D 0) + if (lp->eth_irq < 0) dev_info(&pdev->dev, "Ethernet core IRQ not defined\n"); =20 /* Retrieve the MAC address */ --=20 2.43.0 From nobody Fri Sep 25 20:02:05 2026 Received: from mail-pj2-f12.google.com (mail-pj2-f12.google.com [74.125.227.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id E982C331202 for ; Wed, 9 Sep 2026 04:55:23 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=74.125.227.140 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1788929725; cv=none; b=Rs3Miu7FGbCvfHAdsR3LedOphM7WszWLYbs5+b/UMvwrkmfzobv3yuZtJaI3dnR6D13Jz4sHjHDQy+APlOO8bJJ8HSsu7VmLSEvgpEWf0hGzVcKaGnxvprrAa6Ufz78kROwI3z/fbkD7y6FZVpw9uhYQJCv8JivptVv2j8yr+ls= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1788929725; c=relaxed/simple; bh=UFYz45aWYI+X83+iIz+CMEsv5bGyQep6UXbWxkDJvj4=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=N5zENXJWwFPNRYloVjuR6NBYP7TtoaskEcUkqIx+iaTnln6ESCxlNCP/v5Z9eduzNJ0t6byaOJ2OAwd0g2FFJNUvks9OC8rgw2ghP+MuLPVlplWNpJFoOQY8Lgo9g5XW4J3e90NOto8S5Bo1a/vvV8MoFw3QgtDMW9A441FhmNY= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=SsA0cbvm; arc=none smtp.client-ip=74.125.227.140 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="SsA0cbvm" Received: by mail-pj2-f12.google.com with SMTP id d9443c01a7336-2d747f066d8so5893155ad.1 for ; Tue, 08 Sep 2026 21:55:23 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1788929723; x=1789534523; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to:content-type; bh=A5IgLCU04RRBc+Gwx3mrSW66CKoAgwZR7YrSzPsHUdM=; b=SsA0cbvmcOWwQwxUs4Tenu1awhlG/r64x2O6BaCP5YFwQEkrlszmqlz+4vnIFG5SAj NLX+yTstl5JYmsifB0fSB4DbHdp+vaM788GgdJHQ5+QGZfIgFxlhFWTdNyXpvHF2kkJ1 PWYNGsbsmW8AtMe+jBd7LRyblovaofRvYT8iO5DnJCix8wP5uHnjlSFxYMzX+oLbcamm xHBJAgGXLRqQXxuzDkxBa4h5XR2PFy96pzbz04U15u7/3QjvrI2nQCNsX2oEEmdbd2/i XBZbM9MCUwMxRhbRdKzDXJdsZfplQ+FBXHldEqNKBYh2SnZxCd7EVuPedUOKcCQvFCfx Dzxw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1788929723; x=1789534523; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to:content-type; bh=A5IgLCU04RRBc+Gwx3mrSW66CKoAgwZR7YrSzPsHUdM=; b=A0xrqYYIVBd1BZWRScs+D1OG0YRLuepB7Wy58YkFLkYSDzH/jPCtvQKdXTrcUjqsUJ n3MI0gtbL1Oq6GXeBBIj6yIYk7xmQBFem6YQMLRoDsp4upl1IyOnb88TDDuCX3uAECRo wgyau3NUDVen8hAkpJeXZpwAKVJWAzPeovvYQWR8lDVWzU6oE3QluWyoJlImH82txSE3 Wu/dVe288RoKmCGsHk1b4lsh5JctonF/ax/7PIXExky2zKMFuhGMbkedpKekmac1CNgg ajViLLNqijlHFybHY+PWz8Gu8UuFQGKqmHdEo4MoXB4E3N/T4QqL6nhGUPdGsF63eaij 5UDA== X-Forwarded-Encrypted: i=1; AKwUvBz2FyEvQ+D7qIlC5hmoKLoLqDWtcSIv4nr1anSS7kpPQoal70PMKquNcNorzNMW2D39HQ9bjR6R6chx6GI=@vger.kernel.org X-Gm-Message-State: AFuF++kDjmwt2n/OeUejRW8Kty/UlzMjxvUkIdN4nh4AUwVLgL3MgvgM Ohnl+jkYbGAJ/Ay7++Nl+ArDCAmRcS/OLjKx1EmyyNi8L/K47SWbYCrT X-Gm-Gg: AYBFou0bi3hd2rkoaYB2GLP5P2Bmor4QGTHBG6sq3Gk/faV2RMjhNjJcEXdd5rHUhIw eqlWSnL8G4l8mA+0NPY9J4Lc2FfJ4EIv2PUcFeHL+3LGK2K/ykrRzR4Wg2AnV9/ylGFQ6c+V6MD 1hLDmPRDG0KtBW3y6BUNgaYrruS2ssQZAAEax2DvYbAG4Kg7eAdJHjtPLOmcPPJeBSAz86sT1iQ TmO7ghunPQhSZSnTLJs3Dn1oEAnusCw9Ddm/WOb+G1eXURB6vrRB/rLUEawgVVuE6CgaUL+AsBq TkQS424G7MUgBUXpOinpc9Cmk/hR24kefbn0SbqTa+O/+yiqyFHWscWJFuKQ/RfTtji7W7irKNd 04wCyv8gceLt8FInQ4U/y4K0VPpMxN2BwTmg5ZRMGYii5kNNCN0Ug6pgMKpH2ZWqvzlmOUdYGD+ EkjlFokobScIxOrP57FttwjCZElw+In+jR/0XygzIy8TB7hkjFohrxgohBVo0GDDanpZv/eMijU 7QIHJFP1yKDv5aKrm62/pGVqHoWm/fhL6vjQVnxJ1D8kyzRC/SzYaZO6NRz+QeKYi/t1kOBfcgY +kJVmqXz0XC+5xIbKdnLiD9Cdg== X-Received: by 2002:a17:903:40d1:b0:2ca:12aa:a390 with SMTP id d9443c01a7336-2db6f91506dmr96058075ad.0.1788929723024; Tue, 08 Sep 2026 21:55:23 -0700 (PDT) Received: from phuc-desktop.. ([183.91.15.56]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-2db1499e876sm66688505ad.56.2026.09.08.21.55.18 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 08 Sep 2026 21:55:22 -0700 (PDT) From: phucduc.bui@gmail.com To: Radhey Shyam Pandey , Andrew Lunn , davem@davemloft.net, Eric Dumazet , Jakub Kicinski , Paolo Abeni , Michal Simek , Simon Horman Cc: netdev@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, bui duc phuc Subject: [PATCH net-next v6 3/3] net: xilinx: axienet: Fix IRQ error handling Date: Wed, 9 Sep 2026 11:54:50 +0700 Message-ID: <20260909045450.16176-4-phucduc.bui@gmail.com> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20260909045450.16176-1-phucduc.bui@gmail.com> References: <20260909045450.16176-1-phucduc.bui@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" From: bui duc phuc irq_of_parse_and_map() returns 0 when parsing or mapping an IRQ fails, while platform_get_irq() returns a negative error code on failure. Handle both failure cases appropriately: return -EINVAL when irq_of_parse_and_map() fails, and propagate the original error code returned by platform_get_irq() instead of returning -ENOMEM. Reviewed-by: Simon Horman Signed-off-by: bui duc phuc Reviewed-by: Suraj Gupta --- Changes in v4 :=20 - Add error handling for irq_of_parse_and_map() Changes in v5 :=20 - Change the error code returned when irq_of_parse_and_map() fails=20 from -ENOMEM to -EINVAL. Changes in v6 :=20 - Add Simon's Reviewed-by: tag. - Drop the Fixes: tag as this patch is intended for net-next. drivers/net/ethernet/xilinx/xilinx_axienet_main.c | 8 ++++++-- 1 file changed, 6 insertions(+), 2 deletions(-) diff --git a/drivers/net/ethernet/xilinx/xilinx_axienet_main.c b/drivers/ne= t/ethernet/xilinx/xilinx_axienet_main.c index 3927ababf833..782f903d318f 100644 --- a/drivers/net/ethernet/xilinx/xilinx_axienet_main.c +++ b/drivers/net/ethernet/xilinx/xilinx_axienet_main.c @@ -2971,10 +2971,14 @@ static int axienet_probe(struct platform_device *pd= ev) dev_err(&pdev->dev, "could not map DMA regs\n"); return PTR_ERR(lp->dma_regs); } - if (lp->rx_irq <=3D 0 || lp->tx_irq <=3D 0) { + if (!lp->rx_irq || !lp->tx_irq) { dev_err(&pdev->dev, "could not determine irqs\n"); - return -ENOMEM; + return -EINVAL; } + if (lp->rx_irq < 0) + return lp->rx_irq; + if (lp->tx_irq < 0) + return lp->tx_irq; if (lp->eth_irq < 0 && lp->eth_irq !=3D -ENXIO) return lp->eth_irq; =20 --=20 2.43.0